Update from the Superset X.0 working group

2022-03-31 Thread Aaron Suddjian
Hi folks, the group met today to discuss the ongoing changes for Superset
2.0. Key discussion points are noted below.

- All breaking changes have been merged, this looks good to go! 
- Last task is for John/Srini/Aaron to make sure that all the breaking
changes are described well in UPDATING.md.
- Ville will be cutting the 2.0 release as well as 1.5. (Thank you Ville!)
- Created a ticket in the project
to track the release.

Please feel free to join the next working group meeting on April 7th at
10am PST. The meeting can be found on the Superset Community Calendar.

-- 
Aaron Suddjian, Software Engineer at Preset


Re: Update from the Superset X.0 working group

2022-03-17 Thread Tai Dupree
I think all the react crud view tests are mostly covered by js tests and
api tests, so deleting those would probably be the path forward. Given that
most users run superset with that feature flag enabled, there is little
risk to removing that code.

On Thu, Mar 17, 2022 at 11:01 AM Aaron Suddjian  wrote:

> Hi folks, the group met today to discuss the ongoing changes for Superset
> 2.0. Key discussion points are noted below.
>
> - Aaron: Removing the ENABLE_REACT_CRUD_VIEWS flag causes lots of tests to
> fail - assertions depend on text appearing in crud view html. Will skip
> tests for now, and collab with QA to rewrite them.
> - Daniel: Celery bump forced us to bump quite a few more packages including
> flask, flask-jwt-extended.
>- John: Airbnb hasn’t updated flask internally because of some issues.
> Daniel & John to sync up.
> - Elizabeth: is out next week, can send a rep from team to the meeting
> - Evan: A bug was filed with the sqllab backend persistence feature. Fix
> should go into 2.0 https://github.com/apache/superset/pull/19225
>- Elizabeth: This is a new bug, not technically tied to the flag itself.
> - Grace: Removing omnibar feature as discussed in slack
>
> Please feel free to join the next working group meeting on March 24th at
> 10am PST. The meeting can be found on the Superset Community Calendar.
>
> --
> Aaron Suddjian, Software Engineer at Preset
>


Update from the Superset X.0 working group

2022-03-17 Thread Aaron Suddjian
Hi folks, the group met today to discuss the ongoing changes for Superset
2.0. Key discussion points are noted below.

- Aaron: Removing the ENABLE_REACT_CRUD_VIEWS flag causes lots of tests to
fail - assertions depend on text appearing in crud view html. Will skip
tests for now, and collab with QA to rewrite them.
- Daniel: Celery bump forced us to bump quite a few more packages including
flask, flask-jwt-extended.
   - John: Airbnb hasn’t updated flask internally because of some issues.
Daniel & John to sync up.
- Elizabeth: is out next week, can send a rep from team to the meeting
- Evan: A bug was filed with the sqllab backend persistence feature. Fix
should go into 2.0 https://github.com/apache/superset/pull/19225
   - Elizabeth: This is a new bug, not technically tied to the flag itself.
- Grace: Removing omnibar feature as discussed in slack

Please feel free to join the next working group meeting on March 24th at
10am PST. The meeting can be found on the Superset Community Calendar.

-- 
Aaron Suddjian, Software Engineer at Preset


Update from the Superset X.0 working group

2022-03-10 Thread Aaron Suddjian
Hi folks, the group met today to discuss the ongoing changes for Superset
2.0. Key discussion points are noted below.

- Decided to proceed with flipping the SQL_LAB_BACKEND_PERSISTENCE flag.
- Reminder that all the breaking changes need an appropriate entry in
Updating.md and that they get the appropriate PR labels, as well as a
"conventional commits" exclamation point in the title.
- Allowing two small barely-breaking changes onto the board. Future small
bycatch will be considered, subject to discussion/objection.
- Setting a merge target for March 25th, with the Celery change as the only
hard requirement.
- Will do a sweep of PRs from the board when the release branch is cut. to
make sure that all PRs have UPDATING entries and proper labeling.

Please feel free to join the next working group meeting on March 17th at
10am PST. The meeting can be found on the Superset Community Calendar.

-- 
Aaron Suddjian, Software Engineer at Preset