[GitHub] Chun-LingChen opened a new pull request #4411: use full path in case of there are query params
Chun-LingChen opened a new pull request #4411: use full path in case of there are query params URL: https://github.com/apache/incubator-superset/pull/4411 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables
xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-365168344 HI, all, we have updated lots of screenshots in https://github.com/apache/incubator-superset/pull/4394, please vote for us, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaohanyu commented on issue #4394: Implement the column config and row config in pivot table
xiaohanyu commented on issue #4394: Implement the column config and row config in pivot table URL: https://github.com/apache/incubator-superset/pull/4394#issuecomment-365168066 Hi, @mistercrunch Above is the overall features of this so-called "column and row configuration". Actually, we have used superset for almost one year, and designed this feature from bottom up, improve piece by piece, and finally proposed this patch for community. The basic design is: - should be a purely frontend implementation based on datatables state save and restore - put column configuration and row configurations settings to `formData`, just utilize superset's existing tools to save and restore table state There're maybe some issues though: - store column/row configuration may cause url too long for browsers and backend server, need to adjust existing nginx or some other backend settings to accept long `GET` urls - solution: maybe we should switch from `GET` to `POST` for queries to avoid this kind of long url problem? - frontend performance: when user has complicated settings and big data tables, it really takes some time to render the whole table, need to figure out a way to improve this. We're definitely sure that there're should be some improvements over the UI/UX design, to make it more intuitive, so we propose this to community asking some feedback. This feature is mainly designed for dashboard readers, they may be leaders of the team, just glance over multiple dashboard in minutes, and they need colors to mark the most important metrics in a table for them. That's all, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaohanyu commented on issue #4394: Implement the column config and row config in pivot table
xiaohanyu commented on issue #4394: Implement the column config and row config in pivot table URL: https://github.com/apache/incubator-superset/pull/4394#issuecomment-365166554 ## Priority between column configuration and row configuration: - Column configuration has high priority over row configuration (this is the default option):  - Column configuration has low priority over row configuration:  - A new "Prioritize Row Configuration" in "Pivot Opitions":  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaohanyu commented on issue #4394: Implement the column config and row config in pivot table
xiaohanyu commented on issue #4394: Implement the column config and row config in pivot table URL: https://github.com/apache/incubator-superset/pull/4394#issuecomment-365166059 ## Row configuration: - Set rows's background color to red if content in that row contains specific word:  - Set rows's font to bold if content in that row contains specific word:  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaohanyu commented on issue #4394: Implement the column config and row config in pivot table
xiaohanyu commented on issue #4394: Implement the column config and row config in pivot table URL: https://github.com/apache/incubator-superset/pull/4394#issuecomment-365165514 ## column configuration for font option: - set all cells to bold font by setting a wildcard conditional expression like `> 0`.  - set specific column font to bold:  - set specific cells to bold font in a column:  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaohanyu commented on issue #4394: Implement the column config and row config in pivot table
xiaohanyu commented on issue #4394: Implement the column config and row config in pivot table URL: https://github.com/apache/incubator-superset/pull/4394#issuecomment-365160586 Some test cases ## column configuration: - Set all cell's background color to red (by selecting only the metric)  - Set one column's background color to red (by selecting metric and columns)  - Set all cell's background color to blue and set different color for different columns (first by selecting metric and set background color, then set color for different columns under metrics)  - Text alignment for specific column (by setting text align for metric or column)  - Specific formatting for specific column:  ## column configuration with conditional formatting - Set all cells with value greater than 2 to red color background and bold font:  - Set Set all cells of a specific column with value greater than 2 to yellow color background:  - Together with background settings from above, we can mark cells whose value is greater than 2 with yellow color, while other cells with green color by setting background color for the whole column.  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaohanyu commented on issue #4394: Implement the column config and row config in pivot table
xiaohanyu commented on issue #4394: Implement the column config and row config in pivot table URL: https://github.com/apache/incubator-superset/pull/4394#issuecomment-365160586 Test cases for column configuration: - Set all cell's background color to red (by selecting only the metric)  - Set one column's background color to red (by selecting metric and columns)  - Set all cell's background color to blue and set different color for different columns (first by selecting metric and set background color, then set color for different columns under metrics)  - Text alignment for specific column (by setting text align for metric or column)  - Specific formatting for specific column:  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaohanyu commented on issue #4394: Implement the column config and row config in pivot table
xiaohanyu commented on issue #4394: Implement the column config and row config in pivot table URL: https://github.com/apache/incubator-superset/pull/4394#issuecomment-365160586 Test cases for column configuration: - Set all cell's background color to red (by selecting only the metric)  - Set one column's background color to red (by selecting metric and columns)  - Set all cell's background color to blue and set different color for different columns (first by selecting metric and set background color, then set color for different columns under metrics)  - Text alignment for specific column (by setting text align for metric or column)  - Specific formatting for specific column:  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaohanyu commented on issue #4394: Implement the column config and row config in pivot table
xiaohanyu commented on issue #4394: Implement the column config and row config in pivot table URL: https://github.com/apache/incubator-superset/pull/4394#issuecomment-365160554 Hi, here's the "welcome" page for slice with pivot table viz type, we add two new sections in the left side menu:  Expanding column configuration:  Expanding row configuration:  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaohanyu commented on issue #4394: Implement the column config and row config in pivot table
xiaohanyu commented on issue #4394: Implement the column config and row config in pivot table URL: https://github.com/apache/incubator-superset/pull/4394#issuecomment-365156999 Here's a gif: https://user-images.githubusercontent.com/1164623/35914802-9a8c8442-0c3f-11e8-8806-6639c5a1b77d.gif I'll update a few more pics today. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vnnw closed issue #4397: Weird query generated when using Time Series Line Chart with Group By column
vnnw closed issue #4397: Weird query generated when using Time Series Line Chart with Group By column URL: https://github.com/apache/incubator-superset/issues/4397 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch opened a new pull request #4410: Unset 'series limit' default from 50 to null
mistercrunch opened a new pull request #4410: Unset 'series limit' default from 50 to null URL: https://github.com/apache/incubator-superset/pull/4410 Setting "Series Limit" by default results in a subquery (or 2 phase) which can be suboptimal / unecessary where low cardinality dims are used. closes https://github.com/apache/incubator-superset/issues/4397 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaohanyu commented on issue #4394: Implement the column config and row config in pivot table
xiaohanyu commented on issue #4394: Implement the column config and row config in pivot table URL: https://github.com/apache/incubator-superset/pull/4394#issuecomment-365156999 Here's a gif: https://user-images.githubusercontent.com/1164623/35914802-9a8c8442-0c3f-11e8-8806-6639c5a1b77d.gif I'll update a little more today. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sanoopmm commented on issue #4366: Add filters to dashboard in single slice without filter box view - interactive filters
sanoopmm commented on issue #4366: Add filters to dashboard in single slice without filter box view - interactive filters URL: https://github.com/apache/incubator-superset/issues/4366#issuecomment-365155863 I need to add filter drop downs in the existing visualizations like table view, bar chart, pie chart etc. Now it is possible only through an additional slice that is filter box. Also I need to get these filter drop downs from different tables and databases. I mean that I want to use multiple tables from different databases in a single slice. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4397: Weird query generated when using Time Series Line Chart with Group By column
mistercrunch commented on issue #4397: Weird query generated when using Time Series Line Chart with Group By column URL: https://github.com/apache/incubator-superset/issues/4397#issuecomment-365155670 It is the expected query if you want to get the time series for the top N dimension members. I agree the default should be to not apply this This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4394: Implement the column config and row config in pivot table
mistercrunch commented on issue #4394: Implement the column config and row config in pivot table URL: https://github.com/apache/incubator-superset/pull/4394#issuecomment-365154867 Oh neat! Can we get a few screenshots to get an idea of how this looks? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4384: Fix the bug of chord diagram shows incorrect flow from target to source
mistercrunch commented on issue #4384: Fix the bug of chord diagram shows incorrect flow from target to source URL: https://github.com/apache/incubator-superset/pull/4384#issuecomment-365154074 I think it's ok to flip the chart metadata along with flipping the behavior. The chart should just stay the same, and the logic aligned. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4401: [SqlLab] Fix a few height related UI issues
mistercrunch commented on issue #4401: [SqlLab] Fix a few height related UI issues URL: https://github.com/apache/incubator-superset/pull/4401#issuecomment-365153837 ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #4404: Fix ImportError when using BigQuery in SQL Editor
mistercrunch closed pull request #4404: Fix ImportError when using BigQuery in SQL Editor URL: https://github.com/apache/incubator-superset/pull/4404 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/superset/db_engine_specs.py b/superset/db_engine_specs.py index b961c03152..f0e7c67620 100644 --- a/superset/db_engine_specs.py +++ b/superset/db_engine_specs.py @@ -1200,8 +1200,7 @@ def convert_dttm(cls, target_type, dttm): @classmethod def fetch_data(cls, cursor, limit): data = super(BQEngineSpec, cls).fetch_data(cursor, limit) -from google.cloud.bigquery._helpers import Row # pylint: disable=import-error -if len(data) != 0 and isinstance(data[0], Row): +if len(data) != 0 and type(data[0]).__name__ == 'Row': data = [r.values() for r in data] return data This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] goldymanikoth commented on issue #4393: Bypassing the login for Supreset using iframe
goldymanikoth commented on issue #4393: Bypassing the login for Supreset using iframe URL: https://github.com/apache/incubator-superset/issues/4393#issuecomment-365149514 got it, I will do that. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4405: Disable user access request
mistercrunch commented on issue #4405: Disable user access request URL: https://github.com/apache/incubator-superset/pull/4405#issuecomment-365147909 Let's flip it off by default. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4393: Bypassing the login for Supreset using iframe
mistercrunch commented on issue #4393: Bypassing the login for Supreset using iframe URL: https://github.com/apache/incubator-superset/issues/4393#issuecomment-365147723 You probably want to avoid changing `superset/config.py` (which means you're modifying the Superset package) and use `superset_config.py` which is intended to be the way to override the defaults in the configuration. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on a change in pull request #4409: Add permissions decider for delegating access controls.
mistercrunch commented on a change in pull request #4409: Add permissions
decider for delegating access controls.
URL:
https://github.com/apache/incubator-superset/pull/4409#discussion_r167758341
##
File path: superset/viz.py
##
@@ -307,7 +307,12 @@ def get_df_payload(self, query_obj=None):
cached_dttm = datetime.utcnow().isoformat().split('.')[0]
if cache_key and cache and not self.force:
cache_value = cache.get(cache_key)
-if cache_value:
+perms_decider = config.get('DATA_PERMS_DECIDER')
+perms_decider_disapproves = (
Review comment:
`viz.py` doesn't currently handle authorization, I'd rather avoid scattering
the auth logic further across modules. Seems like ideally we'd have most
security-related logic in `security.py` and have `views/base.py` wrap that up.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mistercrunch commented on a change in pull request #4409: Add permissions decider for delegating access controls.
mistercrunch commented on a change in pull request #4409: Add permissions decider for delegating access controls. URL: https://github.com/apache/incubator-superset/pull/4409#discussion_r167757524 ## File path: superset/config.py ## @@ -364,6 +364,24 @@ class CeleryConfig(object): # Interval between consecutive polls when using Hive Engine HIVE_POLL_INTERVAL = 5 + +# System to handle delegated data access. Implement both is_allowed_access() and +# is_eligible_datasource() to delegate access controls. +class PermsDecider: Review comment: Shouldn't that be a static class (not meant to be instantiated)? Also note that in py2 it's always preferable to derive `object` as in `class PermsDecider(object):`. Also this base class should probably be declared outside of `config.py` (maybe security.py)? What about simplifying the interface with a simple `has_datasource_access(user, datasource)` callable that only applies if it's defined? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] goldymanikoth commented on issue #4393: Bypassing the login for Supreset using iframe
goldymanikoth commented on issue #4393: Bypassing the login for Supreset using iframe URL: https://github.com/apache/incubator-superset/issues/4393#issuecomment-365143549 I got some reference to locate the superset install path and I figure out the location and updated the superset/config.py and edited the "PUBLIC_ROLE_LIKE_GAMMA = True" and add the data sources to the role manually to bypass the user login, it is working now , thanks for the support. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] fabianmenges commented on issue #4409: Add permissions decider for delegating access controls.
fabianmenges commented on issue #4409: Add permissions decider for delegating access controls. URL: https://github.com/apache/incubator-superset/pull/4409#issuecomment-365108884 @jeffreythewang @GeorgeSirois FYI This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa opened a new pull request #4409: Add permissions decider for delegating access controls.
timifasubaa opened a new pull request #4409: Add permissions decider for delegating access controls. URL: https://github.com/apache/incubator-superset/pull/4409 This PR creates the perms_decider object in the config which gives different deployments the ability to delegate data access control with the `is_eligible_datasource()` which decides if the perms_decider can handle access decisions for a datasource and `is_allowed_access()` which decides if the user has access. I also added in a case where we consult the perms decider before loading from the cache. With the default options, the flow doesn't change since is_eligible_datasource returns False. @fabianmenges @john-bodley @mistercrunch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on issue #4405: Disable user access request
timifasubaa commented on issue #4405: Disable user access request URL: https://github.com/apache/incubator-superset/pull/4405#issuecomment-365092528 @mistercrunch Done. I left the access requests on by default. Is it better off by default? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on issue #4405: Disable user access request
timifasubaa commented on issue #4405: Disable user access request URL: https://github.com/apache/incubator-superset/pull/4405#issuecomment-365092528 @mistercrunch Done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4407: Error on SQL execution: "Could not broadcast input array from shape (26896) into shape (1,164)"
mistercrunch commented on issue #4407: Error on SQL execution: "Could not broadcast input array from shape (26896) into shape (1,164)" URL: https://github.com/apache/incubator-superset/issues/4407#issuecomment-365091430 Which database engine are you querying here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #2436: Slow query in SQL Lab
mistercrunch commented on issue #2436: Slow query in SQL Lab URL: https://github.com/apache/incubator-superset/issues/2436#issuecomment-365090962 @THDA are sounds like you're looking at the Table component in the "explore view" (not in SQL Lab). For the "explore view" we should use `react-virtualized` (as in SQL Lab). About SQL Lab, there are a few reasons why a CLI will beat Superset. In non-async mode, the CLI may run a `fetchmany` as opposed to `fetchall` and can start showing rows before the query is done executing. In async mode, there are much more things going on. The whole query gets executed, returned, cached in the results backend, and only then, once the client polls sees that the data is ready, the server will fetch the data from the results backend and return it to the client. Those delay become worse as the size of the dataset grows. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4393: Bypassing the login for Supreset using iframe
mistercrunch commented on issue #4393: Bypassing the login for Supreset using iframe URL: https://github.com/apache/incubator-superset/issues/4393#issuecomment-365087037 `pip/setuptools/python` manages your pypi packages, no need to worry about that. `superset_config.py` can live anywhere, but you need to `export PYTHONPATH=/wherever/your/superset_config/lives`. As you fire up the `superset` command, you should see something like: `Loaded your LOCAL configuration at [/wherever/your/superset_config/lives/superset_config.pyc]` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4398: database_access on [mydb] permissionview not created when database added
mistercrunch commented on issue #4398: database_access on [mydb] permissionview not created when database added URL: https://github.com/apache/incubator-superset/issues/4398#issuecomment-365085614 @andrewsali thank you for digging in, please open a PR! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4374: Very big visualizations' thumbnails size
mistercrunch commented on issue #4374: Very big visualizations' thumbnails size URL: https://github.com/apache/incubator-superset/issues/4374#issuecomment-365084856 I'd like to keep the larger files in the repo if not in the python package. Look at the `MANIFEST.in` to removed them from the package. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa opened a new pull request #4408: Add link on how to get permission.
timifasubaa opened a new pull request #4408: Add link on how to get permission. URL: https://github.com/apache/incubator-superset/pull/4408 With the access requests feature removed, this PR creates a way for users to be shown how to gain access to datasources. @john-bodley @mistercrunch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4405: Disable user access request
mistercrunch commented on issue #4405: Disable user access request URL: https://github.com/apache/incubator-superset/pull/4405#issuecomment-365075267 You may want to disable the ModelView as well This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tsuki commented on issue #1231: Support for emailing reports at regular intervals?
Tsuki commented on issue #1231: Support for emailing reports at regular intervals? URL: https://github.com/apache/incubator-superset/issues/1231#issuecomment-365047325 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #4380: [error handling] 'Time Comparison' query returns no data
mistercrunch closed pull request #4380: [error handling] 'Time Comparison'
query returns no data
URL: https://github.com/apache/incubator-superset/pull/4380
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/viz.py b/superset/viz.py
index d66884a3b6..d9addda5f0 100644
--- a/superset/viz.py
+++ b/superset/viz.py
@@ -1127,10 +1127,11 @@ def run_extra_queries(self):
query_object['to_dttm'] -= delta
df2 = self.get_df_payload(query_object).get('df')
-df2[DTTM_ALIAS] += delta
-df2 = self.process_data(df2)
-self.extra_chart_data = self.to_series(
-df2, classed='superset', title_suffix='---')
+if df2 is not None:
+df2[DTTM_ALIAS] += delta
+df2 = self.process_data(df2)
+self.extra_chart_data = self.to_series(
+df2, classed='superset', title_suffix='---')
def get_data(self, df):
df = self.process_data(df)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] maver1ck commented on issue #4374: Very big visualizations' thumbnails size
maver1ck commented on issue #4374: Very big visualizations' thumbnails size URL: https://github.com/apache/incubator-superset/issues/4374#issuecomment-365012342 ping @mistercrunch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] andrewsali commented on issue #4398: database_access on [mydb] permissionview not created when database added
andrewsali commented on issue #4398: database_access on [mydb] permissionview not created when database added URL: https://github.com/apache/incubator-superset/issues/4398#issuecomment-364984407 The following resolves this issue: https://github.com/andrewsali/incubator-superset/commit/00e9820934e47dc1c67f53aa1facf5bab976ecb0 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] romankierzkowski opened a new issue #4407: Error on SQL execution: "Could not broadcast input array from shape (26896) into shape (1,164)"
romankierzkowski opened a new issue #4407: Error on SQL execution: "Could not broadcast input array from shape (26896) into shape (1,164)" URL: https://github.com/apache/incubator-superset/issues/4407 Make sure these boxes are checked before submitting your issue - thank you! - [x ] I have checked the superset logs for python stacktraces and included it here as text if any - [x ] I have reproduced the issue with at least the latest released version of superset - [x ] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version superset (0.22.1) ### Expected results The query should return the left joined two tables grouped by id of the first table and max value of created column of the second table. ### Actual results The "Could not broadcast input array from shape (26896) into shape (1,164)" is displayed. Full stack from logs: 2018-02-12 12:29:31,553:ERROR:root:could not broadcast input array from shape (26896) into shape (1,164) Traceback (most recent call last): File "/home/superset/superset-vevn/lib/python3.5/site-packages/superset/views/core.py", line 2188, in sql_json query_id=query_id, return_results=True) File "/home/superset/superset-vevn/lib/python3.5/site-packages/celery/local.py", line 191, in __call__ return self._get_current_object()(*a, **kw) File "/home/superset/superset-vevn/lib/python3.5/site-packages/celery/app/task.py", line 380, in __call__ return self.run(*args, **kwargs) File "/home/superset/superset-vevn/lib/python3.5/site-packages/superset/sql_lab.py", line 94, in get_sql_results ctask, query_id, return_results, store_results, user_name) File "/home/superset/superset-vevn/lib/python3.5/site-packages/superset/sql_lab.py", line 245, in execute_sql 'data': cdf.data if cdf.data else [], File "/home/superset/superset-vevn/lib/python3.5/site-packages/superset/dataframe.py", line 55, in data for row in self.__df.values] File "/home/superset/superset-vevn/lib/python3.5/site-packages/pandas/core/generic.py", line 3272, in values return self.as_matrix() File "/home/superset/superset-vevn/lib/python3.5/site-packages/pandas/core/generic.py", line 3253, in as_matrix return self._data.as_matrix(columns).T File "/home/superset/superset-vevn/lib/python3.5/site-packages/pandas/core/internals.py", line 3450, in as_matrix return mgr._interleave() File "/home/superset/superset-vevn/lib/python3.5/site-packages/pandas/core/internals.py", line 3477, in _interleave result[rl.indexer] = blk.get_values(dtype) ValueError: could not broadcast input array from shape (26896) into shape (1,164) ### Steps to reproduce Run query: SELECT a.id, max(b.created) FROM a LEFT JOIN b ON b.owner_id = a.id GROUP BY a.id Without a.id in the result, the query executes giving the odd results. It returns much more results than it should. Execution in psql works fine as well. SELECT MAX(b.created) FROM b GROUP BY b.owner_id My environment: alembic==0.9.7 amqp==2.2.2 asn1crypto==0.24.0 Babel==2.5.3 billiard==3.5.0.3 boto3==1.5.26 botocore==1.8.40 celery==4.1.0 certifi==2018.1.18 cffi==1.11.4 chardet==3.0.4 click==6.7 colorama==0.3.9 cryptography==1.9 defusedxml==0.5.0 docutils==0.14 Flask==0.12.2 Flask-AppBuilder==1.9.4 Flask-Babel==0.11.1 Flask-Cache==0.13.1 Flask-Login==0.2.11 Flask-Migrate==2.0.3 Flask-OpenID==1.2.5 Flask-Script==2.0.5 Flask-SQLAlchemy==2.1 Flask-Testing==0.6.2 Flask-WTF==0.14.2 flower==0.9.1 future==0.16.0 gevent==1.2.2 greenlet==0.4.13 gunicorn==19.7.1 humanize==0.5.1 idna==2.5 itsdangerous==0.24 Jinja2==2.10 jmespath==0.9.3 kombu==4.1.0 Mako==1.0.7 Markdown==2.6.8 MarkupSafe==1.0 numpy==1.14.0 pandas==0.20.3 parsedatetime==2.0 pathlib2==2.3.0 pkg-resources==0.0.0 psycopg2==2.7.4 pycparser==2.18 pydruid==0.3.1 PyHive==0.5.0 python-dateutil==2.6.0 python-editor==1.0.3 python3-openid==3.1.0 pytz==2018.3 PyYAML==3.12 requests==2.17.3 s3transfer==0.1.12 sasl==0.2.1 simplejson==3.10.0 six==1.10.0 SQLAlchemy==1.1.9 SQLAlchemy-Utils==0.32.16 sqlparse==0.2.3 superset==0.22.1 thrift==0.11.0 thrift-sasl==0.3.0 tornado==4.2 Unidecode==1.0.22 urllib3==1.21.1 vine==1.1.4 Werkzeug==0.14.1 WTForms==2.1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] daphne-jr commented on issue #4403: Test case not passing when callbacks are used in DateFilterControl_spec.jsx + a repeated test case
daphne-jr commented on issue #4403: Test case not passing when callbacks are
used in DateFilterControl_spec.jsx + a repeated test case
URL:
https://github.com/apache/incubator-superset/issues/4403#issuecomment-364896693
After trying for some time today, this is my crude solution. Hope it helps
someone and perhaps someone else would have a better solution.
```
import React from 'react';
import sinon from 'sinon';
import { expect } from 'chai';
import { describe, it, beforeEach } from 'mocha';
import { mount } from 'enzyme';
import DateFilterControl from
'../../../../javascripts/explore/components/controls/DateFilterControl';
import ControlHeader from
'../../../../javascripts/explore/components/ControlHeader';
const defaultProps = {
animation: false,
name: 'date',
onChange: sinon.spy(),
value: '90 days ago',
label: 'date',
};
describe('DateFilterControl', () => {
let wrapper;
beforeEach(() => {
wrapper = mount();
});
afterEach(() => {
wrapper.unmount();
})
it('renders a ControlHeader', () => {
const controlHeader = wrapper.find(ControlHeader);
expect(controlHeader).to.have.lengthOf(1);
});
it('renders 3 Buttons', () => {
const label = wrapper.find(OverlayTrigger).first();
label.simulate('click');
expect(document.getElementsByTagName("Button").length).to.be.equal(3);
});
it('loads the right state', () => {
const label = wrapper.find('.label').first();
label.simulate('click');
expect(wrapper.state().num).to.equal('90');
});
it('renders 2 dimmed sections', () => {
const label = wrapper.find('.label').first();
expect(document.getElementsByClassName('PopoverSection
dimmed').length).to.be.equal(0);
label.simulate('click');
expect(document.getElementsByClassName('PopoverSection
dimmed').length).to.be.equal(2);
});
it('opens and closes', (done) => {
const label = wrapper.find('.label').first();
label.simulate('click');
expect(document.getElementsByClassName('popover').length).to.be.equal(1);
document.getElementsByClassName('ok')[0].click();
setTimeout(() => {
expect(document.getElementsByClassName('popover').length).to.be.equal(0);
done();
}, 10);
});
});
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] pastarace commented on issue #2123: How to daemonize superset process
pastarace commented on issue #2123: How to daemonize superset process URL: https://github.com/apache/incubator-superset/issues/2123#issuecomment-364893687 Hi running the script from @fuzaro I'm getting `/bin/sh: 1: gunicorn: not found` message, that's due to the virtualenv is not active, I guess.. Any clue on how to solve? Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] THDA commented on issue #2436: Slow query in SQL Lab
THDA commented on issue #2436: Slow query in SQL Lab URL: https://github.com/apache/incubator-superset/issues/2436#issuecomment-364883611 Confirmed here, this is dead slow and needs fixing, it even triggers a "this site does not respond" on ie. Turning on profiling, I see the following top offenders (displaying 3K rows here): Function | Count | Inclusive time | Exclusive time ---|--|| appendChild|33?428|10?121,00|10?112,00 removeChild|9?973|7?047,00|6?749,00 innerHTML|57?173|5?857,00|5?856,00 getClientRects|247|3?467,00|3?467,00 n|6?342|1?650,00|1?071,00 There is definitely a need for server side pagination when supported by the underlying engine. Another way would be to postpone more things, for example only run those append/remove when the user clicks on the "next" button. Looks like this is done in superset/assets/visualizations/table.js. Digging through datatables.net-bs's API, I'll see if I can help This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] THDA commented on issue #2436: Slow query in SQL Lab
THDA commented on issue #2436: Slow query in SQL Lab URL: https://github.com/apache/incubator-superset/issues/2436#issuecomment-364883611 Confirmed here, this is dead slow and needs fixing, it even triggers a "this site does not respond" on ie. Turning on profiling, I see the following top offenders (displaying 3K rows here): Function | Count | Inclusive time | Exclusive time ---|--|| appendChild|33?428|10?121,00|10?112,00 removeChild|9?973|7?047,00|6?749,00 innerHTML|57?173|5?857,00|5?856,00 getClientRects|247|3?467,00|3?467,00 n|6?342|1?650,00|1?071,00 There is definitely a need for server side pagination when supported by the underlying engine. Another way would be to postpone more things, for example only run those append/remove when the user clicks on the "next" button. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
