[GitHub] SpyderRivera commented on issue #4740: Add extraction function support for Druid queries
SpyderRivera commented on issue #4740: Add extraction function support for
Druid queries
URL:
https://github.com/apache/incubator-superset/pull/4740#issuecomment-386110982
The filtering works when an extractionFn is added to the dimension spec of
the lookup, but then the look up doesn't work as a column.
```{
"dimension": "country",
"outputName": "country_group",
"outputType": "STRING",
"retainMissingValue": true,
"type": "selector",
"extractionFn": {
"type": "lookup",
"lookup": {
"map": {
"Algeria": "EMEA",
"Faroe Islands": "EMEA",
"Luxembourg": "EMEA",
"Andorra": "EMEA",
"Cameroon": "EMEA",
"Burkina Faso": "EMEA",
"Benin": "EMEA",
"Bahrain": "EMEA",
"Aland Islands": "EMEA",
"Australia": "AU/NZ",
"Iceland": "EMEA",
"Cape Verde": "EMEA",
"Germany": "EMEA",
"Bosnia and Herzegovina": "EMEA",
"Belgium": "EMEA",
"Netherlands": "EMEA",
"Central African Republic": "EMEA",
"Belarus": "EMEA",
"Albania": "EMEA",
"Switzerland": "EMEA",
"New Zealand": "AU/NZ",
"Bulgaria": "EMEA",
"Greenland": "EMEA",
"Angola": "EMEA",
"Chad": "EMEA",
"Svalbard and Jan Mayen": "EMEA",
"Comoros": "EMEA",
"Austria": "EMEA",
"Burundi": "EMEA",
"Botswana": "EMEA"
},
"type": "map",
"isOneToOne": false
}
}
}
```
VS
```
{
"type": "lookup",
"dimension": "country",
"outputName": "country_group",
"outputType": "STRING",
"retainMissingValue": true,
"lookup": {
"type": "map",
"map": {
"Australia": "AU/NZ",
"New Zealand": "AU/NZ",
"Aland Islands": "EMEA",
"Belgium": "EMEA",
"Faroe Islands": "EMEA",
"Greenland": "EMEA",
"Iceland": "EMEA",
"Luxembourg": "EMEA",
"Netherlands": "EMEA",
"Svalbard and Jan Mayen": "EMEA",
"Austria": "EMEA",
"Germany": "EMEA",
"Switzerland": "EMEA",
"Albania": "EMEA",
"ALgeria": "EMEA",
"Andorra": "EMEA",
"Angola": "EMEA",
"Bahrain": "EMEA",
"Belarus": "EMEA",
"Benin": "EMEA",
"Bosnia and Herzegovina": "EMEA",
"Botswana": "EMEA",
"Bulgaria": "EMEA",
"Burkina Faso": "EMEA",
"Burundi": "EMEA",
"Cameroon": "EMEA",
"Cape Verde": "EMEA",
"Central African Republic": "EMEA",
"Chad": "EMEA",
"Comoros": "EMEA"
},
"isOneToOne": false
}
}
```
Here you can see the filter works, but the column values for country group
are not populating.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] jeffreythewang commented on issue #4740: Add extraction function support for Druid queries
jeffreythewang commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-386061964 My bad, I thought you were attaching `extractionFn`s to `DimensionSpec`s as well like in [this](http://druid.io/docs/latest/querying/dimensionspecs.html#extraction-functions) way, but I realized you are building the `Filter`s from `DimensionSpec`s that already have `extractionFn`s defined. I assume you have users (or someone else) define their own `extractionFn`s in the datasource configuration? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jeffreythewang commented on issue #4740: Add extraction function support for Druid queries
jeffreythewang commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-386061964 My bad, I thought you were attaching `extractionFn`s to `DimensionSpec`s as well like in [this](http://druid.io/docs/latest/querying/dimensionspecs.html#extraction-functions) way, but it seems like you are building the `Filter`s from `DimensionSpec`s that already have `extractionFn`s defined. I assume you have users (or someone else) define their own `extractionFn`s in the datasource configuration? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jasnovak commented on issue #4740: Add extraction function support for Druid queries
jasnovak commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-386051860 Hmm, I'm not sure where you are suggesting using DimensionSpec in this PR. Or are you asking that about the code in general? As far as the filters that this PR is creating, as I note in the code, I couldn't use the Dimension or Bound classes as they don't support extraction functions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] villebro commented on issue #4920: form_data always returns empty dict
villebro commented on issue #4920: form_data always returns empty dict URL: https://github.com/apache/incubator-superset/issues/4920#issuecomment-386039997 Yeah, a big setback, and a feature we'd really need. I'll look into building the opt-in feature described in #4260 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] guillaumewibaux commented on issue #4920: form_data always returns empty dict
guillaumewibaux commented on issue #4920: form_data always returns empty dict URL: https://github.com/apache/incubator-superset/issues/4920#issuecomment-386038400 Damn... thanks for pointing that out though. Any suggestions/ideas how to mitigate that ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4921: [bufix] filtered column was removed
codecov-io commented on issue #4921: [bufix] filtered column was removed URL: https://github.com/apache/incubator-superset/pull/4921#issuecomment-386036637 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4921?src=pr=h1) Report > Merging [#4921](https://codecov.io/gh/apache/incubator-superset/pull/4921?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fa4acb1bda9ee2be4bd3fa110f25b799e719696c?src=pr=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4921?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4921 +/- ## === Coverage 77.12% 77.12% === Files 44 44 Lines8539 8539 === Hits 6586 6586 Misses 1953 1953 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4921?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4921/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `79.9% <100%> (ø)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4921/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `76.32% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4921?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4921?src=pr=footer). Last update [fa4acb1...6b9b729](https://codecov.io/gh/apache/incubator-superset/pull/4921?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4921: [bufix] filtered column was removed
codecov-io commented on issue #4921: [bufix] filtered column was removed URL: https://github.com/apache/incubator-superset/pull/4921#issuecomment-386036637 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4921?src=pr=h1) Report > Merging [#4921](https://codecov.io/gh/apache/incubator-superset/pull/4921?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fa4acb1bda9ee2be4bd3fa110f25b799e719696c?src=pr=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4921?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4921 +/- ## === Coverage 77.12% 77.12% === Files 44 44 Lines8539 8539 === Hits 6586 6586 Misses 1953 1953 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4921?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4921/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `76.32% <100%> (ø)` | :arrow_up: | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4921/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `79.9% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4921?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4921?src=pr=footer). Last update [fa4acb1...6b9b729](https://codecov.io/gh/apache/incubator-superset/pull/4921?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch opened a new pull request #4921: [bufix] filtered column was removed
mistercrunch opened a new pull request #4921: [bufix] filtered column was removed URL: https://github.com/apache/incubator-superset/pull/4921 https://user-images.githubusercontent.com/487433/39535063-d7d86d22-4de7-11e8-965b-41ae316116d9.png;> if a filter is created on a chart, and the column is removed from the dataset, you get a "NoneType object has no attribute is_num" or something to that effect. This fix disregards the filter. Also error messages were HTML escaped which React does already anyways so that's not necessary [anymore] here. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] villebro commented on issue #4920: form_data always returns empty dict
villebro commented on issue #4920: form_data always returns empty dict URL: https://github.com/apache/incubator-superset/issues/4920#issuecomment-386006567 I found this, apparently form_data has been deprecated: #4260 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] grafke commented on issue #4666: Sessions still active on Datasource
grafke commented on issue #4666: Sessions still active on Datasource URL: https://github.com/apache/incubator-superset/issues/4666#issuecomment-385967561 Hi, We're using superset 0.24.0 and the issue is still there. Every time I run a query on the SQL lab, a new connection is made to the DB server (we're using postgres), and at the end of the day, we end up with hundreds of db connections, all are idle of course. Previous Superset versions did not have this issue. I wonder if there's a permanent fix coming up or perhaps we should rely on workarounds for now? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhunwicks commented on issue #3973: uglifyjs-webpack-plugin@^0.4.6 and uglifyjs-webpack-plugin@^1.1.0 both in use
rhunwicks commented on issue #3973: uglifyjs-webpack-plugin@^0.4.6 and
uglifyjs-webpack-plugin@^1.1.0 both in use
URL:
https://github.com/apache/incubator-superset/issues/3973#issuecomment-385961205
Our attempt to build the JavaScript assets is failing with:
```
ERROR in dashboard.e12007b38f5d226a9398.entry.js from UglifyJs
Unexpected token: keyword (const)
[dashboard.e12007b38f5d226a9398.entry.js:250449,7]
ERROR in explore.b068173a7061b4b69f89.entry.js from UglifyJs
Unexpected token: keyword (const)
[explore.b068173a7061b4b69f89.entry.js:250450,7]
```
https://stackoverflow.com/questions/42375468/uglify-syntaxerror-unexpected-token-punc/46294198#46294198
explains that the installed `"uglifyjs-webpack-plugin": "^1.1.0",` from
`package.json` won't get used.
We solved the problem by removing the embedded Webpack version prior to
running the build:
```
rm -rf ./node_modules/webpack/node_modules/uglifyjs-webpack-plugin
npm run prod
```
Once the desired `"uglifyjs-webpack-plugin": "^1.1.0",` was being used we
had to update the `webpack.config.js` to match the config requirements for the
later package:
```javascript
const UglifyJsPlugin = require('uglifyjs-webpack-plugin')
if (process.env.NODE_ENV === 'production') {
// Using settings suggested in
https://github.com/webpack/webpack/issues/537
const UJSplugin = new UglifyJsPlugin({
uglifyOptions: {
ecma: 8,
compress: {
warnings: false
},
},
sourceMap: true,
parallel: 4
});
config.plugins.push(UJSplugin);
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] diethardsteiner commented on issue #4870: Building openssl fails while installing superset on Ubuntu 16.04
diethardsteiner commented on issue #4870: Building openssl fails while installing superset on Ubuntu 16.04 URL: https://github.com/apache/incubator-superset/issues/4870#issuecomment-385936086 Here we go: ``` $ dpkg -l openssl* libssl* dpkg-query: no packages found matching openssl* dpkg-query: no packages found matching libssl* ``` Ok, let's try this: ``` $ dnf list openssl* libssl* Installed Packages openssl.x86_641:1.1.0h-1.fc27 @updates openssl-devel.x86_64 1:1.1.0h-1.fc27 @updates openssl-libs.x86_64 1:1.1.0h-1.fc27 @updates ``` Please let me know if you need any other info. I am running this on Fedora 27. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #4870: Building openssl fails while installing superset on Ubuntu 16.04
xrmx commented on issue #4870: Building openssl fails while installing superset on Ubuntu 16.04 URL: https://github.com/apache/incubator-superset/issues/4870#issuecomment-385932801 Could you please provide the output of "dpkg -l openssl* libssl*" ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] diethardsteiner commented on issue #4870: Building openssl fails while installing superset on Ubuntu 16.04
diethardsteiner commented on issue #4870: Building openssl fails while installing superset on Ubuntu 16.04 URL: https://github.com/apache/incubator-superset/issues/4870#issuecomment-385932225 I am encountering the same problem. Any solution? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] guillaumewibaux commented on issue #4920: form_data always returns empty dict
guillaumewibaux commented on issue #4920: form_data always returns empty dict URL: https://github.com/apache/incubator-superset/issues/4920#issuecomment-385914429 Same issue for me: https://github.com/apache/incubator-superset/issues/1996 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] claycrosby commented on issue #4366: Add filters to dashboard in single slice without filter box view - interactive filters
claycrosby commented on issue #4366: Add filters to dashboard in single slice without filter box view - interactive filters URL: https://github.com/apache/incubator-superset/issues/4366#issuecomment-385911928 Is there a design document that explains this feature in more detail? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peter-stuart-turner commented on a change in pull request #4871: Add spider/radar chart
peter-stuart-turner commented on a change in pull request #4871: Add
spider/radar chart
URL:
https://github.com/apache/incubator-superset/pull/4871#discussion_r185432767
##
File path: superset/viz.py
##
@@ -2375,6 +2375,35 @@ def get_data(self, df):
return result
+class SpiderRadarViz(BaseViz):
+"""
+A spider / radar chart.
+"""
+
+viz_type = 'spider_radar'
+verbose_name = _('Spider Radar Diagram')
+credits = (
+'https://www.visualcinnamon.com/>Nadieh Bremer, Data Viz
Expert')
+is_timeseries = False
+
+def get_data(self, df):
Review comment:
Also, is this what you meant? I mean, adding a test here. I can't seem to
find where to put tests for the javascript code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] peter-stuart-turner commented on a change in pull request #4871: Add spider/radar chart
peter-stuart-turner commented on a change in pull request #4871: Add
spider/radar chart
URL:
https://github.com/apache/incubator-superset/pull/4871#discussion_r185432004
##
File path: superset/viz.py
##
@@ -2375,6 +2375,35 @@ def get_data(self, df):
return result
+class SpiderRadarViz(BaseViz):
+"""
+A spider / radar chart.
+"""
+
+viz_type = 'spider_radar'
+verbose_name = _('Spider Radar Diagram')
+credits = (
+'https://www.visualcinnamon.com/>Nadieh Bremer, Data Viz
Expert')
+is_timeseries = False
+
+def get_data(self, df):
Review comment:
Any chance I can get some help writing this unit test? I'm struggling to get
it to run with tox - tox keeps failing in installing the dependencies. I'm
runnning:
tox -e pylint -- tests/viz_tests.py
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] peter-stuart-turner commented on a change in pull request #4871: Add spider/radar chart
peter-stuart-turner commented on a change in pull request #4871: Add
spider/radar chart
URL:
https://github.com/apache/incubator-superset/pull/4871#discussion_r185430056
##
File path: superset/viz.py
##
@@ -2375,6 +2375,35 @@ def get_data(self, df):
return result
+class SpiderRadarViz(BaseViz):
+"""
+A spider / radar chart.
+"""
+
+viz_type = 'spider_radar'
+verbose_name = _('Spider Radar Diagram')
+credits = (
+'https://www.visualcinnamon.com/>Nadieh Bremer, Data Viz
Expert')
+is_timeseries = False
+
+def get_data(self, df):
+fd = self.form_data
+
+metrics = fd.get('metrics')
+groupby = fd.get('groupby')
+
+axisMap = groupby[0]
+valueMap = metrics[0].get('label')
+
+created_data = []
+for index, row in df.iterrows():
+created_data.append({'axis': row[axisMap], 'value': row[valueMap]})
+data = [created_data]
Review comment:
To make room for later functionality of having multiple 'scenarios' pitted
against one another:
var data = [
[//iPhone
{axis:"Battery
Life",value:0.22},
{axis:"Brand",value:0.28},
],[//Samsung
{axis:"Battery
Life",value:0.27},
{axis:"Brand",value:0.16},
],[//Nokia Smartphone
{axis:"Battery
Life",value:0.26},
{axis:"Brand",value:0.10},
]
];
Example over here:
https://www.visualcinnamon.com/2015/10/different-look-d3-radar-chart.html
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] kuriancheeramelil commented on issue #4915: Exploring BQ table throws query error as date is incorrectly formatted
kuriancheeramelil commented on issue #4915: Exploring BQ table throws query error as date is incorrectly formatted URL: https://github.com/apache/incubator-superset/issues/4915#issuecomment-385903678 Thank you @mistercrunch. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] guillaumewibaux commented on issue #1996: Custom SQL queries with filters
guillaumewibaux commented on issue #1996: Custom SQL queries with filters
URL:
https://github.com/apache/incubator-superset/issues/1996#issuecomment-385898140
I tried to access "time_grain_sqla" (or any other key) in _form_data_ dict
in Explore but I am afraid that it is empty.
I think it was added at some point:
https://github.com/apache/incubator-superset/commit/a0ddbb9ec954a65a77350bc054b83e35bc4dffeb#diff-f25a00842d88e3e5cc4e4bcc822d40f7
but removed since i don't know why:
```
def get_sqla_query( # sqla
self,
groupby, metrics,
granularity,
from_dttm, to_dttm,
filter=None, # noqa
is_timeseries=True,
timeseries_limit=15,
timeseries_limit_metric=None,
row_limit=None,
inner_from_dttm=None,
inner_to_dttm=None,
orderby=None,
extras=None,
columns=None,
order_desc=True,
prequeries=None,
is_prequery=False,
):
"""Querying any sqla table from this common interface"""
template_kwargs = {
'from_dttm': from_dttm,
'groupby': groupby,
'metrics': metrics,
'row_limit': row_limit,
'to_dttm': to_dttm,
'filter': filter,
'columns': {col.column_name: col for col in self.columns},
}
```
So what I get is the empty dict from the constructor:
```
self.context = {
'url_param': url_param,
'current_user_id': current_user_id,
'current_username': current_username,
'form_data': {},
}
```
https://github.com/apache/incubator-superset/blob/510ae84b3b3c3880393b84ba1db6d9979ecb63e0/superset/jinja_context.py#L92
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] villebro opened a new issue #4920: form_data always returns empty dict
villebro opened a new issue #4920: form_data always returns empty dict
URL: https://github.com/apache/incubator-superset/issues/4920
Make sure these boxes are checked before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included
it here as text if any
- [x] I have reproduced the issue with at least the latest released version
of superset
- [x] I have checked the issue tracker for the same issue and I haven't
found one similar
### Superset version
Master branch
### Expected results
When adding filters and groupings to a slice, referencing `form_data` in the
query should return a dict with at least `groupby` and `filters`.
### Actual results
In the Jinja context, form_data is always an empty dict, ie. `{}`.
### Steps to reproduce
1. Create a new query with reference to form_data, e.g. `{%
form_data.get('groupby') %}`.
2. Create a slice that and add a few group-bys.
3. Notice that the group-bys don't show up in the rendered query.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mistercrunch commented on issue #4366: Add filters to dashboard in single slice without filter box view - interactive filters
mistercrunch commented on issue #4366: Add filters to dashboard in single slice without filter box view - interactive filters URL: https://github.com/apache/incubator-superset/issues/4366#issuecomment-385869786 It's planned for the next version of the dashboard app to have "scoped filters" that apply to sections / tabs / overall and perhaps individual charts. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #945: Google BigQuery Support
mistercrunch commented on issue #945: Google BigQuery Support URL: https://github.com/apache/incubator-superset/issues/945#issuecomment-385869242 I wouldn't recommend running on Windows since Superset isn't tested against it. You will hit problems like this one. Even if you'd fix this issue there could be regressions in the future since no one uses Windows to run Superset in production. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] swamy16 commented on issue #945: Google BigQuery Support
swamy16 commented on issue #945: Google BigQuery Support URL: https://github.com/apache/incubator-superset/issues/945#issuecomment-385862029 @darylerwin @mistercrunch sorry it is a typo from my end. The actual error is SIGALRM as mentioned by @mxmzdlv Module 'signal has no attribute 'SIGALRM' Basically I am able to add tables to superset and am able to visualize them in dashboards (Be it tables from bigquery, or the default main db "world bank dataset" ) but I am not able to query them (even the main db tables from superset sql lab)  As you can see the highlighted part in the above image "tsukuyomi" is a dataset in my bigquery and "2017_agency_mapping" is a table. I am able to create a slice view using tables from my bigquery.  As you can see in the above image I am querying from the main db of the default world bank. But it is not able to query the same in sql labs sql editor. @mxmzdlv mentioned that this is happening due to SIGALRM not working in windows. Please let em know if there is a way to solve this error in windows. I tried replicate what ASPePeX mentioned in the link you have given Unity-Technologies/ml-agents#7 But I am not able to locate the file in my computer. /python/unityagents/environment.py I am also not sure if this is the right approach This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] swamy16 commented on issue #945: Google BigQuery Support
swamy16 commented on issue #945: Google BigQuery Support URL: https://github.com/apache/incubator-superset/issues/945#issuecomment-385862029 @darylerwin @mistercrunch sorry it is a typo from my end. The actual error is SIGALRM as mentioned by @mxmzdlv Module 'signal has no attribute 'SIGALRM' Basically I am able to add tables to superset and am able to visualize them in dashboards (Be it tables from bigquery, or the default main db "world bank dataset" ) but I am not able to query them (even the main db tables from superset sql lab)  As you can see the highlighted part in the above image "tsukuyomi" is a dataset in my bigquery and "2017_agency_mapping" is a table. I am able to create a slice view using tables from my bigquery.  As you can see in the above image I am querying from the main db of the default world bank. But it is not able to query the same in sql labs sql editor. @mxmzdlv mentioned that this is happening due to SIGALRM not working in windows. Please let em know if there is a way to solve this error in windows. I tried replicate what ASPePeX mentioned in the link you have given Unity-Technologies/ml-agents#7 But I am not able to locate the file in my computer. /python/unityagents/environment.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #4917: Add doc entry for BigQuery support
mistercrunch closed pull request #4917: Add doc entry for BigQuery support URL: https://github.com/apache/incubator-superset/pull/4917 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docs/installation.rst b/docs/installation.rst index ca9cf3f595..06afbc637a 100644 --- a/docs/installation.rst +++ b/docs/installation.rst @@ -320,6 +320,8 @@ Here's a list of some of the recommended packages. +---+-+-+ | Kylin| ``pip install kylinpy`` | ``kylin://`` | +---+-+-+ +| BigQuery | ``pip install pybigquery`` | ``bigquery://`` | ++---+-+-+ Note that many other database are supported, the main criteria being the existence of a functional SqlAlchemy dialect and Python driver. Googling This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed issue #945: Google BigQuery Support
mistercrunch closed issue #945: Google BigQuery Support URL: https://github.com/apache/incubator-superset/issues/945 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations
williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-385803221 > I'm guessing the load time improvements have to do with the fact that some of the work can be started upfront while the bundles are downloading Yes, and this is great from a user perspective because it doesn't block page render like it currently does. I think this will have the effect of making users feel like the page is loading _much_ faster. > I'm thinking for visualizations that use React, they shouldn't have to import it and should somehow pick it up from global, same goes for jquery and perhaps a set of other things. React [is not that large](https://bundlephobia.com/result?p=react@16.3.2) (even smaller if we could actually upgrade to `16.0.0`) and I can't tell if you mean literal globals (`window.jquery`) but we should move away from that pattern (and `jquery` in general, it's just syntactic sugar for JS and ideally we'd be using fetch not ajax) rather than embrace it. It seems like the proper way to pull out "globally shared" code is using the webpack `CommonChunksPlugin`, if chunks share code it will pull them into a new chunk. I used this to create a separate `chunk` for all shared deck.gl code, and I also added it in a way that it _should_ pull out all shared code into a separate chunk if it is imported by >=2 modules ... BUT this didn't appear to have any effect so the vis chunks must not really share that much code 路♀️ This is the new final webpack output (note the deckgl layer size decreases, and the new larger `deckgl.fb9e56a3bf69cd1ce139.chunk.js`): ``` Version: webpack 3.11.0 Time: 46756ms Asset Size ChunksChunk Names deckgl/layers/grid.a8beccbf9f5b13e97f98.chunk.js8.74 kB 32 [emitted] deckgl/layers/grid f4769f9bdb7466be65088239c12046d1.eot20.1 kB [emitted] fa2772327f55d8198301fdb8bcfc8158.woff23.4 kB [emitted] e18bbf611f2a2e43afc071aa2f4e1512.ttf45.4 kB [emitted] 89889688147bd7575d6327160d64e760.svg 109 kB [emitted] nvd3_vis.7b1466ac696cd8d30467.chunk.js 6.8 MB 0 [emitted] [big] nvd3_vis sankey.0da04cf564e3607b0313.chunk.js 268 kB 1 [emitted] [big] sankey paired_ttest.d9654f93c94179c43de4.chunk.js 304 kB 2 [emitted] [big] paired_ttest pivot_table.752772a0c72696357184.chunk.js2.08 MB 3 [emitted] [big] pivot_table parallel_coordinates.0d0923b8adf4d520192a.chunk.js 204 kB 4 [emitted] parallel_coordinates EventFlow.04abc2ccfab65027f920.chunk.js2.57 MB 5 [emitted] [big] EventFlow big_number.39d33798fefe5e02632e.chunk.js41.8 kB 6 [emitted] big_number markup.0ee56d948bd6cc1366fb.chunk.js14.7 kB 7 [emitted] markup filter_box.f76d5a45eff1c943db92.chunk.js 12 MB 8 [emitted] [big] filter_box time_table.49446835d78c8f19c439.chunk.js1.51 MB 9 [emitted] [big] time_table mapbox.b927c5a82390d9078f99.chunk.js4.43 MB 10 [emitted] [big] mapbox partition.408cf680da8bcce8ad58.chunk.js 159 kB 11 [emitted] partition deckgl/multi.bced534d9159ab18934d.chunk.js 512 kB 12, 13, 14, 29, 30, 31, 32, 33, 34 [emitted] [big] deckgl/multi deckgl/layers/scatter.ce1c712e5113e386fc6a.chunk.js 429 kB 13 [emitted] [big] deckgl/layers/scatter deckgl/layers/screengrid.3619502e1991df96e5d5.chunk.js 400 kB 14 [emitted] [big] deckgl/layers/screengrid heatmap.a587cf5f653617b1305a.chunk.js 108 kB 15 [emitted] heatmap table.48aed4719820c3e79b32.chunk.js2.09 MB 16 [emitted] [big] table cal_heatmap.ed95b9fdabe40cb02ef1.chunk.js 348 kB 17 [emitted] [big] cal_heatmap
[GitHub] graceguo-supercat commented on issue #4919: [Profile]Gamma, Alpha user can't see their profile page
graceguo-supercat commented on issue #4919: [Profile]Gamma, Alpha user can't see their profile page URL: https://github.com/apache/incubator-superset/issues/4919#issuecomment-385798104 @mistercrunch Alpha and Gamma user can't access their own profile page. is this logic in FAB code base? Thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] graceguo-supercat commented on issue #4919: [Profile]Gamma, Alpha user can't see their profile page
graceguo-supercat commented on issue #4919: [Profile]Gamma, Alpha user can't see their profile page URL: https://github.com/apache/incubator-superset/issues/4919#issuecomment-385798104 @mistercrunch Alpha and Gamma user can't see their profile page. is this logic in FAB code base? Thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] graceguo-supercat opened a new issue #4919: [Profile]Gamma, Alpha user can't see their profile page
graceguo-supercat opened a new issue #4919: [Profile]Gamma, Alpha user can't see their profile page URL: https://github.com/apache/incubator-superset/issues/4919 Make sure these boxes are checked before submitting your issue - thank you! - [x ] I have checked the superset logs for python stacktraces and included it here as text if any - [x ] I have reproduced the issue with at least the latest released version of superset - [x ] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version latest ### Expected results visit user's profile content ### Actual results page got 302 redirect. ### Steps to reproduce clicks on Profile icon from Superset header https://user-images.githubusercontent.com/27990562/39494701-46b5db18-4d4c-11e8-923a-8cc526406d79.png;> This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #1413: Added average metric AVG() to default metrics
mistercrunch commented on issue #1413: Added average metric AVG() to default metrics URL: https://github.com/apache/incubator-superset/pull/1413#issuecomment-385794518 You have to create post-aggregations for averages on Druid. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] graceguo-supercat commented on a change in pull request #4760: URL shortner for dashboards
graceguo-supercat commented on a change in pull request #4760: URL shortner for
dashboards
URL:
https://github.com/apache/incubator-superset/pull/4760#discussion_r185330381
##
File path:
superset/assets/javascripts/explore/components/ExploreViewContainer.jsx
##
@@ -157,27 +151,6 @@ class ExploreViewContainer extends React.Component {
}
}
- addHistory({ isReplace = false, title }) {
Review comment:
i feel it's safe to keep query state in browser history.
- we still need to keep url scheme backward compatible right? Even we
display url in browser like /r/123, when user request with old scheme, we
should handle it correctly.
- after query state added into browser history, there is no real long url
request happened unless user refreshed browser or someone accessed the shared
url. So i guess the rate of old url scheme is pretty low.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] graceguo-supercat commented on issue #4833: [sqllab] Help sqllab forget query history
graceguo-supercat commented on issue #4833: [sqllab] Help sqllab forget query history URL: https://github.com/apache/incubator-superset/pull/4833#issuecomment-385783066 current auto query refresh component work like this: - in client-side, from all queries in local storage, it find out - status in `'running', 'started', 'pending', 'fetching'`, and - started in < 6 hours - if has any queries, polling with latest updated timestamp - if there is no such queries, stop polling. - in server-side, for every poll request, we get all queries - by user_id, and - changed after updated timestamp - if some query went wrong, and query status kept as `running` but never got to updated after 6 hours, when client-side polling with a newer timestamp (< 6 hours), this query will not have a chance to be set as `timeout` state. But it won't cause client-side keep polling because now client-side added timeout threshold. this PR LGTM. but will not merge until @mistercrunch feel comfortable. Thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed issue #4915: Exploring BQ table throws query error as date is incorrectly formatted
mistercrunch closed issue #4915: Exploring BQ table throws query error as date is incorrectly formatted URL: https://github.com/apache/incubator-superset/issues/4915 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #4918: Fix typos from linting
mistercrunch closed pull request #4918: Fix typos from linting
URL: https://github.com/apache/incubator-superset/pull/4918
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/db_engine_specs.py b/superset/db_engine_specs.py
index e95b4d3928..ee8f632da4 100644
--- a/superset/db_engine_specs.py
+++ b/superset/db_engine_specs.py
@@ -1260,7 +1260,7 @@ class BQEngineSpec(BaseEngineSpec):
def convert_dttm(cls, target_type, dttm):
tt = target_type.upper()
if tt == 'DATE':
-return "{}'".format(dttm.strftime('%Y-%m-%d'))
+return "'{}'".format(dttm.strftime('%Y-%m-%d'))
return "'{}'".format(dttm.strftime('%Y-%m-%d %H:%M:%S'))
@classmethod
@@ -1291,7 +1291,7 @@ class ImpalaEngineSpec(BaseEngineSpec):
def convert_dttm(cls, target_type, dttm):
tt = target_type.upper()
if tt == 'DATE':
-return "{}'".format(dttm.strftime('%Y-%m-%d'))
+return "'{}'".format(dttm.strftime('%Y-%m-%d'))
return "'{}'".format(dttm.strftime('%Y-%m-%d %H:%M:%S'))
@classmethod
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #4760: URL shortner for dashboards
codecov-io commented on issue #4760: URL shortner for dashboards URL: https://github.com/apache/incubator-superset/pull/4760#issuecomment-378721411 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr=h1) Report > Merging [#4760](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/510ae84b3b3c3880393b84ba1db6d9979ecb63e0?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4760 +/- ## == - Coverage 77.13% 77.12% -0.02% == Files 44 44 Lines8542 8538 -4 == - Hits 6589 6585 -4 Misses 1953 1953 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.66% <100%> (-0.02%)` | :arrow_down: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `87.85% <0%> (-0.22%)` | :arrow_down: | | [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `93.33% <0%> (ø)` | :arrow_up: | | [superset/cache\_util.py](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr=tree#diff-c3VwZXJzZXQvY2FjaGVfdXRpbC5weQ==) | `54.16% <0%> (ø)` | :arrow_up: | | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `81.16% <0%> (ø)` | :arrow_up: | | [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `92.85% <0%> (ø)` | :arrow_up: | | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `73.33% <0%> (ø)` | :arrow_up: | | [superset/data/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr=tree#diff-c3VwZXJzZXQvZGF0YS9fX2luaXRfXy5weQ==) | `100% <0%> (ø)` | :arrow_up: | | [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `98.59% <0%> (ø)` | :arrow_up: | | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `70.47% <0%> (ø)` | :arrow_up: | | ... and [29 more](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr=footer). Last update [510ae84...d3e1e76](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] LanDeQuHuXi commented on issue #4366: Add filters to dashboard in single slice without filter box view - interactive filters
LanDeQuHuXi commented on issue #4366: Add filters to dashboard in single slice without filter box view - interactive filters URL: https://github.com/apache/incubator-superset/issues/4366#issuecomment-385780560 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #4911: Fix for week_start_sunday and week_ending_saturday
mistercrunch closed pull request #4911: Fix for week_start_sunday and
week_ending_saturday
URL: https://github.com/apache/incubator-superset/pull/4911
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/spec/javascripts/modules/time_spec.js
b/superset/assets/spec/javascripts/modules/time_spec.js
new file mode 100644
index 00..59dab8effe
--- /dev/null
+++ b/superset/assets/spec/javascripts/modules/time_spec.js
@@ -0,0 +1,58 @@
+import { it, describe } from 'mocha';
+import { expect } from 'chai';
+import { getPlaySliderParams } from '../../../src/modules/time';
+
+describe('getPlaySliderParams', () => {
+ it('is a function', () => {
+assert.isFunction(getPlaySliderParams);
+ });
+
+ it('handles durations', () => {
+const timestamps = [
+ new Date('2018-01-01'),
+ new Date('2018-01-02'),
+ new Date('2018-01-03'),
+ new Date('2018-01-04'),
+ new Date('2018-01-05'),
+ new Date('2018-01-06'),
+ new Date('2018-01-07'),
+ new Date('2018-01-08'),
+ new Date('2018-01-09'),
+ new Date('2018-01-10'),
+].map(d => d.getTime());
+const { start, end, step, values, disabled } =
getPlaySliderParams(timestamps, 'P2D');
+expect(new Date(start)).to.eql(new Date('2018-01-01'));
+expect(new Date(end)).to.eql(new Date('2018-01-11'));
+expect(step).to.equal(2 * 24 * 60 * 60 * 1000);
+expect(values.map(v => new Date(v))).to.eql([
+ new Date('2018-01-01'),
+ new Date('2018-01-03'),
+]);
+expect(disabled).to.equal(false);
+ });
+
+ it('handles intervals', () => {
+const timestamps = [
+ new Date('2018-01-01'),
+ new Date('2018-01-02'),
+ new Date('2018-01-03'),
+ new Date('2018-01-04'),
+ new Date('2018-01-05'),
+ new Date('2018-01-06'),
+ new Date('2018-01-07'),
+ new Date('2018-01-08'),
+ new Date('2018-01-09'),
+ new Date('2018-01-10'),
+].map(d => d.getTime());
+// 1970-01-03 was a Saturday
+const { start, end, step, values, disabled } =
getPlaySliderParams(timestamps, 'P1W/1970-01-03T00:00:00Z');
+expect(new Date(start)).to.eql(new Date('2017-12-30')); // Saturday
+expect(new Date(end)).to.eql(new Date('2018-01-13')); // Saturday
+expect(step).to.equal(7 * 24 * 60 * 60 * 1000);
+expect(values.map(v => new Date(v))).to.eql([
+ new Date('2017-12-30'),
+ new Date('2018-01-06'),
+]);
+expect(disabled).to.equal(false);
+ });
+});
diff --git a/superset/assets/src/explore/controls.jsx
b/superset/assets/src/explore/controls.jsx
index ffe264b547..b3248df454 100644
--- a/superset/assets/src/explore/controls.jsx
+++ b/superset/assets/src/explore/controls.jsx
@@ -776,8 +776,8 @@ export const controls = {
['P1D', '1 day'],
['P7D', '7 days'],
['P1W', 'week'],
- ['P1W', 'week_starting_sunday'],
- ['P1W', 'week_ending_saturday'],
+ ['week_starting_sunday', 'week starting Sunday'],
+ ['week_ending_saturday', 'week ending Saturday'],
['P1M', 'month'],
],
description: t('The time granularity for the visualization. Note that you
' +
diff --git a/superset/assets/src/modules/time.js
b/superset/assets/src/modules/time.js
index 0c13dae859..7ebc4d7766 100644
--- a/superset/assets/src/modules/time.js
+++ b/superset/assets/src/modules/time.js
@@ -4,11 +4,31 @@ import parseIsoDuration from 'parse-iso-duration';
export const getPlaySliderParams = function (timestamps, timeGrain) {
let start = Math.min(...timestamps);
let end = Math.max(...timestamps);
+ let step;
- // lock start and end to the closest steps
- const step = parseIsoDuration(timeGrain);
- start -= start % step;
- end += step - end % step;
+ if (timeGrain.indexOf('/') > 0) {
+// Here, time grain is a time interval instead of a simple duration, either
+// `reference/duration` or `duration/reference`. We need to parse the
+// duration and make sure that start and end are in the right places. For
+// example, if `reference` is a Saturday and `duration` is 1 week (P1W)
+// then both start and end should be Saturdays.
+const parts = timeGrain.split('/', 2);
+let reference;
+if (parts[0].endsWith('Z')) { // ISO string
+ reference = new Date(parts[0]).getTime();
+ step = parseIsoDuration(parts[1]);
+} else {
+ reference = new Date(parts[1]).getTime();
+ step = parseIsoDuration(parts[0]);
+}
+start = reference + step * Math.floor((start - reference) / step);
+end = reference + step * (Math.floor((end - reference) / step) + 1);
+ } else {
+// lock start and end to the closest steps
+step = parseIsoDuration(timeGrain);
+start -= start % step;
+end += step - end % step;
+ }
[GitHub] timifasubaa commented on issue #4833: [sqllab] Help sqllab forget query history
timifasubaa commented on issue #4833: [sqllab] Help sqllab forget query history URL: https://github.com/apache/incubator-superset/pull/4833#issuecomment-385761026 PING Quick update on the state of the logic. What is really happening is that the frontend ceases to poll for queries older than 6 hours old. This is because on polls, it checks for all queries by that user whose state has changed after the last updated time. Meaning if a query is on pending for a very long time (> 6hours) and another query that's running at the same time changes state. We will no longer poll and also no longer receive any more updates. Is this backend code worth having? Especially since it may trick people into believing we actually timeout the queries when the query will most likely not be updated to timeout. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mohadelrezk commented on issue #1413: Added average metric AVG() to default metrics
mohadelrezk commented on issue #1413: Added average metric AVG() to default metrics URL: https://github.com/apache/incubator-superset/pull/1413#issuecomment-385751870 Hi, I am using latest version of superset (0.24) but average is not activated as a metric when I create a chart/slice from druid datasource note: it is available when I load data from csv files directly This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mohadelrezk commented on issue #1413: Added average metric AVG() to default metrics
mohadelrezk commented on issue #1413: Added average metric AVG() to default metrics URL: https://github.com/apache/incubator-superset/pull/1413#issuecomment-385751870 Hi, I am using latest version of superset (0.24) but average is not activated as a metric This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #4908: Replace NaN/Infinity with null
mistercrunch closed pull request #4908: Replace NaN/Infinity with null
URL: https://github.com/apache/incubator-superset/pull/4908
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/views/core.py b/superset/views/core.py
index 2e01e99b3a..a79ff2b4da 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -6,7 +6,6 @@
from __future__ import unicode_literals
from datetime import datetime, timedelta
-import json
import logging
import os
import re
@@ -24,6 +23,7 @@
from flask_babel import gettext as __
from flask_babel import lazy_gettext as _
import pandas as pd
+import simplejson as json
from six import text_type
import sqlalchemy as sqla
from sqlalchemy import create_engine
@@ -2327,7 +2327,8 @@ def results(self, key):
payload_json = json.loads(payload)
payload_json['data'] = payload_json['data'][:display_limit]
return json_success(
-json.dumps(payload_json, default=utils.json_iso_dttm_ser))
+json.dumps(
+payload_json, default=utils.json_iso_dttm_ser,
ignore_nan=True))
@has_access_api
@expose('/stop_query/', methods=['POST'])
@@ -2435,7 +2436,7 @@ def sql_json(self):
resp = json_success(json.dumps(
{'query': query.to_dict()}, default=utils.json_int_dttm_ser,
-allow_nan=False), status=202)
+ignore_nan=True), status=202)
session.commit()
return resp
@@ -2453,7 +2454,7 @@ def sql_json(self):
rendered_query,
return_results=True)
payload = json.dumps(
-data, default=utils.pessimistic_json_iso_dttm_ser)
+data, default=utils.pessimistic_json_iso_dttm_ser,
ignore_nan=True)
except Exception as e:
logging.exception(e)
return json_error_response('{}'.format(e))
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] betodealmeida commented on a change in pull request #4908: Replace NaN/Infinity with null
betodealmeida commented on a change in pull request #4908: Replace NaN/Infinity
with null
URL:
https://github.com/apache/incubator-superset/pull/4908#discussion_r185292674
##
File path: superset/views/core.py
##
@@ -2435,7 +2436,7 @@ def sql_json(self):
resp = json_success(json.dumps(
{'query': query.to_dict()}, default=utils.json_int_dttm_ser,
-allow_nan=False), status=202)
+ignore_nan=True), status=202)
Review comment:
Digging in a bit more, I found the first commit where this was introduced by
some guy called @mistercrunch:
https://github.com/apache/incubator-superset/commit/38b8db805 :-P
Initially both sync and async responses used `allow_nan=False`. Eventually
it got dropped from the sync response in
https://github.com/apache/incubator-superset/commit/269f55c29 when the
pessimistic encoder was introduced. The pessimistic encoder was not added to
the async response because the commit is trying to fix gigantic HTML error
messages, but IMHO it should've been added as well.
The problem is that the pessimistic encoder doesn't handle `NaN` and
`±Infinity` because they're floats, so the JSON encoder never calls the
`default` method on them.
I think the change above is safe — it will return _some_ result instead of
failing with a `ValueError` exception. But I think the best approach would be
using a more robust serialization to send data to the browser, like BSON.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #4819: Visualization for multiple line charts
codecov-io commented on issue #4819: Visualization for multiple line charts URL: https://github.com/apache/incubator-superset/pull/4819#issuecomment-383682187 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4819?src=pr=h1) Report > Merging [#4819](https://codecov.io/gh/apache/incubator-superset/pull/4819?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c94e1f710dcdea03c3e1f04c42439f1b4127fa0?src=pr=desc) will **increase** coverage by `0.06%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4819?src=pr=tree) ```diff @@Coverage Diff@@ ## master #4819 +/- ## = + Coverage 77.14% 77.2% +0.06% = Files 44 44 Lines85398563 +24 = + Hits 65876611 +24 Misses 19521952 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4819?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4819/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `80.1% <100%> (+0.2%)` | :arrow_up: | | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/4819/diff?src=pr=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `44.69% <100%> (+0.62%)` | :arrow_up: | | [superset/data/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/4819/diff?src=pr=tree#diff-c3VwZXJzZXQvZGF0YS9fX2luaXRfXy5weQ==) | `100% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4819?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4819?src=pr=footer). Last update [8c94e1f...1e58489](https://codecov.io/gh/apache/incubator-superset/pull/4819?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday
codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=h1) Report > Merging [#4911](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e1d2150391ba827a64cebd0c0573aab0a82a3634?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4911 +/- ## === Coverage 77.14% 77.14% === Files 44 44 Lines8539 8539 === Hits 6587 6587 Misses 1952 1952 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4911/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `52.69% <ø> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=footer). Last update [e1d2150...158e02e](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] darylerwin commented on issue #945: Google BigQuery Support
darylerwin commented on issue #945: Google BigQuery Support URL: https://github.com/apache/incubator-superset/issues/945#issuecomment-385737552 @swamy16 is that a typo in the alarm and perhaps related to this windows signal python issue? https://github.com/Unity-Technologies/ml-agents/issues/7 Basically it is timing out? Is the dataset too big? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday
codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=h1) Report > Merging [#4911](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e1d2150391ba827a64cebd0c0573aab0a82a3634?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4911 +/- ## === Coverage 77.14% 77.14% === Files 44 44 Lines8539 8539 === Hits 6587 6587 Misses 1952 1952 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4911/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `52.69% <ø> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=footer). Last update [e1d2150...158e02e](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #3724: SECRET_KEY encrypts database secrets without warning, possibly breaking web interface if changed
mistercrunch commented on issue #3724: SECRET_KEY encrypts database secrets without warning, possibly breaking web interface if changed URL: https://github.com/apache/incubator-superset/issues/3724#issuecomment-385736855 FYI the easiest way is to use `DB_CONNECTION_MUTATOR` that you can define in your `superset_config.py`. More info here: https://github.com/apache/incubator-superset/blob/master/superset/config.py#L386 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday
codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=h1) Report > Merging [#4911](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e1d2150391ba827a64cebd0c0573aab0a82a3634?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4911 +/- ## === Coverage 77.14% 77.14% === Files 44 44 Lines8539 8539 === Hits 6587 6587 Misses 1952 1952 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4911/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `52.69% <ø> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=footer). Last update [e1d2150...158e02e](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4727: [webpack] setup lazy loading for all visualizations
mistercrunch commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-385718217 I'm worried about the way things look here without bundling visualizations together. The sum of all visualization is much more than the original `explore` bundle. A simple dashboard with a `filter_box` , nvd3, `table` and `pivot_table` will load like 24mb which is significantly more than the old explore bundle. I'm guessing the load time improvements have to do with the fact that some of the work can be started upfront while the bundles are downloading. Results may look different on a network-bound scenario. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4727: [webpack] setup lazy loading for all visualizations
mistercrunch commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-385719915 We need to fix the fact that `filter_box` is 12mb. I'm thinking for visualizations that use `React`, they shouldn't have to import it and should somehow pick it up from `global`, same goes for `jquery` and perhaps a set of other things. We probably need some sort of `global_imports` package that all apps (explore, dashboard, profile, ...) would import and build, and that visualization would pick from without importing/bundling. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] johnsks commented on issue #4037: table view pagination
johnsks commented on issue #4037: table view pagination URL: https://github.com/apache/incubator-superset/issues/4037#issuecomment-385718766 Hello all, We are currently using 0.23.0dev, and have quite a few table views in our implementation. The lack of pagination is impacting the performance of the dashboards, which I am sure are all aware of. I have funding to get the table view pagination changes done, and a resource available. We will gladly contribute all the changes back to product. However, it will be helpful if any of you who have looked into the issue can share your thought son the changes needed. For example to table.js, viz.py etc. Your insights into how we can go about making the changes is much appreciated. Thank you in advance. John This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4727: [webpack] setup lazy loading for all visualizations
mistercrunch commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-385718217 I'm worried about the way things look here without bundling visualizations together. The sum of all visualization is much more than the original `explore` bundle. A simple dashboard with a `filter_box` , nvd3, `table` and `pivot_table` will load like 24mb which is significantly more than the old explore bundle. I'm guessing the load time improvements have to do with the fact that some of the work can be started upfront while the bundles are downloading. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations
williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-385716957 I can give deck.gl a shot if you want tho, I think the d3 bundle is almost over optimizing. That'll be harder to untangle potentially as we refactor vis libraries. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations
williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-385716957 I can give deck.gl a shot if you want tho, I think the d3 bundle is almost over optimizing. That'll be harder to untangle potential totally as we refactor vis libraries. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations
williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-385715788 It's not as trivial as using the same chunk name. The final name consists of chunk name and hash. I'd rather do that optimization in another PR because I think you'd have to create an index file that exports all of deckgl and async import that file. I'm not as familiar with the deckgl code organization so you all might be best suited to do that? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4918: Fix typos from linting
codecov-io commented on issue #4918: Fix typos from linting URL: https://github.com/apache/incubator-superset/pull/4918#issuecomment-385713818 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4918?src=pr=h1) Report > Merging [#4918](https://codecov.io/gh/apache/incubator-superset/pull/4918?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c94e1f710dcdea03c3e1f04c42439f1b4127fa0?src=pr=desc) will **not change** coverage. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4918?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4918 +/- ## === Coverage 77.14% 77.14% === Files 44 44 Lines8539 8539 === Hits 6587 6587 Misses 1952 1952 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4918?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4918/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `52.69% <0%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4918?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4918?src=pr=footer). Last update [8c94e1f...36ebd6e](https://codecov.io/gh/apache/incubator-superset/pull/4918?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4917: Add doc entry for BigQuery support
codecov-io commented on issue #4917: Add doc entry for BigQuery support URL: https://github.com/apache/incubator-superset/pull/4917#issuecomment-385710264 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4917?src=pr=h1) Report > Merging [#4917](https://codecov.io/gh/apache/incubator-superset/pull/4917?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e1d2150391ba827a64cebd0c0573aab0a82a3634?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4917?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4917 +/- ## === Coverage 77.14% 77.14% === Files 44 44 Lines8539 8539 === Hits 6587 6587 Misses 1952 1952 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4917?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4917?src=pr=footer). Last update [e1d2150...ad3ecd4](https://codecov.io/gh/apache/incubator-superset/pull/4917?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4819: Visualization for multiple line charts
mistercrunch commented on issue #4819: Visualization for multiple line charts URL: https://github.com/apache/incubator-superset/pull/4819#issuecomment-385708415 Cool, please fix merge conflicts, as this looks like it's ready to be merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4915: Exploring BQ table throws query error as date is incorrectly formatted
mistercrunch commented on issue #4915: Exploring BQ table throws query error as date is incorrectly formatted URL: https://github.com/apache/incubator-superset/issues/4915#issuecomment-385708066 Thanks for reporting this, https://github.com/apache/incubator-superset/pull/4918 addresses the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch opened a new pull request #4918: Fix typos from linting
mistercrunch opened a new pull request #4918: Fix typos from linting URL: https://github.com/apache/incubator-superset/pull/4918 Caused by https://github.com/apache/incubator-superset/pull/3847 Fixes https://github.com/apache/incubator-superset/issues/4915 Greped for more of this pattern but didn't find other errors. @john-bodley please check if you can think of what went wrong and whether other similar patterns may be affected. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on a change in pull request #3847: [flake8] Resolving Q??? errors
mistercrunch commented on a change in pull request #3847: [flake8] Resolving
Q??? errors
URL:
https://github.com/apache/incubator-superset/pull/3847#discussion_r185256095
##
File path: superset/db_engine_specs.py
##
@@ -1043,22 +1043,22 @@ class BQEngineSpec(BaseEngineSpec):
engine = 'bigquery'
time_grains = (
-Grain("Time Column", _('Time Column'), "{col}"),
-Grain("second", _('second'), "TIMESTAMP_TRUNC({col}, SECOND)"),
-Grain("minute", _('minute'), "TIMESTAMP_TRUNC({col}, MINUTE)"),
-Grain("hour", _('hour'), "TIMESTAMP_TRUNC({col}, HOUR)"),
-Grain("day", _('day'), "TIMESTAMP_TRUNC({col}, DAY)"),
-Grain("week", _('week'), "TIMESTAMP_TRUNC({col}, WEEK)"),
-Grain("month", _('month'), "TIMESTAMP_TRUNC({col}, MONTH)"),
-Grain("quarter", _('quarter'), "TIMESTAMP_TRUNC({col}, QUARTER)"),
-Grain("year", _('year'), "TIMESTAMP_TRUNC({col}, YEAR)"),
+Grain('Time Column', _('Time Column'), '{col}'),
+Grain('second', _('second'), 'TIMESTAMP_TRUNC({col}, SECOND)'),
+Grain('minute', _('minute'), 'TIMESTAMP_TRUNC({col}, MINUTE)'),
+Grain('hour', _('hour'), 'TIMESTAMP_TRUNC({col}, HOUR)'),
+Grain('day', _('day'), 'TIMESTAMP_TRUNC({col}, DAY)'),
+Grain('week', _('week'), 'TIMESTAMP_TRUNC({col}, WEEK)'),
+Grain('month', _('month'), 'TIMESTAMP_TRUNC({col}, MONTH)'),
+Grain('quarter', _('quarter'), 'TIMESTAMP_TRUNC({col}, QUARTER)'),
+Grain('year', _('year'), 'TIMESTAMP_TRUNC({col}, YEAR)'),
)
@classmethod
def convert_dttm(cls, target_type, dttm):
tt = target_type.upper()
if tt == 'DATE':
-return "'{}'".format(dttm.strftime('%Y-%m-%d'))
+return "{}'".format(dttm.strftime('%Y-%m-%d'))
Review comment:
This caused: https://github.com/apache/incubator-superset/issues/4915
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mistercrunch closed pull request #4913: Fix country_map visualization URL
mistercrunch closed pull request #4913: Fix country_map visualization URL
URL: https://github.com/apache/incubator-superset/pull/4913
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/src/visualizations/country_map.js
b/superset/assets/src/visualizations/country_map.js
index a5ab3c431d..09d325de67 100644
--- a/superset/assets/src/visualizations/country_map.js
+++ b/superset/assets/src/visualizations/country_map.js
@@ -132,7 +132,7 @@ function countryMapChart(slice, payload) {
.attr('x', 20)
.attr('y', 60);
- const url =
`/static/assets/visualizations/countries/${fd.select_country.toLowerCase()}.geojson`;
+ const url =
`/static/assets/src/visualizations/countries/${fd.select_country.toLowerCase()}.geojson`;
d3.json(url, function (error, mapData) {
const features = mapData.features;
const center = d3.geo.centroid(mapData);
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mistercrunch opened a new pull request #4917: Add doc entry for BigQuery support
mistercrunch opened a new pull request #4917: Add doc entry for BigQuery support URL: https://github.com/apache/incubator-superset/pull/4917 closes https://github.com/apache/incubator-superset/issues/945 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4727: [webpack] setup lazy loading for all visualizations
mistercrunch commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-385704283 We should use the same webchunk name for all `deckgl`-related charts, same for `nvd3` and same all the ones that only require `d3`. I'm thinking we could have 4-5 bundles with all the visualizations in them. The "DeckGL Demo" dashboard should be much fast as it will load one 8mb chunk instead of 6 of them. Is it just a matter of sharing/reusing webchunknames? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4727: [webpack] setup lazy loading for all visualizations
mistercrunch commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-385704283 We should use the same webchunk name for all `deckgl`-related charts, same for `nvd3` and same all the ones that only require `d3`. I'm thinking we could have 4-5 bundles with all the visualizations in them. Is it just a matter of sharing/reusing webchunknames? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4916: Readonly Databases not Supported (eg Dremio or lower permissioned connections)
mistercrunch commented on issue #4916: Readonly Databases not Supported (eg Dremio or lower permissioned connections) URL: https://github.com/apache/incubator-superset/issues/4916#issuecomment-385699143 I think you're misinterpreting the logs. Superset does not require writing to target databases. `SELECT EXISTS` is against your Superset metadata database as it should as it tries to add a new entry on the Superset side to store the table's metadata from Dremio. My guess it that the call that tries to extract the metadata from Dremio here https://github.com/apache/incubator-superset/blob/master/superset/models/core.py#L809 isn't working properly in the dialect. Some database don't have a direct notion or schema, or sometimes have 2 levels of namespacing (Postgres has database and schema/owner) and that doesn't always fits the SQLAlchemy model perfectly. Dialects implementation have to be careful to line things up properly. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #4916: Readonly Databases not Supported (eg Dremio or lower permissioned connections)
xrmx commented on issue #4916: Readonly Databases not Supported (eg Dremio or lower permissioned connections) URL: https://github.com/apache/incubator-superset/issues/4916#issuecomment-385671694 You may want to raise debugging level to see more interesting things. Superset works perfectly fine with multiple databases. It looks like it's just matter of ironing out the compatibility with dremio. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] malsmith opened a new issue #4916: Readonly Databases not Supported (eg Dremio or lower permissioned connections)
malsmith opened a new issue #4916: Readonly Databases not Supported (eg Dremio or lower permissioned connections) URL: https://github.com/apache/incubator-superset/issues/4916 Make sure these boxes are checked before submitting your issue - thank you! - [X] I have checked the superset logs for python stacktraces and included it here as text if any - [X] I have reproduced the issue with at least the latest released version of superset - [X] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version 0.24 ### Expected results I should be able to add a table from any database connection. Note that when I add more database connections I can use them just fine in the SQL Lab UI - just can't add tables from them in the Tables function - so I can't actually use them in charts or dashboards. It seems like the Superset system is only designed to use a single database at a time and requires read/write access to that database, which would block my planned use of the system where I planned to have a small postgresql database for metadata and management and a large readonly database (Dremio in my case) as the analytical datastore. ### Actual results When adding a new Table item in the UI the system gets confused and queries the target database to check if the "tables" table already contains the new entry - rather than checking the main database connection (sqlite in my case). The system returns an Unknown error from database Flash message and the query itself fails in the Superset system logs (table "Tables" does not exist) ### Steps to reproduce Install the system as is with the Sqlite datasource/database as the primary database (load samples etc). Then Add a new Database in addition to the SQLLite one. In my case add a database where new tables cannot be created (although this seems to be beside the point). Attempt to add a new Table that is known to exist in the secondary database. Watch the system fail to add the new table (generating the unknown database flash message) Appears to be a problem in (or leading up to) ``` superset/connectors/sqla/views.py line 236 pre_add method ``` This seems to grab the wrong database sqla engine value and implications are that the system needs to know which is the database engine that holds the Superset metadata and which is the system where the new table is to be added from. SQL Trace ``` 2018-04-30 20:14:20,274 INFO sqlalchemy.engine.base.Engine SELECT EXISTS (SELECT 1 FROM tables WHERE tables.table_name = ? AND tables.schema = ? AND tables.database_id = ?) AS anon_1 2018-04-30 20:14:20,274:INFO:sqlalchemy.engine.base.Engine:SELECT EXISTS (SELECT 1 FROM tables WHERE tables.table_name = ? AND tables.schema = ? AND tables.database_id = ?) AS anon_1 2018-04-30 20:14:20,275 INFO sqlalchemy.engine.base.Engine (u'sf_incidents_clean', u'', 3) 2018-04-30 20:14:20,275:INFO:sqlalchemy.engine.base.Engine:(u'sf_incidents_clean', u'', 3) 2018-04-30 20:14:20,275:INFO:root:Database.get_sqla_engine(). Masked URL: dremio+pyodbc://malsmith:XX@mydremio 2018-04-30 20:14:20,562 INFO sqlalchemy.engine.base.Engine ROLLBACK 2018-04-30 20:14:20,562:INFO:sqlalchemy.engine.base.Engine:ROLLBACK 2018-04-30 20:14:20,564:INFO:werkzeug:127.0.0.1 - - [30/Apr/2018 20:14:20] "POST /tablemodelview/add HTTP/1.1" 302 - ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] swamy16 commented on issue #945: Google BigQuery Support
swamy16 commented on issue #945: Google BigQuery Support URL: https://github.com/apache/incubator-superset/issues/945#issuecomment-385653782 @mxmzdlv thanks for the help. I shall try installing superset in virtualbox. also is it possible to share the dashboards I create on superset with others in my organisation who don't have superset or python installed? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mxmzdlv commented on issue #945: Google BigQuery Support
mxmzdlv commented on issue #945: Google BigQuery Support URL: https://github.com/apache/incubator-superset/issues/945#issuecomment-385631372 @swamy16 seems to be an issue with calling signal(signal.SIGALRM) — SIGALRM is not available on Windows. https://github.com/apache/incubator-superset/blob/d533ce09676921ec2f72e1032bbca0d2a37f65b6/superset/utils.py#L508 I think the easiest way to handle this would be to run Superset in a Docker / Vagrant or just install Virtualbox with Linux on it and run Superset from there? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mxmzdlv commented on issue #945: Google BigQuery Support
mxmzdlv commented on issue #945: Google BigQuery Support URL: https://github.com/apache/incubator-superset/issues/945#issuecomment-385631372 @swamy16 seems to be an issue with calling signal(signal.SIGALRM) — SIGALRM is not available on Windows. https://github.com/apache/incubator-superset/blob/d533ce09676921ec2f72e1032bbca0d2a37f65b6/superset/utils.py#L508 I think the easiest way to handle this would be to run Superset in a Docker / Vagrant. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] swamy16 commented on issue #945: Google BigQuery Support
swamy16 commented on issue #945: Google BigQuery Support URL: https://github.com/apache/incubator-superset/issues/945#issuecomment-385619874 @tswast @darylerwin @mistercrunch @mxmzdlv @Bamieh Thanks to you guys (your guidance) I was finally able to connect my superset to bigquery in windows. For some reason I was not able to set env variable through command promt or windows power shell. I did it manually through mycomputer/properties/settings/environment variables. I had to restart superset to make it work though. @Bamieh Idid not try using docker for running this. I have only heard about docker. Have never practically used it or worked with it. It would be great if you could point me to some resources on it so that I can learn the same. Now I can see tables and get their count and other things. Please refer below image for the same.  But when I am trying to run the same query from sql lab I am not able to generate any result. It just keeps on running and timesout. The same is happening If I try to query from the default 'main' DB that gets installed for visualising World Bank Data and other dashboards. I get the following error `Module 'signal has no attribute 'SILGRAM' ` and the query keeps on running for ever.  Currently I am creating dashboards using a manual process (Upload csv). Please help me resolve this error. Also is there a way to share the dashboard made on superset to others who dont have superset (even python) installed on them. Can I share it privately within the organisation I work in? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] swamy16 commented on issue #945: Google BigQuery Support
swamy16 commented on issue #945: Google BigQuery Support URL: https://github.com/apache/incubator-superset/issues/945#issuecomment-385619874 @tswast @darylerwin @mistercrunch @mxmzdlv Thanks to you guys (your guidance) I was finally able to connect my superset to bigquery in windows. For some reason I was not able to set env variable through command promt or windows power shell. I did it manually through mycomputer/properties/settings/environment variables. I had to restart superset to make it work though. Now I can see tables and get their count and other things. Please refer below image for the same.  But when I am trying to run the same query from sql lab I am not able to generate any result. It just keeps on running and timesout. The same is happening If I try to query from the default 'main' DB that gets installed for visualising World Bank Data and other dashboards. I get the following error `Module 'signal has no attribute 'SILGRAM' ` and the query keeps on running for ever.  Currently I am creating dashboards using a manual process (Upload csv). Please help me resolve this error. Also is there a way to share the dashboard made on superset to others who dont have superset (even python) installed on them. Can I share it privately within the organisation I work in? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations
williaster commented on issue #4727: [webpack] setup lazy loading for all
visualizations
URL:
https://github.com/apache/incubator-superset/pull/4727#issuecomment-385615006
I got chunk names to update (see exact webpack input / output below) and
wanted to post some numbers from local dashboard testing which all look pretty
good:
- average total payload **decreased by 5 MB**
- DOM content load time **decreased 3.4s**
- Page load time **decreased 1.1s**
- the average # requests **increased by 6**
| Total payload (MB) | |
-- | -- | -- | --
Dashboard | Before | After |
Births example | 12.4 | 6.9 | -5.5
World data example | 12.4 | 8.7 | -3.7
Misc charts example | 14.9 | 8.5 | -6.4
Misc charts example w Deck gl | 15.4 | 11.1 | -4.3
| DOM content loaded (seconds) | |
-- | -- | -- | --
Dashboard | Before | After | Delta
Births example | 7.69 | 2.93 | -4.76
World data example | 6.58 | 2.63 | -3.95
Misc charts example | 6.38 | 3.88 | -2.50
Misc charts example w Deck gl | 6.20 | 2.71 | -3.49
| Total time (seconds) | |
-- | -- | -- | --
Dashboard | Before | After | Delta
Births example | 9.25 | 6.87 | -2.38
World data example | 9.22 | 6.78 | -2.44
Misc charts example | 7.69 | 5.53 | -2.16
Misc charts example w Deck gl | 7.73 | 10.19 | +2.45
| Requests (count) | |
-- | -- | -- | --
Dashboard | Before | After | Delta
Births example | 32 | 36 | +4
World data example | 29 | 34 | +5
Misc charts example | 45 | 53 | +8
Misc charts example w Deck gl | 59 | 67 | +8
webpack output before
```
Hash: 09e816a63d54c8a794f4
Version: webpack 3.10.0
Time: 44176ms (44s)
Asset Size Chunks
Chunk Names
welcome.f1949d0f24772fdd90be.entry.js8.49 MB5, 6 [emitted] [big]
welcome
f4769f9bdb7466be65088239c12046d1.eot20.1 kB [emitted]
fa2772327f55d8198301fdb8bcfc8158.woff23.4 kB [emitted]
e18bbf611f2a2e43afc071aa2f4e1512.ttf45.4 kB [emitted]
89889688147bd7575d6327160d64e760.svg 109 kB [emitted]
dashboard.7aae3890d2f0d6521e6e.entry.js48.1 MB0, 6 [emitted] [big]
dashboard
explore.7876f80fe4be57a17e6c.entry.js46.3 MB1, 6 [emitted] [big]
explore
sqllab.80cb1149088d4df08c50.entry.js17.8 MB2, 6 [emitted] [big]
sqllab
profile.87ba695abcd8682ad921.entry.js8.57 MB3, 6 [emitted] [big]
profile
addSlice.f27f6a8368fce90f27ca.entry.js9.18 MB4, 6 [emitted] [big]
addSlice
448c34a56d699c29117adc64c43affeb.woff2 18 kB [emitted]
common.540032da3aeaf1cdc78e.entry.js3.85 MB 6 [emitted] [big]
common
theme.912f2edddcf1890cf5f2.entry.js6.12 kB 7 [emitted]
theme
theme.912f2edddcf1890cf5f2.css 321 kB 7 [emitted] [big]
theme
explore.7876f80fe4be57a17e6c.css85.5 kB1, 6 [emitted]
explore
dashboard.7aae3890d2f0d6521e6e.css92.9 kB0, 6 [emitted]
dashboard
sqllab.80cb1149088d4df08c50.css7.01 kB2, 6 [emitted]
sqllab
welcome.f1949d0f24772fdd90be.css 846 bytes5, 6 [emitted]
welcome
profile.87ba695abcd8682ad921.css1.04 kB3, 6 [emitted]
profile
manifest.json1.17 kB [emitted]
[31] ./src/locales.jsx 5.63 kB {0} {1} {2} {3} {4} {5} {6} [built]
[544] ./src/common.js 1.52 kB {0} {1} {2} {3} {4} {5} {6} [built]
[2877] ./src/theme.js 152 bytes {7} [built]
[2879] ./stylesheets/react-select/select.less 41 bytes {7} [built]
[2881] multi babel-polyfill ./src/addSlice/index.jsx 40 bytes {4} [built]
[2882] ./src/addSlice/index.jsx 793 bytes {4} [built]
[2884] multi babel-polyfill ./src/explore/index.jsx 40 bytes {1} [built]
[2885] ./src/explore/index.jsx 3.53 kB {1} [built]
[2910] multi babel-polyfill ./src/dashboard/index.jsx 40 bytes {0} [built]
[2911] ./src/dashboard/index.jsx 1.47 kB {0} [built]
[2976] multi babel-polyfill ./src/SqlLab/index.jsx 40 bytes {2} [built]
[2977] ./src/SqlLab/index.jsx 1.55 kB {2} [built]
[3062] multi babel-polyfill ./src/welcome/index.jsx 40 bytes {5} [built]
[3066] multi babel-polyfill ./src/profile/index.jsx 40 bytes {3} [built]
[3067] ./src/profile/index.jsx 775 bytes {3} [built]
+ 3119 hidden modules
```
webpack output after
```
Hash: 460ae189f7f00025375d
Version: webpack 3.11.0
Time: 45052ms
Asset Size
ChunksChunk Names
parallel_coordinates.e19f30010f7bbf13546b.chunk.js 204 kB
22 [emitted] parallel_coordinates
f4769f9bdb7466be65088239c12046d1.eot
[GitHub] williaster commented on issue #4913: Fix country_map visualization URL
williaster commented on issue #4913: Fix country_map visualization URL URL: https://github.com/apache/incubator-superset/pull/4913#issuecomment-385612991 lgtm This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kuriancheeramelil opened a new issue #4915: Exploring BQ table throws query error as date is incorrectly formatted
kuriancheeramelil opened a new issue #4915: Exploring BQ table throws query
error as date is incorrectly formatted
URL: https://github.com/apache/incubator-superset/issues/4915
Make sure these boxes are checked before submitting your issue - thank you!
- [X] I have checked the superset logs for python stacktraces and included
it here as text if any
- [X] I have reproduced the issue with at least the latest released version
of superset
- [X] I have checked the issue tracker for the same issue and I haven't
found one similar
### Superset version
0.25
### Expected results
Executing BQ table query via table explore page executes query with date
field correctly.
### Actual results
the query generated throws syntax error
### Steps to reproduce
Add BQ table with date in superset and explore table. Any metric throws
syntax error.
The issue seems to be with this line
https://github.com/apache/incubator-superset/blob/e1d2150391ba827a64cebd0c0573aab0a82a3634/superset/db_engine_specs.py#L1263
Instead of
return "'{}'".format(dttm.strftime('%Y-%m-%d'))
it is missing the starting single quote
return "{}'".format(dttm.strftime('%Y-%m-%d'))
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mistercrunch commented on issue #4343: fixing Issue #4335 - Not quoting column name when doing a time series
mistercrunch commented on issue #4343: fixing Issue #4335 - Not quoting column name when doing a time series URL: https://github.com/apache/incubator-superset/pull/4343#issuecomment-385610298 @kstan79 I think this is fixed on master, can you confirm? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4913: Fix country_map visualization URL
codecov-io commented on issue #4913: Fix country_map visualization URL URL: https://github.com/apache/incubator-superset/pull/4913#issuecomment-385609581 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4913?src=pr=h1) Report > Merging [#4913](https://codecov.io/gh/apache/incubator-superset/pull/4913?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e1d2150391ba827a64cebd0c0573aab0a82a3634?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4913?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4913 +/- ## === Coverage 77.14% 77.14% === Files 44 44 Lines8539 8539 === Hits 6587 6587 Misses 1952 1952 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4913?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4913?src=pr=footer). Last update [e1d2150...9b91c9b](https://codecov.io/gh/apache/incubator-superset/pull/4913?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on issue #4910: Use React.PureComponent everywhere
williaster commented on issue #4910: Use React.PureComponent everywhere URL: https://github.com/apache/incubator-superset/pull/4910#issuecomment-385608926 I would not pursue this, [from Dan Abranov ]( https://twitter.com/dan_abramov/status/75938353012011008) (on React team, creator of redux): > Don‘t use PureComponent everywhere. Measure. On that Twitter thread he notes that equality checks for every `prop` for every component (which is what happens when you use `PureComponent`) is not necessarily cheap, and it can actually slow down your app in some cases. This is what I've been told as well, you should only start doing this when you measure something (with dev tools) and know something expensive is happening. Or do some explicit measuring in this PR and only update significant improvements you see. https://user-images.githubusercontent.com/4496521/39463701-2db7b4f2-4cce-11e8-80e6-f6b784dddac0.png; width="400" /> This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on issue #4910: Use React.PureComponent everywhere
williaster commented on issue #4910: Use React.PureComponent everywhere URL: https://github.com/apache/incubator-superset/pull/4910#issuecomment-385608926 I would not pursue this, [from Dan Abranov ]( https://twitter.com/dan_abramov/status/75938353012011008) (on React team, creator of redux): > Don‘t use PureComponent everywhere. Measure. On that Twitter thread he notes that equality checks for every `prop` for every component (which is what happens when you use `PureComponent`) is not necessarily cheap, and it can actually slow down your app in some cases. This is what I've been told as well, you should only start doing this when you measure something (with dev tools) and know something expensive is happening. Or do some explicit measuring in this PR and only update significant improvements you see. https://user-images.githubusercontent.com/4496521/39463701-2db7b4f2-4cce-11e8-80e6-f6b784dddac0.png This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on issue #4910: Use React.PureComponent everywhere
williaster commented on issue #4910: Use React.PureComponent everywhere URL: https://github.com/apache/incubator-superset/pull/4910#issuecomment-385608926 I would not pursue this, [from Dan Abranov ]( https://twitter.com/dan_abramov/status/75938353012011008) (on React team, creator of redux): > Don‘t use PureComponent everywhere. Measure. On that Twitter thread he notes that equality checks for every `prop` for every component (which is what happens when you use `PureComponent`) is not necessarily cheap, and it can actually slow down your app in some cases. This is what I've been told as well, you should only start doing this when you measure something (with dev tools) and know something expensive is happening. Or do some explicit measuring in this PR and see what's improving significantly. https://user-images.githubusercontent.com/4496521/39463701-2db7b4f2-4cce-11e8-80e6-f6b784dddac0.png This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on issue #4910: Use React.PureComponent everywhere
williaster commented on issue #4910: Use React.PureComponent everywhere URL: https://github.com/apache/incubator-superset/pull/4910#issuecomment-385608926 I would not pursue this, [from Dan Abranov ]( https://twitter.com/dan_abramov/status/75938353012011008) (on React team, creator of redux): > Don‘t use PureComponent everywhere. Measure. https://user-images.githubusercontent.com/4496521/39463701-2db7b4f2-4cce-11e8-80e6-f6b784dddac0.png; width="350" /> On that Twitter thread he notes that equality checks for every `prop` for every component (which is what happens when you use `PureComponent`) is not necessarily cheap, and it can actually slow down your app in some cases. This is what I've been told as well, you should only start doing this when you measure something (with dev tools) and know something expensive is happening. Or do some explicit measuring in this PR and see what's improving significantly. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch opened a new pull request #4913: Fix country_map visualization URL
mistercrunch opened a new pull request #4913: Fix country_map visualization URL URL: https://github.com/apache/incubator-superset/pull/4913 When moving the visualizations/ folder to src/ I missed this reference. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jeffreythewang commented on issue #4740: Add extraction function support for Druid queries
jeffreythewang commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-385596164 We currently don't use extraction functions either. This may have already been answered, but I'm curious why you didn't use the pydruid [`DimensionSpec`](https://github.com/druid-io/pydruid/blob/master/pydruid/utils/dimensions.py#L8) builder? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley commented on issue #4740: Add extraction function support for Druid queries
john-bodley commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-385579265 @mistercrunch I don't believe we use extraction functions in any of the Druid clusters connected to Superset (per a quick code search). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday
codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=h1) Report > Merging [#4911](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e1d2150391ba827a64cebd0c0573aab0a82a3634?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4911 +/- ## === Coverage 77.14% 77.14% === Files 44 44 Lines8539 8539 === Hits 6587 6587 Misses 1952 1952 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4911/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `52.69% <ø> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=footer). Last update [e1d2150...d850f31](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday
codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=h1) Report > Merging [#4911](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e1d2150391ba827a64cebd0c0573aab0a82a3634?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4911 +/- ## === Coverage 77.14% 77.14% === Files 44 44 Lines8539 8539 === Hits 6587 6587 Misses 1952 1952 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4911/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `52.69% <ø> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=footer). Last update [e1d2150...d850f31](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] fabianmenges commented on issue #4740: Add extraction function support for Druid queries
fabianmenges commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-385575931 Ack, will do. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday
codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=h1) Report > Merging [#4911](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e1d2150391ba827a64cebd0c0573aab0a82a3634?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4911 +/- ## === Coverage 77.14% 77.14% === Files 44 44 Lines8539 8539 === Hits 6587 6587 Misses 1952 1952 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4911/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `52.69% <ø> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=footer). Last update [e1d2150...d850f31](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday
codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=h1) Report > Merging [#4911](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e1d2150391ba827a64cebd0c0573aab0a82a3634?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4911 +/- ## === Coverage 77.14% 77.14% === Files 44 44 Lines8539 8539 === Hits 6587 6587 Misses 1952 1952 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4911/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `52.69% <ø> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=footer). Last update [e1d2150...d850f31](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday
codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=h1) Report > Merging [#4911](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e1d2150391ba827a64cebd0c0573aab0a82a3634?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4911 +/- ## === Coverage 77.14% 77.14% === Files 44 44 Lines8539 8539 === Hits 6587 6587 Misses 1952 1952 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4911/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `52.69% <ø> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=footer). Last update [e1d2150...d850f31](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch opened a new issue #4912: Missing predefined metrics options in MetricsControls
mistercrunch opened a new issue #4912: Missing predefined metrics options in MetricsControls URL: https://github.com/apache/incubator-superset/issues/4912 @GabeLoins I noticed that many of the basic predefined metrics are not showing up in the dropdowns. This is easy to reproduce with most datasources (births does it) in the examples. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on a change in pull request #4760: URL shortner for dashboards
mistercrunch commented on a change in pull request #4760: URL shortner for
dashboards
URL:
https://github.com/apache/incubator-superset/pull/4760#discussion_r185149117
##
File path:
superset/assets/javascripts/explore/components/ExploreViewContainer.jsx
##
@@ -157,27 +151,6 @@ class ExploreViewContainer extends React.Component {
}
}
- addHistory({ isReplace = false, title }) {
Review comment:
@ttannis can we just keep `addHistory` as untouched as possible?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] betodealmeida opened a new pull request #4911: Fix for week_start_sunday and week_ending_saturday
betodealmeida opened a new pull request #4911: Fix for week_start_sunday and
week_ending_saturday
URL: https://github.com/apache/incubator-superset/pull/4911
The granularity options `week_ending_saturday` ("truncate forward til next
Saturday") and `week_start_sunday` ("truncate back til last Sunday") are not
working correctly. Currently the granularity dropdown has the same key (`P1W`,
one week) for `week`, `week_ending_saturday` and `week_start_sunday`, and only
the first one can be selected.
I fixed this bug by making the key unique. The ISO 8601 spec supports `time
intervals`, so I used `1969-12-28T00:00:00Z/P1W` to represent
`week_start_sunday` (since 1969-12-28 was a Sunday), and
`P1W/1970-01-03T00:00:00Z` to represent (week_ending_saturday` (since
1970-01-03 was a Saturday). This required modifying the `getPlaySliderParams`
function, since it parses the ISO duration in order to get its props.
I also added these two granularities to the SQLite backend, in order to test
it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #4910: Use React.PureComponent everywhere
codecov-io commented on issue #4910: Use React.PureComponent everywhere URL: https://github.com/apache/incubator-superset/pull/4910#issuecomment-385572529 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4910?src=pr=h1) Report > Merging [#4910](https://codecov.io/gh/apache/incubator-superset/pull/4910?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e1d2150391ba827a64cebd0c0573aab0a82a3634?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4910?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4910 +/- ## === Coverage 77.14% 77.14% === Files 44 44 Lines8539 8539 === Hits 6587 6587 Misses 1952 1952 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4910?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4910?src=pr=footer). Last update [e1d2150...fb7534b](https://codecov.io/gh/apache/incubator-superset/pull/4910?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4740: Add extraction function support for Druid queries
mistercrunch commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-385571371 @fabianmenges @john-bodley I'm identifying this PR as something that could break things in your environment but I can't really test it in my environment since we don't have a lot of charts on Druid at this point. Can you 2 review/greenlight this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
