[jira] [Commented] (TEPHRA-188) There should be a way to limit the transaction timeout

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TEPHRA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553926#comment-15553926
 ] 

ASF GitHub Bot commented on TEPHRA-188:
---

Github user poornachandra commented on the issue:

https://github.com/apache/incubator-tephra/pull/17
  
LGTM


> There should be a way to limit the transaction timeout
> --
>
> Key: TEPHRA-188
> URL: https://issues.apache.org/jira/browse/TEPHRA-188
> Project: Tephra
>  Issue Type: Improvement
>  Components: api, manager
>Affects Versions: 0.9.0-incubating
>Reporter: Andreas Neumann
>Assignee: Andreas Neumann
> Fix For: 0.10.0-incubating
>
>
> When clients start a transaction, they can give a custom timeout for the 
> transaction. If a client uses a really long timeout, then crashes and never 
> commits or invalidates, then this will remain an active transaction forever. 
> In some use cases, it is therefore desirable to impose a system-wide limit on 
> that timeout. 
> I am proposing to add a new property data.tx.max.timeout to the 
> configuration. This can be optional, but if set, it limits the custom 
> transaction timeout for startShort(int timeout). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-tephra issue #17: (TEPHRA-188) Allow to configure a limit for the ...

[poornachandra]

Github user poornachandra commented on the issue:

https://github.com/apache/incubator-tephra/pull/17
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tephra issue #17: (TEPHRA-188) Allow to configure a limit for the ...

[anew]

Github user anew commented on the issue:

https://github.com/apache/incubator-tephra/pull/17
  
@poornachandra I made the change. Please take another look. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tephra pull request #17: (TEPHRA-188) Allow to configure a limit f...

[anew]

Github user anew commented on a diff in the pull request:

https://github.com/apache/incubator-tephra/pull/17#discussion_r82313446
  
--- Diff: 
tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
@@ -722,7 +725,10 @@ public Transaction startShort() {
* @param timeoutInSeconds the time out period in seconds.
*/
   public Transaction startShort(int timeoutInSeconds) {
-Preconditions.checkArgument(timeoutInSeconds > 0, "timeout must be 
positive but is %s", timeoutInSeconds);
+Preconditions.checkArgument(timeoutInSeconds > 0,
+"timeout must be positive but is %s", 
timeoutInSeconds);
+Preconditions.checkArgument(timeoutInSeconds <= maxTimeout,
+"timeout must not exceed %s but is %s", 
maxTimeout, timeoutInSeconds);
--- End diff --

oh, good point. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TEPHRA-188) There should be a way to limit the transaction timeout

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TEPHRA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553582#comment-15553582
 ] 

ASF GitHub Bot commented on TEPHRA-188:
---

Github user poornachandra commented on a diff in the pull request:

https://github.com/apache/incubator-tephra/pull/17#discussion_r82304628
  
--- Diff: 
tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
@@ -722,7 +725,10 @@ public Transaction startShort() {
* @param timeoutInSeconds the time out period in seconds.
*/
   public Transaction startShort(int timeoutInSeconds) {
-Preconditions.checkArgument(timeoutInSeconds > 0, "timeout must be 
positive but is %s", timeoutInSeconds);
+Preconditions.checkArgument(timeoutInSeconds > 0,
+"timeout must be positive but is %s", 
timeoutInSeconds);
+Preconditions.checkArgument(timeoutInSeconds <= maxTimeout,
+"timeout must not exceed %s but is %s", 
maxTimeout, timeoutInSeconds);
--- End diff --

It would be good to add the units here


> There should be a way to limit the transaction timeout
> --
>
> Key: TEPHRA-188
> URL: https://issues.apache.org/jira/browse/TEPHRA-188
> Project: Tephra
>  Issue Type: Improvement
>  Components: api, manager
>Affects Versions: 0.9.0-incubating
>Reporter: Andreas Neumann
>Assignee: Andreas Neumann
> Fix For: 0.10.0-incubating
>
>
> When clients start a transaction, they can give a custom timeout for the 
> transaction. If a client uses a really long timeout, then crashes and never 
> commits or invalidates, then this will remain an active transaction forever. 
> In some use cases, it is therefore desirable to impose a system-wide limit on 
> that timeout. 
> I am proposing to add a new property data.tx.max.timeout to the 
> configuration. This can be optional, but if set, it limits the custom 
> transaction timeout for startShort(int timeout). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-tephra pull request #17: (TEPHRA-188) Allow to configure a limit f...

[poornachandra]

Github user poornachandra commented on a diff in the pull request:

https://github.com/apache/incubator-tephra/pull/17#discussion_r82304628
  
--- Diff: 
tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
@@ -722,7 +725,10 @@ public Transaction startShort() {
* @param timeoutInSeconds the time out period in seconds.
*/
   public Transaction startShort(int timeoutInSeconds) {
-Preconditions.checkArgument(timeoutInSeconds > 0, "timeout must be 
positive but is %s", timeoutInSeconds);
+Preconditions.checkArgument(timeoutInSeconds > 0,
+"timeout must be positive but is %s", 
timeoutInSeconds);
+Preconditions.checkArgument(timeoutInSeconds <= maxTimeout,
+"timeout must not exceed %s but is %s", 
maxTimeout, timeoutInSeconds);
--- End diff --

It would be good to add the units here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Proposing a new Apache Tephra logo

[Andreas Neumann]

Just recently Apache Spot went into incubation. It also features a dog as
the logo. Is that something to worry about?

http://spot.incubator.apache.org/

On Wed, Sep 14, 2016 at 2:02 PM, Gokul Gunasekaran  wrote:

> +1 on the new logo! Thank you Poorna.
>
> On Wed, Sep 14, 2016 at 11:03 AM, Poorna Chandra 
> wrote:
>
> > Hello all,
> >
> > One of the common feedback that we get when talking to users is that the
> > Apache Tephra logo is abstract, and does not immediately connect to the
> > project. Also the logo doesn't really fit in with the other projects in
> the
> > "zoo" of the Hadoop ecosystem.
> >
> > One of the things we have wanted to do for a while was to update the
> logo,
> > and with the recent move into incubator, we figured it was good timing to
> > develop and propose a new logo for the project moving forward.
> >
> > While designing the new logo, we thought it would be ideal for the new
> logo
> > to embrace an animal of some sort. In addition to an animal, we wanted it
> > to somehow connect back to what Tephra is all about: maintaining
> > consistency.
> >
> > There aren't many consistent things in the animal kingdom, but we honed
> in
> > around a particular idea. We've ended up in the current proposed logo
> > design with a dog (specifically, a border collie or similar herding
> breed).
> > The logo is attached to JIRA TEPHRA-183 [1]
> >
> > The notion is that a herding dog is used by a herder to maintain order
> and
> > consistency amongst the flock. It is in some way an enforcer of
> > consistency, under control of the herder, but in a way that abstracts
> much
> > of the hard work and details away from the herder.
> >
> > The dog in a stalking position shows it in action and enforcing order
> > across the herd.
> >
> > We are open to suggestions and improvements.
> >
> > The design was done by the in-house designer at Cask, and the logo and
> > rights will be donated to the ASF.
> >
> > Thanks,
> > Poorna.
> >
> > [1] - https://issues.apache.org/jira/browse/TEPHRA-183
> >
>

[GitHub] incubator-tephra pull request #17: (TEPHRA-188) Allow to configure a limit f...

[anew]

GitHub user anew opened a pull request:

https://github.com/apache/incubator-tephra/pull/17

(TEPHRA-188) Allow to configure a limit for the transaction timeout

the title says it all. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anew/incubator-tephra 
tephra-188-tx-timeout-limit

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-tephra/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #17






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TEPHRA-188) There should be a way to limit the transaction timeout

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TEPHRA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553389#comment-15553389
 ] 

ASF GitHub Bot commented on TEPHRA-188:
---

GitHub user anew opened a pull request:

https://github.com/apache/incubator-tephra/pull/17

(TEPHRA-188) Allow to configure a limit for the transaction timeout

the title says it all. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anew/incubator-tephra 
tephra-188-tx-timeout-limit

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-tephra/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #17






> There should be a way to limit the transaction timeout
> --
>
> Key: TEPHRA-188
> URL: https://issues.apache.org/jira/browse/TEPHRA-188
> Project: Tephra
>  Issue Type: Improvement
>  Components: api, manager
>Affects Versions: 0.9.0-incubating
>Reporter: Andreas Neumann
>Assignee: Andreas Neumann
> Fix For: 0.10.0-incubating
>
>
> When clients start a transaction, they can give a custom timeout for the 
> transaction. If a client uses a really long timeout, then crashes and never 
> commits or invalidates, then this will remain an active transaction forever. 
> In some use cases, it is therefore desirable to impose a system-wide limit on 
> that timeout. 
> I am proposing to add a new property data.tx.max.timeout to the 
> configuration. This can be optional, but if set, it limits the custom 
> transaction timeout for startShort(int timeout). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)