[jira] [Closed] (THRIFT-1233) Remove unused include in generated C++ code

[Jake Farrell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell closed THRIFT-1233.


   Resolution: Fixed
Fix Version/s: 0.7
 Assignee: Diwaker Gupta  (was: Jake Farrell)

Committed, thanks for the patch.

> Remove unused include in generated C++ code
> ---
>
> Key: THRIFT-1233
> URL: https://issues.apache.org/jira/browse/THRIFT-1233
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Compiler
> Environment: Ubuntu 11.04, latest trunk.
>Reporter: Diwaker Gupta
>Assignee: Diwaker Gupta
>Priority: Trivial
> Fix For: 0.7
>
> Attachments: THRIFT-1233.patch
>
>
> When using cob_style with the CPP generator, the compiler adds an include for 
> TTransportUtils. This include doesn't seem to be used anywhere and creates an 
> unnecessary dependency. It also complicates compiling Thrift generated code 
> on other platforms.
> Patch available for review here:
> https://reviews.apache.org/r/1034/

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: Javascript: gen:nodejs generated code works in the browser

[roger]

yes, we do that within the JavaScript test suite. It uses the Java  
Test Suite for the server side.


just execute the following commands:
cd lib/js/test/
ant (=> lint)
ant testserver (=> http://localhost:8088/test/test.html )


-Roger

Quoting Peter Neumark :


I confess I haven't been able to keep up with the current state of the
unified test suite initiative.
Is it possible to match a node.js test client with a test server written in
another language?

Peter

On Thu, Jul 14, 2011 at 7:05 AM,  wrote:


That's a cool feature Peter!

I would really like to have a aligned JavaScript and Node.js Thrift
implementation.
Today, lot of code is duplicated and I think it should be possible to use
the same lib for JavaScript and node.js

The following essentials are still missing for node.js:
Node.js Testsuite =>  
https://issues.apache.org/**jira/browse/THRIFT-1134
Node.js Tutorial =>  
https://issues.apache.org/**jira/browse/THRIFT-1135


It would be great to see some patches in that area!

Regards
Roger



Quoting Peter Neumark :

 Hi,


I've always through its sort of strange to have separate code generators
for
node.js and browser environments.
Since I'm trying to get the browser to work as a thrift server (responding
to requests coming from the webserver),
I need to use the node.js code generator.

I got a proof of concept working:
https://github.com/postlock/**thrift-over-socketio

Is anybody else interested in converging the browser/node.js javascript
libs
and code generator as much as possible?

Peter





--**--**
This message was sent using IMP, the Internet Messaging Program.









This message was sent using IMP, the Internet Messaging Program.

Re: Javascript: gen:nodejs generated code works in the browser

[Peter Neumark]

I confess I haven't been able to keep up with the current state of the
unified test suite initiative.
Is it possible to match a node.js test client with a test server written in
another language?

Peter

On Thu, Jul 14, 2011 at 7:05 AM,  wrote:

> That's a cool feature Peter!
>
> I would really like to have a aligned JavaScript and Node.js Thrift
> implementation.
> Today, lot of code is duplicated and I think it should be possible to use
> the same lib for JavaScript and node.js
>
> The following essentials are still missing for node.js:
> Node.js Testsuite => 
> https://issues.apache.org/**jira/browse/THRIFT-1134
> Node.js Tutorial => 
> https://issues.apache.org/**jira/browse/THRIFT-1135
>
> It would be great to see some patches in that area!
>
> Regards
> Roger
>
>
>
> Quoting Peter Neumark :
>
>  Hi,
>>
>> I've always through its sort of strange to have separate code generators
>> for
>> node.js and browser environments.
>> Since I'm trying to get the browser to work as a thrift server (responding
>> to requests coming from the webserver),
>> I need to use the node.js code generator.
>>
>> I got a proof of concept working:
>> https://github.com/postlock/**thrift-over-socketio
>>
>> Is anybody else interested in converging the browser/node.js javascript
>> libs
>> and code generator as much as possible?
>>
>> Peter
>>
>>
>
>
> --**--**
> This message was sent using IMP, the Internet Messaging Program.
>
>