[jira] [Commented] (THRIFT-1286) Modernize the Thrift Ruby Library Dev Environment
[ https://issues.apache.org/jira/browse/THRIFT-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13091005#comment-13091005 ] Jake Farrell commented on THRIFT-1286: -- patch does not apply cleanly. Merging your additions with my patch to make this all play nicely Modernize the Thrift Ruby Library Dev Environment - Key: THRIFT-1286 URL: https://issues.apache.org/jira/browse/THRIFT-1286 Project: Thrift Issue Type: Improvement Components: Ruby - Library Affects Versions: 0.7, 0.8 Reporter: Scott Gonyea Assignee: Jake Farrell Fix For: 0.7, 0.8 Attachments: thrift-1286.patch, thrift-1286.patch This fixes the ruby libraries environment. This introduces Bundler for managing the development environment, as well as in handling the Gem release process. Echoe is no longer present. The end result is that the development environment is easier to setup and easier to reproduce. Thus, easier to contribute to. This structures the spec folder to better follow conventions RSpec. The RSpec, as used in the ruby library, was using a mix of RSpec 1 and RSpec 2. This brings everything into the land of RSpec 2. Some additional cleanup could definitely be done, but this gets us out of the deprecation warnings and other weird behavior-ings. To run this in CI, however that is done, you'll effectively want the shell script (or whatever) to look like this: which bundle || gem install bundler bundle install bundle exec rake spec Patch should be pulled from: https://github.com/sgonyea/thrift/compare/apache:trunk...1fd22f135700c5d32244c63c164610f52b94619b or up to the commit: https://github.com/sgonyea/thrift/commit/1fd22f135700c5d32244c63c164610f52b94619b -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (THRIFT-1291) Severely outdated config.sub in 0.7 distribution
[
https://issues.apache.org/jira/browse/THRIFT-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell reassigned THRIFT-1291:
Assignee: Jake Farrell
Severely outdated config.sub in 0.7 distribution
Key: THRIFT-1291
URL: https://issues.apache.org/jira/browse/THRIFT-1291
Project: Thrift
Issue Type: Bug
Components: Build Process, Deployment
Affects Versions: 0.7
Reporter: Diwaker Gupta
Assignee: Jake Farrell
Attachments: config.sub.0.6, config.sub.0.7
The version of config.sub that is distributed with Thrift 0.7 seems to be
from 2003, whereas the one that shipped with 0.6 is from 2008. This is
breaking Thrift builds for us on non-standard platforms. For instance:
{noformat}
$ bash config.sub.0.6 arm-unknown-linux-uclibcgnueabi
arm-unknown-linux-uclibcgnueabi
$ bash config.sub.0.7 arm-unknown-linux-uclibcgnueabi
Invalid configuration `arm-unknown-linux-uclibcgnueabi': machine
`arm-unknown-linux' not recognized
{noformat}
The first few lines of the files are also instructive:
{noformat}
$ head -n 7 config.sub.0.6
#! /bin/sh
# Configuration validation subroutine script.
# Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
# 2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008
# Free Software Foundation, Inc.
timestamp='2008-01-16'
$ head -n 7 config.sub.0.7
#! /bin/sh
# Configuration validation subroutine script.
# Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
# 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
timestamp='2003-06-18'
{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1291) Severely outdated config.sub in 0.7 distribution
[
https://issues.apache.org/jira/browse/THRIFT-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13091045#comment-13091045
]
Jake Farrell commented on THRIFT-1291:
--
these files are auto-generated during the release process so they should always
be current. When I made the last two release I used autoconf 2.65 on centos.
0.6.1 shows a timestamp of '2003-06-18'. Something most likely is wrong with my
version on centos. Switching over to os x with autoconf 2.68 yields a correct
timestamp of '2009-04-17'. Will be using os x for future releases so should not
be an issue moving forward.
Severely outdated config.sub in 0.7 distribution
Key: THRIFT-1291
URL: https://issues.apache.org/jira/browse/THRIFT-1291
Project: Thrift
Issue Type: Bug
Components: Build Process, Deployment
Affects Versions: 0.7
Reporter: Diwaker Gupta
Assignee: Jake Farrell
Attachments: config.sub.0.6, config.sub.0.7
The version of config.sub that is distributed with Thrift 0.7 seems to be
from 2003, whereas the one that shipped with 0.6 is from 2008. This is
breaking Thrift builds for us on non-standard platforms. For instance:
{noformat}
$ bash config.sub.0.6 arm-unknown-linux-uclibcgnueabi
arm-unknown-linux-uclibcgnueabi
$ bash config.sub.0.7 arm-unknown-linux-uclibcgnueabi
Invalid configuration `arm-unknown-linux-uclibcgnueabi': machine
`arm-unknown-linux' not recognized
{noformat}
The first few lines of the files are also instructive:
{noformat}
$ head -n 7 config.sub.0.6
#! /bin/sh
# Configuration validation subroutine script.
# Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
# 2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008
# Free Software Foundation, Inc.
timestamp='2008-01-16'
$ head -n 7 config.sub.0.7
#! /bin/sh
# Configuration validation subroutine script.
# Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
# 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
timestamp='2003-06-18'
{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1267) Node.js can't throw exceptions.
[ https://issues.apache.org/jira/browse/THRIFT-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Duedal updated THRIFT-1267: Attachment: thrift-1267-callback.patch New patch, with callback(err, result) instead. Updated gist:1151782 usecase also. Should support syntax from gist:1098395 (Russel Haering) as well. Implemented it using instanceof and early returns. What do you think? Node.js can't throw exceptions. Key: THRIFT-1267 URL: https://issues.apache.org/jira/browse/THRIFT-1267 Project: Thrift Issue Type: Improvement Components: JavaScript - Compiler Affects Versions: 0.7 Reporter: Hans Duedal Labels: compiler, javascript, node, nodejs Fix For: 0.8 Attachments: nodejs-exception.patch, thrift-1267-callback.patch There is no way as far as I can tell for node.js servers to throw thrift exceptions. I have made a patch to allow it to throw exceptions. It lets the node.js server implementation give params directly to the result object, thereby being able to specify the exception. It doesn't affect normal (non exception) return data. Test case: https://gist.github.com/1151782 Install thrift module npm install thrift, generate thrift thrift --gen js:node test.thrift and run server then client. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1290) thrift: TNonblockingServer: clean up state in the
[ https://issues.apache.org/jira/browse/THRIFT-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Watson updated THRIFT-1290: Attachment: 0017-thrift-TNonblockingServer-clean-up-state-in-the-dest.patch-2 svn up'd, resolved conflict thrift: TNonblockingServer: clean up state in the --- Key: THRIFT-1290 URL: https://issues.apache.org/jira/browse/THRIFT-1290 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Priority: Minor Attachments: 0017-thrift-TNonblockingServer-clean-up-state-in-the-dest.patch, 0017-thrift-TNonblockingServer-clean-up-state-in-the-dest.patch-2 From cd9c1a10cb4df058fbdbed1b98a21a7a7470a28c Mon Sep 17 00:00:00 2001 From: Adam Simpkins simpk...@fb.com Date: Tue, 6 Apr 2010 20:43:23 + Subject: [PATCH 17/33] thrift: TNonblockingServer: clean up state in the destructor Summary: Implement the TNonblockingServer destructor, so that it closes the listen socket, destroys the event_base, and deletes any TConnections left in the connectionStack_. However, TNonblockingServer doesn't keep track of active TConnection objects, so those objects are still leaked. As part of this, I also changed the code to use event_init() rather than event_base_new(). This way we won't set the global event_base inside libevent, and we can be sure that no one else will be using it after the TNonblockingServer is destroyed. I grepped through all of [fb code base] to check for any other direct uses of event_set(), and didn't see any places that weren't also using event_base_set(). Therefore it seems like it should be safe to stop initializing the global event_base pointer. Test Plan: Tested with the test code in [a fb unittest], which creates, stops, and then deletes several TNonblockingServers. Ran it under valgrind, and now it only complains about any active connections being leaked. Revert Plan: OK --- lib/cpp/src/server/TNonblockingServer.cpp |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (THRIFT-1292) thrift: silence log spew from TThreadedServer
thrift: silence log spew from TThreadedServer --- Key: THRIFT-1292 URL: https://issues.apache.org/jira/browse/THRIFT-1292 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Priority: Minor From e8bd9a6d266df3ab811c7e1e23f2e1e28ad11f8c Mon Sep 17 00:00:00 2001 From: Adam Simpkins simpk...@fb.com Date: Tue, 6 Apr 2010 20:59:26 + Subject: [PATCH 18/33] thrift: silence log spew from TThreadedServer Summary: Stop logging messages when a client connection is closed. --- lib/cpp/src/server/TThreadedServer.cpp |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (THRIFT-1293) thrift: improve handling of exceptions thrown by
thrift: improve handling of exceptions thrown by -- Key: THRIFT-1293 URL: https://issues.apache.org/jira/browse/THRIFT-1293 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Priority: Minor Attachments: 0019-thrift-improve-handling-of-exceptions-thrown-by-proc.patch From 68ed500b994bbe3beeb2eb66e052c6af7ef3a72c Mon Sep 17 00:00:00 2001 From: Adam Simpkins simpk...@fb.com Date: Tue, 6 Apr 2010 20:59:29 + Subject: [PATCH 19/33] thrift: improve handling of exceptions thrown by process() Summary: Update the server code to print the exeption message for any std::exception that is thrown by process(), and not just TExceptions. Also print the exception type in the message. Test Plan: Used it to debug some broken code that was throwing std::length_error. (That turned out to just be a race condition in some of my test code.) Revert Plan: OK --- lib/cpp/src/server/TNonblockingServer.cpp | 25 ++--- lib/cpp/src/server/TSimpleServer.cpp |8 lib/cpp/src/server/TThreadPoolServer.cpp | 11 --- lib/cpp/src/server/TThreadedServer.cpp|8 4 files changed, 26 insertions(+), 26 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1292) thrift: silence log spew from TThreadedServer
[ https://issues.apache.org/jira/browse/THRIFT-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Watson updated THRIFT-1292: Attachment: 0018-thrift-silence-log-spew-from-TThreadedServer.patch thrift: silence log spew from TThreadedServer --- Key: THRIFT-1292 URL: https://issues.apache.org/jira/browse/THRIFT-1292 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Priority: Minor Attachments: 0018-thrift-silence-log-spew-from-TThreadedServer.patch From e8bd9a6d266df3ab811c7e1e23f2e1e28ad11f8c Mon Sep 17 00:00:00 2001 From: Adam Simpkins simpk...@fb.com Date: Tue, 6 Apr 2010 20:59:26 + Subject: [PATCH 18/33] thrift: silence log spew from TThreadedServer Summary: Stop logging messages when a client connection is closed. --- lib/cpp/src/server/TThreadedServer.cpp |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1293) thrift: improve handling of exceptions thrown by
[ https://issues.apache.org/jira/browse/THRIFT-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Watson updated THRIFT-1293: Attachment: 0019-thrift-improve-handling-of-exceptions-thrown-by-proc.patch thrift: improve handling of exceptions thrown by -- Key: THRIFT-1293 URL: https://issues.apache.org/jira/browse/THRIFT-1293 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Priority: Minor Attachments: 0019-thrift-improve-handling-of-exceptions-thrown-by-proc.patch From 68ed500b994bbe3beeb2eb66e052c6af7ef3a72c Mon Sep 17 00:00:00 2001 From: Adam Simpkins simpk...@fb.com Date: Tue, 6 Apr 2010 20:59:29 + Subject: [PATCH 19/33] thrift: improve handling of exceptions thrown by process() Summary: Update the server code to print the exeption message for any std::exception that is thrown by process(), and not just TExceptions. Also print the exception type in the message. Test Plan: Used it to debug some broken code that was throwing std::length_error. (That turned out to just be a race condition in some of my test code.) Revert Plan: OK --- lib/cpp/src/server/TNonblockingServer.cpp | 25 ++--- lib/cpp/src/server/TSimpleServer.cpp |8 lib/cpp/src/server/TThreadPoolServer.cpp | 11 --- lib/cpp/src/server/TThreadedServer.cpp|8 4 files changed, 26 insertions(+), 26 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1294) thrift: fix log message typos in TSimpleServer
[ https://issues.apache.org/jira/browse/THRIFT-1294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Watson updated THRIFT-1294: Attachment: 0020-thrift-fix-log-message-typos-in-TSimpleServer.patch thrift: fix log message typos in TSimpleServer Key: THRIFT-1294 URL: https://issues.apache.org/jira/browse/THRIFT-1294 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Priority: Minor Attachments: 0020-thrift-fix-log-message-typos-in-TSimpleServer.patch From 1cedaf9061760446e5c70de0797b93c3837e9841 Mon Sep 17 00:00:00 2001 From: Adam Simpkins simpk...@fb.com Date: Tue, 6 Apr 2010 20:59:32 + Subject: [PATCH 20/33] thrift: fix log message typos in TSimpleServer Summary: TSimpleSimple -- TSimpleServer Also cleaned up some references that could be const. Test Plan: It compiles. Revert Plan: OK --- lib/cpp/src/server/TSimpleServer.cpp | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1290) thrift: TNonblockingServer: clean up state in the
[ https://issues.apache.org/jira/browse/THRIFT-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury closed THRIFT-1290. - Resolution: Fixed Fix Version/s: 0.8 Assignee: Dave Watson I just committed this. thrift: TNonblockingServer: clean up state in the --- Key: THRIFT-1290 URL: https://issues.apache.org/jira/browse/THRIFT-1290 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Assignee: Dave Watson Priority: Minor Fix For: 0.8 Attachments: 0017-thrift-TNonblockingServer-clean-up-state-in-the-dest.patch, 0017-thrift-TNonblockingServer-clean-up-state-in-the-dest.patch-2 From cd9c1a10cb4df058fbdbed1b98a21a7a7470a28c Mon Sep 17 00:00:00 2001 From: Adam Simpkins simpk...@fb.com Date: Tue, 6 Apr 2010 20:43:23 + Subject: [PATCH 17/33] thrift: TNonblockingServer: clean up state in the destructor Summary: Implement the TNonblockingServer destructor, so that it closes the listen socket, destroys the event_base, and deletes any TConnections left in the connectionStack_. However, TNonblockingServer doesn't keep track of active TConnection objects, so those objects are still leaked. As part of this, I also changed the code to use event_init() rather than event_base_new(). This way we won't set the global event_base inside libevent, and we can be sure that no one else will be using it after the TNonblockingServer is destroyed. I grepped through all of [fb code base] to check for any other direct uses of event_set(), and didn't see any places that weren't also using event_base_set(). Therefore it seems like it should be safe to stop initializing the global event_base pointer. Test Plan: Tested with the test code in [a fb unittest], which creates, stops, and then deletes several TNonblockingServers. Ran it under valgrind, and now it only complains about any active connections being leaked. Revert Plan: OK --- lib/cpp/src/server/TNonblockingServer.cpp |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1292) thrift: silence log spew from TThreadedServer
[ https://issues.apache.org/jira/browse/THRIFT-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury closed THRIFT-1292. - Resolution: Fixed Fix Version/s: 0.8 Assignee: Dave Watson I just committed this. thrift: silence log spew from TThreadedServer --- Key: THRIFT-1292 URL: https://issues.apache.org/jira/browse/THRIFT-1292 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Assignee: Dave Watson Priority: Minor Fix For: 0.8 Attachments: 0018-thrift-silence-log-spew-from-TThreadedServer.patch From e8bd9a6d266df3ab811c7e1e23f2e1e28ad11f8c Mon Sep 17 00:00:00 2001 From: Adam Simpkins simpk...@fb.com Date: Tue, 6 Apr 2010 20:59:26 + Subject: [PATCH 18/33] thrift: silence log spew from TThreadedServer Summary: Stop logging messages when a client connection is closed. --- lib/cpp/src/server/TThreadedServer.cpp |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1294) thrift: fix log message typos in TSimpleServer
[ https://issues.apache.org/jira/browse/THRIFT-1294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury closed THRIFT-1294. - Resolution: Fixed Fix Version/s: 0.8 Assignee: Dave Watson I just committed this. thrift: fix log message typos in TSimpleServer Key: THRIFT-1294 URL: https://issues.apache.org/jira/browse/THRIFT-1294 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Assignee: Dave Watson Priority: Minor Fix For: 0.8 Attachments: 0020-thrift-fix-log-message-typos-in-TSimpleServer.patch From 1cedaf9061760446e5c70de0797b93c3837e9841 Mon Sep 17 00:00:00 2001 From: Adam Simpkins simpk...@fb.com Date: Tue, 6 Apr 2010 20:59:32 + Subject: [PATCH 20/33] thrift: fix log message typos in TSimpleServer Summary: TSimpleSimple -- TSimpleServer Also cleaned up some references that could be const. Test Plan: It compiles. Revert Plan: OK --- lib/cpp/src/server/TSimpleServer.cpp | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Build failed in Jenkins: Thrift #235
See https://builds.apache.org/job/Thrift/235/changes Changes: [bryanduxbury] THRIFT-1293. cpp: improve handling of exceptions thrown by process() Patch: Adam Simpkins [bryanduxbury] THRIFT-1292. cpp: silence log spew from TThreadedServer Patch: Adam Simpkins [bryanduxbury] THRIFT-1290. cpp: TNonblockingServer: clean up state in the destructor Patch: Adam Simpkins -- [...truncated 2093 lines...] /home/hudson/tools/ant/latest/bin/ant -Dtest.junit.output.format=xml test Buildfile: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build.xml generate: check-gjslint: [echo] check if gjslint is available: [exec] Execute failed: java.io.IOException: Cannot run program gjslint: java.io.IOException: error=2, No such file or directory gjslint: resolve: [copy] Copying 36 files to https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/lib jslint: lint: dependencies: init: [mkdir] Created dir: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js/lib [mkdir] Created dir: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/log [mkdir] Created dir: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/test [mkdir] Created dir: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/test/log xvfb: [echo] check if Xvfb is available: [exec] Result: 1 phantomjs: [echo] check if phantomjs is available: [exec] Execute failed: java.io.IOException: Cannot run program phantomjs: java.io.IOException: error=2, No such file or directory compile: [javac] Compiling 21 source files to https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/test [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. [javac] Compiling 1 source file to https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/test [javac] Note: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/src/test/Httpd.java uses or overrides a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] Note: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/src/test/Httpd.java uses unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. jstest: [jar] Building jar: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/jstest.jar proxy: jslibs: [get] Getting: http://code.jquery.com/jquery-1.5.2.js [get] To: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js/lib/jquery-1.5.2.js [get] Getting: http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/equiv.js [get] To: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js/lib/equiv.js [get] Getting: http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/QUnitAdapter.js [get] To: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js/lib/QUnitAdapter.js [get] Getting: http://code.jquery.com/qunit/git/qunit.js [get] To: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js/lib/qunit.js [get] Getting: http://code.jquery.com/qunit/git/qunit.css [get] To: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js/lib/qunit.css [copy] Copying 1 file to https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js unittest: test: BUILD SUCCESSFUL Total time: 10 seconds make[3]: Leaving directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test' make[2]: Leaving directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test' Making check in py make[2]: Entering directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/py' /usr/bin/python setup.py build running build running build_py running build_ext make check-local make[3]: Entering directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/py' /usr/bin/python setup.py build running build running build_py running build_ext make[3]: Leaving directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/py' make[2]: Leaving directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/py' Making check in erl make[2]: Entering directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/erl' ./rebar eunit == erl (eunit) Compiled src/thrift_transport.erl Compiled src/thrift_service.erl Compiled src/thrift_protocol.erl Compiled test/constantsDemo_types.erl Compiled test/thriftTest_types.erl Compiled test/inherited_thrift.erl Compiled test/manyTypedefs_types.erl Compiled test/service_thrift.erl Compiled test/yowza_thrift.erl Compiled test/emptyService_thrift.erl Compiled test/test_client.erl Compiled test/thrift1151_types.erl Compiled test/reverseOrderService_thrift.erl Compiled test/smallService_thrift.erl Compiled test/test_disklog.erl Compiled test/aService_thrift.erl
[jira] [Commented] (THRIFT-1293) thrift: improve handling of exceptions thrown by
[ https://issues.apache.org/jira/browse/THRIFT-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13091165#comment-13091165 ] Hudson commented on THRIFT-1293: Integrated in Thrift #235 (See [https://builds.apache.org/job/Thrift/235/]) THRIFT-1293. cpp: improve handling of exceptions thrown by process() Patch: Adam Simpkins bryanduxbury : http://svn.apache.org/viewvc/?view=revrev=1161660 Files : * /thrift/trunk/lib/cpp/src/server/TNonblockingServer.cpp * /thrift/trunk/lib/cpp/src/server/TSimpleServer.cpp * /thrift/trunk/lib/cpp/src/server/TThreadPoolServer.cpp * /thrift/trunk/lib/cpp/src/server/TThreadedServer.cpp thrift: improve handling of exceptions thrown by -- Key: THRIFT-1293 URL: https://issues.apache.org/jira/browse/THRIFT-1293 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Assignee: Dave Watson Priority: Minor Fix For: 0.8 Attachments: 0019-thrift-improve-handling-of-exceptions-thrown-by-proc.patch From 68ed500b994bbe3beeb2eb66e052c6af7ef3a72c Mon Sep 17 00:00:00 2001 From: Adam Simpkins simpk...@fb.com Date: Tue, 6 Apr 2010 20:59:29 + Subject: [PATCH 19/33] thrift: improve handling of exceptions thrown by process() Summary: Update the server code to print the exeption message for any std::exception that is thrown by process(), and not just TExceptions. Also print the exception type in the message. Test Plan: Used it to debug some broken code that was throwing std::length_error. (That turned out to just be a race condition in some of my test code.) Revert Plan: OK --- lib/cpp/src/server/TNonblockingServer.cpp | 25 ++--- lib/cpp/src/server/TSimpleServer.cpp |8 lib/cpp/src/server/TThreadPoolServer.cpp | 11 --- lib/cpp/src/server/TThreadedServer.cpp|8 4 files changed, 26 insertions(+), 26 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1292) thrift: silence log spew from TThreadedServer
[ https://issues.apache.org/jira/browse/THRIFT-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13091166#comment-13091166 ] Hudson commented on THRIFT-1292: Integrated in Thrift #235 (See [https://builds.apache.org/job/Thrift/235/]) THRIFT-1292. cpp: silence log spew from TThreadedServer Patch: Adam Simpkins bryanduxbury : http://svn.apache.org/viewvc/?view=revrev=1161659 Files : * /thrift/trunk/lib/cpp/src/server/TThreadedServer.cpp thrift: silence log spew from TThreadedServer --- Key: THRIFT-1292 URL: https://issues.apache.org/jira/browse/THRIFT-1292 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Assignee: Dave Watson Priority: Minor Fix For: 0.8 Attachments: 0018-thrift-silence-log-spew-from-TThreadedServer.patch From e8bd9a6d266df3ab811c7e1e23f2e1e28ad11f8c Mon Sep 17 00:00:00 2001 From: Adam Simpkins simpk...@fb.com Date: Tue, 6 Apr 2010 20:59:26 + Subject: [PATCH 18/33] thrift: silence log spew from TThreadedServer Summary: Stop logging messages when a client connection is closed. --- lib/cpp/src/server/TThreadedServer.cpp |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1290) thrift: TNonblockingServer: clean up state in the
[ https://issues.apache.org/jira/browse/THRIFT-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13091167#comment-13091167 ] Hudson commented on THRIFT-1290: Integrated in Thrift #235 (See [https://builds.apache.org/job/Thrift/235/]) THRIFT-1290. cpp: TNonblockingServer: clean up state in the destructor Patch: Adam Simpkins bryanduxbury : http://svn.apache.org/viewvc/?view=revrev=1161655 Files : * /thrift/trunk/lib/cpp/src/server/TNonblockingServer.cpp thrift: TNonblockingServer: clean up state in the --- Key: THRIFT-1290 URL: https://issues.apache.org/jira/browse/THRIFT-1290 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Assignee: Dave Watson Priority: Minor Fix For: 0.8 Attachments: 0017-thrift-TNonblockingServer-clean-up-state-in-the-dest.patch, 0017-thrift-TNonblockingServer-clean-up-state-in-the-dest.patch-2 From cd9c1a10cb4df058fbdbed1b98a21a7a7470a28c Mon Sep 17 00:00:00 2001 From: Adam Simpkins simpk...@fb.com Date: Tue, 6 Apr 2010 20:43:23 + Subject: [PATCH 17/33] thrift: TNonblockingServer: clean up state in the destructor Summary: Implement the TNonblockingServer destructor, so that it closes the listen socket, destroys the event_base, and deletes any TConnections left in the connectionStack_. However, TNonblockingServer doesn't keep track of active TConnection objects, so those objects are still leaked. As part of this, I also changed the code to use event_init() rather than event_base_new(). This way we won't set the global event_base inside libevent, and we can be sure that no one else will be using it after the TNonblockingServer is destroyed. I grepped through all of [fb code base] to check for any other direct uses of event_set(), and didn't see any places that weren't also using event_base_set(). Therefore it seems like it should be safe to stop initializing the global event_base pointer. Test Plan: Tested with the test code in [a fb unittest], which creates, stops, and then deletes several TNonblockingServers. Ran it under valgrind, and now it only complains about any active connections being leaked. Revert Plan: OK --- lib/cpp/src/server/TNonblockingServer.cpp |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Build failed in Jenkins: Thrift #236
See https://builds.apache.org/job/Thrift/236/changes Changes: [bryanduxbury] THRIFT-1294. cpp: fix log message typos in TSimpleServer Patch: Adam Simpkins -- [...truncated 2095 lines...] make check-local make[3]: Entering directory `/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test' /home/hudson/tools/ant/latest/bin/ant -Dtest.junit.output.format=xml test Buildfile: /x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build.xml generate: check-gjslint: [echo] check if gjslint is available: [exec] Execute failed: java.io.IOException: Cannot run program gjslint: java.io.IOException: error=2, No such file or directory gjslint: resolve: [copy] Copying 36 files to /x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/lib jslint: lint: dependencies: init: [mkdir] Created dir: /x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js/lib [mkdir] Created dir: /x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/log [mkdir] Created dir: /x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/test [mkdir] Created dir: /x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/test/log xvfb: [echo] check if Xvfb is available: [exec] Result: 1 phantomjs: [echo] check if phantomjs is available: [exec] Execute failed: java.io.IOException: Cannot run program phantomjs: java.io.IOException: error=2, No such file or directory compile: [javac] Compiling 21 source files to /x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/test [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. [javac] Compiling 1 source file to /x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/test [javac] Note: /x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/src/test/Httpd.java uses or overrides a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] Note: /x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/src/test/Httpd.java uses unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. jstest: [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/jstest.jar proxy: jslibs: [get] Getting: http://code.jquery.com/jquery-1.5.2.js [get] To: /x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js/lib/jquery-1.5.2.js [get] Getting: http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/equiv.js [get] To: /x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js/lib/equiv.js [get] Getting: http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/QUnitAdapter.js [get] To: /x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js/lib/QUnitAdapter.js [get] Getting: http://code.jquery.com/qunit/git/qunit.js [get] To: /x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js/lib/qunit.js [get] Getting: http://code.jquery.com/qunit/git/qunit.css [get] To: /x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js/lib/qunit.css [copy] Copying 1 file to /x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js unittest: test: BUILD SUCCESSFUL Total time: 10 seconds make[3]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test' make[2]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test' Making check in py make[2]: Entering directory `/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/py' /usr/bin/python setup.py build running build running build_py running build_ext make check-local make[3]: Entering directory `/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/py' /usr/bin/python setup.py build running build running build_py running build_ext make[3]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/py' make[2]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/py' Making check in erl make[2]: Entering directory `/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/erl' ./rebar eunit == erl (eunit) Compiled src/thrift_protocol.erl Compiled src/thrift_transport.erl Compiled src/thrift_service.erl Compiled test/smallService_thrift.erl Compiled test/smallTest_types.erl Compiled test/inherited_thrift.erl Compiled test/aService_thrift.erl Compiled test/stressTest_types.erl Compiled test/debugProtoTest_types.erl Compiled test/test_client.erl Compiled test/yowza_thrift.erl Compiled test/annotationTest_types.erl Compiled test/test_thrift_1151.erl Compiled test/denseLinkingTest_types.erl Compiled test/javaBeansTest_types.erl Compiled test/secondService_thrift.erl Compiled
[jira] [Commented] (THRIFT-1294) thrift: fix log message typos in TSimpleServer
[ https://issues.apache.org/jira/browse/THRIFT-1294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13091186#comment-13091186 ] Hudson commented on THRIFT-1294: Integrated in Thrift #236 (See [https://builds.apache.org/job/Thrift/236/]) THRIFT-1294. cpp: fix log message typos in TSimpleServer Patch: Adam Simpkins bryanduxbury : http://svn.apache.org/viewvc/?view=revrev=1161663 Files : * /thrift/trunk/lib/cpp/src/server/TSimpleServer.cpp thrift: fix log message typos in TSimpleServer Key: THRIFT-1294 URL: https://issues.apache.org/jira/browse/THRIFT-1294 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Assignee: Dave Watson Priority: Minor Fix For: 0.8 Attachments: 0020-thrift-fix-log-message-typos-in-TSimpleServer.patch From 1cedaf9061760446e5c70de0797b93c3837e9841 Mon Sep 17 00:00:00 2001 From: Adam Simpkins simpk...@fb.com Date: Tue, 6 Apr 2010 20:59:32 + Subject: [PATCH 20/33] thrift: fix log message typos in TSimpleServer Summary: TSimpleSimple -- TSimpleServer Also cleaned up some references that could be const. Test Plan: It compiles. Revert Plan: OK --- lib/cpp/src/server/TSimpleServer.cpp | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1286) Modernize the Thrift Ruby Library Dev Environment
[ https://issues.apache.org/jira/browse/THRIFT-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Gonyea updated THRIFT-1286: - Attachment: thrift-1286.patch Updated patch Modernize the Thrift Ruby Library Dev Environment - Key: THRIFT-1286 URL: https://issues.apache.org/jira/browse/THRIFT-1286 Project: Thrift Issue Type: Improvement Components: Ruby - Library Affects Versions: 0.7, 0.8 Reporter: Scott Gonyea Assignee: Jake Farrell Fix For: 0.7, 0.8 Attachments: thrift-1286.patch, thrift-1286.patch, thrift-1286.patch This fixes the ruby libraries environment. This introduces Bundler for managing the development environment, as well as in handling the Gem release process. Echoe is no longer present. The end result is that the development environment is easier to setup and easier to reproduce. Thus, easier to contribute to. This structures the spec folder to better follow conventions RSpec. The RSpec, as used in the ruby library, was using a mix of RSpec 1 and RSpec 2. This brings everything into the land of RSpec 2. Some additional cleanup could definitely be done, but this gets us out of the deprecation warnings and other weird behavior-ings. To run this in CI, however that is done, you'll effectively want the shell script (or whatever) to look like this: which bundle || gem install bundler bundle install bundle exec rake spec Patch should be pulled from: https://github.com/sgonyea/thrift/compare/apache:trunk...1fd22f135700c5d32244c63c164610f52b94619b or up to the commit: https://github.com/sgonyea/thrift/commit/1fd22f135700c5d32244c63c164610f52b94619b -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Build failed in Jenkins: Thrift #237
See https://builds.apache.org/job/Thrift/237/changes Changes: [jfarrell] Thrift-1295: Duplicate include in TSocket.cpp Client: cpp Patch: Diwaker Gupta TSocket.cpp includes netdb.in which is already included by TSocket.h. -- [...truncated 2089 lines...] make check-local make[3]: Entering directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test' /home/hudson/tools/ant/latest/bin/ant -Dtest.junit.output.format=xml test Buildfile: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build.xml generate: check-gjslint: [echo] check if gjslint is available: [exec] Execute failed: java.io.IOException: Cannot run program gjslint: java.io.IOException: error=2, No such file or directory gjslint: resolve: [copy] Copying 36 files to https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/lib jslint: lint: dependencies: init: [mkdir] Created dir: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js/lib [mkdir] Created dir: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/log [mkdir] Created dir: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/test [mkdir] Created dir: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/test/log xvfb: [echo] check if Xvfb is available: [exec] Result: 1 phantomjs: [echo] check if phantomjs is available: [exec] Execute failed: java.io.IOException: Cannot run program phantomjs: java.io.IOException: error=2, No such file or directory compile: [javac] Compiling 21 source files to https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/test [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. [javac] Compiling 1 source file to https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/test [javac] Note: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/src/test/Httpd.java uses or overrides a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] Note: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/src/test/Httpd.java uses unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. jstest: [jar] Building jar: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/jstest.jar proxy: jslibs: [get] Getting: http://code.jquery.com/jquery-1.5.2.js [get] To: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js/lib/jquery-1.5.2.js [get] Getting: http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/equiv.js [get] To: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js/lib/equiv.js [get] Getting: http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/QUnitAdapter.js [get] To: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js/lib/QUnitAdapter.js [get] Getting: http://code.jquery.com/qunit/git/qunit.js [get] To: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js/lib/qunit.js [get] Getting: http://code.jquery.com/qunit/git/qunit.css [get] To: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js/lib/qunit.css [copy] Copying 1 file to https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js unittest: test: BUILD SUCCESSFUL Total time: 9 seconds make[3]: Leaving directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test' make[2]: Leaving directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test' Making check in py make[2]: Entering directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/py' /usr/bin/python setup.py build running build running build_py running build_ext make check-local make[3]: Entering directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/py' /usr/bin/python setup.py build running build running build_py running build_ext make[3]: Leaving directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/py' make[2]: Leaving directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/py' Making check in erl make[2]: Entering directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/erl' ./rebar eunit == erl (eunit) Compiled src/thrift_transport.erl Compiled src/thrift_service.erl Compiled src/thrift_protocol.erl Compiled test/constantsDemo_types.erl Compiled test/thriftTest_types.erl Compiled test/inherited_thrift.erl Compiled test/service_thrift.erl Compiled test/manyTypedefs_types.erl Compiled test/yowza_thrift.erl Compiled test/test_client.erl Compiled test/emptyService_thrift.erl Compiled test/thrift1151_types.erl Compiled test/test_disklog.erl Compiled test/reverseOrderService_thrift.erl Compiled test/smallService_thrift.erl Compiled test/aService_thrift.erl Compiled test/test_membuffer.erl Compiled
[jira] [Commented] (THRIFT-1295) Duplicate include in TSocket.cpp
[
https://issues.apache.org/jira/browse/THRIFT-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13091362#comment-13091362
]
Hudson commented on THRIFT-1295:
Integrated in Thrift #237 (See [https://builds.apache.org/job/Thrift/237/])
Thrift-1295: Duplicate include in TSocket.cpp
Client: cpp
Patch: Diwaker Gupta
TSocket.cpp includes netdb.in which is already included by TSocket.h.
Duplicate include in TSocket.cpp
Key: THRIFT-1295
URL: https://issues.apache.org/jira/browse/THRIFT-1295
Project: Thrift
Issue Type: Improvement
Components: C++ - Library
Affects Versions: 0.7
Reporter: Diwaker Gupta
Assignee: Diwaker Gupta
Priority: Trivial
Fix For: 0.8
TSocket.cpp includes netdb.in which is already included by TSocket.h. Trivial
diff:
{noformat}
--- lib/cpp/src/transport/TSocket.cpp
+++ lib/cpp/src/transport/TSocket.cpp
@@ -27,7 +27,6 @@
#include arpa/inet.h
#include netinet/in.h
#include netinet/tcp.h
-#include netdb.h
#include unistd.h
#include errno.h
#include fcntl.h
{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Build failed in Jenkins: Thrift #238
See https://builds.apache.org/job/Thrift/238/changes Changes: [jfarrell] Thrift-1240: TBinarySerializer.php invalid serialization due to TBufferTransport not flushing last chunk of data into TMemoryBuffer Client: php Patch: Marimuthu Ponnambalam Simple Serialization errors out, due to the TBufferTransport not flushing the data into TMemoryBuffer after $object-write($protocol) in TBinarySerializer. -- [...truncated 2092 lines...] Making check in js/test make[2]: Entering directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test' make check-local make[3]: Entering directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test' /home/hudson/tools/ant/latest/bin/ant -Dtest.junit.output.format=xml test Buildfile: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build.xml generate: check-gjslint: [echo] check if gjslint is available: [exec] Execute failed: java.io.IOException: Cannot run program gjslint: java.io.IOException: error=2, No such file or directory gjslint: resolve: [copy] Copying 36 files to https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/lib jslint: lint: dependencies: init: [mkdir] Created dir: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js/lib [mkdir] Created dir: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/log [mkdir] Created dir: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/test [mkdir] Created dir: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/test/log xvfb: [echo] check if Xvfb is available: [exec] Execute failed: java.io.IOException: Cannot run program Xvfb: java.io.IOException: error=2, No such file or directory phantomjs: compile: [javac] Compiling 21 source files to https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/test [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. [javac] Compiling 1 source file to https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/test [javac] Note: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/src/test/Httpd.java uses or overrides a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] Note: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/src/test/Httpd.java uses unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. jstest: [jar] Building jar: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/jstest.jar proxy: jslibs: [get] Getting: http://code.jquery.com/jquery-1.5.2.js [get] To: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js/lib/jquery-1.5.2.js [get] Getting: http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/equiv.js [get] To: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js/lib/equiv.js [get] Getting: http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/QUnitAdapter.js [get] To: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js/lib/QUnitAdapter.js [get] Getting: http://code.jquery.com/qunit/git/qunit.js [get] To: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js/lib/qunit.js [get] Getting: http://code.jquery.com/qunit/git/qunit.css [get] To: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js/lib/qunit.css [copy] Copying 1 file to https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js unittest: test: BUILD SUCCESSFUL Total time: 9 seconds make[3]: Leaving directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test' make[2]: Leaving directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test' Making check in py make[2]: Entering directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/py' /usr/bin/python setup.py build running build running build_py running build_ext make check-local make[3]: Entering directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/py' /usr/bin/python setup.py build running build running build_py running build_ext make[3]: Leaving directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/py' make[2]: Leaving directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/py' Making check in erl make[2]: Entering directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/erl' ./rebar eunit == erl (eunit) Compiled src/thrift_protocol.erl Compiled src/thrift_service.erl Compiled src/thrift_transport.erl Compiled test/serviceForExceptionWithAMap_thrift.erl Compiled test/emptyService_thrift.erl Compiled test/test_disklog.erl Compiled test/test_thrift_1151.erl Compiled test/stress_server.erl Compiled test/service_thrift.erl Compiled test/test_server.erl Compiled
