[jira] [Closed] (THRIFT-1308) libfb303-0.7.0.jar missing in maven repository

[Jake Farrell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell closed THRIFT-1308.


   Resolution: Fixed
Fix Version/s: 0.7

repository.apache.org


  org.apache.thrift
  libfb303
  0.7.0
  pom


> libfb303-0.7.0.jar missing in maven repository
> --
>
> Key: THRIFT-1308
> URL: https://issues.apache.org/jira/browse/THRIFT-1308
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Affects Versions: 0.7
>Reporter: Carl Steinbach
>Assignee: Jake Farrell
> Fix For: 0.7
>
>
> It looks like libfb303 was published to maven repositories for the 0.6.1 
> release,
> but I don't see any libfb303 artifacts available for the 0.7.0 release.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (THRIFT-1308) libfb303-0.7.0.jar missing in maven repository

[Jake Farrell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell reassigned THRIFT-1308:


Assignee: Jake Farrell

> libfb303-0.7.0.jar missing in maven repository
> --
>
> Key: THRIFT-1308
> URL: https://issues.apache.org/jira/browse/THRIFT-1308
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Affects Versions: 0.7
>Reporter: Carl Steinbach
>Assignee: Jake Farrell
>
> It looks like libfb303 was published to maven repositories for the 0.6.1 
> release,
> but I don't see any libfb303 artifacts available for the 0.7.0 release.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1307) Add compression to Thrift

[Jake Farrell (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093316#comment-13093316
 ] 

Jake Farrell commented on THRIFT-1307:
--

The plugin interface was just a thought for 3rd party items like snappy to be 
able to easily interact with any existing transport. A wrapper transport, like 
zlib, would be the way to accomplish this right now

> Add compression to Thrift
> -
>
> Key: THRIFT-1307
> URL: https://issues.apache.org/jira/browse/THRIFT-1307
> Project: Thrift
>  Issue Type: New Feature
>  Components: Java - Library
>Reporter: Jerome Boulon
>
> Thrift output could be compressed on the fly similar to what Tomcat/Apache 
> are doing.
> But instead of using Gzip, since performance matter more than the compression 
> ratio, Snappy could be used.
> Snappy: http://code.google.com/p/snappy/
> Snappy is written in C++, but Java bindings are included

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (THRIFT-1309) libfb303-0.7.0.jar missing in maven repository

[Jake Farrell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell closed THRIFT-1309.


   Resolution: Duplicate
Fix Version/s: 0.8

Duplicates Thrift-1308

> libfb303-0.7.0.jar missing in maven repository
> --
>
> Key: THRIFT-1309
> URL: https://issues.apache.org/jira/browse/THRIFT-1309
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Affects Versions: 0.7
>Reporter: Carl Steinbach
> Fix For: 0.8
>
>
> It looks like libfb303 was published to maven repositories for the 0.6.1 
> release,
> but I don't see any libfb303 artifacts available for the 0.7.0 release.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1308) libfb303-0.7.0.jar missing in maven repository

[Carl Steinbach (JIRA)]

libfb303-0.7.0.jar missing in maven repository
--

 Key: THRIFT-1308
 URL: https://issues.apache.org/jira/browse/THRIFT-1308
 Project: Thrift
  Issue Type: Bug
  Components: Build Process
Affects Versions: 0.7
Reporter: Carl Steinbach


It looks like libfb303 was published to maven repositories for the 0.6.1 
release,
but I don't see any libfb303 artifacts available for the 0.7.0 release.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1309) libfb303-0.7.0.jar missing in maven repository

[Carl Steinbach (JIRA)]

libfb303-0.7.0.jar missing in maven repository
--

 Key: THRIFT-1309
 URL: https://issues.apache.org/jira/browse/THRIFT-1309
 Project: Thrift
  Issue Type: Bug
  Components: Build Process
Affects Versions: 0.7
Reporter: Carl Steinbach


It looks like libfb303 was published to maven repositories for the 0.6.1 
release,
but I don't see any libfb303 artifacts available for the 0.7.0 release.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1309) libfb303-0.7.0.jar missing in maven repository

[Carl Steinbach (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093311#comment-13093311
 ] 

Carl Steinbach commented on THRIFT-1309:


Reference: http://mvnrepository.com/artifact/org.apache.thrift

> libfb303-0.7.0.jar missing in maven repository
> --
>
> Key: THRIFT-1309
> URL: https://issues.apache.org/jira/browse/THRIFT-1309
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Affects Versions: 0.7
>Reporter: Carl Steinbach
>
> It looks like libfb303 was published to maven repositories for the 0.6.1 
> release,
> but I don't see any libfb303 artifacts available for the 0.7.0 release.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1307) Add compression to Thrift

[David Nadlinger (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093275#comment-13093275
 ] 

David Nadlinger commented on THRIFT-1307:
-

Why would a new plugin interface be needed for this? Can't this just be 
implemented with a »wrapper« transport like e.g. zlib for C++?

> Add compression to Thrift
> -
>
> Key: THRIFT-1307
> URL: https://issues.apache.org/jira/browse/THRIFT-1307
> Project: Thrift
>  Issue Type: New Feature
>  Components: Java - Library
>Reporter: Jerome Boulon
>
> Thrift output could be compressed on the fly similar to what Tomcat/Apache 
> are doing.
> But instead of using Gzip, since performance matter more than the compression 
> ratio, Snappy could be used.
> Snappy: http://code.google.com/p/snappy/
> Snappy is written in C++, but Java bindings are included

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1143) Build doesn't detect correct architecture type on 64bit osx

[Jake Farrell (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093248#comment-13093248
 ] 

Jake Farrell commented on THRIFT-1143:
--

Still a known issue with OS X 10.6, distutils still doesnt have a good solution 
for this either http://bugs.python.org/issue11623 . ARCHFLAGS="-arch x86_64" 
flag for OS X users is still the best approach to fix when needed, I dont think 
attaching to GOARCH as initially patched against is the best approach to 
solving this.

> Build doesn't detect correct architecture type on 64bit osx
> ---
>
> Key: THRIFT-1143
> URL: https://issues.apache.org/jira/browse/THRIFT-1143
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Affects Versions: 0.5
> Environment: OSX Snow leopard 64 bit
>Reporter: Jonathan Evans
>Assignee: Jake Farrell
>  Labels: build, mac, osx, x86_64
> Attachments: thrift-1143.patch
>
>
> python setup.py install
> running install
> running build
> running build_py
> running build_ext
> building 'thrift.protocol.fastbinary' extension
> gcc-4.2 -fno-strict-aliasing -fno-common -dynamic -DNDEBUG -g -fwrapv -Os 
> -Wall -Wstrict-prototypes -DENABLE_DTRACE -arch i386 -arch ppc -arch x86_64 
> -pipe 
> -I/System/Library/Frameworks/Python.framework/Versions/2.6/include/python2.6 
> -c src/protocol/fastbinary.c -o 
> build/temp.macosx-10.6-universal-2.6/src/protocol/fastbinary.o
> /usr/libexec/gcc/powerpc-apple-darwin10/4.2.1/as: assembler 
> (/usr/bin/../libexec/gcc/darwin/ppc/as or 
> /usr/bin/../local/libexec/gcc/darwin/ppc/as) for architecture ppc not 
> installed
> Installed assemblers are:
> /usr/bin/../libexec/gcc/darwin/x86_64/as for architecture x86_64
> /usr/bin/../libexec/gcc/darwin/i386/as for architecture i386
> src/protocol/fastbinary.c:1203: fatal error: error writing to -: Broken pipe
> compilation terminated.
> lipo: can't open input file: 
> /var/folders/t7/t7jaJ7IcGnKFNCMY3G37PU+++TI/-Tmp-//ccP7p7J0.out (No such file 
> or directory)
> error: command 'gcc-4.2' failed with exit status 1
> To fix:
> export ARCHFLAGS="-arch x86_64"

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1307) Add compression to Thrift

[Bryan Duxbury (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093192#comment-13093192
 ] 

Bryan Duxbury commented on THRIFT-1307:
---

Some of the libraries already have compressed transports, usually zlib or gzip. 
I think it would make sense to make a SnappyTransport.

> Add compression to Thrift
> -
>
> Key: THRIFT-1307
> URL: https://issues.apache.org/jira/browse/THRIFT-1307
> Project: Thrift
>  Issue Type: New Feature
>  Components: Java - Library
>Reporter: Jerome Boulon
>
> Thrift output could be compressed on the fly similar to what Tomcat/Apache 
> are doing.
> But instead of using Gzip, since performance matter more than the compression 
> ratio, Snappy could be used.
> Snappy: http://code.google.com/p/snappy/
> Snappy is written in C++, but Java bindings are included

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1305) thrift: make TConnection a private inner class of

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093188#comment-13093188
 ] 

Hudson commented on THRIFT-1305:


Integrated in Thrift #243 (See [https://builds.apache.org/job/Thrift/243/])
THRIFT-1305. cpp: make TConnection a private inner class of
TNonblockingServer

Patch: Adam Simpkins

bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1162987
Files : 
* /thrift/trunk/lib/cpp/src/server/TNonblockingServer.cpp
* /thrift/trunk/lib/cpp/src/server/TNonblockingServer.h


>  thrift: make TConnection a private inner class of

> ---
>
> Key: THRIFT-1305
> URL: https://issues.apache.org/jira/browse/THRIFT-1305
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Assignee: Dave Watson
>Priority: Minor
> Fix For: 0.8
>
> Attachments: 
> 0024-thrift-make-TConnection-a-private-inner-class-of-TNo.patch
>
>
> From 1f203754d8e9eb3e509cd874f6e5824eeaf5aa34 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Mon, 19 Apr 2010 19:09:13 +
> Subject: [PATCH 24/33] thrift: make TConnection a private inner class of
>  TNonblockingServer
> Summary:
> The immediate need for this is so that TConnection can access some
> protected methods of TNonblockingServer.  However, it
> seems a generally good thing to eliminate TConnection from the publicly
> exposed API.
> Test Plan:
> Ran the tests from [fb unittest].
> Revert Plan:
> OK
> Conflicts:
>   lib/cpp/src/server/TNonblockingServer.cpp
>   lib/cpp/src/server/TNonblockingServer.h
> ---
>  lib/cpp/src/server/TNonblockingServer.cpp |  301 
> +++--
>  lib/cpp/src/server/TNonblockingServer.h   |  275 +--
>  2 files changed, 291 insertions(+), 285 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Build failed in Jenkins: Thrift #243

[Apache Jenkins Server]

See 

Changes:

[bryanduxbury] THRIFT-1305. cpp: make TConnection a private inner class of
TNonblockingServer

Patch: Adam Simpkins

--
[...truncated 2102 lines...]
Making check in js/test
make[2]: Entering directory 
`
make  check-local
make[3]: Entering directory 
`
/home/hudson/tools/ant/latest/bin/ant -Dtest.junit.output.format=xml test
Buildfile: 


generate:

check-gjslint:
 [echo] check if gjslint is available:
 [exec] Execute failed: java.io.IOException: Cannot run program "gjslint": 
java.io.IOException: error=2, No such file or directory

gjslint:

resolve:
 [copy] Copying 36 files to 


jslint:

lint:

dependencies:

init:
[mkdir] Created dir: 

[mkdir] Created dir: 

[mkdir] Created dir: 

[mkdir] Created dir: 


xvfb:
 [echo] check if Xvfb is available:
 [exec] Execute failed: java.io.IOException: Cannot run program "Xvfb": 
java.io.IOException: error=2, No such file or directory

phantomjs:

compile:
[javac] Compiling 21 source files to 

[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] Compiling 1 source file to 

[javac] Note: 

 uses or overrides a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] Note: 

 uses unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.

jstest:
  [jar] Building jar: 


proxy:

jslibs:
  [get] Getting: http://code.jquery.com/jquery-1.5.2.js
  [get] To: 

  [get] Getting: 
http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/equiv.js
  [get] To: 

  [get] Getting: 
http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/QUnitAdapter.js
  [get] To: 

  [get] Getting: http://code.jquery.com/qunit/git/qunit.js
  [get] To: 

  [get] Getting: http://code.jquery.com/qunit/git/qunit.css
  [get] To: 

 [copy] Copying 1 file to 


unittest:

test:

BUILD SUCCESSFUL
Total time: 9 seconds
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in py
make[2]: Entering directory 
`
/usr/bin/python setup.py build
running build
running build_py
running build_ext
make  check-local
make[3]: Entering directory 
`
/usr/bin/python setup.py build
running build
running build_py
running build_ext
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in erl
make[2]: Entering directory 
`
./rebar eunit
==> erl (eunit)
Compiled src/thrift_protocol.erl
Compiled src/thrift_service.erl
Compiled src/thrift_transport.erl
Compiled test/serviceForExceptionWithAMap_thrift.erl
Compiled test/emptyService_thrift.erl
Compiled test/test_disklog.erl
Compiled test/test_thrift_1151.erl
Compiled test/stress_server.erl
Compiled test/service_thrift.erl
Compiled test/test_server.erl
Compiled test/optionalRequiredTest_types.erl
Compiled test/test_membuffer.erl
Compiled test/denseLinkingTest_types.erl
Compiled test/stressTest_types.erl
Compiled test/srv_thrift.erl
Compiled test/thr

[jira] [Commented] (THRIFT-1307) Add compression to Thrift

[Jerome Boulon (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093182#comment-13093182
 ] 

Jerome Boulon commented on THRIFT-1307:
---

+1 on the plugin interface. Snappy is just an example.

> Add compression to Thrift
> -
>
> Key: THRIFT-1307
> URL: https://issues.apache.org/jira/browse/THRIFT-1307
> Project: Thrift
>  Issue Type: New Feature
>  Components: Java - Library
>Reporter: Jerome Boulon
>
> Thrift output could be compressed on the fly similar to what Tomcat/Apache 
> are doing.
> But instead of using Gzip, since performance matter more than the compression 
> ratio, Snappy could be used.
> Snappy: http://code.google.com/p/snappy/
> Snappy is written in C++, but Java bindings are included

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (THRIFT-1305) thrift: make TConnection a private inner class of

[Bryan Duxbury (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Duxbury closed THRIFT-1305.
-

   Resolution: Fixed
Fix Version/s: 0.8
 Assignee: Dave Watson

Committed.

>  thrift: make TConnection a private inner class of

> ---
>
> Key: THRIFT-1305
> URL: https://issues.apache.org/jira/browse/THRIFT-1305
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Assignee: Dave Watson
>Priority: Minor
> Fix For: 0.8
>
> Attachments: 
> 0024-thrift-make-TConnection-a-private-inner-class-of-TNo.patch
>
>
> From 1f203754d8e9eb3e509cd874f6e5824eeaf5aa34 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Mon, 19 Apr 2010 19:09:13 +
> Subject: [PATCH 24/33] thrift: make TConnection a private inner class of
>  TNonblockingServer
> Summary:
> The immediate need for this is so that TConnection can access some
> protected methods of TNonblockingServer.  However, it
> seems a generally good thing to eliminate TConnection from the publicly
> exposed API.
> Test Plan:
> Ran the tests from [fb unittest].
> Revert Plan:
> OK
> Conflicts:
>   lib/cpp/src/server/TNonblockingServer.cpp
>   lib/cpp/src/server/TNonblockingServer.h
> ---
>  lib/cpp/src/server/TNonblockingServer.cpp |  301 
> +++--
>  lib/cpp/src/server/TNonblockingServer.h   |  275 +--
>  2 files changed, 291 insertions(+), 285 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1307) Add compression to Thrift

[Jake Farrell (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093162#comment-13093162
 ] 

Jake Farrell commented on THRIFT-1307:
--

This might be a good area to allow for some sort of plugin interface to be able 
to add mutators like this. Would want to avoid using something like snappy 
directly in the code due to it not supporting every client we currently support 
and that snappys clients are mostly 3rd party to their library, would make hard 
to maintain and test and add as a uniform dependency. good idea

> Add compression to Thrift
> -
>
> Key: THRIFT-1307
> URL: https://issues.apache.org/jira/browse/THRIFT-1307
> Project: Thrift
>  Issue Type: New Feature
>  Components: Java - Library
>Reporter: Jerome Boulon
>
> Thrift output could be compressed on the fly similar to what Tomcat/Apache 
> are doing.
> But instead of using Gzip, since performance matter more than the compression 
> ratio, Snappy could be used.
> Snappy: http://code.google.com/p/snappy/
> Snappy is written in C++, but Java bindings are included

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1307) Add compression to Thrift

[Jerome Boulon (JIRA)]

Add compression to Thrift
-

 Key: THRIFT-1307
 URL: https://issues.apache.org/jira/browse/THRIFT-1307
 Project: Thrift
  Issue Type: New Feature
  Components: Java - Library
Reporter: Jerome Boulon


Thrift output could be compressed on the fly similar to what Tomcat/Apache are 
doing.
But instead of using Gzip, since performance matter more than the compression 
ratio, Snappy could be used.
Snappy: http://code.google.com/p/snappy/
Snappy is written in C++, but Java bindings are included

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1304) TNonblockingServer: pass in the connection context to

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093114#comment-13093114
 ] 

Hudson commented on THRIFT-1304:


Integrated in Thrift #242 (See [https://builds.apache.org/job/Thrift/242/])
THRIFT-1304. cpp: TNonblockingServer: pass in the connection context to
process()

Patch: Adam Simpkins

bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1162943
Files : 
* /thrift/trunk/lib/cpp/src/server/TNonblockingServer.cpp


>  TNonblockingServer: pass in the connection context to

> ---
>
> Key: THRIFT-1304
> URL: https://issues.apache.org/jira/browse/THRIFT-1304
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Assignee: Dave Watson
>Priority: Minor
> Fix For: 0.8
>
> Attachments: 
> 0023-TNonblockingServer-pass-in-the-connection-context-to.patch
>
>
> From aa5cdf5b40e046b41a0c61e521dba0e78e1887b0 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Sat, 17 Apr 2010 01:10:15 +
> Subject: [PATCH 23/33] TNonblockingServer: pass in the connection context to
>  process()
> Summary:
> When using TNonblockingServer without a ThreadManager, it always passed
> NULL to process(), instead of passing in the context returned by
> TProcessorEventHandler::getContext().  This was broken and could cause
> TProcessorEventHandlers to crash, since they expected to get the value
> they had previously returned via getContext().
> Test Plan:
> Ran the test code in [fb unittest].  The non-threaded TNonblockingServer tests
> no longer crash.
> Revert Plan:
> OK
> ---
>  lib/cpp/src/server/TNonblockingServer.cpp |3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1296) SSL detection is broken

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093112#comment-13093112
 ] 

Hudson commented on THRIFT-1296:


Integrated in Thrift #242 (See [https://builds.apache.org/job/Thrift/242/])
Thrift-1296: SSL detection is broken
Patch: jfarrell

Updated configure to check for crypto and then ssl and error along the way if 
unavailable.


> SSL detection is broken
> ---
>
> Key: THRIFT-1296
> URL: https://issues.apache.org/jira/browse/THRIFT-1296
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Affects Versions: 0.7
> Environment: Ubuntu 10.04
> Building Thrift against a custom toolchain (not using system 
> packages/libraries)
>Reporter: Diwaker Gupta
>Assignee: Jake Farrell
> Attachments: THRIFT-1296.patch, thrift-1296.patch
>
>
> When using shared libraries, libssl has dependencies on libcrypto. The 
> current autoconf macro for checking SSL doesn't do the job:
> {noformat}
> configure:23665: checking for SSL_ctrl in -lssl
> configure:23690: x86_64-unknown-linux-gnu-g++ -o conftest -O2 -Wall -pipe  
> -L -I  -O2 -Wall -pipe conftest.cpp -lssl  -lrt -lpthread  >&5
> x86_64-unknown-linux-gnu/bin/ld: warning: libcrypto.so.1.0.0, needed by 
> /usr/lib/libssl.so, not found (try using -rpath or -rpath-link)
> {noformat}
> The following patch fixes this problem:
> {noformat}
> +--- configure.ac
>  configure.ac
> +@@ -312,7 +312,7 @@ dnl of the POSIX Real-Time Extensions.  This seems 
> necessary on Linux,
> + dnl and we haven't yet found a system where this is a problem.
> + AC_CHECK_LIB(rt, clock_gettime)
> + AC_CHECK_LIB(socket, setsockopt)
> +-AC_CHECK_LIB(ssl, SSL_ctrl)
> ++AC_CHECK_LIB(ssl, SSL_ctrl,[LIBS="-lssl -lcrypto $LIBS"],,-lcrypto)
> +
> + AC_TYPE_INT16_T
> + AC_TYPE_INT32_T
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1299) If SSL is available, 'thrift' binary links against it

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093115#comment-13093115
 ] 

Hudson commented on THRIFT-1299:


Integrated in Thrift #242 (See [https://builds.apache.org/job/Thrift/242/])
Thrift-1299: If SSL is available, 'thrift' binary links against it
Patch: jfarrell

Removes the dependencies added from configure.ac in the thrift compiler 
makefile.


> If SSL is available, 'thrift' binary links against it
> -
>
> Key: THRIFT-1299
> URL: https://issues.apache.org/jira/browse/THRIFT-1299
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process, C++ - Compiler, C++ - Library
>Affects Versions: 0.7
>Reporter: Diwaker Gupta
>Assignee: Jake Farrell
>Priority: Minor
> Attachments: thrift-1299.patch
>
>
> Inspection of compiler/cpp/Makefile and lib/cpp/Makefile reveals that for 
> building both the thrift compiler as well as the C++ libraries, the same set 
> of libraries (in the variable LIBS) are used. When OpenSSL is available, this 
> has the unintended consequence that the thrift compiler links libssl (and 
> potentially libcrypto), even though it doesn't need to. In theory there is no 
> harm in linking against additional shared libraries but it can be an issue in 
> practice. Specifically, if OpenSSL etc are installed in a custom location 
> (such as when building a custom toolchain), the thrift binary will fail to 
> run unless LD_LIBRARY_PATH is set every time thrift needs to run.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1306) Fix stale documentation

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093113#comment-13093113
 ] 

Hudson commented on THRIFT-1306:


Integrated in Thrift #242 (See [https://builds.apache.org/job/Thrift/242/])
THRIFT-1306: Fix stale documentation
Client: cpp
Patch: Diwaker Gupta

Fix documentation to match API change. Also format to 80 chars.

jfarrell : http://svn.apache.org/viewvc/?view=rev&rev=1162937
Files : 
* /thrift/trunk/lib/cpp/src/async/TAsyncChannel.h


> Fix stale documentation
> ---
>
> Key: THRIFT-1306
> URL: https://issues.apache.org/jira/browse/THRIFT-1306
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Affects Versions: 0.7
>Reporter: Diwaker Gupta
>Assignee: Diwaker Gupta
>Priority: Trivial
> Attachments: THRIFT-1306.patch
>
>
> Fix documentation to match API change. Also format to 80 chars.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Build failed in Jenkins: Thrift #242

[Apache Jenkins Server]

See 

Changes:

[bryanduxbury] THRIFT-1304. cpp: TNonblockingServer: pass in the connection 
context to
process()

Patch: Adam Simpkins

[jfarrell] THRIFT-1306: Fix stale documentation
Client: cpp
Patch: Diwaker Gupta

Fix documentation to match API change. Also format to 80 chars.

[jfarrell] Thrift-1299: If SSL is available, 'thrift' binary links against it
Patch: jfarrell

Removes the dependencies added from configure.ac in the thrift compiler 
makefile.

[jfarrell] Thrift-1296: SSL detection is broken
Patch: jfarrell

Updated configure to check for crypto and then ssl and error along the way if 
unavailable.

--
[...truncated 2103 lines...]
Buildfile: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build.xml

generate:

check-gjslint:
 [echo] check if gjslint is available:
 [exec] Execute failed: java.io.IOException: Cannot run program "gjslint": 
java.io.IOException: error=2, No such file or directory

gjslint:

resolve:
 [copy] Copying 36 files to 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/lib

jslint:

lint:

dependencies:

init:
[mkdir] Created dir: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js/lib
[mkdir] Created dir: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/log
[mkdir] Created dir: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/test
[mkdir] Created dir: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/test/log

xvfb:
 [echo] check if Xvfb is available:
 [exec] Result: 1

phantomjs:
 [echo] check if phantomjs is available:
 [exec] Execute failed: java.io.IOException: Cannot run program 
"phantomjs": java.io.IOException: error=2, No such file or directory

compile:
[javac] Compiling 21 source files to 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/test
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] Compiling 1 source file to 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/test
[javac] Note: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/src/test/Httpd.java
 uses or overrides a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] Note: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/src/test/Httpd.java
 uses unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.

jstest:
  [jar] Building jar: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/jstest.jar

proxy:

jslibs:
  [get] Getting: http://code.jquery.com/jquery-1.5.2.js
  [get] To: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js/lib/jquery-1.5.2.js
  [get] Getting: 
http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/equiv.js
  [get] To: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js/lib/equiv.js
  [get] Getting: 
http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/QUnitAdapter.js
  [get] To: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js/lib/QUnitAdapter.js
  [get] Getting: http://code.jquery.com/qunit/git/qunit.js
  [get] To: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js/lib/qunit.js
  [get] Getting: http://code.jquery.com/qunit/git/qunit.css
  [get] To: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js/lib/qunit.css
 [copy] Copying 1 file to 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js

unittest:

test:

BUILD SUCCESSFUL
Total time: 9 seconds
make[3]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test'
make[2]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test'
Making check in py
make[2]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/py'
/usr/bin/python setup.py build
running build
running build_py
running build_ext
make  check-local
make[3]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/py'
/usr/bin/python setup.py build
running build
running build_py
running build_ext
make[3]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/py'
make[2]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/py'
Making check in erl
make[2]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/erl'
./rebar eunit
==> erl (eunit)
Compiled src/thrift_protocol.erl
Compiled src/thrift_transport.erl
Compiled src/thrift_service.erl
Compiled test/smallService_thrift.erl
Compiled test/smallTest_types.erl
Compiled test/inherited_thrift.erl
Compiled test/aService_thrift.erl
Compiled test/stressTest_ty

[jira] [Closed] (THRIFT-1291) Severely outdated config.sub in 0.7 distribution

[Jake Farrell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell closed THRIFT-1291.


Resolution: Fixed

Tracked down to an issue with my env, migrated off that box and next release 
will not have this issue.

> Severely outdated config.sub in 0.7 distribution
> 
>
> Key: THRIFT-1291
> URL: https://issues.apache.org/jira/browse/THRIFT-1291
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process, Deployment
>Affects Versions: 0.7
>Reporter: Diwaker Gupta
>Assignee: Jake Farrell
> Attachments: config.sub.0.6, config.sub.0.7
>
>
> The version of config.sub that is distributed with Thrift 0.7 seems to be 
> from 2003, whereas the one that shipped with 0.6 is from 2008. This is 
> breaking Thrift builds for us on non-standard platforms. For instance:
> {noformat}
> $ bash config.sub.0.6 arm-unknown-linux-uclibcgnueabi
> arm-unknown-linux-uclibcgnueabi
> $ bash config.sub.0.7 arm-unknown-linux-uclibcgnueabi
> Invalid configuration `arm-unknown-linux-uclibcgnueabi': machine 
> `arm-unknown-linux' not recognized
> {noformat}
> The first few lines of the files are also instructive:
> {noformat}
> $ head -n 7 config.sub.0.6
> #! /bin/sh
> # Configuration validation subroutine script.
> #   Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
> #   2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008
> #   Free Software Foundation, Inc.
> timestamp='2008-01-16'
> $ head -n 7 config.sub.0.7
> #! /bin/sh
> # Configuration validation subroutine script.
> #   Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
> #   2000, 2001, 2002, 2003 Free Software Foundation, Inc.
> timestamp='2003-06-18'
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (THRIFT-1304) TNonblockingServer: pass in the connection context to

[Bryan Duxbury (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Duxbury closed THRIFT-1304.
-

   Resolution: Fixed
Fix Version/s: 0.8
 Assignee: Dave Watson

Committed.

>  TNonblockingServer: pass in the connection context to

> ---
>
> Key: THRIFT-1304
> URL: https://issues.apache.org/jira/browse/THRIFT-1304
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Assignee: Dave Watson
>Priority: Minor
> Fix For: 0.8
>
> Attachments: 
> 0023-TNonblockingServer-pass-in-the-connection-context-to.patch
>
>
> From aa5cdf5b40e046b41a0c61e521dba0e78e1887b0 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Sat, 17 Apr 2010 01:10:15 +
> Subject: [PATCH 23/33] TNonblockingServer: pass in the connection context to
>  process()
> Summary:
> When using TNonblockingServer without a ThreadManager, it always passed
> NULL to process(), instead of passing in the context returned by
> TProcessorEventHandler::getContext().  This was broken and could cause
> TProcessorEventHandlers to crash, since they expected to get the value
> they had previously returned via getContext().
> Test Plan:
> Ran the test code in [fb unittest].  The non-threaded TNonblockingServer tests
> no longer crash.
> Revert Plan:
> OK
> ---
>  lib/cpp/src/server/TNonblockingServer.cpp |3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (THRIFT-1306) Fix stale documentation

[Jake Farrell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell closed THRIFT-1306.


Resolution: Fixed
  Assignee: Diwaker Gupta

Thanks for the patch, committed 

> Fix stale documentation
> ---
>
> Key: THRIFT-1306
> URL: https://issues.apache.org/jira/browse/THRIFT-1306
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Affects Versions: 0.7
>Reporter: Diwaker Gupta
>Assignee: Diwaker Gupta
>Priority: Trivial
> Attachments: THRIFT-1306.patch
>
>
> Fix documentation to match API change. Also format to 80 chars.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (THRIFT-1299) If SSL is available, 'thrift' binary links against it

[Jake Farrell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell closed THRIFT-1299.


Resolution: Fixed

committed

> If SSL is available, 'thrift' binary links against it
> -
>
> Key: THRIFT-1299
> URL: https://issues.apache.org/jira/browse/THRIFT-1299
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process, C++ - Compiler, C++ - Library
>Affects Versions: 0.7
>Reporter: Diwaker Gupta
>Assignee: Jake Farrell
>Priority: Minor
> Attachments: thrift-1299.patch
>
>
> Inspection of compiler/cpp/Makefile and lib/cpp/Makefile reveals that for 
> building both the thrift compiler as well as the C++ libraries, the same set 
> of libraries (in the variable LIBS) are used. When OpenSSL is available, this 
> has the unintended consequence that the thrift compiler links libssl (and 
> potentially libcrypto), even though it doesn't need to. In theory there is no 
> harm in linking against additional shared libraries but it can be an issue in 
> practice. Specifically, if OpenSSL etc are installed in a custom location 
> (such as when building a custom toolchain), the thrift binary will fail to 
> run unless LD_LIBRARY_PATH is set every time thrift needs to run.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1302) thrift: raise an exception if send() times out in

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093052#comment-13093052
 ] 

Hudson commented on THRIFT-1302:


Integrated in Thrift #241 (See [https://builds.apache.org/job/Thrift/241/])
THRIFT-1302. cpp: raise an exception if send() times out in
TSocket::write()

Patch: Adam Simpkins

bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1162923
Files : 
* /thrift/trunk/lib/cpp/src/transport/TSocket.cpp


>  thrift: raise an exception if send() times out in

> ---
>
> Key: THRIFT-1302
> URL: https://issues.apache.org/jira/browse/THRIFT-1302
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Assignee: Dave Watson
>Priority: Minor
> Fix For: 0.8
>
> Attachments: 
> 0022-thrift-raise-an-exception-if-send-times-out-in-TSock.patch
>
>
> From 1f76284b5972ab01d6f6ac68f96024a8066a3b59 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Fri, 16 Apr 2010 17:43:21 +
> Subject: [PATCH 22/33] thrift: raise an exception if send() times out in
>  TSocket::write()
> Summary:
> Previously, if send() timed out in TSocket::write(), it would sleep for
> 50 microseconds and retry.  This essentially made the timeout set with
> setSendTimeout() useless.  Now it raises a TTransportException on
> timeout.
> TNonblockingServer does use TSocket with the fd manually put in
> non-blocking mode, and that could cause EWOULDBLOCK and EAGAIN to occur
> during normal operation.  However, it only uses write_partial() and
> never write(), so it should be safe to have write() throw the exception.
> Test Plan:
> Used the client and server in thrift/tutorial/cpp/async/sort/ to test
> sending a large message to the server.  I set a 100ms timeout in the
> client, and verified that it correctly times out now if the server
> process is stopped.
> I also ran [fb unittests] to try and verify that this doesn't negatively
> affect any other code.
> Revert Plan:
> OK
> ---
>  lib/cpp/src/transport/TSocket.cpp |7 ---
>  1 files changed, 4 insertions(+), 3 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1301) thrift: consolidate common code in TNonblockingServer

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093050#comment-13093050
 ] 

Hudson commented on THRIFT-1301:


Integrated in Thrift #241 (See [https://builds.apache.org/job/Thrift/241/])
THRIFT-1301. cpp: consolidate common code in TNonblockingServer constructors

Patch: Adam Simpkins

bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1162920
Files : 
* /thrift/trunk/lib/cpp/src/server/TNonblockingServer.h


>  thrift: consolidate common code in TNonblockingServer

> ---
>
> Key: THRIFT-1301
> URL: https://issues.apache.org/jira/browse/THRIFT-1301
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Assignee: Dave Watson
>Priority: Minor
> Fix For: 0.8
>
> Attachments: 0021-consolidate-common-code-2.patch
>
>
> From eb29276e934e6d445fb3226da9cb81b890be5cb7 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Fri, 16 Apr 2010 01:28:36 +
> Subject: [PATCH 21/33] thrift: consolidate common code in TNonblockingServer
>  constructors
> Summary:
> This moves most of the code in the initializer lists into a helper
> function.  I'm about to make a change that will double the number of
> constructors, and I'd rather not have to copy-and-paste these long
> initializers.
> Test Plan:
> Ran the tests from [fb unit test], and everything passes.
> Revert Plan:
> OK
> ---
>  lib/cpp/src/server/TNonblockingServer.h |  125 --
>  1 files changed, 50 insertions(+), 75 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1298) Standard scheme doesn't read or write metadata along with field values

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093051#comment-13093051
 ] 

Hudson commented on THRIFT-1298:


Integrated in Thrift #241 (See [https://builds.apache.org/job/Thrift/241/])
THRIFT-1298. java: Standard scheme doesn't read or write metadata along 
with field values

This patch makes StandardScheme write metadata, and adds tests against a static 
known-good Binary-serialized struct for a reference.

Patch: Armaan Sarkar

bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1162917
Files : 
* /thrift/trunk/compiler/cpp/src/generate/t_java_generator.cc
* /thrift/trunk/lib/java/test/org/apache/thrift/Fixtures.java
* /thrift/trunk/lib/java/test/org/apache/thrift/scheme
* /thrift/trunk/lib/java/test/org/apache/thrift/scheme/TestStandardScheme.java


> Standard scheme doesn't read or write metadata along with field values
> --
>
> Key: THRIFT-1298
> URL: https://issues.apache.org/jira/browse/THRIFT-1298
> Project: Thrift
>  Issue Type: Bug
>  Components: Java - Compiler
>Affects Versions: 0.8
>Reporter: Armaan Sarkar
>Assignee: Armaan Sarkar
> Fix For: 0.8
>
> Attachments: THRIFT-1289_v1.patch
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Metadata (such as field type, length, etc) is not read or written to by the 
> standard scheme. This is not the intended functionality. It causes problems 
> reading structs that were written before pluggable serializers came into 
> effect. Since the standard scheme is the default serializer it must function 
> exactly like thrift serialization did in the past (complete with metadata 
> surrounding the fields).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1306) Fix stale documentation

[Diwaker Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Diwaker Gupta updated THRIFT-1306:
--

Attachment: THRIFT-1306.patch

> Fix stale documentation
> ---
>
> Key: THRIFT-1306
> URL: https://issues.apache.org/jira/browse/THRIFT-1306
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Affects Versions: 0.7
>Reporter: Diwaker Gupta
>Priority: Trivial
> Attachments: THRIFT-1306.patch
>
>
> Fix documentation to match API change. Also format to 80 chars.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Build failed in Jenkins: Thrift #241

[Apache Jenkins Server]

See 

Changes:

[bryanduxbury] THRIFT-1302. cpp: raise an exception if send() times out in
TSocket::write()

Patch: Adam Simpkins

[bryanduxbury] THRIFT-1301. cpp: consolidate common code in TNonblockingServer 
constructors

Patch: Adam Simpkins

[bryanduxbury] THRIFT-1298. java: Standard scheme doesn't read or write 
metadata along with field values

This patch makes StandardScheme write metadata, and adds tests against a static 
known-good Binary-serialized struct for a reference.

Patch: Armaan Sarkar

--
[...truncated 3355 lines...]
/home/hudson/tools/ant/latest/bin/ant -Dtest.junit.output.format=xml test
Buildfile: 


generate:

check-gjslint:
 [echo] check if gjslint is available:
 [exec] Execute failed: java.io.IOException: Cannot run program "gjslint": 
java.io.IOException: error=2, No such file or directory

gjslint:

resolve:
 [copy] Copying 36 files to 


jslint:

lint:

dependencies:

init:
[mkdir] Created dir: 

[mkdir] Created dir: 

[mkdir] Created dir: 

[mkdir] Created dir: 


xvfb:
 [echo] check if Xvfb is available:
 [exec] Result: 1

phantomjs:
 [echo] check if phantomjs is available:
 [exec] Execute failed: java.io.IOException: Cannot run program 
"phantomjs": java.io.IOException: error=2, No such file or directory

compile:
[javac] Compiling 21 source files to 

[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] Compiling 1 source file to 

[javac] Note: 

 uses or overrides a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] Note: 

 uses unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.

jstest:
  [jar] Building jar: 


proxy:

jslibs:
  [get] Getting: http://code.jquery.com/jquery-1.5.2.js
  [get] To: 

  [get] Getting: 
http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/equiv.js
  [get] To: 

  [get] Getting: 
http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/QUnitAdapter.js
  [get] To: 

  [get] Getting: http://code.jquery.com/qunit/git/qunit.js
  [get] To: 

  [get] Getting: http://code.jquery.com/qunit/git/qunit.css
  [get] To: 

 [copy] Copying 1 file to 


unittest:

test:

BUILD SUCCESSFUL
Total time: 11 seconds
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in py
make[2]: Entering directory 
`
/usr/bin/python setup.py build
running build
running build_py
running build_ext
make  check-local
make[3]: Entering directory 
`
/usr/bin/python setup.py build
running build
running build_py
running build_ext
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in erl
make[2]: Entering directory 
`
./rebar eunit
==> erl (eunit)
Compiled src/thrift_transport.erl
Compiled src/thrift_service.erl
Compiled src/thrift_protocol.erl
Compiled test/constantsDemo_types.erl
Compiled test/thriftTest_types.erl
Compiled test/inherited_thrift.erl
Compiled test/manyTypedefs_types.erl
Compiled test/service_thrift.erl
Compiled test/yowza_thrift.erl
Compiled test/test

[jira] [Created] (THRIFT-1306) Fix stale documentation

[Diwaker Gupta (JIRA)]

Fix stale documentation
---

 Key: THRIFT-1306
 URL: https://issues.apache.org/jira/browse/THRIFT-1306
 Project: Thrift
  Issue Type: Improvement
  Components: C++ - Library
Affects Versions: 0.7
Reporter: Diwaker Gupta
Priority: Trivial


Fix documentation to match API change. Also format to 80 chars.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (THRIFT-1296) SSL detection is broken

[Jake Farrell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell closed THRIFT-1296.


Resolution: Fixed

Flipped around the checks so crypto is looked for first and then used when 
checking for ssl, committed

> SSL detection is broken
> ---
>
> Key: THRIFT-1296
> URL: https://issues.apache.org/jira/browse/THRIFT-1296
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Affects Versions: 0.7
> Environment: Ubuntu 10.04
> Building Thrift against a custom toolchain (not using system 
> packages/libraries)
>Reporter: Diwaker Gupta
>Assignee: Jake Farrell
> Attachments: THRIFT-1296.patch, thrift-1296.patch
>
>
> When using shared libraries, libssl has dependencies on libcrypto. The 
> current autoconf macro for checking SSL doesn't do the job:
> {noformat}
> configure:23665: checking for SSL_ctrl in -lssl
> configure:23690: x86_64-unknown-linux-gnu-g++ -o conftest -O2 -Wall -pipe  
> -L -I  -O2 -Wall -pipe conftest.cpp -lssl  -lrt -lpthread  >&5
> x86_64-unknown-linux-gnu/bin/ld: warning: libcrypto.so.1.0.0, needed by 
> /usr/lib/libssl.so, not found (try using -rpath or -rpath-link)
> {noformat}
> The following patch fixes this problem:
> {noformat}
> +--- configure.ac
>  configure.ac
> +@@ -312,7 +312,7 @@ dnl of the POSIX Real-Time Extensions.  This seems 
> necessary on Linux,
> + dnl and we haven't yet found a system where this is a problem.
> + AC_CHECK_LIB(rt, clock_gettime)
> + AC_CHECK_LIB(socket, setsockopt)
> +-AC_CHECK_LIB(ssl, SSL_ctrl)
> ++AC_CHECK_LIB(ssl, SSL_ctrl,[LIBS="-lssl -lcrypto $LIBS"],,-lcrypto)
> +
> + AC_TYPE_INT16_T
> + AC_TYPE_INT32_T
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1243) TAsyncChannel callbacks

[Diwaker Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093043#comment-13093043
 ] 

Diwaker Gupta commented on THRIFT-1243:
---

Saw this a bit late but I'm concerned about this change. With this change, 
there is no way for implementors of sendMessage/recvMessage to signal to the 
callers that something unexpected happened or any other error conditions. Just 
because the current implementation ignores the return values doesn't mean 
they're not useful.

Is the recommendation now to throw a TException instead?

> TAsyncChannel callbacks
> ---
>
> Key: THRIFT-1243
> URL: https://issues.apache.org/jira/browse/THRIFT-1243
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Affects Versions: 0.7
> Environment: Visual C++ 2010
>Reporter: alexandre parenteau
>Assignee: alexandre parenteau
>Priority: Minor
>  Labels: patch
> Fix For: 0.8
>
> Attachments: THRIFT-1243.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> [Context: This patch is part of a larger patch to use thriftnb on 
> Windows/VisualC++. See 
> https://github.com/aubonbeurre/thrift/blob/alex-0.7.0/README.non.blocking.Windows
>  for more details.]
> When compiling using Visual C++ 2010, the compiler chokes on casting some 
> callbacks bool(*)() to void(*)().
> Although probably valid and supported by gcc, this is further complicated by 
> the fact those casting seem unnecessary: for each of the callbacks returning 
> bool in TAsyncChannel.h:
> 1. the returned value is never checked
> 2. they always return true
> Attached is a trivial patch based on 0.7.0, tested on Ubuntu 11.04 and Visual 
> C++ 2010.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (THRIFT-1302) thrift: raise an exception if send() times out in

[Bryan Duxbury (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Duxbury closed THRIFT-1302.
-

   Resolution: Fixed
Fix Version/s: 0.8
 Assignee: Dave Watson

Committed.

>  thrift: raise an exception if send() times out in

> ---
>
> Key: THRIFT-1302
> URL: https://issues.apache.org/jira/browse/THRIFT-1302
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Assignee: Dave Watson
>Priority: Minor
> Fix For: 0.8
>
> Attachments: 
> 0022-thrift-raise-an-exception-if-send-times-out-in-TSock.patch
>
>
> From 1f76284b5972ab01d6f6ac68f96024a8066a3b59 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Fri, 16 Apr 2010 17:43:21 +
> Subject: [PATCH 22/33] thrift: raise an exception if send() times out in
>  TSocket::write()
> Summary:
> Previously, if send() timed out in TSocket::write(), it would sleep for
> 50 microseconds and retry.  This essentially made the timeout set with
> setSendTimeout() useless.  Now it raises a TTransportException on
> timeout.
> TNonblockingServer does use TSocket with the fd manually put in
> non-blocking mode, and that could cause EWOULDBLOCK and EAGAIN to occur
> during normal operation.  However, it only uses write_partial() and
> never write(), so it should be safe to have write() throw the exception.
> Test Plan:
> Used the client and server in thrift/tutorial/cpp/async/sort/ to test
> sending a large message to the server.  I set a 100ms timeout in the
> client, and verified that it correctly times out now if the server
> process is stopped.
> I also ran [fb unittests] to try and verify that this doesn't negatively
> affect any other code.
> Revert Plan:
> OK
> ---
>  lib/cpp/src/transport/TSocket.cpp |7 ---
>  1 files changed, 4 insertions(+), 3 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (THRIFT-1301) thrift: consolidate common code in TNonblockingServer

[Bryan Duxbury (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Duxbury closed THRIFT-1301.
-

   Resolution: Fixed
Fix Version/s: 0.8
 Assignee: Dave Watson

Committed.

>  thrift: consolidate common code in TNonblockingServer

> ---
>
> Key: THRIFT-1301
> URL: https://issues.apache.org/jira/browse/THRIFT-1301
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Assignee: Dave Watson
>Priority: Minor
> Fix For: 0.8
>
> Attachments: 0021-consolidate-common-code-2.patch
>
>
> From eb29276e934e6d445fb3226da9cb81b890be5cb7 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Fri, 16 Apr 2010 01:28:36 +
> Subject: [PATCH 21/33] thrift: consolidate common code in TNonblockingServer
>  constructors
> Summary:
> This moves most of the code in the initializer lists into a helper
> function.  I'm about to make a change that will double the number of
> constructors, and I'd rather not have to copy-and-paste these long
> initializers.
> Test Plan:
> Ran the tests from [fb unit test], and everything passes.
> Revert Plan:
> OK
> ---
>  lib/cpp/src/server/TNonblockingServer.h |  125 --
>  1 files changed, 50 insertions(+), 75 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (THRIFT-1298) Standard scheme doesn't read or write metadata along with field values

[Bryan Duxbury (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Duxbury closed THRIFT-1298.
-

Resolution: Fixed

I did a little refactoring and committed this. 

> Standard scheme doesn't read or write metadata along with field values
> --
>
> Key: THRIFT-1298
> URL: https://issues.apache.org/jira/browse/THRIFT-1298
> Project: Thrift
>  Issue Type: Bug
>  Components: Java - Compiler
>Affects Versions: 0.8
>Reporter: Armaan Sarkar
>Assignee: Armaan Sarkar
> Fix For: 0.8
>
> Attachments: THRIFT-1289_v1.patch
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Metadata (such as field type, length, etc) is not read or written to by the 
> standard scheme. This is not the intended functionality. It causes problems 
> reading structs that were written before pluggable serializers came into 
> effect. Since the standard scheme is the default serializer it must function 
> exactly like thrift serialization did in the past (complete with metadata 
> surrounding the fields).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1296) SSL detection is broken

[Diwaker Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092989#comment-13092989
 ] 

Diwaker Gupta commented on THRIFT-1296:
---

My AC-foo is fairly limited, but IIUC you need to include '-lcrypto' in the 
last (5th) parameter to AC_CHECK_LIB(ssl...). The reason being that just to 
link against libssl to check for SSL_ctrl, you need to also link against 
libcrypto (at least on my platform); otherwise GCC fails complaining about 
missing symbols. Otherwise the patch looks great!

> SSL detection is broken
> ---
>
> Key: THRIFT-1296
> URL: https://issues.apache.org/jira/browse/THRIFT-1296
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Affects Versions: 0.7
> Environment: Ubuntu 10.04
> Building Thrift against a custom toolchain (not using system 
> packages/libraries)
>Reporter: Diwaker Gupta
>Assignee: Jake Farrell
> Attachments: THRIFT-1296.patch, thrift-1296.patch
>
>
> When using shared libraries, libssl has dependencies on libcrypto. The 
> current autoconf macro for checking SSL doesn't do the job:
> {noformat}
> configure:23665: checking for SSL_ctrl in -lssl
> configure:23690: x86_64-unknown-linux-gnu-g++ -o conftest -O2 -Wall -pipe  
> -L -I  -O2 -Wall -pipe conftest.cpp -lssl  -lrt -lpthread  >&5
> x86_64-unknown-linux-gnu/bin/ld: warning: libcrypto.so.1.0.0, needed by 
> /usr/lib/libssl.so, not found (try using -rpath or -rpath-link)
> {noformat}
> The following patch fixes this problem:
> {noformat}
> +--- configure.ac
>  configure.ac
> +@@ -312,7 +312,7 @@ dnl of the POSIX Real-Time Extensions.  This seems 
> necessary on Linux,
> + dnl and we haven't yet found a system where this is a problem.
> + AC_CHECK_LIB(rt, clock_gettime)
> + AC_CHECK_LIB(socket, setsockopt)
> +-AC_CHECK_LIB(ssl, SSL_ctrl)
> ++AC_CHECK_LIB(ssl, SSL_ctrl,[LIBS="-lssl -lcrypto $LIBS"],,-lcrypto)
> +
> + AC_TYPE_INT16_T
> + AC_TYPE_INT32_T
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1299) If SSL is available, 'thrift' binary links against it

[Diwaker Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092985#comment-13092985
 ] 

Diwaker Gupta commented on THRIFT-1299:
---

Looks good to me!

> If SSL is available, 'thrift' binary links against it
> -
>
> Key: THRIFT-1299
> URL: https://issues.apache.org/jira/browse/THRIFT-1299
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process, C++ - Compiler, C++ - Library
>Affects Versions: 0.7
>Reporter: Diwaker Gupta
>Assignee: Jake Farrell
>Priority: Minor
> Attachments: thrift-1299.patch
>
>
> Inspection of compiler/cpp/Makefile and lib/cpp/Makefile reveals that for 
> building both the thrift compiler as well as the C++ libraries, the same set 
> of libraries (in the variable LIBS) are used. When OpenSSL is available, this 
> has the unintended consequence that the thrift compiler links libssl (and 
> potentially libcrypto), even though it doesn't need to. In theory there is no 
> harm in linking against additional shared libraries but it can be an issue in 
> practice. Specifically, if OpenSSL etc are installed in a custom location 
> (such as when building a custom toolchain), the thrift binary will fail to 
> run unless LD_LIBRARY_PATH is set every time thrift needs to run.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1303) Twisted tutorial client does not include correct generated path

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092920#comment-13092920
 ] 

Hudson commented on THRIFT-1303:


Integrated in Thrift #240 (See [https://builds.apache.org/job/Thrift/240/])
Thrift-1303: Twisted tutorial client does not include correct generated path
Client: tutorial

Updated path in python client to include correct generated code.


> Twisted tutorial client does not include correct generated path
> ---
>
> Key: THRIFT-1303
> URL: https://issues.apache.org/jira/browse/THRIFT-1303
> Project: Thrift
>  Issue Type: Bug
>Reporter: Jake Farrell
>Assignee: Jake Farrell
>Priority: Minor
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Build failed in Jenkins: Thrift #240

[Apache Jenkins Server]

See 

Changes:

[jfarrell] Thrift-1303: Twisted tutorial client does not include correct 
generated path
Client: tutorial

Updated path in python client to include correct generated code.

--
[...truncated 3348 lines...]
make  check-local
make[3]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test'
/home/hudson/tools/ant/latest/bin/ant -Dtest.junit.output.format=xml test
Buildfile: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build.xml

generate:

check-gjslint:
 [echo] check if gjslint is available:
 [exec] Execute failed: java.io.IOException: Cannot run program "gjslint": 
java.io.IOException: error=2, No such file or directory

gjslint:

resolve:
 [copy] Copying 36 files to 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/lib

jslint:

lint:

dependencies:

init:
[mkdir] Created dir: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js/lib
[mkdir] Created dir: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/log
[mkdir] Created dir: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/test
[mkdir] Created dir: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/test/log

xvfb:
 [echo] check if Xvfb is available:
 [exec] Result: 1

phantomjs:
 [echo] check if phantomjs is available:
 [exec] Execute failed: java.io.IOException: Cannot run program 
"phantomjs": java.io.IOException: error=2, No such file or directory

compile:
[javac] Compiling 21 source files to 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/test
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] Compiling 1 source file to 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/test
[javac] Note: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/src/test/Httpd.java
 uses or overrides a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] Note: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/src/test/Httpd.java
 uses unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.

jstest:
  [jar] Building jar: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/jstest.jar

proxy:

jslibs:
  [get] Getting: http://code.jquery.com/jquery-1.5.2.js
  [get] To: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js/lib/jquery-1.5.2.js
  [get] Getting: 
http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/equiv.js
  [get] To: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js/lib/equiv.js
  [get] Getting: 
http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/QUnitAdapter.js
  [get] To: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js/lib/QUnitAdapter.js
  [get] Getting: http://code.jquery.com/qunit/git/qunit.js
  [get] To: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js/lib/qunit.js
  [get] Getting: http://code.jquery.com/qunit/git/qunit.css
  [get] To: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js/lib/qunit.css
 [copy] Copying 1 file to 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js

unittest:

test:

BUILD SUCCESSFUL
Total time: 9 seconds
make[3]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test'
make[2]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test'
Making check in py
make[2]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/py'
/usr/bin/python setup.py build
running build
running build_py
running build_ext
make  check-local
make[3]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/py'
/usr/bin/python setup.py build
running build
running build_py
running build_ext
make[3]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/py'
make[2]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/py'
Making check in erl
make[2]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/erl'
./rebar eunit
==> erl (eunit)
Compiled src/thrift_protocol.erl
Compiled src/thrift_transport.erl
Compiled src/thrift_service.erl
Compiled test/smallTest_types.erl
Compiled test/smallService_thrift.erl
Compiled test/debugProtoTest_types.erl
Compiled test/inherited_thrift.erl
Compiled test/test_client.erl
Compiled test/stressTest_types.erl
Compiled test/aService_thrift.erl
Compiled test/yowza_thrift.erl
Compiled test/annotationTest_types.erl
Compiled test/secondService_thrift.erl
Compiled test/denseLinkingTest_types.erl
Compiled test/javaBe

[jira] [Updated] (THRIFT-1305) thrift: make TConnection a private inner class of

[Dave Watson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1305:


Attachment: 0024-thrift-make-TConnection-a-private-inner-class-of-TNo.patch

>  thrift: make TConnection a private inner class of

> ---
>
> Key: THRIFT-1305
> URL: https://issues.apache.org/jira/browse/THRIFT-1305
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Attachments: 
> 0024-thrift-make-TConnection-a-private-inner-class-of-TNo.patch
>
>
> From 1f203754d8e9eb3e509cd874f6e5824eeaf5aa34 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Mon, 19 Apr 2010 19:09:13 +
> Subject: [PATCH 24/33] thrift: make TConnection a private inner class of
>  TNonblockingServer
> Summary:
> The immediate need for this is so that TConnection can access some
> protected methods of TNonblockingServer.  However, it
> seems a generally good thing to eliminate TConnection from the publicly
> exposed API.
> Test Plan:
> Ran the tests from [fb unittest].
> Revert Plan:
> OK
> Conflicts:
>   lib/cpp/src/server/TNonblockingServer.cpp
>   lib/cpp/src/server/TNonblockingServer.h
> ---
>  lib/cpp/src/server/TNonblockingServer.cpp |  301 
> +++--
>  lib/cpp/src/server/TNonblockingServer.h   |  275 +--
>  2 files changed, 291 insertions(+), 285 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1305) thrift: make TConnection a private inner class of

[Dave Watson (JIRA)]

 thrift: make TConnection a private inner class of

---

 Key: THRIFT-1305
 URL: https://issues.apache.org/jira/browse/THRIFT-1305
 Project: Thrift
  Issue Type: Improvement
  Components: C++ - Library
Reporter: Dave Watson
Priority: Minor
 Attachments: 
0024-thrift-make-TConnection-a-private-inner-class-of-TNo.patch

>From 1f203754d8e9eb3e509cd874f6e5824eeaf5aa34 Mon Sep 17 00:00:00 2001
From: Adam Simpkins 
Date: Mon, 19 Apr 2010 19:09:13 +
Subject: [PATCH 24/33] thrift: make TConnection a private inner class of
 TNonblockingServer

Summary:
The immediate need for this is so that TConnection can access some
protected methods of TNonblockingServer.  However, it
seems a generally good thing to eliminate TConnection from the publicly
exposed API.

Test Plan:
Ran the tests from [fb unittest].

Revert Plan:
OK


Conflicts:

lib/cpp/src/server/TNonblockingServer.cpp
lib/cpp/src/server/TNonblockingServer.h
---
 lib/cpp/src/server/TNonblockingServer.cpp |  301 +++--
 lib/cpp/src/server/TNonblockingServer.h   |  275 +--
 2 files changed, 291 insertions(+), 285 deletions(-)



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1304) TNonblockingServer: pass in the connection context to

[Dave Watson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1304:


Attachment: 0023-TNonblockingServer-pass-in-the-connection-context-to.patch

>  TNonblockingServer: pass in the connection context to

> ---
>
> Key: THRIFT-1304
> URL: https://issues.apache.org/jira/browse/THRIFT-1304
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Attachments: 
> 0023-TNonblockingServer-pass-in-the-connection-context-to.patch
>
>
> From aa5cdf5b40e046b41a0c61e521dba0e78e1887b0 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Sat, 17 Apr 2010 01:10:15 +
> Subject: [PATCH 23/33] TNonblockingServer: pass in the connection context to
>  process()
> Summary:
> When using TNonblockingServer without a ThreadManager, it always passed
> NULL to process(), instead of passing in the context returned by
> TProcessorEventHandler::getContext().  This was broken and could cause
> TProcessorEventHandlers to crash, since they expected to get the value
> they had previously returned via getContext().
> Test Plan:
> Ran the test code in [fb unittest].  The non-threaded TNonblockingServer tests
> no longer crash.
> Revert Plan:
> OK
> ---
>  lib/cpp/src/server/TNonblockingServer.cpp |3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1304) TNonblockingServer: pass in the connection context to

[Dave Watson (JIRA)]

 TNonblockingServer: pass in the connection context to

---

 Key: THRIFT-1304
 URL: https://issues.apache.org/jira/browse/THRIFT-1304
 Project: Thrift
  Issue Type: Improvement
  Components: C++ - Library
Reporter: Dave Watson
Priority: Minor
 Attachments: 
0023-TNonblockingServer-pass-in-the-connection-context-to.patch

>From aa5cdf5b40e046b41a0c61e521dba0e78e1887b0 Mon Sep 17 00:00:00 2001
From: Adam Simpkins 
Date: Sat, 17 Apr 2010 01:10:15 +
Subject: [PATCH 23/33] TNonblockingServer: pass in the connection context to
 process()

Summary:
When using TNonblockingServer without a ThreadManager, it always passed
NULL to process(), instead of passing in the context returned by
TProcessorEventHandler::getContext().  This was broken and could cause
TProcessorEventHandlers to crash, since they expected to get the value
they had previously returned via getContext().

Test Plan:
Ran the test code in [fb unittest].  The non-threaded TNonblockingServer tests
no longer crash.

Revert Plan:
OK

---
 lib/cpp/src/server/TNonblockingServer.cpp |3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (THRIFT-1303) Twisted tutorial client does not include correct generated path

[Jake Farrell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell closed THRIFT-1303.


Resolution: Fixed

Updated client to include correct generated code path

> Twisted tutorial client does not include correct generated path
> ---
>
> Key: THRIFT-1303
> URL: https://issues.apache.org/jira/browse/THRIFT-1303
> Project: Thrift
>  Issue Type: Bug
>Reporter: Jake Farrell
>Assignee: Jake Farrell
>Priority: Minor
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1302) thrift: raise an exception if send() times out in

[Dave Watson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1302:


Attachment: 0022-thrift-raise-an-exception-if-send-times-out-in-TSock.patch

>  thrift: raise an exception if send() times out in

> ---
>
> Key: THRIFT-1302
> URL: https://issues.apache.org/jira/browse/THRIFT-1302
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Attachments: 
> 0022-thrift-raise-an-exception-if-send-times-out-in-TSock.patch
>
>
> From 1f76284b5972ab01d6f6ac68f96024a8066a3b59 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Fri, 16 Apr 2010 17:43:21 +
> Subject: [PATCH 22/33] thrift: raise an exception if send() times out in
>  TSocket::write()
> Summary:
> Previously, if send() timed out in TSocket::write(), it would sleep for
> 50 microseconds and retry.  This essentially made the timeout set with
> setSendTimeout() useless.  Now it raises a TTransportException on
> timeout.
> TNonblockingServer does use TSocket with the fd manually put in
> non-blocking mode, and that could cause EWOULDBLOCK and EAGAIN to occur
> during normal operation.  However, it only uses write_partial() and
> never write(), so it should be safe to have write() throw the exception.
> Test Plan:
> Used the client and server in thrift/tutorial/cpp/async/sort/ to test
> sending a large message to the server.  I set a 100ms timeout in the
> client, and verified that it correctly times out now if the server
> process is stopped.
> I also ran [fb unittests] to try and verify that this doesn't negatively
> affect any other code.
> Revert Plan:
> OK
> ---
>  lib/cpp/src/transport/TSocket.cpp |7 ---
>  1 files changed, 4 insertions(+), 3 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1303) Twisted tutorial client does not include correct generated path

[Jake Farrell (JIRA)]

Twisted tutorial client does not include correct generated path
---

 Key: THRIFT-1303
 URL: https://issues.apache.org/jira/browse/THRIFT-1303
 Project: Thrift
  Issue Type: Bug
Reporter: Jake Farrell
Assignee: Jake Farrell
Priority: Minor




--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1302) thrift: raise an exception if send() times out in

[Dave Watson (JIRA)]

 thrift: raise an exception if send() times out in

---

 Key: THRIFT-1302
 URL: https://issues.apache.org/jira/browse/THRIFT-1302
 Project: Thrift
  Issue Type: Improvement
  Components: C++ - Library
Reporter: Dave Watson
Priority: Minor


>From 1f76284b5972ab01d6f6ac68f96024a8066a3b59 Mon Sep 17 00:00:00 2001
From: Adam Simpkins 
Date: Fri, 16 Apr 2010 17:43:21 +
Subject: [PATCH 22/33] thrift: raise an exception if send() times out in
 TSocket::write()

Summary:
Previously, if send() timed out in TSocket::write(), it would sleep for
50 microseconds and retry.  This essentially made the timeout set with
setSendTimeout() useless.  Now it raises a TTransportException on
timeout.

TNonblockingServer does use TSocket with the fd manually put in
non-blocking mode, and that could cause EWOULDBLOCK and EAGAIN to occur
during normal operation.  However, it only uses write_partial() and
never write(), so it should be safe to have write() throw the exception.

Test Plan:
Used the client and server in thrift/tutorial/cpp/async/sort/ to test
sending a large message to the server.  I set a 100ms timeout in the
client, and verified that it correctly times out now if the server
process is stopped.

I also ran [fb unittests] to try and verify that this doesn't negatively
affect any other code.

Revert Plan:
OK

---
 lib/cpp/src/transport/TSocket.cpp |7 ---
 1 files changed, 4 insertions(+), 3 deletions(-)



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1301) thrift: consolidate common code in TNonblockingServer

[Dave Watson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1301:


Attachment: 0021-consolidate-common-code-2.patch

>  thrift: consolidate common code in TNonblockingServer

> ---
>
> Key: THRIFT-1301
> URL: https://issues.apache.org/jira/browse/THRIFT-1301
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Attachments: 0021-consolidate-common-code-2.patch
>
>
> From eb29276e934e6d445fb3226da9cb81b890be5cb7 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Fri, 16 Apr 2010 01:28:36 +
> Subject: [PATCH 21/33] thrift: consolidate common code in TNonblockingServer
>  constructors
> Summary:
> This moves most of the code in the initializer lists into a helper
> function.  I'm about to make a change that will double the number of
> constructors, and I'd rather not have to copy-and-paste these long
> initializers.
> Test Plan:
> Ran the tests from [fb unit test], and everything passes.
> Revert Plan:
> OK
> ---
>  lib/cpp/src/server/TNonblockingServer.h |  125 --
>  1 files changed, 50 insertions(+), 75 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1301) thrift: consolidate common code in TNonblockingServer

[Dave Watson (JIRA)]

 thrift: consolidate common code in TNonblockingServer

---

 Key: THRIFT-1301
 URL: https://issues.apache.org/jira/browse/THRIFT-1301
 Project: Thrift
  Issue Type: Improvement
  Components: C++ - Library
Reporter: Dave Watson
Priority: Minor


>From eb29276e934e6d445fb3226da9cb81b890be5cb7 Mon Sep 17 00:00:00 2001
From: Adam Simpkins 
Date: Fri, 16 Apr 2010 01:28:36 +
Subject: [PATCH 21/33] thrift: consolidate common code in TNonblockingServer
 constructors

Summary:
This moves most of the code in the initializer lists into a helper
function.  I'm about to make a change that will double the number of
constructors, and I'd rather not have to copy-and-paste these long
initializers.

Test Plan:
Ran the tests from [fb unit test], and everything passes.

Revert Plan:
OK

---
 lib/cpp/src/server/TNonblockingServer.h |  125 --
 1 files changed, 50 insertions(+), 75 deletions(-)



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1298) Standard scheme doesn't read or write metadata along with field values

[Armaan Sarkar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Armaan Sarkar updated THRIFT-1298:
--

Attachment: THRIFT-1289_v1.patch

> Standard scheme doesn't read or write metadata along with field values
> --
>
> Key: THRIFT-1298
> URL: https://issues.apache.org/jira/browse/THRIFT-1298
> Project: Thrift
>  Issue Type: Bug
>  Components: Java - Compiler
>Affects Versions: 0.8
>Reporter: Armaan Sarkar
>Assignee: Armaan Sarkar
> Fix For: 0.8
>
> Attachments: THRIFT-1289_v1.patch
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Metadata (such as field type, length, etc) is not read or written to by the 
> standard scheme. This is not the intended functionality. It causes problems 
> reading structs that were written before pluggable serializers came into 
> effect. Since the standard scheme is the default serializer it must function 
> exactly like thrift serialization did in the past (complete with metadata 
> surrounding the fields).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira