[jira] [Created] (THRIFT-1360) Move away from the "exception type" field in TExceptions

2011-09-23 Thread Bryan Duxbury (JIRA) 
Move away from the "exception type" field in TExceptions


 Key: THRIFT-1360
 URL: https://issues.apache.org/jira/browse/THRIFT-1360
 Project: Thrift
  Issue Type: Improvement
  Components: Java - Library
Reporter: Bryan Duxbury
Priority: Minor


It's a pain in the ass. Let's deprecate and use actual exception subclasses.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: Generating UUIDs

2011-09-23 Thread Davanum Srinivas 
JensG,

One option is to look at uuid support in APR
(http://svn.apache.org/viewvc/apr/apr/trunk/crypto/)

-- dims

On Fri, Sep 23, 2011 at 2:36 PM, Jens Geyer  wrote:
> Hi,
>
> I need the possibility to generate some GUIDs / UUIDs within Thrift
> compiler. Unfortunately MinGW seems not to contain the necessary lib and
> header files, or I just haven't looked at the right place. After some trying
> and two hours googling around and looking through different approaches I
> found a package which allows the usage of libuuid.a and uuid.h also under
> MinGW.
>
> http://sourceforge.net/projects/libuuidmingw/
>
> Although this solution would work perfectly, there's a problem: This piece
> of software is GPLv3.
>
> Does anybody know of another (better) solution to use uuid.h/libuuid with
> MinGW? Particularly, I need to call uuid_generate() and uuid_unparse().
>
> Any help would be appreciated,
> many thanks,
> JensG
>
>
>
>



-- 
Davanum Srinivas :: http://davanum.wordpress.com

Generating UUIDs

2011-09-23 Thread Jens Geyer 

Hi,

I need the possibility to generate some GUIDs / UUIDs within Thrift 
compiler. Unfortunately MinGW seems not to contain the necessary lib and 
header files, or I just haven't looked at the right place. After some trying 
and two hours googling around and looking through different approaches I 
found a package which allows the usage of libuuid.a and uuid.h also under 
MinGW.


http://sourceforge.net/projects/libuuidmingw/

Although this solution would work perfectly, there's a problem: This piece 
of software is GPLv3.


Does anybody know of another (better) solution to use uuid.h/libuuid with 
MinGW? Particularly, I need to call uuid_generate() and uuid_unparse().


Any help would be appreciated,
many thanks,
JensG

[jira] [Updated] (THRIFT-1359) --gen-cob cpp:cob_style does not compile anymore

2011-09-23 Thread alexandre parenteau (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

alexandre parenteau updated THRIFT-1359:


Attachment: THRIFT-1359.patch

Patch to fix compilation problem with cob style C++ (current trunk)

> --gen-cob cpp:cob_style does not compile anymore
> 
>
> Key: THRIFT-1359
> URL: https://issues.apache.org/jira/browse/THRIFT-1359
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Compiler, C++ - Library
>Affects Versions: 0.8
> Environment: Linux/Windows
>Reporter: alexandre parenteau
>  Labels: patch
> Fix For: 0.8
>
> Attachments: THRIFT-1359.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> A recent change introduced the concept of "getProcessor" (TProcessor). This 
> code does not take into account when generating cob style C++ 
> (TAsyncProcessor).
> TAsyncProcessor and TProcessor are unrelated, therefore it generates a 
> compilation problem when trying to pass smart pointers around.
> The included patch tries to address this, and was tested on Linux/Windows.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1359) --gen-cob cpp:cob_style does not compile anymore

2011-09-23 Thread alexandre parenteau (JIRA) 
--gen-cob cpp:cob_style does not compile anymore


 Key: THRIFT-1359
 URL: https://issues.apache.org/jira/browse/THRIFT-1359
 Project: Thrift
  Issue Type: Bug
  Components: C++ - Compiler, C++ - Library
Affects Versions: 0.8
 Environment: Linux/Windows
Reporter: alexandre parenteau
 Fix For: 0.8


A recent change introduced the concept of "getProcessor" (TProcessor). This 
code does not take into account when generating cob style C++ (TAsyncProcessor).

TAsyncProcessor and TProcessor are unrelated, therefore it generates a 
compilation problem when trying to pass smart pointers around.

The included patch tries to address this, and was tested on Linux/Windows.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1355) Running make in lib/rb doesn't build the native extensions

2011-09-23 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113612#comment-13113612
 ] 

Hudson commented on THRIFT-1355:


Integrated in Thrift #276 (See [https://builds.apache.org/job/Thrift/276/])
Thrift-1355: Running make in lib/rb doesn't build the native extensions
Client: rb
Patch: jfarrell

Builds extension prior to running spec calls to resolve test deps.


> Running make in lib/rb doesn't build the native extensions
> --
>
> Key: THRIFT-1355
> URL: https://issues.apache.org/jira/browse/THRIFT-1355
> Project: Thrift
>  Issue Type: Bug
>  Components: Ruby - Library
>Reporter: Takashi Yonebayashi
>Assignee: Jake Farrell
>Priority: Minor
> Fix For: 0.8
>
> Attachments: thrift-1355.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1355) Running make in lib/rb doesn't build the native extensions

2011-09-23 Thread Takashi Yonebayashi (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113582#comment-13113582
 ] 

Takashi Yonebayashi commented on THRIFT-1355:
-

Sweet, thanks.  

> Running make in lib/rb doesn't build the native extensions
> --
>
> Key: THRIFT-1355
> URL: https://issues.apache.org/jira/browse/THRIFT-1355
> Project: Thrift
>  Issue Type: Bug
>  Components: Ruby - Library
>Reporter: Takashi Yonebayashi
>Assignee: Jake Farrell
>Priority: Minor
> Fix For: 0.8
>
> Attachments: thrift-1355.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1355) Running make in lib/rb doesn't build the native extensions

2011-09-23 Thread Jake Farrell (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell updated THRIFT-1355:
-

Attachment: thrift-1355.patch

Fixes ruby build

> Running make in lib/rb doesn't build the native extensions
> --
>
> Key: THRIFT-1355
> URL: https://issues.apache.org/jira/browse/THRIFT-1355
> Project: Thrift
>  Issue Type: Bug
>  Components: Ruby - Library
>Reporter: Takashi Yonebayashi
>Assignee: Jake Farrell
>Priority: Minor
> Fix For: 0.8
>
> Attachments: thrift-1355.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (THRIFT-1355) Running make in lib/rb doesn't build the native extensions

2011-09-23 Thread Jake Farrell (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell closed THRIFT-1355.


   Resolution: Fixed
Fix Version/s: 0.8

committed 

> Running make in lib/rb doesn't build the native extensions
> --
>
> Key: THRIFT-1355
> URL: https://issues.apache.org/jira/browse/THRIFT-1355
> Project: Thrift
>  Issue Type: Bug
>  Components: Ruby - Library
>Reporter: Takashi Yonebayashi
>Assignee: Jake Farrell
>Priority: Minor
> Fix For: 0.8
>
> Attachments: thrift-1355.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1355) Running make in lib/rb doesn't build the native extensions

2011-09-23 Thread Takashi Yonebayashi (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113565#comment-13113565
 ] 

Takashi Yonebayashi commented on THRIFT-1355:
-

I think that's the issue then.  If specs are run before the extension is built, 
that would cause this problem.  The extension should be built before the specs 
are run.  

> Running make in lib/rb doesn't build the native extensions
> --
>
> Key: THRIFT-1355
> URL: https://issues.apache.org/jira/browse/THRIFT-1355
> Project: Thrift
>  Issue Type: Bug
>  Components: Ruby - Library
>Reporter: Takashi Yonebayashi
>Assignee: Jake Farrell
>Priority: Minor
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1358) Custom-scheme based version of Compact Protocol

2011-09-23 Thread Bryan Duxbury (JIRA) 
Custom-scheme based version of Compact Protocol
---

 Key: THRIFT-1358
 URL: https://issues.apache.org/jira/browse/THRIFT-1358
 Project: Thrift
  Issue Type: Improvement
  Components: Java - Compiler, Java - Library
Reporter: Bryan Duxbury


Now that there's general Scheme support, it would be cool to rework the Compact 
Protocol to use a custom scheme that tracks all the state. I think this could 
give it a nice CPU time improvement.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (THRIFT-1357) Erlang Dependency breaks build

2011-09-23 Thread Jake Farrell (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell reassigned THRIFT-1357:


Assignee: Jake Farrell

> Erlang Dependency breaks build
> --
>
> Key: THRIFT-1357
> URL: https://issues.apache.org/jira/browse/THRIFT-1357
> Project: Thrift
>  Issue Type: Bug
>  Components: Erlang - Library
> Environment: Apache build Infrastructure based on Ubuntu lucid
> {noformat}
> ii  erlang-base 1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP virtual machine and base applicat
> ii  erlang-crypto   1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP cryprographic modules
> ii  erlang-dev  1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP development libraries and headers
> ii  erlang-eunit1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP module for unit testing
> ii  erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP modules for handling abstract Erl
> ii  erlang-base 1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP virtual machine and base applicat
> ii  erlang-crypto   1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP cryprographic modules
> ii  erlang-dev  1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP development libraries and headers
> ii  erlang-eunit1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP module for unit testing
> ii  erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP modules for handling abstract Erl
> {noformat}
>Reporter: Roger Meier
>Assignee: Jake Farrell
>
> THRIFT-1227 introduced JSON for erlang,
> however the Ubuntu build infrastructur does not support this...
> {noformat}
> ./rebar get-deps
> ==> erl (get-deps)
> Pulling jsx from {git,"git://github.com/talentdeficit/jsx.git",{tag,"v0.9.0"}}
> Initialized empty Git repository in 
> /home/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/erl/deps/jsx/.git/
> ==> nicefloats (get-deps)
> ==> jsx (get-deps)
> ./rebar compile
> ==> nicefloats (compile)
> Compiled src/nicefloats.erl
> ==> jsx (compile)
> ./include/jsx_common.hrl:34: type jsx_opt() undefined
> ./include/jsx_common.hrl:66: type jsx_parser_result() undefined
> ./include/jsx_common.hrl:82: type eep0018_array() undefined
> ./include/jsx_common.hrl:82: type eep0018_object() undefined
> ./include/jsx_common.hrl:84: type eep0018_term() undefined
> ./include/jsx_common.hrl:85: type eep0018_key() undefined
> ./include/jsx_common.hrl:85: type eep0018_term() undefined
> ./include/jsx_common.hrl:91: type eep0018_string() undefined
> ./include/jsx_common.hrl:92: type eep0018_number() undefined
> ./include/jsx_common.hrl:100: type encoder_opt() undefined
> ./include/jsx_common.hrl:109: type decoder_opt() undefined
> ./include/jsx_common.hrl:117: type verify_opt() undefined
> ./include/jsx_common.hrl:123: type format_opt() undefined
> make[3]: *** [all] Error 1
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1357) Erlang Dependency breaks build

2011-09-23 Thread Roger Meier (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113508#comment-13113508
 ] 

Roger Meier commented on THRIFT-1357:
-

Jake, I like that idea! please proceed if you have some time to do this!

-roger

> Erlang Dependency breaks build
> --
>
> Key: THRIFT-1357
> URL: https://issues.apache.org/jira/browse/THRIFT-1357
> Project: Thrift
>  Issue Type: Bug
>  Components: Erlang - Library
> Environment: Apache build Infrastructure based on Ubuntu lucid
> {noformat}
> ii  erlang-base 1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP virtual machine and base applicat
> ii  erlang-crypto   1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP cryprographic modules
> ii  erlang-dev  1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP development libraries and headers
> ii  erlang-eunit1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP module for unit testing
> ii  erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP modules for handling abstract Erl
> ii  erlang-base 1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP virtual machine and base applicat
> ii  erlang-crypto   1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP cryprographic modules
> ii  erlang-dev  1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP development libraries and headers
> ii  erlang-eunit1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP module for unit testing
> ii  erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP modules for handling abstract Erl
> {noformat}
>Reporter: Roger Meier
>
> THRIFT-1227 introduced JSON for erlang,
> however the Ubuntu build infrastructur does not support this...
> {noformat}
> ./rebar get-deps
> ==> erl (get-deps)
> Pulling jsx from {git,"git://github.com/talentdeficit/jsx.git",{tag,"v0.9.0"}}
> Initialized empty Git repository in 
> /home/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/erl/deps/jsx/.git/
> ==> nicefloats (get-deps)
> ==> jsx (get-deps)
> ./rebar compile
> ==> nicefloats (compile)
> Compiled src/nicefloats.erl
> ==> jsx (compile)
> ./include/jsx_common.hrl:34: type jsx_opt() undefined
> ./include/jsx_common.hrl:66: type jsx_parser_result() undefined
> ./include/jsx_common.hrl:82: type eep0018_array() undefined
> ./include/jsx_common.hrl:82: type eep0018_object() undefined
> ./include/jsx_common.hrl:84: type eep0018_term() undefined
> ./include/jsx_common.hrl:85: type eep0018_key() undefined
> ./include/jsx_common.hrl:85: type eep0018_term() undefined
> ./include/jsx_common.hrl:91: type eep0018_string() undefined
> ./include/jsx_common.hrl:92: type eep0018_number() undefined
> ./include/jsx_common.hrl:100: type encoder_opt() undefined
> ./include/jsx_common.hrl:109: type decoder_opt() undefined
> ./include/jsx_common.hrl:117: type verify_opt() undefined
> ./include/jsx_common.hrl:123: type format_opt() undefined
> make[3]: *** [all] Error 1
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1031) Patch to compile Thrift for vc++ 9.0 and 10.0

2011-09-23 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113491#comment-13113491
 ] 

Hudson commented on THRIFT-1031:


Integrated in Thrift #275 (See [https://builds.apache.org/job/Thrift/275/])
THRIFT-1031 Patch to compile Thrift for vc++ 9.0 and 10.0
=> some more improvements

Patch: James Dickson

roger : http://svn.apache.org/viewvc/?view=rev&rev=1174801
Files : 
* /thrift/trunk/compiler/cpp/compiler.sln
* /thrift/trunk/compiler/cpp/compiler.vcxproj
* /thrift/trunk/compiler/cpp/compiler.vcxproj.filters
* /thrift/trunk/lib/cpp/libthrift.vcxproj
* /thrift/trunk/lib/cpp/src/Thrift.h
* /thrift/trunk/lib/cpp/src/transport/TSocket.cpp
* /thrift/trunk/lib/cpp/src/windows/TargetVersion.h
* /thrift/trunk/lib/cpp/src/windows/config.h
* /thrift/trunk/lib/cpp/src/windows/force_inc.h


> Patch to compile Thrift for vc++ 9.0 and 10.0
> -
>
> Key: THRIFT-1031
> URL: https://issues.apache.org/jira/browse/THRIFT-1031
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
> Environment: Windows XP 32bit, vc++ 9.0, 10.0
>Reporter: James Dickson
>Assignee: Roger Meier
>Priority: Trivial
> Fix For: 0.8
>
> Attachments: thrift_msvc.patch, thrift_msvc_v0_1.patch, 
> thrift_msvc_v0_2.patch, thrift_msvc_v0_3.patch, thrift_msvc_v0_4.patch, 
> thrift_msvc_v0_5.patch, thrift_msvc_v0_6.patch, thrift_msvc_v0_7.patch
>
>
> At our company we need clients running on Windows being able to connect to 
> our linux servers running hypertable. The attached patch enables the parts 
> needed by Hypertable to be compiled on Windows using either the VC++ 9.0 or 
> 10.0 compilers.
> Having read previous posts about ports using boost::asio we found these to be 
> too intrusive for our needs. This version uses pthreads_win32 and winsock2 
> and is as designed to be as un-intrusive as is possible to the original unix 
> code base. It is mostly #defines between unix sockets and winsock2 sockets. 
> We also tried to follow the folder structuring of the C# runtime that has 
> visual studio solutions to be consistent.
> More details are in the README as not all the functionality of the original 
> unix code base is available to windows users. We will add the missing 
> functionality, we just wanted to share what we had as for a Windows based 
> client for us it is sufficient.
> The patch is based on the latest revision in SVN, we would love feedback and 
> any code reviews. If there is any possibility of this being added to the main 
> trunk then that would be much appreciated, however we don't expect that.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Jenkins build is back to normal : Thrift #274

2011-09-23 Thread Apache Jenkins Server 
See

[jira] [Commented] (THRIFT-1357) Erlang Dependency breaks build

2011-09-23 Thread Jake Farrell (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113476#comment-13113476
 ] 

Jake Farrell commented on THRIFT-1357:
--

The build infra is a stock ubuntu with only the required packages to help keep 
the system stable and in a known 'good' state. If the jsx lib depends on a 
specific version of erl then we should add that check into configure and if not 
met dont allow the erl client lib to be built (similar to ruby and the spec vs 
rspec versioning issue). If you are good with this path then I can throw 
together a patch to detect the erlang version on initial configure which should 
resolve this

> Erlang Dependency breaks build
> --
>
> Key: THRIFT-1357
> URL: https://issues.apache.org/jira/browse/THRIFT-1357
> Project: Thrift
>  Issue Type: Bug
>  Components: Erlang - Library
> Environment: Apache build Infrastructure based on Ubuntu lucid
> {noformat}
> ii  erlang-base 1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP virtual machine and base applicat
> ii  erlang-crypto   1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP cryprographic modules
> ii  erlang-dev  1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP development libraries and headers
> ii  erlang-eunit1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP module for unit testing
> ii  erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP modules for handling abstract Erl
> ii  erlang-base 1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP virtual machine and base applicat
> ii  erlang-crypto   1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP cryprographic modules
> ii  erlang-dev  1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP development libraries and headers
> ii  erlang-eunit1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP module for unit testing
> ii  erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP modules for handling abstract Erl
> {noformat}
>Reporter: Roger Meier
>
> THRIFT-1227 introduced JSON for erlang,
> however the Ubuntu build infrastructur does not support this...
> {noformat}
> ./rebar get-deps
> ==> erl (get-deps)
> Pulling jsx from {git,"git://github.com/talentdeficit/jsx.git",{tag,"v0.9.0"}}
> Initialized empty Git repository in 
> /home/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/erl/deps/jsx/.git/
> ==> nicefloats (get-deps)
> ==> jsx (get-deps)
> ./rebar compile
> ==> nicefloats (compile)
> Compiled src/nicefloats.erl
> ==> jsx (compile)
> ./include/jsx_common.hrl:34: type jsx_opt() undefined
> ./include/jsx_common.hrl:66: type jsx_parser_result() undefined
> ./include/jsx_common.hrl:82: type eep0018_array() undefined
> ./include/jsx_common.hrl:82: type eep0018_object() undefined
> ./include/jsx_common.hrl:84: type eep0018_term() undefined
> ./include/jsx_common.hrl:85: type eep0018_key() undefined
> ./include/jsx_common.hrl:85: type eep0018_term() undefined
> ./include/jsx_common.hrl:91: type eep0018_string() undefined
> ./include/jsx_common.hrl:92: type eep0018_number() undefined
> ./include/jsx_common.hrl:100: type encoder_opt() undefined
> ./include/jsx_common.hrl:109: type decoder_opt() undefined
> ./include/jsx_common.hrl:117: type verify_opt() undefined
> ./include/jsx_common.hrl:123: type format_opt() undefined
> make[3]: *** [all] Error 1
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1031) Patch to compile Thrift for vc++ 9.0 and 10.0

2011-09-23 Thread Roger Meier (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113474#comment-13113474
 ] 

Roger Meier commented on THRIFT-1031:
-

Thanks! just committed patch 0_7

> Patch to compile Thrift for vc++ 9.0 and 10.0
> -
>
> Key: THRIFT-1031
> URL: https://issues.apache.org/jira/browse/THRIFT-1031
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
> Environment: Windows XP 32bit, vc++ 9.0, 10.0
>Reporter: James Dickson
>Assignee: Roger Meier
>Priority: Trivial
> Fix For: 0.8
>
> Attachments: thrift_msvc.patch, thrift_msvc_v0_1.patch, 
> thrift_msvc_v0_2.patch, thrift_msvc_v0_3.patch, thrift_msvc_v0_4.patch, 
> thrift_msvc_v0_5.patch, thrift_msvc_v0_6.patch, thrift_msvc_v0_7.patch
>
>
> At our company we need clients running on Windows being able to connect to 
> our linux servers running hypertable. The attached patch enables the parts 
> needed by Hypertable to be compiled on Windows using either the VC++ 9.0 or 
> 10.0 compilers.
> Having read previous posts about ports using boost::asio we found these to be 
> too intrusive for our needs. This version uses pthreads_win32 and winsock2 
> and is as designed to be as un-intrusive as is possible to the original unix 
> code base. It is mostly #defines between unix sockets and winsock2 sockets. 
> We also tried to follow the folder structuring of the C# runtime that has 
> visual studio solutions to be consistent.
> More details are in the README as not all the functionality of the original 
> unix code base is available to windows users. We will add the missing 
> functionality, we just wanted to share what we had as for a Windows based 
> client for us it is sufficient.
> The patch is based on the latest revision in SVN, we would love feedback and 
> any code reviews. If there is any possibility of this being added to the main 
> trunk then that would be much appreciated, however we don't expect that.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1357) Erlang Dependency breaks build

2011-09-23 Thread Roger Meier (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113470#comment-13113470
 ] 

Roger Meier commented on THRIFT-1357:
-

I have disabled continous build for erlang for the moment.
https://builds.apache.org/view/S-Z/view/Thrift/job/Thrift/

> Erlang Dependency breaks build
> --
>
> Key: THRIFT-1357
> URL: https://issues.apache.org/jira/browse/THRIFT-1357
> Project: Thrift
>  Issue Type: Bug
>  Components: Erlang - Library
> Environment: Apache build Infrastructure based on Ubuntu lucid
> {noformat}
> ii  erlang-base 1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP virtual machine and base applicat
> ii  erlang-crypto   1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP cryprographic modules
> ii  erlang-dev  1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP development libraries and headers
> ii  erlang-eunit1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP module for unit testing
> ii  erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP modules for handling abstract Erl
> ii  erlang-base 1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP virtual machine and base applicat
> ii  erlang-crypto   1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP cryprographic modules
> ii  erlang-dev  1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP development libraries and headers
> ii  erlang-eunit1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP module for unit testing
> ii  erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP modules for handling abstract Erl
> {noformat}
>Reporter: Roger Meier
>
> THRIFT-1227 introduced JSON for erlang,
> however the Ubuntu build infrastructur does not support this...
> {noformat}
> ./rebar get-deps
> ==> erl (get-deps)
> Pulling jsx from {git,"git://github.com/talentdeficit/jsx.git",{tag,"v0.9.0"}}
> Initialized empty Git repository in 
> /home/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/erl/deps/jsx/.git/
> ==> nicefloats (get-deps)
> ==> jsx (get-deps)
> ./rebar compile
> ==> nicefloats (compile)
> Compiled src/nicefloats.erl
> ==> jsx (compile)
> ./include/jsx_common.hrl:34: type jsx_opt() undefined
> ./include/jsx_common.hrl:66: type jsx_parser_result() undefined
> ./include/jsx_common.hrl:82: type eep0018_array() undefined
> ./include/jsx_common.hrl:82: type eep0018_object() undefined
> ./include/jsx_common.hrl:84: type eep0018_term() undefined
> ./include/jsx_common.hrl:85: type eep0018_key() undefined
> ./include/jsx_common.hrl:85: type eep0018_term() undefined
> ./include/jsx_common.hrl:91: type eep0018_string() undefined
> ./include/jsx_common.hrl:92: type eep0018_number() undefined
> ./include/jsx_common.hrl:100: type encoder_opt() undefined
> ./include/jsx_common.hrl:109: type decoder_opt() undefined
> ./include/jsx_common.hrl:117: type verify_opt() undefined
> ./include/jsx_common.hrl:123: type format_opt() undefined
> make[3]: *** [all] Error 1
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1331) Ruby library deserializes an empty map to nil

2011-09-23 Thread Jake Farrell (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113468#comment-13113468
 ] 

Jake Farrell commented on THRIFT-1331:
--

THRIFT-1355 caused by the "should deserialize an empty map to an empty hash" 
test in compact_protocol_spec.rb added in this patch. This test case if failing 
and breaking the build. 

> Ruby library deserializes an empty map to nil
> -
>
> Key: THRIFT-1331
> URL: https://issues.apache.org/jira/browse/THRIFT-1331
> Project: Thrift
>  Issue Type: Bug
>  Components: Ruby - Library
>Affects Versions: 0.7, 0.8
>Reporter: Armaan Sarkar
>Assignee: Armaan Sarkar
> Fix For: 0.8
>
> Attachments: THRIFT-1331_v1.patch, THRIFT-1331_v2.patch, 
> THRIFT-1331_v3.patch
>
>
> The problem occurs when deserializing an empty map. Instead of deserializing 
> to an empty hash in Ruby, Thrift currently makes it a nil object. This poses 
> a variety of problems and is not the intended/original behavior. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1357) Erlang Dependency breaks build

2011-09-23 Thread Roger Meier (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Roger Meier updated THRIFT-1357:


Component/s: Erlang - Library

> Erlang Dependency breaks build
> --
>
> Key: THRIFT-1357
> URL: https://issues.apache.org/jira/browse/THRIFT-1357
> Project: Thrift
>  Issue Type: Bug
>  Components: Erlang - Library
> Environment: Apache build Infrastructure based on Ubuntu lucid
> {noformat}
> ii  erlang-base 1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP virtual machine and base applicat
> ii  erlang-crypto   1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP cryprographic modules
> ii  erlang-dev  1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP development libraries and headers
> ii  erlang-eunit1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP module for unit testing
> ii  erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP modules for handling abstract Erl
> ii  erlang-base 1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP virtual machine and base applicat
> ii  erlang-crypto   1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP cryprographic modules
> ii  erlang-dev  1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP development libraries and headers
> ii  erlang-eunit1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP module for unit testing
> ii  erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1  
>   Erlang/OTP modules for handling abstract Erl
> {noformat}
>Reporter: Roger Meier
>
> THRIFT-1227 introduced JSON for erlang,
> however the Ubuntu build infrastructur does not support this...
> {noformat}
> ./rebar get-deps
> ==> erl (get-deps)
> Pulling jsx from {git,"git://github.com/talentdeficit/jsx.git",{tag,"v0.9.0"}}
> Initialized empty Git repository in 
> /home/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/erl/deps/jsx/.git/
> ==> nicefloats (get-deps)
> ==> jsx (get-deps)
> ./rebar compile
> ==> nicefloats (compile)
> Compiled src/nicefloats.erl
> ==> jsx (compile)
> ./include/jsx_common.hrl:34: type jsx_opt() undefined
> ./include/jsx_common.hrl:66: type jsx_parser_result() undefined
> ./include/jsx_common.hrl:82: type eep0018_array() undefined
> ./include/jsx_common.hrl:82: type eep0018_object() undefined
> ./include/jsx_common.hrl:84: type eep0018_term() undefined
> ./include/jsx_common.hrl:85: type eep0018_key() undefined
> ./include/jsx_common.hrl:85: type eep0018_term() undefined
> ./include/jsx_common.hrl:91: type eep0018_string() undefined
> ./include/jsx_common.hrl:92: type eep0018_number() undefined
> ./include/jsx_common.hrl:100: type encoder_opt() undefined
> ./include/jsx_common.hrl:109: type decoder_opt() undefined
> ./include/jsx_common.hrl:117: type verify_opt() undefined
> ./include/jsx_common.hrl:123: type format_opt() undefined
> make[3]: *** [all] Error 1
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1357) Erlang Dependency breaks build

2011-09-23 Thread Roger Meier (JIRA) 
Erlang Dependency breaks build
--

 Key: THRIFT-1357
 URL: https://issues.apache.org/jira/browse/THRIFT-1357
 Project: Thrift
  Issue Type: Bug
 Environment: Apache build Infrastructure based on Ubuntu lucid
{noformat}
ii  erlang-base 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP virtual machine and base applicat
ii  erlang-crypto   1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP cryprographic modules
ii  erlang-dev  1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP development libraries and headers
ii  erlang-eunit1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP module for unit testing
ii  erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP modules for handling abstract Erl
ii  erlang-base 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP virtual machine and base applicat
ii  erlang-crypto   1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP cryprographic modules
ii  erlang-dev  1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP development libraries and headers
ii  erlang-eunit1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP module for unit testing
ii  erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP modules for handling abstract Erl
{noformat}

Reporter: Roger Meier


THRIFT-1227 introduced JSON for erlang,
however the Ubuntu build infrastructur does not support this...
{noformat}
./rebar get-deps
==> erl (get-deps)
Pulling jsx from {git,"git://github.com/talentdeficit/jsx.git",{tag,"v0.9.0"}}
Initialized empty Git repository in 
/home/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/erl/deps/jsx/.git/
==> nicefloats (get-deps)
==> jsx (get-deps)
./rebar compile
==> nicefloats (compile)
Compiled src/nicefloats.erl
==> jsx (compile)
./include/jsx_common.hrl:34: type jsx_opt() undefined
./include/jsx_common.hrl:66: type jsx_parser_result() undefined
./include/jsx_common.hrl:82: type eep0018_array() undefined
./include/jsx_common.hrl:82: type eep0018_object() undefined
./include/jsx_common.hrl:84: type eep0018_term() undefined
./include/jsx_common.hrl:85: type eep0018_key() undefined
./include/jsx_common.hrl:85: type eep0018_term() undefined
./include/jsx_common.hrl:91: type eep0018_string() undefined
./include/jsx_common.hrl:92: type eep0018_number() undefined
./include/jsx_common.hrl:100: type encoder_opt() undefined
./include/jsx_common.hrl:109: type decoder_opt() undefined
./include/jsx_common.hrl:117: type verify_opt() undefined
./include/jsx_common.hrl:123: type format_opt() undefined
make[3]: *** [all] Error 1
{noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1355) Running make in lib/rb doesn't build the native extensions

2011-09-23 Thread Jake Farrell (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113465#comment-13113465
 ] 

Jake Farrell commented on THRIFT-1355:
--

The test case added in THRIFT-1331 for CompactProtocolFactory deserializing an 
empty map to an empty hash is failing. removing this test from 
compact_protocol_spec.rb allowed realspec call to correctly finish and then the 
extension and gem to be created. Tracking down issue and will have a patch 
shortly 

> Running make in lib/rb doesn't build the native extensions
> --
>
> Key: THRIFT-1355
> URL: https://issues.apache.org/jira/browse/THRIFT-1355
> Project: Thrift
>  Issue Type: Bug
>  Components: Ruby - Library
>Reporter: Takashi Yonebayashi
>Assignee: Jake Farrell
>Priority: Minor
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Issue Comment Edited] (THRIFT-1031) Patch to compile Thrift for vc++ 9.0 and 10.0

2011-09-23 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/THRIFT-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113391#comment-13113391
 ] 

Aurélien Revol edited comment on THRIFT-1031 at 9/23/11 1:10 PM:
-

Hi all,

Thanks for the Windows port, it's great work! My last obstacle to using it, 
though, is that I have to build it in *VC++ 9.0*; unfortunately, starting from 
??thrift_msvc_v0_2.patch??, the project files are *VC++ 10.0 only*. Is this a 
deliberate and necessary choice, or is there a way for me to undo this?

Another question: a port to MinGW/MSYS would be great, since the rest of the 
project is based on the autotools, and we have native Win32 code here. Do you 
think these sources are compatible with MinGW? How much effort would be needed 
make it work with the autotools scripts?

  was (Author: arevol):
Hi all,

Thanks for the Windows port, it's great work! My last obstacle to using it, 
though, is that I have to build it in *VC++ 9.0*; unfortunately, starting from 
??thrift_msvc_v0_2.patch??, the project files are *VC++ 10.0 only*. Is this a 
deliberate and necessary choice, or is there a way for me to undo this?

Another question: a port to MinGW/MSYS would be great, since the rest of the 
project is based on the autotools, and we have native Win32 code here. Do you 
think these patches would be compatible with gcc? How much effort would be 
needed to integrate them in the autotools scripts?
  
> Patch to compile Thrift for vc++ 9.0 and 10.0
> -
>
> Key: THRIFT-1031
> URL: https://issues.apache.org/jira/browse/THRIFT-1031
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
> Environment: Windows XP 32bit, vc++ 9.0, 10.0
>Reporter: James Dickson
>Assignee: Roger Meier
>Priority: Trivial
> Fix For: 0.8
>
> Attachments: thrift_msvc.patch, thrift_msvc_v0_1.patch, 
> thrift_msvc_v0_2.patch, thrift_msvc_v0_3.patch, thrift_msvc_v0_4.patch, 
> thrift_msvc_v0_5.patch, thrift_msvc_v0_6.patch, thrift_msvc_v0_7.patch
>
>
> At our company we need clients running on Windows being able to connect to 
> our linux servers running hypertable. The attached patch enables the parts 
> needed by Hypertable to be compiled on Windows using either the VC++ 9.0 or 
> 10.0 compilers.
> Having read previous posts about ports using boost::asio we found these to be 
> too intrusive for our needs. This version uses pthreads_win32 and winsock2 
> and is as designed to be as un-intrusive as is possible to the original unix 
> code base. It is mostly #defines between unix sockets and winsock2 sockets. 
> We also tried to follow the folder structuring of the C# runtime that has 
> visual studio solutions to be consistent.
> More details are in the README as not all the functionality of the original 
> unix code base is available to windows users. We will add the missing 
> functionality, we just wanted to share what we had as for a Windows based 
> client for us it is sufficient.
> The patch is based on the latest revision in SVN, we would love feedback and 
> any code reviews. If there is any possibility of this being added to the main 
> trunk then that would be much appreciated, however we don't expect that.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1031) Patch to compile Thrift for vc++ 9.0 and 10.0

2011-09-23 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/THRIFT-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113391#comment-13113391
 ] 

Aurélien Revol commented on THRIFT-1031:


Hi all,

Thanks for the Windows port, it's great work! My last obstacle to using it, 
though, is that I have to build it in *VC++ 9.0*; unfortunately, starting from 
??thrift_msvc_v0_2.patch??, the project files are *VC++ 10.0 only*. Is this a 
deliberate and necessary choice, or is there a way for me to undo this?

Another question: a port to MinGW/MSYS would be great, since the rest of the 
project is based on the autotools, and we have native Win32 code here. Do you 
think these patches would be compatible with gcc? How much effort would be 
needed to integrate them in the autotools scripts?

> Patch to compile Thrift for vc++ 9.0 and 10.0
> -
>
> Key: THRIFT-1031
> URL: https://issues.apache.org/jira/browse/THRIFT-1031
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
> Environment: Windows XP 32bit, vc++ 9.0, 10.0
>Reporter: James Dickson
>Assignee: Roger Meier
>Priority: Trivial
> Fix For: 0.8
>
> Attachments: thrift_msvc.patch, thrift_msvc_v0_1.patch, 
> thrift_msvc_v0_2.patch, thrift_msvc_v0_3.patch, thrift_msvc_v0_4.patch, 
> thrift_msvc_v0_5.patch, thrift_msvc_v0_6.patch, thrift_msvc_v0_7.patch
>
>
> At our company we need clients running on Windows being able to connect to 
> our linux servers running hypertable. The attached patch enables the parts 
> needed by Hypertable to be compiled on Windows using either the VC++ 9.0 or 
> 10.0 compilers.
> Having read previous posts about ports using boost::asio we found these to be 
> too intrusive for our needs. This version uses pthreads_win32 and winsock2 
> and is as designed to be as un-intrusive as is possible to the original unix 
> code base. It is mostly #defines between unix sockets and winsock2 sockets. 
> We also tried to follow the folder structuring of the C# runtime that has 
> visual studio solutions to be consistent.
> More details are in the README as not all the functionality of the original 
> unix code base is available to windows users. We will add the missing 
> functionality, we just wanted to share what we had as for a Windows based 
> client for us it is sufficient.
> The patch is based on the latest revision in SVN, we would love feedback and 
> any code reviews. If there is any possibility of this being added to the main 
> trunk then that would be much appreciated, however we don't expect that.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Issue Comment Edited] (THRIFT-1031) Patch to compile Thrift for vc++ 9.0 and 10.0

2011-09-23 Thread James Dickson (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113289#comment-13113289
 ] 

James Dickson edited comment on THRIFT-1031 at 9/23/11 9:36 AM:


New version added - 0_7.
@alexandre: 1. Yep, not sure what else to do short so if you have any 
suggestions please let me know. 2-7 are done, Please see the changes in 0_7.

Also a couple of bug fixes with the non-blocking path. On windows the connect 
method returns EWOULDBLOCK instead of EINPROGRESS when non blocking is set on 
the socket.

  was (Author: jamesd):
New version added - 0_7.
@alexandre: 1-7 done. Please see the changes in 0_7.

Also a couple of bug fixes with the non-blocking path. On windows the connect 
method returns EWOULDBLOCK instead of EINPROGRESS when non blocking is set on 
the socket.
  
> Patch to compile Thrift for vc++ 9.0 and 10.0
> -
>
> Key: THRIFT-1031
> URL: https://issues.apache.org/jira/browse/THRIFT-1031
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
> Environment: Windows XP 32bit, vc++ 9.0, 10.0
>Reporter: James Dickson
>Assignee: Roger Meier
>Priority: Trivial
> Fix For: 0.8
>
> Attachments: thrift_msvc.patch, thrift_msvc_v0_1.patch, 
> thrift_msvc_v0_2.patch, thrift_msvc_v0_3.patch, thrift_msvc_v0_4.patch, 
> thrift_msvc_v0_5.patch, thrift_msvc_v0_6.patch, thrift_msvc_v0_7.patch
>
>
> At our company we need clients running on Windows being able to connect to 
> our linux servers running hypertable. The attached patch enables the parts 
> needed by Hypertable to be compiled on Windows using either the VC++ 9.0 or 
> 10.0 compilers.
> Having read previous posts about ports using boost::asio we found these to be 
> too intrusive for our needs. This version uses pthreads_win32 and winsock2 
> and is as designed to be as un-intrusive as is possible to the original unix 
> code base. It is mostly #defines between unix sockets and winsock2 sockets. 
> We also tried to follow the folder structuring of the C# runtime that has 
> visual studio solutions to be consistent.
> More details are in the README as not all the functionality of the original 
> unix code base is available to windows users. We will add the missing 
> functionality, we just wanted to share what we had as for a Windows based 
> client for us it is sufficient.
> The patch is based on the latest revision in SVN, we would love feedback and 
> any code reviews. If there is any possibility of this being added to the main 
> trunk then that would be much appreciated, however we don't expect that.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1031) Patch to compile Thrift for vc++ 9.0 and 10.0

2011-09-23 Thread James Dickson (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113289#comment-13113289
 ] 

James Dickson commented on THRIFT-1031:
---

New version added - 0_7.
@alexandre: 1-7 done. Please see the changes in 0_7.

Also a couple of bug fixes with the non-blocking path. On windows the connect 
method returns EWOULDBLOCK instead of EINPROGRESS when non blocking is set on 
the socket.

> Patch to compile Thrift for vc++ 9.0 and 10.0
> -
>
> Key: THRIFT-1031
> URL: https://issues.apache.org/jira/browse/THRIFT-1031
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
> Environment: Windows XP 32bit, vc++ 9.0, 10.0
>Reporter: James Dickson
>Assignee: Roger Meier
>Priority: Trivial
> Fix For: 0.8
>
> Attachments: thrift_msvc.patch, thrift_msvc_v0_1.patch, 
> thrift_msvc_v0_2.patch, thrift_msvc_v0_3.patch, thrift_msvc_v0_4.patch, 
> thrift_msvc_v0_5.patch, thrift_msvc_v0_6.patch, thrift_msvc_v0_7.patch
>
>
> At our company we need clients running on Windows being able to connect to 
> our linux servers running hypertable. The attached patch enables the parts 
> needed by Hypertable to be compiled on Windows using either the VC++ 9.0 or 
> 10.0 compilers.
> Having read previous posts about ports using boost::asio we found these to be 
> too intrusive for our needs. This version uses pthreads_win32 and winsock2 
> and is as designed to be as un-intrusive as is possible to the original unix 
> code base. It is mostly #defines between unix sockets and winsock2 sockets. 
> We also tried to follow the folder structuring of the C# runtime that has 
> visual studio solutions to be consistent.
> More details are in the README as not all the functionality of the original 
> unix code base is available to windows users. We will add the missing 
> functionality, we just wanted to share what we had as for a Windows based 
> client for us it is sufficient.
> The patch is based on the latest revision in SVN, we would love feedback and 
> any code reviews. If there is any possibility of this being added to the main 
> trunk then that would be much appreciated, however we don't expect that.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1031) Patch to compile Thrift for vc++ 9.0 and 10.0

2011-09-23 Thread James Dickson (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Dickson updated THRIFT-1031:
--

Attachment: thrift_msvc_v0_7.patch

> Patch to compile Thrift for vc++ 9.0 and 10.0
> -
>
> Key: THRIFT-1031
> URL: https://issues.apache.org/jira/browse/THRIFT-1031
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
> Environment: Windows XP 32bit, vc++ 9.0, 10.0
>Reporter: James Dickson
>Assignee: Roger Meier
>Priority: Trivial
> Fix For: 0.8
>
> Attachments: thrift_msvc.patch, thrift_msvc_v0_1.patch, 
> thrift_msvc_v0_2.patch, thrift_msvc_v0_3.patch, thrift_msvc_v0_4.patch, 
> thrift_msvc_v0_5.patch, thrift_msvc_v0_6.patch, thrift_msvc_v0_7.patch
>
>
> At our company we need clients running on Windows being able to connect to 
> our linux servers running hypertable. The attached patch enables the parts 
> needed by Hypertable to be compiled on Windows using either the VC++ 9.0 or 
> 10.0 compilers.
> Having read previous posts about ports using boost::asio we found these to be 
> too intrusive for our needs. This version uses pthreads_win32 and winsock2 
> and is as designed to be as un-intrusive as is possible to the original unix 
> code base. It is mostly #defines between unix sockets and winsock2 sockets. 
> We also tried to follow the folder structuring of the C# runtime that has 
> visual studio solutions to be consistent.
> More details are in the README as not all the functionality of the original 
> unix code base is available to windows users. We will add the missing 
> functionality, we just wanted to share what we had as for a Windows based 
> client for us it is sufficient.
> The patch is based on the latest revision in SVN, we would love feedback and 
> any code reviews. If there is any possibility of this being added to the main 
> trunk then that would be much appreciated, however we don't expect that.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1356) Memory leak and other issues in TSocketClient

2011-09-23 Thread Matthew Phillips (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matthew Phillips updated THRIFT-1356:
-

Attachment: TSocketClient.m

Fixed version of TSocketClient (change from 0.7).

> Memory leak and other issues in TSocketClient
> -
>
> Key: THRIFT-1356
> URL: https://issues.apache.org/jira/browse/THRIFT-1356
> Project: Thrift
>  Issue Type: Bug
>  Components: Cocoa - Library
>Affects Versions: 0.7
> Environment: iOS 4.3
>Reporter: Matthew Phillips
> Attachments: TSocketClient.m
>
>
> The socket setup code in TSocketClient seems to have been copied blindly from 
> Apple's docs. The two problems with that are:
>  (a) The example is for non-blocking event-based network IO, but Thrift uses 
> it in blocking mode and does not handle the delegate events it registers for. 
> This causes network operations to randomly hang.
>  (b) It retains the input and output streams, which already have a retain 
> count of 1, and which are then retained again by the superclass, causing a 
> memory leak.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1356) Memory leak and other issues in TSocketClient

2011-09-23 Thread Matthew Phillips (JIRA) 
Memory leak and other issues in TSocketClient
-

 Key: THRIFT-1356
 URL: https://issues.apache.org/jira/browse/THRIFT-1356
 Project: Thrift
  Issue Type: Bug
  Components: Cocoa - Library
Affects Versions: 0.7
 Environment: iOS 4.3
Reporter: Matthew Phillips


The socket setup code in TSocketClient seems to have been copied blindly from 
Apple's docs. The two problems with that are:

 (a) The example is for non-blocking event-based network IO, but Thrift uses it 
in blocking mode and does not handle the delegate events it registers for. This 
causes network operations to randomly hang.

 (b) It retains the input and output streams, which already have a retain count 
of 1, and which are then retained again by the superclass, causing a memory 
leak.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira