[jira] [Commented] (THRIFT-1550) Contributing Thrift: The Missing Guide
[ https://issues.apache.org/jira/browse/THRIFT-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13276373#comment-13276373 ] Jake Farrell commented on THRIFT-1550: -- Diwaker, thank you for the work on this guide, merging this with the new site now Contributing Thrift: The Missing Guide Key: THRIFT-1550 URL: https://issues.apache.org/jira/browse/THRIFT-1550 Project: Thrift Issue Type: Improvement Components: Documentation Reporter: Diwaker Gupta Assignee: Jake Farrell Priority: Minor Attachments: diwakergupta-thrift-missing-guide-3976f06.tar.gz I'm contributing the guide available at http://diwakergupta.github.com/thrift-missing-guide/ for use by the Thrift project on it's website. The original guide will remain online but I will include a pointer in BIG BOLD letters to the updated Thrift website when it is up. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1519) Thirft Build Failure referencing rb_intern2 symbol
[ https://issues.apache.org/jira/browse/THRIFT-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13276394#comment-13276394 ] Jake Farrell commented on THRIFT-1519: -- Ilya, are you still having this issue? I can not reproduce and I have tried several operating systems. On OS X 10.7.3 with default ruby 1.8.7 and showing no issues gem build thrift.gemspec Successfully built RubyGem Name: thrift Version: 0.9.0.1 File: thrift-0.9.0.1.gem Thirft Build Failure referencing rb_intern2 symbol -- Key: THRIFT-1519 URL: https://issues.apache.org/jira/browse/THRIFT-1519 Project: Thrift Issue Type: Bug Components: Ruby - Library Affects Versions: 0.8 Environment: bash-3.00# uname -a SunOS nc17a 5.10 Generic_127127-11 sun4u sparc SUNW,A70 Solaris python 2.6 bash-3.00# ruby -v ruby 1.8.7 (2008-08-11 patchlevel 72) [sparc-solaris2.10] bash-3.00# gem list actionmailer (3.2.1) actionpack (3.2.1) activemodel (3.2.1) activerecord (3.2.1) activeresource (3.2.1) activesupport (3.2.1) arel (3.0.0) builder (3.0.0) bundler (1.0.22) cgi_multipart_eof_fix (2.5.0) daemons (1.1.8) diff-lcs (1.1.3) erubis (2.7.0) fastthread (1.0.7) gem_plugin (0.2.3) hike (1.2.1) i18n (0.6.0) journey (1.0.1) json (1.6.5) mail (2.4.1) mime-types (1.17.2) mongrel (1.1.5) mongrel_cluster (1.0.5) multi_json (1.0.4) polyglot (0.3.3) rack (1.4.1) rack-cache (1.1) rack-ssl (1.3.2) rack-test (0.6.1) rails (3.2.1) railties (3.2.1) rake (0.9.2.2) rdoc (3.12) rest-client (1.6.7) rspec (2.8.0, 1.3.2) rspec-core (2.8.0) rspec-expectations (2.8.0) rspec-mocks (2.8.0) spec (0.0.0) sprockets (2.1.2) thor (0.14.6) thrift (0.8.0) thrift_client (0.8.1) tilt (1.3.3) treetop (1.4.10) tzinfo (0.3.31) Reporter: Thomas Wroblewski Assignee: Jake Farrell Priority: Critical Labels: build, newbie Attachments: make.out This is an output of the rake command from build. The warnings while bother some do not appear to be the issue. ** Invoke default (first_time) ** Invoke gem (first_time) ** Invoke spec (first_time) ** Invoke gen-rb (first_time) ** Invoke gen-rb:spec (first_time) ** Execute gen-rb:spec ../../compiler/cpp/thrift --gen rb -o /opt/Scribes/thrift-0.8.0/lib/rb/spec /opt/Scribes/thrift-0.8.0/lib/rb/spec/ThriftSpec.thrift ** Invoke gen-rb:benchmark (first_time) ** Execute gen-rb:benchmark ../../compiler/cpp/thrift --gen rb -o /opt/Scribes/thrift-0.8.0/lib/rb/benchmark /opt/Scribes/thrift-0.8.0/lib/rb/benchmark/Benchmark.thrift ** Invoke gen-rb:debug_proto (first_time) ** Execute gen-rb:debug_proto mkdir -p test/debug_proto ../../compiler/cpp/thrift --gen rb -o test/debug_proto ../../test/DebugProtoTest.thrift [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:41] 64-bit constant 100 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:173] 64-bit constant 1099511627775 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:183] 64-bit constant 4294967295 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:183] 64-bit constant 1099511627775 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:183] 64-bit constant 281474976710655 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:183] 64-bit constant 72057594037927935 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:183] 64-bit constant 9223372036854775807 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:192] 64-bit constant 4294967295 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:192] 64-bit constant 1099511627775 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:192] 64-bit constant 281474976710655 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:192] 64-bit constant 72057594037927935 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:192] 64-bit constant 9223372036854775807 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:201] 64-bit constant 9223372036854775807 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:208] 64-bit constant 9223372036854775807 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:355] No field key specified for field1, resulting protocol may have conflicts or not be
[jira] [Closed] (THRIFT-1519) Thirft Build Failure referencing rb_intern2 symbol
[ https://issues.apache.org/jira/browse/THRIFT-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1519. Resolution: Cannot Reproduce Fix Version/s: 0.9 Thirft Build Failure referencing rb_intern2 symbol -- Key: THRIFT-1519 URL: https://issues.apache.org/jira/browse/THRIFT-1519 Project: Thrift Issue Type: Bug Components: Ruby - Library Affects Versions: 0.8 Environment: bash-3.00# uname -a SunOS nc17a 5.10 Generic_127127-11 sun4u sparc SUNW,A70 Solaris python 2.6 bash-3.00# ruby -v ruby 1.8.7 (2008-08-11 patchlevel 72) [sparc-solaris2.10] bash-3.00# gem list actionmailer (3.2.1) actionpack (3.2.1) activemodel (3.2.1) activerecord (3.2.1) activeresource (3.2.1) activesupport (3.2.1) arel (3.0.0) builder (3.0.0) bundler (1.0.22) cgi_multipart_eof_fix (2.5.0) daemons (1.1.8) diff-lcs (1.1.3) erubis (2.7.0) fastthread (1.0.7) gem_plugin (0.2.3) hike (1.2.1) i18n (0.6.0) journey (1.0.1) json (1.6.5) mail (2.4.1) mime-types (1.17.2) mongrel (1.1.5) mongrel_cluster (1.0.5) multi_json (1.0.4) polyglot (0.3.3) rack (1.4.1) rack-cache (1.1) rack-ssl (1.3.2) rack-test (0.6.1) rails (3.2.1) railties (3.2.1) rake (0.9.2.2) rdoc (3.12) rest-client (1.6.7) rspec (2.8.0, 1.3.2) rspec-core (2.8.0) rspec-expectations (2.8.0) rspec-mocks (2.8.0) spec (0.0.0) sprockets (2.1.2) thor (0.14.6) thrift (0.8.0) thrift_client (0.8.1) tilt (1.3.3) treetop (1.4.10) tzinfo (0.3.31) Reporter: Thomas Wroblewski Assignee: Jake Farrell Priority: Critical Labels: build, newbie Fix For: 0.9 Attachments: make.out This is an output of the rake command from build. The warnings while bother some do not appear to be the issue. ** Invoke default (first_time) ** Invoke gem (first_time) ** Invoke spec (first_time) ** Invoke gen-rb (first_time) ** Invoke gen-rb:spec (first_time) ** Execute gen-rb:spec ../../compiler/cpp/thrift --gen rb -o /opt/Scribes/thrift-0.8.0/lib/rb/spec /opt/Scribes/thrift-0.8.0/lib/rb/spec/ThriftSpec.thrift ** Invoke gen-rb:benchmark (first_time) ** Execute gen-rb:benchmark ../../compiler/cpp/thrift --gen rb -o /opt/Scribes/thrift-0.8.0/lib/rb/benchmark /opt/Scribes/thrift-0.8.0/lib/rb/benchmark/Benchmark.thrift ** Invoke gen-rb:debug_proto (first_time) ** Execute gen-rb:debug_proto mkdir -p test/debug_proto ../../compiler/cpp/thrift --gen rb -o test/debug_proto ../../test/DebugProtoTest.thrift [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:41] 64-bit constant 100 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:173] 64-bit constant 1099511627775 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:183] 64-bit constant 4294967295 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:183] 64-bit constant 1099511627775 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:183] 64-bit constant 281474976710655 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:183] 64-bit constant 72057594037927935 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:183] 64-bit constant 9223372036854775807 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:192] 64-bit constant 4294967295 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:192] 64-bit constant 1099511627775 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:192] 64-bit constant 281474976710655 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:192] 64-bit constant 72057594037927935 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:192] 64-bit constant 9223372036854775807 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:201] 64-bit constant 9223372036854775807 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:208] 64-bit constant 9223372036854775807 may not work in all languages. [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:355] No field key specified for field1, resulting protocol may have conflicts or not be backwards compatible! [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:356] No field key specified for field2, resulting protocol may have conflicts or not be backwards compatible! [WARNING:/opt/Scribes/thrift-0.8.0/test/DebugProtoTest.thrift:357] No field
[jira] [Created] (THRIFT-1604) Python exception handeling for changes from PEP 3110
Jake Farrell created THRIFT-1604: Summary: Python exception handeling for changes from PEP 3110 Key: THRIFT-1604 URL: https://issues.apache.org/jira/browse/THRIFT-1604 Project: Thrift Issue Type: Bug Affects Versions: 0.8, 0.9 Reporter: Jake Farrell Assignee: Jake Farrell Priority: Minor Python PEP 3110 changed exception handling by replacing the ',' with 'as'. This was initially introduced in python 2.6 and in 3.0 the ',' usage is no longer suppported. Since exception handling through out the py lib uses the ',' it will need to be converted over to using the 'as' syntax for exceptions -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1450) Problems building thrift 0.8.0 for Python and Ruby
[ https://issues.apache.org/jira/browse/THRIFT-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1450. Resolution: Fixed Fix Version/s: 0.9 Ruby build issue documented above, THRIFT-1604 created for Python Exception problem Problems building thrift 0.8.0 for Python and Ruby -- Key: THRIFT-1450 URL: https://issues.apache.org/jira/browse/THRIFT-1450 Project: Thrift Issue Type: Bug Components: Build Process Affects Versions: 0.8 Environment: CentOS 5.5 Python 3.2 Ruby 1.9.3 Reporter: Matthew Shaver Assignee: Jake Farrell Fix For: 0.9 Building thrift 0.8.0 I get the following error: Making all in py make[3]: Entering directory `/home/mshaver/dl/thrift-0.8.0/lib/py' /home/mshaver/bin/python setup.py build File setup.py, line 45 except DistutilsPlatformError, x: ^ SyntaxError: invalid syntax make[3]: *** [all-local] Error 1 make[3]: Leaving directory `/home/mshaver/dl/thrift-0.8.0/lib/py' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/home/mshaver/dl/thrift-0.8.0/lib' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/mshaver/dl/thrift-0.8.0' make: *** [all] Error 2 If I configure without Python I get the following error during the build: Making all in rb make[3]: Entering directory `/home/mshaver/dl/thrift-0.8.0/lib/rb' /usr/local/bin/rake rake aborted! cannot load such file -- spec/rake/spectask (See full trace by running task with --trace) make[3]: *** [all-local] Error 1 make[3]: Leaving directory `/home/mshaver/dl/thrift-0.8.0/lib/rb' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/home/mshaver/dl/thrift-0.8.0/lib' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/mshaver/dl/thrift-0.8.0' make: *** [all] Error 2 Here are the gems that are installed: $ gem list *** LOCAL GEMS *** bigdecimal (1.1.0) bundler (1.0.21) diff-lcs (1.1.3) io-console (0.3) json (1.5.4) minitest (2.5.1) rake (0.9.2.2) rdoc (3.9.4) rspec (2.7.0) rspec-core (2.7.1) rspec-expectations (2.7.0) rspec-mocks (2.7.0) rubygems-update (1.8.12) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1492) enabling c_glib render thrift unusable (even for C++ code)
[
https://issues.apache.org/jira/browse/THRIFT-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-1492.
Resolution: Fixed
Fix Version/s: 0.9
Subissues fixed resolving this ticket, closing
enabling c_glib render thrift unusable (even for C++ code)
--
Key: THRIFT-1492
URL: https://issues.apache.org/jira/browse/THRIFT-1492
Project: Thrift
Issue Type: Bug
Affects Versions: 0.8, 0.9
Environment: Mac OS 10.6.8 x86/64 on an air 11 1.4GHz core 2 duo,
gcc 4.5.3, gcc 4.6.2
Reporter: Philippe STRAUSS
Assignee: Jake Farrell
Fix For: 0.9
It's been a while I didn't touched my project which use thrift.
After updating, either using svn or 0.8.0, with gcc-4.5.3, got the following
when trying to build my project (this one was with thrift 0.8.0 tarball):
*** omake: changing directory to /Users/philou/mysrc
*** omake: reading OMakefiles
*** omake: finished reading OMakefiles (0.64 sec)
- build jack_preamp rc_types.o
+ /opt/gnucc/bin/g++ -Wall -DHAVE_NETINET_IN_H -DHAVE_INTTYPES_H -DDEBUG -O3
-march=core2 -mssse3 -I/usr/local/include -I/opt/local/include
-I/opt/misc/include -I/opt/local/include/glib-2.0
-I/opt/local/lib/glib-2.0/include -I/opt/local/include
-I/opt/misc/include/thrift -I/opt/av/include -I/opt/num/include -I../common.c
-I../jackc -I../config -I../sigpath -c -o rc_types.o rc_types.cpp
In file included from rc_types.h:11:0,
from rc_types.cpp:7:
/opt/misc/include/thrift/TApplicationException.h:32:49: erreur: expected
class-name before '{' token
/opt/misc/include/thrift/TApplicationException.h:57:31: erreur: 'string' in
namespace 'std' does not name a type
/opt/misc/include/thrift/TApplicationException.h:57:44: erreur: ISO C++
forbids declaration of 'message' with no type [-fpermissive]
/opt/misc/include/thrift/TApplicationException.h:62:31: erreur: 'string' in
namespace 'std' does not name a type
/opt/misc/include/thrift/TApplicationException.h:62:44: erreur: ISO C++
forbids declaration of 'message' with no type [-fpermissive]
/opt/misc/include/thrift/TApplicationException.h:94:3: erreur: 'uint32_t'
does not name a type
/opt/misc/include/thrift/TApplicationException.h:95:3: erreur: 'uint32_t'
does not name a type
/opt/misc/include/thrift/TApplicationException.h: In constructor
'apache::thrift::TApplicationException::TApplicationException()':
/opt/misc/include/thrift/TApplicationException.h:50:5: erreur: class
'apache::thrift::TApplicationException' does not have any field named
'TException'
...
TApplicationException.h:32:49: erreur: expected class-name before '{' token
configure opts were :
./configure --prefix=/opt/misc/ --with-c_glib --with-haskell=no --with-php=no
--with-ruby=no --with-java=no
removing --with-c_glib and now I can build my C++ project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-762) Cocoa library won't compile on Mac OS X
[
https://issues.apache.org/jira/browse/THRIFT-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13276412#comment-13276412
]
Jake Farrell commented on THRIFT-762:
-
Hey Andrew, I would just go with 10.6 but there is all ready checks in place
for NSStreamDelegate, see transport/TSocketClient.h so use a similar approach.
I will help with making a framework, will create a separate ticket for it
Cocoa library won't compile on Mac OS X
---
Key: THRIFT-762
URL: https://issues.apache.org/jira/browse/THRIFT-762
Project: Thrift
Issue Type: Bug
Components: Cocoa - Library
Affects Versions: 0.2, 0.3
Environment: Mac OS X Snow Leopard 10.6, Mac OS X Leopard 10.5
Reporter: Jeremy Fergason
Assignee: Andrew McGeachie
Attachments: build_on_osx.patch
The cocoa library will not compile for Objective-C Cocoa applications on Mac
OS X because it tries to include CFNetwork/CFSocketStream.h in
transport/TSocketClient.m. This should be a pound-define that includes
CoreServices/CoreServices.h if being compiled on Mac OS X or
CFNetwork/CFNetwork.h if being compiled for iPhone OS.
Also, the Mac OS X build will give a warning because the NSStreamDelegate
protocol is not implemented in transport/TNSStreamTransport.{h,m}
I have attached a patch to fix both issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (THRIFT-1605) Cocoa framework
Jake Farrell created THRIFT-1605: Summary: Cocoa framework Key: THRIFT-1605 URL: https://issues.apache.org/jira/browse/THRIFT-1605 Project: Thrift Issue Type: Improvement Components: Cocoa - Library Affects Versions: 0.8, 0.9 Reporter: Jake Farrell Assignee: Jake Farrell Create a cocoa framework for the lib -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-973) Cocoa library won't compile using clang
[ https://issues.apache.org/jira/browse/THRIFT-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-973. --- Resolution: Fixed Fix Version/s: 0.9 Assignee: HIRANO Satoshi (was: Andrew McGeachie) Fixed as part of the ARC patch in Thrift-1340 Cocoa library won't compile using clang --- Key: THRIFT-973 URL: https://issues.apache.org/jira/browse/THRIFT-973 Project: Thrift Issue Type: Bug Components: Cocoa - Library Reporter: Kevin Ballard Assignee: HIRANO Satoshi Fix For: 0.9 Attachments: thrift.patch The Cocoa library won't compile under Clang because TNSFileHandleTransport.m and TNSStreamTransport.m don't fully conform to the TTransport protocol. Specifically, they're missing the const modifier for the first argument of the write:offset:length: method. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-541) Cocoa code generator doesn't put keywords before all arguments.
[ https://issues.apache.org/jira/browse/THRIFT-541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-541. --- Resolution: Fixed Fix Version/s: 0.9 rebased for trunk and committed. thanks for the patch Cocoa code generator doesn't put keywords before all arguments. --- Key: THRIFT-541 URL: https://issues.apache.org/jira/browse/THRIFT-541 Project: Thrift Issue Type: Improvement Components: Cocoa - Compiler Reporter: Matt Ronge Assignee: Andrew McGeachie Priority: Minor Fix For: 0.9 Attachments: arg_name_fix.patch The compiler doesn't put keywords in front of all args. Per Cocoa coding conventions (http://developer.apple.com/documentation/Cocoa/Conceptual/CodingGuidelines/Articles/NamingMethods.html#//apple_ref/doc/uid/20001282-1001751-BCIJHEDH) all args should have a keyword. Currently this would be generated - (int32_t) calculate: (int32_t) logid : (Work *) w; But this is better - (int32_t) calculate: (int32_t) logid w: (Work *) w; Attached is a very small patch that uses the name of the arg variable as the keyword. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Build failed in Jenkins: Thrift #469
See https://builds.apache.org/job/Thrift/469/changes Changes: [jfarrell] Thrift-541: Cocoa code generator doesn't put keywords before all arguments. Client: cocoa Patch: Andrew McGeachie Updates args list to contain keywords before any args. -- [...truncated 5137 lines...] Ran 18 tests in 0.723s OK ...ERROR:root:Exception test PASSES. Traceback (most recent call last): File ../../lib/py/build/lib.linux-x86_64-2.6/thrift/server/TServer.py, line 84, in serve self.processor.process(iprot, oprot) File gen-py-slots/ThriftTest/ThriftTest.py, line 1006, in process self._processMap[name](self, seqid, iprot, oprot) File gen-py-slots/ThriftTest/ThriftTest.py, line 1202, in process_testException self._handler.testException(args.arg) File ./TestServer.py, line 112, in testException raise ValueError(Exception test PASSES.) ValueError: Exception test PASSES. ... -- Ran 18 tests in 0.678s OK ...ERROR:root:Exception test PASSES. Traceback (most recent call last): File ../../lib/py/build/lib.linux-x86_64-2.6/thrift/server/TServer.py, line 84, in serve self.processor.process(iprot, oprot) File gen-py-slots/ThriftTest/ThriftTest.py, line 1006, in process self._processMap[name](self, seqid, iprot, oprot) File gen-py-slots/ThriftTest/ThriftTest.py, line 1202, in process_testException self._handler.testException(args.arg) File ./TestServer.py, line 112, in testException raise ValueError(Exception test PASSES.) ValueError: Exception test PASSES. ... -- Ran 18 tests in 0.727s OK ...ERROR:root:Exception test PASSES. Traceback (most recent call last): File ../../lib/py/build/lib.linux-x86_64-2.6/thrift/server/TServer.py, line 84, in serve self.processor.process(iprot, oprot) File gen-py-slots/ThriftTest/ThriftTest.py, line 1006, in process self._processMap[name](self, seqid, iprot, oprot) File gen-py-slots/ThriftTest/ThriftTest.py, line 1202, in process_testException self._handler.testException(args.arg) File ./TestServer.py, line 112, in testException raise ValueError(Exception test PASSES.) ValueError: Exception test PASSES. ... -- Ran 18 tests in 0.685s OK ...ERROR:root:Exception test PASSES. Traceback (most recent call last): File ../../lib/py/build/lib.linux-x86_64-2.6/thrift/server/TServer.py, line 84, in serve self.processor.process(iprot, oprot) File gen-py-slots/ThriftTest/ThriftTest.py, line 1006, in process self._processMap[name](self, seqid, iprot, oprot) File gen-py-slots/ThriftTest/ThriftTest.py, line 1202, in process_testException self._handler.testException(args.arg) File ./TestServer.py, line 112, in testException raise ValueError(Exception test PASSES.) ValueError: Exception test PASSES. ... -- Ran 18 tests in 0.727s OK oto=compact --port=9090 --zlib --ssl OK: Finished (includes gen-py-default) TSimpleServer / compact proto / zlib=True / SSL=True. 12 combinations tested. Test run #13: (includes gen-py-slots) Server=TSimpleServer, Proto=accel, zlib=False, SSL=False Testing server TSimpleServer: /usr/bin/python ./TestServer.py --genpydir=gen-py-slots --proto=accel --port=9090 TSimpleServer Testing client: /usr/bin/python ./TestClient.py --genpydir=gen-py-slots --proto=accel --port=9090 OK: Finished (includes gen-py-slots) TSimpleServer / accel proto / zlib=False / SSL=False. 13 combinations tested. Test run #14: (includes gen-py-slots) Server=TSimpleServer, Proto=accel, zlib=False, SSL=True Testing server TSimpleServer: /usr/bin/python ./TestServer.py --genpydir=gen-py-slots --proto=accel --port=9090 --ssl TSimpleServer Testing client: /usr/bin/python ./TestClient.py --genpydir=gen-py-slots --proto=accel --port=9090 --ssl OK: Finished (includes gen-py-slots) TSimpleServer / accel proto / zlib=False / SSL=True. 14 combinations tested. Test run #15: (includes gen-py-slots) Server=TSimpleServer, Proto=accel, zlib=True, SSL=False Testing server TSimpleServer: /usr/bin/python ./TestServer.py --genpydir=gen-py-slots --proto=accel --port=9090 --zlib TSimpleServer Testing client: /usr/bin/python ./TestClient.py --genpydir=gen-py-slots --proto=accel --port=9090 --zlib OK: Finished (includes gen-py-slots) TSimpleServer / accel proto / zlib=True / SSL=False. 15 combinations tested. Test run #16: (includes gen-py-slots) Server=TSimpleServer, Proto=accel, zlib=True, SSL=True Testing server TSimpleServer: /usr/bin/python ./TestServer.py --genpydir=gen-py-slots --proto=accel --port=9090 --zlib --ssl TSimpleServer Testing client: /usr/bin/python ./TestClient.py --genpydir=gen-py-slots --proto=accel --port=9090 --zlib
[jira] [Commented] (THRIFT-541) Cocoa code generator doesn't put keywords before all arguments.
[ https://issues.apache.org/jira/browse/THRIFT-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13276437#comment-13276437 ] Hudson commented on THRIFT-541: --- Integrated in Thrift #469 (See [https://builds.apache.org/job/Thrift/469/]) Thrift-541: Cocoa code generator doesn't put keywords before all arguments. Client: cocoa Patch: Andrew McGeachie Updates args list to contain keywords before any args. (Revision 1338995) Result = FAILURE Cocoa code generator doesn't put keywords before all arguments. --- Key: THRIFT-541 URL: https://issues.apache.org/jira/browse/THRIFT-541 Project: Thrift Issue Type: Improvement Components: Cocoa - Compiler Reporter: Matt Ronge Assignee: Andrew McGeachie Priority: Minor Fix For: 0.9 Attachments: arg_name_fix.patch The compiler doesn't put keywords in front of all args. Per Cocoa coding conventions (http://developer.apple.com/documentation/Cocoa/Conceptual/CodingGuidelines/Articles/NamingMethods.html#//apple_ref/doc/uid/20001282-1001751-BCIJHEDH) all args should have a keyword. Currently this would be generated - (int32_t) calculate: (int32_t) logid : (Work *) w; But this is better - (int32_t) calculate: (int32_t) logid w: (Work *) w; Attached is a very small patch that uses the name of the arg variable as the keyword. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
