[GitHub] thrift pull request #1080: THRIFT-3891 TNonblockingServer configured with mo...
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1080#discussion_r97789162
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1524,7 +1532,7 @@ void TNonblockingIOThread::breakLoop(bool error) {
}
// sets a flag so that the loop exits on the next event
- event_base_loopbreak(eventBase_);
+ event_base_loopexit(eventBase_, 0);
--- End diff --
Your commends correspond to the discussion in the Jira entry for this item
from @nsuke. Is that something you would have time to do?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (THRIFT-3891) TNonblockingServer configured with more than one IO threads does not always return from serve() upon stop()
[
https://issues.apache.org/jira/browse/THRIFT-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837811#comment-15837811
]
ASF GitHub Bot commented on THRIFT-3891:
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1080#discussion_r97789162
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1524,7 +1532,7 @@ void TNonblockingIOThread::breakLoop(bool error) {
}
// sets a flag so that the loop exits on the next event
- event_base_loopbreak(eventBase_);
+ event_base_loopexit(eventBase_, 0);
--- End diff --
Your commends correspond to the discussion in the Jira entry for this item
from @nsuke. Is that something you would have time to do?
> TNonblockingServer configured with more than one IO threads does not always
> return from serve() upon stop()
> ---
>
> Key: THRIFT-3891
> URL: https://issues.apache.org/jira/browse/THRIFT-3891
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Affects Versions: 0.9.3
>Reporter: Buğra Gedik
>Priority: Minor
> Attachments: patch.diff
>
>
> Using {{TNonblockingServer}}, when the number of IO threads is > 1, there is
> race condition in which {{stop()}} does not properly unblock {{serve()}}.
> The problem manifests itself when {{stop()}} is called (obviously from a
> different thread) soon after {{serve()}}.
> The core issue is that, {{event_base_loopbreak()}} is called within the
> {{stop()}} sequence without checking whether the IO thread has actually
> entered its event loop. The documentation of {{event_base_loopbreak()}} says
> (http://www.wangafu.net/~nickm/libevent-book/Ref3_eventloop.html)
> {quote}
> Note also that event_base_loopexit(base,NULL) and event_base_loopbreak(base)
> act differently when no event loop is running: loopexit schedules the next
> instance of the event loop to stop right after the next round of callbacks
> are run (as if it had been invoked with EVLOOP_ONCE) whereas loopbreak only
> stops a currently running loop, and has no effect if the event loop isn’t
> running.
> {quote}
> Attached is a patch (against the released 0.9.3 version of the codebase).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-3892) Thrift uses TLS SNI extension provided by OpenSSL library. Older version of OpenSSL(< 0.9.8f) may create problem because they do not support 'SSL_set_tlsext_host_name()'
[ https://issues.apache.org/jira/browse/THRIFT-3892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3892: --- Issue Type: Bug (was: Improvement) > Thrift uses TLS SNI extension provided by OpenSSL library. Older version of > OpenSSL(< 0.9.8f) may create problem because they do not support > 'SSL_set_tlsext_host_name()'. > -- > > Key: THRIFT-3892 > URL: https://issues.apache.org/jira/browse/THRIFT-3892 > Project: Thrift > Issue Type: Bug > Components: C++ - Compiler >Reporter: Udit Raikwar >Assignee: James E. King, III >Priority: Trivial > Labels: newbie > Fix For: 0.11.0 > > > Thrift uses TLS SNI extension during SSL handshake provided by OpenSSL > library. Older version of OpenSSL(< 0.9.8f) may create problem because they > do not support 'SSL_set_tlsext_host_name()'. > I have created a pull request regarding this issue[1], this issue is although > negligible because all newer version of OpenSSL supports TLS SNI extension > but checking if TLS SNI extension is supported in user's OpenSSL version is > not bad. > [1]=https://github.com/apache/thrift/pull/1057 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-3892) Thrift uses TLS SNI extension provided by OpenSSL library. Older version of OpenSSL(< 0.9.8f) may create problem because they do not support 'SSL_set_tlsext_host_name()
[ https://issues.apache.org/jira/browse/THRIFT-3892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3892. Resolution: Fixed Assignee: James E. King, III Fix Version/s: 0.11.0 > Thrift uses TLS SNI extension provided by OpenSSL library. Older version of > OpenSSL(< 0.9.8f) may create problem because they do not support > 'SSL_set_tlsext_host_name()'. > -- > > Key: THRIFT-3892 > URL: https://issues.apache.org/jira/browse/THRIFT-3892 > Project: Thrift > Issue Type: Improvement > Components: C++ - Compiler >Reporter: Udit Raikwar >Assignee: James E. King, III >Priority: Trivial > Labels: newbie > Fix For: 0.11.0 > > > Thrift uses TLS SNI extension during SSL handshake provided by OpenSSL > library. Older version of OpenSSL(< 0.9.8f) may create problem because they > do not support 'SSL_set_tlsext_host_name()'. > I have created a pull request regarding this issue[1], this issue is although > negligible because all newer version of OpenSSL supports TLS SNI extension > but checking if TLS SNI extension is supported in user's OpenSSL version is > not bad. > [1]=https://github.com/apache/thrift/pull/1057 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request #1057: Update TSSLSocket.cpp
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1057 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #896: THRIFT-3676
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/896 Hi, would you be able to rebase on the current master and squash the commits, and force push? This will restart the CI build with our current codebase so we know the change is still applicable and passes all tests. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3676) Cocoa server does not emit exceptions
[ https://issues.apache.org/jira/browse/THRIFT-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837863#comment-15837863 ] ASF GitHub Bot commented on THRIFT-3676: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/896 Hi, would you be able to rebase on the current master and squash the commits, and force push? This will restart the CI build with our current codebase so we know the change is still applicable and passes all tests. Thanks. > Cocoa server does not emit exceptions > - > > Key: THRIFT-3676 > URL: https://issues.apache.org/jira/browse/THRIFT-3676 > Project: Thrift > Issue Type: Bug > Components: Cocoa - Compiler >Reporter: Niels Grewe > > The server side code emitted by the Cocoa generator does not send exceptions > back to the client. Instead the client will be hung waiting for a response. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request #1080: THRIFT-3891 TNonblockingServer configured with mo...
Github user bgedik commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1080#discussion_r97798270
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1524,7 +1532,7 @@ void TNonblockingIOThread::breakLoop(bool error) {
}
// sets a flag so that the loop exits on the next event
- event_base_loopbreak(eventBase_);
+ event_base_loopexit(eventBase_, 0);
--- End diff --
I created the JIRA entry, with a patch that works for us (in production and
testing). I know it is not the ideal fix, but I was hoping that someone who is
more versed in the ``TNonblockingServer`` implementation can work it. I don't
have the time to dig into the design of ``TNonblockingServer``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (THRIFT-3891) TNonblockingServer configured with more than one IO threads does not always return from serve() upon stop()
[
https://issues.apache.org/jira/browse/THRIFT-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837879#comment-15837879
]
ASF GitHub Bot commented on THRIFT-3891:
Github user bgedik commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1080#discussion_r97798270
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1524,7 +1532,7 @@ void TNonblockingIOThread::breakLoop(bool error) {
}
// sets a flag so that the loop exits on the next event
- event_base_loopbreak(eventBase_);
+ event_base_loopexit(eventBase_, 0);
--- End diff --
I created the JIRA entry, with a patch that works for us (in production and
testing). I know it is not the ideal fix, but I was hoping that someone who is
more versed in the ``TNonblockingServer`` implementation can work it. I don't
have the time to dig into the design of ``TNonblockingServer``.
> TNonblockingServer configured with more than one IO threads does not always
> return from serve() upon stop()
> ---
>
> Key: THRIFT-3891
> URL: https://issues.apache.org/jira/browse/THRIFT-3891
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Affects Versions: 0.9.3
>Reporter: Buğra Gedik
>Priority: Minor
> Attachments: patch.diff
>
>
> Using {{TNonblockingServer}}, when the number of IO threads is > 1, there is
> race condition in which {{stop()}} does not properly unblock {{serve()}}.
> The problem manifests itself when {{stop()}} is called (obviously from a
> different thread) soon after {{serve()}}.
> The core issue is that, {{event_base_loopbreak()}} is called within the
> {{stop()}} sequence without checking whether the IO thread has actually
> entered its event loop. The documentation of {{event_base_loopbreak()}} says
> (http://www.wangafu.net/~nickm/libevent-book/Ref3_eventloop.html)
> {quote}
> Note also that event_base_loopexit(base,NULL) and event_base_loopbreak(base)
> act differently when no event loop is running: loopexit schedules the next
> instance of the event loop to stop right after the next round of callbacks
> are run (as if it had been invoked with EVLOOP_ONCE) whereas loopbreak only
> stops a currently running loop, and has no effect if the event loop isn’t
> running.
> {quote}
> Attached is a patch (against the released 0.9.3 version of the codebase).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] thrift issue #930: THRIFT-3369 : Implement SSL/TLS support on C with c_glib
Github user gadLinux commented on the issue: https://github.com/apache/thrift/pull/930 Hi, I know that it's not a good idea to rewrite history but since this is not merged anyplace I just overwrote the commit. This time I think it's correct. Le'ts see what the tests are saying... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3369) Implement SSL/TLS support on C with c_glib
[ https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838148#comment-15838148 ] ASF GitHub Bot commented on THRIFT-3369: Github user gadLinux commented on the issue: https://github.com/apache/thrift/pull/930 Hi, I know that it's not a good idea to rewrite history but since this is not merged anyplace I just overwrote the commit. This time I think it's correct. Le'ts see what the tests are saying... > Implement SSL/TLS support on C with c_glib > -- > > Key: THRIFT-3369 > URL: https://issues.apache.org/jira/browse/THRIFT-3369 > Project: Thrift > Issue Type: Improvement > Components: C glib - Library >Affects Versions: 0.9.1, 0.9.2, 0.9.3, 1.0 >Reporter: Gonzalo Aguilar > Labels: features, patch > > Implement SSL/TLS based on plain openssl instead of going through the way > defined in THRIFT-1016. > This help us to maintain a reference implementation and later switch over GIO > or whatever is defined. But also does not add any other dependencies to the > project. So bare minimum installation for supporting SSL/TLS is there and > aligned with CPP counterpart. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request #1156: THRIFT-4011 Use slices for Thrift sets
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1156#discussion_r97841167
--- Diff: lib/go/test/tests/thrifttest_handler.go ---
@@ -96,7 +96,7 @@ func (p *ThriftTestHandler) TestStringMap(thing
map[string]string) (r map[string
return thing, nil
}
-func (p *ThriftTestHandler) TestSet(thing map[int32]struct{}) (r
map[int32]struct{}, err error) {
+func (p *ThriftTestHandler) TestSet(thing []int32) (r []int32, err error) {
--- End diff --
This looks like a breaking change; any generated go implementation's
handler will need to change. How will this be communicated? What happens to
existing handlers that implement the older method?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (THRIFT-4011) Sets of Thrift structs generate Go code that can't be serialized to JSON
[
https://issues.apache.org/jira/browse/THRIFT-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838271#comment-15838271
]
ASF GitHub Bot commented on THRIFT-4011:
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1156#discussion_r97841167
--- Diff: lib/go/test/tests/thrifttest_handler.go ---
@@ -96,7 +96,7 @@ func (p *ThriftTestHandler) TestStringMap(thing
map[string]string) (r map[string
return thing, nil
}
-func (p *ThriftTestHandler) TestSet(thing map[int32]struct{}) (r
map[int32]struct{}, err error) {
+func (p *ThriftTestHandler) TestSet(thing []int32) (r []int32, err error) {
--- End diff --
This looks like a breaking change; any generated go implementation's
handler will need to change. How will this be communicated? What happens to
existing handlers that implement the older method?
> Sets of Thrift structs generate Go code that can't be serialized to JSON
>
>
> Key: THRIFT-4011
> URL: https://issues.apache.org/jira/browse/THRIFT-4011
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Reporter: Can Celasun
>
> Consider the following structs:
> {code}
> struct Foo {
> 1: optional string foo
> }
> struct Bar {
> 1: optional set foos
> }
> {code}
> This compiles into the following Go code:
> {code}
> type Bar struct {
> Foos map[*Foo]struct{} `thrift:"foos,1" db:"foos" json:"foos,omitempty"`
> }
> {code}
> Even though the generated code has tags for JSON support, Bar can't be
> serialized to JSON:
> {code}
> json: unsupported type: map[*Foo]struct {}
> {code}
> One solution would be to use slices, not maps, for Thrift sets. Thoughts?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] thrift pull request #1156: THRIFT-4011 Use slices for Thrift sets
Github user dcelasun commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1156#discussion_r97843055
--- Diff: lib/go/test/tests/thrifttest_handler.go ---
@@ -96,7 +96,7 @@ func (p *ThriftTestHandler) TestStringMap(thing
map[string]string) (r map[string
return thing, nil
}
-func (p *ThriftTestHandler) TestSet(thing map[int32]struct{}) (r
map[int32]struct{}, err error) {
+func (p *ThriftTestHandler) TestSet(thing []int32) (r []int32, err error) {
--- End diff --
Yes, this is a breaking change which was originally discussed in
THRIFT-4011; I only started working on this PR after I was given the go ahead.
> How will this be communicated?
I would imagine posts to the mailing lists and an announcement on the
website, several weeks in advance of a new release?
> What happens to existing handlers that implement the older method?
Compiling IDLs with this patch will change the signature of any RPC or
struct in the generated Go code, so it's very easy to catch at compile time and
make the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (THRIFT-4011) Sets of Thrift structs generate Go code that can't be serialized to JSON
[
https://issues.apache.org/jira/browse/THRIFT-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838285#comment-15838285
]
ASF GitHub Bot commented on THRIFT-4011:
Github user dcelasun commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1156#discussion_r97843055
--- Diff: lib/go/test/tests/thrifttest_handler.go ---
@@ -96,7 +96,7 @@ func (p *ThriftTestHandler) TestStringMap(thing
map[string]string) (r map[string
return thing, nil
}
-func (p *ThriftTestHandler) TestSet(thing map[int32]struct{}) (r
map[int32]struct{}, err error) {
+func (p *ThriftTestHandler) TestSet(thing []int32) (r []int32, err error) {
--- End diff --
Yes, this is a breaking change which was originally discussed in
THRIFT-4011; I only started working on this PR after I was given the go ahead.
> How will this be communicated?
I would imagine posts to the mailing lists and an announcement on the
website, several weeks in advance of a new release?
> What happens to existing handlers that implement the older method?
Compiling IDLs with this patch will change the signature of any RPC or
struct in the generated Go code, so it's very easy to catch at compile time and
make the changes.
> Sets of Thrift structs generate Go code that can't be serialized to JSON
>
>
> Key: THRIFT-4011
> URL: https://issues.apache.org/jira/browse/THRIFT-4011
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Reporter: Can Celasun
>
> Consider the following structs:
> {code}
> struct Foo {
> 1: optional string foo
> }
> struct Bar {
> 1: optional set foos
> }
> {code}
> This compiles into the following Go code:
> {code}
> type Bar struct {
> Foos map[*Foo]struct{} `thrift:"foos,1" db:"foos" json:"foos,omitempty"`
> }
> {code}
> Even though the generated code has tags for JSON support, Bar can't be
> serialized to JSON:
> {code}
> json: unsupported type: map[*Foo]struct {}
> {code}
> One solution would be to use slices, not maps, for Thrift sets. Thoughts?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-4012) Python Twisted implementation uses implements, not compatible with Py3
[ https://issues.apache.org/jira/browse/THRIFT-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4012: --- Component/s: Python - Compiler > Python Twisted implementation uses implements, not compatible with Py3 > -- > > Key: THRIFT-4012 > URL: https://issues.apache.org/jira/browse/THRIFT-4012 > Project: Thrift > Issue Type: Bug > Components: Python - Compiler >Affects Versions: 0.9.3 >Reporter: Palmer > Fix For: 0.10.0 > > > The Zope implements method is not compatible with Python 3. Instead, > @implementer is compatible with Python 3 as well as Python 2. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-4012) Python Twisted implementation uses implements, not compatible with Py3
[ https://issues.apache.org/jira/browse/THRIFT-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4012. Resolution: Fixed Fix Version/s: 0.10.0 Given this was merged on Dec 22 I am marking it fixed in 0.10.0. > Python Twisted implementation uses implements, not compatible with Py3 > -- > > Key: THRIFT-4012 > URL: https://issues.apache.org/jira/browse/THRIFT-4012 > Project: Thrift > Issue Type: Bug > Components: Python - Compiler >Affects Versions: 0.9.3 >Reporter: Palmer > Fix For: 0.10.0 > > > The Zope implements method is not compatible with Python 3. Instead, > @implementer is compatible with Python 3 as well as Python 2. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-4012) Python Twisted implementation uses implements, not compatible with Py3
[ https://issues.apache.org/jira/browse/THRIFT-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4012: --- Affects Version/s: 0.9.3 > Python Twisted implementation uses implements, not compatible with Py3 > -- > > Key: THRIFT-4012 > URL: https://issues.apache.org/jira/browse/THRIFT-4012 > Project: Thrift > Issue Type: Bug > Components: Python - Compiler >Affects Versions: 0.9.3 >Reporter: Palmer > Fix For: 0.10.0 > > > The Zope implements method is not compatible with Python 3. Instead, > @implementer is compatible with Python 3 as well as Python 2. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2208) Thrift package for chocolatey
[ https://issues.apache.org/jira/browse/THRIFT-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-2208: --- Issue Type: Wish (was: Bug) > Thrift package for chocolatey > - > > Key: THRIFT-2208 > URL: https://issues.apache.org/jira/browse/THRIFT-2208 > Project: Thrift > Issue Type: Wish > Components: Build Process >Reporter: Jake Farrell >Assignee: Jake Farrell > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2208) Thrift package for chocolatey
[ https://issues.apache.org/jira/browse/THRIFT-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-2208: --- Priority: Minor (was: Major) > Thrift package for chocolatey > - > > Key: THRIFT-2208 > URL: https://issues.apache.org/jira/browse/THRIFT-2208 > Project: Thrift > Issue Type: Wish > Components: Build Process >Reporter: Jake Farrell >Assignee: Jake Farrell >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3475) prefix tags with v as defined by semver
[
https://issues.apache.org/jira/browse/THRIFT-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838300#comment-15838300
]
James E. King, III commented on THRIFT-3475:
Any further news on semver 2 requirements?
> prefix tags with v as defined by semver
> ---
>
> Key: THRIFT-3475
> URL: https://issues.apache.org/jira/browse/THRIFT-3475
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
>Reporter: Roger Meier
>Assignee: Jake Farrell
>
> We need to prefix our tags with **v** to follow the semver model, e.g.
> **v0.9.3**
> non prefix causes issues such as tag and branch conflicts.
> I had to do this when pushing to the release branch on my fork
> {noformat}
> git push bufferoverflow heads/0.9.3
> {noformat}
> see also THRIFT-6
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-3358) Makefile:1362: *** missing separator. Stop.
[ https://issues.apache.org/jira/browse/THRIFT-3358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3358. Resolution: Workaround Assignee: James E. King, III Fix Version/s: 0.10.0 Haven't seen the issue in quite some time (and it hasn't been updated). Recommend you use the cmake build environment to resolve. > Makefile:1362: *** missing separator. Stop. > > > Key: THRIFT-3358 > URL: https://issues.apache.org/jira/browse/THRIFT-3358 > Project: Thrift > Issue Type: Bug > Components: Build Process > Environment: OS X 10.10.5 >Reporter: David Laxer >Assignee: James E. King, III > Fix For: 0.10.0 > > > Hi > I pulled the latest changes to 'thrift' from git. > $ make > ... > /Applications/Xcode.app/Contents/Developer/usr/bin/make all-recursive > Making all in compiler/cpp > /Applications/Xcode.app/Contents/Developer/usr/bin/make all-am > make[3]: Nothing to be done for `all-am'. > Making all in lib > Making all in cpp > Making all in . > make[4]: Nothing to be done for `all-am'. > Making all in test > Makefile:1362: *** missing separator. Stop. > make[3]: *** [all-recursive] Error 1 > make[2]: *** [all-recursive] Error 1 > make[1]: *** [all-recursive] Error 1 > make: *** [all] Error 2 > I would look for a 'tab problem' on line 1362, however, all the makefile have > less lines. > wc Make* > 9713539 30816 Makefile > 56 2321441 Makefile.am > 9713533 30442 Makefile.in > 19987304 62699 total -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-3358) Makefile:1362: *** missing separator. Stop.
[ https://issues.apache.org/jira/browse/THRIFT-3358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3358: --- Fix Version/s: (was: 0.10.0) 0.11.0 > Makefile:1362: *** missing separator. Stop. > > > Key: THRIFT-3358 > URL: https://issues.apache.org/jira/browse/THRIFT-3358 > Project: Thrift > Issue Type: Bug > Components: Build Process > Environment: OS X 10.10.5 >Reporter: David Laxer >Assignee: James E. King, III > Fix For: 0.11.0 > > > Hi > I pulled the latest changes to 'thrift' from git. > $ make > ... > /Applications/Xcode.app/Contents/Developer/usr/bin/make all-recursive > Making all in compiler/cpp > /Applications/Xcode.app/Contents/Developer/usr/bin/make all-am > make[3]: Nothing to be done for `all-am'. > Making all in lib > Making all in cpp > Making all in . > make[4]: Nothing to be done for `all-am'. > Making all in test > Makefile:1362: *** missing separator. Stop. > make[3]: *** [all-recursive] Error 1 > make[2]: *** [all-recursive] Error 1 > make[1]: *** [all-recursive] Error 1 > make: *** [all] Error 2 > I would look for a 'tab problem' on line 1362, however, all the makefile have > less lines. > wc Make* > 9713539 30816 Makefile > 56 2321441 Makefile.am > 9713533 30442 Makefile.in > 19987304 62699 total -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-3249) Build fails without static boost libraries
[ https://issues.apache.org/jira/browse/THRIFT-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3249. Resolution: Workaround Assignee: James E. King, III Fix Version/s: 0.11.0 Recommend you use the cmake build environment or build your own boost. Given this issue is 1.5 years old without an update I am resolving with a workaround to use cmake or build your own boost. If you continue to see the issue please feel free to reopen it. > Build fails without static boost libraries > -- > > Key: THRIFT-3249 > URL: https://issues.apache.org/jira/browse/THRIFT-3249 > Project: Thrift > Issue Type: Bug > Components: Build Process > Environment: Slackware-current >Reporter: Julian Grinblat >Assignee: James E. King, III > Fix For: 0.11.0 > > > I've been trying to build thrift 0.9.2 on my slackware current box, but it > keeps failing to find libboost_unit_test_framework.a... a little digging > resulted in finding that the Slackware boost package builds only the static > libraries > (http://slackware.cs.utah.edu/pub/slackware/slackware64-current/source/l/boost/boost.SlackBuild)... > Is there any way to build thrift using the shared libraries? I wouldn't want > to modify the default boost package on my box, it makes more sense to me to > build thrift using the shared libraries instead -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift issue #1060: [THRIFT-3895] Fix java 1.8 with ant < 1.9 compatibility
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1060 Would you be able to rebase this against master and force push an update? This will kick off a new CI build. I would like to see the build pass before merging into the project. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3895) Build fails using Java 1.8 with Ant < 1.9
[
https://issues.apache.org/jira/browse/THRIFT-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838319#comment-15838319
]
ASF GitHub Bot commented on THRIFT-3895:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1060
Would you be able to rebase this against master and force push an update?
This will kick off a new CI build. I would like to see the build pass before
merging into the project.
> Build fails using Java 1.8 with Ant < 1.9
> -
>
> Key: THRIFT-3895
> URL: https://issues.apache.org/jira/browse/THRIFT-3895
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
>Affects Versions: 0.9.3
>Reporter: Adinata
>
> Failed with these errors:
> {code}
> Class not found: javac1.8
> {code}
> Solution:
> Add to all {{javac}} ant task attributes {{compiler="modern"}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-3826) Appveyor builds cannot download winflexbison properly
[
https://issues.apache.org/jira/browse/THRIFT-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-3826.
Resolution: Fixed
Fix Version/s: 0.10.0
> Appveyor builds cannot download winflexbison properly
> -
>
> Key: THRIFT-3826
> URL: https://issues.apache.org/jira/browse/THRIFT-3826
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
>Affects Versions: 0.10.0
> Environment: Appveyor
>Reporter: James E. King, III
>Assignee: Aki Sukegawa
> Fix For: 0.10.0
>
>
> {noformat}
> cinst winflexbison
> Installing the following packages:
> winflexbison
> By installing you accept licenses for the packages.
>
> winflexbison v2.4.3.20140715
> Downloading winflexbison 32 bit
>from
> 'http://sourceforge.net/projects/winflexbison/files/old_versions/win_flex_bison-2.4.3.zip'
> Chocolatey expected a file at
> 'C:\Users\appveyor\AppData\Local\Temp\1\chocolate
> y\winflexbison\2.4.3.20140715\winflexbisonInstall.zip' to be of length
> '667674' but the length was '69240'.
> At C:\ProgramData\chocolatey\helpers\functions\Get-ChocolateyWebFile.ps1:162
> char:101
> + if ($headers.ContainsKey("Content-Length") -and ($fi.Length -ne
> $headers["Co ...
> +
> ~
> ~~~{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-4012) Python Twisted implementation uses implements, not compatible with Py3
[ https://issues.apache.org/jira/browse/THRIFT-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Palmer updated THRIFT-4012: --- Fix Version/s: (was: 0.10.0) 0.11.0 > Python Twisted implementation uses implements, not compatible with Py3 > -- > > Key: THRIFT-4012 > URL: https://issues.apache.org/jira/browse/THRIFT-4012 > Project: Thrift > Issue Type: Bug > Components: Python - Compiler >Affects Versions: 0.9.3 >Reporter: Palmer > Fix For: 0.11.0 > > > The Zope implements method is not compatible with Python 3. Instead, > @implementer is compatible with Python 3 as well as Python 2. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-4012) Python Twisted implementation uses implements, not compatible with Py3
[ https://issues.apache.org/jira/browse/THRIFT-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838337#comment-15838337 ] Palmer commented on THRIFT-4012: Updated fix version to 0.11.0 since the fix isn't included in 0.10.0 (ie, the change isn't in https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=lib/py/src/transport/TTwisted.py;h=5710b573dce7eb6cafd396acb5c015066d9d8e07;hb=b2a4d4ae21c789b689dd162deb819665567f481c) > Python Twisted implementation uses implements, not compatible with Py3 > -- > > Key: THRIFT-4012 > URL: https://issues.apache.org/jira/browse/THRIFT-4012 > Project: Thrift > Issue Type: Bug > Components: Python - Compiler >Affects Versions: 0.9.3 >Reporter: Palmer > Fix For: 0.11.0 > > > The Zope implements method is not compatible with Python 3. Instead, > @implementer is compatible with Python 3 as well as Python 2. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request #1156: THRIFT-4011 Use slices for Thrift sets
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1156#discussion_r97858435
--- Diff: lib/go/test/tests/thrifttest_handler.go ---
@@ -96,7 +96,7 @@ func (p *ThriftTestHandler) TestStringMap(thing
map[string]string) (r map[string
return thing, nil
}
-func (p *ThriftTestHandler) TestSet(thing map[int32]struct{}) (r
map[int32]struct{}, err error) {
+func (p *ThriftTestHandler) TestSet(thing []int32) (r []int32, err error) {
--- End diff --
As long as it is a compile time failure if someone doesn't change it,
that's good. In C++ (C++03, or C++11 without the "override" keyword being
used) if you change the signature of a virtual method, anything that overrides
it will silently define a new method instead of overriding what you want. It's
pretty messy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (THRIFT-4011) Sets of Thrift structs generate Go code that can't be serialized to JSON
[
https://issues.apache.org/jira/browse/THRIFT-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838409#comment-15838409
]
ASF GitHub Bot commented on THRIFT-4011:
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1156#discussion_r97858435
--- Diff: lib/go/test/tests/thrifttest_handler.go ---
@@ -96,7 +96,7 @@ func (p *ThriftTestHandler) TestStringMap(thing
map[string]string) (r map[string
return thing, nil
}
-func (p *ThriftTestHandler) TestSet(thing map[int32]struct{}) (r
map[int32]struct{}, err error) {
+func (p *ThriftTestHandler) TestSet(thing []int32) (r []int32, err error) {
--- End diff --
As long as it is a compile time failure if someone doesn't change it,
that's good. In C++ (C++03, or C++11 without the "override" keyword being
used) if you change the signature of a virtual method, anything that overrides
it will silently define a new method instead of overriding what you want. It's
pretty messy.
> Sets of Thrift structs generate Go code that can't be serialized to JSON
>
>
> Key: THRIFT-4011
> URL: https://issues.apache.org/jira/browse/THRIFT-4011
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Reporter: Can Celasun
>
> Consider the following structs:
> {code}
> struct Foo {
> 1: optional string foo
> }
> struct Bar {
> 1: optional set foos
> }
> {code}
> This compiles into the following Go code:
> {code}
> type Bar struct {
> Foos map[*Foo]struct{} `thrift:"foos,1" db:"foos" json:"foos,omitempty"`
> }
> {code}
> Even though the generated code has tags for JSON support, Bar can't be
> serialized to JSON:
> {code}
> json: unsupported type: map[*Foo]struct {}
> {code}
> One solution would be to use slices, not maps, for Thrift sets. Thoughts?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-2208) Thrift package for chocolatey
[ https://issues.apache.org/jira/browse/THRIFT-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-2208: --- Assignee: (was: Jake Farrell) > Thrift package for chocolatey > - > > Key: THRIFT-2208 > URL: https://issues.apache.org/jira/browse/THRIFT-2208 > Project: Thrift > Issue Type: Wish > Components: Build Process >Reporter: Jake Farrell >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-381) Fail fast if configure detects C++ problems
[ https://issues.apache.org/jira/browse/THRIFT-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-381. --- Resolution: Won't Fix Assignee: James E. King, III (was: David Reiss) Fix Version/s: 0.11.0 Resolving as won't fix. Project is moving to cmake. > Fail fast if configure detects C++ problems > --- > > Key: THRIFT-381 > URL: https://issues.apache.org/jira/browse/THRIFT-381 > Project: Thrift > Issue Type: Bug > Components: Build Process >Reporter: David Reiss >Assignee: James E. King, III >Priority: Trivial > Fix For: 0.11.0 > > > We had a guy on the public list who couldn't compile and run a trivial C++ > program on his machine because libstdc++ was messed up. configure should > detect this and bail out. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-4030) CI jobs do not reuse downloaded docker images
[ https://issues.apache.org/jira/browse/THRIFT-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838500#comment-15838500 ] James E. King, III commented on THRIFT-4030: We had some issues with the docker image that got resolved with e0ccbd6e62e14f32d7c5fe0f9cec6eff3259b863 on January 16. Was this the issue you were seeing? Do you want to keep this open or close it out? Saving 10 minutes on each build is worth continuing to use docker images instead of rebuilding them. > CI jobs do not reuse downloaded docker images > - > > Key: THRIFT-4030 > URL: https://issues.apache.org/jira/browse/THRIFT-4030 > Project: Thrift > Issue Type: Bug > Components: Build Process >Reporter: Aki Sukegawa >Priority: Minor > > The main motivation for me to introduce this script was to avoid docker build > which was failing too often due to occasional apt download failures. > But for some unknown reason apt is not failing any longer. > Although reusing reduces build time by ~10min for each job, we may well > remove the script and always build images from scratch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3042) Dockerfiles fail to build
[ https://issues.apache.org/jira/browse/THRIFT-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838508#comment-15838508 ] James E. King, III commented on THRIFT-3042: Is this still an open issue? > Dockerfiles fail to build > - > > Key: THRIFT-3042 > URL: https://issues.apache.org/jira/browse/THRIFT-3042 > Project: Thrift > Issue Type: Bug > Components: Build Process >Affects Versions: 0.9.3 > Environment: ubuntu 14.04 docker host >Reporter: Randy Abernethy >Assignee: Jake Farrell >Priority: Minor > Fix For: 1.0 > > Attachments: thrift-3042-ubuntu.patch > > > h3. Docker build on build/docker/ubuntu/Dockerfile fails on Haxe setup. e.g. > docker@ubuntu:~$ docker build -t thrift thrift/build/docker/ubuntu > ... > haxe-3.1.3/std/Xml.hx > Uncaught exception - load.c(237) : Failed to load library : std.ndll > (std.ndll: cannot open shared object file: No such file or directory) > INFO[0011] The command [/bin/sh -c apt-get install -y libneko0 && mkdir > -p /tmp/haxe /usr/lib/haxe && curl > http://haxe.org/website-content/downloads/3,1,3/downloads/haxe-3.1.3-linux64.tar.gz > -o /tmp/haxe/haxe-3.1.3-linux64.tar.gz && tar -xvzf > /tmp/haxe/haxe-3.1.3-linux64.tar.gz -C /usr/lib/haxe --strip-components=1 && >ln -s /usr/lib/haxe/haxe /usr/bin/haxe && ln -s /usr/lib/haxe/haxelib > /usr/bin/haxelib && ln -s /usr/lib/libneko.so.0 /usr/lib/libneko.so && > mkdir -p /usr/lib/haxe/lib && chmod -R 777 /usr/lib/haxe/lib && > haxelib setup /usr/lib/haxe/lib && haxelib install hxcpp] returned a > non-zero code: 1 > h3. Docker build on build/docker/centosDockerfile fails on Boost build. e.g. > docker@ubuntu:~$ docker build -t thrift thrift/build/docker/centos > ... > /tmp/boost/boost_1_55_0/tools/build/v2/tools/gcc.jam:148: in gcc.init from > module gcc > error: toolset gcc initialization: > error: no command provided, default command 'g++' not found > error: initialized from project-config.jam:12 > /tmp/boost/boost_1_55_0/tools/build/v2/build/toolset.jam:41: in toolset.using > from module toolset > /tmp/boost/boost_1_55_0/tools/build/v2/build/project.jam:1007: in using from > module project-rules > project-config.jam:12: in modules.load from module project-config > /tmp/boost/boost_1_55_0/tools/build/v2/build-system.jam:249: in load-config > from module build-system > /tmp/boost/boost_1_55_0/tools/build/v2/build-system.jam:412: in > load-configuration-files from module build-system > /tmp/boost/boost_1_55_0/tools/build/v2/build-system.jam:524: in load from > module build-system > /tmp/boost/boost_1_55_0/tools/build/v2/kernel/modules.jam:289: in import from > module modules > /tmp/boost/boost_1_55_0/tools/build/v2/kernel/bootstrap.jam:139: in > boost-build from module > /tmp/boost/boost_1_55_0/boost-build.jam:17: in module scope from module > INFO[0264] The command [/bin/sh -c mkdir -p /tmp/boost && curl -SL > "http://sourceforge.net/projects/boost/files/boost/1.55.0/boost_1_55_0.tar.gz"; > | tar -xzC /tmp/boost && cd /tmp/boost/boost_1_55_0 && > ./bootstrap.sh && ./b2 install && cd $HOME] returned a non-zero > code: 1 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-3281) Travis CI build passed but the log says BUILD FAILED
[
https://issues.apache.org/jira/browse/THRIFT-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-3281.
Resolution: Cannot Reproduce
Assignee: James E. King, III
Fix Version/s: 0.11.0
We haven't seen this since it happened. Closing.
> Travis CI build passed but the log says BUILD FAILED
>
>
> Key: THRIFT-3281
> URL: https://issues.apache.org/jira/browse/THRIFT-3281
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
>Affects Versions: 0.9.3
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Minor
> Fix For: 0.11.0
>
>
> See: https://travis-ci.org/apache/thrift/jobs/73274645
> {noformat}
> javadoc:
> [javadoc] Generating Javadoc
> [javadoc] Javadoc execution
> [javadoc] Creating destination directory:
> "/home/travis/build/apache/thrift/cmake_build/lib/java/javadoc/"
> [javadoc] Loading source files for package org.apache.thrift...
> [javadoc] Loading source files for package org.apache.thrift.async...
> [javadoc] Loading source files for package org.apache.thrift.meta_data...
> [javadoc] Loading source files for package org.apache.thrift.protocol...
> [javadoc] Loading source files for package org.apache.thrift.scheme...
> [javadoc] Loading source files for package org.apache.thrift.server...
> [javadoc] Loading source files for package org.apache.thrift.transport...
> [javadoc] Constructing Javadoc information...
> [javadoc] Standard Doclet version 1.7.0_76
> [javadoc] Building tree for all the packages and classes...
> [javadoc]
> /home/travis/build/apache/thrift/lib/java/src/org/apache/thrift/server/TExtensibleServlet.java:68:
> warning - @return tag has no arguments.
> [javadoc]
> /home/travis/build/apache/thrift/lib/java/src/org/apache/thrift/server/TExtensibleServlet.java:76:
> warning - @return tag has no arguments.
> [javadoc]
> /home/travis/build/apache/thrift/lib/java/src/org/apache/thrift/server/TExtensibleServlet.java:84:
> warning - @return tag has no arguments.
> [javadoc] Building index for all the packages and classes...
> [javadoc] Building index for all classes...
> [javadoc] Generating
> /home/travis/build/apache/thrift/cmake_build/lib/java/javadoc/help-doc.html...
> [javadoc] 3 warnings
> [jar] Building jar:
> /home/travis/build/apache/thrift/cmake_build/lib/java/libthrift-1.0.0-javadoc.jar
> install:
> [copy] Copying 12 files to /usr/local/lib/java
> BUILD FAILED
> /home/travis/build/apache/thrift/lib/java/build.xml:148: Failed to copy
> /home/travis/build/apache/thrift/cmake_build/lib/java/libthrift-1.0.0-javadoc.jar
> to /usr/local/lib/java/libthrift-1.0.0-javadoc.jar due to failed to create
> the parent directory for /usr/local/lib/java/libthrift-1.0.0-javadoc.jar
> Total time: 11 seconds
> CPack: Create package
> CPack: - package:
> /home/travis/build/apache/thrift/cmake_build/thrift-1.0.0-dev-Linux.deb
> generated.
> The command "if [ "x$CMAKE_CONFIG" != "xnone" ] ; then cpack ; cd
> $TRAVIS_BUILD_DIR ; fi" exited with 0.
> 0.01s$ if [ "x$CONFIG" != "xnone" ] ; then sh bootstrap.sh ; fi
> The command "if [ "x$CONFIG" != "xnone" ] ; then sh bootstrap.sh ; fi" exited
> with 0.
> 0.01s$ if [ "x$CONFIG" != "xnone" ] ; then sh configure $CONFIG ; fi
> The command "if [ "x$CONFIG" != "xnone" ] ; then sh configure $CONFIG ; fi"
> exited with 0.
> 0.01s$ if [ "x$CONFIG" != "xnone" ] ; then make $MAKE_TARGET -j2 ; fi
> The command "if [ "x$CONFIG" != "xnone" ] ; then make $MAKE_TARGET -j2 ; fi"
> exited with 0.
> Done. Your build exited with 0.{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-2956) autoconf - possibly undefined macro - AC_PROG_BISON
[
https://issues.apache.org/jira/browse/THRIFT-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-2956:
---
Assignee: Jens Geyer
> autoconf - possibly undefined macro - AC_PROG_BISON
> ---
>
> Key: THRIFT-2956
> URL: https://issues.apache.org/jira/browse/THRIFT-2956
> Project: Thrift
> Issue Type: Question
> Components: Build Process
> Environment: Ubuntu and OS X
>Reporter: Andrew de Andrade
>Assignee: Jens Geyer
>Priority: Minor
>
> I'm trying to run `aclocal` and then `autoconf` on a fresh git clone and I
> get the following errors:
> {code}
> $ aclocal
> $ autoconf
> configure.ac:91: error: possibly undefined macro: AC_PROG_BISON
> If this token and others are legitimate, please use m4_pattern_allow.
> See the Autoconf documentation.
> configure.ac:271: error: possibly undefined macro: AC_PROG_PERL_MODULES
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-2956) autoconf - possibly undefined macro - AC_PROG_BISON
[
https://issues.apache.org/jira/browse/THRIFT-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-2956:
---
Issue Type: Question (was: Bug)
> autoconf - possibly undefined macro - AC_PROG_BISON
> ---
>
> Key: THRIFT-2956
> URL: https://issues.apache.org/jira/browse/THRIFT-2956
> Project: Thrift
> Issue Type: Question
> Components: Build Process
> Environment: Ubuntu and OS X
>Reporter: Andrew de Andrade
>Priority: Minor
>
> I'm trying to run `aclocal` and then `autoconf` on a fresh git clone and I
> get the following errors:
> {code}
> $ aclocal
> $ autoconf
> configure.ac:91: error: possibly undefined macro: AC_PROG_BISON
> If this token and others are legitimate, please use m4_pattern_allow.
> See the Autoconf documentation.
> configure.ac:271: error: possibly undefined macro: AC_PROG_PERL_MODULES
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-2956) autoconf - possibly undefined macro - AC_PROG_BISON
[
https://issues.apache.org/jira/browse/THRIFT-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-2956.
Resolution: Resolved
Solution was provided. In addition, the project is moving to cmake. Resolving.
> autoconf - possibly undefined macro - AC_PROG_BISON
> ---
>
> Key: THRIFT-2956
> URL: https://issues.apache.org/jira/browse/THRIFT-2956
> Project: Thrift
> Issue Type: Question
> Components: Build Process
> Environment: Ubuntu and OS X
>Reporter: Andrew de Andrade
>Assignee: Jens Geyer
>Priority: Minor
>
> I'm trying to run `aclocal` and then `autoconf` on a fresh git clone and I
> get the following errors:
> {code}
> $ aclocal
> $ autoconf
> configure.ac:91: error: possibly undefined macro: AC_PROG_BISON
> If this token and others are legitimate, please use m4_pattern_allow.
> See the Autoconf documentation.
> configure.ac:271: error: possibly undefined macro: AC_PROG_PERL_MODULES
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-3281) Travis CI build passed but the log says BUILD FAILED
[
https://issues.apache.org/jira/browse/THRIFT-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-3281:
---
Fix Version/s: 0.11.0
> Travis CI build passed but the log says BUILD FAILED
>
>
> Key: THRIFT-3281
> URL: https://issues.apache.org/jira/browse/THRIFT-3281
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
>Affects Versions: 0.9.3
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Minor
> Fix For: 0.11.0
>
>
> See: https://travis-ci.org/apache/thrift/jobs/73274645
> {noformat}
> javadoc:
> [javadoc] Generating Javadoc
> [javadoc] Javadoc execution
> [javadoc] Creating destination directory:
> "/home/travis/build/apache/thrift/cmake_build/lib/java/javadoc/"
> [javadoc] Loading source files for package org.apache.thrift...
> [javadoc] Loading source files for package org.apache.thrift.async...
> [javadoc] Loading source files for package org.apache.thrift.meta_data...
> [javadoc] Loading source files for package org.apache.thrift.protocol...
> [javadoc] Loading source files for package org.apache.thrift.scheme...
> [javadoc] Loading source files for package org.apache.thrift.server...
> [javadoc] Loading source files for package org.apache.thrift.transport...
> [javadoc] Constructing Javadoc information...
> [javadoc] Standard Doclet version 1.7.0_76
> [javadoc] Building tree for all the packages and classes...
> [javadoc]
> /home/travis/build/apache/thrift/lib/java/src/org/apache/thrift/server/TExtensibleServlet.java:68:
> warning - @return tag has no arguments.
> [javadoc]
> /home/travis/build/apache/thrift/lib/java/src/org/apache/thrift/server/TExtensibleServlet.java:76:
> warning - @return tag has no arguments.
> [javadoc]
> /home/travis/build/apache/thrift/lib/java/src/org/apache/thrift/server/TExtensibleServlet.java:84:
> warning - @return tag has no arguments.
> [javadoc] Building index for all the packages and classes...
> [javadoc] Building index for all classes...
> [javadoc] Generating
> /home/travis/build/apache/thrift/cmake_build/lib/java/javadoc/help-doc.html...
> [javadoc] 3 warnings
> [jar] Building jar:
> /home/travis/build/apache/thrift/cmake_build/lib/java/libthrift-1.0.0-javadoc.jar
> install:
> [copy] Copying 12 files to /usr/local/lib/java
> BUILD FAILED
> /home/travis/build/apache/thrift/lib/java/build.xml:148: Failed to copy
> /home/travis/build/apache/thrift/cmake_build/lib/java/libthrift-1.0.0-javadoc.jar
> to /usr/local/lib/java/libthrift-1.0.0-javadoc.jar due to failed to create
> the parent directory for /usr/local/lib/java/libthrift-1.0.0-javadoc.jar
> Total time: 11 seconds
> CPack: Create package
> CPack: - package:
> /home/travis/build/apache/thrift/cmake_build/thrift-1.0.0-dev-Linux.deb
> generated.
> The command "if [ "x$CMAKE_CONFIG" != "xnone" ] ; then cpack ; cd
> $TRAVIS_BUILD_DIR ; fi" exited with 0.
> 0.01s$ if [ "x$CONFIG" != "xnone" ] ; then sh bootstrap.sh ; fi
> The command "if [ "x$CONFIG" != "xnone" ] ; then sh bootstrap.sh ; fi" exited
> with 0.
> 0.01s$ if [ "x$CONFIG" != "xnone" ] ; then sh configure $CONFIG ; fi
> The command "if [ "x$CONFIG" != "xnone" ] ; then sh configure $CONFIG ; fi"
> exited with 0.
> 0.01s$ if [ "x$CONFIG" != "xnone" ] ; then make $MAKE_TARGET -j2 ; fi
> The command "if [ "x$CONFIG" != "xnone" ] ; then make $MAKE_TARGET -j2 ; fi"
> exited with 0.
> Done. Your build exited with 0.{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-3281) Travis CI build passed but the log says BUILD FAILED
[
https://issues.apache.org/jira/browse/THRIFT-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-3281:
---
Fix Version/s: (was: 0.11.0)
> Travis CI build passed but the log says BUILD FAILED
>
>
> Key: THRIFT-3281
> URL: https://issues.apache.org/jira/browse/THRIFT-3281
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
>Affects Versions: 0.9.3
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Minor
> Fix For: 0.11.0
>
>
> See: https://travis-ci.org/apache/thrift/jobs/73274645
> {noformat}
> javadoc:
> [javadoc] Generating Javadoc
> [javadoc] Javadoc execution
> [javadoc] Creating destination directory:
> "/home/travis/build/apache/thrift/cmake_build/lib/java/javadoc/"
> [javadoc] Loading source files for package org.apache.thrift...
> [javadoc] Loading source files for package org.apache.thrift.async...
> [javadoc] Loading source files for package org.apache.thrift.meta_data...
> [javadoc] Loading source files for package org.apache.thrift.protocol...
> [javadoc] Loading source files for package org.apache.thrift.scheme...
> [javadoc] Loading source files for package org.apache.thrift.server...
> [javadoc] Loading source files for package org.apache.thrift.transport...
> [javadoc] Constructing Javadoc information...
> [javadoc] Standard Doclet version 1.7.0_76
> [javadoc] Building tree for all the packages and classes...
> [javadoc]
> /home/travis/build/apache/thrift/lib/java/src/org/apache/thrift/server/TExtensibleServlet.java:68:
> warning - @return tag has no arguments.
> [javadoc]
> /home/travis/build/apache/thrift/lib/java/src/org/apache/thrift/server/TExtensibleServlet.java:76:
> warning - @return tag has no arguments.
> [javadoc]
> /home/travis/build/apache/thrift/lib/java/src/org/apache/thrift/server/TExtensibleServlet.java:84:
> warning - @return tag has no arguments.
> [javadoc] Building index for all the packages and classes...
> [javadoc] Building index for all classes...
> [javadoc] Generating
> /home/travis/build/apache/thrift/cmake_build/lib/java/javadoc/help-doc.html...
> [javadoc] 3 warnings
> [jar] Building jar:
> /home/travis/build/apache/thrift/cmake_build/lib/java/libthrift-1.0.0-javadoc.jar
> install:
> [copy] Copying 12 files to /usr/local/lib/java
> BUILD FAILED
> /home/travis/build/apache/thrift/lib/java/build.xml:148: Failed to copy
> /home/travis/build/apache/thrift/cmake_build/lib/java/libthrift-1.0.0-javadoc.jar
> to /usr/local/lib/java/libthrift-1.0.0-javadoc.jar due to failed to create
> the parent directory for /usr/local/lib/java/libthrift-1.0.0-javadoc.jar
> Total time: 11 seconds
> CPack: Create package
> CPack: - package:
> /home/travis/build/apache/thrift/cmake_build/thrift-1.0.0-dev-Linux.deb
> generated.
> The command "if [ "x$CMAKE_CONFIG" != "xnone" ] ; then cpack ; cd
> $TRAVIS_BUILD_DIR ; fi" exited with 0.
> 0.01s$ if [ "x$CONFIG" != "xnone" ] ; then sh bootstrap.sh ; fi
> The command "if [ "x$CONFIG" != "xnone" ] ; then sh bootstrap.sh ; fi" exited
> with 0.
> 0.01s$ if [ "x$CONFIG" != "xnone" ] ; then sh configure $CONFIG ; fi
> The command "if [ "x$CONFIG" != "xnone" ] ; then sh configure $CONFIG ; fi"
> exited with 0.
> 0.01s$ if [ "x$CONFIG" != "xnone" ] ; then make $MAKE_TARGET -j2 ; fi
> The command "if [ "x$CONFIG" != "xnone" ] ; then make $MAKE_TARGET -j2 ; fi"
> exited with 0.
> Done. Your build exited with 0.{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-2956) autoconf - possibly undefined macro - AC_PROG_BISON
[
https://issues.apache.org/jira/browse/THRIFT-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-2956:
---
Fix Version/s: 0.11.0
> autoconf - possibly undefined macro - AC_PROG_BISON
> ---
>
> Key: THRIFT-2956
> URL: https://issues.apache.org/jira/browse/THRIFT-2956
> Project: Thrift
> Issue Type: Question
> Components: Build Process
> Environment: Ubuntu and OS X
>Reporter: Andrew de Andrade
>Assignee: Jens Geyer
>Priority: Minor
> Fix For: 0.11.0
>
>
> I'm trying to run `aclocal` and then `autoconf` on a fresh git clone and I
> get the following errors:
> {code}
> $ aclocal
> $ autoconf
> configure.ac:91: error: possibly undefined macro: AC_PROG_BISON
> If this token and others are legitimate, please use m4_pattern_allow.
> See the Autoconf documentation.
> configure.ac:271: error: possibly undefined macro: AC_PROG_PERL_MODULES
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] thrift issue #1060: [THRIFT-3895] Fix java 1.8 with ant < 1.9 compatibility
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1060 If the only build failure turns out to be the unrelated hspec-core issue in job #17 I will ignore that and merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3895) Build fails using Java 1.8 with Ant < 1.9
[
https://issues.apache.org/jira/browse/THRIFT-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838630#comment-15838630
]
ASF GitHub Bot commented on THRIFT-3895:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1060
If the only build failure turns out to be the unrelated hspec-core issue in
job #17 I will ignore that and merge it.
> Build fails using Java 1.8 with Ant < 1.9
> -
>
> Key: THRIFT-3895
> URL: https://issues.apache.org/jira/browse/THRIFT-3895
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
>Affects Versions: 0.9.3
>Reporter: Adinata
>
> Failed with these errors:
> {code}
> Class not found: javac1.8
> {code}
> Solution:
> Add to all {{javac}} ant task attributes {{compiler="modern"}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Travis CI Build Failures - haskell
Many build jobs have been failing with this signature: Building hspec-core-2.4.0... Preprocessing library hspec-core-2.4.0... [ 1 of 22] Compiling Paths_hspec_core ( dist/build/autogen/Paths_hspec_core.hs, dist/build/Paths_hspec_core.o ) [ 2 of 22] Compiling Test.Hspec.Core.Timer ( src/Test/Hspec/Core/Timer.hs, dist/build/Test/Hspec/Core/Timer.o ) [ 3 of 22] Compiling Data.Algorithm.Diff ( vendor/Data/Algorithm/Diff.hs, dist/build/Data/Algorithm/Diff.o ) [ 4 of 22] Compiling Test.Hspec.Core.Formatters.Diff ( src/Test/Hspec/Core/Formatters/Diff.hs, dist/build/Test/Hspec/Core/Formatters/Diff.o ) [ 5 of 22] Compiling Test.Hspec.Core.Compat ( src/Test/Hspec/Core/Compat.hs, dist/build/Test/Hspec/Core/Compat.o ) [ 6 of 22] Compiling Test.Hspec.Core.Util ( src/Test/Hspec/Core/Util.hs, dist/build/Test/Hspec/Core/Util.o ) [ 7 of 22] Compiling Test.Hspec.Core.FailureReport ( src/Test/Hspec/Core/FailureReport.hs, dist/build/Test/Hspec/Core/FailureReport.o ) [ 8 of 22] Compiling Test.Hspec.Core.QuickCheckUtil ( src/Test/Hspec/Core/QuickCheckUtil.hs, dist/build/Test/Hspec/Core/QuickCheckUtil.o ) [ 9 of 22] Compiling Test.Hspec.Core.Formatters.Free ( src/Test/Hspec/Core/Formatters/Free.hs, dist/build/Test/Hspec/Core/Formatters/Free.o ) [10 of 22] Compiling Test.Hspec.Core.Example ( src/Test/Hspec/Core/Example.hs, dist/build/Test/Hspec/Core/Example.o ) src/Test/Hspec/Core/Example.hs:156:45: Couldn't match type `[Char]' with `FailureReason' Expected type: FailureReason Actual type: String In the second argument of `Failure', namely `err' In the expression: Failure Nothing err In a case alternative: HUnit.HUnitFailure err -> Failure Nothing err Failed to install hspec-core-2.4.0 cabal: Error: some packages failed to install: hspec-2.4.0 depends on hspec-core-2.4.0 which failed to install. hspec-core-2.4.0 failed during the building phase. The exception was: ExitFailure 1 make[2]: *** [lib/hs/thrift_cabal.stamp] Error 1 make[1]: *** [lib/hs/CMakeFiles/haskell_library.dir/all] Error 2 make: *** [all] Error 2 Does anybody know how to resolve this? Reference: https://travis-ci.org/apache/thrift/jobs/195278087 https://travis-ci.org/apache/thrift/builds/195278064 (Build job 17) [Description: Description: simplivity-lg-xsmall] James E. King, III Architect 8 Technology Drive, 2nd Floor Westborough, MA 01581-1756 Ph: 855-SVT-INFO --- PRIVACY STATEMENT: This message is a PRIVATE communication. This message and all attachments are a private communication sent by SimpliVity and are considered to be confidential or protected by privilege. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution or use of the information contained in or attached to this message is strictly prohibited. Please notify the sender of the delivery error by replying to this message, and then delete it from your system. ---
[jira] [Commented] (THRIFT-2945) Implement support for Rust language
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838683#comment-15838683 ] Jens Geyer commented on THRIFT-2945: I'm getting conflicts on merge? > Implement support for Rust language > --- > > Key: THRIFT-2945 > URL: https://issues.apache.org/jira/browse/THRIFT-2945 > Project: Thrift > Issue Type: New Feature > Components: Wish List >Reporter: Maksim Golov >Assignee: Jeremy Fitzhardinge > > Work on implementing support for Rust is in progress: > https://github.com/maximg/thrift by Simon Génier and myself. > It will probably take quite some time to complete. Please keep us updated if > there are changes related to our work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2364) OCaml: Use Oasis exclusively for build process
[ https://issues.apache.org/jira/browse/THRIFT-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838719#comment-15838719 ] James E. King, III commented on THRIFT-2364: I was able to apply this to the github master, build and install. I don't know ocaml however so I don't know if the resulting files work or not. The only change I had to make was that I had to add "*/*.mldylib" to the .gitignore. Also It looks like OCaml is not part of our standard build process (autoconf or cmake). It looks like OCaml is not tested as part of our "make cross" testing. I think that, in order to validate these are good changes, it would be a good idea to include OCaml as part of our docker based image and build. I am going to open some stories for this. > OCaml: Use Oasis exclusively for build process > -- > > Key: THRIFT-2364 > URL: https://issues.apache.org/jira/browse/THRIFT-2364 > Project: Thrift > Issue Type: Improvement > Components: Build Process, OCaml - Library > Environment: All environments >Reporter: Spiros Eliopoulos >Assignee: Spiros Eliopoulos >Priority: Minor > Attachments: THRIFT-2364.patch > > > The OCaml library currently contains custom makefiles, as well as an _oasis > configuration file that will generate a configuration script and Makefile. > The preferred method of the community for building OCaml libraries is to use > Oasis, so the other files should be dropped in favor of that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-4041) OCaml: Build and test as part of our regular cadence
James E. King, III created THRIFT-4041: -- Summary: OCaml: Build and test as part of our regular cadence Key: THRIFT-4041 URL: https://issues.apache.org/jira/browse/THRIFT-4041 Project: Thrift Issue Type: Improvement Components: OCaml - Library Affects Versions: 0.10.0 Reporter: James E. King, III Priority: Minor THRIFT-2364 provides an alternate build environment for the OCaml thrift bindings. It seems to work but I have no way to test it. I recommend that we add OCaml to the docker image and to the Appveyor environment and that we build OCaml through our CMake build process, and then provide "make cross" testing of OCaml. Without these things, changes like THRIFT-2364 cannot be tested through CI. Alternatively, if there is not enough demand for OCaml, we can move this from lib/ to contrib/, and then changes like this can be merged in without needing to go through the CI gate as maintenance would be handled externally. Given there is very little OCaml use evidence in Jira, I'll have to talk to the project coordinator to see what we want to do here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2945) Implement support for Rust language
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838727#comment-15838727 ] Allen George commented on THRIFT-2945: -- [~jensg] I don't see a conflict in github. Let me pull upstream master again and rebase. Give me 5 mins. > Implement support for Rust language > --- > > Key: THRIFT-2945 > URL: https://issues.apache.org/jira/browse/THRIFT-2945 > Project: Thrift > Issue Type: New Feature > Components: Wish List >Reporter: Maksim Golov >Assignee: Jeremy Fitzhardinge > > Work on implementing support for Rust is in progress: > https://github.com/maximg/thrift by Simon Génier and myself. > It will probably take quite some time to complete. Please keep us updated if > there are changes related to our work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2945) Implement support for Rust language
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838729#comment-15838729 ] Allen George commented on THRIFT-2945: -- [~jensg] Also, could you tell me while file is causing issues? > Implement support for Rust language > --- > > Key: THRIFT-2945 > URL: https://issues.apache.org/jira/browse/THRIFT-2945 > Project: Thrift > Issue Type: New Feature > Components: Wish List >Reporter: Maksim Golov >Assignee: Jeremy Fitzhardinge > > Work on implementing support for Rust is in progress: > https://github.com/maximg/thrift by Simon Génier and myself. > It will probably take quite some time to complete. Please keep us updated if > there are changes related to our work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2945) Implement support for Rust language
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838737#comment-15838737 ] Allen George commented on THRIFT-2945: -- [~jensg] I have just updated the PR commit after rebasing on master right now (the latest commit I have locally is 6fe7fa Thrift-3892). As far as I can tell on Github there are no merge conflicts. Could you let me know if there are any issues? I'd be happy to help track them down and resolve them. > Implement support for Rust language > --- > > Key: THRIFT-2945 > URL: https://issues.apache.org/jira/browse/THRIFT-2945 > Project: Thrift > Issue Type: New Feature > Components: Wish List >Reporter: Maksim Golov >Assignee: Jeremy Fitzhardinge > > Work on implementing support for Rust is in progress: > https://github.com/maximg/thrift by Simon Génier and myself. > It will probably take quite some time to complete. Please keep us updated if > there are changes related to our work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (THRIFT-2945) Implement support for Rust language
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838737#comment-15838737 ] Allen George edited comment on THRIFT-2945 at 1/25/17 10:40 PM: [~jensg] I have just updated the PR commit after rebasing on master right now (the latest commit I have locally is 6fe7fa Thrift-3892). As far as I can tell on Github there are no merge conflicts. Could you let me know if there are any issues? I'd be happy to help track them down and resolve them. Also, keep in mind that I've just been updating the PR in place (i.e. modifying the latest commit) so, if you've got a copy of my branch locally you will have to update it. was (Author: allengeorge): [~jensg] I have just updated the PR commit after rebasing on master right now (the latest commit I have locally is 6fe7fa Thrift-3892). As far as I can tell on Github there are no merge conflicts. Could you let me know if there are any issues? I'd be happy to help track them down and resolve them. > Implement support for Rust language > --- > > Key: THRIFT-2945 > URL: https://issues.apache.org/jira/browse/THRIFT-2945 > Project: Thrift > Issue Type: New Feature > Components: Wish List >Reporter: Maksim Golov >Assignee: Jeremy Fitzhardinge > > Work on implementing support for Rust is in progress: > https://github.com/maximg/thrift by Simon Génier and myself. > It will probably take quite some time to complete. Please keep us updated if > there are changes related to our work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2945) Implement support for Rust language
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838795#comment-15838795 ] Jens Geyer commented on THRIFT-2945: Ah, got it. The URL has changed, it's now thrift-2945-pr. I took the old one and hit the wall with tons of conflicts (not just one or two). Merge succeeded, looking into it ... > Implement support for Rust language > --- > > Key: THRIFT-2945 > URL: https://issues.apache.org/jira/browse/THRIFT-2945 > Project: Thrift > Issue Type: New Feature > Components: Wish List >Reporter: Maksim Golov >Assignee: Jeremy Fitzhardinge > > Work on implementing support for Rust is in progress: > https://github.com/maximg/thrift by Simon Génier and myself. > It will probably take quite some time to complete. Please keep us updated if > there are changes related to our work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2945) Implement support for Rust language
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838841#comment-15838841 ] Allen George commented on THRIFT-2945: -- Oh great! Yes - sorry about that. I had an initial PR that I abandoned; I squashed everything into a single commit and have simply been updating that. But, just to confirm, the latest hash I have is "b9b20fa0". Thank you for taking the time [~jensg] - and let me know if you've any questions or comments! > Implement support for Rust language > --- > > Key: THRIFT-2945 > URL: https://issues.apache.org/jira/browse/THRIFT-2945 > Project: Thrift > Issue Type: New Feature > Components: Wish List >Reporter: Maksim Golov >Assignee: Jeremy Fitzhardinge > > Work on implementing support for Rust is in progress: > https://github.com/maximg/thrift by Simon Génier and myself. > It will probably take quite some time to complete. Please keep us updated if > there are changes related to our work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request #1147: THRIFT-2945 Add Rust support
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1147 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2945) Implement support for Rust language
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838912#comment-15838912 ] ASF GitHub Bot commented on THRIFT-2945: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1147 > Implement support for Rust language > --- > > Key: THRIFT-2945 > URL: https://issues.apache.org/jira/browse/THRIFT-2945 > Project: Thrift > Issue Type: New Feature > Components: Wish List >Reporter: Maksim Golov >Assignee: Jeremy Fitzhardinge > > Work on implementing support for Rust is in progress: > https://github.com/maximg/thrift by Simon Génier and myself. > It will probably take quite some time to complete. Please keep us updated if > there are changes related to our work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2945) Implement support for Rust language
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2945: --- Component/s: (was: Wish List) Rust - Library Rust - Compiler > Implement support for Rust language > --- > > Key: THRIFT-2945 > URL: https://issues.apache.org/jira/browse/THRIFT-2945 > Project: Thrift > Issue Type: New Feature > Components: Rust - Compiler, Rust - Library >Reporter: Maksim Golov >Assignee: Jeremy Fitzhardinge > > Work on implementing support for Rust is in progress: > https://github.com/maximg/thrift by Simon Génier and myself. > It will probably take quite some time to complete. Please keep us updated if > there are changes related to our work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2945) Implement support for Rust language
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2945. Resolution: Fixed Assignee: Allen George (was: Jeremy Fitzhardinge) Fix Version/s: 0.11.0 Committed. Congratulations, and many thanks for the great work! (PS: When will we see JSON? ;-)) > Implement support for Rust language > --- > > Key: THRIFT-2945 > URL: https://issues.apache.org/jira/browse/THRIFT-2945 > Project: Thrift > Issue Type: New Feature > Components: Rust - Compiler, Rust - Library >Reporter: Maksim Golov >Assignee: Allen George > Fix For: 0.11.0 > > > Work on implementing support for Rust is in progress: > https://github.com/maximg/thrift by Simon Génier and myself. > It will probably take quite some time to complete. Please keep us updated if > there are changes related to our work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2945) Implement support for Rust language
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838919#comment-15838919 ] Anatol Pomozov commented on THRIFT-2945: Yay! It is great! And thank you Allen for your work! Who owns access to language package manager account (in case of Rust - http://crates.io)? Who publishes `thrift` crate? Is there a such thing as a Thrift language binding maintainer? Allen did a great work with Thrift. Is there an easy way for him to maintain his code? Anything like per-language commit access or something similar? > Implement support for Rust language > --- > > Key: THRIFT-2945 > URL: https://issues.apache.org/jira/browse/THRIFT-2945 > Project: Thrift > Issue Type: New Feature > Components: Rust - Compiler, Rust - Library >Reporter: Maksim Golov >Assignee: Allen George > Fix For: 0.11.0 > > > Work on implementing support for Rust is in progress: > https://github.com/maximg/thrift by Simon Génier and myself. > It will probably take quite some time to complete. Please keep us updated if > there are changes related to our work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2945) Implement support for Rust language
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838921#comment-15838921 ] Anatol Pomozov commented on THRIFT-2945: Also, when are you going to release a new version of Thrift? I know you just released 0.10.0 recently. Is there any hope that we will see 0.10.1 in the next few months? > Implement support for Rust language > --- > > Key: THRIFT-2945 > URL: https://issues.apache.org/jira/browse/THRIFT-2945 > Project: Thrift > Issue Type: New Feature > Components: Rust - Compiler, Rust - Library >Reporter: Maksim Golov >Assignee: Allen George > Fix For: 0.11.0 > > > Work on implementing support for Rust is in progress: > https://github.com/maximg/thrift by Simon Génier and myself. > It will probably take quite some time to complete. Please keep us updated if > there are changes related to our work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2945) Implement support for Rust language
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838941#comment-15838941 ] Jens Geyer commented on THRIFT-2945: Hi [~anatolikus], - Regarding the package stuff you should talk to [~jfarrell]. - Only [Apache Committers|https://www.apache.org/dev/committers.html] have write access to ASF repos, on a per-project basis (i.e. Thrift is a project), for a number of reasons. - Maintaining happens as before via Github and/or Patch files, reviews and finally commits. There is usually someone around that will take care of this. And since this is open source, everybody can [contribute|https://community.apache.org/contributors] by reviewing and testing patch proposals and giving useful feedback. > Implement support for Rust language > --- > > Key: THRIFT-2945 > URL: https://issues.apache.org/jira/browse/THRIFT-2945 > Project: Thrift > Issue Type: New Feature > Components: Rust - Compiler, Rust - Library >Reporter: Maksim Golov >Assignee: Allen George > Fix For: 0.11.0 > > > Work on implementing support for Rust is in progress: > https://github.com/maximg/thrift by Simon Génier and myself. > It will probably take quite some time to complete. Please keep us updated if > there are changes related to our work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (THRIFT-2945) Implement support for Rust language
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838941#comment-15838941 ] Jens Geyer edited comment on THRIFT-2945 at 1/26/17 1:00 AM: - Hi [~anatolikus], - Regarding the package stuff you should talk to [~jfarrell]. - Only [Apache Committers|https://www.apache.org/dev/committers.html] have write access to ASF repos, on a per-project basis (i.e. Thrift is a project), for a number of reasons. - Maintaining happens as before via Github and/or Patch files, reviews and finally commits. There is usually someone around that will take care of this. And since this is open source, everybody can [contribute|https://community.apache.org/contributors] by reviewing and testing patch proposals and giving useful feedback. PS: Please ask further questions like this on the mailing list. It doesn't really belong here. was (Author: jensg): Hi [~anatolikus], - Regarding the package stuff you should talk to [~jfarrell]. - Only [Apache Committers|https://www.apache.org/dev/committers.html] have write access to ASF repos, on a per-project basis (i.e. Thrift is a project), for a number of reasons. - Maintaining happens as before via Github and/or Patch files, reviews and finally commits. There is usually someone around that will take care of this. And since this is open source, everybody can [contribute|https://community.apache.org/contributors] by reviewing and testing patch proposals and giving useful feedback. > Implement support for Rust language > --- > > Key: THRIFT-2945 > URL: https://issues.apache.org/jira/browse/THRIFT-2945 > Project: Thrift > Issue Type: New Feature > Components: Rust - Compiler, Rust - Library >Reporter: Maksim Golov >Assignee: Allen George > Fix For: 0.11.0 > > > Work on implementing support for Rust is in progress: > https://github.com/maximg/thrift by Simon Génier and myself. > It will probably take quite some time to complete. Please keep us updated if > there are changes related to our work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request #1060: [THRIFT-3895] Fix java 1.8 with ant < 1.9 compati...
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1060 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3895) Build fails using Java 1.8 with Ant < 1.9
[
https://issues.apache.org/jira/browse/THRIFT-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838985#comment-15838985
]
ASF GitHub Bot commented on THRIFT-3895:
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1060
> Build fails using Java 1.8 with Ant < 1.9
> -
>
> Key: THRIFT-3895
> URL: https://issues.apache.org/jira/browse/THRIFT-3895
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
>Affects Versions: 0.9.3
>Reporter: Adinata
>Assignee: James E. King, III
> Fix For: 0.11.0
>
>
> Failed with these errors:
> {code}
> Class not found: javac1.8
> {code}
> Solution:
> Add to all {{javac}} ant task attributes {{compiler="modern"}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-3895) Build fails using Java 1.8 with Ant < 1.9
[
https://issues.apache.org/jira/browse/THRIFT-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-3895.
Resolution: Fixed
Assignee: James E. King, III
Fix Version/s: 0.11.0
> Build fails using Java 1.8 with Ant < 1.9
> -
>
> Key: THRIFT-3895
> URL: https://issues.apache.org/jira/browse/THRIFT-3895
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
>Affects Versions: 0.9.3
>Reporter: Adinata
>Assignee: James E. King, III
> Fix For: 0.11.0
>
>
> Failed with these errors:
> {code}
> Class not found: javac1.8
> {code}
> Solution:
> Add to all {{javac}} ant task attributes {{compiler="modern"}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] thrift pull request #1157: THRIFT-4033 disable compiler plug-ins for standar...
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1157 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Resolved] (THRIFT-4033) Default build WITH_PLUGIN=ON for all builds results in packaging errors
[
https://issues.apache.org/jira/browse/THRIFT-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4033.
Resolution: Fixed
Fix Version/s: 0.11.0
> Default build WITH_PLUGIN=ON for all builds results in packaging errors
> ---
>
> Key: THRIFT-4033
> URL: https://issues.apache.org/jira/browse/THRIFT-4033
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
>Affects Versions: 0.10.0
> Environment: Ubuntu 14.04.4 LTS is where I reproduced it.
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Critical
> Fix For: 0.11.0
>
>
> I built thrift-0.10.0 debian packages doing the following:
> # Clone the thrift project from github
> # Check out the 0.10.0 tag
> # Create a docker image: docker build -t thrift build/docker/ubuntu (from
> https://github.com/apache/thrift/tree/master/build/docker)
> # Load the image as a docker instance: docker run -v $(pwd):/thrift/src -it
> thrift /bin/bash
> # Run this command to build all debian package: dpkg-buildpackage -d -tc
> Then I replaced thrift-0.8.0 on my Ubuntu 14.04 system with the packages that
> I just built and tried to get the version from the thrift compiler:
> {noformat}
> jking@dvm61:~/thrift/packages/0.10.0/unpacked$ dpkg -l | grep thrift
> hi libthrift-dev 0.8.0-0+svt12
> amd64Thrift C++ library (development headers)
> ii libthrift-java0.8.0-0+svt12
> all Java bindings for Thrift
> hi libthrift-perl0.8.0-0+svt12
> all Perl bindings for Thrift
> hi libthrift00.8.0-0+svt12
> amd64Thrift C++ library
> hi php5-thrift 0.8.0-0+svt12
> amd64PHP bindings for Thrift
> ii python-thrift 0.8.0-0+svt12
> amd64Python bindings for Thrift
> ii thrift-compiler 0.8.0-0+svt12
> amd64Compiler for Thrift definition files
> jking@dvm61:~/thrift/packages/0.10.0/unpacked$ sudo dpkg -i
> libthrift0_0.10.0_amd64.deb libthrift-dev_0.10.0_amd64.deb
> libthrift-java_0.10.0_all.deb libthrift-perl_0.10.0_all.deb
> php5-thrift_0.10.0_amd64.deb python-thrift_0.10.0_amd64.deb
> thrift-compiler_0.10.0_amd64.deb
> (Reading database ... 232573 files and directories currently installed.)
> Preparing to unpack libthrift0_0.10.0_amd64.deb ...
> Unpacking libthrift0 (0.10.0) over (0.8.0-0+svt12) ...
> Preparing to unpack libthrift-dev_0.10.0_amd64.deb ...
> Unpacking libthrift-dev (0.10.0) over (0.8.0-0+svt12) ...
> Preparing to unpack libthrift-java_0.10.0_all.deb ...
> Unpacking libthrift-java (0.10.0) over (0.8.0-0+svt12) ...
> Preparing to unpack libthrift-perl_0.10.0_all.deb ...
> Unpacking libthrift-perl (0.10.0) over (0.8.0-0+svt12) ...
> Preparing to unpack php5-thrift_0.10.0_amd64.deb ...
> Unpacking php5-thrift (0.10.0) over (0.8.0-0+svt12) ...
> Preparing to unpack python-thrift_0.10.0_amd64.deb ...
> Unpacking python-thrift (0.10.0) over (0.8.0-0+svt12) ...
> Preparing to unpack thrift-compiler_0.10.0_amd64.deb ...
> Unpacking thrift-compiler (0.10.0) over (0.8.0-0+svt12) ...
> Setting up libthrift0 (0.10.0) ...
> Setting up libthrift-dev (0.10.0) ...
> Setting up libthrift-java (0.10.0) ...
> Setting up libthrift-perl (0.10.0) ...
> Setting up php5-thrift (0.10.0) ...
> Setting up python-thrift (0.10.0) ...
> Setting up thrift-compiler (0.10.0) ...
> Processing triggers for python-support (1.0.15) ...
> Processing triggers for libc-bin (2.19-0ubuntu6.7+svt1) ...
> jking@dvm61:~/thrift/packages/0.10.0/unpacked$ dpkg -l | grep thrift
> ii libthrift-dev 0.10.0
> amd64Thrift C++ library (development headers)
> ii libthrift-java0.10.0
> all Java bindings for Thrift
> ii libthrift-perl0.10.0
> all Perl bindings for Thrift
> ii libthrift00.10.0
> amd64Thrift C++ library
> ii php5-thrift 0.10.0
> amd64PHP bindings for Thrift
> ii python-thrift 0.10.0
> amd64Python bindings for Thrift (Python 2)
> ii thrift-compiler
[jira] [Commented] (THRIFT-4033) Default build WITH_PLUGIN=ON for all builds results in packaging errors
[
https://issues.apache.org/jira/browse/THRIFT-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838996#comment-15838996
]
ASF GitHub Bot commented on THRIFT-4033:
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1157
> Default build WITH_PLUGIN=ON for all builds results in packaging errors
> ---
>
> Key: THRIFT-4033
> URL: https://issues.apache.org/jira/browse/THRIFT-4033
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
>Affects Versions: 0.10.0
> Environment: Ubuntu 14.04.4 LTS is where I reproduced it.
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Critical
> Fix For: 0.11.0
>
>
> I built thrift-0.10.0 debian packages doing the following:
> # Clone the thrift project from github
> # Check out the 0.10.0 tag
> # Create a docker image: docker build -t thrift build/docker/ubuntu (from
> https://github.com/apache/thrift/tree/master/build/docker)
> # Load the image as a docker instance: docker run -v $(pwd):/thrift/src -it
> thrift /bin/bash
> # Run this command to build all debian package: dpkg-buildpackage -d -tc
> Then I replaced thrift-0.8.0 on my Ubuntu 14.04 system with the packages that
> I just built and tried to get the version from the thrift compiler:
> {noformat}
> jking@dvm61:~/thrift/packages/0.10.0/unpacked$ dpkg -l | grep thrift
> hi libthrift-dev 0.8.0-0+svt12
> amd64Thrift C++ library (development headers)
> ii libthrift-java0.8.0-0+svt12
> all Java bindings for Thrift
> hi libthrift-perl0.8.0-0+svt12
> all Perl bindings for Thrift
> hi libthrift00.8.0-0+svt12
> amd64Thrift C++ library
> hi php5-thrift 0.8.0-0+svt12
> amd64PHP bindings for Thrift
> ii python-thrift 0.8.0-0+svt12
> amd64Python bindings for Thrift
> ii thrift-compiler 0.8.0-0+svt12
> amd64Compiler for Thrift definition files
> jking@dvm61:~/thrift/packages/0.10.0/unpacked$ sudo dpkg -i
> libthrift0_0.10.0_amd64.deb libthrift-dev_0.10.0_amd64.deb
> libthrift-java_0.10.0_all.deb libthrift-perl_0.10.0_all.deb
> php5-thrift_0.10.0_amd64.deb python-thrift_0.10.0_amd64.deb
> thrift-compiler_0.10.0_amd64.deb
> (Reading database ... 232573 files and directories currently installed.)
> Preparing to unpack libthrift0_0.10.0_amd64.deb ...
> Unpacking libthrift0 (0.10.0) over (0.8.0-0+svt12) ...
> Preparing to unpack libthrift-dev_0.10.0_amd64.deb ...
> Unpacking libthrift-dev (0.10.0) over (0.8.0-0+svt12) ...
> Preparing to unpack libthrift-java_0.10.0_all.deb ...
> Unpacking libthrift-java (0.10.0) over (0.8.0-0+svt12) ...
> Preparing to unpack libthrift-perl_0.10.0_all.deb ...
> Unpacking libthrift-perl (0.10.0) over (0.8.0-0+svt12) ...
> Preparing to unpack php5-thrift_0.10.0_amd64.deb ...
> Unpacking php5-thrift (0.10.0) over (0.8.0-0+svt12) ...
> Preparing to unpack python-thrift_0.10.0_amd64.deb ...
> Unpacking python-thrift (0.10.0) over (0.8.0-0+svt12) ...
> Preparing to unpack thrift-compiler_0.10.0_amd64.deb ...
> Unpacking thrift-compiler (0.10.0) over (0.8.0-0+svt12) ...
> Setting up libthrift0 (0.10.0) ...
> Setting up libthrift-dev (0.10.0) ...
> Setting up libthrift-java (0.10.0) ...
> Setting up libthrift-perl (0.10.0) ...
> Setting up php5-thrift (0.10.0) ...
> Setting up python-thrift (0.10.0) ...
> Setting up thrift-compiler (0.10.0) ...
> Processing triggers for python-support (1.0.15) ...
> Processing triggers for libc-bin (2.19-0ubuntu6.7+svt1) ...
> jking@dvm61:~/thrift/packages/0.10.0/unpacked$ dpkg -l | grep thrift
> ii libthrift-dev 0.10.0
> amd64Thrift C++ library (development headers)
> ii libthrift-java0.10.0
> all Java bindings for Thrift
> ii libthrift-perl0.10.0
> all Perl bindings for Thrift
> ii libthrift00.10.0
> amd64Thrift C++ library
> ii php5-thrift 0.10.0
> amd64PHP bindings for Thrift
> ii python-thrift 0.10.0
> a
[jira] [Assigned] (THRIFT-3550) Latest indexed version of the perl lib on CPAN is 0.8.0, although 0.9.0 is present
[ https://issues.apache.org/jira/browse/THRIFT-3550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-3550: -- Assignee: James E. King, III > Latest indexed version of the perl lib on CPAN is 0.8.0, although 0.9.0 is > present > -- > > Key: THRIFT-3550 > URL: https://issues.apache.org/jira/browse/THRIFT-3550 > Project: Thrift > Issue Type: Wish > Components: Perl - Library >Affects Versions: 0.9.3 >Reporter: David Morel >Assignee: James E. King, III > > Running cpanm or cpan installs version 0.8.0 of the perl lib, although 0.9.0 > has been uploaded on PAUSE. > Also, would be nice to have v 0.9.3 since it's available? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-775) performance improvements for Perl
[ https://issues.apache.org/jira/browse/THRIFT-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-775. --- Resolution: Unresolved Assignee: James E. King, III Fix Version/s: 0.11.0 Issue is 7 years old. Closing. I use perl thrift regularly; performance improvements would be useful but we should open a new ticket if we're going to make those improvements. > performance improvements for Perl > - > > Key: THRIFT-775 > URL: https://issues.apache.org/jira/browse/THRIFT-775 > Project: Thrift > Issue Type: Improvement > Components: Perl - Compiler, Perl - Library >Reporter: Ted Zlatanov >Assignee: James E. King, III > Labels: benchmark, performance, perl > Fix For: 0.11.0 > > Attachments: nytprof.out.aa, nytprof.out.ab, tester.pl > > > The Perl libraries are 5-20x slower than the Java libraries for the same > data. Possible performance boosters: > - make fewer OO method calls > - build and use monolithic pack/unpack templates when possible -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3550) Latest indexed version of the perl lib on CPAN is 0.8.0, although 0.9.0 is present
[ https://issues.apache.org/jira/browse/THRIFT-3550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839004#comment-15839004 ] James E. King, III commented on THRIFT-3550: I will see about getting 0.9.3 and 0.10.0 published to cpan. > Latest indexed version of the perl lib on CPAN is 0.8.0, although 0.9.0 is > present > -- > > Key: THRIFT-3550 > URL: https://issues.apache.org/jira/browse/THRIFT-3550 > Project: Thrift > Issue Type: Wish > Components: Perl - Library >Affects Versions: 0.9.3 >Reporter: David Morel >Assignee: James E. King, III > > Running cpanm or cpan installs version 0.8.0 of the perl lib, although 0.9.0 > has been uploaded on PAUSE. > Also, would be nice to have v 0.9.3 since it's available? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-3550) Latest indexed version of the perl lib on CPAN is 0.8.0, although 0.9.0 is present
[ https://issues.apache.org/jira/browse/THRIFT-3550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3550: --- Affects Version/s: 0.10.0 > Latest indexed version of the perl lib on CPAN is 0.8.0, although 0.9.0 is > present > -- > > Key: THRIFT-3550 > URL: https://issues.apache.org/jira/browse/THRIFT-3550 > Project: Thrift > Issue Type: Wish > Components: Perl - Library >Affects Versions: 0.9.1, 0.9.2, 0.9.3, 0.10.0 >Reporter: David Morel >Assignee: James E. King, III > > Running cpanm or cpan installs version 0.8.0 of the perl lib, although 0.9.0 > has been uploaded on PAUSE. > Also, would be nice to have v 0.9.3 since it's available? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-3550) Latest indexed version of the perl lib on CPAN is 0.8.0, although 0.9.0 is present
[ https://issues.apache.org/jira/browse/THRIFT-3550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3550: --- Affects Version/s: 0.9.1 0.9.2 > Latest indexed version of the perl lib on CPAN is 0.8.0, although 0.9.0 is > present > -- > > Key: THRIFT-3550 > URL: https://issues.apache.org/jira/browse/THRIFT-3550 > Project: Thrift > Issue Type: Wish > Components: Perl - Library >Affects Versions: 0.9.1, 0.9.2, 0.9.3, 0.10.0 >Reporter: David Morel >Assignee: James E. King, III > > Running cpanm or cpan installs version 0.8.0 of the perl lib, although 0.9.0 > has been uploaded on PAUSE. > Also, would be nice to have v 0.9.3 since it's available? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-105) make a thrift_spec for a structures with negative tags
[ https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-105. --- Resolution: Won't Fix Assignee: James E. King, III (was: Alexander Shigin) Fix Version/s: 0.11.0 Issue is almost 9 years old now and there was no clear benefit from the initial performance testing. This may have already been done since this was opened; if there is interest let's start a new item in the backlog. > make a thrift_spec for a structures with negative tags > -- > > Key: THRIFT-105 > URL: https://issues.apache.org/jira/browse/THRIFT-105 > Project: Thrift > Issue Type: Improvement > Components: Python - Compiler, Python - Library, Test Suite >Reporter: Alexander Shigin >Assignee: James E. King, III > Fix For: 0.11.0 > > Attachments: thrift-python-offset.patch, > thrift-python-offset-v2.patch, thrift-python-offset-v3.patch, > thrift-python-offset-v4.diff, thrift-python-offset-v5.diff, > thrift-python-offset-v6.diff, thrift-python-offset-v7.diff > > > The patch introduces thrift_offset variable for a python thrift structures. > The change allows to use fastbinary module for structures with negative tags. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-448) Option to suppress specific compiler warnings
[ https://issues.apache.org/jira/browse/THRIFT-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839012#comment-15839012 ] James E. King, III commented on THRIFT-448: --- Still an issue we need to track? > Option to suppress specific compiler warnings > - > > Key: THRIFT-448 > URL: https://issues.apache.org/jira/browse/THRIFT-448 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General) >Reporter: Bryan Duxbury >Priority: Trivial > > It's super annoying to run the Thrift compiler in the tests because of the > warnings about potentially invalid i64 constants. I would love to be able to > specifically suppress that warning from showing up, since it's just noise in > the libraries I code in. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-281) Cocoa library code needs comments, badly
[ https://issues.apache.org/jira/browse/THRIFT-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-281: -- Issue Type: Improvement (was: Bug) > Cocoa library code needs comments, badly > > > Key: THRIFT-281 > URL: https://issues.apache.org/jira/browse/THRIFT-281 > Project: Thrift > Issue Type: Improvement > Components: Cocoa - Library >Reporter: Andrew McGeachie >Assignee: Andrew McGeachie >Priority: Minor > > A large portion of the Cocoa library code is lacking comments. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-472) Don't allow unquoted strings at all
[ https://issues.apache.org/jira/browse/THRIFT-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839017#comment-15839017 ] James E. King, III commented on THRIFT-472: --- Do you think this still occurs? > Don't allow unquoted strings at all > --- > > Key: THRIFT-472 > URL: https://issues.apache.org/jira/browse/THRIFT-472 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General) >Affects Versions: 0.1 >Reporter: Bryan Duxbury >Priority: Minor > > If you are working with constants in Thrift and happen to write a string > without quotes, the compiler will warn you about using unquoted strings, but > it's not an error. This can lead to some confusing debugging if you actually > mistyped an enum value's constant or the like. > I propose that rather than having such a thing as an "unquoted string", we > just check if it's a constant, and if not error out. It seems like it would > decrease the potential complexities without really sacrificing any > functionality. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-281) Cocoa library code needs comments, badly
[ https://issues.apache.org/jira/browse/THRIFT-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-281. --- Resolution: Won't Fix Assignee: James E. King, III (was: Andrew McGeachie) Fix Version/s: 0.11.0 Issue has been open for 8 years; unlikely to see any movement on this. I looked at the code and saw some comments; I agree not many, however code should be self-explanatory. > Cocoa library code needs comments, badly > > > Key: THRIFT-281 > URL: https://issues.apache.org/jira/browse/THRIFT-281 > Project: Thrift > Issue Type: Improvement > Components: Cocoa - Library >Reporter: Andrew McGeachie >Assignee: James E. King, III >Priority: Minor > Fix For: 0.11.0 > > > A large portion of the Cocoa library code is lacking comments. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-476) option to generate one file per class instead of one giant file
[ https://issues.apache.org/jira/browse/THRIFT-476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839022#comment-15839022 ] James E. King, III commented on THRIFT-476: --- Do you think this is still valid? > option to generate one file per class instead of one giant file > --- > > Key: THRIFT-476 > URL: https://issues.apache.org/jira/browse/THRIFT-476 > Project: Thrift > Issue Type: New Feature > Components: Ruby - Compiler >Affects Versions: 0.1 >Reporter: Bryan Duxbury >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-750) C++ Compiler Virtual Function Option
[ https://issues.apache.org/jira/browse/THRIFT-750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-750. --- Resolution: Won't Fix Assignee: James E. King, III Fix Version/s: 0.11.0 Issue has been outstanding for 7 years; recommend Won't Fix. We can re-open it as a new item against the current master if needed. > C++ Compiler Virtual Function Option > > > Key: THRIFT-750 > URL: https://issues.apache.org/jira/browse/THRIFT-750 > Project: Thrift > Issue Type: New Feature > Components: C++ - Compiler >Affects Versions: 0.2, 0.3 > Environment: Cygwin 1.7.1 on Windows XP SP3, Thrift 0.2.0 & r760184 & > Trunk >Reporter: Tim Wilson-Brown >Assignee: James E. King, III >Priority: Minor > Fix For: 0.11.0 > > Attachments: cpp_virtual_thrift020.patch, t_cpp_generator.cc > > Original Estimate: 24h > Remaining Estimate: 24h > > The C++ Compiler currelty emits most functions in the *Client class as > non-virtual. > This makes it difficult to subclass the generated *Client class and override > its functions. > In particular, if a subclass overrides the *_send and *_recv functions, it > must also override the function itself. > Otherwise, the *Client version of the function calls the *Client versions of > *_send and *_recv. > A workaround is to inherit from the interface class *If, which has virtual > functions, > and use them to call *Client class member functions. > But this can be cumbersome in some situations, and still requires additional > functions to be overridden. > I propose to add a virtual option to the C++ compiler that emits function > declarations as virtual. > I have attached a patched version of t_cpp_generator.cc from Thrift 0.2.0 - I > can work out how to turn it into a patch file if needed. > Is this worth merging into the trunk? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (THRIFT-1242) Unable to use typedef for exceptions
[ https://issues.apache.org/jira/browse/THRIFT-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-1242: -- Assignee: James E. King, III > Unable to use typedef for exceptions > > > Key: THRIFT-1242 > URL: https://issues.apache.org/jira/browse/THRIFT-1242 > Project: Thrift > Issue Type: Bug > Components: C# - Compiler >Affects Versions: 0.7 > Environment: Thrift trunk. >Reporter: Artem Oboturov >Assignee: James E. King, III >Priority: Minor > Attachments: thrift_typedef_exception_problem.zip > > > Unable to use typedef to make a shortcut for an exception type. Using the > same exception by referencing the full type works fine. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
