Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1156#discussion_r97858435 --- Diff: lib/go/test/tests/thrifttest_handler.go --- @@ -96,7 +96,7 @@ func (p *ThriftTestHandler) TestStringMap(thing map[string]string) (r map[string return thing, nil } -func (p *ThriftTestHandler) TestSet(thing map[int32]struct{}) (r map[int32]struct{}, err error) { +func (p *ThriftTestHandler) TestSet(thing []int32) (r []int32, err error) { --- End diff -- As long as it is a compile time failure if someone doesn't change it, that's good. In C++ (C++03, or C++11 without the "override" keyword being used) if you change the signature of a virtual method, anything that overrides it will silently define a new method instead of overriding what you want. It's pretty messy.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---