[GitHub] thrift issue #1191: Thrift 3706 - Implement multiplexor.
Github user gadLinux commented on the issue: https://github.com/apache/thrift/pull/1191 Hi Jeking3, You are right! I forgot this time to do the proper naming of the merge request. Yesterday I was thinking about the cross test. I will try to add a cross test for Java vs c_glib since it's the one actually tested in our own internal test. Do you have a guideline for the cross test? As you know I'm little lost there. Thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3369) Implement SSL/TLS support on C with c_glib
[ https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867065#comment-15867065 ] James E. King, III commented on THRIFT-3369: In the future you can use "git rebase -i HEAD~n" where n is the number of commits to squash. Change "pull" to "fixme" on all of YOUR commits except the first one. Don't do other commits. This squashes all your commits, as long as you didn't rebase to master. After doing this you need to force push to github. I keep all my github pull requests as single commits this way. Here's another page about squash and force push: https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit > Implement SSL/TLS support on C with c_glib > -- > > Key: THRIFT-3369 > URL: https://issues.apache.org/jira/browse/THRIFT-3369 > Project: Thrift > Issue Type: Improvement > Components: C glib - Library >Affects Versions: 0.9.1, 0.9.2, 0.9.3, 1.0 >Reporter: Gonzalo Aguilar >Assignee: James E. King, III > Labels: features, patch > Fix For: 0.11.0 > > > Implement SSL/TLS based on plain openssl instead of going through the way > defined in THRIFT-1016. > This help us to maintain a reference implementation and later switch over GIO > or whatever is defined. But also does not add any other dependencies to the > project. So bare minimum installation for supporting SSL/TLS is there and > aligned with CPP counterpart. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-3369) Implement SSL/TLS support on C with c_glib
[ https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867062#comment-15867062 ] James E. King, III commented on THRIFT-3369: For a multi-commit PR that isn't squashed (this had over 10 commits in it) I do a patch pull from githuib which squashes the commits into a single patch, and then I have to commit it under my account. This is why the third line of the commit has a "Patch" originator, which is you. > Implement SSL/TLS support on C with c_glib > -- > > Key: THRIFT-3369 > URL: https://issues.apache.org/jira/browse/THRIFT-3369 > Project: Thrift > Issue Type: Improvement > Components: C glib - Library >Affects Versions: 0.9.1, 0.9.2, 0.9.3, 1.0 >Reporter: Gonzalo Aguilar >Assignee: James E. King, III > Labels: features, patch > Fix For: 0.11.0 > > > Implement SSL/TLS based on plain openssl instead of going through the way > defined in THRIFT-1016. > This help us to maintain a reference implementation and later switch over GIO > or whatever is defined. But also does not add any other dependencies to the > project. So bare minimum installation for supporting SSL/TLS is there and > aligned with CPP counterpart. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-2364) OCaml: Use Oasis exclusively for build process
[ https://issues.apache.org/jira/browse/THRIFT-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866711#comment-15866711 ] ASF GitHub Bot commented on THRIFT-2364: GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1193 THRIFT-2364: use oasis to build thrift for ocaml You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift improvement/THRIFT-2364 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1193.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1193 commit 14c81f1f4941b9c6b9d687988cc01cdbcf084e39 Author: James E. King, III Date: 2017-01-25T22:20:33Z THRIFT-2364: use oasis to build thrift for ocaml > OCaml: Use Oasis exclusively for build process > -- > > Key: THRIFT-2364 > URL: https://issues.apache.org/jira/browse/THRIFT-2364 > Project: Thrift > Issue Type: Improvement > Components: Build Process, OCaml - Library > Environment: All environments >Reporter: Spiros Eliopoulos >Assignee: Spiros Eliopoulos >Priority: Minor > Attachments: THRIFT-2364.patch > > > The OCaml library currently contains custom makefiles, as well as an _oasis > configuration file that will generate a configuration script and Makefile. > The preferred method of the community for building OCaml libraries is to use > Oasis, so the other files should be dropped in favor of that. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift pull request #1193: THRIFT-2364: use oasis to build thrift for ocaml
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1193 THRIFT-2364: use oasis to build thrift for ocaml You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift improvement/THRIFT-2364 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1193.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1193 commit 14c81f1f4941b9c6b9d687988cc01cdbcf084e39 Author: James E. King, III Date: 2017-01-25T22:20:33Z THRIFT-2364: use oasis to build thrift for ocaml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-4041) Add OCaml to the ubuntu and debian build docker images
[ https://issues.apache.org/jira/browse/THRIFT-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866700#comment-15866700 ] ASF GitHub Bot commented on THRIFT-4041: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1190 > Add OCaml to the ubuntu and debian build docker images > -- > > Key: THRIFT-4041 > URL: https://issues.apache.org/jira/browse/THRIFT-4041 > Project: Thrift > Issue Type: Improvement > Components: OCaml - Library >Affects Versions: 0.10.0 >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Minor > > Add OCaml to the docker image so it can be used in CI builds. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (THRIFT-4041) Add OCaml to the ubuntu and debian build docker images
[ https://issues.apache.org/jira/browse/THRIFT-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4041. Resolution: Fixed > Add OCaml to the ubuntu and debian build docker images > -- > > Key: THRIFT-4041 > URL: https://issues.apache.org/jira/browse/THRIFT-4041 > Project: Thrift > Issue Type: Improvement > Components: OCaml - Library >Affects Versions: 0.10.0 >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Minor > > Add OCaml to the docker image so it can be used in CI builds. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift pull request #1190: THRIFT-4041: add ocaml and oasis to ubuntu and de...
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1190 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Closed] (THRIFT-4066) Perl client, C++ Server in cross test with SSL fails, tlsv1 alert unknown ca
[
https://issues.apache.org/jira/browse/THRIFT-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III closed THRIFT-4066.
--
> Perl client, C++ Server in cross test with SSL fails, tlsv1 alert unknown ca
>
>
> Key: THRIFT-4066
> URL: https://issues.apache.org/jira/browse/THRIFT-4066
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library, Perl - Library, Test Suite
>Affects Versions: 0.10.0
> Environment: Ubuntu 14.04 (gcc 4.6.4) Perl 5.18
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> I re-enabled the two cpp-perl SSL based tests in make cross and they failed:
> cpp-perlbinary framed-ip-sslfailure(255)
> cpp-perlbinary buffered-ip-ssl failure(255)
> The cpp server complained that "tlsv1 alert unknown ca".
> {noformat}
> Thu Feb 02 14:07:33 2017
> Executing: /home/jking/thrift/github/thrift/test/cpp/TestServer
> --protocol=binary --transport=buffered --ssl --port=41785
> Directory: /home/jking/thrift/github/thrift/test/cpp
> config:delay: 5
> config:timeout: 5
> ==
> Starting "simple" server (buffered/binary) listen on: 41785
> Thrift: Thu Feb 2 14:07:33 2017 TConnectedClient died: SSL_accept: error
> code: 0
> Thrift: Thu Feb 2 14:07:33 2017 TConnectedClient died: SSL_accept: tlsv1
> alert unknown ca
> Thrift: Thu Feb 2 14:07:33 2017 TConnectedClient died: SSL_accept: tlsv1
> alert unknown ca
> Thrift: Thu Feb 2 14:07:34 2017 TConnectedClient died: SSL_accept: tlsv1
> alert unknown ca
> Thrift: Thu Feb 2 14:07:34 2017 TConnectedClient died: SSL_accept: tlsv1
> alert unknown ca
> Thrift: Thu Feb 2 14:07:34 2017 TConnectedClient died: SSL_accept: tlsv1
> alert unknown ca
> Thrift: Thu Feb 2 14:07:34 2017 TConnectedClient died: SSL_accept: tlsv1
> alert unknown ca
> Thrift: Thu Feb 2 14:07:35 2017 TConnectedClient died: SSL_accept: tlsv1
> alert unknown ca
> Thrift: Thu Feb 2 14:07:35 2017 TConnectedClient died: SSL_accept: tlsv1
> alert unknown ca
> Server process is successfully killed.
> ==
> Process is killed.
> Test execution took 2.2 seconds.
> Thu Feb 02 14:07:35 2017
> {noformat}
> The perl client simply said it could not connect:
> {noformat}
> Thu Feb 02 14:07:35 2017
> Executing: perl -Igen-perl/ -I../../lib/perl/lib/ TestClient.pl
> --cert=../keys/client.pem --protocol=binary --transport=buffered --ssl
> --port=41785
> Directory: /home/jking/thrift/github/thrift/test/perl
> config:delay: 5
> config:timeout: 5
> ==
> $VAR1 = bless( {
> 'message' => 'Thrift::SSLSocket: Could not connect to
> localhost:41785 ()',
> 'code' => 0
>}, 'Thrift::TException' );
> ==
> Return code: 255
> Test execution took 0.1 seconds.
> Thu Feb 02 14:07:35 2017
> {noformat}
> Given both tests should be using the same certificate files, this is quite
> odd.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (THRIFT-4066) Perl client, C++ Server in cross test with SSL fails, tlsv1 alert unknown ca
[
https://issues.apache.org/jira/browse/THRIFT-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4066.
Resolution: Duplicate
Perl was not properly authenticating or verifying CA because it was not
possible to pass these down. This was fixed as part of THRIFT-3272.
> Perl client, C++ Server in cross test with SSL fails, tlsv1 alert unknown ca
>
>
> Key: THRIFT-4066
> URL: https://issues.apache.org/jira/browse/THRIFT-4066
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library, Perl - Library, Test Suite
>Affects Versions: 0.10.0
> Environment: Ubuntu 14.04 (gcc 4.6.4) Perl 5.18
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> I re-enabled the two cpp-perl SSL based tests in make cross and they failed:
> cpp-perlbinary framed-ip-sslfailure(255)
> cpp-perlbinary buffered-ip-ssl failure(255)
> The cpp server complained that "tlsv1 alert unknown ca".
> {noformat}
> Thu Feb 02 14:07:33 2017
> Executing: /home/jking/thrift/github/thrift/test/cpp/TestServer
> --protocol=binary --transport=buffered --ssl --port=41785
> Directory: /home/jking/thrift/github/thrift/test/cpp
> config:delay: 5
> config:timeout: 5
> ==
> Starting "simple" server (buffered/binary) listen on: 41785
> Thrift: Thu Feb 2 14:07:33 2017 TConnectedClient died: SSL_accept: error
> code: 0
> Thrift: Thu Feb 2 14:07:33 2017 TConnectedClient died: SSL_accept: tlsv1
> alert unknown ca
> Thrift: Thu Feb 2 14:07:33 2017 TConnectedClient died: SSL_accept: tlsv1
> alert unknown ca
> Thrift: Thu Feb 2 14:07:34 2017 TConnectedClient died: SSL_accept: tlsv1
> alert unknown ca
> Thrift: Thu Feb 2 14:07:34 2017 TConnectedClient died: SSL_accept: tlsv1
> alert unknown ca
> Thrift: Thu Feb 2 14:07:34 2017 TConnectedClient died: SSL_accept: tlsv1
> alert unknown ca
> Thrift: Thu Feb 2 14:07:34 2017 TConnectedClient died: SSL_accept: tlsv1
> alert unknown ca
> Thrift: Thu Feb 2 14:07:35 2017 TConnectedClient died: SSL_accept: tlsv1
> alert unknown ca
> Thrift: Thu Feb 2 14:07:35 2017 TConnectedClient died: SSL_accept: tlsv1
> alert unknown ca
> Server process is successfully killed.
> ==
> Process is killed.
> Test execution took 2.2 seconds.
> Thu Feb 02 14:07:35 2017
> {noformat}
> The perl client simply said it could not connect:
> {noformat}
> Thu Feb 02 14:07:35 2017
> Executing: perl -Igen-perl/ -I../../lib/perl/lib/ TestClient.pl
> --cert=../keys/client.pem --protocol=binary --transport=buffered --ssl
> --port=41785
> Directory: /home/jking/thrift/github/thrift/test/perl
> config:delay: 5
> config:timeout: 5
> ==
> $VAR1 = bless( {
> 'message' => 'Thrift::SSLSocket: Could not connect to
> localhost:41785 ()',
> 'code' => 0
>}, 'Thrift::TException' );
> ==
> Return code: 255
> Test execution took 0.1 seconds.
> Thu Feb 02 14:07:35 2017
> {noformat}
> Given both tests should be using the same certificate files, this is quite
> odd.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Assigned] (THRIFT-3272) Perl SSL Authentication Support
[ https://issues.apache.org/jira/browse/THRIFT-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-3272: -- Assignee: James E. King, III > Perl SSL Authentication Support > --- > > Key: THRIFT-3272 > URL: https://issues.apache.org/jira/browse/THRIFT-3272 > Project: Thrift > Issue Type: Improvement > Components: Perl - Library >Affects Versions: 0.9.3 >Reporter: James E. King, III >Assignee: James E. King, III > > In THRIFT-3053 SSL support was added to perl, however it only supports > encryption and the ability to select the certificate to use. No support was > added for authentication, and that needs to be done. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4091) Removed unused realloc test causing autoconf warnings at bootstrap time
[
https://issues.apache.org/jira/browse/THRIFT-4091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866371#comment-15866371
]
ASF GitHub Bot commented on THRIFT-4091:
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1192
THRIFT-4091 - revert THRIFT-4045 (bad change) and remove unused test code
in test/cpp
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT-4091
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1192.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1192
commit 80f76e835219e5dc450870f93c1dd9511594eb39
Author: James E. King, III
Date: 2017-02-14T17:50:45Z
THRIFT-4091 - revert THRIFT-4045 and remove unused test code in test/cpp
> Removed unused realloc test causing autoconf warnings at bootstrap time
> ---
>
> Key: THRIFT-4091
> URL: https://issues.apache.org/jira/browse/THRIFT-4091
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Affects Versions: 0.10.0
> Environment: Ubuntu 14.04
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Trivial
>
> Following THRIFT-4045 bootstrap posts a couple warnings:
> {noformat}
> configure.ac: warning: missing AC_FUNC_MALLOC wanted by:
> test/cpp/realloc/realloc_test.c:99
> configure.ac: warning: missing AC_FUNC_REALLOC wanted by:
> test/cpp/realloc/realloc_test.c:29
> {noformat}
> This test is not built or used so it can be removed. Removing the test
> uncovers others, so THRIFT-4045 is a bad fix. Revert it and provide guidance.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] thrift pull request #1192: THRIFT-4091 - revert THRIFT-4045 (bad change) and...
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1192 THRIFT-4091 - revert THRIFT-4045 (bad change) and remove unused test code in test/cpp You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift THRIFT-4091 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1192.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1192 commit 80f76e835219e5dc450870f93c1dd9511594eb39 Author: James E. King, III Date: 2017-02-14T17:50:45Z THRIFT-4091 - revert THRIFT-4045 and remove unused test code in test/cpp --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3770) Support Python 3.4+ asyncio support
[ https://issues.apache.org/jira/browse/THRIFT-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866313#comment-15866313 ] ASF GitHub Bot commented on THRIFT-3770: Github user vmarkovtsev commented on the issue: https://github.com/apache/thrift/pull/972 I will resume this as soon as the maintainers show up themselves :) Since the last time there appeared conflicts and I don't want to resolve them multiple times - not working with Thrift anymore. > Support Python 3.4+ asyncio support > --- > > Key: THRIFT-3770 > URL: https://issues.apache.org/jira/browse/THRIFT-3770 > Project: Thrift > Issue Type: Bug > Components: Python - Compiler, Python - Library >Affects Versions: 1.0 >Reporter: Vadim Markovtsev >Priority: Minor > Labels: features > > Currently, Tornado and Twisted async engines are supported in client lib and > the compiler. asyncio is a relatively new engine which is included into > Python 3.4+ standard library. It is gaining popularity fast. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift issue #972: THRIFT-3770 Implement Python 3.4+ asyncio support
Github user vmarkovtsev commented on the issue: https://github.com/apache/thrift/pull/972 I will resume this as soon as the maintainers show up themselves :) Since the last time there appeared conflicts and I don't want to resolve them multiple times - not working with Thrift anymore. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #972: THRIFT-3770 Implement Python 3.4+ asyncio support
Github user AndreLouisCaron commented on the issue: https://github.com/apache/thrift/pull/972 I'm interested in using this. I see that [facebook/fbthrift](https://github.com/facebook/fbthrift) has support for it, but it's not in PyPI. Any chance work on this PR will resume? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3706) There's no support for Multiplexed protocol on c_glib library
[ https://issues.apache.org/jira/browse/THRIFT-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866298#comment-15866298 ] ASF GitHub Bot commented on THRIFT-3706: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1191 In the future please format your pull request title to start with THRIFT-3706 so that the bots link the pull request to the open Jira item. Thanks! > There's no support for Multiplexed protocol on c_glib library > - > > Key: THRIFT-3706 > URL: https://issues.apache.org/jira/browse/THRIFT-3706 > Project: Thrift > Issue Type: Improvement > Components: C glib - Library >Affects Versions: 0.9.3 >Reporter: Gonzalo Aguilar >Assignee: Gonzalo Aguilar > > There's no multiplexed protocol. > I will implement the same way it's done in Java an C++ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift issue #1191: Thrift 3706 - Implement multiplexor.
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1191 In the future please format your pull request title to start with THRIFT-3706 so that the bots link the pull request to the open Jira item. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1191: Thrift 3706 - Implement multiplexor.
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1191 What testing have you done to verify this code (I have to ask because there is no multiplexed protocol testing being done in crosstest currently)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3770) Support Python 3.4+ asyncio support
[ https://issues.apache.org/jira/browse/THRIFT-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866281#comment-15866281 ] ASF GitHub Bot commented on THRIFT-3770: Github user AndreLouisCaron commented on the issue: https://github.com/apache/thrift/pull/972 I'm interested in using this. I see that [facebook/fbthrift](https://github.com/facebook/fbthrift) has support for it, but it's not in PyPI. Any chance work on this PR will resume? > Support Python 3.4+ asyncio support > --- > > Key: THRIFT-3770 > URL: https://issues.apache.org/jira/browse/THRIFT-3770 > Project: Thrift > Issue Type: Bug > Components: Python - Compiler, Python - Library >Affects Versions: 1.0 >Reporter: Vadim Markovtsev >Priority: Minor > Labels: features > > Currently, Tornado and Twisted async engines are supported in client lib and > the compiler. asyncio is a relatively new engine which is included into > Python 3.4+ standard library. It is gaining popularity fast. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (THRIFT-4091) Removed unused realloc test causing autoconf warnings at bootstrap time
[
https://issues.apache.org/jira/browse/THRIFT-4091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4091:
---
Issue Type: Bug (was: Test)
> Removed unused realloc test causing autoconf warnings at bootstrap time
> ---
>
> Key: THRIFT-4091
> URL: https://issues.apache.org/jira/browse/THRIFT-4091
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Affects Versions: 0.10.0
> Environment: Ubuntu 14.04
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Trivial
>
> Following THRIFT-4045 bootstrap posts a couple warnings:
> {noformat}
> configure.ac: warning: missing AC_FUNC_MALLOC wanted by:
> test/cpp/realloc/realloc_test.c:99
> configure.ac: warning: missing AC_FUNC_REALLOC wanted by:
> test/cpp/realloc/realloc_test.c:29
> {noformat}
> This test is not built or used so it can be removed. Removing the test
> uncovers others, so THRIFT-4045 is a bad fix. Revert it and provide guidance.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (THRIFT-4091) Removed unused realloc test causing autoconf warnings at bootstrap time
[
https://issues.apache.org/jira/browse/THRIFT-4091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4091:
---
Description:
Following THRIFT-4045 bootstrap posts a couple warnings:
{noformat}
configure.ac: warning: missing AC_FUNC_MALLOC wanted by:
test/cpp/realloc/realloc_test.c:99
configure.ac: warning: missing AC_FUNC_REALLOC wanted by:
test/cpp/realloc/realloc_test.c:29
{noformat}
This test is not built or used so it can be removed. Removing the test
uncovers others, so THRIFT-4045 is a bad fix. Revert it and provide guidance.
was:
Following THRIFT-4045 bootstrap posts a couple warnings:
{noformat}
configure.ac: warning: missing AC_FUNC_MALLOC wanted by:
test/cpp/realloc/realloc_test.c:99
configure.ac: warning: missing AC_FUNC_REALLOC wanted by:
test/cpp/realloc/realloc_test.c:29
{noformat}
This test is not built or used so it can be removed.
> Removed unused realloc test causing autoconf warnings at bootstrap time
> ---
>
> Key: THRIFT-4091
> URL: https://issues.apache.org/jira/browse/THRIFT-4091
> Project: Thrift
> Issue Type: Test
> Components: C++ - Library
>Affects Versions: 0.10.0
> Environment: Ubuntu 14.04
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Trivial
>
> Following THRIFT-4045 bootstrap posts a couple warnings:
> {noformat}
> configure.ac: warning: missing AC_FUNC_MALLOC wanted by:
> test/cpp/realloc/realloc_test.c:99
> configure.ac: warning: missing AC_FUNC_REALLOC wanted by:
> test/cpp/realloc/realloc_test.c:29
> {noformat}
> This test is not built or used so it can be removed. Removing the test
> uncovers others, so THRIFT-4045 is a bad fix. Revert it and provide guidance.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (THRIFT-4045) Remove AC_FUNC_MALLOC and AC_FUNC_REALLOC to fix building with Address Sanitizer
[ https://issues.apache.org/jira/browse/THRIFT-4045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4045. Resolution: Won't Fix Fix Version/s: (was: 0.11.0) Use cmake instead of autoconf for address sanitized builds, or modify the file locally as in the original pull requests. This causes autoconf warnings when removed. > Remove AC_FUNC_MALLOC and AC_FUNC_REALLOC to fix building with Address > Sanitizer > > > Key: THRIFT-4045 > URL: https://issues.apache.org/jira/browse/THRIFT-4045 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.10.0 >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Trivial > > Created for https://github.com/apache/thrift/pull/1065 > Note: this was later reverted in THRIFT-4091. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (THRIFT-4045) Remove AC_FUNC_MALLOC and AC_FUNC_REALLOC to fix building with Address Sanitizer
[ https://issues.apache.org/jira/browse/THRIFT-4045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III closed THRIFT-4045. -- > Remove AC_FUNC_MALLOC and AC_FUNC_REALLOC to fix building with Address > Sanitizer > > > Key: THRIFT-4045 > URL: https://issues.apache.org/jira/browse/THRIFT-4045 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.10.0 >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Trivial > > Created for https://github.com/apache/thrift/pull/1065 > Note: this was later reverted in THRIFT-4091. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (THRIFT-4045) Remove AC_FUNC_MALLOC and AC_FUNC_REALLOC to fix building with Address Sanitizer
[ https://issues.apache.org/jira/browse/THRIFT-4045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4045: --- Description: Created for https://github.com/apache/thrift/pull/1065 Note: this was later reverted in THRIFT-4091. was:Created for https://github.com/apache/thrift/pull/1065 > Remove AC_FUNC_MALLOC and AC_FUNC_REALLOC to fix building with Address > Sanitizer > > > Key: THRIFT-4045 > URL: https://issues.apache.org/jira/browse/THRIFT-4045 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.10.0 >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Trivial > Fix For: 0.11.0 > > > Created for https://github.com/apache/thrift/pull/1065 > Note: this was later reverted in THRIFT-4091. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Reopened] (THRIFT-4045) Remove AC_FUNC_MALLOC and AC_FUNC_REALLOC to fix building with Address Sanitizer
[ https://issues.apache.org/jira/browse/THRIFT-4045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reopened THRIFT-4045: > Remove AC_FUNC_MALLOC and AC_FUNC_REALLOC to fix building with Address > Sanitizer > > > Key: THRIFT-4045 > URL: https://issues.apache.org/jira/browse/THRIFT-4045 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.10.0 >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Trivial > Fix For: 0.11.0 > > > Created for https://github.com/apache/thrift/pull/1065 > Note: this was later reverted in THRIFT-4091. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (THRIFT-4091) Removed unused realloc test causing autoconf warnings at bootstrap time
James E. King, III created THRIFT-4091:
--
Summary: Removed unused realloc test causing autoconf warnings at
bootstrap time
Key: THRIFT-4091
URL: https://issues.apache.org/jira/browse/THRIFT-4091
Project: Thrift
Issue Type: Test
Components: C++ - Library
Affects Versions: 0.10.0
Environment: Ubuntu 14.04
Reporter: James E. King, III
Assignee: James E. King, III
Priority: Trivial
Following THRIFT-4045 bootstrap posts a couple warnings:
{noformat}
configure.ac: warning: missing AC_FUNC_MALLOC wanted by:
test/cpp/realloc/realloc_test.c:99
configure.ac: warning: missing AC_FUNC_REALLOC wanted by:
test/cpp/realloc/realloc_test.c:29
{noformat}
This test is not built or used so it can be removed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] thrift pull request #1191: Thrift 3706 - Implement multiplexor.
GitHub user gadLinux opened a pull request: https://github.com/apache/thrift/pull/1191 Thrift 3706 - Implement multiplexor. Implement protocol multiplexor. Implement protocol decorator. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gadLinux/thrift thrift-3706 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1191.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1191 commit 226710b0a62b9f8a7f32c18ae77132e405996a9a Author: Gonzalo Aguilar Delgado Date: 2016-03-04T12:16:22Z Implement multiplexed protocol commit 619f54b90bc6a5724400fdb9e71b3d50b3e26e17 Author: Gonzalo Aguilar Delgado Date: 2016-03-05T00:21:27Z Implement protocol multiplexor. For me there are a pair of things missing. Implement protocol decorator. commit c734748f712fb4133e6a031640a9a4be3f361ae2 Author: Gonzalo Aguilar Delgado Date: 2016-03-28T23:08:52Z Fix protocol decorator cause it failed to register list cls->read_list_end on thrift_protocol_decorator_class_init Change log to debug --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3706) There's no support for Multiplexed protocol on c_glib library
[ https://issues.apache.org/jira/browse/THRIFT-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866136#comment-15866136 ] ASF GitHub Bot commented on THRIFT-3706: Github user gadLinux commented on the issue: https://github.com/apache/thrift/pull/927 I will redo it > There's no support for Multiplexed protocol on c_glib library > - > > Key: THRIFT-3706 > URL: https://issues.apache.org/jira/browse/THRIFT-3706 > Project: Thrift > Issue Type: Improvement > Components: C glib - Library >Affects Versions: 0.9.3 >Reporter: Gonzalo Aguilar >Assignee: Gonzalo Aguilar > > There's no multiplexed protocol. > I will implement the same way it's done in Java an C++ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-3706) There's no support for Multiplexed protocol on c_glib library
[ https://issues.apache.org/jira/browse/THRIFT-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866137#comment-15866137 ] ASF GitHub Bot commented on THRIFT-3706: Github user gadLinux closed the pull request at: https://github.com/apache/thrift/pull/927 > There's no support for Multiplexed protocol on c_glib library > - > > Key: THRIFT-3706 > URL: https://issues.apache.org/jira/browse/THRIFT-3706 > Project: Thrift > Issue Type: Improvement > Components: C glib - Library >Affects Versions: 0.9.3 >Reporter: Gonzalo Aguilar >Assignee: Gonzalo Aguilar > > There's no multiplexed protocol. > I will implement the same way it's done in Java an C++ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift pull request #927: THRIFT-3706 : Implement protocol multiplexor in c_...
Github user gadLinux closed the pull request at: https://github.com/apache/thrift/pull/927 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #927: THRIFT-3706 : Implement protocol multiplexor in c_glib [R...
Github user gadLinux commented on the issue: https://github.com/apache/thrift/pull/927 I will redo it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3369) Implement SSL/TLS support on C with c_glib
[ https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866087#comment-15866087 ] Gonzalo Aguilar commented on THRIFT-3369: - Why I'm not the committer for this incident? > Implement SSL/TLS support on C with c_glib > -- > > Key: THRIFT-3369 > URL: https://issues.apache.org/jira/browse/THRIFT-3369 > Project: Thrift > Issue Type: Improvement > Components: C glib - Library >Affects Versions: 0.9.1, 0.9.2, 0.9.3, 1.0 >Reporter: Gonzalo Aguilar >Assignee: James E. King, III > Labels: features, patch > Fix For: 0.11.0 > > > Implement SSL/TLS based on plain openssl instead of going through the way > defined in THRIFT-1016. > This help us to maintain a reference implementation and later switch over GIO > or whatever is defined. But also does not add any other dependencies to the > project. So bare minimum installation for supporting SSL/TLS is there and > aligned with CPP counterpart. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (THRIFT-3369) Implement SSL/TLS support on C with c_glib
[ https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3369. Resolution: Fixed Fix Version/s: 0.11.0 > Implement SSL/TLS support on C with c_glib > -- > > Key: THRIFT-3369 > URL: https://issues.apache.org/jira/browse/THRIFT-3369 > Project: Thrift > Issue Type: Improvement > Components: C glib - Library >Affects Versions: 0.9.1, 0.9.2, 0.9.3, 1.0 >Reporter: Gonzalo Aguilar >Assignee: James E. King, III > Labels: features, patch > Fix For: 0.11.0 > > > Implement SSL/TLS based on plain openssl instead of going through the way > defined in THRIFT-1016. > This help us to maintain a reference implementation and later switch over GIO > or whatever is defined. But also does not add any other dependencies to the > project. So bare minimum installation for supporting SSL/TLS is there and > aligned with CPP counterpart. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (THRIFT-3369) Implement SSL/TLS support on C with c_glib
[ https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-3369: -- Assignee: James E. King, III > Implement SSL/TLS support on C with c_glib > -- > > Key: THRIFT-3369 > URL: https://issues.apache.org/jira/browse/THRIFT-3369 > Project: Thrift > Issue Type: Improvement > Components: C glib - Library >Affects Versions: 0.9.1, 0.9.2, 0.9.3, 1.0 >Reporter: Gonzalo Aguilar >Assignee: James E. King, III > Labels: features, patch > Fix For: 0.11.0 > > > Implement SSL/TLS based on plain openssl instead of going through the way > defined in THRIFT-1016. > This help us to maintain a reference implementation and later switch over GIO > or whatever is defined. But also does not add any other dependencies to the > project. So bare minimum installation for supporting SSL/TLS is there and > aligned with CPP counterpart. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4089) Several issues with generated Python code: TFrozenDict, _fast_encode
[ https://issues.apache.org/jira/browse/THRIFT-4089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865866#comment-15865866 ] Manasi Vartak commented on THRIFT-4089: --- Got it. Let me check on that. > Several issues with generated Python code: TFrozenDict, _fast_encode > > > Key: THRIFT-4089 > URL: https://issues.apache.org/jira/browse/THRIFT-4089 > Project: Thrift > Issue Type: Bug > Components: Python - Compiler >Affects Versions: 0.10.0 > Environment: Python 2.7, 3.5. OS-X >Reporter: Manasi Vartak > > When you generate Python sources for a simple thrift file (e.g. Thrift > tutorial from https://thrift.apache.org/tutorial/py will also repro erros), > errors are thrown while running the PythonServer and PythonClient. > 1. When running the vanilla PythonServer, I get the following error: > File "gen-py/shared/SharedService.py", line 9, in > from thrift.Thrift import TType, TMessageType, TFrozenDict, TException, > TApplicationException > ImportError: cannot import name TFrozenDict > I see this error consistently for all generated thrift files. The error > disappears on removing TFrozenDict from the generated files (it is not used > anywhere in the file). > 2. When running the vanilla PythonClient (the server is now running after the > above fix), I get the following error: > File "PythonClient.py", line 51, in main > client.ping() > File "gen-py/tutorial/Calculator.py", line 73, in ping > self.send_ping() > File "gen-py/tutorial/Calculator.py", line 79, in send_ping > args.write(self._oprot) > File "gen-py/tutorial/Calculator.py", line 297, in write > if oprot._fast_encode is not None and self.thrift_spec is not None: > AttributeError: TBinaryProtocol instance has no attribute '_fast_encode' > I am not sure why this error is being thrown/what can be done to fix it. > These two errors, and mainly the latter one, are rendering the Server/Client > un-usable. Is this a known issue? And how do you recommend working around it? -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (THRIFT-4041) Add OCaml to the ubuntu and debian build docker images
[ https://issues.apache.org/jira/browse/THRIFT-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4041: --- Summary: Add OCaml to the ubuntu and debian build docker images (was: OCaml: Build and test as part of our regular cadence) > Add OCaml to the ubuntu and debian build docker images > -- > > Key: THRIFT-4041 > URL: https://issues.apache.org/jira/browse/THRIFT-4041 > Project: Thrift > Issue Type: Improvement > Components: OCaml - Library >Affects Versions: 0.10.0 >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Minor > > Add OCaml to the docker image so it can be used in CI builds. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (THRIFT-4041) OCaml: Build and test as part of our regular cadence
[ https://issues.apache.org/jira/browse/THRIFT-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4041: -- Assignee: James E. King, III > OCaml: Build and test as part of our regular cadence > > > Key: THRIFT-4041 > URL: https://issues.apache.org/jira/browse/THRIFT-4041 > Project: Thrift > Issue Type: Improvement > Components: OCaml - Library >Affects Versions: 0.10.0 >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Minor > > Add OCaml to the docker image so it can be used in CI builds. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4041) OCaml: Build and test as part of our regular cadence
[ https://issues.apache.org/jira/browse/THRIFT-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865845#comment-15865845 ] ASF GitHub Bot commented on THRIFT-4041: GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1190 THRIFT-4041: add ocaml and oasis to ubuntu and debian dockerfiles You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift THRIFT-4041 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1190.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1190 commit 8575ce4abf4bb9289040fa90277649de52a70654 Author: James E. King, III Date: 2017-02-13T23:33:03Z THRIFT-4041: add ocaml and oasis to ubuntu and debian dockerfiles > OCaml: Build and test as part of our regular cadence > > > Key: THRIFT-4041 > URL: https://issues.apache.org/jira/browse/THRIFT-4041 > Project: Thrift > Issue Type: Improvement > Components: OCaml - Library >Affects Versions: 0.10.0 >Reporter: James E. King, III >Priority: Minor > > Add OCaml to the docker image so it can be used in CI builds. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (THRIFT-4041) OCaml: Build and test as part of our regular cadence
[ https://issues.apache.org/jira/browse/THRIFT-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4041: --- Description: Add OCaml to the docker image so it can be used in CI builds. (was: THRIFT-2364 provides an alternate build environment for the OCaml thrift bindings. It seems to work but I have no way to test it. I recommend that we add OCaml to the docker image and to the Appveyor environment and that we build OCaml through our CMake build process, and then provide "make cross" testing of OCaml. Without these things, changes like THRIFT-2364 cannot be tested through CI. Alternatively, if there is not enough demand for OCaml, we can move this from lib/ to contrib/, and then changes like this can be merged in without needing to go through the CI gate as maintenance would be handled externally. Given there is very little OCaml use evidence in Jira, I'll have to talk to the project coordinator to see what we want to do here.) > OCaml: Build and test as part of our regular cadence > > > Key: THRIFT-4041 > URL: https://issues.apache.org/jira/browse/THRIFT-4041 > Project: Thrift > Issue Type: Improvement > Components: OCaml - Library >Affects Versions: 0.10.0 >Reporter: James E. King, III >Priority: Minor > > Add OCaml to the docker image so it can be used in CI builds. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift pull request #1190: THRIFT-4041: add ocaml and oasis to ubuntu and de...
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1190 THRIFT-4041: add ocaml and oasis to ubuntu and debian dockerfiles You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift THRIFT-4041 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1190.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1190 commit 8575ce4abf4bb9289040fa90277649de52a70654 Author: James E. King, III Date: 2017-02-13T23:33:03Z THRIFT-4041: add ocaml and oasis to ubuntu and debian dockerfiles --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-4089) Several issues with generated Python code: TFrozenDict, _fast_encode
[ https://issues.apache.org/jira/browse/THRIFT-4089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865827#comment-15865827 ] Aki Sukegawa commented on THRIFT-4089: -- [~mvartak] no, Thrift runtime. If you can locate Thrift.py you're importing, it should look like https://github.com/apache/thrift/blob/0.10.0/lib/py/src/Thrift.py if it is from correct version. TFrozenDict is in this file. > Several issues with generated Python code: TFrozenDict, _fast_encode > > > Key: THRIFT-4089 > URL: https://issues.apache.org/jira/browse/THRIFT-4089 > Project: Thrift > Issue Type: Bug > Components: Python - Compiler >Affects Versions: 0.10.0 > Environment: Python 2.7, 3.5. OS-X >Reporter: Manasi Vartak > > When you generate Python sources for a simple thrift file (e.g. Thrift > tutorial from https://thrift.apache.org/tutorial/py will also repro erros), > errors are thrown while running the PythonServer and PythonClient. > 1. When running the vanilla PythonServer, I get the following error: > File "gen-py/shared/SharedService.py", line 9, in > from thrift.Thrift import TType, TMessageType, TFrozenDict, TException, > TApplicationException > ImportError: cannot import name TFrozenDict > I see this error consistently for all generated thrift files. The error > disappears on removing TFrozenDict from the generated files (it is not used > anywhere in the file). > 2. When running the vanilla PythonClient (the server is now running after the > above fix), I get the following error: > File "PythonClient.py", line 51, in main > client.ping() > File "gen-py/tutorial/Calculator.py", line 73, in ping > self.send_ping() > File "gen-py/tutorial/Calculator.py", line 79, in send_ping > args.write(self._oprot) > File "gen-py/tutorial/Calculator.py", line 297, in write > if oprot._fast_encode is not None and self.thrift_spec is not None: > AttributeError: TBinaryProtocol instance has no attribute '_fast_encode' > I am not sure why this error is being thrown/what can be done to fix it. > These two errors, and mainly the latter one, are rendering the Server/Client > un-usable. Is this a known issue? And how do you recommend working around it? -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (THRIFT-4089) Several issues with generated Python code: TFrozenDict, _fast_encode
[ https://issues.apache.org/jira/browse/THRIFT-4089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4089: --- Component/s: Python - Compiler > Several issues with generated Python code: TFrozenDict, _fast_encode > > > Key: THRIFT-4089 > URL: https://issues.apache.org/jira/browse/THRIFT-4089 > Project: Thrift > Issue Type: Bug > Components: Python - Compiler >Affects Versions: 0.10.0 > Environment: Python 2.7, 3.5. OS-X >Reporter: Manasi Vartak > > When you generate Python sources for a simple thrift file (e.g. Thrift > tutorial from https://thrift.apache.org/tutorial/py will also repro erros), > errors are thrown while running the PythonServer and PythonClient. > 1. When running the vanilla PythonServer, I get the following error: > File "gen-py/shared/SharedService.py", line 9, in > from thrift.Thrift import TType, TMessageType, TFrozenDict, TException, > TApplicationException > ImportError: cannot import name TFrozenDict > I see this error consistently for all generated thrift files. The error > disappears on removing TFrozenDict from the generated files (it is not used > anywhere in the file). > 2. When running the vanilla PythonClient (the server is now running after the > above fix), I get the following error: > File "PythonClient.py", line 51, in main > client.ping() > File "gen-py/tutorial/Calculator.py", line 73, in ping > self.send_ping() > File "gen-py/tutorial/Calculator.py", line 79, in send_ping > args.write(self._oprot) > File "gen-py/tutorial/Calculator.py", line 297, in write > if oprot._fast_encode is not None and self.thrift_spec is not None: > AttributeError: TBinaryProtocol instance has no attribute '_fast_encode' > I am not sure why this error is being thrown/what can be done to fix it. > These two errors, and mainly the latter one, are rendering the Server/Client > un-usable. Is this a known issue? And how do you recommend working around it? -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (THRIFT-4090) compile error with array of alias in golang
[
https://issues.apache.org/jira/browse/THRIFT-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4090:
---
Fix Version/s: (was: 0.9.3)
> compile error with array of alias in golang
> ---
>
> Key: THRIFT-4090
> URL: https://issues.apache.org/jira/browse/THRIFT-4090
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.10.0
> Environment: mac sierra latest
>Reporter: Yi Zheng
>
> This case works well under 0.9.3 but not in 0.10.0
> -aaa.thrift
> typedef i64 SomeStruct
> -bbb.thrift
> include "aaa.thrift"
> struct AnotherStruct {
> 1: required list another_struct;
> }
> ==
> I read the compiled code, there will be code in "ReadFieldX" function like:
> for i := 0; i < size; i ++ {
> var _elem0 int64
> if v, err := iprot.ReadI64(); err != nil {
> return thrift.PrependError("error reading field 0: ", err)
> } else {
> _elem0 = v
> }
> p.EswLinkList = append(p.EswLinkList, _elem0) // <= compilation
> error here!
> }
> However, it is not allowed to append a int64 to an array of int64's alias.
> But this works in 0.9.3, I don't know whether this is an expected behavior?
> Thanks very much!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (THRIFT-4089) Several issues with generated Python code: TFrozenDict, _fast_encode
[ https://issues.apache.org/jira/browse/THRIFT-4089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865788#comment-15865788 ] Manasi Vartak commented on THRIFT-4089: --- Are you referring to the Python library? I tested with Python 3.5 as well, same issue. > Several issues with generated Python code: TFrozenDict, _fast_encode > > > Key: THRIFT-4089 > URL: https://issues.apache.org/jira/browse/THRIFT-4089 > Project: Thrift > Issue Type: Bug >Affects Versions: 0.10.0 > Environment: Python 2.7, 3.5. OS-X >Reporter: Manasi Vartak > > When you generate Python sources for a simple thrift file (e.g. Thrift > tutorial from https://thrift.apache.org/tutorial/py will also repro erros), > errors are thrown while running the PythonServer and PythonClient. > 1. When running the vanilla PythonServer, I get the following error: > File "gen-py/shared/SharedService.py", line 9, in > from thrift.Thrift import TType, TMessageType, TFrozenDict, TException, > TApplicationException > ImportError: cannot import name TFrozenDict > I see this error consistently for all generated thrift files. The error > disappears on removing TFrozenDict from the generated files (it is not used > anywhere in the file). > 2. When running the vanilla PythonClient (the server is now running after the > above fix), I get the following error: > File "PythonClient.py", line 51, in main > client.ping() > File "gen-py/tutorial/Calculator.py", line 73, in ping > self.send_ping() > File "gen-py/tutorial/Calculator.py", line 79, in send_ping > args.write(self._oprot) > File "gen-py/tutorial/Calculator.py", line 297, in write > if oprot._fast_encode is not None and self.thrift_spec is not None: > AttributeError: TBinaryProtocol instance has no attribute '_fast_encode' > I am not sure why this error is being thrown/what can be done to fix it. > These two errors, and mainly the latter one, are rendering the Server/Client > un-usable. Is this a known issue? And how do you recommend working around it? -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (THRIFT-4089) Several issues with generated Python code: TFrozenDict, _fast_encode
[ https://issues.apache.org/jira/browse/THRIFT-4089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manasi Vartak updated THRIFT-4089: -- Environment: Python 2.7, 3.5. OS-X (was: Python 2.7. OS-X) > Several issues with generated Python code: TFrozenDict, _fast_encode > > > Key: THRIFT-4089 > URL: https://issues.apache.org/jira/browse/THRIFT-4089 > Project: Thrift > Issue Type: Bug >Affects Versions: 0.10.0 > Environment: Python 2.7, 3.5. OS-X >Reporter: Manasi Vartak > > When you generate Python sources for a simple thrift file (e.g. Thrift > tutorial from https://thrift.apache.org/tutorial/py will also repro erros), > errors are thrown while running the PythonServer and PythonClient. > 1. When running the vanilla PythonServer, I get the following error: > File "gen-py/shared/SharedService.py", line 9, in > from thrift.Thrift import TType, TMessageType, TFrozenDict, TException, > TApplicationException > ImportError: cannot import name TFrozenDict > I see this error consistently for all generated thrift files. The error > disappears on removing TFrozenDict from the generated files (it is not used > anywhere in the file). > 2. When running the vanilla PythonClient (the server is now running after the > above fix), I get the following error: > File "PythonClient.py", line 51, in main > client.ping() > File "gen-py/tutorial/Calculator.py", line 73, in ping > self.send_ping() > File "gen-py/tutorial/Calculator.py", line 79, in send_ping > args.write(self._oprot) > File "gen-py/tutorial/Calculator.py", line 297, in write > if oprot._fast_encode is not None and self.thrift_spec is not None: > AttributeError: TBinaryProtocol instance has no attribute '_fast_encode' > I am not sure why this error is being thrown/what can be done to fix it. > These two errors, and mainly the latter one, are rendering the Server/Client > un-usable. Is this a known issue? And how do you recommend working around it? -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4089) Several issues with generated Python code: TFrozenDict, _fast_encode
[ https://issues.apache.org/jira/browse/THRIFT-4089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865568#comment-15865568 ] Aki Sukegawa commented on THRIFT-4089: -- Sounds like version mismatch between compiler and library: 0.10.0 compiler against older python lib. > Several issues with generated Python code: TFrozenDict, _fast_encode > > > Key: THRIFT-4089 > URL: https://issues.apache.org/jira/browse/THRIFT-4089 > Project: Thrift > Issue Type: Bug >Affects Versions: 0.10.0 > Environment: Python 2.7. OS-X >Reporter: Manasi Vartak > > When you generate Python sources for a simple thrift file (e.g. Thrift > tutorial from https://thrift.apache.org/tutorial/py will also repro erros), > errors are thrown while running the PythonServer and PythonClient. > 1. When running the vanilla PythonServer, I get the following error: > File "gen-py/shared/SharedService.py", line 9, in > from thrift.Thrift import TType, TMessageType, TFrozenDict, TException, > TApplicationException > ImportError: cannot import name TFrozenDict > I see this error consistently for all generated thrift files. The error > disappears on removing TFrozenDict from the generated files (it is not used > anywhere in the file). > 2. When running the vanilla PythonClient (the server is now running after the > above fix), I get the following error: > File "PythonClient.py", line 51, in main > client.ping() > File "gen-py/tutorial/Calculator.py", line 73, in ping > self.send_ping() > File "gen-py/tutorial/Calculator.py", line 79, in send_ping > args.write(self._oprot) > File "gen-py/tutorial/Calculator.py", line 297, in write > if oprot._fast_encode is not None and self.thrift_spec is not None: > AttributeError: TBinaryProtocol instance has no attribute '_fast_encode' > I am not sure why this error is being thrown/what can be done to fix it. > These two errors, and mainly the latter one, are rendering the Server/Client > un-usable. Is this a known issue? And how do you recommend working around it? -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (THRIFT-4090) compile error with array of alias in golang
[
https://issues.apache.org/jira/browse/THRIFT-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yi Zheng updated THRIFT-4090:
-
Issue Type: Bug (was: Question)
> compile error with array of alias in golang
> ---
>
> Key: THRIFT-4090
> URL: https://issues.apache.org/jira/browse/THRIFT-4090
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.10.0
> Environment: mac sierra latest
>Reporter: Yi Zheng
> Fix For: 0.9.3
>
>
> This case works well under 0.9.3 but not in 0.10.0
> -aaa.thrift
> typedef i64 SomeStruct
> -bbb.thrift
> include "aaa.thrift"
> struct AnotherStruct {
> 1: required list another_struct;
> }
> ==
> I read the compiled code, there will be code in "ReadFieldX" function like:
> for i := 0; i < size; i ++ {
> var _elem0 int64
> if v, err := iprot.ReadI64(); err != nil {
> return thrift.PrependError("error reading field 0: ", err)
> } else {
> _elem0 = v
> }
> p.EswLinkList = append(p.EswLinkList, _elem0) // <= compilation
> error here!
> }
> However, it is not allowed to append a int64 to an array of int64's alias.
> But this works in 0.9.3, I don't know whether this is an expected behavior?
> Thanks very much!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Created] (THRIFT-4090) compile error with array of alias in golang
Yi Zheng created THRIFT-4090:
Summary: compile error with array of alias in golang
Key: THRIFT-4090
URL: https://issues.apache.org/jira/browse/THRIFT-4090
Project: Thrift
Issue Type: Question
Components: Go - Compiler
Affects Versions: 0.10.0
Environment: mac sierra latest
Reporter: Yi Zheng
Fix For: 0.9.3
This case works well under 0.9.3 but not in 0.10.0
-aaa.thrift
typedef i64 SomeStruct
-bbb.thrift
include "aaa.thrift"
struct AnotherStruct {
1: required list another_struct;
}
==
I read the compiled code, there will be code in "ReadFieldX" function like:
for i := 0; i < size; i ++ {
var _elem0 int64
if v, err := iprot.ReadI64(); err != nil {
return thrift.PrependError("error reading field 0: ", err)
} else {
_elem0 = v
}
p.EswLinkList = append(p.EswLinkList, _elem0) // <= compilation error
here!
}
However, it is not allowed to append a int64 to an array of int64's alias.
But this works in 0.9.3, I don't know whether this is an expected behavior?
Thanks very much!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
