[jira] [Updated] (THRIFT-4104) Add a CI build job that runs without libevent or zlib
[ https://issues.apache.org/jira/browse/THRIFT-4104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4104: --- Priority: Major (was: Critical) > Add a CI build job that runs without libevent or zlib > - > > Key: THRIFT-4104 > URL: https://issues.apache.org/jira/browse/THRIFT-4104 > Project: Thrift > Issue Type: Improvement > Components: Build Process, C++ - Library >Affects Versions: 0.10.0 >Reporter: James E. King, III >Assignee: James E. King, III > > Support for libevent and for zlib are optional. We should have CI build jobs > for unix and windows that omit these libraries and ensure we can still build > and run tests. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4152) HTML Documentation doesn't link correctly structs
[ https://issues.apache.org/jira/browse/THRIFT-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952142#comment-15952142 ] Jens Geyer commented on THRIFT-4152: > We made a patch for structs. but we have to check if it works for the rest of > types. Where? > I'm curious why this wasn't picked up in any of our tests - perhaps the > language isn't properly represented in "make cross" testing? Hoiw do you test documentation "cross"? > HTML Documentation doesn't link correctly structs > - > > Key: THRIFT-4152 > URL: https://issues.apache.org/jira/browse/THRIFT-4152 > Project: Thrift > Issue Type: Bug > Components: HTML - Compiler >Affects Versions: 0.10.0 > Environment: Thrift Master on commit > 431732d39e89f1661dc7dddffedb2c5c1e019cc7 >Reporter: Gonzalo Aguilar >Assignee: Gonzalo Aguilar >Priority: Minor > > We discovered the html documents are not correctly generated because the > links of structs are sometimes done as Struct and sometimes as Typedef. > None of the Typedef links are working. Mainly because they are Structs in our > case and thus no link is performed. > We made a patch for structs. but we have to check if it works for the rest of > types. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift issue #1230: Make a patch to fix #4152 at least for structs
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1230 THRIFT-4152 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-4152) HTML Documentation doesn't link correctly structs
[ https://issues.apache.org/jira/browse/THRIFT-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952144#comment-15952144 ] ASF GitHub Bot commented on THRIFT-4152: Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1230 THRIFT-4152 > HTML Documentation doesn't link correctly structs > - > > Key: THRIFT-4152 > URL: https://issues.apache.org/jira/browse/THRIFT-4152 > Project: Thrift > Issue Type: Bug > Components: HTML - Compiler >Affects Versions: 0.10.0 > Environment: Thrift Master on commit > 431732d39e89f1661dc7dddffedb2c5c1e019cc7 >Reporter: Gonzalo Aguilar >Assignee: Gonzalo Aguilar >Priority: Minor > > We discovered the html documents are not correctly generated because the > links of structs are sometimes done as Struct and sometimes as Typedef. > None of the Typedef links are working. Mainly because they are Structs in our > case and thus no link is performed. > We made a patch for structs. but we have to check if it works for the rest of > types. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (THRIFT-4152) HTML Documentation doesn't link correctly structs
[ https://issues.apache.org/jira/browse/THRIFT-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952142#comment-15952142 ] Jens Geyer edited comment on THRIFT-4152 at 4/1/17 9:38 AM: > I'm curious why this wasn't picked up in any of our tests - perhaps the > language isn't properly represented in "make cross" testing? Hoiw do you test documentation "cross"? was (Author: jensg): > We made a patch for structs. but we have to check if it works for the rest of > types. Where? > I'm curious why this wasn't picked up in any of our tests - perhaps the > language isn't properly represented in "make cross" testing? Hoiw do you test documentation "cross"? > HTML Documentation doesn't link correctly structs > - > > Key: THRIFT-4152 > URL: https://issues.apache.org/jira/browse/THRIFT-4152 > Project: Thrift > Issue Type: Bug > Components: HTML - Compiler >Affects Versions: 0.10.0 > Environment: Thrift Master on commit > 431732d39e89f1661dc7dddffedb2c5c1e019cc7 >Reporter: Gonzalo Aguilar >Assignee: Gonzalo Aguilar >Priority: Minor > > We discovered the html documents are not correctly generated because the > links of structs are sometimes done as Struct and sometimes as Typedef. > None of the Typedef links are working. Mainly because they are Structs in our > case and thus no link is performed. > We made a patch for structs. but we have to check if it works for the rest of > types. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4152) HTML Documentation doesn't link correctly structs
[ https://issues.apache.org/jira/browse/THRIFT-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952147#comment-15952147 ] Jens Geyer commented on THRIFT-4152: GitHub user gadLinux opened a pull request: https://github.com/apache/thrift/pull/1230 Make a patch to fix #4152 at least for structs Change type Type_ for Struct_ so structs are correctly linked. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gadLinux/thrift THRIFT-4152 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1230.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1230 commit 83ea476613868e78da6196e456583128b9454d00 Author: Gonzalo Aguilar Delgado Date: 2017-03-31T09:13:04Z Make a patch to fix #4152 at least for structs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- > HTML Documentation doesn't link correctly structs > - > > Key: THRIFT-4152 > URL: https://issues.apache.org/jira/browse/THRIFT-4152 > Project: Thrift > Issue Type: Bug > Components: HTML - Compiler >Affects Versions: 0.10.0 > Environment: Thrift Master on commit > 431732d39e89f1661dc7dddffedb2c5c1e019cc7 >Reporter: Gonzalo Aguilar >Assignee: Gonzalo Aguilar >Priority: Minor > > We discovered the html documents are not correctly generated because the > links of structs are sometimes done as Struct and sometimes as Typedef. > None of the Typedef links are working. Mainly because they are Structs in our > case and thus no link is performed. > We made a patch for structs. but we have to check if it works for the rest of > types. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift pull request #1232: THRIFT-4138: Remove undefined behavior imported f...
GitHub user jbapple-cloudera opened a pull request: https://github.com/apache/thrift/pull/1232 THRIFT-4138: Remove undefined behavior imported from Boost Client: C++ There is undefined behavior in boost::lexical_cast that was fixed in https://github.com/boostorg/lexical_cast/issues/21, but that fix is only available in recent Boost releases. This patch removes all uses of lexical_cast instead. That removes the last undefined behavior, so this patch also makes ubsan.sh unconditionally fail on undefined behavior. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbapple-cloudera/thrift boost-vptr Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1232.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1232 commit e8c76d1939ec0f338d4a520ec9e81cfefe6e33b1 Author: Jim Apple Date: 2017-03-30T03:39:36Z THRIFT-4138: Remove undefined behavior imported from Boost Client: C++ There is undefined behavior in boost::lexical_cast that was fixed in https://github.com/boostorg/lexical_cast/issues/21, but that fix is only available in recent Boost releases. This patch removes all uses of lexical_cast instead. That removes the last undefined behavior, so this patch also makes ubsan.sh unconditionally fail on undefined behavior. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library
[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952207#comment-15952207 ] ASF GitHub Bot commented on THRIFT-4138: GitHub user jbapple-cloudera opened a pull request: https://github.com/apache/thrift/pull/1232 THRIFT-4138: Remove undefined behavior imported from Boost Client: C++ There is undefined behavior in boost::lexical_cast that was fixed in https://github.com/boostorg/lexical_cast/issues/21, but that fix is only available in recent Boost releases. This patch removes all uses of lexical_cast instead. That removes the last undefined behavior, so this patch also makes ubsan.sh unconditionally fail on undefined behavior. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbapple-cloudera/thrift boost-vptr Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1232.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1232 commit e8c76d1939ec0f338d4a520ec9e81cfefe6e33b1 Author: Jim Apple Date: 2017-03-30T03:39:36Z THRIFT-4138: Remove undefined behavior imported from Boost Client: C++ There is undefined behavior in boost::lexical_cast that was fixed in https://github.com/boostorg/lexical_cast/issues/21, but that fix is only available in recent Boost releases. This patch removes all uses of lexical_cast instead. That removes the last undefined behavior, so this patch also makes ubsan.sh unconditionally fail on undefined behavior. > Fix remaining undefined behavior invalid vptr casts in C++ library > -- > > Key: THRIFT-4138 > URL: https://issues.apache.org/jira/browse/THRIFT-4138 > Project: Thrift > Issue Type: Sub-task > Components: C++ - Library >Reporter: Jens Geyer > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library
[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-4138: -- Assignee: Jim Apple > Fix remaining undefined behavior invalid vptr casts in C++ library > -- > > Key: THRIFT-4138 > URL: https://issues.apache.org/jira/browse/THRIFT-4138 > Project: Thrift > Issue Type: Sub-task > Components: C++ - Library >Reporter: Jens Geyer >Assignee: Jim Apple > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift issue #1232: THRIFT-4138: Remove undefined behavior imported from Boo...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1232 I'm curious - did every case where lexical_cast was used report this error running in ubsan or was it perhaps just one of them? The original boost defect says, "Undefined behaviour in lexical cast of boost::filesystem::path to std::string". We're not using boost::filesystem::path in any of these locations - it's usually just a simple numeric conversion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library
[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952236#comment-15952236 ] ASF GitHub Bot commented on THRIFT-4138: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1232 I'm curious - did every case where lexical_cast was used report this error running in ubsan or was it perhaps just one of them? The original boost defect says, "Undefined behaviour in lexical cast of boost::filesystem::path to std::string". We're not using boost::filesystem::path in any of these locations - it's usually just a simple numeric conversion. > Fix remaining undefined behavior invalid vptr casts in C++ library > -- > > Key: THRIFT-4138 > URL: https://issues.apache.org/jira/browse/THRIFT-4138 > Project: Thrift > Issue Type: Sub-task > Components: C++ - Library >Reporter: Jens Geyer >Assignee: Jim Apple > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4152) HTML Documentation doesn't link correctly structs
[ https://issues.apache.org/jira/browse/THRIFT-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952237#comment-15952237 ] James E. King, III commented on THRIFT-4152: Sorry I thought this was in generated code. :) > HTML Documentation doesn't link correctly structs > - > > Key: THRIFT-4152 > URL: https://issues.apache.org/jira/browse/THRIFT-4152 > Project: Thrift > Issue Type: Bug > Components: HTML - Compiler >Affects Versions: 0.10.0 > Environment: Thrift Master on commit > 431732d39e89f1661dc7dddffedb2c5c1e019cc7 >Reporter: Gonzalo Aguilar >Assignee: Gonzalo Aguilar >Priority: Minor > > We discovered the html documents are not correctly generated because the > links of structs are sometimes done as Struct and sometimes as Typedef. > None of the Typedef links are working. Mainly because they are Structs in our > case and thus no link is performed. > We made a patch for structs. but we have to check if it works for the rest of > types. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift pull request #1110: THRIFT-3944 TSSLSocket has dead code in checkHand...
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1110 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Resolved] (THRIFT-3944) TSSLSocket has dead code in checkHandshake
[ https://issues.apache.org/jira/browse/THRIFT-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3944. Resolution: Fixed Fix Version/s: 0.11.0 > TSSLSocket has dead code in checkHandshake > -- > > Key: THRIFT-3944 > URL: https://issues.apache.org/jira/browse/THRIFT-3944 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.9.3 >Reporter: Ted Wang >Assignee: Ted Wang >Priority: Minor > Fix For: 0.11.0 > > > There is a block of code in checkHandshake that attempts to set read/write > memory bios to be nonblocking. This code doesn't do anything: > https://github.com/apache/thrift/blob/master/lib/cpp/src/thrift/transport/TSSLSocket.cpp#L441 > Here's what this code looks like, and the problems: > - BIO_new(BIO_s_mem()) creates a new memory BIO. Not sure why. > - BIO_set_nbio() executes BIO_ctrl(..., BIO_C_SET_NBIO, ...). This errors out > and return 0 because mem_ctrl does not have a case for BIO_C_SET_NBIO. See: > https://github.com/openssl/openssl/blob/6f0ac0e2f27d9240516edb9a23b7863e7ad02898/crypto/bio/bss_mem.c#L226 > - SSL_set_bio() sets the SSL* to use the memory BIOs. > - SSL_set_fd() creates a socket BIO, sets the FD on it, and uses > SSL_set_bio() to replace the memory BIOs. > As far as I can tell, this block of code does nothing and will not change > functionality. If there's a reason that it's there, it needs to be > re-implemented. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-3944) TSSLSocket has dead code in checkHandshake
[ https://issues.apache.org/jira/browse/THRIFT-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952241#comment-15952241 ] ASF GitHub Bot commented on THRIFT-3944: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1110 > TSSLSocket has dead code in checkHandshake > -- > > Key: THRIFT-3944 > URL: https://issues.apache.org/jira/browse/THRIFT-3944 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.9.3 >Reporter: Ted Wang >Assignee: Ted Wang >Priority: Minor > Fix For: 0.11.0 > > > There is a block of code in checkHandshake that attempts to set read/write > memory bios to be nonblocking. This code doesn't do anything: > https://github.com/apache/thrift/blob/master/lib/cpp/src/thrift/transport/TSSLSocket.cpp#L441 > Here's what this code looks like, and the problems: > - BIO_new(BIO_s_mem()) creates a new memory BIO. Not sure why. > - BIO_set_nbio() executes BIO_ctrl(..., BIO_C_SET_NBIO, ...). This errors out > and return 0 because mem_ctrl does not have a case for BIO_C_SET_NBIO. See: > https://github.com/openssl/openssl/blob/6f0ac0e2f27d9240516edb9a23b7863e7ad02898/crypto/bio/bss_mem.c#L226 > - SSL_set_bio() sets the SSL* to use the memory BIOs. > - SSL_set_fd() creates a socket BIO, sets the FD on it, and uses > SSL_set_bio() to replace the memory BIOs. > As far as I can tell, this block of code does nothing and will not change > functionality. If there's a reason that it's there, it needs to be > re-implemented. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift issue #1232: THRIFT-4138: Remove undefined behavior imported from Boo...
Github user jbapple-cloudera commented on the issue: https://github.com/apache/thrift/pull/1232 UBSan refuses to report an error more than once, and unfortunately it does not have a way to override this behavior. So, once you've seen one UBSan error at a particular line in a particular function, it won't report it again until the binary exits. I agree that we are not using boost::filesystem::path. This was a different error from https://github.com/boostorg/lexical_cast/blob/boost-1.54.0/include/boost/lexical_cast.hpp#L1620. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library
[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952243#comment-15952243 ] ASF GitHub Bot commented on THRIFT-4138: Github user jbapple-cloudera commented on the issue: https://github.com/apache/thrift/pull/1232 UBSan refuses to report an error more than once, and unfortunately it does not have a way to override this behavior. So, once you've seen one UBSan error at a particular line in a particular function, it won't report it again until the binary exits. I agree that we are not using boost::filesystem::path. This was a different error from https://github.com/boostorg/lexical_cast/blob/boost-1.54.0/include/boost/lexical_cast.hpp#L1620. > Fix remaining undefined behavior invalid vptr casts in C++ library > -- > > Key: THRIFT-4138 > URL: https://issues.apache.org/jira/browse/THRIFT-4138 > Project: Thrift > Issue Type: Sub-task > Components: C++ - Library >Reporter: Jens Geyer >Assignee: Jim Apple > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-3857) thrift js:node complier support an object as parameter not an instance of struct
[
https://issues.apache.org/jira/browse/THRIFT-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952247#comment-15952247
]
James E. King, III commented on THRIFT-3857:
Any node.js folks want to comment on this? The CI builds passed but this needs
to be reviewed and approved by someone who uses the language regularly.
The PR checks in a binary libparse.a build which needs to be removed... ideally
if this PR could be fixed, squashed into a single commit and rebased against
the current master it would make it easier to merge if approved.
> thrift js:node complier support an object as parameter not an instance of
> struct
>
>
> Key: THRIFT-3857
> URL: https://issues.apache.org/jira/browse/THRIFT-3857
> Project: Thrift
> Issue Type: New Feature
> Components: Node.js - Compiler
>Affects Versions: 0.9.3, 1.0
>Reporter: jiangq
>
> use the tutorial.thrift,code like:
> {code:javascript}
> let param = {
> op: ttypes.Operation.DIVIDE,
> num1: 1,
> num2: 0
> }
> let work = new ttypes.Work(param);
> client.calculate(1, work)
> .then(function(message) {
> console.log('Whoa? You know how to divide by zero?');
> })
> .fail(function(err) {
> console.log("InvalidOperation " + err);
> });
> {code}
> can we support like these:
> {code:javascript}
> let work = {
> op: ttypes.Operation.DIVIDE,
> num1: 1,
> num2: 0
> }
> client.calculate(1, work)
> .then(function(message) {
> console.log('Whoa? You know how to divide by zero?');
> })
> .fail(function(err) {
> console.log("InvalidOperation " + err);
> });
> {code}
> If we can support this feature will be very convenient， and I have read the
> 't_js_generator.cc' file, find this feature is easy to support, can we add
> the support for this feature?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] thrift issue #1031: THRIFT-3859: Unix Domain Socket Support in Objective-C
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1031 Have you used this in a project and know that it works? Given this is an improvement I'd like to get it in, but if you don't have time right now to add make cross support, I can add a story in Jira to complete the work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3859) Unix Domain Socket Support in Objective-C
[
https://issues.apache.org/jira/browse/THRIFT-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952248#comment-15952248
]
ASF GitHub Bot commented on THRIFT-3859:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1031
Have you used this in a project and know that it works? Given this is an
improvement I'd like to get it in, but if you don't have time right now to add
make cross support, I can add a story in Jira to complete the work.
> Unix Domain Socket Support in Objective-C
> -
>
> Key: THRIFT-3859
> URL: https://issues.apache.org/jira/browse/THRIFT-3859
> Project: Thrift
> Issue Type: Improvement
> Components: Cocoa - Library
>Affects Versions: 0.10.0
>Reporter: Chris Vasselli
>Priority: Minor
>
> I would like to be able to use Unix Domain Sockets as the transport to
> communicate between different processes on a single machine. There seems to
> be support in the C++ and Python libraries (the two other languages used in
> my project), but no support in Objective-C.
> Proposed server interface:
> {{TSocketServer *server = [[TSocketServer alloc]
> initWithPath:@"/path/to/pipe" protocolFactory:protocolFactory
> processorFactory:processorFactory];}}
> Proposed client interface:
> {{TSocketTransport *socket = [[TSocketTransport alloc]
> initWithPath:@"/path/to/pipe"];}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Assigned] (THRIFT-3823) Escape documentation while generating non escaped documetation
[
https://issues.apache.org/jira/browse/THRIFT-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-3823:
--
Assignee: James E. King, III
> Escape documentation while generating non escaped documetation
> --
>
> Key: THRIFT-3823
> URL: https://issues.apache.org/jira/browse/THRIFT-3823
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
>Affects Versions: 0.9.3
>Reporter: maxime mouial
>Assignee: James E. King, III
>Priority: Minor
> Fix For: 0.11.0
>
>
> The HTML generated documentation from a .thrift don't format comments. They
> all appears as a one-liner.
> When not using the "noescape" tag, documentation comments should be displayed
> between "" tag to keep readability.
> This will allow comment such as this one to be displayed correctly (and not
> on one line):
> {code}
> /**
> * This method is doing this and that.
> *
> * @param user
> * Current identifier of the user
> *
> * @param password
> * Some password
> *
> * @return
> * Some data
> *
> * @throws ExceptionA
> * @throws ExceptionB
> */
> string doSomeStuff(
> 1: string user,
> 2: string pasword,
> ) throws (
> 1: ExceptionA userException,
> 2: ExceptionB systemException,
> )
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (THRIFT-3823) Escape documentation while generating non escaped documetation
[
https://issues.apache.org/jira/browse/THRIFT-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-3823.
Resolution: Fixed
Fix Version/s: 0.11.0
> Escape documentation while generating non escaped documetation
> --
>
> Key: THRIFT-3823
> URL: https://issues.apache.org/jira/browse/THRIFT-3823
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
>Affects Versions: 0.9.3
>Reporter: maxime mouial
>Assignee: James E. King, III
>Priority: Minor
> Fix For: 0.11.0
>
>
> The HTML generated documentation from a .thrift don't format comments. They
> all appears as a one-liner.
> When not using the "noescape" tag, documentation comments should be displayed
> between "" tag to keep readability.
> This will allow comment such as this one to be displayed correctly (and not
> on one line):
> {code}
> /**
> * This method is doing this and that.
> *
> * @param user
> * Current identifier of the user
> *
> * @param password
> * Some password
> *
> * @return
> * Some data
> *
> * @throws ExceptionA
> * @throws ExceptionB
> */
> string doSomeStuff(
> 1: string user,
> 2: string pasword,
> ) throws (
> 1: ExceptionA userException,
> 2: ExceptionB systemException,
> )
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (THRIFT-3823) Escape documentation while generating non escaped documetation
[
https://issues.apache.org/jira/browse/THRIFT-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-3823:
---
Priority: Minor (was: Major)
> Escape documentation while generating non escaped documetation
> --
>
> Key: THRIFT-3823
> URL: https://issues.apache.org/jira/browse/THRIFT-3823
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
>Affects Versions: 0.9.3
>Reporter: maxime mouial
>Priority: Minor
> Fix For: 0.11.0
>
>
> The HTML generated documentation from a .thrift don't format comments. They
> all appears as a one-liner.
> When not using the "noescape" tag, documentation comments should be displayed
> between "" tag to keep readability.
> This will allow comment such as this one to be displayed correctly (and not
> on one line):
> {code}
> /**
> * This method is doing this and that.
> *
> * @param user
> * Current identifier of the user
> *
> * @param password
> * Some password
> *
> * @return
> * Some data
> *
> * @throws ExceptionA
> * @throws ExceptionB
> */
> string doSomeStuff(
> 1: string user,
> 2: string pasword,
> ) throws (
> 1: ExceptionA userException,
> 2: ExceptionB systemException,
> )
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] thrift issue #1029: THRIFT-3823: Use 'pre' HTML tag when generating non esca...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1029 @jfarrell or @hush-hush could you please close this? There were two pull requests for this Jira ticket and I only put one of them into the "This closes" part of the comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3823) Escape documentation while generating non escaped documetation
[
https://issues.apache.org/jira/browse/THRIFT-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952250#comment-15952250
]
ASF GitHub Bot commented on THRIFT-3823:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1029
@jfarrell or @hush-hush could you please close this? There were two pull
requests for this Jira ticket and I only put one of them into the "This closes"
part of the comment.
> Escape documentation while generating non escaped documetation
> --
>
> Key: THRIFT-3823
> URL: https://issues.apache.org/jira/browse/THRIFT-3823
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
>Affects Versions: 0.9.3
>Reporter: maxime mouial
>Assignee: James E. King, III
>Priority: Minor
> Fix For: 0.11.0
>
>
> The HTML generated documentation from a .thrift don't format comments. They
> all appears as a one-liner.
> When not using the "noescape" tag, documentation comments should be displayed
> between "" tag to keep readability.
> This will allow comment such as this one to be displayed correctly (and not
> on one line):
> {code}
> /**
> * This method is doing this and that.
> *
> * @param user
> * Current identifier of the user
> *
> * @param password
> * Some password
> *
> * @return
> * Some data
> *
> * @throws ExceptionA
> * @throws ExceptionB
> */
> string doSomeStuff(
> 1: string user,
> 2: string pasword,
> ) throws (
> 1: ExceptionA userException,
> 2: ExceptionB systemException,
> )
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] thrift pull request #1231: THRIFT-4140: fix unsafe call to gmtime
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1231 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Resolved] (THRIFT-4140) Use of non-thread-safe function gmtime()
[ https://issues.apache.org/jira/browse/THRIFT-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4140. Resolution: Fixed Fix Version/s: 0.11.0 > Use of non-thread-safe function gmtime() > > > Key: THRIFT-4140 > URL: https://issues.apache.org/jira/browse/THRIFT-4140 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.10.0 >Reporter: Adriaan Schmidt >Assignee: James E. King, III >Priority: Minor > Fix For: 0.11.0 > > Attachments: THRIFT-4140.patch > > > Method *THttpServer::getTimeRFC1123()* (in > lib/cpp/src/thr8ft/transport/THttpServer.cpp) uses gmtime(). > This function is documented to be not thread-safe > (https://www.gnu.org/software/libc/manual/html_node/Broken_002ddown-Time.html). > Instead, we should use gmtime_r(). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4140) Use of non-thread-safe function gmtime()
[ https://issues.apache.org/jira/browse/THRIFT-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952253#comment-15952253 ] ASF GitHub Bot commented on THRIFT-4140: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1231 > Use of non-thread-safe function gmtime() > > > Key: THRIFT-4140 > URL: https://issues.apache.org/jira/browse/THRIFT-4140 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.10.0 >Reporter: Adriaan Schmidt >Assignee: James E. King, III >Priority: Minor > Fix For: 0.11.0 > > Attachments: THRIFT-4140.patch > > > Method *THttpServer::getTimeRFC1123()* (in > lib/cpp/src/thr8ft/transport/THttpServer.cpp) uses gmtime(). > This function is documented to be not thread-safe > (https://www.gnu.org/software/libc/manual/html_node/Broken_002ddown-Time.html). > Instead, we should use gmtime_r(). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift pull request #1232: THRIFT-4138: Remove undefined behavior imported f...
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1232 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Resolved] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library
[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4138. Resolution: Fixed Fix Version/s: 0.11.0 Committed - thanks! > Fix remaining undefined behavior invalid vptr casts in C++ library > -- > > Key: THRIFT-4138 > URL: https://issues.apache.org/jira/browse/THRIFT-4138 > Project: Thrift > Issue Type: Sub-task > Components: C++ - Library >Reporter: Jens Geyer >Assignee: Jim Apple > Fix For: 0.11.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library
[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952257#comment-15952257 ] ASF GitHub Bot commented on THRIFT-4138: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1232 > Fix remaining undefined behavior invalid vptr casts in C++ library > -- > > Key: THRIFT-4138 > URL: https://issues.apache.org/jira/browse/THRIFT-4138 > Project: Thrift > Issue Type: Sub-task > Components: C++ - Library >Reporter: Jens Geyer >Assignee: Jim Apple > Fix For: 0.11.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts
[
https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952258#comment-15952258
]
James E. King, III commented on THRIFT-4134:
I merged the third and final subtask. Please review and if you believe this
work is complete, resolve this as well.
> Fix remaining undefined behavior invalid vptr casts
> ---
>
> Key: THRIFT-4134
> URL: https://issues.apache.org/jira/browse/THRIFT-4134
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General), D - Compiler, Haxe - Compiler, Java
> - Compiler
>Affects Versions: 0.11.0
> Environment: Travis CI, Ubuntu 14.04.5
>Reporter: Jim Apple
> Attachments:
> 0001-THRIFT-4134-Fix-remaining-undefined-behavior-invalid.patch,
> thrift-vptr-travis.txt
>
>
> Removing {{-fno-sanitize-recover=undefined -fno-sanitize=vptr}} from
> {{ubsan.sh}} shows {{vptr}} errors in the following places:
> {noformat}
> src/thrift/generate/t_d_generator.cc:384:25: runtime error:
> src/thrift/generate/t_d_generator.cc:385:12: runtime error:
> src/thrift/generate/t_haxe_generator.cc:2576:34: runtime error:
> src/thrift/generate/t_haxe_generator.cc:2576:35: runtime error:
> src/thrift/parse/t_list.h:33:42: runtime error:
> thrift/parse/t_scope.h:88:40: runtime error:
> thrift/parse/t_scope.h:88:41: runtime error:
> /usr/include/boost/lexical_cast.hpp:1620:43: runtime error:
> src/thrift/generate/t_java_generator.cc:2693:27: runtime error:
> src/thrift/generate/t_java_generator.cc:2693:28: runtime error:
> src/thrift/generate/t_java_generator.cc:3756:35: runtime error:
> src/thrift/generate/t_java_generator.cc:3756:36: runtime error:
> src/thrift/generate/t_java_generator.cc:4639:11: runtime error:
> src/thrift/generate/t_java_generator.cc:4639:12: runtime error:
> src/thrift/generate/t_java_generator.cc:4666:10: runtime error:
> src/thrift/generate/t_java_generator.cc:4666:9: runtime error:
> src/thrift/generate/t_json_generator.cc:277:21: runtime error:
> src/thrift/generate/t_json_generator.cc:277:22: runtime error:
> src/thrift/generate/t_xml_generator.cc:395:21: runtime error:
> src/thrift/generate/t_xml_generator.cc:395:22: runtime error:
> src/thrift/parse/t_base_type.h:64:35: runtime error:
> src/thrift/parse/t_list.h:33:42: runtime error:
> src/thrift/parse/t_set.h:33:42: runtime error:
> thrift/parse/t_scope.h:88:40: runtime error:
> thrift/parse/t_scope.h:88:41: runtime error:
> thrift/parse/t_scope.h:88:41: runtime error:
> {noformat}
> Here is an example
> {noformat}
> [exec] src/thrift/generate/t_json_generator.cc:277:22: runtime error:
> downcast of address 0x03f61d40 which does not point to an object of type
> 't_list'
> [exec] 0x03f61d40: note: object is of type 't_set'
> [exec] 00 00 00 00 a8 b9 f7 01 00 00 00 00 d8 23 04 8e 7e 2b 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00
> [exec] ^~~
> [exec] vptr for 't_set'
> [exec] [WARNING:/thrift/src/test/ThriftTest.thrift:45] No generator
> named 'noexist' could be found!
> [exec] [WARNING:/thrift/src/test/ThriftTest.thrift:47] cpp generator
> does not accept 'noexist' as sub-namespace!
> [exec] #0 0xaa355e in t_json_generator::write_type_spec(t_type*)
> /thrift/src/compiler/cpp/src/thrift/generate/t_json_generator.cc:277:22
> [exec] #1 0xaa12e5 in t_json_generator::write_type_spec_object(char
> const*, t_type*)
> /thrift/src/compiler/cpp/src/thrift/generate/t_json_generator.cc:252:5
> [exec] #2 0xabcc0f in t_json_generator::generate_field(t_field*)
> /thrift/src/compiler/cpp/src/thrift/generate/t_json_generator.cc:663:3
> [exec] #3 0xabb4cd in t_json_generator::generate_struct(t_struct*)
> /thrift/src/compiler/cpp/src/thrift/generate/t_json_generator.cc:583:5
> [exec] #4 0xaad948 in t_json_generator::generate_program()
> /thrift/src/compiler/cpp/src/thrift/generate/t_json_generator.cc:400:7
> [exec] #5 0x44d0f6 in generate(t_program*, std::vector std::allocator > const&)
> /thrift/src/compiler/cpp/src/thrift/main.cc:1032:9
> [exec] #6 0x4532ba in main
> /thrift/src/compiler/cpp/src/thrift/main.cc:1289:5
> [exec] #7 0x2b7e8e784f44 in __libc_start_main
> (/lib/x86_64-linux-gnu/libc.so.6+0x21f44)
> [exec] #8 0x417ec3 in _start
> (/thrift/src/compiler/cpp/thrift+0x417ec3)
> {noformat}
> The problem here is this:
> {noformat}
> } else if (ttype->is_list() || ttype->is_set()) {
> t_type* etype = ((t_list*)ttype)->get_elem_type();
> {noformat}
> {{ttype}} cannot necessarily be cast to {{t_list*}}, since sometimes it is a
> {{t_set*}}. When it is a {{t_set*}}, the call to {{get_elem_type()}} is
> undefined behavior: section 9.3.1 "Nonsta
[jira] [Resolved] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts
[
https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Apple resolved THRIFT-4134.
---
Resolution: Fixed
See subtasks for commits that fixed this
> Fix remaining undefined behavior invalid vptr casts
> ---
>
> Key: THRIFT-4134
> URL: https://issues.apache.org/jira/browse/THRIFT-4134
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General), D - Compiler, Haxe - Compiler, Java
> - Compiler
>Affects Versions: 0.11.0
> Environment: Travis CI, Ubuntu 14.04.5
>Reporter: Jim Apple
> Attachments:
> 0001-THRIFT-4134-Fix-remaining-undefined-behavior-invalid.patch,
> thrift-vptr-travis.txt
>
>
> Removing {{-fno-sanitize-recover=undefined -fno-sanitize=vptr}} from
> {{ubsan.sh}} shows {{vptr}} errors in the following places:
> {noformat}
> src/thrift/generate/t_d_generator.cc:384:25: runtime error:
> src/thrift/generate/t_d_generator.cc:385:12: runtime error:
> src/thrift/generate/t_haxe_generator.cc:2576:34: runtime error:
> src/thrift/generate/t_haxe_generator.cc:2576:35: runtime error:
> src/thrift/parse/t_list.h:33:42: runtime error:
> thrift/parse/t_scope.h:88:40: runtime error:
> thrift/parse/t_scope.h:88:41: runtime error:
> /usr/include/boost/lexical_cast.hpp:1620:43: runtime error:
> src/thrift/generate/t_java_generator.cc:2693:27: runtime error:
> src/thrift/generate/t_java_generator.cc:2693:28: runtime error:
> src/thrift/generate/t_java_generator.cc:3756:35: runtime error:
> src/thrift/generate/t_java_generator.cc:3756:36: runtime error:
> src/thrift/generate/t_java_generator.cc:4639:11: runtime error:
> src/thrift/generate/t_java_generator.cc:4639:12: runtime error:
> src/thrift/generate/t_java_generator.cc:4666:10: runtime error:
> src/thrift/generate/t_java_generator.cc:4666:9: runtime error:
> src/thrift/generate/t_json_generator.cc:277:21: runtime error:
> src/thrift/generate/t_json_generator.cc:277:22: runtime error:
> src/thrift/generate/t_xml_generator.cc:395:21: runtime error:
> src/thrift/generate/t_xml_generator.cc:395:22: runtime error:
> src/thrift/parse/t_base_type.h:64:35: runtime error:
> src/thrift/parse/t_list.h:33:42: runtime error:
> src/thrift/parse/t_set.h:33:42: runtime error:
> thrift/parse/t_scope.h:88:40: runtime error:
> thrift/parse/t_scope.h:88:41: runtime error:
> thrift/parse/t_scope.h:88:41: runtime error:
> {noformat}
> Here is an example
> {noformat}
> [exec] src/thrift/generate/t_json_generator.cc:277:22: runtime error:
> downcast of address 0x03f61d40 which does not point to an object of type
> 't_list'
> [exec] 0x03f61d40: note: object is of type 't_set'
> [exec] 00 00 00 00 a8 b9 f7 01 00 00 00 00 d8 23 04 8e 7e 2b 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00
> [exec] ^~~
> [exec] vptr for 't_set'
> [exec] [WARNING:/thrift/src/test/ThriftTest.thrift:45] No generator
> named 'noexist' could be found!
> [exec] [WARNING:/thrift/src/test/ThriftTest.thrift:47] cpp generator
> does not accept 'noexist' as sub-namespace!
> [exec] #0 0xaa355e in t_json_generator::write_type_spec(t_type*)
> /thrift/src/compiler/cpp/src/thrift/generate/t_json_generator.cc:277:22
> [exec] #1 0xaa12e5 in t_json_generator::write_type_spec_object(char
> const*, t_type*)
> /thrift/src/compiler/cpp/src/thrift/generate/t_json_generator.cc:252:5
> [exec] #2 0xabcc0f in t_json_generator::generate_field(t_field*)
> /thrift/src/compiler/cpp/src/thrift/generate/t_json_generator.cc:663:3
> [exec] #3 0xabb4cd in t_json_generator::generate_struct(t_struct*)
> /thrift/src/compiler/cpp/src/thrift/generate/t_json_generator.cc:583:5
> [exec] #4 0xaad948 in t_json_generator::generate_program()
> /thrift/src/compiler/cpp/src/thrift/generate/t_json_generator.cc:400:7
> [exec] #5 0x44d0f6 in generate(t_program*, std::vector std::allocator > const&)
> /thrift/src/compiler/cpp/src/thrift/main.cc:1032:9
> [exec] #6 0x4532ba in main
> /thrift/src/compiler/cpp/src/thrift/main.cc:1289:5
> [exec] #7 0x2b7e8e784f44 in __libc_start_main
> (/lib/x86_64-linux-gnu/libc.so.6+0x21f44)
> [exec] #8 0x417ec3 in _start
> (/thrift/src/compiler/cpp/thrift+0x417ec3)
> {noformat}
> The problem here is this:
> {noformat}
> } else if (ttype->is_list() || ttype->is_set()) {
> t_type* etype = ((t_list*)ttype)->get_elem_type();
> {noformat}
> {{ttype}} cannot necessarily be cast to {{t_list*}}, since sometimes it is a
> {{t_set*}}. When it is a {{t_set*}}, the call to {{get_elem_type()}} is
> undefined behavior: section 9.3.1 "Nonstatic member functions
> \[class.mfct.non-static\]", paragraph 2 of the C++14 standard states "If a
> non-static member function
[GitHub] thrift pull request #1230: Make a patch to fix #4152 at least for structs
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1230 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-4152) HTML Documentation doesn't link correctly structs
[ https://issues.apache.org/jira/browse/THRIFT-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952260#comment-15952260 ] James E. King, III commented on THRIFT-4152: I merged the open pull request, however I am not going to resolve this Jira ticket based on your description, "but we have to check if it works for the rest of types." If you believe the issue is now resolved, please resolve it here. > HTML Documentation doesn't link correctly structs > - > > Key: THRIFT-4152 > URL: https://issues.apache.org/jira/browse/THRIFT-4152 > Project: Thrift > Issue Type: Bug > Components: HTML - Compiler >Affects Versions: 0.10.0 > Environment: Thrift Master on commit > 431732d39e89f1661dc7dddffedb2c5c1e019cc7 >Reporter: Gonzalo Aguilar >Assignee: Gonzalo Aguilar >Priority: Minor > > We discovered the html documents are not correctly generated because the > links of structs are sometimes done as Struct and sometimes as Typedef. > None of the Typedef links are working. Mainly because they are Structs in our > case and thus no link is performed. > We made a patch for structs. but we have to check if it works for the rest of > types. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift issue #1228: THRIFT-3978: tighten up pthread mutex implementation, re...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1228 For anybody interested in reviewing this pull request, I pretty much followed the logic that boost::mutex is using with one exception. In cases where boost ignores an error condition to avoid throwing in a destructor, I have instead preferred to abort the process. My thought process on this is that should mutex destruction return EBUSY or EINVAL, it is a design flaw in the implementation using the Mutex class. EBUSY means we tried to delete the mutex while it was locked. EINVAL means it may have been destroyed twice. In either case, getting a core is way more useful than silently letting the issue pass by in a release build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3978) Thrift C++ runtime uses assert to prevent overflows, checks sanity only in debug builds
[ https://issues.apache.org/jira/browse/THRIFT-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952261#comment-15952261 ] ASF GitHub Bot commented on THRIFT-3978: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1228 For anybody interested in reviewing this pull request, I pretty much followed the logic that boost::mutex is using with one exception. In cases where boost ignores an error condition to avoid throwing in a destructor, I have instead preferred to abort the process. My thought process on this is that should mutex destruction return EBUSY or EINVAL, it is a design flaw in the implementation using the Mutex class. EBUSY means we tried to delete the mutex while it was locked. EINVAL means it may have been destroyed twice. In either case, getting a core is way more useful than silently letting the issue pass by in a release build. > Thrift C++ runtime uses assert to prevent overflows, checks sanity only in > debug builds > --- > > Key: THRIFT-3978 > URL: https://issues.apache.org/jira/browse/THRIFT-3978 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.10.0 > Environment: All >Reporter: James E. King, III >Assignee: James E. King, III > Labels: security > > Currently there is widespread use of assert in the thrift C++ runtime > library. Some of the more disturbing cases are security related, for example > checking header sizes. I recommend we eliminate assertions that are only > checked in debug mode, and instead throw the appropriate exception, usually a > TTransportException with CORRUPTED_DATA as the reason. If we're going to > check for an overflow or a buffer overrun, we should do so in debug and > release modes. Further, assertions are not easily tested whereas exceptions > are. > In THRIFT-3873 apache::thrift::transport::safe_numeric_cast was added, so I > also suggest changing static_cast to safe_numeric_cast where appropriate > throughout the transport code to catch any overflow errors. > Another location where assert is used liberally is inside the posix Mutex > implementation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (THRIFT-3784) thrift-maven-plugin generates invalid include directories for IDL in dependency JARs
[ https://issues.apache.org/jira/browse/THRIFT-3784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3784. Resolution: Fixed Assignee: James E. King, III Fix Version/s: 0.11.0 Committed - thanks. > thrift-maven-plugin generates invalid include directories for IDL in > dependency JARs > > > Key: THRIFT-3784 > URL: https://issues.apache.org/jira/browse/THRIFT-3784 > Project: Thrift > Issue Type: Bug > Components: Java - Library >Reporter: Chris Osborn >Assignee: James E. King, III > Fix For: 0.11.0 > > > The thrift-maven-plugin attempts to support building .thrift files that > depend on other .thrift files provided in a dependency JAR. It does this by > copying the dependency JAR's thrift files into a temporary directory then > passing corresponding include directory options to the thrift compiler. > However, the process of generating the include directory paths is faulty: > there is a path for each and every directory that contains a .thrift file, > rather than a single path to the root of the thrift file hierarchy. That > means that any thrift files that reference others using paths relative to a > root will fail. It may happen to work where the thrift files are all in a > single directory, but not in the general case. > There are no tests of this support, so I've added a few in the pull request > I'm preparing. > Somebody found the exact same problem and issued a pull request against this > plugin's original repository on Github: > https://github.com/dtrott/maven-thrift-plugin/pull/28. It went nowhere > because the project was already pending ASF acceptance at that point, but > it's worth looking at as an additional reference. > Thanks! -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift pull request #984: THRIFT-3784: fix and tests
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/984 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3784) thrift-maven-plugin generates invalid include directories for IDL in dependency JARs
[ https://issues.apache.org/jira/browse/THRIFT-3784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952268#comment-15952268 ] ASF GitHub Bot commented on THRIFT-3784: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/984 > thrift-maven-plugin generates invalid include directories for IDL in > dependency JARs > > > Key: THRIFT-3784 > URL: https://issues.apache.org/jira/browse/THRIFT-3784 > Project: Thrift > Issue Type: Bug > Components: Java - Library >Reporter: Chris Osborn >Assignee: James E. King, III > Fix For: 0.11.0 > > > The thrift-maven-plugin attempts to support building .thrift files that > depend on other .thrift files provided in a dependency JAR. It does this by > copying the dependency JAR's thrift files into a temporary directory then > passing corresponding include directory options to the thrift compiler. > However, the process of generating the include directory paths is faulty: > there is a path for each and every directory that contains a .thrift file, > rather than a single path to the root of the thrift file hierarchy. That > means that any thrift files that reference others using paths relative to a > root will fail. It may happen to work where the thrift files are all in a > single directory, but not in the general case. > There are no tests of this support, so I've added a few in the pull request > I'm preparing. > Somebody found the exact same problem and issued a pull request against this > plugin's original repository on Github: > https://github.com/dtrott/maven-thrift-plugin/pull/28. It went nowhere > because the project was already pending ASF acceptance at that point, but > it's worth looking at as an additional reference. > Thanks! -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift pull request #940: THRIFT-3730 server log error twice
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/940 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Resolved] (THRIFT-3730) server log error twice
[ https://issues.apache.org/jira/browse/THRIFT-3730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3730. Resolution: Fixed Assignee: James E. King, III Fix Version/s: 0.11.0 Committed - thanks. > server log error twice > -- > > Key: THRIFT-3730 > URL: https://issues.apache.org/jira/browse/THRIFT-3730 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Affects Versions: 0.9.3 >Reporter: zhujun >Assignee: James E. King, III >Priority: Trivial > Labels: easyfix > Fix For: 0.11.0 > > > Go-Library simple_server log err twitce -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-3730) server log error twice
[ https://issues.apache.org/jira/browse/THRIFT-3730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952274#comment-15952274 ] ASF GitHub Bot commented on THRIFT-3730: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/940 > server log error twice > -- > > Key: THRIFT-3730 > URL: https://issues.apache.org/jira/browse/THRIFT-3730 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Affects Versions: 0.9.3 >Reporter: zhujun >Assignee: James E. King, III >Priority: Trivial > Labels: easyfix > Fix For: 0.11.0 > > > Go-Library simple_server log err twitce -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-3686) Java processor should report internal error on uncaught exception
[ https://issues.apache.org/jira/browse/THRIFT-3686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952275#comment-15952275 ] James E. King, III commented on THRIFT-3686: This needs to be refreshed so it rebuilds on Travis CI. > Java processor should report internal error on uncaught exception > - > > Key: THRIFT-3686 > URL: https://issues.apache.org/jira/browse/THRIFT-3686 > Project: Thrift > Issue Type: Sub-task > Components: Java - Library >Reporter: Aki Sukegawa >Assignee: Aki Sukegawa > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift issue #896: THRIFT-3676
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/896 I think this should be closed and resubmitted, the history got messed up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3676) Cocoa server does not emit exceptions
[ https://issues.apache.org/jira/browse/THRIFT-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952276#comment-15952276 ] ASF GitHub Bot commented on THRIFT-3676: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/896 I think this should be closed and resubmitted, the history got messed up. > Cocoa server does not emit exceptions > - > > Key: THRIFT-3676 > URL: https://issues.apache.org/jira/browse/THRIFT-3676 > Project: Thrift > Issue Type: Bug > Components: Cocoa - Compiler >Reporter: Niels Grewe > > The server side code emitted by the Cocoa generator does not send exceptions > back to the client. Instead the client will be hung waiting for a response. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts
[
https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952286#comment-15952286
]
Jens Geyer commented on THRIFT-4134:
Thanks Jim!
> Fix remaining undefined behavior invalid vptr casts
> ---
>
> Key: THRIFT-4134
> URL: https://issues.apache.org/jira/browse/THRIFT-4134
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General), D - Compiler, Haxe - Compiler, Java
> - Compiler
>Affects Versions: 0.11.0
> Environment: Travis CI, Ubuntu 14.04.5
>Reporter: Jim Apple
> Attachments:
> 0001-THRIFT-4134-Fix-remaining-undefined-behavior-invalid.patch,
> thrift-vptr-travis.txt
>
>
> Removing {{-fno-sanitize-recover=undefined -fno-sanitize=vptr}} from
> {{ubsan.sh}} shows {{vptr}} errors in the following places:
> {noformat}
> src/thrift/generate/t_d_generator.cc:384:25: runtime error:
> src/thrift/generate/t_d_generator.cc:385:12: runtime error:
> src/thrift/generate/t_haxe_generator.cc:2576:34: runtime error:
> src/thrift/generate/t_haxe_generator.cc:2576:35: runtime error:
> src/thrift/parse/t_list.h:33:42: runtime error:
> thrift/parse/t_scope.h:88:40: runtime error:
> thrift/parse/t_scope.h:88:41: runtime error:
> /usr/include/boost/lexical_cast.hpp:1620:43: runtime error:
> src/thrift/generate/t_java_generator.cc:2693:27: runtime error:
> src/thrift/generate/t_java_generator.cc:2693:28: runtime error:
> src/thrift/generate/t_java_generator.cc:3756:35: runtime error:
> src/thrift/generate/t_java_generator.cc:3756:36: runtime error:
> src/thrift/generate/t_java_generator.cc:4639:11: runtime error:
> src/thrift/generate/t_java_generator.cc:4639:12: runtime error:
> src/thrift/generate/t_java_generator.cc:4666:10: runtime error:
> src/thrift/generate/t_java_generator.cc:4666:9: runtime error:
> src/thrift/generate/t_json_generator.cc:277:21: runtime error:
> src/thrift/generate/t_json_generator.cc:277:22: runtime error:
> src/thrift/generate/t_xml_generator.cc:395:21: runtime error:
> src/thrift/generate/t_xml_generator.cc:395:22: runtime error:
> src/thrift/parse/t_base_type.h:64:35: runtime error:
> src/thrift/parse/t_list.h:33:42: runtime error:
> src/thrift/parse/t_set.h:33:42: runtime error:
> thrift/parse/t_scope.h:88:40: runtime error:
> thrift/parse/t_scope.h:88:41: runtime error:
> thrift/parse/t_scope.h:88:41: runtime error:
> {noformat}
> Here is an example
> {noformat}
> [exec] src/thrift/generate/t_json_generator.cc:277:22: runtime error:
> downcast of address 0x03f61d40 which does not point to an object of type
> 't_list'
> [exec] 0x03f61d40: note: object is of type 't_set'
> [exec] 00 00 00 00 a8 b9 f7 01 00 00 00 00 d8 23 04 8e 7e 2b 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00
> [exec] ^~~
> [exec] vptr for 't_set'
> [exec] [WARNING:/thrift/src/test/ThriftTest.thrift:45] No generator
> named 'noexist' could be found!
> [exec] [WARNING:/thrift/src/test/ThriftTest.thrift:47] cpp generator
> does not accept 'noexist' as sub-namespace!
> [exec] #0 0xaa355e in t_json_generator::write_type_spec(t_type*)
> /thrift/src/compiler/cpp/src/thrift/generate/t_json_generator.cc:277:22
> [exec] #1 0xaa12e5 in t_json_generator::write_type_spec_object(char
> const*, t_type*)
> /thrift/src/compiler/cpp/src/thrift/generate/t_json_generator.cc:252:5
> [exec] #2 0xabcc0f in t_json_generator::generate_field(t_field*)
> /thrift/src/compiler/cpp/src/thrift/generate/t_json_generator.cc:663:3
> [exec] #3 0xabb4cd in t_json_generator::generate_struct(t_struct*)
> /thrift/src/compiler/cpp/src/thrift/generate/t_json_generator.cc:583:5
> [exec] #4 0xaad948 in t_json_generator::generate_program()
> /thrift/src/compiler/cpp/src/thrift/generate/t_json_generator.cc:400:7
> [exec] #5 0x44d0f6 in generate(t_program*, std::vector std::allocator > const&)
> /thrift/src/compiler/cpp/src/thrift/main.cc:1032:9
> [exec] #6 0x4532ba in main
> /thrift/src/compiler/cpp/src/thrift/main.cc:1289:5
> [exec] #7 0x2b7e8e784f44 in __libc_start_main
> (/lib/x86_64-linux-gnu/libc.so.6+0x21f44)
> [exec] #8 0x417ec3 in _start
> (/thrift/src/compiler/cpp/thrift+0x417ec3)
> {noformat}
> The problem here is this:
> {noformat}
> } else if (ttype->is_list() || ttype->is_set()) {
> t_type* etype = ((t_list*)ttype)->get_elem_type();
> {noformat}
> {{ttype}} cannot necessarily be cast to {{t_list*}}, since sometimes it is a
> {{t_set*}}. When it is a {{t_set*}}, the call to {{get_elem_type()}} is
> undefined behavior: section 9.3.1 "Nonstatic member functions
> \[class.mfct.non-static\]", paragraph 2 of the C++14 standard states "If a
> non-static member fu
[jira] [Updated] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts
[
https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4134:
---
Fix Version/s: 0.11.0
> Fix remaining undefined behavior invalid vptr casts
> ---
>
> Key: THRIFT-4134
> URL: https://issues.apache.org/jira/browse/THRIFT-4134
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General), D - Compiler, Haxe - Compiler, Java
> - Compiler
>Affects Versions: 0.11.0
> Environment: Travis CI, Ubuntu 14.04.5
>Reporter: Jim Apple
> Fix For: 0.11.0
>
> Attachments:
> 0001-THRIFT-4134-Fix-remaining-undefined-behavior-invalid.patch,
> thrift-vptr-travis.txt
>
>
> Removing {{-fno-sanitize-recover=undefined -fno-sanitize=vptr}} from
> {{ubsan.sh}} shows {{vptr}} errors in the following places:
> {noformat}
> src/thrift/generate/t_d_generator.cc:384:25: runtime error:
> src/thrift/generate/t_d_generator.cc:385:12: runtime error:
> src/thrift/generate/t_haxe_generator.cc:2576:34: runtime error:
> src/thrift/generate/t_haxe_generator.cc:2576:35: runtime error:
> src/thrift/parse/t_list.h:33:42: runtime error:
> thrift/parse/t_scope.h:88:40: runtime error:
> thrift/parse/t_scope.h:88:41: runtime error:
> /usr/include/boost/lexical_cast.hpp:1620:43: runtime error:
> src/thrift/generate/t_java_generator.cc:2693:27: runtime error:
> src/thrift/generate/t_java_generator.cc:2693:28: runtime error:
> src/thrift/generate/t_java_generator.cc:3756:35: runtime error:
> src/thrift/generate/t_java_generator.cc:3756:36: runtime error:
> src/thrift/generate/t_java_generator.cc:4639:11: runtime error:
> src/thrift/generate/t_java_generator.cc:4639:12: runtime error:
> src/thrift/generate/t_java_generator.cc:4666:10: runtime error:
> src/thrift/generate/t_java_generator.cc:4666:9: runtime error:
> src/thrift/generate/t_json_generator.cc:277:21: runtime error:
> src/thrift/generate/t_json_generator.cc:277:22: runtime error:
> src/thrift/generate/t_xml_generator.cc:395:21: runtime error:
> src/thrift/generate/t_xml_generator.cc:395:22: runtime error:
> src/thrift/parse/t_base_type.h:64:35: runtime error:
> src/thrift/parse/t_list.h:33:42: runtime error:
> src/thrift/parse/t_set.h:33:42: runtime error:
> thrift/parse/t_scope.h:88:40: runtime error:
> thrift/parse/t_scope.h:88:41: runtime error:
> thrift/parse/t_scope.h:88:41: runtime error:
> {noformat}
> Here is an example
> {noformat}
> [exec] src/thrift/generate/t_json_generator.cc:277:22: runtime error:
> downcast of address 0x03f61d40 which does not point to an object of type
> 't_list'
> [exec] 0x03f61d40: note: object is of type 't_set'
> [exec] 00 00 00 00 a8 b9 f7 01 00 00 00 00 d8 23 04 8e 7e 2b 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00
> [exec] ^~~
> [exec] vptr for 't_set'
> [exec] [WARNING:/thrift/src/test/ThriftTest.thrift:45] No generator
> named 'noexist' could be found!
> [exec] [WARNING:/thrift/src/test/ThriftTest.thrift:47] cpp generator
> does not accept 'noexist' as sub-namespace!
> [exec] #0 0xaa355e in t_json_generator::write_type_spec(t_type*)
> /thrift/src/compiler/cpp/src/thrift/generate/t_json_generator.cc:277:22
> [exec] #1 0xaa12e5 in t_json_generator::write_type_spec_object(char
> const*, t_type*)
> /thrift/src/compiler/cpp/src/thrift/generate/t_json_generator.cc:252:5
> [exec] #2 0xabcc0f in t_json_generator::generate_field(t_field*)
> /thrift/src/compiler/cpp/src/thrift/generate/t_json_generator.cc:663:3
> [exec] #3 0xabb4cd in t_json_generator::generate_struct(t_struct*)
> /thrift/src/compiler/cpp/src/thrift/generate/t_json_generator.cc:583:5
> [exec] #4 0xaad948 in t_json_generator::generate_program()
> /thrift/src/compiler/cpp/src/thrift/generate/t_json_generator.cc:400:7
> [exec] #5 0x44d0f6 in generate(t_program*, std::vector std::allocator > const&)
> /thrift/src/compiler/cpp/src/thrift/main.cc:1032:9
> [exec] #6 0x4532ba in main
> /thrift/src/compiler/cpp/src/thrift/main.cc:1289:5
> [exec] #7 0x2b7e8e784f44 in __libc_start_main
> (/lib/x86_64-linux-gnu/libc.so.6+0x21f44)
> [exec] #8 0x417ec3 in _start
> (/thrift/src/compiler/cpp/thrift+0x417ec3)
> {noformat}
> The problem here is this:
> {noformat}
> } else if (ttype->is_list() || ttype->is_set()) {
> t_type* etype = ((t_list*)ttype)->get_elem_type();
> {noformat}
> {{ttype}} cannot necessarily be cast to {{t_list*}}, since sometimes it is a
> {{t_set*}}. When it is a {{t_set*}}, the call to {{get_elem_type()}} is
> undefined behavior: section 9.3.1 "Nonstatic member functions
> \[class.mfct.non-static\]", paragraph 2 of the C++14 standard states "If a
> non-static membe
[GitHub] thrift issue #1082: THRIFT-3828 In cmake avoid use of both quoted paths and ...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1082 @jfarrell the Jira ticket was resolved as "Won't Fix" here; can you close this PR? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3828) cmake fails when Boost_INCLUDE_DIRS (and other variables passed to include_directories()) is empty
[ https://issues.apache.org/jira/browse/THRIFT-3828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952368#comment-15952368 ] ASF GitHub Bot commented on THRIFT-3828: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1082 @jfarrell the Jira ticket was resolved as "Won't Fix" here; can you close this PR? Thanks. > cmake fails when Boost_INCLUDE_DIRS (and other variables passed to > include_directories()) is empty > --- > > Key: THRIFT-3828 > URL: https://issues.apache.org/jira/browse/THRIFT-3828 > Project: Thrift > Issue Type: Bug > Components: Build Process >Reporter: Cody Schafer >Assignee: James E. King, III >Priority: Minor > Fix For: 0.10.0 > > Attachments: > 0001-cmake-avoid-use-of-both-quoted-paths-and-SYSTEM-with.patch > > > This is due to the current quoting of those variables when passed to > `include_directories()`. These variables may (and soon will, see below) be > empty in the case where the include directory is a system include path that > is implicitly included. > I ran into this issue when trying to build thrift using gcc-6. gcc-6 doesn't > work with includes that are part of the platform/system include path (see > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129 for one mention). To > resolve this, `FindBoost.cmake` will be adjusted to avoid adding those types > of directories to Boost_INCLUDE_DIRS. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (THRIFT-4154) PHP close() of a TSocket needs to close any type of socket
James E. King, III created THRIFT-4154:
--
Summary: PHP close() of a TSocket needs to close any type of socket
Key: THRIFT-4154
URL: https://issues.apache.org/jira/browse/THRIFT-4154
Project: Thrift
Issue Type: Bug
Components: PHP - Library
Affects Versions: 0.9.3
Reporter: James E. King, III
Assignee: James E. King, III
Opening a ticket for https://github.com/apache/thrift/pull/1011.
{quote}
php must close the socket, anyhow.
otherwise you will get previous reponse when the previous request timeout and
the socket is reused.
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] thrift issue #1011: Fix bug for php close socket
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1011 I opened THRIFT-4154 and I am going to submit a second PR for this. If it passes CI builds I can merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-4154) PHP close() of a TSocket needs to close any type of socket
[
https://issues.apache.org/jira/browse/THRIFT-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952370#comment-15952370
]
ASF GitHub Bot commented on THRIFT-4154:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1011
I opened THRIFT-4154 and I am going to submit a second PR for this. If it
passes CI builds I can merge it.
> PHP close() of a TSocket needs to close any type of socket
> --
>
> Key: THRIFT-4154
> URL: https://issues.apache.org/jira/browse/THRIFT-4154
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library
>Affects Versions: 0.9.3
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> Opening a ticket for https://github.com/apache/thrift/pull/1011.
> {quote}
> php must close the socket, anyhow.
> otherwise you will get previous reponse when the previous request timeout and
> the socket is reused.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (THRIFT-4154) PHP close() of a TSocket needs to close any type of socket
[
https://issues.apache.org/jira/browse/THRIFT-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952372#comment-15952372
]
ASF GitHub Bot commented on THRIFT-4154:
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1233
THRIFT-4154: properly close socket whether it is persistent or not on
close()
Replaces PR #1011. Resubmitting to get a CI build that passes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT-4154
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1233.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1233
commit a48781a52d9f79c290c153830cf1ee48348b9a67
Author: James E. King, III
Date: 2017-04-01T19:57:36Z
THRIFT-4154: properly close socket whether it is persistent or not on
close()
> PHP close() of a TSocket needs to close any type of socket
> --
>
> Key: THRIFT-4154
> URL: https://issues.apache.org/jira/browse/THRIFT-4154
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library
>Affects Versions: 0.9.3
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> Opening a ticket for https://github.com/apache/thrift/pull/1011.
> {quote}
> php must close the socket, anyhow.
> otherwise you will get previous reponse when the previous request timeout and
> the socket is reused.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] thrift pull request #1233: THRIFT-4154: properly close socket whether it is ...
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1233 THRIFT-4154: properly close socket whether it is persistent or not on close() Replaces PR #1011. Resubmitting to get a CI build that passes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift THRIFT-4154 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1233.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1233 commit a48781a52d9f79c290c153830cf1ee48348b9a67 Author: James E. King, III Date: 2017-04-01T19:57:36Z THRIFT-4154: properly close socket whether it is persistent or not on close() --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1011: Fix bug for php close socket
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1011 Superceded by #1233 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (THRIFT-4155) Unstable D language test has caused some CI build failures
James E. King, III created THRIFT-4155:
--
Summary: Unstable D language test has caused some CI build failures
Key: THRIFT-4155
URL: https://issues.apache.org/jira/browse/THRIFT-4155
Project: Thrift
Issue Type: Bug
Components: D - Library
Affects Versions: 0.11.0
Environment: Travis CI Build Job #5
Reporter: James E. King, III
For an example see:
https://travis-ci.org/apache/thrift/jobs/217605837
{noformat}
make[4]: Leaving directory `/thrift/src/lib/d'
make[3]: Leaving directory `/thrift/src/lib/d'
Making check in test
make[3]: Entering directory `/thrift/src/lib/d/test'
openssl req -new -x509 -nodes -config openssl.test.cnf \
-out server-certificate.pem
Generating a 2048 bit RSA private key
...+++
...+++
writing new private key to 'server-private-key.pem'
-
cat server-certificate.pem > trusted-ca-certificate.pem
make check-am
make[4]: Entering directory `/thrift/src/lib/d/test'
make check-TESTS check-local
make[5]: Entering directory `/thrift/src/lib/d/test'
dmd -L-levent ../libthriftd-event.a -L-lssl -L-lcrypto ../libthriftd-ssl.a -w
-wi -O -release -inline -I../../../lib/d/src -Igen-d
../../../lib/d/libthriftd.a -ofclient_pool_test client_pool_test.d
dmd -L-levent ../libthriftd-event.a -L-lssl -L-lcrypto ../libthriftd-ssl.a -w
-wi -O -release -inline -I../../../lib/d/src -Igen-d
../../../lib/d/libthriftd.a -oftransport_test transport_test.d
dmd -L-levent ../libthriftd-event.a -L-lssl -L-lcrypto ../libthriftd-ssl.a -w
-wi -O -release -inline -I../../../lib/d/src -Igen-d
../../../lib/d/libthriftd.a -ofasync_test async_test.d
../../../compiler/cpp/thrift --gen d ../../../test/ThriftTest.thrift
[WARNING:/thrift/src/test/ThriftTest.thrift:45] No generator named 'noexist'
could be found!
[WARNING:/thrift/src/test/ThriftTest.thrift:47] cpp generator does not accept
'noexist' as sub-namespace!
../../../compiler/cpp/thrift --gen d ../../../test/ThriftTest.thrift
[WARNING:/thrift/src/test/ThriftTest.thrift:45] No generator named 'noexist'
could be found!
[WARNING:/thrift/src/test/ThriftTest.thrift:47] cpp generator does not accept
'noexist' as sub-namespace!
../../../compiler/cpp/thrift --gen d -nowarn ../../../test/DebugProtoTest.thrift
../../../compiler/cpp/thrift --gen d ../../../test/StressTest.thrift
[WARNING:/thrift/src/test/StressTest.thrift:31] Consider using the more
efficient "binary" type instead of "list".
[WARNING:/thrift/src/test/StressTest.thrift:31] Consider using the more
efficient "binary" type instead of "list".
../../../compiler/cpp/thrift --gen d ../../../test/StressTest.thrift
[WARNING:/thrift/src/test/StressTest.thrift:31] Consider using the more
efficient "binary" type instead of "list".
[WARNING:/thrift/src/test/StressTest.thrift:31] Consider using the more
efficient "binary" type instead of "list".
dmd -L-levent ../libthriftd-event.a -L-lssl -L-lcrypto ../libthriftd-ssl.a -w
-wi -O -release -inline -I../../../lib/d/src -Igen-d
../../../lib/d/libthriftd.a -ofthrift_test_client thrift_test_client.d
thrift_test_common.d gen-d/thrift/test/SecondService.d
gen-d/thrift/test/ThriftTest.d gen-d/thrift/test/ThriftTest_constants.d
gen-d/thrift/test/ThriftTest_types.d
dmd -L-levent ../libthriftd-event.a -L-lssl -L-lcrypto ../libthriftd-ssl.a -w
-wi -O -release -inline -I../../../lib/d/src -Igen-d
../../../lib/d/libthriftd.a -ofthrift_test_server thrift_test_server.d
thrift_test_common.d test_utils.d gen-d/thrift/test/SecondService.d
gen-d/thrift/test/ThriftTest.d gen-d/thrift/test/ThriftTest_constants.d
gen-d/thrift/test/ThriftTest_types.d
dmd -L-levent ../libthriftd-event.a -L-lssl -L-lcrypto ../libthriftd-ssl.a -w
-wi -O -release -inline -I../../../lib/d/src -Igen-d
../../../lib/d/libthriftd.a -ofserialization_benchmark
serialization_benchmark.d gen-d/DebugProtoTest_types.d
dmd -L-levent ../libthriftd-event.a -L-lssl -L-lcrypto ../libthriftd-ssl.a -w
-wi -O -release -inline -I../../../lib/d/src -Igen-d
../../../lib/d/libthriftd.a -ofstress_test_server stress_test_server.d
test_utils.d gen-d/thrift/test/stress/Service.d
gen-d/thrift/test/stress/StressTest_types.d
thrift.transport.base.TTransportException@src/thrift/transport/socket.d(255):
Failed to connect to 127.0.0.1:9090.
??:? void thrift.transport.socket.TSocket.open() [0x50b8a8]
??:? int
thrift.codegen.client_pool.TClientPool!(client_pool_test.ExTestService).TClientPool.executeOnPool!(int).executeOnPool(scope
int
delegate(thrift.codegen.client.TClientBase!(client_pool_test.ExTestService).TClientBase))
[0x4f9a0e]
??:? int
thrift.codegen.client_pool.TClientPool!(client_pool_test.ExTestService).TClientPool.getPort()
[0x4e2250]
??:? void client_pool_test.syncClientPoolTest(const(ushort)[],
client_pool_test.ExTestHandler[]) [0x4cbc7e]
??:? _Dmain [0x4cbad3]
??:? _D2rt
[GitHub] thrift issue #1233: THRIFT-4154: properly close socket whether it is persist...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1233 I logged the build failure as THRIFT-4155 as it appears to be an intermittent test failure. I've seen it twice this week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-4154) PHP close() of a TSocket needs to close any type of socket
[
https://issues.apache.org/jira/browse/THRIFT-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952504#comment-15952504
]
ASF GitHub Bot commented on THRIFT-4154:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1233
I logged the build failure as THRIFT-4155 as it appears to be an
intermittent test failure. I've seen it twice this week.
> PHP close() of a TSocket needs to close any type of socket
> --
>
> Key: THRIFT-4154
> URL: https://issues.apache.org/jira/browse/THRIFT-4154
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library
>Affects Versions: 0.9.3
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> Opening a ticket for https://github.com/apache/thrift/pull/1011.
> {quote}
> php must close the socket, anyhow.
> otherwise you will get previous reponse when the previous request timeout and
> the socket is reused.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] thrift pull request #1233: THRIFT-4154: properly close socket whether it is ...
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1233 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Resolved] (THRIFT-4154) PHP close() of a TSocket needs to close any type of socket
[
https://issues.apache.org/jira/browse/THRIFT-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4154.
Resolution: Fixed
Fix Version/s: 0.11.0
> PHP close() of a TSocket needs to close any type of socket
> --
>
> Key: THRIFT-4154
> URL: https://issues.apache.org/jira/browse/THRIFT-4154
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library
>Affects Versions: 0.9.3
>Reporter: James E. King, III
>Assignee: James E. King, III
> Fix For: 0.11.0
>
>
> Opening a ticket for https://github.com/apache/thrift/pull/1011.
> {quote}
> php must close the socket, anyhow.
> otherwise you will get previous reponse when the previous request timeout and
> the socket is reused.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] thrift pull request #1011: Fix bug for php close socket
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1011 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-4154) PHP close() of a TSocket needs to close any type of socket
[
https://issues.apache.org/jira/browse/THRIFT-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952505#comment-15952505
]
ASF GitHub Bot commented on THRIFT-4154:
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1233
> PHP close() of a TSocket needs to close any type of socket
> --
>
> Key: THRIFT-4154
> URL: https://issues.apache.org/jira/browse/THRIFT-4154
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library
>Affects Versions: 0.9.3
>Reporter: James E. King, III
>Assignee: James E. King, III
> Fix For: 0.11.0
>
>
> Opening a ticket for https://github.com/apache/thrift/pull/1011.
> {quote}
> php must close the socket, anyhow.
> otherwise you will get previous reponse when the previous request timeout and
> the socket is reused.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (THRIFT-3799) Make constants to use iota
[ https://issues.apache.org/jira/browse/THRIFT-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952506#comment-15952506 ] ASF GitHub Bot commented on THRIFT-3799: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/995 @jfarrell please close this pull request as it was rejected last year. Thanks. > Make constants to use iota > -- > > Key: THRIFT-3799 > URL: https://issues.apache.org/jira/browse/THRIFT-3799 > Project: Thrift > Issue Type: Improvement > Components: Go - Library >Reporter: Mahendran Kathirvel >Priority: Minor > Labels: easyfix > Original Estimate: 24h > Remaining Estimate: 24h > > Now, the constants and enumerations are using hardcoded values but Go has a > elegant way of doing this by using `Iota` -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift issue #995: THRIFT-3799 Make constants to use iota
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/995 @jfarrell please close this pull request as it was rejected last year. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #991: dependency version constraints for haskell
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/991 @jfarrell I checked the current haskell build file and we've already modified it to work the dependencies. This item doesn't have a Jira ticket I can comment on, so this can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3657) D TFileWriterTransport close should use non-priority send
[ https://issues.apache.org/jira/browse/THRIFT-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952507#comment-15952507 ] James E. King, III commented on THRIFT-3657: This issue needs a refresh on the pull request. > D TFileWriterTransport close should use non-priority send > - > > Key: THRIFT-3657 > URL: https://issues.apache.org/jira/browse/THRIFT-3657 > Project: Thrift > Issue Type: Bug > Components: D - Library >Reporter: Aki Sukegawa >Assignee: Aki Sukegawa >Priority: Trivial > > prioritySend is used in TFileWriterTransport close method. > A possible problem with this is that even synchronized calls that are > strictly before close call can be ignored in rare occasions. > The author has put a comment "FIXME: Should use normal send here" and there's > no reason not to. > I suspect it is a remnant of old implementation or local debug stuff. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-3627) Missing basic code style consistency of JavaScript.
[
https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952508#comment-15952508
]
James E. King, III commented on THRIFT-3627:
This pull request probably needs to be rebased on upstream/master and
resubmitted to merge properly given its age.
> Missing basic code style consistency of JavaScript.
> ---
>
> Key: THRIFT-3627
> URL: https://issues.apache.org/jira/browse/THRIFT-3627
> Project: Thrift
> Issue Type: Improvement
> Components: JavaScript - Library
>Reporter: Kazuki Matsuda
>Priority: Minor
>
> E.g.)
> * No white space in {code}function(args){// beteween `){`{code}
> https://github.com/apache/thrift/blob/84cf363eeedf4cc9bb618bb2b1980696b9f6fc9b/lib/js/src/thrift.js#L1497
> * "Double quoted" (not 'single quoted') string litteral
> https://github.com/apache/thrift/blob/84cf363eeedf4cc9bb618bb2b1980696b9f6fc9b/lib/js/src/thrift.js#L133
> Those errors can be easily fixed by fixjsstyle.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] thrift issue #733: THRIFT-3474 Docker: thrift-compiler
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/733 @jfarrell this is marked Closed/Fixed in jira; this pull request can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3474) Docker: thrift-compiler
[ https://issues.apache.org/jira/browse/THRIFT-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952509#comment-15952509 ] ASF GitHub Bot commented on THRIFT-3474: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/733 @jfarrell this is marked Closed/Fixed in jira; this pull request can be closed. > Docker: thrift-compiler > --- > > Key: THRIFT-3474 > URL: https://issues.apache.org/jira/browse/THRIFT-3474 > Project: Thrift > Issue Type: Bug > Components: Compiler (General), Deployment >Reporter: Roger Meier >Assignee: Roger Meier > Fix For: 0.10.0 > > > I made a Dockerfile and .dockerignore for this -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-2457) fbthrift float
[ https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952514#comment-15952514 ] James E. King, III commented on THRIFT-2457: This issue stalled; there's an open pull request for cpp that needs to be refreshed: https://github.com/apache/thrift/pull/731/files The original issue goes back to 2010: THRIFT-964 Do we know that every language implementation can support the float type properly? Is this something we want to continue to pursue? > fbthrift float > -- > > Key: THRIFT-2457 > URL: https://issues.apache.org/jira/browse/THRIFT-2457 > Project: Thrift > Issue Type: Sub-task > Components: Build Process, C++ - Compiler, C++ - Library, Test Suite >Reporter: Roger Meier >Priority: Minor > Fix For: 1.0 > > > I'm interested into the fbthrift FLOAT data type. > Which languages are supported? -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift issue #688: THRIFT-3385 warning: format ‘%lu’ expects ‘long uns...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/688 @jfarrell this issue has been closed/fixed and the pull request can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3385) warning: format ‘%lu’ expects ‘long unsigned int’, but has type ‘std::basic_string::size_type {aka unsigned int}
[
https://issues.apache.org/jira/browse/THRIFT-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952515#comment-15952515
]
ASF GitHub Bot commented on THRIFT-3385:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/688
@jfarrell this issue has been closed/fixed and the pull request can be
closed.
> warning: format ‘%lu’ expects ‘long unsigned int’, but has type
> ‘std::basic_string::size_type {aka unsigned int}
> --
>
> Key: THRIFT-3385
> URL: https://issues.apache.org/jira/browse/THRIFT-3385
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Reporter: Jens Geyer
>Assignee: Jens Geyer
>Priority: Minor
> Fix For: 0.10.0
>
> Attachments:
> THRIFT-3385-warning-format-lu-expects-long-unsigned-.patch
>
>
> {{make check}} for C++ produces the following:
> {code}
> src/TestClient.cpp: In function ‘int main(int, char**)’:
> src/TestClient.cpp:486:58: warning: format ‘%lu’ expects argument of type
> ‘long unsigned int’, but argument 2 has type
> ‘std::basic_string::size_type {aka unsigned int}’ [-Wformat=]
> {code}
> ___
> EDIT: sorry for the noise
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] thrift issue #651: THRIFT-3380 nodejs Fix broken transport and protocol requ...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/651 @jfarrell this was marked Won't Fix in Jira. This PR can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #639: Implements ssl sockets on c_glib
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/639 @jfarrell this was done in another set of PRs so this can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3380) nodejs: 0.9.2 -> 0.9.3 upgrade breaks Protocol and Transport requires
[
https://issues.apache.org/jira/browse/THRIFT-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952531#comment-15952531
]
ASF GitHub Bot commented on THRIFT-3380:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/651
@jfarrell this was marked Won't Fix in Jira. This PR can be closed.
> nodejs: 0.9.2 -> 0.9.3 upgrade breaks Protocol and Transport requires
> -
>
> Key: THRIFT-3380
> URL: https://issues.apache.org/jira/browse/THRIFT-3380
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
>Affects Versions: 0.9.3
>Reporter: Matt Willer
>Assignee: Roger Meier
>Priority: Critical
> Fix For: 0.10.0
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> Node.js projects that depend on Thrift and need to use a specific transport
> or protocol must require them in separately, like this:
> {code}
> var thrift = require('thrift'),
> ThriftTransports = require('thrift/lib/thrift/transport');
> {code}
> The new version (0.9.3) changed that directory structure of the thrift module
> so that the transport file is now located at
> thrift/lib/nodejs/lib/thrift/transport.js, which breaks any application that
> was requiring it at the old path. This type of breaking change is
> inappropriate for a patch version, and should be fixed immediately.
> The directory structure change also has the undesirable side effect of
> including every single language implementation of thrift in the Node.js
> module, bloating the size of the module with unnecessary files.
> Long-term, the right fix for this is to export useful parts of the library
> (e.g. transport and protocol constructors) from the main file, but since this
> is a patch version the immediate fix should be to maintain existing behavior.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (THRIFT-3357) Additional java compiler option to generate EnumSet/EnumMap where elements/keys are enums
[ https://issues.apache.org/jira/browse/THRIFT-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952532#comment-15952532 ] James E. King, III commented on THRIFT-3357: Any interest in reviving this / refreshing against current master? > Additional java compiler option to generate EnumSet/EnumMap where > elements/keys are enums > - > > Key: THRIFT-3357 > URL: https://issues.apache.org/jira/browse/THRIFT-3357 > Project: Thrift > Issue Type: Improvement > Components: Java - Compiler >Reporter: Deniss Afonin > > Additional java compiler option to generate EnumSet/EnumMap instead of > HashSet/HashMap where elements/keys are enums. > This makes these maps/sets memory efficient and faster. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-3288) c_glib: Build unit tests with all warnings enabled, no warnings generated
[
https://issues.apache.org/jira/browse/THRIFT-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952533#comment-15952533
]
ASF GitHub Bot commented on THRIFT-3288:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/577
@jfarrell this is marked closed fixed in Jira. This PR can be closed.
> c_glib: Build unit tests with all warnings enabled, no warnings generated
> -
>
> Key: THRIFT-3288
> URL: https://issues.apache.org/jira/browse/THRIFT-3288
> Project: Thrift
> Issue Type: Improvement
> Components: C glib - Library
>Affects Versions: 0.9.3
> Environment: Cloud9 (Ubuntu 14.04.2 LTS; gcc 4.8.2)
>Reporter: Simon South
>Assignee: Simon South
>Priority: Minor
> Labels: c_glib, unit-test
> Fix For: 0.9.3
>
>
> For correctness and to help with tracking down bugs, the C (GLib) unit tests
> (in {{lib/c_glib/test}}) should build with the same compiler-warning options
> enabled for the C++ library's tests ({{-Wall -Wextra -pedantic}}) and without
> any warnings generated.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] thrift issue #577: THRIFT-3288 c glib build unit tests with all warnings ena...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/577 @jfarrell this is marked closed fixed in Jira. This PR can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #501: THRIFT-3154: tornado tutorial fail to work
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/501 @jfarrell this is closed fixed in Jira. This PR can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3204) SimpleServer process loop missed handle some error
[ https://issues.apache.org/jira/browse/THRIFT-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952535#comment-15952535 ] ASF GitHub Bot commented on THRIFT-3204: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/529 @jfarrell Recommend we close this as won't fix. It never passed and the original author's github repository isn't around any more. > SimpleServer process loop missed handle some error > -- > > Key: THRIFT-3204 > URL: https://issues.apache.org/jira/browse/THRIFT-3204 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Affects Versions: 0.9.2 >Reporter: Jing Wang >Assignee: Jing Wang > Labels: patch > > SimpleServer do not handle all errors returned by processor. > When a error returned by processor.Process methods In SimpleServer's > processRequests, program will omit this error and log nothing to the > programmer if this error is not thrift.TTransportException type. > If a Protocol error happens, the server will close the client connection and > log nothing, > This bug is cause by a wrong "else if" condition. In the if esle condition, > the inside variable "err" will cover the scope of outside "err", and it will > always be "nil", the "else if" condition will never reached -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift issue #529: [THRIFT-3204] SimpleServer processRequests method nerver ...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/529 @jfarrell Recommend we close this as won't fix. It never passed and the original author's github repository isn't around any more. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3154) tutorial/py.tornado throw EOF exception
[ https://issues.apache.org/jira/browse/THRIFT-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952536#comment-15952536 ] ASF GitHub Bot commented on THRIFT-3154: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/501 @jfarrell this is closed fixed in Jira. This PR can be closed. > tutorial/py.tornado throw EOF exception > --- > > Key: THRIFT-3154 > URL: https://issues.apache.org/jira/browse/THRIFT-3154 > Project: Thrift > Issue Type: Bug > Components: Python - Compiler >Affects Versions: 0.9.2 > Environment: ubuntu 14.04 >Reporter: K K > Fix For: 0.10.0 > > > make check also fail at py.tornado -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift issue #500: THRIFT-3112: Typed AsyncMethodCallback with return type
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/500 @jfarrell this is closed/fixed in Jira. This PR can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3112) [Java] AsyncMethodCallback should be typed in generated AsyncIface
[
https://issues.apache.org/jira/browse/THRIFT-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952537#comment-15952537
]
ASF GitHub Bot commented on THRIFT-3112:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/500
@jfarrell this is closed/fixed in Jira. This PR can be closed.
> [Java] AsyncMethodCallback should be typed in generated AsyncIface
> --
>
> Key: THRIFT-3112
> URL: https://issues.apache.org/jira/browse/THRIFT-3112
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Compiler, Java - Library
>Affects Versions: 0.9.2, 0.9.3
>Reporter: Sergei Egorov
>Assignee: John Sirois
> Fix For: 0.10.0
>
>
> AsyncMethodCallback is generic, but current Java code generator is not adding
> type info to it, and instead of:
> {code:java}
> public interface AsyncIface {
> public void ping(org.apache.thrift.async.AsyncMethodCallback
> resultHandler) throws org.apache.thrift.TException;
> }
> {code}
> we have:
> {code:java}
> public interface AsyncIface {
> public void ping(org.apache.thrift.async.AsyncMethodCallback
> resultHandler) throws org.apache.thrift.TException;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (THRIFT-3121) Librt does not exist on OS X
[ https://issues.apache.org/jira/browse/THRIFT-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952538#comment-15952538 ] ASF GitHub Bot commented on THRIFT-3121: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/475 @jfarrell this can be closed - it was fixed. > Librt does not exist on OS X > > > Key: THRIFT-3121 > URL: https://issues.apache.org/jira/browse/THRIFT-3121 > Project: Thrift > Issue Type: Bug > Components: Test Suite > Environment: OSX >Reporter: Thomas Bartelmess > Fix For: 0.9.3 > > > THRIFT-2441 introduced a dependency on librt which does not exist on OS X -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift issue #475: THRIFT-3121 Librt does not exist on OSX
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/475 @jfarrell this can be closed - it was fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #432: [THRIFT-3088] TThreadPoolServer with Sasl auth may leak C...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/432 @jfarrell this can be closed - it was fixed a while back. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3088) TThreadPoolServer with Sasl auth may leak CLOSE_WAIT socket
[ https://issues.apache.org/jira/browse/THRIFT-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952539#comment-15952539 ] ASF GitHub Bot commented on THRIFT-3088: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/432 @jfarrell this can be closed - it was fixed a while back. > TThreadPoolServer with Sasl auth may leak CLOSE_WAIT socket > --- > > Key: THRIFT-3088 > URL: https://issues.apache.org/jira/browse/THRIFT-3088 > Project: Thrift > Issue Type: Bug > Components: Java - Library >Affects Versions: 0.9 >Reporter: Winger Pun > Fix For: 0.9.3 > > > Start TThreadPoolServer to server with TSaslServerTransport.Factory as > transportFactory. While using nc to test the specified port whether > reachable, it will leak CLOSE_WAIT socket.That's because nc will close socket > at once while successful connect TThreadPoolServer, but the server still try > using sasl protocol to build an inputTransport which of course failed at > once. However inputTransport is null which makes it can't close socket > properly which lead to CLOSE_WAIT socket. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift issue #386: THRIFT-2983: replaces deprecated -[NSData getBytes:] with...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/386 @jfarrell this was resolved invalid - please close PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2983) Replace use of deprecated -[NSData getBytes:] in -[TNSFileHandleTransport readAll:offset:length:]
[ https://issues.apache.org/jira/browse/THRIFT-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952540#comment-15952540 ] ASF GitHub Bot commented on THRIFT-2983: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/386 @jfarrell this was resolved invalid - please close PR. > Replace use of deprecated -[NSData getBytes:] in -[TNSFileHandleTransport > readAll:offset:length:] > -- > > Key: THRIFT-2983 > URL: https://issues.apache.org/jira/browse/THRIFT-2983 > Project: Thrift > Issue Type: Bug > Components: Cocoa - Library >Affects Versions: 0.9.2 >Reporter: Jeremy W. Sherman >Assignee: James E. King, III > Fix For: 0.10.0 > > Original Estimate: 1h > Remaining Estimate: 1h > > It looks like the access is actually safe; the code just needs to provide the > known length to -getBytes:length: and this will be fixed. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift issue #356: THRIFT-2941
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/356 @jfarrell this was closed incomplete a while back. The PR can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2941) Convert processor to use switch instead of map
[ https://issues.apache.org/jira/browse/THRIFT-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952541#comment-15952541 ] ASF GitHub Bot commented on THRIFT-2941: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/356 @jfarrell this was closed incomplete a while back. The PR can be closed. > Convert processor to use switch instead of map > -- > > Key: THRIFT-2941 > URL: https://issues.apache.org/jira/browse/THRIFT-2941 > Project: Thrift > Issue Type: Improvement > Components: Go - Compiler >Reporter: Craig Peterson > > We are using a special protocol extension to insert auxiliary tracking data > into our method names on certain services. Our implementation works by > creating a special Processor Wrapper and creating a new Handler/Processor for > each request. > The current implementation of the generated handler makes this rather > expensive, as a new map is created each time you create a processor. I > propose reworking the generated processor to use a switch structure for > dispatch rather than the current map-based solution. > A summary of the differences before and after for a small example can be > found in this gist: > https://gist.github.com/captncraig/e2bc7e7d1a0cb2c8127b#file-foo-thrift > I ran benchmarks and the baseline performance (both in time and allocations) > of the processor seem almost exactly the same after my changes. My > modified/wrapped processor however is able to perform much faster and with > less memory with these changes. > No application code should need to be changed unless it was interacting with > the exported processor map functions (which I suspect should have been > private all along). > Working on a patch right now. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift issue #354: THRIFT-2940: Package json
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/354 @jfarrell this was closed fixed a while back. This PR can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2940) Allow installing Thrift from git as NPM module by providing package.json in top level directory
[
https://issues.apache.org/jira/browse/THRIFT-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952542#comment-15952542
]
ASF GitHub Bot commented on THRIFT-2940:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/354
@jfarrell this was closed fixed a while back. This PR can be closed.
> Allow installing Thrift from git as NPM module by providing package.json in
> top level directory
> ---
>
> Key: THRIFT-2940
> URL: https://issues.apache.org/jira/browse/THRIFT-2940
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
>Reporter: Radoslaw Gruchalski
>Assignee: Roger Meier
> Fix For: 0.9.3
>
>
> Allow installing thirft from git as NPM module by providing package.json in
> top level directory. Currently, result is similar to:
> {noformat}
> drone:gossiperl-client-js rad$ npm install
> npm WARN excluding symbolic link tutorial/erl/client.sh -> server.sh
> npm ERR! Error: ENOENT, open
> '/var/folders/gd/jkx3kmg53gj85lwjslf79n6mgn/T/npm-36445-mmwd9VRJ/1421011402511-0.04021586640737951/package/package.json'
> npm ERR! If you need help, you may report this log at:
> npm ERR!
> npm ERR! or email it to:
> npm ERR!
> npm ERR! System Darwin 14.0.0
> npm ERR! command "node" "/usr/local/bin/npm" "install"
> npm ERR! cwd /Users/rad/dev/my/gossiperl-client-js
> npm ERR! node -v v0.10.22
> npm ERR! npm -v 1.3.14
> npm ERR! path
> /var/folders/gd/jkx3kmg53gj85lwjslf79n6mgn/T/npm-36445-mmwd9VRJ/1421011402511-0.04021586640737951/package/package.json
> npm ERR! code ENOENT
> npm ERR! errno 34
> npm ERR!
> npm ERR! Additional logging details can be found in:
> npm ERR! /Users/rad/dev/my/gossiperl-client-js/npm-debug.log
> npm ERR! not ok code 0
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (THRIFT-2899) Enum values should be prefixed with the Cocoa namespace
[ https://issues.apache.org/jira/browse/THRIFT-2899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952543#comment-15952543 ] ASF GitHub Bot commented on THRIFT-2899: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/328 @jfarrell this was resolved as a duplicate. This PR can be closed. > Enum values should be prefixed with the Cocoa namespace > --- > > Key: THRIFT-2899 > URL: https://issues.apache.org/jira/browse/THRIFT-2899 > Project: Thrift > Issue Type: Improvement > Components: Cocoa - Compiler >Reporter: Jim Speth >Assignee: James E. King, III >Priority: Minor > Fix For: 0.10.0 > > > Enum types are prefixed with the Cocoa namespace, but enum values are not. > This means the values could potentially collide. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift issue #328: THRIFT-2899: Prefix enum values with the Cocoa namespace.
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/328 @jfarrell this was resolved as a duplicate. This PR can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #278: THRIFT-2796: Added testcase for THRIFT-2793. Needs testin...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/278 @jfarrell this can be closed. It was resolved incomplete/later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2796) Testcase for THRIFT-2793
[ https://issues.apache.org/jira/browse/THRIFT-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952544#comment-15952544 ] ASF GitHub Bot commented on THRIFT-2796: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/278 @jfarrell this can be closed. It was resolved incomplete/later. > Testcase for THRIFT-2793 > > > Key: THRIFT-2796 > URL: https://issues.apache.org/jira/browse/THRIFT-2796 > Project: Thrift > Issue Type: Test > Components: Go - Compiler >Reporter: Jens Geyer > > Add test for THRIFT-2793 Go compiler produces uncompilable code -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-2721) generate more idiomatic erlang code
[ https://issues.apache.org/jira/browse/THRIFT-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952545#comment-15952545 ] ASF GitHub Bot commented on THRIFT-2721: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/226 @jfarrell this can be closed; the Jira ticket is resolved. > generate more idiomatic erlang code > --- > > Key: THRIFT-2721 > URL: https://issues.apache.org/jira/browse/THRIFT-2721 > Project: Thrift > Issue Type: Improvement > Components: Erlang - Compiler >Reporter: alisdair sullivan >Assignee: alisdair sullivan >Priority: Minor > Labels: erlang > > reduces the amount of code generated by the erlang compiler and increases > readability of resulting modules. also adds some more comprehensive tests for > the compiler -- This message was sent by Atlassian JIRA (v6.3.15#6346)
