[jira] [Updated] (THRIFT-2644) Haxe support
[ https://issues.apache.org/jira/browse/THRIFT-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2644: --- Fix Version/s: 1.0 > Haxe support > > > Key: THRIFT-2644 > URL: https://issues.apache.org/jira/browse/THRIFT-2644 > Project: Thrift > Issue Type: Improvement >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 1.0 > > > I'm currently about to prepare a patch to include [Haxe|http://haxe.org/] > support into Thrift over there in my [GitHub Thrift > fork|https://github.com/Jens-G/thrift/tree/haxe]. If anyone has an interest > in this and wants to join for development, testing and/or review, you're > welcome - just drop me a mail. I'll update this ticket accordingly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2644) Haxe support
[ https://issues.apache.org/jira/browse/THRIFT-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2644: --- Component/s: Haxe - Library Haxe - Compiler > Haxe support > > > Key: THRIFT-2644 > URL: https://issues.apache.org/jira/browse/THRIFT-2644 > Project: Thrift > Issue Type: Improvement > Components: Haxe - Compiler, Haxe - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 1.0 > > > I'm currently about to prepare a patch to include [Haxe|http://haxe.org/] > support into Thrift over there in my [GitHub Thrift > fork|https://github.com/Jens-G/thrift/tree/haxe]. If anyone has an interest > in this and wants to join for development, testing and/or review, you're > welcome - just drop me a mail. I'll update this ticket accordingly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2706) D library does not support "oneway" message type
[ https://issues.apache.org/jira/browse/THRIFT-2706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2706. Resolution: Fixed Fix Version/s: 0.9.2 Assignee: Jens Geyer Committed, thank you both! > D library does not support "oneway" message type > > > Key: THRIFT-2706 > URL: https://issues.apache.org/jira/browse/THRIFT-2706 > Project: Thrift > Issue Type: Bug > Components: D - Compiler, D - Library >Reporter: Konrad Grochowski >Assignee: Jens Geyer > Fix For: 0.9.2 > > > all calls are sent as "TMessageType.CALL", never using "TMessageType.ONEWAY" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-2718) Command line help for Thrift test server/client
Jens Geyer created THRIFT-2718: -- Summary: Command line help for Thrift test server/client Key: THRIFT-2718 URL: https://issues.apache.org/jira/browse/THRIFT-2718 Project: Thrift Issue Type: Improvement Components: Delphi - Library Reporter: Jens Geyer Assignee: Jens Geyer Priority: Trivial The Delphi test client and server lack a sufficient cmdline help. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2718) Command line help for Thrift test server/client
[ https://issues.apache.org/jira/browse/THRIFT-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2718: --- Attachment: THRIFT-2718-Command-line-help-for-Thrift-test-server.patch > Command line help for Thrift test server/client > --- > > Key: THRIFT-2718 > URL: https://issues.apache.org/jira/browse/THRIFT-2718 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Library >Reporter: Jens Geyer >Assignee: Jens Geyer >Priority: Trivial > Attachments: > THRIFT-2718-Command-line-help-for-Thrift-test-server.patch > > > The Delphi test client and server lack a sufficient cmdline help. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2718) Align command line args for Thrift test server/client
[ https://issues.apache.org/jira/browse/THRIFT-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2718: --- Summary: Align command line args for Thrift test server/client (was: Command line help for Thrift test server/client) > Align command line args for Thrift test server/client > - > > Key: THRIFT-2718 > URL: https://issues.apache.org/jira/browse/THRIFT-2718 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Library >Reporter: Jens Geyer >Assignee: Jens Geyer >Priority: Trivial > Attachments: > THRIFT-2718-Command-line-help-for-Thrift-test-server.patch > > > The Delphi test client and server lack a sufficient cmdline help. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2644) Haxe support
[ https://issues.apache.org/jira/browse/THRIFT-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143831#comment-14143831 ] Jens Geyer commented on THRIFT-2644: FYI, just added JSON to the pull request :-) > Haxe support > > > Key: THRIFT-2644 > URL: https://issues.apache.org/jira/browse/THRIFT-2644 > Project: Thrift > Issue Type: Improvement > Components: Haxe - Compiler, Haxe - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 1.0 > > > I'm currently about to prepare a patch to include [Haxe|http://haxe.org/] > support into Thrift over there in my [GitHub Thrift > fork|https://github.com/Jens-G/thrift/tree/haxe]. If anyone has an interest > in this and wants to join for development, testing and/or review, you're > welcome - just drop me a mail. I'll update this ticket accordingly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2718) Align command line args for Thrift test server/client
[ https://issues.apache.org/jira/browse/THRIFT-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143839#comment-14143839 ] Jens Geyer commented on THRIFT-2718: The doc is incomplete. We have named pipes, anon pipes, ... am I free to make the rules here? > Align command line args for Thrift test server/client > - > > Key: THRIFT-2718 > URL: https://issues.apache.org/jira/browse/THRIFT-2718 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Library >Reporter: Jens Geyer >Assignee: Jens Geyer >Priority: Trivial > Attachments: > THRIFT-2718-Command-line-help-for-Thrift-test-server.patch > > > The Delphi test client and server lack a sufficient cmdline help. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (THRIFT-2718) Align command line args for Thrift test server/client
[ https://issues.apache.org/jira/browse/THRIFT-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143839#comment-14143839 ] Jens Geyer edited comment on THRIFT-2718 at 9/22/14 9:35 PM: - The doc is incomplete. We have named pipes, anon pipes, ... am I free to make the rules here? EDIT: There is another problem. Since buffered is the default, but I can specify multiple layered transports ... how would I disable buffered? was (Author: jensg): The doc is incomplete. We have named pipes, anon pipes, ... am I free to make the rules here? > Align command line args for Thrift test server/client > - > > Key: THRIFT-2718 > URL: https://issues.apache.org/jira/browse/THRIFT-2718 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Library >Reporter: Jens Geyer >Assignee: Jens Geyer >Priority: Trivial > Attachments: > THRIFT-2718-Command-line-help-for-Thrift-test-server.patch > > > The Delphi test client and server lack a sufficient cmdline help. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (THRIFT-2718) Align command line args for Thrift test server/client
[ https://issues.apache.org/jira/browse/THRIFT-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143839#comment-14143839 ] Jens Geyer edited comment on THRIFT-2718 at 9/22/14 9:37 PM: - The doc is incomplete. We have named pipes, anon pipes, ... am I free to make the rules here? EDIT: There is another problem. Since buffered is the default, but I can specify multiple layered transports ... how would I disable buffered? => Proposal: Default is "socket", not buffered. was (Author: jensg): The doc is incomplete. We have named pipes, anon pipes, ... am I free to make the rules here? EDIT: There is another problem. Since buffered is the default, but I can specify multiple layered transports ... how would I disable buffered? > Align command line args for Thrift test server/client > - > > Key: THRIFT-2718 > URL: https://issues.apache.org/jira/browse/THRIFT-2718 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Library >Reporter: Jens Geyer >Assignee: Jens Geyer >Priority: Trivial > Attachments: > THRIFT-2718-Command-line-help-for-Thrift-test-server.patch > > > The Delphi test client and server lack a sufficient cmdline help. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2718) Align command line args for Thrift test server/client
[ https://issues.apache.org/jira/browse/THRIFT-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2718: --- Attachment: (was: THRIFT-2718-Command-line-help-for-Thrift-test-server.patch) > Align command line args for Thrift test server/client > - > > Key: THRIFT-2718 > URL: https://issues.apache.org/jira/browse/THRIFT-2718 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Library >Reporter: Jens Geyer >Assignee: Jens Geyer >Priority: Trivial > Attachments: > THRIFT-2718-Command-line-help-for-Thrift-test-server-v2.patch > > > The Delphi test client and server lack a sufficient cmdline help. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2718) Align command line args for Thrift test server/client
[ https://issues.apache.org/jira/browse/THRIFT-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2718: --- Attachment: THRIFT-2718-Command-line-help-for-Thrift-test-server-v2.patch > Align command line args for Thrift test server/client > - > > Key: THRIFT-2718 > URL: https://issues.apache.org/jira/browse/THRIFT-2718 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Library >Reporter: Jens Geyer >Assignee: Jens Geyer >Priority: Trivial > Attachments: > THRIFT-2718-Command-line-help-for-Thrift-test-server-v2.patch, > THRIFT-2718-Command-line-help-for-Thrift-test-server.patch > > > The Delphi test client and server lack a sufficient cmdline help. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2718) Align command line args for Thrift test server/client
[ https://issues.apache.org/jira/browse/THRIFT-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2718: --- Attachment: (was: THRIFT-2718-Command-line-help-for-Thrift-test-server-v2.patch) > Align command line args for Thrift test server/client > - > > Key: THRIFT-2718 > URL: https://issues.apache.org/jira/browse/THRIFT-2718 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Attachments: > THRIFT-2718-Command-line-help-for-Thrift-test-server-v3.patch > > > The Delphi test client and server lack a sufficient cmdline help. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2718) Align command line args for Thrift test server/client
[ https://issues.apache.org/jira/browse/THRIFT-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2718: --- Priority: Major (was: Trivial) > Align command line args for Thrift test server/client > - > > Key: THRIFT-2718 > URL: https://issues.apache.org/jira/browse/THRIFT-2718 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Attachments: > THRIFT-2718-Command-line-help-for-Thrift-test-server-v3.patch > > > The Delphi test client and server lack a sufficient cmdline help. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2718) Align command line args for Thrift test server/client
[ https://issues.apache.org/jira/browse/THRIFT-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2718: --- Attachment: THRIFT-2718-Command-line-help-for-Thrift-test-server-v3.patch > Align command line args for Thrift test server/client > - > > Key: THRIFT-2718 > URL: https://issues.apache.org/jira/browse/THRIFT-2718 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Attachments: > THRIFT-2718-Command-line-help-for-Thrift-test-server-v3.patch > > > The Delphi test client and server lack a sufficient cmdline help. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2718) Align command line args for Thrift test server/client
[
https://issues.apache.org/jira/browse/THRIFT-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143996#comment-14143996
]
Jens Geyer commented on THRIFT-2718:
I added a few options to the list, following the existing scheme. In particular:
Client and Server:
{code}
--named-pipe argWindows Named Pipe (e.g. MyThriftPipe)
--anon-pipes hRead hWrite Windows Anonymous Pipes pair (handles)
{code}
Client only:
{code}
-t [ --threads ] arg (=1) Number of Test threads
{code}
The default "buffered" issue is unchanged, but still valid, IMHO.
> Align command line args for Thrift test server/client
> -
>
> Key: THRIFT-2718
> URL: https://issues.apache.org/jira/browse/THRIFT-2718
> Project: Thrift
> Issue Type: Improvement
> Components: Delphi - Library
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Attachments:
> THRIFT-2718-Command-line-help-for-Thrift-test-server-v3.patch
>
>
> The Delphi test client and server lack a sufficient cmdline help.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2711) master no longer compiles with i586-mingw32msvc
[ https://issues.apache.org/jira/browse/THRIFT-2711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145155#comment-14145155 ] Jens Geyer commented on THRIFT-2711: Hi [~hcorg], what MinGW is that running on? I had have lots of troubles with MinGW Thrift builds on Windows lately, incompatibilities, bugs and the like, so I finally stopped using it at all. > master no longer compiles with i586-mingw32msvc > --- > > Key: THRIFT-2711 > URL: https://issues.apache.org/jira/browse/THRIFT-2711 > Project: Thrift > Issue Type: Bug > Components: Build Process, Compiler (General) > Environment: Travis >Reporter: Konrad Grochowski > > first I've noticed that Travis reports false positive for mingw builds. After > fixing it (patch will be attached) I checked why it does not compile: some > thrift compiler code uses C++11 features (which is good imho), but > i586-mingw32msvc is very old compiler. > I started working on patch for Travis to run CI with newer version of cross > compiler. But maybe i586-mingw32msvc is desired for some special purpose? Is > it possible to update it? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2718) Align command line args for Thrift test server/client
[ https://issues.apache.org/jira/browse/THRIFT-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2718: --- Attachment: THRIFT-2718-Align-cmdline-help-and-return-codes-for-V4.patch Patch version 4: * added return code according to THRIFT-2668 * updated readme.md accordingly > Align command line args for Thrift test server/client > - > > Key: THRIFT-2718 > URL: https://issues.apache.org/jira/browse/THRIFT-2718 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Attachments: > THRIFT-2718-Align-cmdline-help-and-return-codes-for-V4.patch > > > The Delphi test client and server lack a sufficient cmdline help. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2718) Align command line args for Thrift test server/client
[ https://issues.apache.org/jira/browse/THRIFT-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2718: --- Attachment: (was: THRIFT-2718-Command-line-help-for-Thrift-test-server-v3.patch) > Align command line args for Thrift test server/client > - > > Key: THRIFT-2718 > URL: https://issues.apache.org/jira/browse/THRIFT-2718 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Attachments: > THRIFT-2718-Align-cmdline-help-and-return-codes-for-V4.patch > > > The Delphi test client and server lack a sufficient cmdline help. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2718) Align command line args for Thrift test server/client
[ https://issues.apache.org/jira/browse/THRIFT-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2718. Resolution: Fixed Fix Version/s: 0.9.2 Committed. > Align command line args for Thrift test server/client > - > > Key: THRIFT-2718 > URL: https://issues.apache.org/jira/browse/THRIFT-2718 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.9.2 > > Attachments: > THRIFT-2718-Align-cmdline-help-and-return-codes-for-V4.patch > > > The Delphi test client and server lack a sufficient cmdline help. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (THRIFT-2719) ObjectDisposedException in TSocket when sending rapidly
[ https://issues.apache.org/jira/browse/THRIFT-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-2719: -- Assignee: Jens Geyer > ObjectDisposedException in TSocket when sending rapidly > --- > > Key: THRIFT-2719 > URL: https://issues.apache.org/jira/browse/THRIFT-2719 > Project: Thrift > Issue Type: Bug > Components: C# - Library >Affects Versions: 0.9.1 >Reporter: Nils Hügelmann >Assignee: Jens Geyer > Attachments: thrift-2719-fix.patch > > > Test code opens a connection, fires one request, then closes the connection > in a loop. In my environment, i get an ObjectDisposedException for a socket > object in TSocket.cs after a few hundred requests. I'm not sure what causes > this, i suspect some underlying socket reusing. > Attached patch fixes the issue. > If you require more info to accept this, i cannot promise that i will be able > to deliver that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Reopened] (THRIFT-2718) Align command line args for Thrift test server/client
[ https://issues.apache.org/jira/browse/THRIFT-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reopened THRIFT-2718: > Align command line args for Thrift test server/client > - > > Key: THRIFT-2718 > URL: https://issues.apache.org/jira/browse/THRIFT-2718 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.9.2 > > Attachments: > THRIFT-2718-Align-cmdline-help-and-return-codes-for-V4.patch > > > The Delphi test client and server lack a sufficient cmdline help. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2718) Align command line args for Thrift test server/client
[ https://issues.apache.org/jira/browse/THRIFT-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2718: --- Attachment: THRIFT-2718-Align-cmdline-help-and-return-codes-V5.patch > Align command line args for Thrift test server/client > - > > Key: THRIFT-2718 > URL: https://issues.apache.org/jira/browse/THRIFT-2718 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.9.2 > > Attachments: > THRIFT-2718-Align-cmdline-help-and-return-codes-V5.patch, > THRIFT-2718-Align-cmdline-help-and-return-codes-for-V4.patch > > > The Delphi test client and server lack a sufficient cmdline help. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2718) Align command line args for Thrift test server/client
[ https://issues.apache.org/jira/browse/THRIFT-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-2718. -- Resolution: Fixed Minor fix, committed. > Align command line args for Thrift test server/client > - > > Key: THRIFT-2718 > URL: https://issues.apache.org/jira/browse/THRIFT-2718 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.9.2 > > Attachments: > THRIFT-2718-Align-cmdline-help-and-return-codes-V5.patch, > THRIFT-2718-Align-cmdline-help-and-return-codes-for-V4.patch > > > The Delphi test client and server lack a sufficient cmdline help. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2654) reduce number of server exceptions
[ https://issues.apache.org/jira/browse/THRIFT-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2654: --- Assignee: (was: Jens Geyer) > reduce number of server exceptions > -- > > Key: THRIFT-2654 > URL: https://issues.apache.org/jira/browse/THRIFT-2654 > Project: Thrift > Issue Type: Improvement > Components: C# - Library >Reporter: Jens Geyer > > GitHub user captncraig opened a pull request: > https://github.com/apache/thrift/pull/177 > C# - reduce number of server exceptions > The current server implementation reads in a loop until the client > closes, at which point an exception is thrown by the processor/transport and > caught by the server. > > I solve this by creating a smarter peek functionality in TTransport which > reads and caches a byte from the underlying transport and reinserts it in > ReadAll. > You can merge this pull request into a Git repository by running: > $ git pull https://github.com/captncraig/thrift transport-peek > Alternatively you can review and apply these changes as the patch at: > https://github.com/apache/thrift/pull/177.patch > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > This closes #177 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2654) reduce number of server exceptions
[ https://issues.apache.org/jira/browse/THRIFT-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151206#comment-14151206 ] Jens Geyer commented on THRIFT-2654: I like the idea. But Peek() isn't actually a peek, it is a read operation. Let's just take this (theoretical) scenario: * call transport.Peek() to effectively read a Byte * now call transport.Read() instead of transport.ReadAll() * depending on the Transport used, you may lose the peeked Byte, maybe read it later out of band. I haven't checked the entire code if that is currently the case, but I don't like even the possibility of this. To me it would unexpected that Read and ReadAll differ that much. While we're at it, why don't we implement a real peek operation? Again, I like the idea! https://github.com/apache/thrift/pull/177#issuecomment-56222777 > reduce number of server exceptions > -- > > Key: THRIFT-2654 > URL: https://issues.apache.org/jira/browse/THRIFT-2654 > Project: Thrift > Issue Type: Improvement > Components: C# - Library >Reporter: Jens Geyer > > GitHub user captncraig opened a pull request: > https://github.com/apache/thrift/pull/177 > C# - reduce number of server exceptions > The current server implementation reads in a loop until the client > closes, at which point an exception is thrown by the processor/transport and > caught by the server. > > I solve this by creating a smarter peek functionality in TTransport which > reads and caches a byte from the underlying transport and reinserts it in > ReadAll. > You can merge this pull request into a Git repository by running: > $ git pull https://github.com/captncraig/thrift transport-peek > Alternatively you can review and apply these changes as the patch at: > https://github.com/apache/thrift/pull/177.patch > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > This closes #177 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2654) reduce number of server exceptions
[ https://issues.apache.org/jira/browse/THRIFT-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2654. Resolution: Fixed Fix Version/s: 0.9.2 Assignee: Jens Geyer Ok, I committed this after some formatting. I have to say that 'm still not really happy with it, for the reasons outlined above. > reduce number of server exceptions > -- > > Key: THRIFT-2654 > URL: https://issues.apache.org/jira/browse/THRIFT-2654 > Project: Thrift > Issue Type: Improvement > Components: C# - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.9.2 > > > GitHub user captncraig opened a pull request: > https://github.com/apache/thrift/pull/177 > C# - reduce number of server exceptions > The current server implementation reads in a loop until the client > closes, at which point an exception is thrown by the processor/transport and > caught by the server. > > I solve this by creating a smarter peek functionality in TTransport which > reads and caches a byte from the underlying transport and reinserts it in > ReadAll. > You can merge this pull request into a Git repository by running: > $ git pull https://github.com/captncraig/thrift transport-peek > Alternatively you can review and apply these changes as the patch at: > https://github.com/apache/thrift/pull/177.patch > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > This closes #177 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2701) Update TCompactProtocol.php
[ https://issues.apache.org/jira/browse/THRIFT-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2701. Resolution: Fixed Fix Version/s: 0.9.2 Assignee: Jens Geyer Committed. > Update TCompactProtocol.php > --- > > Key: THRIFT-2701 > URL: https://issues.apache.org/jira/browse/THRIFT-2701 > Project: Thrift > Issue Type: Bug > Components: PHP - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.9.2 > > > GitHub user anjz opened a pull request: > https://github.com/apache/thrift/pull/212 > Update TCompactProtocol.php > Removed `strrev` from `readDouble` and `writeDouble` functions. I found > problems reading a double that was generated with the python library. > You can merge this pull request into a Git repository by running: > $ git pull https://github.com/anjz/thrift master > Alternatively you can review and apply these changes as the patch at: > https://github.com/apache/thrift/pull/212.patch > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > This closes #212 > > > commit c5d971fdf660f38426d3109a3e844ae6d1beb624 > Author: anjz > Date: 2014-09-11T15:52:07Z > Update TCompactProtocol.php > > Removed `strrev` from `readDouble` and `writeDouble` functions. I found > problems reading a double that was generated with the python library. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2144) Cocoa: Client-side support for Multiplexing Services on any Transport and Protocol
[ https://issues.apache.org/jira/browse/THRIFT-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2144. Resolution: Fixed Fix Version/s: 0.9.2 Committed, thanks! > Cocoa: Client-side support for Multiplexing Services on any Transport and > Protocol > -- > > Key: THRIFT-2144 > URL: https://issues.apache.org/jira/browse/THRIFT-2144 > Project: Thrift > Issue Type: Sub-task > Components: Cocoa - Library >Reporter: David Robakowski >Assignee: Jens Geyer > Labels: multiplexing > Fix For: 0.9.2 > > > The attached > [patch|https://issues.apache.org/jira/secure/attachment/12599415/thrift-2144_Client-side-support-for-Multiplexing-Services.patch] > provides client-side support for multiplexed services as specified at > [THRIFT-563|https://issues.apache.org/jira/browse/THRIFT-563]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (THRIFT-2719) ObjectDisposedException in TSocket when sending rapidly
[
https://issues.apache.org/jira/browse/THRIFT-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152290#comment-14152290
]
Jens Geyer edited comment on THRIFT-2719 at 9/29/14 9:06 PM:
-
{code}
try
{
if( hlp.Client.Client != null)
hlp.Client.EndConnect(asyncres);
}
catch (Exception)
{
// catch that away
}
catch (ObjectDisposedException)
{
// catch that away
}
{code}
I'm sorry, but that dog don't hunt. It gives me an CS0160 error, because the
less specific {{catch (Exception)}} block [already catches the
exception|http://msdn.microsoft.com/en-us/library/0yd65esw.aspx].
What am I doing wrong?
was (Author: jensg):
{code}
try
{
if( hlp.Client.Client != null)
hlp.Client.EndConnect(asyncres);
}
catch (Exception)
{
// catch that away
}
catch (ObjectDisposedException)
{
// catch that away
}
{code}
I'm sorry, but that dog don't hunt. It gives me an CS0160 error, because the
less specific {{catch (Exception)}} block [already catches the
exception|http://msdn.microsoft.com/de-de/library/0yd65esw.aspx].
What am I doing wrong?
> ObjectDisposedException in TSocket when sending rapidly
> ---
>
> Key: THRIFT-2719
> URL: https://issues.apache.org/jira/browse/THRIFT-2719
> Project: Thrift
> Issue Type: Bug
> Components: C# - Library
>Affects Versions: 0.9.1
>Reporter: Nils Hügelmann
>Assignee: Jens Geyer
> Attachments: thrift-2719-fix.patch
>
>
> Test code opens a connection, fires one request, then closes the connection
> in a loop. In my environment, i get an ObjectDisposedException for a socket
> object in TSocket.cs after a few hundred requests. I'm not sure what causes
> this, i suspect some underlying socket reusing.
> Attached patch fixes the issue.
> If you require more info to accept this, i cannot promise that i will be able
> to deliver that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2719) ObjectDisposedException in TSocket when sending rapidly
[ https://issues.apache.org/jira/browse/THRIFT-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152293#comment-14152293 ] Jens Geyer commented on THRIFT-2719: Could you add the full error message, including stack and all? > ObjectDisposedException in TSocket when sending rapidly > --- > > Key: THRIFT-2719 > URL: https://issues.apache.org/jira/browse/THRIFT-2719 > Project: Thrift > Issue Type: Bug > Components: C# - Library >Affects Versions: 0.9.1 >Reporter: Nils Hügelmann >Assignee: Jens Geyer > Attachments: thrift-2719-fix.patch > > > Test code opens a connection, fires one request, then closes the connection > in a loop. In my environment, i get an ObjectDisposedException for a socket > object in TSocket.cs after a few hundred requests. I'm not sure what causes > this, i suspect some underlying socket reusing. > Attached patch fixes the issue. > If you require more info to accept this, i cannot promise that i will be able > to deliver that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2719) ObjectDisposedException in TSocket when sending rapidly
[
https://issues.apache.org/jira/browse/THRIFT-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152290#comment-14152290
]
Jens Geyer commented on THRIFT-2719:
{code}
try
{
if( hlp.Client.Client != null)
hlp.Client.EndConnect(asyncres);
}
catch (Exception)
{
// catch that away
}
catch (ObjectDisposedException)
{
// catch that away
}
{code}
I'm sorry, but that dog don't hunt. It gives me an CS0160 error, because the
less specific {{catch (Exception)}} block [already catches the
exception|http://msdn.microsoft.com/de-de/library/0yd65esw.aspx].
What am I doing wrong?
> ObjectDisposedException in TSocket when sending rapidly
> ---
>
> Key: THRIFT-2719
> URL: https://issues.apache.org/jira/browse/THRIFT-2719
> Project: Thrift
> Issue Type: Bug
> Components: C# - Library
>Affects Versions: 0.9.1
>Reporter: Nils Hügelmann
>Assignee: Jens Geyer
> Attachments: thrift-2719-fix.patch
>
>
> Test code opens a connection, fires one request, then closes the connection
> in a loop. In my environment, i get an ObjectDisposedException for a socket
> object in TSocket.cs after a few hundred requests. I'm not sure what causes
> this, i suspect some underlying socket reusing.
> Attached patch fixes the issue.
> If you require more info to accept this, i cannot promise that i will be able
> to deliver that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (THRIFT-2753) Misc. Haxe improvements
Jens Geyer created THRIFT-2753: -- Summary: Misc. Haxe improvements Key: THRIFT-2753 URL: https://issues.apache.org/jira/browse/THRIFT-2753 Project: Thrift Issue Type: Improvement Components: Haxe - Compiler, Haxe - Library Reporter: Jens Geyer Assignee: Jens Geyer This is the second part of the Haxe addition started with THRIFT-2644, completing the base feature set with HTTP client and stream transports. *Test improvements* - added missing testException tests - aligned cross test return codes - aligned cross test command line arguments - added --skip-speed-test switch fixed test exit code *Code generator improvements* - added suffix "_FIELD_ID" to the fieldIDs to prevent name collisions with uppercase-only members (like ID, VAT) - always render enum type with full namespace to prevent name collisions with class members *Library improvements* - HTTP transport client added - Generic Stream transport added, implemented FileStream transport - fixed possible double UTF-8 encoding/decoding in JSON protocol - Haxe Thrift library test project added -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2753) Misc. Haxe improvements
[ https://issues.apache.org/jira/browse/THRIFT-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2753: --- Issue Type: Sub-task (was: Improvement) Parent: THRIFT-2644 > Misc. Haxe improvements > --- > > Key: THRIFT-2753 > URL: https://issues.apache.org/jira/browse/THRIFT-2753 > Project: Thrift > Issue Type: Sub-task > Components: Haxe - Compiler, Haxe - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > > This is the second part of the Haxe addition started with THRIFT-2644, > completing the base feature set with HTTP client and stream transports. > *Test improvements* > - added missing testException tests > - aligned cross test return codes > - aligned cross test command line arguments > - added --skip-speed-test switch fixed test exit code > *Code generator improvements* > - added suffix "_FIELD_ID" to the fieldIDs to prevent name collisions with > uppercase-only members (like ID, VAT) > - always render enum type with full namespace to prevent name collisions with > class members > *Library improvements* > - HTTP transport client added > - Generic Stream transport added, implemented FileStream transport > - fixed possible double UTF-8 encoding/decoding in JSON protocol > - Haxe Thrift library test project added -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2753) Misc. Haxe improvements
[ https://issues.apache.org/jira/browse/THRIFT-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2753: --- Description: This is the second part of the Haxe addition started with THRIFT-2644, completing the base feature set with HTTP client and stream transports. *Test improvements* - added missing testException tests - aligned cross test return codes - aligned cross test command line arguments - added --skip-speed-test switch *Code generator improvements* - added suffix "_FIELD_ID" to the fieldIDs to prevent name collisions with uppercase-only members (like ID, VAT) - always render enum type with full namespace to prevent name collisions with class members *Library improvements* - HTTP transport client added - Generic Stream transport added, implemented FileStream transport - fixed possible double UTF-8 encoding/decoding in JSON protocol - Haxe Thrift library test project added was: This is the second part of the Haxe addition started with THRIFT-2644, completing the base feature set with HTTP client and stream transports. *Test improvements* - added missing testException tests - aligned cross test return codes - aligned cross test command line arguments - added --skip-speed-test switch fixed test exit code *Code generator improvements* - added suffix "_FIELD_ID" to the fieldIDs to prevent name collisions with uppercase-only members (like ID, VAT) - always render enum type with full namespace to prevent name collisions with class members *Library improvements* - HTTP transport client added - Generic Stream transport added, implemented FileStream transport - fixed possible double UTF-8 encoding/decoding in JSON protocol - Haxe Thrift library test project added > Misc. Haxe improvements > --- > > Key: THRIFT-2753 > URL: https://issues.apache.org/jira/browse/THRIFT-2753 > Project: Thrift > Issue Type: Sub-task > Components: Haxe - Compiler, Haxe - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > > This is the second part of the Haxe addition started with THRIFT-2644, > completing the base feature set with HTTP client and stream transports. > *Test improvements* > - added missing testException tests > - aligned cross test return codes > - aligned cross test command line arguments > - added --skip-speed-test switch > *Code generator improvements* > - added suffix "_FIELD_ID" to the fieldIDs to prevent name collisions with > uppercase-only members (like ID, VAT) > - always render enum type with full namespace to prevent name collisions with > class members > *Library improvements* > - HTTP transport client added > - Generic Stream transport added, implemented FileStream transport > - fixed possible double UTF-8 encoding/decoding in JSON protocol > - Haxe Thrift library test project added -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2665) tornado library debug messages are too verbose
[ https://issues.apache.org/jira/browse/THRIFT-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2665. Resolution: Fixed Fix Version/s: 0.9.2 Assignee: Jens Geyer Committed. Had to resolve conflicts against another one of your patches. > tornado library debug messages are too verbose > -- > > Key: THRIFT-2665 > URL: https://issues.apache.org/jira/browse/THRIFT-2665 > Project: Thrift > Issue Type: Bug > Components: Python - Library >Affects Versions: 0.9.1 >Reporter: Dustin Spicuzza >Assignee: Jens Geyer > Fix For: 0.9.2 > > > In TTornado.py, It generates a debug message each time a new message comes > in. The other python bindings do not have the same behavior, so it doesn't > make sense to keep this debug code in the bindings. Presumably those log > messages are only useful for thrift developers or someone debugging thrift > itself. > Especially considering that it's logging to the root logger (see > THRIFT-2663), it makes it really difficult to ignore these messages. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2719) ObjectDisposedException in TSocket when sending rapidly
[ https://issues.apache.org/jira/browse/THRIFT-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-2719. -- Resolution: Duplicate Fix Version/s: 0.9.2 Solved by THRIFT-2339, so I close it as a duplicate, even though it is not in the strict sense of the word. > ObjectDisposedException in TSocket when sending rapidly > --- > > Key: THRIFT-2719 > URL: https://issues.apache.org/jira/browse/THRIFT-2719 > Project: Thrift > Issue Type: Bug > Components: C# - Library >Affects Versions: 0.9.1 >Reporter: Nils Hügelmann >Assignee: Jens Geyer > Fix For: 0.9.2 > > Attachments: thrift-2719-fix.patch > > > Test code opens a connection, fires one request, then closes the connection > in a loop. In my environment, i get an ObjectDisposedException for a socket > object in TSocket.cs after a few hundred requests. I'm not sure what causes > this, i suspect some underlying socket reusing. > Attached patch fixes the issue. > If you require more info to accept this, i cannot promise that i will be able > to deliver that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2754) erlang lib tests don't clean up after themselves properly
[ https://issues.apache.org/jira/browse/THRIFT-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2754. Resolution: Fixed Committed, thanks! > erlang lib tests don't clean up after themselves properly > - > > Key: THRIFT-2754 > URL: https://issues.apache.org/jira/browse/THRIFT-2754 > Project: Thrift > Issue Type: Test > Components: Erlang - Library >Reporter: alisdair sullivan >Assignee: alisdair sullivan >Priority: Trivial > Labels: erlang > Fix For: 0.9.2 > > > the erlang disklog tests leave some files behind in tmp after running. they > should be cleaned up by the tests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2689) struct names that differ only in capitalization of first character generate broken erlang code
[
https://issues.apache.org/jira/browse/THRIFT-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-2689.
Resolution: Fixed
Committed.
> struct names that differ only in capitalization of first character generate
> broken erlang code
> --
>
> Key: THRIFT-2689
> URL: https://issues.apache.org/jira/browse/THRIFT-2689
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Compiler, Erlang - Library
>Reporter: alisdair sullivan
>Assignee: alisdair sullivan
>Priority: Minor
> Fix For: 0.9.2
>
>
> the following thrift specification generates broken erlang code:
> struct invalid { /* contents of struct are irrelevent */ }
> struct Invalid { /* still irrelevent }
> the compiler currently renames any struct that starts with a capital so that
> it starts with a lowercase letter. instead, it should leave names intact and
> use proper erlang syntax in generation. the attached patch does exactly that
> this does break backwards compatibility
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2674) JavaScript: declare Accept: and Content-Type: in request
[
https://issues.apache.org/jira/browse/THRIFT-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155348#comment-14155348
]
Jens Geyer commented on THRIFT-2674:
{quote}
It seems that my github pull request is not tracked in this Jira, is there
anything else I need to do to make that happen?
{quote}
Ideally one mentions the THRIFT-number in the pull request. Doing that later in
a comment works too, but we lose the initial pull request message and have to
look up that in the mailing list archives, if needed for some reason. So the
recommended order is JIRA first, pull request second, mentioning the number
from step 1
> JavaScript: declare Accept: and Content-Type: in request
>
>
> Key: THRIFT-2674
> URL: https://issues.apache.org/jira/browse/THRIFT-2674
> Project: Thrift
> Issue Type: Bug
> Components: JavaScript - Library
>Reporter: Stig Bakken
>Priority: Minor
> Attachments: js-type.diff
>
>
> When a JS client communicates with a backend supporting several encodings,
> knowing which protocol to use is a bit kludgy. This patch tries to fix that
> by always setting the Accept: and Content-Type: request headers to
> "application/json".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2143) Generated Ruby client doesn't handle enums
[ https://issues.apache.org/jira/browse/THRIFT-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155351#comment-14155351 ] Jens Geyer commented on THRIFT-2143: Hi [~thecarlhall], any progress on this? > Generated Ruby client doesn't handle enums > -- > > Key: THRIFT-2143 > URL: https://issues.apache.org/jira/browse/THRIFT-2143 > Project: Thrift > Issue Type: Bug > Components: Ruby - Compiler >Affects Versions: 0.9, 0.9.1 >Reporter: Carl Hall > Attachments: thrift-2143.diff > > > The generated ruby client includes and uses enums but doesn't send or receive > them correctly. They go out as i32 and are expected to be received as i32. > While this is the underlying data type, it breaks things that expect the enum > to come through. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-1503) No FramedTransport support in cocoa
[ https://issues.apache.org/jira/browse/THRIFT-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-1503. -- Resolution: Fixed Fix Version/s: 0.9.1 Duplicate of THRIFT-1792 > No FramedTransport support in cocoa > --- > > Key: THRIFT-1503 > URL: https://issues.apache.org/jira/browse/THRIFT-1503 > Project: Thrift > Issue Type: New Feature > Components: Cocoa - Library > Environment: osx/ios >Reporter: Jools Enticknap > Labels: feature, patch > Fix For: 0.9.1 > > Attachments: TNSFramedTransport.h, TNSFramedTransport.m > > > There is no support for Framed Transport in the cocoa support library, making > it impossible for cocoa clients to connect to cassandra as this is now the > default transport. > Attached is an implementation -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-1847) TSSLSocket.cpp and TFileTransport.cpp incorrectly excluded from Visual Studio project file
[ https://issues.apache.org/jira/browse/THRIFT-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-1847. Resolution: Fixed Fix Version/s: 0.9.2 Assignee: Jens Geyer Rebased, tested and committed. The snprintf() thing has been solved by another ticket in the meantime. > TSSLSocket.cpp and TFileTransport.cpp incorrectly excluded from Visual Studio > project file > -- > > Key: THRIFT-1847 > URL: https://issues.apache.org/jira/browse/THRIFT-1847 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.9 > Environment: MSVC 2010 (Windows 7) and MSVC 2012 (Windows 8) >Reporter: Chris Stylianou >Assignee: Jens Geyer >Priority: Minor > Labels: cpp, msvc, thrift > Fix For: 0.9.2 > > Attachments: thrift-msvc.patch > > > Both TSSLSocket.cpp and TFileTransport.cpp are incorrectly excluded from > Visual Studio project file, so they are not built. I've attached a patch to > include them again. > TSSLSocket.cpp also has an issue due to the use of 'snprintf' which is a C99 > feature that isn't provided by MSVC compilers. I've also included a fix for > this in the attached patch which uses '_snprintf_s' for MSVC instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-1847) TSSLSocket.cpp and TFileTransport.cpp incorrectly excluded from Visual Studio project file
[ https://issues.apache.org/jira/browse/THRIFT-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-1847: --- Labels: cpp msvc (was: cpp msvc thrift) > TSSLSocket.cpp and TFileTransport.cpp incorrectly excluded from Visual Studio > project file > -- > > Key: THRIFT-1847 > URL: https://issues.apache.org/jira/browse/THRIFT-1847 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.9 > Environment: MSVC 2010 (Windows 7) and MSVC 2012 (Windows 8) >Reporter: Chris Stylianou >Assignee: Jens Geyer >Priority: Minor > Labels: cpp, msvc > Fix For: 0.9.2 > > Attachments: thrift-msvc.patch > > > Both TSSLSocket.cpp and TFileTransport.cpp are incorrectly excluded from > Visual Studio project file, so they are not built. I've attached a patch to > include them again. > TSSLSocket.cpp also has an issue due to the use of 'snprintf' which is a C99 > feature that isn't provided by MSVC compilers. I've also included a fix for > this in the attached patch which uses '_snprintf_s' for MSVC instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-1248) pointer subtraction in TMemoryBuffer relies on undefined behavior
[ https://issues.apache.org/jira/browse/THRIFT-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155414#comment-14155414 ] Jens Geyer commented on THRIFT-1248: Hi [~fanatoly], any progress on this? > pointer subtraction in TMemoryBuffer relies on undefined behavior > - > > Key: THRIFT-1248 > URL: https://issues.apache.org/jira/browse/THRIFT-1248 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.5 >Reporter: Anatoly Fayngelerin >Assignee: Anatoly Fayngelerin > Fix For: 1.0 > > Attachments: 0_7_0_ptrdiff.patch > > > The ensureCanWrite function in TMemoryBuffer currently "rebases" the buffer > pointers by subtracting the original buffer pointer from the pointer newly > returned by realloc. While this seems to work fine on my linux setup(I > couldn't force a reproducer), pointer subtraction between pointers that we > allocated separately is an undefined operation. > I have run into problems with this on platforms other than linux. > I am attaching a patch that removes the undefined operation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2628) erlang: struct member name conflicts due to lowercased names
[ https://issues.apache.org/jira/browse/THRIFT-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2628. Resolution: Fixed Committed, many thanks! > erlang: struct member name conflicts due to lowercased names > > > Key: THRIFT-2628 > URL: https://issues.apache.org/jira/browse/THRIFT-2628 > Project: Thrift > Issue Type: Bug > Components: Erlang - Compiler, Erlang - Library >Reporter: alisdair sullivan >Assignee: alisdair sullivan > Labels: erlang > Fix For: 0.9.2 > > > the erlang backend generates records to represent structs. instead of the > unique sequential id they use the struct field name as the record keys. > records in erlang do not support repeated keys so generated erlang modules do > not compile > the most obvious fix is to refuse to generate code from structs with repeated > keys but this means the erlang backend is not capable of handling all valid > structs > the easiest fix is to switch structs to use the unique sequential ids as the > keys of the record but this breaks backwards compatibility and probably > necessitates generating helper functions to retrieve fields by name > also possible is switching to an erlang data structure that supports repeated > keys but this would also require breaking backwards compatibility -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-1191) Erlang binding throws during skipping fields of composite type (maps, lists, structs, sets)
[ https://issues.apache.org/jira/browse/THRIFT-1191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-1191. -- Resolution: Cannot Reproduce @[~chaos-ad], Sorry for the delay with this ticket. I close it right now because of the above comments. However, if there exists an issue, we should solve it. Please feel free to reopen if necessary. Thanks! > Erlang binding throws during skipping fields of composite type (maps, lists, > structs, sets) > --- > > Key: THRIFT-1191 > URL: https://issues.apache.org/jira/browse/THRIFT-1191 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Reporter: Anatoly Kanivetsky >Assignee: alisdair sullivan > Attachments: THRIFT-1191.patch > > > Erlang binding throws during skipping fields of composite type (maps, lists, > structs, sets) > Here's the pull request with this fix: > https://github.com/apache/thrift/pull/3 here is the patch > Here's the fix only: > https://github.com/chaos-ad/thrift/commit/d70576209ae01f7ae56a1afccc1210d120b0ecde -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2674) JavaScript: declare Accept: and Content-Type: in request
[
https://issues.apache.org/jira/browse/THRIFT-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14157111#comment-14157111
]
Jens Geyer commented on THRIFT-2674:
Randy brought this up on the mailing list today so I had a short look.
[WP|http://en.wikipedia.org/wiki/Internet_media_type#Suffix] references various
RFCs for the suffix theme, such as the [+json
suffix|http://tools.ietf.org/html/rfc6839#section-3.1] in RFC6839. However,
only {{+json}} is a defined suffix, neither binary nor compact nor anything
else we support today would fall into that category.
$0,02
> JavaScript: declare Accept: and Content-Type: in request
>
>
> Key: THRIFT-2674
> URL: https://issues.apache.org/jira/browse/THRIFT-2674
> Project: Thrift
> Issue Type: Bug
> Components: JavaScript - Library
>Reporter: Stig Bakken
>Priority: Minor
> Attachments: js-type.diff
>
>
> When a JS client communicates with a backend supporting several encodings,
> knowing which protocol to use is a bit kludgy. This patch tries to fix that
> by always setting the Accept: and Content-Type: request headers to
> "application/json".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2674) JavaScript: declare Accept: and Content-Type: in request
[ https://issues.apache.org/jira/browse/THRIFT-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14157259#comment-14157259 ] Jens Geyer commented on THRIFT-2674: Not sure if I brought my point across properly: I would happily support the suffix, if asked. They exist for a reason. Even more, if such a simple action like picking the right MIME type suffix enables us to gain advantages like those you mentioned above. > JavaScript: declare Accept: and Content-Type: in request > > > Key: THRIFT-2674 > URL: https://issues.apache.org/jira/browse/THRIFT-2674 > Project: Thrift > Issue Type: Bug > Components: JavaScript - Library >Reporter: Stig Bakken >Priority: Minor > Attachments: js-type.diff > > > When a JS client communicates with a backend supporting several encodings, > knowing which protocol to use is a bit kludgy. This patch tries to fix that > by always setting the Accept: and Content-Type: request headers to > "application/json". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (THRIFT-2674) JavaScript: declare Accept: and Content-Type: in request
[ https://issues.apache.org/jira/browse/THRIFT-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14157259#comment-14157259 ] Jens Geyer edited comment on THRIFT-2674 at 10/2/14 9:55 PM: - Not sure if I brought my point across properly: I would happily support the suffix, if asked. They exist for a reason. Even more, if such a simple action like picking the right MIME type suffix enables us to gain advantages like those you mentioned above. On the other hand I am not so much involved in that matter that I have developed strong opinions about it, so just $0,02 was (Author: jensg): Not sure if I brought my point across properly: I would happily support the suffix, if asked. They exist for a reason. Even more, if such a simple action like picking the right MIME type suffix enables us to gain advantages like those you mentioned above. > JavaScript: declare Accept: and Content-Type: in request > > > Key: THRIFT-2674 > URL: https://issues.apache.org/jira/browse/THRIFT-2674 > Project: Thrift > Issue Type: Bug > Components: JavaScript - Library >Reporter: Stig Bakken >Priority: Minor > Attachments: js-type.diff > > > When a JS client communicates with a backend supporting several encodings, > knowing which protocol to use is a bit kludgy. This patch tries to fix that > by always setting the Accept: and Content-Type: request headers to > "application/json". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2725) General coding standards
[ https://issues.apache.org/jira/browse/THRIFT-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14158169#comment-14158169 ] Jens Geyer commented on THRIFT-2725: Assumed, I do some whitespace cleanup. Do I have to add a JIRA for that? I mean, nobody ever added a JIRA ticket for maintaining .gitignore, so probably not, since it is not a content change. Opinions? > General coding standards > > > Key: THRIFT-2725 > URL: https://issues.apache.org/jira/browse/THRIFT-2725 > Project: Thrift > Issue Type: Sub-task >Reporter: Konrad Grochowski > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-2768) Whitespace fixups
Jens Geyer created THRIFT-2768: -- Summary: Whitespace fixups Key: THRIFT-2768 URL: https://issues.apache.org/jira/browse/THRIFT-2768 Project: Thrift Issue Type: Improvement Components: C# - Library, Delphi - Library Affects Versions: 0.9.2 Reporter: Jens Geyer Assignee: Jens Geyer Priority: Trivial Fix For: 0.9.2 Of course I had to make some content changes. The C# patch file is 354 KB, a lot of files are considered completely replaced. The Delphi patch file has "only" 282 KB. The "content" changes are (1) one indentation alignment in a batch file, and (2) one missing ASF header in a .cs file which I added. Anything else is just TABS, SPACEs and CRs. I'm going to commit that. For the records, here are the patch files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2768) Whitespace fixups
[ https://issues.apache.org/jira/browse/THRIFT-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2768: --- Issue Type: Sub-task (was: Improvement) Parent: THRIFT-2724 > Whitespace fixups > - > > Key: THRIFT-2768 > URL: https://issues.apache.org/jira/browse/THRIFT-2768 > Project: Thrift > Issue Type: Sub-task > Components: C# - Library, Delphi - Library >Affects Versions: 0.9.2 >Reporter: Jens Geyer >Assignee: Jens Geyer >Priority: Trivial > Fix For: 0.9.2 > > > Of course I had to make some content changes. The C# patch file is 354 KB, a > lot of files are considered completely replaced. The Delphi patch file has > "only" 282 KB. > The "content" changes are > (1) one indentation alignment in a batch file, and > (2) one missing ASF header in a .cs file which I added. > Anything else is just TABS, SPACEs and CRs. I'm going to commit that. For the > records, here are the patch files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2768) Whitespace fixups
[ https://issues.apache.org/jira/browse/THRIFT-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2768: --- Attachment: THRIFT-2768_Delphi-Whitespace-Fixup.patch THRIFT-2768_C#-Whitespace-Fixup.patch > Whitespace fixups > - > > Key: THRIFT-2768 > URL: https://issues.apache.org/jira/browse/THRIFT-2768 > Project: Thrift > Issue Type: Sub-task > Components: C# - Library, Delphi - Library >Affects Versions: 0.9.2 >Reporter: Jens Geyer >Assignee: Jens Geyer >Priority: Trivial > Fix For: 0.9.2 > > Attachments: THRIFT-2768_C#-Whitespace-Fixup.patch, > THRIFT-2768_Delphi-Whitespace-Fixup.patch > > > Of course I had to make some content changes. The C# patch file is 354 KB, a > lot of files are considered completely replaced. The Delphi patch file has > "only" 282 KB. > The "content" changes are > (1) one indentation alignment in a batch file, and > (2) one missing ASF header in a .cs file which I added. > Anything else is just TABS, SPACEs and CRs. I'm going to commit that. For the > records, here are the patch files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2768) Whitespace fixups
[ https://issues.apache.org/jira/browse/THRIFT-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-2768. -- Resolution: Fixed Committed. > Whitespace fixups > - > > Key: THRIFT-2768 > URL: https://issues.apache.org/jira/browse/THRIFT-2768 > Project: Thrift > Issue Type: Sub-task > Components: C# - Library, Delphi - Library >Affects Versions: 0.9.2 >Reporter: Jens Geyer >Assignee: Jens Geyer >Priority: Trivial > Fix For: 0.9.2 > > Attachments: THRIFT-2768_C#-Whitespace-Fixup.patch, > THRIFT-2768_Delphi-Whitespace-Fixup.patch > > > Of course I had to make some content changes. The C# patch file is 354 KB, a > lot of files are considered completely replaced. The Delphi patch file has > "only" 282 KB. > The "content" changes are > (1) one indentation alignment in a batch file, and > (2) one missing ASF header in a .cs file which I added. > Anything else is just TABS, SPACEs and CRs. I'm going to commit that. For the > records, here are the patch files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2717) C++11 generator
[
https://issues.apache.org/jira/browse/THRIFT-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14161613#comment-14161613
]
Jens Geyer commented on THRIFT-2717:
{quote}
Another idea:
current - renamed to c++98
new - just c++
--gen cpp option kept as an alias to --gen c++98 but will issue warning and be
removed in some unspecified future and will not be listed in help as available
{quote}
+1
We should test however on Windows before, the {{++}} signs are not strictly
illegal in folder names, but smell very much like problems lurking.
{quote}
The avoid confused users: add this information to lib/cpp/README.md and
lib/c++/README.md
{quote}
[If you have to explain it, it is bad
design|http://www.amazon.com/The-Design-Everyday-Things-Expanded/dp/0465050654].
Furthermore, 80% [will not read the
README|http://www.joelonsoftware.com/uibook/chapters/fog62.html] and
complain anyway. Having it documented is still a good idea, I just would not
rely on it too much.
> C++11 generator
> ---
>
> Key: THRIFT-2717
> URL: https://issues.apache.org/jira/browse/THRIFT-2717
> Project: Thrift
> Issue Type: New Feature
> Components: C++ - Compiler
>Reporter: Konrad Grochowski
>
> instead of adding another set of options to 'old' cpp generator I've started
> creating new one in:
> https://github.com/hcorg/thrift/tree/cpp11_generator
> using old as an reference
> main goals:
> * code compatible with old librart (at least for first tests, new lib and
> compiler switches can be added later)
> * no more ugly {{__isset}} structure -> boost::optional for optional values
> * as a result - no more {{__}} in names, which violates C++ standard
> * all generation code will have own unit tests (TDD used wherever possible)
> * generated types headers independent from Thrift header, to allow other
> layers of application using generated types without dependency leaks
> * each type will generate own header/cpp file - easier for user to include
> only used parts.
> * unordered map/sets
> * returning using move semantics, no more ugly 'return via output parameter'
> (still possible as option thou - sometimes it's needed for performance)
> * async client using boost::future
> * enum classes
> * initializer lists for constants (maybe)
> I'm aiming in C++11 subset available in gcc 4.8 and MSVC 2013
> currently I have only complete enum generation, but work is in progress
> all comments etc are very welcome :)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-2689) struct names that differ only in capitalization of first character generate broken erlang code
[
https://issues.apache.org/jira/browse/THRIFT-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-2689.
Resolution: Fixed
Just committed the last patch - thanks Alisdair!
> struct names that differ only in capitalization of first character generate
> broken erlang code
> --
>
> Key: THRIFT-2689
> URL: https://issues.apache.org/jira/browse/THRIFT-2689
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Compiler, Erlang - Library
>Reporter: alisdair sullivan
>Assignee: alisdair sullivan
>Priority: Minor
> Fix For: 0.9.2
>
>
> the following thrift specification generates broken erlang code:
> struct invalid { /* contents of struct are irrelevent */ }
> struct Invalid { /* still irrelevent }
> the compiler currently renames any struct that starts with a capital so that
> it starts with a lowercase letter. instead, it should leave names intact and
> use proper erlang syntax in generation. the attached patch does exactly that
> this does break backwards compatibility
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-2769) D: std.traits.pointerTarget is deprecated
[ https://issues.apache.org/jira/browse/THRIFT-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2769. Resolution: Fixed Committed. > D: std.traits.pointerTarget is deprecated > - > > Key: THRIFT-2769 > URL: https://issues.apache.org/jira/browse/THRIFT-2769 > Project: Thrift > Issue Type: Bug > Components: D - Library >Reporter: David Nadlinger >Priority: Minor > > std.traits.pointerTarget has been renamed to PointerTarget. Right now, the D > library still builds, but emits deprecation warnings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2769) D: std.traits.pointerTarget is deprecated
[ https://issues.apache.org/jira/browse/THRIFT-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2769: --- Assignee: David Nadlinger > D: std.traits.pointerTarget is deprecated > - > > Key: THRIFT-2769 > URL: https://issues.apache.org/jira/browse/THRIFT-2769 > Project: Thrift > Issue Type: Bug > Components: D - Library >Reporter: David Nadlinger >Assignee: David Nadlinger >Priority: Minor > Fix For: 0.9.2 > > > std.traits.pointerTarget has been renamed to PointerTarget. Right now, the D > library still builds, but emits deprecation warnings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2769) D: std.traits.pointerTarget is deprecated
[ https://issues.apache.org/jira/browse/THRIFT-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2769: --- Fix Version/s: 0.9.2 > D: std.traits.pointerTarget is deprecated > - > > Key: THRIFT-2769 > URL: https://issues.apache.org/jira/browse/THRIFT-2769 > Project: Thrift > Issue Type: Bug > Components: D - Library >Reporter: David Nadlinger >Priority: Minor > Fix For: 0.9.2 > > > std.traits.pointerTarget has been renamed to PointerTarget. Right now, the D > library still builds, but emits deprecation warnings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2770) D: thrift.internal.traits unittest fails due to std.metastrings import
[ https://issues.apache.org/jira/browse/THRIFT-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2770. Resolution: Fixed Fix Version/s: 0.9.2 Assignee: David Nadlinger Committed. > D: thrift.internal.traits unittest fails due to std.metastrings import > -- > > Key: THRIFT-2770 > URL: https://issues.apache.org/jira/browse/THRIFT-2770 > Project: Thrift > Issue Type: Bug > Components: D - Library >Reporter: David Nadlinger >Assignee: David Nadlinger >Priority: Minor > Fix For: 0.9.2 > > > There is an unused import for std.metastrings in the thrift.internal.traits > unit tests. The module has been deprecated for ages and was recently removed. > Thus, the unit test build is currently broken. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-2775) static assert fails in src/thrift/internal/ctfe.d
Jens Geyer created THRIFT-2775:
--
Summary: static assert fails in src/thrift/internal/ctfe.d
Key: THRIFT-2775
URL: https://issues.apache.org/jira/browse/THRIFT-2775
Project: Thrift
Issue Type: Bug
Components: D - Library
Affects Versions: 0.9.2
Environment: openSUSE 13.1 (i586)
DMD Compiler v2.066.0
german locale
Reporter: Jens Geyer
make check in d/lib fails with
{code}
src/thrift/internal/ctfe.d(94): Error: static assert (ctfeToString(3.1415) ==
"3.1415") is false
{code}
because ctfeToString(3.1415) evaluates to "3.141499"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-2779) PHP TJSONProtocol encode unicode into UCS-4LE which can't be parsed by other langurage bindings
[ https://issues.apache.org/jira/browse/THRIFT-2779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2779: --- Issue Type: Sub-task (was: Improvement) Parent: THRIFT-2336 > PHP TJSONProtocol encode unicode into UCS-4LE which can't be parsed by other > langurage bindings > --- > > Key: THRIFT-2779 > URL: https://issues.apache.org/jira/browse/THRIFT-2779 > Project: Thrift > Issue Type: Sub-task > Components: PHP - Library >Reporter: He Liangliang >Priority: Critical > > TJSONProtocol serialize string using json_encode which convert unicode > character into UCS-4LE format, which can't be accepted by other language > bindings, e.g. Java library. The simplest way to fix it is change UCS-4LE > encoding to UTF8 encoding. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (THRIFT-2779) PHP TJSONProtocol encode unicode into UCS-4LE which can't be parsed by other langurage bindings
[ https://issues.apache.org/jira/browse/THRIFT-2779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-2779: -- Assignee: Jens Geyer > PHP TJSONProtocol encode unicode into UCS-4LE which can't be parsed by other > langurage bindings > --- > > Key: THRIFT-2779 > URL: https://issues.apache.org/jira/browse/THRIFT-2779 > Project: Thrift > Issue Type: Sub-task > Components: PHP - Library >Reporter: He Liangliang >Assignee: Jens Geyer >Priority: Critical > > TJSONProtocol serialize string using json_encode which convert unicode > character into UCS-4LE format, which can't be accepted by other language > bindings, e.g. Java library. The simplest way to fix it is change UCS-4LE > encoding to UTF8 encoding. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (THRIFT-2644) Haxe support
[ https://issues.apache.org/jira/browse/THRIFT-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14165155#comment-14165155 ] Jens Geyer edited comment on THRIFT-2644 at 10/9/14 2:08 PM: - Hi, thanks for the patch file. I have both patches already merged and ready for commit on my disk, i'm just waitin' for the 0.9.2 release. I will commit both as soon as the 0.9.2 release is history. Re Neko: To be honest, I did most of the tests with C++ only, on Windows and openSUSE. i'm sure there will be other problems with other targets - that's still work to be done (and a reason why I think it's not yet ready for 0.9.2). All of these issues along with some missing features (e.g. multiplex) will get solved with the forthcoming patches, at least that' what the plans are. Of course, support (e.g. testing) is always welcome. I try to keep my GitHub branch always at the most current state regarding both my work and the Thrift master branch. PS: Are you using Haxe 3.1.3 or any older version? The 3.1.3 is not in all Linux repos, you have to install the downloads from the home page. was (Author: jensg): Hi, thanks for the patch file. I have both patches already merged and ready for commit on my disk, i'm just waitin' for the 0.9.2 release. I will commit both as soon as the 0.9.2 release is history. Re Neko: To be honest, I did most of the tests with C++ only, on Windows and openSUSE. i'm sure there will be other problems with other targets - that's still work to be done (and a reason why I think it's not yet ready for 0.9.2). All of these issues along with some missing features (e.g. multiplex) will get solved with the forthcoming patches, at least that' what the plans are. Of course, support (e.g. testing) is always welcome. I try to keep my GitHub branch always at the most current state regarding both my work and the Thrift master branch. > Haxe support > > > Key: THRIFT-2644 > URL: https://issues.apache.org/jira/browse/THRIFT-2644 > Project: Thrift > Issue Type: Improvement > Components: Haxe - Compiler, Haxe - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 1.0 > > Attachments: THRIFT-2644_haxe.patch > > > I'm currently about to prepare a patch to include [Haxe|http://haxe.org/] > support into Thrift over there in my [GitHub Thrift > fork|https://github.com/Jens-G/thrift/tree/haxe]. If anyone has an interest > in this and wants to join for development, testing and/or review, you're > welcome - just drop me a mail. I'll update this ticket accordingly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2644) Haxe support
[ https://issues.apache.org/jira/browse/THRIFT-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14165155#comment-14165155 ] Jens Geyer commented on THRIFT-2644: Hi, thanks for the patch file. I have both patches already merged and ready for commit on my disk, i'm just waitin' for the 0.9.2 release. I will commit both as soon as the 0.9.2 release is history. Re Neko: To be honest, I did most of the tests with C++ only, on Windows and openSUSE. i'm sure there will be other problems with other targets - that's still work to be done (and a reason why I think it's not yet ready for 0.9.2). All of these issues along with some missing features (e.g. multiplex) will get solved with the forthcoming patches, at least that' what the plans are. Of course, support (e.g. testing) is always welcome. I try to keep my GitHub branch always at the most current state regarding both my work and the Thrift master branch. > Haxe support > > > Key: THRIFT-2644 > URL: https://issues.apache.org/jira/browse/THRIFT-2644 > Project: Thrift > Issue Type: Improvement > Components: Haxe - Compiler, Haxe - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 1.0 > > Attachments: THRIFT-2644_haxe.patch > > > I'm currently about to prepare a patch to include [Haxe|http://haxe.org/] > support into Thrift over there in my [GitHub Thrift > fork|https://github.com/Jens-G/thrift/tree/haxe]. If anyone has an interest > in this and wants to join for development, testing and/or review, you're > welcome - just drop me a mail. I'll update this ticket accordingly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (THRIFT-2644) Haxe support
[ https://issues.apache.org/jira/browse/THRIFT-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14165155#comment-14165155 ] Jens Geyer edited comment on THRIFT-2644 at 10/9/14 2:09 PM: - Hi, thanks for the patch file. I have both patches already merged and ready for commit on my disk, i'm just waitin' for the 0.9.2 release. I will commit both as soon as the 0.9.2 release is history. Re Neko: To be honest, I did most of the tests with C++ only, on Windows and openSUSE. i'm sure there will be other problems with other targets - that's still work to be done (and a reason why I think it's not yet ready for 0.9.2). All of these issues along with some missing features (e.g. multiplex) will get solved with the forthcoming patches, at least that' what the plans are. Of course, support (e.g. testing) is always welcome. I try to keep my GitHub branch always at the most current state regarding both my work and the Thrift master branch. -PS: Are you using Haxe 3.1.3 or any older version? The 3.1.3 is not in all Linux repos, you have to install the downloads from the home page- Sorry didn't see the 3.2.0 remark. was (Author: jensg): Hi, thanks for the patch file. I have both patches already merged and ready for commit on my disk, i'm just waitin' for the 0.9.2 release. I will commit both as soon as the 0.9.2 release is history. Re Neko: To be honest, I did most of the tests with C++ only, on Windows and openSUSE. i'm sure there will be other problems with other targets - that's still work to be done (and a reason why I think it's not yet ready for 0.9.2). All of these issues along with some missing features (e.g. multiplex) will get solved with the forthcoming patches, at least that' what the plans are. Of course, support (e.g. testing) is always welcome. I try to keep my GitHub branch always at the most current state regarding both my work and the Thrift master branch. PS: Are you using Haxe 3.1.3 or any older version? The 3.1.3 is not in all Linux repos, you have to install the downloads from the home page. > Haxe support > > > Key: THRIFT-2644 > URL: https://issues.apache.org/jira/browse/THRIFT-2644 > Project: Thrift > Issue Type: Improvement > Components: Haxe - Compiler, Haxe - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 1.0 > > Attachments: THRIFT-2644_haxe.patch > > > I'm currently about to prepare a patch to include [Haxe|http://haxe.org/] > support into Thrift over there in my [GitHub Thrift > fork|https://github.com/Jens-G/thrift/tree/haxe]. If anyone has an interest > in this and wants to join for development, testing and/or review, you're > welcome - just drop me a mail. I'll update this ticket accordingly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2644) Haxe support
[ https://issues.apache.org/jira/browse/THRIFT-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14165160#comment-14165160 ] Jens Geyer commented on THRIFT-2644: I look at the issue this evening. > Haxe support > > > Key: THRIFT-2644 > URL: https://issues.apache.org/jira/browse/THRIFT-2644 > Project: Thrift > Issue Type: Improvement > Components: Haxe - Compiler, Haxe - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 1.0 > > Attachments: THRIFT-2644_haxe.patch > > > I'm currently about to prepare a patch to include [Haxe|http://haxe.org/] > support into Thrift over there in my [GitHub Thrift > fork|https://github.com/Jens-G/thrift/tree/haxe]. If anyone has an interest > in this and wants to join for development, testing and/or review, you're > welcome - just drop me a mail. I'll update this ticket accordingly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2775) static assert fails in src/thrift/internal/ctfe.d
[
https://issues.apache.org/jira/browse/THRIFT-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14165539#comment-14165539
]
Jens Geyer commented on THRIFT-2775:
Thanks for the patch. The big question is, however, what is the intention of
that test? Is it ok to patch it that way, or should the function being tested
be modified?
> static assert fails in src/thrift/internal/ctfe.d
> -
>
> Key: THRIFT-2775
> URL: https://issues.apache.org/jira/browse/THRIFT-2775
> Project: Thrift
> Issue Type: Bug
> Components: D - Library
>Affects Versions: 0.9.2
> Environment: openSUSE 13.1 (i586)
> DMD Compiler v2.066.0
> german locale
>Reporter: Jens Geyer
> Attachments: THRIFT-2775_ctfe_assert_fail.patch
>
>
> make check in d/lib fails with
> {code}
> src/thrift/internal/ctfe.d(94): Error: static assert (ctfeToString(3.1415)
> == "3.1415") is false
> {code}
> because ctfeToString(3.1415) evaluates to "3.141499"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-2775) static assert fails in src/thrift/internal/ctfe.d
[
https://issues.apache.org/jira/browse/THRIFT-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-2775.
Resolution: Fixed
Fix Version/s: 0.9.2
Assignee: Jens Geyer
Committed Konrad's patch. At least it solves the actual issue.
> static assert fails in src/thrift/internal/ctfe.d
> -
>
> Key: THRIFT-2775
> URL: https://issues.apache.org/jira/browse/THRIFT-2775
> Project: Thrift
> Issue Type: Bug
> Components: D - Library
>Affects Versions: 0.9.2
> Environment: openSUSE 13.1 (i586)
> DMD Compiler v2.066.0
> german locale
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Fix For: 0.9.2
>
> Attachments: THRIFT-2775_ctfe_assert_fail.patch
>
>
> make check in d/lib fails with
> {code}
> src/thrift/internal/ctfe.d(94): Error: static assert (ctfeToString(3.1415)
> == "3.1415") is false
> {code}
> because ctfeToString(3.1415) evaluates to "3.141499"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (THRIFT-2644) Haxe support
[
https://issues.apache.org/jira/browse/THRIFT-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14165712#comment-14165712
]
Jens Geyer edited comment on THRIFT-2644 at 10/9/14 8:45 PM:
-
According to [this IRC log|http://echelog.com/logs/browse/haxe/1408485600] you
need a compatible hxcpp version.
{quote}
I'm getting a following error with the Cpp target "Error: In file included
from ./src/__boot__.cpp:4:0: include/haxe/Log.h:27:3: error: ?HX_DO_RTTI_ALL?
does not name a type HX_DO_RTTI_ALL;"
Any ideas?
I've seen that before, I think it comes from using an incompatible hxcpp
version.
What does {{haxe -version}} give?
*3.2.0*
*You need hxcpp git then*.
Try {{haxelib git hxcpp http://github.com/HaxeFoundation/hxcpp}}
{quote}
was (Author: jensg):
According to [this IRC log|http://echelog.com/logs/browse/haxe/1408485600] you
need a compatible hxcpp version.
{quote}
\[10:01:46\] I'm getting a following error with the Cpp target
"Error: In file included from ./src/__boot__.cpp:4:0: include/haxe/Log.h:27:3:
error: ?HX_DO_RTTI_ALL? does not name a type HX_DO_RTTI_ALL;"
\[10:01:55\] Any ideas?
\[10:04:29\] I've seen that before, I think it comes from using an
incompatible hxcpp version.
\[10:04:54\] What does {{haxe -version}} give?
\[10:06:01\] *3.2.0*
\[10:06:16\] *You need hxcpp git then*.
\[10:06:24\] Ah. Thanks.
\[10:06:30\] Try {{haxelib git hxcpp
http://github.com/HaxeFoundation/hxcpp}}
{quote}
> Haxe support
>
>
> Key: THRIFT-2644
> URL: https://issues.apache.org/jira/browse/THRIFT-2644
> Project: Thrift
> Issue Type: Improvement
> Components: Haxe - Compiler, Haxe - Library
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Fix For: 1.0
>
> Attachments: THRIFT-2644_haxe.patch
>
>
> I'm currently about to prepare a patch to include [Haxe|http://haxe.org/]
> support into Thrift over there in my [GitHub Thrift
> fork|https://github.com/Jens-G/thrift/tree/haxe]. If anyone has an interest
> in this and wants to join for development, testing and/or review, you're
> welcome - just drop me a mail. I'll update this ticket accordingly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2644) Haxe support
[
https://issues.apache.org/jira/browse/THRIFT-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14165712#comment-14165712
]
Jens Geyer commented on THRIFT-2644:
According to [this IRC log|http://echelog.com/logs/browse/haxe/1408485600] you
need a compatible hxcpp version.
{quote}
\[10:01:46\] I'm getting a following error with the Cpp target
"Error: In file included from ./src/__boot__.cpp:4:0: include/haxe/Log.h:27:3:
error: ?HX_DO_RTTI_ALL? does not name a type HX_DO_RTTI_ALL;"
\[10:01:55\] Any ideas?
\[10:04:29\] I've seen that before, I think it comes from using an
incompatible hxcpp version.
\[10:04:54\] What does {{haxe -version}} give?
\[10:06:01\] *3.2.0*
\[10:06:16\] *You need hxcpp git then*.
\[10:06:24\] Ah. Thanks.
\[10:06:30\] Try {{haxelib git hxcpp
http://github.com/HaxeFoundation/hxcpp}}
{quote}
> Haxe support
>
>
> Key: THRIFT-2644
> URL: https://issues.apache.org/jira/browse/THRIFT-2644
> Project: Thrift
> Issue Type: Improvement
> Components: Haxe - Compiler, Haxe - Library
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Fix For: 1.0
>
> Attachments: THRIFT-2644_haxe.patch
>
>
> I'm currently about to prepare a patch to include [Haxe|http://haxe.org/]
> support into Thrift over there in my [GitHub Thrift
> fork|https://github.com/Jens-G/thrift/tree/haxe]. If anyone has an interest
> in this and wants to join for development, testing and/or review, you're
> welcome - just drop me a mail. I'll update this ticket accordingly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (THRIFT-2781) D compiler stuck at idlgen due to compiler bug
Jens Geyer created THRIFT-2781: -- Summary: D compiler stuck at idlgen due to compiler bug Key: THRIFT-2781 URL: https://issues.apache.org/jira/browse/THRIFT-2781 Project: Thrift Issue Type: Bug Components: D - Library Reporter: Jens Geyer Assignee: Jens Geyer Fix For: 0.9.2 The latest build of DMD leads to the effect, that idlgen will not get compiled. The compiler get stuck at nearly 100% CPU. The problem has been confirmed by [~klickverbot] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2776) D tests failing
[
https://issues.apache.org/jira/browse/THRIFT-2776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-2776:
---
Attachment: THRIFT-2776-D-tests-failing.patch
> D tests failing
>
>
> Key: THRIFT-2776
> URL: https://issues.apache.org/jira/browse/THRIFT-2776
> Project: Thrift
> Issue Type: Bug
> Components: D - Library
>Affects Versions: 0.9.2
>Reporter: Jake Farrell
>Assignee: David Nadlinger
> Fix For: 0.9.2
>
> Attachments: THRIFT-2776-D-tests-failing.patch
>
>
> 1 of the 88 D lib tests are failing when testing in the contrib/Vagrantfile
> (ubuntu 14.04 using dmd version 2.065.0-0 with the following error
> ping [~jensg], [~klickverbot]
> {code}
> object.Exception@src/thrift/internal/resource_pool.d(349): Enforcement failed
>
> ./unittest/debug/thrift/internal/resource_pool(pure @safe bool
> std.exception.enforce!(bool).enforce(bool, lazy const(char)[],
> immutable(char)[], ulong)+0x6b) [0x48a36b]
> ./unittest/debug/thrift/internal/resource_pool(void
> thrift.internal.resource_pool.__unittestL285_1()+0x7c6) [0x483e06]
> ./unittest/debug/thrift/internal/resource_pool(void
> thrift.internal.resource_pool.__modtest()+0x9) [0x49c071]
> ./unittest/debug/thrift/internal/resource_pool(int
> core.runtime.runModuleUnitTests().__foreachbody3(ref
> object.ModuleInfo*)+0x30) [0x4b9cb0]
> ./unittest/debug/thrift/internal/resource_pool(int
> rt.minfo.moduleinfos_apply(scope int delegate(ref
> object.ModuleInfo*)).__foreachbody2(ref rt.sections_linux.DSO)+0x4c)
> [0x4a67ec]
> ./unittest/debug/thrift/internal/resource_pool(int
> rt.sections_linux.DSO.opApply(scope int delegate(ref
> rt.sections_linux.DSO))+0x42) [0x4a6862]
> ./unittest/debug/thrift/internal/resource_pool(int
> rt.minfo.moduleinfos_apply(scope int delegate(ref object.ModuleInfo*))+0x25)
> [0x4a6785]
> ./unittest/debug/thrift/internal/resource_pool(runModuleUnitTests+0xae)
> [0x4b9b46]
> ./unittest/debug/thrift/internal/resource_pool(void
> rt.dmain2._d_run_main(int, char**, extern (C) int
> function(char[][])*).runAll()+0x17) [0x4a397f]
> ./unittest/debug/thrift/internal/resource_pool(void
> rt.dmain2._d_run_main(int, char**, extern (C) int
> function(char[][])*).tryExec(scope void delegate())+0x2a) [0x4a3932]
> ./unittest/debug/thrift/internal/resource_pool(_d_run_main+0x1a3) [0x4a38b3]
> ./unittest/debug/thrift/internal/resource_pool(main+0x25) [0x49c10d]
> /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5) [0x2b599d472ec5]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-2781) D compiler stuck at idlgen due to compiler bug
[ https://issues.apache.org/jira/browse/THRIFT-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2781: --- Attachment: THRIFT-2781-D-compiler-stuck-at-idlgen-due-to-compil.patch > D compiler stuck at idlgen due to compiler bug > -- > > Key: THRIFT-2781 > URL: https://issues.apache.org/jira/browse/THRIFT-2781 > Project: Thrift > Issue Type: Bug > Components: D - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.9.2 > > Attachments: > THRIFT-2781-D-compiler-stuck-at-idlgen-due-to-compil.patch > > > The latest build of DMD leads to the effect, that idlgen will not get > compiled. The compiler get stuck at nearly 100% CPU. The problem has been > confirmed by [~klickverbot] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2781) D compiler stuck at idlgen due to compiler bug
[ https://issues.apache.org/jira/browse/THRIFT-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2781. Resolution: Fixed Committed. > D compiler stuck at idlgen due to compiler bug > -- > > Key: THRIFT-2781 > URL: https://issues.apache.org/jira/browse/THRIFT-2781 > Project: Thrift > Issue Type: Bug > Components: D - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.9.2 > > Attachments: > THRIFT-2781-D-compiler-stuck-at-idlgen-due-to-compil.patch > > > The latest build of DMD leads to the effect, that idlgen will not get > compiled. The compiler get stuck at nearly 100% CPU. The problem has been > confirmed by [~klickverbot] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2776) D tests failing
[
https://issues.apache.org/jira/browse/THRIFT-2776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-2776.
Resolution: Fixed
Committed.
> D tests failing
>
>
> Key: THRIFT-2776
> URL: https://issues.apache.org/jira/browse/THRIFT-2776
> Project: Thrift
> Issue Type: Bug
> Components: D - Library
>Affects Versions: 0.9.2
>Reporter: Jake Farrell
>Assignee: David Nadlinger
> Fix For: 0.9.2
>
> Attachments: THRIFT-2776-D-tests-failing.patch
>
>
> 1 of the 88 D lib tests are failing when testing in the contrib/Vagrantfile
> (ubuntu 14.04 using dmd version 2.065.0-0 with the following error
> ping [~jensg], [~klickverbot]
> {code}
> object.Exception@src/thrift/internal/resource_pool.d(349): Enforcement failed
>
> ./unittest/debug/thrift/internal/resource_pool(pure @safe bool
> std.exception.enforce!(bool).enforce(bool, lazy const(char)[],
> immutable(char)[], ulong)+0x6b) [0x48a36b]
> ./unittest/debug/thrift/internal/resource_pool(void
> thrift.internal.resource_pool.__unittestL285_1()+0x7c6) [0x483e06]
> ./unittest/debug/thrift/internal/resource_pool(void
> thrift.internal.resource_pool.__modtest()+0x9) [0x49c071]
> ./unittest/debug/thrift/internal/resource_pool(int
> core.runtime.runModuleUnitTests().__foreachbody3(ref
> object.ModuleInfo*)+0x30) [0x4b9cb0]
> ./unittest/debug/thrift/internal/resource_pool(int
> rt.minfo.moduleinfos_apply(scope int delegate(ref
> object.ModuleInfo*)).__foreachbody2(ref rt.sections_linux.DSO)+0x4c)
> [0x4a67ec]
> ./unittest/debug/thrift/internal/resource_pool(int
> rt.sections_linux.DSO.opApply(scope int delegate(ref
> rt.sections_linux.DSO))+0x42) [0x4a6862]
> ./unittest/debug/thrift/internal/resource_pool(int
> rt.minfo.moduleinfos_apply(scope int delegate(ref object.ModuleInfo*))+0x25)
> [0x4a6785]
> ./unittest/debug/thrift/internal/resource_pool(runModuleUnitTests+0xae)
> [0x4b9b46]
> ./unittest/debug/thrift/internal/resource_pool(void
> rt.dmain2._d_run_main(int, char**, extern (C) int
> function(char[][])*).runAll()+0x17) [0x4a397f]
> ./unittest/debug/thrift/internal/resource_pool(void
> rt.dmain2._d_run_main(int, char**, extern (C) int
> function(char[][])*).tryExec(scope void delegate())+0x2a) [0x4a3932]
> ./unittest/debug/thrift/internal/resource_pool(_d_run_main+0x1a3) [0x4a38b3]
> ./unittest/debug/thrift/internal/resource_pool(main+0x25) [0x49c10d]
> /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5) [0x2b599d472ec5]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2776) D tests failing
[
https://issues.apache.org/jira/browse/THRIFT-2776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14167166#comment-14167166
]
Jens Geyer commented on THRIFT-2776:
Hi [~klickverbot],
please create a new ticket and link this one when you are going to submit a
pull request.
Thanks,
JensG
> D tests failing
>
>
> Key: THRIFT-2776
> URL: https://issues.apache.org/jira/browse/THRIFT-2776
> Project: Thrift
> Issue Type: Bug
> Components: D - Library
>Affects Versions: 0.9.2
>Reporter: Jake Farrell
>Assignee: David Nadlinger
> Fix For: 0.9.2
>
> Attachments: THRIFT-2776-D-tests-failing.patch
>
>
> 1 of the 88 D lib tests are failing when testing in the contrib/Vagrantfile
> (ubuntu 14.04 using dmd version 2.065.0-0 with the following error
> ping [~jensg], [~klickverbot]
> {code}
> object.Exception@src/thrift/internal/resource_pool.d(349): Enforcement failed
>
> ./unittest/debug/thrift/internal/resource_pool(pure @safe bool
> std.exception.enforce!(bool).enforce(bool, lazy const(char)[],
> immutable(char)[], ulong)+0x6b) [0x48a36b]
> ./unittest/debug/thrift/internal/resource_pool(void
> thrift.internal.resource_pool.__unittestL285_1()+0x7c6) [0x483e06]
> ./unittest/debug/thrift/internal/resource_pool(void
> thrift.internal.resource_pool.__modtest()+0x9) [0x49c071]
> ./unittest/debug/thrift/internal/resource_pool(int
> core.runtime.runModuleUnitTests().__foreachbody3(ref
> object.ModuleInfo*)+0x30) [0x4b9cb0]
> ./unittest/debug/thrift/internal/resource_pool(int
> rt.minfo.moduleinfos_apply(scope int delegate(ref
> object.ModuleInfo*)).__foreachbody2(ref rt.sections_linux.DSO)+0x4c)
> [0x4a67ec]
> ./unittest/debug/thrift/internal/resource_pool(int
> rt.sections_linux.DSO.opApply(scope int delegate(ref
> rt.sections_linux.DSO))+0x42) [0x4a6862]
> ./unittest/debug/thrift/internal/resource_pool(int
> rt.minfo.moduleinfos_apply(scope int delegate(ref object.ModuleInfo*))+0x25)
> [0x4a6785]
> ./unittest/debug/thrift/internal/resource_pool(runModuleUnitTests+0xae)
> [0x4b9b46]
> ./unittest/debug/thrift/internal/resource_pool(void
> rt.dmain2._d_run_main(int, char**, extern (C) int
> function(char[][])*).runAll()+0x17) [0x4a397f]
> ./unittest/debug/thrift/internal/resource_pool(void
> rt.dmain2._d_run_main(int, char**, extern (C) int
> function(char[][])*).tryExec(scope void delegate())+0x2a) [0x4a3932]
> ./unittest/debug/thrift/internal/resource_pool(_d_run_main+0x1a3) [0x4a38b3]
> ./unittest/debug/thrift/internal/resource_pool(main+0x25) [0x49c10d]
> /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5) [0x2b599d472ec5]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2781) D compiler stuck at idlgen due to compiler bug
[ https://issues.apache.org/jira/browse/THRIFT-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14167170#comment-14167170 ] Jens Geyer commented on THRIFT-2781: The idlgen feature is not strictly required for Thrift. So as a workaround, the patch simply removes it from the build run. > D compiler stuck at idlgen due to compiler bug > -- > > Key: THRIFT-2781 > URL: https://issues.apache.org/jira/browse/THRIFT-2781 > Project: Thrift > Issue Type: Bug > Components: D - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.9.2 > > Attachments: > THRIFT-2781-D-compiler-stuck-at-idlgen-due-to-compil.patch > > > The latest build of DMD leads to the effect, that idlgen will not get > compiled. The compiler get stuck at nearly 100% CPU. The problem has been > confirmed by [~klickverbot] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2782) D: Timing-insensitive unit tests for thrift.internal.resource_pool
[ https://issues.apache.org/jira/browse/THRIFT-2782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2782. Resolution: Fixed Fix Version/s: 0.9.2 Assignee: David Nadlinger Committed, thanks for the quick patch! @[~jfarrell], if that patch still doesn't do for you, feel free to revert to the previous state and reopen. I did not run into problems on my machine, but that was already true before :-) > D: Timing-insensitive unit tests for thrift.internal.resource_pool > -- > > Key: THRIFT-2782 > URL: https://issues.apache.org/jira/browse/THRIFT-2782 > Project: Thrift > Issue Type: Bug > Components: D - Library >Reporter: David Nadlinger >Assignee: David Nadlinger >Priority: Minor > Fix For: 0.9.2 > > > See https://issues.apache.org/jira/browse/THRIFT-2776. > Pull request incoming. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-2785) Wrap errors in iostream_transport.go
Jens Geyer created THRIFT-2785: -- Summary: Wrap errors in iostream_transport.go Key: THRIFT-2785 URL: https://issues.apache.org/jira/browse/THRIFT-2785 Project: Thrift Issue Type: Improvement Components: Go - Library Reporter: Jens Geyer Assignee: Jens Geyer Priority: Minor GitHub user cvlchinet opened a pull request: https://github.com/apache/thrift/pull/246 Wrap errors in iostream_transport.go When I used the StreamTransport to do unit tests I noticed that the EOF TTransportException is not correctly thrown. I quickly found out that the errors in iostream_transport.go where not wrapped with NewTTransportExceptionFromError. Fixed that quickly and it works greatly! Hope this saves others precious time when developing with thrift and go :-) You can merge this pull request into a Git repository by running: $ git pull https://github.com/cvlchinet/thrift master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/246.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #246 commit c00fa154faa337db47a07c2c49d13d51c487d77a Author: cvlchinet Date: 2014-10-11T22:57:23Z Wrap errors in iostream_transport.go Wrap errors in iostream_transport.go using NewTTransportExceptionFromError -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2785) Wrap errors in iostream_transport.go
[ https://issues.apache.org/jira/browse/THRIFT-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2785. Resolution: Fixed Fix Version/s: 0.9.2 Committed, thanks! > Wrap errors in iostream_transport.go > > > Key: THRIFT-2785 > URL: https://issues.apache.org/jira/browse/THRIFT-2785 > Project: Thrift > Issue Type: Improvement > Components: Go - Library >Reporter: Jens Geyer >Assignee: Jens Geyer >Priority: Minor > Fix For: 0.9.2 > > > GitHub user cvlchinet opened a pull request: > https://github.com/apache/thrift/pull/246 > Wrap errors in iostream_transport.go > When I used the StreamTransport to do unit tests I noticed that the EOF > TTransportException is not correctly thrown. I quickly found out that the > errors in iostream_transport.go where not wrapped with > NewTTransportExceptionFromError. Fixed that quickly and it works greatly! > > Hope this saves others precious time when developing with thrift and go > :-) > You can merge this pull request into a Git repository by running: > $ git pull https://github.com/cvlchinet/thrift master > Alternatively you can review and apply these changes as the patch at: > https://github.com/apache/thrift/pull/246.patch > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > This closes #246 > > > commit c00fa154faa337db47a07c2c49d13d51c487d77a > Author: cvlchinet > Date: 2014-10-11T22:57:23Z > Wrap errors in iostream_transport.go > > Wrap errors in iostream_transport.go using NewTTransportExceptionFromError > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2786) Cpp Tutorial: Make TThreadPoolServer / TThreadedServer a bit easier to use
[ https://issues.apache.org/jira/browse/THRIFT-2786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2786. Resolution: Fixed Fix Version/s: 0.9.2 Assignee: Jens Geyer Committed, thanks! > Cpp Tutorial: Make TThreadPoolServer / TThreadedServer a bit easier to use > -- > > Key: THRIFT-2786 > URL: https://issues.apache.org/jira/browse/THRIFT-2786 > Project: Thrift > Issue Type: Improvement > Components: Tutorial >Reporter: Brian Brooks >Assignee: Jens Geyer >Priority: Trivial > Fix For: 0.9.2 > > Attachments: thrift-2786.patch > > > Add a little code to make the other servers easier to uncomment & use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2784) Eliminate compiler warnings in generated C++ code
[ https://issues.apache.org/jira/browse/THRIFT-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172334#comment-14172334 ] Jens Geyer commented on THRIFT-2784: That enum is an edge case. The IDL allows it syntactically, but some envorinments have problems with it. I agree with removel, but we should keep that in mind and probably fix it later (read. disallow empty enums) > Eliminate compiler warnings in generated C++ code > - > > Key: THRIFT-2784 > URL: https://issues.apache.org/jira/browse/THRIFT-2784 > Project: Thrift > Issue Type: Improvement > Components: C++ - Compiler >Affects Versions: 0.9.1 >Reporter: John Campbell >Assignee: Roger Meier >Priority: Minor > Attachments: thrift-2784-eliminate_generated_cpp_warnings.patch > > > Generated C++ classes generate compiler warnings when the using code is > compiled with -Wall -Wextra -pedantic. > Specifically, there are two types of warnings in the generated code: > 1. Exceptions don't call parent constructor > 2. Unused warnings > (there may be others in the generated code, however no others have been found > at this time) > Ideally, the generated C++ code should not have these errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (THRIFT-2784) Eliminate compiler warnings in generated C++ code
[ https://issues.apache.org/jira/browse/THRIFT-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172334#comment-14172334 ] Jens Geyer edited comment on THRIFT-2784 at 10/15/14 1:01 PM: -- That enum is an edge case. The IDL allows it syntactically, but some environments have problems with empty enus. I agree with removal, but we should keep that in mind and probably fix it later (read. disallow empty enums) was (Author: jensg): That enum is an edge case. The IDL allows it syntactically, but some envorinments have problems with it. I agree with removel, but we should keep that in mind and probably fix it later (read. disallow empty enums) > Eliminate compiler warnings in generated C++ code > - > > Key: THRIFT-2784 > URL: https://issues.apache.org/jira/browse/THRIFT-2784 > Project: Thrift > Issue Type: Improvement > Components: C++ - Compiler >Affects Versions: 0.9.1 >Reporter: John Campbell >Assignee: Roger Meier >Priority: Minor > Attachments: thrift-2784-eliminate_generated_cpp_warnings.patch > > > Generated C++ classes generate compiler warnings when the using code is > compiled with -Wall -Wextra -pedantic. > Specifically, there are two types of warnings in the generated code: > 1. Exceptions don't call parent constructor > 2. Unused warnings > (there may be others in the generated code, however no others have been found > at this time) > Ideally, the generated C++ code should not have these errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2589) C# generator: const of BaseType in IDL generates static instead of const properties
[
https://issues.apache.org/jira/browse/THRIFT-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14174147#comment-14174147
]
Jens Geyer commented on THRIFT-2589:
Partially, yes. First, it is in the Repository:
{code}
SHA-1: c20eeaae8296fa9d9de34b07fe8b21cf509c8884
* THRIFT-2589 const of BaseType in IDL generates static instead of const
properties
Client: C#
Patch: Thomas Lazar
{code}
{code}
git.exe branch -a --contains c20eeaae8296fa9d9de34b07fe8b21cf509c8884
master
remotes/origin/HEAD -> origin/master
remotes/origin/master
Success (281 ms @ 16.10.2014 21:36:47)
{code}
What you see as the Git 0.9.2 branch was a branch made for the first RC a few
days earlier, at 2014-07-10 to be precise. The commit above was made on
2014-08-07, so it is not part of /that/ particular branch.
But since the 0.9.2 is not yet released, it will become part of the forthcoming
release, thus the "fixed in version" comment is correct.
> C# generator: const of BaseType in IDL generates static instead of const
> properties
> ---
>
> Key: THRIFT-2589
> URL: https://issues.apache.org/jira/browse/THRIFT-2589
> Project: Thrift
> Issue Type: Bug
> Components: C# - Compiler
>Affects Versions: 0.9.1
> Environment: Windows 7
>Reporter: Thomas Lazar
>Assignee: Jens Geyer
> Fix For: 0.9.2
>
> Attachments: thrift-2589-fix-csharp-basetype-const.patch
>
>
> Compiling a thrift file containing const definitions for basetype variables
> results in static properties {{public static whatsits}} being generated.
> Should generate const properties {{public const whatsits}}.
> Current version generates this from test/ConstantsDemo.thrift
> {code}
> public static class ConstantsDemoConstants
> {
> public static int myInt = 3;
> public static int hex_const = 31;
> public static int GEN_ME = -3523553;
> public static double GEn_DUB = 325.532;
> public static double GEn_DU = 85.2355;
> public static string GEN_STRING = "asldkjasfd";
> public static Dictionary GEN_MAP = new Dictionary();
> public static List GEN_LIST = new List();
> ...
> {code}
> The code should instead look like this.
> {code}
> public static class ConstantsDemoConstants
> {
> public const int myInt = 3;
> public const int hex_const = 31;
> public const int GEN_ME = -3523553;
> public const double GEn_DUB = 325.532;
> public const double GEn_DU = 85.2355;
> public const string GEN_STRING = "asldkjasfd";
> public static Dictionary GEN_MAP = new Dictionary();
> public static List GEN_LIST = new List();
> ...
> {code}
> A patch for this change is supplied.
> As i don't really know yet how the testing for these kind of changes is done
> i haven't supplied one. But generating all the .thrift files in test with a
> before and after version of the compiler and comparing the output of both
> looked good to me.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (THRIFT-2787) Delphi Lib README
Jens Geyer created THRIFT-2787: -- Summary: Delphi Lib README Key: THRIFT-2787 URL: https://issues.apache.org/jira/browse/THRIFT-2787 Project: Thrift Issue Type: Improvement Components: Delphi - Library Reporter: Jens Geyer Assignee: Jens Geyer Priority: Trivial Fix For: 0.9.2 The README is missing, thus Delphi is missing from the web site Libraries section. :-( -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2787) Delphi Lib README
[ https://issues.apache.org/jira/browse/THRIFT-2787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2787. Resolution: Fixed Committed. > Delphi Lib README > - > > Key: THRIFT-2787 > URL: https://issues.apache.org/jira/browse/THRIFT-2787 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Library >Reporter: Jens Geyer >Assignee: Jens Geyer >Priority: Trivial > Fix For: 0.9.2 > > > The README is missing, thus Delphi is missing from the web site Libraries > section. :-( -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2787) Delphi Lib README
[ https://issues.apache.org/jira/browse/THRIFT-2787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2787: --- Attachment: THRIFT-2787-Delphi-Lib-README-missing.patch > Delphi Lib README > - > > Key: THRIFT-2787 > URL: https://issues.apache.org/jira/browse/THRIFT-2787 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Library >Reporter: Jens Geyer >Assignee: Jens Geyer >Priority: Trivial > Fix For: 0.9.2 > > Attachments: THRIFT-2787-Delphi-Lib-README-missing.patch > > > The README is missing, thus Delphi is missing from the web site Libraries > section. :-( -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2790) thrift -gen all => an option to generate all languages and features
[ https://issues.apache.org/jira/browse/THRIFT-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2790: --- Attachment: generate-all-languages.bat I have felt the need a tome or two to do some tests. I have a batch file here, I'll attach it just in case anyone needs it. The tricky part are things like node (maybe python as well) where one has to do multiple calls for one language to cover all cases. > thrift -gen all => an option to generate all languages and features > --- > > Key: THRIFT-2790 > URL: https://issues.apache.org/jira/browse/THRIFT-2790 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General), Documentation, Test Suite >Reporter: Roger Meier > Attachments: generate-all-languages.bat > > > I would like to have a *thrift -gen all* option to generate everything we > have in one step. This would allow proper testing of all compiler changes by > using test/ThriftTest.thrift. An optional make check target could compare > different versions based on their git hash or to previous gen-all.backup > folder. > Suggested-by: Roger Meier -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (THRIFT-2790) thrift -gen all => an option to generate all languages and features
[ https://issues.apache.org/jira/browse/THRIFT-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176301#comment-14176301 ] Jens Geyer edited comment on THRIFT-2790 at 10/19/14 12:21 PM: --- I felt the need as well a time or two to do some tests. I have a batch file here, I'll attach it just in case anyone needs it. The tricky part are things like node (maybe python as well) where one has to do multiple calls for one language to cover all cases. was (Author: jensg): I have felt the need a tome or two to do some tests. I have a batch file here, I'll attach it just in case anyone needs it. The tricky part are things like node (maybe python as well) where one has to do multiple calls for one language to cover all cases. > thrift -gen all => an option to generate all languages and features > --- > > Key: THRIFT-2790 > URL: https://issues.apache.org/jira/browse/THRIFT-2790 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General), Documentation, Test Suite >Reporter: Roger Meier > Attachments: generate-all-languages.bat > > > I would like to have a *thrift -gen all* option to generate everything we > have in one step. This would allow proper testing of all compiler changes by > using test/ThriftTest.thrift. An optional make check target could compare > different versions based on their git hash or to previous gen-all.backup > folder. > Suggested-by: Roger Meier -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Reopened] (THRIFT-2654) reduce number of server exceptions
[
https://issues.apache.org/jira/browse/THRIFT-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer reopened THRIFT-2654:
Reopen: After applying this patch, the {{Peek()}} method introduces additional
{{IOExceptions}} (instead of less exceptions) on client disconnects.
> reduce number of server exceptions
> --
>
> Key: THRIFT-2654
> URL: https://issues.apache.org/jira/browse/THRIFT-2654
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Library
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Fix For: 0.9.2
>
>
> GitHub user captncraig opened a pull request:
> https://github.com/apache/thrift/pull/177
> C# - reduce number of server exceptions
> The current server implementation reads in a loop until the client
> closes, at which point an exception is thrown by the processor/transport and
> caught by the server.
>
> I solve this by creating a smarter peek functionality in TTransport which
> reads and caches a byte from the underlying transport and reinserts it in
> ReadAll.
> You can merge this pull request into a Git repository by running:
> $ git pull https://github.com/captncraig/thrift transport-peek
> Alternatively you can review and apply these changes as the patch at:
> https://github.com/apache/thrift/pull/177.patch
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
> This closes #177
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-2654) reduce number of server exceptions
[ https://issues.apache.org/jira/browse/THRIFT-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2654: --- Attachment: THRIFT-2654-reduce-number-of-server-exceptions__additional.patch > reduce number of server exceptions > -- > > Key: THRIFT-2654 > URL: https://issues.apache.org/jira/browse/THRIFT-2654 > Project: Thrift > Issue Type: Improvement > Components: C# - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.9.2 > > Attachments: > THRIFT-2654-reduce-number-of-server-exceptions__additional.patch > > > GitHub user captncraig opened a pull request: > https://github.com/apache/thrift/pull/177 > C# - reduce number of server exceptions > The current server implementation reads in a loop until the client > closes, at which point an exception is thrown by the processor/transport and > caught by the server. > > I solve this by creating a smarter peek functionality in TTransport which > reads and caches a byte from the underlying transport and reinserts it in > ReadAll. > You can merge this pull request into a Git repository by running: > $ git pull https://github.com/captncraig/thrift transport-peek > Alternatively you can review and apply these changes as the patch at: > https://github.com/apache/thrift/pull/177.patch > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > This closes #177 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2654) reduce number of server exceptions
[ https://issues.apache.org/jira/browse/THRIFT-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2654. Resolution: Fixed Committed. > reduce number of server exceptions > -- > > Key: THRIFT-2654 > URL: https://issues.apache.org/jira/browse/THRIFT-2654 > Project: Thrift > Issue Type: Improvement > Components: C# - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.9.2 > > Attachments: > THRIFT-2654-reduce-number-of-server-exceptions__additional.patch > > > GitHub user captncraig opened a pull request: > https://github.com/apache/thrift/pull/177 > C# - reduce number of server exceptions > The current server implementation reads in a loop until the client > closes, at which point an exception is thrown by the processor/transport and > caught by the server. > > I solve this by creating a smarter peek functionality in TTransport which > reads and caches a byte from the underlying transport and reinserts it in > ReadAll. > You can merge this pull request into a Git repository by running: > $ git pull https://github.com/captncraig/thrift transport-peek > Alternatively you can review and apply these changes as the patch at: > https://github.com/apache/thrift/pull/177.patch > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > This closes #177 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (THRIFT-2791) Allowing use of buffered sockets in go server
[ https://issues.apache.org/jira/browse/THRIFT-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-2791: -- Assignee: Jens Geyer > Allowing use of buffered sockets in go server > - > > Key: THRIFT-2791 > URL: https://issues.apache.org/jira/browse/THRIFT-2791 > Project: Thrift > Issue Type: Improvement > Components: Go - Library >Reporter: Craig Peterson >Assignee: Jens Geyer > > There is currently no way in a go server to use buffered sockets. Failing to > do so decreases performance significantly in my tests. > I added an option on TServerSocket to set the buffer size to use. This will > default to 1024 bytes, but can be disabled if desired to get back to the > original behavior by setting BufferSize to 0. > Github pull request: https://github.com/apache/thrift/pull/249 > Patch https://github.com/apache/thrift/pull/249.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (THRIFT-2598) Add check for minimum Go version to configure.ac
[
https://issues.apache.org/jira/browse/THRIFT-2598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer reassigned THRIFT-2598:
--
Assignee: Jens Geyer
> Add check for minimum Go version to configure.ac
>
>
> Key: THRIFT-2598
> URL: https://issues.apache.org/jira/browse/THRIFT-2598
> Project: Thrift
> Issue Type: Bug
> Components: Build Process, Go - Library
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Fix For: 1.0
>
>
> The Go build currently fails, if some older Go version is installed, e.g.
> because of missing {{io.ByteWriter}}. Need to add appropriate check in
> configure.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-2598) Add check for minimum Go version to configure.ac
[
https://issues.apache.org/jira/browse/THRIFT-2598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-2598:
---
Assignee: (was: Jens Geyer)
> Add check for minimum Go version to configure.ac
>
>
> Key: THRIFT-2598
> URL: https://issues.apache.org/jira/browse/THRIFT-2598
> Project: Thrift
> Issue Type: Bug
> Components: Build Process, Go - Library
>Reporter: Jens Geyer
> Fix For: 1.0
>
>
> The Go build currently fails, if some older Go version is installed, e.g.
> because of missing {{io.ByteWriter}}. Need to add appropriate check in
> configure.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-2793) Go compiler produces uncompilable code
[
https://issues.apache.org/jira/browse/THRIFT-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-2793:
---
Attachment: Thrift2793.thrift
[^Thrift2793.thrift|Here's an IDL file] with all of your above mentioned test
cases rolled into one file. I can confirm the problem using that file.
> Go compiler produces uncompilable code
> --
>
> Key: THRIFT-2793
> URL: https://issues.apache.org/jira/browse/THRIFT-2793
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.9.2
> Environment: OSX 10.10
>Reporter: Frank Schroeder
> Attachments: Thrift2793.thrift
>
>
> The Thrift Go compiler produces wrong code for the following code:
> {code}
> struct A { 1: list b }
> struct B { 1: i64 id }
> {code}
> The abbreviated reader method creates a []B instead of a []*B but still tries
> to add a &B{}.
> {code}
> func (p *A) ReadField1(iprot thrift.TProtocol) error {
> ...
> tSlice := make([]B, 0, size)
> ...
> for i := 0; i < size; i++ {
> _elem0 := &B{}
> ...
> p.B = append(p.B, _elem0)
> }
> ...
> }
> {code}
> The Go compiler message is:
> {code}
> $ go version
> go version go1.3.3 darwin/amd64
> $ go build
> ./ttypes.go:74: cannot use _elem0 (type *B) as type B in append
> {code}
> Moving struct B *above* struct A produces correct code:
> {code}
> struct B { 1: i64 id }
> struct A { 1: list b }
> {code}
> The abbreviated reader method:
> {code}
> func (p *A) ReadField1(iprot thrift.TProtocol) error {
> ...
> tSlice := make([]*B, 0, size)
> ...
> for i := 0; i < size; i++ {
> _elem0 := &B{}
> ...
> p.B = append(p.B, _elem0)
> }
> ...
> }
> {code}
> This problem does not occurr with enums since they are aliases for int64. So
> both versions generate correct code:
> {code}
> struct A { 1: list b }
> enum B { X }
> {code}
> and
> {code}
> enum B { X }
> struct A { 1: list b }
> {code}
> Tested with version 902b7af4c84b8f716668d4d4f10612c16109c09a from
> https://git-wip-us.apache.org/repos/asf/thrift.git.
> I've built the thrift compiler with the following flags:
> {code}
> PATH=/opt/boxen/homebrew/Cellar/bison27/2.7.1/bin:$PATH ./configure \
> --without-cpp \
> --without-qt4 \
> --without-c_glib \
> --without-csharp \
> --without-java \
> --without-erlang \
> --without-nodejs \
> --without-lua \
> --without-python \
> --without-perl \
> --without-php \
> --without-php_extension \
> --without-ruby \
> --without-haskell \
> --with-go
> {code}
> and generate the thrift stubs as follows:
> {code}
> ../compiler/cpp/thrift --gen go -out . model.thrift
> {code}
> I'll try to dig a bit through the source of the generator to see whether I
> can produce a patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (THRIFT-2793) Go compiler produces uncompilable code
[
https://issues.apache.org/jira/browse/THRIFT-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187441#comment-14187441
]
Jens Geyer edited comment on THRIFT-2793 at 10/28/14 8:53 PM:
--
[Here's an IDL file|^Thrift2793.thrift] with all of your above mentioned test
cases rolled into one file. I can confirm the problem using that file.
was (Author: jensg):
[^Thrift2793.thrift|Here's an IDL file] with all of your above mentioned test
cases rolled into one file. I can confirm the problem using that file.
> Go compiler produces uncompilable code
> --
>
> Key: THRIFT-2793
> URL: https://issues.apache.org/jira/browse/THRIFT-2793
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.9.2
> Environment: OSX 10.10
>Reporter: Frank Schroeder
> Attachments: Thrift2793.thrift
>
>
> The Thrift Go compiler produces wrong code for the following code:
> {code}
> struct A { 1: list b }
> struct B { 1: i64 id }
> {code}
> The abbreviated reader method creates a []B instead of a []*B but still tries
> to add a &B{}.
> {code}
> func (p *A) ReadField1(iprot thrift.TProtocol) error {
> ...
> tSlice := make([]B, 0, size)
> ...
> for i := 0; i < size; i++ {
> _elem0 := &B{}
> ...
> p.B = append(p.B, _elem0)
> }
> ...
> }
> {code}
> The Go compiler message is:
> {code}
> $ go version
> go version go1.3.3 darwin/amd64
> $ go build
> ./ttypes.go:74: cannot use _elem0 (type *B) as type B in append
> {code}
> Moving struct B *above* struct A produces correct code:
> {code}
> struct B { 1: i64 id }
> struct A { 1: list b }
> {code}
> The abbreviated reader method:
> {code}
> func (p *A) ReadField1(iprot thrift.TProtocol) error {
> ...
> tSlice := make([]*B, 0, size)
> ...
> for i := 0; i < size; i++ {
> _elem0 := &B{}
> ...
> p.B = append(p.B, _elem0)
> }
> ...
> }
> {code}
> This problem does not occurr with enums since they are aliases for int64. So
> both versions generate correct code:
> {code}
> struct A { 1: list b }
> enum B { X }
> {code}
> and
> {code}
> enum B { X }
> struct A { 1: list b }
> {code}
> Tested with version 902b7af4c84b8f716668d4d4f10612c16109c09a from
> https://git-wip-us.apache.org/repos/asf/thrift.git.
> I've built the thrift compiler with the following flags:
> {code}
> PATH=/opt/boxen/homebrew/Cellar/bison27/2.7.1/bin:$PATH ./configure \
> --without-cpp \
> --without-qt4 \
> --without-c_glib \
> --without-csharp \
> --without-java \
> --without-erlang \
> --without-nodejs \
> --without-lua \
> --without-python \
> --without-perl \
> --without-php \
> --without-php_extension \
> --without-ruby \
> --without-haskell \
> --with-go
> {code}
> and generate the thrift stubs as follows:
> {code}
> ../compiler/cpp/thrift --gen go -out . model.thrift
> {code}
> I'll try to dig a bit through the source of the generator to see whether I
> can produce a patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (THRIFT-2792) Wrong option level for setsockopt(...TCP_DEFER_ACCEPT)
[ https://issues.apache.org/jira/browse/THRIFT-2792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-2792: -- Assignee: Jens Geyer > Wrong option level for setsockopt(...TCP_DEFER_ACCEPT) > -- > > Key: THRIFT-2792 > URL: https://issues.apache.org/jira/browse/THRIFT-2792 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.9.2 > Environment: OpenWrt Barrier-breaker, Mint Qiana >Reporter: Sven-Ola Tücke >Assignee: Jens Geyer > Attachments: fix-tcp-defer-accept.txt > > > Should set TCP_DEFER_ACCEPT(9), sets SO_KEEPALIVE(also 9) instead. Please > apply patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
