[jira] [Resolved] (THRIFT-2792) Wrong option level for setsockopt(...TCP_DEFER_ACCEPT)
[ https://issues.apache.org/jira/browse/THRIFT-2792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2792. Resolution: Fixed Fix Version/s: 0.9.2 Committed, thanks for catching! > Wrong option level for setsockopt(...TCP_DEFER_ACCEPT) > -- > > Key: THRIFT-2792 > URL: https://issues.apache.org/jira/browse/THRIFT-2792 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.9.2 > Environment: OpenWrt Barrier-breaker, Mint Qiana >Reporter: Sven-Ola Tücke >Assignee: Jens Geyer > Fix For: 0.9.2 > > Attachments: fix-tcp-defer-accept.txt > > > Should set TCP_DEFER_ACCEPT(9), sets SO_KEEPALIVE(also 9) instead. Please > apply patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2791) Allowing use of buffered sockets in go server
[ https://issues.apache.org/jira/browse/THRIFT-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2791. Resolution: Fixed Fix Version/s: 0.9.2 Committed > Allowing use of buffered sockets in go server > - > > Key: THRIFT-2791 > URL: https://issues.apache.org/jira/browse/THRIFT-2791 > Project: Thrift > Issue Type: Improvement > Components: Go - Library >Reporter: Craig Peterson >Assignee: Jens Geyer > Fix For: 0.9.2 > > > There is currently no way in a go server to use buffered sockets. Failing to > do so decreases performance significantly in my tests. > I added an option on TServerSocket to set the buffer size to use. This will > default to 1024 bytes, but can be disabled if desired to get back to the > original behavior by setting BufferSize to 0. > Github pull request: https://github.com/apache/thrift/pull/249 > Patch https://github.com/apache/thrift/pull/249.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2794) generated Java code full of warnings
[
https://issues.apache.org/jira/browse/THRIFT-2794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-2794:
---
Component/s: Java - Compiler
> generated Java code full of warnings
>
>
> Key: THRIFT-2794
> URL: https://issues.apache.org/jira/browse/THRIFT-2794
> Project: Thrift
> Issue Type: Bug
> Components: Java - Compiler
>Affects Versions: 0.9.1, 1.0
> Environment: Ubuntu 14.04
>Reporter: Kevin
>Priority: Minor
>
> The java code generated by thrift is full of warnings about unused imports
> and fields. With a lot of thrift generated classes, we're getting warnings we
> care about drowned out in the noise of generated code warnings (approx. 600).
> This small example generates about a half dozen unused imports:
> struct Publisher
> {
> 1: optional string id,
> 2: optional string name,
> 3: optional list cat,
> 4: optional string domain
> }
> thrift --gen java -out . publisher.thrift
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (THRIFT-2793) Go compiler produces uncompilable code
[
https://issues.apache.org/jira/browse/THRIFT-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer reassigned THRIFT-2793:
--
Assignee: Jens Geyer
> Go compiler produces uncompilable code
> --
>
> Key: THRIFT-2793
> URL: https://issues.apache.org/jira/browse/THRIFT-2793
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.9.2
> Environment: OSX 10.10
>Reporter: Frank Schroeder
>Assignee: Jens Geyer
> Attachments: THRIFT-2793.patch, Thrift2793.thrift
>
>
> The Thrift Go compiler produces wrong code for the following code:
> {code}
> struct A { 1: list b }
> struct B { 1: i64 id }
> {code}
> The abbreviated reader method creates a []B instead of a []*B but still tries
> to add a &B{}.
> {code}
> func (p *A) ReadField1(iprot thrift.TProtocol) error {
> ...
> tSlice := make([]B, 0, size)
> ...
> for i := 0; i < size; i++ {
> _elem0 := &B{}
> ...
> p.B = append(p.B, _elem0)
> }
> ...
> }
> {code}
> The Go compiler message is:
> {code}
> $ go version
> go version go1.3.3 darwin/amd64
> $ go build
> ./ttypes.go:74: cannot use _elem0 (type *B) as type B in append
> {code}
> Moving struct B *above* struct A produces correct code:
> {code}
> struct B { 1: i64 id }
> struct A { 1: list b }
> {code}
> The abbreviated reader method:
> {code}
> func (p *A) ReadField1(iprot thrift.TProtocol) error {
> ...
> tSlice := make([]*B, 0, size)
> ...
> for i := 0; i < size; i++ {
> _elem0 := &B{}
> ...
> p.B = append(p.B, _elem0)
> }
> ...
> }
> {code}
> This problem does not occurr with enums since they are aliases for int64. So
> both versions generate correct code:
> {code}
> struct A { 1: list b }
> enum B { X }
> {code}
> and
> {code}
> enum B { X }
> struct A { 1: list b }
> {code}
> Tested with version 902b7af4c84b8f716668d4d4f10612c16109c09a from
> https://git-wip-us.apache.org/repos/asf/thrift.git.
> I've built the thrift compiler with the following flags:
> {code}
> PATH=/opt/boxen/homebrew/Cellar/bison27/2.7.1/bin:$PATH ./configure \
> --without-cpp \
> --without-qt4 \
> --without-c_glib \
> --without-csharp \
> --without-java \
> --without-erlang \
> --without-nodejs \
> --without-lua \
> --without-python \
> --without-perl \
> --without-php \
> --without-php_extension \
> --without-ruby \
> --without-haskell \
> --with-go
> {code}
> and generate the thrift stubs as follows:
> {code}
> ../compiler/cpp/thrift --gen go -out . model.thrift
> {code}
> I'll try to dig a bit through the source of the generator to see whether I
> can produce a patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2793) Go compiler produces uncompilable code
[
https://issues.apache.org/jira/browse/THRIFT-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14193453#comment-14193453
]
Jens Geyer commented on THRIFT-2793:
LGTM, all tests succeed => committed
> I want to complete it with a new test case in the build if possible.
Having a dedicated test case would be cool indeed. I leave the ticket open.
> Go compiler produces uncompilable code
> --
>
> Key: THRIFT-2793
> URL: https://issues.apache.org/jira/browse/THRIFT-2793
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.9.2
> Environment: OSX 10.10
>Reporter: Frank Schroeder
>Assignee: Jens Geyer
> Attachments: THRIFT-2793.patch, Thrift2793.thrift
>
>
> The Thrift Go compiler produces wrong code for the following code:
> {code}
> struct A { 1: list b }
> struct B { 1: i64 id }
> {code}
> The abbreviated reader method creates a []B instead of a []*B but still tries
> to add a &B{}.
> {code}
> func (p *A) ReadField1(iprot thrift.TProtocol) error {
> ...
> tSlice := make([]B, 0, size)
> ...
> for i := 0; i < size; i++ {
> _elem0 := &B{}
> ...
> p.B = append(p.B, _elem0)
> }
> ...
> }
> {code}
> The Go compiler message is:
> {code}
> $ go version
> go version go1.3.3 darwin/amd64
> $ go build
> ./ttypes.go:74: cannot use _elem0 (type *B) as type B in append
> {code}
> Moving struct B *above* struct A produces correct code:
> {code}
> struct B { 1: i64 id }
> struct A { 1: list b }
> {code}
> The abbreviated reader method:
> {code}
> func (p *A) ReadField1(iprot thrift.TProtocol) error {
> ...
> tSlice := make([]*B, 0, size)
> ...
> for i := 0; i < size; i++ {
> _elem0 := &B{}
> ...
> p.B = append(p.B, _elem0)
> }
> ...
> }
> {code}
> This problem does not occurr with enums since they are aliases for int64. So
> both versions generate correct code:
> {code}
> struct A { 1: list b }
> enum B { X }
> {code}
> and
> {code}
> enum B { X }
> struct A { 1: list b }
> {code}
> Tested with version 902b7af4c84b8f716668d4d4f10612c16109c09a from
> https://git-wip-us.apache.org/repos/asf/thrift.git.
> I've built the thrift compiler with the following flags:
> {code}
> PATH=/opt/boxen/homebrew/Cellar/bison27/2.7.1/bin:$PATH ./configure \
> --without-cpp \
> --without-qt4 \
> --without-c_glib \
> --without-csharp \
> --without-java \
> --without-erlang \
> --without-nodejs \
> --without-lua \
> --without-python \
> --without-perl \
> --without-php \
> --without-php_extension \
> --without-ruby \
> --without-haskell \
> --with-go
> {code}
> and generate the thrift stubs as follows:
> {code}
> ../compiler/cpp/thrift --gen go -out . model.thrift
> {code}
> I'll try to dig a bit through the source of the generator to see whether I
> can produce a patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-2793) Go compiler produces uncompilable code
[
https://issues.apache.org/jira/browse/THRIFT-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-2793:
---
Fix Version/s: 0.9.2
> Go compiler produces uncompilable code
> --
>
> Key: THRIFT-2793
> URL: https://issues.apache.org/jira/browse/THRIFT-2793
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.9.2
> Environment: OSX 10.10
>Reporter: Frank Schroeder
>Assignee: Jens Geyer
> Fix For: 0.9.2
>
> Attachments: THRIFT-2793.patch, Thrift2793.thrift
>
>
> The Thrift Go compiler produces wrong code for the following code:
> {code}
> struct A { 1: list b }
> struct B { 1: i64 id }
> {code}
> The abbreviated reader method creates a []B instead of a []*B but still tries
> to add a &B{}.
> {code}
> func (p *A) ReadField1(iprot thrift.TProtocol) error {
> ...
> tSlice := make([]B, 0, size)
> ...
> for i := 0; i < size; i++ {
> _elem0 := &B{}
> ...
> p.B = append(p.B, _elem0)
> }
> ...
> }
> {code}
> The Go compiler message is:
> {code}
> $ go version
> go version go1.3.3 darwin/amd64
> $ go build
> ./ttypes.go:74: cannot use _elem0 (type *B) as type B in append
> {code}
> Moving struct B *above* struct A produces correct code:
> {code}
> struct B { 1: i64 id }
> struct A { 1: list b }
> {code}
> The abbreviated reader method:
> {code}
> func (p *A) ReadField1(iprot thrift.TProtocol) error {
> ...
> tSlice := make([]*B, 0, size)
> ...
> for i := 0; i < size; i++ {
> _elem0 := &B{}
> ...
> p.B = append(p.B, _elem0)
> }
> ...
> }
> {code}
> This problem does not occurr with enums since they are aliases for int64. So
> both versions generate correct code:
> {code}
> struct A { 1: list b }
> enum B { X }
> {code}
> and
> {code}
> enum B { X }
> struct A { 1: list b }
> {code}
> Tested with version 902b7af4c84b8f716668d4d4f10612c16109c09a from
> https://git-wip-us.apache.org/repos/asf/thrift.git.
> I've built the thrift compiler with the following flags:
> {code}
> PATH=/opt/boxen/homebrew/Cellar/bison27/2.7.1/bin:$PATH ./configure \
> --without-cpp \
> --without-qt4 \
> --without-c_glib \
> --without-csharp \
> --without-java \
> --without-erlang \
> --without-nodejs \
> --without-lua \
> --without-python \
> --without-perl \
> --without-php \
> --without-php_extension \
> --without-ruby \
> --without-haskell \
> --with-go
> {code}
> and generate the thrift stubs as follows:
> {code}
> ../compiler/cpp/thrift --gen go -out . model.thrift
> {code}
> I'll try to dig a bit through the source of the generator to see whether I
> can produce a patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2793) Go compiler produces uncompilable code
[
https://issues.apache.org/jira/browse/THRIFT-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197855#comment-14197855
]
Jens Geyer commented on THRIFT-2793:
[~magiconair],
the patch is already committed into 0.9.2, see above (even though it is not
mentioned in CHANGES). I file a separate ticket for the test case to make this
clear, no prb.
[~jfarrell]
FYI
> Go compiler produces uncompilable code
> --
>
> Key: THRIFT-2793
> URL: https://issues.apache.org/jira/browse/THRIFT-2793
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.9.2
> Environment: OSX 10.10
>Reporter: Frank Schroeder
>Assignee: Jens Geyer
> Fix For: 1.0
>
> Attachments: THRIFT-2793.patch, Thrift2793.thrift
>
>
> The Thrift Go compiler produces wrong code for the following code:
> {code}
> struct A { 1: list b }
> struct B { 1: i64 id }
> {code}
> The abbreviated reader method creates a []B instead of a []*B but still tries
> to add a &B{}.
> {code}
> func (p *A) ReadField1(iprot thrift.TProtocol) error {
> ...
> tSlice := make([]B, 0, size)
> ...
> for i := 0; i < size; i++ {
> _elem0 := &B{}
> ...
> p.B = append(p.B, _elem0)
> }
> ...
> }
> {code}
> The Go compiler message is:
> {code}
> $ go version
> go version go1.3.3 darwin/amd64
> $ go build
> ./ttypes.go:74: cannot use _elem0 (type *B) as type B in append
> {code}
> Moving struct B *above* struct A produces correct code:
> {code}
> struct B { 1: i64 id }
> struct A { 1: list b }
> {code}
> The abbreviated reader method:
> {code}
> func (p *A) ReadField1(iprot thrift.TProtocol) error {
> ...
> tSlice := make([]*B, 0, size)
> ...
> for i := 0; i < size; i++ {
> _elem0 := &B{}
> ...
> p.B = append(p.B, _elem0)
> }
> ...
> }
> {code}
> This problem does not occurr with enums since they are aliases for int64. So
> both versions generate correct code:
> {code}
> struct A { 1: list b }
> enum B { X }
> {code}
> and
> {code}
> enum B { X }
> struct A { 1: list b }
> {code}
> Tested with version 902b7af4c84b8f716668d4d4f10612c16109c09a from
> https://git-wip-us.apache.org/repos/asf/thrift.git.
> I've built the thrift compiler with the following flags:
> {code}
> PATH=/opt/boxen/homebrew/Cellar/bison27/2.7.1/bin:$PATH ./configure \
> --without-cpp \
> --without-qt4 \
> --without-c_glib \
> --without-csharp \
> --without-java \
> --without-erlang \
> --without-nodejs \
> --without-lua \
> --without-python \
> --without-perl \
> --without-php \
> --without-php_extension \
> --without-ruby \
> --without-haskell \
> --with-go
> {code}
> and generate the thrift stubs as follows:
> {code}
> ../compiler/cpp/thrift --gen go -out . model.thrift
> {code}
> I'll try to dig a bit through the source of the generator to see whether I
> can produce a patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (THRIFT-2796) Testcase for THRIFT-2793
Jens Geyer created THRIFT-2796: -- Summary: Testcase for THRIFT-2793 Key: THRIFT-2796 URL: https://issues.apache.org/jira/browse/THRIFT-2796 Project: Thrift Issue Type: Test Components: Go - Compiler Reporter: Jens Geyer Fix For: 1.0 Add test for THRIFT-2793 Go compiler produces uncompilable code -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2793) Go compiler produces uncompilable code
[
https://issues.apache.org/jira/browse/THRIFT-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-2793:
---
Fix Version/s: (was: 1.0)
0.9.2
> Go compiler produces uncompilable code
> --
>
> Key: THRIFT-2793
> URL: https://issues.apache.org/jira/browse/THRIFT-2793
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.9.2
> Environment: OSX 10.10
>Reporter: Frank Schroeder
>Assignee: Jens Geyer
> Fix For: 0.9.2
>
> Attachments: THRIFT-2793.patch, Thrift2793.thrift
>
>
> The Thrift Go compiler produces wrong code for the following code:
> {code}
> struct A { 1: list b }
> struct B { 1: i64 id }
> {code}
> The abbreviated reader method creates a []B instead of a []*B but still tries
> to add a &B{}.
> {code}
> func (p *A) ReadField1(iprot thrift.TProtocol) error {
> ...
> tSlice := make([]B, 0, size)
> ...
> for i := 0; i < size; i++ {
> _elem0 := &B{}
> ...
> p.B = append(p.B, _elem0)
> }
> ...
> }
> {code}
> The Go compiler message is:
> {code}
> $ go version
> go version go1.3.3 darwin/amd64
> $ go build
> ./ttypes.go:74: cannot use _elem0 (type *B) as type B in append
> {code}
> Moving struct B *above* struct A produces correct code:
> {code}
> struct B { 1: i64 id }
> struct A { 1: list b }
> {code}
> The abbreviated reader method:
> {code}
> func (p *A) ReadField1(iprot thrift.TProtocol) error {
> ...
> tSlice := make([]*B, 0, size)
> ...
> for i := 0; i < size; i++ {
> _elem0 := &B{}
> ...
> p.B = append(p.B, _elem0)
> }
> ...
> }
> {code}
> This problem does not occurr with enums since they are aliases for int64. So
> both versions generate correct code:
> {code}
> struct A { 1: list b }
> enum B { X }
> {code}
> and
> {code}
> enum B { X }
> struct A { 1: list b }
> {code}
> Tested with version 902b7af4c84b8f716668d4d4f10612c16109c09a from
> https://git-wip-us.apache.org/repos/asf/thrift.git.
> I've built the thrift compiler with the following flags:
> {code}
> PATH=/opt/boxen/homebrew/Cellar/bison27/2.7.1/bin:$PATH ./configure \
> --without-cpp \
> --without-qt4 \
> --without-c_glib \
> --without-csharp \
> --without-java \
> --without-erlang \
> --without-nodejs \
> --without-lua \
> --without-python \
> --without-perl \
> --without-php \
> --without-php_extension \
> --without-ruby \
> --without-haskell \
> --with-go
> {code}
> and generate the thrift stubs as follows:
> {code}
> ../compiler/cpp/thrift --gen go -out . model.thrift
> {code}
> I'll try to dig a bit through the source of the generator to see whether I
> can produce a patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-2793) Go compiler produces uncompilable code
[
https://issues.apache.org/jira/browse/THRIFT-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-2793.
Resolution: Fixed
Already committed into 0.9.2, FUP for test case see THRIFT-2796
> Go compiler produces uncompilable code
> --
>
> Key: THRIFT-2793
> URL: https://issues.apache.org/jira/browse/THRIFT-2793
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.9.2
> Environment: OSX 10.10
>Reporter: Frank Schroeder
>Assignee: Jens Geyer
> Fix For: 0.9.2
>
> Attachments: THRIFT-2793.patch, Thrift2793.thrift
>
>
> The Thrift Go compiler produces wrong code for the following code:
> {code}
> struct A { 1: list b }
> struct B { 1: i64 id }
> {code}
> The abbreviated reader method creates a []B instead of a []*B but still tries
> to add a &B{}.
> {code}
> func (p *A) ReadField1(iprot thrift.TProtocol) error {
> ...
> tSlice := make([]B, 0, size)
> ...
> for i := 0; i < size; i++ {
> _elem0 := &B{}
> ...
> p.B = append(p.B, _elem0)
> }
> ...
> }
> {code}
> The Go compiler message is:
> {code}
> $ go version
> go version go1.3.3 darwin/amd64
> $ go build
> ./ttypes.go:74: cannot use _elem0 (type *B) as type B in append
> {code}
> Moving struct B *above* struct A produces correct code:
> {code}
> struct B { 1: i64 id }
> struct A { 1: list b }
> {code}
> The abbreviated reader method:
> {code}
> func (p *A) ReadField1(iprot thrift.TProtocol) error {
> ...
> tSlice := make([]*B, 0, size)
> ...
> for i := 0; i < size; i++ {
> _elem0 := &B{}
> ...
> p.B = append(p.B, _elem0)
> }
> ...
> }
> {code}
> This problem does not occurr with enums since they are aliases for int64. So
> both versions generate correct code:
> {code}
> struct A { 1: list b }
> enum B { X }
> {code}
> and
> {code}
> enum B { X }
> struct A { 1: list b }
> {code}
> Tested with version 902b7af4c84b8f716668d4d4f10612c16109c09a from
> https://git-wip-us.apache.org/repos/asf/thrift.git.
> I've built the thrift compiler with the following flags:
> {code}
> PATH=/opt/boxen/homebrew/Cellar/bison27/2.7.1/bin:$PATH ./configure \
> --without-cpp \
> --without-qt4 \
> --without-c_glib \
> --without-csharp \
> --without-java \
> --without-erlang \
> --without-nodejs \
> --without-lua \
> --without-python \
> --without-perl \
> --without-php \
> --without-php_extension \
> --without-ruby \
> --without-haskell \
> --with-go
> {code}
> and generate the thrift stubs as follows:
> {code}
> ../compiler/cpp/thrift --gen go -out . model.thrift
> {code}
> I'll try to dig a bit through the source of the generator to see whether I
> can produce a patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2800) error in running make : error in thrifty.cc the method yyparse() reserch the method strdup() (not declared)
[ https://issues.apache.org/jira/browse/THRIFT-2800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14200601#comment-14200601 ] Jens Geyer commented on THRIFT-2800: Hi, have you tried the Visual Studio projects? > error in running make : error in thrifty.cc the method yyparse() reserch the > method strdup() (not declared) > --- > > Key: THRIFT-2800 > URL: https://issues.apache.org/jira/browse/THRIFT-2800 > Project: Thrift > Issue Type: Bug > Components: Build Process > Environment: cygwin64 > Windows 7 _ 64 bits >Reporter: saber hattay >Priority: Blocker > Labels: build, github-import > Attachments: ConfigureAndMake.txt > > > Hello, > When I tape this command : configure && make > I receive this result : > make : *** error 2 > cause by the appel of this function strdup() (function not declared). > It's the first time I want to build thrift. > Thank you in advance for you help. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-2803) TCP_DEFER_ACCEPT not supported with domain sockets
Jens Geyer created THRIFT-2803:
--
Summary: TCP_DEFER_ACCEPT not supported with domain sockets
Key: THRIFT-2803
URL: https://issues.apache.org/jira/browse/THRIFT-2803
Project: Thrift
Issue Type: Bug
Components: C++ - Library
Affects Versions: 0.9.2
Reporter: Jens Geyer
Assignee: Jens Geyer
Fix For: 0.9.3
After applying the fix from THRIFT-2792, the code does no longer work with
domain sockets:
{code}
$ ./TestServer --domain-socket=/tmp/ThriftTest.thrift
Starting "simple" server (buffered/binary) listen on: /tmp/ThriftTest.thrift
Thrift: Wed Nov 5 21:54:07 2014 TServerSocket::listen() setsockopt()
TCP_DEFER_ACCEPT Operation not supported
terminate called after throwing an instance of
'apache::thrift::transport::TTransportException'
what(): Could not set TCP_DEFER_ACCEPT: Operation not supported
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-2803) TCP_DEFER_ACCEPT not supported with domain sockets
[
https://issues.apache.org/jira/browse/THRIFT-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-2803:
---
Description:
After applying the fix from THRIFT-2792, the code does no longer work with
domain sockets:
{code}
$ ./TestServer --domain-socket=/tmp/ThriftTest.thrift
Starting "simple" server (buffered/binary) listen on: /tmp/ThriftTest.thrift
Thrift: Wed Nov 5 21:54:07 2014 TServerSocket::listen() setsockopt()
TCP_DEFER_ACCEPT Operation not supported
terminate called after throwing an instance of
'apache::thrift::transport::TTransportException'
what(): Could not set TCP_DEFER_ACCEPT: Operation not supported
{code}
Thanks to [~roger.meier] who pointed this out.
was:
After applying the fix from THRIFT-2792, the code does no longer work with
domain sockets:
{code}
$ ./TestServer --domain-socket=/tmp/ThriftTest.thrift
Starting "simple" server (buffered/binary) listen on: /tmp/ThriftTest.thrift
Thrift: Wed Nov 5 21:54:07 2014 TServerSocket::listen() setsockopt()
TCP_DEFER_ACCEPT Operation not supported
terminate called after throwing an instance of
'apache::thrift::transport::TTransportException'
what(): Could not set TCP_DEFER_ACCEPT: Operation not supported
{code}
> TCP_DEFER_ACCEPT not supported with domain sockets
> --
>
> Key: THRIFT-2803
> URL: https://issues.apache.org/jira/browse/THRIFT-2803
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Affects Versions: 0.9.2
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Fix For: 0.9.3
>
>
> After applying the fix from THRIFT-2792, the code does no longer work with
> domain sockets:
> {code}
> $ ./TestServer --domain-socket=/tmp/ThriftTest.thrift
> Starting "simple" server (buffered/binary) listen on: /tmp/ThriftTest.thrift
> Thrift: Wed Nov 5 21:54:07 2014 TServerSocket::listen() setsockopt()
> TCP_DEFER_ACCEPT Operation not supported
> terminate called after throwing an instance of
> 'apache::thrift::transport::TTransportException'
> what(): Could not set TCP_DEFER_ACCEPT: Operation not supported
> {code}
> Thanks to [~roger.meier] who pointed this out.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-2803) TCP_DEFER_ACCEPT not supported with domain sockets
[
https://issues.apache.org/jira/browse/THRIFT-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-2803:
---
Attachment: THRIFT-2803-TCP_DEFER_ACCEPT-not-supported-with-doma.patch
> TCP_DEFER_ACCEPT not supported with domain sockets
> --
>
> Key: THRIFT-2803
> URL: https://issues.apache.org/jira/browse/THRIFT-2803
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Affects Versions: 0.9.2
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Fix For: 0.9.3
>
> Attachments:
> THRIFT-2803-TCP_DEFER_ACCEPT-not-supported-with-doma.patch
>
>
> After applying the fix from THRIFT-2792, the code does no longer work with
> domain sockets:
> {code}
> $ ./TestServer --domain-socket=/tmp/ThriftTest.thrift
> Starting "simple" server (buffered/binary) listen on: /tmp/ThriftTest.thrift
> Thrift: Wed Nov 5 21:54:07 2014 TServerSocket::listen() setsockopt()
> TCP_DEFER_ACCEPT Operation not supported
> terminate called after throwing an instance of
> 'apache::thrift::transport::TTransportException'
> what(): Could not set TCP_DEFER_ACCEPT: Operation not supported
> {code}
> Thanks to [~roger.meier] who pointed this out.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-2803) TCP_DEFER_ACCEPT not supported with domain sockets
[
https://issues.apache.org/jira/browse/THRIFT-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-2803.
Resolution: Fixed
Committed
> TCP_DEFER_ACCEPT not supported with domain sockets
> --
>
> Key: THRIFT-2803
> URL: https://issues.apache.org/jira/browse/THRIFT-2803
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Affects Versions: 0.9.2
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Fix For: 0.9.3
>
> Attachments:
> THRIFT-2803-TCP_DEFER_ACCEPT-not-supported-with-doma.patch
>
>
> After applying the fix from THRIFT-2792, the code does no longer work with
> domain sockets:
> {code}
> $ ./TestServer --domain-socket=/tmp/ThriftTest.thrift
> Starting "simple" server (buffered/binary) listen on: /tmp/ThriftTest.thrift
> Thrift: Wed Nov 5 21:54:07 2014 TServerSocket::listen() setsockopt()
> TCP_DEFER_ACCEPT Operation not supported
> terminate called after throwing an instance of
> 'apache::thrift::transport::TTransportException'
> what(): Could not set TCP_DEFER_ACCEPT: Operation not supported
> {code}
> Thanks to [~roger.meier] who pointed this out.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-2753) Misc. Haxe improvements
[ https://issues.apache.org/jira/browse/THRIFT-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2753. Resolution: Fixed Tested again against most current stable versions, committed. > Misc. Haxe improvements > --- > > Key: THRIFT-2753 > URL: https://issues.apache.org/jira/browse/THRIFT-2753 > Project: Thrift > Issue Type: Sub-task > Components: Haxe - Compiler, Haxe - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > > This is the second part of the Haxe addition started with THRIFT-2644, > completing the base feature set with HTTP client and stream transports. > *Test improvements* > - added missing testException tests > - aligned cross test return codes > - aligned cross test command line arguments > - added --skip-speed-test switch > *Code generator improvements* > - added suffix "_FIELD_ID" to the fieldIDs to prevent name collisions with > uppercase-only members (like ID, VAT) > - always render enum type with full namespace to prevent name collisions with > class members > *Library improvements* > - HTTP transport client added > - Generic Stream transport added, implemented FileStream transport > - fixed possible double UTF-8 encoding/decoding in JSON protocol > - Haxe Thrift library test project added -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2753) Misc. Haxe improvements
[ https://issues.apache.org/jira/browse/THRIFT-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2753: --- Fix Version/s: 0.9.3 > Misc. Haxe improvements > --- > > Key: THRIFT-2753 > URL: https://issues.apache.org/jira/browse/THRIFT-2753 > Project: Thrift > Issue Type: Sub-task > Components: Haxe - Compiler, Haxe - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.9.3 > > > This is the second part of the Haxe addition started with THRIFT-2644, > completing the base feature set with HTTP client and stream transports. > *Test improvements* > - added missing testException tests > - aligned cross test return codes > - aligned cross test command line arguments > - added --skip-speed-test switch > *Code generator improvements* > - added suffix "_FIELD_ID" to the fieldIDs to prevent name collisions with > uppercase-only members (like ID, VAT) > - always render enum type with full namespace to prevent name collisions with > class members > *Library improvements* > - HTTP transport client added > - Generic Stream transport added, implemented FileStream transport > - fixed possible double UTF-8 encoding/decoding in JSON protocol > - Haxe Thrift library test project added -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2644) Haxe support
[ https://issues.apache.org/jira/browse/THRIFT-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2644. Resolution: Fixed Tested again against most current stable versions, committed. > Haxe support > > > Key: THRIFT-2644 > URL: https://issues.apache.org/jira/browse/THRIFT-2644 > Project: Thrift > Issue Type: Improvement > Components: Haxe - Compiler, Haxe - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.9.3 > > Attachments: THRIFT-2644_haxe.patch > > > I'm currently about to prepare a patch to include [Haxe|http://haxe.org/] > support into Thrift over there in my [GitHub Thrift > fork|https://github.com/Jens-G/thrift/tree/haxe]. If anyone has an interest > in this and wants to join for development, testing and/or review, you're > welcome - just drop me a mail. I'll update this ticket accordingly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-2806) more whitespace fixups
Jens Geyer created THRIFT-2806: -- Summary: more whitespace fixups Key: THRIFT-2806 URL: https://issues.apache.org/jira/browse/THRIFT-2806 Project: Thrift Issue Type: Improvement Components: Haxe - Library Affects Versions: 0.9.3 Reporter: Jens Geyer Assignee: Jens Geyer Priority: Trivial Fix For: 0.9.3 Whitespace fixups according to formatting guidelines -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2806) more whitespace fixups
[ https://issues.apache.org/jira/browse/THRIFT-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2806. Resolution: Fixed Tested & committed > more whitespace fixups > -- > > Key: THRIFT-2806 > URL: https://issues.apache.org/jira/browse/THRIFT-2806 > Project: Thrift > Issue Type: Improvement > Components: Haxe - Library >Affects Versions: 0.9.3 >Reporter: Jens Geyer >Assignee: Jens Geyer >Priority: Trivial > Fix For: 0.9.3 > > > Whitespace fixups according to formatting guidelines -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-2811) Make remote socket address accessible
Jens Geyer created THRIFT-2811: -- Summary: Make remote socket address accessible Key: THRIFT-2811 URL: https://issues.apache.org/jira/browse/THRIFT-2811 Project: Thrift Issue Type: Improvement Components: Go - Library Reporter: Jens Geyer Assignee: Jens Geyer Fix For: 0.9.3 GitHub user captncraig opened a pull request: https://github.com/apache/thrift/pull/255 Go Library - Make remote socket address accessible In my server I would like to log the remote ip address of incoming connections. This patch makes the addr available on TSocket via an accessor, so my server implementation can read it and log it or do other things with it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/captncraig/thrift addr Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/255.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #255 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2811) Make remote socket address accessible
[ https://issues.apache.org/jira/browse/THRIFT-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2811. Resolution: Fixed Committed, thanks Craig! > Make remote socket address accessible > - > > Key: THRIFT-2811 > URL: https://issues.apache.org/jira/browse/THRIFT-2811 > Project: Thrift > Issue Type: Improvement > Components: Go - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.9.3 > > > GitHub user captncraig opened a pull request: > https://github.com/apache/thrift/pull/255 > Go Library - Make remote socket address accessible > In my server I would like to log the remote ip address of incoming > connections. This patch makes the addr available on TSocket via an accessor, > so my server implementation can read it and log it or do other things with it. > You can merge this pull request into a Git repository by running: > $ git pull https://github.com/captncraig/thrift addr > Alternatively you can review and apply these changes as the patch at: > https://github.com/apache/thrift/pull/255.patch > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > This closes #255 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2807) PHP Code Style
[ https://issues.apache.org/jira/browse/THRIFT-2807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2807: --- Component/s: PHP - Library > PHP Code Style > -- > > Key: THRIFT-2807 > URL: https://issues.apache.org/jira/browse/THRIFT-2807 > Project: Thrift > Issue Type: Improvement > Components: PHP - Library >Reporter: Roger Thomas >Priority: Minor > > The Code Style of the PHP Library is seemingly non-consitent (depending on > who's been writing it). > I've proposed a PR (https://github.com/apache/thrift/pull/252) that runs a > simple php-cs-fixer across the library to amend code style (tabs, bracket > alignment etc). > The Travis build has executed and passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2812) Go server adding redundant buffering layer
[ https://issues.apache.org/jira/browse/THRIFT-2812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2812: --- Patch Info: Patch Available Affects Version/s: 0.9.2 Fix Version/s: 0.9.3 Assignee: Jens Geyer > Go server adding redundant buffering layer > -- > > Key: THRIFT-2812 > URL: https://issues.apache.org/jira/browse/THRIFT-2812 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Affects Versions: 0.9.2 >Reporter: Stephen Marbowitz >Assignee: Jens Geyer > Fix For: 0.9.3 > > > THRIFT-2791 incorrectly assumed there was no way to do buffered sockets on > the server. The solution is to simply use a TBufferedTransportFActory and > give it to the server at creation time. Can we please revert that patch? Any > code that was previously using buffered server sockets now has an extra layer > of buffering. I consider this a breaking change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2812) Go server adding redundant buffering layer
[ https://issues.apache.org/jira/browse/THRIFT-2812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2812. Resolution: Fixed Committed, thanks for catching this. > Go server adding redundant buffering layer > -- > > Key: THRIFT-2812 > URL: https://issues.apache.org/jira/browse/THRIFT-2812 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Affects Versions: 0.9.2 >Reporter: Stephen Marbowitz >Assignee: Jens Geyer > Fix For: 0.9.3 > > > THRIFT-2791 incorrectly assumed there was no way to do buffered sockets on > the server. The solution is to simply use a TBufferedTransportFActory and > give it to the server at creation time. Can we please revert that patch? Any > code that was previously using buffered server sockets now has an extra layer > of buffering. I consider this a breaking change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-2813) multiple haxe library fixes/improvements
Jens Geyer created THRIFT-2813: -- Summary: multiple haxe library fixes/improvements Key: THRIFT-2813 URL: https://issues.apache.org/jira/browse/THRIFT-2813 Project: Thrift Issue Type: Bug Components: Haxe - Library Reporter: Jens Geyer Assignee: Jens Geyer Fix For: 0.9.3 multiple Haxe library fixes/improvements: - TSocket ignores timeout on read() - TFramedTransport throws Eof after first receive cycle - TFramedTransport .flush() did not invoke the read callback - incorrect declaration of logDelegate member variable - added FlashDevelop project files - added Haxe files to EXTRA_DIST etc. - added haxelib.json control file for haxelib.org -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-2814) args/result classes not found when no namespace is set
Jens Geyer created THRIFT-2814:
--
Summary: args/result classes not found when no namespace is set
Key: THRIFT-2814
URL: https://issues.apache.org/jira/browse/THRIFT-2814
Project: Thrift
Issue Type: Bug
Components: Haxe - Compiler
Reporter: Jens Geyer
Assignee: Jens Geyer
Fix For: 0.9.3
The args/results helper classes are not found by the Haxe compiler if no
namespaces are set in the IDL. With Haxe, classes are located via:
(1) the file name matching the class name
(2) wildcard {{namespace.*}} imports.
With an empty namespace only the first method is used. Because the helper
classes are located within the (e.g.) {{MethodCall_Impl.hx}} file instead the
{{MethodCall_args.hx}} file, they are not found in that case.
Changes:
- generate one source file per Haxe class
- ensure correctly capitalized names in all cases
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (THRIFT-2815) Haxe: Support for Multiplexing Services on any Transport, Protocol and Server
Jens Geyer created THRIFT-2815: -- Summary: Haxe: Support for Multiplexing Services on any Transport, Protocol and Server Key: THRIFT-2815 URL: https://issues.apache.org/jira/browse/THRIFT-2815 Project: Thrift Issue Type: Sub-task Components: Haxe - Library Reporter: Jens Geyer Assignee: Jens Geyer Fix For: 0.9.3 Multiplexing support, see THRIFT-563 & THRIFT-1915 for details -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2813) multiple haxe library fixes/improvements
[ https://issues.apache.org/jira/browse/THRIFT-2813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2813. Resolution: Fixed committed > multiple haxe library fixes/improvements > > > Key: THRIFT-2813 > URL: https://issues.apache.org/jira/browse/THRIFT-2813 > Project: Thrift > Issue Type: Bug > Components: Haxe - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.9.3 > > > multiple Haxe library fixes/improvements: > - TSocket ignores timeout on read() > - TFramedTransport throws Eof after first receive cycle > - TFramedTransport .flush() did not invoke the read callback > - incorrect declaration of logDelegate member variable > - added FlashDevelop project files > - added Haxe files to EXTRA_DIST etc. > - added haxelib.json control file for haxelib.org -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2815) Haxe: Support for Multiplexing Services on any Transport, Protocol and Server
[ https://issues.apache.org/jira/browse/THRIFT-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2815. Resolution: Fixed committed > Haxe: Support for Multiplexing Services on any Transport, Protocol and Server > - > > Key: THRIFT-2815 > URL: https://issues.apache.org/jira/browse/THRIFT-2815 > Project: Thrift > Issue Type: Sub-task > Components: Haxe - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.9.3 > > > Multiplexing support, see THRIFT-563 & THRIFT-1915 for details -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2814) args/result classes not found when no namespace is set
[
https://issues.apache.org/jira/browse/THRIFT-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-2814.
Resolution: Fixed
committed
> args/result classes not found when no namespace is set
> --
>
> Key: THRIFT-2814
> URL: https://issues.apache.org/jira/browse/THRIFT-2814
> Project: Thrift
> Issue Type: Bug
> Components: Haxe - Compiler
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Fix For: 0.9.3
>
>
> The args/results helper classes are not found by the Haxe compiler if no
> namespaces are set in the IDL. With Haxe, classes are located via:
> (1) the file name matching the class name
> (2) wildcard {{namespace.*}} imports.
> With an empty namespace only the first method is used. Because the helper
> classes are located within the (e.g.) {{MethodCall_Impl.hx}} file instead the
> {{MethodCall_args.hx}} file, they are not found in that case.
> Changes:
> - generate one source file per Haxe class
> - ensure correctly capitalized names in all cases
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (THRIFT-2824) Flag to disable html escaping doctext
[ https://issues.apache.org/jira/browse/THRIFT-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-2824: -- Assignee: Jens Geyer > Flag to disable html escaping doctext > - > > Key: THRIFT-2824 > URL: https://issues.apache.org/jira/browse/THRIFT-2824 > Project: Thrift > Issue Type: New Feature > Components: HTML - Compiler >Affects Versions: 0.9.2 >Reporter: Craig Peterson >Assignee: Jens Geyer >Priority: Minor > > We use the html generator to create and publish documentation for our > services. We primarily use the program level doctext to insert html > documentation for the entire service. > We would like to add richer content up top, but are limited by the escaping > performed by the html generator on doctexts. > This patch adds the "noescape" flag to simply render doctexts as-is. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2818) Trailing commas in array
[ https://issues.apache.org/jira/browse/THRIFT-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-2818. -- Resolution: Fixed Fix Version/s: 0.9.3 Assignee: Jens Geyer Committed, thanks. > Trailing commas in array > > > Key: THRIFT-2818 > URL: https://issues.apache.org/jira/browse/THRIFT-2818 > Project: Thrift > Issue Type: Bug > Components: Node.js - Library >Reporter: Chi Vinh Le >Assignee: Jens Geyer >Priority: Minor > Fix For: 0.9.3 > > > There are trailing commas in array defined in thrift.js. > When using browserify, this causes parsing errors in older browsers. > https://github.com/apache/thrift/pull/263 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-2826) html:standalone sometimes ignored
Jens Geyer created THRIFT-2826:
--
Summary: html:standalone sometimes ignored
Key: THRIFT-2826
URL: https://issues.apache.org/jira/browse/THRIFT-2826
Project: Thrift
Issue Type: Bug
Components: HTML - Compiler
Reporter: Jens Geyer
Assignee: Jens Geyer
Fix For: 0.9.3
In some cases the generated HTML contains references/links to the file name,
even though the {{standalone}} flag was set.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (THRIFT-2826) html:standalone sometimes ignored
[
https://issues.apache.org/jira/browse/THRIFT-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer closed THRIFT-2826.
--
Resolution: Fixed
Committed.
> html:standalone sometimes ignored
> -
>
> Key: THRIFT-2826
> URL: https://issues.apache.org/jira/browse/THRIFT-2826
> Project: Thrift
> Issue Type: Bug
> Components: HTML - Compiler
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Fix For: 0.9.3
>
>
> In some cases the generated HTML contains references/links to the file name,
> even though the {{standalone}} flag was set.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (THRIFT-2824) Flag to disable html escaping doctext
[ https://issues.apache.org/jira/browse/THRIFT-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-2824. -- Resolution: Fixed Fix Version/s: 0.9.3 Committed. Nice idea. > Flag to disable html escaping doctext > - > > Key: THRIFT-2824 > URL: https://issues.apache.org/jira/browse/THRIFT-2824 > Project: Thrift > Issue Type: New Feature > Components: HTML - Compiler >Affects Versions: 0.9.2 >Reporter: Craig Peterson >Assignee: Jens Geyer >Priority: Minor > Fix For: 0.9.3 > > > We use the html generator to create and publish documentation for our > services. We primarily use the program level doctext to insert html > documentation for the entire service. > We would like to add richer content up top, but are limited by the escaping > performed by the html generator on doctexts. > This patch adds the "noescape" flag to simply render doctexts as-is. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-2828) slightly wrong help screen indent
Jens Geyer created THRIFT-2828:
--
Summary: slightly wrong help screen indent
Key: THRIFT-2828
URL: https://issues.apache.org/jira/browse/THRIFT-2828
Project: Thrift
Issue Type: Bug
Components: Compiler (General)
Reporter: Jens Geyer
Assignee: Jens Geyer
Priority: Trivial
Fix For: 0.9.3
Some options shown in the {{thrift --help}} screen are slightly misaligned.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (THRIFT-2829) Support haxelib installation via github
Jens Geyer created THRIFT-2829:
--
Summary: Support haxelib installation via github
Key: THRIFT-2829
URL: https://issues.apache.org/jira/browse/THRIFT-2829
Project: Thrift
Issue Type: Bug
Components: Haxe - Library
Reporter: Jens Geyer
Assignee: Jens Geyer
Fix For: 0.9.3
The haxelib tool supports installation via GitHub. Because haxelib.org
currently does not support the Apache 2.0 license option, the library cannot be
installed via {{haxelib install}]. However, since the {{haxelib git}] option is
fully functional with regard to updates, we can use that option without much
problems.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-2829) Support haxelib installation via github
[
https://issues.apache.org/jira/browse/THRIFT-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-2829.
Resolution: Fixed
Committed.
> Support haxelib installation via github
> ---
>
> Key: THRIFT-2829
> URL: https://issues.apache.org/jira/browse/THRIFT-2829
> Project: Thrift
> Issue Type: Bug
> Components: Haxe - Library
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Fix For: 0.9.3
>
>
> The haxelib tool supports installation via GitHub. Because haxelib.org
> currently does not support the Apache 2.0 license option, the library cannot
> be installed via {{haxelib install}]. However, since the {{haxelib git}]
> option is fully functional with regard to updates, we can use that option
> without much problems.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-2828) slightly wrong help screen indent
[
https://issues.apache.org/jira/browse/THRIFT-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-2828.
Resolution: Fixed
Committed.
> slightly wrong help screen indent
> -
>
> Key: THRIFT-2828
> URL: https://issues.apache.org/jira/browse/THRIFT-2828
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
>Reporter: Jens Geyer
>Assignee: Jens Geyer
>Priority: Trivial
> Fix For: 0.9.3
>
>
> Some options shown in the {{thrift --help}} screen are slightly misaligned.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-2829) Support haxelib installation via github
[
https://issues.apache.org/jira/browse/THRIFT-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-2829:
---
Description: The haxelib tool supports installation via GitHub. Because
haxelib.org currently does not support the Apache 2.0 license option, the
library cannot be installed via {{haxelib install}}. However, since the
{{haxelib git}} option is fully functional with regard to updates, we can use
that option without much problems. (was: The haxelib tool supports
installation via GitHub. Because haxelib.org currently does not support the
Apache 2.0 license option, the library cannot be installed via {{haxelib
install}]. However, since the {{haxelib git}] option is fully functional with
regard to updates, we can use that option without much problems.)
> Support haxelib installation via github
> ---
>
> Key: THRIFT-2829
> URL: https://issues.apache.org/jira/browse/THRIFT-2829
> Project: Thrift
> Issue Type: Bug
> Components: Haxe - Library
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Fix For: 0.9.3
>
>
> The haxelib tool supports installation via GitHub. Because haxelib.org
> currently does not support the Apache 2.0 license option, the library cannot
> be installed via {{haxelib install}}. However, since the {{haxelib git}}
> option is fully functional with regard to updates, we can use that option
> without much problems.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (THRIFT-2839) TFramedTransport read bug
[ https://issues.apache.org/jira/browse/THRIFT-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-2839: -- Assignee: Jens Geyer > TFramedTransport read bug > - > > Key: THRIFT-2839 > URL: https://issues.apache.org/jira/browse/THRIFT-2839 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Affects Versions: 0.9.2 >Reporter: Chi Vinh Le >Assignee: Jens Geyer > > When calling TFramedTransport.Read, it should return remaining bytes. > Currently throws an error without reading, when passing a []byte that is > bigger than frame_size. > PR available at: https://github.com/apache/thrift/pull/273 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Reopened] (THRIFT-2814) args/result classes not found when no namespace is set
[
https://issues.apache.org/jira/browse/THRIFT-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer reopened THRIFT-2814:
The fix breaks namespaced types in some cases.
> args/result classes not found when no namespace is set
> --
>
> Key: THRIFT-2814
> URL: https://issues.apache.org/jira/browse/THRIFT-2814
> Project: Thrift
> Issue Type: Bug
> Components: Haxe - Compiler
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Fix For: 0.9.3
>
>
> The args/results helper classes are not found by the Haxe compiler if no
> namespaces are set in the IDL. With Haxe, classes are located via:
> (1) the file name matching the class name
> (2) wildcard {{namespace.*}} imports.
> With an empty namespace only the first method is used. Because the helper
> classes are located within the (e.g.) {{MethodCall_Impl.hx}} file instead the
> {{MethodCall_args.hx}} file, they are not found in that case.
> Changes:
> - generate one source file per Haxe class
> - ensure correctly capitalized names in all cases
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-2814) args/result classes not found when no namespace is set
[
https://issues.apache.org/jira/browse/THRIFT-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-2814.
Resolution: Fixed
Committed.
> args/result classes not found when no namespace is set
> --
>
> Key: THRIFT-2814
> URL: https://issues.apache.org/jira/browse/THRIFT-2814
> Project: Thrift
> Issue Type: Bug
> Components: Haxe - Compiler
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Fix For: 0.9.3
>
>
> The args/results helper classes are not found by the Haxe compiler if no
> namespaces are set in the IDL. With Haxe, classes are located via:
> (1) the file name matching the class name
> (2) wildcard {{namespace.*}} imports.
> With an empty namespace only the first method is used. Because the helper
> classes are located within the (e.g.) {{MethodCall_Impl.hx}} file instead the
> {{MethodCall_args.hx}} file, they are not found in that case.
> Changes:
> - generate one source file per Haxe class
> - ensure correctly capitalized names in all cases
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (THRIFT-2817) TSimpleJSONProtocol reads beyond end of message
[ https://issues.apache.org/jira/browse/THRIFT-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-2817: -- Assignee: Jens Geyer > TSimpleJSONProtocol reads beyond end of message > --- > > Key: THRIFT-2817 > URL: https://issues.apache.org/jira/browse/THRIFT-2817 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Reporter: Chi Vinh Le >Assignee: Jens Geyer > > The TSimpleJSONProtocol reads beyond end of message, which prevent processing > the message until more data arrives. > https://github.com/apache/thrift/pull/264 > EDIT: New pull request here: > https://github.com/apache/thrift/pull/273 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-2841) Add comprehensive integration tests for the whole Go stack
Jens Geyer created THRIFT-2841: -- Summary: Add comprehensive integration tests for the whole Go stack Key: THRIFT-2841 URL: https://issues.apache.org/jira/browse/THRIFT-2841 Project: Thrift Issue Type: Sub-task Components: Go - Library Reporter: Jens Geyer Assignee: Jens Geyer Fix For: 0.9.3 Issue extracted from THRIFT-2817: > To test THRIFT-2817 fix I ported the integration tests from the nodejs thrift > library to go. > Those are comprehensive integration tests that tests the whole thrift stack. > The tests revealed another problem in TFramedTransport (see THRIFT-2839) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2841) Add comprehensive integration tests for the whole Go stack
[ https://issues.apache.org/jira/browse/THRIFT-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2841. Resolution: Fixed Committed, thanks! > Add comprehensive integration tests for the whole Go stack > -- > > Key: THRIFT-2841 > URL: https://issues.apache.org/jira/browse/THRIFT-2841 > Project: Thrift > Issue Type: Sub-task > Components: Go - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.9.3 > > > Issue extracted from THRIFT-2817: > > To test THRIFT-2817 fix I ported the integration tests from the nodejs > > thrift library to go. > > Those are comprehensive integration tests that tests the whole thrift stack. > > The tests revealed another problem in TFramedTransport (see THRIFT-2839) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2839) TFramedTransport read bug
[ https://issues.apache.org/jira/browse/THRIFT-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2839. Resolution: Fixed Fix Version/s: 0.9.3 Committed, thanks! > TFramedTransport read bug > - > > Key: THRIFT-2839 > URL: https://issues.apache.org/jira/browse/THRIFT-2839 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Affects Versions: 0.9.2 >Reporter: Chi Vinh Le >Assignee: Jens Geyer > Fix For: 0.9.3 > > > When calling TFramedTransport.Read, it should return remaining bytes. > Currently throws an error without reading, when passing a []byte that is > bigger than frame_size. > PR available at: https://github.com/apache/thrift/pull/273 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2817) TSimpleJSONProtocol reads beyond end of message
[ https://issues.apache.org/jira/browse/THRIFT-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2817. Resolution: Fixed Fix Version/s: 0.9.3 Committed, thanks! > TSimpleJSONProtocol reads beyond end of message > --- > > Key: THRIFT-2817 > URL: https://issues.apache.org/jira/browse/THRIFT-2817 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Reporter: Chi Vinh Le >Assignee: Jens Geyer > Fix For: 0.9.3 > > > The TSimpleJSONProtocol reads beyond end of message, which prevent processing > the message until more data arrives. > https://github.com/apache/thrift/pull/264 > EDIT: New pull request here: > https://github.com/apache/thrift/pull/273 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2790) thrift -gen all => an option to generate all languages and features
[
https://issues.apache.org/jira/browse/THRIFT-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216816#comment-14216816
]
Jens Geyer commented on THRIFT-2790:
Nice (except for the tabs :-)), but this still does not cover {{js:node}} and
the like. To be honest, I have no idea how these "special" switches could be
distinguished from the "normal" ones. Maybe we need to pass some special flag
or option when registering the generators to have these information somewhere,
somehow present.
> thrift -gen all => an option to generate all languages and features
> ---
>
> Key: THRIFT-2790
> URL: https://issues.apache.org/jira/browse/THRIFT-2790
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General), Documentation, Test Suite
>Reporter: Roger Meier
> Attachments:
> 0001-THRIFT-2790-gen-all-option-to-easily-test-compatibil.patch,
> generate-all-languages.bat
>
>
> I would like to have a *thrift -gen all* option to generate everything we
> have in one step. This would allow proper testing of all compiler changes by
> using test/ThriftTest.thrift. An optional make check target could compare
> different versions based on their git hash or to previous gen-all.backup
> folder.
> Suggested-by: Roger Meier
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-2213) java.lang.NoSuchMethodError: thrift org.apache.thrift.EncodingUtils.setBit(BIZ)B
[ https://issues.apache.org/jira/browse/THRIFT-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2213: --- Summary: java.lang.NoSuchMethodError: thrift org.apache.thrift.EncodingUtils.setBit(BIZ)B (was: thrift org.apache.thrift.EncodingUtils.setBit(BIZ)B) > java.lang.NoSuchMethodError: thrift > org.apache.thrift.EncodingUtils.setBit(BIZ)B > > > Key: THRIFT-2213 > URL: https://issues.apache.org/jira/browse/THRIFT-2213 > Project: Thrift > Issue Type: Bug > Components: Java - Library >Reporter: lianwenbo > > Exception in thread "main" java.lang.NoSuchMethodError: > org.apache.thrift.EncodingUtils.setBit(BIZ)B > at > org.apache.hadoop.hive.ql.plan.api.Query.setStartedIsSet(Query.java:487) > at org.apache.hadoop.hive.ql.plan.api.Query.setStarted(Query.java:474) > at > org.apache.hadoop.hive.ql.QueryPlan.updateCountersInQueryPlan(QueryPlan.java:304) > at org.apache.hadoop.hive.ql.QueryPlan.getQueryPlan(QueryPlan.java:437) > at org.apache.hadoop.hive.ql.QueryPlan.toString(QueryPlan.java:609) > at > org.apache.hadoop.hive.ql.history.HiveHistory.logPlanProgress(HiveHistory.java:499) > at org.apache.hadoop.hive.ql.Driver.execute(Driver.java:1059) > at org.apache.hadoop.hive.ql.Driver.run(Driver.java:935) > at > org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:259) > at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:216) > at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:412) > at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:755) > at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:613) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at org.apache.hadoop.util.RunJar.main(RunJar.java:156) > When running the show tables in hive cli, I find the above errors. I try to > reinstall the thriftlib,but make no use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2796) Testcase for THRIFT-2793
[
https://issues.apache.org/jira/browse/THRIFT-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14220225#comment-14220225
]
Jens Geyer commented on THRIFT-2796:
Hi [~magiconair],
thanks for the patch!
Some comments though:
1. Please move the test from {{test/go}} into {{lib/go/test}}. Don't worry,
that's a common misunderstanding: The {{test}} folder is reserved for the
standard Thrift cross test only. All other tests should be placed under
{{lib/language/test}}
2. Re the Yosemite and Ubuntu build problems: Please search JIRA for similar
issues. There have been a few fixes in the last days, not sure however whether
or not these cover your particular issue. You may also consider to discuss this
on the mailing list and/or file a separate JIRA ticket.
Overall -1 for this pull request, but please keep contributing.
> Testcase for THRIFT-2793
>
>
> Key: THRIFT-2796
> URL: https://issues.apache.org/jira/browse/THRIFT-2796
> Project: Thrift
> Issue Type: Test
> Components: Go - Compiler
>Reporter: Jens Geyer
> Fix For: 1.0
>
>
> Add test for THRIFT-2793 Go compiler produces uncompilable code
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (THRIFT-2796) Testcase for THRIFT-2793
[
https://issues.apache.org/jira/browse/THRIFT-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14220225#comment-14220225
]
Jens Geyer edited comment on THRIFT-2796 at 11/20/14 11:46 PM:
---
Hi [~magiconair],
thanks for the patch!
Some comments though:
1. Please move the test from {{test/go}} into {{lib/go/test}}. Don't worry,
that's a common misunderstanding: The {{test}} folder is reserved for the
standard Thrift cross test only. All other tests should be placed under
{{lib/language/test}}
2. The newly added file is lacking the ASF license header.
3. Re the Yosemite and Ubuntu build problems: Please search JIRA for similar
issues. There have been a few fixes in the last days, not sure however whether
or not these cover your particular issue. You may also consider to discuss this
on the mailing list and/or file a separate JIRA ticket.
Overall -1 for this pull request, but please keep contributing.
was (Author: jensg):
Hi [~magiconair],
thanks for the patch!
Some comments though:
1. Please move the test from {{test/go}} into {{lib/go/test}}. Don't worry,
that's a common misunderstanding: The {{test}} folder is reserved for the
standard Thrift cross test only. All other tests should be placed under
{{lib/language/test}}
2. Re the Yosemite and Ubuntu build problems: Please search JIRA for similar
issues. There have been a few fixes in the last days, not sure however whether
or not these cover your particular issue. You may also consider to discuss this
on the mailing list and/or file a separate JIRA ticket.
Overall -1 for this pull request, but please keep contributing.
> Testcase for THRIFT-2793
>
>
> Key: THRIFT-2796
> URL: https://issues.apache.org/jira/browse/THRIFT-2796
> Project: Thrift
> Issue Type: Test
> Components: Go - Compiler
>Reporter: Jens Geyer
> Fix For: 1.0
>
>
> Add test for THRIFT-2793 Go compiler produces uncompilable code
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (THRIFT-2847) function IfValue() is a duplicate of System.StrUtils.IfThen
Jens Geyer created THRIFT-2847:
--
Summary: function IfValue() is a duplicate of
System.StrUtils.IfThen
Key: THRIFT-2847
URL: https://issues.apache.org/jira/browse/THRIFT-2847
Project: Thrift
Issue Type: Bug
Components: Delphi - Library
Reporter: Jens Geyer
Assignee: Jens Geyer
Priority: Minor
Fix For: 0.9.3
unnecessary helper function:
{{IfValue}} is a duplicate of
[{{System.StrUtils.IfThen}}|http://docwiki.embarcadero.com/Libraries/XE7/en/System.StrUtils.IfThen]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-2847) function IfValue() is a duplicate of System.StrUtils.IfThen
[
https://issues.apache.org/jira/browse/THRIFT-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-2847.
Resolution: Fixed
That function seems not to be used anywhere at all.
Committed, thanks!
> function IfValue() is a duplicate of System.StrUtils.IfThen
> ---
>
> Key: THRIFT-2847
> URL: https://issues.apache.org/jira/browse/THRIFT-2847
> Project: Thrift
> Issue Type: Bug
> Components: Delphi - Library
>Reporter: Jens Geyer
>Assignee: Jens Geyer
>Priority: Minor
> Fix For: 0.9.3
>
>
> unnecessary helper function:
> {{IfValue}} is a duplicate of
> [{{System.StrUtils.IfThen}}|http://docwiki.embarcadero.com/Libraries/XE7/en/System.StrUtils.IfThen]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (THRIFT-2848) certain Delphi tests do not build if TypeRegistry is used
Jens Geyer created THRIFT-2848:
--
Summary: certain Delphi tests do not build if TypeRegistry is used
Key: THRIFT-2848
URL: https://issues.apache.org/jira/browse/THRIFT-2848
Project: Thrift
Issue Type: Bug
Components: Delphi - Library
Reporter: Jens Geyer
Assignee: Jens Geyer
Priority: Minor
Fix For: 0.9.3
Unit Thrift.TypeRegistry is needed when the {{TypeRegistry}} switch is used. In
that case certain samples/tests do not build without manual intervention.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-2848) certain Delphi tests do not build if TypeRegistry is used
[
https://issues.apache.org/jira/browse/THRIFT-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-2848:
---
Attachment: THRIFT-2848-certain-Delphi-tests-do-not-build-if-Typ.patch
> certain Delphi tests do not build if TypeRegistry is used
> -
>
> Key: THRIFT-2848
> URL: https://issues.apache.org/jira/browse/THRIFT-2848
> Project: Thrift
> Issue Type: Bug
> Components: Delphi - Library
>Reporter: Jens Geyer
>Assignee: Jens Geyer
>Priority: Minor
> Fix For: 0.9.3
>
> Attachments:
> THRIFT-2848-certain-Delphi-tests-do-not-build-if-Typ.patch
>
>
> Unit Thrift.TypeRegistry is needed when the {{TypeRegistry}} switch is used.
> In that case certain samples/tests do not build without manual intervention.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-2848) certain Delphi tests do not build if TypeRegistry is used
[
https://issues.apache.org/jira/browse/THRIFT-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-2848.
Resolution: Fixed
Committed.
> certain Delphi tests do not build if TypeRegistry is used
> -
>
> Key: THRIFT-2848
> URL: https://issues.apache.org/jira/browse/THRIFT-2848
> Project: Thrift
> Issue Type: Bug
> Components: Delphi - Library
>Reporter: Jens Geyer
>Assignee: Jens Geyer
>Priority: Minor
> Fix For: 0.9.3
>
> Attachments:
> THRIFT-2848-certain-Delphi-tests-do-not-build-if-Typ.patch
>
>
> Unit Thrift.TypeRegistry is needed when the {{TypeRegistry}} switch is used.
> In that case certain samples/tests do not build without manual intervention.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (THRIFT-2839) TFramedTransport read bug
[ https://issues.apache.org/jira/browse/THRIFT-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-2839. -- > TFramedTransport read bug > - > > Key: THRIFT-2839 > URL: https://issues.apache.org/jira/browse/THRIFT-2839 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Affects Versions: 0.9.2 >Reporter: Chi Vinh Le >Assignee: Jens Geyer > Fix For: 0.9.3 > > > When calling TFramedTransport.Read, it should return remaining bytes. > Currently throws an error without reading, when passing a []byte that is > bigger than frame_size. > PR available at: https://github.com/apache/thrift/pull/273 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2829) Support haxelib installation via github
[
https://issues.apache.org/jira/browse/THRIFT-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer closed THRIFT-2829.
--
> Support haxelib installation via github
> ---
>
> Key: THRIFT-2829
> URL: https://issues.apache.org/jira/browse/THRIFT-2829
> Project: Thrift
> Issue Type: Bug
> Components: Haxe - Library
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Fix For: 0.9.3
>
>
> The haxelib tool supports installation via GitHub. Because haxelib.org
> currently does not support the Apache 2.0 license option, the library cannot
> be installed via {{haxelib install}}. However, since the {{haxelib git}}
> option is fully functional with regard to updates, we can use that option
> without much problems.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (THRIFT-2815) Haxe: Support for Multiplexing Services on any Transport, Protocol and Server
[ https://issues.apache.org/jira/browse/THRIFT-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-2815. -- > Haxe: Support for Multiplexing Services on any Transport, Protocol and Server > - > > Key: THRIFT-2815 > URL: https://issues.apache.org/jira/browse/THRIFT-2815 > Project: Thrift > Issue Type: Sub-task > Components: Haxe - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.9.3 > > > Multiplexing support, see THRIFT-563 & THRIFT-1915 for details -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2753) Misc. Haxe improvements
[ https://issues.apache.org/jira/browse/THRIFT-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-2753. -- > Misc. Haxe improvements > --- > > Key: THRIFT-2753 > URL: https://issues.apache.org/jira/browse/THRIFT-2753 > Project: Thrift > Issue Type: Sub-task > Components: Haxe - Compiler, Haxe - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.9.3 > > > This is the second part of the Haxe addition started with THRIFT-2644, > completing the base feature set with HTTP client and stream transports. > *Test improvements* > - added missing testException tests > - aligned cross test return codes > - aligned cross test command line arguments > - added --skip-speed-test switch > *Code generator improvements* > - added suffix "_FIELD_ID" to the fieldIDs to prevent name collisions with > uppercase-only members (like ID, VAT) > - always render enum type with full namespace to prevent name collisions with > class members > *Library improvements* > - HTTP transport client added > - Generic Stream transport added, implemented FileStream transport > - fixed possible double UTF-8 encoding/decoding in JSON protocol > - Haxe Thrift library test project added -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2841) Add comprehensive integration tests for the whole Go stack
[ https://issues.apache.org/jira/browse/THRIFT-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-2841. -- > Add comprehensive integration tests for the whole Go stack > -- > > Key: THRIFT-2841 > URL: https://issues.apache.org/jira/browse/THRIFT-2841 > Project: Thrift > Issue Type: Sub-task > Components: Go - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.9.3 > > > Issue extracted from THRIFT-2817: > > To test THRIFT-2817 fix I ported the integration tests from the nodejs > > thrift library to go. > > Those are comprehensive integration tests that tests the whole thrift stack. > > The tests revealed another problem in TFramedTransport (see THRIFT-2839) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2811) Make remote socket address accessible
[ https://issues.apache.org/jira/browse/THRIFT-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-2811. -- > Make remote socket address accessible > - > > Key: THRIFT-2811 > URL: https://issues.apache.org/jira/browse/THRIFT-2811 > Project: Thrift > Issue Type: Improvement > Components: Go - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.9.3 > > > GitHub user captncraig opened a pull request: > https://github.com/apache/thrift/pull/255 > Go Library - Make remote socket address accessible > In my server I would like to log the remote ip address of incoming > connections. This patch makes the addr available on TSocket via an accessor, > so my server implementation can read it and log it or do other things with it. > You can merge this pull request into a Git repository by running: > $ git pull https://github.com/captncraig/thrift addr > Alternatively you can review and apply these changes as the patch at: > https://github.com/apache/thrift/pull/255.patch > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > This closes #255 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2806) more whitespace fixups
[ https://issues.apache.org/jira/browse/THRIFT-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-2806. -- > more whitespace fixups > -- > > Key: THRIFT-2806 > URL: https://issues.apache.org/jira/browse/THRIFT-2806 > Project: Thrift > Issue Type: Improvement > Components: Haxe - Library >Affects Versions: 0.9.3 >Reporter: Jens Geyer >Assignee: Jens Geyer >Priority: Trivial > Fix For: 0.9.3 > > > Whitespace fixups according to formatting guidelines -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2644) Haxe support
[ https://issues.apache.org/jira/browse/THRIFT-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-2644. -- > Haxe support > > > Key: THRIFT-2644 > URL: https://issues.apache.org/jira/browse/THRIFT-2644 > Project: Thrift > Issue Type: Improvement > Components: Haxe - Compiler, Haxe - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.9.3 > > Attachments: THRIFT-2644_haxe.patch > > > I'm currently about to prepare a patch to include [Haxe|http://haxe.org/] > support into Thrift over there in my [GitHub Thrift > fork|https://github.com/Jens-G/thrift/tree/haxe]. If anyone has an interest > in this and wants to join for development, testing and/or review, you're > welcome - just drop me a mail. I'll update this ticket accordingly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2812) Go server adding redundant buffering layer
[ https://issues.apache.org/jira/browse/THRIFT-2812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-2812. -- > Go server adding redundant buffering layer > -- > > Key: THRIFT-2812 > URL: https://issues.apache.org/jira/browse/THRIFT-2812 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Affects Versions: 0.9.2 >Reporter: Stephen Marbowitz >Assignee: Jens Geyer > Fix For: 0.9.3 > > > THRIFT-2791 incorrectly assumed there was no way to do buffered sockets on > the server. The solution is to simply use a TBufferedTransportFActory and > give it to the server at creation time. Can we please revert that patch? Any > code that was previously using buffered server sockets now has an extra layer > of buffering. I consider this a breaking change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2828) slightly wrong help screen indent
[
https://issues.apache.org/jira/browse/THRIFT-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer closed THRIFT-2828.
--
> slightly wrong help screen indent
> -
>
> Key: THRIFT-2828
> URL: https://issues.apache.org/jira/browse/THRIFT-2828
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
>Reporter: Jens Geyer
>Assignee: Jens Geyer
>Priority: Trivial
> Fix For: 0.9.3
>
>
> Some options shown in the {{thrift --help}} screen are slightly misaligned.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (THRIFT-2813) multiple haxe library fixes/improvements
[ https://issues.apache.org/jira/browse/THRIFT-2813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-2813. -- > multiple haxe library fixes/improvements > > > Key: THRIFT-2813 > URL: https://issues.apache.org/jira/browse/THRIFT-2813 > Project: Thrift > Issue Type: Bug > Components: Haxe - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.9.3 > > > multiple Haxe library fixes/improvements: > - TSocket ignores timeout on read() > - TFramedTransport throws Eof after first receive cycle > - TFramedTransport .flush() did not invoke the read callback > - incorrect declaration of logDelegate member variable > - added FlashDevelop project files > - added Haxe files to EXTRA_DIST etc. > - added haxelib.json control file for haxelib.org -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2817) TSimpleJSONProtocol reads beyond end of message
[ https://issues.apache.org/jira/browse/THRIFT-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-2817. -- > TSimpleJSONProtocol reads beyond end of message > --- > > Key: THRIFT-2817 > URL: https://issues.apache.org/jira/browse/THRIFT-2817 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Reporter: Chi Vinh Le >Assignee: Jens Geyer > Fix For: 0.9.3 > > > The TSimpleJSONProtocol reads beyond end of message, which prevent processing > the message until more data arrives. > https://github.com/apache/thrift/pull/264 > EDIT: New pull request here: > https://github.com/apache/thrift/pull/273 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2814) args/result classes not found when no namespace is set
[
https://issues.apache.org/jira/browse/THRIFT-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer closed THRIFT-2814.
--
> args/result classes not found when no namespace is set
> --
>
> Key: THRIFT-2814
> URL: https://issues.apache.org/jira/browse/THRIFT-2814
> Project: Thrift
> Issue Type: Bug
> Components: Haxe - Compiler
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Fix For: 0.9.3
>
>
> The args/results helper classes are not found by the Haxe compiler if no
> namespaces are set in the IDL. With Haxe, classes are located via:
> (1) the file name matching the class name
> (2) wildcard {{namespace.*}} imports.
> With an empty namespace only the first method is used. Because the helper
> classes are located within the (e.g.) {{MethodCall_Impl.hx}} file instead the
> {{MethodCall_args.hx}} file, they are not found in that case.
> Changes:
> - generate one source file per Haxe class
> - ensure correctly capitalized names in all cases
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-2849) Spell errors reported by codespell tool
[ https://issues.apache.org/jira/browse/THRIFT-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2849: --- Component/s: Compiler (General) > Spell errors reported by codespell tool > --- > > Key: THRIFT-2849 > URL: https://issues.apache.org/jira/browse/THRIFT-2849 > Project: Thrift > Issue Type: Bug > Components: Compiler (General) >Reporter: Anatol Pomozov > > Codespell is a useful tool that find (and optionally fixes) common spell > errors. It is what it found for current HEAD: > [anatol@arch thrift]$ codespell > ./CHANGES:9: Extention ==> Extension > ./CHANGES:270: compatiblity ==> compatibility > ./CHANGES:560: libary ==> library > ./CHANGES:562: reproducable ==> reproducible > ./debian/rules:196: independant ==> independent > ./debian/rules:200: dependant ==> dependent > ./contrib/parse_profiling.py:45: funtion ==> function > ./contrib/vagrant/centos-6.5/README.md:18: preperation ==> preparation > ./contrib/fb303/TClientInfo.h:195: additonal ==> additional > ./contrib/fb303/aclocal/ax_javac_and_java.m4:10: currenly ==> currently > ./contrib/thrift-maven-plugin/src/main/java/org/apache/thrift/maven/AbstractThriftMojo.java:196: > occured ==> occurred > ./contrib/zeromq/csharp/TZmqClient.cs:50: reponse ==> response > ./test/README.md:12: acording ==> according > ./test/DocTest.thrift:158: cannonical ==> canonical > ./test/ThriftTest.thrift:175: seperated ==> separated > ./test/ThriftTest.thrift:190: seperated ==> separated > ./test/ThriftTest.thrift:198: seperated ==> separated > ./test/ThriftTest.thrift:206: seperated ==> separated > ./test/ThriftTest.thrift:214: seperated ==> separated > ./test/test.py:45: seperated ==> separated > ./test/test.py:47: seperated ==> separated > ./test/rb/core/transport/test_transport.rb:54: guarenteed ==> guaranteed > ./test/haxe/src/TestServerHandler.hx:121: seperated ==> separated > ./test/haxe/src/TestServerHandler.hx:161: seperated ==> separated > ./test/haxe/src/TestServerHandler.hx:186: seperated ==> separated > ./test/haxe/src/TestServerHandler.hx:211: seperated ==> separated > ./test/haxe/src/TestServerHandler.hx:236: seperated ==> separated > ./test/go/src/common/printing_handler.go:94: seperated ==> separated > ./test/go/src/common/printing_handler.go:118: seperated ==> separated > ./test/go/src/common/printing_handler.go:140: seperated ==> separated > ./test/go/src/common/printing_handler.go:162: seperated ==> separated > ./test/go/src/common/printing_handler.go:184: seperated ==> separated > WARNING: Binary file: ./test/keys/server.p12 > WARNING: Binary file: ./test/keys/client.p12 > ./test/hs/TestClient.hs:118: nestIn ==> nesting > ./test/hs/TestClient.hs:122: nestIn ==> nesting > ./test/hs/TestClient.hs:123: nestIn ==> nesting > ./aclocal/ax_javac_and_java.m4:10: currenly ==> currently > ./compiler/cpp/src/globals.h:126: seperately ==> separately > ./compiler/cpp/src/main.cc:995: Propogate ==> Propagate > ./compiler/cpp/src/parse/t_program.h:138: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:140: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:142: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:152: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:153: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:154: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:155: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:156: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:157: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:169: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:172: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:173: occurances ==> occurrences > ./compiler/cpp/src/generate/t_php_generator.cc:231: allready ==> already > ./compiler/cpp/src/generate/t_csharp_generator.cc:694: seperate ==> separate > ./compiler/cpp/src/generate/t_html_generator.cc:719: indentifier ==> > identifier > ./lib/py/setup.py:105: occured ==> occurred > ./lib/py/src/protocol/fastbinary.c:335: FUCNTION ==> FUNCTION > ./lib/py/src/protocol/fastbinary.c:939: FUCNTION ==> FUNCTION > ./lib/py/src/server/TNonblockingServer.py:264: usualy ==> usually > ./lib/d/test/async_test.d:343: succeded ==> succeeded > ./lib/d/test/async_test.d:345: succeded ==> succeeded > ./lib/d/test/async_test.d:356: succeded ==> succeeded > ./lib/d/test/async_test.d:358: succeded ==> succeeded > ./lib/d/src/thrift/base.d:46: occured ==> occurred > ./lib/d/src/thrift/base.d:65: occured ==> occurred > ./lib/d/src/thrift/util/future.d:319: similiar ==> similar > ./lib/d/src/thrift/util/future.d:457: possiblity ==> possibility > ./lib/d/src/thrift/util/hashse
[jira] [Updated] (THRIFT-2849) Spell errors reported by codespell tool
[ https://issues.apache.org/jira/browse/THRIFT-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2849: --- Priority: Trivial (was: Major) > Spell errors reported by codespell tool > --- > > Key: THRIFT-2849 > URL: https://issues.apache.org/jira/browse/THRIFT-2849 > Project: Thrift > Issue Type: Bug > Components: Compiler (General) >Reporter: Anatol Pomozov >Priority: Trivial > > Codespell is a useful tool that find (and optionally fixes) common spell > errors. It is what it found for current HEAD: > [anatol@arch thrift]$ codespell > ./CHANGES:9: Extention ==> Extension > ./CHANGES:270: compatiblity ==> compatibility > ./CHANGES:560: libary ==> library > ./CHANGES:562: reproducable ==> reproducible > ./debian/rules:196: independant ==> independent > ./debian/rules:200: dependant ==> dependent > ./contrib/parse_profiling.py:45: funtion ==> function > ./contrib/vagrant/centos-6.5/README.md:18: preperation ==> preparation > ./contrib/fb303/TClientInfo.h:195: additonal ==> additional > ./contrib/fb303/aclocal/ax_javac_and_java.m4:10: currenly ==> currently > ./contrib/thrift-maven-plugin/src/main/java/org/apache/thrift/maven/AbstractThriftMojo.java:196: > occured ==> occurred > ./contrib/zeromq/csharp/TZmqClient.cs:50: reponse ==> response > ./test/README.md:12: acording ==> according > ./test/DocTest.thrift:158: cannonical ==> canonical > ./test/ThriftTest.thrift:175: seperated ==> separated > ./test/ThriftTest.thrift:190: seperated ==> separated > ./test/ThriftTest.thrift:198: seperated ==> separated > ./test/ThriftTest.thrift:206: seperated ==> separated > ./test/ThriftTest.thrift:214: seperated ==> separated > ./test/test.py:45: seperated ==> separated > ./test/test.py:47: seperated ==> separated > ./test/rb/core/transport/test_transport.rb:54: guarenteed ==> guaranteed > ./test/haxe/src/TestServerHandler.hx:121: seperated ==> separated > ./test/haxe/src/TestServerHandler.hx:161: seperated ==> separated > ./test/haxe/src/TestServerHandler.hx:186: seperated ==> separated > ./test/haxe/src/TestServerHandler.hx:211: seperated ==> separated > ./test/haxe/src/TestServerHandler.hx:236: seperated ==> separated > ./test/go/src/common/printing_handler.go:94: seperated ==> separated > ./test/go/src/common/printing_handler.go:118: seperated ==> separated > ./test/go/src/common/printing_handler.go:140: seperated ==> separated > ./test/go/src/common/printing_handler.go:162: seperated ==> separated > ./test/go/src/common/printing_handler.go:184: seperated ==> separated > WARNING: Binary file: ./test/keys/server.p12 > WARNING: Binary file: ./test/keys/client.p12 > ./test/hs/TestClient.hs:118: nestIn ==> nesting > ./test/hs/TestClient.hs:122: nestIn ==> nesting > ./test/hs/TestClient.hs:123: nestIn ==> nesting > ./aclocal/ax_javac_and_java.m4:10: currenly ==> currently > ./compiler/cpp/src/globals.h:126: seperately ==> separately > ./compiler/cpp/src/main.cc:995: Propogate ==> Propagate > ./compiler/cpp/src/parse/t_program.h:138: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:140: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:142: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:152: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:153: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:154: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:155: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:156: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:157: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:169: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:172: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:173: occurances ==> occurrences > ./compiler/cpp/src/generate/t_php_generator.cc:231: allready ==> already > ./compiler/cpp/src/generate/t_csharp_generator.cc:694: seperate ==> separate > ./compiler/cpp/src/generate/t_html_generator.cc:719: indentifier ==> > identifier > ./lib/py/setup.py:105: occured ==> occurred > ./lib/py/src/protocol/fastbinary.c:335: FUCNTION ==> FUNCTION > ./lib/py/src/protocol/fastbinary.c:939: FUCNTION ==> FUNCTION > ./lib/py/src/server/TNonblockingServer.py:264: usualy ==> usually > ./lib/d/test/async_test.d:343: succeded ==> succeeded > ./lib/d/test/async_test.d:345: succeded ==> succeeded > ./lib/d/test/async_test.d:356: succeded ==> succeeded > ./lib/d/test/async_test.d:358: succeded ==> succeeded > ./lib/d/src/thrift/base.d:46: occured ==> occurred > ./lib/d/src/thrift/base.d:65: occured ==> occurred > ./lib/d/src/thrift/util/future.d:319: similiar ==> similar > ./lib/d/src/thrift/util/future.d:457: possiblity ==> possibility >
[jira] [Commented] (THRIFT-2849) Spell errors reported by codespell tool
[ https://issues.apache.org/jira/browse/THRIFT-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222494#comment-14222494 ] Jens Geyer commented on THRIFT-2849: Hi @Anatol Pomozov, if you have a patch at hand, we like to review it. [More info about how to contribute can be found here|http://thrift.apache.org/docs/HowToContribute]. > Spell errors reported by codespell tool > --- > > Key: THRIFT-2849 > URL: https://issues.apache.org/jira/browse/THRIFT-2849 > Project: Thrift > Issue Type: Bug > Components: Compiler (General) >Reporter: Anatol Pomozov >Priority: Trivial > > Codespell is a useful tool that find (and optionally fixes) common spell > errors. It is what it found for current HEAD: > [anatol@arch thrift]$ codespell > ./CHANGES:9: Extention ==> Extension > ./CHANGES:270: compatiblity ==> compatibility > ./CHANGES:560: libary ==> library > ./CHANGES:562: reproducable ==> reproducible > ./debian/rules:196: independant ==> independent > ./debian/rules:200: dependant ==> dependent > ./contrib/parse_profiling.py:45: funtion ==> function > ./contrib/vagrant/centos-6.5/README.md:18: preperation ==> preparation > ./contrib/fb303/TClientInfo.h:195: additonal ==> additional > ./contrib/fb303/aclocal/ax_javac_and_java.m4:10: currenly ==> currently > ./contrib/thrift-maven-plugin/src/main/java/org/apache/thrift/maven/AbstractThriftMojo.java:196: > occured ==> occurred > ./contrib/zeromq/csharp/TZmqClient.cs:50: reponse ==> response > ./test/README.md:12: acording ==> according > ./test/DocTest.thrift:158: cannonical ==> canonical > ./test/ThriftTest.thrift:175: seperated ==> separated > ./test/ThriftTest.thrift:190: seperated ==> separated > ./test/ThriftTest.thrift:198: seperated ==> separated > ./test/ThriftTest.thrift:206: seperated ==> separated > ./test/ThriftTest.thrift:214: seperated ==> separated > ./test/test.py:45: seperated ==> separated > ./test/test.py:47: seperated ==> separated > ./test/rb/core/transport/test_transport.rb:54: guarenteed ==> guaranteed > ./test/haxe/src/TestServerHandler.hx:121: seperated ==> separated > ./test/haxe/src/TestServerHandler.hx:161: seperated ==> separated > ./test/haxe/src/TestServerHandler.hx:186: seperated ==> separated > ./test/haxe/src/TestServerHandler.hx:211: seperated ==> separated > ./test/haxe/src/TestServerHandler.hx:236: seperated ==> separated > ./test/go/src/common/printing_handler.go:94: seperated ==> separated > ./test/go/src/common/printing_handler.go:118: seperated ==> separated > ./test/go/src/common/printing_handler.go:140: seperated ==> separated > ./test/go/src/common/printing_handler.go:162: seperated ==> separated > ./test/go/src/common/printing_handler.go:184: seperated ==> separated > WARNING: Binary file: ./test/keys/server.p12 > WARNING: Binary file: ./test/keys/client.p12 > ./test/hs/TestClient.hs:118: nestIn ==> nesting > ./test/hs/TestClient.hs:122: nestIn ==> nesting > ./test/hs/TestClient.hs:123: nestIn ==> nesting > ./aclocal/ax_javac_and_java.m4:10: currenly ==> currently > ./compiler/cpp/src/globals.h:126: seperately ==> separately > ./compiler/cpp/src/main.cc:995: Propogate ==> Propagate > ./compiler/cpp/src/parse/t_program.h:138: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:140: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:142: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:152: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:153: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:154: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:155: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:156: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:157: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:169: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:172: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:173: occurances ==> occurrences > ./compiler/cpp/src/generate/t_php_generator.cc:231: allready ==> already > ./compiler/cpp/src/generate/t_csharp_generator.cc:694: seperate ==> separate > ./compiler/cpp/src/generate/t_html_generator.cc:719: indentifier ==> > identifier > ./lib/py/setup.py:105: occured ==> occurred > ./lib/py/src/protocol/fastbinary.c:335: FUCNTION ==> FUNCTION > ./lib/py/src/protocol/fastbinary.c:939: FUCNTION ==> FUNCTION > ./lib/py/src/server/TNonblockingServer.py:264: usualy ==> usually > ./lib/d/test/async_test.d:343: succeded ==> succeeded > ./lib/d/test/async_test.d:345: succeded ==> succeeded > ./lib/d/test/async_test.d:356: succeded ==> succeeded > ./lib/d/test/async_test.d:358: succeded ==> succeeded > ./lib/d/src/thrift/base.d:46: occured
[jira] [Comment Edited] (THRIFT-2849) Spell errors reported by codespell tool
[ https://issues.apache.org/jira/browse/THRIFT-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222494#comment-14222494 ] Jens Geyer edited comment on THRIFT-2849 at 11/23/14 8:54 PM: -- Hi [~anatolikus], if you have a patch at hand, we like to review it. [More info about how to contribute can be found here|http://thrift.apache.org/docs/HowToContribute]. was (Author: jensg): Hi @Anatol Pomozov, if you have a patch at hand, we like to review it. [More info about how to contribute can be found here|http://thrift.apache.org/docs/HowToContribute]. > Spell errors reported by codespell tool > --- > > Key: THRIFT-2849 > URL: https://issues.apache.org/jira/browse/THRIFT-2849 > Project: Thrift > Issue Type: Bug > Components: Compiler (General) >Reporter: Anatol Pomozov >Priority: Trivial > > Codespell is a useful tool that find (and optionally fixes) common spell > errors. It is what it found for current HEAD: > [anatol@arch thrift]$ codespell > ./CHANGES:9: Extention ==> Extension > ./CHANGES:270: compatiblity ==> compatibility > ./CHANGES:560: libary ==> library > ./CHANGES:562: reproducable ==> reproducible > ./debian/rules:196: independant ==> independent > ./debian/rules:200: dependant ==> dependent > ./contrib/parse_profiling.py:45: funtion ==> function > ./contrib/vagrant/centos-6.5/README.md:18: preperation ==> preparation > ./contrib/fb303/TClientInfo.h:195: additonal ==> additional > ./contrib/fb303/aclocal/ax_javac_and_java.m4:10: currenly ==> currently > ./contrib/thrift-maven-plugin/src/main/java/org/apache/thrift/maven/AbstractThriftMojo.java:196: > occured ==> occurred > ./contrib/zeromq/csharp/TZmqClient.cs:50: reponse ==> response > ./test/README.md:12: acording ==> according > ./test/DocTest.thrift:158: cannonical ==> canonical > ./test/ThriftTest.thrift:175: seperated ==> separated > ./test/ThriftTest.thrift:190: seperated ==> separated > ./test/ThriftTest.thrift:198: seperated ==> separated > ./test/ThriftTest.thrift:206: seperated ==> separated > ./test/ThriftTest.thrift:214: seperated ==> separated > ./test/test.py:45: seperated ==> separated > ./test/test.py:47: seperated ==> separated > ./test/rb/core/transport/test_transport.rb:54: guarenteed ==> guaranteed > ./test/haxe/src/TestServerHandler.hx:121: seperated ==> separated > ./test/haxe/src/TestServerHandler.hx:161: seperated ==> separated > ./test/haxe/src/TestServerHandler.hx:186: seperated ==> separated > ./test/haxe/src/TestServerHandler.hx:211: seperated ==> separated > ./test/haxe/src/TestServerHandler.hx:236: seperated ==> separated > ./test/go/src/common/printing_handler.go:94: seperated ==> separated > ./test/go/src/common/printing_handler.go:118: seperated ==> separated > ./test/go/src/common/printing_handler.go:140: seperated ==> separated > ./test/go/src/common/printing_handler.go:162: seperated ==> separated > ./test/go/src/common/printing_handler.go:184: seperated ==> separated > WARNING: Binary file: ./test/keys/server.p12 > WARNING: Binary file: ./test/keys/client.p12 > ./test/hs/TestClient.hs:118: nestIn ==> nesting > ./test/hs/TestClient.hs:122: nestIn ==> nesting > ./test/hs/TestClient.hs:123: nestIn ==> nesting > ./aclocal/ax_javac_and_java.m4:10: currenly ==> currently > ./compiler/cpp/src/globals.h:126: seperately ==> separately > ./compiler/cpp/src/main.cc:995: Propogate ==> Propagate > ./compiler/cpp/src/parse/t_program.h:138: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:140: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:142: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:152: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:153: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:154: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:155: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:156: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:157: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:169: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:172: occurances ==> occurrences > ./compiler/cpp/src/parse/t_program.h:173: occurances ==> occurrences > ./compiler/cpp/src/generate/t_php_generator.cc:231: allready ==> already > ./compiler/cpp/src/generate/t_csharp_generator.cc:694: seperate ==> separate > ./compiler/cpp/src/generate/t_html_generator.cc:719: indentifier ==> > identifier > ./lib/py/setup.py:105: occured ==> occurred > ./lib/py/src/protocol/fastbinary.c:335: FUCNTION ==> FUNCTION > ./lib/py/src/protocol/fastbinary.c:939: FUCNTION ==> FUNCTION > ./lib/py/src/server/TNonblockingServer.py:264: usualy ==> usually > ./lib/d/test/asyn
[jira] [Commented] (THRIFT-2849) Spell errors reported by codespell tool
[
https://issues.apache.org/jira/browse/THRIFT-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222517#comment-14222517
]
Jens Geyer commented on THRIFT-2849:
{quote}
One has to be a bit careful with autocorrection as some reported misspellings
are wrong.
{quote}
i know. Why do you think did I ask for a patch or PR?
> Spell errors reported by codespell tool
> ---
>
> Key: THRIFT-2849
> URL: https://issues.apache.org/jira/browse/THRIFT-2849
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
>Reporter: Anatol Pomozov
>Priority: Trivial
>
> Codespell is a useful tool that find (and optionally fixes) common spell
> errors. It is what it found for current HEAD:
> [anatol@arch thrift]$ codespell
> ./CHANGES:9: Extention ==> Extension
> ./CHANGES:270: compatiblity ==> compatibility
> ./CHANGES:560: libary ==> library
> ./CHANGES:562: reproducable ==> reproducible
> ./debian/rules:196: independant ==> independent
> ./debian/rules:200: dependant ==> dependent
> ./contrib/parse_profiling.py:45: funtion ==> function
> ./contrib/vagrant/centos-6.5/README.md:18: preperation ==> preparation
> ./contrib/fb303/TClientInfo.h:195: additonal ==> additional
> ./contrib/fb303/aclocal/ax_javac_and_java.m4:10: currenly ==> currently
> ./contrib/thrift-maven-plugin/src/main/java/org/apache/thrift/maven/AbstractThriftMojo.java:196:
> occured ==> occurred
> ./contrib/zeromq/csharp/TZmqClient.cs:50: reponse ==> response
> ./test/README.md:12: acording ==> according
> ./test/DocTest.thrift:158: cannonical ==> canonical
> ./test/ThriftTest.thrift:175: seperated ==> separated
> ./test/ThriftTest.thrift:190: seperated ==> separated
> ./test/ThriftTest.thrift:198: seperated ==> separated
> ./test/ThriftTest.thrift:206: seperated ==> separated
> ./test/ThriftTest.thrift:214: seperated ==> separated
> ./test/test.py:45: seperated ==> separated
> ./test/test.py:47: seperated ==> separated
> ./test/rb/core/transport/test_transport.rb:54: guarenteed ==> guaranteed
> ./test/haxe/src/TestServerHandler.hx:121: seperated ==> separated
> ./test/haxe/src/TestServerHandler.hx:161: seperated ==> separated
> ./test/haxe/src/TestServerHandler.hx:186: seperated ==> separated
> ./test/haxe/src/TestServerHandler.hx:211: seperated ==> separated
> ./test/haxe/src/TestServerHandler.hx:236: seperated ==> separated
> ./test/go/src/common/printing_handler.go:94: seperated ==> separated
> ./test/go/src/common/printing_handler.go:118: seperated ==> separated
> ./test/go/src/common/printing_handler.go:140: seperated ==> separated
> ./test/go/src/common/printing_handler.go:162: seperated ==> separated
> ./test/go/src/common/printing_handler.go:184: seperated ==> separated
> WARNING: Binary file: ./test/keys/server.p12
> WARNING: Binary file: ./test/keys/client.p12
> ./test/hs/TestClient.hs:118: nestIn ==> nesting
> ./test/hs/TestClient.hs:122: nestIn ==> nesting
> ./test/hs/TestClient.hs:123: nestIn ==> nesting
> ./aclocal/ax_javac_and_java.m4:10: currenly ==> currently
> ./compiler/cpp/src/globals.h:126: seperately ==> separately
> ./compiler/cpp/src/main.cc:995: Propogate ==> Propagate
> ./compiler/cpp/src/parse/t_program.h:138: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:140: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:142: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:152: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:153: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:154: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:155: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:156: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:157: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:169: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:172: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:173: occurances ==> occurrences
> ./compiler/cpp/src/generate/t_php_generator.cc:231: allready ==> already
> ./compiler/cpp/src/generate/t_csharp_generator.cc:694: seperate ==> separate
> ./compiler/cpp/src/generate/t_html_generator.cc:719: indentifier ==>
> identifier
> ./lib/py/setup.py:105: occured ==> occurred
> ./lib/py/src/protocol/fastbinary.c:335: FUCNTION ==> FUNCTION
> ./lib/py/src/protocol/fastbinary.c:939: FUCNTION ==> FUNCTION
> ./lib/py/src/server/TNonblockingServer.py:264: usualy ==> usually
> ./lib/d/test/async_test.d:343: succeded ==> succeeded
> ./lib/d/test/async_test.d:345: succeded ==> succeeded
> ./lib/d/test/async_test.d:356: succeded ==> succeeded
> ./lib/d/test/async_test.d:358: succeded ==> succeeded
> ./lib/d/src/thrift/base.d:46: occured ==> occurred
>
[jira] [Comment Edited] (THRIFT-2849) Spell errors reported by codespell tool
[
https://issues.apache.org/jira/browse/THRIFT-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222517#comment-14222517
]
Jens Geyer edited comment on THRIFT-2849 at 11/23/14 10:08 PM:
---
{quote}
One has to be a bit careful with autocorrection as some reported misspellings
are wrong.
{quote}
I know. Why do you think did I ask for a patch or PR? ;-)
was (Author: jensg):
{quote}
One has to be a bit careful with autocorrection as some reported misspellings
are wrong.
{quote}
i know. Why do you think did I ask for a patch or PR?
> Spell errors reported by codespell tool
> ---
>
> Key: THRIFT-2849
> URL: https://issues.apache.org/jira/browse/THRIFT-2849
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
>Reporter: Anatol Pomozov
>Priority: Trivial
>
> Codespell is a useful tool that find (and optionally fixes) common spell
> errors. It is what it found for current HEAD:
> [anatol@arch thrift]$ codespell
> ./CHANGES:9: Extention ==> Extension
> ./CHANGES:270: compatiblity ==> compatibility
> ./CHANGES:560: libary ==> library
> ./CHANGES:562: reproducable ==> reproducible
> ./debian/rules:196: independant ==> independent
> ./debian/rules:200: dependant ==> dependent
> ./contrib/parse_profiling.py:45: funtion ==> function
> ./contrib/vagrant/centos-6.5/README.md:18: preperation ==> preparation
> ./contrib/fb303/TClientInfo.h:195: additonal ==> additional
> ./contrib/fb303/aclocal/ax_javac_and_java.m4:10: currenly ==> currently
> ./contrib/thrift-maven-plugin/src/main/java/org/apache/thrift/maven/AbstractThriftMojo.java:196:
> occured ==> occurred
> ./contrib/zeromq/csharp/TZmqClient.cs:50: reponse ==> response
> ./test/README.md:12: acording ==> according
> ./test/DocTest.thrift:158: cannonical ==> canonical
> ./test/ThriftTest.thrift:175: seperated ==> separated
> ./test/ThriftTest.thrift:190: seperated ==> separated
> ./test/ThriftTest.thrift:198: seperated ==> separated
> ./test/ThriftTest.thrift:206: seperated ==> separated
> ./test/ThriftTest.thrift:214: seperated ==> separated
> ./test/test.py:45: seperated ==> separated
> ./test/test.py:47: seperated ==> separated
> ./test/rb/core/transport/test_transport.rb:54: guarenteed ==> guaranteed
> ./test/haxe/src/TestServerHandler.hx:121: seperated ==> separated
> ./test/haxe/src/TestServerHandler.hx:161: seperated ==> separated
> ./test/haxe/src/TestServerHandler.hx:186: seperated ==> separated
> ./test/haxe/src/TestServerHandler.hx:211: seperated ==> separated
> ./test/haxe/src/TestServerHandler.hx:236: seperated ==> separated
> ./test/go/src/common/printing_handler.go:94: seperated ==> separated
> ./test/go/src/common/printing_handler.go:118: seperated ==> separated
> ./test/go/src/common/printing_handler.go:140: seperated ==> separated
> ./test/go/src/common/printing_handler.go:162: seperated ==> separated
> ./test/go/src/common/printing_handler.go:184: seperated ==> separated
> WARNING: Binary file: ./test/keys/server.p12
> WARNING: Binary file: ./test/keys/client.p12
> ./test/hs/TestClient.hs:118: nestIn ==> nesting
> ./test/hs/TestClient.hs:122: nestIn ==> nesting
> ./test/hs/TestClient.hs:123: nestIn ==> nesting
> ./aclocal/ax_javac_and_java.m4:10: currenly ==> currently
> ./compiler/cpp/src/globals.h:126: seperately ==> separately
> ./compiler/cpp/src/main.cc:995: Propogate ==> Propagate
> ./compiler/cpp/src/parse/t_program.h:138: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:140: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:142: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:152: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:153: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:154: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:155: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:156: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:157: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:169: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:172: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:173: occurances ==> occurrences
> ./compiler/cpp/src/generate/t_php_generator.cc:231: allready ==> already
> ./compiler/cpp/src/generate/t_csharp_generator.cc:694: seperate ==> separate
> ./compiler/cpp/src/generate/t_html_generator.cc:719: indentifier ==>
> identifier
> ./lib/py/setup.py:105: occured ==> occurred
> ./lib/py/src/protocol/fastbinary.c:335: FUCNTION ==> FUNCTION
> ./lib/py/src/protocol/fastbinary.c:939: FUCNTION ==> FUNCTION
> ./lib/py/src/server/TNonblockingServer.py:264: usualy ==> usually
> ./lib/d/test/async_test.d:343: succeded
[jira] [Comment Edited] (THRIFT-2849) Spell errors reported by codespell tool
[
https://issues.apache.org/jira/browse/THRIFT-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222517#comment-14222517
]
Jens Geyer edited comment on THRIFT-2849 at 11/23/14 10:12 PM:
---
{quote}
One has to be a bit careful with autocorrection as some reported misspellings
are wrong.
{quote}
I know. Why do you think did I ask for a patch or PR? ;-)
{quote}
I also highly recommend to use the latest codespell version (1.7)
{quote}
To be perfectly honest, I would like someone adressing the [known Coverity
issues|https://issues.apache.org/jira/browse/THRIFT-2564] (and others). That's
where we could really need some help.
was (Author: jensg):
{quote}
One has to be a bit careful with autocorrection as some reported misspellings
are wrong.
{quote}
I know. Why do you think did I ask for a patch or PR? ;-)
> Spell errors reported by codespell tool
> ---
>
> Key: THRIFT-2849
> URL: https://issues.apache.org/jira/browse/THRIFT-2849
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
>Reporter: Anatol Pomozov
>Priority: Trivial
>
> Codespell is a useful tool that find (and optionally fixes) common spell
> errors. It is what it found for current HEAD:
> [anatol@arch thrift]$ codespell
> ./CHANGES:9: Extention ==> Extension
> ./CHANGES:270: compatiblity ==> compatibility
> ./CHANGES:560: libary ==> library
> ./CHANGES:562: reproducable ==> reproducible
> ./debian/rules:196: independant ==> independent
> ./debian/rules:200: dependant ==> dependent
> ./contrib/parse_profiling.py:45: funtion ==> function
> ./contrib/vagrant/centos-6.5/README.md:18: preperation ==> preparation
> ./contrib/fb303/TClientInfo.h:195: additonal ==> additional
> ./contrib/fb303/aclocal/ax_javac_and_java.m4:10: currenly ==> currently
> ./contrib/thrift-maven-plugin/src/main/java/org/apache/thrift/maven/AbstractThriftMojo.java:196:
> occured ==> occurred
> ./contrib/zeromq/csharp/TZmqClient.cs:50: reponse ==> response
> ./test/README.md:12: acording ==> according
> ./test/DocTest.thrift:158: cannonical ==> canonical
> ./test/ThriftTest.thrift:175: seperated ==> separated
> ./test/ThriftTest.thrift:190: seperated ==> separated
> ./test/ThriftTest.thrift:198: seperated ==> separated
> ./test/ThriftTest.thrift:206: seperated ==> separated
> ./test/ThriftTest.thrift:214: seperated ==> separated
> ./test/test.py:45: seperated ==> separated
> ./test/test.py:47: seperated ==> separated
> ./test/rb/core/transport/test_transport.rb:54: guarenteed ==> guaranteed
> ./test/haxe/src/TestServerHandler.hx:121: seperated ==> separated
> ./test/haxe/src/TestServerHandler.hx:161: seperated ==> separated
> ./test/haxe/src/TestServerHandler.hx:186: seperated ==> separated
> ./test/haxe/src/TestServerHandler.hx:211: seperated ==> separated
> ./test/haxe/src/TestServerHandler.hx:236: seperated ==> separated
> ./test/go/src/common/printing_handler.go:94: seperated ==> separated
> ./test/go/src/common/printing_handler.go:118: seperated ==> separated
> ./test/go/src/common/printing_handler.go:140: seperated ==> separated
> ./test/go/src/common/printing_handler.go:162: seperated ==> separated
> ./test/go/src/common/printing_handler.go:184: seperated ==> separated
> WARNING: Binary file: ./test/keys/server.p12
> WARNING: Binary file: ./test/keys/client.p12
> ./test/hs/TestClient.hs:118: nestIn ==> nesting
> ./test/hs/TestClient.hs:122: nestIn ==> nesting
> ./test/hs/TestClient.hs:123: nestIn ==> nesting
> ./aclocal/ax_javac_and_java.m4:10: currenly ==> currently
> ./compiler/cpp/src/globals.h:126: seperately ==> separately
> ./compiler/cpp/src/main.cc:995: Propogate ==> Propagate
> ./compiler/cpp/src/parse/t_program.h:138: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:140: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:142: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:152: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:153: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:154: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:155: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:156: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:157: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:169: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:172: occurances ==> occurrences
> ./compiler/cpp/src/parse/t_program.h:173: occurances ==> occurrences
> ./compiler/cpp/src/generate/t_php_generator.cc:231: allready ==> already
> ./compiler/cpp/src/generate/t_csharp_generator.cc:694: seperate ==> separate
> ./compiler/cpp/src/generate/t_html_generator.cc:719: indentifier ==>
> identifier
> ./l
[jira] [Commented] (THRIFT-2851) Remove strange public Peek() from GO transports
[
https://issues.apache.org/jira/browse/THRIFT-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223329#comment-14223329
]
Jens Geyer commented on THRIFT-2851:
{quote}
If there are useless, we can remove them right?
{quote}
It may not be the best way how it is implemented, but {{Peek()}} is a standard
functionality for all Thrift transports. Even though it is not listed
[here|https://thrift.apache.org/docs/concepts] (note that the list is marked as
not exhaustive), IMHO making it better => yes, removing => no.
@all:
Other opinions welcome, though.
> Remove strange public Peek() from GO transports
> ---
>
> Key: THRIFT-2851
> URL: https://issues.apache.org/jira/browse/THRIFT-2851
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
>Affects Versions: 0.9.2
>Reporter: Chi Vinh Le
>Priority: Minor
> Fix For: 0.9.3
>
>
> I've been seeing this public Peek() function in the GO library for a while,
> but
> still cannot figure out any sense to it.
> If there are useless, we can remove them right?
> This PR removes the public Peek() from the implemented transports.
> All tests still pass.
> PR: https://github.com/apache/thrift/pull/283
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (THRIFT-2851) Remove strange public Peek() from GO transports
[
https://issues.apache.org/jira/browse/THRIFT-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223329#comment-14223329
]
Jens Geyer edited comment on THRIFT-2851 at 11/24/14 7:14 PM:
--
{quote}
If there are useless, we can remove them right?
{quote}
It may not be the best way how it is implemented, but {{Peek()}} is a standard
functionality for all Thrift transports. Throughout the library the core
concepts and the implementations should be as consistent as possible. Even
though {{Peek()}} is not listed [here|https://thrift.apache.org/docs/concepts]
(note that the list is marked as not exhaustive), IMHO making it better => yes,
removing => no.
@all:
Other opinions welcome, though.
was (Author: jensg):
{quote}
If there are useless, we can remove them right?
{quote}
It may not be the best way how it is implemented, but {{Peek()}} is a standard
functionality for all Thrift transports. Even though it is not listed
[here|https://thrift.apache.org/docs/concepts] (note that the list is marked as
not exhaustive), IMHO making it better => yes, removing => no.
@all:
Other opinions welcome, though.
> Remove strange public Peek() from GO transports
> ---
>
> Key: THRIFT-2851
> URL: https://issues.apache.org/jira/browse/THRIFT-2851
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
>Affects Versions: 0.9.2
>Reporter: Chi Vinh Le
>Priority: Minor
> Fix For: 0.9.3
>
>
> I've been seeing this public Peek() function in the GO library for a while,
> but
> still cannot figure out any sense to it.
> If there are useless, we can remove them right?
> This PR removes the public Peek() from the implemented transports.
> All tests still pass.
> PR: https://github.com/apache/thrift/pull/283
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (THRIFT-2851) Remove strange public Peek() from GO transports
[ https://issues.apache.org/jira/browse/THRIFT-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-2851: -- Assignee: Jens Geyer > Remove strange public Peek() from GO transports > --- > > Key: THRIFT-2851 > URL: https://issues.apache.org/jira/browse/THRIFT-2851 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Affects Versions: 0.9.2 >Reporter: Chi Vinh Le >Assignee: Jens Geyer >Priority: Minor > Fix For: 0.9.3 > > > I've been seeing this public Peek() function in the GO library for a while, > but > still cannot figure out any sense to it. > If there are useless, we can remove them right? > This PR removes the public Peek() from the implemented transports. > All tests still pass. > PR: https://github.com/apache/thrift/pull/283 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (THRIFT-2852) Better Open/IsOpen/Close behavior for StreamTransport.
[ https://issues.apache.org/jira/browse/THRIFT-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-2852: -- Assignee: Jens Geyer > Better Open/IsOpen/Close behavior for StreamTransport. > -- > > Key: THRIFT-2852 > URL: https://issues.apache.org/jira/browse/THRIFT-2852 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Affects Versions: 0.9.2 >Reporter: Chi Vinh Le >Assignee: Jens Geyer > Fix For: 0.9.3 > > > I use StreamTransport a lot to test functionality locally that otherwise uses > a Socket transport. Current implementation of IsOpen returns always true, > even though after a close, the whole transport is not usable. > The following PR implements IsOpen, Open and Close that reflects the internal > state and behaves more similar to other transports like TSocket. > https://github.com/apache/thrift/pull/285 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2852) Better Open/IsOpen/Close behavior for StreamTransport.
[ https://issues.apache.org/jira/browse/THRIFT-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-2852. -- Resolution: Fixed Committed, thanks! > Better Open/IsOpen/Close behavior for StreamTransport. > -- > > Key: THRIFT-2852 > URL: https://issues.apache.org/jira/browse/THRIFT-2852 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Affects Versions: 0.9.2 >Reporter: Chi Vinh Le >Assignee: Jens Geyer > Fix For: 0.9.3 > > > I use StreamTransport a lot to test functionality locally that otherwise uses > a Socket transport. Current implementation of IsOpen returns always true, > even though after a close, the whole transport is not usable. > The following PR implements IsOpen, Open and Close that reflects the internal > state and behaves more similar to other transports like TSocket. > https://github.com/apache/thrift/pull/285 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2853) Adjust comments that doesn't apply anymore because of THRIFT-2852
[ https://issues.apache.org/jira/browse/THRIFT-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2853: --- Summary: Adjust comments that doesn't apply anymore because of THRIFT-2852 (was: Remove comments that doesn't apply anymore because of THRIFT-2852) > Adjust comments that doesn't apply anymore because of THRIFT-2852 > - > > Key: THRIFT-2853 > URL: https://issues.apache.org/jira/browse/THRIFT-2853 > Project: Thrift > Issue Type: Task > Components: Go - Library >Affects Versions: 0.9.2 >Reporter: Chi Vinh Le >Priority: Minor > Fix For: 0.9.3 > > > THRIFT-2852 changed behavior of iostream_transport.go which made some > comments invalid. This PR removes the remaining comments. > PR: https://github.com/apache/thrift/pull/286 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2853) Adjust comments not applying anymore after THRIFT-2852
[ https://issues.apache.org/jira/browse/THRIFT-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2853: --- Summary: Adjust comments not applying anymore after THRIFT-2852 (was: Adjust comments that doesn't apply anymore because of THRIFT-2852) > Adjust comments not applying anymore after THRIFT-2852 > -- > > Key: THRIFT-2853 > URL: https://issues.apache.org/jira/browse/THRIFT-2853 > Project: Thrift > Issue Type: Task > Components: Go - Library >Affects Versions: 0.9.2 >Reporter: Chi Vinh Le >Priority: Minor > Fix For: 0.9.3 > > > THRIFT-2852 changed behavior of iostream_transport.go which made some > comments invalid. This PR removes the remaining comments. > PR: https://github.com/apache/thrift/pull/286 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2853) Adjust comments not applying anymore after THRIFT-2852
[ https://issues.apache.org/jira/browse/THRIFT-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-2853. -- Resolution: Fixed Assignee: Jens Geyer Committed. I changed it a bit, since Open() indeed looks slightly odd at the first glance. > Adjust comments not applying anymore after THRIFT-2852 > -- > > Key: THRIFT-2853 > URL: https://issues.apache.org/jira/browse/THRIFT-2853 > Project: Thrift > Issue Type: Task > Components: Go - Library >Affects Versions: 0.9.2 >Reporter: Chi Vinh Le >Assignee: Jens Geyer >Priority: Minor > Fix For: 0.9.3 > > > THRIFT-2852 changed behavior of iostream_transport.go which made some > comments invalid. This PR removes the remaining comments. > PR: https://github.com/apache/thrift/pull/286 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2855) Move contributing.md to the root of the repository
[ https://issues.apache.org/jira/browse/THRIFT-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225157#comment-14225157 ] Jens Geyer commented on THRIFT-2855: Sounds good. > Move contributing.md to the root of the repository > -- > > Key: THRIFT-2855 > URL: https://issues.apache.org/jira/browse/THRIFT-2855 > Project: Thrift > Issue Type: Improvement > Components: Documentation >Reporter: Cash Costello >Priority: Minor > > Github automatically picks up the file CONTRIBUTING.md if it is in the root > of the repository and adds a notice for those making pull requests. See > https://help.github.com/articles/setting-guidelines-for-repository-contributors/ > This should reduce the number of times that Thrift developers have to > manually post links to the contributing guidelines on Github pull requests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2851) Remove strange public Peek() from Go transports
[ https://issues.apache.org/jira/browse/THRIFT-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2851: --- Summary: Remove strange public Peek() from Go transports (was: Remove strange public Peek() from GO transports) > Remove strange public Peek() from Go transports > --- > > Key: THRIFT-2851 > URL: https://issues.apache.org/jira/browse/THRIFT-2851 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Affects Versions: 0.9.2 >Reporter: Chi Vinh Le >Assignee: Jens Geyer >Priority: Minor > Fix For: 0.9.3 > > > I've been seeing this public Peek() function in the GO library for a while, > but > still cannot figure out any sense to it. > If there are useless, we can remove them right? > This PR removes the public Peek() from the implemented transports. > All tests still pass. > PR: https://github.com/apache/thrift/pull/283 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2851) Remove strange public Peek() from Go transports
[ https://issues.apache.org/jira/browse/THRIFT-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2851. Resolution: Fixed After sleeping a night about it, I think you are right. In its current form Peek() is not only next to useless, but more important misleading to the less careful observer. So unless someone comes up with a better implementation, we should throw it out. Committed. > Remove strange public Peek() from Go transports > --- > > Key: THRIFT-2851 > URL: https://issues.apache.org/jira/browse/THRIFT-2851 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Affects Versions: 0.9.2 >Reporter: Chi Vinh Le >Assignee: Jens Geyer >Priority: Minor > Fix For: 0.9.3 > > > I've been seeing this public Peek() function in the GO library for a while, > but > still cannot figure out any sense to it. > If there are useless, we can remove them right? > This PR removes the public Peek() from the implemented transports. > All tests still pass. > PR: https://github.com/apache/thrift/pull/283 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2854) Go Struct writer and reader looses important error information
[
https://issues.apache.org/jira/browse/THRIFT-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-2854:
---
Summary: Go Struct writer and reader looses important error information
(was: GO Struct writer and reader looses important error information)
> Go Struct writer and reader looses important error information
> --
>
> Key: THRIFT-2854
> URL: https://issues.apache.org/jira/browse/THRIFT-2854
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.9.2
>Reporter: Chi Vinh Le
> Fix For: 0.9.3
>
>
> The GO Compiler generates code for a struct so that the following occurs:
> When an error occurs while reading or writing, a new error is created with
> additional text information using {code}fmt.Errorf{code}.
> By doing this the original error is completely lost. This is a real problem
> because errors of type TTransportException and TProtocolExceptions which
> contain additional information are lost. This will cause bad error handling,
> as the server implementation is dependent on those information.
> In my personal fork, I have a quick'n dirty fix for this, but I'm looking for
> a better option.
> Maybe instead of {code}fmt.Errorf{code} we could use this:
> {code}
> // Prepends additional information to an error without losing the Thrift
> interface
> func PrependError(err error, prepend string) error {
> if t, ok := err.(TTransportException); ok {
> return NewTTransportException(t.TypeId(), prepend+t.Error())
> }
> if t, ok := err.(TProtocolException); ok {
> return NewTProtocolExceptionWithType(t.TypeId(),
> errors.New(prepend+err.Error()))
> }
> if t, ok := err.(TApplicationException); ok {
> return NewTApplicationException(t.TypeId(), prepend+t.Error())
> }
> return errors.New(prepend + err.Error())
> }
> {code}
> I want to discuss this first here, because making a patch is quiet some work
> and I don't want major changes after I create a fix.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (THRIFT-2854) Go Struct writer and reader looses important error information
[
https://issues.apache.org/jira/browse/THRIFT-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225211#comment-14225211
]
Jens Geyer edited comment on THRIFT-2854 at 11/25/14 9:10 PM:
--
The generated code has some known flaws with respect to error handling in
general. I absolutely agree that we should do something about it. A good test
case would be nice as well.
Actually there are some more places that could need some reviewing. At some
occasions returned errors are entirely ignored right now,e.g. the generated
{{Process()}} functions. Although these are a bit tricky because of the
{{oneway}} stuff. But that's probably a bit outside of the scope of this ticket.
was (Author: jensg):
The generated code has some known flaws with respect to error handling in
general. I absolutely agree that we should do something about it. A good test
case would be nice.
Actually there are some more places that could need some reviewing. At some
occasions returned errors are entirely ignored right now,e.g. the generated
{{Process()}} functions. Although these are a bit tricky because of the
{{oneway}} stuff. But that's probably a bit outside of the scope of this ticket.
> Go Struct writer and reader looses important error information
> --
>
> Key: THRIFT-2854
> URL: https://issues.apache.org/jira/browse/THRIFT-2854
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.9.2
>Reporter: Chi Vinh Le
> Fix For: 0.9.3
>
>
> The GO Compiler generates code for a struct so that the following occurs:
> When an error occurs while reading or writing, a new error is created with
> additional text information using {code}fmt.Errorf{code}.
> By doing this the original error is completely lost. This is a real problem
> because errors of type TTransportException and TProtocolExceptions which
> contain additional information are lost. This will cause bad error handling,
> as the server implementation is dependent on those information.
> In my personal fork, I have a quick'n dirty fix for this, but I'm looking for
> a better option.
> Maybe instead of {code}fmt.Errorf{code} we could use this:
> {code}
> // Prepends additional information to an error without losing the Thrift
> interface
> func PrependError(err error, prepend string) error {
> if t, ok := err.(TTransportException); ok {
> return NewTTransportException(t.TypeId(), prepend+t.Error())
> }
> if t, ok := err.(TProtocolException); ok {
> return NewTProtocolExceptionWithType(t.TypeId(),
> errors.New(prepend+err.Error()))
> }
> if t, ok := err.(TApplicationException); ok {
> return NewTApplicationException(t.TypeId(), prepend+t.Error())
> }
> return errors.New(prepend + err.Error())
> }
> {code}
> I want to discuss this first here, because making a patch is quiet some work
> and I don't want major changes after I create a fix.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2854) Go Struct writer and reader looses important error information
[
https://issues.apache.org/jira/browse/THRIFT-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225211#comment-14225211
]
Jens Geyer commented on THRIFT-2854:
The generated code has some known flaws with respect to error handling in
general. I absolutely agree that we should do something about it. A good test
case would be nice.
Actually there are some more places that could need some reviewing. At some
occasions returned errors are entirely ignored right now,e.g. the generated
{{Process()}} functions. Although these are a bit tricky because of the
{{oneway}} stuff. But that's probably a bit outside of the scope of this ticket.
> Go Struct writer and reader looses important error information
> --
>
> Key: THRIFT-2854
> URL: https://issues.apache.org/jira/browse/THRIFT-2854
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.9.2
>Reporter: Chi Vinh Le
> Fix For: 0.9.3
>
>
> The GO Compiler generates code for a struct so that the following occurs:
> When an error occurs while reading or writing, a new error is created with
> additional text information using {code}fmt.Errorf{code}.
> By doing this the original error is completely lost. This is a real problem
> because errors of type TTransportException and TProtocolExceptions which
> contain additional information are lost. This will cause bad error handling,
> as the server implementation is dependent on those information.
> In my personal fork, I have a quick'n dirty fix for this, but I'm looking for
> a better option.
> Maybe instead of {code}fmt.Errorf{code} we could use this:
> {code}
> // Prepends additional information to an error without losing the Thrift
> interface
> func PrependError(err error, prepend string) error {
> if t, ok := err.(TTransportException); ok {
> return NewTTransportException(t.TypeId(), prepend+t.Error())
> }
> if t, ok := err.(TProtocolException); ok {
> return NewTProtocolExceptionWithType(t.TypeId(),
> errors.New(prepend+err.Error()))
> }
> if t, ok := err.(TApplicationException); ok {
> return NewTApplicationException(t.TypeId(), prepend+t.Error())
> }
> return errors.New(prepend + err.Error())
> }
> {code}
> I want to discuss this first here, because making a patch is quiet some work
> and I don't want major changes after I create a fix.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-1976) Javascript client unable to serialize/deserialize maps with struct keys
[
https://issues.apache.org/jira/browse/THRIFT-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-1976:
---
Description:
The Javascript compiler is unable to serialize maps where a struct is a key due
to particularities with how Javascript treats {} objects.
Using the following thrift definition:
{code}
struct Foo {
1: required string name;
}
struct Bar {
1: required string description;
}
struct Mapper {
1: required map fooToBar;
}
{code}
It produces the following javascript code:
{code}
Mapper.prototype.write = function(output) {
output.writeStructBegin('Mapper');
if (this.fooToBar !== null && this.fooToBar !== undefined) {
output.writeFieldBegin('fooToBar', Thrift.Type.MAP, 1);
output.writeMapBegin(Thrift.Type.STRUCT, Thrift.Type.STRUCT,
Thrift.objectLength(this.fooToBar));
// XXX
// This will always fail as kiter8 will always be a String
// XXX
for (var kiter8 in this.fooToBar)
{
if (this.fooToBar.hasOwnProperty(kiter8))
{
var viter9 = this.fooToBar[kiter8];
// kiter8 is a string, not an object.
kiter8.write(output);
viter9.write(output);
}
}
output.writeMapEnd();
output.writeFieldEnd();
}
output.writeFieldStop();
output.writeStructEnd();
return;
};
{code}
This code always fails since enumeration of an object's keys will always yield
String values. I've annotated the relevant parts in the above code.
There isn't really a simple fix for this either: Using for-in, there is no way
to get a reference to the original key object. Practically, a Map type would
have to be added to the thrift library with basic put()/get()/delete()
operations to allow for struct maps.
was:
The Javascript compiler is unable to serialize maps where a struct is a key due
to particularities with how Javascript treats {} objects.
Using the following thrift definition:
struct Foo {
1: required string name;
}
struct Bar {
1: required string description;
}
struct Mapper {
1: required map fooToBar;
}
/* End */
It produces the following javascript code:
/* Start -Snipped */
Mapper.prototype.write = function(output) {
output.writeStructBegin('Mapper');
if (this.fooToBar !== null && this.fooToBar !== undefined) {
output.writeFieldBegin('fooToBar', Thrift.Type.MAP, 1);
output.writeMapBegin(Thrift.Type.STRUCT, Thrift.Type.STRUCT,
Thrift.objectLength(this.fooToBar));
// XXX
// This will always fail as kiter8 will always be a String
// XXX
for (var kiter8 in this.fooToBar)
{
if (this.fooToBar.hasOwnProperty(kiter8))
{
var viter9 = this.fooToBar[kiter8];
// kiter8 is a string, not an object.
kiter8.write(output);
viter9.write(output);
}
}
output.writeMapEnd();
output.writeFieldEnd();
}
output.writeFieldStop();
output.writeStructEnd();
return;
};
/* END */
This code always fails since enumeration of an object's keys will always yield
String values. I've annotated the relevant parts in the above code.
There isn't really a simple fix for this either: Using for-in, there is no way
to get a reference to the original key object. Practically, a Map type would
have to be added to the thrift library with basic put()/get()/delete()
operations to allow for struct maps.
> Javascript client unable to serialize/deserialize maps with struct keys
> ---
>
> Key: THRIFT-1976
> URL: https://issues.apache.org/jira/browse/THRIFT-1976
> Project: Thrift
> Issue Type: Bug
> Components: JavaScript - Compiler, JavaScript - Library
>Affects Versions: 0.9
> Environment: All
>Reporter: Andrew Stanton
>Assignee: Randy Abernethy
>
> The Javascript compiler is unable to serialize maps where a struct is a key
> due to particularities with how Javascript treats {} objects.
> Using the following thrift definition:
> {code}
> struct Foo {
> 1: required string name;
> }
> struct Bar {
> 1: required string description;
> }
> struct Mapper {
> 1: required map fooToBar;
> }
> {code}
> It produces the following javascript code:
> {code}
> Mapper.prototype.write = function(output) {
> output.writeStructBegin('Mapper');
> if (this.fooToBar !== null && this.fooToBar !== undefined) {
> output.writeFieldBegin('fooToBar', Thrift.Type.MAP, 1);
> output.writeMapBegin(Thrift.Type.STRUCT, Thrift.Type.STRUCT,
> Thrift.objectLength(this.fooToBar));
> // XXX
> // This will always fail as kiter8 will always be a String
> // XXX
> for (var kiter8 in this.fooToBar)
> {
> if (this.fooToBar.hasOwnProperty(kiter8))
> {
> var viter9 = this.fooToBar[kiter8];
> // kiter8 is a string, not
[jira] [Commented] (THRIFT-2854) Go Struct writer and reader looses important error information
[
https://issues.apache.org/jira/browse/THRIFT-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225305#comment-14225305
]
Jens Geyer commented on THRIFT-2854:
{quote}where are the flaws?{quote}
{code:title=protocol.go}
// note the error returns
type TProtocol interface {
WriteMessageBegin(name string, typeId TMessageType, seqid int32) error
WriteMessageEnd() error
// ... more code ...
ReadMessageBegin() (name string, typeId TMessageType, seqid int32, err
error)
ReadMessageEnd() error
// ... more code ...
Flush() (err error)
{code}
{code:title=some_generated_code.go}
func (p *foobarProcessorBaz_) Process(seqId int32, iprot, oprot
thrift.TProtocol) (success bool, err thrift.TException) {
args := NewBazArgs_{}
if err = args.Read(iprot); err != nil {
iprot.ReadMessageEnd() // <== no error check
x := thrift.NewTApplicationException(thrift.PROTOCOL_ERROR,
err.Error())
oprot.WriteMessageBegin("Quox", thrift.EXCEPTION, seqId) //
<== no error check
x.Write(oprot) // <== no error check
oprot.WriteMessageEnd() // <== no error check
oprot.Flush() // <== no error check
return false, err
}
iprot.ReadMessageEnd()
// ... more code ...
{code}
{quote}
Why does the Process() functions returns 2 variables (success bool, err
thrift.TException). Isn't just having err thrift.TException enough?
{quote}
That would break too many things. You know, people are actually using this
stuff and we already had some breaking changes in the Go library not so long
ago. I would like to avoid that, especially compared to the limited benefit we
would get from it. That is also a point to consider when providing patches in
general: First, we have a somwehat standardized layout of certain things across
all languages that we want to keep. Next, we want to be compatible.
Thanks to a number of significant contributions the Go part of Thrift has
reached quite a good state that we absolutely should strive to improve (there
is room for that), but not at all cost.
> Go Struct writer and reader looses important error information
> --
>
> Key: THRIFT-2854
> URL: https://issues.apache.org/jira/browse/THRIFT-2854
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.9.2
>Reporter: Chi Vinh Le
> Fix For: 0.9.3
>
>
> The GO Compiler generates code for a struct so that the following occurs:
> When an error occurs while reading or writing, a new error is created with
> additional text information using {code}fmt.Errorf{code}.
> By doing this the original error is completely lost. This is a real problem
> because errors of type TTransportException and TProtocolExceptions which
> contain additional information are lost. This will cause bad error handling,
> as the server implementation is dependent on those information.
> In my personal fork, I have a quick'n dirty fix for this, but I'm looking for
> a better option.
> Maybe instead of {code}fmt.Errorf{code} we could use this:
> {code}
> // Prepends additional information to an error without losing the Thrift
> interface
> func PrependError(err error, prepend string) error {
> if t, ok := err.(TTransportException); ok {
> return NewTTransportException(t.TypeId(), prepend+t.Error())
> }
> if t, ok := err.(TProtocolException); ok {
> return NewTProtocolExceptionWithType(t.TypeId(),
> errors.New(prepend+err.Error()))
> }
> if t, ok := err.(TApplicationException); ok {
> return NewTApplicationException(t.TypeId(), prepend+t.Error())
> }
> return errors.New(prepend + err.Error())
> }
> {code}
> I want to discuss this first here, because making a patch is quiet some work
> and I don't want major changes after I create a fix.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2854) Go Struct writer and reader looses important error information
[
https://issues.apache.org/jira/browse/THRIFT-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225422#comment-14225422
]
Jens Geyer commented on THRIFT-2854:
Ok.
> Go Struct writer and reader looses important error information
> --
>
> Key: THRIFT-2854
> URL: https://issues.apache.org/jira/browse/THRIFT-2854
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.9.2
>Reporter: Chi Vinh Le
> Fix For: 0.9.3
>
>
> The GO Compiler generates code for a struct so that the following occurs:
> When an error occurs while reading or writing, a new error is created with
> additional text information using {code}fmt.Errorf{code}.
> By doing this the original error is completely lost. This is a real problem
> because errors of type TTransportException and TProtocolExceptions which
> contain additional information are lost. This will cause bad error handling,
> as the server implementation is dependent on those information.
> In my personal fork, I have a quick'n dirty fix for this, but I'm looking for
> a better option.
> Maybe instead of {code}fmt.Errorf{code} we could use this:
> {code}
> // Prepends additional information to an error without losing the Thrift
> interface
> func PrependError(err error, prepend string) error {
> if t, ok := err.(TTransportException); ok {
> return NewTTransportException(t.TypeId(), prepend+t.Error())
> }
> if t, ok := err.(TProtocolException); ok {
> return NewTProtocolExceptionWithType(t.TypeId(),
> errors.New(prepend+err.Error()))
> }
> if t, ok := err.(TApplicationException); ok {
> return NewTApplicationException(t.TypeId(), prepend+t.Error())
> }
> return errors.New(prepend + err.Error())
> }
> {code}
> I want to discuss this first here, because making a patch is quiet some work
> and I don't want major changes after I create a fix.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (THRIFT-2857) C# generator creates uncompilable code for struct constants
[ https://issues.apache.org/jira/browse/THRIFT-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-2857: -- Assignee: Jens Geyer > C# generator creates uncompilable code for struct constants > --- > > Key: THRIFT-2857 > URL: https://issues.apache.org/jira/browse/THRIFT-2857 > Project: Thrift > Issue Type: Bug > Components: C# - Compiler >Affects Versions: 0.9.2 >Reporter: Stig Bakken >Assignee: Jens Geyer >Priority: Minor > > If you have constants with struct values, the C# generator does not uppercase > member names, leading to compile errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2857) C# generator creates uncompilable code for struct constants
[ https://issues.apache.org/jira/browse/THRIFT-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226648#comment-14226648 ] Jens Geyer commented on THRIFT-2857: Do you have a test case at hand? > C# generator creates uncompilable code for struct constants > --- > > Key: THRIFT-2857 > URL: https://issues.apache.org/jira/browse/THRIFT-2857 > Project: Thrift > Issue Type: Bug > Components: C# - Compiler >Affects Versions: 0.9.2 >Reporter: Stig Bakken >Assignee: Jens Geyer >Priority: Minor > > If you have constants with struct values, the C# generator does not uppercase > member names, leading to compile errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2858) Enable header field case insensitive match in THttpServer
[ https://issues.apache.org/jira/browse/THRIFT-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226717#comment-14226717 ] Jens Geyer commented on THRIFT-2858: Does that affect other languages besides C++ as well? > Enable header field case insensitive match in THttpServer > - > > Key: THRIFT-2858 > URL: https://issues.apache.org/jira/browse/THRIFT-2858 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.9.1, 0.9.2 > Environment: ubuntu 14.04 LTS > gcc 4.8 >Reporter: YI-HUNG JEN > Labels: patch > Fix For: 0.9.3 > > Attachments: > thrift-2858-enable-THttpServer_cpp-header-case-insensitive-match.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > Communications between THttpServer in cpp lib and nodejs http client caused > unexpected ECONNRESET. This was caused by nodejs client setting > "Content-length" instead of "Content-Length" in the header field, causing > THttpServer to terminate the request prematurely. > Per HTTP specification, header field name is case insensitive, therefore this > patch used case insensitive match to identify "Content-Length" field. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (THRIFT-2858) Enable header field case insensitive match in THttpServer
[ https://issues.apache.org/jira/browse/THRIFT-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226717#comment-14226717 ] Jens Geyer edited comment on THRIFT-2858 at 11/26/14 7:47 PM: -- Does that affect other languages besides C++ as well? I mean, do they have a similar issue? was (Author: jensg): Does that affect other languages besides C++ as well? > Enable header field case insensitive match in THttpServer > - > > Key: THRIFT-2858 > URL: https://issues.apache.org/jira/browse/THRIFT-2858 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.9.1, 0.9.2 > Environment: ubuntu 14.04 LTS > gcc 4.8 >Reporter: YI-HUNG JEN > Labels: patch > Fix For: 0.9.3 > > Attachments: > thrift-2858-enable-THttpServer_cpp-header-case-insensitive-match.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > Communications between THttpServer in cpp lib and nodejs http client caused > unexpected ECONNRESET. This was caused by nodejs client setting > "Content-length" instead of "Content-Length" in the header field, causing > THttpServer to terminate the request prematurely. > Per HTTP specification, header field name is case insensitive, therefore this > patch used case insensitive match to identify "Content-Length" field. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2857) C# generator creates uncompilable code for struct constants
[
https://issues.apache.org/jira/browse/THRIFT-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226988#comment-14226988
]
Jens Geyer commented on THRIFT-2857:
TBH, I only wanted an example similar to the problem you had, right here in the
JIRA ticket, so I know what to look for. ;-) If you still want to do that,
please put it directly into {{lib/csharp/test}}. We can move it later, if
necessary. Do *not* put it into {{lib/csharp/test/ThriftTest}}.
> C# generator creates uncompilable code for struct constants
> ---
>
> Key: THRIFT-2857
> URL: https://issues.apache.org/jira/browse/THRIFT-2857
> Project: Thrift
> Issue Type: Bug
> Components: C# - Compiler
>Affects Versions: 0.9.2
>Reporter: Stig Bakken
>Assignee: Jens Geyer
>Priority: Minor
>
> If you have constants with struct values, the C# generator does not uppercase
> member names, leading to compile errors.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
