[jira] [Commented] (THRIFT-4692) Please release 0.12.0 to php packagist or enable others to do so
[ https://issues.apache.org/jira/browse/THRIFT-4692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729878#comment-16729878 ] Roger Meier commented on THRIFT-4692: - [~jking3] Could you provide your username on packagist? > Please release 0.12.0 to php packagist or enable others to do so > > > Key: THRIFT-4692 > URL: https://issues.apache.org/jira/browse/THRIFT-4692 > Project: Thrift > Issue Type: Task > Components: Build Process >Affects Versions: 0.12.0 >Reporter: James E. King III >Assignee: Roger Meier >Priority: Critical > > For [~jfarrell] and [~roger.meier] please upload thrift 0.12.0 to packagist > and/or enable other committers to do the same. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-3961) TConnectedClient does not terminate the connection to the client if an exception while processing the received message occures.
[
https://issues.apache.org/jira/browse/THRIFT-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655030#comment-15655030
]
Roger Meier commented on THRIFT-3961:
-
+1 as soon as THRIFT-3957 is in
> TConnectedClient does not terminate the connection to the client if an
> exception while processing the received message occures.
> ---
>
> Key: THRIFT-3961
> URL: https://issues.apache.org/jira/browse/THRIFT-3961
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Affects Versions: 0.9.3
>Reporter: Claudius Heine
>
> The server should disconnect from the client, if the client sends invalid
> messages to the server instead of throwing exception for every byte.
> {code}
> $ bin/TestServer --protocol=json --transport=http --server-type=thread-pool
> --port=9080
> Starting "thread-pool" server (http/json) listen on: 9080
> Thrift: Tue Nov 8 15:10:53 2016 TConnectedClient processing exception:
> Expected '['; got '1'.
> Thrift: Tue Nov 8 15:10:53 2016 TConnectedClient processing exception:
> Expected '['; got '2'.
> Thrift: Tue Nov 8 15:10:53 2016 TConnectedClient processing exception:
> Expected '['; got '3'.
> Thrift: Tue Nov 8 15:10:53 2016 TConnectedClient processing exception:
> Expected '['; got '4'.
> Thrift: Tue Nov 8 15:10:53 2016 TConnectedClient processing exception:
> Expected '['; got '5'.
> Thrift: Tue Nov 8 15:10:53 2016 TConnectedClient processing exception:
> Expected '['; got '6'.
> Thrift: Tue Nov 8 15:10:53 2016 TConnectedClient processing exception:
> Expected '['; got '7'.
> Thrift: Tue Nov 8 15:10:53 2016 TConnectedClient processing exception:
> Expected '['; got '8'.
> Thrift: Tue Nov 8 15:10:53 2016 TConnectedClient processing exception:
> Expected '['; got '9'.
> Thrift: Tue Nov 8 15:10:53 2016 TConnectedClient processing exception:
> Expected '['; got '0'.
> {code}
> when sending
> {code}
> $ curl --data "1234567890" http://localhost:9080
> {code}
> This behavior can easily be abused to DOS attack the server, by sending
> massive amounts of garbage to it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3957) TConnectedClient does not disconnect from clients when their timeout is reached.
[
https://issues.apache.org/jira/browse/THRIFT-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15654986#comment-15654986
]
Roger Meier commented on THRIFT-3957:
-
+1
> TConnectedClient does not disconnect from clients when their timeout is
> reached.
>
>
> Key: THRIFT-3957
> URL: https://issues.apache.org/jira/browse/THRIFT-3957
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Affects Versions: 0.9.3, 0.10.0
>Reporter: Claudius Heine
>Assignee: James E. King, III
> Attachments:
> 0001-cpp-TestServer-removed-while-loop-and-added-connecti.patch,
> 0002-cpp-server-TConnectedClient-Timeouts-are-disconnecti.patch
>
>
> When starting the TestServer with the first appended patch:
> {code}
> bin/TestServer --protocol=json --transport=http --server-type=thread-pool
> --port=9080
> {code}
> And connecting to it with this shell command:
> {code}
> wget --post-data='[' http://localhost:9080
> {code}
> The connection stays up for a long time. Making DOS attacks very easy,
> because at some point the server runs out of available client connections.
> The second appended patch fixes the issue in TConnectedClient.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3965) VisualStudio project cannot build compiler CPP project
[
https://issues.apache.org/jira/browse/THRIFT-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15654946#comment-15654946
]
Roger Meier commented on THRIFT-3965:
-
+1 for removing the solution files and to provide CMake only here. This was one
reason for pushing the adoption of CMake from my side.
> VisualStudio project cannot build compiler CPP project
> --
>
> Key: THRIFT-3965
> URL: https://issues.apache.org/jira/browse/THRIFT-3965
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
> Environment: Microsoft Visual Studio Enterprise 2015
> Version 14.0.25123.00 Update 2
> Microsoft .NET Framework
> Version 4.6.01055
> Installed Version: Enterprise
> Architecture and Modeling Tools 00322-8-0-AA924
> Microsoft Architecture and Modeling Tools
>
> UML® and Unified Modeling Language™ are trademarks or registered trademarks
> of the Object Management Group, Inc. in the United States and other countries.
> Visual Basic 2015 00322-8-0-AA924
> Microsoft Visual Basic 2015
> Visual C# 2015 00322-8-0-AA924
> Microsoft Visual C# 2015
> Visual C++ 2015 00322-8-0-AA924
> Microsoft Visual C++ 2015
> Application Insights Tools for Visual Studio Package 5.209.60613.1
> Application Insights Tools for Visual Studio
> ASP.NET and Web Tools 2015.1 (Beta8) 14.1.11106.0
> ASP.NET and Web Tools 2015.1 (Beta8)
> ASP.NET Web Frameworks and Tools 2012.2 4.1.41102.0
> For additional information, visit
> http://go.microsoft.com/fwlink/?LinkID=309563
> ASP.NET Web Frameworks and Tools 2013 5.2.40314.0
> For additional information, visit http://www.asp.net/
> Common Azure Tools 1.7
> Provides common services for use by Azure Mobile Services and Microsoft Azure
> Tools.
> JavaScript Language Service 2.0
> JavaScript Language Service
> JavaScript Project System 2.0
> JavaScript Project System
> Microsoft Azure Mobile Services Tools 1.4
> Microsoft Azure Mobile Services Tools
> NuGet Package Manager 3.4.4
> NuGet Package Manager in Visual Studio. For more information about NuGet,
> visit http://docs.nuget.org/.
> PreEmptive Analytics Visualizer 1.2
> Microsoft Visual Studio extension to visualize aggregated summaries from the
> PreEmptive Analytics product.
> SQL Server Data Tools 14.0.60311.1
> Microsoft SQL Server Data Tools
> TypeScript 1.8.31.0
> TypeScript tools for Visual Studio
>Reporter: Gary Gregory
>Assignee: James E. King, III
> Labels: Windows
>
> Based on the current git master branch.
> The project's {{t_generator.h}} want to use the header file {{version.h}}:
> {code}
> #include "thrift/version.h"
> {code}
> The file does not exist but {{version.h.in}} is there and looks to be
> expected by the CMake build's {{CMakeLists.txt}}:
> {code}
> configure_file(${CMAKE_CURRENT_SOURCE_DIR}/src/thrift/version.h.in
> ${CMAKE_CURRENT_BINARY_DIR}/thrift/version.h)
> {code}
> As a workaround I just copied {{version.h.in}} to {{version.h}}.
> It would be nice to fix this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3581) Pure Java build of the Thrift compiler using NestedVM [WIP]
[ https://issues.apache.org/jira/browse/THRIFT-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194015#comment-15194015 ] Roger Meier commented on THRIFT-3581: - ok, we are fine with this as long as everything is Apache 2 > Pure Java build of the Thrift compiler using NestedVM [WIP] > --- > > Key: THRIFT-3581 > URL: https://issues.apache.org/jira/browse/THRIFT-3581 > Project: Thrift > Issue Type: New Feature > Components: Compiler (General) >Reporter: Benjamin Gould >Assignee: Benjamin Gould >Priority: Minor > Attachments: thrift-compiler-0.9.4-SNAPSHOT-sources.jar, > thrift-compiler-0.9.4-SNAPSHOT.jar > > > I've developed a build process for building the Thrift compiler as a JAR file > that can be run on a JVM and requires no dependencies by cross-compiling the > executable with NestedVM. > I think this could be use for the following, among other things: > 1) Building Thrift plugins for IDEs written in Java > 2) Integration into Java build tools like Ant and Maven > 3) Calling the compiler from a Java program when the host platform is unknown > Also, I see this as providing a way to potentially allow people to create > third party "plugins" for the compiler... Java and the plethora of JVM > language available might make creating new generators much more approachable > for people not comfortable with C++... and also in Java it is not complicated > to load code dynamically based on a class name as long as it is on the > classpath. > In any case, I have a working prototype, but it is far from battle tested. > For the inpatient, I'm attaching a snapshot build to this ticket, but you can > also find the source and build instructions here: > https://github.com/bgould/thrift/tree/nestedvm/contrib/nestedvm > Will open a pull request when I feel all of the wrinkles have been ironed out > (it is close, and quite usuable already) to see if it might be appropriate to > bring this into the contrib/ folder, or even include as an artifact in the > Maven repos for a future release. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Reopened] (THRIFT-3742) haxe php cli support
[ https://issues.apache.org/jira/browse/THRIFT-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier reopened THRIFT-3742: - Thanks for the patch! Please do not resolve issues as long as they are not committed. > haxe php cli support > > > Key: THRIFT-3742 > URL: https://issues.apache.org/jira/browse/THRIFT-3742 > Project: Thrift > Issue Type: Improvement > Components: Haxe - Library >Affects Versions: 0.10.0, 1.0 >Reporter: Oleksii Prudkyi > Fix For: 0.10.0 > > Attachments: THRIFT-3742-haxe-php-cli-support.patch > > > patch is coming soon -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (THRIFT-3581) Pure Java build of the Thrift compiler using NestedVM [WIP]
[ https://issues.apache.org/jira/browse/THRIFT-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15190158#comment-15190158 ] Roger Meier edited comment on THRIFT-3581 at 3/10/16 11:16 PM: --- I was able to build it but I'm unsure on integrating it, also from a licensing perspective. was (Author: roger.meier): I was able to build it put I'm unsure on integrating it, also from a licensing perspective. > Pure Java build of the Thrift compiler using NestedVM [WIP] > --- > > Key: THRIFT-3581 > URL: https://issues.apache.org/jira/browse/THRIFT-3581 > Project: Thrift > Issue Type: New Feature > Components: Compiler (General) >Reporter: Benjamin Gould >Assignee: Benjamin Gould >Priority: Minor > Attachments: thrift-compiler-0.9.4-SNAPSHOT-sources.jar, > thrift-compiler-0.9.4-SNAPSHOT.jar > > > I've developed a build process for building the Thrift compiler as a JAR file > that can be run on a JVM and requires no dependencies by cross-compiling the > executable with NestedVM. > I think this could be use for the following, among other things: > 1) Building Thrift plugins for IDEs written in Java > 2) Integration into Java build tools like Ant and Maven > 3) Calling the compiler from a Java program when the host platform is unknown > Also, I see this as providing a way to potentially allow people to create > third party "plugins" for the compiler... Java and the plethora of JVM > language available might make creating new generators much more approachable > for people not comfortable with C++... and also in Java it is not complicated > to load code dynamically based on a class name as long as it is on the > classpath. > In any case, I have a working prototype, but it is far from battle tested. > For the inpatient, I'm attaching a snapshot build to this ticket, but you can > also find the source and build instructions here: > https://github.com/bgould/thrift/tree/nestedvm/contrib/nestedvm > Will open a pull request when I feel all of the wrinkles have been ironed out > (it is close, and quite usuable already) to see if it might be appropriate to > bring this into the contrib/ folder, or even include as an artifact in the > Maven repos for a future release. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3581) Pure Java build of the Thrift compiler using NestedVM [WIP]
[ https://issues.apache.org/jira/browse/THRIFT-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15190158#comment-15190158 ] Roger Meier commented on THRIFT-3581: - I was able to build it put I'm unsure on integrating it, also from a licensing perspective. > Pure Java build of the Thrift compiler using NestedVM [WIP] > --- > > Key: THRIFT-3581 > URL: https://issues.apache.org/jira/browse/THRIFT-3581 > Project: Thrift > Issue Type: New Feature > Components: Compiler (General) >Reporter: Benjamin Gould >Assignee: Benjamin Gould >Priority: Minor > Attachments: thrift-compiler-0.9.4-SNAPSHOT-sources.jar, > thrift-compiler-0.9.4-SNAPSHOT.jar > > > I've developed a build process for building the Thrift compiler as a JAR file > that can be run on a JVM and requires no dependencies by cross-compiling the > executable with NestedVM. > I think this could be use for the following, among other things: > 1) Building Thrift plugins for IDEs written in Java > 2) Integration into Java build tools like Ant and Maven > 3) Calling the compiler from a Java program when the host platform is unknown > Also, I see this as providing a way to potentially allow people to create > third party "plugins" for the compiler... Java and the plethora of JVM > language available might make creating new generators much more approachable > for people not comfortable with C++... and also in Java it is not complicated > to load code dynamically based on a class name as long as it is on the > classpath. > In any case, I have a working prototype, but it is far from battle tested. > For the inpatient, I'm attaching a snapshot build to this ticket, but you can > also find the source and build instructions here: > https://github.com/bgould/thrift/tree/nestedvm/contrib/nestedvm > Will open a pull request when I feel all of the wrinkles have been ironed out > (it is close, and quite usuable already) to see if it might be appropriate to > bring this into the contrib/ folder, or even include as an artifact in the > Maven repos for a future release. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-3714) Thrift.TProtocolException is not defined in js/src/thrift.js
[ https://issues.apache.org/jira/browse/THRIFT-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-3714. - Resolution: Fixed Fix Version/s: 1.0 0.10.0 thanks > Thrift.TProtocolException is not defined in js/src/thrift.js > > > Key: THRIFT-3714 > URL: https://issues.apache.org/jira/browse/THRIFT-3714 > Project: Thrift > Issue Type: Bug > Components: JavaScript - Compiler >Affects Versions: 0.9.2 >Reporter: Liyin Tang > Fix For: 0.10.0, 1.0 > > Attachments: thrift-3714.patch > > > THRIFT-809 will throw new Thrift.TProtocolException if a required field is > missing. However, in the js/src/thrift.js, TProtocolException is not defined. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3627) Missing basic code style consistency of JavaScript.
[
https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15190127#comment-15190127
]
Roger Meier commented on THRIFT-3627:
-
I think we should add something like https://www.npmjs.com/package/jscs to
package.json and automate this, so the
https://github.com/apache/thrift/blob/master/lib/js/coding_standards.md might
become obsolete.
> Missing basic code style consistency of JavaScript.
> ---
>
> Key: THRIFT-3627
> URL: https://issues.apache.org/jira/browse/THRIFT-3627
> Project: Thrift
> Issue Type: Improvement
> Components: JavaScript - Library
>Reporter: Kazuki Matsuda
>Priority: Minor
>
> E.g.)
> * No white space in {code}function(args){// beteween `){`{code}
> https://github.com/apache/thrift/blob/84cf363eeedf4cc9bb618bb2b1980696b9f6fc9b/lib/js/src/thrift.js#L1497
> * "Double quoted" (not 'single quoted') string litteral
> https://github.com/apache/thrift/blob/84cf363eeedf4cc9bb618bb2b1980696b9f6fc9b/lib/js/src/thrift.js#L133
> Those errors can be easily fixed by fixjsstyle.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3669) JS Deserialization of lists of lists is broken
[
https://issues.apache.org/jira/browse/THRIFT-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15190113#comment-15190113
]
Roger Meier commented on THRIFT-3669:
-
Could you please test on master branch and provide a patch? We also like test
cases.
> JS Deserialization of lists of lists is broken
> --
>
> Key: THRIFT-3669
> URL: https://issues.apache.org/jira/browse/THRIFT-3669
> Project: Thrift
> Issue Type: Bug
> Components: JavaScript - Library
>Affects Versions: 0.9.3, 1.0
>Reporter: Christian Bürckert
> Fix For: 0.9.3, 1.0
>
> Attachments: thrift.js
>
>
> struct QueryResult {
> 1: required list> rows;
> }
> service QueryService{
> QueryResult query();
> }
> Using TJSONProtocol the list> is transmitted correctly but
> deserialized wrong. Only the first sublist will contain the correct string
> values the second, third and so on will be empty. The error is a combination
> of readListBegin, readListEnd and readString (in thrift.js) which somehow
> interacts wrongly with the internal rstack when lists are included in lists.
> As a temporary solution until the deserialization is fixed I advice others to
> create an intermediate struct which contains the sublists.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-3704) "TConnectedClient died: Could not refill buffer" message shown when using HTTP Server
[
https://issues.apache.org/jira/browse/THRIFT-3704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-3704.
-
Resolution: Fixed
Assignee: Pascal Bach
Thanks Pascal!
> "TConnectedClient died: Could not refill buffer" message shown when using
> HTTP Server
> -
>
> Key: THRIFT-3704
> URL: https://issues.apache.org/jira/browse/THRIFT-3704
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Affects Versions: 0.9.3
> Environment: Linux 64bit and Linux arm
>Reporter: Pascal Bach
>Assignee: Pascal Bach
> Attachments:
> 0001-Modify-tutorial-server-to-use-HTTP-and-JSON-to-repro.patch,
> 0001-Treat-the-case-where-we-are-not-able-to-refill-the-b.patch
>
>
> When using {{THttpTransport}} after every request the server prints the
> following message:
> {{TConnectedClient died: Could not refill buffer}}
> However the operation seems to be completed successfully.
> It doesn't matter what protocol is used (JSON, Binary). The issue can be
> observed independent of the client used (C++, JavaScript in Browser).
> The error is thrown in the {{THttpTransport::refill}} function in the case
> where read from the transport returns 0.
> I'm not sure if throwing an exception there is really necessary?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3704) "TConnectedClient died: Could not refill buffer" message shown when using HTTP Server
[
https://issues.apache.org/jira/browse/THRIFT-3704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15182351#comment-15182351
]
Roger Meier commented on THRIFT-3704:
-
Yes, throwing {noformat}TTransportException::END_OF_FILE{noformat} is what we
need here. It is handled by
{noformat}src/thrift/server/TConnectedClient.cpp{noformat}.
and we do this on other transports as well.
> "TConnectedClient died: Could not refill buffer" message shown when using
> HTTP Server
> -
>
> Key: THRIFT-3704
> URL: https://issues.apache.org/jira/browse/THRIFT-3704
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Affects Versions: 0.9.3
> Environment: Linux 64bit and Linux arm
>Reporter: Pascal Bach
> Attachments:
> 0001-Modify-tutorial-server-to-use-HTTP-and-JSON-to-repro.patch,
> 0001-Treat-the-case-where-we-are-not-able-to-refill-the-b.patch
>
>
> When using {{THttpTransport}} after every request the server prints the
> following message:
> {{TConnectedClient died: Could not refill buffer}}
> However the operation seems to be completed successfully.
> It doesn't matter what protocol is used (JSON, Binary). The issue can be
> observed independent of the client used (C++, JavaScript in Browser).
> The error is thrown in the {{THttpTransport::refill}} function in the case
> where read from the transport returns 0.
> I'm not sure if throwing an exception there is really necessary?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-3667) Add TLS SNI support to clients
[ https://issues.apache.org/jira/browse/THRIFT-3667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-3667. - Resolution: Fixed committed > Add TLS SNI support to clients > -- > > Key: THRIFT-3667 > URL: https://issues.apache.org/jira/browse/THRIFT-3667 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library >Reporter: Teddy Reed >Priority: Trivial > Original Estimate: 24h > Remaining Estimate: 24h > > Most services are deployed behind a TLS proxy/LB. It's nice to have SNI > support in TLS clients, this is a trivial change in the C++ OpenSSL > implementations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3605) Have the compiler complain about invalid arguments and options
[
https://issues.apache.org/jira/browse/THRIFT-3605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139721#comment-15139721
]
Roger Meier commented on THRIFT-3605:
-
using a real option parser as suggested in THRIFT-3013 should solve this
> Have the compiler complain about invalid arguments and options
> --
>
> Key: THRIFT-3605
> URL: https://issues.apache.org/jira/browse/THRIFT-3605
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
>Reporter: Jens Geyer
>Assignee: Jens Geyer
>
> As kind of a follow-up to THRIFT-3603, the goal is to have the compiler
> validate not only the arguments , but also any argument options passed to it.
> If an unknown option is found, a short error message should be printed
> similar to what we already have with invalid args:
> {code}
> $ thrift -gen csharp:whoa
> Unrecognized option: whoa
> Usage: thrift [options] file
> Use thrift -help for a list of options
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2756) register Media Type @ IANA
[
https://issues.apache.org/jira/browse/THRIFT-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136447#comment-15136447
]
Roger Meier commented on THRIFT-2756:
-
transition to IANA conform headers is not yet implemented, they are just
registered.
I will create followup tasks to implement this soon.
> register Media Type @ IANA
> --
>
> Key: THRIFT-2756
> URL: https://issues.apache.org/jira/browse/THRIFT-2756
> Project: Thrift
> Issue Type: Improvement
>Reporter: Roger Meier
>Assignee: Roger Meier
> Fix For: 0.9.3
>
>
> Discussion started here THRIFT-2674
> Goal is to get proper Content-Types for Apache Thrift:
> {noformat}
> Content-Type: application/vnd.apache.thrift.binary; # binary
> Content-Type: application/vnd.apache.thrift.json; charset=utf-8 # 8-bit text
> Content-Type: application/vnd.apache.thrift.compact;# binary
> {noformat}
> Binary was already accepted:
> http://www.iana.org/assignments/media-types/application/vnd.apache.thrift.binary
> json and compact are in Expert Review status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3550) Latest indexed version of the perl lib on CPAN is 0.8.0, although 0.9.0 is present
[ https://issues.apache.org/jira/browse/THRIFT-3550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136332#comment-15136332 ] Roger Meier commented on THRIFT-3550: - I'm not familiar with the perl publishing process and do not know who did it before. Is it a simle thing? > Latest indexed version of the perl lib on CPAN is 0.8.0, although 0.9.0 is > present > -- > > Key: THRIFT-3550 > URL: https://issues.apache.org/jira/browse/THRIFT-3550 > Project: Thrift > Issue Type: Bug > Components: Perl - Library >Affects Versions: 0.9.3 >Reporter: David Morel > > Running cpanm or cpan installs version 0.8.0 of the perl lib, although 0.9.0 > has been uploaded on PAUSE. > Also, would be nice to have v 0.9.3 since it's available? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3595) Perl Bindings: Set serialization/deserialization differs
[
https://issues.apache.org/jira/browse/THRIFT-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136334#comment-15136334
]
Roger Meier commented on THRIFT-3595:
-
[~dmorel] Could you review that?
> Perl Bindings: Set serialization/deserialization differs
>
>
> Key: THRIFT-3595
> URL: https://issues.apache.org/jira/browse/THRIFT-3595
> Project: Thrift
> Issue Type: Bug
> Components: Perl - Compiler
>Affects Versions: 0.9.1, 0.9.2, 0.9.3
>Reporter: Adam Millerchip
>
> In the Perl bindings, a Thrift Set is dezerialized as a hashref, but the
> serialization code expects an arrayref. This causes the code to die when
> called if attempting to serialize a previously dezerialized Set.
> Additionally, it looks like there is a typo in the test that is testing this
> feature:
> https://github.com/apache/thrift/blob/49f4dc0cd8c87213a0f80ae1daba2d094a358ea7/test/perl/TestClient.pl#L262
> If you change that {{@$setout}} to {{@$setin}}, the test fails.
> It doesn't make much sense to implement a Set in Perl as array, because
> arrays allow duplicate entries and are ordered.
> I've written a change for the serialization that correctly expects a hashref:
> https://github.com/apache/thrift/pull/831
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (THRIFT-3550) Latest indexed version of the perl lib on CPAN is 0.8.0, although 0.9.0 is present
[ https://issues.apache.org/jira/browse/THRIFT-3550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136332#comment-15136332 ] Roger Meier edited comment on THRIFT-3550 at 2/7/16 5:40 PM: - I'm not familiar with the perl publishing process and do not know who did it before. Is it a simple thing? was (Author: roger.meier): I'm not familiar with the perl publishing process and do not know who did it before. Is it a simle thing? > Latest indexed version of the perl lib on CPAN is 0.8.0, although 0.9.0 is > present > -- > > Key: THRIFT-3550 > URL: https://issues.apache.org/jira/browse/THRIFT-3550 > Project: Thrift > Issue Type: Bug > Components: Perl - Library >Affects Versions: 0.9.3 >Reporter: David Morel > > Running cpanm or cpan installs version 0.8.0 of the perl lib, although 0.9.0 > has been uploaded on PAUSE. > Also, would be nice to have v 0.9.3 since it's available? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-3380) nodejs: 0.9.2 -> 0.9.3 upgrade breaks Protocol and Transport requires
[
https://issues.apache.org/jira/browse/THRIFT-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-3380.
-
Resolution: Won't Fix
> nodejs: 0.9.2 -> 0.9.3 upgrade breaks Protocol and Transport requires
> -
>
> Key: THRIFT-3380
> URL: https://issues.apache.org/jira/browse/THRIFT-3380
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
>Affects Versions: 0.9.3
>Reporter: Matt Willer
>Priority: Critical
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> Node.js projects that depend on Thrift and need to use a specific transport
> or protocol must require them in separately, like this:
> {code}
> var thrift = require('thrift'),
> ThriftTransports = require('thrift/lib/thrift/transport');
> {code}
> The new version (0.9.3) changed that directory structure of the thrift module
> so that the transport file is now located at
> thrift/lib/nodejs/lib/thrift/transport.js, which breaks any application that
> was requiring it at the old path. This type of breaking change is
> inappropriate for a patch version, and should be fixed immediately.
> The directory structure change also has the undesirable side effect of
> including every single language implementation of thrift in the Node.js
> module, bloating the size of the module with unnecessary files.
> Long-term, the right fix for this is to export useful parts of the library
> (e.g. transport and protocol constructors) from the main file, but since this
> is a patch version the immediate fix should be to maintain existing behavior.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3581) Pure Java build of the Thrift compiler using NestedVM [WIP]
[ https://issues.apache.org/jira/browse/THRIFT-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136222#comment-15136222 ] Roger Meier commented on THRIFT-3581: - I've downloaded the jar file you've made, nice! I think this is worth to add and I'm pretty sure Java Developers would love this. One issue I have is building nestedvm on my Debian Jessie machine, none of the 3 repos builds successful on my machine: * http://git.megacz.com/nestedvm.git * https://github.com/jdstroy/nestedvm.git * https://github.com/bgould/nestedvm.git > Pure Java build of the Thrift compiler using NestedVM [WIP] > --- > > Key: THRIFT-3581 > URL: https://issues.apache.org/jira/browse/THRIFT-3581 > Project: Thrift > Issue Type: New Feature > Components: Compiler (General) >Reporter: Benjamin Gould >Assignee: Benjamin Gould >Priority: Minor > Attachments: thrift-compiler-0.9.4-SNAPSHOT-sources.jar, > thrift-compiler-0.9.4-SNAPSHOT.jar > > > I've developed a build process for building the Thrift compiler as a JAR file > that can be run on a JVM and requires no dependencies by cross-compiling the > executable with NestedVM. > I think this could be use for the following, among other things: > 1) Building Thrift plugins for IDEs written in Java > 2) Integration into Java build tools like Ant and Maven > 3) Calling the compiler from a Java program when the host platform is unknown > Also, I see this as providing a way to potentially allow people to create > third party "plugins" for the compiler... Java and the plethora of JVM > language available might make creating new generators much more approachable > for people not comfortable with C++... and also in Java it is not complicated > to load code dynamically based on a class name as long as it is on the > classpath. > In any case, I have a working prototype, but it is far from battle tested. > For the inpatient, I'm attaching a snapshot build to this ticket, but you can > also find the source and build instructions here: > https://github.com/bgould/thrift/tree/nestedvm/contrib/nestedvm > Will open a pull request when I feel all of the wrinkles have been ironed out > (it is close, and quite usuable already) to see if it might be appropriate to > bring this into the contrib/ folder, or even include as an artifact in the > Maven repos for a future release. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-3419) thrift-maven-plugin property error
[
https://issues.apache.org/jira/browse/THRIFT-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-3419.
-
Resolution: Fixed
all,
thanks for the patch and testing it!
> thrift-maven-plugin property error
> --
>
> Key: THRIFT-3419
> URL: https://issues.apache.org/jira/browse/THRIFT-3419
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
>Affects Versions: 0.9.3, 0.9.4, 1.0
>Reporter: chillon_m
> Labels: patch
> Attachments: temporaryThriftFileDirectory.patch, thrift-error.png
>
>
> execute 'mvn compile' occure an error:
> The parameters '${project.build.directory}/thrift-dependencies' for goal
> org.apache.thrift:thrift-maven-plugin:0.9.3:compile are missing or invalid
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-1482) Unix domain socket support under PHP
[ https://issues.apache.org/jira/browse/THRIFT-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136207#comment-15136207 ] Roger Meier commented on THRIFT-1482: - please attach a patch or create a Pull request > Unix domain socket support under PHP > > > Key: THRIFT-1482 > URL: https://issues.apache.org/jira/browse/THRIFT-1482 > Project: Thrift > Issue Type: New Feature > Components: PHP - Library >Affects Versions: 0.8 >Reporter: Asad Saeed >Assignee: Roger Meier > Fix For: 0.9.4 > > > I would like to use Unix domain sockets under PHP for TSocket and > TServerSocket. Currently only tcp can be used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3581) Pure Java build of the Thrift compiler using NestedVM [WIP]
[ https://issues.apache.org/jira/browse/THRIFT-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132276#comment-15132276 ] Roger Meier commented on THRIFT-3581: - Cool, I was not aware of this possibility. However, http://nestedvm.ibex.org/ seems not to be in a maintained state. > Pure Java build of the Thrift compiler using NestedVM [WIP] > --- > > Key: THRIFT-3581 > URL: https://issues.apache.org/jira/browse/THRIFT-3581 > Project: Thrift > Issue Type: New Feature > Components: Compiler (General) >Reporter: Benjamin Gould >Assignee: Benjamin Gould >Priority: Minor > Attachments: thrift-compiler-0.9.4-SNAPSHOT-sources.jar, > thrift-compiler-0.9.4-SNAPSHOT.jar > > > I've developed a build process for building the Thrift compiler as a JAR file > that can be run on a JVM and requires no dependencies by cross-compiling the > executable with NestedVM. > I think this could be use for the following, among other things: > 1) Building Thrift plugins for IDEs written in Java > 2) Integration into Java build tools like Ant and Maven > 3) Calling the compiler from a Java program when the host platform is unknown > Also, I see this as providing a way to potentially allow people to create > third party "plugins" for the compiler... Java and the plethora of JVM > language available might make creating new generators much more approachable > for people not comfortable with C++... and also in Java it is not complicated > to load code dynamically based on a class name as long as it is on the > classpath. > In any case, I have a working prototype, but it is far from battle tested. > For the inpatient, I'm attaching a snapshot build to this ticket, but you can > also find the source and build instructions here: > https://github.com/bgould/thrift/tree/nestedvm/contrib/nestedvm > Will open a pull request when I feel all of the wrinkles have been ironed out > (it is close, and quite usuable already) to see if it might be appropriate to > bring this into the contrib/ folder, or even include as an artifact in the > Maven repos for a future release. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-3556) c_glib file descriptor transport
[ https://issues.apache.org/jira/browse/THRIFT-3556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier updated THRIFT-3556: Assignee: Simon South > c_glib file descriptor transport > > > Key: THRIFT-3556 > URL: https://issues.apache.org/jira/browse/THRIFT-3556 > Project: Thrift > Issue Type: Improvement > Components: C glib - Library >Affects Versions: 0.9.3 >Reporter: Chandler May >Assignee: Simon South > > c_glib library does not have any filesystem transports, including a file > descriptor transport -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-3589) Dart generator uses wrong name in constructor for uppercase arguments with defaults
[ https://issues.apache.org/jira/browse/THRIFT-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-3589. - Resolution: Fixed committed > Dart generator uses wrong name in constructor for uppercase arguments with > defaults > --- > > Key: THRIFT-3589 > URL: https://issues.apache.org/jira/browse/THRIFT-3589 > Project: Thrift > Issue Type: Bug > Components: Dart - Compiler >Reporter: Mark Erickson >Assignee: Mark Erickson > Fix For: 0.9.4 > > > PROBLEM > The dart generator produces inconsistent code for argument names that start > with an uppercase letter and have a default value. The function signature > uses lowercase, but the constructor uses uppercase. > SOLUTION > Pass the argument name through the get_field_name() function, to generate > code consistent with the other references of argument names. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-3549) Exceptions are not properly stringified in Perl library
[
https://issues.apache.org/jira/browse/THRIFT-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-3549.
-
Resolution: Fixed
Fix Version/s: 1.0
0.9.4
Thanks David
> Exceptions are not properly stringified in Perl library
> ---
>
> Key: THRIFT-3549
> URL: https://issues.apache.org/jira/browse/THRIFT-3549
> Project: Thrift
> Issue Type: Bug
> Components: Perl - Library
>Affects Versions: 0.9.3
>Reporter: David Morel
> Fix For: 0.9.4, 1.0
>
> Attachments: THRIFT-3549.001.patch
>
>
> since exceptions are Thrift::TException objects and are used in numerous
> places in die() statements, most of the time the error message would be along
> the lines of:
> {{(in cleanup) Thrift::TException=HASH(0x7fdaa2939900) at (eval 38) line
> 31}}
> which is absolutely useless. The patch below (as suggested on the cpan
> bugtracker) overloads stringification of the exception to present something
> more meaningful, like:
> {{(in cleanup) Thrift::TException error: Thrift::Socket: timed out
> reading from localhost:1 (code 0) at (eval 37) line 31.}}
> {noformat}
> --- perl5extralib/Thrift.pm 2016-01-13 11:37:07.0 +0100
> +++ Downloads/thrift-0.9.3/lib/perl/lib/Thrift.pm 2015-09-27
> 04:50:44.0 +0200
> @@ -58,15 +58,6 @@
> package Thrift::TException;
> -use overload '""' => sub {
> -return
> - ref( $_[0] )
> -. " error: "
> -. ( $_[0]->{message} || 'empty message' )
> -. " (code "
> -. ( defined $_[0]->{code} ? $_[0]->{code} : 'undefined' ) . ")";
> -};
> -
> sub new {
> my $classname = shift;
> my $self = {message => shift, code => shift || 0};
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-66) Java: Allow multiplexing multiple services over a single TCP connection
[
https://issues.apache.org/jira/browse/THRIFT-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15111493#comment-15111493
]
Roger Meier commented on THRIFT-66:
---
I suggest to create a new ticket for this.
Start with the spec and as soon as we have a consensus on the spec, add
subtasks for the languages and implement.
> Java: Allow multiplexing multiple services over a single TCP connection
> ---
>
> Key: THRIFT-66
> URL: https://issues.apache.org/jira/browse/THRIFT-66
> Project: Thrift
> Issue Type: Sub-task
> Components: C# - Library, C++ - Library, Cocoa - Library, Erlang -
> Library, Java - Library, Perl - Library, Python - Library, Ruby - Library
>Reporter: Johan Stuyts
>Assignee: Roger Meier
>Priority: Trivial
> Fix For: 0.9.2
>
> Attachments: CalculatorImpl.java, MultiplexTestClientMain.java,
> MultiplexTestServerMain.java, ReleaseWaitingReplyThreadsOnDisconnect.patch,
> SharedImpl.java, TMultiplexServer.java, TMultiplexServer.py,
> TSimpleMultiplexServer.java, Thrift Endpoints and Channels.vsd,
> ThriftCSharpEndpointsChannels.zip, ThriftMultiplexInvocationHandler.java
>
>
> The current {{TServer}} implementations expose a single service on a port. If
> an application has many services many ports have to be opened. This is
> cumbersome because:
> - you have to document which service is available on which port, and
> remembering the port numbers is difficult
> - to prevent the overhead of connection setup on each call, a client has to
> maintain to many connections: at least one to each port
> - it requires opening many ports on a firewall if one is between the client
> and the server.
> By multiplexing multiple services on a single port the problems above are
> resolved:
> - instead of a port number a symbolic name can be assigned to a service
> - a client can maintain a small pool of connections to a single port
> - only one port has to be opened on the firewall
> The attached Java implementation simply wraps a normal {{CALL}} message with
> a (new) {{SERVICE_SELECTION}} message. It is not necessary to modify or wrap
> the response. No changes are needed to the generated classes. Only a new type
> of server is introduced, and an invocation handler for a dynamic proxy around
> the {{Client}} classes of services is provided for the client side. The
> implementation does not handle communication errors (invalid data, timeouts,
> etc.) yet.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3555) 'configure' script does not honor --with-openssl= for libcrypto for BN_init
[
https://issues.apache.org/jira/browse/THRIFT-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15103971#comment-15103971
]
Roger Meier commented on THRIFT-3555:
-
Do you already have a patch?
see https://thrift.apache.org/docs/HowToContribute
> 'configure' script does not honor --with-openssl= for libcrypto for
> BN_init
> -
>
> Key: THRIFT-3555
> URL: https://issues.apache.org/jira/browse/THRIFT-3555
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
>Affects Versions: 0.9.3
>Reporter: Peter Butler
>
> When running the 'configure' script to set up the thrift build environment,
> the path supplied to the 'with-openssl=' option is not honored for all
> tests within the script where libcrypto is required.
> For the first part of the script the path is indeed honored. For example, at
> line 17316 ("checking whether compiling and linking against OpenSSL works")
> it can be easily validated (via strace and/or bash script debugging) that the
> correct user-supplied path to a particular OpenSSL library is being used.
> However, later in the script, at line 23292 ("checking for BN_init in
> -lcrypto...") this is not the case. Again this can readily verified (via
> strace and/or bash script debugging) that the user supplied path is skipped
> entirely, and only the O/S system-defined default library paths are searched
> for libcrypto.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3549) Exceptions are not properly stringified in Perl library
[
https://issues.apache.org/jira/browse/THRIFT-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15103970#comment-15103970
]
Roger Meier commented on THRIFT-3549:
-
Could you provide a link to the cpan bugtracker and attach the patch, see
https://thrift.apache.org/docs/HowToContribute
> Exceptions are not properly stringified in Perl library
> ---
>
> Key: THRIFT-3549
> URL: https://issues.apache.org/jira/browse/THRIFT-3549
> Project: Thrift
> Issue Type: Bug
> Components: Perl - Library
>Affects Versions: 0.9.3
>Reporter: David Morel
>
> since exceptions are Thrift::TException objects and are used in numerous
> places in die() statements, most of the time the error message would be along
> the lines of:
> {{(in cleanup) Thrift::TException=HASH(0x7fdaa2939900) at (eval 38) line
> 31}}
> which is absolutely useless. The patch below (as suggested on the cpan
> bugtracker) overloads stringification of the exception to present something
> more meaningful, like:
> {{(in cleanup) Thrift::TException error: Thrift::Socket: timed out
> reading from localhost:1 (code 0) at (eval 37) line 31.}}
> {noformat}
> --- perl5extralib/Thrift.pm 2016-01-13 11:37:07.0 +0100
> +++ Downloads/thrift-0.9.3/lib/perl/lib/Thrift.pm 2015-09-27
> 04:50:44.0 +0200
> @@ -58,15 +58,6 @@
> package Thrift::TException;
> -use overload '""' => sub {
> -return
> - ref( $_[0] )
> -. " error: "
> -. ( $_[0]->{message} || 'empty message' )
> -. " (code "
> -. ( defined $_[0]->{code} ? $_[0]->{code} : 'undefined' ) . ")";
> -};
> -
> sub new {
> my $classname = shift;
> my $self = {message => shift, code => shift || 0};
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-3551) Thrift perl library missing package declaration
[
https://issues.apache.org/jira/browse/THRIFT-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-3551.
-
Resolution: Fixed
Assignee: Roger Meier
Fix Version/s: 1.0
0.9.4
committed
> Thrift perl library missing package declaration
> ---
>
> Key: THRIFT-3551
> URL: https://issues.apache.org/jira/browse/THRIFT-3551
> Project: Thrift
> Issue Type: Bug
> Components: Perl - Library
>Affects Versions: 0.9.3
>Reporter: David Morel
>Assignee: Roger Meier
> Fix For: 0.9.4, 1.0
>
>
> The perl library is missing a {{package Thrift;}} declaration at the top,
> resulting in the library version {{our $VERSION}} being inaccessible from the
> outside of the class. It's apparently a very simple fix
> {noformat}
> --- perl5extralib/Thrift.pm 2016-01-13 12:59:26.0 +0100
> +++ Downloads/thrift-0.9.3/lib/perl/lib/Thrift.pm 2015-09-27
> 04:50:44.0 +0200
> @@ -17,8 +17,6 @@
> # under the License.
> #
> -package Thrift;
> -
> our $VERSION = '0.9.3';
> require 5.6.0;
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-3558) typos in c_glib tests
[ https://issues.apache.org/jira/browse/THRIFT-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-3558. - Resolution: Fixed Fix Version/s: 1.0 0.9.4 Thanks! > typos in c_glib tests > - > > Key: THRIFT-3558 > URL: https://issues.apache.org/jira/browse/THRIFT-3558 > Project: Thrift > Issue Type: Bug > Components: C glib - Library >Affects Versions: 0.9.3 >Reporter: Chandler May >Priority: Minor > Fix For: 0.9.4, 1.0 > > > There are five accidental assignments (instead of equality comparisons) > inside asserts in lib/c_glib/test/testbinaryprotocol.c, starting at line 439 > in git revision f58bca7. There is also one in > lib/c_glib/test/testoptionalrequired.c at line 82. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-3428) Go test fails when running make check
[
https://issues.apache.org/jira/browse/THRIFT-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-3428.
-
Resolution: Fixed
Assignee: Roger Meier
Fix Version/s: 1.0
0.9.4
> Go test fails when running make check
> -
>
> Key: THRIFT-3428
> URL: https://issues.apache.org/jira/browse/THRIFT-3428
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Environment: Debian Jessie amd64
> go version go1.5.1 linux/amd64
>Reporter: Roger Meier
>Assignee: Roger Meier
> Fix For: 0.9.4, 1.0
>
> Attachments: THRIFT-3428_go_test_fail_on_busy_machine.patch
>
>
> Is this a local roger problem?
> {noformat}
> make[3]: Leaving directory 'thrift-git/lib/go'
> Making check in test
> make[3]: Entering directory 'thrift-git/lib/go/test'
> GOPATH=`pwd`/gopath /usr/local/go/bin/go build \
> includestest \
> binarykeytest \
> servicestest \
> typedeffieldtest \
> refannotationfieldstest \
> errortest \
> namestest \
> initialismstest \
> dontexportrwtest \
> ignoreinitialismstest
> GOPATH=`pwd`/gopath /usr/local/go/bin/go test thrift tests dontexportrwtest
> okthrift 0.010s
> --- FAIL: TestInitClient1 (0.00s)
> multiplexed_protocol_test.go:83: Unable to open client socket dial tcp
> 127.0.0.1:56418: getsockopt: connection refused
> --- FAIL: TestCallFirst (0.00s)
> multiplexed_protocol_test.go:117: Unable to call first server:
> Connection not open
> Hi!
> FAIL
> FAIL tests 0.065s
> okdontexportrwtest0.002s
> Makefile:658: recipe for target 'check' failed
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-3552) glib_c Memory Leak
[ https://issues.apache.org/jira/browse/THRIFT-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-3552. - Resolution: Fixed Fix Version/s: 1.0 0.9.4 Thanks Simon! > glib_c Memory Leak > -- > > Key: THRIFT-3552 > URL: https://issues.apache.org/jira/browse/THRIFT-3552 > Project: Thrift > Issue Type: Bug > Components: C glib - Library >Affects Versions: 0.9.3 >Reporter: Anish Shah >Assignee: Simon South >Priority: Critical > Fix For: 0.9.4, 1.0 > > Attachments: 0001-c_glib-Fix-memory-leak-in-processor.patch > > > I have been seeing some memory leaks using valgring in my testprogram. > Leak: > ==94320== 17,878 bytes in 2,712 blocks are definitely lost in loss record 987 > of 1,018 > ==94320==at 0x4A057BB: calloc (vg_replace_malloc.c:593) > ==94320==by 0x3D7DA49BF7: g_malloc0 (gmem.c:196) > ==94320==by 0x5768002: thrift_binary_protocol_read_string > (thrift_binary_protocol.c:791) > ==94320==by 0x5768987: thrift_binary_protocol_read_message_begin > (thrift_binary_protocol.c:431) > ==94320==by 0x576702E: thrift_dispatch_processor_process > (thrift_dispatch_processor.c:41) > ==94320==by 0x576CC06: thrift_simple_server_serve > (thrift_simple_server.c:62) > ==94320==by 0x45A548: server_start (server.c:135) > ==94320==by 0x3D7C607A50: start_thread (pthread_create.c:301) > ==94320==by 0x3D7C2E893C: clone (clone.S:115) > My question is where is the *str memory allocated by function > thrift_binary_protocol_read_string() freed? Am I doing something wrong or is > there an actual memory leak? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-3428) Go test fails when running make check
[
https://issues.apache.org/jira/browse/THRIFT-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier updated THRIFT-3428:
Patch Info: Patch Available
> Go test fails when running make check
> -
>
> Key: THRIFT-3428
> URL: https://issues.apache.org/jira/browse/THRIFT-3428
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Environment: Debian Jessie amd64
> go version go1.5.1 linux/amd64
>Reporter: Roger Meier
> Attachments: THRIFT-3428_go_test_fail_on_busy_machine.patch
>
>
> Is this a local roger problem?
> {noformat}
> make[3]: Leaving directory 'thrift-git/lib/go'
> Making check in test
> make[3]: Entering directory 'thrift-git/lib/go/test'
> GOPATH=`pwd`/gopath /usr/local/go/bin/go build \
> includestest \
> binarykeytest \
> servicestest \
> typedeffieldtest \
> refannotationfieldstest \
> errortest \
> namestest \
> initialismstest \
> dontexportrwtest \
> ignoreinitialismstest
> GOPATH=`pwd`/gopath /usr/local/go/bin/go test thrift tests dontexportrwtest
> okthrift 0.010s
> --- FAIL: TestInitClient1 (0.00s)
> multiplexed_protocol_test.go:83: Unable to open client socket dial tcp
> 127.0.0.1:56418: getsockopt: connection refused
> --- FAIL: TestCallFirst (0.00s)
> multiplexed_protocol_test.go:117: Unable to call first server:
> Connection not open
> Hi!
> FAIL
> FAIL tests 0.065s
> okdontexportrwtest0.002s
> Makefile:658: recipe for target 'check' failed
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-3428) Go test fails when running make check
[
https://issues.apache.org/jira/browse/THRIFT-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier updated THRIFT-3428:
Attachment: THRIFT-3428_go_test_fail_on_busy_machine.patch
> Go test fails when running make check
> -
>
> Key: THRIFT-3428
> URL: https://issues.apache.org/jira/browse/THRIFT-3428
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Environment: Debian Jessie amd64
> go version go1.5.1 linux/amd64
>Reporter: Roger Meier
> Attachments: THRIFT-3428_go_test_fail_on_busy_machine.patch
>
>
> Is this a local roger problem?
> {noformat}
> make[3]: Leaving directory 'thrift-git/lib/go'
> Making check in test
> make[3]: Entering directory 'thrift-git/lib/go/test'
> GOPATH=`pwd`/gopath /usr/local/go/bin/go build \
> includestest \
> binarykeytest \
> servicestest \
> typedeffieldtest \
> refannotationfieldstest \
> errortest \
> namestest \
> initialismstest \
> dontexportrwtest \
> ignoreinitialismstest
> GOPATH=`pwd`/gopath /usr/local/go/bin/go test thrift tests dontexportrwtest
> okthrift 0.010s
> --- FAIL: TestInitClient1 (0.00s)
> multiplexed_protocol_test.go:83: Unable to open client socket dial tcp
> 127.0.0.1:56418: getsockopt: connection refused
> --- FAIL: TestCallFirst (0.00s)
> multiplexed_protocol_test.go:117: Unable to call first server:
> Connection not open
> Hi!
> FAIL
> FAIL tests 0.065s
> okdontexportrwtest0.002s
> Makefile:658: recipe for target 'check' failed
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Reopened] (THRIFT-3428) Go test fails when running make check
[
https://issues.apache.org/jira/browse/THRIFT-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier reopened THRIFT-3428:
-
The good thing, the issue is reproducable!
*clients starts to fast or server takes to long to start*
I added *time.Sleep* after startup of the servers and *make check* passes
always now.
Dear go coders, is there a better way to fix this?
> Go test fails when running make check
> -
>
> Key: THRIFT-3428
> URL: https://issues.apache.org/jira/browse/THRIFT-3428
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Environment: Debian Jessie amd64
> go version go1.5.1 linux/amd64
>Reporter: Roger Meier
> Attachments: THRIFT-3428_go_test_fail_on_busy_machine.patch
>
>
> Is this a local roger problem?
> {noformat}
> make[3]: Leaving directory 'thrift-git/lib/go'
> Making check in test
> make[3]: Entering directory 'thrift-git/lib/go/test'
> GOPATH=`pwd`/gopath /usr/local/go/bin/go build \
> includestest \
> binarykeytest \
> servicestest \
> typedeffieldtest \
> refannotationfieldstest \
> errortest \
> namestest \
> initialismstest \
> dontexportrwtest \
> ignoreinitialismstest
> GOPATH=`pwd`/gopath /usr/local/go/bin/go test thrift tests dontexportrwtest
> okthrift 0.010s
> --- FAIL: TestInitClient1 (0.00s)
> multiplexed_protocol_test.go:83: Unable to open client socket dial tcp
> 127.0.0.1:56418: getsockopt: connection refused
> --- FAIL: TestCallFirst (0.00s)
> multiplexed_protocol_test.go:117: Unable to call first server:
> Connection not open
> Hi!
> FAIL
> FAIL tests 0.065s
> okdontexportrwtest0.002s
> Makefile:658: recipe for target 'check' failed
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-3127) switch -recurse to --recurse and reserve -r
[
https://issues.apache.org/jira/browse/THRIFT-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-3127.
-
Resolution: Fixed
change parameters within rb
> switch -recurse to --recurse and reserve -r
> ---
>
> Key: THRIFT-3127
> URL: https://issues.apache.org/jira/browse/THRIFT-3127
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
>Affects Versions: 0.9.2
>Reporter: Xiaoshuang LU
>Assignee: Roger Meier
>
> we may need to switch {code}-recurse{code} to {code}--recurse{code},
> and reserve {code}-r{code} since it is the standard behavior of command line
> parameter processing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-3428) Go test fails when running make check
[
https://issues.apache.org/jira/browse/THRIFT-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-3428.
-
Resolution: Not A Problem
seems to be a local problem
> Go test fails when running make check
> -
>
> Key: THRIFT-3428
> URL: https://issues.apache.org/jira/browse/THRIFT-3428
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Environment: Debian Jessie amd64
> go version go1.5.1 linux/amd64
>Reporter: Roger Meier
>
> Is this a local roger problem?
> {noformat}
> make[3]: Leaving directory 'thrift-git/lib/go'
> Making check in test
> make[3]: Entering directory 'thrift-git/lib/go/test'
> GOPATH=`pwd`/gopath /usr/local/go/bin/go build \
> includestest \
> binarykeytest \
> servicestest \
> typedeffieldtest \
> refannotationfieldstest \
> errortest \
> namestest \
> initialismstest \
> dontexportrwtest \
> ignoreinitialismstest
> GOPATH=`pwd`/gopath /usr/local/go/bin/go test thrift tests dontexportrwtest
> okthrift 0.010s
> --- FAIL: TestInitClient1 (0.00s)
> multiplexed_protocol_test.go:83: Unable to open client socket dial tcp
> 127.0.0.1:56418: getsockopt: connection refused
> --- FAIL: TestCallFirst (0.00s)
> multiplexed_protocol_test.go:117: Unable to call first server:
> Connection not open
> Hi!
> FAIL
> FAIL tests 0.065s
> okdontexportrwtest0.002s
> Makefile:658: recipe for target 'check' failed
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-3538) Remove UnboundMethodType in TProtocolDecorator
[
https://issues.apache.org/jira/browse/THRIFT-3538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-3538.
-
Resolution: Fixed
Fix Version/s: 1.0
0.9.4
committed
> Remove UnboundMethodType in TProtocolDecorator
> --
>
> Key: THRIFT-3538
> URL: https://issues.apache.org/jira/browse/THRIFT-3538
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Reporter: Thomas Bartelmess
> Fix For: 0.9.4, 1.0
>
>
> UnboundMethodType is the same as MethodType, and it's gone in Python 3.
> Removing it doesn't cause any harm because it's just an alias to MethodType
> {code}
> Python 2.7.10 (default, Aug 20 2015, 14:23:27)
> [GCC 4.2.1 Compatible Apple LLVM 6.1.0 (clang-602.0.53)] on darwin
> Type "help", "copyright", "credits" or "license" for more information.
> >>> from types import *
> >>> UnboundMethodType == MethodType
> True
> >>> UnboundMethodType is MethodType
> True
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-1736) Visual Studio top level project files within msvc
[ https://issues.apache.org/jira/browse/THRIFT-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-1736. - Resolution: Won't Fix we have CMake to generate MSVC files > Visual Studio top level project files within msvc > - > > Key: THRIFT-1736 > URL: https://issues.apache.org/jira/browse/THRIFT-1736 > Project: Thrift > Issue Type: Improvement > Components: C# - Compiler >Reporter: Roger Meier > > improve visual studio support by introducing a top level solution file within > top level msvc folder. > see libusb for a good example: > http://www.libusb.org/browser/libusb/msvc -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-3208) Fix Visual Studio solution build failure due to missing source
[ https://issues.apache.org/jira/browse/THRIFT-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-3208. - Resolution: Fixed Assignee: Roger Meier Fix Version/s: 1.0 0.9.4 committed > Fix Visual Studio solution build failure due to missing source > -- > > Key: THRIFT-3208 > URL: https://issues.apache.org/jira/browse/THRIFT-3208 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library >Affects Versions: 0.9.2 > Environment: Visual Studio >Reporter: Paweł Janicki >Assignee: Roger Meier >Priority: Minor > Labels: easyfix > Fix For: 0.9.4, 1.0 > > > The Visual Studio solution still refers to lib\cpp\src\thrift\Thrift.cpp that > was renamed to lib\cpp\src\thrift\TOutput.cpp by commit > 24ea0bf5df0e431416fca897077af220a27b0320. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-3534) Link error when building with Qt5
[ https://issues.apache.org/jira/browse/THRIFT-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-3534. - Resolution: Fixed committed > Link error when building with Qt5 > - > > Key: THRIFT-3534 > URL: https://issues.apache.org/jira/browse/THRIFT-3534 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Reporter: Harald Fernengel > Attachments: THRIFT-3534-qt5-build-fix.patch > > > When building thrift with CMakeLists.txt and Qt5 support, I'm getting: > Undefined symbols for architecture x86_64: > "apache::thrift::TOutput::strerror_s(int)", referenced from: > > apache::thrift::transport::TTransportException::TTransportException(apache::thrift::transport::TTransportException::TTransportExceptionType, > std::__1::basic_string, > std::__1::allocator > const&, int) in TQIODeviceTransport.cpp.o > "typeinfo for apache::thrift::transport::TTransportException", referenced > from: > apache::thrift::transport::TQIODeviceTransport::open() in > TQIODeviceTransport.cpp.o > apache::thrift::transport::TQIODeviceTransport::read(unsigned char*, > unsigned int) in TQIODeviceTransport.cpp.o > The Qt5 lib is not linking to thriftcpp, thus, the linker complains. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-3534) Link error when building with Qt5
[ https://issues.apache.org/jira/browse/THRIFT-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier updated THRIFT-3534: Fix Version/s: 1.0 0.9.4 > Link error when building with Qt5 > - > > Key: THRIFT-3534 > URL: https://issues.apache.org/jira/browse/THRIFT-3534 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Reporter: Harald Fernengel > Fix For: 0.9.4, 1.0 > > Attachments: THRIFT-3534-qt5-build-fix.patch > > > When building thrift with CMakeLists.txt and Qt5 support, I'm getting: > Undefined symbols for architecture x86_64: > "apache::thrift::TOutput::strerror_s(int)", referenced from: > > apache::thrift::transport::TTransportException::TTransportException(apache::thrift::transport::TTransportException::TTransportExceptionType, > std::__1::basic_string, > std::__1::allocator > const&, int) in TQIODeviceTransport.cpp.o > "typeinfo for apache::thrift::transport::TTransportException", referenced > from: > apache::thrift::transport::TQIODeviceTransport::open() in > TQIODeviceTransport.cpp.o > apache::thrift::transport::TQIODeviceTransport::read(unsigned char*, > unsigned int) in TQIODeviceTransport.cpp.o > The Qt5 lib is not linking to thriftcpp, thus, the linker complains. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-3452) .travis.yml: Migrating from legacy to container-based infrastructure
[ https://issues.apache.org/jira/browse/THRIFT-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-3452. - Resolution: Fixed I would say we did it ;-) > .travis.yml: Migrating from legacy to container-based infrastructure > > > Key: THRIFT-3452 > URL: https://issues.apache.org/jira/browse/THRIFT-3452 > Project: Thrift > Issue Type: Story > Components: Build Process >Reporter: Roger Meier >Assignee: Roger Meier > > I've started to work on this: > https://docs.travis-ci.com/user/migrating-from-legacy/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-3469) Docker: Debian support
[ https://issues.apache.org/jira/browse/THRIFT-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-3469. - Resolution: Fixed Fix Version/s: 1.0 0.9.4 committed > Docker: Debian support > -- > > Key: THRIFT-3469 > URL: https://issues.apache.org/jira/browse/THRIFT-3469 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Reporter: Roger Meier >Assignee: Roger Meier > Fix For: 0.9.4, 1.0 > > > I like to support Docker using Debian( the upstream project of Ubuntu). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3014) AppVeyor support
[ https://issues.apache.org/jira/browse/THRIFT-3014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090962#comment-15090962 ] Roger Meier commented on THRIFT-3014: - We need a hook on GitHub to trigger the AppVeyor build automatically. I do this with my GH account at the moment https://ci.appveyor.com/project/bufferoverflow/thrift > AppVeyor support > > > Key: THRIFT-3014 > URL: https://issues.apache.org/jira/browse/THRIFT-3014 > Project: Thrift > Issue Type: Bug > Components: Build Process > Environment: Windows >Reporter: Roger Meier >Assignee: Roger Meier > Fix For: 0.9.4 > > Attachments: appveyor.yml > > > same as travis on linux is appveyor for WIndows > see it in action here: https://ci.appveyor.com/project/bufferoverflow/thrift/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-3514) PHP 7 compatible version of binary protocol
[ https://issues.apache.org/jira/browse/THRIFT-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-3514. - Resolution: Fixed Fix Version/s: 0.9.4 Hi David & PHP people! To be honest, I'm not the fan of redundant code, but it seems that you are willing to refactor this and other php coders like it as well, so I've committed this. Looking forward for other patches from the php community. Thank you and all the PHP people for getting the open source code based internet really started ... LAMP! Where would we be today without? all the best! -roger PS: could you close the PR on github? here https://github.com/apache/thrift/pull/765 I forgot to do a git --amend to add the closes #765 line :-( > PHP 7 compatible version of binary protocol > --- > > Key: THRIFT-3514 > URL: https://issues.apache.org/jira/browse/THRIFT-3514 > Project: Thrift > Issue Type: Improvement > Components: PHP - Library >Reporter: David Soria Parra > Fix For: 0.9.4, 1.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-184) Add OSGi Manifest headers to the libthrift java library to be able to use Thrift in the OSGi runtime
[ https://issues.apache.org/jira/browse/THRIFT-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-184. Resolution: Fixed > Add OSGi Manifest headers to the libthrift java library to be able to use > Thrift in the OSGi runtime > > > Key: THRIFT-184 > URL: https://issues.apache.org/jira/browse/THRIFT-184 > Project: Thrift > Issue Type: New Feature > Components: Java - Library >Reporter: Siamak Haschemi >Assignee: Jake Farrell >Priority: Trivial > Fix For: 1.0 > > Attachments: bnd-0.0.249.jar, libthrift.bnd, osgi.patch, > thrift-184.patch > > Original Estimate: 10m > Remaining Estimate: 10m > > To be able to use Thrift in the OSGi runtime (see > http://en.wikipedia.org/wiki/OSGi), some additional Manifest entries are > needed. The bnd-tool (see http://www.aqute.biz/Code/Bnd) creates this entries > automatically. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3475) prefix tags with v as defined by semver
[
https://issues.apache.org/jira/browse/THRIFT-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060994#comment-15060994
]
Roger Meier commented on THRIFT-3475:
-
[~jfarrell] Would you like to do this or shall I?
> prefix tags with v as defined by semver
> ---
>
> Key: THRIFT-3475
> URL: https://issues.apache.org/jira/browse/THRIFT-3475
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
>Reporter: Roger Meier
>
> We need to prefix our tags with **v** to follow the semver model, e.g.
> **v0.9.3**
> non prefix causes issues such as tag and branch conflicts.
> I had to do this when pushing to the release branch on my fork
> {noformat}
> git push bufferoverflow heads/0.9.3
> {noformat}
> see also THRIFT-6
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-747) C++ TSocket->close calls shutdown breaking forked parent process
[ https://issues.apache.org/jira/browse/THRIFT-747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-747. Resolution: Won't Fix > C++ TSocket->close calls shutdown breaking forked parent process > > > Key: THRIFT-747 > URL: https://issues.apache.org/jira/browse/THRIFT-747 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.2, 0.3 > Environment: Cygwin 1.7.1 on Windows XP SP3, Thrift 0.2.0 & r760184 & > Trunk >Reporter: Tim Wilson-Brown >Priority: Minor > Attachments: TSocket-020-fix.cpp, TSocket-020-fix.h, > thrift_shutdown_example.cpp > > Original Estimate: 72h > Remaining Estimate: 72h > > If a Thrift C++ Client opens a TSocket, then calls fork(), the child process > can terminate the parent processes' connection by deleting its copy of the > parent TSocket. > In particular, > TSocket->close() calls shutdown(socket_,SHUT_RDWR) before close(socket_) > Discussion: > This behaviour is inconsistent, as it is: > * unlike the unix socket close() semantics - close() only affects the > process that calls it, and the socket is shut down when all copies of it are > closed > * unlike the python and java code, which (appears) to only use close() > This design choice makes it really difficult to program a Thrift client that > forks other clients in C++, as the first process to call TSocket->close() > terminates all copies of the connection. The child process is unable to > cleanup its copy of the parent's connection - this is a particular issue when > using shared_ptr because the child process can not even exit(). > However, the design choice also prevents deadlock/slowdown issues where a > forked process holds open a copy of the parent's Thrift connections. > The design choice may also be an attempt to implement the 'block to send then > close' behaviour described in > http://blog.netherlabs.nl/articles/2009/01/18/the-ultimate-so_linger-page-or-why-is-my-tcp-not-reliable > However, the shutdown call, and close with the default linger interval of 0 > are both hard resets. > In the absence of linger/shutdown, the kernel can usually send small thrift > messages by itself. > Options: > * The most functional resolution would be to implement > TSocket->setShutdownOnClose() that allows Thrift users to set their > preference for shutdown on socket close or delete. However, this change may > also need to be made to other language libraries. > * Removing shutdown() from TSocket->close() could break programs that > expect TSockets not to stay open if children are still running. > TODO: > * Confirm issue on Linux - see attached test code > * Decide how to resolve issue > * Create Patch - see attached TSocket.h & TSocket.cpp from Thrift 0.2.0 (I > don't know how to generate patches but I'm happy to try and work it out) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3479) Oneway calls should not return exceptions to clients
[ https://issues.apache.org/jira/browse/THRIFT-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15049379#comment-15049379 ] Roger Meier commented on THRIFT-3479: - Thanks for the patch! Yes, one way should behave like this, but we still have the risk that it behaves different within the languages and we have over 20 of them... One of the most challenging parts of Thrift is same behavior across languages, that's why we invested a lot into cross language testing which is described over here: http://thrift.apache.org/test/ > Oneway calls should not return exceptions to clients > > > Key: THRIFT-3479 > URL: https://issues.apache.org/jira/browse/THRIFT-3479 > Project: Thrift > Issue Type: Bug > Components: Java - Library >Affects Versions: 0.9.1, 0.9.2, 0.9.3 >Reporter: Josh Elser >Priority: Critical > Fix For: 0.9.4 > > Attachments: THRIFT-3479.001.patch > > > We noticed the following happening over in ACCUMULO-4065. > A client made a oneway call to a server which ultimately caused a TException > to propagate up through to ProcessFunction. This caused a message to be sent > back to the client with a TApplicationException wrapping the TException. > The problem is that the client had already returned its connection to a pool > because it was oneway (it had no means to know when the call finished -- nor > did it care). The next client that tried to send an RPC to the same server > sent its message, then read the response off the wire, only to get the oneway > call's exception Message, not the response for the call it made. > Ultimately, this screwed up the connection (the next client was always > reading the previous clients response). > Given my understanding on the current implementation (mostly discerned from > the docs, a bit from code), it's my belief that oneway calls can never safely > return a message to clients. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-1805) Thrift should not swallow ALL exceptions
[ https://issues.apache.org/jira/browse/THRIFT-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15049363#comment-15049363 ] Roger Meier commented on THRIFT-1805: - [~elserj], you are right. It is up to you to show interest and contribute on the Java part of Thrift. There are not that many patches and improvement coming in for Java nowadays. Managing every api change within PMC is not ideal as we do not have enough Java stakeholders there. We need to discuss these topics within Jira or the dev mailing list to get some more Java people involved. There are many other projects out there using Thrift without the Apache sister projects and they use other languages such as go, nodejs, c++. I would really like to have more involvement of Apache sister projects and I guess most of them depend on Java and they should integrate very smooth. > Thrift should not swallow ALL exceptions > > > Key: THRIFT-1805 > URL: https://issues.apache.org/jira/browse/THRIFT-1805 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler, Java - Library >Affects Versions: 0.9 >Reporter: Diwaker Gupta >Assignee: Diwaker Gupta > Attachments: THRIFT-1805.patch > > > In Thrift 0.8.0, Thrift generated Java code did not swallow application > exceptions. As a result of THRIFT-1658, this behavior changed in 0.9.0 and > now the generated code swallows ALL application exceptions (via > ProcessFunction). Apparently this was the behavior in Thrift 0.6.0 and while > I see the rationale, it is breaking our applications. > Our code relies on the fact that exceptions can propagate outside of Thrift > for certain things (e.g., to aggressively drop connections for clients that > send invalid/malformed requests). ProcessFunction makes it near impossible to > do this -- not only does it swallow the exception, it also loses all > information about the original exception and just writes out a generic > TApplicationException. > IMO ProcessFunction should only catch TException. If the application code > wants to use other exceptions for some reason (in particular, Errors and > RuntimeExceptions), Thrift shouldn't prevent that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-3328) A callback is not called when a server is down.
[
https://issues.apache.org/jira/browse/THRIFT-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-3328.
-
Resolution: Fixed
Assignee: HIRANO Satoshi
committed
> A callback is not called when a server is down.
> ---
>
> Key: THRIFT-3328
> URL: https://issues.apache.org/jira/browse/THRIFT-3328
> Project: Thrift
> Issue Type: Bug
> Components: JavaScript - Library
>Reporter: HIRANO Satoshi
>Assignee: HIRANO Satoshi
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When an async method is called in a JS client for a server which is down, the
> call should call a supplied callback.
> Actually the async call fails with the following error and the callback not
> called.
> OPTIONS http:// net::ERR_CONNECTION_REFUSED
> Note that the above OPTIONS is because I use HTTP OPTIONS. Don't mind.
> Thrift.TXHRTransport.flush() has the following fragment.
> if (callback) {
> //Ignore XHR callbacks until the data arrives, then call the
> // client's callback
> xreq.onreadystatechange =
> (function() {
> var clientCallback = callback;
> return function() {
> if (this.readyState == 4 && this.status == 200) {
> self.setRecvBuffer(this.responseText);
> clientCallback();
> }
> };
> }());
> }
> I think the reason why the callback is not called is that "this.status ==
> 200" ignores fatal statuses and skips clientCallback().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-3478) Restore dropped method to THsHaServer.java
[ https://issues.apache.org/jira/browse/THRIFT-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-3478. - Resolution: Fixed Thanks for preparing the patch Keith! > Restore dropped method to THsHaServer.java > -- > > Key: THRIFT-3478 > URL: https://issues.apache.org/jira/browse/THRIFT-3478 > Project: Thrift > Issue Type: Bug >Affects Versions: 0.9.3 >Reporter: Keith Turner >Assignee: Keith Turner > Fix For: 0.9.4 > > > In THRIFT-3202 a method was dropped from THsHaServer.java which broke > compatibility. On mailing list restoring the method as deprecated was > discussed (see this > [thread|http://mail-archives.apache.org/mod_mbox/thrift-dev/201512.mbox/%3ccagutchpl+rutdonzmyxemmzdhhucfk4e+k8qmxjkbzorrmb...@mail.gmail.com%3E]). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (THRIFT-3476) Missing include in ./src/thrift/protocol/TJSONProtocol.cpp
[ https://issues.apache.org/jira/browse/THRIFT-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045781#comment-15045781 ] Roger Meier edited comment on THRIFT-3476 at 12/7/15 9:33 PM: -- Thanks Martin for reporting this. It is always worth to provide a patch and we would be appreciated if you could do so. was (Author: roger.meier): Thanks Martin for reporting this. It is always worth to provide a patch and it would be appreciated if you could do so. > Missing include in ./src/thrift/protocol/TJSONProtocol.cpp > -- > > Key: THRIFT-3476 > URL: https://issues.apache.org/jira/browse/THRIFT-3476 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.9.3 > Environment: Using built-in specs. > COLLECT_GCC=g++ > COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/4.7/lto-wrapper > Target: x86_64-linux-gnu > Configured with: ../src/configure -v --with-pkgversion='Debian 4.7.2-5' > --with-bugurl=file:///usr/share/doc/gcc-4.7/README.Bugs > --enable-languages=c,c++,go,fortran,objc,obj-c++ --prefix=/usr > --program-suffix=-4.7 --enable-shared --enable-linker-build-id > --with-system-zlib --libexecdir=/usr/lib --without-included-gettext > --enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.7 > --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu > --enable-libstdcxx-debug --enable-libstdcxx-time=yes > --enable-gnu-unique-object --enable-plugin --enable-objc-gc > --with-arch-32=i586 --with-tune=generic --enable-checking=release > --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu > Thread model: posix > gcc version 4.7.2 (Debian 4.7.2-5) >Reporter: Martin Werner > > CPP library did not compile due to not finding std::runtime_error as > #include is missing at the beginning of this file... > Too simple for a patch ;-) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3476) Missing include in ./src/thrift/protocol/TJSONProtocol.cpp
[ https://issues.apache.org/jira/browse/THRIFT-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045781#comment-15045781 ] Roger Meier commented on THRIFT-3476: - Thanks Martin for reporting this. It is always worth to provide a patch and it would be appreciated if you could do so. > Missing include in ./src/thrift/protocol/TJSONProtocol.cpp > -- > > Key: THRIFT-3476 > URL: https://issues.apache.org/jira/browse/THRIFT-3476 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.9.3 > Environment: Using built-in specs. > COLLECT_GCC=g++ > COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/4.7/lto-wrapper > Target: x86_64-linux-gnu > Configured with: ../src/configure -v --with-pkgversion='Debian 4.7.2-5' > --with-bugurl=file:///usr/share/doc/gcc-4.7/README.Bugs > --enable-languages=c,c++,go,fortran,objc,obj-c++ --prefix=/usr > --program-suffix=-4.7 --enable-shared --enable-linker-build-id > --with-system-zlib --libexecdir=/usr/lib --without-included-gettext > --enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.7 > --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu > --enable-libstdcxx-debug --enable-libstdcxx-time=yes > --enable-gnu-unique-object --enable-plugin --enable-objc-gc > --with-arch-32=i586 --with-tune=generic --enable-checking=release > --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu > Thread model: posix > gcc version 4.7.2 (Debian 4.7.2-5) >Reporter: Martin Werner > > CPP library did not compile due to not finding std::runtime_error as > #include is missing at the beginning of this file... > Too simple for a patch ;-) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-3475) prefix tags with v as defined by semver
Roger Meier created THRIFT-3475:
---
Summary: prefix tags with v as defined by semver
Key: THRIFT-3475
URL: https://issues.apache.org/jira/browse/THRIFT-3475
Project: Thrift
Issue Type: Bug
Components: Build Process
Reporter: Roger Meier
We need to prefix our tags with **v** to follow the semver model, e.g.
**v0.9.3**
non prefix causes issues such as tag and branch conflicts.
I had to do this when pushing to the release branch on my fork
{noformat}
git push bufferoverflow heads/0.9.3
{noformat}
see also THRIFT-6
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-1385) make install doesn't install java library in the setted folder
[
https://issues.apache.org/jira/browse/THRIFT-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044154#comment-15044154
]
Roger Meier commented on THRIFT-1385:
-
yep, autoconf is sometimes a pain.
I belive CMake(THRIFT-2850) and Docker will simplify this for the future.
CMake is already supporting Java and some tests over there would be nice.
> make install doesn't install java library in the setted folder
> --
>
> Key: THRIFT-1385
> URL: https://issues.apache.org/jira/browse/THRIFT-1385
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Environment: -- Ant version
> $ ant -version
> Apache Ant(TM) version 1.8.2 compiled on December 20 2010
> -- Commands
> svn checkout http://svn.apache.org/repos/asf/thrift/trunk thrift
> cd thrift
> ./bootstrap.sh
> ./configure --prefix=${HOME}/fakeroot --without-cpp --without-boost
> --without-libevent --without-zlib --without-c_glib --without-csharp
> --without-erlang --without-python --without-perl --without-php
> --without-php_extension --without-ruby --without-haskell --without-go
> make && make install
>Reporter: Verdoïa Laurent
>Assignee: Roger Meier
> Attachments: install.patch
>
>
> make install failed on the java library with this error message:
> ./thrift/lib/java/build.xml:135: Failed to copy
> ./thrift/lib/java/build/libthrift-0.8.0-snapshot-javadoc.jar to
> /usr/local/lib/libthrift-0.8.0-snapshot-javadoc.jar due to
> java.io.FileNotFoundException
> /usr/local/lib/libthrift-0.8.0-snapshot-javadoc.jar (Permission non accordée)
> For the safety I verified if the file
> /thrift/lib/java/build/libthrift-0.8.0-snapshot-javadoc.jar exists; and the
> file exists.
> But the source file is not the problem here !
> Why the install basename is /usr/local/lib/ even with
> --prefix=${HOME}/fakeroot
> The fakeroot folder exists too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-3474) Docker: thrift-compiler
[ https://issues.apache.org/jira/browse/THRIFT-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier updated THRIFT-3474: Component/s: (was: D - Compiler) Compiler (General) > Docker: thrift-compiler > --- > > Key: THRIFT-3474 > URL: https://issues.apache.org/jira/browse/THRIFT-3474 > Project: Thrift > Issue Type: Bug > Components: Compiler (General), Deployment >Reporter: Roger Meier >Assignee: Roger Meier > > I made a Dockerfile and .dockerignore for this -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-3474) Docker: thrift-compiler
[ https://issues.apache.org/jira/browse/THRIFT-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-3474. - Resolution: Fixed committed > Docker: thrift-compiler > --- > > Key: THRIFT-3474 > URL: https://issues.apache.org/jira/browse/THRIFT-3474 > Project: Thrift > Issue Type: Bug > Components: D - Compiler, Deployment >Reporter: Roger Meier >Assignee: Roger Meier > > I made a Dockerfile and .dockerignore for this -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3474) Docker: thrift-compiler
[
https://issues.apache.org/jira/browse/THRIFT-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043955#comment-15043955
]
Roger Meier commented on THRIFT-3474:
-
here is the first build from my branch:
https://hub.docker.com/r/thrift/thrift-compiler-test/
{noformat}
docker pull thrift/thrift-compiler-test
docker run thrift/thrift-compiler-test
{noformat}
> Docker: thrift-compiler
> ---
>
> Key: THRIFT-3474
> URL: https://issues.apache.org/jira/browse/THRIFT-3474
> Project: Thrift
> Issue Type: Bug
> Components: D - Compiler, Deployment
>Reporter: Roger Meier
>Assignee: Roger Meier
>
> I made a Dockerfile and .dockerignore for this
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (THRIFT-3474) Docker: thrift-compiler
Roger Meier created THRIFT-3474: --- Summary: Docker: thrift-compiler Key: THRIFT-3474 URL: https://issues.apache.org/jira/browse/THRIFT-3474 Project: Thrift Issue Type: Bug Components: D - Compiler, Deployment Reporter: Roger Meier Assignee: Roger Meier I made a Dockerfile and .dockerignore for this -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-1545) Generated javascript code uses "for in" for looping over arrays
[
https://issues.apache.org/jira/browse/THRIFT-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-1545.
-
Resolution: Fixed
> Generated javascript code uses "for in" for looping over arrays
> ---
>
> Key: THRIFT-1545
> URL: https://issues.apache.org/jira/browse/THRIFT-1545
> Project: Thrift
> Issue Type: Bug
> Components: JavaScript - Compiler
>Affects Versions: 0.8
>Reporter: Larregoity
>Priority: Minor
>
> For lists, generated javascript is like :
> >>
> GetRepairersResponse.prototype.write = function(output){
> output.writeStructBegin('GetRepairersResponse')
> if (null != this.repairers) {
> output.writeFieldBegin('repairers', Thrift.Type.LIST, 1)
> {
> output.writeListBegin(Thrift.Type.STRUCT, this.repairers.length)
> {
> for(var iter62 in this.repairers)
> {
> iter62=this.repairers[iter62]
> iter62.write(output)
> }
> }
> output.writeListEnd()
> }
> output.writeFieldEnd()
> }
> output.writeFieldStop()
> output.writeStructEnd()
> return
> }
> >>
> The use of "for in" generates problems when properties or functions are added
> to the Array object (for instance in the sencha library, that adds the
> "indexOf", "remove" and "contains" methods), because these properties will be
> included in the for loop.
> As said in
> https://developer.mozilla.org/en/JavaScript/Guide/Predefined_Core_Objects,:
> "Since JavaScript elements are saved as standard object properties, it is not
> advisable to iterate through JavaScript arrays using for...in loops because
> normal elements and all enumerable properties will be listed."
> It would be much safer if the generated code used standard for loops to like
> :
> >>
> var colors = ['red', 'green', 'blue'];
> for (var i = 0; i < colors.length; i++) {
> console.log(colors[i]);
> }
> >>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3473) When use "optional' before a list, C++ server cannot return it correctly
[
https://issues.apache.org/jira/browse/THRIFT-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043838#comment-15043838
]
Roger Meier commented on THRIFT-3473:
-
Thanks for reporting this [~huache]
Could you extend an existing test case within the Thrift code base, so we can
easily reproduce it?
> When use "optional' before a list, C++ server cannot return it correctly
> -
>
> Key: THRIFT-3473
> URL: https://issues.apache.org/jira/browse/THRIFT-3473
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Affects Versions: 0.9.3
> Environment: CentOS 7, GCC 4.8.3, Perl 5.16
>Reporter: YU Chang
>
> Any "optional" modifier relates to a list will cause to a null/undef return
> value.
> Here is thrift file:
> {code:title=WordAligner.thrift|borderStyle=solid}
> namespace cpp thrifttest
> namespace perl thrifttest
> struct Pair {
> 1: optional string a,
> 2: optional string b
> }
> struct Result {
> 1: optional list strList,
> 2: optional list pairList
> }
> service Test {
> Result listTest()
> }
> {code}
> Here is C++ code (server):
> {code:title=Test_server.cpp|borderStyle=solid}
> #include "gen-cpp/Test.h"
> #include
> #include
> #include
> #include
> #include
> using namespace std;
> using namespace ::apache::thrift;
> using namespace ::apache::thrift::protocol;
> using namespace ::apache::thrift::transport;
> using namespace ::apache::thrift::server;
> using boost::shared_ptr;
> using namespace ::thrifttest;
> class TestHandler : virtual public TestIf {
> public:
> TestHandler() {
> // Your initialization goes here
> }
> void listTest(Result& _return) {
> _return.strList.push_back("Test");
> _return.strList.push_back("one level list");
> cout << "strList size: " << _return.strList.size() << endl;
> Pair pair;
> pair.a = "Test";
> pair.b = "two level list";
> _return.pairList.push_back(pair);
> cout << "pairList size: " << _return.pairList.size() << endl;
> printf("call listTest\n");
> }
> };
> int main(int argc, char **argv) {
> int port = 9595;
> shared_ptr handler(new TestHandler());
> shared_ptr processor(new TestProcessor(handler));
> shared_ptr serverTransport(new TServerSocket(port));
> shared_ptr transportFactory(new
> TBufferedTransportFactory());
> shared_ptr protocolFactory(new
> TBinaryProtocolFactory());
> TSimpleServer server(processor, serverTransport, transportFactory,
> protocolFactory);
> server.serve();
> return 0;
> }
> {code}
> Here is perl code (client):
> {code:title=Test_client.pl|borderStyle=solid}
> #!/usr/bin/perl
> use v5.12;
> use warnings;
> use autodie;
> use utf8;
> use Data::Dumper;
> use lib 'gen-perl';
> use thrifttest::Test;
> use thrifttest::Constants;
> use thrifttest::Types;
> use Thrift;
> use Thrift::BinaryProtocol;
> use Thrift::Socket;
> use Thrift::BufferedTransport;
> my $socket= new Thrift::Socket('localhost', 9595);
> my $transport = new Thrift::BufferedTransport($socket, 1024, 1024);
> my $protocol = new Thrift::BinaryProtocol($transport);
> my $client= new thrifttest::TestClient($protocol);
> eval {
> $transport->open();
> my $result = $client->listTest;
> say Dumper($result);
> $transport->close();
> };
> say $@ if $@;
> {code}
> {code:title=C++ server output|borderStyle=solid}
> strList size: 2
> pairList size: 1
> call listTest
> {code}
> {code:title=perl client output|borderStyle=solid}
> $VAR1 = bless( {
> 'pairList' => undef,
> 'strList' => undef
>}, 'thrifttest::Result' );
> {code}
> In this test case, every "optional" corresponding to a undef return value.
> Only If I delete all the "optional" in the thrift file, I will get right
> return value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-1385) make install doesn't install java library in the setted folder
[
https://issues.apache.org/jira/browse/THRIFT-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-1385.
-
Resolution: Fixed
Assignee: Roger Meier (was: Jake Farrell)
committed.
Thanks Tom!
It is really helpful for maintainers to have existing patches reviewed and
tested by multiple persons.
> make install doesn't install java library in the setted folder
> --
>
> Key: THRIFT-1385
> URL: https://issues.apache.org/jira/browse/THRIFT-1385
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Environment: -- Ant version
> $ ant -version
> Apache Ant(TM) version 1.8.2 compiled on December 20 2010
> -- Commands
> svn checkout http://svn.apache.org/repos/asf/thrift/trunk thrift
> cd thrift
> ./bootstrap.sh
> ./configure --prefix=${HOME}/fakeroot --without-cpp --without-boost
> --without-libevent --without-zlib --without-c_glib --without-csharp
> --without-erlang --without-python --without-perl --without-php
> --without-php_extension --without-ruby --without-haskell --without-go
> make && make install
>Reporter: Verdoïa Laurent
>Assignee: Roger Meier
> Attachments: install.patch
>
>
> make install failed on the java library with this error message:
> ./thrift/lib/java/build.xml:135: Failed to copy
> ./thrift/lib/java/build/libthrift-0.8.0-snapshot-javadoc.jar to
> /usr/local/lib/libthrift-0.8.0-snapshot-javadoc.jar due to
> java.io.FileNotFoundException
> /usr/local/lib/libthrift-0.8.0-snapshot-javadoc.jar (Permission non accordée)
> For the safety I verified if the file
> /thrift/lib/java/build/libthrift-0.8.0-snapshot-javadoc.jar exists; and the
> file exists.
> But the source file is not the problem here !
> Why the install basename is /usr/local/lib/ even with
> --prefix=${HOME}/fakeroot
> The fakeroot folder exists too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-1805) Thrift should not swallow ALL exceptions
[ https://issues.apache.org/jira/browse/THRIFT-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043579#comment-15043579 ] Roger Meier commented on THRIFT-1805: - You are welcome to help improving Java within Thrift, patches or verification of available patches are very welcome. Also overall code quality fixes for the Java code base. > Thrift should not swallow ALL exceptions > > > Key: THRIFT-1805 > URL: https://issues.apache.org/jira/browse/THRIFT-1805 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler, Java - Library >Affects Versions: 0.9 >Reporter: Diwaker Gupta >Assignee: Diwaker Gupta > Attachments: THRIFT-1805.patch > > > In Thrift 0.8.0, Thrift generated Java code did not swallow application > exceptions. As a result of THRIFT-1658, this behavior changed in 0.9.0 and > now the generated code swallows ALL application exceptions (via > ProcessFunction). Apparently this was the behavior in Thrift 0.6.0 and while > I see the rationale, it is breaking our applications. > Our code relies on the fact that exceptions can propagate outside of Thrift > for certain things (e.g., to aggressively drop connections for clients that > send invalid/malformed requests). ProcessFunction makes it near impossible to > do this -- not only does it swallow the exception, it also loses all > information about the original exception and just writes out a generic > TApplicationException. > IMO ProcessFunction should only catch TException. If the application code > wants to use other exceptions for some reason (in particular, Errors and > RuntimeExceptions), Thrift shouldn't prevent that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-1385) make install doesn't install java library in the setted folder
[
https://issues.apache.org/jira/browse/THRIFT-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043577#comment-15043577
]
Roger Meier commented on THRIFT-1385:
-
[~tlippy01] does the attached patch work as expected?
> make install doesn't install java library in the setted folder
> --
>
> Key: THRIFT-1385
> URL: https://issues.apache.org/jira/browse/THRIFT-1385
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Environment: -- Ant version
> $ ant -version
> Apache Ant(TM) version 1.8.2 compiled on December 20 2010
> -- Commands
> svn checkout http://svn.apache.org/repos/asf/thrift/trunk thrift
> cd thrift
> ./bootstrap.sh
> ./configure --prefix=${HOME}/fakeroot --without-cpp --without-boost
> --without-libevent --without-zlib --without-c_glib --without-csharp
> --without-erlang --without-python --without-perl --without-php
> --without-php_extension --without-ruby --without-haskell --without-go
> make && make install
>Reporter: Verdoïa Laurent
>Assignee: Jake Farrell
> Attachments: install.patch
>
>
> make install failed on the java library with this error message:
> ./thrift/lib/java/build.xml:135: Failed to copy
> ./thrift/lib/java/build/libthrift-0.8.0-snapshot-javadoc.jar to
> /usr/local/lib/libthrift-0.8.0-snapshot-javadoc.jar due to
> java.io.FileNotFoundException
> /usr/local/lib/libthrift-0.8.0-snapshot-javadoc.jar (Permission non accordée)
> For the safety I verified if the file
> /thrift/lib/java/build/libthrift-0.8.0-snapshot-javadoc.jar exists; and the
> file exists.
> But the source file is not the problem here !
> Why the install basename is /usr/local/lib/ even with
> --prefix=${HOME}/fakeroot
> The fakeroot folder exists too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (THRIFT-3469) Docker: Debian support
Roger Meier created THRIFT-3469: --- Summary: Docker: Debian support Key: THRIFT-3469 URL: https://issues.apache.org/jira/browse/THRIFT-3469 Project: Thrift Issue Type: Bug Reporter: Roger Meier Assignee: Roger Meier I like to support Docker using Debian( the upstream project of Ubuntu). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (THRIFT-3127) switch -recurse to --recurse and reserve -r
[
https://issues.apache.org/jira/browse/THRIFT-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier reassigned THRIFT-3127:
---
Assignee: Roger Meier
> switch -recurse to --recurse and reserve -r
> ---
>
> Key: THRIFT-3127
> URL: https://issues.apache.org/jira/browse/THRIFT-3127
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
>Affects Versions: 0.9.2
>Reporter: Xiaoshuang LU
>Assignee: Roger Meier
>
> we may need to switch {code}-recurse{code} to {code}--recurse{code},
> and reserve {code}-r{code} since it is the standard behavior of command line
> parameter processing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-3463) Java can't be disabled in CMake build
[ https://issues.apache.org/jira/browse/THRIFT-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-3463. - Resolution: Fixed Assignee: Pascal Bach Thanks Pascal! > Java can't be disabled in CMake build > - > > Key: THRIFT-3463 > URL: https://issues.apache.org/jira/browse/THRIFT-3463 > Project: Thrift > Issue Type: Bug > Components: Build Process >Affects Versions: 0.9.4 >Reporter: Pascal Bach >Assignee: Pascal Bach > Attachments: 0001-THRIFT-3463-Don-t-fail-if-Java-is-not-found.patch > > > If `-DWITH_JAVA=OFF` is given as argument to CMake it still tries to find > Java and fails if not found. > This patch fixes this and doesn't fail if Java is not found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3452) .travis.yml: Migrating from legacy to container-based infrastructure
[ https://issues.apache.org/jira/browse/THRIFT-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033610#comment-15033610 ] Roger Meier commented on THRIFT-3452: - great! Could you make us members of apache/thrift ? > .travis.yml: Migrating from legacy to container-based infrastructure > > > Key: THRIFT-3452 > URL: https://issues.apache.org/jira/browse/THRIFT-3452 > Project: Thrift > Issue Type: Bug >Reporter: Roger Meier >Assignee: Roger Meier > > I've started to work on this: > https://docs.travis-ci.com/user/migrating-from-legacy/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-6) Thrift libraries and compiler lack version number
[ https://issues.apache.org/jira/browse/THRIFT-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-6. -- Resolution: Fixed I would say this is done. > Thrift libraries and compiler lack version number > - > > Key: THRIFT-6 > URL: https://issues.apache.org/jira/browse/THRIFT-6 > Project: Thrift > Issue Type: Bug > Components: Build Process >Affects Versions: 1.0 >Reporter: Bryan Duxbury >Assignee: Roger Meier > Fix For: 1.0 > > Attachments: > 0001-THRIFT-6-Thrift-libraries-and-compiler-lack-version-.patch, > ASF.LICENSE.NOT.GRANTED--v1-0001-THRIFT-6.-Add-a-Makefile-rule-to-print-the-version-f.patch, > THRIFT-6_align_version_and_description_to_0.6.0-dev.patch, updateversion.sh > > > Right now it's impossible to tell which version of Thrift you have installed. > If you're depending on features that have recently been added (and that > subtly don't exist), you can spend a lot of time chasing your tail trying to > figure out what the problem is. > This may be something that has to be implemented piecemeal on each client > library (ruby gem, java classes, etc). Thoughts? > While we're at it, let's add a --version switch or something to the compiler > so you know what version of stuff you're actually generating. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-1482) Unix domain socket support under PHP
[ https://issues.apache.org/jira/browse/THRIFT-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-1482. - Resolution: Later please reopen and provide a patch , see CONTRIBUTING.md > Unix domain socket support under PHP > > > Key: THRIFT-1482 > URL: https://issues.apache.org/jira/browse/THRIFT-1482 > Project: Thrift > Issue Type: New Feature > Components: PHP - Library >Affects Versions: 0.8 >Reporter: Asad Saeed >Assignee: Roger Meier > > I would like to use Unix domain sockets under PHP for TSocket and > TServerSocket. Currently only tcp can be used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-3213) make cross should indicate when it skips a known failing test
[
https://issues.apache.org/jira/browse/THRIFT-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-3213.
-
Resolution: Fixed
we introduced *make fail*
> make cross should indicate when it skips a known failing test
> -
>
> Key: THRIFT-3213
> URL: https://issues.apache.org/jira/browse/THRIFT-3213
> Project: Thrift
> Issue Type: Improvement
> Components: Test Suite
>Affects Versions: 0.9.2
> Environment: Ubuntu 12.04 LTS with cpp, java, python, perl, php, and
> go enabled.
>Reporter: James E. King, III
>Assignee: Roger Meier
>Priority: Minor
>
> I do not know if this affects earlier releases. I am trying to get {{cpp}}
> and {{go}} to run in a {{make cross}}. Currently I can make cpp on both
> sides, and go on both sides, but when I try to mix them up then no tests run:
> {noformat}
> jking@dvm-4:~/thrift$ /usr/bin/python test/test.py -s --server cpp --client
> cpp
> Apache Thrift - Integration Test Suite
> Tue Jun 30 16:26:24 2015
> ==
> server-client: protocol:transport: result:
> cpp-cppcompact buffered-domain success(0)
> cpp-cppcompact framed-ipsuccess(0)
> cpp-cppcompact buffered-ip success(0)
> cpp-cppcompact http-ip-ssl success(0)
> cpp-cppcompact framed-ip-sslsuccess(0)
> cpp-cppcompact buffered-ip-ssl success(0)
> cpp-cppbinary buffered-ip-ssl success(0)
> cpp-cppcompact framed-domainsuccess(0)
> cpp-cppbinary http-ip-ssl success(0)
> cpp-cppbinary buffered-ip success(0)
> cpp-cppbinary framed-ip-sslsuccess(0)
> cpp-cppbinary buffered-domain success(0)
> cpp-cppbinary framed-domainsuccess(0)
> cpp-cppbinary framed-ipsuccess(0)
> cpp-cppjson http-ip-ssl success(0)
> cpp-cppjson buffered-ip success(0)
> cpp-cppjson buffered-ip-ssl success(0)
> cpp-cppjson buffered-domain success(0)
> cpp-cppjson framed-ip-sslsuccess(0)
> cpp-cppjson framed-ipsuccess(0)
> cpp-cppjson framed-domainsuccess(0)
> ==
> No unexpected failures.
> You can browse results at:
> file:///home/jking/thrift/test/result.html
> # If you use Chrome, run:
> # cd /home/jking/thrift/test
> # python -m SimpleHTTPServer 8001
> # then browse:
> # http://localhost:8001/result.html
> Full log for each test is here:
> test/log/client_server_protocol_transport_client.log
> test/log/client_server_protocol_transport_server.log
> 0 failed of 21 tests in total.
> Test execution took 12.6 seconds.
> Tue Jun 30 16:26:37 2015
> jking@dvm-4:~/thrift$ ps ax | grep est
> 20778 pts/4S+ 0:00 grep --color=auto est
> jking@dvm-4:~/thrift$ /usr/bin/python test/test.py -s --server cpp --client go
> Apache Thrift - Integration Test Suite
> Tue Jun 30 16:26:45 2015
> ==
> server-client: protocol:transport: result:
> ==
> No unexpected failures.
> You can browse results at:
> file:///home/jking/thrift/test/result.html
> # If you use Chrome, run:
> # cd /home/jking/thrift/test
> # python -m SimpleHTTPServer 8001
> # then browse:
> # http://localhost:8001/result.html
> Full log for each test is here:
> test/log/client_server_protocol_transport_client.log
> test/log/client_server_protocol_transport_server.log
> 0 failed of 0 tests in total.
> Test execution took 0.1 seconds.
> Tue Jun 30 16:26:45 2015
> jking@dvm-4:~/thrift$ /usr/bin/python test/test.py -s --server go --client go
> Apache Thrift - Integration Test Suite
> Tue Jun 30 16:26:49 2015
> ==
> server-client: protocol:transport: result:
> go-go compact framed-ipsuccess(0)
> go-go binary buffered-ip success(0)
> go-go compact buffered-ip success(0)
> go-go compact framed-ip-sslsuccess(0)
> go-go compact buffer
[jira] [Reopened] (THRIFT-3068) C++ cppcheck warnings
[
https://issues.apache.org/jira/browse/THRIFT-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier reopened THRIFT-3068:
-
Assignee: James E. King, III
> C++ cppcheck warnings
> -
>
> Key: THRIFT-3068
> URL: https://issues.apache.org/jira/browse/THRIFT-3068
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library, Lua - Library, Ruby - Library
>Affects Versions: 0.9.2
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Minor
>
> These warnings were identified by cppcheck-1.69 on the thrift-0.9.3 codebase
> as of July 30 2015. Many of them are inconsequential, and some may be
> intentional for performance, and some of the warnings could be false
> positives...
> {noformat}
> $ cppcheck --enable=all --quiet --std=c++03 --force thrift/
> [thrift/compiler/cpp/src/audit/t_audit.cpp:59]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:78]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:102]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:107]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:269]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:278]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:285]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:286]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:293]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:299]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:309]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:315]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:357]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:364]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:388]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:394]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:442]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:448]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/generate/t_generator.h:39]: (style) Class
> 't_generator' has a constructor with 1 argument that is not explicit.
> [thrift/compiler/cpp/src/generate/t_oop_generator.h:39]: (style) Class
> 't_oop_generator' has a constructor with 1 argument that is not explicit.
> [thrift/compiler/cpp/src/generate/t_c_glib_generator.cc:984] ->
> [thrift/compiler/cpp/src/generate/t_c_glib_generator.cc:993]: (performance)
> Variable 'list_initializer' is reassigned a value before the old one has been
> used.
> [thrift/compiler/cpp/src/generate/t_c_glib_generator.cc:134]: (style) Unused
> private function: 't_c_glib_generator::declare_field'
> [thrift/compiler/cpp/src/generate/t_c_glib_generator.cc:1529]: (performance)
> Prefer prefix ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/generate/t_c_glib_generator.cc:1545]: (performance)
> Prefer prefix ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/generate/t_cpp_generator.cc:638]: (style) The scope
> of the variable 'is_nonrequired_field' can be reduced.
> [thrift/compiler/cpp/src/generate/t_cpp_generator.cc:1165]: (style) Variable
> 'type' is assigned a value that is never used.
> [thrift/compiler/cpp/src/generate/t_csharp_generator.cc:50]: (warning) Member
> variable 't_csharp_generator::member_mapping_scope' is not initialized in the
> constructor.
> [thrift/compiler/cpp/src/generate/t_delphi_generator.cc:3136]: (style) The
> scope of the variable 'tt' can be reduced.
> [thrift/compiler/cpp/src/generate/t_delphi_generator.cc:3158]: (style) The
> scope of the variable 'tt' can be reduced.
> [thrift/compiler/cpp/src/generate/t_erl_generator.cc:49]: (warning) Member
> variable 't_erl_generator::export_lines_first_' is not initialized in the
> constructor.
> [thrift/compi
[jira] [Resolved] (THRIFT-3068) C++ cppcheck warnings
[
https://issues.apache.org/jira/browse/THRIFT-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-3068.
-
Resolution: Fixed
we added *make fail*
> C++ cppcheck warnings
> -
>
> Key: THRIFT-3068
> URL: https://issues.apache.org/jira/browse/THRIFT-3068
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library, Lua - Library, Ruby - Library
>Affects Versions: 0.9.2
>Reporter: James E. King, III
>Priority: Minor
>
> These warnings were identified by cppcheck-1.69 on the thrift-0.9.3 codebase
> as of July 30 2015. Many of them are inconsequential, and some may be
> intentional for performance, and some of the warnings could be false
> positives...
> {noformat}
> $ cppcheck --enable=all --quiet --std=c++03 --force thrift/
> [thrift/compiler/cpp/src/audit/t_audit.cpp:59]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:78]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:102]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:107]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:269]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:278]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:285]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:286]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:293]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:299]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:309]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:315]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:357]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:364]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:388]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:394]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:442]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/audit/t_audit.cpp:448]: (performance) Prefer prefix
> ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/generate/t_generator.h:39]: (style) Class
> 't_generator' has a constructor with 1 argument that is not explicit.
> [thrift/compiler/cpp/src/generate/t_oop_generator.h:39]: (style) Class
> 't_oop_generator' has a constructor with 1 argument that is not explicit.
> [thrift/compiler/cpp/src/generate/t_c_glib_generator.cc:984] ->
> [thrift/compiler/cpp/src/generate/t_c_glib_generator.cc:993]: (performance)
> Variable 'list_initializer' is reassigned a value before the old one has been
> used.
> [thrift/compiler/cpp/src/generate/t_c_glib_generator.cc:134]: (style) Unused
> private function: 't_c_glib_generator::declare_field'
> [thrift/compiler/cpp/src/generate/t_c_glib_generator.cc:1529]: (performance)
> Prefer prefix ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/generate/t_c_glib_generator.cc:1545]: (performance)
> Prefer prefix ++/-- operators for non-primitive types.
> [thrift/compiler/cpp/src/generate/t_cpp_generator.cc:638]: (style) The scope
> of the variable 'is_nonrequired_field' can be reduced.
> [thrift/compiler/cpp/src/generate/t_cpp_generator.cc:1165]: (style) Variable
> 'type' is assigned a value that is never used.
> [thrift/compiler/cpp/src/generate/t_csharp_generator.cc:50]: (warning) Member
> variable 't_csharp_generator::member_mapping_scope' is not initialized in the
> constructor.
> [thrift/compiler/cpp/src/generate/t_delphi_generator.cc:3136]: (style) The
> scope of the variable 'tt' can be reduced.
> [thrift/compiler/cpp/src/generate/t_delphi_generator.cc:3158]: (style) The
> scope of the variable 'tt' can be reduced.
> [thrift/compiler/cpp/src/generate/t_erl_generator.cc:49]: (warning) Member
> variable 't_erl_generator::export_lines_first_' is not initialized in the
> constructor.
> [thrift/compiler/cpp/src/generate/t_erl_genera
[jira] [Resolved] (THRIFT-2431) TFileTransportTest fails with "check delta < XXX failed"
[
https://issues.apache.org/jira/browse/THRIFT-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-2431.
-
Resolution: Cannot Reproduce
I would say this is fixed on master
> TFileTransportTest fails with "check delta < XXX failed"
>
>
> Key: THRIFT-2431
> URL: https://issues.apache.org/jira/browse/THRIFT-2431
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Affects Versions: 0.9.1
> Environment: Linux 3.4.43
> Building the SRPM from Fedora Core 21
>Reporter: Benoit Sigoure
>Priority: Minor
>
> This test is flaky, I can easily make it fail:
> {code}
> $ ./TFileTransportTest
> Running 5 test cases...
> TFileTransportTest.cpp(289): error in "test_flush_max_us1": check delta <
> max_allowed_delta failed [17031 >= 15000]
> *** 1 failure detected in test suite "TFileTransportTest"
> $ ./TFileTransportTest
> Running 5 test cases...
> *** No errors detected
> $ ./TFileTransportTest
> Running 5 test cases...
> *** No errors detected
> $ ./TFileTransportTest
> Running 5 test cases...
> TFileTransportTest.cpp(339): fatal error in "test_noop_flush": critical check
> delta < 200 failed [3000242 >= 200]
> *** 1 failure detected in test suite "TFileTransportTest"
> $ ./TFileTransportTest
> Running 5 test cases...
> TFileTransportTest.cpp(339): fatal error in "test_noop_flush": critical check
> delta < 200 failed [3000137 >= 200]
> *** 1 failure detected in test suite "TFileTransportTest"
> {code}
> Seems like this has hit a
> [couple|http://mail-archives.apache.org/mod_mbox/thrift-dev/201107.mbox/%3C412700474.6601310132626839.JavaMail.hudson@aegis%3E]
>
> [times|http://mail-archives.apache.org/mod_mbox/thrift-dev/201110.mbox/%3C566967061.2611319633097563.JavaMail.hudson@aegis%3E]
> in Jenkins already.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-2510) Implement TNonblockingServer's ability to listen on unix domain sockets
[ https://issues.apache.org/jira/browse/THRIFT-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-2510. - Resolution: Unresolved We like to have this feature. However, this is very old, please reopen if you have a patch > Implement TNonblockingServer's ability to listen on unix domain sockets > --- > > Key: THRIFT-2510 > URL: https://issues.apache.org/jira/browse/THRIFT-2510 > Project: Thrift > Issue Type: New Feature > Components: C++ - Library >Affects Versions: 0.9.1 >Reporter: Serge >Priority: Trivial > > See https://github.com/apache/thrift/pull/80 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-3063) C++ build -Wunused-parameter warnings on processor_test, TransportTest
[
https://issues.apache.org/jira/browse/THRIFT-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-3063.
-
Resolution: Cannot Reproduce
> C++ build -Wunused-parameter warnings on processor_test, TransportTest
> --
>
> Key: THRIFT-3063
> URL: https://issues.apache.org/jira/browse/THRIFT-3063
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Affects Versions: 0.9.2
> Environment: linux, Ubuntu 14.04 LTS
>Reporter: James E. King, III
>Priority: Trivial
>
> During a build the following compiler warnings appear:
> {noformat}libtool: link: g++ -Wall -Wextra -pedantic -g -O2 -std=c++11 -o
> .libs/Benchmark Benchmark.o -L/usr/lib/x86_64-linux-gnu
> ./.libs/libtestgencpp.a
> /home/svtbuild/stash/pkgs/thrift2/lib/cpp/.libs/libthrift.so -lssl -lcrypto
> -lrt -lpthread
> In file included from processor/ServerThread.cpp:22:0:
> processor/ServerThread.h:64:16: warning: unused parameter ‘port’
> [-Wunused-parameter]
>virtual void bindSuccessful(uint16_t port) {
> ^
> In file included from processor/ProcessorTest.cpp:39:0:
> processor/ServerThread.h:64:16: warning: unused parameter ‘port’
> [-Wunused-parameter]
>virtual void bindSuccessful(uint16_t port) {
> ^
> In file included from processor/ProcessorTest.cpp:40:0:
> processor/Handlers.h:228:16: warning: unused parameter ‘serverContext’
> [-Wunused-parameter]
>virtual void processContext(
> ^
> processor/Handlers.h:228:16: warning: unused parameter ‘transport’
> [-Wunused-parameter]
> processor/Handlers.h:287:8: warning: unused parameter ‘bytes’
> [-Wunused-parameter]
>void postRead(void* ctx, const char* fnName, uint32_t bytes) {
> ^
> processor/Handlers.h:301:8: warning: unused parameter ‘bytes’
> [-Wunused-parameter]
>void postWrite(void* ctx, const char* fnName, uint32_t bytes) {
> ^
> processor/ProcessorTest.cpp:936:24: warning: unused parameter ‘argc’
> [-Wunused-parameter]
> unit_test::test_suite* init_unit_test_suite(int argc, char* argv[]) {
> ^
> processor/ProcessorTest.cpp:936:24: warning: unused parameter ‘argv’
> [-Wunused-parameter]
> /bin/bash ../../../libtool --tag=CXX --mode=link g++ -Wall -Wextra
> -pedantic -g -O2 -std=c++11 -L/usr/lib/x86_64-linux-gnu -o processor_test
> processor/ProcessorTest.o processor/EventLog.o processor/ServerThread.o
> libprocessortest.la ../../../lib/cpp/libthrift.la
> ../../../lib/cpp/libthriftnb.la -L/usr/lib/x86_64-linux-gnu -levent
> -l:libboost_unit_test_framework.a -lssl -lcrypto -lrt -lpthread
> libtool: link: g++ -Wall -Wextra -pedantic -g -O2 -std=c++11 -o
> .libs/processor_test processor/ProcessorTest.o processor/EventLog.o
> processor/ServerThread.o -L/usr/lib/x86_64-linux-gnu
> ./.libs/libprocessortest.a ../../../lib/cpp/.libs/libthrift.so
> ../../../lib/cpp/.libs/libthriftnb.so -levent
> -l:libboost_unit_test_framework.a -lssl -lcrypto -lrt -lpthread{noformat}
> {noformat}
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src/thrift
> -I/usr/include -I../../../lib/cpp/src -Wall -Wextra -pedantic -g -O2
> -std=c++11 -MT TransportTest.o -MD -MP -MF $depbase.Tpo -c -o TransportTest.o
> TransportTest.cpp &&\
> mv -f $depbase.Tpo $depbase.Po
> TransportTest.cpp:1048:31: warning: unused parameter ‘argc’
> [-Wunused-parameter]
> boost::unit_test::test_suite* init_unit_test_suite(int argc, char* argv[]) {
>^
> TransportTest.cpp:1048:31: warning: unused parameter ‘argv’
> [-Wunused-parameter]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-749) C++ TBufferedTransports do not flush their buffers on delete
[ https://issues.apache.org/jira/browse/THRIFT-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-749. Resolution: Cannot Reproduce this is very old, please reopen or create a new issue > C++ TBufferedTransports do not flush their buffers on delete > > > Key: THRIFT-749 > URL: https://issues.apache.org/jira/browse/THRIFT-749 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.2, 0.3 > Environment: Cygwin 1.7.1 on Windows XP SP3, Thrift 0.2.0 & r760184 & > Trunk >Reporter: Tim Wilson-Brown >Priority: Trivial > Fix For: 1.0 > > Original Estimate: 24h > Remaining Estimate: 24h > > Edit: replaced 'close underlying transport' with 'flush buffers' > The C++ TBufferedTransports (such as TBufferedTransport) do not flush their > buffers on delete. > The workaround is to manually flush the TBufferedTransport before deleting > it. If the TBufferedTransport owned the last instance of the underlying > transport, it will be deleted and close itself. > This may be worth fixing - at the moment, substituting a buffered TSocket for > an unbuffered one changes the behaviour on delete. > Data may be buffered then lost when the TBufferedTransport is deleted. > This is undesirable - they should behave identically except for the > buffering. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-1828) moc_TQTcpServer.cpp was removed from source tree but is in thrift-0.9.0.tar.gz
[ https://issues.apache.org/jira/browse/THRIFT-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-1828. - Resolution: Cannot Reproduce this is solved in master branch > moc_TQTcpServer.cpp was removed from source tree but is in thrift-0.9.0.tar.gz > -- > > Key: THRIFT-1828 > URL: https://issues.apache.org/jira/browse/THRIFT-1828 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.9 > Environment: CentOS 6.3 w/Qt 4.6.2 >Reporter: David Rennalls >Assignee: Jake Farrell >Priority: Minor > > When attempting to build the the 0.9.0 cpp library I get the following error > ... > src/thrift/qt/moc_TQTcpServer.cpp:14:2: error: #error "This file was > generated using the moc from 4.8.1. It" > src/thrift/qt/moc_TQTcpServer.cpp:15:2: error: #error "cannot be used with > the include files from this version of Qt." > src/thrift/qt/moc_TQTcpServer.cpp:16:2: error: #error "(The moc has changed > too much.)" > ... > As far as I can tell when the C++ QT Bindings were added (see > https://issues.apache.org/jira/browse/THRIFT-1348) that file was removed > since it was an auto-generated file and shouldn't be in source control. > However although it's no longer in the source tree it's being included in the > release .tar.gz > [/tmp]$ wget -q > https://dist.apache.org/repos/dist/release/thrift/0.9.0/thrift-0.9.0.tar.gz > -O - | tar tzvf - | grep moc_ > -rw-r--r-- root/root 3311 2012-10-11 21:00 > thrift-0.9.0/lib/cpp/src/thrift/qt/moc_TQTcpServer.cpp > So if the version of Qt that's installed when building is different than the > one used to generate the file in the release .tar.gz the build will break. > Another user seems to have run into this as well, see > http://mail-archives.apache.org/mod_mbox/thrift-user/201212.mbox/%3C002f01cdd2aa$c7f3a840$57daf8c0$@asiainfo-linkage.com%3E > As a workaround I have to either remove the file before building or specify > --with-qt4=no -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-1680) make install requires GNU make
[ https://issues.apache.org/jira/browse/THRIFT-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-1680. - Resolution: Fixed this is very old, please reopen or create a new issue or use the CMake build > make install requires GNU make > -- > > Key: THRIFT-1680 > URL: https://issues.apache.org/jira/browse/THRIFT-1680 > Project: Thrift > Issue Type: Bug > Components: C++ - Compiler >Affects Versions: 0.8 > Environment: NetBSD >Reporter: James K. Lowden >Assignee: Jake Farrell >Priority: Minor > Labels: bsdmake, gmake, make > Attachments: Thrift-1680.patch > > Original Estimate: 3h > Remaining Estimate: 3h > > test/cpp/Makefile.am includes targets whose dependency rule relies on the > variable "$<" to pick up the first dependency. This variable is specific to > GNU make; it is not supported by most BSD make programs. AFAICT this is the > only such dependency on GNU make. I was able to build thrift using BSD make; > I was prevented only from installing it (because install invokes tests). > BSD make has no analog for $<. The simplest fix I know of is to repeat the > name of the first dependency the command. The second easiest fix would be to > document the limitation. ;-) > Three other suggestions, if I may: > 1. It would be nice if the DIR for --with-boost=DIR were more clearly > specified. It's not obvious that --with-boost=/usr/pkg is what's needed if > the Boost headers are in /usr/pkg/include/boost. > 2. The defaults indicated by configure --help are IMO misleading because > they're the defaults *if* configure detects them. I would prefer all default > to No, and for configure to stop with an error if --with-foo is specified and > fails. It is otherwise exceedingly difficult to detect automatically whether > the specified configuration was in fact installed. > 3. The thrift error message is ridiculous: > $ thrift --foo 2>&1 | wc -l > 78 > The first line "No output language(s) specified" (less the "!!!", please) > suffices to indicate the syntax error. The user can more easily consult the > manual to learn how to use the program than read 78 lines of output on his > terminal. The "help" obscures the error. > Thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-1472) Configuration conflicts with boost platform include header
[ https://issues.apache.org/jira/browse/THRIFT-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-1472. - Resolution: Cannot Reproduce this is very old, please reopen or create a new issue > Configuration conflicts with boost platform include header > -- > > Key: THRIFT-1472 > URL: https://issues.apache.org/jira/browse/THRIFT-1472 > Project: Thrift > Issue Type: Bug > Components: C++ - Compiler >Affects Versions: 0.8 >Reporter: Forest Rouse > Attachments: configure.ac > > > The current configuration script (configure.in) uses AC_FUNC_MALLOC and > AC_FUNC_REALLOC. However, as described in > http://nerdland.net/unstumping-the-internet/malloc-has-not-been-declared/ > when boost headers include , the statements > using ::malloc; > and > using ::realloc; > fail. > Also, my centos 6.1 release does not have an autoconf of the version required > for running your autoconf so I had to manually fix the configuration file to > fix the problem. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-1487) Namespace problem, compile fails on generated code
[ https://issues.apache.org/jira/browse/THRIFT-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-1487. - Resolution: Cannot Reproduce this is very old, please reopen or create a new issue > Namespace problem, compile fails on generated code > -- > > Key: THRIFT-1487 > URL: https://issues.apache.org/jira/browse/THRIFT-1487 > Project: Thrift > Issue Type: Bug > Components: C++ - Compiler >Affects Versions: 0.8 > Environment: thrift 0.8.0 >Reporter: Gasol Wu > > you can find build log at > http://pointyhat.freebsd.org/errorlogs/amd64-errorlogs/a.7.20120107170754/php5-pdo_cassandra-0.2.1.log > > , and Thrift IDL file at > https://github.com/mkoppanen/php-pdo_cassandra/blob/master/interface/cassandra.thrift > this problem occurred after THRIFT-1275 commited, > I'm not c++ guy, There are two solution i found to resolve this problem, > > 1. prefix all namespace with "::" > 2. avoid namespace conflict, change cpp namespace from "org.apache.cassandra" > to "cassandra" in cassandra.thrift -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2154) Missing
[
https://issues.apache.org/jira/browse/THRIFT-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-2154.
-
Resolution: Cannot Reproduce
> Missing --
>
> Key: THRIFT-2154
> URL: https://issues.apache.org/jira/browse/THRIFT-2154
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Compiler
>Affects Versions: 0.9
> Environment: Fedora 19
> g++ (GCC) 4.8.1 20130603 (Red Hat 4.8.1-1)
>Reporter: Blackbox Dev Team
>
> When I compile:
> {code:title=d.thrift}
> struct Ala {
> 1: optional i32 a
> }
> struct Basia {
> 1: optional map b
> }
> {code}
> {code:title=main.cpp}
> #include
> #include "gen-cpp/d_types.h"
> int main() {
> Basia b;
> return 0;
> }
> {code}
> {code:title=makefile}
> GEN_SRC := main.cpp\
> gen-cpp/d_constants.cpp \
> gen-cpp/d_types.cpp \
> GEN_OBJ := $(patsubst %.cpp,%.o, $(GEN_SRC))
> THRIFT_DIR := /usr/local/include/thrift
> BOOST_DIR := /usr/local/include
> INC := -I$(THRIFT_DIR) -I$(BOOST_DIR)
> .PHONY: all clean
> all: main
> %.o: %.cpp
> $(CXX) --std=c++11 -Wall -DHAVE_INTTYPES_H -DHAVE_NETINET_IN_H $(INC)
> -c $< -o $@
> main: main.o $(GEN_OBJ)
> $(CXX) $^ -o $@ -L/usr/local/lib -lthrift
> clean:
> $(RM) *.o gen-cpp/*.o main
> {code}
> I get an error:
> {code}
> g++ main.o gen-cpp/d_constants.o gen-cpp/d_types.o -o main -L/usr/local/lib
> -lthrift
> gen-cpp/d_types.o: In function `std::less::operator()(Ala const&, Ala
> const&) const':
> d_types.cpp:(.text._ZNKSt4lessI3AlaEclERKS0_S3_[_ZNKSt4lessI3AlaEclERKS0_S3_]+0x14):
> undefined reference to `Ala::operator<(Ala const&) const'
> collect2: error: ld returned 1 exit status
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-732) server exits abnormally when client calls send_xxx function without calling recv_xxx function
[
https://issues.apache.org/jira/browse/THRIFT-732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-732.
Resolution: Cannot Reproduce
this is very old, please reopen or create a new issue
> server exits abnormally when client calls send_xxx function without calling
> recv_xxx function
> -
>
> Key: THRIFT-732
> URL: https://issues.apache.org/jira/browse/THRIFT-732
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Compiler
>Affects Versions: 0.2
> Environment: MacOS SnowLeopard
>Reporter: Eric Lam
> Attachments: aggregator_server.cpp, leaf.cpp
>
>
> TNonblockingServer exits abnormally when client calls send_xxx function
> without recv_xxx function.
> The following code can reproduce the issue,
> #include
> #include
> #include
> #include "aggregator.h"
> #include
> #include
> #include
> using namespace apache::thrift;
> using namespace apache::thrift::protocol;
> using namespace apache::thrift::transport;
> //using namespace apache::thrift::concurrency;
> using boost::shared_ptr;
> int main(int argc, const char *argv[]) {
> shared_ptr socket(new TSocket("localhost", 9090));
> shared_ptr framedtransport(new
> TFramedTransport(socket));
> shared_ptr protocol(new TBinaryProtocol(framedtransport));
> aggregatorClient client(protocol);
>
> try {
> framedtransport->open();
> } catch (TTransportException e) {
> std::cout << "transport exception" << std::endl;
> return 1;
> } catch (TException e2) {
> std::cout << "exception" << std::endl;
> }
>
> UserProfile profile;
> client.send_retrieve(1);
>
> framedtransport->close();
> return 0;
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-3206) Fix Visual Studio build failure due 'pthread_self': identifier not found
[
https://issues.apache.org/jira/browse/THRIFT-3206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-3206.
-
Resolution: Fixed
Assignee: Roger Meier
committed
> Fix Visual Studio build failure due 'pthread_self': identifier not found
>
>
> Key: THRIFT-3206
> URL: https://issues.apache.org/jira/browse/THRIFT-3206
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Affects Versions: 0.9.2
> Environment: Visual Studio 2013 Update 5 RC
>Reporter: Paweł Janicki
>Assignee: Roger Meier
> Labels: easyfix
> Attachments: THRIFT-3206.patch
>
>
> Build fail of project lib\cpp\libthrift.vcxproj due to compile error
> {noformat}
> 1>c:\...\thrift\lib\cpp\src\thrift\transport\tsslsocket.cpp(69): error C3861:
> 'pthread_self': identifier not found
> {noformat}
> The current Thrift code calls
> [pthread_self()|http://man7.org/linux/man-pages/man3/pthread_self.3.html]
> which is not available on Windows platform in current Thrift library
> dependency set.
> Herein I propose resolution by using native WINAPI equivalent
> GetCurrentThreadId() in case source is compiled when _WIN32 macro is defined.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-847) Test Framework harmonization across all languages
[ https://issues.apache.org/jira/browse/THRIFT-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-847. Resolution: Fixed I would say this is implemented and heavily improved and reworked by [~nsuke] see http://thrift.apache.org/test/ > Test Framework harmonization across all languages > - > > Key: THRIFT-847 > URL: https://issues.apache.org/jira/browse/THRIFT-847 > Project: Thrift > Issue Type: Improvement > Components: C# - Library, C++ - Library, Cocoa - Library, Erlang - > Library, Haskell - Library, Java - Library, JavaScript - Library, OCaml - > Library, Perl - Library, PHP - Library, Python - Library, Ruby - Library, > Test Suite >Affects Versions: 0.1, 0.2, 0.3 >Reporter: Roger Meier >Assignee: Roger Meier > Labels: gsoc2014, mentor > Attachments: > 0001-THRIFT-847-Test-Framework-harmonization-across-all-l.patch, > 0001-THRIFT-847-Test-Framework-harmonization-across-all-l.patch, > 0001-THRIFT-847-Test-Framework-harmonization-across-all-l.patch, > 0001-THRIFT-847-Test-Framework-harmonization-across-all-l.patch, > 0001-THRIFT-847-Test-Framework-harmonization-across-all-l.patch, > 0001-THRIFT-847-Test-Framework-harmonization-across-all-l.patch, > THRIFT-847_add__make_cross__build_target.patch, build.xml, test.sh, > v1-WORK_IN_PROGRESS-unified_tests.tar.gz > > > Today each Language supported by Thrift, have its own unit test, all are > using the same Thrift IDL's located at the test directory. But the behavior > of these tests seems to be different from language to language... this makes > it difficult to do tests and bug fixing across different Languages. e.g. > * C++ Test and JavaScript Test Server written in Java have different > responses for the same services > * C# and Java Test Server have different responses for testException as C++ > I propose the following steps: > * identify the language with the reference implementation (well defined > return values for all test cases) > * update the ThriftTest.thrift with details about the required return values > that have to be implemented > * update test implementations and move language tests into their appropriate > library directory (THRIFT-35) > * a public test server that supports multiple protocols and transports could > be another enhancement for testing purposes > I'm ready to help preparing patches, just tell me what you need! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2845) ChildService.Plo: No such file or directory
[ https://issues.apache.org/jira/browse/THRIFT-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-2845. - Resolution: Fixed > ChildService.Plo: No such file or directory > --- > > Key: THRIFT-2845 > URL: https://issues.apache.org/jira/browse/THRIFT-2845 > Project: Thrift > Issue Type: Bug > Components: Build Process >Affects Versions: 0.9.2 >Reporter: Robert J. Gebis >Priority: Critical > Labels: build > > I am using on Mac 10.10.1 with latest Apple Command line tools (clang) > ./configure --prefix=/Users/oxoocoffee/Downloads/thrift-0.9.2/output > --with-openssl --with-libevent CXXFLAGS="-Wno-deprecated-register" > -Wno-deprecated-register - To suppress > warning: 'register' storage class specifier is deprecated > [-Wdeprecated-register] > C++ Library: >Build TZlibTransport .. : yes >Build TNonblockingServer .. : yes >Build TQTcpServer (Qt) : no > make > Making all in test > Makefile:990: gen-cpp/.deps/ChildService.Plo: No such file or directory > Makefile:991: gen-cpp/.deps/DebugProtoTest_types.Plo: No such file or > directory > Makefile:992: gen-cpp/.deps/EnumTest_types.Plo: No such file or directory > Makefile:993: gen-cpp/.deps/OptionalRequiredTest_types.Plo: No such file or > directory > Makefile:994: gen-cpp/.deps/ParentService.Plo: No such file or directory > Makefile:995: gen-cpp/.deps/Recursive_types.Plo: No such file or directory > Makefile:996: gen-cpp/.deps/ThriftTest_constants.Plo: No such file or > directory > Makefile:997: gen-cpp/.deps/ThriftTest_types.Plo: No such file or directory > Makefile:998: gen-cpp/.deps/TypedefTest_types.Plo: No such file or directory > Makefile:999: gen-cpp/.deps/proc_types.Plo: No such file or directory > make[4]: *** No rule to make target `gen-cpp/.deps/proc_types.Plo'. Stop. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3452) .travis.yml: Migrating from legacy to container-based infrastructure
[ https://issues.apache.org/jira/browse/THRIFT-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030933#comment-15030933 ] Roger Meier commented on THRIFT-3452: - yes thrift/compiler is not optimal, so we should go for thrift/thrift-compiler the distro packagers name it also thrift-compiler > .travis.yml: Migrating from legacy to container-based infrastructure > > > Key: THRIFT-3452 > URL: https://issues.apache.org/jira/browse/THRIFT-3452 > Project: Thrift > Issue Type: Bug >Reporter: Roger Meier >Assignee: Roger Meier > > I've started to work on this: > https://docs.travis-ci.com/user/migrating-from-legacy/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3452) .travis.yml: Migrating from legacy to container-based infrastructure
[ https://issues.apache.org/jira/browse/THRIFT-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030898#comment-15030898 ] Roger Meier commented on THRIFT-3452: - I would say we should become able to build and provide the following docker images for build and testing: * thrift/debian * thrift/centos * thrift/ubuntu for endusers: * thrift/compiler > .travis.yml: Migrating from legacy to container-based infrastructure > > > Key: THRIFT-3452 > URL: https://issues.apache.org/jira/browse/THRIFT-3452 > Project: Thrift > Issue Type: Bug >Reporter: Roger Meier >Assignee: Roger Meier > > I've started to work on this: > https://docs.travis-ci.com/user/migrating-from-legacy/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3452) .travis.yml: Migrating from legacy to container-based infrastructure
[ https://issues.apache.org/jira/browse/THRIFT-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030895#comment-15030895 ] Roger Meier commented on THRIFT-3452: - I've just added you as a collaborator on my repo https://github.com/bufferoverflow/thrift/ that is currently linked to https://hub.docker.com/u/thrift/ for the moment. [~jfarrell] Could you create a web hook at the github apache thrift account to Docker hub as described here: https://docs.docker.com/docker-hub/builds/ > .travis.yml: Migrating from legacy to container-based infrastructure > > > Key: THRIFT-3452 > URL: https://issues.apache.org/jira/browse/THRIFT-3452 > Project: Thrift > Issue Type: Bug >Reporter: Roger Meier >Assignee: Roger Meier > > I've started to work on this: > https://docs.travis-ci.com/user/migrating-from-legacy/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (THRIFT-3452) .travis.yml: Migrating from legacy to container-based infrastructure
[ https://issues.apache.org/jira/browse/THRIFT-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030881#comment-15030881 ] Roger Meier edited comment on THRIFT-3452 at 11/29/15 11:03 AM: autosync needs a web hook, see https://docs.docker.com/docker-hub/builds/ I did that for my personal account and the thrift account, I've just added you to the thrift account so we can pull from there. At the moment adopting and tuning all the dockerfiles we have and switching travis to Docker seems to be a good first step. was (Author: roger.meier): autosync needs a web hook, see https://docs.docker.com/docker-hub/builds/ I did that for my personal account and the thrift account, just tell me your account name and I will add you. At the moment adopting and tuning all the dockerfiles we have and switching travis to Docker seems to be a good first step. > .travis.yml: Migrating from legacy to container-based infrastructure > > > Key: THRIFT-3452 > URL: https://issues.apache.org/jira/browse/THRIFT-3452 > Project: Thrift > Issue Type: Bug >Reporter: Roger Meier >Assignee: Roger Meier > > I've started to work on this: > https://docs.travis-ci.com/user/migrating-from-legacy/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3452) .travis.yml: Migrating from legacy to container-based infrastructure
[ https://issues.apache.org/jira/browse/THRIFT-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030881#comment-15030881 ] Roger Meier commented on THRIFT-3452: - autosync needs a web hook, see https://docs.docker.com/docker-hub/builds/ I did that for my personal account and the thrift account, just tell me your account name and I will add you. At the moment adopting and tuning all the dockerfiles we have and switching travis to Docker seems to be a good first step. > .travis.yml: Migrating from legacy to container-based infrastructure > > > Key: THRIFT-3452 > URL: https://issues.apache.org/jira/browse/THRIFT-3452 > Project: Thrift > Issue Type: Bug >Reporter: Roger Meier >Assignee: Roger Meier > > I've started to work on this: > https://docs.travis-ci.com/user/migrating-from-legacy/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3452) .travis.yml: Migrating from legacy to container-based infrastructure
[ https://issues.apache.org/jira/browse/THRIFT-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030634#comment-15030634 ] Roger Meier commented on THRIFT-3452: - That's very nice and I guess we should take this in. Here is what I did so far for Debian: https://github.com/bufferoverflow/thrift/commit/b3272e5277faa2ef69dcfe14b87f08b9947a6639 some are pushed to https://hub.docker.com/u/thrift/ we might use this account to publish > .travis.yml: Migrating from legacy to container-based infrastructure > > > Key: THRIFT-3452 > URL: https://issues.apache.org/jira/browse/THRIFT-3452 > Project: Thrift > Issue Type: Bug >Reporter: Roger Meier >Assignee: Roger Meier > > I've started to work on this: > https://docs.travis-ci.com/user/migrating-from-legacy/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-3453) remove rat_exclude
[ https://issues.apache.org/jira/browse/THRIFT-3453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-3453. - Resolution: Fixed committed > remove rat_exclude > -- > > Key: THRIFT-3453 > URL: https://issues.apache.org/jira/browse/THRIFT-3453 > Project: Thrift > Issue Type: Bug >Reporter: Roger Meier >Assignee: Roger Meier > > rat_exclude file within root of our source tree is not in use anymore. > It has its origin from incubating phase, where the Tool Apache Rat was used. > http://creadur.apache.org/rat/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-3453) remove rat_exclude
[ https://issues.apache.org/jira/browse/THRIFT-3453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier updated THRIFT-3453: Description: rat_exclude file within root of our source tree is not in use anymore. It has its origin from incubating phase, where the Tool Apache Rat was used. http://creadur.apache.org/rat/ was: rat_exclude file within root of our source tree is not in use anymore. It is a relict from adding all the Apcahe license headers using > remove rat_exclude > -- > > Key: THRIFT-3453 > URL: https://issues.apache.org/jira/browse/THRIFT-3453 > Project: Thrift > Issue Type: Bug >Reporter: Roger Meier >Assignee: Roger Meier > > rat_exclude file within root of our source tree is not in use anymore. > It has its origin from incubating phase, where the Tool Apache Rat was used. > http://creadur.apache.org/rat/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-3453) remove rat_exclude
Roger Meier created THRIFT-3453: --- Summary: remove rat_exclude Key: THRIFT-3453 URL: https://issues.apache.org/jira/browse/THRIFT-3453 Project: Thrift Issue Type: Bug Reporter: Roger Meier Assignee: Roger Meier rat_exclude file within root of our source tree is not in use anymore. It is a relict from adding all the Apcahe license headers using -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-3451) thrift_protocol PHP extension missing config.m4 file
[ https://issues.apache.org/jira/browse/THRIFT-3451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-3451. - Resolution: Fixed committed, will be there with next release > thrift_protocol PHP extension missing config.m4 file > > > Key: THRIFT-3451 > URL: https://issues.apache.org/jira/browse/THRIFT-3451 > Project: Thrift > Issue Type: Bug > Components: PHP - Library >Affects Versions: 0.9.2, 0.9.3 >Reporter: Filip Chabik >Assignee: Roger Meier >Priority: Minor > > ../lib/php/src/ext/thrift_protocol/config.m4 file is missing in the tarballs > which prevents PHP extension to be properly compiled. I checked 0.9.3 and > 0.9.2 versions and both were suffering from the same problem. Oddly enough, > config.m4 is present in the git repo: > https://github.com/apache/thrift/blob/master/lib/php/src/ext/thrift_protocol/config.m4 > My guess would be, that during the build/packaging process this file somehow > lost. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
