[GitHub] thrift pull request #1410: Common Lisp support

[dkochmanski]

Github user dkochmanski commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1410#discussion_r148797236
  
--- Diff: lib/cl/framed-transport.lisp ---
@@ -0,0 +1,136 @@
+(in-package #:org.apache.thrift.implementation)
+
+ Copyright 2017 Rigetti Computing 
--- End diff --

Our work on Thrift is sponsored by Rigetti, so there is no need for that.


---

[GitHub] thrift pull request #1410: Common Lisp support

[dkochmanski]

Github user dkochmanski commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1410#discussion_r148796969
  
--- Diff: lib/cl/externals/bundle-info.sexp ---
@@ -0,0 +1,14 @@
+(:CREATION-TIME #A((20) BASE-CHAR . "2017-10-31T11:49:23Z") 
:REQUESTED-SYSTEMS
--- End diff --

all things put in `externals` are checked in, so whole directory will be 
removed (this file included).


---

[GitHub] thrift pull request #1410: Common Lisp support

[jeking3]

Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1410#discussion_r148790161
  
--- Diff: lib/cl/externals/bundle.lisp ---
@@ -0,0 +1,161 @@
+(cl:in-package #:cl-user)
--- End diff --

Missing license statement.


---

[GitHub] thrift pull request #1410: Common Lisp support

[jeking3]

Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1410#discussion_r148790890
  
--- Diff: 
lib/cl/externals/software/usocket-0.7.0.1/vendor/OpenTransportUDP.lisp ---
@@ -0,0 +1,146 @@
+;;;-*-Mode: LISP; Package: CCL -*-
--- End diff --

As with the other libraries, this should not be checked in.  I have skipped 
over all of the externals/ due to this.


---

[GitHub] thrift pull request #1410: Common Lisp support

[jeking3]

Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1410#discussion_r148791102
  
--- Diff: lib/cl/framed-transport.lisp ---
@@ -0,0 +1,136 @@
+(in-package #:org.apache.thrift.implementation)
+
+ Copyright 2017 Rigetti Computing 
--- End diff --

@jfarrell do we need to check with them to make sure this is okay to submit?


---

[GitHub] thrift pull request #1410: Common Lisp support

[jeking3]

Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1410#discussion_r148790668
  
--- Diff: lib/cl/externals/software/bordeaux-threads-v0.8.5/.travis.yml ---
@@ -0,0 +1,44 @@
+language: lisp
--- End diff --

If you checked in bordeaux-threads, it should not be part of the 
submission.  Instead, the build process should install it on demand in the same 
manner that the nodejs implementation calls npm to install packages during the 
build.


---

[GitHub] thrift pull request #1410: Common Lisp support

[jeking3]

Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1410#discussion_r148791220
  
--- Diff: lib/cl/binary-protocol.lisp ---
@@ -0,0 +1,255 @@
+(in-package #:org.apache.thrift.implementation)
+
+ This file defines the concrete `binary-protocol` layer for the 
`org.apache.thrift` library.
+
+ copyright 2010 [james anderson](james.ander...@setf.de)
--- End diff --

@jfarrell do we need to check with them to make sure this is okay to submit?


---

[GitHub] thrift pull request #1410: Common Lisp support

[jeking3]

Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1410#discussion_r148790488
  
--- Diff: lib/cl/externals/software/alexandria-20170830-git/.boring ---
@@ -0,0 +1,13 @@
+# Boring file regexps:
--- End diff --

If you checked in alexandria, it should not be part of the submission.  
Instead, the build process should install it on demand in the same manner that 
the nodejs implementation calls npm to install packages during the build.


---

[GitHub] thrift pull request #1410: Common Lisp support

[jeking3]

Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1410#discussion_r148789088
  
--- Diff: compiler/cpp/src/thrift/generate/t_cl_generator.cc ---
@@ -0,0 +1,544 @@
+// Copyright (c) 2008- Patrick Collison 
--- End diff --

This needs the standard Apache Software License statement applied.


---

[GitHub] thrift pull request #1410: Common Lisp support

[uint]

GitHub user uint opened a pull request:

https://github.com/apache/thrift/pull/1410

Common Lisp support

This adds Common Lisp support - library, generator, cross-tests, tutorial 
code, etc. Currently only SBCL is supported.

The minimal requirements are fulfilled. Cross-tests pass against most 
languages that I've tried.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TurtleWarePL/thrift develop

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1410.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1410


commit 171e9a60784910d48006f1c1c4e08b64f81b22b4
Author: Tomek Kurcz 
Date:   2017-09-19T07:16:43Z

Patch Thrift with de.setf.thrift

commit d4850239d69d32a11793152f9cb98b46bea55075
Author: Tomek Kurcz 
Date:   2017-09-19T07:16:56Z

CL generator: fix and integrate it

commit a48a65de910b8769c3754bd8bdfe69ba1f0e9bc0
Author: Tomek Kurcz 
Date:   2017-09-19T08:42:55Z

Remove non-existent packages and system dependencies

commit 1fae86f6c77bb82847607507f68b92907385b325
Author: Tomek Kurcz 
Date:   2017-09-19T10:05:54Z

Add namespace declarations for CL in tutorial .thrift files

commit 6668f0984d936539ee13755bbdfb57f6cbe760e6
Author: Tomek Kurcz 
Date:   2017-09-19T12:53:39Z

Fix Thrift URIs

commit f85eab281eb89d43dda5eb8cf869cbe23690b008
Author: Tomek Kurcz 
Date:   2017-09-19T13:20:10Z

Cosmetic: Remove emacs file headers

commit a6f873e14ee33c5229e40a3101f4732d87b4caf7
Author: Tomek Kurcz 
Date:   2017-09-20T10:35:06Z

Fix the handling of Thrift types

The decoder should expect i32 when the field type is enum

Rename i08 to i8 according to Thrift's expectations

commit b6c44618c3776e9d5ce80e9276b9e176b7fb96f9
Author: Tomek Kurcz 
Date:   2017-09-21T06:39:10Z

Defined services should just be exported to the current *package*

commit 6393e7d75cec8822d6f57d4cec14a6563528
Author: Tomek Kurcz 
Date:   2017-09-21T07:38:19Z

Bugfix: wrong order of arguments in a function call

commit 8cafef222a8a8f532627a7f31c5f5a7568954283
Author: Tomek Kurcz 
Date:   2017-09-22T09:17:31Z

Ensure users can use :common-lisp symbols when implementing services

commit c413c64ff7699151916a01638c1f02d37b473acc
Author: Tomek Kurcz 
Date:   2017-09-22T11:29:55Z

CL generator: Generate ASDF systems for Thrift programs

Also adds the CLI option not to generate .asd files, but the default is to
generate them.

commit cf85ca14704c51aeafd926bc4cc14f6fdbdd3117
Author: Tomek Kurcz 
Date:   2017-09-22T11:50:10Z

Don't expect server implementation to exist when loading gen'd code

We probably expect those to be declared later

commit 11bdf23b208dad9c2a95d0e1350782c75b4b1bb6
Author: Tomek Kurcz 
Date:   2017-09-25T09:50:26Z

CL generator: Put generated "programs" in separate directories

commit 19ff832d21599618c389fba44963f519c4637712
Author: Tomek Kurcz 
Date:   2017-09-25T11:20:14Z

CL generator: copy the options string to comments in generated files

commit cfdbc1e2ad1bd1d8a66888a0db17879c9cae0562
Author: Tomek Kurcz 
Date:   2017-09-25T11:33:02Z

CL generator: Fix the remaining warnings

commit 340486f190a9cc66555dbdaac6c6ee463bfb615a
Author: Tomek Kurcz 
Date:   2017-09-25T12:08:39Z

Replace the float conversion code with `ieee-floats` from quicklisp

commit c990ad183817e1199aa222afa38996c7dd405e0e
Author: Tomek Kurcz 
Date:   2017-09-26T08:25:46Z

CL generator: Add the option to change the ASDF system prefix

Also: Cosmetic: add a newline after a generated (def-service)

commit fb63de742ccf20d4324cdf20ded1aeca7c81dde4
Author: Tomek Kurcz 
Date:   2017-09-27T08:32:52Z

Fix the load order of thrift-test components

commit 2e0fb30a62f1881fc6cb3946cff20e5c46096f4a
Author: Tomek Kurcz 
Date:   2017-09-27T08:33:17Z

Export vector-stream for use in thrift-test

commit 80494401afcc52bbb5e6d40bcd374986078d195c
Author: Tomek Kurcz 
Date:   2017-09-27T08:38:43Z

Exclude definition-operators.lisp from compilation for now

commit f847cf503dc2cba7f3efb34bef04793d0a068a3c
Author: Tomek Kurcz 
Date:   2017-09-27T08:53:34Z

Cosmetic: Typos and reindentation

commit 61c60b4d3b3c76ce46868b4e9c2a949cf5c4fc4c
Author: Tomek Kurcz 
Date:   2017-09-27T09:01:14Z

Fix vector-protocol.write-sequence

commit