[jira] [Commented] (THRIFT-1629) Ruby 1.9 Compatibility during Thrift configure, make, install
[ https://issues.apache.org/jira/browse/THRIFT-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13593910#comment-13593910 ] Hudson commented on THRIFT-1629: Integrated in Thrift #625 (See [https://builds.apache.org/job/Thrift/625/]) Thrift-1629:Ruby 1.9 Compatibility during Thrift configure, make, install (Revision 073f9eb9b920bda948b306ee16e78743e42b7cd1) Result = ABORTED Ruby 1.9 Compatibility during Thrift configure, make, install - Key: THRIFT-1629 URL: https://issues.apache.org/jira/browse/THRIFT-1629 Project: Thrift Issue Type: Improvement Components: Ruby - Library Affects Versions: 0.8 Environment: Mac OSX, *nix Reporter: Nick Zalabak Assignee: Nick Zalabak Fix For: 1.0 Attachments: thrift-1629-ruby-thin-webserver.patch I downloaded the 0.8 stable version of Thrift and began by performing the configure, make tasks. It appears that this version of Thrift is not compatible with Ruby 1.9. The problem encountered is that Ruby library inside Thrift includes the Mongrel web server. Mongrel does not work with Ruby 1.9. A drop in replacement for Mongrel is the Thin web server, and there are also several other choices. I have submitted a pull request via Github to resolve this matter. https://github.com/apache/thrift/pull/23 Thanks. Nick Zalabak @techwhizbang -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1629) Ruby 1.9 Compatibility during Thrift configure, make, install
[ https://issues.apache.org/jira/browse/THRIFT-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13592610#comment-13592610 ] Nick Zalabak commented on THRIFT-1629: -- Hi Jake, I attached the patch. Sorry about the delay, I ended up not using Thrift so I forgot about the patch I promised. Ruby 1.9 Compatibility during Thrift configure, make, install - Key: THRIFT-1629 URL: https://issues.apache.org/jira/browse/THRIFT-1629 Project: Thrift Issue Type: Improvement Components: Ruby - Library Affects Versions: 0.8 Environment: Mac OSX, *nix Reporter: Nick Zalabak Assignee: Jake Farrell Attachments: thrift-1629-ruby-thin-webserver.patch I downloaded the 0.8 stable version of Thrift and began by performing the configure, make tasks. It appears that this version of Thrift is not compatible with Ruby 1.9. The problem encountered is that Ruby library inside Thrift includes the Mongrel web server. Mongrel does not work with Ruby 1.9. A drop in replacement for Mongrel is the Thin web server, and there are also several other choices. I have submitted a pull request via Github to resolve this matter. https://github.com/apache/thrift/pull/23 Thanks. Nick Zalabak @techwhizbang -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1629) Ruby 1.9 Compatibility during Thrift configure, make, install
[ https://issues.apache.org/jira/browse/THRIFT-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13591603#comment-13591603 ] Jake Farrell commented on THRIFT-1629: -- Nick, any updates on this patch? Ruby 1.9 Compatibility during Thrift configure, make, install - Key: THRIFT-1629 URL: https://issues.apache.org/jira/browse/THRIFT-1629 Project: Thrift Issue Type: Improvement Components: Ruby - Library Affects Versions: 0.8 Environment: Mac OSX, *nix Reporter: Nick Zalabak Assignee: Jake Farrell I downloaded the 0.8 stable version of Thrift and began by performing the configure, make tasks. It appears that this version of Thrift is not compatible with Ruby 1.9. The problem encountered is that Ruby library inside Thrift includes the Mongrel web server. Mongrel does not work with Ruby 1.9. A drop in replacement for Mongrel is the Thin web server, and there are also several other choices. I have submitted a pull request via Github to resolve this matter. https://github.com/apache/thrift/pull/23 Thanks. Nick Zalabak @techwhizbang -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1629) Ruby 1.9 Compatibility during Thrift configure, make, install
[ https://issues.apache.org/jira/browse/THRIFT-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13410416#comment-13410416 ] Jake Farrell commented on THRIFT-1629: -- Nick, we do not currently accept github pull requests, please see http://thrift.apache.org/docs/HowToContribute/ for information on submitting a patch. Also your patch isn't against trunk which shows the dependencies as the following s.add_development_dependency rake s.add_development_dependency rspec, 1.3.2 s.add_development_dependency mongrel vs your patch which has s.add_development_dependency rake, ~ 0.9.2.2 s.add_development_dependency rspec, 1.3.2 s.add_development_dependency rack, ~ 1.4.1 s.add_development_dependency rack-test, ~ 0.6.1 s.add_development_dependency thin, ~ 1.3.1 s.add_development_dependency bundler, ~ 1.1.4 I am all for using the best option for maintainability and cross version stability, but I would like to avoid adding more dependencies to help keep things easier to debug. Ruby 1.9 Compatibility during Thrift configure, make, install - Key: THRIFT-1629 URL: https://issues.apache.org/jira/browse/THRIFT-1629 Project: Thrift Issue Type: Improvement Components: Ruby - Library Affects Versions: 0.8 Environment: Mac OSX, *nix Reporter: Nick Zalabak I downloaded the 0.8 stable version of Thrift and began by performing the configure, make tasks. It appears that this version of Thrift is not compatible with Ruby 1.9. The problem encountered is that Ruby library inside Thrift includes the Mongrel web server. Mongrel does not work with Ruby 1.9. A drop in replacement for Mongrel is the Thin web server, and there are also several other choices. I have submitted a pull request via Github to resolve this matter. https://github.com/apache/thrift/pull/23 Thanks. Nick Zalabak @techwhizbang -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1629) Ruby 1.9 Compatibility during Thrift configure, make, install
[ https://issues.apache.org/jira/browse/THRIFT-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13410549#comment-13410549 ] Nick Zalabak commented on THRIFT-1629: -- Thanks Jake. I will submit the patch based on the How to Contribute instructions. There are a just a few new additions to the dependency chain for the added benefit of cross compatibility. In terms of the Thrift Ruby client gemspec though, it should be setup to specify runtime and development dependencies. At the moment it doesn't specify runtime deps and it really ought too. Not specifying runtime deps makes the gem difficult to use especially when added to application stacks with sizable dependency chains. In fact, I will make another patch that addresses this as well. Ruby 1.9 Compatibility during Thrift configure, make, install - Key: THRIFT-1629 URL: https://issues.apache.org/jira/browse/THRIFT-1629 Project: Thrift Issue Type: Improvement Components: Ruby - Library Affects Versions: 0.8 Environment: Mac OSX, *nix Reporter: Nick Zalabak I downloaded the 0.8 stable version of Thrift and began by performing the configure, make tasks. It appears that this version of Thrift is not compatible with Ruby 1.9. The problem encountered is that Ruby library inside Thrift includes the Mongrel web server. Mongrel does not work with Ruby 1.9. A drop in replacement for Mongrel is the Thin web server, and there are also several other choices. I have submitted a pull request via Github to resolve this matter. https://github.com/apache/thrift/pull/23 Thanks. Nick Zalabak @techwhizbang -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
