[jira] [Commented] (THRIFT-1856) different comments generated on OSX vs Linux/Windows
[ https://issues.apache.org/jira/browse/THRIFT-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13688124#comment-13688124 ] Jake Farrell commented on THRIFT-1856: -- this patch is not in the 0.9.0 release, it will be available in the upcoming 0.9.1 release > different comments generated on OSX vs Linux/Windows > > > Key: THRIFT-1856 > URL: https://issues.apache.org/jira/browse/THRIFT-1856 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler >Affects Versions: 0.9, 1.0 > Environment: OSX 10.7 > Ubuntu 12.04 >Reporter: Vitali Lovich >Assignee: Jake Farrell > Attachments: mytest.thrift, Test.java.linux, Test.java.osx > > > Compiling the same thrift definition on OSX & Linux produces two slightly > different outputs. Since our thrift files are committed in the repository, > it makes it annoying to develop on OSX. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1856) different comments generated on OSX vs Linux/Windows
[ https://issues.apache.org/jira/browse/THRIFT-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13688017#comment-13688017 ] Christopher Tubbs commented on THRIFT-1856: --- On what version (was this/will this be) fixed? > different comments generated on OSX vs Linux/Windows > > > Key: THRIFT-1856 > URL: https://issues.apache.org/jira/browse/THRIFT-1856 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler >Affects Versions: 0.9, 1.0 > Environment: OSX 10.7 > Ubuntu 12.04 >Reporter: Vitali Lovich >Assignee: Jake Farrell > Attachments: mytest.thrift, Test.java.linux, Test.java.osx > > > Compiling the same thrift definition on OSX & Linux produces two slightly > different outputs. Since our thrift files are committed in the repository, > it makes it annoying to develop on OSX. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1856) different comments generated on OSX vs Linux/Windows
[ https://issues.apache.org/jira/browse/THRIFT-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580935#comment-13580935 ] Jake Farrell commented on THRIFT-1856: -- On OS X the Maps key and value where being marked with required and optional comments within the serialize and deserialize functions, on linux the lex compiler is setting the optional flag on maps value field differently. The patch moved the optional or required comment to only be in the initial declaration of the variables defined in the idl and removes the comments from internally generated variables. > different comments generated on OSX vs Linux/Windows > > > Key: THRIFT-1856 > URL: https://issues.apache.org/jira/browse/THRIFT-1856 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler >Affects Versions: 0.9, 1.0 > Environment: OSX 10.7 > Ubuntu 12.04 >Reporter: Vitali Lovich >Assignee: Jake Farrell > Attachments: mytest.thrift, Test.java.linux, Test.java.osx > > > Compiling the same thrift definition on OSX & Linux produces two slightly > different outputs. Since our thrift files are committed in the repository, > it makes it annoying to develop on OSX. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1856) different comments generated on OSX vs Linux/Windows
[ https://issues.apache.org/jira/browse/THRIFT-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580366#comment-13580366 ] Vitali Lovich commented on THRIFT-1856: --- Just curious about the patch. While it seems like it would workaround the issue, it doesn't seem to fix the underlying reason why different comments would be generated. Is there any explanation of why different code-paths are being taken? My guess would be the difference in default signedness of char but I haven't had any luck root-causing the issue. > different comments generated on OSX vs Linux/Windows > > > Key: THRIFT-1856 > URL: https://issues.apache.org/jira/browse/THRIFT-1856 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler >Affects Versions: 0.9, 1.0 > Environment: OSX 10.7 > Ubuntu 12.04 >Reporter: Vitali Lovich >Assignee: Jake Farrell > Attachments: mytest.thrift, Test.java.linux, Test.java.osx > > > Compiling the same thrift definition on OSX & Linux produces two slightly > different outputs. Since our thrift files are committed in the repository, > it makes it annoying to develop on OSX. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1856) different comments generated on OSX vs Linux/Windows
[ https://issues.apache.org/jira/browse/THRIFT-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580356#comment-13580356 ] Hudson commented on THRIFT-1856: Integrated in Thrift #624 (See [https://builds.apache.org/job/Thrift/624/]) THRIFT-1856: different comments generated (Revision 5b0c590968a8864f93273cc0957a59774717519e) Result = FAILURE jfarrell : https://git-wip-us.apache.org/repos/asf?p=thrift.git&a=commit&h=5b0c590968a8864f93273cc0957a59774717519e Files : * compiler/cpp/src/generate/t_java_generator.cc > different comments generated on OSX vs Linux/Windows > > > Key: THRIFT-1856 > URL: https://issues.apache.org/jira/browse/THRIFT-1856 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler >Affects Versions: 0.9, 1.0 > Environment: OSX 10.7 > Ubuntu 12.04 >Reporter: Vitali Lovich >Assignee: Jake Farrell > Attachments: mytest.thrift, Test.java.linux, Test.java.osx > > > Compiling the same thrift definition on OSX & Linux produces two slightly > different outputs. Since our thrift files are committed in the repository, > it makes it annoying to develop on OSX. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1856) different comments generated on OSX vs Linux/Windows
[ https://issues.apache.org/jira/browse/THRIFT-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580297#comment-13580297 ] Hudson commented on THRIFT-1856: Integrated in Thrift #623 (See [https://builds.apache.org/job/Thrift/623/]) THRIFT-1856: different comments generated (Revision 1af57289f299f9f03c9ed0e5826f8e464171bbf9) Result = FAILURE jfarrell : https://git-wip-us.apache.org/repos/asf?p=thrift.git&a=commit&h=1af57289f299f9f03c9ed0e5826f8e464171bbf9 Files : * compiler/cpp/src/generate/t_java_generator.cc > different comments generated on OSX vs Linux/Windows > > > Key: THRIFT-1856 > URL: https://issues.apache.org/jira/browse/THRIFT-1856 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler >Affects Versions: 0.9, 1.0 > Environment: OSX 10.7 > Ubuntu 12.04 >Reporter: Vitali Lovich >Assignee: Jake Farrell > Attachments: mytest.thrift, Test.java.linux, Test.java.osx > > > Compiling the same thrift definition on OSX & Linux produces two slightly > different outputs. Since our thrift files are committed in the repository, > it makes it annoying to develop on OSX. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1856) different comments generated on OSX vs Linux/Windows
[ https://issues.apache.org/jira/browse/THRIFT-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580100#comment-13580100 ] Jake Farrell commented on THRIFT-1856: -- When generating the test idl on both centos and os x I get a difference of centos not respecting the comment for optional fields where os x is working as expected. In your os x generated Test.java you have a duplicate line on 183 which I was unable to reproduce. > different comments generated on OSX vs Linux/Windows > > > Key: THRIFT-1856 > URL: https://issues.apache.org/jira/browse/THRIFT-1856 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler >Affects Versions: 0.9, 1.0 > Environment: OSX 10.7 > Ubuntu 12.04 >Reporter: Vitali Lovich > Attachments: mytest.thrift, Test.java.linux, Test.java.osx > > > Compiling the same thrift definition on OSX & Linux produces two slightly > different outputs. Since our thrift files are committed in the repository, > it makes it annoying to develop on OSX. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
