[jira] [Commented] (THRIFT-3831) build of test/cpp/src/TestClient.cpp fails with newer gcc on platforms with unsigned char due to narrowing conversions
[
https://issues.apache.org/jira/browse/THRIFT-3831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538645#comment-15538645
]
ASF GitHub Bot commented on THRIFT-3831:
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1085
> build of test/cpp/src/TestClient.cpp fails with newer gcc on platforms with
> unsigned char due to narrowing conversions
> --
>
> Key: THRIFT-3831
> URL: https://issues.apache.org/jira/browse/THRIFT-3831
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Reporter: Cody Schafer
> Attachments: 0001-test-cpp-explicitly-use-signed-char.patch
>
>
> Specifically, we get a bunch of errors like:
> test/cpp/src/TestClient.cpp:404:15: error: narrowing conversion
> of '-1' from 'int' to 'char' inside { } [-Wnarrowing]
> gcc faq talks about this: https://gcc.gnu.org/wiki/FAQ#Wnarrowing
> I've only seen this in gcc-6, but the faq seems to indicate it could occur in
> gcc-5 as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3831) build of test/cpp/src/TestClient.cpp fails with newer gcc on platforms with unsigned char due to narrowing conversions
[
https://issues.apache.org/jira/browse/THRIFT-3831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15478127#comment-15478127
]
ASF GitHub Bot commented on THRIFT-3831:
GitHub user jmesmon opened a pull request:
https://github.com/apache/thrift/pull/1085
THRIFT-3831 in test/cpp explicitly use `signed char`
`char`'s signed-ness is implimentation dependent, and in the case where
`char` was not signed, we previously recieved errors like
thrift/0.9.3-r0/git/test/cpp/src/TestClient.cpp:404:15: error:
narrowing conversion of '-127' from 'int' to 'char' inside { } [-Wnarrowing]
(This example from gcc-6 on arm)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jmesmon/thrift thrift-3831-use-signed-char
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1085.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1085
commit 353ab11c3402265b62d865a24427b53e75fe1c5f
Author: Cody P Schafer
Date: 2016-09-09T19:50:26Z
THRIFT-3831 in test/cpp explicitly use `signed char`
`char`'s signed-ness is implimentation dependent, and in the case where
`char` was not signed, we previously recieved errors like
thrift/0.9.3-r0/git/test/cpp/src/TestClient.cpp:404:15: error:
narrowing conversion of '-127' from 'int' to 'char' inside { } [-Wnarrowing]
(This example from gcc-6 on arm)
> build of test/cpp/src/TestClient.cpp fails with newer gcc on platforms with
> unsigned char due to narrowing conversions
> --
>
> Key: THRIFT-3831
> URL: https://issues.apache.org/jira/browse/THRIFT-3831
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Reporter: Cody Schafer
> Attachments: 0001-test-cpp-explicitly-use-signed-char.patch
>
>
> Specifically, we get a bunch of errors like:
> test/cpp/src/TestClient.cpp:404:15: error: narrowing conversion
> of '-1' from 'int' to 'char' inside { } [-Wnarrowing]
> gcc faq talks about this: https://gcc.gnu.org/wiki/FAQ#Wnarrowing
> I've only seen this in gcc-6, but the faq seems to indicate it could occur in
> gcc-5 as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3831) build of test/cpp/src/TestClient.cpp fails with newer gcc on platforms with unsigned char due to narrowing conversions
[
https://issues.apache.org/jira/browse/THRIFT-3831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335331#comment-15335331
]
James E. King, III commented on THRIFT-3831:
I'd recommend you open a pull request for this. The easiest way is generate a
pull request from a fork of the thrift project on Github. That process and the
patch upload method to contributing fixes can be found here:
https://github.com/apache/thrift/blob/master/doc/committers.md.
> build of test/cpp/src/TestClient.cpp fails with newer gcc on platforms with
> unsigned char due to narrowing conversions
> --
>
> Key: THRIFT-3831
> URL: https://issues.apache.org/jira/browse/THRIFT-3831
> Project: Thrift
> Issue Type: Bug
>Reporter: Cody Schafer
> Attachments: 0001-test-cpp-explicitly-use-signed-char.patch
>
>
> Specifically, we get a bunch of errors like:
> test/cpp/src/TestClient.cpp:404:15: error: narrowing conversion
> of '-1' from 'int' to 'char' inside { } [-Wnarrowing]
> gcc faq talks about this: https://gcc.gnu.org/wiki/FAQ#Wnarrowing
> I've only seen this in gcc-6, but the faq seems to indicate it could occur in
> gcc-5 as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
