[jira] [Updated] (THRIFT-1286) Modernize the Thrift Ruby Library Dev Environment
[ https://issues.apache.org/jira/browse/THRIFT-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-1286: - Attachment: thrift-1286.patch Updated patch with the following features - Removes dependency on echoe for spec generation - Adds gemfile for bulider and uses thrift.gemspec for dependency management. - adds checks in configure for builder and only calls if available (make check-local on ci servers) - Adds checks in configure for Ruby and rake (bundler as well but this is optional for check-local and auto dependency management) - still allows for rake to do its thing if all dependencies are in place - Removed Manifest and setup.rb - Adds a install task which will generate a gem and then install that gem to locally configured ruby path (no more prefix or destdir with this client) > Modernize the Thrift Ruby Library Dev Environment > - > > Key: THRIFT-1286 > URL: https://issues.apache.org/jira/browse/THRIFT-1286 > Project: Thrift > Issue Type: Improvement > Components: Ruby - Library >Affects Versions: 0.7, 0.8 >Reporter: Scott Gonyea >Assignee: Jake Farrell > Fix For: 0.7, 0.8 > > Attachments: thrift-1286.patch, thrift-1286.patch, thrift-1286.patch, > thrift-1286.patch, thrift-1286.patch > > > This fixes the ruby libraries environment. This introduces Bundler for > managing the development environment, as well as in handling the Gem release > process. Echoe is no longer present. > The end result is that the development environment is easier to setup and > easier to reproduce. Thus, easier to contribute to. > This structures the spec folder to better follow conventions RSpec. > The RSpec, as used in the ruby library, was using a mix of RSpec 1 and RSpec > 2. This brings everything into the land of RSpec 2. Some additional cleanup > could definitely be done, but this gets us out of the deprecation warnings > and other weird behavior-ings. > To run this in CI, however that is done, you'll effectively want the shell > script (or whatever) to look like this: > which bundle || gem install bundler > bundle install > bundle exec rake spec > Patch should be pulled from: > https://github.com/sgonyea/thrift/compare/apache:trunk...1fd22f135700c5d32244c63c164610f52b94619b > or up to the commit: > https://github.com/sgonyea/thrift/commit/1fd22f135700c5d32244c63c164610f52b94619b -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1286) Modernize the Thrift Ruby Library Dev Environment
[ https://issues.apache.org/jira/browse/THRIFT-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-1286: - Attachment: thrift-1286.patch Updated patch that allows for either bundler or rake to build the ruby client. Configure script now checks for Bundler availability to allow ci servers to build successfully. Dependencies are automatically handled via Bundler and the thrift.gemspec. Removes dependency on echoe. > Modernize the Thrift Ruby Library Dev Environment > - > > Key: THRIFT-1286 > URL: https://issues.apache.org/jira/browse/THRIFT-1286 > Project: Thrift > Issue Type: Improvement > Components: Ruby - Library >Affects Versions: 0.7, 0.8 >Reporter: Scott Gonyea >Assignee: Jake Farrell > Fix For: 0.7, 0.8 > > Attachments: thrift-1286.patch, thrift-1286.patch, thrift-1286.patch, > thrift-1286.patch > > > This fixes the ruby libraries environment. This introduces Bundler for > managing the development environment, as well as in handling the Gem release > process. Echoe is no longer present. > The end result is that the development environment is easier to setup and > easier to reproduce. Thus, easier to contribute to. > This structures the spec folder to better follow conventions RSpec. > The RSpec, as used in the ruby library, was using a mix of RSpec 1 and RSpec > 2. This brings everything into the land of RSpec 2. Some additional cleanup > could definitely be done, but this gets us out of the deprecation warnings > and other weird behavior-ings. > To run this in CI, however that is done, you'll effectively want the shell > script (or whatever) to look like this: > which bundle || gem install bundler > bundle install > bundle exec rake spec > Patch should be pulled from: > https://github.com/sgonyea/thrift/compare/apache:trunk...1fd22f135700c5d32244c63c164610f52b94619b > or up to the commit: > https://github.com/sgonyea/thrift/commit/1fd22f135700c5d32244c63c164610f52b94619b -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1286) Modernize the Thrift Ruby Library Dev Environment
[ https://issues.apache.org/jira/browse/THRIFT-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Gonyea updated THRIFT-1286: - Attachment: thrift-1286.patch Updated patch > Modernize the Thrift Ruby Library Dev Environment > - > > Key: THRIFT-1286 > URL: https://issues.apache.org/jira/browse/THRIFT-1286 > Project: Thrift > Issue Type: Improvement > Components: Ruby - Library >Affects Versions: 0.7, 0.8 >Reporter: Scott Gonyea >Assignee: Jake Farrell > Fix For: 0.7, 0.8 > > Attachments: thrift-1286.patch, thrift-1286.patch, thrift-1286.patch > > > This fixes the ruby libraries environment. This introduces Bundler for > managing the development environment, as well as in handling the Gem release > process. Echoe is no longer present. > The end result is that the development environment is easier to setup and > easier to reproduce. Thus, easier to contribute to. > This structures the spec folder to better follow conventions RSpec. > The RSpec, as used in the ruby library, was using a mix of RSpec 1 and RSpec > 2. This brings everything into the land of RSpec 2. Some additional cleanup > could definitely be done, but this gets us out of the deprecation warnings > and other weird behavior-ings. > To run this in CI, however that is done, you'll effectively want the shell > script (or whatever) to look like this: > which bundle || gem install bundler > bundle install > bundle exec rake spec > Patch should be pulled from: > https://github.com/sgonyea/thrift/compare/apache:trunk...1fd22f135700c5d32244c63c164610f52b94619b > or up to the commit: > https://github.com/sgonyea/thrift/commit/1fd22f135700c5d32244c63c164610f52b94619b -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1286) Modernize the Thrift Ruby Library Dev Environment
[ https://issues.apache.org/jira/browse/THRIFT-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Gonyea updated THRIFT-1286: - Attachment: thrift-1286.patch Patch for THRIFT-1286 > Modernize the Thrift Ruby Library Dev Environment > - > > Key: THRIFT-1286 > URL: https://issues.apache.org/jira/browse/THRIFT-1286 > Project: Thrift > Issue Type: Improvement > Components: Ruby - Library >Affects Versions: 0.7, 0.8 >Reporter: Scott Gonyea >Assignee: Jake Farrell > Fix For: 0.7, 0.8 > > Attachments: thrift-1286.patch, thrift-1286.patch > > > This fixes the ruby libraries environment. This introduces Bundler for > managing the development environment, as well as in handling the Gem release > process. Echoe is no longer present. > The end result is that the development environment is easier to setup and > easier to reproduce. Thus, easier to contribute to. > This structures the spec folder to better follow conventions RSpec. > The RSpec, as used in the ruby library, was using a mix of RSpec 1 and RSpec > 2. This brings everything into the land of RSpec 2. Some additional cleanup > could definitely be done, but this gets us out of the deprecation warnings > and other weird behavior-ings. > To run this in CI, however that is done, you'll effectively want the shell > script (or whatever) to look like this: > which bundle || gem install bundler > bundle install > bundle exec rake spec > Patch should be pulled from: > https://github.com/sgonyea/thrift/compare/apache:trunk...1fd22f135700c5d32244c63c164610f52b94619b > or up to the commit: > https://github.com/sgonyea/thrift/commit/1fd22f135700c5d32244c63c164610f52b94619b -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1286) Modernize the Thrift Ruby Library Dev Environment
[ https://issues.apache.org/jira/browse/THRIFT-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-1286: - Attachment: thrift-1286.patch I've been looking into why the rb client changes to rspec2 have been breaking the ci builds. The build servers are not on the latest version of ruby gems and are running rspec 1.3. The configure script checked for spec to be installed, which is available on the ci servers, and then when make check was issued the rb makefile was calling rake spec which caused the build to break since the new rake file depended on rspec2 not rspec 1.3. To solve this the attached patch introduces the bundler gem as a new ruby dependency. This will help ruby client builds with a Gemfile for versioning all the clients dependencies and i've added in the necessary calls in configure to guarantee that bundler is installed before attempting to use any ruby specific build tools (rake, rspec, spec, etc.). > Modernize the Thrift Ruby Library Dev Environment > - > > Key: THRIFT-1286 > URL: https://issues.apache.org/jira/browse/THRIFT-1286 > Project: Thrift > Issue Type: Improvement > Components: Ruby - Library >Affects Versions: 0.7, 0.8 >Reporter: Scott Gonyea > Fix For: 0.7, 0.8 > > Attachments: thrift-1286.patch > > > This fixes the ruby libraries environment. This introduces Bundler for > managing the development environment, as well as in handling the Gem release > process. Echoe is no longer present. > The end result is that the development environment is easier to setup and > easier to reproduce. Thus, easier to contribute to. > This structures the spec folder to better follow conventions RSpec. > The RSpec, as used in the ruby library, was using a mix of RSpec 1 and RSpec > 2. This brings everything into the land of RSpec 2. Some additional cleanup > could definitely be done, but this gets us out of the deprecation warnings > and other weird behavior-ings. > To run this in CI, however that is done, you'll effectively want the shell > script (or whatever) to look like this: > which bundle || gem install bundler > bundle install > bundle exec rake spec > Patch should be pulled from: > https://github.com/sgonyea/thrift/compare/apache:trunk...1fd22f135700c5d32244c63c164610f52b94619b > or up to the commit: > https://github.com/sgonyea/thrift/commit/1fd22f135700c5d32244c63c164610f52b94619b -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
