[jira] [Commented] (TIKA-4119) Return media type "text/javascript" instead of "application/javascript to follow RFC-9239
[
https://issues.apache.org/jira/browse/TIKA-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759921#comment-17759921
]
Nick Burch commented on TIKA-4119:
--
I wonder if this is a big enough change around Detection that we ought to wait
for 3.x to make it. Thoughts anyone?
(We already define {{text/javascript}} as an alias for the type, so users can
already define parsers etc for the text variant, but swapping the canonical and
the alias is going to break a lot of detection uses if people don't update)
> Return media type "text/javascript" instead of "application/javascript to
> follow RFC-9239
> -
>
> Key: TIKA-4119
> URL: https://issues.apache.org/jira/browse/TIKA-4119
> Project: Tika
> Issue Type: Improvement
>Reporter: Matthias Juchmes
>Priority: Major
>
> [RFC-9239|https://www.rfc-editor.org/rfc/rfc9239.html] obsoletes some
> javascript media types, including "application/javascript", which is
> currently returned by Tika for javascript files. "text/javascript" is defined
> as the most widely supported one, so Tika should reflect this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TIKA-4119) Return media type "text/javascript" instead of "application/javascript to follow RFC-9239
[ https://issues.apache.org/jira/browse/TIKA-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761987#comment-17761987 ] Matthias Juchmes commented on TIKA-4119: I agree that changing this for 3.x probably makes the most sense. > Return media type "text/javascript" instead of "application/javascript to > follow RFC-9239 > - > > Key: TIKA-4119 > URL: https://issues.apache.org/jira/browse/TIKA-4119 > Project: Tika > Issue Type: Improvement >Reporter: Matthias Juchmes >Priority: Major > > [RFC-9239|https://www.rfc-editor.org/rfc/rfc9239.html] obsoletes some > javascript media types, including "application/javascript", which is > currently returned by Tika for javascript files. "text/javascript" is defined > as the most widely supported one, so Tika should reflect this. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TIKA-4119) Return media type "text/javascript" instead of "application/javascript to follow RFC-9239
[ https://issues.apache.org/jira/browse/TIKA-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810075#comment-17810075 ] ASF GitHub Bot commented on TIKA-4119: -- marcospereira opened a new pull request, #1556: URL: https://github.com/apache/tika/pull/1556 ## What Fixes [TIKA-4119](https://issues.apache.org/jira/browse/TIKA-4119). Additionally, I've added support for ".mjs" files, as documented in the RFC: > Additional information: > > Deprecated alias names for this type: application/javascript, application/x-javascript, text/javascript1.0, text/javascript1.1, text/javascript1.2, text/javascript1.3, text/javascript1.4, text/javascript1.5, text/jscript, text/livescript > > Magic number(s): N/A > **File extension(s): .js, .mjs** > Macintosh File Type Code(s): TEXT > Return media type "text/javascript" instead of "application/javascript to > follow RFC-9239 > - > > Key: TIKA-4119 > URL: https://issues.apache.org/jira/browse/TIKA-4119 > Project: Tika > Issue Type: Improvement > Components: mime >Reporter: Matthias Juchmes >Priority: Major > Labels: tika-3x > > [RFC-9239|https://www.rfc-editor.org/rfc/rfc9239.html] obsoletes some > javascript media types, including "application/javascript", which is > currently returned by Tika for javascript files. "text/javascript" is defined > as the most widely supported one, so Tika should reflect this. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TIKA-4119) Return media type "text/javascript" instead of "application/javascript to follow RFC-9239
[
https://issues.apache.org/jira/browse/TIKA-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810080#comment-17810080
]
ASF GitHub Bot commented on TIKA-4119:
--
tballison commented on code in PR #1556:
URL: https://github.com/apache/tika/pull/1556#discussion_r1463871190
##
tika-core/src/test/java/org/apache/tika/mime/MimeTypesReaderTest.java:
##
Review Comment:
Better not to include the whitespace changes unrelated to the javascript
issue. No need to modify, though. I'm guilty of this too occasionally. LOL...
Same goes for the improvements to the minShouldMatch tests
##
README.md:
##
@@ -20,7 +20,7 @@ Tika jars can be fetched from Maven Central or your favourite
Maven mirror.
**Tika 1.X reached End of Life (EOL) on September 30, 2022.**
-Tika is based on **Java 8** and uses the [Maven 3](https://maven.apache.org)
build system.
+Tika is based on **Java 11** and uses the [Maven 3](https://maven.apache.org)
build system.
Review Comment:
Probably better in a separate commit, but let's leave it. Same goes for
other improvements in this file.
##
tika-core/src/test/java/org/apache/tika/mime/ProbabilisticMimeDetectionTest.java:
##
@@ -135,7 +136,7 @@ private void testFile(String expected, String filename)
throws IOException {
private void testStream(String expected, String urlOrFileName, InputStream
in)
throws IOException {
-assertNotNull("Test stream: [" + urlOrFileName + "] is null!", in);
+assertNotNull(in, "Test stream: [" + urlOrFileName + "] is null!");
Review Comment:
This is a bug which we'll fix in main separately. Let's revert this here.
> Return media type "text/javascript" instead of "application/javascript to
> follow RFC-9239
> -
>
> Key: TIKA-4119
> URL: https://issues.apache.org/jira/browse/TIKA-4119
> Project: Tika
> Issue Type: Improvement
> Components: mime
>Reporter: Matthias Juchmes
>Priority: Major
> Labels: tika-3x
>
> [RFC-9239|https://www.rfc-editor.org/rfc/rfc9239.html] obsoletes some
> javascript media types, including "application/javascript", which is
> currently returned by Tika for javascript files. "text/javascript" is defined
> as the most widely supported one, so Tika should reflect this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TIKA-4119) Return media type "text/javascript" instead of "application/javascript to follow RFC-9239
[ https://issues.apache.org/jira/browse/TIKA-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810081#comment-17810081 ] ASF GitHub Bot commented on TIKA-4119: -- marcospereira commented on code in PR #1556: URL: https://github.com/apache/tika/pull/1556#discussion_r1463888582 ## README.md: ## @@ -20,7 +20,7 @@ Tika jars can be fetched from Maven Central or your favourite Maven mirror. **Tika 1.X reached End of Life (EOL) on September 30, 2022.** -Tika is based on **Java 8** and uses the [Maven 3](https://maven.apache.org) build system. +Tika is based on **Java 11** and uses the [Maven 3](https://maven.apache.org) build system. Review Comment: Oh, it was in a separate commit before, but the pull request template recommends squashing all the changes. I can easily split this if you want. :-) > Return media type "text/javascript" instead of "application/javascript to > follow RFC-9239 > - > > Key: TIKA-4119 > URL: https://issues.apache.org/jira/browse/TIKA-4119 > Project: Tika > Issue Type: Improvement > Components: mime >Reporter: Matthias Juchmes >Priority: Major > Labels: tika-3x > > [RFC-9239|https://www.rfc-editor.org/rfc/rfc9239.html] obsoletes some > javascript media types, including "application/javascript", which is > currently returned by Tika for javascript files. "text/javascript" is defined > as the most widely supported one, so Tika should reflect this. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TIKA-4119) Return media type "text/javascript" instead of "application/javascript to follow RFC-9239
[ https://issues.apache.org/jira/browse/TIKA-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810082#comment-17810082 ] ASF GitHub Bot commented on TIKA-4119: -- marcospereira commented on code in PR #1556: URL: https://github.com/apache/tika/pull/1556#discussion_r1463889449 ## tika-core/src/test/java/org/apache/tika/mime/MimeTypesReaderTest.java: ## Review Comment: It was not intentional. The code editor formatted the code automatically. 😬 > Return media type "text/javascript" instead of "application/javascript to > follow RFC-9239 > - > > Key: TIKA-4119 > URL: https://issues.apache.org/jira/browse/TIKA-4119 > Project: Tika > Issue Type: Improvement > Components: mime >Reporter: Matthias Juchmes >Priority: Major > Labels: tika-3x > > [RFC-9239|https://www.rfc-editor.org/rfc/rfc9239.html] obsoletes some > javascript media types, including "application/javascript", which is > currently returned by Tika for javascript files. "text/javascript" is defined > as the most widely supported one, so Tika should reflect this. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TIKA-4119) Return media type "text/javascript" instead of "application/javascript to follow RFC-9239
[
https://issues.apache.org/jira/browse/TIKA-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810083#comment-17810083
]
ASF GitHub Bot commented on TIKA-4119:
--
marcospereira commented on code in PR #1556:
URL: https://github.com/apache/tika/pull/1556#discussion_r1463890809
##
tika-core/src/test/java/org/apache/tika/mime/ProbabilisticMimeDetectionTest.java:
##
@@ -135,7 +136,7 @@ private void testFile(String expected, String filename)
throws IOException {
private void testStream(String expected, String urlOrFileName, InputStream
in)
throws IOException {
-assertNotNull("Test stream: [" + urlOrFileName + "] is null!", in);
+assertNotNull(in, "Test stream: [" + urlOrFileName + "] is null!");
Review Comment:
Got it. Let me reorganize the commits and remove this now. The tests passed
with no issues on my machine, though.
> Return media type "text/javascript" instead of "application/javascript to
> follow RFC-9239
> -
>
> Key: TIKA-4119
> URL: https://issues.apache.org/jira/browse/TIKA-4119
> Project: Tika
> Issue Type: Improvement
> Components: mime
>Reporter: Matthias Juchmes
>Priority: Major
> Labels: tika-3x
>
> [RFC-9239|https://www.rfc-editor.org/rfc/rfc9239.html] obsoletes some
> javascript media types, including "application/javascript", which is
> currently returned by Tika for javascript files. "text/javascript" is defined
> as the most widely supported one, so Tika should reflect this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TIKA-4119) Return media type "text/javascript" instead of "application/javascript to follow RFC-9239
[ https://issues.apache.org/jira/browse/TIKA-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810085#comment-17810085 ] ASF GitHub Bot commented on TIKA-4119: -- marcospereira commented on PR #1556: URL: https://github.com/apache/tika/pull/1556#issuecomment-1906786972 @tballison, thanks for the quick review. This should be in a better state now. > Return media type "text/javascript" instead of "application/javascript to > follow RFC-9239 > - > > Key: TIKA-4119 > URL: https://issues.apache.org/jira/browse/TIKA-4119 > Project: Tika > Issue Type: Improvement > Components: mime >Reporter: Matthias Juchmes >Priority: Major > Labels: tika-3x > > [RFC-9239|https://www.rfc-editor.org/rfc/rfc9239.html] obsoletes some > javascript media types, including "application/javascript", which is > currently returned by Tika for javascript files. "text/javascript" is defined > as the most widely supported one, so Tika should reflect this. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TIKA-4119) Return media type "text/javascript" instead of "application/javascript to follow RFC-9239
[
https://issues.apache.org/jira/browse/TIKA-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810095#comment-17810095
]
ASF GitHub Bot commented on TIKA-4119:
--
tballison commented on code in PR #1556:
URL: https://github.com/apache/tika/pull/1556#discussion_r1463954328
##
tika-core/src/test/java/org/apache/tika/mime/ProbabilisticMimeDetectionTest.java:
##
@@ -135,7 +136,7 @@ private void testFile(String expected, String filename)
throws IOException {
private void testStream(String expected, String urlOrFileName, InputStream
in)
throws IOException {
-assertNotNull("Test stream: [" + urlOrFileName + "] is null!", in);
+assertNotNull(in, "Test stream: [" + urlOrFileName + "] is null!");
Review Comment:
Ha, right, the tests pass because our current test is "is the warning
message not null", and in fact, the warning message is not null. LOL...
> Return media type "text/javascript" instead of "application/javascript to
> follow RFC-9239
> -
>
> Key: TIKA-4119
> URL: https://issues.apache.org/jira/browse/TIKA-4119
> Project: Tika
> Issue Type: Improvement
> Components: mime
>Reporter: Matthias Juchmes
>Priority: Major
> Labels: tika-3x
>
> [RFC-9239|https://www.rfc-editor.org/rfc/rfc9239.html] obsoletes some
> javascript media types, including "application/javascript", which is
> currently returned by Tika for javascript files. "text/javascript" is defined
> as the most widely supported one, so Tika should reflect this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TIKA-4119) Return media type "text/javascript" instead of "application/javascript to follow RFC-9239
[ https://issues.apache.org/jira/browse/TIKA-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810098#comment-17810098 ] ASF GitHub Bot commented on TIKA-4119: -- tballison commented on code in PR #1556: URL: https://github.com/apache/tika/pull/1556#discussion_r1463958645 ## tika-core/src/test/java/org/apache/tika/mime/MimeTypesReaderTest.java: ## Review Comment: Y, same. > Return media type "text/javascript" instead of "application/javascript to > follow RFC-9239 > - > > Key: TIKA-4119 > URL: https://issues.apache.org/jira/browse/TIKA-4119 > Project: Tika > Issue Type: Improvement > Components: mime >Reporter: Matthias Juchmes >Priority: Major > Labels: tika-3x > > [RFC-9239|https://www.rfc-editor.org/rfc/rfc9239.html] obsoletes some > javascript media types, including "application/javascript", which is > currently returned by Tika for javascript files. "text/javascript" is defined > as the most widely supported one, so Tika should reflect this. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TIKA-4119) Return media type "text/javascript" instead of "application/javascript to follow RFC-9239
[ https://issues.apache.org/jira/browse/TIKA-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810105#comment-17810105 ] ASF GitHub Bot commented on TIKA-4119: -- tballison commented on PR #1556: URL: https://github.com/apache/tika/pull/1556#issuecomment-1906907783 ``` Failures: Error:TestMimeTypes.testCodeFormats:1151->assertTypeByName:1385 expected: but was: Error: TestMimeTypes.testTextBasedFormatsDetection:721->assertTypeByName:1385 expected: but was: ``` Doh Something went wrong in the tests. > Return media type "text/javascript" instead of "application/javascript to > follow RFC-9239 > - > > Key: TIKA-4119 > URL: https://issues.apache.org/jira/browse/TIKA-4119 > Project: Tika > Issue Type: Improvement > Components: mime >Reporter: Matthias Juchmes >Priority: Major > Labels: tika-3x > > [RFC-9239|https://www.rfc-editor.org/rfc/rfc9239.html] obsoletes some > javascript media types, including "application/javascript", which is > currently returned by Tika for javascript files. "text/javascript" is defined > as the most widely supported one, so Tika should reflect this. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TIKA-4119) Return media type "text/javascript" instead of "application/javascript to follow RFC-9239
[ https://issues.apache.org/jira/browse/TIKA-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810148#comment-17810148 ] ASF GitHub Bot commented on TIKA-4119: -- marcospereira commented on PR #1556: URL: https://github.com/apache/tika/pull/1556#issuecomment-1907174771 Alright, it should be good now. At least all the tests passed twice when running on my machine. :-) > Return media type "text/javascript" instead of "application/javascript to > follow RFC-9239 > - > > Key: TIKA-4119 > URL: https://issues.apache.org/jira/browse/TIKA-4119 > Project: Tika > Issue Type: Improvement > Components: mime >Reporter: Matthias Juchmes >Priority: Major > Labels: tika-3x > > [RFC-9239|https://www.rfc-editor.org/rfc/rfc9239.html] obsoletes some > javascript media types, including "application/javascript", which is > currently returned by Tika for javascript files. "text/javascript" is defined > as the most widely supported one, so Tika should reflect this. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TIKA-4119) Return media type "text/javascript" instead of "application/javascript to follow RFC-9239
[ https://issues.apache.org/jira/browse/TIKA-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810473#comment-17810473 ] ASF GitHub Bot commented on TIKA-4119: -- tballison commented on PR #1556: URL: https://github.com/apache/tika/pull/1556#issuecomment-1908421415 Thank you, @marcospereira ! > Return media type "text/javascript" instead of "application/javascript to > follow RFC-9239 > - > > Key: TIKA-4119 > URL: https://issues.apache.org/jira/browse/TIKA-4119 > Project: Tika > Issue Type: Improvement > Components: mime >Reporter: Matthias Juchmes >Priority: Major > Labels: tika-3x > > [RFC-9239|https://www.rfc-editor.org/rfc/rfc9239.html] obsoletes some > javascript media types, including "application/javascript", which is > currently returned by Tika for javascript files. "text/javascript" is defined > as the most widely supported one, so Tika should reflect this. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TIKA-4119) Return media type "text/javascript" instead of "application/javascript to follow RFC-9239
[ https://issues.apache.org/jira/browse/TIKA-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810471#comment-17810471 ] ASF GitHub Bot commented on TIKA-4119: -- tballison merged PR #1556: URL: https://github.com/apache/tika/pull/1556 > Return media type "text/javascript" instead of "application/javascript to > follow RFC-9239 > - > > Key: TIKA-4119 > URL: https://issues.apache.org/jira/browse/TIKA-4119 > Project: Tika > Issue Type: Improvement > Components: mime >Reporter: Matthias Juchmes >Priority: Major > Labels: tika-3x > > [RFC-9239|https://www.rfc-editor.org/rfc/rfc9239.html] obsoletes some > javascript media types, including "application/javascript", which is > currently returned by Tika for javascript files. "text/javascript" is defined > as the most widely supported one, so Tika should reflect this. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TIKA-4119) Return media type "text/javascript" instead of "application/javascript to follow RFC-9239
[ https://issues.apache.org/jira/browse/TIKA-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810514#comment-17810514 ] Hudson commented on TIKA-4119: -- SUCCESS: Integrated in Jenkins build Tika » tika-main-jdk11 #1478 (See [https://ci-builds.apache.org/job/Tika/job/tika-main-jdk11/1478/]) [TIKA-4119]: Return media type "text/javascript" instead of "application/javascript" to follow RFC-9239 (#1556) (github: [https://github.com/apache/tika/commit/ae737cd2625b5e2659c20c27713785df8bfc1957]) * (edit) tika-core/src/test/java/org/apache/tika/mime/MimeTypesReaderTest.java * (edit) CHANGES.txt * (edit) tika-core/src/main/resources/org/apache/tika/mime/tika-mimetypes.xml * (edit) tika-core/src/test/java/org/apache/tika/TikaDetectionTest.java * (edit) README.md * (edit) tika-parsers/tika-parsers-standard/tika-parsers-standard-package/src/test/java/org/apache/tika/mime/TestMimeTypes.java * (edit) tika-core/src/test/java/org/apache/tika/mime/ProbabilisticMimeDetectionTest.java > Return media type "text/javascript" instead of "application/javascript to > follow RFC-9239 > - > > Key: TIKA-4119 > URL: https://issues.apache.org/jira/browse/TIKA-4119 > Project: Tika > Issue Type: Improvement > Components: mime >Reporter: Matthias Juchmes >Priority: Major > Labels: tika-3x > > [RFC-9239|https://www.rfc-editor.org/rfc/rfc9239.html] obsoletes some > javascript media types, including "application/javascript", which is > currently returned by Tika for javascript files. "text/javascript" is defined > as the most widely supported one, so Tika should reflect this. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TIKA-4119) Return media type "text/javascript" instead of "application/javascript to follow RFC-9239
[ https://issues.apache.org/jira/browse/TIKA-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810555#comment-17810555 ] ASF GitHub Bot commented on TIKA-4119: -- marcospereira commented on PR #1556: URL: https://github.com/apache/tika/pull/1556#issuecomment-1908850994 > Thank you, @marcospereira ! Thank you, @tballison. I see https://issues.apache.org/jira/browse/TIKA-4119 is still marked as "open". Is there something I need to do on my end or is it just out of sync with the changes here? > Return media type "text/javascript" instead of "application/javascript to > follow RFC-9239 > - > > Key: TIKA-4119 > URL: https://issues.apache.org/jira/browse/TIKA-4119 > Project: Tika > Issue Type: Improvement > Components: mime >Reporter: Matthias Juchmes >Priority: Major > Labels: tika-3x > > [RFC-9239|https://www.rfc-editor.org/rfc/rfc9239.html] obsoletes some > javascript media types, including "application/javascript", which is > currently returned by Tika for javascript files. "text/javascript" is defined > as the most widely supported one, so Tika should reflect this. -- This message was sent by Atlassian Jira (v8.20.10#820010)
