RE: import (re)ordering?
Y, I'll try to be more careful about separating out formatting from content in the future (apologies for TIKA-1451). What I didn't want to do was start an IDE war if others have different settings that will order imports in a different way. Thank you! -Original Message- From: Mattmann, Chris A (3980) [mailto:chris.a.mattm...@jpl.nasa.gov] Sent: Friday, October 24, 2014 1:53 AM To: dev@tika.apache.org Subject: Re: import (re)ordering? Hey Tim, No big objections from me, but it will dilute things so glad we have it noted if it happens. Cheers, Chris ++ Chris Mattmann, Ph.D. Chief Architect Instrument Software and Science Data Systems Section (398) NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA Office: 168-519, Mailstop: 168-527 Email: chris.a.mattm...@nasa.gov WWW: http://sunset.usc.edu/~mattmann/ ++ Adjunct Associate Professor, Computer Science Department University of Southern California, Los Angeles, CA 90089 USA ++ -Original Message- From: Allison, Timothy B. talli...@mitre.org Reply-To: dev@tika.apache.org dev@tika.apache.org Date: Tuesday, October 21, 2014 at 1:59 PM To: dev@tika.apache.org dev@tika.apache.org Subject: import (re)ordering? All, I have Intellij set to order imports by javax, java, then other. I think this is the most common pattern in Tika. Is it ok if I make these (meaningless/formatting) changes when I commit other changes? Thank you. Best, Tim
RE: import (re)ordering?
Thanks, Tim. I'll be sure to update my settings for this. On a similar note, can we standardize the formatting of the pom.xml files? Right now, they are pretty irregular. Tyler On Oct 24, 2014 10:52 AM, Allison, Timothy B. talli...@mitre.org wrote: Y, I'll try to be more careful about separating out formatting from content in the future (apologies for TIKA-1451). What I didn't want to do was start an IDE war if others have different settings that will order imports in a different way. Thank you! -Original Message- From: Mattmann, Chris A (3980) [mailto:chris.a.mattm...@jpl.nasa.gov] Sent: Friday, October 24, 2014 1:53 AM To: dev@tika.apache.org Subject: Re: import (re)ordering? Hey Tim, No big objections from me, but it will dilute things so glad we have it noted if it happens. Cheers, Chris ++ Chris Mattmann, Ph.D. Chief Architect Instrument Software and Science Data Systems Section (398) NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA Office: 168-519, Mailstop: 168-527 Email: chris.a.mattm...@nasa.gov WWW: http://sunset.usc.edu/~mattmann/ ++ Adjunct Associate Professor, Computer Science Department University of Southern California, Los Angeles, CA 90089 USA ++ -Original Message- From: Allison, Timothy B. talli...@mitre.org Reply-To: dev@tika.apache.org dev@tika.apache.org Date: Tuesday, October 21, 2014 at 1:59 PM To: dev@tika.apache.org dev@tika.apache.org Subject: import (re)ordering? All, I have Intellij set to order imports by javax, java, then other. I think this is the most common pattern in Tika. Is it ok if I make these (meaningless/formatting) changes when I commit other changes? Thank you. Best, Tim
RE: import (re)ordering?
On Fri, 24 Oct 2014, Allison, Timothy B. wrote: Y, I'll try to be more careful about separating out formatting from content in the future (apologies for TIKA-1451). What I didn't want to do was start an IDE war if others have different settings that will order imports in a different way. I'd say just pick something sensible, and then document it for everyone in http://tika.apache.org/contribute.html so it's clear what to do! Nick
Re: import (re)ordering?
Hey Tim, No big objections from me, but it will dilute things so glad we have it noted if it happens. Cheers, Chris ++ Chris Mattmann, Ph.D. Chief Architect Instrument Software and Science Data Systems Section (398) NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA Office: 168-519, Mailstop: 168-527 Email: chris.a.mattm...@nasa.gov WWW: http://sunset.usc.edu/~mattmann/ ++ Adjunct Associate Professor, Computer Science Department University of Southern California, Los Angeles, CA 90089 USA ++ -Original Message- From: Allison, Timothy B. talli...@mitre.org Reply-To: dev@tika.apache.org dev@tika.apache.org Date: Tuesday, October 21, 2014 at 1:59 PM To: dev@tika.apache.org dev@tika.apache.org Subject: import (re)ordering? All, I have Intellij set to order imports by javax, java, then other. I think this is the most common pattern in Tika. Is it ok if I make these (meaningless/formatting) changes when I commit other changes? Thank you. Best, Tim
Re: import (re)ordering?
On Tue, 21 Oct 2014, Allison, Timothy B. wrote: I have Intellij set to order imports by javax, java, then other. I think this is the most common pattern in Tika. Is it ok if I make these (meaningless/formatting) changes when I commit other changes? The only downside of this is that the top of the commit message is then all noise, so it's less likely that people will end up skipping the review of the meat of the commit It's not always possible, but where you can, it's generally best to split up tidy up / formatting commits (whitespace, imports, formatting etc) ones from ones that touch functionality. Cheers Nick
