Re: Review Request 27414: GRIB Parser for TIKA

2014-11-03 Thread Vineet Ghatge Hemantkumar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27414/
---

(Updated Nov. 4, 2014, 5:48 a.m.)


Review request for tika, Lewis McGibbney, Chris Mattmann, and Tyler Palsulich.


Bugs: tika-1423
https://issues.apache.org/jira/browse/tika-1423


Repository: tika


Description
---

GRIB Parser Patch


Diffs
-

  trunk/tika-parsers/pom.xml 1635045 

Diff: https://reviews.apache.org/r/27414/diff/


Testing
---

To test the parser in place
1. Download the patch and three file - GribParserTest.java, GribParser.java and 
gdas.forecmwf
2. Put the GribParser.java in the following folder - 
tika-parsers/src/main/java/org/apache/tika/parser/grib. You will need to have 
folder named grib here
3. Put the GribParserTest.java in the following folder - 
tika-parsers/src/test/java/org/apache/tika/parser/grib
4. Put the resource file in the following location - 
tika-parsers/src/test/resources/test-documents/
5. Apply the patch and build.


File Attachments


ParserTestFile
  
https://reviews.apache.org/media/uploaded/files/2014/10/31/840fcf4b-d67f-4ed5-8e7c-52d49c74c9d0__GribParserTest.java
GribParser
  
https://reviews.apache.org/media/uploaded/files/2014/10/31/2f897768-d61e-4985-a254-4a45fc821524__GribParser.java
Resource file
  
https://reviews.apache.org/media/uploaded/files/2014/10/31/a47d7101-98d7-4833-94f3-cdf31351e19e__gdas1.forecmwf.2014062612.grib2


Thanks,

Vineet Ghatge Hemantkumar

Re: Review Request 27414: GRIB Parser for TIKA

2014-11-03 Thread Vineet Ghatge Hemantkumar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27414/
---

(Updated Nov. 4, 2014, 5:36 a.m.)


Review request for tika, Lewis McGibbney, Chris Mattmann, and Tyler Palsulich.


Bugs: tika-1423
https://issues.apache.org/jira/browse/tika-1423


Repository: tika


Description
---

GRIB Parser Patch


Diffs
-

  trunk/tika-parsers/pom.xml 1635045 

Diff: https://reviews.apache.org/r/27414/diff/


Testing
---

To test the parser in place
1. Download the patch and three file - GribParserTest.java, GribParser.java and 
gdas.forecmwf
2. Put the GribParser.java in the following folder - 
tika-parsers/src/main/java/org/apache/tika/parser/grib. You will need to have 
folder named grib here
3. Put the GribParserTest.java in the following folder - 
tika-parsers/src/test/java/org/apache/tika/parser/grib
4. Put the resource file in the following location - 
tika-parsers/src/test/resources/test-documents/
5. Apply the patch and build.


File Attachments


ParserTestFile
  
https://reviews.apache.org/media/uploaded/files/2014/10/31/840fcf4b-d67f-4ed5-8e7c-52d49c74c9d0__GribParserTest.java
GribParser
  
https://reviews.apache.org/media/uploaded/files/2014/10/31/2f897768-d61e-4985-a254-4a45fc821524__GribParser.java
Resource file
  
https://reviews.apache.org/media/uploaded/files/2014/10/31/a47d7101-98d7-4833-94f3-cdf31351e19e__gdas1.forecmwf.2014062612.grib2


Thanks,

Vineet Ghatge Hemantkumar

Re: Review Request 27414: GRIB Parser for TIKA

2014-11-03 Thread Vineet Ghatge Hemantkumar 


> On Nov. 2, 2014, 3:01 a.m., Chris Mattmann wrote:
> > trunk/tika-parsers/pom.xml, line 84
> > 
> >
> > shouldn't this replace the above dependency

I am not sure if there are components to which depend on it. I know that netcdf 
still depends on the old version of the jar


- Vineet Ghatge


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27414/#review59513
---


On Nov. 2, 2014, 3:17 p.m., Vineet Ghatge Hemantkumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27414/
> ---
> 
> (Updated Nov. 2, 2014, 3:17 p.m.)
> 
> 
> Review request for tika, Lewis McGibbney, Chris Mattmann, and Tyler Palsulich.
> 
> 
> Bugs: tika-1423
> https://issues.apache.org/jira/browse/tika-1423
> 
> 
> Repository: tika
> 
> 
> Description
> ---
> 
> GRIB Parser Patch
> 
> 
> Diffs
> -
> 
>   trunk/tika-parsers/pom.xml 1635045 
> 
> Diff: https://reviews.apache.org/r/27414/diff/
> 
> 
> Testing
> ---
> 
> To test the parser in place
> 1. Download the patch and three file - GribParserTest.java, GribParser.java 
> and gdas.forecmwf
> 2. Put the GribParser.java in the following folder - 
> tika-parsers/src/main/java/org/apache/tika/parser/grib. You will need to have 
> folder named grib here
> 3. Put the GribParserTest.java in the following folder - 
> tika-parsers/src/test/java/org/apache/tika/parser/grib
> 4. Put the resource file in the following location - 
> tika-parsers/src/test/resources/test-documents/
> 5. Apply the patch and build.
> 
> 
> File Attachments
> 
> 
> ParserTestFile
>   
> https://reviews.apache.org/media/uploaded/files/2014/10/31/840fcf4b-d67f-4ed5-8e7c-52d49c74c9d0__GribParserTest.java
> GribParser
>   
> https://reviews.apache.org/media/uploaded/files/2014/10/31/2f897768-d61e-4985-a254-4a45fc821524__GribParser.java
> Resource file
>   
> https://reviews.apache.org/media/uploaded/files/2014/10/31/a47d7101-98d7-4833-94f3-cdf31351e19e__gdas1.forecmwf.2014062612.grib2
> 
> 
> Thanks,
> 
> Vineet Ghatge Hemantkumar
> 
>

Re: Review Request 27414: GRIB Parser for TIKA

2014-11-03 Thread Vineet Ghatge Hemantkumar 


> On Oct. 31, 2014, 3:22 p.m., Lewis McGibbney wrote:
> > File Attachment: GribParser - GribParser.java
> > 
> >
> > Formatting and TikaException message is not correct. I would suggest 
> > that we stick to GRIB parse error.
> > Additionally, I don't know if it is wise for us to have such a long try 
> > catch scenario!

Added multiple try catch for different sections


> On Oct. 31, 2014, 3:22 p.m., Lewis McGibbney wrote:
> > File Attachment: GribParser - GribParser.java
> > 
> >
> > Of courser this is not 100% correct as in this case the underlying 
> > library is being used to parse GRIB2 files... correct?

Corrected the links and yes we are using to parse grib2 files


- Vineet Ghatge


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27414/#review59346
---


On Nov. 2, 2014, 3:17 p.m., Vineet Ghatge Hemantkumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27414/
> ---
> 
> (Updated Nov. 2, 2014, 3:17 p.m.)
> 
> 
> Review request for tika, Lewis McGibbney, Chris Mattmann, and Tyler Palsulich.
> 
> 
> Bugs: tika-1423
> https://issues.apache.org/jira/browse/tika-1423
> 
> 
> Repository: tika
> 
> 
> Description
> ---
> 
> GRIB Parser Patch
> 
> 
> Diffs
> -
> 
>   trunk/tika-parsers/pom.xml 1635045 
> 
> Diff: https://reviews.apache.org/r/27414/diff/
> 
> 
> Testing
> ---
> 
> To test the parser in place
> 1. Download the patch and three file - GribParserTest.java, GribParser.java 
> and gdas.forecmwf
> 2. Put the GribParser.java in the following folder - 
> tika-parsers/src/main/java/org/apache/tika/parser/grib. You will need to have 
> folder named grib here
> 3. Put the GribParserTest.java in the following folder - 
> tika-parsers/src/test/java/org/apache/tika/parser/grib
> 4. Put the resource file in the following location - 
> tika-parsers/src/test/resources/test-documents/
> 5. Apply the patch and build.
> 
> 
> File Attachments
> 
> 
> ParserTestFile
>   
> https://reviews.apache.org/media/uploaded/files/2014/10/31/840fcf4b-d67f-4ed5-8e7c-52d49c74c9d0__GribParserTest.java
> GribParser
>   
> https://reviews.apache.org/media/uploaded/files/2014/10/31/2f897768-d61e-4985-a254-4a45fc821524__GribParser.java
> Resource file
>   
> https://reviews.apache.org/media/uploaded/files/2014/10/31/a47d7101-98d7-4833-94f3-cdf31351e19e__gdas1.forecmwf.2014062612.grib2
> 
> 
> Thanks,
> 
> Vineet Ghatge Hemantkumar
> 
>

Re: Review Request 27414: GRIB Parser for TIKA

2014-11-03 Thread Vineet Ghatge Hemantkumar 


> On Nov. 2, 2014, 5:39 p.m., Tyler Palsulich wrote:
> > File Attachment: GribParser - GribParser.java
> > 
> >
> > Need a corresponding `xhtml.endElement("ul");`.

Corrected!


- Vineet Ghatge


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27414/#review59526
---


On Nov. 2, 2014, 3:17 p.m., Vineet Ghatge Hemantkumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27414/
> ---
> 
> (Updated Nov. 2, 2014, 3:17 p.m.)
> 
> 
> Review request for tika, Lewis McGibbney, Chris Mattmann, and Tyler Palsulich.
> 
> 
> Bugs: tika-1423
> https://issues.apache.org/jira/browse/tika-1423
> 
> 
> Repository: tika
> 
> 
> Description
> ---
> 
> GRIB Parser Patch
> 
> 
> Diffs
> -
> 
>   trunk/tika-parsers/pom.xml 1635045 
> 
> Diff: https://reviews.apache.org/r/27414/diff/
> 
> 
> Testing
> ---
> 
> To test the parser in place
> 1. Download the patch and three file - GribParserTest.java, GribParser.java 
> and gdas.forecmwf
> 2. Put the GribParser.java in the following folder - 
> tika-parsers/src/main/java/org/apache/tika/parser/grib. You will need to have 
> folder named grib here
> 3. Put the GribParserTest.java in the following folder - 
> tika-parsers/src/test/java/org/apache/tika/parser/grib
> 4. Put the resource file in the following location - 
> tika-parsers/src/test/resources/test-documents/
> 5. Apply the patch and build.
> 
> 
> File Attachments
> 
> 
> ParserTestFile
>   
> https://reviews.apache.org/media/uploaded/files/2014/10/31/840fcf4b-d67f-4ed5-8e7c-52d49c74c9d0__GribParserTest.java
> GribParser
>   
> https://reviews.apache.org/media/uploaded/files/2014/10/31/2f897768-d61e-4985-a254-4a45fc821524__GribParser.java
> Resource file
>   
> https://reviews.apache.org/media/uploaded/files/2014/10/31/a47d7101-98d7-4833-94f3-cdf31351e19e__gdas1.forecmwf.2014062612.grib2
> 
> 
> Thanks,
> 
> Vineet Ghatge Hemantkumar
> 
>

Re: Review Request 27414: GRIB Parser for TIKA

2014-11-03 Thread Vineet Ghatge Hemantkumar 


> On Nov. 2, 2014, 5:39 p.m., Tyler Palsulich wrote:
> > File Attachment: GribParser - GribParser.java
> > 
> >
> > Need a corresponding `xhtml.endElement("ul");`.

Corrected!


- Vineet Ghatge


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27414/#review59526
---


On Nov. 2, 2014, 3:17 p.m., Vineet Ghatge Hemantkumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27414/
> ---
> 
> (Updated Nov. 2, 2014, 3:17 p.m.)
> 
> 
> Review request for tika, Lewis McGibbney, Chris Mattmann, and Tyler Palsulich.
> 
> 
> Bugs: tika-1423
> https://issues.apache.org/jira/browse/tika-1423
> 
> 
> Repository: tika
> 
> 
> Description
> ---
> 
> GRIB Parser Patch
> 
> 
> Diffs
> -
> 
>   trunk/tika-parsers/pom.xml 1635045 
> 
> Diff: https://reviews.apache.org/r/27414/diff/
> 
> 
> Testing
> ---
> 
> To test the parser in place
> 1. Download the patch and three file - GribParserTest.java, GribParser.java 
> and gdas.forecmwf
> 2. Put the GribParser.java in the following folder - 
> tika-parsers/src/main/java/org/apache/tika/parser/grib. You will need to have 
> folder named grib here
> 3. Put the GribParserTest.java in the following folder - 
> tika-parsers/src/test/java/org/apache/tika/parser/grib
> 4. Put the resource file in the following location - 
> tika-parsers/src/test/resources/test-documents/
> 5. Apply the patch and build.
> 
> 
> File Attachments
> 
> 
> ParserTestFile
>   
> https://reviews.apache.org/media/uploaded/files/2014/10/31/840fcf4b-d67f-4ed5-8e7c-52d49c74c9d0__GribParserTest.java
> GribParser
>   
> https://reviews.apache.org/media/uploaded/files/2014/10/31/2f897768-d61e-4985-a254-4a45fc821524__GribParser.java
> Resource file
>   
> https://reviews.apache.org/media/uploaded/files/2014/10/31/a47d7101-98d7-4833-94f3-cdf31351e19e__gdas1.forecmwf.2014062612.grib2
> 
> 
> Thanks,
> 
> Vineet Ghatge Hemantkumar
> 
>

Re: Review Request 27414: GRIB Parser for TIKA

2014-11-03 Thread Lewis McGibbney 


> On Oct. 31, 2014, 3:22 p.m., Lewis McGibbney wrote:
> > File Attachment: GribParser - GribParser.java
> > 
> >
> > Is this always available? What happens if we read an InputStream and 
> > not a File? Can we still populate Metadata.RESOURCE_NAME_KEY?
> 
> Tyler Palsulich wrote:
> I think a better solution would be to create a TikaInputStream, then grab 
> a temporary file from that. See TikaInputStream#get(InputStream, 
> TemporaryResources) and TikaInputStream#getFile(). Then the Parser won't be 
> dependent on a Metadata field.

+1 Tyler


- Lewis


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27414/#review59346
---


On Nov. 2, 2014, 3:17 p.m., Vineet Ghatge Hemantkumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27414/
> ---
> 
> (Updated Nov. 2, 2014, 3:17 p.m.)
> 
> 
> Review request for tika, Lewis McGibbney, Chris Mattmann, and Tyler Palsulich.
> 
> 
> Bugs: tika-1423
> https://issues.apache.org/jira/browse/tika-1423
> 
> 
> Repository: tika
> 
> 
> Description
> ---
> 
> GRIB Parser Patch
> 
> 
> Diffs
> -
> 
>   trunk/tika-parsers/pom.xml 1635045 
> 
> Diff: https://reviews.apache.org/r/27414/diff/
> 
> 
> Testing
> ---
> 
> To test the parser in place
> 1. Download the patch and three file - GribParserTest.java, GribParser.java 
> and gdas.forecmwf
> 2. Put the GribParser.java in the following folder - 
> tika-parsers/src/main/java/org/apache/tika/parser/grib. You will need to have 
> folder named grib here
> 3. Put the GribParserTest.java in the following folder - 
> tika-parsers/src/test/java/org/apache/tika/parser/grib
> 4. Put the resource file in the following location - 
> tika-parsers/src/test/resources/test-documents/
> 5. Apply the patch and build.
> 
> 
> File Attachments
> 
> 
> ParserTestFile
>   
> https://reviews.apache.org/media/uploaded/files/2014/10/31/840fcf4b-d67f-4ed5-8e7c-52d49c74c9d0__GribParserTest.java
> GribParser
>   
> https://reviews.apache.org/media/uploaded/files/2014/10/31/2f897768-d61e-4985-a254-4a45fc821524__GribParser.java
> Resource file
>   
> https://reviews.apache.org/media/uploaded/files/2014/10/31/a47d7101-98d7-4833-94f3-cdf31351e19e__gdas1.forecmwf.2014062612.grib2
> 
> 
> Thanks,
> 
> Vineet Ghatge Hemantkumar
> 
>

Re: Review Request 27414: GRIB Parser for TIKA

2014-11-02 Thread Tyler Palsulich 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27414/#review59526
---



File Attachment: GribParser - GribParser.java


Need a corresponding `xhtml.endElement("ul");`.



File Attachment: GribParser - GribParser.java


Need a corresponding `xhtml.endElement("ul");`.



File Attachment: GribParser - GribParser.java


Optional style comment: Can do a foreach loop.


- Tyler Palsulich


On Nov. 2, 2014, 3:17 p.m., Vineet Ghatge Hemantkumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27414/
> ---
> 
> (Updated Nov. 2, 2014, 3:17 p.m.)
> 
> 
> Review request for tika, Lewis McGibbney, Chris Mattmann, and Tyler Palsulich.
> 
> 
> Bugs: tika-1423
> https://issues.apache.org/jira/browse/tika-1423
> 
> 
> Repository: tika
> 
> 
> Description
> ---
> 
> GRIB Parser Patch
> 
> 
> Diffs
> -
> 
>   trunk/tika-parsers/pom.xml 1635045 
> 
> Diff: https://reviews.apache.org/r/27414/diff/
> 
> 
> Testing
> ---
> 
> To test the parser in place
> 1. Download the patch and three file - GribParserTest.java, GribParser.java 
> and gdas.forecmwf
> 2. Put the GribParser.java in the following folder - 
> tika-parsers/src/main/java/org/apache/tika/parser/grib. You will need to have 
> folder named grib here
> 3. Put the GribParserTest.java in the following folder - 
> tika-parsers/src/test/java/org/apache/tika/parser/grib
> 4. Put the resource file in the following location - 
> tika-parsers/src/test/resources/test-documents/
> 5. Apply the patch and build.
> 
> 
> File Attachments
> 
> 
> ParserTestFile
>   
> https://reviews.apache.org/media/uploaded/files/2014/10/31/840fcf4b-d67f-4ed5-8e7c-52d49c74c9d0__GribParserTest.java
> GribParser
>   
> https://reviews.apache.org/media/uploaded/files/2014/10/31/2f897768-d61e-4985-a254-4a45fc821524__GribParser.java
> Resource file
>   
> https://reviews.apache.org/media/uploaded/files/2014/10/31/a47d7101-98d7-4833-94f3-cdf31351e19e__gdas1.forecmwf.2014062612.grib2
> 
> 
> Thanks,
> 
> Vineet Ghatge Hemantkumar
> 
>

Re: Review Request 27414: GRIB Parser for TIKA

2014-11-02 Thread Tyler Palsulich 


> On Oct. 31, 2014, 3:22 p.m., Lewis McGibbney wrote:
> > File Attachment: GribParser - GribParser.java
> > 
> >
> > Is this always available? What happens if we read an InputStream and 
> > not a File? Can we still populate Metadata.RESOURCE_NAME_KEY?

I think a better solution would be to create a TikaInputStream, then grab a 
temporary file from that. See TikaInputStream#get(InputStream, 
TemporaryResources) and TikaInputStream#getFile(). Then the Parser won't be 
dependent on a Metadata field.


- Tyler


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27414/#review59346
---


On Nov. 2, 2014, 3:17 p.m., Vineet Ghatge Hemantkumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27414/
> ---
> 
> (Updated Nov. 2, 2014, 3:17 p.m.)
> 
> 
> Review request for tika, Lewis McGibbney, Chris Mattmann, and Tyler Palsulich.
> 
> 
> Bugs: tika-1423
> https://issues.apache.org/jira/browse/tika-1423
> 
> 
> Repository: tika
> 
> 
> Description
> ---
> 
> GRIB Parser Patch
> 
> 
> Diffs
> -
> 
>   trunk/tika-parsers/pom.xml 1635045 
> 
> Diff: https://reviews.apache.org/r/27414/diff/
> 
> 
> Testing
> ---
> 
> To test the parser in place
> 1. Download the patch and three file - GribParserTest.java, GribParser.java 
> and gdas.forecmwf
> 2. Put the GribParser.java in the following folder - 
> tika-parsers/src/main/java/org/apache/tika/parser/grib. You will need to have 
> folder named grib here
> 3. Put the GribParserTest.java in the following folder - 
> tika-parsers/src/test/java/org/apache/tika/parser/grib
> 4. Put the resource file in the following location - 
> tika-parsers/src/test/resources/test-documents/
> 5. Apply the patch and build.
> 
> 
> File Attachments
> 
> 
> ParserTestFile
>   
> https://reviews.apache.org/media/uploaded/files/2014/10/31/840fcf4b-d67f-4ed5-8e7c-52d49c74c9d0__GribParserTest.java
> GribParser
>   
> https://reviews.apache.org/media/uploaded/files/2014/10/31/2f897768-d61e-4985-a254-4a45fc821524__GribParser.java
> Resource file
>   
> https://reviews.apache.org/media/uploaded/files/2014/10/31/a47d7101-98d7-4833-94f3-cdf31351e19e__gdas1.forecmwf.2014062612.grib2
> 
> 
> Thanks,
> 
> Vineet Ghatge Hemantkumar
> 
>

Re: Review Request 27414: GRIB Parser for TIKA

2014-11-02 Thread Vineet Ghatge Hemantkumar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27414/
---

(Updated Nov. 2, 2014, 3:17 p.m.)


Review request for tika, Lewis McGibbney, Chris Mattmann, and Tyler Palsulich.


Bugs: tika-1423
https://issues.apache.org/jira/browse/tika-1423


Repository: tika


Description
---

GRIB Parser Patch


Diffs
-

  trunk/tika-parsers/pom.xml 1635045 

Diff: https://reviews.apache.org/r/27414/diff/


Testing
---

To test the parser in place
1. Download the patch and three file - GribParserTest.java, GribParser.java and 
gdas.forecmwf
2. Put the GribParser.java in the following folder - 
tika-parsers/src/main/java/org/apache/tika/parser/grib. You will need to have 
folder named grib here
3. Put the GribParserTest.java in the following folder - 
tika-parsers/src/test/java/org/apache/tika/parser/grib
4. Put the resource file in the following location - 
tika-parsers/src/test/resources/test-documents/
5. Apply the patch and build.


File Attachments


ParserTestFile
  
https://reviews.apache.org/media/uploaded/files/2014/10/31/840fcf4b-d67f-4ed5-8e7c-52d49c74c9d0__GribParserTest.java
GribParser
  
https://reviews.apache.org/media/uploaded/files/2014/10/31/2f897768-d61e-4985-a254-4a45fc821524__GribParser.java
Resource file
  
https://reviews.apache.org/media/uploaded/files/2014/10/31/a47d7101-98d7-4833-94f3-cdf31351e19e__gdas1.forecmwf.2014062612.grib2


Thanks,

Vineet Ghatge Hemantkumar