[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427434#comment-15427434
 ] 

ASF GitHub Bot commented on TINKERPOP-1037:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/384
  
I think a mockup of the desired coloring effect would be nice to have.  
Currently elements just have toString called on them. I added a vertex.color 
and edge.color for demonstration purposes. Here's what it would look like. Let 
me know if that's worth committing.

![screenshot_2016-08-18_21-00-22](https://cloud.githubusercontent.com/assets/122206/17795525/12511530-6587-11e6-8427-71d6e033a026.png)



> Gremlin shell output coloring
> -
>
> Key: TINKERPOP-1037
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1037
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.1.0-incubating
>Reporter: Jeremy Hanna
>Priority: Trivial
>
> In order to increase the readability of the output from the gremlin shell, it 
> would be nice to have some coloring in the output.  For example coloring the 
> edges in the textual output.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/384
  
I think a mockup of the desired coloring effect would be nice to have.  
Currently elements just have toString called on them. I added a vertex.color 
and edge.color for demonstration purposes. Here's what it would look like. Let 
me know if that's worth committing.

![screenshot_2016-08-18_21-00-22](https://cloud.githubusercontent.com/assets/122206/17795525/12511530-6587-11e6-8427-71d6e033a026.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427342#comment-15427342
 ] 

ASF GitHub Bot commented on TINKERPOP-1037:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/384
  
nice @robertdale - a final request from my end would be documentation. 
perhaps a word or two added to the docs about these settings. I guess the 
reference docs might be the best place for that:


https://github.com/apache/tinkerpop/blob/f35f733663029701af538fc527e1f5ab563eb07d/docs/src/reference/gremlin-applications.asciidoc#console-commands

then maybe an announcement of the feature in upgrade docs for users:


https://github.com/apache/tinkerpop/blob/f35f733663029701af538fc527e1f5ab563eb07d/docs/src/upgrade/release-3.2.x-incubating.asciidoc#upgrading-for-users

and if you want to really be complete an entry in changelog:


https://github.com/apache/tinkerpop/blob/f35f733663029701af538fc527e1f5ab563eb07d/CHANGELOG.asciidoc#tinkerpop-322-not-officially-released-yet

@dkuppitz brought up the full scope of the ticket, but i think we can save 
the bigger picture for some other time. at least the pattern for colors is in 
place and working.

I still haven't tested this out myself or reviewed the code just yet to see 
what you did differently than me to get this to work. My mind is still kinda 
reeling from that.  :disappointed: 



> Gremlin shell output coloring
> -
>
> Key: TINKERPOP-1037
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1037
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.1.0-incubating
>Reporter: Jeremy Hanna
>Priority: Trivial
>
> In order to increase the readability of the output from the gremlin shell, it 
> would be nice to have some coloring in the output.  For example coloring the 
> edges in the textual output.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful

[spmallette]

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/384
  
nice @robertdale - a final request from my end would be documentation. 
perhaps a word or two added to the docs about these settings. I guess the 
reference docs might be the best place for that:


https://github.com/apache/tinkerpop/blob/f35f733663029701af538fc527e1f5ab563eb07d/docs/src/reference/gremlin-applications.asciidoc#console-commands

then maybe an announcement of the feature in upgrade docs for users:


https://github.com/apache/tinkerpop/blob/f35f733663029701af538fc527e1f5ab563eb07d/docs/src/upgrade/release-3.2.x-incubating.asciidoc#upgrading-for-users

and if you want to really be complete an entry in changelog:


https://github.com/apache/tinkerpop/blob/f35f733663029701af538fc527e1f5ab563eb07d/CHANGELOG.asciidoc#tinkerpop-322-not-officially-released-yet

@dkuppitz brought up the full scope of the ticket, but i think we can save 
the bigger picture for some other time. at least the pattern for colors is in 
place and working.

I still haven't tested this out myself or reviewed the code just yet to see 
what you did differently than me to get this to work. My mind is still kinda 
reeling from that.  :disappointed: 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427326#comment-15427326
 ] 

ASF GitHub Bot commented on TINKERPOP-1037:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/384
  

![screenshot_2016-08-18_18-54-19](https://cloud.githubusercontent.com/assets/122206/17793465/77a45b16-6575-11e6-99ce-bef4bb1471af.png)

## Color codes:
-BLACK
- RED
- GREEN
- YELLOW
- BLUE
- MAGENTA
- CYAN
- WHITE

### Background Colors
- BG_BLACK
- BG_RED
- BG_GREEN
- BG_YELLOW
- BG_BLUE
- BG_MAGENTA
- BG_CYAN
- BG_WHITE

### Attributes
- RESET
- INTENSITY_BOLD
- INTENSITY_FAINT
- ITALIC
- UNDERLINE
- BLINK_SLOW
- BLINK_FAST
- BLINK_OFF
- NEGATIVE_ON
- NEGATIVE_OFF
- CONCEAL_ON
- CONCEAL_OFF
- UNDERLINE_DOUBLE
- UNDERLINE_OFF
- BOLD
- FAINT



> Gremlin shell output coloring
> -
>
> Key: TINKERPOP-1037
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1037
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.1.0-incubating
>Reporter: Jeremy Hanna
>Priority: Trivial
>
> In order to increase the readability of the output from the gremlin shell, it 
> would be nice to have some coloring in the output.  For example coloring the 
> edges in the textual output.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/384
  

![screenshot_2016-08-18_18-54-19](https://cloud.githubusercontent.com/assets/122206/17793465/77a45b16-6575-11e6-99ce-bef4bb1471af.png)

## Color codes:
-BLACK
- RED
- GREEN
- YELLOW
- BLUE
- MAGENTA
- CYAN
- WHITE

### Background Colors
- BG_BLACK
- BG_RED
- BG_GREEN
- BG_YELLOW
- BG_BLUE
- BG_MAGENTA
- BG_CYAN
- BG_WHITE

### Attributes
- RESET
- INTENSITY_BOLD
- INTENSITY_FAINT
- ITALIC
- UNDERLINE
- BLINK_SLOW
- BLINK_FAST
- BLINK_OFF
- NEGATIVE_ON
- NEGATIVE_OFF
- CONCEAL_ON
- CONCEAL_OFF
- UNDERLINE_DOUBLE
- UNDERLINE_OFF
- BOLD
- FAINT



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful

[okram]

Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/384
  
+1 for `:set`. Look at our other `sets` to get a consistent naming 
convention, please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427097#comment-15427097
 ] 

ASF GitHub Bot commented on TINKERPOP-1037:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/384
  
+1 for use of `:set`


> Gremlin shell output coloring
> -
>
> Key: TINKERPOP-1037
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1037
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.1.0-incubating
>Reporter: Jeremy Hanna
>Priority: Trivial
>
> In order to increase the readability of the output from the gremlin shell, it 
> would be nice to have some coloring in the output.  For example coloring the 
> edges in the textual output.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427079#comment-15427079
 ] 

ASF GitHub Bot commented on TINKERPOP-1037:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/384
  
There are some things that are out of our control because they are 
inherited from groovy.


> Gremlin shell output coloring
> -
>
> Key: TINKERPOP-1037
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1037
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.1.0-incubating
>Reporter: Jeremy Hanna
>Priority: Trivial
>
> In order to increase the readability of the output from the gremlin shell, it 
> would be nice to have some coloring in the output.  For example coloring the 
> edges in the textual output.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427088#comment-15427088
 ] 

ASF GitHub Bot commented on TINKERPOP-1037:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/384
  
Would you really want a separate preferences (properties) file or rather 
reuse the existing preferences mechanism (:set gremlin.console.errorMessage 
red) ?


> Gremlin shell output coloring
> -
>
> Key: TINKERPOP-1037
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1037
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.1.0-incubating
>Reporter: Jeremy Hanna
>Priority: Trivial
>
> In order to increase the readability of the output from the gremlin shell, it 
> would be nice to have some coloring in the output.  For example coloring the 
> edges in the textual output.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/384
  
Would you really want a separate preferences (properties) file or rather 
reuse the existing preferences mechanism (:set gremlin.console.errorMessage 
red) ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/384
  
There are some things that are out of our control because they are 
inherited from groovy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #385: TINKERPOP-1285 added multi-line line number sup...

[robertdale]

GitHub user robertdale opened a pull request:

https://github.com/apache/tinkerpop/pull/385

TINKERPOP-1285 added multi-line line number support

Looks like:
```
gremlin> 
gremlin> 1 +
001   2 +
002   3 +
003   x
No such property: x for class: groovysh_evaluate
Display stack trace? [yN] 
003   4
==>10
```
Note that the line number remained the same for the correction.

Example from the jira ticket:
```
gremlin> script = """line1
001   line2
002   line3
003   ...
004   """
==>line1
line2
line3
...

gremlin> 
```

Multi-line query:
```
gremlin> 
gremlin> g.V().has(
001   'name',
002   'marko')
==>v[1]
gremlin> 
```

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/robertdale/tinkerpop TINKERPOP-1285

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/385.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #385


commit 96537e40844731ad7efd0e513fac15b13dae16d7
Author: Robert Dale 
Date:   2016-08-18T19:18:31Z

added multi-line line number support




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426998#comment-15426998
 ] 

ASF GitHub Bot commented on TINKERPOP-1037:
---

Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/384
  
Whoa. This is really cool. However, I think we should have a 
`.gremlin_preferences` style file where we do this:

```
gremlin.console.errorMessage=red
gremlin.console.prompt=white
gremlin.console.character=green
etc.
```

Then people can tweak to their liking and if they don't like it, they can 
go NOT have that file and it will be as it was before.



> Gremlin shell output coloring
> -
>
> Key: TINKERPOP-1037
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1037
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.1.0-incubating
>Reporter: Jeremy Hanna
>Priority: Trivial
>
> In order to increase the readability of the output from the gremlin shell, it 
> would be nice to have some coloring in the output.  For example coloring the 
> edges in the textual output.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful

[okram]

Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/384
  
Whoa. This is really cool. However, I think we should have a 
`.gremlin_preferences` style file where we do this:

```
gremlin.console.errorMessage=red
gremlin.console.prompt=white
gremlin.console.character=green
etc.
```

Then people can tweak to their liking and if they don't like it, they can 
go NOT have that file and it will be as it was before.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426993#comment-15426993
 ] 

ASF GitHub Bot commented on TINKERPOP-1037:
---

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/384
  
Hm, now the console has some colors, that's nice, but `TINKERPOP-1037` is 
actually about output coloring (which means to me, that results should have a 
bit of syntax coloring, right?). What do we need to do in order to have colored 
results (e.g. Strings in red, numbers in bllue, etc. et.c)?


> Gremlin shell output coloring
> -
>
> Key: TINKERPOP-1037
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1037
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.1.0-incubating
>Reporter: Jeremy Hanna
>Priority: Trivial
>
> In order to increase the readability of the output from the gremlin shell, it 
> would be nice to have some coloring in the output.  For example coloring the 
> edges in the textual output.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful

[dkuppitz]

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/384
  
Hm, now the console has some colors, that's nice, but `TINKERPOP-1037` is 
actually about output coloring (which means to me, that results should have a 
bit of syntax coloring, right?). What do we need to do in order to have colored 
results (e.g. Strings in red, numbers in bllue, etc. et.c)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426921#comment-15426921
 ] 

ASF GitHub Bot commented on TINKERPOP-1037:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/384
  
Screenshot:  
![screenshot_2016-08-18_13-59-58](https://cloud.githubusercontent.com/assets/122206/17784872/4286944a-654c-11e6-8813-025bc3974601.png)



> Gremlin shell output coloring
> -
>
> Key: TINKERPOP-1037
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1037
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.1.0-incubating
>Reporter: Jeremy Hanna
>Priority: Trivial
>
> In order to increase the readability of the output from the gremlin shell, it 
> would be nice to have some coloring in the output.  For example coloring the 
> edges in the textual output.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/384
  
Screenshot:  
![screenshot_2016-08-18_13-59-58](https://cloud.githubusercontent.com/assets/122206/17784872/4286944a-654c-11e6-8813-025bc3974601.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426904#comment-15426904
 ] 

ASF GitHub Bot commented on TINKERPOP-1037:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/384
  
that looks like all the same code i've written in the 
past...


> Gremlin shell output coloring
> -
>
> Key: TINKERPOP-1037
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1037
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.1.0-incubating
>Reporter: Jeremy Hanna
>Priority: Trivial
>
> In order to increase the readability of the output from the gremlin shell, it 
> would be nice to have some coloring in the output.  For example coloring the 
> edges in the textual output.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful

[spmallette]

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/384
  
that looks like all the same code i've written in the 
past...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1246) 'help' in the gremlin console should give the user something

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426883#comment-15426883
 ] 

ASF GitHub Bot commented on TINKERPOP-1246:
---

Github user robertdale closed the pull request at:

https://github.com/apache/tinkerpop/pull/383


> 'help' in the gremlin console should give the user something
> 
>
> Key: TINKERPOP-1246
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1246
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.1.1-incubating
>Reporter: Jeremy Hanna
>
> A new user to TinkerPop and/or Gremlin will probably flounder initially and 
> will likely try to type 'help' in the gremlin-console.  Currently it just 
> gives an error that help is not mapped to a class and gives the option to 
> show a stack trace.
> I know there is :help for the command mode, but that's going to confuse them 
> further I think because those are special commands and not what they're 
> looking for.
> Piggy backing on something [~rustyrazorblade] mentioned, perhaps we could 
> have it give a general message but help gremlin or help tinkerpop could open 
> the docs.
> In general though, I think it would be useful to have something defined for 
> help - perhaps a basic explanation with a couple of examples with the toy 
> graph while also referring to the tutorials section of the site.  Then it 
> would also be handy to override the help with specific commands like for each 
> of the commands in the docs like traversal steps (though that may be a lot of 
> work to maintain) such as 'help count' or 'help barrier'.  Specific keywords 
> could be used like was mentioned 'help gremlin' or 'help tinkerpop' or 'help 
> docs' could open the docs.
> Maybe some of this is overkill but I think overriding 'help' in some form 
> would be helpful for new users.  Also just trying to brainstorm what could be 
> done.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop pull request #383: TINKERPOP-1246 Added help message to console

[robertdale]

Github user robertdale closed the pull request at:

https://github.com/apache/tinkerpop/pull/383


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426878#comment-15426878
 ] 

ASF GitHub Bot commented on TINKERPOP-1037:
---

GitHub user robertdale opened a pull request:

https://github.com/apache/tinkerpop/pull/384

TINKERPOP-1037 Made life more colorful

Stephen did all the hard work.
- Added option -C to disable ANSI colors just in case.
- Colorized the gremlin ascii art.
- Added bold red to some, but probably not all, error messages
- Snuck in the help text for TINKERPOP-1246

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/robertdale/tinkerpop TINKERPOP-1037

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/384.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #384


commit ef518fbfef1910a73183abeed0bee90ba38e9a1f
Author: Robert Dale 
Date:   2016-08-18T17:34:04Z

made life more colorful




> Gremlin shell output coloring
> -
>
> Key: TINKERPOP-1037
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1037
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.1.0-incubating
>Reporter: Jeremy Hanna
>Priority: Trivial
>
> In order to increase the readability of the output from the gremlin shell, it 
> would be nice to have some coloring in the output.  For example coloring the 
> edges in the textual output.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop pull request #384: TINKERPOP-1037 Made life more colorful

[robertdale]

GitHub user robertdale opened a pull request:

https://github.com/apache/tinkerpop/pull/384

TINKERPOP-1037 Made life more colorful

Stephen did all the hard work.
- Added option -C to disable ANSI colors just in case.
- Colorized the gremlin ascii art.
- Added bold red to some, but probably not all, error messages
- Snuck in the help text for TINKERPOP-1246

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/robertdale/tinkerpop TINKERPOP-1037

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/384.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #384


commit ef518fbfef1910a73183abeed0bee90ba38e9a1f
Author: Robert Dale 
Date:   2016-08-18T17:34:04Z

made life more colorful




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1246) 'help' in the gremlin console should give the user something

[Marko A. Rodriguez (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426788#comment-15426788
 ] 

Marko A. Rodriguez commented on TINKERPOP-1246:
---

I like printing the help message after a stack trace.

> 'help' in the gremlin console should give the user something
> 
>
> Key: TINKERPOP-1246
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1246
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.1.1-incubating
>Reporter: Jeremy Hanna
>
> A new user to TinkerPop and/or Gremlin will probably flounder initially and 
> will likely try to type 'help' in the gremlin-console.  Currently it just 
> gives an error that help is not mapped to a class and gives the option to 
> show a stack trace.
> I know there is :help for the command mode, but that's going to confuse them 
> further I think because those are special commands and not what they're 
> looking for.
> Piggy backing on something [~rustyrazorblade] mentioned, perhaps we could 
> have it give a general message but help gremlin or help tinkerpop could open 
> the docs.
> In general though, I think it would be useful to have something defined for 
> help - perhaps a basic explanation with a couple of examples with the toy 
> graph while also referring to the tutorials section of the site.  Then it 
> would also be handy to override the help with specific commands like for each 
> of the commands in the docs like traversal steps (though that may be a lot of 
> work to maintain) such as 'help count' or 'help barrier'.  Specific keywords 
> could be used like was mentioned 'help gremlin' or 'help tinkerpop' or 'help 
> docs' could open the docs.
> Maybe some of this is overkill but I think overriding 'help' in some form 
> would be helpful for new users.  Also just trying to brainstorm what could be 
> done.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #383: TINKERPOP-1246 Added help message to console

[PommeVerte]

Github user PommeVerte commented on the issue:

https://github.com/apache/tinkerpop/pull/383
  
I'm personally ok with the concept. It seems pretty mainstream and will 
definitely help some folk. It's the kind of thing that you don't really pick up 
from reading the documentation (at least I don't) I know it's there from 
keeping up with the mailing list but otherwise I wouldn't have a clue. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1246) 'help' in the gremlin console should give the user something

[Robert Dale (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426670#comment-15426670
 ] 

Robert Dale commented on TINKERPOP-1246:


What about aliasing 'help' to ':help', much like '?' already is?
Or, print the help message after the stacktrace?

{noformat}
gremlin> help
No such property: help for class: groovysh_evaluate
Type ':help' or ':h' for help.
Display stack trace? [yN]
{noformat}

> 'help' in the gremlin console should give the user something
> 
>
> Key: TINKERPOP-1246
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1246
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.1.1-incubating
>Reporter: Jeremy Hanna
>
> A new user to TinkerPop and/or Gremlin will probably flounder initially and 
> will likely try to type 'help' in the gremlin-console.  Currently it just 
> gives an error that help is not mapped to a class and gives the option to 
> show a stack trace.
> I know there is :help for the command mode, but that's going to confuse them 
> further I think because those are special commands and not what they're 
> looking for.
> Piggy backing on something [~rustyrazorblade] mentioned, perhaps we could 
> have it give a general message but help gremlin or help tinkerpop could open 
> the docs.
> In general though, I think it would be useful to have something defined for 
> help - perhaps a basic explanation with a couple of examples with the toy 
> graph while also referring to the tutorials section of the site.  Then it 
> would also be handy to override the help with specific commands like for each 
> of the commands in the docs like traversal steps (though that may be a lot of 
> work to maintain) such as 'help count' or 'help barrier'.  Specific keywords 
> could be used like was mentioned 'help gremlin' or 'help tinkerpop' or 'help 
> docs' could open the docs.
> Maybe some of this is overkill but I think overriding 'help' in some form 
> would be helpful for new users.  Also just trying to brainstorm what could be 
> done.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TINKERPOP-1246) 'help' in the gremlin console should give the user something

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426465#comment-15426465
 ] 

ASF GitHub Bot commented on TINKERPOP-1246:
---

Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/383
  
Hm. Not a fan. :| +0.


> 'help' in the gremlin console should give the user something
> 
>
> Key: TINKERPOP-1246
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1246
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.1.1-incubating
>Reporter: Jeremy Hanna
>
> A new user to TinkerPop and/or Gremlin will probably flounder initially and 
> will likely try to type 'help' in the gremlin-console.  Currently it just 
> gives an error that help is not mapped to a class and gives the option to 
> show a stack trace.
> I know there is :help for the command mode, but that's going to confuse them 
> further I think because those are special commands and not what they're 
> looking for.
> Piggy backing on something [~rustyrazorblade] mentioned, perhaps we could 
> have it give a general message but help gremlin or help tinkerpop could open 
> the docs.
> In general though, I think it would be useful to have something defined for 
> help - perhaps a basic explanation with a couple of examples with the toy 
> graph while also referring to the tutorials section of the site.  Then it 
> would also be handy to override the help with specific commands like for each 
> of the commands in the docs like traversal steps (though that may be a lot of 
> work to maintain) such as 'help count' or 'help barrier'.  Specific keywords 
> could be used like was mentioned 'help gremlin' or 'help tinkerpop' or 'help 
> docs' could open the docs.
> Maybe some of this is overkill but I think overriding 'help' in some form 
> would be helpful for new users.  Also just trying to brainstorm what could be 
> done.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #383: TINKERPOP-1246 Added help message to console

[okram]

Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/383
  
Hm. Not a fan. :| +0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1226) Gremlin Console should :clear automagically after "Display stack trace."

[Marko A. Rodriguez (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426462#comment-15426462
 ] 

Marko A. Rodriguez commented on TINKERPOP-1226:
---

I like this idea. Though, I don't like the indentation cause by {{:XXX}}. 
Perhaps:

{code}
gremlin> ...
001> ...
002> .
gremlin> .
gremlin> .
{code}

> Gremlin Console should :clear automagically after "Display stack trace."
> 
>
> Key: TINKERPOP-1226
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1226
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.1.1-incubating
>Reporter: Marko A. Rodriguez
>
> I don't know if this is possible, but Martin brought this up the other day. 
> Why not just automatically call {{:clear}} after an Exception has been 
> through to get the Console back into an orderly state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TINKERPOP-1226) Gremlin Console should :clear automagically after "Display stack trace."

[Robert Dale (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426316#comment-15426316
 ] 

Robert Dale commented on TINKERPOP-1226:


This has gotten me several times early on before I knew about :clear and :d.  I 
think the problem stems from the lack of an indication that there is multi-line 
input TINKERPOP-1285 .  And so :d isn't always immediately obvious.

Simple example, but think of a complex, multi-line query with a single quote or 
paren missing:
gremlin> g.V().has('name,'marko')
gremlin> 
gremlin> 
gremlin> :d
 000> g.V().has('name,'marko')
gremlin> 

Again, with multi-line support TINKERPOP-1285 :
gremlin> g.V().has('name,'marko')
gremlin:001> 

Ah, it's waiting more input! I must be missing something!

And maybe this is why 'null' return has been an important indicator to keep 
around - TINKERPOP-1409 .  With multi-line support, it's no longer ambiguous if 
the console is awaiting more input or has returned.



> Gremlin Console should :clear automagically after "Display stack trace."
> 
>
> Key: TINKERPOP-1226
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1226
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.1.1-incubating
>Reporter: Marko A. Rodriguez
>
> I don't know if this is possible, but Martin brought this up the other day. 
> Why not just automatically call {{:clear}} after an Exception has been 
> through to get the Console back into an orderly state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TINKERPOP-1246) 'help' in the gremlin console should give the user something

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426297#comment-15426297
 ] 

ASF GitHub Bot commented on TINKERPOP-1246:
---

GitHub user robertdale opened a pull request:

https://github.com/apache/tinkerpop/pull/383

TINKERPOP-1246 Added help message to console

Type ':help' or ':h' for help.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/robertdale/tinkerpop TINKERPOP-1246

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/383.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #383


commit 3530d4612192659c6984d5428ddafb2b069f12f4
Author: Robert Dale 
Date:   2016-08-18T11:29:11Z

added help message




> 'help' in the gremlin console should give the user something
> 
>
> Key: TINKERPOP-1246
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1246
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: console
>Affects Versions: 3.1.1-incubating
>Reporter: Jeremy Hanna
>
> A new user to TinkerPop and/or Gremlin will probably flounder initially and 
> will likely try to type 'help' in the gremlin-console.  Currently it just 
> gives an error that help is not mapped to a class and gives the option to 
> show a stack trace.
> I know there is :help for the command mode, but that's going to confuse them 
> further I think because those are special commands and not what they're 
> looking for.
> Piggy backing on something [~rustyrazorblade] mentioned, perhaps we could 
> have it give a general message but help gremlin or help tinkerpop could open 
> the docs.
> In general though, I think it would be useful to have something defined for 
> help - perhaps a basic explanation with a couple of examples with the toy 
> graph while also referring to the tutorials section of the site.  Then it 
> would also be handy to override the help with specific commands like for each 
> of the commands in the docs like traversal steps (though that may be a lot of 
> work to maintain) such as 'help count' or 'help barrier'.  Specific keywords 
> could be used like was mentioned 'help gremlin' or 'help tinkerpop' or 'help 
> docs' could open the docs.
> Maybe some of this is overkill but I think overriding 'help' in some form 
> would be helpful for new users.  Also just trying to brainstorm what could be 
> done.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)