date:20170922

[jira] [Closed] (TINKERPOP-1787) Allow :remote command to accept a user defined Cluster instance

2017-09-22 Thread stephen mallette (JIRA)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette closed TINKERPOP-1787.
---
   Resolution: Done
Fix Version/s: 3.3.1
   3.2.7

> Allow :remote command to accept a user defined Cluster instance
> ---
>
> Key: TINKERPOP-1787
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1787
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: plugin
>Affects Versions: 3.2.6
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
> Fix For: 3.2.7, 3.3.1
>
>
> Make a minor adjustment to the {{DriverRemoteAcceptor}} to allow for this 
> type of syntax:
> {code}
> gremlin> cluster = Cluster.open()
> ==>localhost/127.0.0.1:8182
> gremlin> :remote connect tinkerpop.server cluster
> ==>Configured localhost/127.0.0.1:8182
> {code}
> which will provide more flexibility to those those who are trying to script 
> the console.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1752) Gremlin.Net: Generate completely type-safe methods

2017-09-22 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176768#comment-16176768
 ] 

ASF GitHub Bot commented on TINKERPOP-1752:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/712
  
Changes look generally ok to me, but I'll let @jorgebay do a more technical 
review of the code itself as i'm still trying to get my head back into .NET. 
Getting rid of the `params object[] args` seems like a helpful thing to do for 
users. Based on that: 

VOTE +1


> Gremlin.Net: Generate completely type-safe methods
> --
>
> Key: TINKERPOP-1752
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1752
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: dotnet
>Affects Versions: 3.2.5
>Reporter: Florian Hockmann
>Priority: Minor
>
> Currently the generated traversal methods in Gremlin.Net take {{params 
> object[] args}} as an argument which allows the user to provide an arbitrary 
> number of arguments with any type. While this makes the generation rather 
> simple, it doesn't tell the user which arguments are actually valid so users 
> can submit completely invalid traversals like:
> {code}
> g.V(1).AddE(1234, "invalidArgument2").Next()
> {code}
> Type-safe methods could also use the original argument names to tell users 
> something about what kind of values the methods expect. Consider for example 
> the following method signatures for the C# step {{AddE}} that are basically a 
> 1:1 representation of the original Java {{addE}} step:
> {code}
> public GraphTraversal< S , Edge > AddE (Direction direction, string 
> firstVertexKeyOrEdgeLabel, string edgeLabelOrSecondVertexKey, params object[] 
> propertyKeyValues);
> public GraphTraversal< S , Edge > AddE (string edgeLabel);
> {code}
> Implementing this should make TINKERPOP-1725 obsolete and also resolve 
> TINKERPOP-1751.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop issue #712: TINKERPOP-1752: Gremlin.Net: Generate completely type-...

2017-09-22 Thread spmallette

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/712
  
Changes look generally ok to me, but I'll let @jorgebay do a more technical 
review of the code itself as i'm still trying to get my head back into .NET. 
Getting rid of the `params object[] args` seems like a helpful thing to do for 
users. Based on that: 

VOTE +1


---

[jira] [Closed] (TINKERPOP-1731) Docker build does not appear to work for gremlin-dotnet

2017-09-22 Thread stephen mallette (JIRA)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette closed TINKERPOP-1731.
---
   Resolution: Fixed
 Assignee: stephen mallette
Fix Version/s: 3.3.1
   3.2.7

> Docker build does not appear to work for gremlin-dotnet
> ---
>
> Key: TINKERPOP-1731
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1731
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release, dotnet
>Affects Versions: 3.3.0
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Critical
> Fix For: 3.2.7, 3.3.1
>
>
> Docker won't build the gremlin-dotnet stuff. I pulled out the {{.glv}} files 
> from that module so that docker would run properly until this can be fixed:
> https://github.com/apache/tinkerpop/blob/2d30a76aabdd009b9b926f83df2308b7578571c0/docker/scripts/build.sh#L71-L72



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (TINKERPOP-1731) Docker build does not appear to work for gremlin-dotnet

2017-09-22 Thread stephen mallette (JIRA)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette closed TINKERPOP-1731.
---
Resolution: Fixed

> Docker build does not appear to work for gremlin-dotnet
> ---
>
> Key: TINKERPOP-1731
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1731
> Project: TinkerPop
>  Issue Type: Bug
>  Components: build-release, dotnet
>Affects Versions: 3.3.0
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Critical
> Fix For: 3.2.7, 3.3.1
>
>
> Docker won't build the gremlin-dotnet stuff. I pulled out the {{.glv}} files 
> from that module so that docker would run properly until this can be fixed:
> https://github.com/apache/tinkerpop/blob/2d30a76aabdd009b9b926f83df2308b7578571c0/docker/scripts/build.sh#L71-L72



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Reopened] (TINKERPOP-1731) Docker build does not appear to work for gremlin-dotnet

2017-09-22 Thread stephen mallette (JIRA)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette reopened TINKERPOP-1731:
-

> Docker build does not appear to work for gremlin-dotnet
> ---
>
> Key: TINKERPOP-1731
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1731
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release, dotnet
>Affects Versions: 3.3.0
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Critical
> Fix For: 3.2.7, 3.3.1
>
>
> Docker won't build the gremlin-dotnet stuff. I pulled out the {{.glv}} files 
> from that module so that docker would run properly until this can be fixed:
> https://github.com/apache/tinkerpop/blob/2d30a76aabdd009b9b926f83df2308b7578571c0/docker/scripts/build.sh#L71-L72



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1731) Docker build does not appear to work for gremlin-dotnet

2017-09-22 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176717#comment-16176717
 ] 

ASF GitHub Bot commented on TINKERPOP-1731:
---

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/719


> Docker build does not appear to work for gremlin-dotnet
> ---
>
> Key: TINKERPOP-1731
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1731
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release, dotnet
>Affects Versions: 3.3.0
>Reporter: stephen mallette
>Priority: Critical
>
> Docker won't build the gremlin-dotnet stuff. I pulled out the {{.glv}} files 
> from that module so that docker would run properly until this can be fixed:
> https://github.com/apache/tinkerpop/blob/2d30a76aabdd009b9b926f83df2308b7578571c0/docker/scripts/build.sh#L71-L72



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop pull request #719: TINKERPOP-1731 Build for .NET working in docker

2017-09-22 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/719


---

[GitHub] tinkerpop issue #714: TINKERPOP-1782 RangeByIsCountStrategy doesn't handle f...

2017-09-22 Thread robertdale

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/714
  
Tests in the jira ticket work as expected.
VOTE +1



---

[jira] [Commented] (TINKERPOP-1782) RangeByIsCountStrategy doesn't handle floating point numbers properly

2017-09-22 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176683#comment-16176683
 ] 

ASF GitHub Bot commented on TINKERPOP-1782:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/714
  
Tests in the jira ticket work as expected.
VOTE +1



> RangeByIsCountStrategy doesn't handle floating point numbers properly
> -
>
> Key: TINKERPOP-1782
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1782
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.6
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>
> See: https://groups.google.com/d/msg/gremlin-users/90IY6QMp4YQ/w60l_pfvCgAJ



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1787) Allow :remote command to accept a user defined Cluster instance

2017-09-22 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176608#comment-16176608
 ] 

ASF GitHub Bot commented on TINKERPOP-1787:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/718
  
VOTE +1


> Allow :remote command to accept a user defined Cluster instance
> ---
>
> Key: TINKERPOP-1787
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1787
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: plugin
>Affects Versions: 3.2.6
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
>
> Make a minor adjustment to the {{DriverRemoteAcceptor}} to allow for this 
> type of syntax:
> {code}
> gremlin> cluster = Cluster.open()
> ==>localhost/127.0.0.1:8182
> gremlin> :remote connect tinkerpop.server cluster
> ==>Configured localhost/127.0.0.1:8182
> {code}
> which will provide more flexibility to those those who are trying to script 
> the console.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop issue #718: TINKERPOP-1787 Add syntax for :remote to accept a Clus...

2017-09-22 Thread robertdale

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/718
  
VOTE +1


---

[jira] [Commented] (TINKERPOP-1692) Bump to Neo4j 3.2.3

2017-09-22 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176600#comment-16176600
 ] 

ASF GitHub Bot commented on TINKERPOP-1692:
---

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/674


> Bump to Neo4j 3.2.3
> ---
>
> Key: TINKERPOP-1692
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1692
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: neo4j
>Affects Versions: 3.2.5
>Reporter: stephen mallette
>Assignee: Robert Dale
> Fix For: 3.3.1
>
>
> There is a newer version of Neo4j available - 
> https://mvnrepository.com/artifact/org.neo4j/neo4j-tinkerpop-api-impl/0.4-3.0.3



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop pull request #674: Neo4j upgrade to 3.2.2 - TINKERPOP-1692

2017-09-22 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/674


---

[jira] [Commented] (TINKERPOP-1731) Docker build does not appear to work for gremlin-dotnet

2017-09-22 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176596#comment-16176596
 ] 

ASF GitHub Bot commented on TINKERPOP-1731:
---

Github user jorgebay commented on the issue:

https://github.com/apache/tinkerpop/pull/719
  
dotnet tests pass on docker  

Relevant lines:

```
Test run for 
/usr/src/tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/bin/Release/netcoreapp1.0/Gremlin.Net.IntegrationTest.dll(.NETCoreApp,Version=v1.0)
Microsoft (R) Test Execution Command Line Tool Version 15.0.0.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
[xUnit.net 00:00:00.8446945]   Discovering: Gremlin.Net.IntegrationTest
[xUnit.net 00:00:01.0599920]   Discovered:  Gremlin.Net.IntegrationTest
[xUnit.net 00:00:01.1216217]   Starting:Gremlin.Net.IntegrationTest
[xUnit.net 00:00:03.0767841]   Finished:Gremlin.Net.IntegrationTest

Total tests: 77. Passed: 77. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 4.1080 Seconds


Build started, please wait...
Build completed.

Test run for 
/usr/src/tinkerpop/gremlin-dotnet/test/Gremlin.Net.UnitTest/bin/Release/netcoreapp1.0/Gremlin.Net.UnitTest.dll(.NETCoreApp,Version=v1.0)
Microsoft (R) Test Execution Command Line Tool Version 15.0.0.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
[xUnit.net 00:00:00.7192188]   Discovering: Gremlin.Net.UnitTest
[xUnit.net 00:00:00.9493505]   Discovered:  Gremlin.Net.UnitTest
[xUnit.net 00:00:01.0271298]   Starting:Gremlin.Net.UnitTest
[xUnit.net 00:00:02.1334540]   Finished:Gremlin.Net.UnitTest

Total tests: 131. Passed: 131. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 2.9851 Seconds
```

VOTE: +1


> Docker build does not appear to work for gremlin-dotnet
> ---
>
> Key: TINKERPOP-1731
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1731
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release, dotnet
>Affects Versions: 3.3.0
>Reporter: stephen mallette
>Priority: Critical
>
> Docker won't build the gremlin-dotnet stuff. I pulled out the {{.glv}} files 
> from that module so that docker would run properly until this can be fixed:
> https://github.com/apache/tinkerpop/blob/2d30a76aabdd009b9b926f83df2308b7578571c0/docker/scripts/build.sh#L71-L72



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop issue #719: TINKERPOP-1731 Build for .NET working in docker

2017-09-22 Thread jorgebay

Github user jorgebay commented on the issue:

https://github.com/apache/tinkerpop/pull/719
  
dotnet tests pass on docker ð 

Relevant lines:

```
Test run for 
/usr/src/tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/bin/Release/netcoreapp1.0/Gremlin.Net.IntegrationTest.dll(.NETCoreApp,Version=v1.0)
Microsoft (R) Test Execution Command Line Tool Version 15.0.0.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
[xUnit.net 00:00:00.8446945]   Discovering: Gremlin.Net.IntegrationTest
[xUnit.net 00:00:01.0599920]   Discovered:  Gremlin.Net.IntegrationTest
[xUnit.net 00:00:01.1216217]   Starting:Gremlin.Net.IntegrationTest
[xUnit.net 00:00:03.0767841]   Finished:Gremlin.Net.IntegrationTest

Total tests: 77. Passed: 77. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 4.1080 Seconds


Build started, please wait...
Build completed.

Test run for 
/usr/src/tinkerpop/gremlin-dotnet/test/Gremlin.Net.UnitTest/bin/Release/netcoreapp1.0/Gremlin.Net.UnitTest.dll(.NETCoreApp,Version=v1.0)
Microsoft (R) Test Execution Command Line Tool Version 15.0.0.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
[xUnit.net 00:00:00.7192188]   Discovering: Gremlin.Net.UnitTest
[xUnit.net 00:00:00.9493505]   Discovered:  Gremlin.Net.UnitTest
[xUnit.net 00:00:01.0271298]   Starting:Gremlin.Net.UnitTest
[xUnit.net 00:00:02.1334540]   Finished:Gremlin.Net.UnitTest

Total tests: 131. Passed: 131. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 2.9851 Seconds
```

VOTE: +1


---

[jira] [Commented] (TINKERPOP-1783) PageRank gives incorrect results for graphs with sinks

2017-09-22 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176530#comment-16176530
 ] 

ASF GitHub Bot commented on TINKERPOP-1783:
---

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/717


> PageRank gives incorrect results for graphs with sinks
> --
>
> Key: TINKERPOP-1783
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1783
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.3.0, 3.1.8, 3.2.6
>Reporter: Artem Aliev
>Assignee: Marko A. Rodriguez
>  Labels: breaking
> Fix For: 3.3.1
>
>
> {quote} Sink vertices (those with no outgoing edges) should evenly distribute 
> their rank to the entire graph but in the current implementation it is just 
> lost.
> {quote} 
> Wiki: https://en.wikipedia.org/wiki/PageRank#Simplified_algorithm
> {quote}  In the original form of PageRank, the sum of PageRank over all pages 
> was the total number of pages on the web at that time
> {quote} 
> I found the issue, while comparing results with the spark graphX.
> So this is a copy of  https://issues.apache.org/jira/browse/SPARK-18847
> How to reproduce:
> {code}
> gremlin> graph = TinkerFactory.createModern()
> gremlin> g = graph.traversal().withComputer()
> gremlin> 
> g.V().pageRank(0.85).times(40).by('pageRank').values('pageRank').sum()
> ==>1.318625
> gremlin> g.V().pageRank(0.85).times(1).by('pageRank').values('pageRank').sum()
> ==>3.4497
> #inital values:
> gremlin> g.V().pageRank(0.85).times(0).by('pageRank').values('pageRank').sum()
> ==>6.0
> {code}
> They fixed the issue by normalising values after each step.
> The other way to fix is to send the message to it self (stay on the same 
> page).
> To workaround the problem just add self pointing edges:
> {code}
> gremlin>g.V().as('B').addE('knows').from('B')
> {code}
> Then you'll get always correct sum. But I'm not sure it is a proper 
> assumption. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (TINKERPOP-1783) PageRank gives incorrect results for graphs with sinks

2017-09-22 Thread Marko A. Rodriguez (JIRA)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marko A. Rodriguez closed TINKERPOP-1783.
-
   Resolution: Fixed
Fix Version/s: 3.3.1

> PageRank gives incorrect results for graphs with sinks
> --
>
> Key: TINKERPOP-1783
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1783
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.3.0, 3.1.8, 3.2.6
>Reporter: Artem Aliev
>Assignee: Marko A. Rodriguez
>  Labels: breaking
> Fix For: 3.3.1
>
>
> {quote} Sink vertices (those with no outgoing edges) should evenly distribute 
> their rank to the entire graph but in the current implementation it is just 
> lost.
> {quote} 
> Wiki: https://en.wikipedia.org/wiki/PageRank#Simplified_algorithm
> {quote}  In the original form of PageRank, the sum of PageRank over all pages 
> was the total number of pages on the web at that time
> {quote} 
> I found the issue, while comparing results with the spark graphX.
> So this is a copy of  https://issues.apache.org/jira/browse/SPARK-18847
> How to reproduce:
> {code}
> gremlin> graph = TinkerFactory.createModern()
> gremlin> g = graph.traversal().withComputer()
> gremlin> 
> g.V().pageRank(0.85).times(40).by('pageRank').values('pageRank').sum()
> ==>1.318625
> gremlin> g.V().pageRank(0.85).times(1).by('pageRank').values('pageRank').sum()
> ==>3.4497
> #inital values:
> gremlin> g.V().pageRank(0.85).times(0).by('pageRank').values('pageRank').sum()
> ==>6.0
> {code}
> They fixed the issue by normalising values after each step.
> The other way to fix is to send the message to it self (stay on the same 
> page).
> To workaround the problem just add self pointing edges:
> {code}
> gremlin>g.V().as('B').addE('knows').from('B')
> {code}
> Then you'll get always correct sum. But I'm not sure it is a proper 
> assumption. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop pull request #717: TINKERPOP-1783: PageRank gives incorrect result...

2017-09-22 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/717


---

[jira] [Commented] (TINKERPOP-1783) PageRank gives incorrect results for graphs with sinks

2017-09-22 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176529#comment-16176529
 ] 

ASF GitHub Bot commented on TINKERPOP-1783:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/717
  
All tests pass with `docker/build.sh -t -i`

VOTE +1


> PageRank gives incorrect results for graphs with sinks
> --
>
> Key: TINKERPOP-1783
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1783
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.3.0, 3.1.8, 3.2.6
>Reporter: Artem Aliev
>Assignee: Marko A. Rodriguez
>  Labels: breaking
>
> {quote} Sink vertices (those with no outgoing edges) should evenly distribute 
> their rank to the entire graph but in the current implementation it is just 
> lost.
> {quote} 
> Wiki: https://en.wikipedia.org/wiki/PageRank#Simplified_algorithm
> {quote}  In the original form of PageRank, the sum of PageRank over all pages 
> was the total number of pages on the web at that time
> {quote} 
> I found the issue, while comparing results with the spark graphX.
> So this is a copy of  https://issues.apache.org/jira/browse/SPARK-18847
> How to reproduce:
> {code}
> gremlin> graph = TinkerFactory.createModern()
> gremlin> g = graph.traversal().withComputer()
> gremlin> 
> g.V().pageRank(0.85).times(40).by('pageRank').values('pageRank').sum()
> ==>1.318625
> gremlin> g.V().pageRank(0.85).times(1).by('pageRank').values('pageRank').sum()
> ==>3.4497
> #inital values:
> gremlin> g.V().pageRank(0.85).times(0).by('pageRank').values('pageRank').sum()
> ==>6.0
> {code}
> They fixed the issue by normalising values after each step.
> The other way to fix is to send the message to it self (stay on the same 
> page).
> To workaround the problem just add self pointing edges:
> {code}
> gremlin>g.V().as('B').addE('knows').from('B')
> {code}
> Then you'll get always correct sum. But I'm not sure it is a proper 
> assumption. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1789) Reference elements should be represented by id and label

2017-09-22 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176526#comment-16176526
 ] 

ASF GitHub Bot commented on TINKERPOP-1789:
---

Github user okram commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/720#discussion_r140513636
  
--- Diff: docs/src/upgrade/release-3.2.x-incubating.asciidoc ---
@@ -95,6 +95,19 @@ In `gremlin-test` there is a new `GraphHelper` class 
that has a `cloneElements()
 the first graph to the second - `GraphHelper.cloneElements(Graph original, 
Graph clone)`. This helper method is
 primarily intended for use in tests.
 
+Upgrading for Providers
+~~~
+
+ReferenceVertex Label
+^
+
+`ReferenceVertex.label()` was hard coded to return `EMPTY_STRING`. At some 
point, `ReferenceElements` were support to
--- End diff --

fixed.


> Reference elements should be represented by id and label
> 
>
> Key: TINKERPOP-1789
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1789
> Project: TinkerPop
>  Issue Type: Bug
>  Components: io
>Affects Versions: 3.2.6
>Reporter: stephen mallette
>Assignee: Marko A. Rodriguez
>Priority: Critical
>  Labels: breaking
> Fix For: 3.2.7, 3.3.1
>
>
> Reference elements don't have {{label()}} - wow. This is a breaking change 
> because adding label to reference objects will mean that the gryo 
> serialization format will change for reference objects.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop issue #717: TINKERPOP-1783: PageRank gives incorrect results for g...

2017-09-22 Thread spmallette

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/717
  
All tests pass with `docker/build.sh -t -i`

VOTE +1


---

[GitHub] tinkerpop pull request #720: TINKERPOP-1789: Reference elements should be re...

2017-09-22 Thread okram

Github user okram commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/720#discussion_r140513636
  
--- Diff: docs/src/upgrade/release-3.2.x-incubating.asciidoc ---
@@ -95,6 +95,19 @@ In `gremlin-test` there is a new `GraphHelper` class 
that has a `cloneElements()
 the first graph to the second - `GraphHelper.cloneElements(Graph original, 
Graph clone)`. This helper method is
 primarily intended for use in tests.
 
+Upgrading for Providers
+~~~
+
+ReferenceVertex Label
+^
+
+`ReferenceVertex.label()` was hard coded to return `EMPTY_STRING`. At some 
point, `ReferenceElements` were support to
--- End diff --

fixed.


---

[jira] [Created] (TINKERPOP-1791) GremlinDsl custom step with generic end type produces invalid code in __.java

2017-09-22 Thread Severin Stampler (JIRA)

Severin Stampler created TINKERPOP-1791:
---

 Summary: GremlinDsl custom step with generic end type produces 
invalid code in __.java
 Key: TINKERPOP-1791
 URL: https://issues.apache.org/jira/browse/TINKERPOP-1791
 Project: TinkerPop
  Issue Type: Bug
  Components: process
Affects Versions: 3.2.5
Reporter: Severin Stampler


I'm trying the create a custom step to perform a full-text search in an 
external index and return the matching vertices or edges, like this:

{code:java}
@GremlinDsl(traversalSource = 
"com.saillabs.mediaminer.mmgraphdsl.MMGraphTraversalSourceDsl")
public interface MMGraphTraversalDsl extends GraphTraversal.Admin {

public default GraphTraversal search(String field, String query) {
//TODO:
// Find vertex ids matching the search query in external index

Set vids = new HashSet<>();
// for now add some hardcoded vertex ids
vids.add("vertex1");
vids.add("vertex2");

return hasId(P.within(vids));
}

}
{code}

The code seems correct in my point of view, but the generated code in the 
__.java is not compilable. It produces this error:


{noformat}
[ERROR] 
/C:/svn/start/mm/mmserver/server/mvn/mmgraphdsl/target/generated-sources/annotations/com/saillabs/mediaminer/mmgraphdsl/__.java:[41,41]
 cannot find symbol
[ERROR] symbol:   class E
[ERROR] location: class com.saillabs.mediaminer.mmgraphdsl.__
{noformat}

The generated code is this:


{code:java}
public static  MMGraphTraversal search(String field, String query) {
return __.start().search(field,query);
  }
{code}

I think the correct generated code should look like this:


{code:java}
public static  MMGraphTraversal search(String field, String query) {
return __.start().search(field,query);
  }
{code}

I think it's a bug in the GremlinDsl code generator, however, I may be wrong. 
Any help is appreciated.
Thanks, br
Severin



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [DISCUSS] GLV Test Suite

2017-09-22 Thread Stephen Mallette

Thanks for the update. I'm trying to keep the test language as simple as
possible so that we don't need an overly complicated test implementation.
Hopefully that will help make the .NET approach as easy as possible.

On Fri, Sep 22, 2017 at 8:20 AM, Jorge Bay Gondra 
wrote:

> I've been looking into Gherkin support for .NET: SpecFlow, the cucumber
> implementation for .NET  >,
> does not support .NET Core platform (we use .NET Core build tools for the
> .NET GLV) and only supports .NET Framework.
>
> From what I can see ,
> .NET
> Core support on SpecFlow is coming at a very slow pace and we shouldn't
> expect to land any time soon (there were some design decisions in SpecFlow
> library that makes supporting other platforms non-trivial, like requiring
> code gen).
>
> The alternative would be to implement our own harness to support it: from a
> xunit test, look for certain types and parse the annotations, and execute
> them using the Gherkin features.
> There is a .NET cross-platform Gherkin parser:
> https://github.com/cucumber/gherkin-dotnet
> I'll continue looking into this option and try to understand the effort
> required...
>
> On Tue, Sep 19, 2017 at 6:21 PM, Jorge Bay Gondra <
> jorgebaygon...@gmail.com>
> wrote:
>
> > Nice! Gherkin will make our lives easier with a growing number of GLVs.
> >
> > We should find a way to define the different features supported by each
> > GLV, as it's reasonable to have different maturity levels per GLV (ie:
> > lambdas support, traversal strategy, ...). I don't know if it will be
> > beneficial to do it in the Gherkin files or within each GLV
> implementation.
> > Also, we should consider the process of rolling out a new method / class
> > in the java implementation, how that could affect each GLV.
> >
> > On Thu, Sep 14, 2017 at 11:12 PM, Stephen Mallette  >
> > wrote:
> >
> >> that's what i meant by "reflection" or as you suggest eval(). I guess
> the
> >> point is that if the language can support some way of taking the string
> >> value and turning it automatically into a traversal in that GLVs style
> >> then
> >> we should do that.
> >>
> >> On Thu, Sep 14, 2017 at 4:45 PM, Daniel Kuppitz 
> wrote:
> >>
> >> > For unparameterized queries it can probably be as easy as:
> >> >
> >> > @given("the traversal of")
> >> > def translate_traversal(step):
> >> > g = step.context.g
> >> > step.context.traversal = eval(step.text)
> >> >
> >> >
> >> > Cheers,
> >> > Daniel
> >> >
> >> >
> >> > On Thu, Sep 14, 2017 at 1:39 PM, Daniel Kuppitz 
> >> wrote:
> >> >
> >> > > That's great stuff. I haven't used Cucumber / Gherkin for years,
> but I
> >> > > really like the BDD approach.
> >> > >
> >> > > and then you can look at the GLV Gremlin translations specifically
> >> here:
> >> > >> https://github.com/apache/tinkerpop/blob/TINKERPOP-1784/grem
> >> > >> lin-python/src/main/jython/radish/count_features_step.py#L34-L46
> >> > >
> >> > >
> >> > > This part is the only thing that looks weird to me. You're basically
> >> > > writing every query twice; is there really no easier way to do that?
> >> > >
> >> > > Cheers,
> >> > > Daniel
> >> > >
> >> > >
> >> > > On Thu, Sep 14, 2017 at 1:17 PM, Stephen Mallette <
> >> spmalle...@gmail.com>
> >> > > wrote:
> >> > >
> >> > >> I've brought this issue up in the past and had suggested some
> >> options I
> >> > >> had
> >> > >> in mind but now I've finally put the basics of those ideas in place
> >> so I
> >> > >> figured I'd start a fresh thread. Recall that the issue at hand is
> >> that
> >> > we
> >> > >> don't have a test suite for GLVs as gremlin-test is bound to the
> >> JVM. We
> >> > >> have some tricks that let us test gremlin-python with it but those
> >> > tricks
> >> > >> won't work for every language and we now have the first language in
> >> > >> gremlin-dotnet and upcoming gremlin-javascript which won't support
> it
> >> > >> (yes,
> >> > >> i know that gremlin-javascript can run on the jvm but there are
> >> issues
> >> > >> with
> >> > >> getting it all to work with the test framework that make it unduly
> >> > >> complicated).
> >> > >>
> >> > >> On other threads I offered the idea that we look to use Gherkin to
> >> write
> >> > >> general Gremlin test specifications, which then could be read and
> >> > >> processed
> >> > >> by the wide variety of test frameworks that can read that format -
> >> there
> >> > >> tend to be Gherkin processors in just about every language - for
> >> > example,
> >> > >> see:
> >> > >>
> >> > >> https://cucumber.io/
> >> > >>
> >> > >> I just created this issue:
> >> > >>
> >> > >> https://issues.apache.org/jira/browse/TINKERPOP-1784
> >> > >>
> >> > >> and pushed this branch:
> >> > >>
> >> > >> https://github.com/apache/tinkerpop/tree/TINKERPOP-1784
> >> > >>
> >> > >> which demonstrates

Re: [DISCUSS] GLV Test Suite

2017-09-22 Thread Jorge Bay Gondra

I've been looking into Gherkin support for .NET: SpecFlow, the cucumber
implementation for .NET ,
does not support .NET Core platform (we use .NET Core build tools for the
.NET GLV) and only supports .NET Framework.

>From what I can see , .NET
Core support on SpecFlow is coming at a very slow pace and we shouldn't
expect to land any time soon (there were some design decisions in SpecFlow
library that makes supporting other platforms non-trivial, like requiring
code gen).

The alternative would be to implement our own harness to support it: from a
xunit test, look for certain types and parse the annotations, and execute
them using the Gherkin features.
There is a .NET cross-platform Gherkin parser:
https://github.com/cucumber/gherkin-dotnet
I'll continue looking into this option and try to understand the effort
required...

On Tue, Sep 19, 2017 at 6:21 PM, Jorge Bay Gondra 
wrote:

> Nice! Gherkin will make our lives easier with a growing number of GLVs.
>
> We should find a way to define the different features supported by each
> GLV, as it's reasonable to have different maturity levels per GLV (ie:
> lambdas support, traversal strategy, ...). I don't know if it will be
> beneficial to do it in the Gherkin files or within each GLV implementation.
> Also, we should consider the process of rolling out a new method / class
> in the java implementation, how that could affect each GLV.
>
> On Thu, Sep 14, 2017 at 11:12 PM, Stephen Mallette 
> wrote:
>
>> that's what i meant by "reflection" or as you suggest eval(). I guess the
>> point is that if the language can support some way of taking the string
>> value and turning it automatically into a traversal in that GLVs style
>> then
>> we should do that.
>>
>> On Thu, Sep 14, 2017 at 4:45 PM, Daniel Kuppitz  wrote:
>>
>> > For unparameterized queries it can probably be as easy as:
>> >
>> > @given("the traversal of")
>> > def translate_traversal(step):
>> > g = step.context.g
>> > step.context.traversal = eval(step.text)
>> >
>> >
>> > Cheers,
>> > Daniel
>> >
>> >
>> > On Thu, Sep 14, 2017 at 1:39 PM, Daniel Kuppitz 
>> wrote:
>> >
>> > > That's great stuff. I haven't used Cucumber / Gherkin for years, but I
>> > > really like the BDD approach.
>> > >
>> > > and then you can look at the GLV Gremlin translations specifically
>> here:
>> > >> https://github.com/apache/tinkerpop/blob/TINKERPOP-1784/grem
>> > >> lin-python/src/main/jython/radish/count_features_step.py#L34-L46
>> > >
>> > >
>> > > This part is the only thing that looks weird to me. You're basically
>> > > writing every query twice; is there really no easier way to do that?
>> > >
>> > > Cheers,
>> > > Daniel
>> > >
>> > >
>> > > On Thu, Sep 14, 2017 at 1:17 PM, Stephen Mallette <
>> spmalle...@gmail.com>
>> > > wrote:
>> > >
>> > >> I've brought this issue up in the past and had suggested some
>> options I
>> > >> had
>> > >> in mind but now I've finally put the basics of those ideas in place
>> so I
>> > >> figured I'd start a fresh thread. Recall that the issue at hand is
>> that
>> > we
>> > >> don't have a test suite for GLVs as gremlin-test is bound to the
>> JVM. We
>> > >> have some tricks that let us test gremlin-python with it but those
>> > tricks
>> > >> won't work for every language and we now have the first language in
>> > >> gremlin-dotnet and upcoming gremlin-javascript which won't support it
>> > >> (yes,
>> > >> i know that gremlin-javascript can run on the jvm but there are
>> issues
>> > >> with
>> > >> getting it all to work with the test framework that make it unduly
>> > >> complicated).
>> > >>
>> > >> On other threads I offered the idea that we look to use Gherkin to
>> write
>> > >> general Gremlin test specifications, which then could be read and
>> > >> processed
>> > >> by the wide variety of test frameworks that can read that format -
>> there
>> > >> tend to be Gherkin processors in just about every language - for
>> > example,
>> > >> see:
>> > >>
>> > >> https://cucumber.io/
>> > >>
>> > >> I just created this issue:
>> > >>
>> > >> https://issues.apache.org/jira/browse/TINKERPOP-1784
>> > >>
>> > >> and pushed this branch:
>> > >>
>> > >> https://github.com/apache/tinkerpop/tree/TINKERPOP-1784
>> > >>
>> > >> which demonstrates how this works with gremlin-python. The basic
>> anatomy
>> > >> of
>> > >> this setup involves this new directory in gremlin-test:
>> > >>
>> > >> https://github.com/apache/tinkerpop/tree/TINKERPOP-1784/grem
>> > >> lin-test/features
>> > >>
>> > >> It contains the Gherkin .features files. These are the test
>> > >> specifications.
>> > >> They are written using gremlin-java as the "model" language. GLVs
>> will
>> > >> then
>> > >> need to write some infrastructure to process these Gherkin files. The
>> > key
>> > >> to making this "easy" to

[jira] [Commented] (TINKERPOP-1731) Docker build does not appear to work for gremlin-dotnet

2017-09-22 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176291#comment-16176291
 ] 

ASF GitHub Bot commented on TINKERPOP-1731:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/719
  
yes - you gotta remove the old image


> Docker build does not appear to work for gremlin-dotnet
> ---
>
> Key: TINKERPOP-1731
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1731
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release, dotnet
>Affects Versions: 3.3.0
>Reporter: stephen mallette
>Priority: Critical
>
> Docker won't build the gremlin-dotnet stuff. I pulled out the {{.glv}} files 
> from that module so that docker would run properly until this can be fixed:
> https://github.com/apache/tinkerpop/blob/2d30a76aabdd009b9b926f83df2308b7578571c0/docker/scripts/build.sh#L71-L72



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop issue #719: TINKERPOP-1731 Build for .NET working in docker

2017-09-22 Thread spmallette

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/719
  
yes - you gotta remove the old image


---

[GitHub] tinkerpop pull request #720: TINKERPOP-1789: Reference elements should be re...

2017-09-22 Thread spmallette

Github user spmallette commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/720#discussion_r140470761
  
--- Diff: docs/src/upgrade/release-3.2.x-incubating.asciidoc ---
@@ -95,6 +95,19 @@ In `gremlin-test` there is a new `GraphHelper` class 
that has a `cloneElements()
 the first graph to the second - `GraphHelper.cloneElements(Graph original, 
Graph clone)`. This helper method is
 primarily intended for use in tests.
 
+Upgrading for Providers
+~~~
+
+ReferenceVertex Label
+^
+
+`ReferenceVertex.label()` was hard coded to return `EMPTY_STRING`. At some 
point, `ReferenceElements` were support to
--- End diff --

i'm going with "supposed to" :smile: 


---

Re: GraphSON3 collections and subtypes

2017-09-22 Thread Robert Dale

This seems like a special case. If you use valueMap(true), then you do get
back . I still don't understand what this really has to do
with the GraphSON format and less to do with the GLV API.  Shouldn't the
GLV API have a typed return?

Robert Dale

On Fri, Sep 22, 2017 at 6:17 AM, Stephen Mallette 
wrote:

> I can't quite think of how this might work on the server side where the
> serialization takes place. You mentioned that maybe:
>
> > the graph processor could optimize by returning a specific type of
> traverser as a result of the execution of a certain traversal (in the
> example, when the valueMap is the last step).
>
> I think that we've talked about Traversers carrying meta data before.
> Perhaps that's a waynot sure.
>
> On Thu, Sep 21, 2017 at 4:47 AM, Jorge Bay Gondra <
> jorgebaygon...@gmail.com>
> wrote:
>
> > There are 2 ways that I can think of to tackle this from the .NET GLV:
> >  - Provide on demand conversion methods, for example from:
> > Dictionary (default for maps) to Dictionary.
> >  - Do an intermediate parsing, maintaining the original structure that
> gets
> > converted to the provided collection when the user inspects the result.
> > (for example, the original key/value array to Dictionary.
> >
> > There are workarounds, both have some implications...
> >
> > But this is not directly related to C#/.NET. I still think we should try
> to
> > specify the returned data in our serialization format (when thinking of
> > newer versions of GraphSON).
> >
> > On Wed, Sep 20, 2017 at 5:24 PM, Stephen Mallette 
> > wrote:
> >
> > > Is there and alternative on the GLV side? Could the GLV detect
> valueMap()
> > > as the last step and make the conversion appropriately?
> > >
> > > I haven't gone into deep thought on altering GraphSON in the manner you
> > > describe, but without knowing other options it makes me feel uneasy to
> > > think about. hehe
> > >
> > >
> > >
> > > On Wed, Sep 20, 2017 at 4:28 AM, Jorge Bay Gondra <
> > > jorgebaygon...@gmail.com>
> > > wrote:
> > >
> > > > I'm proposing the addition of a new types of map/list/set with
> > specified
> > > > child types. There is no doubt about the need of a map which keys are
> > > > objects (like in groupCount()) and the benefits of using a g:Map over
> > > plain
> > > > json objects in GraphSON3.
> > > >
> > > > > is that basically the core of the usability problem?
> > > >
> > > > I think its a specification problem, not a usability problem.
> > > > GraphTraversal interface exposes valueMap() as a method that returns
> a
> > > > Map, but the GraphSON3 specification doesn't provide an
> > > > specification of a Map with string keys so it's being returned as an
> > > > Map.
> > > >
> > > > > Is there a way to do that? how do we know what's in the Map/List
> > until
> > > we
> > > > iterate it all?
> > > >
> > > > I think its a responsibility of the graph processor, that could
> > optimize
> > > by
> > > > returning a specific type of traverser as a result of the execution
> of
> > a
> > > > certain traversal (in the example, when the valueMap is the last
> step).
> > > >
> > > >
> > > > On Tue, Sep 19, 2017 at 6:56 PM, Stephen Mallette <
> > spmalle...@gmail.com>
> > > > wrote:
> > > >
> > > > > > user is stuck with a unspecified map, which contains strings as
> > keys.
> > > > >
> > > > > so basically in .NET the result of valueMap() is stuck with
> "object"
> > > as a
> > > > > key when the user expects "string". i guess that's inconvenient. if
> > you
> > > > > iterated the keys of the dictionary and wanted to do some string
> > > > operation
> > > > > on that you'd have to cast - is that basically the core of the
> > > usability
> > > > > problem?  i tend to think it's more inconvenient to not be able to
> > get
> > > a
> > > > > proper result from groupCount() where the keys might be something
> > other
> > > > > than a string - we definitely don't want to lose that capability.
> > > > >
> > > > > >  tackle this at the source and try to specify the child types on
> > > > > serialization when we have that information.
> > > > >
> > > > > Is there a way to do that? how do we know what's in the Map/List
> > until
> > > we
> > > > > iterate it all?
> > > > >
> > > > > On Tue, Sep 19, 2017 at 12:38 PM, Jorge Bay Gondra <
> > > > > jorgebaygon...@gmail.com
> > > > > > wrote:
> > > > >
> > > > > > I wanted to bump this open discussion that after the JIRA
> > adjustments
> > > > > > probably got buried.
> > > > > >
> > > > > > On Tue, Sep 12, 2017 at 2:31 PM, Jorge Bay Gondra <
> > > > > > jorgebaygon...@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > > > Collections with unspecified child types are useful for mixed
> > > types,
> > > > > but
> > > > > > > we are reusing those types of collections for all the cases.
> > > > > > > This behaviour poses a problem for strict statically typed
> > > languages
> > > >

[jira] [Created] (TINKERPOP-1790) GraphSON 3.0 doc updates

2017-09-22 Thread Robert Dale (JIRA)

Robert Dale created TINKERPOP-1790:
--

 Summary: GraphSON 3.0 doc updates
 Key: TINKERPOP-1790
 URL: https://issues.apache.org/jira/browse/TINKERPOP-1790
 Project: TinkerPop
  Issue Type: Bug
  Components: documentation
Affects Versions: 3.3.0
Reporter: Robert Dale
Assignee: stephen mallette


The upgrade notes indicate that GraphSON 3.0 is the default and even that 1.0, 
2.0 configuration and example files have been dropped. However, the reference 
documentation  mentions only 1.0,2.0 and does not discuss 3.0 at all. This is 
confusing.

Also, and maybe this should be a separate issue, the GraphSON 3.0 section in IO 
Reference should be standalone.  Currently, the description is one sentence and 
to find out any details one has to go to the 2.0 section.
 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1731) Docker build does not appear to work for gremlin-dotnet

2017-09-22 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176275#comment-16176275
 ] 

ASF GitHub Bot commented on TINKERPOP-1731:
---

Github user jorgebay commented on the issue:

https://github.com/apache/tinkerpop/pull/719
  
Recreating `tinkerpop:base`now...


> Docker build does not appear to work for gremlin-dotnet
> ---
>
> Key: TINKERPOP-1731
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1731
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release, dotnet
>Affects Versions: 3.3.0
>Reporter: stephen mallette
>Priority: Critical
>
> Docker won't build the gremlin-dotnet stuff. I pulled out the {{.glv}} files 
> from that module so that docker would run properly until this can be fixed:
> https://github.com/apache/tinkerpop/blob/2d30a76aabdd009b9b926f83df2308b7578571c0/docker/scripts/build.sh#L71-L72



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1731) Docker build does not appear to work for gremlin-dotnet

2017-09-22 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176266#comment-16176266
 ] 

ASF GitHub Bot commented on TINKERPOP-1731:
---

Github user jorgebay commented on the issue:

https://github.com/apache/tinkerpop/pull/719
  
Maybe I have to remove the previous tinkerpop:base image?


> Docker build does not appear to work for gremlin-dotnet
> ---
>
> Key: TINKERPOP-1731
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1731
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release, dotnet
>Affects Versions: 3.3.0
>Reporter: stephen mallette
>Priority: Critical
>
> Docker won't build the gremlin-dotnet stuff. I pulled out the {{.glv}} files 
> from that module so that docker would run properly until this can be fixed:
> https://github.com/apache/tinkerpop/blob/2d30a76aabdd009b9b926f83df2308b7578571c0/docker/scripts/build.sh#L71-L72



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop issue #719: TINKERPOP-1731 Build for .NET working in docker

2017-09-22 Thread jorgebay

Github user jorgebay commented on the issue:

https://github.com/apache/tinkerpop/pull/719
  
Maybe I have to remove the previous tinkerpop:base image?


---

[jira] [Commented] (TINKERPOP-1789) Reference elements should be represented by id and label

2017-09-22 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176263#comment-16176263
 ] 

ASF GitHub Bot commented on TINKERPOP-1789:
---

Github user robertdale commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/720#discussion_r140465221
  
--- Diff: docs/src/upgrade/release-3.2.x-incubating.asciidoc ---
@@ -95,6 +95,19 @@ In `gremlin-test` there is a new `GraphHelper` class 
that has a `cloneElements()
 the first graph to the second - `GraphHelper.cloneElements(Graph original, 
Graph clone)`. This helper method is
 primarily intended for use in tests.
 
+Upgrading for Providers
+~~~
+
+ReferenceVertex Label
+^
+
+`ReferenceVertex.label()` was hard coded to return `EMPTY_STRING`. At some 
point, `ReferenceElements` were support to
--- End diff --

'to support'?


> Reference elements should be represented by id and label
> 
>
> Key: TINKERPOP-1789
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1789
> Project: TinkerPop
>  Issue Type: Bug
>  Components: io
>Affects Versions: 3.2.6
>Reporter: stephen mallette
>Assignee: Marko A. Rodriguez
>Priority: Critical
>  Labels: breaking
> Fix For: 3.2.7, 3.3.1
>
>
> Reference elements don't have {{label()}} - wow. This is a breaking change 
> because adding label to reference objects will mean that the gryo 
> serialization format will change for reference objects.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop pull request #720: TINKERPOP-1789: Reference elements should be re...

2017-09-22 Thread robertdale

Github user robertdale commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/720#discussion_r140465221
  
--- Diff: docs/src/upgrade/release-3.2.x-incubating.asciidoc ---
@@ -95,6 +95,19 @@ In `gremlin-test` there is a new `GraphHelper` class 
that has a `cloneElements()
 the first graph to the second - `GraphHelper.cloneElements(Graph original, 
Graph clone)`. This helper method is
 primarily intended for use in tests.
 
+Upgrading for Providers
+~~~
+
+ReferenceVertex Label
+^
+
+`ReferenceVertex.label()` was hard coded to return `EMPTY_STRING`. At some 
point, `ReferenceElements` were support to
--- End diff --

'to support'?


---

[jira] [Commented] (TINKERPOP-1731) Docker build does not appear to work for gremlin-dotnet

2017-09-22 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176257#comment-16176257
 ] 

ASF GitHub Bot commented on TINKERPOP-1731:
---

Github user jorgebay commented on the issue:

https://github.com/apache/tinkerpop/pull/719
  
I've got a failure on Gremlin Python:

```
[INFO] --- maven-antrun-plugin:1.8:run (setup-py-env) @ gremlin-python ---
[WARNING] Parameter tasks is deprecated, use target instead
[INFO] Executing tasks

main:
 [copy] Copying 44 files to 
/usr/src/tinkerpop/gremlin-python/target/python3
 [copy] Copying 44 files to 
/usr/src/tinkerpop/gremlin-python/target/python2
 [copy] Copying 44 files to 
/usr/src/tinkerpop/gremlin-python/target/python-packaged
[INFO] 

[INFO] Reactor Summary:
[INFO] 
[INFO] Apache TinkerPop .. SUCCESS 
[3:13.218s]
[INFO] Apache TinkerPop :: Gremlin Shaded  SUCCESS [30.870s]
[INFO] Apache TinkerPop :: Gremlin Core .. SUCCESS 
[1:04.724s]
[INFO] Apache TinkerPop :: Gremlin Test .. SUCCESS [5.845s]
[INFO] Apache TinkerPop :: Gremlin Groovy  SUCCESS 
[6:45.098s]
[INFO] Apache TinkerPop :: Gremlin Groovy Test ... SUCCESS [3.929s]
[INFO] Apache TinkerPop :: TinkerGraph Gremlin ... SUCCESS 
[6:09.785s]
[INFO] Apache TinkerPop :: Gremlin Benchmark . SUCCESS [7.064s]
[INFO] Apache TinkerPop :: Gremlin Driver  SUCCESS 
[1:42.859s]
[INFO] Apache TinkerPop :: Neo4j Gremlin . SUCCESS 
[21:10.620s]
[INFO] Apache TinkerPop :: Gremlin Server  SUCCESS 
[16:43.687s]
[INFO] Apache TinkerPop :: Gremlin Python  FAILURE 
[1:11.484s]
[INFO] Apache TinkerPop :: Gremlin.Net ... SKIPPED
[INFO] Apache TinkerPop :: Gremlin.Net - Source .. SKIPPED
[INFO] Apache TinkerPop :: Gremlin.Net - Tests ... SKIPPED
[INFO] Apache TinkerPop :: Hadoop Gremlin  SKIPPED
[INFO] Apache TinkerPop :: Spark Gremlin . SKIPPED
[INFO] Apache TinkerPop :: Giraph Gremlin  SKIPPED
[INFO] Apache TinkerPop :: Gremlin Console ... SKIPPED
[INFO] Apache TinkerPop :: Gremlin Archetype . SKIPPED
[INFO] Apache TinkerPop :: Archetype - TinkerGraph ... SKIPPED
[INFO] Apache TinkerPop :: Archetype - Server  SKIPPED
[INFO] Apache TinkerPop :: Archetype - DSL ... SKIPPED
[INFO] 

[INFO] BUILD FAILURE
[INFO] 

[INFO] Total time: 59:06.197s
[INFO] Finished at: Fri Sep 22 10:39:06 UTC 2017
[INFO] Final Memory: 137M/338M
[INFO] 

[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-antrun-plugin:1.8:run (setup-py-env) on project 
gremlin-python: An Ant BuildException has occured: Execute failed: 
java.io.IOException: Cannot run program "virtualenv" (in directory 
"/usr/src/tinkerpop/gremlin-python/target/python2"): error=2, No such file or 
directory
[ERROR] around Ant part .. @ 13:107 in 
/usr/src/tinkerpop/gremlin-python/target/antrun/build-main.xml
```


> Docker build does not appear to work for gremlin-dotnet
> ---
>
> Key: TINKERPOP-1731
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1731
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release, dotnet
>Affects Versions: 3.3.0
>Reporter: stephen mallette
>Priority: Critical
>
> Docker won't build the gremlin-dotnet stuff. I pulled out the {{.glv}} files 
> from that module so that docker would run properly until this can be fixed:
> https://github.com/apache/tinkerpop/blob/2d30a76aabdd009b9b926f83df2308b7578571c0/docker/scripts/build.sh#L71-L72



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop issue #719: TINKERPOP-1731 Build for .NET working in docker

2017-09-22 Thread jorgebay

Github user jorgebay commented on the issue:

https://github.com/apache/tinkerpop/pull/719
  
I've got a failure on Gremlin Python:

```
[INFO] --- maven-antrun-plugin:1.8:run (setup-py-env) @ gremlin-python ---
[WARNING] Parameter tasks is deprecated, use target instead
[INFO] Executing tasks

main:
 [copy] Copying 44 files to 
/usr/src/tinkerpop/gremlin-python/target/python3
 [copy] Copying 44 files to 
/usr/src/tinkerpop/gremlin-python/target/python2
 [copy] Copying 44 files to 
/usr/src/tinkerpop/gremlin-python/target/python-packaged
[INFO] 

[INFO] Reactor Summary:
[INFO] 
[INFO] Apache TinkerPop .. SUCCESS 
[3:13.218s]
[INFO] Apache TinkerPop :: Gremlin Shaded  SUCCESS [30.870s]
[INFO] Apache TinkerPop :: Gremlin Core .. SUCCESS 
[1:04.724s]
[INFO] Apache TinkerPop :: Gremlin Test .. SUCCESS [5.845s]
[INFO] Apache TinkerPop :: Gremlin Groovy  SUCCESS 
[6:45.098s]
[INFO] Apache TinkerPop :: Gremlin Groovy Test ... SUCCESS [3.929s]
[INFO] Apache TinkerPop :: TinkerGraph Gremlin ... SUCCESS 
[6:09.785s]
[INFO] Apache TinkerPop :: Gremlin Benchmark . SUCCESS [7.064s]
[INFO] Apache TinkerPop :: Gremlin Driver  SUCCESS 
[1:42.859s]
[INFO] Apache TinkerPop :: Neo4j Gremlin . SUCCESS 
[21:10.620s]
[INFO] Apache TinkerPop :: Gremlin Server  SUCCESS 
[16:43.687s]
[INFO] Apache TinkerPop :: Gremlin Python  FAILURE 
[1:11.484s]
[INFO] Apache TinkerPop :: Gremlin.Net ... SKIPPED
[INFO] Apache TinkerPop :: Gremlin.Net - Source .. SKIPPED
[INFO] Apache TinkerPop :: Gremlin.Net - Tests ... SKIPPED
[INFO] Apache TinkerPop :: Hadoop Gremlin  SKIPPED
[INFO] Apache TinkerPop :: Spark Gremlin . SKIPPED
[INFO] Apache TinkerPop :: Giraph Gremlin  SKIPPED
[INFO] Apache TinkerPop :: Gremlin Console ... SKIPPED
[INFO] Apache TinkerPop :: Gremlin Archetype . SKIPPED
[INFO] Apache TinkerPop :: Archetype - TinkerGraph ... SKIPPED
[INFO] Apache TinkerPop :: Archetype - Server  SKIPPED
[INFO] Apache TinkerPop :: Archetype - DSL ... SKIPPED
[INFO] 

[INFO] BUILD FAILURE
[INFO] 

[INFO] Total time: 59:06.197s
[INFO] Finished at: Fri Sep 22 10:39:06 UTC 2017
[INFO] Final Memory: 137M/338M
[INFO] 

[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-antrun-plugin:1.8:run (setup-py-env) on project 
gremlin-python: An Ant BuildException has occured: Execute failed: 
java.io.IOException: Cannot run program "virtualenv" (in directory 
"/usr/src/tinkerpop/gremlin-python/target/python2"): error=2, No such file or 
directory
[ERROR] around Ant part .. @ 13:107 in 
/usr/src/tinkerpop/gremlin-python/target/antrun/build-main.xml
```


---

Re: GraphSON3 collections and subtypes

2017-09-22 Thread Stephen Mallette

I can't quite think of how this might work on the server side where the
serialization takes place. You mentioned that maybe:

> the graph processor could optimize by returning a specific type of
traverser as a result of the execution of a certain traversal (in the
example, when the valueMap is the last step).

I think that we've talked about Traversers carrying meta data before.
Perhaps that's a waynot sure.

On Thu, Sep 21, 2017 at 4:47 AM, Jorge Bay Gondra 
wrote:

> There are 2 ways that I can think of to tackle this from the .NET GLV:
>  - Provide on demand conversion methods, for example from:
> Dictionary (default for maps) to Dictionary.
>  - Do an intermediate parsing, maintaining the original structure that gets
> converted to the provided collection when the user inspects the result.
> (for example, the original key/value array to Dictionary.
>
> There are workarounds, both have some implications...
>
> But this is not directly related to C#/.NET. I still think we should try to
> specify the returned data in our serialization format (when thinking of
> newer versions of GraphSON).
>
> On Wed, Sep 20, 2017 at 5:24 PM, Stephen Mallette 
> wrote:
>
> > Is there and alternative on the GLV side? Could the GLV detect valueMap()
> > as the last step and make the conversion appropriately?
> >
> > I haven't gone into deep thought on altering GraphSON in the manner you
> > describe, but without knowing other options it makes me feel uneasy to
> > think about. hehe
> >
> >
> >
> > On Wed, Sep 20, 2017 at 4:28 AM, Jorge Bay Gondra <
> > jorgebaygon...@gmail.com>
> > wrote:
> >
> > > I'm proposing the addition of a new types of map/list/set with
> specified
> > > child types. There is no doubt about the need of a map which keys are
> > > objects (like in groupCount()) and the benefits of using a g:Map over
> > plain
> > > json objects in GraphSON3.
> > >
> > > > is that basically the core of the usability problem?
> > >
> > > I think its a specification problem, not a usability problem.
> > > GraphTraversal interface exposes valueMap() as a method that returns a
> > > Map, but the GraphSON3 specification doesn't provide an
> > > specification of a Map with string keys so it's being returned as an
> > > Map.
> > >
> > > > Is there a way to do that? how do we know what's in the Map/List
> until
> > we
> > > iterate it all?
> > >
> > > I think its a responsibility of the graph processor, that could
> optimize
> > by
> > > returning a specific type of traverser as a result of the execution of
> a
> > > certain traversal (in the example, when the valueMap is the last step).
> > >
> > >
> > > On Tue, Sep 19, 2017 at 6:56 PM, Stephen Mallette <
> spmalle...@gmail.com>
> > > wrote:
> > >
> > > > > user is stuck with a unspecified map, which contains strings as
> keys.
> > > >
> > > > so basically in .NET the result of valueMap() is stuck with "object"
> > as a
> > > > key when the user expects "string". i guess that's inconvenient. if
> you
> > > > iterated the keys of the dictionary and wanted to do some string
> > > operation
> > > > on that you'd have to cast - is that basically the core of the
> > usability
> > > > problem?  i tend to think it's more inconvenient to not be able to
> get
> > a
> > > > proper result from groupCount() where the keys might be something
> other
> > > > than a string - we definitely don't want to lose that capability.
> > > >
> > > > >  tackle this at the source and try to specify the child types on
> > > > serialization when we have that information.
> > > >
> > > > Is there a way to do that? how do we know what's in the Map/List
> until
> > we
> > > > iterate it all?
> > > >
> > > > On Tue, Sep 19, 2017 at 12:38 PM, Jorge Bay Gondra <
> > > > jorgebaygon...@gmail.com
> > > > > wrote:
> > > >
> > > > > I wanted to bump this open discussion that after the JIRA
> adjustments
> > > > > probably got buried.
> > > > >
> > > > > On Tue, Sep 12, 2017 at 2:31 PM, Jorge Bay Gondra <
> > > > > jorgebaygon...@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > Collections with unspecified child types are useful for mixed
> > types,
> > > > but
> > > > > > we are reusing those types of collections for all the cases.
> > > > > > This behaviour poses a problem for strict statically typed
> > languages
> > > > like
> > > > > > C#. Let's see if I can explain myself with an example:
> > > > > >
> > > > > > valueMap() step yields a map representation. In GraphSON2, it was
> > > > > returned
> > > > > > as a js object (where keys are always strings), that were mapped
> to
> > > C#
> > > > > > Dictionary (equivalent of java's Map > > Object>).
> > > > > > In GraphSON3, it's returned as a "g:Map", that is mapped to C#
> > > > > > Dictionary. As there is no type coercion (ie:
> type
> > > > > erasure
> > > > > > in java) for Dictionary to

39 matches

Mail list logo