Re: [DISCUSS] Leaner version of detached vertex

[Stephen Mallette]

There already is a leaner version - ReferenceVertex (and similar Reference*
classes). It is just what you are asking for with id and label returned
with nothing else. Currently this is the default return value for Gremlin
Language Variants - so if you use Gremlin Python, for example, you only get
back the id/label for a vertex. We've not changed that for Gremlin string
based traversals, which still return Detached*, because it would cause too
great a break for too many users at this point. There are a few ways to
configure Gremlin Server to return Reference* but the best way is to
configured the GraphTraversalSource with HaltedTraverserStrategy and
specify that it use the ReferenceFactory for detachment.

On Fri, Jan 12, 2018 at 8:41 PM, Divij Vaidya 
wrote:

> Hello,
>
> I have a question regarding the implementation of serializers. This
> question holds true for Gryo as well as Graphson.
>
> What is the motivation for adding properties associated with the Vertex in
> the serialized result sent back to the client? I understand that a
> DetachedVertex is defined by the vertex along with the properties, but in
> cases when the client is only interested in projecting out the vertex with
> Id and Label, the additional computation & serialization of properties is
> unnecessary.
>
> Do you think it would be an idea worth considering to create a leaner
> version of detached vertex which consists of only the Id of the vertex?
> This leaner implementation should be the output to queries which project
> out a vertex such as g.V(1).
>
> Serializer code reference: https://github.com/apache/tinkerpop/blob/
> 4062898a0d15de030b656283a038eaa7c0b128d0/gremlin-core/src/
> main/java/org/apache/tinkerpop/gremlin/structure/
> io/gryo/GryoSerializersV3d0.java#L132
>
> Regards,
> Divij
>

[DISCUSS] Leaner version of detached vertex

[Divij Vaidya]

Hello,

I have a question regarding the implementation of serializers. This
question holds true for Gryo as well as Graphson.

What is the motivation for adding properties associated with the Vertex in
the serialized result sent back to the client? I understand that a
DetachedVertex is defined by the vertex along with the properties, but in
cases when the client is only interested in projecting out the vertex with
Id and Label, the additional computation & serialization of properties is
unnecessary.

Do you think it would be an idea worth considering to create a leaner
version of detached vertex which consists of only the Id of the vertex?
This leaner implementation should be the output to queries which project
out a vertex such as g.V(1).

Serializer code reference: https://github.com/apache/tinkerpop/blob/
4062898a0d15de030b656283a038eaa7c0b128d0/gremlin-core/src/
main/java/org/apache/tinkerpop/gremlin/structure/
io/gryo/GryoSerializersV3d0.java#L132

Regards,
Divij

[jira] [Commented] (TINKERPOP-1869) Profile step and iterate do not play nicely with each other

[Robert Dale (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324432#comment-16324432
 ] 

Robert Dale commented on TINKERPOP-1869:


Is this with remote connections only?

> Profile step and iterate do not play nicely with each other
> ---
>
> Key: TINKERPOP-1869
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1869
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.3.1
>Reporter: Bryn Cooke
>
> Profile step doesn't like it if there are any other steps after it. However 
> if someone calls profile().iterate() they will get an error as iterate 
> appends a NoneStep to the end of the traversal.
> Even though this means that the results of the profile would never be 
> returned I think that profile step should allow None step to follow it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1858) HttpChannelizer regression: Does not create specified AuthenticationHandler

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324379#comment-16324379
 ] 

ASF GitHub Bot commented on TINKERPOP-1858:
---

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/767
  
VOTE: +1


> HttpChannelizer regression: Does not create specified AuthenticationHandler
> ---
>
> Key: TINKERPOP-1858
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1858
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.3.0
> Environment: All
>Reporter: Keith Lohnes
>  Labels: easyfix, regression
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> HttpChannelizer creates a HttpBasicAuthenticationHandler instead of 
> instantiating the specified AuthenticationHandler from the configuration



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

[dkuppitz]

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/767
  
VOTE: +1


---

[jira] [Commented] (TINKERPOP-1860) valueMap(True) result in error in gremlin-python

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324367#comment-16324367
 ] 

ASF GitHub Bot commented on TINKERPOP-1860:
---

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/774
  
VOTE: +1


> valueMap(True) result in error in gremlin-python
> 
>
> Key: TINKERPOP-1860
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1860
> Project: TinkerPop
>  Issue Type: Bug
>  Components: python
>Affects Versions: 3.3.0
> Environment: Windows 10
> jvm 1.8, python 3.5
> tinkerpop 3.3.0
>Reporter: yokota masanori
>Priority: Minor
>
> I use [True] value as a argument of valueMap() step.  And it result in error 
> as below.
> (This error didn't occur in Groovy Query and return list of Value Map with id 
> and label)
> // Python 
> graph = Graph()
> g = 
> graph.traversal().withRemote(DriverRemoteConnection('ws://localhost:8182/gremlin','g'))
> g.V().valueMap(True).toList()
> =>
> TypeError 
> > 1 g.V().valueMap(True).toList()
>  ...
>  ~\site-packages\gremlin_python\structure\io\graphsonV3d0.py in 
> objectify(cls, l, reader)
> 453 x = 0
> 454 while x < len(l):
> --> 455 new_dict[reader.toObject(l[x])] = reader.toObject(l[x 
> + 1])
> 456 x = x + 2
> 457 return new_dict
> TypeError: unhashable type: 'dict'



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1860) valueMap(True) result in error in gremlin-python

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324365#comment-16324365
 ] 

ASF GitHub Bot commented on TINKERPOP-1860:
---

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/773
  
VOTE: +1


> valueMap(True) result in error in gremlin-python
> 
>
> Key: TINKERPOP-1860
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1860
> Project: TinkerPop
>  Issue Type: Bug
>  Components: python
>Affects Versions: 3.3.0
> Environment: Windows 10
> jvm 1.8, python 3.5
> tinkerpop 3.3.0
>Reporter: yokota masanori
>Priority: Minor
>
> I use [True] value as a argument of valueMap() step.  And it result in error 
> as below.
> (This error didn't occur in Groovy Query and return list of Value Map with id 
> and label)
> // Python 
> graph = Graph()
> g = 
> graph.traversal().withRemote(DriverRemoteConnection('ws://localhost:8182/gremlin','g'))
> g.V().valueMap(True).toList()
> =>
> TypeError 
> > 1 g.V().valueMap(True).toList()
>  ...
>  ~\site-packages\gremlin_python\structure\io\graphsonV3d0.py in 
> objectify(cls, l, reader)
> 453 x = 0
> 454 while x < len(l):
> --> 455 new_dict[reader.toObject(l[x])] = reader.toObject(l[x 
> + 1])
> 456 x = x + 2
> 457 return new_dict
> TypeError: unhashable type: 'dict'



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop issue #774: TINKERPOP-1860 valueMap(true) support/testing

[dkuppitz]

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/774
  
VOTE: +1


---

[GitHub] tinkerpop issue #773: TINKERPOP-1860 Added tests for valueMap(true) variatio...

[dkuppitz]

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/773
  
VOTE: +1


---

[jira] [Created] (TINKERPOP-1869) Profile step and iterate do not play nicely with each other

[Bryn Cooke (JIRA)]

Bryn Cooke created TINKERPOP-1869:
-

 Summary: Profile step and iterate do not play nicely with each 
other
 Key: TINKERPOP-1869
 URL: https://issues.apache.org/jira/browse/TINKERPOP-1869
 Project: TinkerPop
  Issue Type: Bug
  Components: process
Affects Versions: 3.3.1
Reporter: Bryn Cooke


Profile step doesn't like it if there are any other steps after it. However if 
someone calls profile().iterate() they will get an error as iterate appends a 
NoneStep to the end of the traversal.
Even though this means that the results of the profile would never be returned 
I think that profile step should allow None step to follow it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)