[GitHub] tinkerpop issue #842: TINKERPOP-1945
Github user danielcweber commented on the issue: https://github.com/apache/tinkerpop/pull/842 Revised based on the comments, rebased onto the current tp32 branch. ---
[jira] [Commented] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577960#comment-16577960 ] ASF GitHub Bot commented on TINKERPOP-1945: --- Github user danielcweber commented on the issue: https://github.com/apache/tinkerpop/pull/842 Revised based on the comments, rebased onto the current tp32 branch. > Add support for extended GraphSon types to Gremlin.net > -- > > Key: TINKERPOP-1945 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1945 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Reporter: Daniel C. Weber >Priority: Minor > > While Gremlin.net can properly serialize and deserialize all of the core > GraphSon types, support for most of the extended types as described > [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #898: gremlin-javascript: Typescript typings definition
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/898 Nice @daem0ndev! I think its a good idea to provide typing definitions inside the package. [Gremlin Variant APIs](http://tinkerpop.apache.org/docs/current/tutorials/gremlin-language-variants/) like gremlin-javascript are generated from the Java API using a set of groovy templates and scripts, see https://github.com/apache/tinkerpop/blob/master/gremlin-javascript/glv/generate.groovy for example. We should do the same in this case, do you want to adapt your pull request to generate the `.ts` file? Also, could you target `tp32` branch instead? ---
[GitHub] tinkerpop issue #898: gremlin-javascript: Typescript typings definition
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/898 That was going to be my suggestion too - I think that it can be auto-generated then it should be. ---
[GitHub] tinkerpop issue #842: TINKERPOP-1945
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/842 Great, thanks for making those changes. My VOTE +1 from nearly 3 months ago still holds with these recent changes. ---
[jira] [Commented] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578175#comment-16578175 ] ASF GitHub Bot commented on TINKERPOP-1945: --- Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/842 Great, thanks for making those changes. My VOTE +1 from nearly 3 months ago still holds with these recent changes. > Add support for extended GraphSon types to Gremlin.net > -- > > Key: TINKERPOP-1945 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1945 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Reporter: Daniel C. Weber >Priority: Minor > > While Gremlin.net can properly serialize and deserialize all of the core > GraphSon types, support for most of the extended types as described > [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop pull request #842: TINKERPOP-1945
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/842#discussion_r209598480 --- Diff: gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj --- @@ -48,7 +48,7 @@ Please see the reference documentation at Apache TinkerPop for more information - + --- End diff -- I don't understand the need to bump the json dependency of the actual Gremlin.Net library. ---
[jira] [Commented] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578251#comment-16578251 ] ASF GitHub Bot commented on TINKERPOP-1945: --- Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/842#discussion_r209598480 --- Diff: gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj --- @@ -48,7 +48,7 @@ Please see the reference documentation at Apache TinkerPop for more information - + --- End diff -- I don't understand the need to bump the json dependency of the actual Gremlin.Net library. > Add support for extended GraphSon types to Gremlin.net > -- > > Key: TINKERPOP-1945 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1945 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Reporter: Daniel C. Weber >Priority: Minor > > While Gremlin.net can properly serialize and deserialize all of the core > GraphSon types, support for most of the extended types as described > [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578264#comment-16578264 ] ASF GitHub Bot commented on TINKERPOP-1945: --- Github user FlorianHockmann commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/842#discussion_r209602159 --- Diff: gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj --- @@ -48,7 +48,7 @@ Please see the reference documentation at Apache TinkerPop for more information - + --- End diff -- The reason was that this version of Newtonsoft.Json couldn't deserialize _TooBigInteger_ according to @danielcweber and I didn't see a good reason why we shouldn't update the dependency. Are you against the version bump? > Add support for extended GraphSon types to Gremlin.net > -- > > Key: TINKERPOP-1945 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1945 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Reporter: Daniel C. Weber >Priority: Minor > > While Gremlin.net can properly serialize and deserialize all of the core > GraphSon types, support for most of the extended types as described > [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop pull request #842: TINKERPOP-1945
Github user FlorianHockmann commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/842#discussion_r209602159 --- Diff: gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj --- @@ -48,7 +48,7 @@ Please see the reference documentation at Apache TinkerPop for more information - + --- End diff -- The reason was that this version of Newtonsoft.Json couldn't deserialize _TooBigInteger_ according to @danielcweber and I didn't see a good reason why we shouldn't update the dependency. Are you against the version bump? ---
[GitHub] tinkerpop pull request #842: TINKERPOP-1945
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/842#discussion_r209605835 --- Diff: gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj --- @@ -48,7 +48,7 @@ Please see the reference documentation at Apache TinkerPop for more information - + --- End diff -- Not against, but it's always another variable that might impact upstream users. The good news is that v11 of Json.NET has an specific target for netstandard2.0 as we do, so it will require fewer downstream dependencies :) http://james.newtonking.com/archive/2018/02/22/json-net-11-0-release-1-net-standard-2-0-jsonconverters-json-path-and-more ---
[GitHub] tinkerpop issue #842: TINKERPOP-1945
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/842 LGTM! VOTE: +1. Thanks @danielcweber for the contribution! Note to committers: I think it would be better to squash the commits ahead of the merge. ---
[jira] [Commented] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578273#comment-16578273 ] ASF GitHub Bot commented on TINKERPOP-1945: --- Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/842#discussion_r209605835 --- Diff: gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj --- @@ -48,7 +48,7 @@ Please see the reference documentation at Apache TinkerPop for more information - + --- End diff -- Not against, but it's always another variable that might impact upstream users. The good news is that v11 of Json.NET has an specific target for netstandard2.0 as we do, so it will require fewer downstream dependencies :) http://james.newtonking.com/archive/2018/02/22/json-net-11-0-release-1-net-standard-2-0-jsonconverters-json-path-and-more > Add support for extended GraphSon types to Gremlin.net > -- > > Key: TINKERPOP-1945 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1945 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Reporter: Daniel C. Weber >Priority: Minor > > While Gremlin.net can properly serialize and deserialize all of the core > GraphSon types, support for most of the extended types as described > [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578276#comment-16578276 ] ASF GitHub Bot commented on TINKERPOP-1945: --- Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/842 LGTM! VOTE: +1. Thanks @danielcweber for the contribution! Note to committers: I think it would be better to squash the commits ahead of the merge. > Add support for extended GraphSon types to Gremlin.net > -- > > Key: TINKERPOP-1945 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1945 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Reporter: Daniel C. Weber >Priority: Minor > > While Gremlin.net can properly serialize and deserialize all of the core > GraphSon types, support for most of the extended types as described > [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop pull request #842: TINKERPOP-1945
Github user FlorianHockmann commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/842#discussion_r209610435 --- Diff: gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj --- @@ -48,7 +48,7 @@ Please see the reference documentation at Apache TinkerPop for more information - + --- End diff -- That's why I wanted to upgrade Newtonsoft.Json for the next release anyway. ---
[jira] [Commented] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578286#comment-16578286 ] ASF GitHub Bot commented on TINKERPOP-1945: --- Github user FlorianHockmann commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/842#discussion_r209610435 --- Diff: gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj --- @@ -48,7 +48,7 @@ Please see the reference documentation at Apache TinkerPop for more information - + --- End diff -- That's why I wanted to upgrade Newtonsoft.Json for the next release anyway. > Add support for extended GraphSon types to Gremlin.net > -- > > Key: TINKERPOP-1945 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1945 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Reporter: Daniel C. Weber >Priority: Minor > > While Gremlin.net can properly serialize and deserialize all of the core > GraphSon types, support for most of the extended types as described > [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop pull request #889: Tinkerpop 1977 - Sasl Authentication
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/889#discussion_r209620249
--- Diff:
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/auth/sasl-authenticator.js
---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+'use strict';
+
+const Authenticator = require('./authenticator');
+
+class SaslAuthenticator extends Authenticator {
+ /**
+ * Creates a new instance of SaslAuthenticator.
+ * @param {Object} [options] The authentication options.
+ * @param {Object} [options.mechanism] The mechanism to be used for
authentication.
+ * @constructor
+ */
+ constructor(options) {
+super(options);
+
+if (options.mechanism === null || options.mechanism === undefined) {
+ throw new Error('No Sasl Mechanism Specified');
+}
+ }
+
+ /**
+ * Evaluates the challenge from the server and returns appropriate
response.
+ * @param {String} challenge Challenge string presented by the server.
+ * @return {Object} A Promise that resolves to a valid sasl response
object.
+ */
+ evaluateChallenge(challenge) {
+return
Promise.resolve(this._options.mechanism.evaluateChallenge(challenge));
--- End diff --
I think we should not use `Promise.resolve()` here, we should rely on the
return value of the mechanism (a `Promise`).
---
[GitHub] tinkerpop pull request #889: Tinkerpop 1977 - Sasl Authentication
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/889#discussion_r209628120
--- Diff:
gremlin-javascript/src/main/javascript/gremlin-javascript/test/integration/sasl-authentication-tests.js
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/**
+ * @author Jorge Bay Gondra
+ */
+'use strict';
+
+const assert = require('assert');
+const Bytecode = require('../../lib/process/bytecode');
+const graphModule = require('../../lib/structure/graph');
+const helper = require('../helper');
+
+let connection;
+
+describe('DriverRemoteConnectionWithSaslAuthenticator', function () {
+ before(function () {
+this.timeout(2);
+connection = helper.getSecureConnectionWithAuthenticator(null);
+return connection.open();
+ });
+ after(function () {
+return connection.close();
+ });
+ describe('#submit()', function () {
+it('should send the request with valid credentials and parse the
response', function () {
+ return connection.submit(new Bytecode().addStep('V',
[]).addStep('tail', []))
+.then(function (response) {
+ assert.ok(response);
+ assert.ok(response.traversers);
+ //assert.strictEqual(response.traversers.length, 1);
--- End diff --
NIT: remove commented out lines.
---
[GitHub] tinkerpop pull request #889: Tinkerpop 1977 - Sasl Authentication
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/889#discussion_r209616766 --- Diff: gremlin-javascript/src/main/javascript/gremlin-javascript/test/integration/sasl-authentication-tests.js --- @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/** + * @author Jorge Bay Gondra --- End diff -- Probably unintended copy/paste :) ---
[GitHub] tinkerpop pull request #911: TINKERPOP-2024 Make server archetype use remote...
GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/911 TINKERPOP-2024 Make server archetype use remote traversal https://issues.apache.org/jira/browse/TINKERPOP-2024 Since we're promoting remote traversals over scripts it would be better for the archetype to use them. Builds with `mvn clean install` VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-2024 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/911.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #911 commit 1a3549f7232ebe65cbba158c1442a567bc2dc695 Author: Stephen Mallette Date: 2018-08-13T14:28:53Z TINKERPOP-2024 Make server archetype use remote traversal Since we're promoting remote traversals over scripts it would be better for the archetype to use them. ---
[jira] [Commented] (TINKERPOP-2024) Gremlin Server Application archetype should connect via withRemote
[
https://issues.apache.org/jira/browse/TINKERPOP-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578341#comment-16578341
]
ASF GitHub Bot commented on TINKERPOP-2024:
---
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/911
TINKERPOP-2024 Make server archetype use remote traversal
https://issues.apache.org/jira/browse/TINKERPOP-2024
Since we're promoting remote traversals over scripts it would be better for
the archetype to use them.
Builds with `mvn clean install`
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-2024
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/911.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #911
commit 1a3549f7232ebe65cbba158c1442a567bc2dc695
Author: Stephen Mallette
Date: 2018-08-13T14:28:53Z
TINKERPOP-2024 Make server archetype use remote traversal
Since we're promoting remote traversals over scripts it would be better for
the archetype to use them.
> Gremlin Server Application archetype should connect via withRemote
> --
>
> Key: TINKERPOP-2024
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2024
> Project: TinkerPop
> Issue Type: Improvement
> Components: documentation, server
>Affects Versions: 3.2.9
>Reporter: Florian Hockmann
>Priority: Minor
>
> We seem to have established consensus that Gremlin Bytecode is the preferred
> way to execute Gremlin traversals instead of sending traversals as scripts to
> the server for execution. The Gremlin Server Application Maven archetype
> however still only uses the script variant:
> {code:java}
> public List findCreatorsOfSoftware(String softwareName) throws
> Exception {
> // it is very important from a performance perspective to parameterize
> queries
> Map params = new HashMap();
> params.put("n", softwareName);
> return
> client.submit("g.V().hasLabel('software').has('name',n).in('created').values('name')",
> params)
> .all().get().stream().map(r ->
> r.getString()).collect(Collectors.toList());
> }
> {code}
> Since new users can use this archetype to get started with Gremlin, we should
> encourage best practices and therefore connect via {{withRemote}} to send the
> traversal as Bytecode.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (TINKERPOP-2024) Gremlin Server Application archetype should connect via withRemote
[
https://issues.apache.org/jira/browse/TINKERPOP-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette reassigned TINKERPOP-2024:
---
Assignee: stephen mallette
> Gremlin Server Application archetype should connect via withRemote
> --
>
> Key: TINKERPOP-2024
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2024
> Project: TinkerPop
> Issue Type: Improvement
> Components: documentation, server
>Affects Versions: 3.2.9
>Reporter: Florian Hockmann
>Assignee: stephen mallette
>Priority: Minor
>
> We seem to have established consensus that Gremlin Bytecode is the preferred
> way to execute Gremlin traversals instead of sending traversals as scripts to
> the server for execution. The Gremlin Server Application Maven archetype
> however still only uses the script variant:
> {code:java}
> public List findCreatorsOfSoftware(String softwareName) throws
> Exception {
> // it is very important from a performance perspective to parameterize
> queries
> Map params = new HashMap();
> params.put("n", softwareName);
> return
> client.submit("g.V().hasLabel('software').has('name',n).in('created').values('name')",
> params)
> .all().get().stream().map(r ->
> r.getString()).collect(Collectors.toList());
> }
> {code}
> Since new users can use this archetype to get started with Gremlin, we should
> encourage best practices and therefore connect via {{withRemote}} to send the
> traversal as Bytecode.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop issue #908: TINKERPOP-2017 Add check for Column in `by(Function)`
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/908 Cherry picked this commit to tp32 - a0a243b256dbfdf66bb5ce24958fc91c7e6eed03 ---
[jira] [Commented] (TINKERPOP-2017) Check for Column in by()
[
https://issues.apache.org/jira/browse/TINKERPOP-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578349#comment-16578349
]
ASF GitHub Bot commented on TINKERPOP-2017:
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/908
Cherry picked this commit to tp32 - a0a243b256dbfdf66bb5ce24958fc91c7e6eed03
> Check for Column in by()
>
>
> Key: TINKERPOP-2017
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2017
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.2.9
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
>
> The {{by(Function)}} doesn't check for {{Column}}:
> https://github.com/apache/tinkerpop/blob/a14cf28f45742f47f15b768a90355ca9e9e89e17/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/ByModulating.java#L57
> as it does here:
> https://github.com/apache/tinkerpop/blob/a14cf28f45742f47f15b768a90355ca9e9e89e17/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/ByModulating.java#L94
> Seems like it would be better to just add:
> {code}
> if (function instanceof Column)
> this.modulateBy(new ColumnTraversal((Column) function))
> {code}
> Mentioned here on the user list:
> https://groups.google.com/d/msg/gremlin-users/Y0fez_aLdqs/nyUKQkO_AAAJ
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop pull request #908: TINKERPOP-2017 Add check for Column in `by(Func...
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/908 ---
[jira] [Commented] (TINKERPOP-2017) Check for Column in by()
[
https://issues.apache.org/jira/browse/TINKERPOP-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578351#comment-16578351
]
ASF GitHub Bot commented on TINKERPOP-2017:
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/908
> Check for Column in by()
>
>
> Key: TINKERPOP-2017
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2017
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.2.9
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
> Fix For: 3.4.0, 3.3.4, 3.2.10
>
>
> The {{by(Function)}} doesn't check for {{Column}}:
> https://github.com/apache/tinkerpop/blob/a14cf28f45742f47f15b768a90355ca9e9e89e17/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/ByModulating.java#L57
> as it does here:
> https://github.com/apache/tinkerpop/blob/a14cf28f45742f47f15b768a90355ca9e9e89e17/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/ByModulating.java#L94
> Seems like it would be better to just add:
> {code}
> if (function instanceof Column)
> this.modulateBy(new ColumnTraversal((Column) function))
> {code}
> Mentioned here on the user list:
> https://groups.google.com/d/msg/gremlin-users/Y0fez_aLdqs/nyUKQkO_AAAJ
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (TINKERPOP-2017) Check for Column in by()
[
https://issues.apache.org/jira/browse/TINKERPOP-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-2017.
---
Resolution: Done
Fix Version/s: 3.2.10
3.3.4
3.4.0
> Check for Column in by()
>
>
> Key: TINKERPOP-2017
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2017
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.2.9
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
> Fix For: 3.4.0, 3.3.4, 3.2.10
>
>
> The {{by(Function)}} doesn't check for {{Column}}:
> https://github.com/apache/tinkerpop/blob/a14cf28f45742f47f15b768a90355ca9e9e89e17/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/ByModulating.java#L57
> as it does here:
> https://github.com/apache/tinkerpop/blob/a14cf28f45742f47f15b768a90355ca9e9e89e17/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/ByModulating.java#L94
> Seems like it would be better to just add:
> {code}
> if (function instanceof Column)
> this.modulateBy(new ColumnTraversal((Column) function))
> {code}
> Mentioned here on the user list:
> https://groups.google.com/d/msg/gremlin-users/Y0fez_aLdqs/nyUKQkO_AAAJ
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop issue #842: TINKERPOP-1945
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/842 I'm working on merging this now. ---
[jira] [Commented] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578359#comment-16578359 ] ASF GitHub Bot commented on TINKERPOP-1945: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/842 I'm working on merging this now. > Add support for extended GraphSon types to Gremlin.net > -- > > Key: TINKERPOP-1945 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1945 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Reporter: Daniel C. Weber >Priority: Minor > > While Gremlin.net can properly serialize and deserialize all of the core > GraphSon types, support for most of the extended types as described > [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #842: TINKERPOP-1945
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/842 I got the merge done on tp32, but when I merged to tp33 .NET wouldn't build. I didn't immediately recognize the problem, so perhaps it's best that @jorgebay or @FlorianHockmann pick it up from here. I've squashed/merged and added a couple of commits to this branch: https://github.com/apache/tinkerpop/commits/TINKERPOP-1945 which is based on tp32. I guess we can close this PR once we get that branch merged to tp33 and master. @danielcweber thanks again for sticking to this PR and taking it to the end. it is appreciated. ---
[jira] [Commented] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578438#comment-16578438 ] ASF GitHub Bot commented on TINKERPOP-1945: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/842 I got the merge done on tp32, but when I merged to tp33 .NET wouldn't build. I didn't immediately recognize the problem, so perhaps it's best that @jorgebay or @FlorianHockmann pick it up from here. I've squashed/merged and added a couple of commits to this branch: https://github.com/apache/tinkerpop/commits/TINKERPOP-1945 which is based on tp32. I guess we can close this PR once we get that branch merged to tp33 and master. @danielcweber thanks again for sticking to this PR and taking it to the end. it is appreciated. > Add support for extended GraphSon types to Gremlin.net > -- > > Key: TINKERPOP-1945 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1945 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Reporter: Daniel C. Weber >Priority: Minor > > While Gremlin.net can properly serialize and deserialize all of the core > GraphSon types, support for most of the extended types as described > [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #903: Gremlin.Net: Add ConnectionPool min and max sizes TINK...
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/903 I'm back from OOO, I'll look at it this week. ---
[jira] [Commented] (TINKERPOP-1774) Gremlin .NET: Support min and max sizes in Connection pool
[
https://issues.apache.org/jira/browse/TINKERPOP-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578443#comment-16578443
]
ASF GitHub Bot commented on TINKERPOP-1774:
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/903
I'm back from OOO, I'll look at it this week.
> Gremlin .NET: Support min and max sizes in Connection pool
> --
>
> Key: TINKERPOP-1774
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1774
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
>Affects Versions: 3.2.7
>Reporter: Jorge Bay
>Assignee: Florian Hockmann
>Priority: Minor
>
> Similar to the java connection pool, we should limit the maximum amount of
> connections and start with a minimum number.
> It would also a good opportunity to remove the synchronous acquisitions of
> {{lock}} in the pool implementation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop issue #842: TINKERPOP-1945
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/842 I'm looking into this. At a first glance it seems to be based on the combination of the upgraded Newtonsoft.Json version and the addition of the .NET Standard 2.0 target. ---
[jira] [Commented] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578497#comment-16578497 ] ASF GitHub Bot commented on TINKERPOP-1945: --- Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/842 I'm looking into this. At a first glance it seems to be based on the combination of the upgraded Newtonsoft.Json version and the addition of the .NET Standard 2.0 target. > Add support for extended GraphSon types to Gremlin.net > -- > > Key: TINKERPOP-1945 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1945 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Reporter: Daniel C. Weber >Priority: Minor > > While Gremlin.net can properly serialize and deserialize all of the core > GraphSon types, support for most of the extended types as described > [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #842: TINKERPOP-1945
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/842 I don't know if this matters but I noticed that the upgrade of that JSON thing didn't seem to matter to the tests. they passed on the old version (i sorta tested that version by accident because the PR updated the proj file directory and not the template so maven overwrote the change back to 9) - so do we need 9? or do we need a test case that shows we need 9? ---
[jira] [Commented] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578514#comment-16578514 ] ASF GitHub Bot commented on TINKERPOP-1945: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/842 I don't know if this matters but I noticed that the upgrade of that JSON thing didn't seem to matter to the tests. they passed on the old version (i sorta tested that version by accident because the PR updated the proj file directory and not the template so maven overwrote the change back to 9) - so do we need 9? or do we need a test case that shows we need 9? > Add support for extended GraphSon types to Gremlin.net > -- > > Key: TINKERPOP-1945 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1945 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Reporter: Daniel C. Weber >Priority: Minor > > While Gremlin.net can properly serialize and deserialize all of the core > GraphSon types, support for most of the extended types as described > [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #842: TINKERPOP-1945
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/842 I think I found the cause of the problem: We're using `dynamic` in Gremlin.Net which requires the `Microsoft.CSharp` package. We always got that package because Newtonsoft.Json also had a dependency on it. However, Newtonsoft.Json seems to not use it anymore for .NET Standard 2.0: .NETStandard 1.3 Microsoft.CSharp (>= 4.3.0) NETStandard.Library (>= 1.6.1) System.ComponentModel.TypeConverter (>= 4.3.0) System.Runtime.Serialization.Formatters (>= 4.3.0) System.Runtime.Serialization.Primitives (>= 4.3.0) System.Xml.XmlDocument (>= 4.3.0) .NETStandard 2.0 No dependencies. So, we're now getting errors for every use of `dynamic` with .NET Standard 2.0 as the target framework. I'm now adding a direct dependency on Microsoft.CSharp to Gremlin.Net. So, this can't happen again, even if Newtonsoft.Json would get completely rid of that dependency. We already had that dependency before, it was only kind of _hidden_ behind our dependency on Newtonsoft.Json. ---
[jira] [Commented] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578534#comment-16578534 ] ASF GitHub Bot commented on TINKERPOP-1945: --- Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/842 I think I found the cause of the problem: We're using `dynamic` in Gremlin.Net which requires the `Microsoft.CSharp` package. We always got that package because Newtonsoft.Json also had a dependency on it. However, Newtonsoft.Json seems to not use it anymore for .NET Standard 2.0: .NETStandard 1.3 Microsoft.CSharp (>= 4.3.0) NETStandard.Library (>= 1.6.1) System.ComponentModel.TypeConverter (>= 4.3.0) System.Runtime.Serialization.Formatters (>= 4.3.0) System.Runtime.Serialization.Primitives (>= 4.3.0) System.Xml.XmlDocument (>= 4.3.0) .NETStandard 2.0 No dependencies. So, we're now getting errors for every use of `dynamic` with .NET Standard 2.0 as the target framework. I'm now adding a direct dependency on Microsoft.CSharp to Gremlin.Net. So, this can't happen again, even if Newtonsoft.Json would get completely rid of that dependency. We already had that dependency before, it was only kind of _hidden_ behind our dependency on Newtonsoft.Json. > Add support for extended GraphSon types to Gremlin.net > -- > > Key: TINKERPOP-1945 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1945 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Reporter: Daniel C. Weber >Priority: Minor > > While Gremlin.net can properly serialize and deserialize all of the core > GraphSon types, support for most of the extended types as described > [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop pull request #902: TINKERPOP-1878 sparql-gremlin
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/902#discussion_r209688434
--- Diff:
sparql-gremlin/src/main/java/org/apache/tinkerpop/gremlin/sparql/process/traversal/dsl/sparql/SparqlTraversalSource.java
---
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.tinkerpop.gremlin.sparql.process.traversal.dsl.sparql;
+
+import org.apache.commons.configuration.Configuration;
+import org.apache.tinkerpop.gremlin.process.remote.RemoteConnection;
+import
org.apache.tinkerpop.gremlin.process.remote.traversal.strategy.decoration.RemoteStrategy;
+import org.apache.tinkerpop.gremlin.process.traversal.Bytecode;
+import org.apache.tinkerpop.gremlin.process.traversal.TraversalSource;
+import org.apache.tinkerpop.gremlin.process.traversal.TraversalStrategies;
+import org.apache.tinkerpop.gremlin.process.traversal.TraversalStrategy;
+import
org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal;
+import
org.apache.tinkerpop.gremlin.process.traversal.step.map.ConstantStep;
+import
org.apache.tinkerpop.gremlin.process.traversal.step.sideEffect.InjectStep;
+import
org.apache.tinkerpop.gremlin.sparql.process.traversal.strategy.SparqlStrategy;
+import org.apache.tinkerpop.gremlin.structure.Graph;
+import org.apache.tinkerpop.gremlin.structure.Transaction;
+import org.apache.tinkerpop.gremlin.structure.util.StringFactory;
+
+/**
+ * A {@link TraversalSource} implementation that spawns {@link
SparqlTraversal} instances.
+ *
+ * @author Stephen Mallette (http://stephen.genoprime.com)
+ */
+public class SparqlTraversalSource implements TraversalSource {
+protected transient RemoteConnection connection;
+protected final Graph graph;
+protected TraversalStrategies strategies;
+protected Bytecode bytecode = new Bytecode();
+
+public SparqlTraversalSource(final Graph graph, final
TraversalStrategies traversalStrategies) {
+this.graph = graph;
+this.strategies = traversalStrategies;
+}
+
+public SparqlTraversalSource(final Graph graph) {
+this(graph,
TraversalStrategies.GlobalCache.getStrategies(graph.getClass()));
+}
+
+@Override
+public TraversalStrategies getStrategies() {
+return this.strategies;
+}
+
+@Override
+public Graph getGraph() {
+return this.graph;
+}
+
+@Override
+public Bytecode getBytecode() {
+return this.bytecode;
+}
+
+@SuppressWarnings("CloneDoesntDeclareCloneNotSupportedException")
+public SparqlTraversalSource clone() {
+try {
+final SparqlTraversalSource clone = (SparqlTraversalSource)
super.clone();
+clone.strategies = this.strategies.clone();
+clone.bytecode = this.bytecode.clone();
+return clone;
+} catch (final CloneNotSupportedException e) {
+throw new IllegalStateException(e.getMessage(), e);
+}
+}
+
+ CONFIGURATIONS
+
+@Override
+public SparqlTraversalSource withStrategies(final TraversalStrategy...
traversalStrategies) {
+return (SparqlTraversalSource)
TraversalSource.super.withStrategies(traversalStrategies);
+}
+
+@Override
+@SuppressWarnings({"unchecked"})
+public SparqlTraversalSource withoutStrategies(final Class... traversalStrategyClasses) {
+return (SparqlTraversalSource)
TraversalSource.super.withoutStrategies(traversalStrategyClasses);
+}
+
+@Override
+public SparqlTraversalSource withRemote(final Configuration conf) {
+return (SparqlTraversalSource)
TraversalSource.super.withRemote(conf);
+}
+
+@Override
+public SparqlTraversalSource withRemote(final String configFile)
throws Exception {
+return (
[jira] [Commented] (TINKERPOP-1878) Sparql to Gremlin Compiler
[
https://issues.apache.org/jira/browse/TINKERPOP-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578631#comment-16578631
]
ASF GitHub Bot commented on TINKERPOP-1878:
---
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/902#discussion_r209688434
--- Diff:
sparql-gremlin/src/main/java/org/apache/tinkerpop/gremlin/sparql/process/traversal/dsl/sparql/SparqlTraversalSource.java
---
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.tinkerpop.gremlin.sparql.process.traversal.dsl.sparql;
+
+import org.apache.commons.configuration.Configuration;
+import org.apache.tinkerpop.gremlin.process.remote.RemoteConnection;
+import
org.apache.tinkerpop.gremlin.process.remote.traversal.strategy.decoration.RemoteStrategy;
+import org.apache.tinkerpop.gremlin.process.traversal.Bytecode;
+import org.apache.tinkerpop.gremlin.process.traversal.TraversalSource;
+import org.apache.tinkerpop.gremlin.process.traversal.TraversalStrategies;
+import org.apache.tinkerpop.gremlin.process.traversal.TraversalStrategy;
+import
org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal;
+import
org.apache.tinkerpop.gremlin.process.traversal.step.map.ConstantStep;
+import
org.apache.tinkerpop.gremlin.process.traversal.step.sideEffect.InjectStep;
+import
org.apache.tinkerpop.gremlin.sparql.process.traversal.strategy.SparqlStrategy;
+import org.apache.tinkerpop.gremlin.structure.Graph;
+import org.apache.tinkerpop.gremlin.structure.Transaction;
+import org.apache.tinkerpop.gremlin.structure.util.StringFactory;
+
+/**
+ * A {@link TraversalSource} implementation that spawns {@link
SparqlTraversal} instances.
+ *
+ * @author Stephen Mallette (http://stephen.genoprime.com)
+ */
+public class SparqlTraversalSource implements TraversalSource {
+protected transient RemoteConnection connection;
+protected final Graph graph;
+protected TraversalStrategies strategies;
+protected Bytecode bytecode = new Bytecode();
+
+public SparqlTraversalSource(final Graph graph, final
TraversalStrategies traversalStrategies) {
+this.graph = graph;
+this.strategies = traversalStrategies;
+}
+
+public SparqlTraversalSource(final Graph graph) {
+this(graph,
TraversalStrategies.GlobalCache.getStrategies(graph.getClass()));
+}
+
+@Override
+public TraversalStrategies getStrategies() {
+return this.strategies;
+}
+
+@Override
+public Graph getGraph() {
+return this.graph;
+}
+
+@Override
+public Bytecode getBytecode() {
+return this.bytecode;
+}
+
+@SuppressWarnings("CloneDoesntDeclareCloneNotSupportedException")
+public SparqlTraversalSource clone() {
+try {
+final SparqlTraversalSource clone = (SparqlTraversalSource)
super.clone();
+clone.strategies = this.strategies.clone();
+clone.bytecode = this.bytecode.clone();
+return clone;
+} catch (final CloneNotSupportedException e) {
+throw new IllegalStateException(e.getMessage(), e);
+}
+}
+
+ CONFIGURATIONS
+
+@Override
+public SparqlTraversalSource withStrategies(final TraversalStrategy...
traversalStrategies) {
+return (SparqlTraversalSource)
TraversalSource.super.withStrategies(traversalStrategies);
+}
+
+@Override
+@SuppressWarnings({"unchecked"})
+public SparqlTraversalSource withoutStrategies(final Class... traversalStrategyClasses) {
+return (SparqlTraversalSource)
TraversalSource.super.withoutStrategies(traversalStrategyClasses);
+}
+
+@Override
+public SparqlTraversalSource withRe
[GitHub] tinkerpop issue #842: TINKERPOP-1945
Github user danielcweber commented on the issue: https://github.com/apache/tinkerpop/pull/842 Thanks for accepting the contribution! For what it's worth, I am developing a [type-safe ORM](https://github.com/ExRam/ExRam.Gremlinq) (abusing the 'R' in ORM a bit ;-) on top of Gremlin.net, (among others). If this is of any interest for you wrt. to the Tinkerpop repo, let me know! ---
[jira] [Commented] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578656#comment-16578656 ] ASF GitHub Bot commented on TINKERPOP-1945: --- Github user danielcweber commented on the issue: https://github.com/apache/tinkerpop/pull/842 Thanks for accepting the contribution! For what it's worth, I am developing a [type-safe ORM](https://github.com/ExRam/ExRam.Gremlinq) (abusing the 'R' in ORM a bit ;-) on top of Gremlin.net, (among others). If this is of any interest for you wrt. to the Tinkerpop repo, let me know! > Add support for extended GraphSon types to Gremlin.net > -- > > Key: TINKERPOP-1945 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1945 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Reporter: Daniel C. Weber >Priority: Minor > > While Gremlin.net can properly serialize and deserialize all of the core > GraphSon types, support for most of the extended types as described > [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #842: TINKERPOP-1945
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/842 neat - I'd be happy to suggest adding it to our provider index on the tinkerpop home page assuming it meets the listing policy: http://tinkerpop.apache.org/policy.html please let me know if that's something you'd like to see and if so, whether or not you think you meet the policy. ---
[jira] [Commented] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578668#comment-16578668 ] ASF GitHub Bot commented on TINKERPOP-1945: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/842 neat - I'd be happy to suggest adding it to our provider index on the tinkerpop home page assuming it meets the listing policy: http://tinkerpop.apache.org/policy.html please let me know if that's something you'd like to see and if so, whether or not you think you meet the policy. > Add support for extended GraphSon types to Gremlin.net > -- > > Key: TINKERPOP-1945 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1945 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Reporter: Daniel C. Weber >Priority: Minor > > While Gremlin.net can properly serialize and deserialize all of the core > GraphSon types, support for most of the extended types as described > [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #842: TINKERPOP-1945
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/842 Very interesting project! I will definitely keep an eye on it. I just merged the TINKERPOP-1945 feature branch together with a [CTR commit](https://github.com/apache/tinkerpop/commit/ea18963e543de90668f401938217f5aa21f2ff29) that adds the Microsoft.CSharp dependency as described above. So, we should be finally done now with this ticket ð ---
[GitHub] tinkerpop issue #902: TINKERPOP-1878 sparql-gremlin
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/902 VOTE: +1 ---
[jira] [Commented] (TINKERPOP-1878) Sparql to Gremlin Compiler
[
https://issues.apache.org/jira/browse/TINKERPOP-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578686#comment-16578686
]
ASF GitHub Bot commented on TINKERPOP-1878:
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/902
VOTE: +1
> Sparql to Gremlin Compiler
> --
>
> Key: TINKERPOP-1878
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1878
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.3.1
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Major
>
> The {{sparql-gremlin}} module should convert sparql queries to Gremlin thus
> allowing that query language to run on any TinkerPop-enabled graph system.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578687#comment-16578687 ] ASF GitHub Bot commented on TINKERPOP-1945: --- Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/842 Very interesting project! I will definitely keep an eye on it. I just merged the TINKERPOP-1945 feature branch together with a [CTR commit](https://github.com/apache/tinkerpop/commit/ea18963e543de90668f401938217f5aa21f2ff29) that adds the Microsoft.CSharp dependency as described above. So, we should be finally done now with this ticket 😅 > Add support for extended GraphSon types to Gremlin.net > -- > > Key: TINKERPOP-1945 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1945 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Reporter: Daniel C. Weber >Priority: Minor > > While Gremlin.net can properly serialize and deserialize all of the core > GraphSon types, support for most of the extended types as described > [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #842: TINKERPOP-1945
Github user danielcweber commented on the issue: https://github.com/apache/tinkerpop/pull/842 I guess it could qualify for the listing with some minor tweaks. It doesn't have a release yet (things get deliberately broken by me all the time, so it's at most in some version 0.x, if there was a release), and, well, there is __some__ documentation... I will update the docs to reflect what it can already do today, and probably even package a preview nuget. Thanks for the offer! ---
[jira] [Commented] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578691#comment-16578691 ] ASF GitHub Bot commented on TINKERPOP-1945: --- Github user danielcweber commented on the issue: https://github.com/apache/tinkerpop/pull/842 I guess it could qualify for the listing with some minor tweaks. It doesn't have a release yet (things get deliberately broken by me all the time, so it's at most in some version 0.x, if there was a release), and, well, there is __some__ documentation... I will update the docs to reflect what it can already do today, and probably even package a preview nuget. Thanks for the offer! > Add support for extended GraphSon types to Gremlin.net > -- > > Key: TINKERPOP-1945 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1945 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Reporter: Daniel C. Weber >Priority: Minor > > While Gremlin.net can properly serialize and deserialize all of the core > GraphSon types, support for most of the extended types as described > [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #842: TINKERPOP-1945
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/842 nice @FlorianHockmann - i will manually close this PR now @danielcweber hope we get to see some more pull requests from you in the future. really nicely done - i bragged about your effort on twitter: https://twitter.com/spmallette/status/1029033230228447232 ---
[jira] [Commented] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578696#comment-16578696 ] ASF GitHub Bot commented on TINKERPOP-1945: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/842 nice @FlorianHockmann - i will manually close this PR now @danielcweber hope we get to see some more pull requests from you in the future. really nicely done - i bragged about your effort on twitter: https://twitter.com/spmallette/status/1029033230228447232 > Add support for extended GraphSon types to Gremlin.net > -- > > Key: TINKERPOP-1945 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1945 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Reporter: Daniel C. Weber >Priority: Minor > > While Gremlin.net can properly serialize and deserialize all of the core > GraphSon types, support for most of the extended types as described > [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578700#comment-16578700 ] ASF GitHub Bot commented on TINKERPOP-1945: --- Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/842 > Add support for extended GraphSon types to Gremlin.net > -- > > Key: TINKERPOP-1945 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1945 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Reporter: Daniel C. Weber >Priority: Minor > > While Gremlin.net can properly serialize and deserialize all of the core > GraphSon types, support for most of the extended types as described > [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop pull request #842: TINKERPOP-1945
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/842 ---
[jira] [Closed] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1945. --- Resolution: Done Assignee: Florian Hockmann Fix Version/s: 3.2.10 3.3.4 3.4.0 > Add support for extended GraphSon types to Gremlin.net > -- > > Key: TINKERPOP-1945 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1945 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Reporter: Daniel C. Weber >Assignee: Florian Hockmann >Priority: Minor > Fix For: 3.4.0, 3.3.4, 3.2.10 > > > While Gremlin.net can properly serialize and deserialize all of the core > GraphSon types, support for most of the extended types as described > [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #911: TINKERPOP-2024 Make server archetype use remote traver...
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/911 Thanks for implementing this so quickly, @spmallette LGTM, VOTE +1 ---
[jira] [Commented] (TINKERPOP-2024) Gremlin Server Application archetype should connect via withRemote
[
https://issues.apache.org/jira/browse/TINKERPOP-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578705#comment-16578705
]
ASF GitHub Bot commented on TINKERPOP-2024:
---
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/911
Thanks for implementing this so quickly, @spmallette
LGTM, VOTE +1
> Gremlin Server Application archetype should connect via withRemote
> --
>
> Key: TINKERPOP-2024
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2024
> Project: TinkerPop
> Issue Type: Improvement
> Components: documentation, server
>Affects Versions: 3.2.9
>Reporter: Florian Hockmann
>Assignee: stephen mallette
>Priority: Minor
>
> We seem to have established consensus that Gremlin Bytecode is the preferred
> way to execute Gremlin traversals instead of sending traversals as scripts to
> the server for execution. The Gremlin Server Application Maven archetype
> however still only uses the script variant:
> {code:java}
> public List findCreatorsOfSoftware(String softwareName) throws
> Exception {
> // it is very important from a performance perspective to parameterize
> queries
> Map params = new HashMap();
> params.put("n", softwareName);
> return
> client.submit("g.V().hasLabel('software').has('name',n).in('created').values('name')",
> params)
> .all().get().stream().map(r ->
> r.getString()).collect(Collectors.toList());
> }
> {code}
> Since new users can use this archetype to get started with Gremlin, we should
> encourage best practices and therefore connect via {{withRemote}} to send the
> traversal as Bytecode.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop issue #842: TINKERPOP-1945
Github user danielcweber commented on the issue: https://github.com/apache/tinkerpop/pull/842 Thanks a lot for the twitter mention! In a completely unrelated issue, is anybody of your team in contact with the graph implementors over at CosmosDB? I have no luck in getting [this issue](https://feedback.azure.com/forums/263030-azure-cosmos-db/suggestions/33998623-cosmosdb-s-implementation-of-the-tinkerpop-dsl-has) across and I wonder if there's a workaround I haven't thought of yet... ---
[jira] [Commented] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578716#comment-16578716 ] ASF GitHub Bot commented on TINKERPOP-1945: --- Github user danielcweber commented on the issue: https://github.com/apache/tinkerpop/pull/842 Thanks a lot for the twitter mention! In a completely unrelated issue, is anybody of your team in contact with the graph implementors over at CosmosDB? I have no luck in getting [this issue](https://feedback.azure.com/forums/263030-azure-cosmos-db/suggestions/33998623-cosmosdb-s-implementation-of-the-tinkerpop-dsl-has) across and I wonder if there's a workaround I haven't thought of yet... > Add support for extended GraphSon types to Gremlin.net > -- > > Key: TINKERPOP-1945 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1945 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Reporter: Daniel C. Weber >Assignee: Florian Hockmann >Priority: Minor > Fix For: 3.4.0, 3.3.4, 3.2.10 > > > While Gremlin.net can properly serialize and deserialize all of the core > GraphSon types, support for most of the extended types as described > [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #842: TINKERPOP-1945
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/842 I'm not personally in touch with anyone over there really. I usually just ping folks over there on twitter if I need to convey/ask something - try Luis Bosquez: https://twitter.com/_lbosq ---
[jira] [Commented] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578727#comment-16578727 ] ASF GitHub Bot commented on TINKERPOP-1945: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/842 I'm not personally in touch with anyone over there really. I usually just ping folks over there on twitter if I need to convey/ask something - try Luis Bosquez: https://twitter.com/_lbosq > Add support for extended GraphSon types to Gremlin.net > -- > > Key: TINKERPOP-1945 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1945 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Reporter: Daniel C. Weber >Assignee: Florian Hockmann >Priority: Minor > Fix For: 3.4.0, 3.3.4, 3.2.10 > > > While Gremlin.net can properly serialize and deserialize all of the core > GraphSon types, support for most of the extended types as described > [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #842: TINKERPOP-1945
Github user danielcweber commented on the issue: https://github.com/apache/tinkerpop/pull/842 Alright, thanks! ---
[jira] [Commented] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578733#comment-16578733 ] ASF GitHub Bot commented on TINKERPOP-1945: --- Github user danielcweber commented on the issue: https://github.com/apache/tinkerpop/pull/842 Alright, thanks! > Add support for extended GraphSon types to Gremlin.net > -- > > Key: TINKERPOP-1945 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1945 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Reporter: Daniel C. Weber >Assignee: Florian Hockmann >Priority: Minor > Fix For: 3.4.0, 3.3.4, 3.2.10 > > > While Gremlin.net can properly serialize and deserialize all of the core > GraphSon types, support for most of the extended types as described > [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #907: Fix Sack Split.
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/907 @RainMark did you have a chance to consider the previous comment from @robertdale ? While I appreciate that you have a solution to a problem you are seeing, I share his concern about understanding the nature of the problem itself that is being fixed. ---
[GitHub] tinkerpop pull request #912: TINKERPOP-2023 SSL Enhancements
GitHub user robertdale opened a pull request: https://github.com/apache/tinkerpop/pull/912 TINKERPOP-2023 SSL Enhancements https://issues.apache.org/jira/browse/TINKERPOP-2023 Gremlin Server no longer supports automatically creating self-signed certificates. Cluster client no longer trusts all certs by default as this is an insecure configuration. (TINKERPOP-2022) If no trust store is configured, Cluster will use the default CA certs. To revert to the previous behavior and accept all certs, it must be explicitly configured. Introduces JKS and PKCS12 support. JKS is the legacy Java Key Store. PKCS12 has better cross-platform support and is gaining in adoption. Be aware that JKS is the default on Java 8. Java 9 and higher use PKCS12 as the default. Both Java keytool and OpenSSL tools can create, read, update PKCS12 files. Other new features include specifying SSL protocols and cipher suites. The packaged `*-secure.yaml` files now restrict the protocol to `TLSv1.2` by default. The implication of all of the above changes means that the packaged `*-secure.yaml` files no longer "just work". Minimally, the server files must be configured with a key/cert. PEM-based configurations are deprecated, to be removed in a future release. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-2023 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/912.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #912 commit 14f99a46cc939d0dcfe0423a3db4611e90b0eb6f Author: Robert Dale Date: 2018-08-12T01:12:50Z TINKERPOP-2023 new SSL client, server parameters commit 317e81280ac1a2c1793d610f3e7fc538a00cab67 Author: Robert Dale Date: 2018-08-13T01:50:02Z TINKERPOP-2023 default to TLSv1.2, updated upgrade notes commit 48347f235fa5b66268591732fe799ad0d14a4f8b Author: Robert Dale Date: 2018-08-13T02:23:33Z TINKERPOP-2023 updated docs commit 2da958b03dda0af828e8bccacac029e64c95c1cc Author: Robert Dale Date: 2018-08-13T19:28:40Z TINKERPOP-2023 added tests and some fixes ---
[jira] [Commented] (TINKERPOP-2023) Gremlin Server should not create self-signed certs
[ https://issues.apache.org/jira/browse/TINKERPOP-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578828#comment-16578828 ] ASF GitHub Bot commented on TINKERPOP-2023: --- GitHub user robertdale opened a pull request: https://github.com/apache/tinkerpop/pull/912 TINKERPOP-2023 SSL Enhancements https://issues.apache.org/jira/browse/TINKERPOP-2023 Gremlin Server no longer supports automatically creating self-signed certificates. Cluster client no longer trusts all certs by default as this is an insecure configuration. (TINKERPOP-2022) If no trust store is configured, Cluster will use the default CA certs. To revert to the previous behavior and accept all certs, it must be explicitly configured. Introduces JKS and PKCS12 support. JKS is the legacy Java Key Store. PKCS12 has better cross-platform support and is gaining in adoption. Be aware that JKS is the default on Java 8. Java 9 and higher use PKCS12 as the default. Both Java keytool and OpenSSL tools can create, read, update PKCS12 files. Other new features include specifying SSL protocols and cipher suites. The packaged `*-secure.yaml` files now restrict the protocol to `TLSv1.2` by default. The implication of all of the above changes means that the packaged `*-secure.yaml` files no longer "just work". Minimally, the server files must be configured with a key/cert. PEM-based configurations are deprecated, to be removed in a future release. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-2023 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/912.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #912 commit 14f99a46cc939d0dcfe0423a3db4611e90b0eb6f Author: Robert Dale Date: 2018-08-12T01:12:50Z TINKERPOP-2023 new SSL client, server parameters commit 317e81280ac1a2c1793d610f3e7fc538a00cab67 Author: Robert Dale Date: 2018-08-13T01:50:02Z TINKERPOP-2023 default to TLSv1.2, updated upgrade notes commit 48347f235fa5b66268591732fe799ad0d14a4f8b Author: Robert Dale Date: 2018-08-13T02:23:33Z TINKERPOP-2023 updated docs commit 2da958b03dda0af828e8bccacac029e64c95c1cc Author: Robert Dale Date: 2018-08-13T19:28:40Z TINKERPOP-2023 added tests and some fixes > Gremlin Server should not create self-signed certs > -- > > Key: TINKERPOP-2023 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2023 > Project: TinkerPop > Issue Type: Improvement > Components: server >Affects Versions: 3.2.9 >Reporter: Robert Dale >Assignee: Robert Dale >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #889: Tinkerpop 1977 - Sasl Authentication
Github user mattallenuk commented on the issue: https://github.com/apache/tinkerpop/pull/889 @jorgebay Yes that is a great idea have implemented and made the changes requested. Have also updated the tests to use the PlainTextSaslAuthenticator class. ---
Re: [DISCUSS] Options for withRemote()
Why does it have to be a graph at all? Maybe getting a traversal from a graph is the wrong concept and that's why it perplexes you so. We're connecting to a server that can contain one or more graphs. The traversal should probably come off the connection or be standalone. Maybe the traversal takes a graph. Robert Dale On Fri, Aug 10, 2018 at 3:01 PM Stephen Mallette wrote: > I've never been quite settled on how to connect to remote graphs. For a > while we had RemoteGraph but that wasn't useful really because it was > largely non-functional, as you really just needed a remote configured > TraversalSource - so we deprecated that. TraversalSource.withRemote() is > fine, but you can't get to it without a Graph implementation to create the > TraversalSource in the first place. For that we started to use EmptyGraph, > which works, but is a bit confusing, but less confusing than using say, > TinkerGraph, JanusGraph, etc. > > So, how do we nicely create a TraversalSource, that is meant to call > withRemote()? > > We could create a new Graph implementation that's like EmptyGraph, called > ReferenceGraph, which would behave in the same fashion, but at least it > sorta fits because remoting only returns "Reference" elements. I suppose > ReferenceGraph is somewhere in between EmptyGraph and RemoteGraph in terms > of functionality so maybe it makes more sense usability wise than the > extremes of the other two? I wonder if ReferenceGraph is even a Graph > instance?? maybe it just has a single static method like: > > g = ReferenceGraph.traversal(conf) > > where traversal() constructs a GraphTraversalSource and proxies calls to > withRemote()? Not sure what happens to DSLs though...that might be trouble. > > Anyway, it's a DISCUSS - so let's discuss. >
[GitHub] tinkerpop pull request #902: TINKERPOP-1878 sparql-gremlin
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/902 ---
[jira] [Commented] (TINKERPOP-1878) Sparql to Gremlin Compiler
[
https://issues.apache.org/jira/browse/TINKERPOP-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578977#comment-16578977
]
ASF GitHub Bot commented on TINKERPOP-1878:
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/902
> Sparql to Gremlin Compiler
> --
>
> Key: TINKERPOP-1878
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1878
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.3.1
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Major
>
> The {{sparql-gremlin}} module should convert sparql queries to Gremlin thus
> allowing that query language to run on any TinkerPop-enabled graph system.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: [DISCUSS] Options for withRemote()
Yes - I did consider killing instantiation through a Graph except that: 1. It felt like a major major departure from what we have been doing and if users have been using things like GraphFactory to instantiate graphs then they might continue to expect that support (currently supported by RemoteGraph) 2. Given 1 above, the test suite is one of those things that relies on that... 3. Didn't really think of a suitable API that I loved to suggest dealing with the fallout of 1 and 2, but perhaps I didn't try hard enough. On Mon, Aug 13, 2018 at 5:05 PM Robert Dale wrote: > Why does it have to be a graph at all? Maybe getting a traversal from a > graph is the wrong concept and that's why it perplexes you so. We're > connecting to a server that can contain one or more graphs. The traversal > should probably come off the connection or be standalone. Maybe the > traversal takes a graph. > > Robert Dale > > On Fri, Aug 10, 2018 at 3:01 PM Stephen Mallette > wrote: > > > I've never been quite settled on how to connect to remote graphs. For a > > while we had RemoteGraph but that wasn't useful really because it was > > largely non-functional, as you really just needed a remote configured > > TraversalSource - so we deprecated that. TraversalSource.withRemote() is > > fine, but you can't get to it without a Graph implementation to create > the > > TraversalSource in the first place. For that we started to use > EmptyGraph, > > which works, but is a bit confusing, but less confusing than using say, > > TinkerGraph, JanusGraph, etc. > > > > So, how do we nicely create a TraversalSource, that is meant to call > > withRemote()? > > > > We could create a new Graph implementation that's like EmptyGraph, called > > ReferenceGraph, which would behave in the same fashion, but at least it > > sorta fits because remoting only returns "Reference" elements. I suppose > > ReferenceGraph is somewhere in between EmptyGraph and RemoteGraph in > terms > > of functionality so maybe it makes more sense usability wise than the > > extremes of the other two? I wonder if ReferenceGraph is even a Graph > > instance?? maybe it just has a single static method like: > > > > g = ReferenceGraph.traversal(conf) > > > > where traversal() constructs a GraphTraversalSource and proxies calls to > > withRemote()? Not sure what happens to DSLs though...that might be > trouble. > > > > Anyway, it's a DISCUSS - so let's discuss. > > >
[jira] [Closed] (TINKERPOP-1878) Sparql to Gremlin Compiler
[
https://issues.apache.org/jira/browse/TINKERPOP-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-1878.
---
Resolution: Done
Fix Version/s: 3.4.0
> Sparql to Gremlin Compiler
> --
>
> Key: TINKERPOP-1878
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1878
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.3.1
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Major
> Fix For: 3.4.0
>
>
> The {{sparql-gremlin}} module should convert sparql queries to Gremlin thus
> allowing that query language to run on any TinkerPop-enabled graph system.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
