[GitHub] tinkerpop issue #922: TINKERPOP-1959: Gremlin Javascript ability to send a s...
Github user mattallenuk commented on the issue: https://github.com/apache/tinkerpop/pull/922 @spmallette, my apologies I've been unwell the last week. I have done the test but it showed that I need to parse the bindings so that the standard Op processor can read them, it doesn't appear to like bytecode bindings. I'm hoping to have that done and tested today. On the documentation side I noticed that there doesn't appear to be any documentation in the other glv sections about submitting scripts, am I okay to add this documentation to the javascript glv section? ---
[jira] [Commented] (TINKERPOP-1959) Provide a way to submit scripts to the server in gremlin-javascript
[ https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637921#comment-16637921 ] ASF GitHub Bot commented on TINKERPOP-1959: --- Github user mattallenuk commented on the issue: https://github.com/apache/tinkerpop/pull/922 @spmallette, my apologies I've been unwell the last week. I have done the test but it showed that I need to parse the bindings so that the standard Op processor can read them, it doesn't appear to like bytecode bindings. I'm hoping to have that done and tested today. On the documentation side I noticed that there doesn't appear to be any documentation in the other glv sections about submitting scripts, am I okay to add this documentation to the javascript glv section? > Provide a way to submit scripts to the server in gremlin-javascript > --- > > Key: TINKERPOP-1959 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1959 > Project: TinkerPop > Issue Type: Improvement > Components: javascript >Affects Versions: 3.2.8 >Reporter: stephen mallette >Priority: Critical > > It is currently only possible to submit bytecode based requests to the server > with gremlin-javascript. We should also provide some means for submitting > scripts. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #928: TINKERPOP-2015 Expose WebSocket configuration in Greml...
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/928
@deejvince: Did you see [the integration
test](https://github.com/apache/tinkerpop/blob/master/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Driver/GremlinClientTests.cs#L233)
added with this PR?
The relevant part is basically this:
```cs
var webSocketConfiguration =
new Action(options =>
{
options.UseDefaultCredentials = false;
options.KeepAliveInterval =
TimeSpan.FromMilliseconds(11);
});
var gremlinClient = new GremlinClient(gremlinServer,
webSocketConfiguration: webSocketConfiguration);
```
The `Action` you provide will be called for every `ClientWebSocket` created
by the driver of Gremlin.Net.
I haven't tested that specifically, but it should also be possible to set a
request header like this:
```cs
var webSocketConfiguration =
new Action(options =>
{
options.SetRequestHeader("Authorization", "Bearer " +
token);
});
```
Please report back if that doesn't work.
---
[jira] [Commented] (TINKERPOP-2015) Allow users to configure the WebSocket connections
[
https://issues.apache.org/jira/browse/TINKERPOP-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637949#comment-16637949
]
ASF GitHub Bot commented on TINKERPOP-2015:
---
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/928
@deejvince: Did you see [the integration
test](https://github.com/apache/tinkerpop/blob/master/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Driver/GremlinClientTests.cs#L233)
added with this PR?
The relevant part is basically this:
```cs
var webSocketConfiguration =
new Action(options =>
{
options.UseDefaultCredentials = false;
options.KeepAliveInterval =
TimeSpan.FromMilliseconds(11);
});
var gremlinClient = new GremlinClient(gremlinServer,
webSocketConfiguration: webSocketConfiguration);
```
The `Action` you provide will be called for every `ClientWebSocket` created
by the driver of Gremlin.Net.
I haven't tested that specifically, but it should also be possible to set a
request header like this:
```cs
var webSocketConfiguration =
new Action(options =>
{
options.SetRequestHeader("Authorization", "Bearer " +
token);
});
```
Please report back if that doesn't work.
> Allow users to configure the WebSocket connections
> --
>
> Key: TINKERPOP-2015
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2015
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
>Affects Versions: 3.3.3, 3.2.9
>Reporter: Florian Hockmann
>Assignee: Florian Hockmann
>Priority: Major
> Fix For: 3.4.0, 3.3.4, 3.2.10
>
>
> Gremlin.Net currently just creates instances of the {{ClientWebSocket}} class
> with default options. That is probably appropriate for most users but it
> makes it impossible to change the config and use certain features like client
> certificates or proxy settings.
> We could simply allow users to provide a
> [{{ClientWebSocketOptions}}|https://docs.microsoft.com/dotnet/api/system.net.websockets.clientwebsocketoptions]
> object. Since it's part of .NET Standard (and not a 3rd party library) it
> shouldn't be a problem to expose this type. This would also have the nice
> advantage that users could immediately use new options like the
> {{[RemoteCertificateValidationCallback|https://docs.microsoft.com/dotnet/api/system.net.websockets.clientwebsocketoptions.remotecertificatevalidationcallback]}}
> that was just added in .NET Core 2.1.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-2041) Text Predicates
[
https://issues.apache.org/jira/browse/TINKERPOP-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638039#comment-16638039
]
ASF GitHub Bot commented on TINKERPOP-2041:
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/944
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
> Text Predicates
> ---
>
> Key: TINKERPOP-2041
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2041
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.4.0
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>Priority: Major
>
> Provide these simple text predicates:
> * {{startsWith}}
> * {{endsWith}}
> * {{contains}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop issue #944: TINKERPOP-2041 Text Predicates
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/944 All tests pass with `docker/build.sh -t -n -i` VOTE +1 ---
[GitHub] tinkerpop pull request #942: TINKERPOP-2049 Added with(k) overload
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/942 ---
[GitHub] tinkerpop issue #922: TINKERPOP-1959: Gremlin Javascript ability to send a s...
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/922 sorry to hear about the sickness. i hope your doing well now. you're right about the documentation. i think we wanted to focus folks on bytecode based traversals. we do have a section for gremlin-python for submitting scripts, but i think i discouraged the one for .NET. I'd forgotten that. I'd had the idea that i was going to massively rework the documentation on 3.4.0 to better organize all this GLV stuff and that hasn't fully happened yet. ok, so, i guess you just need the test/serialization fixups then, a changelog entry and a note in upgrade docs to say that this is now there...perhaps just add some example usage there. thanks ---
[jira] [Commented] (TINKERPOP-1959) Provide a way to submit scripts to the server in gremlin-javascript
[ https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638067#comment-16638067 ] ASF GitHub Bot commented on TINKERPOP-1959: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/922 sorry to hear about the sickness. i hope your doing well now. you're right about the documentation. i think we wanted to focus folks on bytecode based traversals. we do have a section for gremlin-python for submitting scripts, but i think i discouraged the one for .NET. I'd forgotten that. I'd had the idea that i was going to massively rework the documentation on 3.4.0 to better organize all this GLV stuff and that hasn't fully happened yet. ok, so, i guess you just need the test/serialization fixups then, a changelog entry and a note in upgrade docs to say that this is now there...perhaps just add some example usage there. thanks > Provide a way to submit scripts to the server in gremlin-javascript > --- > > Key: TINKERPOP-1959 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1959 > Project: TinkerPop > Issue Type: Improvement > Components: javascript >Affects Versions: 3.2.8 >Reporter: stephen mallette >Priority: Critical > > It is currently only possible to submit bytecode based requests to the server > with gremlin-javascript. We should also provide some means for submitting > scripts. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-2049) Single argument with() overload
[
https://issues.apache.org/jira/browse/TINKERPOP-2049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638060#comment-16638060
]
ASF GitHub Bot commented on TINKERPOP-2049:
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/942
> Single argument with() overload
> ---
>
> Key: TINKERPOP-2049
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2049
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.4.0
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Major
> Fix For: 3.4.0
>
>
> Add {{with(k)}} which is equivalent of {{with(k, true}}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (TINKERPOP-2049) Single argument with() overload
[
https://issues.apache.org/jira/browse/TINKERPOP-2049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-2049.
---
Resolution: Done
> Single argument with() overload
> ---
>
> Key: TINKERPOP-2049
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2049
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.4.0
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Major
> Fix For: 3.4.0
>
>
> Add {{with(k)}} which is equivalent of {{with(k, true}}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop issue #943: TINKERPOP-2044 Configurable traversal to validate host...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/943 VOTE +1 ---
[jira] [Commented] (TINKERPOP-2044) Cannot reconnect to Azure cosmos host that becomes available again
[ https://issues.apache.org/jira/browse/TINKERPOP-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638120#comment-16638120 ] ASF GitHub Bot commented on TINKERPOP-2044: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/943 VOTE +1 > Cannot reconnect to Azure cosmos host that becomes available again > -- > > Key: TINKERPOP-2044 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2044 > Project: TinkerPop > Issue Type: Bug > Components: driver >Affects Versions: 3.3.3 >Reporter: Dantis P S >Assignee: stephen mallette >Priority: Major > > If a Azure Cosmos Gremlin host goes down and if it becomes available again, > the tinkerpop3 java driver cannot reconnect to it. > Sample code is available at [https://github.com/cancure/tinkerpopcosmos] > > These are the steps to reproduce - > 1) Start the application after providing proper connection details in > remote.yaml file. > 2) Call the end point POST [http://localhost:8080/query.] Pass a valid > gremlin query as HTTP body E.g. g.V(1).id() > 3) Disconnect computer from internet. > 4) Do step 2. > 5) Reconnect computer to the internet. > 6) Do step 2. > Any query executed from this point onwards gets the error - > "java.lang.RuntimeException: java.util.concurrent.TimeoutException: Timed out > while waiting for an available host - check the client configuration and > connectivity to the server if this message persists". > > The issue seems to be coming from > org.apache.tinkerpop.gremlin.driver.ConnectionPool.java. In line #403, the > gremlin query used for ping message is '' (Empty string in single quotes). > final RequestMessage ping = > RequestMessage.build(Tokens.OPS_EVAL).add(Tokens.ARGS_GREMLIN, "''").create(); > > Cosmos server returns an error saying that the gremlin query's grammar is > incorrect. Because of this error the rest of the lines of the method does not > get executed. > > Fix will be to use a gremlin query which is valid for all supported graph DBs. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #944: TINKERPOP-2041 Text Predicates
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/944 VOTE +1 ---
[jira] [Commented] (TINKERPOP-2041) Text Predicates
[
https://issues.apache.org/jira/browse/TINKERPOP-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638157#comment-16638157
]
ASF GitHub Bot commented on TINKERPOP-2041:
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/944
VOTE +1
> Text Predicates
> ---
>
> Key: TINKERPOP-2041
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2041
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.4.0
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>Priority: Major
>
> Provide these simple text predicates:
> * {{startsWith}}
> * {{endsWith}}
> * {{contains}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop issue #945: TINKERPOP-2053 Support for OptionsStrategy
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/945 VOTE +1 ---
[jira] [Commented] (TINKERPOP-2053) Provider OptionsStrategy for traversal configurations
[
https://issues.apache.org/jira/browse/TINKERPOP-2053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638160#comment-16638160
]
ASF GitHub Bot commented on TINKERPOP-2053:
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/945
VOTE +1
> Provider OptionsStrategy for traversal configurations
> -
>
> Key: TINKERPOP-2053
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2053
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.3.3
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Major
> Fix For: 3.4.0
>
>
> {{OptionsStrategy}} will make it so that users can set traversal-wide options
> that can be accessed by steps or other classes that might interact with a
> {{Traversal}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop issue #947: TINKERPOP-2055 Support NaN and Infinity in GraphSON
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/947 Stephen "The Polyglot" VOTE +1 ---
[jira] [Commented] (TINKERPOP-2055) Provide support for special number cases like Infinity in GraphSON
[
https://issues.apache.org/jira/browse/TINKERPOP-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638240#comment-16638240
]
ASF GitHub Bot commented on TINKERPOP-2055:
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/947
Stephen "The Polyglot"
VOTE +1
> Provide support for special number cases like Infinity in GraphSON
> --
>
> Key: TINKERPOP-2055
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2055
> Project: TinkerPop
> Issue Type: Improvement
> Components: io
>Affects Versions: 3.2.9
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
>
> GraphSON currently doesn't handle: {{Double.Nan}},
> {{Double.NEGATIVE_INFINITY}} or {{Double.POSITIVE_INFINITY}} because it has a
> custom {{Double}} serializer that ignores those cases in GraphSON 2.0 and
> 3.0. Not going to try to solve this for 1.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (TINKERPOP-2058) Contains predicates should rely on Compare predicates
Daniel Kuppitz created TINKERPOP-2058:
-
Summary: Contains predicates should rely on Compare predicates
Key: TINKERPOP-2058
URL: https://issues.apache.org/jira/browse/TINKERPOP-2058
Project: TinkerPop
Issue Type: Bug
Components: process
Affects Versions: 3.4.0
Reporter: Daniel Kuppitz
Assignee: Daniel Kuppitz
The problem:
{noformat}
gremlin> g.V().has("age", eq(32L))
==>v[4]
gremlin> g.V().has("age", within(32L, 35L))
gremlin>
{noformat}
{{Contains}} predicates should really behave the same way {{Compare}}
predicates do.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop issue #948: Optimizes Map with enum using the EnumMap implementati...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/948 VOTE +1 ---
[jira] [Commented] (TINKERPOP-2056) Use NumberHelper in Compare
[
https://issues.apache.org/jira/browse/TINKERPOP-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638299#comment-16638299
]
ASF GitHub Bot commented on TINKERPOP-2056:
---
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/949
TINKERPOP-2056 Use NumberHelper in Compare
Instead of converting all numbers to `BigDecimal`, `Compare` predicates now
use `NumberHelper` for numerical comparisons.
`docker/build.sh -t -i -n` passed.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-2056
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/949.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #949
commit 8759b39ce83b2165bc1415d1feead005e970a505
Author: Daniel Kuppitz
Date: 2018-10-04T14:07:27Z
TINKERPOP-2056 Made use of `NumberHelper` in `Compare` predicates.
> Use NumberHelper in Compare
> ---
>
> Key: TINKERPOP-2056
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2056
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.2.9
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>Priority: Major
>
> The {{Compare}} enum doesn't use {{NumberHelper}}. Instead, it converts
> numbers of differing types to {{BigDecimal}}s. That's pretty much the slowest
> thing we can do.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop pull request #949: TINKERPOP-2056 Use NumberHelper in Compare
GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/949 TINKERPOP-2056 Use NumberHelper in Compare Instead of converting all numbers to `BigDecimal`, `Compare` predicates now use `NumberHelper` for numerical comparisons. `docker/build.sh -t -i -n` passed. VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-2056 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/949.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #949 commit 8759b39ce83b2165bc1415d1feead005e970a505 Author: Daniel Kuppitz Date: 2018-10-04T14:07:27Z TINKERPOP-2056 Made use of `NumberHelper` in `Compare` predicates. ---
[GitHub] tinkerpop issue #922: TINKERPOP-1959: Gremlin Javascript ability to send a s...
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
@jorgebay @spmallette So I've written the following test, however I'm
getting a Provided key/value array length must be a multiple of two when
submitting. I am guessing this is due to submitting the cardinality as a string
value. How should non-native JS types be submitted via script?
`connection.submit('g.V(vert).property(card, nm, val)', { vert: 1, card:
t.cardinality.set, nm: 'test', val: 12 } )`
this produces:
[RequestMessage{, requestId='reqid', op='eval', processor='',
args={gremlin=g.V(1).property(card, nm, val), aliases={g=gmodern},
bindings={vert=1, card=set, nm=test, val=12}, language=gremlin-groovy,
accept=application/json}}]
---
[GitHub] tinkerpop issue #922: TINKERPOP-1959: Gremlin Javascript ability to send a s...
Github user mattallenuk commented on the issue: https://github.com/apache/tinkerpop/pull/922 @spmallette Doing better now thank you! ---
[jira] [Commented] (TINKERPOP-1959) Provide a way to submit scripts to the server in gremlin-javascript
[
https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638305#comment-16638305
]
ASF GitHub Bot commented on TINKERPOP-1959:
---
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
@jorgebay @spmallette So I've written the following test, however I'm
getting a Provided key/value array length must be a multiple of two when
submitting. I am guessing this is due to submitting the cardinality as a string
value. How should non-native JS types be submitted via script?
`connection.submit('g.V(vert).property(card, nm, val)', { vert: 1, card:
t.cardinality.set, nm: 'test', val: 12 } )`
this produces:
[RequestMessage{, requestId='reqid', op='eval', processor='',
args={gremlin=g.V(1).property(card, nm, val), aliases={g=gmodern},
bindings={vert=1, card=set, nm=test, val=12}, language=gremlin-groovy,
accept=application/json}}]
> Provide a way to submit scripts to the server in gremlin-javascript
> ---
>
> Key: TINKERPOP-1959
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1959
> Project: TinkerPop
> Issue Type: Improvement
> Components: javascript
>Affects Versions: 3.2.8
>Reporter: stephen mallette
>Priority: Critical
>
> It is currently only possible to submit bytecode based requests to the server
> with gremlin-javascript. We should also provide some means for submitting
> scripts.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop pull request #950: TINKERPOP-2058 Contains predicates should rely ...
GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/950 TINKERPOP-2058 Contains predicates should rely on Compare predicates https://issues.apache.org/jira/browse/TINKERPOP-2058 If the object to be filtered is a number, `Contains` predicates will now scan the provided collection, comparing each element using `Compare.eq`. For non-numeric values `Contains.within` will still use `collection.contains()` in order to make use of search-optimized data types (e.g. `Set`). This is a breaking change as the test suite previously ensured that number types had an effect on `Contains` predicates. This, however, was inconsistent with `Compare` predicates which ignore the number type. `docker/build.sh -t -i -n` passed. VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-2058 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/950.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #950 commit ec0d8805fe18e6d1985af5544106f78169f3f5b4 Author: Daniel Kuppitz Date: 2018-10-04T14:15:09Z TINKERPOP-2058 Use `Compare.eq` in `Contains.within` to ensure equal filter behaviors. If the object to be filtered is a number, `Contains` predicates will now scan the provided collection, comparing each element using `Compare.eq`. For non-numeric values `Contains.within` will still use `collection.contains()` in order to make use of search-optimized data types (e.g. `Set`). ---
[jira] [Commented] (TINKERPOP-2058) Contains predicates should rely on Compare predicates
[
https://issues.apache.org/jira/browse/TINKERPOP-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638311#comment-16638311
]
ASF GitHub Bot commented on TINKERPOP-2058:
---
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/950
TINKERPOP-2058 Contains predicates should rely on Compare predicates
https://issues.apache.org/jira/browse/TINKERPOP-2058
If the object to be filtered is a number, `Contains` predicates will now
scan the provided collection, comparing each element using `Compare.eq`. For
non-numeric values `Contains.within` will still use `collection.contains()` in
order to make use of search-optimized data types (e.g. `Set`).
This is a breaking change as the test suite previously ensured that number
types had an effect on `Contains` predicates. This, however, was inconsistent
with `Compare` predicates which ignore the number type.
`docker/build.sh -t -i -n` passed.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-2058
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/950.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #950
commit ec0d8805fe18e6d1985af5544106f78169f3f5b4
Author: Daniel Kuppitz
Date: 2018-10-04T14:15:09Z
TINKERPOP-2058 Use `Compare.eq` in `Contains.within` to ensure equal filter
behaviors.
If the object to be filtered is a number, `Contains` predicates will now
scan the provided collection, comparing
each element using `Compare.eq`. For non-numeric values `Contains.within`
will still use `collection.contains()`
in order to make use of search-optimized data types (e.g. `Set`).
> Contains predicates should rely on Compare predicates
> -
>
> Key: TINKERPOP-2058
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2058
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.4.0
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>Priority: Major
> Labels: breaking
>
> The problem:
> {noformat}
> gremlin> g.V().has("age", eq(32L))
> ==>v[4]
> gremlin> g.V().has("age", within(32L, 35L))
> gremlin>
> {noformat}
> {{Contains}} predicates should really behave the same way {{Compare}}
> predicates do.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1959) Provide a way to submit scripts to the server in gremlin-javascript
[ https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638307#comment-16638307 ] ASF GitHub Bot commented on TINKERPOP-1959: --- Github user mattallenuk commented on the issue: https://github.com/apache/tinkerpop/pull/922 @spmallette Doing better now thank you! > Provide a way to submit scripts to the server in gremlin-javascript > --- > > Key: TINKERPOP-1959 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1959 > Project: TinkerPop > Issue Type: Improvement > Components: javascript >Affects Versions: 3.2.8 >Reporter: stephen mallette >Priority: Critical > > It is currently only possible to submit bytecode based requests to the server > with gremlin-javascript. We should also provide some means for submitting > scripts. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #922: TINKERPOP-1959: Gremlin Javascript ability to send a s...
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
I've just tried it not parsing the bindings to strings and get the same
issue. So I'm wondering now if I do need to parse the parameters or if I'm just
calling the addProperty function wrong?
`[RequestMessage{, requestId=27ad0188-8b5a-40e0-bf52-b158a1e92507,
op='eval', processor='', args={gremlin=g.V(1).property(card, nm, val),
aliases={g=gmodern}, bindings={card={typeName=Cardinality, elementName=set},
nm=test, val=12}, language=gremlin-groovy, accept=application/json}}].`
---
[jira] [Commented] (TINKERPOP-1959) Provide a way to submit scripts to the server in gremlin-javascript
[
https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638332#comment-16638332
]
ASF GitHub Bot commented on TINKERPOP-1959:
---
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
I've just tried it not parsing the bindings to strings and get the same
issue. So I'm wondering now if I do need to parse the parameters or if I'm just
calling the addProperty function wrong?
`[RequestMessage{, requestId=27ad0188-8b5a-40e0-bf52-b158a1e92507,
op='eval', processor='', args={gremlin=g.V(1).property(card, nm, val),
aliases={g=gmodern}, bindings={card={typeName=Cardinality, elementName=set},
nm=test, val=12}, language=gremlin-groovy, accept=application/json}}].`
> Provide a way to submit scripts to the server in gremlin-javascript
> ---
>
> Key: TINKERPOP-1959
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1959
> Project: TinkerPop
> Issue Type: Improvement
> Components: javascript
>Affects Versions: 3.2.8
>Reporter: stephen mallette
>Priority: Critical
>
> It is currently only possible to submit bytecode based requests to the server
> with gremlin-javascript. We should also provide some means for submitting
> scripts.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-2041) Text Predicates
[
https://issues.apache.org/jira/browse/TINKERPOP-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638369#comment-16638369
]
ASF GitHub Bot commented on TINKERPOP-2041:
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/944
> Text Predicates
> ---
>
> Key: TINKERPOP-2041
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2041
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.4.0
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>Priority: Major
>
> Provide these simple text predicates:
> * {{startsWith}}
> * {{endsWith}}
> * {{contains}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop pull request #944: TINKERPOP-2041 Text Predicates
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/944 ---
[jira] [Closed] (TINKERPOP-2041) Text Predicates
[
https://issues.apache.org/jira/browse/TINKERPOP-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Kuppitz closed TINKERPOP-2041.
-
Resolution: Fixed
Fix Version/s: 3.4.0
> Text Predicates
> ---
>
> Key: TINKERPOP-2041
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2041
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.4.0
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>Priority: Major
> Fix For: 3.4.0
>
>
> Provide these simple text predicates:
> * {{startsWith}}
> * {{endsWith}}
> * {{contains}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop pull request #943: TINKERPOP-2044 Configurable traversal to valida...
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/943 ---
[jira] [Closed] (TINKERPOP-2044) Cannot reconnect to Azure cosmos host that becomes available again
[ https://issues.apache.org/jira/browse/TINKERPOP-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-2044. --- Resolution: Fixed Fix Version/s: 3.2.10 3.3.4 3.4.0 > Cannot reconnect to Azure cosmos host that becomes available again > -- > > Key: TINKERPOP-2044 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2044 > Project: TinkerPop > Issue Type: Bug > Components: driver >Affects Versions: 3.3.3 >Reporter: Dantis P S >Assignee: stephen mallette >Priority: Major > Fix For: 3.4.0, 3.3.4, 3.2.10 > > > If a Azure Cosmos Gremlin host goes down and if it becomes available again, > the tinkerpop3 java driver cannot reconnect to it. > Sample code is available at [https://github.com/cancure/tinkerpopcosmos] > > These are the steps to reproduce - > 1) Start the application after providing proper connection details in > remote.yaml file. > 2) Call the end point POST [http://localhost:8080/query.] Pass a valid > gremlin query as HTTP body E.g. g.V(1).id() > 3) Disconnect computer from internet. > 4) Do step 2. > 5) Reconnect computer to the internet. > 6) Do step 2. > Any query executed from this point onwards gets the error - > "java.lang.RuntimeException: java.util.concurrent.TimeoutException: Timed out > while waiting for an available host - check the client configuration and > connectivity to the server if this message persists". > > The issue seems to be coming from > org.apache.tinkerpop.gremlin.driver.ConnectionPool.java. In line #403, the > gremlin query used for ping message is '' (Empty string in single quotes). > final RequestMessage ping = > RequestMessage.build(Tokens.OPS_EVAL).add(Tokens.ARGS_GREMLIN, "''").create(); > > Cosmos server returns an error saying that the gremlin query's grammar is > incorrect. Because of this error the rest of the lines of the method does not > get executed. > > Fix will be to use a gremlin query which is valid for all supported graph DBs. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #922: TINKERPOP-1959: Gremlin Javascript ability to send a s...
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/922
`addProperty()` looks right. On `tp32` I guess the default is GraphSON 2.0
which has this form for `Cardinality` values:
http://tinkerpop.apache.org/docs/3.2.9/dev/io/#_cardinality
I see that the `accept` is set to "application/json". On `tp32` I think
that defaults to GraphSON 1.0 which wouldn't be able to deal with complex
objects. You can only pass primitives that are compatible with JSON data types.
Does it work if you don't use `Cardinality`? maybe, just do something more
simple like:
js
connection.submit('x+y', { x: 1, y: 1 } );
```
If that works then change to GraphSON 2.0 -
"application/vnd.gremlin-v2.0+json" - and see what happens for complex stuff
like:
js
connection.submit(card.toString()', { card: t.cardinality.set } );
```
---
[jira] [Commented] (TINKERPOP-1959) Provide a way to submit scripts to the server in gremlin-javascript
[
https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638482#comment-16638482
]
ASF GitHub Bot commented on TINKERPOP-1959:
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/922
`addProperty()` looks right. On `tp32` I guess the default is GraphSON 2.0
which has this form for `Cardinality` values:
http://tinkerpop.apache.org/docs/3.2.9/dev/io/#_cardinality
I see that the `accept` is set to "application/json". On `tp32` I think
that defaults to GraphSON 1.0 which wouldn't be able to deal with complex
objects. You can only pass primitives that are compatible with JSON data types.
Does it work if you don't use `Cardinality`? maybe, just do something more
simple like:
js
connection.submit('x+y', { x: 1, y: 1 } );
```
If that works then change to GraphSON 2.0 -
"application/vnd.gremlin-v2.0+json" - and see what happens for complex stuff
like:
js
connection.submit(card.toString()', { card: t.cardinality.set } );
```
> Provide a way to submit scripts to the server in gremlin-javascript
> ---
>
> Key: TINKERPOP-1959
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1959
> Project: TinkerPop
> Issue Type: Improvement
> Components: javascript
>Affects Versions: 3.2.8
>Reporter: stephen mallette
>Priority: Critical
>
> It is currently only possible to submit bytecode based requests to the server
> with gremlin-javascript. We should also provide some means for submitting
> scripts.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-2044) Cannot reconnect to Azure cosmos host that becomes available again
[ https://issues.apache.org/jira/browse/TINKERPOP-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638450#comment-16638450 ] ASF GitHub Bot commented on TINKERPOP-2044: --- Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/943 > Cannot reconnect to Azure cosmos host that becomes available again > -- > > Key: TINKERPOP-2044 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2044 > Project: TinkerPop > Issue Type: Bug > Components: driver >Affects Versions: 3.3.3 >Reporter: Dantis P S >Assignee: stephen mallette >Priority: Major > > If a Azure Cosmos Gremlin host goes down and if it becomes available again, > the tinkerpop3 java driver cannot reconnect to it. > Sample code is available at [https://github.com/cancure/tinkerpopcosmos] > > These are the steps to reproduce - > 1) Start the application after providing proper connection details in > remote.yaml file. > 2) Call the end point POST [http://localhost:8080/query.] Pass a valid > gremlin query as HTTP body E.g. g.V(1).id() > 3) Disconnect computer from internet. > 4) Do step 2. > 5) Reconnect computer to the internet. > 6) Do step 2. > Any query executed from this point onwards gets the error - > "java.lang.RuntimeException: java.util.concurrent.TimeoutException: Timed out > while waiting for an available host - check the client configuration and > connectivity to the server if this message persists". > > The issue seems to be coming from > org.apache.tinkerpop.gremlin.driver.ConnectionPool.java. In line #403, the > gremlin query used for ping message is '' (Empty string in single quotes). > final RequestMessage ping = > RequestMessage.build(Tokens.OPS_EVAL).add(Tokens.ARGS_GREMLIN, "''").create(); > > Cosmos server returns an error saying that the gremlin query's grammar is > incorrect. Because of this error the rest of the lines of the method does not > get executed. > > Fix will be to use a gremlin query which is valid for all supported graph DBs. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop pull request #947: TINKERPOP-2055 Support NaN and Infinity in Grap...
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/947#discussion_r222751451
--- Diff:
gremlin-javascript/src/main/javascript/gremlin-javascript/test/unit/graphson-test.js
---
@@ -46,6 +46,30 @@ describe('GraphSONReader', function () {
assert.strictEqual(result, item[1]);
});
});
+ it('should parse GraphSON Nan from GraphSON', function () {
+ const reader = new GraphSONReader();
+ var result = reader.read({
+"@type": "g:Double",
+"@value": "NaN"
+ });
+ assert.ok(isNaN(result));
+ });
+ it('should parse GraphSON -Infinity and Nan from GraphSON', function () {
--- End diff --
Just a minor nit but why does it say _and Nan_ when only `-Infinity` is
tested here?
---
[jira] [Commented] (TINKERPOP-2055) Provide support for special number cases like Infinity in GraphSON
[
https://issues.apache.org/jira/browse/TINKERPOP-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638549#comment-16638549
]
ASF GitHub Bot commented on TINKERPOP-2055:
---
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/947#discussion_r222751451
--- Diff:
gremlin-javascript/src/main/javascript/gremlin-javascript/test/unit/graphson-test.js
---
@@ -46,6 +46,30 @@ describe('GraphSONReader', function () {
assert.strictEqual(result, item[1]);
});
});
+ it('should parse GraphSON Nan from GraphSON', function () {
+ const reader = new GraphSONReader();
+ var result = reader.read({
+"@type": "g:Double",
+"@value": "NaN"
+ });
+ assert.ok(isNaN(result));
+ });
+ it('should parse GraphSON -Infinity and Nan from GraphSON', function () {
--- End diff --
Just a minor nit but why does it say _and Nan_ when only `-Infinity` is
tested here?
> Provide support for special number cases like Infinity in GraphSON
> --
>
> Key: TINKERPOP-2055
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2055
> Project: TinkerPop
> Issue Type: Improvement
> Components: io
>Affects Versions: 3.2.9
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
>
> GraphSON currently doesn't handle: {{Double.Nan}},
> {{Double.NEGATIVE_INFINITY}} or {{Double.POSITIVE_INFINITY}} because it has a
> custom {{Double}} serializer that ignores those cases in GraphSON 2.0 and
> 3.0. Not going to try to solve this for 1.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop pull request #947: TINKERPOP-2055 Support NaN and Infinity in Grap...
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/947#discussion_r222757984
--- Diff:
gremlin-javascript/src/main/javascript/gremlin-javascript/test/unit/graphson-test.js
---
@@ -46,6 +46,30 @@ describe('GraphSONReader', function () {
assert.strictEqual(result, item[1]);
});
});
+ it('should parse GraphSON Nan from GraphSON', function () {
+ const reader = new GraphSONReader();
+ var result = reader.read({
+"@type": "g:Double",
+"@value": "NaN"
+ });
+ assert.ok(isNaN(result));
+ });
+ it('should parse GraphSON -Infinity and Nan from GraphSON', function () {
--- End diff --
just missed the capitlization in that string. i can fix it
---
[jira] [Commented] (TINKERPOP-2055) Provide support for special number cases like Infinity in GraphSON
[
https://issues.apache.org/jira/browse/TINKERPOP-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638564#comment-16638564
]
ASF GitHub Bot commented on TINKERPOP-2055:
---
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/947#discussion_r222757984
--- Diff:
gremlin-javascript/src/main/javascript/gremlin-javascript/test/unit/graphson-test.js
---
@@ -46,6 +46,30 @@ describe('GraphSONReader', function () {
assert.strictEqual(result, item[1]);
});
});
+ it('should parse GraphSON Nan from GraphSON', function () {
+ const reader = new GraphSONReader();
+ var result = reader.read({
+"@type": "g:Double",
+"@value": "NaN"
+ });
+ assert.ok(isNaN(result));
+ });
+ it('should parse GraphSON -Infinity and Nan from GraphSON', function () {
--- End diff --
just missed the capitlization in that string. i can fix it
> Provide support for special number cases like Infinity in GraphSON
> --
>
> Key: TINKERPOP-2055
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2055
> Project: TinkerPop
> Issue Type: Improvement
> Components: io
>Affects Versions: 3.2.9
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
>
> GraphSON currently doesn't handle: {{Double.Nan}},
> {{Double.NEGATIVE_INFINITY}} or {{Double.POSITIVE_INFINITY}} because it has a
> custom {{Double}} serializer that ignores those cases in GraphSON 2.0 and
> 3.0. Not going to try to solve this for 1.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop pull request #947: TINKERPOP-2055 Support NaN and Infinity in Grap...
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/947 ---
[jira] [Closed] (TINKERPOP-2055) Provide support for special number cases like Infinity in GraphSON
[
https://issues.apache.org/jira/browse/TINKERPOP-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-2055.
---
Resolution: Done
Fix Version/s: 3.2.10
3.3.4
3.4.0
> Provide support for special number cases like Infinity in GraphSON
> --
>
> Key: TINKERPOP-2055
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2055
> Project: TinkerPop
> Issue Type: Improvement
> Components: io
>Affects Versions: 3.2.9
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
> Fix For: 3.4.0, 3.3.4, 3.2.10
>
>
> GraphSON currently doesn't handle: {{Double.Nan}},
> {{Double.NEGATIVE_INFINITY}} or {{Double.POSITIVE_INFINITY}} because it has a
> custom {{Double}} serializer that ignores those cases in GraphSON 2.0 and
> 3.0. Not going to try to solve this for 1.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-2055) Provide support for special number cases like Infinity in GraphSON
[
https://issues.apache.org/jira/browse/TINKERPOP-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638697#comment-16638697
]
ASF GitHub Bot commented on TINKERPOP-2055:
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/947
> Provide support for special number cases like Infinity in GraphSON
> --
>
> Key: TINKERPOP-2055
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2055
> Project: TinkerPop
> Issue Type: Improvement
> Components: io
>Affects Versions: 3.2.9
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
> Fix For: 3.4.0, 3.3.4, 3.2.10
>
>
> GraphSON currently doesn't handle: {{Double.Nan}},
> {{Double.NEGATIVE_INFINITY}} or {{Double.POSITIVE_INFINITY}} because it has a
> custom {{Double}} serializer that ignores those cases in GraphSON 2.0 and
> 3.0. Not going to try to solve this for 1.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop issue #922: TINKERPOP-1959: Gremlin Javascript ability to send a s...
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
@spmallette Ok so your above code runs fine and returns a value. It appears
that my call to g.V(1).property() is not liked.
My request looks like this now:
`[RequestMessage{, requestId=7baf2b77-ca79-4679-9812-f3e0d8d3dbb5,
op='eval', processor='', args={gremlin=g.V(1).property(card, nm, val),
aliases={g=gmodern}, bindings={card={typeName=Cardinality, elementName=set},
nm=test, val=12}, language=gremlin-groovy,
accept=application/vnd.gremlin-v2.0+json}}]`
The full error I get is as follows:
`java.lang.IllegalArgumentException: The provided key/value array length
must be a multiple of two
at
org.apache.tinkerpop.gremlin.structure.Element$Exceptions.providedKeyValuesMustBeAMultipleOfTwo
(Element.java:125)
at
org.apache.tinkerpop.gremlin.process.traversal.step.util.Parameters.set
(Parameters.java:175)
at
org.apache.tinkerpop.gremlin.process.traversal.step.sideEffect.AddPropertyStep.addPropertyMutations
(AddPropertyStep.java:80)
at
org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal.property
(GraphTraversal.java:2066)
at
org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal.property
(GraphTraversal.java:2094)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at
org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite$PojoCachedMethodSite.invoke
(PojoMetaMethodSite.java:192)
at org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite.call
(PojoMetaMethodSite.java:56)
at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall
(CallSiteArray.java:47)
at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call
(AbstractCallSite.java:116)
at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call
(AbstractCallSite.java:144)
at Script7.run (Script7.groovy:1)
at
org.apache.tinkerpop.gremlin.groovy.jsr223.GremlinGroovyScriptEngine.eval
(GremlinGroovyScriptEngine.java:856)
at
org.apache.tinkerpop.gremlin.groovy.jsr223.GremlinGroovyScriptEngine.eval
(GremlinGroovyScriptEngine.java:561)
at javax.script.AbstractScriptEngine.eval
(AbstractScriptEngine.java:233)
at org.apache.tinkerpop.gremlin.groovy.engine.ScriptEngines.eval
(ScriptEngines.java:135)
at
org.apache.tinkerpop.gremlin.groovy.engine.GremlinExecutor.lambda$eval$0
(GremlinExecutor.java:291)
at java.util.concurrent.FutureTask.run (FutureTask.java:266)
at java.util.concurrent.Executors$RunnableAdapter.call
(Executors.java:511)
at java.util.concurrent.FutureTask.run (FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker
(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run
(ThreadPoolExecutor.java:617)
at java.lang.Thread.run (Thread.java:748)`
What is the best way forward, your test proves that non native JS types are
being sent correctly, but my test should also work...
---
[jira] [Commented] (TINKERPOP-1959) Provide a way to submit scripts to the server in gremlin-javascript
[
https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638728#comment-16638728
]
ASF GitHub Bot commented on TINKERPOP-1959:
---
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
@spmallette Ok so your above code runs fine and returns a value. It appears
that my call to g.V(1).property() is not liked.
My request looks like this now:
`[RequestMessage{, requestId=7baf2b77-ca79-4679-9812-f3e0d8d3dbb5,
op='eval', processor='', args={gremlin=g.V(1).property(card, nm, val),
aliases={g=gmodern}, bindings={card={typeName=Cardinality, elementName=set},
nm=test, val=12}, language=gremlin-groovy,
accept=application/vnd.gremlin-v2.0+json}}]`
The full error I get is as follows:
`java.lang.IllegalArgumentException: The provided key/value array length
must be a multiple of two
at
org.apache.tinkerpop.gremlin.structure.Element$Exceptions.providedKeyValuesMustBeAMultipleOfTwo
(Element.java:125)
at
org.apache.tinkerpop.gremlin.process.traversal.step.util.Parameters.set
(Parameters.java:175)
at
org.apache.tinkerpop.gremlin.process.traversal.step.sideEffect.AddPropertyStep.addPropertyMutations
(AddPropertyStep.java:80)
at
org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal.property
(GraphTraversal.java:2066)
at
org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal.property
(GraphTraversal.java:2094)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at
org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite$PojoCachedMethodSite.invoke
(PojoMetaMethodSite.java:192)
at org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite.call
(PojoMetaMethodSite.java:56)
at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall
(CallSiteArray.java:47)
at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call
(AbstractCallSite.java:116)
at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call
(AbstractCallSite.java:144)
at Script7.run (Script7.groovy:1)
at
org.apache.tinkerpop.gremlin.groovy.jsr223.GremlinGroovyScriptEngine.eval
(GremlinGroovyScriptEngine.java:856)
at
org.apache.tinkerpop.gremlin.groovy.jsr223.GremlinGroovyScriptEngine.eval
(GremlinGroovyScriptEngine.java:561)
at javax.script.AbstractScriptEngine.eval
(AbstractScriptEngine.java:233)
at org.apache.tinkerpop.gremlin.groovy.engine.ScriptEngines.eval
(ScriptEngines.java:135)
at
org.apache.tinkerpop.gremlin.groovy.engine.GremlinExecutor.lambda$eval$0
(GremlinExecutor.java:291)
at java.util.concurrent.FutureTask.run (FutureTask.java:266)
at java.util.concurrent.Executors$RunnableAdapter.call
(Executors.java:511)
at java.util.concurrent.FutureTask.run (FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker
(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run
(ThreadPoolExecutor.java:617)
at java.lang.Thread.run (Thread.java:748)`
What is the best way forward, your test proves that non native JS types are
being sent correctly, but my test should also work...
> Provide a way to submit scripts to the server in gremlin-javascript
> ---
>
> Key: TINKERPOP-1959
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1959
> Project: TinkerPop
> Issue Type: Improvement
> Components: javascript
>Affects Versions: 3.2.8
>Reporter: stephen mallette
>Priority: Critical
>
> It is currently only possible to submit bytecode based requests to the server
> with gremlin-javascript. We should also provide some means for submitting
> scripts.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop issue #922: TINKERPOP-1959: Gremlin Javascript ability to send a s...
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/922
It works with Java and GraphSON 2.0:
```text
gremlin> cluster = Cluster.build().serializer("GRAPHSON_V2D0").create()
==>localhost/127.0.0.1:8182
gremlin> client = cluster.connect()
==>org.apache.tinkerpop.gremlin.driver.Client$ClusteredClient@24a298a6
gremlin> client.submit("g.addV().property(c,k,v)",
[c:set,k:'name',v:123]).all().get()
==>result{object=v[4]
class=org.apache.tinkerpop.gremlin.structure.util.detached.DetachedVertex}
gremlin> client.submit("g.V().has('name',123).count()").all().get()
==>result{object=1 class=java.lang.Long}
```
So, i'm not sure what's wrong. If you want to commit/push what you have i
can try to test on my own to see what I (or maybe someone else) can figure out.
---
[jira] [Commented] (TINKERPOP-1959) Provide a way to submit scripts to the server in gremlin-javascript
[
https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638750#comment-16638750
]
ASF GitHub Bot commented on TINKERPOP-1959:
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/922
It works with Java and GraphSON 2.0:
```text
gremlin> cluster = Cluster.build().serializer("GRAPHSON_V2D0").create()
==>localhost/127.0.0.1:8182
gremlin> client = cluster.connect()
==>org.apache.tinkerpop.gremlin.driver.Client$ClusteredClient@24a298a6
gremlin> client.submit("g.addV().property(c,k,v)",
[c:set,k:'name',v:123]).all().get()
==>result{object=v[4]
class=org.apache.tinkerpop.gremlin.structure.util.detached.DetachedVertex}
gremlin> client.submit("g.V().has('name',123).count()").all().get()
==>result{object=1 class=java.lang.Long}
```
So, i'm not sure what's wrong. If you want to commit/push what you have i
can try to test on my own to see what I (or maybe someone else) can figure out.
> Provide a way to submit scripts to the server in gremlin-javascript
> ---
>
> Key: TINKERPOP-1959
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1959
> Project: TinkerPop
> Issue Type: Improvement
> Components: javascript
>Affects Versions: 3.2.8
>Reporter: stephen mallette
>Priority: Critical
>
> It is currently only possible to submit bytecode based requests to the server
> with gremlin-javascript. We should also provide some means for submitting
> scripts.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop issue #928: TINKERPOP-2015 Expose WebSocket configuration in Greml...
Github user jantzeca commented on the issue: https://github.com/apache/tinkerpop/pull/928 My latest Gremlin.net NuGet package is showing as 3.3.3. Is the package for these new changes not ready yet? ---
[jira] [Commented] (TINKERPOP-1959) Provide a way to submit scripts to the server in gremlin-javascript
[ https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638790#comment-16638790 ] ASF GitHub Bot commented on TINKERPOP-1959: --- Github user mattallenuk commented on the issue: https://github.com/apache/tinkerpop/pull/922 @spmallette Ok, have pushed the changes along with the documentation changes we'd discussed. Hopefully it's an easy fix. > Provide a way to submit scripts to the server in gremlin-javascript > --- > > Key: TINKERPOP-1959 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1959 > Project: TinkerPop > Issue Type: Improvement > Components: javascript >Affects Versions: 3.2.8 >Reporter: stephen mallette >Priority: Critical > > It is currently only possible to submit bytecode based requests to the server > with gremlin-javascript. We should also provide some means for submitting > scripts. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #922: TINKERPOP-1959: Gremlin Javascript ability to send a s...
Github user mattallenuk commented on the issue: https://github.com/apache/tinkerpop/pull/922 @spmallette Ok, have pushed the changes along with the documentation changes we'd discussed. Hopefully it's an easy fix. ---
[GitHub] tinkerpop issue #950: TINKERPOP-2058 Contains predicates should rely on Comp...
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/950 Reminder: Merge #949 first, then rebase this PRs branch and fix `PTest` (include differing number tests for `Contains` predicates). https://github.com/apache/tinkerpop/pull/949/files#diff-dc8c8777ab12a44729fc5f2c9c255c66R115 ---
[GitHub] tinkerpop issue #928: TINKERPOP-2015 Expose WebSocket configuration in Greml...
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/928 @jantzeca this merged a day or so ago. it has not been released yet to nuget. we have releases scheduled for 3.2.10 and 3.3.4 in the next couple of weeks. it will be available then. ---
[jira] [Commented] (TINKERPOP-1972) inject() tests are throwing exceptions in .NET GLV tests
[
https://issues.apache.org/jira/browse/TINKERPOP-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638804#comment-16638804
]
stephen mallette commented on TINKERPOP-1972:
-
hmm - at least you pinpointed the problem. java seems to generate this bytecode
{code}
{
"@type": "g:Bytecode",
"@value": {
"step": [
["inject", {
"@type": "g:Int32",
"@value": 1
}],
["choose", {
"@type": "g:Bytecode",
"@value": {
"step": [
["is", {
"@type": "g:Int32",
"@value": 1
}]
]
}
}, {
"@type": "g:Bytecode",
"@value": {
"step": [
["constant", {
"@type": "g:Int32",
"@value": 10
}],
["fold"]
]
}
}, {
"@type": "g:Bytecode",
"@value": {
"step": [
["fold"]
]
}
}]
]
}
}
{code}
which seems to match what you said is working after you edit the file above
(i.e. remove the embedded list in the argument for {{inject()}}). I tried to
dig into it futher but I can't say I follow where that problem is originating
from yet. you say it's something "general" but is the problem general to
serialization or bytecode construction or did you not get that far?
> inject() tests are throwing exceptions in .NET GLV tests
>
>
> Key: TINKERPOP-1972
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1972
> Project: TinkerPop
> Issue Type: Bug
> Components: dotnet
>Affects Versions: 3.2.9
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
>
> New GLV tests were added in TINKERPOP-1963 and are generating this error:
> {code}
> Failures:
> 1) g_injectX1X_chooseXisX1X__constantX10Xfold__foldX: Failed
> System.NotSupportedException: Type is not supported.
>at System.Array.InternalCreate(Void* elementType, Int32 rank, Int32*
> pLengths, Int32* pLowerBounds)
>at System.Array.CreateInstance(Type elementType, Int32 length)
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.BuildParameters(MethodInfo
> method, Token token, IDictionary`2& genericParameterTypes) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 268
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.GetTraversalFromTokens(IList`1
> tokens, GraphTraversalSource g, IDictionary`2 contextParameterValues, String
> traversalText) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 90
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.GetTraversal(String
> traversalText, GraphTraversalSource g, IDictionary`2 contextParameterValues)
> in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 62
>at
> Gremlin.Net.IntegrationTest.Gherkin.CommonSteps.TranslateTraversal(String
> traversalText) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs:line
> 101
> 2) g_injectX2X_chooseXisX1X__constantX10Xfold__foldX: Failed
> System.NotSupportedException: Type is not supported.
>at System.Array.InternalCreate(Void* elementType, Int32 rank, Int32*
> pLengths, Int32* pLowerBounds)
>at System.Array.CreateInstance(Type elementType, Int32 length)
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.BuildParameters(MethodInfo
> method, T
[jira] [Commented] (TINKERPOP-1972) inject() tests are throwing exceptions in .NET GLV tests
[
https://issues.apache.org/jira/browse/TINKERPOP-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638812#comment-16638812
]
stephen mallette commented on TINKERPOP-1972:
-
We don't have tests for multiple {{inject()}} which is odd...anyway, out of
curiosity, I did this:
{code}
gremlin> mapper = GraphSONMapper.build().version("V2_0").create().createMapper()
==>org.apache.tinkerpop.shaded.jackson.databind.ObjectMapper@226b143b
gremlin> mapper.writeValueAsString(g.inject(1,2,3).asAdmin().bytecode)
==>{"@type":"g:Bytecode","@value":{"step":[["inject",{"@type":"g:Int32","@value":1},{"@type":"g:Int32","@value":2},{"@type":"g:Int32","@value":3}]]}}
{code}
which formats to:
{code}
{
"@type": "g:Bytecode",
"@value": {
"step": [
["inject", {
"@type": "g:Int32",
"@value": 1
}, {
"@type": "g:Int32",
"@value": 2
}, {
"@type": "g:Int32",
"@value": 3
}]
]
}
}
{code}
> inject() tests are throwing exceptions in .NET GLV tests
>
>
> Key: TINKERPOP-1972
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1972
> Project: TinkerPop
> Issue Type: Bug
> Components: dotnet
>Affects Versions: 3.2.9
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
>
> New GLV tests were added in TINKERPOP-1963 and are generating this error:
> {code}
> Failures:
> 1) g_injectX1X_chooseXisX1X__constantX10Xfold__foldX: Failed
> System.NotSupportedException: Type is not supported.
>at System.Array.InternalCreate(Void* elementType, Int32 rank, Int32*
> pLengths, Int32* pLowerBounds)
>at System.Array.CreateInstance(Type elementType, Int32 length)
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.BuildParameters(MethodInfo
> method, Token token, IDictionary`2& genericParameterTypes) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 268
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.GetTraversalFromTokens(IList`1
> tokens, GraphTraversalSource g, IDictionary`2 contextParameterValues, String
> traversalText) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 90
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.GetTraversal(String
> traversalText, GraphTraversalSource g, IDictionary`2 contextParameterValues)
> in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 62
>at
> Gremlin.Net.IntegrationTest.Gherkin.CommonSteps.TranslateTraversal(String
> traversalText) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs:line
> 101
> 2) g_injectX2X_chooseXisX1X__constantX10Xfold__foldX: Failed
> System.NotSupportedException: Type is not supported.
>at System.Array.InternalCreate(Void* elementType, Int32 rank, Int32*
> pLengths, Int32* pLowerBounds)
>at System.Array.CreateInstance(Type elementType, Int32 length)
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.BuildParameters(MethodInfo
> method, Token token, IDictionary`2& genericParameterTypes) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 268
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.GetTraversalFromTokens(IList`1
> tokens, GraphTraversalSource g, IDictionary`2 contextParameterValues, String
> traversalText) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 90
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.GetTraversal(String
> traversalText, GraphTraversalSource g, IDictionary`2 contextParameterValues)
> in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 62
>at
> Gremlin.Net.IntegrationTest.Gherkin.CommonSteps.TranslateTraversal(String
> traversalText) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationT
[jira] [Commented] (TINKERPOP-2015) Allow users to configure the WebSocket connections
[
https://issues.apache.org/jira/browse/TINKERPOP-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638800#comment-16638800
]
ASF GitHub Bot commented on TINKERPOP-2015:
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/928
@jantzeca this merged a day or so ago. it has not been released yet to
nuget. we have releases scheduled for 3.2.10 and 3.3.4 in the next couple of
weeks. it will be available then.
> Allow users to configure the WebSocket connections
> --
>
> Key: TINKERPOP-2015
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2015
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
>Affects Versions: 3.3.3, 3.2.9
>Reporter: Florian Hockmann
>Assignee: Florian Hockmann
>Priority: Major
> Fix For: 3.4.0, 3.3.4, 3.2.10
>
>
> Gremlin.Net currently just creates instances of the {{ClientWebSocket}} class
> with default options. That is probably appropriate for most users but it
> makes it impossible to change the config and use certain features like client
> certificates or proxy settings.
> We could simply allow users to provide a
> [{{ClientWebSocketOptions}}|https://docs.microsoft.com/dotnet/api/system.net.websockets.clientwebsocketoptions]
> object. Since it's part of .NET Standard (and not a 3rd party library) it
> shouldn't be a problem to expose this type. This would also have the nice
> advantage that users could immediately use new options like the
> {{[RemoteCertificateValidationCallback|https://docs.microsoft.com/dotnet/api/system.net.websockets.clientwebsocketoptions.remotecertificatevalidationcallback]}}
> that was just added in .NET Core 2.1.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-2058) Contains predicates should rely on Compare predicates
[
https://issues.apache.org/jira/browse/TINKERPOP-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638798#comment-16638798
]
ASF GitHub Bot commented on TINKERPOP-2058:
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/950
Reminder: Merge #949 first, then rebase this PRs branch and fix `PTest`
(include differing number tests for `Contains` predicates).
https://github.com/apache/tinkerpop/pull/949/files#diff-dc8c8777ab12a44729fc5f2c9c255c66R115
> Contains predicates should rely on Compare predicates
> -
>
> Key: TINKERPOP-2058
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2058
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.4.0
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>Priority: Major
> Labels: breaking
>
> The problem:
> {noformat}
> gremlin> g.V().has("age", eq(32L))
> ==>v[4]
> gremlin> g.V().has("age", within(32L, 35L))
> gremlin>
> {noformat}
> {{Contains}} predicates should really behave the same way {{Compare}}
> predicates do.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-2015) Allow users to configure the WebSocket connections
[
https://issues.apache.org/jira/browse/TINKERPOP-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638775#comment-16638775
]
ASF GitHub Bot commented on TINKERPOP-2015:
---
Github user jantzeca commented on the issue:
https://github.com/apache/tinkerpop/pull/928
My latest Gremlin.net NuGet package is showing as 3.3.3. Is the package for
these new changes not ready yet?
> Allow users to configure the WebSocket connections
> --
>
> Key: TINKERPOP-2015
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2015
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
>Affects Versions: 3.3.3, 3.2.9
>Reporter: Florian Hockmann
>Assignee: Florian Hockmann
>Priority: Major
> Fix For: 3.4.0, 3.3.4, 3.2.10
>
>
> Gremlin.Net currently just creates instances of the {{ClientWebSocket}} class
> with default options. That is probably appropriate for most users but it
> makes it impossible to change the config and use certain features like client
> certificates or proxy settings.
> We could simply allow users to provide a
> [{{ClientWebSocketOptions}}|https://docs.microsoft.com/dotnet/api/system.net.websockets.clientwebsocketoptions]
> object. Since it's part of .NET Standard (and not a 3rd party library) it
> shouldn't be a problem to expose this type. This would also have the nice
> advantage that users could immediately use new options like the
> {{[RemoteCertificateValidationCallback|https://docs.microsoft.com/dotnet/api/system.net.websockets.clientwebsocketoptions.remotecertificatevalidationcallback]}}
> that was just added in .NET Core 2.1.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop issue #922: TINKERPOP-1959: Gremlin Javascript ability to send a s...
Github user mattallenuk commented on the issue: https://github.com/apache/tinkerpop/pull/922 @spmallette I can confirm that this test works for bytecode submission so possibly an issue in the way the bindings are being submitted? Should the language parameter be gremlin-groovy or something else? ---
[jira] [Commented] (TINKERPOP-1959) Provide a way to submit scripts to the server in gremlin-javascript
[ https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638832#comment-16638832 ] ASF GitHub Bot commented on TINKERPOP-1959: --- Github user mattallenuk commented on the issue: https://github.com/apache/tinkerpop/pull/922 @spmallette I can confirm that this test works for bytecode submission so possibly an issue in the way the bindings are being submitted? Should the language parameter be gremlin-groovy or something else? > Provide a way to submit scripts to the server in gremlin-javascript > --- > > Key: TINKERPOP-1959 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1959 > Project: TinkerPop > Issue Type: Improvement > Components: javascript >Affects Versions: 3.2.8 >Reporter: stephen mallette >Priority: Critical > > It is currently only possible to submit bytecode based requests to the server > with gremlin-javascript. We should also provide some means for submitting > scripts. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #922: TINKERPOP-1959: Gremlin Javascript ability to send a s...
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/922 "gremlin-groovy" is fine. The server should default to that if the argument isn't present. ---
[jira] [Commented] (TINKERPOP-1959) Provide a way to submit scripts to the server in gremlin-javascript
[ https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638837#comment-16638837 ] ASF GitHub Bot commented on TINKERPOP-1959: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/922 "gremlin-groovy" is fine. The server should default to that if the argument isn't present. > Provide a way to submit scripts to the server in gremlin-javascript > --- > > Key: TINKERPOP-1959 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1959 > Project: TinkerPop > Issue Type: Improvement > Components: javascript >Affects Versions: 3.2.8 >Reporter: stephen mallette >Priority: Critical > > It is currently only possible to submit bytecode based requests to the server > with gremlin-javascript. We should also provide some means for submitting > scripts. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #948: Optimizes Map with enum using the EnumMap implementati...
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/948 All tests pass with `docker/build.sh -t -n -i` VOTE +1 ---
[GitHub] tinkerpop pull request #948: Optimizes Map with enum using the EnumMap imple...
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/948 ---
[jira] [Commented] (TINKERPOP-2037) Remove unused groovy-sql dependency
[ https://issues.apache.org/jira/browse/TINKERPOP-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638854#comment-16638854 ] ASF GitHub Bot commented on TINKERPOP-2037: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/946 @robertdale lots of stuff merged today - looks like you need a rebase on this one > Remove unused groovy-sql dependency > --- > > Key: TINKERPOP-2037 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2037 > Project: TinkerPop > Issue Type: Improvement > Components: driver >Reporter: Robert Dale >Assignee: Robert Dale >Priority: Trivial > Fix For: 3.4.0 > > > See thread - > https://lists.apache.org/thread.html/da6008600e76d828f435cba7d4f7d9c0334e45e854dab8a9ad967232@%3Cdev.tinkerpop.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #946: TINKERPOP-2037 removed groovy-sql
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/946 @robertdale lots of stuff merged today - looks like you need a rebase on this one ---
[GitHub] tinkerpop issue #948: Optimizes Map with enum using the EnumMap implementati...
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/948 merged to all release branches - thanks @otaviojava ---
[jira] [Commented] (TINKERPOP-1972) inject() tests are throwing exceptions in .NET GLV tests
[
https://issues.apache.org/jira/browse/TINKERPOP-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638884#comment-16638884
]
Florian Hockmann commented on TINKERPOP-1972:
-
I'm not sure yet where the problem exactly is, but it seems to be not a problem
of the traversal generation that we use for the Gherkin tests. I created a
small test that builds the same traversal directly in C# and it had the same
problem. So, the problem seems to be with the {{Inject}} step itself in
Gremlin.Net which probably means that other steps that take a {{params}} array
have the same problem which is what I meant with that it seems to be a general
problem.
I just used your {{inject}} traversal with its GraphSON 2 representation to
write a unit test in C#:
{code}
var graphsonWriter = CreateGraphSONWriter();
var g = new Graph().Traversal();
var graphSON = graphsonWriter.WriteObject(g.Inject(1,2,3).Bytecode);
Assert.Equal(
"{\"@type\":\"g:Bytecode\",\"@value\":{\"step\":[[\"inject\",{\"@type\":\"g:Int32\",\"@value\":1},{\"@type\":\"g:Int32\",\"@value\":2},{\"@type\":\"g:Int32\",\"@value\":3}]]}}",
graphSON);
{code}
This test fails because Gremlin.Net adds square brackets around the integers.
However, the same test succeeds for this traversal: {{g.V().Out("a", "b")}}
with the GraphSON representation taken from Java again which also doesn't
contain square brackets.
So, the problem seems to be specific to {{Inject}} or maybe to steps that take
a generic {{params}} array. That is at least the only difference I can see
between those two steps.
> inject() tests are throwing exceptions in .NET GLV tests
>
>
> Key: TINKERPOP-1972
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1972
> Project: TinkerPop
> Issue Type: Bug
> Components: dotnet
>Affects Versions: 3.2.9
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
>
> New GLV tests were added in TINKERPOP-1963 and are generating this error:
> {code}
> Failures:
> 1) g_injectX1X_chooseXisX1X__constantX10Xfold__foldX: Failed
> System.NotSupportedException: Type is not supported.
>at System.Array.InternalCreate(Void* elementType, Int32 rank, Int32*
> pLengths, Int32* pLowerBounds)
>at System.Array.CreateInstance(Type elementType, Int32 length)
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.BuildParameters(MethodInfo
> method, Token token, IDictionary`2& genericParameterTypes) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 268
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.GetTraversalFromTokens(IList`1
> tokens, GraphTraversalSource g, IDictionary`2 contextParameterValues, String
> traversalText) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 90
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.GetTraversal(String
> traversalText, GraphTraversalSource g, IDictionary`2 contextParameterValues)
> in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 62
>at
> Gremlin.Net.IntegrationTest.Gherkin.CommonSteps.TranslateTraversal(String
> traversalText) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs:line
> 101
> 2) g_injectX2X_chooseXisX1X__constantX10Xfold__foldX: Failed
> System.NotSupportedException: Type is not supported.
>at System.Array.InternalCreate(Void* elementType, Int32 rank, Int32*
> pLengths, Int32* pLowerBounds)
>at System.Array.CreateInstance(Type elementType, Int32 length)
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.BuildParameters(MethodInfo
> method, Token token, IDictionary`2& genericParameterTypes) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 268
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.GetTraversalFromTokens(IList`1
> tokens, GraphTraversalSource g, IDictionary`2 contextParameterValues, String
> traversalText) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 90
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.GetTraversal(String
> traversalText, GraphTraversalSource g, IDictionary`2 contextParameterValue
[jira] [Commented] (TINKERPOP-1972) inject() tests are throwing exceptions in .NET GLV tests
[
https://issues.apache.org/jira/browse/TINKERPOP-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638941#comment-16638941
]
Florian Hockmann commented on TINKERPOP-1972:
-
Looks like I got down to the problem:
The method {{Bytecode.AddStep()}} takes as its second argument a {{params
object[] args}} and we pass all arguments always as an array to this function.
This results in each argument being an element of the {{args}} array that
{{AddStep}} takes. However, for some reason the compiler treats an array with a
generic type differently here and {{args}} will be an array that only has one
element, namely the generic array.
So {{string[] \{"a", "b"\}}} becomes {{object[] \{"a", "b"\}}}
but {{S[] \{1, 2, 3\}}} becomes {{object[] \{object[] \{1, 2, 3\}\}}}
I just manually adjusted the {{Inject}} step to use an {{object[]}} instead of
{{S[]}} and it fixed the problem. The failing scenario also succeeds with this
change. So, we now only need to use this fix in the code generation for
Gremlin.Net. I'll try to implement this tomorrow and then push a commit to the
branch [~jorgebg] already started for this issue.
> inject() tests are throwing exceptions in .NET GLV tests
>
>
> Key: TINKERPOP-1972
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1972
> Project: TinkerPop
> Issue Type: Bug
> Components: dotnet
>Affects Versions: 3.2.9
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
>
> New GLV tests were added in TINKERPOP-1963 and are generating this error:
> {code}
> Failures:
> 1) g_injectX1X_chooseXisX1X__constantX10Xfold__foldX: Failed
> System.NotSupportedException: Type is not supported.
>at System.Array.InternalCreate(Void* elementType, Int32 rank, Int32*
> pLengths, Int32* pLowerBounds)
>at System.Array.CreateInstance(Type elementType, Int32 length)
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.BuildParameters(MethodInfo
> method, Token token, IDictionary`2& genericParameterTypes) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 268
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.GetTraversalFromTokens(IList`1
> tokens, GraphTraversalSource g, IDictionary`2 contextParameterValues, String
> traversalText) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 90
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.GetTraversal(String
> traversalText, GraphTraversalSource g, IDictionary`2 contextParameterValues)
> in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 62
>at
> Gremlin.Net.IntegrationTest.Gherkin.CommonSteps.TranslateTraversal(String
> traversalText) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs:line
> 101
> 2) g_injectX2X_chooseXisX1X__constantX10Xfold__foldX: Failed
> System.NotSupportedException: Type is not supported.
>at System.Array.InternalCreate(Void* elementType, Int32 rank, Int32*
> pLengths, Int32* pLowerBounds)
>at System.Array.CreateInstance(Type elementType, Int32 length)
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.BuildParameters(MethodInfo
> method, Token token, IDictionary`2& genericParameterTypes) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 268
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.GetTraversalFromTokens(IList`1
> tokens, GraphTraversalSource g, IDictionary`2 contextParameterValues, String
> traversalText) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 90
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.GetTraversal(String
> traversalText, GraphTraversalSource g, IDictionary`2 contextParameterValues)
> in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 62
>at
> Gremlin.Net.IntegrationTest.Gherkin.CommonSteps.TranslateTraversal(String
> traversalText) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs:line
> 101
> {code}
--
This message was sent by
[jira] [Assigned] (TINKERPOP-1972) inject() tests are throwing exceptions in .NET GLV tests
[
https://issues.apache.org/jira/browse/TINKERPOP-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette reassigned TINKERPOP-1972:
---
Assignee: Florian Hockmann (was: stephen mallette)
wow - nice job! i've assigned this one to you since it sounds like you have the
solution ready to go.
> inject() tests are throwing exceptions in .NET GLV tests
>
>
> Key: TINKERPOP-1972
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1972
> Project: TinkerPop
> Issue Type: Bug
> Components: dotnet
>Affects Versions: 3.2.9
>Reporter: stephen mallette
>Assignee: Florian Hockmann
>Priority: Minor
>
> New GLV tests were added in TINKERPOP-1963 and are generating this error:
> {code}
> Failures:
> 1) g_injectX1X_chooseXisX1X__constantX10Xfold__foldX: Failed
> System.NotSupportedException: Type is not supported.
>at System.Array.InternalCreate(Void* elementType, Int32 rank, Int32*
> pLengths, Int32* pLowerBounds)
>at System.Array.CreateInstance(Type elementType, Int32 length)
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.BuildParameters(MethodInfo
> method, Token token, IDictionary`2& genericParameterTypes) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 268
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.GetTraversalFromTokens(IList`1
> tokens, GraphTraversalSource g, IDictionary`2 contextParameterValues, String
> traversalText) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 90
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.GetTraversal(String
> traversalText, GraphTraversalSource g, IDictionary`2 contextParameterValues)
> in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 62
>at
> Gremlin.Net.IntegrationTest.Gherkin.CommonSteps.TranslateTraversal(String
> traversalText) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs:line
> 101
> 2) g_injectX2X_chooseXisX1X__constantX10Xfold__foldX: Failed
> System.NotSupportedException: Type is not supported.
>at System.Array.InternalCreate(Void* elementType, Int32 rank, Int32*
> pLengths, Int32* pLowerBounds)
>at System.Array.CreateInstance(Type elementType, Int32 length)
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.BuildParameters(MethodInfo
> method, Token token, IDictionary`2& genericParameterTypes) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 268
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.GetTraversalFromTokens(IList`1
> tokens, GraphTraversalSource g, IDictionary`2 contextParameterValues, String
> traversalText) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 90
>at
> Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation.TraversalParser.GetTraversal(String
> traversalText, GraphTraversalSource g, IDictionary`2 contextParameterValues)
> in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs:line
> 62
>at
> Gremlin.Net.IntegrationTest.Gherkin.CommonSteps.TranslateTraversal(String
> traversalText) in
> /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs:line
> 101
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
