[GitHub] [tinkerpop] mosence closed pull request #1028: Merge pull request #1 from apache/master
[ pull request closed by mosence ] [ Full content available at: https://github.com/apache/tinkerpop/pull/1028 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] mosence opened pull request #1028: Merge pull request #1 from apache/master
update new version [ Full content available at: https://github.com/apache/tinkerpop/pull/1028 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] robertdale opened pull request #1027: Bump Jackson Databind 2.9.8
https://issues.apache.org/jira/browse/TINKERPOP-2121 Fixes: CVE-2018-19360, CVE-2018-19361, CVE-2018-19362, CVE-2018-1000873 ``` $ docker/build.sh -i -t -n [INFO] Apache TinkerPop ... SUCCESS [01:10 min] [INFO] Apache TinkerPop :: Gremlin Shaded . SUCCESS [ 9.105 s] [INFO] Apache TinkerPop :: Gremlin Core ... SUCCESS [01:10 min] [INFO] Apache TinkerPop :: Gremlin Test ... SUCCESS [ 6.737 s] [INFO] Apache TinkerPop :: Gremlin Groovy . SUCCESS [03:32 min] [INFO] Apache TinkerPop :: Gremlin Groovy Test SUCCESS [ 4.568 s] [INFO] Apache TinkerPop :: TinkerGraph Gremlin SUCCESS [03:49 min] [INFO] Apache TinkerPop :: Gremlin Benchmark .. SUCCESS [ 3.470 s] [INFO] Apache TinkerPop :: Gremlin Driver . SUCCESS [ 20.742 s] [INFO] Apache TinkerPop :: Neo4j Gremlin .. SUCCESS [22:17 min] [INFO] Apache TinkerPop :: Gremlin Server . SUCCESS [18:06 min] [INFO] Apache TinkerPop :: Gremlin Javascript . SUCCESS [ 18.003 s] [INFO] Apache TinkerPop :: Gremlin Python . FAILURE [01:15 min] ``` Hopefully it's just that my docker image is out of date. [ Full content available at: https://github.com/apache/tinkerpop/pull/1027 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[jira] [Commented] (TINKERPOP-2119) Validate C# code samples in docs
[ https://issues.apache.org/jira/browse/TINKERPOP-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729094#comment-16729094 ] ASF GitHub Bot commented on TINKERPOP-2119: --- FlorianHockmann commented on pull request #1025: TINKERPOP-2119 Add C# code examples in doc as code URL: https://github.com/apache/tinkerpop/pull/1025 https://issues.apache.org/jira/browse/TINKERPOP-2119 I moved most of the code examples from the docs into C# source files from where they are now included in the docs. The examples are mostly added as tests. Although I had to disable (`skip`) most of these tests for now as they try to connect to a server running on `localhost:8182` where no server is listening in our test environment. Nevertheless, this ensures even for these disabled tests that the example code at least compiles and I could already find some more errors in these examples. We should from now one only add C# code examples to the docs by adding them as source code and then including them in the AsciiDoc to ensure that our examples in the docs always work and always match their respective version of Gremlin.Net. Only one C# code listing is still left directly in the docs as it includes numbers as references which are then referenced in the text below (for the lambda solution). We could of course replace these numbers simply by line numbers, but I didn't want to do that for just one example as it would break the style of the other examples. I verified that the changes in the docs look as expected manually after generating the docs with `docker/build.sh -d` and the .NET tests all pass. VOTE +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Validate C# code samples in docs > > > Key: TINKERPOP-2119 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2119 > Project: TinkerPop > Issue Type: Improvement > Components: documentation, dotnet >Affects Versions: 3.4.0 >Reporter: Florian Hockmann >Assignee: Florian Hockmann >Priority: Major > Fix For: 3.4.0 > > > The docs now contain a lot of C# code samples (thanks for that, Stephen and > Daniel). Unfortunately, some of these samples don't use proper C# syntax and > therefore won't compile. > Since I have already noticed in the past that some listings don't work any > more with more recent versions of Gremlin.Net, we should not only correct > these listings, but actually validate them automatically to ensure that we > notice once the listings don't work any more. > I limited the scope to C# here because I already noticed problems there, but > this could of course also be done later for the other GLVs that can't be > verified with the usual doc generation process. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (TINKERPOP-2088) Enable SourceLink for Gremlin.Net
[
https://issues.apache.org/jira/browse/TINKERPOP-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Florian Hockmann reassigned TINKERPOP-2088:
---
Assignee: Florian Hockmann
> Enable SourceLink for Gremlin.Net
> -
>
> Key: TINKERPOP-2088
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2088
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
>Reporter: Florian Hockmann
>Assignee: Florian Hockmann
>Priority: Minor
>
> SourceLink allows users to step into the sources of a library during
> debugging. Description [from the dotnet
> docs|https://docs.microsoft.com/dotnet/standard/library-guidance/sourcelink]:
> {quote}SourceLink is a technology that enables source code debugging of .NET
> assemblies from NuGet by developers. SourceLink executes when creating the
> NuGet package and embeds source control metadata inside assemblies and the
> package. Developers who download the package and have SourceLink enabled in
> Visual Studio can step into its source code. SourceLink provides source
> control metadata to create a great debugging experience.
> {quote}
> While the quote only mentions Visual Studio, it should also work with Rider
> and VS Code.
> The sources are fetched from GitHub. The NuGet package includes information
> about which commit was used to build the package.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-2088) Enable SourceLink for Gremlin.Net
[
https://issues.apache.org/jira/browse/TINKERPOP-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729103#comment-16729103
]
ASF GitHub Bot commented on TINKERPOP-2088:
---
FlorianHockmann commented on pull request #1026: TINKERPOP-2088 Enable
SourceLink for Gremlin.Net
URL: https://github.com/apache/tinkerpop/pull/1026
https://issues.apache.org/jira/browse/TINKERPOP-2088
This requires contributors to update to .NET Core SDK 2.1.300 or newer.
Travis and the Docker build now use the most recent SDK 2.2.
SourceLink should make it easier for users to debug Gremlin.Net within their
application as they get better access to the source code of Gremlin.Net during
debugging. That is why the .NET open-source library guidance recommends to
enable it for libraries.
The generated NuGet package includes a reference to our git repository as
well as the commit that belongs to the version included in the package:
I verified that the Docker build still works with `docker/build.sh`.
VOTE +1
NOTE: We don't need to merge this for the upcoming release, especially since
we have have a code freeze (although we don't strictly follow that for GLVs). I
just had some spare time to work on this, but we can also merge it after the
3.3.5 release.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enable SourceLink for Gremlin.Net
> -
>
> Key: TINKERPOP-2088
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2088
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
>Reporter: Florian Hockmann
>Priority: Minor
>
> SourceLink allows users to step into the sources of a library during
> debugging. Description [from the dotnet
> docs|https://docs.microsoft.com/dotnet/standard/library-guidance/sourcelink]:
> {quote}SourceLink is a technology that enables source code debugging of .NET
> assemblies from NuGet by developers. SourceLink executes when creating the
> NuGet package and embeds source control metadata inside assemblies and the
> package. Developers who download the package and have SourceLink enabled in
> Visual Studio can step into its source code. SourceLink provides source
> control metadata to create a great debugging experience.
> {quote}
> While the quote only mentions Visual Studio, it should also work with Rider
> and VS Code.
> The sources are fetched from GitHub. The NuGet package includes information
> about which commit was used to build the package.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [tinkerpop] FlorianHockmann opened pull request #1026: TINKERPOP-2088 Enable SourceLink for Gremlin.Net
https://issues.apache.org/jira/browse/TINKERPOP-2088 This requires contributors to update to .NET Core SDK 2.1.300 or newer. Travis and the Docker build now use the most recent SDK 2.2. SourceLink should make it easier for users to debug Gremlin.Net within their application as they get better access to the source code of Gremlin.Net during debugging. That is why the .NET open-source library guidance recommends to enable it for libraries. The generated NuGet package includes a reference to our git repository as well as the commit that belongs to the version included in the package:  I verified that the Docker build still works with `docker/build.sh`. VOTE +1 NOTE: We don't need to merge this for the upcoming release, especially since we have have a code freeze (although we don't strictly follow that for GLVs). I just had some spare time to work on this, but we can also merge it after the 3.3.5 release. [ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] FlorianHockmann opened pull request #1025: TINKERPOP-2119 Add C# code examples in doc as code
https://issues.apache.org/jira/browse/TINKERPOP-2119 I moved most of the code examples from the docs into C# source files from where they are now included in the docs. The examples are mostly added as tests. Although I had to disable (`skip`) most of these tests for now as they try to connect to a server running on `localhost:8182` where no server is listening in our test environment. Nevertheless, this ensures even for these disabled tests that the example code at least compiles and I could already find some more errors in these examples. We should from now one only add C# code examples to the docs by adding them as source code and then including them in the AsciiDoc to ensure that our examples in the docs always work and always match their respective version of Gremlin.Net. Only one C# code listing is still left directly in the docs as it includes numbers as references which are then referenced in the text below (for the lambda solution). We could of course replace these numbers simply by line numbers, but I didn't want to do that for just one example as it would break the style of the other examples. I verified that the changes in the docs look as expected manually after generating the docs with `docker/build.sh -d` and the .NET tests all pass. VOTE +1 [ Full content available at: https://github.com/apache/tinkerpop/pull/1025 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[jira] [Created] (TINKERPOP-2121) Bump Jackson Databind 2.9.8
Robert Dale created TINKERPOP-2121: -- Summary: Bump Jackson Databind 2.9.8 Key: TINKERPOP-2121 URL: https://issues.apache.org/jira/browse/TINKERPOP-2121 Project: TinkerPop Issue Type: Improvement Reporter: Robert Dale -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (TINKERPOP-2121) Bump Jackson Databind 2.9.8
[ https://issues.apache.org/jira/browse/TINKERPOP-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Dale updated TINKERPOP-2121: --- Labels: security (was: ) > Bump Jackson Databind 2.9.8 > --- > > Key: TINKERPOP-2121 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2121 > Project: TinkerPop > Issue Type: Improvement > Components: io >Affects Versions: 3.4.0, 3.3.4, 3.2.10 >Reporter: Robert Dale >Priority: Major > Labels: security > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (TINKERPOP-2121) Bump Jackson Databind 2.9.8
[ https://issues.apache.org/jira/browse/TINKERPOP-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Dale updated TINKERPOP-2121: --- Description: Fixes: CVE-2018-19360, CVE-2018-19361, CVE-2018-19362, CVE-2018-1000873 Release notes: [https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.9.8] > Bump Jackson Databind 2.9.8 > --- > > Key: TINKERPOP-2121 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2121 > Project: TinkerPop > Issue Type: Improvement > Components: io >Affects Versions: 3.4.0, 3.3.4, 3.2.10 >Reporter: Robert Dale >Priority: Major > Labels: security > > > Fixes: CVE-2018-19360, CVE-2018-19361, CVE-2018-19362, CVE-2018-1000873 > Release notes: > [https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.9.8] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (TINKERPOP-2121) Bump Jackson Databind 2.9.8
[ https://issues.apache.org/jira/browse/TINKERPOP-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Dale updated TINKERPOP-2121: --- Component/s: io > Bump Jackson Databind 2.9.8 > --- > > Key: TINKERPOP-2121 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2121 > Project: TinkerPop > Issue Type: Improvement > Components: io >Affects Versions: 3.4.0, 3.3.4, 3.2.10 >Reporter: Robert Dale >Priority: Major > Labels: security > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (TINKERPOP-2121) Bump Jackson Databind 2.9.8
[ https://issues.apache.org/jira/browse/TINKERPOP-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Dale updated TINKERPOP-2121: --- Affects Version/s: 3.4.0 3.3.4 3.2.10 > Bump Jackson Databind 2.9.8 > --- > > Key: TINKERPOP-2121 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2121 > Project: TinkerPop > Issue Type: Improvement > Components: io >Affects Versions: 3.4.0, 3.3.4, 3.2.10 >Reporter: Robert Dale >Priority: Major > Labels: security > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1964) Gremlin.Net: Expose Strategies in GraphTraversal
[
https://issues.apache.org/jira/browse/TINKERPOP-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729038#comment-16729038
]
Florian Hockmann commented on TINKERPOP-1964:
-
The easiest approach to solve this would be to just make the {{get}} property
{{DefaultTraversal.TraversalStrategies}} public, but that would only include
the {{RemoteStrategy}} as all other strategies are only sent to the server as
part of the {{Bytecode}}.
We could also extend the source step {{WithStrategies()}} to add the strategies
also to its {{TravesalStrategies}} which would still be pretty easy to
implement. (+ Exclusion of strategies via {{WithoutStrategies()}})
However, a traversal usually already includes some default strategies that are
not available directly via remote. For example, when I try the example from the
description in the Gremlin Console with TinkerGraph, then I get:
{code:java}
g.V().has("name", "jorge").asAdmin().getStrategies()
==>strategies[ConnectiveStrategy, IncidentToAdjacentStrategy,
MatchPredicateStrategy, FilterRankingStrategy, InlineFilterStrategy,
AdjacentToIncidentStrategy, RepeatUnrollStrategy, CountStrategy,
PathRetractionStrategy, LazyBarrierStrategy, TinkerGraphCountStrategy,
TinkerGraphStepStrategy, ProfileStrategy, StandardVerificationStrategy]
{code}
I guess if we really want to expose all strategies that will be applied to
their traversal, then we need to retrieve these default strategies, add
configured strategies by the user locally and then exclude strategies given to
{{WithoutStrategies()}}. But I'm not sure whether we really want to do that.
What do you think [~jorgebg]? Was your intention with this ticket only to show
the strategies configured locally in the GLV?
> Gremlin.Net: Expose Strategies in GraphTraversal
>
>
> Key: TINKERPOP-1964
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1964
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
>Reporter: Jorge Bay
>Priority: Major
>
> We should provide a way to access the strategies from the traversal.
> This is currently possible in java but not on the .NET GLV:
> {code:java}
> GraphTraversal traversal = g.V().has("name", "jorge");
> TraversalStrategies = traversal.asAdmin().getStrategies();
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-2113) P.Within() doesn't work when given a List argument
[
https://issues.apache.org/jira/browse/TINKERPOP-2113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729032#comment-16729032
]
ASF GitHub Bot commented on TINKERPOP-2113:
---
FlorianHockmann commented on pull request #1024: TINKERPOP-2113 Fix P.Within()
for list arguments in Gremlin.NET
URL: https://github.com/apache/tinkerpop/pull/1024
https://issues.apache.org/jira/browse/TINKERPOP-2119
This was apparently pretty much the same bug as with the problems we had
earlier with the `inject()` step
([TINKERPOP-1972](https://issues.apache.org/jira/browse/TINKERPOP-1972)). So,
the fix was also basically the same.
All .NET tests pass.
VOTE +1
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> P.Within() doesn't work when given a List argument
> --
>
> Key: TINKERPOP-2113
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2113
> Project: TinkerPop
> Issue Type: Bug
> Components: dotnet
>Affects Versions: 3.2.10
>Reporter: Florian Hockmann
>Assignee: Florian Hockmann
>Priority: Minor
>
> In short, this test fails with the modern graph:
> {code:c#}
> var names = new List {"josh", "vadas"};
> var count = g.V().Has("name", P.Within(names)).Count().Next();
> Assert.Equal(2, count);
> {code}
> but this works:
> {code:c#}
> var count = g.V().Has("name", P.Within("josh", "vadas")).Count().Next();
> Assert.Equal(2, count);;
> {code}
> for which we already have a test case.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [tinkerpop] FlorianHockmann opened pull request #1024: TINKERPOP-2113 Fix P.Within() for list arguments in Gremlin.NET
https://issues.apache.org/jira/browse/TINKERPOP-2119 This was apparently pretty much the same bug as with the problems we had earlier with the `inject()` step ([TINKERPOP-1972](https://issues.apache.org/jira/browse/TINKERPOP-1972)). So, the fix was also basically the same. All .NET tests pass. VOTE +1 [ Full content available at: https://github.com/apache/tinkerpop/pull/1024 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[jira] [Assigned] (TINKERPOP-2113) P.Within() doesn't work when given a List argument
[
https://issues.apache.org/jira/browse/TINKERPOP-2113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Florian Hockmann reassigned TINKERPOP-2113:
---
Assignee: Florian Hockmann
> P.Within() doesn't work when given a List argument
> --
>
> Key: TINKERPOP-2113
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2113
> Project: TinkerPop
> Issue Type: Bug
> Components: dotnet
>Affects Versions: 3.2.10
>Reporter: Florian Hockmann
>Assignee: Florian Hockmann
>Priority: Minor
>
> In short, this test fails with the modern graph:
> {code:c#}
> var names = new List {"josh", "vadas"};
> var count = g.V().Has("name", P.Within(names)).Count().Next();
> Assert.Equal(2, count);
> {code}
> but this works:
> {code:c#}
> var count = g.V().Has("name", P.Within("josh", "vadas")).Count().Next();
> Assert.Equal(2, count);;
> {code}
> for which we already have a test case.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [tinkerpop] FlorianHockmann commented on issue #1000: TINKERPOP-1942 New Binary Serialization Format
VOTE +1 [ Full content available at: https://github.com/apache/tinkerpop/pull/1000 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1000: TINKERPOP-1942 New Binary Serialization Format
Sure, but that's not what I meant. My problem was simply that I wasn't sure how
the value format and the type info are combined to form the full serialized
value, but I just read the first paragraph of this document again where this is
explained with:
```
{type_code}{type_info}{value_flag}{value}
```
My confusion probably just came because I read this document top to bottom and
the custom type is the first where a special type info is used. That shouldn't
be a problem however for someone else who jumps directly from the start of the
document to this type (or for someone with a better memory^^)
[ Full content available at: https://github.com/apache/tinkerpop/pull/1000 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
