[jira] [Created] (TINKERPOP-2313) Support query: g.E().properties().hasKey("xx") & hasValue("xx")
Jermy Li created TINKERPOP-2313:
---
Summary: Support query: g.E().properties().hasKey("xx") &
hasValue("xx")
Key: TINKERPOP-2313
URL: https://issues.apache.org/jira/browse/TINKERPOP-2313
Project: TinkerPop
Issue Type: Improvement
Components: process
Affects Versions: 3.4.3
Reporter: Jermy Li
Currently, it's OK to filter vertex properties by key/value, like
g.V().properties().hasKey("xx"),
but an exception will be thrown for query with edge properties filtering:
{code:java}
g.E().properties().hasKey("xx") => XxProperty cannot be cast to Element
{code}
like:
{code:java}
org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerProperty cannot be
cast to org.apache.tinkerpop.gremlin.structure.Element
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [tinkerpop] javeme opened pull request #1222: TINKERPOP-2313 Support g.E().properties().hasKey('xx') & hasValue('xx')
https://issues.apache.org/jira/browse/TINKERPOP-2313 Currently, an exception will be thrown for this query: `XxProperty cannot be cast to Element` [ Full content available at: https://github.com/apache/tinkerpop/pull/1222 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[jira] [Commented] (TINKERPOP-2313) Support query: g.E().properties().hasKey("xx") & hasValue("xx")
[
https://issues.apache.org/jira/browse/TINKERPOP-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973118#comment-16973118
]
ASF GitHub Bot commented on TINKERPOP-2313:
---
javeme commented on pull request #1222: TINKERPOP-2313 Support
g.E().properties().hasKey('xx') & hasValue('xx')
URL: https://github.com/apache/tinkerpop/pull/1222
https://issues.apache.org/jira/browse/TINKERPOP-2313
Currently, an exception will be thrown for this query: `XxProperty cannot be
cast to Element`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support query: g.E().properties().hasKey("xx") & hasValue("xx")
> ---
>
> Key: TINKERPOP-2313
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2313
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.4.3
>Reporter: Jermy Li
>Priority: Major
>
> Currently, it's OK to filter vertex properties by key/value, like
> g.V().properties().hasKey("xx"),
> but an exception will be thrown for query with edge properties filtering:
> {code:java}
> g.E().properties().hasKey("xx") => XxProperty cannot be cast to Element
> {code}
> like:
> {code:java}
> org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerProperty cannot be
> cast to org.apache.tinkerpop.gremlin.structure.Element
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [tinkerpop] dependabot[bot] opened pull request #1221: Bump jackson-databind from 2.6.7 to 2.9.10.1 in /spark-gremlin
Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.6.7 to 2.9.10.1. Commits - See full diff in [compare view](https://github.com/FasterXML/jackson/commits) [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/tinkerpop/network/alerts). [ Full content available at: https://github.com/apache/tinkerpop/pull/1221 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Re: [GitHub] [tinkerpop] dependabot[bot] opened pull request #1221: Bump jackson-databind from 2.6.7 to 2.9.10.1 in /spark-gremlin
i hate this bot. want to punch him in the face On Wed, Nov 13, 2019 at 6:45 AM wrote: > Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.6.7 > to 2.9.10.1. > > Commits > > - See full diff in [compare view]( > https://github.com/FasterXML/jackson/commits) > > > > [](https://help.github.com/articles/configuring-automated-security-fixes > ) > > Dependabot will resolve any conflicts with this PR as long as you don't > alter it yourself. You can also trigger a rebase manually by commenting > `@dependabot rebase`. > > [//]: # (dependabot-automerge-start) > [//]: # (dependabot-automerge-end) > > --- > > > Dependabot commands and options > > > You can trigger Dependabot actions by commenting on this PR: > - `@dependabot rebase` will rebase this PR > - `@dependabot recreate` will recreate this PR, overwriting any edits that > have been made to it > - `@dependabot merge` will merge this PR after your CI passes on it > - `@dependabot squash and merge` will squash and merge this PR after your > CI passes on it > - `@dependabot cancel merge` will cancel a previously requested merge and > block automerging > - `@dependabot reopen` will reopen this PR if it is closed > - `@dependabot ignore this [patch|minor|major] version` will close this PR > and stop Dependabot creating any more for this minor/major version (unless > you reopen the PR or upgrade to it yourself) > - `@dependabot ignore this dependency` will close this PR and stop > Dependabot creating any more for this dependency (unless you reopen the PR > or upgrade to it yourself) > - `@dependabot use these labels` will set the current labels as the > default for future PRs for this repo and language > - `@dependabot use these reviewers` will set the current reviewers as the > default for future PRs for this repo and language > - `@dependabot use these assignees` will set the current assignees as the > default for future PRs for this repo and language > - `@dependabot use this milestone` will set the current milestone as the > default for future PRs for this repo and language > > You can disable automated security fix PRs for this repo from the > [Security Alerts page](https://github.com/apache/tinkerpop/network/alerts > ). > > > > [ Full content available at: https://github.com/apache/tinkerpop/pull/1221 > ] > This message was relayed via gitbox.apache.org for > dev@tinkerpop.apache.org >
Re: [DISCUSS] dependabot
I may or may not have killed dependabot with this: https://github.com/apache/tinkerpop/tree/master/.dependabot Florian, if you or someone else wants to config dependabot in a "nice" way that's useful to us feel free to make the appropriate changes. As folks have interest in this tool I won't bug infra about disabling it for us. On Thu, Nov 7, 2019 at 8:38 AM Robert Dale wrote: > Interesting. However, dependabot appears to be the thing that is used to > create PRs. For instance, if automatic PRs are configured under the > Security tab, then it uses dependabot to make those changes. If automatic > PRs are not enabled, then you should only get the security alert. If we > can't get automatic PRs disabled at the Security level, then we'll have to > use this as a workaround. It would be good to know if we would get any > notification at all as I haven't see the alerts come through, only the PRs. > > 1. > > https://help.github.com/en/github/managing-security-vulnerabilities/about-security-alerts-for-vulnerable-dependencies#alerts-and-automated-security-fixes-for-vulnerable-dependencies > 2. > > https://help.github.com/en/github/managing-security-vulnerabilities/configuring-automated-security-fixes > > Robert Dale > > > On Thu, Nov 7, 2019 at 8:26 AM Florian Hockmann > wrote: > > > I think dependabot could be helpful if we could properly configure it to > > only update parts of our repo where we want that or only certain > > dependencies. It could be very helpful for the GLVs for example in my > > opinion as they shouldn't have dependencies where updates are complicated > > and we don't seem to update them regularly. > > > > Since it's possible to configure dependabot with a config file, we should > > be able to do that without intervention from Apache Infra for every > change: > > https://dependabot.com/docs/config-file/ > > > > But it would of course be good to know first why it was activated and > > whether it stays activated. > > > > -Ursprüngliche Nachricht- > > Von: Stephen Mallette > > Gesendet: Donnerstag, 7. November 2019 14:08 > > An: dev@tinkerpop.apache.org > > Betreff: Re: [DISCUSS] dependabot > > > > I'd be content with alerts on the security tab that we can evaluate and > > then act upon accordingly. > > > > On Thu, Nov 7, 2019 at 8:02 AM Robert Dale wrote: > > > > > Ideally, if they can just configured it to not create PRs and instead > > > create only the alert, that would be great. And of course give us > > > access to the Alert tab under the Security tab. > > > > > > Robert Dale > > > > > > > > > On Thu, Nov 7, 2019 at 7:53 AM Stephen Mallette > > > wrote: > > > > > > > I guess Apache Infra has decided to enable dependabot. Personally, I > > > don't > > > > like these sorts of things. They just create PRs i have to close as > > > > the > > > bot > > > > is unaware of the subtleties of our requirements. My intention is to > > > > ask Infra to disable the feature as we have our own bot that does > > > > this sort > > > of > > > > thing - RobertDaleBot. > > > > > > > > > > > > > > > > On Thu, Nov 7, 2019 at 7:45 AM wrote: > > > > > > > > > OK, I won't notify you again about this release, but will get in > > > > > touch when a new version is available. If you'd rather skip all > > > > > updates until > > > > the > > > > > next major or minor version, let me know by commenting > > > > > `@dependabot > > > > ignore > > > > > this major version` or `@dependabot ignore this minor version`. > > > > > > > > > > If you change your mind, just re-open this PR and I'll resolve any > > > > > conflicts on it. > > > > > > > > > > [ Full content available at: > > > > https://github.com/apache/tinkerpop/pull/1217 > > > > > ] > > > > > This message was relayed via gitbox.apache.org for > > > > > dev@tinkerpop.apache.org > > > > > > > > > > > > > > > > >
[jira] [Commented] (TINKERPOP-2289) Use address instead of hostname for connection
[ https://issues.apache.org/jira/browse/TINKERPOP-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973342#comment-16973342 ] ASF GitHub Bot commented on TINKERPOP-2289: --- spmallette commented on pull request #1213: Reverts TINKERPOP-2289 resolve ip address URL: https://github.com/apache/tinkerpop/pull/1213 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use address instead of hostname for connection > -- > > Key: TINKERPOP-2289 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2289 > Project: TinkerPop > Issue Type: Bug > Components: driver >Affects Versions: 3.4.3 >Reporter: Hua Jiang >Assignee: Stephen Mallette >Priority: Minor > Fix For: 3.3.9, 3.4.4, 3.5.0 > > > The current implementation uses hostname to create connections. It causes two > problems in a scenario where multiple addresses are bound to the same domain > name. > # Load balancing is broken because multiple `Host` may connect to the same > address, and some addresses may have no connection at all. > # It produces misleading log messages because the address in the host label > may not be the one the host is actually connected to. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [tinkerpop] spmallette commented on issue #1213: Reverts TINKERPOP-2289 resolve ip address
thanks for testing @olivertowers - i've published fresh snapshots for all release branches. [ Full content available at: https://github.com/apache/tinkerpop/pull/1213 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[jira] [Created] (TINKERPOP-2314) Employ by(String) for Map when possible and improve errors around incorrect types
Stephen Mallette created TINKERPOP-2314:
---
Summary: Employ by(String) for Map when possible and improve
errors around incorrect types
Key: TINKERPOP-2314
URL: https://issues.apache.org/jira/browse/TINKERPOP-2314
Project: TinkerPop
Issue Type: Improvement
Components: process
Affects Versions: 3.3.9
Reporter: Stephen Mallette
Assignee: Stephen Mallette
This bit of Gremlin demonstrates both problems for uses of {{by(String)}}:
{code}
gremlin> g.V().values('age').project('x').by('name')
java.lang.Integer cannot be cast to
org.apache.tinkerpop.gremlin.structure.Element
Type ':help' or ':h' for help.
Display stack trace? [yN]n
{code}
First, users typically expect this to work because they figure they are just
grabbing a keys value from a {{Map}} and then get the difficult to understand
message which doesn't tell you how to resolve. As a side note, the way to
resolve is with:
{code}
gremlin> g.V().valueMap().project('x').by(select('name'))
==>[x:[marko]]
==>[x:[stephen]]
==>[x:[matthias]]
==>[x:[daniel]]
==>[x:[gremlin]]
==>[x:[tinkergraph]]
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (TINKERPOP-2314) Employ by(String) for Map when possible and improve errors around incorrect types
[
https://issues.apache.org/jira/browse/TINKERPOP-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephen Mallette updated TINKERPOP-2314:
Description:
This bit of Gremlin demonstrates both problems for uses of {{by(String)}}:
{code}
gremlin> g.V().valueMap().project('x').by('name')
java.util.LinkedHashMap cannot be cast to
org.apache.tinkerpop.gremlin.structure.Element
Type ':help' or ':h' for help.
Display stack trace? [yN]n
{code}
First, users typically expect this to work because they figure they are just
grabbing a keys value from a {{Map}} and then get the difficult to understand
message which doesn't tell you how to resolve. As a side note, the way to
resolve is with:
{code}
gremlin> g.V().valueMap().project('x').by(select('name'))
==>[x:[marko]]
==>[x:[stephen]]
==>[x:[matthias]]
==>[x:[daniel]]
==>[x:[gremlin]]
==>[x:[tinkergraph]]
{code}
was:
This bit of Gremlin demonstrates both problems for uses of {{by(String)}}:
{code}
gremlin> g.V().values('age').project('x').by('name')
java.lang.Integer cannot be cast to
org.apache.tinkerpop.gremlin.structure.Element
Type ':help' or ':h' for help.
Display stack trace? [yN]n
{code}
First, users typically expect this to work because they figure they are just
grabbing a keys value from a {{Map}} and then get the difficult to understand
message which doesn't tell you how to resolve. As a side note, the way to
resolve is with:
{code}
gremlin> g.V().valueMap().project('x').by(select('name'))
==>[x:[marko]]
==>[x:[stephen]]
==>[x:[matthias]]
==>[x:[daniel]]
==>[x:[gremlin]]
==>[x:[tinkergraph]]
{code}
> Employ by(String) for Map when possible and improve errors around incorrect
> types
> -
>
> Key: TINKERPOP-2314
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2314
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.3.9
>Reporter: Stephen Mallette
>Assignee: Stephen Mallette
>Priority: Major
>
> This bit of Gremlin demonstrates both problems for uses of {{by(String)}}:
> {code}
> gremlin> g.V().valueMap().project('x').by('name')
> java.util.LinkedHashMap cannot be cast to
> org.apache.tinkerpop.gremlin.structure.Element
> Type ':help' or ':h' for help.
> Display stack trace? [yN]n
> {code}
> First, users typically expect this to work because they figure they are just
> grabbing a keys value from a {{Map}} and then get the difficult to understand
> message which doesn't tell you how to resolve. As a side note, the way to
> resolve is with:
> {code}
> gremlin> g.V().valueMap().project('x').by(select('name'))
> ==>[x:[marko]]
> ==>[x:[stephen]]
> ==>[x:[matthias]]
> ==>[x:[daniel]]
> ==>[x:[gremlin]]
> ==>[x:[tinkergraph]]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (TINKERPOP-2314) Employ by(String) for Map when possible and improve errors around incorrect types
[
https://issues.apache.org/jira/browse/TINKERPOP-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973659#comment-16973659
]
ASF GitHub Bot commented on TINKERPOP-2314:
---
spmallette commented on pull request #1223: TINKERPOP-2314 Employ by(String)
for Map when possible
URL: https://github.com/apache/tinkerpop/pull/1223
https://issues.apache.org/jira/browse/TINKERPOP-2314
Also improve errors around incorrect types that might be called using this
modulator overload. See upgrade docs for reasoning and examples of what's
happening here.
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Employ by(String) for Map when possible and improve errors around incorrect
> types
> -
>
> Key: TINKERPOP-2314
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2314
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.3.9
>Reporter: Stephen Mallette
>Assignee: Stephen Mallette
>Priority: Major
>
> This bit of Gremlin demonstrates both problems for uses of {{by(String)}}:
> {code}
> gremlin> g.V().valueMap().project('x').by('name')
> java.util.LinkedHashMap cannot be cast to
> org.apache.tinkerpop.gremlin.structure.Element
> Type ':help' or ':h' for help.
> Display stack trace? [yN]n
> {code}
> First, users typically expect this to work because they figure they are just
> grabbing a keys value from a {{Map}} and then get the difficult to understand
> message which doesn't tell you how to resolve. As a side note, the way to
> resolve is with:
> {code}
> gremlin> g.V().valueMap().project('x').by(select('name'))
> ==>[x:[marko]]
> ==>[x:[stephen]]
> ==>[x:[matthias]]
> ==>[x:[daniel]]
> ==>[x:[gremlin]]
> ==>[x:[tinkergraph]]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (TINKERPOP-2076) Build with Java 11
[
https://issues.apache.org/jira/browse/TINKERPOP-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973687#comment-16973687
]
Stephen Mallette commented on TINKERPOP-2076:
-
Summarizing and adding to the todo list here:
1. Check docker stability for .NET tests
2. get
{{GraphComputerTest.shouldStartAndEndWorkersForVertexProgramAndMapReduce}}
consistently passing
3. Review more warnings in the maven output
4. Figure out how Docker will work - right now we're sharing base images (i
think that's the right way to say that) so that when we switch from the
"jdk11" branch back to a "jdk8" branch we have to delete the images to
regenerate them with the right jdk. Need to know how to fix that one.
> Build with Java 11
> --
>
> Key: TINKERPOP-2076
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2076
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
>Affects Versions: 3.3.4
> Environment: $ java --version
> java 11 2018-09-25
> Java(TM) SE Runtime Environment 18.9 (build 11+28)
> Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11+28, mixed mode)
>Reporter: Steve Strassmann
>Assignee: Stephen Mallette
>Priority: Major
> Fix For: 3.5.0
>
>
> I cannot build TinkerPop with a current (v11) Java version.
> On the gremlin-users Google group, Robert Dale suggests using Java 8, but
> that is deprecated. Recommended: support current Java versions. Stephen
> Mallette says "we need to start worrying about such things."
> Oracle [says Java 8 is
> deprecated|https://www.oracle.com/technetwork/java/javase/overview/index.html]:
> {quote}{color:#d04437}[End of Public Updates for Oracle JDK
> 8|https://www.oracle.com/technetwork/java/javase/eol-135779.html]{color}
> Oracle will not post further updates of Java SE 8 to its public download
> sites for commercial use after January 2019.
> {quote}
>
> See issue posted in Gremlin-users Google Group:
>
> [https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!topic/gremlin-users/Kgnq4BkrZXQ]
> {{unable to build Tinkerpop from master with mvn clean install. }}
>
> The error appears to be
> An API incompatibility was encountered while executing
> org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce:
> java.lang.ExceptionInInitializerError: null
> {code:java}
> $ git clone https://github.com/apache/tinkerpop.git
> $ git checkout master
> $ mvn --version
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-17T14:33:14-04:00)
> Maven home: /opt/maven
> Java version: 11, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk-11.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"
> {code}
>
>
> {code:java}
> $ mvn clean install
> [INFO] Scanning for projects...
> [WARNING] The project org.apache.tinkerpop:tinkerpop:pom:3.4.0-SNAPSHOT uses
> prerequisites which is only intended for maven-plugin projects but not for
> non maven-plugin projects. For such purposes you should use the
> maven-enforcer-plugin. See
> https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html
> [INFO]
>
> [INFO] Reactor Build Order:
> [INFO]
> [INFO] Apache TinkerPop
> [pom]
> [INFO] Apache TinkerPop :: Gremlin Shaded
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Core
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Test
> [jar]
> [INFO] Apache TinkerPop :: TinkerGraph Gremlin
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Groovy
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Driver
> [jar]
> [INFO] Apache TinkerPop :: Neo4j Gremlin
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Server
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Javascript
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Python
> [jar]
> [INFO] Apache TinkerPop :: Gremlin.Net
> [pom]
> [INFO] Apache TinkerPop :: Gremlin.Net - Source
> [pom]
> [INFO] Apache TinkerPop :: Gremlin.Net - Tests
> [pom]
> [INFO] Apache TinkerPop :: Hadoop Gremlin
> [jar]
> [INFO] Apache TinkerPop :: Spark Gremlin
> [jar]
> [INFO] Apache TinkerPop :: SPARQL Gremlin
> [jar]
> [INFO] Apache Ti
[jira] [Commented] (TINKERPOP-2076) Build with Java 11
[
https://issues.apache.org/jira/browse/TINKERPOP-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973846#comment-16973846
]
Robert Dale commented on TINKERPOP-2076:
re: 4. Noticed that docker/Dockerfile is from xenial but travis is using
bionic. Shouldn't these things match?
> Build with Java 11
> --
>
> Key: TINKERPOP-2076
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2076
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
>Affects Versions: 3.3.4
> Environment: $ java --version
> java 11 2018-09-25
> Java(TM) SE Runtime Environment 18.9 (build 11+28)
> Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11+28, mixed mode)
>Reporter: Steve Strassmann
>Assignee: Stephen Mallette
>Priority: Major
> Fix For: 3.5.0
>
>
> I cannot build TinkerPop with a current (v11) Java version.
> On the gremlin-users Google group, Robert Dale suggests using Java 8, but
> that is deprecated. Recommended: support current Java versions. Stephen
> Mallette says "we need to start worrying about such things."
> Oracle [says Java 8 is
> deprecated|https://www.oracle.com/technetwork/java/javase/overview/index.html]:
> {quote}{color:#d04437}[End of Public Updates for Oracle JDK
> 8|https://www.oracle.com/technetwork/java/javase/eol-135779.html]{color}
> Oracle will not post further updates of Java SE 8 to its public download
> sites for commercial use after January 2019.
> {quote}
>
> See issue posted in Gremlin-users Google Group:
>
> [https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!topic/gremlin-users/Kgnq4BkrZXQ]
> {{unable to build Tinkerpop from master with mvn clean install. }}
>
> The error appears to be
> An API incompatibility was encountered while executing
> org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce:
> java.lang.ExceptionInInitializerError: null
> {code:java}
> $ git clone https://github.com/apache/tinkerpop.git
> $ git checkout master
> $ mvn --version
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-17T14:33:14-04:00)
> Maven home: /opt/maven
> Java version: 11, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk-11.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"
> {code}
>
>
> {code:java}
> $ mvn clean install
> [INFO] Scanning for projects...
> [WARNING] The project org.apache.tinkerpop:tinkerpop:pom:3.4.0-SNAPSHOT uses
> prerequisites which is only intended for maven-plugin projects but not for
> non maven-plugin projects. For such purposes you should use the
> maven-enforcer-plugin. See
> https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html
> [INFO]
>
> [INFO] Reactor Build Order:
> [INFO]
> [INFO] Apache TinkerPop
> [pom]
> [INFO] Apache TinkerPop :: Gremlin Shaded
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Core
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Test
> [jar]
> [INFO] Apache TinkerPop :: TinkerGraph Gremlin
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Groovy
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Driver
> [jar]
> [INFO] Apache TinkerPop :: Neo4j Gremlin
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Server
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Javascript
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Python
> [jar]
> [INFO] Apache TinkerPop :: Gremlin.Net
> [pom]
> [INFO] Apache TinkerPop :: Gremlin.Net - Source
> [pom]
> [INFO] Apache TinkerPop :: Gremlin.Net - Tests
> [pom]
> [INFO] Apache TinkerPop :: Hadoop Gremlin
> [jar]
> [INFO] Apache TinkerPop :: Spark Gremlin
> [jar]
> [INFO] Apache TinkerPop :: SPARQL Gremlin
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Console
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Archetype
> [pom]
> [INFO] Apache TinkerPop :: Archetype - TinkerGraph
> [jar]
> [INFO] Apache TinkerPop :: Archetype - Server
> [jar]
> [INFO] Apache TinkerPop :: Archetype - DSL
> [jar]
> [INFO] Apache Tink
[jira] [Commented] (TINKERPOP-2076) Build with Java 11
[
https://issues.apache.org/jira/browse/TINKERPOP-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973848#comment-16973848
]
Stephen Mallette commented on TINKERPOP-2076:
-
i figured we could safely use bionic for jdk11 because there is no reason to
support jdk8 (which bionic doesn't have natively). the only reason we use
xenial is for that purpose. i don't think there's a problem with having one
branch running jdk8 branches (tp33/tp34) on xenial and jdk11 branches (master)
on bionic, is there?
> Build with Java 11
> --
>
> Key: TINKERPOP-2076
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2076
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
>Affects Versions: 3.3.4
> Environment: $ java --version
> java 11 2018-09-25
> Java(TM) SE Runtime Environment 18.9 (build 11+28)
> Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11+28, mixed mode)
>Reporter: Steve Strassmann
>Assignee: Stephen Mallette
>Priority: Major
> Fix For: 3.5.0
>
>
> I cannot build TinkerPop with a current (v11) Java version.
> On the gremlin-users Google group, Robert Dale suggests using Java 8, but
> that is deprecated. Recommended: support current Java versions. Stephen
> Mallette says "we need to start worrying about such things."
> Oracle [says Java 8 is
> deprecated|https://www.oracle.com/technetwork/java/javase/overview/index.html]:
> {quote}{color:#d04437}[End of Public Updates for Oracle JDK
> 8|https://www.oracle.com/technetwork/java/javase/eol-135779.html]{color}
> Oracle will not post further updates of Java SE 8 to its public download
> sites for commercial use after January 2019.
> {quote}
>
> See issue posted in Gremlin-users Google Group:
>
> [https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!topic/gremlin-users/Kgnq4BkrZXQ]
> {{unable to build Tinkerpop from master with mvn clean install. }}
>
> The error appears to be
> An API incompatibility was encountered while executing
> org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce:
> java.lang.ExceptionInInitializerError: null
> {code:java}
> $ git clone https://github.com/apache/tinkerpop.git
> $ git checkout master
> $ mvn --version
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-17T14:33:14-04:00)
> Maven home: /opt/maven
> Java version: 11, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk-11.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"
> {code}
>
>
> {code:java}
> $ mvn clean install
> [INFO] Scanning for projects...
> [WARNING] The project org.apache.tinkerpop:tinkerpop:pom:3.4.0-SNAPSHOT uses
> prerequisites which is only intended for maven-plugin projects but not for
> non maven-plugin projects. For such purposes you should use the
> maven-enforcer-plugin. See
> https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html
> [INFO]
>
> [INFO] Reactor Build Order:
> [INFO]
> [INFO] Apache TinkerPop
> [pom]
> [INFO] Apache TinkerPop :: Gremlin Shaded
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Core
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Test
> [jar]
> [INFO] Apache TinkerPop :: TinkerGraph Gremlin
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Groovy
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Driver
> [jar]
> [INFO] Apache TinkerPop :: Neo4j Gremlin
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Server
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Javascript
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Python
> [jar]
> [INFO] Apache TinkerPop :: Gremlin.Net
> [pom]
> [INFO] Apache TinkerPop :: Gremlin.Net - Source
> [pom]
> [INFO] Apache TinkerPop :: Gremlin.Net - Tests
> [pom]
> [INFO] Apache TinkerPop :: Hadoop Gremlin
> [jar]
> [INFO] Apache TinkerPop :: Spark Gremlin
> [jar]
> [INFO] Apache TinkerPop :: SPARQL Gremlin
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Console
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Archetype
> [pom]
> [INFO] Apache TinkerPop :: Archetype - Tinke
[jira] [Commented] (TINKERPOP-2076) Build with Java 11
[
https://issues.apache.org/jira/browse/TINKERPOP-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973852#comment-16973852
]
Robert Dale commented on TINKERPOP-2076:
consistency for when things go awry ;)
> Build with Java 11
> --
>
> Key: TINKERPOP-2076
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2076
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
>Affects Versions: 3.3.4
> Environment: $ java --version
> java 11 2018-09-25
> Java(TM) SE Runtime Environment 18.9 (build 11+28)
> Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11+28, mixed mode)
>Reporter: Steve Strassmann
>Assignee: Stephen Mallette
>Priority: Major
> Fix For: 3.5.0
>
>
> I cannot build TinkerPop with a current (v11) Java version.
> On the gremlin-users Google group, Robert Dale suggests using Java 8, but
> that is deprecated. Recommended: support current Java versions. Stephen
> Mallette says "we need to start worrying about such things."
> Oracle [says Java 8 is
> deprecated|https://www.oracle.com/technetwork/java/javase/overview/index.html]:
> {quote}{color:#d04437}[End of Public Updates for Oracle JDK
> 8|https://www.oracle.com/technetwork/java/javase/eol-135779.html]{color}
> Oracle will not post further updates of Java SE 8 to its public download
> sites for commercial use after January 2019.
> {quote}
>
> See issue posted in Gremlin-users Google Group:
>
> [https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!topic/gremlin-users/Kgnq4BkrZXQ]
> {{unable to build Tinkerpop from master with mvn clean install. }}
>
> The error appears to be
> An API incompatibility was encountered while executing
> org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce:
> java.lang.ExceptionInInitializerError: null
> {code:java}
> $ git clone https://github.com/apache/tinkerpop.git
> $ git checkout master
> $ mvn --version
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-17T14:33:14-04:00)
> Maven home: /opt/maven
> Java version: 11, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk-11.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"
> {code}
>
>
> {code:java}
> $ mvn clean install
> [INFO] Scanning for projects...
> [WARNING] The project org.apache.tinkerpop:tinkerpop:pom:3.4.0-SNAPSHOT uses
> prerequisites which is only intended for maven-plugin projects but not for
> non maven-plugin projects. For such purposes you should use the
> maven-enforcer-plugin. See
> https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html
> [INFO]
>
> [INFO] Reactor Build Order:
> [INFO]
> [INFO] Apache TinkerPop
> [pom]
> [INFO] Apache TinkerPop :: Gremlin Shaded
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Core
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Test
> [jar]
> [INFO] Apache TinkerPop :: TinkerGraph Gremlin
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Groovy
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Driver
> [jar]
> [INFO] Apache TinkerPop :: Neo4j Gremlin
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Server
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Javascript
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Python
> [jar]
> [INFO] Apache TinkerPop :: Gremlin.Net
> [pom]
> [INFO] Apache TinkerPop :: Gremlin.Net - Source
> [pom]
> [INFO] Apache TinkerPop :: Gremlin.Net - Tests
> [pom]
> [INFO] Apache TinkerPop :: Hadoop Gremlin
> [jar]
> [INFO] Apache TinkerPop :: Spark Gremlin
> [jar]
> [INFO] Apache TinkerPop :: SPARQL Gremlin
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Console
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Archetype
> [pom]
> [INFO] Apache TinkerPop :: Archetype - TinkerGraph
> [jar]
> [INFO] Apache TinkerPop :: Archetype - Server
> [jar]
> [INFO] Apache TinkerPop :: Archetype - DSL
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Tools
> [pom]
> [INFO]
[jira] [Commented] (TINKERPOP-2076) Build with Java 11
[
https://issues.apache.org/jira/browse/TINKERPOP-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973898#comment-16973898
]
Robert Dale commented on TINKERPOP-2076:
re: 4. images can co-exist for multiple versions through tags. currently what
we see are three images:
{noformat}
tinkerpop:hadoop-2.7.7
tinkerpop:base
ubuntu:xenial
{noformat}
{{ubuntu:xenial}} is obviously the ubuntu base image
{{base}} is the big heavy-weight. it builds on ubuntu and adds updates,
language compilers, and many other things. This is the thing you really don't
want to have to rebuild. Looks like {{dotnet}} is the largest consumer of
space.
{{hadoop-2.7.7}} is much smaller, containing only the hadoop install. Trivial
to rebuild with a newer hadoop version.
So, all we need to do is come up with some new tags for images we need to
co-exist. We could add TinkerPop versioning or divide it by jdk version
(similar to hadoop version).
TinkerPop Versioning:
{noformat}
tinkerpop:base-3.3
tinkerpop:base-3.5
{noformat}
such that {{base-3.3}} is compat with 3.3, 3.4. {{base-3.5}} is compat with
3.5+ (and until some high version exists).
JDK Versioning:
{noformat}
tinkerpop:base-jdk11
tinkerpop:base-jdk8
{noformat}
Self-explanatory. Technically, we don't have to make a {{base-jdk8}}. we can
leave the existing {{base}} alone or just retag it if we really want to migrate
existing images to the new naming scheme.
The only thing that's less clear is how do we want to handle the hadoop image.
{{hadoop-2.7.7_jdk11}}? Do we even still need this? Does the version change
enough to warrant it? Or do we want to move more, potentially changing version
things into it and give it a more general name?
Anyway, lots of options on how to reorganize dependencies, version, and tag
them.
> Build with Java 11
> --
>
> Key: TINKERPOP-2076
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2076
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
>Affects Versions: 3.3.4
> Environment: $ java --version
> java 11 2018-09-25
> Java(TM) SE Runtime Environment 18.9 (build 11+28)
> Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11+28, mixed mode)
>Reporter: Steve Strassmann
>Assignee: Stephen Mallette
>Priority: Major
> Fix For: 3.5.0
>
>
> I cannot build TinkerPop with a current (v11) Java version.
> On the gremlin-users Google group, Robert Dale suggests using Java 8, but
> that is deprecated. Recommended: support current Java versions. Stephen
> Mallette says "we need to start worrying about such things."
> Oracle [says Java 8 is
> deprecated|https://www.oracle.com/technetwork/java/javase/overview/index.html]:
> {quote}{color:#d04437}[End of Public Updates for Oracle JDK
> 8|https://www.oracle.com/technetwork/java/javase/eol-135779.html]{color}
> Oracle will not post further updates of Java SE 8 to its public download
> sites for commercial use after January 2019.
> {quote}
>
> See issue posted in Gremlin-users Google Group:
>
> [https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!topic/gremlin-users/Kgnq4BkrZXQ]
> {{unable to build Tinkerpop from master with mvn clean install. }}
>
> The error appears to be
> An API incompatibility was encountered while executing
> org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce:
> java.lang.ExceptionInInitializerError: null
> {code:java}
> $ git clone https://github.com/apache/tinkerpop.git
> $ git checkout master
> $ mvn --version
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-17T14:33:14-04:00)
> Maven home: /opt/maven
> Java version: 11, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk-11.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"
> {code}
>
>
> {code:java}
> $ mvn clean install
> [INFO] Scanning for projects...
> [WARNING] The project org.apache.tinkerpop:tinkerpop:pom:3.4.0-SNAPSHOT uses
> prerequisites which is only intended for maven-plugin projects but not for
> non maven-plugin projects. For such purposes you should use the
> maven-enforcer-plugin. See
> https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html
> [INFO]
>
> [INFO] Reactor Build Order:
> [INFO]
> [INFO] Apache TinkerPop
> [pom]
> [INFO] Apache TinkerPop :: Gremlin Shaded
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Core
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Test
> [jar]
> [INFO] Apache TinkerPop :: Tinke
[GitHub] [tinkerpop] javeme commented on issue #1222: TINKERPOP-2313 Support g.E().properties().hasKey('xx') & hasValue('xx')
hi @spmallette Could you accept this change? And do you think it is necessary to unify the behavior of edges comparison? like StarEdge and TinkerEdge. [ Full content available at: https://github.com/apache/tinkerpop/pull/1222 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
