[jira] [Commented] (TINKERPOP-2877) The incorrect result caused by long integer overflows

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786135#comment-17786135
 ] 

ASF GitHub Bot commented on TINKERPOP-2877:
---

Cole-Greer commented on PR #2344:
URL: https://github.com/apache/tinkerpop/pull/2344#issuecomment-1811674823

   VOTE +1




> The incorrect result caused by long integer overflows
> -
>
> Key: TINKERPOP-2877
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2877
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.5.5
>Reporter: Miracy Cavendish
>Assignee: Valentyn Kahamlyk
>Priority: Blocker
>
> {code:java}
> Gremlin1: 
> g.V().both().both().both().both().both().both().values('prop9').sum()
> Result1: -5308416236269507008
> Gremlin2: 
> g.V().both().both().both().both().both().both().has('prop2').values('prop9').sum()
> Result2: 756493433251093
> Gremlin3: 
> g.V().both().both().both().both().both().both().hasNot('prop2').values('prop9').sum()
> Result3: -8222751935482731416{code}
> We execute the above gremlin queries: Result1 should equal the sum of Result2 
> and Result3, whereas -5308416236269507008 ≠756493433251093 + 
> -8222751935482731416.
> The possible reason is that long integer overflows happen in the process. 
> Could you return an exception to notify the user when the overflow occurs, or 
> use BigDecimal during the procedure?
> The graph is created by the following statements:
> {code:java}
> g.addV("Vlabel1").property("prop11", true).property("prop26", 
> -1.3054643785208727e+18).property("prop3", 
> 5955883311802481410).property("PersonalId", 1)
> g.addV("Vlabel2").property("prop23", 1013597808).property("prop14", 
> Double.POSITIVE_INFINITY).property("prop29", 
> -8.088511244487521e+18).property("prop1", 
> -791166414100353228).property("prop10", Double.NaN).property("prop20", 
> false).property("prop12", -1.611044197269977e+18).property("prop8", 
> Double.POSITIVE_INFINITY).property("prop28", 
> "r8OwmXN0z4xVA32DuW").property("prop7", true).property("prop18", 
> 122416389).property("prop4", -133008224708918302).property("prop16", 
> Double.POSITIVE_INFINITY).property("prop5", 
> 2.199870305073074e+18).property("prop30", 1951661449).property("PersonalId", 
> 2)
> g.addV("Vlabel3").property("prop13", -1833987394).property("prop11", 
> false).property("prop20", true).property("prop28", "Eb").property("prop26", 
> Double.POSITIVE_INFINITY).property("prop19", 
> "fkOMPiHGK4Qh9AEt").property("prop4", 7223784666736222475).property("prop21", 
> "emdyKI4gibcntwr9xr1R").property("prop8", 
> 1.6766837870245322e+18).property("prop6", 
> "KPvJU8zUZkDujXO5").property("prop5", 
> Double.POSITIVE_INFINITY).property("prop16", 
> Double.NEGATIVE_INFINITY).property("prop29", 
> -6.379213156782167e+16).property("prop9", 
> -2639063587618099127).property("prop2", 
> -4223871862589164789).property("prop7", true).property("prop22", 
> 3.3866441258784246e+18).property("prop12", 
> Double.NEGATIVE_INFINITY).property("prop15", 
> Double.POSITIVE_INFINITY).property("prop27", -811138702).property("prop18", 
> -823086061).property("prop30", 1766879986).property("prop10", 
> Double.NEGATIVE_INFINITY).property("prop25", true).property("prop17", 
> -7.221182960918364e+17).property("prop3", 
> 3709150069759562136).property("prop24", true).property("prop23", 
> 2089722858).property("prop1", 4952669033574350283).property("PersonalId", 3)
> g.addV("Vlabel4").property("prop18", 1921954359).property("prop9", 
> 3679390972557414017).property("prop28", "zea").property("prop5", 
> -5.37655340395617e+18).property("prop23", 873631855).property("prop29", 
> -4.730510618138025e+18).property("prop13", 262081621).property("prop27", 
> 954111430).property("prop25", true).property("prop7", 
> false).property("prop12", Double.POSITIVE_INFINITY).property("prop24", 
> false).property("PersonalId", 4)
> g.addV("Vlabel5").property("prop6", "BaCsHhoMCngKebN").property("prop26", 
> Double.NEGATIVE_INFINITY).property("prop30", -1093199590).property("prop27", 
> -761660443).property("prop7", false).property("prop16", 
> -3.702472520864335e+18).property("prop13", -1871493760).property("prop11", 
> true).property("prop1", 3729131191884336357).property("prop15", 
> -1.6551486100927974e+17).property("prop17", Double.NaN).property("prop8", 
> Double.POSITIVE_INFINITY).property("prop22", 
> 2.21716537881794e+18).property("prop14", 
> Double.POSITIVE_INFINITY).property("PersonalId", 
> 5)g.addV("Vlabel5").property("prop6", "cBao").property("prop26", 
> -5.21685685375749e+18).property("prop30", 1375392625).property("prop27", 
> 429620057).property("prop7", false).property("prop16", 
> 1535367691959044.0).property("prop13", 1046501670).property("prop11", 
> false).property("prop1", 

[jira] [Commented] (TINKERPOP-3016) TinkerTransactionGraph can incorrectly handle some read operations.

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-3016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786127#comment-17786127
 ] 

ASF GitHub Bot commented on TINKERPOP-3016:
---

kenhuuu commented on code in PR #2343:
URL: https://github.com/apache/tinkerpop/pull/2343#discussion_r1393504695


##
tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerElementContainer.java:
##
@@ -221,10 +235,11 @@ public boolean canBeRemoved() {
 /**
  * Cleanup changes made in the current transaction.
  */
-private void reset() {
+void reset() {

Review Comment:
   Should this be public?



##
tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerElementContainer.java:
##
@@ -221,10 +235,11 @@ public boolean canBeRemoved() {
 /**
  * Cleanup changes made in the current transaction.
  */
-private void reset() {
+void reset() {

Review Comment:
   Nit: Should this be public?





> TinkerTransactionGraph can incorrectly handle some read operations.
> ---
>
> Key: TINKERPOP-3016
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3016
> Project: TinkerPop
>  Issue Type: Bug
>  Components: tinkergraph
>Affects Versions: 3.7.0
>Reporter: Valentyn Kahamlyk
>Assignee: Valentyn Kahamlyk
>Priority: Critical
>
> With some combination of reading operations, `TinkerTransactionGraph` may 
> return not the current Element value, but the cached one.
> This may also cause update operations to fail with `Conflict: element 
> modified in another transaction` exception.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (TINKERPOP-3016) TinkerTransactionGraph can incorrectly handle some read operations.

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-3016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786126#comment-17786126
 ] 

ASF GitHub Bot commented on TINKERPOP-3016:
---

kenhuuu commented on code in PR #2343:
URL: https://github.com/apache/tinkerpop/pull/2343#discussion_r1393504432


##
tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerTransactionGraph.java:
##
@@ -72,8 +72,8 @@ public final class TinkerTransactionGraph extends 
AbstractTinkerGraph {
 
 private final TinkerTransaction transaction = new TinkerTransaction(this);
 
-protected Map> vertices = new 
ConcurrentHashMap<>();
-protected Map> edges = new 
ConcurrentHashMap<>();
+final Map> vertices = new 
ConcurrentHashMap<>();

Review Comment:
   Nit: explicitly state what the access modifer should be.





> TinkerTransactionGraph can incorrectly handle some read operations.
> ---
>
> Key: TINKERPOP-3016
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3016
> Project: TinkerPop
>  Issue Type: Bug
>  Components: tinkergraph
>Affects Versions: 3.7.0
>Reporter: Valentyn Kahamlyk
>Assignee: Valentyn Kahamlyk
>Priority: Critical
>
> With some combination of reading operations, `TinkerTransactionGraph` may 
> return not the current Element value, but the cached one.
> This may also cause update operations to fail with `Conflict: element 
> modified in another transaction` exception.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (TINKERPOP-3016) TinkerTransactionGraph can incorrectly handle some read operations.

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-3016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786125#comment-17786125
 ] 

ASF GitHub Bot commented on TINKERPOP-3016:
---

kenhuuu commented on PR #2343:
URL: https://github.com/apache/tinkerpop/pull/2343#issuecomment-1811638396

   Needs a CHANGELOG.




> TinkerTransactionGraph can incorrectly handle some read operations.
> ---
>
> Key: TINKERPOP-3016
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3016
> Project: TinkerPop
>  Issue Type: Bug
>  Components: tinkergraph
>Affects Versions: 3.7.0
>Reporter: Valentyn Kahamlyk
>Assignee: Valentyn Kahamlyk
>Priority: Critical
>
> With some combination of reading operations, `TinkerTransactionGraph` may 
> return not the current Element value, but the cached one.
> This may also cause update operations to fail with `Conflict: element 
> modified in another transaction` exception.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (TINKERPOP-3016) TinkerTransactionGraph can incorrectly handle some read operations.

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-3016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786121#comment-17786121
 ] 

ASF GitHub Bot commented on TINKERPOP-3016:
---

kenhuuu commented on PR #2343:
URL: https://github.com/apache/tinkerpop/pull/2343#issuecomment-1811620721

   VOTE +1




> TinkerTransactionGraph can incorrectly handle some read operations.
> ---
>
> Key: TINKERPOP-3016
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3016
> Project: TinkerPop
>  Issue Type: Bug
>  Components: tinkergraph
>Affects Versions: 3.7.0
>Reporter: Valentyn Kahamlyk
>Assignee: Valentyn Kahamlyk
>Priority: Critical
>
> With some combination of reading operations, `TinkerTransactionGraph` may 
> return not the current Element value, but the cached one.
> This may also cause update operations to fail with `Conflict: element 
> modified in another transaction` exception.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (TINKERPOP-3016) TinkerTransactionGraph can incorrectly handle some read operations.

2023-11-14 Thread Valentyn Kahamlyk (Jira)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-3016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Valentyn Kahamlyk reassigned TINKERPOP-3016:


Assignee: Valentyn Kahamlyk

> TinkerTransactionGraph can incorrectly handle some read operations.
> ---
>
> Key: TINKERPOP-3016
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3016
> Project: TinkerPop
>  Issue Type: Bug
>  Components: tinkergraph
>Affects Versions: 3.7.0
>Reporter: Valentyn Kahamlyk
>Assignee: Valentyn Kahamlyk
>Priority: Critical
>
> With some combination of reading operations, `TinkerTransactionGraph` may 
> return not the current Element value, but the cached one.
> This may also cause update operations to fail with `Conflict: element 
> modified in another transaction` exception.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (TINKERPOP-3016) TinkerTransactionGraph can incorrectly handle some read operations.

2023-11-14 Thread Valentyn Kahamlyk (Jira)
Valentyn Kahamlyk created TINKERPOP-3016:


 Summary: TinkerTransactionGraph can incorrectly handle some read 
operations.
 Key: TINKERPOP-3016
 URL: https://issues.apache.org/jira/browse/TINKERPOP-3016
 Project: TinkerPop
  Issue Type: Bug
  Components: tinkergraph
Affects Versions: 3.7.0
Reporter: Valentyn Kahamlyk


With some combination of reading operations, `TinkerTransactionGraph` may 
return not the current Element value, but the cached one.
This may also cause update operations to fail with `Conflict: element modified 
in another transaction` exception.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (TINKERPOP-2877) The incorrect result caused by long integer overflows

2023-11-14 Thread Valentyn Kahamlyk (Jira)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Valentyn Kahamlyk reassigned TINKERPOP-2877:


Assignee: Valentyn Kahamlyk

> The incorrect result caused by long integer overflows
> -
>
> Key: TINKERPOP-2877
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2877
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.5.5
>Reporter: Miracy Cavendish
>Assignee: Valentyn Kahamlyk
>Priority: Blocker
>
> {code:java}
> Gremlin1: 
> g.V().both().both().both().both().both().both().values('prop9').sum()
> Result1: -5308416236269507008
> Gremlin2: 
> g.V().both().both().both().both().both().both().has('prop2').values('prop9').sum()
> Result2: 756493433251093
> Gremlin3: 
> g.V().both().both().both().both().both().both().hasNot('prop2').values('prop9').sum()
> Result3: -8222751935482731416{code}
> We execute the above gremlin queries: Result1 should equal the sum of Result2 
> and Result3, whereas -5308416236269507008 ≠756493433251093 + 
> -8222751935482731416.
> The possible reason is that long integer overflows happen in the process. 
> Could you return an exception to notify the user when the overflow occurs, or 
> use BigDecimal during the procedure?
> The graph is created by the following statements:
> {code:java}
> g.addV("Vlabel1").property("prop11", true).property("prop26", 
> -1.3054643785208727e+18).property("prop3", 
> 5955883311802481410).property("PersonalId", 1)
> g.addV("Vlabel2").property("prop23", 1013597808).property("prop14", 
> Double.POSITIVE_INFINITY).property("prop29", 
> -8.088511244487521e+18).property("prop1", 
> -791166414100353228).property("prop10", Double.NaN).property("prop20", 
> false).property("prop12", -1.611044197269977e+18).property("prop8", 
> Double.POSITIVE_INFINITY).property("prop28", 
> "r8OwmXN0z4xVA32DuW").property("prop7", true).property("prop18", 
> 122416389).property("prop4", -133008224708918302).property("prop16", 
> Double.POSITIVE_INFINITY).property("prop5", 
> 2.199870305073074e+18).property("prop30", 1951661449).property("PersonalId", 
> 2)
> g.addV("Vlabel3").property("prop13", -1833987394).property("prop11", 
> false).property("prop20", true).property("prop28", "Eb").property("prop26", 
> Double.POSITIVE_INFINITY).property("prop19", 
> "fkOMPiHGK4Qh9AEt").property("prop4", 7223784666736222475).property("prop21", 
> "emdyKI4gibcntwr9xr1R").property("prop8", 
> 1.6766837870245322e+18).property("prop6", 
> "KPvJU8zUZkDujXO5").property("prop5", 
> Double.POSITIVE_INFINITY).property("prop16", 
> Double.NEGATIVE_INFINITY).property("prop29", 
> -6.379213156782167e+16).property("prop9", 
> -2639063587618099127).property("prop2", 
> -4223871862589164789).property("prop7", true).property("prop22", 
> 3.3866441258784246e+18).property("prop12", 
> Double.NEGATIVE_INFINITY).property("prop15", 
> Double.POSITIVE_INFINITY).property("prop27", -811138702).property("prop18", 
> -823086061).property("prop30", 1766879986).property("prop10", 
> Double.NEGATIVE_INFINITY).property("prop25", true).property("prop17", 
> -7.221182960918364e+17).property("prop3", 
> 3709150069759562136).property("prop24", true).property("prop23", 
> 2089722858).property("prop1", 4952669033574350283).property("PersonalId", 3)
> g.addV("Vlabel4").property("prop18", 1921954359).property("prop9", 
> 3679390972557414017).property("prop28", "zea").property("prop5", 
> -5.37655340395617e+18).property("prop23", 873631855).property("prop29", 
> -4.730510618138025e+18).property("prop13", 262081621).property("prop27", 
> 954111430).property("prop25", true).property("prop7", 
> false).property("prop12", Double.POSITIVE_INFINITY).property("prop24", 
> false).property("PersonalId", 4)
> g.addV("Vlabel5").property("prop6", "BaCsHhoMCngKebN").property("prop26", 
> Double.NEGATIVE_INFINITY).property("prop30", -1093199590).property("prop27", 
> -761660443).property("prop7", false).property("prop16", 
> -3.702472520864335e+18).property("prop13", -1871493760).property("prop11", 
> true).property("prop1", 3729131191884336357).property("prop15", 
> -1.6551486100927974e+17).property("prop17", Double.NaN).property("prop8", 
> Double.POSITIVE_INFINITY).property("prop22", 
> 2.21716537881794e+18).property("prop14", 
> Double.POSITIVE_INFINITY).property("PersonalId", 
> 5)g.addV("Vlabel5").property("prop6", "cBao").property("prop26", 
> -5.21685685375749e+18).property("prop30", 1375392625).property("prop27", 
> 429620057).property("prop7", false).property("prop16", 
> 1535367691959044.0).property("prop13", 1046501670).property("prop11", 
> false).property("prop1", -7972953637432281761).property("prop15", 
> Double.NaN).property("prop17", -4.373267040890351e+18).property("prop8", 
> 

[jira] [Commented] (TINKERPOP-2877) The incorrect result caused by long integer overflows

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786120#comment-17786120
 ] 

ASF GitHub Bot commented on TINKERPOP-2877:
---

vkagamlyk closed pull request #2315: [TINKERPOP-2877] Added integer overflow 
checks
URL: https://github.com/apache/tinkerpop/pull/2315




> The incorrect result caused by long integer overflows
> -
>
> Key: TINKERPOP-2877
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2877
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.5.5
>Reporter: Miracy Cavendish
>Priority: Blocker
>
> {code:java}
> Gremlin1: 
> g.V().both().both().both().both().both().both().values('prop9').sum()
> Result1: -5308416236269507008
> Gremlin2: 
> g.V().both().both().both().both().both().both().has('prop2').values('prop9').sum()
> Result2: 756493433251093
> Gremlin3: 
> g.V().both().both().both().both().both().both().hasNot('prop2').values('prop9').sum()
> Result3: -8222751935482731416{code}
> We execute the above gremlin queries: Result1 should equal the sum of Result2 
> and Result3, whereas -5308416236269507008 ≠756493433251093 + 
> -8222751935482731416.
> The possible reason is that long integer overflows happen in the process. 
> Could you return an exception to notify the user when the overflow occurs, or 
> use BigDecimal during the procedure?
> The graph is created by the following statements:
> {code:java}
> g.addV("Vlabel1").property("prop11", true).property("prop26", 
> -1.3054643785208727e+18).property("prop3", 
> 5955883311802481410).property("PersonalId", 1)
> g.addV("Vlabel2").property("prop23", 1013597808).property("prop14", 
> Double.POSITIVE_INFINITY).property("prop29", 
> -8.088511244487521e+18).property("prop1", 
> -791166414100353228).property("prop10", Double.NaN).property("prop20", 
> false).property("prop12", -1.611044197269977e+18).property("prop8", 
> Double.POSITIVE_INFINITY).property("prop28", 
> "r8OwmXN0z4xVA32DuW").property("prop7", true).property("prop18", 
> 122416389).property("prop4", -133008224708918302).property("prop16", 
> Double.POSITIVE_INFINITY).property("prop5", 
> 2.199870305073074e+18).property("prop30", 1951661449).property("PersonalId", 
> 2)
> g.addV("Vlabel3").property("prop13", -1833987394).property("prop11", 
> false).property("prop20", true).property("prop28", "Eb").property("prop26", 
> Double.POSITIVE_INFINITY).property("prop19", 
> "fkOMPiHGK4Qh9AEt").property("prop4", 7223784666736222475).property("prop21", 
> "emdyKI4gibcntwr9xr1R").property("prop8", 
> 1.6766837870245322e+18).property("prop6", 
> "KPvJU8zUZkDujXO5").property("prop5", 
> Double.POSITIVE_INFINITY).property("prop16", 
> Double.NEGATIVE_INFINITY).property("prop29", 
> -6.379213156782167e+16).property("prop9", 
> -2639063587618099127).property("prop2", 
> -4223871862589164789).property("prop7", true).property("prop22", 
> 3.3866441258784246e+18).property("prop12", 
> Double.NEGATIVE_INFINITY).property("prop15", 
> Double.POSITIVE_INFINITY).property("prop27", -811138702).property("prop18", 
> -823086061).property("prop30", 1766879986).property("prop10", 
> Double.NEGATIVE_INFINITY).property("prop25", true).property("prop17", 
> -7.221182960918364e+17).property("prop3", 
> 3709150069759562136).property("prop24", true).property("prop23", 
> 2089722858).property("prop1", 4952669033574350283).property("PersonalId", 3)
> g.addV("Vlabel4").property("prop18", 1921954359).property("prop9", 
> 3679390972557414017).property("prop28", "zea").property("prop5", 
> -5.37655340395617e+18).property("prop23", 873631855).property("prop29", 
> -4.730510618138025e+18).property("prop13", 262081621).property("prop27", 
> 954111430).property("prop25", true).property("prop7", 
> false).property("prop12", Double.POSITIVE_INFINITY).property("prop24", 
> false).property("PersonalId", 4)
> g.addV("Vlabel5").property("prop6", "BaCsHhoMCngKebN").property("prop26", 
> Double.NEGATIVE_INFINITY).property("prop30", -1093199590).property("prop27", 
> -761660443).property("prop7", false).property("prop16", 
> -3.702472520864335e+18).property("prop13", -1871493760).property("prop11", 
> true).property("prop1", 3729131191884336357).property("prop15", 
> -1.6551486100927974e+17).property("prop17", Double.NaN).property("prop8", 
> Double.POSITIVE_INFINITY).property("prop22", 
> 2.21716537881794e+18).property("prop14", 
> Double.POSITIVE_INFINITY).property("PersonalId", 
> 5)g.addV("Vlabel5").property("prop6", "cBao").property("prop26", 
> -5.21685685375749e+18).property("prop30", 1375392625).property("prop27", 
> 429620057).property("prop7", false).property("prop16", 
> 1535367691959044.0).property("prop13", 1046501670).property("prop11", 
> false).property("prop1", -7972953637432281761).property("prop15", 
> 

[jira] [Commented] (TINKERPOP-2877) The incorrect result caused by long integer overflows

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786119#comment-17786119
 ] 

ASF GitHub Bot commented on TINKERPOP-2877:
---

vkagamlyk commented on PR #2315:
URL: https://github.com/apache/tinkerpop/pull/2315#issuecomment-1811613204

   It's breaking change, so will go to new major release.
   New PR: https://github.com/apache/tinkerpop/pull/2344




> The incorrect result caused by long integer overflows
> -
>
> Key: TINKERPOP-2877
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2877
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.5.5
>Reporter: Miracy Cavendish
>Priority: Blocker
>
> {code:java}
> Gremlin1: 
> g.V().both().both().both().both().both().both().values('prop9').sum()
> Result1: -5308416236269507008
> Gremlin2: 
> g.V().both().both().both().both().both().both().has('prop2').values('prop9').sum()
> Result2: 756493433251093
> Gremlin3: 
> g.V().both().both().both().both().both().both().hasNot('prop2').values('prop9').sum()
> Result3: -8222751935482731416{code}
> We execute the above gremlin queries: Result1 should equal the sum of Result2 
> and Result3, whereas -5308416236269507008 ≠756493433251093 + 
> -8222751935482731416.
> The possible reason is that long integer overflows happen in the process. 
> Could you return an exception to notify the user when the overflow occurs, or 
> use BigDecimal during the procedure?
> The graph is created by the following statements:
> {code:java}
> g.addV("Vlabel1").property("prop11", true).property("prop26", 
> -1.3054643785208727e+18).property("prop3", 
> 5955883311802481410).property("PersonalId", 1)
> g.addV("Vlabel2").property("prop23", 1013597808).property("prop14", 
> Double.POSITIVE_INFINITY).property("prop29", 
> -8.088511244487521e+18).property("prop1", 
> -791166414100353228).property("prop10", Double.NaN).property("prop20", 
> false).property("prop12", -1.611044197269977e+18).property("prop8", 
> Double.POSITIVE_INFINITY).property("prop28", 
> "r8OwmXN0z4xVA32DuW").property("prop7", true).property("prop18", 
> 122416389).property("prop4", -133008224708918302).property("prop16", 
> Double.POSITIVE_INFINITY).property("prop5", 
> 2.199870305073074e+18).property("prop30", 1951661449).property("PersonalId", 
> 2)
> g.addV("Vlabel3").property("prop13", -1833987394).property("prop11", 
> false).property("prop20", true).property("prop28", "Eb").property("prop26", 
> Double.POSITIVE_INFINITY).property("prop19", 
> "fkOMPiHGK4Qh9AEt").property("prop4", 7223784666736222475).property("prop21", 
> "emdyKI4gibcntwr9xr1R").property("prop8", 
> 1.6766837870245322e+18).property("prop6", 
> "KPvJU8zUZkDujXO5").property("prop5", 
> Double.POSITIVE_INFINITY).property("prop16", 
> Double.NEGATIVE_INFINITY).property("prop29", 
> -6.379213156782167e+16).property("prop9", 
> -2639063587618099127).property("prop2", 
> -4223871862589164789).property("prop7", true).property("prop22", 
> 3.3866441258784246e+18).property("prop12", 
> Double.NEGATIVE_INFINITY).property("prop15", 
> Double.POSITIVE_INFINITY).property("prop27", -811138702).property("prop18", 
> -823086061).property("prop30", 1766879986).property("prop10", 
> Double.NEGATIVE_INFINITY).property("prop25", true).property("prop17", 
> -7.221182960918364e+17).property("prop3", 
> 3709150069759562136).property("prop24", true).property("prop23", 
> 2089722858).property("prop1", 4952669033574350283).property("PersonalId", 3)
> g.addV("Vlabel4").property("prop18", 1921954359).property("prop9", 
> 3679390972557414017).property("prop28", "zea").property("prop5", 
> -5.37655340395617e+18).property("prop23", 873631855).property("prop29", 
> -4.730510618138025e+18).property("prop13", 262081621).property("prop27", 
> 954111430).property("prop25", true).property("prop7", 
> false).property("prop12", Double.POSITIVE_INFINITY).property("prop24", 
> false).property("PersonalId", 4)
> g.addV("Vlabel5").property("prop6", "BaCsHhoMCngKebN").property("prop26", 
> Double.NEGATIVE_INFINITY).property("prop30", -1093199590).property("prop27", 
> -761660443).property("prop7", false).property("prop16", 
> -3.702472520864335e+18).property("prop13", -1871493760).property("prop11", 
> true).property("prop1", 3729131191884336357).property("prop15", 
> -1.6551486100927974e+17).property("prop17", Double.NaN).property("prop8", 
> Double.POSITIVE_INFINITY).property("prop22", 
> 2.21716537881794e+18).property("prop14", 
> Double.POSITIVE_INFINITY).property("PersonalId", 
> 5)g.addV("Vlabel5").property("prop6", "cBao").property("prop26", 
> -5.21685685375749e+18).property("prop30", 1375392625).property("prop27", 
> 429620057).property("prop7", false).property("prop16", 
> 1535367691959044.0).property("prop13", 

[jira] [Commented] (TINKERPOP-2877) The incorrect result caused by long integer overflows

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786118#comment-17786118
 ] 

ASF GitHub Bot commented on TINKERPOP-2877:
---

vkagamlyk opened a new pull request, #2344:
URL: https://github.com/apache/tinkerpop/pull/2344

   For some integer operations the result is not checked for overflow, which 
can lead to unexpected results.
   For example
   ```
   gremlin> __.inject(Long.MAX_VALUE,Long.MAX_VALUE,2).sum()
   ==>0
   ```
   
   In this PR I added throwing `ArithmeticException` for overflow cases. 
   
   More details in https://issues.apache.org/jira/browse/TINKERPOP-2877




> The incorrect result caused by long integer overflows
> -
>
> Key: TINKERPOP-2877
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2877
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.5.5
>Reporter: Miracy Cavendish
>Priority: Blocker
>
> {code:java}
> Gremlin1: 
> g.V().both().both().both().both().both().both().values('prop9').sum()
> Result1: -5308416236269507008
> Gremlin2: 
> g.V().both().both().both().both().both().both().has('prop2').values('prop9').sum()
> Result2: 756493433251093
> Gremlin3: 
> g.V().both().both().both().both().both().both().hasNot('prop2').values('prop9').sum()
> Result3: -8222751935482731416{code}
> We execute the above gremlin queries: Result1 should equal the sum of Result2 
> and Result3, whereas -5308416236269507008 ≠756493433251093 + 
> -8222751935482731416.
> The possible reason is that long integer overflows happen in the process. 
> Could you return an exception to notify the user when the overflow occurs, or 
> use BigDecimal during the procedure?
> The graph is created by the following statements:
> {code:java}
> g.addV("Vlabel1").property("prop11", true).property("prop26", 
> -1.3054643785208727e+18).property("prop3", 
> 5955883311802481410).property("PersonalId", 1)
> g.addV("Vlabel2").property("prop23", 1013597808).property("prop14", 
> Double.POSITIVE_INFINITY).property("prop29", 
> -8.088511244487521e+18).property("prop1", 
> -791166414100353228).property("prop10", Double.NaN).property("prop20", 
> false).property("prop12", -1.611044197269977e+18).property("prop8", 
> Double.POSITIVE_INFINITY).property("prop28", 
> "r8OwmXN0z4xVA32DuW").property("prop7", true).property("prop18", 
> 122416389).property("prop4", -133008224708918302).property("prop16", 
> Double.POSITIVE_INFINITY).property("prop5", 
> 2.199870305073074e+18).property("prop30", 1951661449).property("PersonalId", 
> 2)
> g.addV("Vlabel3").property("prop13", -1833987394).property("prop11", 
> false).property("prop20", true).property("prop28", "Eb").property("prop26", 
> Double.POSITIVE_INFINITY).property("prop19", 
> "fkOMPiHGK4Qh9AEt").property("prop4", 7223784666736222475).property("prop21", 
> "emdyKI4gibcntwr9xr1R").property("prop8", 
> 1.6766837870245322e+18).property("prop6", 
> "KPvJU8zUZkDujXO5").property("prop5", 
> Double.POSITIVE_INFINITY).property("prop16", 
> Double.NEGATIVE_INFINITY).property("prop29", 
> -6.379213156782167e+16).property("prop9", 
> -2639063587618099127).property("prop2", 
> -4223871862589164789).property("prop7", true).property("prop22", 
> 3.3866441258784246e+18).property("prop12", 
> Double.NEGATIVE_INFINITY).property("prop15", 
> Double.POSITIVE_INFINITY).property("prop27", -811138702).property("prop18", 
> -823086061).property("prop30", 1766879986).property("prop10", 
> Double.NEGATIVE_INFINITY).property("prop25", true).property("prop17", 
> -7.221182960918364e+17).property("prop3", 
> 3709150069759562136).property("prop24", true).property("prop23", 
> 2089722858).property("prop1", 4952669033574350283).property("PersonalId", 3)
> g.addV("Vlabel4").property("prop18", 1921954359).property("prop9", 
> 3679390972557414017).property("prop28", "zea").property("prop5", 
> -5.37655340395617e+18).property("prop23", 873631855).property("prop29", 
> -4.730510618138025e+18).property("prop13", 262081621).property("prop27", 
> 954111430).property("prop25", true).property("prop7", 
> false).property("prop12", Double.POSITIVE_INFINITY).property("prop24", 
> false).property("PersonalId", 4)
> g.addV("Vlabel5").property("prop6", "BaCsHhoMCngKebN").property("prop26", 
> Double.NEGATIVE_INFINITY).property("prop30", -1093199590).property("prop27", 
> -761660443).property("prop7", false).property("prop16", 
> -3.702472520864335e+18).property("prop13", -1871493760).property("prop11", 
> true).property("prop1", 3729131191884336357).property("prop15", 
> -1.6551486100927974e+17).property("prop17", Double.NaN).property("prop8", 
> Double.POSITIVE_INFINITY).property("prop22", 
> 2.21716537881794e+18).property("prop14", 
> Double.POSITIVE_INFINITY).property("PersonalId", 
> 

[jira] [Reopened] (TINKERPOP-2988) Serialization error throws an Invalid OpProcessor exception when using stream() API

2023-11-14 Thread Cole Greer (Jira)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Cole Greer reopened TINKERPOP-2988:
---
  Assignee: Ken Hu

> Serialization error throws an Invalid OpProcessor exception when using 
> stream() API
> ---
>
> Key: TINKERPOP-2988
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2988
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.7.0
>Reporter: Taylor Riggan
>Assignee: Ken Hu
>Priority: Critical
> Fix For: 3.6.6, 3.7.1, 4.0.0
>
>
> The following throws an 
> {code:java}
> Invalid OpProcessor requested [null] (499){code}
>  exception.  The cause is due to an invalid RequestId (an non-conformant UUID 
> is being used):
> {code:java}
> resp = client.stream ("g.V()", {}, { batchSize: 1, requestId: 'foo', 
> userAgent: 'bar', evaluationTimeout: 5000 });{code}
>  
> The error was diagnosed using Gremlin Server 3.7.0 and seeing the following 
> in the server logs:
>  
> {code:java}
> [WARN] o.a.t.g.s.h.WsGremlinBinaryRequestDecoder - Serialization error while 
> decoding request
> org.apache.tinkerpop.gremlin.driver.ser.SerializationException: 
> org.apache.tinkerpop.shaded.jackson.databind.JsonMappingException: Could not 
> deserialize the JSON value as required. Nested exception: 
> org.apache.tinkerpop.shaded.jackson.databind.exc.InvalidFormatException: 
> Cannot deserialize value of type `java.util.UUID` from String "foo": UUID has 
> to be represented by standard 36-char representation
>  at [Source: (byte[])"{"requestId":{{{}
> {"@type":"g:UUID","@value":"foo"}
> {}}},"op":"eval","processor":"","args":{"gremlin":"g.V()","aliases":{{{}
> {"g":"g"}
> {}}},"batchSize":1,"userAgent":"bar","evaluationTimeout":5000,"bindings":{},"language":"gremlin-groovy","accept":"application/vnd.gremlin-v3.0+json"";
>  line: 1, column: 41]{}}}
>  at [Source: (byte[])"{"requestId":{{{}
> {"@type":"g:UUID","@value":"foo"}
> {}}},"op":"eval","processor":"","args":{"gremlin":"g.V()","aliases":{{{}
> {"g":"g"}
> {}}},"batchSize":1,"userAgent":"bar","evaluationTimeout":5000,"bindings":{},"language":"gremlin-groovy","accept":"application/vnd.gremlin-v3.0+json"";
>  line: 1, column: 41] (through reference chain: 
> java.util.LinkedHashMap["requestId"]){}}}
>     at 
> org.apache.tinkerpop.gremlin.driver.ser.AbstractGraphSONMessageSerializerV2d0.deserializeRequest(AbstractGraphSONMessageSerializerV2d0.java:124)
>     at 
> org.apache.tinkerpop.gremlin.server.handler.WsGremlinBinaryRequestDecoder.decode(WsGremlinBinaryRequestDecoder.java:77)
> 
> {code}
>  
> A better client side error message is needed in order to provide the user 
> with guidance on how to fix the issue.  `Invalid OpProcessor` is too 
> ambiguous.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (TINKERPOP-2988) Serialization error throws an Invalid OpProcessor exception when using stream() API

2023-11-14 Thread Cole Greer (Jira)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Cole Greer closed TINKERPOP-2988.
-
Resolution: Fixed

> Serialization error throws an Invalid OpProcessor exception when using 
> stream() API
> ---
>
> Key: TINKERPOP-2988
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2988
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.7.0
>Reporter: Taylor Riggan
>Assignee: Ken Hu
>Priority: Critical
> Fix For: 3.6.6, 3.7.1, 4.0.0
>
>
> The following throws an 
> {code:java}
> Invalid OpProcessor requested [null] (499){code}
>  exception.  The cause is due to an invalid RequestId (an non-conformant UUID 
> is being used):
> {code:java}
> resp = client.stream ("g.V()", {}, { batchSize: 1, requestId: 'foo', 
> userAgent: 'bar', evaluationTimeout: 5000 });{code}
>  
> The error was diagnosed using Gremlin Server 3.7.0 and seeing the following 
> in the server logs:
>  
> {code:java}
> [WARN] o.a.t.g.s.h.WsGremlinBinaryRequestDecoder - Serialization error while 
> decoding request
> org.apache.tinkerpop.gremlin.driver.ser.SerializationException: 
> org.apache.tinkerpop.shaded.jackson.databind.JsonMappingException: Could not 
> deserialize the JSON value as required. Nested exception: 
> org.apache.tinkerpop.shaded.jackson.databind.exc.InvalidFormatException: 
> Cannot deserialize value of type `java.util.UUID` from String "foo": UUID has 
> to be represented by standard 36-char representation
>  at [Source: (byte[])"{"requestId":{{{}
> {"@type":"g:UUID","@value":"foo"}
> {}}},"op":"eval","processor":"","args":{"gremlin":"g.V()","aliases":{{{}
> {"g":"g"}
> {}}},"batchSize":1,"userAgent":"bar","evaluationTimeout":5000,"bindings":{},"language":"gremlin-groovy","accept":"application/vnd.gremlin-v3.0+json"";
>  line: 1, column: 41]{}}}
>  at [Source: (byte[])"{"requestId":{{{}
> {"@type":"g:UUID","@value":"foo"}
> {}}},"op":"eval","processor":"","args":{"gremlin":"g.V()","aliases":{{{}
> {"g":"g"}
> {}}},"batchSize":1,"userAgent":"bar","evaluationTimeout":5000,"bindings":{},"language":"gremlin-groovy","accept":"application/vnd.gremlin-v3.0+json"";
>  line: 1, column: 41] (through reference chain: 
> java.util.LinkedHashMap["requestId"]){}}}
>     at 
> org.apache.tinkerpop.gremlin.driver.ser.AbstractGraphSONMessageSerializerV2d0.deserializeRequest(AbstractGraphSONMessageSerializerV2d0.java:124)
>     at 
> org.apache.tinkerpop.gremlin.server.handler.WsGremlinBinaryRequestDecoder.decode(WsGremlinBinaryRequestDecoder.java:77)
> 
> {code}
>  
> A better client side error message is needed in order to provide the user 
> with guidance on how to fix the issue.  `Invalid OpProcessor` is too 
> ambiguous.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (TINKERPOP-3013) Console not sending scripts to the server when :remote console is enabled

2023-11-14 Thread Cole Greer (Jira)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Cole Greer closed TINKERPOP-3013.
-
Resolution: Fixed

> Console not sending scripts to the server when :remote console is enabled
> -
>
> Key: TINKERPOP-3013
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3013
> Project: TinkerPop
>  Issue Type: Bug
>  Components: console
>Affects Versions: 3.7.0
>Reporter: Stephen Mallette
>Assignee: Ken Hu
>Priority: Blocker
> Fix For: 3.7.1
>
>
> Not sure what's happening but commands seem to be only executing locally:
> {code}
> gremlin> :remote connect tinkerpop.server conf/remote.yaml
> ==>Configured localhost/127.0.0.1:8182
> gremlin> :remote console
> ==>All scripts will now be sent to Gremlin Server - 
> [localhost/127.0.0.1:8182] - type ':remote console' to return to local mode
> gremlin> g.V().count()
> No such property: g for class: groovysh_evaluate
> Type ':help' or ':h' for help.
> Display stack trace? [yN]n
> gremlin> :> g
> ==>graphtraversalsource[tinkergraph[vertices:1 edges:116974], standard]
> gremlin> :> g.V().count()
> ==>1
> {code}
> Only tested on 3.7.0 - could be bad on earlier versions. not sure



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (TINKERPOP-3013) Console not sending scripts to the server when :remote console is enabled

2023-11-14 Thread Cole Greer (Jira)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Cole Greer updated TINKERPOP-3013:
--
Fix Version/s: 3.7.1

> Console not sending scripts to the server when :remote console is enabled
> -
>
> Key: TINKERPOP-3013
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3013
> Project: TinkerPop
>  Issue Type: Bug
>  Components: console
>Affects Versions: 3.7.0
>Reporter: Stephen Mallette
>Assignee: Ken Hu
>Priority: Blocker
> Fix For: 3.7.1
>
>
> Not sure what's happening but commands seem to be only executing locally:
> {code}
> gremlin> :remote connect tinkerpop.server conf/remote.yaml
> ==>Configured localhost/127.0.0.1:8182
> gremlin> :remote console
> ==>All scripts will now be sent to Gremlin Server - 
> [localhost/127.0.0.1:8182] - type ':remote console' to return to local mode
> gremlin> g.V().count()
> No such property: g for class: groovysh_evaluate
> Type ':help' or ':h' for help.
> Display stack trace? [yN]n
> gremlin> :> g
> ==>graphtraversalsource[tinkergraph[vertices:1 edges:116974], standard]
> gremlin> :> g.V().count()
> ==>1
> {code}
> Only tested on 3.7.0 - could be bad on earlier versions. not sure



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (TINKERPOP-3013) Console not sending scripts to the server when :remote console is enabled

2023-11-14 Thread Cole Greer (Jira)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Cole Greer reassigned TINKERPOP-3013:
-

Assignee: Ken Hu

> Console not sending scripts to the server when :remote console is enabled
> -
>
> Key: TINKERPOP-3013
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3013
> Project: TinkerPop
>  Issue Type: Bug
>  Components: console
>Affects Versions: 3.7.0
>Reporter: Stephen Mallette
>Assignee: Ken Hu
>Priority: Blocker
>
> Not sure what's happening but commands seem to be only executing locally:
> {code}
> gremlin> :remote connect tinkerpop.server conf/remote.yaml
> ==>Configured localhost/127.0.0.1:8182
> gremlin> :remote console
> ==>All scripts will now be sent to Gremlin Server - 
> [localhost/127.0.0.1:8182] - type ':remote console' to return to local mode
> gremlin> g.V().count()
> No such property: g for class: groovysh_evaluate
> Type ':help' or ':h' for help.
> Display stack trace? [yN]n
> gremlin> :> g
> ==>graphtraversalsource[tinkergraph[vertices:1 edges:116974], standard]
> gremlin> :> g.V().count()
> ==>1
> {code}
> Only tested on 3.7.0 - could be bad on earlier versions. not sure



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (TINKERPOP-3013) Console not sending scripts to the server when :remote console is enabled

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786113#comment-17786113
 ] 

ASF GitHub Bot commented on TINKERPOP-3013:
---

Cole-Greer merged PR #2341:
URL: https://github.com/apache/tinkerpop/pull/2341




> Console not sending scripts to the server when :remote console is enabled
> -
>
> Key: TINKERPOP-3013
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3013
> Project: TinkerPop
>  Issue Type: Bug
>  Components: console
>Affects Versions: 3.7.0
>Reporter: Stephen Mallette
>Priority: Blocker
>
> Not sure what's happening but commands seem to be only executing locally:
> {code}
> gremlin> :remote connect tinkerpop.server conf/remote.yaml
> ==>Configured localhost/127.0.0.1:8182
> gremlin> :remote console
> ==>All scripts will now be sent to Gremlin Server - 
> [localhost/127.0.0.1:8182] - type ':remote console' to return to local mode
> gremlin> g.V().count()
> No such property: g for class: groovysh_evaluate
> Type ':help' or ':h' for help.
> Display stack trace? [yN]n
> gremlin> :> g
> ==>graphtraversalsource[tinkergraph[vertices:1 edges:116974], standard]
> gremlin> :> g.V().count()
> ==>1
> {code}
> Only tested on 3.7.0 - could be bad on earlier versions. not sure



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (TINKERPOP-3013) Console not sending scripts to the server when :remote console is enabled

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786112#comment-17786112
 ] 

ASF GitHub Bot commented on TINKERPOP-3013:
---

Cole-Greer commented on PR #2341:
URL: https://github.com/apache/tinkerpop/pull/2341#issuecomment-1811564007

   LGTM, VOTE +1




> Console not sending scripts to the server when :remote console is enabled
> -
>
> Key: TINKERPOP-3013
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3013
> Project: TinkerPop
>  Issue Type: Bug
>  Components: console
>Affects Versions: 3.7.0
>Reporter: Stephen Mallette
>Priority: Blocker
>
> Not sure what's happening but commands seem to be only executing locally:
> {code}
> gremlin> :remote connect tinkerpop.server conf/remote.yaml
> ==>Configured localhost/127.0.0.1:8182
> gremlin> :remote console
> ==>All scripts will now be sent to Gremlin Server - 
> [localhost/127.0.0.1:8182] - type ':remote console' to return to local mode
> gremlin> g.V().count()
> No such property: g for class: groovysh_evaluate
> Type ':help' or ':h' for help.
> Display stack trace? [yN]n
> gremlin> :> g
> ==>graphtraversalsource[tinkergraph[vertices:1 edges:116974], standard]
> gremlin> :> g.V().count()
> ==>1
> {code}
> Only tested on 3.7.0 - could be bad on earlier versions. not sure



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (TINKERPOP-3013) Console not sending scripts to the server when :remote console is enabled

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785983#comment-17785983
 ] 

ASF GitHub Bot commented on TINKERPOP-3013:
---

vkagamlyk commented on PR #2341:
URL: https://github.com/apache/tinkerpop/pull/2341#issuecomment-1810710363

   VOTE +1




> Console not sending scripts to the server when :remote console is enabled
> -
>
> Key: TINKERPOP-3013
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3013
> Project: TinkerPop
>  Issue Type: Bug
>  Components: console
>Affects Versions: 3.7.0
>Reporter: Stephen Mallette
>Priority: Blocker
>
> Not sure what's happening but commands seem to be only executing locally:
> {code}
> gremlin> :remote connect tinkerpop.server conf/remote.yaml
> ==>Configured localhost/127.0.0.1:8182
> gremlin> :remote console
> ==>All scripts will now be sent to Gremlin Server - 
> [localhost/127.0.0.1:8182] - type ':remote console' to return to local mode
> gremlin> g.V().count()
> No such property: g for class: groovysh_evaluate
> Type ':help' or ':h' for help.
> Display stack trace? [yN]n
> gremlin> :> g
> ==>graphtraversalsource[tinkergraph[vertices:1 edges:116974], standard]
> gremlin> :> g.V().count()
> ==>1
> {code}
> Only tested on 3.7.0 - could be bad on earlier versions. not sure



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (TINKERPOP-2988) Serialization error throws an Invalid OpProcessor exception when using stream() API

2023-11-14 Thread Ken Hu (Jira)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ken Hu closed TINKERPOP-2988.
-
Resolution: Fixed

> Serialization error throws an Invalid OpProcessor exception when using 
> stream() API
> ---
>
> Key: TINKERPOP-2988
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2988
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.7.0
>Reporter: Taylor Riggan
>Priority: Critical
> Fix For: 3.6.6, 3.7.1, 4.0.0
>
>
> The following throws an 
> {code:java}
> Invalid OpProcessor requested [null] (499){code}
>  exception.  The cause is due to an invalid RequestId (an non-conformant UUID 
> is being used):
> {code:java}
> resp = client.stream ("g.V()", {}, { batchSize: 1, requestId: 'foo', 
> userAgent: 'bar', evaluationTimeout: 5000 });{code}
>  
> The error was diagnosed using Gremlin Server 3.7.0 and seeing the following 
> in the server logs:
>  
> {code:java}
> [WARN] o.a.t.g.s.h.WsGremlinBinaryRequestDecoder - Serialization error while 
> decoding request
> org.apache.tinkerpop.gremlin.driver.ser.SerializationException: 
> org.apache.tinkerpop.shaded.jackson.databind.JsonMappingException: Could not 
> deserialize the JSON value as required. Nested exception: 
> org.apache.tinkerpop.shaded.jackson.databind.exc.InvalidFormatException: 
> Cannot deserialize value of type `java.util.UUID` from String "foo": UUID has 
> to be represented by standard 36-char representation
>  at [Source: (byte[])"{"requestId":{{{}
> {"@type":"g:UUID","@value":"foo"}
> {}}},"op":"eval","processor":"","args":{"gremlin":"g.V()","aliases":{{{}
> {"g":"g"}
> {}}},"batchSize":1,"userAgent":"bar","evaluationTimeout":5000,"bindings":{},"language":"gremlin-groovy","accept":"application/vnd.gremlin-v3.0+json"";
>  line: 1, column: 41]{}}}
>  at [Source: (byte[])"{"requestId":{{{}
> {"@type":"g:UUID","@value":"foo"}
> {}}},"op":"eval","processor":"","args":{"gremlin":"g.V()","aliases":{{{}
> {"g":"g"}
> {}}},"batchSize":1,"userAgent":"bar","evaluationTimeout":5000,"bindings":{},"language":"gremlin-groovy","accept":"application/vnd.gremlin-v3.0+json"";
>  line: 1, column: 41] (through reference chain: 
> java.util.LinkedHashMap["requestId"]){}}}
>     at 
> org.apache.tinkerpop.gremlin.driver.ser.AbstractGraphSONMessageSerializerV2d0.deserializeRequest(AbstractGraphSONMessageSerializerV2d0.java:124)
>     at 
> org.apache.tinkerpop.gremlin.server.handler.WsGremlinBinaryRequestDecoder.decode(WsGremlinBinaryRequestDecoder.java:77)
> 
> {code}
>  
> A better client side error message is needed in order to provide the user 
> with guidance on how to fix the issue.  `Invalid OpProcessor` is too 
> ambiguous.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (TINKERPOP-2988) Serialization error throws an Invalid OpProcessor exception when using stream() API

2023-11-14 Thread Ken Hu (Jira)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ken Hu updated TINKERPOP-2988:
--
Fix Version/s: 3.6.6
   3.7.1
   4.0.0

> Serialization error throws an Invalid OpProcessor exception when using 
> stream() API
> ---
>
> Key: TINKERPOP-2988
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2988
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.7.0
>Reporter: Taylor Riggan
>Priority: Critical
> Fix For: 3.6.6, 3.7.1, 4.0.0
>
>
> The following throws an 
> {code:java}
> Invalid OpProcessor requested [null] (499){code}
>  exception.  The cause is due to an invalid RequestId (an non-conformant UUID 
> is being used):
> {code:java}
> resp = client.stream ("g.V()", {}, { batchSize: 1, requestId: 'foo', 
> userAgent: 'bar', evaluationTimeout: 5000 });{code}
>  
> The error was diagnosed using Gremlin Server 3.7.0 and seeing the following 
> in the server logs:
>  
> {code:java}
> [WARN] o.a.t.g.s.h.WsGremlinBinaryRequestDecoder - Serialization error while 
> decoding request
> org.apache.tinkerpop.gremlin.driver.ser.SerializationException: 
> org.apache.tinkerpop.shaded.jackson.databind.JsonMappingException: Could not 
> deserialize the JSON value as required. Nested exception: 
> org.apache.tinkerpop.shaded.jackson.databind.exc.InvalidFormatException: 
> Cannot deserialize value of type `java.util.UUID` from String "foo": UUID has 
> to be represented by standard 36-char representation
>  at [Source: (byte[])"{"requestId":{{{}
> {"@type":"g:UUID","@value":"foo"}
> {}}},"op":"eval","processor":"","args":{"gremlin":"g.V()","aliases":{{{}
> {"g":"g"}
> {}}},"batchSize":1,"userAgent":"bar","evaluationTimeout":5000,"bindings":{},"language":"gremlin-groovy","accept":"application/vnd.gremlin-v3.0+json"";
>  line: 1, column: 41]{}}}
>  at [Source: (byte[])"{"requestId":{{{}
> {"@type":"g:UUID","@value":"foo"}
> {}}},"op":"eval","processor":"","args":{"gremlin":"g.V()","aliases":{{{}
> {"g":"g"}
> {}}},"batchSize":1,"userAgent":"bar","evaluationTimeout":5000,"bindings":{},"language":"gremlin-groovy","accept":"application/vnd.gremlin-v3.0+json"";
>  line: 1, column: 41] (through reference chain: 
> java.util.LinkedHashMap["requestId"]){}}}
>     at 
> org.apache.tinkerpop.gremlin.driver.ser.AbstractGraphSONMessageSerializerV2d0.deserializeRequest(AbstractGraphSONMessageSerializerV2d0.java:124)
>     at 
> org.apache.tinkerpop.gremlin.server.handler.WsGremlinBinaryRequestDecoder.decode(WsGremlinBinaryRequestDecoder.java:77)
> 
> {code}
>  
> A better client side error message is needed in order to provide the user 
> with guidance on how to fix the issue.  `Invalid OpProcessor` is too 
> ambiguous.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (TINKERPOP-2988) Serialization error throws an Invalid OpProcessor exception when using stream() API

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785949#comment-17785949
 ] 

ASF GitHub Bot commented on TINKERPOP-2988:
---

kenhuuu merged PR #2329:
URL: https://github.com/apache/tinkerpop/pull/2329




> Serialization error throws an Invalid OpProcessor exception when using 
> stream() API
> ---
>
> Key: TINKERPOP-2988
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2988
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.7.0
>Reporter: Taylor Riggan
>Priority: Critical
>
> The following throws an 
> {code:java}
> Invalid OpProcessor requested [null] (499){code}
>  exception.  The cause is due to an invalid RequestId (an non-conformant UUID 
> is being used):
> {code:java}
> resp = client.stream ("g.V()", {}, { batchSize: 1, requestId: 'foo', 
> userAgent: 'bar', evaluationTimeout: 5000 });{code}
>  
> The error was diagnosed using Gremlin Server 3.7.0 and seeing the following 
> in the server logs:
>  
> {code:java}
> [WARN] o.a.t.g.s.h.WsGremlinBinaryRequestDecoder - Serialization error while 
> decoding request
> org.apache.tinkerpop.gremlin.driver.ser.SerializationException: 
> org.apache.tinkerpop.shaded.jackson.databind.JsonMappingException: Could not 
> deserialize the JSON value as required. Nested exception: 
> org.apache.tinkerpop.shaded.jackson.databind.exc.InvalidFormatException: 
> Cannot deserialize value of type `java.util.UUID` from String "foo": UUID has 
> to be represented by standard 36-char representation
>  at [Source: (byte[])"{"requestId":{{{}
> {"@type":"g:UUID","@value":"foo"}
> {}}},"op":"eval","processor":"","args":{"gremlin":"g.V()","aliases":{{{}
> {"g":"g"}
> {}}},"batchSize":1,"userAgent":"bar","evaluationTimeout":5000,"bindings":{},"language":"gremlin-groovy","accept":"application/vnd.gremlin-v3.0+json"";
>  line: 1, column: 41]{}}}
>  at [Source: (byte[])"{"requestId":{{{}
> {"@type":"g:UUID","@value":"foo"}
> {}}},"op":"eval","processor":"","args":{"gremlin":"g.V()","aliases":{{{}
> {"g":"g"}
> {}}},"batchSize":1,"userAgent":"bar","evaluationTimeout":5000,"bindings":{},"language":"gremlin-groovy","accept":"application/vnd.gremlin-v3.0+json"";
>  line: 1, column: 41] (through reference chain: 
> java.util.LinkedHashMap["requestId"]){}}}
>     at 
> org.apache.tinkerpop.gremlin.driver.ser.AbstractGraphSONMessageSerializerV2d0.deserializeRequest(AbstractGraphSONMessageSerializerV2d0.java:124)
>     at 
> org.apache.tinkerpop.gremlin.server.handler.WsGremlinBinaryRequestDecoder.decode(WsGremlinBinaryRequestDecoder.java:77)
> 
> {code}
>  
> A better client side error message is needed in order to provide the user 
> with guidance on how to fix the issue.  `Invalid OpProcessor` is too 
> ambiguous.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)