[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/439 @PommeVerte do you think you might have some free time soon to review this and vote? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/439 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/439 @spmallette I pushed the windows changes. can you review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/439 @PommeVerte do you mind if we move the ubuntu script to a separate pull request so this one can move forward? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/439 I'm currently on some ressource intensive tasks so it's hard for me to bounce back and forth between projects but I would like to give this a run on ubuntu 14.04. I suspect that sysV might work out of the box with a simple change in commands. Will give this a spin asap. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/439 I just tested with backgrounding the job and killing that. That also still works. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/439 oh - right - you had said that. sorry --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/439 That should still work. What won't work is an invocation of just "gremlin-server.sh" without parameters. I didn't find any in the code base nor in the docs (which is highly convenient). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/439 It occurred to me that it would seem there must be a place that gremlin-server.sh is used in doc generation - and here it is: https://github.com/apache/tinkerpop/blob/8ab682fef3e3da12904cb0d825abf4cc1ba8235a/docs/preprocessor/preprocess.sh#L84 I assume that command will no longer work with these changes and a fix is needed there? @dkuppitz any other secret areas you know about where gremlin-server.sh is used? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/439 Cool. I was wondering how to link. Didn't think it was absolute. I hope it works. Tried testing with `./docker/build.sh -d` but it hangs at installing plugins `* hadoop-gremlin ...`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/439 wow - @robertdale - this is a really nice PR. I added the "breaking" label to the JIRA ticket as this would prevent gremlin-server.sh from working as it did before. I think I'm ok with that, but we should probably have a DISCUSS on the dev list about that just to bring it to everyone's attention to make sure there are no objections. Do you mind starting that thread for us - otherwise I will kick one off? As for the PR itself, I can test this manually, but will have to rely on others for code review. gremlin-server.sh is looking pretty legit! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/439 - `gremlin-server.sh` _is_ the init script. This makes it more inline with other Apache servers like Tomcat, ActiveMQ, solr, etc. - Moved how to install "As A Service" from Upgrade to Gremlin Server Configuration per @PommeVerte - Also added parameters and environment config to Server Configuration section - Deprecated `-i` in favor of `install` - Starting `gremlin-server.sh` without parameters is a breaking change. Amazingly, it's not ever actually used anywhere without parameters. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/439 Maybe if the script detects that it's called via link with no parameters, then it's in initd mode and displays help. If the script is called directly with no parameters, then it just runs in foreground. Then there's no breaking change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/439 Upstart looks simple enough. I don't know if the one @dkuppitz created, referenced in TINKERPOP-980 , is still viable. But I can't test. Any volunteers? I would have to say that it's not customary for systemd/upstart templates to be in `bin/`. They're really not binaries, more like configuration for those apps. Maybe create an `extras/` dir? The initd script is a real, executable script with `start, stop, status`. I didn't want to modify `gremlin-server.sh` since it has some functionality over a pure init script like install deps, run in foreground, pass conf file. However, it also has its short-comings like it can only be run in the install dir. The initd script can be run from anywhere and also can be directly referenced from initd. That said, it's not unusual for the main server script to also be the initd script. My preference would be to merge the two. But there *should* be a breaking change in that executing `gremlin-server.sh` would show help instead of running in the foreground. Would probably add a new option to run in foreground, `start -f`. Passing a conf file can still work, with or without start. `-i` can still work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/439 I like the suggestion @PommeVerte made to have some docs in the gremlin-server section somewhere. Then you could just reference them from the upgrade docs. I don't know what an upstart script entails so i'm not sure if a separate body of work for it is required or not. Finally, not sure where this should be in the repo. Is it customary to find these in a `bin/` directory? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/439 Just confirming that although ubuntu 14.04 has `systemd` it does not have `systemd-as-init` . So an upstart would be a good idea and should be relatively easy since this PR seems to be thorough. Question is, do we make a separate PR for this or not? Also maybe we should add some more documentation around this (instead of only having the upgrade docs)? Like in the gremlin-server section. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/439 Should we add upstart to this PR? I'm not sure if the systemd covers older versions of ubuntu. Namely 14.04LTS ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
