[jira] [Commented] (TINKERPOP-1633) use org.mindrot:jbcrypt v0.4
[ https://issues.apache.org/jira/browse/TINKERPOP-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868298#comment-15868298 ] ASF GitHub Bot commented on TINKERPOP-1633: --- Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/557 > use org.mindrot:jbcrypt v0.4 > > > Key: TINKERPOP-1633 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1633 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.1.6 >Reporter: Zach A. Thomas > > I have followed Sonatype's guidelines for deploying third party artifacts, > and jbcrypt v0.4 is now in Maven Central. > Unlike alternative jbcrypts available, this is Damien Miller's code > _unmodified_. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1633) use org.mindrot:jbcrypt v0.4
[ https://issues.apache.org/jira/browse/TINKERPOP-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868045#comment-15868045 ] ASF GitHub Bot commented on TINKERPOP-1633: --- Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/557#discussion_r101305767 --- Diff: docs/src/reference/gremlin-applications.asciidoc --- @@ -50,7 +50,6 @@ the defaults. TinkerPop recommends the following configuration in that file: http://repository.codehaus.org/"; m2compatible="true"/> --- End diff -- true - i can do that as part of the merge though > use org.mindrot:jbcrypt v0.4 > > > Key: TINKERPOP-1633 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1633 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.1.6 >Reporter: Zach A. Thomas > > I have followed Sonatype's guidelines for deploying third party artifacts, > and jbcrypt v0.4 is now in Maven Central. > Unlike alternative jbcrypts available, this is Damien Miller's code > _unmodified_. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1633) use org.mindrot:jbcrypt v0.4
[ https://issues.apache.org/jira/browse/TINKERPOP-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868043#comment-15868043 ] ASF GitHub Bot commented on TINKERPOP-1633: --- Github user pluradj commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/557#discussion_r101305064 --- Diff: docs/src/reference/gremlin-applications.asciidoc --- @@ -50,7 +50,6 @@ the defaults. TinkerPop recommends the following configuration in that file: http://repository.codehaus.org/"; m2compatible="true"/> --- End diff -- We can remove `codehaus` also. It went out of service a couple years ago. > use org.mindrot:jbcrypt v0.4 > > > Key: TINKERPOP-1633 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1633 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.1.6 >Reporter: Zach A. Thomas > > I have followed Sonatype's guidelines for deploying third party artifacts, > and jbcrypt v0.4 is now in Maven Central. > Unlike alternative jbcrypts available, this is Damien Miller's code > _unmodified_. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1633) use org.mindrot:jbcrypt v0.4
[ https://issues.apache.org/jira/browse/TINKERPOP-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867802#comment-15867802 ] ASF GitHub Bot commented on TINKERPOP-1633: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/557 transferring my vote from #556 VOTE +1 > use org.mindrot:jbcrypt v0.4 > > > Key: TINKERPOP-1633 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1633 > Project: TinkerPop > Issue Type: Bug > Components: build-release >Reporter: Zach A. Thomas > > I have followed Sonatype's guidelines for deploying third party artifacts, > and jbcrypt v0.4 is now in Maven Central. > Unlike alternative jbcrypts available, this is Damien Miller's code > _unmodified_. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1633) use org.mindrot:jbcrypt v0.4
[ https://issues.apache.org/jira/browse/TINKERPOP-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867675#comment-15867675 ] ASF GitHub Bot commented on TINKERPOP-1633: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/557 All tests pass with `docker/build.sh -t -n -i` VOTE +1 > use org.mindrot:jbcrypt v0.4 > > > Key: TINKERPOP-1633 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1633 > Project: TinkerPop > Issue Type: Bug > Components: build-release >Reporter: Zach A. Thomas > > I have followed Sonatype's guidelines for deploying third party artifacts, > and jbcrypt v0.4 is now in Maven Central. > Unlike alternative jbcrypts available, this is Damien Miller's code > _unmodified_. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1633) use org.mindrot:jbcrypt v0.4
[ https://issues.apache.org/jira/browse/TINKERPOP-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866552#comment-15866552 ] ASF GitHub Bot commented on TINKERPOP-1633: --- Github user dysmento commented on the issue: https://github.com/apache/tinkerpop/pull/557 all set. > use org.mindrot:jbcrypt v0.4 > > > Key: TINKERPOP-1633 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1633 > Project: TinkerPop > Issue Type: Bug > Components: build-release >Reporter: Zach A. Thomas > > I have followed Sonatype's guidelines for deploying third party artifacts, > and jbcrypt v0.4 is now in Maven Central. > Unlike alternative jbcrypts available, this is Damien Miller's code > _unmodified_. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1633) use org.mindrot:jbcrypt v0.4
[ https://issues.apache.org/jira/browse/TINKERPOP-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866509#comment-15866509 ] ASF GitHub Bot commented on TINKERPOP-1633: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/557 I've had some time to review this. I have a few additional tweaks if you don't mind. In the pom.xml you edited you can removed this ``: ```xml jitpack.io https://jitpack.io ``` You can also remove this entry in the docs: https://github.com/apache/tinkerpop/blame/2decc8132ff8726e35e722b8b35475dfa4b2b47c/docs/src/reference/gremlin-applications.asciidoc#L53 There is an entry in `grapeConfig.xml` in the docker directories and a second entry on the gremlin-applications.asciidoc, but both look like those changes were added on the tp32 branch and not here on tp31 - I will take care of that stuff after merging your PR. > use org.mindrot:jbcrypt v0.4 > > > Key: TINKERPOP-1633 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1633 > Project: TinkerPop > Issue Type: Bug > Components: build-release >Reporter: Zach A. Thomas > > I have followed Sonatype's guidelines for deploying third party artifacts, > and jbcrypt v0.4 is now in Maven Central. > Unlike alternative jbcrypts available, this is Damien Miller's code > _unmodified_. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1633) use org.mindrot:jbcrypt v0.4
[ https://issues.apache.org/jira/browse/TINKERPOP-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865767#comment-15865767 ] ASF GitHub Bot commented on TINKERPOP-1633: --- Github user dysmento closed the pull request at: https://github.com/apache/tinkerpop/pull/556 > use org.mindrot:jbcrypt v0.4 > > > Key: TINKERPOP-1633 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1633 > Project: TinkerPop > Issue Type: Bug > Components: build-release >Reporter: Zach A. Thomas > > I have followed Sonatype's guidelines for deploying third party artifacts, > and jbcrypt v0.4 is now in Maven Central. > Unlike alternative jbcrypts available, this is Damien Miller's code > _unmodified_. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1633) use org.mindrot:jbcrypt v0.4
[ https://issues.apache.org/jira/browse/TINKERPOP-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865653#comment-15865653 ] ASF GitHub Bot commented on TINKERPOP-1633: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/556 OK - feel free to close this one then. > use org.mindrot:jbcrypt v0.4 > > > Key: TINKERPOP-1633 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1633 > Project: TinkerPop > Issue Type: Bug > Components: build-release >Reporter: Zach A. Thomas > > I have followed Sonatype's guidelines for deploying third party artifacts, > and jbcrypt v0.4 is now in Maven Central. > Unlike alternative jbcrypts available, this is Damien Miller's code > _unmodified_. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1633) use org.mindrot:jbcrypt v0.4
[ https://issues.apache.org/jira/browse/TINKERPOP-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864411#comment-15864411 ] ASF GitHub Bot commented on TINKERPOP-1633: --- Github user dysmento commented on the issue: https://github.com/apache/tinkerpop/pull/556 I couldn't see how to change the source branch of this PR, so I created another one from tp31. > use org.mindrot:jbcrypt v0.4 > > > Key: TINKERPOP-1633 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1633 > Project: TinkerPop > Issue Type: Bug > Components: build-release >Reporter: Zach A. Thomas > > I have followed Sonatype's guidelines for deploying third party artifacts, > and jbcrypt v0.4 is now in Maven Central. > Unlike alternative jbcrypts available, this is Damien Miller's code > _unmodified_. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1633) use org.mindrot:jbcrypt v0.4
[ https://issues.apache.org/jira/browse/TINKERPOP-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864409#comment-15864409 ] ASF GitHub Bot commented on TINKERPOP-1633: --- GitHub user dysmento opened a pull request: https://github.com/apache/tinkerpop/pull/557 TINKERPOP-1633 use official jbcrypt 0.4 in maven central targeting tp31 branch for this version bump of jbcrypt to 0.4 You can merge this pull request into a Git repository by running: $ git pull https://github.com/dysmento/tinkerpop tp31 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/557.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #557 commit 0fb51e941cafc733419204a7f80b55c30d5387d4 Author: Zach A. Thomas Date: 2017-02-13T21:01:16Z TINKERPOP-1633 use official jbcrypt 0.4 in maven central > use org.mindrot:jbcrypt v0.4 > > > Key: TINKERPOP-1633 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1633 > Project: TinkerPop > Issue Type: Bug > Components: build-release >Reporter: Zach A. Thomas > > I have followed Sonatype's guidelines for deploying third party artifacts, > and jbcrypt v0.4 is now in Maven Central. > Unlike alternative jbcrypts available, this is Damien Miller's code > _unmodified_. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1633) use org.mindrot:jbcrypt v0.4
[ https://issues.apache.org/jira/browse/TINKERPOP-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864292#comment-15864292 ] ASF GitHub Bot commented on TINKERPOP-1633: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/556 Verified that this matches the original code. Compared source files and decompiled class files. VOTE +1 > use org.mindrot:jbcrypt v0.4 > > > Key: TINKERPOP-1633 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1633 > Project: TinkerPop > Issue Type: Bug > Components: build-release >Reporter: Zach A. Thomas > > I have followed Sonatype's guidelines for deploying third party artifacts, > and jbcrypt v0.4 is now in Maven Central. > Unlike alternative jbcrypts available, this is Damien Miller's code > _unmodified_. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1633) use org.mindrot:jbcrypt v0.4
[ https://issues.apache.org/jira/browse/TINKERPOP-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864257#comment-15864257 ] ASF GitHub Bot commented on TINKERPOP-1633: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/556 Coul you please re-targetted this PR to the tp31 branch so that this can be applied to 3.1.x on? > use org.mindrot:jbcrypt v0.4 > > > Key: TINKERPOP-1633 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1633 > Project: TinkerPop > Issue Type: Bug > Components: build-release >Reporter: Zach A. Thomas > > I have followed Sonatype's guidelines for deploying third party artifacts, > and jbcrypt v0.4 is now in Maven Central. > Unlike alternative jbcrypts available, this is Damien Miller's code > _unmodified_. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1633) use org.mindrot:jbcrypt v0.4
[ https://issues.apache.org/jira/browse/TINKERPOP-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864251#comment-15864251 ] stephen mallette commented on TINKERPOP-1633: - oh wow - that's very cool news. thank you! > use org.mindrot:jbcrypt v0.4 > > > Key: TINKERPOP-1633 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1633 > Project: TinkerPop > Issue Type: Bug > Components: build-release >Reporter: Zach A. Thomas > > I have followed Sonatype's guidelines for deploying third party artifacts, > and jbcrypt v0.4 is now in Maven Central. > Unlike alternative jbcrypts available, this is Damien Miller's code > _unmodified_. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1633) use org.mindrot:jbcrypt v0.4
[ https://issues.apache.org/jira/browse/TINKERPOP-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864246#comment-15864246 ] Zach A. Thomas commented on TINKERPOP-1633: --- Pull Request in github: https://github.com/apache/tinkerpop/pull/556 > use org.mindrot:jbcrypt v0.4 > > > Key: TINKERPOP-1633 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1633 > Project: TinkerPop > Issue Type: Bug > Components: build-release >Reporter: Zach A. Thomas > > I have followed Sonatype's guidelines for deploying third party artifacts, > and jbcrypt v0.4 is now in Maven Central. > Unlike alternative jbcrypts available, this is Damien Miller's code > _unmodified_. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1633) use org.mindrot:jbcrypt v0.4
[ https://issues.apache.org/jira/browse/TINKERPOP-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864245#comment-15864245 ] ASF GitHub Bot commented on TINKERPOP-1633: --- GitHub user dysmento opened a pull request: https://github.com/apache/tinkerpop/pull/556 TINKERPOP-1633 use official jbcrypt 0.4 in maven central This removes the hurdle of requiring extra steps to get the artifacts of jbcrypt 0.4, which can now be found in maven central: https://repo1.maven.org/maven2/org/mindrot/jbcrypt/0.4/ You can merge this pull request into a Git repository by running: $ git pull https://github.com/dysmento/tinkerpop master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/556.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #556 commit 53f05d93cea9d1c277e5ad6ca2b79ad53f319a8a Author: Zach A. Thomas Date: 2017-02-13T19:08:50Z TINKERPOP-1633 use official jbcrypt 0.4 in maven central > use org.mindrot:jbcrypt v0.4 > > > Key: TINKERPOP-1633 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1633 > Project: TinkerPop > Issue Type: Bug > Components: build-release >Reporter: Zach A. Thomas > > I have followed Sonatype's guidelines for deploying third party artifacts, > and jbcrypt v0.4 is now in Maven Central. > Unlike alternative jbcrypts available, this is Damien Miller's code > _unmodified_. -- This message was sent by Atlassian JIRA (v6.3.15#6346)