[jira] [Commented] (TINKERPOP-1661) Docker-built documentation does not always point locally

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189840#comment-16189840
 ] 

ASF GitHub Bot commented on TINKERPOP-1661:
---

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/725


> Docker-built documentation does not always point locally
> 
>
> Key: TINKERPOP-1661
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1661
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.4
>Reporter: Robert Dale
>Assignee: Daniel Kuppitz
>Priority: Minor
> Fix For: 3.2.7, 3.3.1
>
>
> After performing {{docker/build.sh -d}}
> When I pull up the initial URL to look at the docs, it's local -
> http://172.17.0.2/ .
> Anchor links to the same page are also local - http://172.17.0.2/#tutorials .
> However, all links to other pages are remote! Also, you can't just replace 
> the server name with the local IP, the URL is slightly different. e.g.
> http://tinkerpop.apache.org/docs/3.3.0-SNAPSHOT/reference
> must be changed to http://172.17.0.2/reference/ in order to view it locally.
> If the reviewer isn't paying attention to the url, s/he might be reviewing 
> the wrong content. It would be better if it were all local and/or relative 
> paths.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1661) Docker-built documentation does not always point locally

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189831#comment-16189831
 ] 

ASF GitHub Bot commented on TINKERPOP-1661:
---

Github user twilmes commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
I cleared out my images and rebuilt and all was good.

VOTE: +1


> Docker-built documentation does not always point locally
> 
>
> Key: TINKERPOP-1661
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1661
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.4
>Reporter: Robert Dale
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> After performing {{docker/build.sh -d}}
> When I pull up the initial URL to look at the docs, it's local -
> http://172.17.0.2/ .
> Anchor links to the same page are also local - http://172.17.0.2/#tutorials .
> However, all links to other pages are remote! Also, you can't just replace 
> the server name with the local IP, the URL is slightly different. e.g.
> http://tinkerpop.apache.org/docs/3.3.0-SNAPSHOT/reference
> must be changed to http://172.17.0.2/reference/ in order to view it locally.
> If the reviewer isn't paying attention to the url, s/he might be reviewing 
> the wrong content. It would be better if it were all local and/or relative 
> paths.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1661) Docker-built documentation does not always point locally

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188542#comment-16188542
 ] 

ASF GitHub Bot commented on TINKERPOP-1661:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
That's fine. Now I know what to look for ;-)


> Docker-built documentation does not always point locally
> 
>
> Key: TINKERPOP-1661
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1661
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.4
>Reporter: Robert Dale
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> After performing {{docker/build.sh -d}}
> When I pull up the initial URL to look at the docs, it's local -
> http://172.17.0.2/ .
> Anchor links to the same page are also local - http://172.17.0.2/#tutorials .
> However, all links to other pages are remote! Also, you can't just replace 
> the server name with the local IP, the URL is slightly different. e.g.
> http://tinkerpop.apache.org/docs/3.3.0-SNAPSHOT/reference
> must be changed to http://172.17.0.2/reference/ in order to view it locally.
> If the reviewer isn't paying attention to the url, s/he might be reviewing 
> the wrong content. It would be better if it were all local and/or relative 
> paths.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1661) Docker-built documentation does not always point locally

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188507#comment-16188507
 ] 

ASF GitHub Bot commented on TINKERPOP-1661:
---

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
I know, Stephen and I talked briefly about it and we came to the conclusion 
that the Docker stuff is really just a developer / contributor thing and we 
shouldn't care too much about "breaking" changes within minor releases. Perhaps 
we should just send a short mail to dev@ if we make changes in the Docker image 
setups.


> Docker-built documentation does not always point locally
> 
>
> Key: TINKERPOP-1661
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1661
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.4
>Reporter: Robert Dale
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> After performing {{docker/build.sh -d}}
> When I pull up the initial URL to look at the docs, it's local -
> http://172.17.0.2/ .
> Anchor links to the same page are also local - http://172.17.0.2/#tutorials .
> However, all links to other pages are remote! Also, you can't just replace 
> the server name with the local IP, the URL is slightly different. e.g.
> http://tinkerpop.apache.org/docs/3.3.0-SNAPSHOT/reference
> must be changed to http://172.17.0.2/reference/ in order to view it locally.
> If the reviewer isn't paying attention to the url, s/he might be reviewing 
> the wrong content. It would be better if it were all local and/or relative 
> paths.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1661) Docker-built documentation does not always point locally

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188482#comment-16188482
 ] 

ASF GitHub Bot commented on TINKERPOP-1661:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
@dkuppitz It was change 37a2471932229ae6a4c1f5e5f3f2d3d25bbf7fd4 that 
introduced dotnet that required the need to rebuild the images. 


> Docker-built documentation does not always point locally
> 
>
> Key: TINKERPOP-1661
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1661
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.4
>Reporter: Robert Dale
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> After performing {{docker/build.sh -d}}
> When I pull up the initial URL to look at the docs, it's local -
> http://172.17.0.2/ .
> Anchor links to the same page are also local - http://172.17.0.2/#tutorials .
> However, all links to other pages are remote! Also, you can't just replace 
> the server name with the local IP, the URL is slightly different. e.g.
> http://tinkerpop.apache.org/docs/3.3.0-SNAPSHOT/reference
> must be changed to http://172.17.0.2/reference/ in order to view it locally.
> If the reviewer isn't paying attention to the url, s/he might be reviewing 
> the wrong content. It would be better if it were all local and/or relative 
> paths.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1661) Docker-built documentation does not always point locally

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188428#comment-16188428
 ] 

ASF GitHub Bot commented on TINKERPOP-1661:
---

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
@robertdale FYI: I just fixed the download in `tp32/` and `master/` and 
rebased this PR. Rebuilding the images should no longer be an issue.


> Docker-built documentation does not always point locally
> 
>
> Key: TINKERPOP-1661
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1661
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.4
>Reporter: Robert Dale
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> After performing {{docker/build.sh -d}}
> When I pull up the initial URL to look at the docs, it's local -
> http://172.17.0.2/ .
> Anchor links to the same page are also local - http://172.17.0.2/#tutorials .
> However, all links to other pages are remote! Also, you can't just replace 
> the server name with the local IP, the URL is slightly different. e.g.
> http://tinkerpop.apache.org/docs/3.3.0-SNAPSHOT/reference
> must be changed to http://172.17.0.2/reference/ in order to view it locally.
> If the reviewer isn't paying attention to the url, s/he might be reviewing 
> the wrong content. It would be better if it were all local and/or relative 
> paths.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1661) Docker-built documentation does not always point locally

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187981#comment-16187981
 ] 

ASF GitHub Bot commented on TINKERPOP-1661:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
This makes reviewing so much easier!
VOTE +1

If anyone is interested, these are the times (in seconds) for building each 
doc:
15 /usr/src/tinkermem/docs/src/recipes/duplicate-vertex.asciidoc
16 /usr/src/tinkermem/docs/src/recipes/connected-components.asciidoc
17 /usr/src/tinkermem/docs/src/recipes/shortest-path.asciidoc
18 /usr/src/tinkermem/docs/src/recipes/if-then-based-grouping.asciidoc
18 /usr/src/tinkermem/docs/src/recipes/style-guide.asciidoc
20 /usr/src/tinkermem/docs/src/recipes/between-vertices.asciidoc
20 /usr/src/tinkermem/docs/src/recipes/pagination.asciidoc
21 /usr/src/tinkermem/docs/src/recipes/traversal-component-reuse.asciidoc
22 /usr/src/tinkermem/docs/src/recipes/cycle-detection.asciidoc
23 /usr/src/tinkermem/docs/src/recipes/duplicate-edge.asciidoc
26 
/usr/src/tinkermem/docs/src/reference/implementations-tinkergraph.asciidoc
28 /usr/src/tinkermem/docs/src/recipes/centrality.asciidoc
29 
/usr/src/tinkermem/docs/src/reference/implementations-hadoop-start.asciidoc
31 /usr/src/tinkermem/docs/src/recipes/tree.asciidoc
35 /usr/src/tinkermem/docs/src/recipes/recommendation.asciidoc
35 /usr/src/tinkermem/docs/src/recipes/traversal-induced-values.asciidoc
41 /usr/src/tinkermem/docs/src/recipes/appendix.asciidoc
42 /usr/src/tinkermem/docs/src/reference/implementations-spark.asciidoc
43 /usr/src/tinkermem/docs/src/reference/gremlin-variants.asciidoc
47 /usr/src/tinkermem/docs/src/reference/implementations-hadoop-end.asciidoc
53 /usr/src/tinkermem/docs/src/reference/intro.asciidoc
56 /usr/src/tinkermem/docs/src/reference/implementations-neo4j.asciidoc
83 /usr/src/tinkermem/docs/src/reference/the-graphcomputer.asciidoc
94 /usr/src/tinkermem/docs/src/reference/the-graph.asciidoc
96 /usr/src/tinkermem/docs/src/tutorials/getting-started/index.asciidoc
98 /usr/src/tinkermem/docs/src/tutorials/the-gremlin-console/index.asciidoc
139 /usr/src/tinkermem/docs/src/dev/provider/index.asciidoc
174 /usr/src/tinkermem/docs/src/reference/implementations-giraph.asciidoc
326 /usr/src/tinkermem/docs/src/reference/gremlin-applications.asciidoc
578 /usr/src/tinkermem/docs/src/reference/the-traversal.asciidoc



> Docker-built documentation does not always point locally
> 
>
> Key: TINKERPOP-1661
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1661
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.4
>Reporter: Robert Dale
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> After performing {{docker/build.sh -d}}
> When I pull up the initial URL to look at the docs, it's local -
> http://172.17.0.2/ .
> Anchor links to the same page are also local - http://172.17.0.2/#tutorials .
> However, all links to other pages are remote! Also, you can't just replace 
> the server name with the local IP, the URL is slightly different. e.g.
> http://tinkerpop.apache.org/docs/3.3.0-SNAPSHOT/reference
> must be changed to http://172.17.0.2/reference/ in order to view it locally.
> If the reviewer isn't paying attention to the url, s/he might be reviewing 
> the wrong content. It would be better if it were all local and/or relative 
> paths.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1661) Docker-built documentation does not always point locally

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187880#comment-16187880
 ] 

ASF GitHub Bot commented on TINKERPOP-1661:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
Ignore that.  Somehow my branch was reset to master.  Rebuilding...


> Docker-built documentation does not always point locally
> 
>
> Key: TINKERPOP-1661
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1661
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.4
>Reporter: Robert Dale
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> After performing {{docker/build.sh -d}}
> When I pull up the initial URL to look at the docs, it's local -
> http://172.17.0.2/ .
> Anchor links to the same page are also local - http://172.17.0.2/#tutorials .
> However, all links to other pages are remote! Also, you can't just replace 
> the server name with the local IP, the URL is slightly different. e.g.
> http://tinkerpop.apache.org/docs/3.3.0-SNAPSHOT/reference
> must be changed to http://172.17.0.2/reference/ in order to view it locally.
> If the reviewer isn't paying attention to the url, s/he might be reviewing 
> the wrong content. It would be better if it were all local and/or relative 
> paths.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1661) Docker-built documentation does not always point locally

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187869#comment-16187869
 ] 

ASF GitHub Bot commented on TINKERPOP-1661:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
I ended up using a local copy of hadoop 2.7.2 to complete my docker rebuild.

Anyway, 'Reference Documentation' is now a local link but everything else 
still points to 'tinkerpop.apache.org'



> Docker-built documentation does not always point locally
> 
>
> Key: TINKERPOP-1661
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1661
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.4
>Reporter: Robert Dale
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> After performing {{docker/build.sh -d}}
> When I pull up the initial URL to look at the docs, it's local -
> http://172.17.0.2/ .
> Anchor links to the same page are also local - http://172.17.0.2/#tutorials .
> However, all links to other pages are remote! Also, you can't just replace 
> the server name with the local IP, the URL is slightly different. e.g.
> http://tinkerpop.apache.org/docs/3.3.0-SNAPSHOT/reference
> must be changed to http://172.17.0.2/reference/ in order to view it locally.
> If the reviewer isn't paying attention to the url, s/he might be reviewing 
> the wrong content. It would be better if it were all local and/or relative 
> paths.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1661) Docker-built documentation does not always point locally

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187412#comment-16187412
 ] 

ASF GitHub Bot commented on TINKERPOP-1661:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
[Started a 
thread](https://lists.apache.org/thread.html/4c8f832ce0640230614989f4d60bfd0078aa69a0e11cfd197015fde1@%3Cdev.tinkerpop.apache.org%3E)
 to try to solve my issues.


> Docker-built documentation does not always point locally
> 
>
> Key: TINKERPOP-1661
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1661
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.4
>Reporter: Robert Dale
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> After performing {{docker/build.sh -d}}
> When I pull up the initial URL to look at the docs, it's local -
> http://172.17.0.2/ .
> Anchor links to the same page are also local - http://172.17.0.2/#tutorials .
> However, all links to other pages are remote! Also, you can't just replace 
> the server name with the local IP, the URL is slightly different. e.g.
> http://tinkerpop.apache.org/docs/3.3.0-SNAPSHOT/reference
> must be changed to http://172.17.0.2/reference/ in order to view it locally.
> If the reviewer isn't paying attention to the url, s/he might be reviewing 
> the wrong content. It would be better if it were all local and/or relative 
> paths.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1661) Docker-built documentation does not always point locally

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187394#comment-16187394
 ] 

ASF GitHub Bot commented on TINKERPOP-1661:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
Couldn't build image tinkerpop:hadoop-2.7.2 because that version is no 
longer on mirrors.  Current version is 2.7.4.



> Docker-built documentation does not always point locally
> 
>
> Key: TINKERPOP-1661
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1661
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.4
>Reporter: Robert Dale
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> After performing {{docker/build.sh -d}}
> When I pull up the initial URL to look at the docs, it's local -
> http://172.17.0.2/ .
> Anchor links to the same page are also local - http://172.17.0.2/#tutorials .
> However, all links to other pages are remote! Also, you can't just replace 
> the server name with the local IP, the URL is slightly different. e.g.
> http://tinkerpop.apache.org/docs/3.3.0-SNAPSHOT/reference
> must be changed to http://172.17.0.2/reference/ in order to view it locally.
> If the reviewer isn't paying attention to the url, s/he might be reviewing 
> the wrong content. It would be better if it were all local and/or relative 
> paths.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1661) Docker-built documentation does not always point locally

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187373#comment-16187373
 ] 

ASF GitHub Bot commented on TINKERPOP-1661:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
Docker images are building this morning. Yay.


> Docker-built documentation does not always point locally
> 
>
> Key: TINKERPOP-1661
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1661
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.4
>Reporter: Robert Dale
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> After performing {{docker/build.sh -d}}
> When I pull up the initial URL to look at the docs, it's local -
> http://172.17.0.2/ .
> Anchor links to the same page are also local - http://172.17.0.2/#tutorials .
> However, all links to other pages are remote! Also, you can't just replace 
> the server name with the local IP, the URL is slightly different. e.g.
> http://tinkerpop.apache.org/docs/3.3.0-SNAPSHOT/reference
> must be changed to http://172.17.0.2/reference/ in order to view it locally.
> If the reviewer isn't paying attention to the url, s/he might be reviewing 
> the wrong content. It would be better if it were all local and/or relative 
> paths.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1661) Docker-built documentation does not always point locally

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186816#comment-16186816
 ] 

ASF GitHub Bot commented on TINKERPOP-1661:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/725
  
Do we need dotnet stuff now to build docs?  I am confused by 
http://tinkerpop.apache.org/docs/3.2.6/dev/developer/#dotnet-environment
How do I set this up in docker?  Do I need to rebuild my docker images for 
this?

`docker/build.sh -d`:
```
[ERROR] Failed to execute goal 
org.eobjects.build:dotnet-maven-plugin:0.14:restore (default-restore) on 
project gremlin-dotnet-source:
Command (in /usr/src/tinkermem/gremlin-dotnet/src/Gremlin.Net) [dotnet, 
restore] failed:
Cannot run program "dotnet" (in directory 
"/usr/src/tinkermem/gremlin-dotnet/src/Gremlin.Net"):
error=2, No such file or directory -> [Help 1]
```



> Docker-built documentation does not always point locally
> 
>
> Key: TINKERPOP-1661
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1661
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.4
>Reporter: Robert Dale
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> After performing {{docker/build.sh -d}}
> When I pull up the initial URL to look at the docs, it's local -
> http://172.17.0.2/ .
> Anchor links to the same page are also local - http://172.17.0.2/#tutorials .
> However, all links to other pages are remote! Also, you can't just replace 
> the server name with the local IP, the URL is slightly different. e.g.
> http://tinkerpop.apache.org/docs/3.3.0-SNAPSHOT/reference
> must be changed to http://172.17.0.2/reference/ in order to view it locally.
> If the reviewer isn't paying attention to the url, s/he might be reviewing 
> the wrong content. It would be better if it were all local and/or relative 
> paths.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1661) Docker-built documentation does not always point locally

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186115#comment-16186115
 ] 

ASF GitHub Bot commented on TINKERPOP-1661:
---

GitHub user dkuppitz opened a pull request:

https://github.com/apache/tinkerpop/pull/725

TINKERPOP-1661 Docker-built documentation does not always point locally

https://issues.apache.org/jira/browse/TINKERPOP-1661

That was much easier than I thought. I started by pushing directories 
around and updating links in most of the asciidoc files. Then I realized, that 
this can be a simple 2 line change in Docker's build script (it's basically 
just a global `sed` replacement and a symlink).

VOTE: +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1661

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/725.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #725


commit 82fb125891276ed610e1e7f195758120de20ae84
Author: Daniel Kuppitz 
Date:   2017-09-29T17:14:46Z

Update links to all docs pages in Docker build and emulate the published 
directory structure. This way the docs are easier to navigate in local builds.




> Docker-built documentation does not always point locally
> 
>
> Key: TINKERPOP-1661
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1661
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.4
>Reporter: Robert Dale
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> After performing {{docker/build.sh -d}}
> When I pull up the initial URL to look at the docs, it's local -
> http://172.17.0.2/ .
> Anchor links to the same page are also local - http://172.17.0.2/#tutorials .
> However, all links to other pages are remote! Also, you can't just replace 
> the server name with the local IP, the URL is slightly different. e.g.
> http://tinkerpop.apache.org/docs/3.3.0-SNAPSHOT/reference
> must be changed to http://172.17.0.2/reference/ in order to view it locally.
> If the reviewer isn't paying attention to the url, s/he might be reviewing 
> the wrong content. It would be better if it were all local and/or relative 
> paths.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)