[jira] [Commented] (TINKERPOP-1669) EdgeVertexStep should be designed for extension
[ https://issues.apache.org/jira/browse/TINKERPOP-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064860#comment-16064860 ] ASF GitHub Bot commented on TINKERPOP-1669: --- Github user okram closed the pull request at: https://github.com/apache/tinkerpop/pull/639 > EdgeVertexStep should be designed for extension > --- > > Key: TINKERPOP-1669 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1669 > Project: TinkerPop > Issue Type: Improvement > Components: process, structure >Affects Versions: 3.2.4 >Reporter: Bryn Cooke >Assignee: Marko A. Rodriguez > Fix For: 3.2.6 > > > GraphStep, VertexStep and PropertiesStep are all not final, so I was > surprised to find that I couldn't extend EdgeVertexStep. In the end I had to > duplicate the entire class > If there are concerns about simply making this class non-final then it could > be designed for extension by making most of the methods final (except > toString), but the leaving the class non-final. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1669) EdgeVertexStep should be designed for extension
[ https://issues.apache.org/jira/browse/TINKERPOP-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064724#comment-16064724 ] ASF GitHub Bot commented on TINKERPOP-1669: --- Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/639 VOTE: +1 > EdgeVertexStep should be designed for extension > --- > > Key: TINKERPOP-1669 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1669 > Project: TinkerPop > Issue Type: Improvement > Components: process, structure >Affects Versions: 3.2.4 >Reporter: Bryn Cooke > > GraphStep, VertexStep and PropertiesStep are all not final, so I was > surprised to find that I couldn't extend EdgeVertexStep. In the end I had to > duplicate the entire class > If there are concerns about simply making this class non-final then it could > be designed for extension by making most of the methods final (except > toString), but the leaving the class non-final. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1669) EdgeVertexStep should be designed for extension
[ https://issues.apache.org/jira/browse/TINKERPOP-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062861#comment-16062861 ] ASF GitHub Bot commented on TINKERPOP-1669: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/639 VOTE +1 > EdgeVertexStep should be designed for extension > --- > > Key: TINKERPOP-1669 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1669 > Project: TinkerPop > Issue Type: Improvement > Components: process, structure >Affects Versions: 3.2.4 >Reporter: Bryn Cooke > > GraphStep, VertexStep and PropertiesStep are all not final, so I was > surprised to find that I couldn't extend EdgeVertexStep. In the end I had to > duplicate the entire class > If there are concerns about simply making this class non-final then it could > be designed for extension by making most of the methods final (except > toString), but the leaving the class non-final. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1669) EdgeVertexStep should be designed for extension
[ https://issues.apache.org/jira/browse/TINKERPOP-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059321#comment-16059321 ] ASF GitHub Bot commented on TINKERPOP-1669: --- GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/639 TINKERPOP-1669: EdgeVertexStep should be designed for extension https://issues.apache.org/jira/browse/TINKERPOP-1669 `EdgeVertexStep` is no longer final and can be extended by providers. VOTE +1. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1669 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/639.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #639 > EdgeVertexStep should be designed for extension > --- > > Key: TINKERPOP-1669 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1669 > Project: TinkerPop > Issue Type: Improvement > Components: process, structure >Affects Versions: 3.2.4 >Reporter: Bryn Cooke > > GraphStep, VertexStep and PropertiesStep are all not final, so I was > surprised to find that I couldn't extend EdgeVertexStep. In the end I had to > duplicate the entire class > If there are concerns about simply making this class non-final then it could > be designed for extension by making most of the methods final (except > toString), but the leaving the class non-final. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1669) EdgeVertexStep should be designed for extension
[ https://issues.apache.org/jira/browse/TINKERPOP-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051846#comment-16051846 ] stephen mallette commented on TINKERPOP-1669: - [~okram] can we do this? or did you have some additional response for bryn? > EdgeVertexStep should be designed for extension > --- > > Key: TINKERPOP-1669 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1669 > Project: TinkerPop > Issue Type: Improvement > Components: process, structure >Affects Versions: 3.2.4 >Reporter: Bryn Cooke > > GraphStep, VertexStep and PropertiesStep are all not final, so I was > surprised to find that I couldn't extend EdgeVertexStep. In the end I had to > duplicate the entire class > If there are concerns about simply making this class non-final then it could > be designed for extension by making most of the methods final (except > toString), but the leaving the class non-final. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1669) EdgeVertexStep should be designed for extension
[ https://issues.apache.org/jira/browse/TINKERPOP-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024532#comment-16024532 ] Bryn Cooke commented on TINKERPOP-1669: --- I have recently embarked upon a review of how we are integrating our graph implementation with Tinkerpop. Previously we had significant traversal rewriting going on, and would add and remove steps. However, it turns out that maintaining correctness when doing this is actually quite hard. Instead I am taking a much less invasive approach by simply replacing the element steps with internal classes while leaving the rest of the traversal alone. This has a couple of advantages: 1. It's much easier to reason about. 2. We can optimise for much more complicated traversals, correctly handling AND and OR. If our backend can't mimic the expressiveness of TP we can do as much as possible and allow the TP traversal to handle the rest. > EdgeVertexStep should be designed for extension > --- > > Key: TINKERPOP-1669 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1669 > Project: TinkerPop > Issue Type: Improvement > Components: process, structure >Affects Versions: 3.2.4 >Reporter: Bryn Cooke > > GraphStep, VertexStep and PropertiesStep are all not final, so I was > surprised to find that I couldn't extend EdgeVertexStep. In the end I had to > duplicate the entire class > If there are concerns about simply making this class non-final then it could > be designed for extension by making most of the methods final (except > toString), but the leaving the class non-final. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1669) EdgeVertexStep should be designed for extension
[
https://issues.apache.org/jira/browse/TINKERPOP-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987623#comment-15987623
]
Marko A. Rodriguez commented on TINKERPOP-1669:
---
"unfinalizing" is not a problem. However, can you please tell me your use case
(why do you want {{EdgeVertexStep}} to be customized?). (for my own interest as
I think I can tell you more which can help you).
> EdgeVertexStep should be designed for extension
> ---
>
> Key: TINKERPOP-1669
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1669
> Project: TinkerPop
> Issue Type: Improvement
> Components: process, structure
>Affects Versions: 3.2.4
>Reporter: Bryn Cooke
>
> GraphStep, VertexStep and PropertiesStep are all not final, so I was
> surprised to find that I couldn't extend EdgeVertexStep. In the end I had to
> duplicate the entire class
> If there are concerns about simply making this class non-final then it could
> be designed for extension by making most of the methods final (except
> toString), but the leaving the class non-final.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
