DO NOT REPLY [Bug 41554] New: - The input stream of the JSP file for compiling is not closed.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=41554.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=41554
Summary: The input stream of the JSP file for compiling is not
closed.
Product: Tomcat 5
Version: 5.5.20
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: normal
Priority: P2
Component: Jasper
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]
The wrong code is:
org.apache.jasper.compiler.JDTCompiler.CompilationUnit
-
public char[] getContents() {
char[] result = null;
try {
InputStreamReader isReader =
new InputStreamReader(new FileInputStream(sourceFile),[EMAIL
PROTECTED] Java\[X
[EMAIL PROTECTED]
ctxt.getOptions().getJavaEncoding());
Reader reader = new BufferedReader(isReader);[EMAIL PROTECTED]@©
closeµÄ¢È¢B
if (reader != null) {
char[] chars = new char[8192];
StringBuffer buf = new StringBuffer();
int count;
while ((count = reader.read(chars, 0,
chars.length)) 0) {
buf.append(chars, 0, count);
}
result = new char[buf.length()];
buf.getChars(0, result.length, result, 0);
}
} catch (IOException e) {
log.error(Compilation error, e);
}
return result;
}
-
The input stream is not closed, so the file and the file descriptor is not
liberated until GC runs.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 41554] - The input stream of the JSP file for compiling is not closed.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=41554. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=41554 --- Additional Comments From [EMAIL PROTECTED] 2007-02-07 01:02 --- I'm sorry, please disregard multi byte characters. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r504474 - /tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/compiler/JDTCompiler.java
Author: pero
Date: Wed Feb 7 01:25:52 2007
New Revision: 504474
URL: http://svn.apache.org/viewvc?view=revrev=504474
Log:
Fix Bug 41554: The input stream of the JSP file for compiling is not closed.
OK, find another not right IOE Handling and fix it.
Modified:
tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/compiler/JDTCompiler.java
Modified:
tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/compiler/JDTCompiler.java
URL:
http://svn.apache.org/viewvc/tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/compiler/JDTCompiler.java?view=diffrev=504474r1=504473r2=504474
==
--- tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/compiler/JDTCompiler.java
(original)
+++ tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/compiler/JDTCompiler.java
Wed Feb 7 01:25:52 2007
@@ -99,11 +99,13 @@
public char[] getContents() {
char[] result = null;
+Reader reader = null ;
+InputStreamReader isReader = null ;
try {
-InputStreamReader isReader =
+isReader =
new InputStreamReader(new FileInputStream(sourceFile),
ctxt.getOptions().getJavaEncoding());
-Reader reader = new BufferedReader(isReader);
+reader = new BufferedReader(isReader);
if (reader != null) {
char[] chars = new char[8192];
StringBuffer buf = new StringBuffer();
@@ -117,6 +119,13 @@
}
} catch (IOException e) {
log.error(Compilation error, e);
+} finally {
+if(isReader != null)
+try { isReader.close() ; }
+catch (IOException ignore) {}
+if(reader != null)
+try { reader.close() ; }
+catch (IOException ignore) {}
}
return result;
}
@@ -340,55 +349,66 @@
new DefaultProblemFactory(Locale.getDefault());
final ICompilerRequestor requestor = new ICompilerRequestor() {
-public void acceptResult(CompilationResult result) {
-try {
-if (result.hasProblems()) {
-IProblem[] problems = result.getProblems();
-for (int i = 0; i problems.length; i++) {
-IProblem problem = problems[i];
-if (problem.isError()) {
-String name =
-new
String(problems[i].getOriginatingFileName());
-try {
-
problemList.add(ErrorDispatcher.createJavacError
-(name, pageNodes, new
StringBuffer(problem.getMessage()),
-
problem.getSourceLineNumber(),ctxt));
-} catch (JasperException e) {
-log.error(Error visiting node, e);
-}
-}
+public void acceptResult(CompilationResult result) {
+if (result.hasProblems()) {
+IProblem[] problems = result.getProblems();
+for (int i = 0; i problems.length; i++) {
+IProblem problem = problems[i];
+if (problem.isError()) {
+String name = new String(problems[i]
+.getOriginatingFileName());
+try {
+problemList.add(ErrorDispatcher
+.createJavacError(name, pageNodes,
+new StringBuffer(problem
+.getMessage()), problem
+.getSourceLineNumber(),
+ctxt));
+} catch (JasperException e) {
+log.error(Error visiting node, e);
}
}
-if (problemList.isEmpty()) {
-ClassFile[] classFiles = result.getClassFiles();
-for (int i = 0; i classFiles.length; i++) {
-ClassFile classFile = classFiles[i];
-char[][] compoundName =
-classFile.getCompoundName();
-
DO NOT REPLY [Bug 41554] - The input stream of the JSP file for compiling is not closed.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=41554. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=41554 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |NEEDINFO --- Additional Comments From [EMAIL PROTECTED] 2007-02-07 01:27 --- You are right. I fix it at svn head. please test my fix and report the result. Peter -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 41554] - The input stream of the JSP file for compiling is not closed.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=41554. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=41554 --- Additional Comments From [EMAIL PROTECTED] 2007-02-07 02:58 --- In the real world, there's never going to be an IOE (the source file has been generated by Jasper moments before). So this can be fixed to feel good about it, I suppose, but this will have no impact. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: 5.5.21 build failed
Thanks Mark. Filip Mark Thomas wrote: Mark Thomas wrote: Filip Hanik - Dev Lists wrote: oops, wasn't clear enough. I don't have the bandwidth to track down this issue right now, if someone wants to go in and fix the build dependencies so that the AprEndpoint class indeed is in the classpath when the AJP connector gets compiled Looks like it could be my patch for TC4 to enable it to build with JDK 1.3 although I would have expected Gump to have started to complain by now. I'll take a look. This was indeed the problem. My bad - sorry. This should now be fixed. Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r504731 - in /tomcat/site/trunk: docs/download-60.html xdocs/download-60.xml
Author: remm Date: Wed Feb 7 15:19:06 2007 New Revision: 504731 URL: http://svn.apache.org/viewvc?view=revrev=504731 Log: - 6.0.9. Modified: tomcat/site/trunk/docs/download-60.html tomcat/site/trunk/xdocs/download-60.xml Modified: tomcat/site/trunk/docs/download-60.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-60.html?view=diffrev=504731r1=504730r2=504731 == --- tomcat/site/trunk/docs/download-60.html (original) +++ tomcat/site/trunk/docs/download-60.html Wed Feb 7 15:19:06 2007 @@ -205,7 +205,7 @@ p blockquote a href=http://www.apache.org/dist/tomcat/tomcat-6/KEYS;KEYS/a | -a href=#6.0.7-beta6.0.7-beta/a | +a href=#6.0.9-beta6.0.9-beta/a | a href=http://archive.apache.org/dist/tomcat/tomcat-6;Archives/a /blockquote /p @@ -302,8 +302,8 @@ tr td bgcolor=#525D76 font color=#ff face=arial,helvetica,sanserif -a name=6.0.7-beta -strong6.0.7-beta/strong +a name=6.0.9-beta +strong6.0.9-beta/strong /a /font /td @@ -313,8 +313,8 @@ p blockquote p - a name=6.0.7-betaPlease/a see the - a href=[preferred]/tomcat/tomcat-6/v6.0.7/README.htmlREADME/a + a name=6.0.9-betaPlease/a see the + a href=[preferred]/tomcat/tomcat-6/v6.0.9/README.htmlREADME/a file for packaging information. It explains what every distribution contains. /p @@ -335,33 +335,33 @@ liCore: ul li -a href=[preferred]/tomcat/tomcat-6/v6.0.7/bin/apache-tomcat-6.0.7.zipzip/a -(a href=http://www.apache.org/dist/tomcat/tomcat-6/v6.0.7/bin/apache-tomcat-6.0.7.zip.asc;pgp/a, -a href=http://www.apache.org/dist/tomcat/tomcat-6/v6.0.7/bin/apache-tomcat-6.0.7.zip.md5;md5/a) +a href=[preferred]/tomcat/tomcat-6/v6.0.9/bin/apache-tomcat-6.0.9.zipzip/a +(a href=http://www.apache.org/dist/tomcat/tomcat-6/v6.0.9/bin/apache-tomcat-6.0.9.zip.asc;pgp/a, +a href=http://www.apache.org/dist/tomcat/tomcat-6/v6.0.9/bin/apache-tomcat-6.0.9.zip.md5;md5/a) /li li -a href=[preferred]/tomcat/tomcat-6/v6.0.7/bin/apache-tomcat-6.0.7.tar.gztar.gz/a -(a href=http://www.apache.org/dist/tomcat/tomcat-6/v6.0.7/bin/apache-tomcat-6.0.7.tar.gz.asc;pgp/a, -a href=http://www.apache.org/dist/tomcat/tomcat-6/v6.0.7/bin/apache-tomcat-6.0.7.tar.gz.md5;md5/a) +a href=[preferred]/tomcat/tomcat-6/v6.0.9/bin/apache-tomcat-6.0.9.tar.gztar.gz/a +(a href=http://www.apache.org/dist/tomcat/tomcat-6/v6.0.9/bin/apache-tomcat-6.0.9.tar.gz.asc;pgp/a, +a href=http://www.apache.org/dist/tomcat/tomcat-6/v6.0.9/bin/apache-tomcat-6.0.9.tar.gz.md5;md5/a) /li li -a href=[preferred]/tomcat/tomcat-6/v6.0.7/bin/apache-tomcat-6.0.7.exeWindows Service Installer/a -(a href=http://www.apache.org/dist/tomcat/tomcat-6/v6.0.7/bin/apache-tomcat-6.0.7.exe.asc;pgp/a, -a href=http://www.apache.org/dist/tomcat/tomcat-6/v6.0.7/bin/apache-tomcat-6.0.7.exe.md5;md5/a) +a href=[preferred]/tomcat/tomcat-6/v6.0.9/bin/apache-tomcat-6.0.9.exeWindows Service Installer/a +(a href=http://www.apache.org/dist/tomcat/tomcat-6/v6.0.9/bin/apache-tomcat-6.0.9.exe.asc;pgp/a, +a href=http://www.apache.org/dist/tomcat/tomcat-6/v6.0.9/bin/apache-tomcat-6.0.9.exe.md5;md5/a) /li /ul /li liDeployer: ul li -a href=[preferred]/tomcat/tomcat-6/v6.0.7/bin/apache-tomcat-6.0.7-deployer.zipzip/a -(a href=http://www.apache.org/dist/tomcat/tomcat-6/v6.0.7/bin/apache-tomcat-6.0.7-deployer.zip.asc;pgp/a, -a href=http://www.apache.org/dist/tomcat/tomcat-6/v6.0.7/bin/apache-tomcat-6.0.7-deployer.zip.md5;md5/a) +a href=[preferred]/tomcat/tomcat-6/v6.0.9/bin/apache-tomcat-6.0.9-deployer.zipzip/a +(a href=http://www.apache.org/dist/tomcat/tomcat-6/v6.0.9/bin/apache-tomcat-6.0.9-deployer.zip.asc;pgp/a, +a href=http://www.apache.org/dist/tomcat/tomcat-6/v6.0.9/bin/apache-tomcat-6.0.9-deployer.zip.md5;md5/a) /li li -a href=[preferred]/tomcat/tomcat-6/v6.0.7/bin/apache-tomcat-6.0.7-deployer.tar.gztar.gz/a -(a href=http://www.apache.org/dist/tomcat/tomcat-6/v6.0.7/bin/apache-tomcat-6.0.7-deployer.tar.gz.asc;pgp/a, -a href=http://www.apache.org/dist/tomcat/tomcat-6/v6.0.7/bin/apache-tomcat-6.0.7-deployer.tar.gz.md5;md5/a) +a href=[preferred]/tomcat/tomcat-6/v6.0.9/bin/apache-tomcat-6.0.9-deployer.tar.gztar.gz/a +(a href=http://www.apache.org/dist/tomcat/tomcat-6/v6.0.9/bin/apache-tomcat-6.0.9-deployer.tar.gz.asc;pgp/a, +a
DO NOT REPLY [Bug 41562] New: - [PATCH] Debug logging for read from client in ISAPI Redirector
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=41562. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=41562 Summary: [PATCH] Debug logging for read from client in ISAPI Redirector Product: Tomcat 5 Version: 5.0.0 Platform: Other OS/Version: other Status: NEW Severity: normal Priority: P2 Component: Native:JK AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] http://issues.apache.org/bugzilla/show_bug.cgi?id=41535 highlighted some deficiencies in the debug logging around reading from request streams. This patch adds logging for when data is read from a request in IIS. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 41563] New: - Processing result of mod_jk for Apache2.0.x is unexpected, differs from the one for Apache1.3.x.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=41563.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=41563
Summary: Processing result of mod_jk for Apache2.0.x is
unexpected, differs from the one for Apache1.3.x.
Product: Tomcat 5
Version: 5.0.28
Platform: Other
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Native:JK
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]
Hi,
I'm using Apache2.0.59, mod_jk1.2.20 and Tomcat5.0.28.
The resources are located in the area where is protected by Tomcat's
BASIC authentication.
When I send a request via HEAD method without account nor password,
the values of response headers are not recorded into the Apache2's
access log file.
In the following case of log related parameters for Apache2:
LogFormat \%{WWW-Authenticate}o\ combined
CustomLog /var/log/httpd/access_log combined
Despite the response includes a WWW-Authenticate header that are not
empty values,
the log is set as - value.
This phenomenon does not happen at the case of neither Apache1.3.37
nor the combination of Apache2.2.4 and mod_proxy_ajp.
I guess that the return value from jk_handler's function causes this
unexpected result.
Since the generation of Apache2,
the value of 'sent_bodyct' has not been set as '1' when the
'header_only' value is '1'
#65288;see httpd-2.0.59/modules/http/http_protocol.c L1765#65289;.
As a result, the condition at
tomcat-connectors-1.2.20-src/native/apache-2.0/mod_jk.c L2118
/* If tomcat returned no body and the status is not OK,
let apache handle the error code */
if (!r-sent_bodyct r-status = HTTP_BAD_REQUEST) {
jk_log(xconf-log, JK_LOG_INFO, No body with status=%d
for worker=%s,
r-status, worker_name);
JK_TRACE_EXIT(xconf-log);
return r-status;
-- snip --
return OK; /* NOT r-status, even if it has changed. */
is true, and jk_handler returns the NOT OK value.
Finnaly, the contents of headers table for Apache2 are all cleared.
I suggest to mend the 'if'-condition clause as below:
if (!r-header_only !r-sent_bodyct r-status =
HTTP_BAD_REQUEST) {
What do you think about this, bug or not?
I would like to resolve this probelm.
Regards,
Taka J.S.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 41564] New: - service.bat does not install tomcat as a service properly on Windows Vista
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=41564. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=41564 Summary: service.bat does not install tomcat as a service properly on Windows Vista Product: Tomcat 5 Version: 5.5.20 Platform: PC OS/Version: other Status: NEW Severity: major Priority: P3 Component: Native:Packaging AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] For our issue see a href=http://jira.atlassian.com/browse/JRA-12109;JRA-12109/a. The service.bat file included in Tomcat fails to install Tomcat as a service properly in Windows Vista. Vista has changed the implementation of services and the current services.bat does not do an adequate job at installing Tomcat as a service. The service gets added to the list of services, but it can't be started, stopped or removed. (due to service privileges missing) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
