svn commit: r1042328 - in /tomcat/site/trunk: docs/migration.html xdocs/migration.xml
Author: kkolinko Date: Sun Dec 5 12:19:10 2010 New Revision: 1042328 URL: http://svn.apache.org/viewvc?rev=1042328&view=rev Log: Added a TOC Modified: tomcat/site/trunk/docs/migration.html tomcat/site/trunk/xdocs/migration.xml Modified: tomcat/site/trunk/docs/migration.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration.html?rev=1042328&r1=1042327&r2=1042328&view=diff == --- tomcat/site/trunk/docs/migration.html (original) +++ tomcat/site/trunk/docs/migration.html Sun Dec 5 12:19:10 2010 @@ -183,6 +183,96 @@ + + + + +Table of Contents + + + + + + + + + + +Before upgrading + + +5.5.x to 6.0.x + + +Java 5 required + + +Modified directory structure + + +Modified classloading + + +Logging API package renaming + + +SSLEnabled attribute on Connector + + +Clustering configuration changes + + +Connector thread pools + + + + +6.0.x to 7.0.x + + +Java 6 required + + +Deployment + + +Manager application + + +Host Manager application + + +Session manager configuration + + +Session cookie configuration + + +Comet + + +XML validation + + +System properties + + + + + + + + + + + + + + + + + + Modified: tomcat/site/trunk/xdocs/migration.xml URL: http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/migration.xml?rev=1042328&r1=1042327&r2=1042328&view=diff == --- tomcat/site/trunk/xdocs/migration.xml (original) +++ tomcat/site/trunk/xdocs/migration.xml Sun Dec 5 12:19:10 2010 @@ -8,6 +8,10 @@ + + + + When updating from one Apache Tomcat branch to a newer one, please make sure - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Taglibs [2010/12/05]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |27717|New|Maj|2004-03-16| very slow in JSTL 1.1 | |38193|Ass|Enh|2006-01-09|[RDC] BuiltIn Grammar support for Field | |38600|Ass|Enh|2006-02-10|[RDC] Enable RDCs to be used in X+V markup (X+RDC)| |42413|New|Enh|2007-05-14|[PATCH] Log Taglib enhancements | |46052|New|Nor|2008-10-21|SetLocaleSupport is slow to initialize when many l| |48333|New|Enh|2009-12-02|TLD generator | |49578|New|Nor|2010-07-09|XPath handling only supports single reference to v| |50064|New|Nor|2010-10-09|bundle-ify the taglibs jars | |50068|New|Nor|2010-10-09|Memory leak with Driver registration | |50250|New|Maj|2010-11-10|Split package issue in impl and jstlel bundles| |50263|New|Nor|2010-11-13|README_src.txt out of date| |50265|New|Nor|2010-11-13|FormatDateSupport.dateFormatCache lazy init is not| +-+---+---+--+--+ | Total 12 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat 5 [2010/12/05]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |27122|Opn|Enh|2004-02-20|IE plugins cannot access components through Tomcat| |28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn | |29494|Inf|Enh|2004-06-10|No way to set PATH when running as a service on Wi| |33262|Inf|Enh|2005-01-27|Service Manager autostart should check for adminis| |33453|Opn|Enh|2005-02-08|Jasper should recompile JSP files whose datestamps| |33671|Opn|Enh|2005-02-21|Manual Windows service installation with custom na| |34801|New|Enh|2005-05-08|PATCH: CGIServlet does not terminate child after a| |34805|Ass|Enh|2005-05-08|warn about invalid security constraint url pattern| |34868|Ass|Enh|2005-05-11|allow to register a trust store for a session that| |35054|Inf|Enh|2005-05-25|warn if appBase is not existing as a File or direc| |36362|New|Enh|2005-08-25|missing check for Java reserved keywords in tag fi| |36569|Inf|Enh|2005-09-09|Redirects produce illegal URL's | |36837|Inf|Enh|2005-09-28|Looking for ProxyHandler implementation of Http re| |37018|Ass|Enh|2005-10-11|Document how to use tomcat-SSL with a pkcs11 token| |37334|Inf|Enh|2005-11-02|Realm digest property not aligned with the adminis| |38216|Inf|Enh|2006-01-10|Extend Jmxproxy to allow call of MBean Operations | |38268|Inf|Enh|2006-01-13|User friendly: Need submit button on adding/deleti| |38360|Inf|Enh|2006-01-24|Domain for session cookies| |38546|Inf|Enh|2006-02-07|Google bot sends invalid If-Modifed-Since Header, | |38577|Inf|Enh|2006-02-08|Enhance logging of security failures | |38916|Inf|Enh|2006-03-10|HttpServletRequest cannot handle multipart request| |39053|Inf|Enh|2006-03-21|include Tomcat embedded sample| |39740|New|Enh|2006-06-07|semi-colon ; isn't allowed as a query argument sep| |39862|Inf|Enh|2006-06-22|provide support for protocol-independent GenericSe| |40211|Inf|Enh|2006-08-08|Compiled JSP don't indent HTML code | |40402|New|Enh|2006-09-03|Manager should display Exceptions | |40510|New|Enh|2006-09-14|installer does not create shortcuts for all users | |40712|New|Enh|2006-10-10|Realm admin error.| |40728|Inf|Enh|2006-10-11|Catalina MBeans use non-serializable classes | |40766|New|Enh|2006-10-16|Using an unsecure jsessionid with mod_proxy_ajp ov| |40881|Opn|Enh|2006-11-02|Unable to receive message through TCP channel -> | |41007|Opn|Enh|2006-11-20|Can't define customized 503 error page| |41179|New|Enh|2006-12-15|400 Bad Request response during auto re-deployment| |41227|Opn|Enh|2006-12-21|When the jasper compiler fails to compile a JSP, i| |41337|Opn|Enh|2007-01-10|Display an error page if no cert is available on C| |41496|New|Enh|2007-01-30|set a security provider for jsse in a connector co| |41498|New|Enh|2007-01-30|allRolesMode Realm configuration option not docume| |41539|Inf|Enh|2007-02-05|NullPointerException during Embedded tomcat restar| |41673|New|Enh|2007-02-21|Jasper output the message of compiling error using| |41697|Ver|Enh|2007-02-25|make visible in debug output if charset from brows| |41709|Inf|Enh|2007-02-26|When calling the API that relates to the buffer af| |41718|New|Enh|2007-02-27|Status 302 response to GET request has no body whe| |42416|New|Enh|2007-05-14|Tomcat startup hangs and AJP13 connector port 8009| |43423|New|Enh|2007-09-18|catalina.sh -force too fast | |43538|New|Enh|2007-10-02|[patch] Show the hostname and IP address in the ma| |43796|Inf|Enh|2007-11-05|Add MIME type mapping for the "log" extension | |43866|New|Enh|2007-11-14|add support for session attribute propagation with| |43925|Opn|Enh|2007-11-21|org.apache.jasper.runtime.BodyContentImpl causing | |43960|New|Enh|2007-11-26|Expose StandardWrapper unavailable and/or availabl| |43991|New|Enh|2007-11-29|Contributing a URLResourceFactory | |44216|New|Enh|2008-01-11|Don't reuse session ID even if emptySessionPath=tr| |44309|
Bug report for Tomcat 6 [2010/12/05]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |39661|Opn|Enh|2006-05-25|Please document JULI FileHandler configuration pro| |41128|Inf|Enh|2006-12-07|Reference to java Thread name from RequestProcesso| |41679|New|Enh|2007-02-22|SemaphoreValve should be able to filter on url pat| |41883|Ass|Enh|2007-03-18|use abstract wrapper instead of plain X509Certific| |41992|New|Enh|2007-03-30|Need ability to set OS process title | |42463|New|Enh|2007-05-20|"crossContext" and classloader issues - pls amend | |43001|New|Enh|2007-07-30|JspC lacks setMappedFile and setDie for use in Ant| |43400|New|Enh|2007-09-14|enum support for tag libs | |43497|New|Enh|2007-09-26|Add ability to escape rendered output of JSP expre| |43548|Opn|Enh|2007-10-04|xml schema for tomcat-users.xml | |43682|New|Enh|2007-10-23|JULI: web-inf/classes/logging.properties to suppor| |43742|New|Enh|2007-10-30|.tag compiles performed one at a time -- extremel| |43790|Ass|Enh|2007-11-03|concurrent access issue on TagHandlerPool | |43979|New|Enh|2007-11-27|Add abstraction for Java and Classfile output | |44047|New|Enh|2007-12-10|Provide a way for Tomcat to serve up error pages w| |44199|New|Enh|2008-01-10|expose current backlog queue size | |44225|New|Enh|2008-01-14|SSL connector tries to load the private keystore f| |44264|New|Enh|2008-01-18|Clustering - Support for disabling multicasting an| |44284|New|Enh|2008-01-23|Support java.lang.Iterable in c:forEach tag | |44294|New|Enh|2008-01-25|Support for EL functions with varargs | |44299|New|Enh|2008-01-26|Provider manager app with a log out button| |44312|New|Enh|2008-01-28|Warn when overwritting docBase of the default Host| |44598|New|Enh|2008-03-13|JAASRealm is suppressing Exceptions | |44645|New|Enh|2008-03-20|[Patch] JNDIRealm - Doesn't support JNDI "java.nam| |44787|New|Enh|2008-04-09|provide more error context on "java.lang.IllegalSt| |44818|New|Enh|2008-04-13|tomcat hangs with GET when content-length is defin| |45014|New|Enh|2008-05-15|Request and Response classes should have wrappers | |45282|New|Enh|2008-06-25|NioReceiver doesn't close cleanly, leaving sockets| |45283|Opn|Enh|2008-06-25|Allow multiple authenticators to be added to pipel| |45428|New|Enh|2008-07-18|warn if the tomcat stop doesn't complete | |45654|New|Enh|2008-08-19|use static methods and attributes in a direct way!| |45731|New|Enh|2008-09-02|Enhancement request : pluggable httpsession cache | |45832|New|Enh|2008-09-18|add DIGEST authentication support to Ant tasks| |45871|New|Enh|2008-09-23|Support for salted and digested patches in DataSou| |45878|New|Enh|2008-09-24|Generated jars do not contain proper manifests or | |45879|Opn|Enh|2008-09-24|Windows installer fails to install NOTICE and RELE| |45931|Opn|Enh|2008-10-01|trimSpaces incorrectly modifies output| |45995|New|Enh|2008-10-13|RFE - MIME type extension not case sensitive | |46173|New|Enh|2008-11-09|Small patch for manager app: Setting an optional c| |46263|New|Enh|2008-11-21|Tomcat reloading of context does not update contex| |46264|New|Enh|2008-11-21|Shutting down tomcat with large number of contexts| |46284|New|Enh|2008-11-24|Add flag to DeltaManager that blocks processing cl| |46350|New|Enh|2008-12-05|Maven repository should contain source bundles| |46451|New|Enh|2008-12-30|Configure svn:bugtraq properties | |46461|New|Enh|2009-01-01|fail graceful on dns changes for connectors/hosts | |46497|New|Enh|2009-01-08|Install Tomcat Deployer/ANT on Windows Platform | |46655|New|Enh|2009-02-03|keystore's password handler | |46727|New|Enh|2009-02-17|DefaultServlet - serving multiple encodings | |46819|New|Enh|2009-03-07|Remove redundant object instantiations in JspRunti| |46902|New|Enh|2009-03-24|LoginValve to bypass restrictions of j_security_ch| |47061|New|Enh|2009-04-21|JDBCStore for saving sessions doesn't support data| |47214|
Bug report for Tomcat 7 [2010/12/05]
+---+
| Bugzilla Bug ID |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) |
| | +-+
| | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major |
| | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial |
| | | +-+
| | | | Date Posted |
| | | | +--+
| | | | | Description |
| | | | | |
|48550|Inf|Enh|2010-01-14|Update examples and default server.xml to use UTF-|
|48870|New|Enh|2010-03-08|avoid parallel arrays of base types |
|48892|New|Enh|2010-03-11|Use URIEncoding from server.xml for decoding post |
|49000|New|Enh|2010-03-26|Cookie parsing bug when an empty value has an equa|
|49122|Opn|Enh|2010-04-14|Update of ROOT application index.html |
|49125|New|Enh|2010-04-14|toString on byte[] array probably is not correct |
|49159|New|Enh|2010-04-20|Improve ThreadLocal memory leak clean-up |
|49165|New|Enh|2010-04-21|Enhancement - Allow %{TIME_FORMAT}t As Configurati|
|49284|New|Enh|2010-05-12|Implement SSL renegotiation for the NIO connector |
|49290|New|Enh|2010-05-14|Using a JarScanner with scanAllDirectories=true ca|
|49318|New|Enh|2010-05-20|add a Negotiate (Kerberos/NTLM) authenticator / in|
|49395|New|Enh|2010-06-06|manager.findLeaks : display the date when the leak|
|49589|New|Enh|2010-07-12|Tag handlers with constant attribute values are al|
|49591|New|Enh|2010-07-13|Custom error page always uses Transfer-Encoding: c|
|49683|New|Nor|2010-08-01|Separate keep-alive and connection timeout with AP|
|49711|New|Enh|2010-08-05|HttpServletRequest#getParts() does not work in a F|
|49785|New|Enh|2010-08-19|Enabling TLS for JNDIRealm|
|49821|New|Enh|2010-08-25|Tomcat CLI|
|50019|New|Enh|2010-09-28|Adding JNDI "lookup-name" support In XML and Resou|
|50175|New|Enh|2010-10-28|Enhance memory leak detection by selectively apply|
|50205|New|Enh|2010-11-03|Add deployIgnorePaths attribute to StandardHost |
|50234|New|Enh|2010-11-08|JspC use servlet 3.0 features |
|50282|New|Enh|2010-11-16|Reference from javax.security.auth.login.LoginCont|
|50306|New|Enh|2010-11-19|Detect stuck threads |
|50325|New|Enh|2010-11-24|Update Tomcat to use JRE provided solutions for CV|
|50353|New|Enh|2010-11-27|Calling asyncContext.getResponse() returns null af|
|50360|Opn|Nor|2010-11-28|Server socket still bound after Embedded.stop is i|
|50405|New|Nor|2010-12-02|Null Pointer Exception at Coyote Adapter |
|50411|New|Nor|2010-12-04|invalid sessions not removed from PersistenManager|
+-+---+---+--+--+
| Total 29 bugs |
+---+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Connectors [2010/12/05]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |34526|Opn|Nor|2005-04-19|Truncated content in decompressed requests from mo| |35959|Opn|Enh|2005-08-01|mod_jk not independant of UseCanonicalName| |36155|Opn|Nor|2005-08-12|tomcat chooses wrong host if using mod_jk | |39967|Inf|Nor|2006-07-05|mod_jk gives segmentation fault when apache is sta| |40208|Inf|Nor|2006-08-08|Request-Dump when ErrorDocument in httpd.conf is a| |41923|Opn|Nor|2007-03-21|Tomcat doesnt recognized client abort | |42366|Inf|Nor|2007-05-09|Memory leak in newer mod_jk version when connectio| |42554|Opn|Nor|2007-05-31|mod_ssl + mod_jk with status_worker does not work | |43303|New|Enh|2007-09-04|Versioning under Windows not reported by many conn| |43968|New|Enh|2007-11-26|[patch] support ipv6 with mod_jk | |44290|New|Nor|2008-01-24|mod_jk/1.2.26: retry is not useful for an importan| |44349|New|Maj|2008-02-04|mod_jk/1.2.26 module does not read worker.status.s| |44379|New|Enh|2008-02-07|convert the output of strftime into UTF-8 | |44454|New|Nor|2008-02-19|busy count reported in mod_jk inflated, causes inc| |44571|New|Enh|2008-03-10|Limits busy per worker to a threshold | |45063|New|Nor|2008-05-22|JK-1.2.26 IIS ISAPI filter issue when running diff| |45313|New|Nor|2008-06-30|mod_jk 1.2.26 & apache 2.2.9 static compiled on so| |45395|New|Min|2008-07-14|MsgAjp dump method does not dump packet when being| |46337|New|Nor|2008-12-04|real worker name is wrong | |46406|New|Enh|2008-12-16|Supporting relative paths in isapi_redirect.proper| |46676|New|Enh|2009-02-09|Configurable test request for Watchdog thread | |46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca| |47038|New|Enh|2009-04-15|USE_FLOCK_LK redefined compiler warning when using| |47327|New|Enh|2009-06-07|remote_user not logged in apache logfile | |47617|New|Enh|2009-07-31|include time spent doing ajp_get_endpoint() in err| |47678|New|Cri|2009-08-11|Unable to allocate shared memory when using isapi_| |47679|New|Nor|2009-08-11|Not all headers get passed to Tomcat server from i| |47692|New|Reg|2009-08-12|Can not compile mod_jk with apache2.0.63 and tomca| |47714|New|Cri|2009-08-20|Reponse mixed between users | |47750|New|Maj|2009-08-27|Loss of worker settings when changing via jkstatus| |47795|New|Maj|2009-09-07|service sticky_session not being set correctly wit| |47840|Inf|Min|2009-09-14|A broken worker name is written in the log file. | |48191|New|Maj|2009-11-13|Problem with mod_jk 1.2.28 - Can not render up the| |48460|New|Nor|2009-12-30|mod_proxy_ajp document has three misleading portio| |48490|New|Nor|2010-01-05|Changing a node to stopped in uriworkermap.propert| |48513|New|Enh|2010-01-09|IIS Quick setup instructions | |48564|New|Nor|2010-01-18|Unable to turn off retries for LB worker | |48830|New|Nor|2010-03-01|IIS shutdown blocked in endpoint service when serv| |48891|Opn|Enh|2010-03-11|Missing EOL-style settings in tomcat/jk/trunk | |48940|New|Maj|2010-03-18|IIS to Tomcat occasionally fails on POST with T-E | |49035|New|Maj|2010-04-01|data lost when post a multipart/form-data form| |49048|New|Nor|2010-04-05|ACL not applied to redirect URLs | |49063|New|Enh|2010-04-07|Please add JkStripSession status in jk-status work| |49135|New|Enh|2010-04-16|SPDY Connector for The Tomcat | |49413|Opn|Reg|2010-06-09|Apache Mod_jk 1.2.30 is shutting down communicatio| |49469|New|Enh|2010-06-19|Workers status page has negative number of connect| |49732|Opn|Nor|2010-08-10|reply_timeout can't wait forever. | |49822|New|Enh|2010-08-25|Add hash lb worker method | |49903|New|Enh|2010-09-09|Make workers file reloadable | |50186|New|Nor|2010-10-31|Wrong documentation of connection_pool_timeout / c| |50233|New|Cri|2010-11-08|support long URLs (more than 2048)| |50304|
Bug report for Tomcat Modules [2010/12/05]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |48240|New|Nor|2009-11-19|Tomcat-Lite missing @Override markers | |48268|New|Nor|2009-11-23|Patch to fix generics in tomcat-lite | |48861|New|Nor|2010-03-04|Files without AL headers | |49543|New|Enh|2010-07-02|Request for a "shared" datasource configuration as| |49685|New|Nor|2010-08-02|Unsafe synchronization in class ManagedBean | |49686|New|Nor|2010-08-02|Using an instance lock to protect static shared da| |49953|New|Nor|2010-09-17|Missing @Override annotations | |49954|New|Nor|2010-09-17|Code tidyup | |50025|New|Cri|2010-09-29|getConnection method in class DataSourceProxy is i| |50333|New|Nor|2010-11-25|IllegalArgumentException occurs when setting maxAc| +-+---+---+--+--+ | Total 10 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Native [2010/12/05]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |38372|Inf|Cri|2006-01-25|tcnative-1.dll response overflow corruption, parti| |41361|New|Nor|2007-01-14|Content lost when read by a slow client. | |42090|New|Cri|2007-04-11|tcnative badly handles some OpenSSL disconnections| |45392|New|Nor|2008-07-14|No OCSP support for client SSL verification | |46041|New|Cri|2008-10-20|Tomcat service is terminated unexpectedly (tcnativ| |46179|New|Maj|2008-11-10|apr ssl client authentication | |46571|New|Nor|2009-01-21|tcnative blocks in APR poll on Solaris| |47319|New|Nor|2009-06-05|With APR, getRemoteHost() returns NULL for unknown| |47851|New|Nor|2009-09-16|thread-safety issues in the TC native Java code | |48253|New|Min|2009-11-20|Tomcat Native patch - adding dynamic locking callb| |48655|New|Nor|2010-02-02|Active multipart downloads prevent tomcat shutdown| |49038|Inf|Nor|2010-04-02|Crash in tcnative | |49556|New|Cri|2010-07-05|the proc.create function used args as env to get t| |49557|New|Cri|2010-07-05|index erro in the loop to get the env info in the | |49595|New|Cri|2010-07-15|Tomcat crashes in tcnative-1.dll frequently | |49795|New|Nor|2010-08-22|Crash in Socket.destroy | |49796|New|Nor|2010-08-22|Crash in SSLSocket.handshake()| |49851|New|Blk|2010-08-31|JNI Registry.deleteKey and Registry.deleteValue co| |50135|New|Nor|2010-10-21|IPV6 problem: unable to connect from other host | |50394|New|Nor|2010-12-01|InternalAprInputBuffer.fill() doesn't deal correct| |50410|New|Nor|2010-12-03|Poll.create with THREADSAFE will silently switch t| +-+---+---+--+--+ | Total 21 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50413] New: Tomcat returns 302 instead of 404 response for static custom 404 error file
https://issues.apache.org/bugzilla/show_bug.cgi?id=50413 Summary: Tomcat returns 302 instead of 404 response for static custom 404 error file Product: Tomcat 7 Version: 7.0.5 Platform: PC OS/Version: Windows XP Status: NEW Severity: minor Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: prei...@web.de When using a static html file for 404 errors and the client sends a request to a file whoch doesn't exist, and adds a "If-Modified-Since" header with a date that is newer than the modification date of the static error file, then Tomcat returns "302 Not Modofied" instead of "404 Not Found". Steps to reproduce: 1) Make a simple webapp that uses a static html file as custom error page for 404 errors, like this (web.xml): 404 /errorpages/404.html 2) Do a GET request to a URL which points to a file that doesn't exist, and add a "If-Modified-Since" header with a date that is newer than the modification date of the 404 error file (the date may also be in the future), e.g. GET /MyWebApp/AUrlToAFileWhichDoesNotExist.gif HTTP/1.1 Host: localhost Keep-Alive: 115 Connection: keep-alive If-Modified-Since: Tue, 08 Nov 2015 15:07:52 GMT (replace "MyWebApp" with your webapp's name) 3) Tomcat returns "HTTP/1.1 302 Not Modified" instead of "HTTP/1.1 404 Not Found". Actual Results: Tomcat returns a "302 Not Modified" response, because it seems to compare the date of the "If-Modified-Header" with the date of the static 404 error file. Expected Results: Tomcat returns a "404 Not Found" response, because the requested file does not exist. If you omit the "If-Modified-Since" header or use a date that is older than the date of the error file, Tomcat correctly returns "404 Not Found", but adds an "Last-Modified" header with the modification date of the 404 file. This behavior caused invalid 302 responses to be sent over the ISAPI redirector (bug 50363, with enabled chunked encoding support) when I was viewing my site in Firefox and pressed F5 to refresh it, because I think as of bug 49591, Tomcat uses chunked encoding for this response, which the ISAPI redirector didn't check. I tested on Tomcat 7.0.5 on 32-Bit Windows XP, with Tomcat Native 1.1.20, on Java 1.6.0_22. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50413] Tomcat returns 304 instead of 404 response for static custom 404 error file
https://issues.apache.org/bugzilla/show_bug.cgi?id=50413 Konstantin Preißer changed: What|Removed |Added Summary|Tomcat returns 302 instead |Tomcat returns 304 instead |of 404 response for static |of 404 response for static |custom 404 error file |custom 404 error file -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50413] Tomcat returns 304 instead of 404 response for static custom 404 error file
https://issues.apache.org/bugzilla/show_bug.cgi?id=50413 --- Comment #1 from Konstantin Preißer 2010-12-05 07:41:06 EST --- Sorry, when I wrote "302 Not Modified" I actually ment "304 Not Modified". -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1042337 - /tomcat/trunk/.fbprefs
Author: markt Date: Sun Dec 5 12:49:22 2010 New Revision: 1042337 URL: http://svn.apache.org/viewvc?rev=1042337&view=rev Log: Remove file accidentally added in r1042029 Removed: tomcat/trunk/.fbprefs - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1042339 - /tomcat/trunk/
Author: markt Date: Sun Dec 5 12:51:46 2010 New Revision: 1042339 URL: http://svn.apache.org/viewvc?rev=1042339&view=rev Log: Ignore all .* files rather than adding them one by one as they appear Modified: tomcat/trunk/ (props changed) Propchange: tomcat/trunk/ -- --- svn:ignore (original) +++ svn:ignore Sun Dec 5 12:51:46 2010 @@ -1,6 +1,3 @@ -.settings -.classpath -.project +.* output build.properties -.checkstyle - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1042344 - in /tomcat/site/trunk: docs/migration.html xdocs/migration.xml
Author: kkolinko Date: Sun Dec 5 13:07:57 2010 New Revision: 1042344 URL: http://svn.apache.org/viewvc?rev=1042344&view=rev Log: Amended / rephrased some of 5.5->6.0 migration tips. Modified: tomcat/site/trunk/docs/migration.html tomcat/site/trunk/xdocs/migration.xml Modified: tomcat/site/trunk/docs/migration.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration.html?rev=1042344&r1=1042343&r2=1042344&view=diff == --- tomcat/site/trunk/docs/migration.html (original) +++ tomcat/site/trunk/docs/migration.html Sun Dec 5 13:07:57 2010 @@ -219,10 +219,10 @@ SSLEnabled attribute on Connector -Clustering configuration changes +Connector thread pools -Connector thread pools +Clustering configuration changes @@ -341,7 +341,7 @@ compatibility problems. -Apache Tomcat 6.0.x requires Java 5, unlike Apache Tomcat 5.5.x which +Apache Tomcat 6.0.x requires Java 5 or later, unlike Apache Tomcat 5.5.x which could use a compatibility package to run on JRE 1.4. @@ -372,13 +372,18 @@ compatibility problems. Apache Tomcat 5.5.x used, by default, a directory structure including -common, shared and server. Apache Tomcat 6.0.x merges these repositories -into a single lib folder. The conf/catalina.properties file -can be used to modify the directory structure. In addition, all of the -default web applications are located in the webapps folder. -When using a shared webhosting environment, it is recommended that usage -of context.xml inside a WAR is forbidden (using the deployXML -attribute of the Host element). +common, shared and server subdirectories. +Apache Tomcat 6.0.x merges these into a single lib directory. +The conf/catalina.properties file can be used to modify +the directory structure. + +In addition, all of the default web applications are located in the +webapps folder. + +When using a shared webhosting environment, it is recommended to forbid +the use of context.xml inside the WAR files (using the deployXML +attribute of the Host element). +(This option is also available in Tomcat 5.5). @@ -447,6 +452,10 @@ compatibility problems. components when using log4j for Tomcat's logging. See the logging and extras documentation for more details. +The commons-logging-api.jar library is no longer provided +by Tomcat. The web applications have to provide their own copy of that +library, if needed + @@ -493,11 +502,11 @@ compatibility problems. - + - -Clustering configuration changes + +Connector thread pools @@ -506,8 +515,12 @@ compatibility problems. -Clustering configuration was refactored. See the clustering documentation -for more details. +The Connector thread pools have been simplified. They +now grow to the maximum size specified but never shrink. The attributes +associated with shrinking the thread pool (e.g. minSpareThreads) +will be ignored. If you require a thread pool that grows and shrinks with +demand you'll need to configure an Executor and then +configure your Connector to use it. @@ -523,11 +536,11 @@ compatibility problems. - + - -Connector thread pools + +Clustering configuration changes @@ -536,12 +549,8 @@ compatibility problems. -The Connector thread pools have been simplified. They -now grow to the maximum size specified but never shrink. The attributes -associated with shrinking the thread pool (e.g. minSpareThreads -will be ignored. If you require a thread pool that grows and shrinks with -demand you'll need to configure an Executor and then -configure your Connector to use it. +Clustering configuration was refactored. See the clustering documentation +for more details. @@ -628,7 +637,7 @@ compatibility problems. XML context descriptors are no longer extracted from deployed WARs and directories and copied to the host's xmlBase. The default Tomcat 6 behavior can be enabled by setting the copyXML -attribute of the host to true. +attribute of the Host element to true. @@ -910,7 +919,7 @@ compatibility problems. -The configuration of XMl validation has been simplified. The +The configuration of XML validation has been simplified. The xmlValidation and xmlNamespaceAware attributes have been removed from theelement. These attributes, along with tldValidation and Modified: tomcat/site/trunk/xdocs/migration.xml URL: http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/migration.xml?rev=1042344&r1=1042343&r2=1042344&view=diff == --- tomcat/site/trunk/xdocs/migration.xml (original) +++ tomcat/site/trunk/xdocs/migration.xml Sun Dec 5 13:07:57 2010 @@ -29,7 +29,7 @@ compati
svn commit: r1042350 - in /tomcat/site/trunk: docs/migration.html xdocs/migration.xml
Author: kkolinko Date: Sun Dec 5 13:48:31 2010 New Revision: 1042350 URL: http://svn.apache.org/viewvc?rev=1042350&view=rev Log: Note disableURLRewriting and useHttpOnly options changes. Modified: tomcat/site/trunk/docs/migration.html tomcat/site/trunk/xdocs/migration.xml Modified: tomcat/site/trunk/docs/migration.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration.html?rev=1042350&r1=1042349&r2=1042350&view=diff == --- tomcat/site/trunk/docs/migration.html (original) +++ tomcat/site/trunk/docs/migration.html Sun Dec 5 13:48:31 2010 @@ -845,23 +845,42 @@ compatibility problems. With the addition of SessionCookieConfig in the Servlet 3.0 specification, a number of session cookie configuration options have been removed to reduce configuration and code complexity. - + - Connector.emptySessionPath: This has been removed. An equivalent + +Connector +.emptySessionPath: This has been removed. An equivalent effect can be obtained by configuring sessionCookiePath="/" in the global context.xml (in CATALINA_BASE/conf/context.xml). - org.apache.catalina.SESSION_COOKIE_NAME system property: This has been + +org.apache.catalina.SESSION_COOKIE_NAME system property: This has been removed. An equivalent effect can be obtained by configuring the - sessionCookieName attribute for the global context.xml + sessionCookieName attribute for the global context.xml (in CATALINA_BASE/conf/context.xml). - org.apache.catalina.SESSION_PARAMETER_NAME system property: This has + +org.apache.catalina.SESSION_PARAMETER_NAME system property: This has been removed. An equivalent effect can be obtained by configuring the - sessionCookieName attribute for the global context.xml + sessionCookieName attribute for the global context.xml (in CATALINA_BASE/conf/context.xml). + + +Context +.disableURLRewriting: This has + been removed. An equivalent effect can be obtained by configuring the + session-config/tracking-mode elements in a web application + or in the global CATALINA_BASE/conf/web.xml file. +The session and SSO cookies in Tomcat 7 are being sent with HttpOnly +flag by default, to instruct browsers to prevent access to those cookies +from JavaScript. +(This can be enabled in Tomcat 6.0 and 5.5 by setting +useHttpOnly="true" on Context element in +a web application or in the global +CATALINA_BASE/conf/context.xml file). + Modified: tomcat/site/trunk/xdocs/migration.xml URL: http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/migration.xml?rev=1042350&r1=1042349&r2=1042350&view=diff == --- tomcat/site/trunk/xdocs/migration.xml (original) +++ tomcat/site/trunk/xdocs/migration.xml Sun Dec 5 13:48:31 2010 @@ -228,23 +228,36 @@ compatibility problems. With the addition of SessionCookieConfig in the Servlet 3.0 specification, a number of session cookie configuration options have been removed to reduce configuration and code complexity. - + - Connector.emptySessionPath: This has been removed. An equivalent + Connector.emptySessionPath: This has been removed. An equivalent effect can be obtained by configuring sessionCookiePath="/" in the global context.xml (in CATALINA_BASE/conf/context.xml). - org.apache.catalina.SESSION_COOKIE_NAME system property: This has been + org.apache.catalina.SESSION_COOKIE_NAME system property: This has been removed. An equivalent effect can be obtained by configuring the - sessionCookieName attribute for the global context.xml + sessionCookieName attribute for the global context.xml (in CATALINA_BASE/conf/context.xml). - org.apache.catalina.SESSION_PARAMETER_NAME system property: This has + org.apache.catalina.SESSION_PARAMETER_NAME system property: This has been removed. An equivalent effect can be obtained by configuring the - sessionCookieName attribute for the global context.xml + sessionCookieName attribute for the global context.xml (in CATALINA_BASE/conf/context.xml). + + Context.disableURLRewriting: This has + been removed. An equivalent effect can be obtained by configuring the + session-config/tracking-mode elements in a web application + or in the global CATALINA_BASE/conf/web.xml file. +The session and SSO cookies in Tomcat 7 are being sent with HttpOnly +flag by default, to instruct browsers to prevent access to those cookies +from JavaScript. +(This can be enabled in Tomcat 6.0 and 5.5 by setting +useHttpOnly="true" on Context element in +a web application or in the global +CATALINA_BASE/conf/context.xml file). + ---
Re: svn commit: r1042350 - in /tomcat/site/trunk: docs/migration.html xdocs/migration.xml
2010/12/5 : > Author: kkolinko > Date: Sun Dec 5 13:48:31 2010 > New Revision: 1042350 > > URL: http://svn.apache.org/viewvc?rev=1042350&view=rev > Log: > Note disableURLRewriting and useHttpOnly options changes. > > Modified: > tomcat/site/trunk/docs/migration.html > tomcat/site/trunk/xdocs/migration.xml > migration.html mentions "sessionCookieName" option on in Tomcat 7, but it is not documented in config/context.xml. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1042364 - in /tomcat/jk/trunk: native/common/jk_map.c xdocs/miscellaneous/changelog.xml
Author: rjung
Date: Sun Dec 5 14:46:32 2010
New Revision: 1042364
URL: http://svn.apache.org/viewvc?rev=1042364&view=rev
Log:
BZ 50339: Fix whitespace trimming when parsing attribute
lists.
strcpy() behaviour is undefined when strings
Modified:
tomcat/jk/trunk/native/common/jk_map.c
tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
Modified: tomcat/jk/trunk/native/common/jk_map.c
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_map.c?rev=1042364&r1=1042363&r2=1042364&view=diff
==
--- tomcat/jk/trunk/native/common/jk_map.c (original)
+++ tomcat/jk/trunk/native/common/jk_map.c Sun Dec 5 14:46:32 2010
@@ -629,27 +629,29 @@ static void trim_prp_comment(char *prp)
static size_t trim(char *s)
{
-size_t i;
+size_t first;
+size_t len;
/* check for empty strings */
-if (!(i = strlen(s)))
+if (!(len = strlen(s)))
return 0;
-for (i = i - 1; (i > 0) &&
- isspace((int)((unsigned char)s[i])); i--);
-if ((i > 0) || !isspace((int)((unsigned char)s[i]))) {
- i++;
+for (len = len - 1; (len > 0) &&
+isspace((int)((unsigned char)s[len])); len--);
+if ((len > 0) || !isspace((int)((unsigned char)s[len]))) {
+len++;
}
-s[i] = '\0';
+s[len] = '\0';
+len++;
-for (i = 0; ('\0' != s[i]) &&
- isspace((int)((unsigned char)s[i])); i++);
+for (first = 0; (s[first] != '\0') &&
+isspace((int)((unsigned char)s[first])); first++);
-if (i > 0) {
-strcpy(s, &s[i]);
+if (first > 0) {
+memmove(s, s + first, len - first);
}
-return strlen(s);
+return len;
}
static int map_realloc(jk_map_t *m)
Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=1042364&r1=1042363&r2=1042364&view=diff
==
--- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Sun Dec 5 14:46:32 2010
@@ -51,7 +51,11 @@
50363: IIS: Prevent chunk encoding of empty message
- bodies for 204, 205 and 304 responses. (timw)
+bodies for 204, 205 and 304 responses. (timw)
+
+
+50339: Fix whitespace trimming when parsing attribute
+lists. (rjung)
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50339] mod_jk parsing error if workers.properties contains whitespaces
https://issues.apache.org/bugzilla/show_bug.cgi?id=50339 Rainer Jung changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #4 from Rainer Jung 2010-12-05 09:47:51 EST --- Fixed in r1042364. The patch provided in comment #2 had a bug (superfluous semicolon prevented it from working). Please use the final fix which was applied. Will be part of 1.2.32. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn propchange: r1042364 - svn:log
Author: rjung Revision: 1042364 Modified property: svn:log Modified: svn:log at Sun Dec 5 14:53:19 2010 -- --- svn:log (original) +++ svn:log Sun Dec 5 14:53:19 2010 @@ -2,3 +2,4 @@ BZ 50339: Fix whitespace trimming when p lists. strcpy() behaviour is undefined when strings +overlap. Use memmove() instead. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1042029 - in /tomcat: tc6.0.x/trunk/STATUS.txt trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java trunk/webapps/docs/changelog.xml trunk/webapps/docs/config/list
ok, thanks for having added them for me. Sylvain On 4 déc. 2010, at 06:21, Konstantin Kolinko wrote: > 2010/12/4 : >> Author: slaurent >> Date: Fri Dec 3 22:19:11 2010 >> New Revision: 1042029 >> >> URL: http://svn.apache.org/viewvc?rev=1042029&view=rev >> Log: >> bug 50282 : Load javax.security.auth.login.Configuration with >> JreMemoryLeakPreventionListener to avoid memory leak when stopping a webapp >> that would use JAAS. >> >> Modified: >>tomcat/tc6.0.x/trunk/STATUS.txt >> >> tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java >>tomcat/trunk/webapps/docs/changelog.xml >>tomcat/trunk/webapps/docs/config/listeners.xml >> >> Modified: tomcat/tc6.0.x/trunk/STATUS.txt >> URL: >> http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1042029&r1=1042028&r2=1042029&view=diff >> + >> +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50282 >> + Improve JreMemoryLeakPreventionListener to load >> + javax.security.auth.login.Configuration to avoid redeployment leak. >> + +1: slaurent >> + -1: > > You must include patch URL in your proposal. (What are we voting for?) > Thus, you usually cannot mix update to STATUS and update to trunk in > the same commit. > > Best regards, > Konstantin Kolinko > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1041892 - in /tomcat/trunk: java/org/apache/catalina/connector/ test/org/apache/catalina/connector/ webapps/docs/ webapps/docs/config/
On 03/12/2010 16:07, schu...@apache.org wrote:
> Author: schultz
> Date: Fri Dec 3 16:07:50 2010
> New Revision: 1041892
>
> URL: http://svn.apache.org/viewvc?rev=1041892&view=rev
> Log:
> Fixed bug 48692: Provide option to parse application/x-www-form-urlencoded
> PUT requests
Some minor comments in-line.
> +protected HashSet parseBodyMethodsSet;
This needs to use generics (same for subsequent use later on in the class).
> +public String getParseBodyMethods()
> +{
> +return (this.parseBodyMethods);
> +}
The Tomcat code style is to have brackets at the end of the previous line.
> +if(methodSet.contains("TRACE"))
> +throw new IllegalArgumentException("TRACE method MUST NOT
> include an entity (see RFC 2616 Section 9.6)");
This should use the StringManager for i18n support.
> +public boolean isParseBodyMethod(String method)
This method could (should?) be protected rather then public.
> -if (!getMethod().equalsIgnoreCase("POST"))
> +if(!getConnector().isParseBodyMethod(getMethod()))
The Tomcat code style is to have a space after the if.
>
> +
> +48692: Provide option to parse
> +application/x-www-form-urlencoded PUT requests.
> (schultz)
> +
>
> 8705: org.apache.catalina.SessionListener now
> extends java.util.EventListener. (markt)
Bugs get added to the changelog in ascending numerical order within the
appropriate section.
> +
> + A comma-separated list of HTTP methods for which request
> + bodies will be parsed for request parameters identically
> + to POST. This is useful in RESTful applications that want to
> + support POST-style semantics for PUT requests.
> + Note that any setting other than POST causes Tomcat
> + to behave in a way that violates the servlet specification.
> + The HTTP method TRACE is specifically forbidden here in accordance
> + with the HTTP specification.
> + The default is POST
> +
"violates" is probably too strong a term here. There is some wiggle
room in the language. I would suggest "goes against the intent" is
probably closer.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: svn commit: r1041892 - in /tomcat/trunk: java/org/apache/catalina/connector/ test/org/apache/catalina/connector/ webapps/docs/ webapps/docs/config/
> From: Mark Thomas [mailto:ma...@apache.org]
> Subject: Re: svn commit: r1041892 - in /tomcat/trunk:
> java/org/apache/catalina/connector/test/org/apache/
> catalina/connector/ webapps/docs/ webapps/docs/config/
> > +public String getParseBodyMethods()
> > +{
> > +return (this.parseBodyMethods);
> > +}
> The Tomcat code style is to have brackets at the end of the previous line.
And there's no reason to put parentheses around a return value.
> > +if(methodSet.contains("TRACE"))
> > +throw new IllegalArgumentException("TRACE method MUST NOT
> > include an entity (see RFC 2616 Section 9.6)");
> This should use the StringManager for i18n support.
Also needs a space after the if.
Is there a convention for line length, and how to handle long constant strings
that aren't controlled by the StringManager?
- Chuck
THIS COMMUNICATION MAY CONTAIN CONFIDENTIAL AND/OR OTHERWISE PROPRIETARY
MATERIAL and is thus for use only by the intended recipient. If you received
this in error, please contact the sender and delete the e-mail and its
attachments from all computers.
Re: svn commit: r1042022 - in /tomcat: tc6.0.x/trunk/STATUS.txt trunk/java/org/apache/catalina/session/StandardManager.java trunk/webapps/docs/changelog.xml
On 03/12/2010 22:00, slaur...@apache.org wrote:
> Author: slaurent
> Date: Fri Dec 3 22:00:58 2010
> New Revision: 1042022
>
> URL: http://svn.apache.org/viewvc?rev=1042022&view=rev
Comments in-line.
> +if (sessions.isEmpty()) {
> +log.debug("No persisted sessions to unload");
> +return; // nothing to do
> +}
We haven't been good at this historically for debug messages but we
should really use a StringManager here for i18n support.
>
>
>
> +
> +48973: Avoid creating a SESSIONS.ser file when stopping
> an
> +application if there's no session. Patch provided by Marc Guillemot.
> +(slaurent)
> +
Bugs should be added in ascending numerical order within the relevant
section.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1042029 - in /tomcat: tc6.0.x/trunk/STATUS.txt trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java trunk/webapps/docs/changelog.xml trunk/webapps/docs/config/list
On 03/12/2010 22:19, slaur...@apache.org wrote:
> Author: slaurent
> Date: Fri Dec 3 22:19:11 2010
> New Revision: 1042029
>
> URL: http://svn.apache.org/viewvc?rev=1042029&view=rev
Comments in-line.
> Modified:
> tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java
> URL:
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java?rev=1042029&r1=1042028&r2=1042029&view=diff
> ==
> ---
> tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java
> (original)
> +++
> tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java
> Fri Dec 3 22:19:11 2010
> @@ -107,7 +107,21 @@ public class JreMemoryLeakPreventionList
> this.securityPolicyProtection = securityPolicyProtection;
> }
>
> -/**
> + /**
> + * Protect against the memory leak caused when the first call to
> + * javax.security.auth.login.Configuration is triggered by
> a web
> + * application. This first call populate a static variable with a
> reference
> + * to the context class loader. Defaults to true.
> + */
> + private boolean securityLoginConfigurationProtection = true;
> + public boolean isSecurityLoginConfigurationProtection() {
> + return securityLoginConfigurationProtection;
> + }
> + public void setSecurityLoginConfigurationProtection(boolean
> securityLoginConfigurationProtection) {
> + this.securityLoginConfigurationProtection =
> securityLoginConfigurationProtection;
> + }
Tomcat code style is to limit line length to a maximum of 80 characters.
No all files stick to this but new code generally should.
>
>
>
> +50282: Load
> javax.security.auth.login.Configuration
> +with JreMemoryLeakPreventionListener to avoid memory
> leak
> +when stopping a webapp that would use JAAS.
> +(slaurent)
> +
> +
webapp is usually written in full as web application in the change log.
> + required="false">
> +Enables protection so that usage of the
> +javax.security.auth.login.Configuration class by a web
> +application does not in a memory leak. The first access of this
> class will
> +trigger the initializer that will retain a static reference to the
> context
> +class loader. The protection loads the class with the system
> classloader
> +to ensure that the static initializer is not triggered by web
> application.
> +Defaults to true.
> +
classloader should be written as class loader.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1042393 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Sun Dec 5 18:08:07 2010 New Revision: 1042393 URL: http://svn.apache.org/viewvc?rev=1042393&view=rev Log: Vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1042393&r1=1042392&r2=1042393&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Dec 5 18:08:07 2010 @@ -236,6 +236,7 @@ PATCHES PROPOSED TO BACKPORT: The patch provided by Marc Guillemot works for tc 6 & 7 http://svn.apache.org/viewvc?rev=1042022&view=rev +1: slaurent, kkolinko + -0: markt - See http://markmail.org/message/xp5beek4mdacygsc -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50282 @@ -243,5 +244,6 @@ PATCHES PROPOSED TO BACKPORT: javax.security.auth.login.Configuration to avoid redeployment leak. http://svn.apache.org/viewvc?rev=1042029&view=rev +1: slaurent, kkolinko + -0: markt - See http://markmail.org/message/mnowpijhnxg554t5 -1: \ No newline at end of file - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1041892 - in /tomcat/trunk: java/org/apache/catalina/connector/ test/org/apache/catalina/connector/ webapps/docs/ webapps/docs/config/
On 05/12/2010 17:50, Caldarale, Charles R wrote:
>> From: Mark Thomas [mailto:ma...@apache.org]
>> Subject: Re: svn commit: r1041892 - in /tomcat/trunk:
>> java/org/apache/catalina/connector/test/org/apache/
>> catalina/connector/ webapps/docs/ webapps/docs/config/
>
>>> +public String getParseBodyMethods()
>>> +{
>>> +return (this.parseBodyMethods);
>>> +}
>> The Tomcat code style is to have brackets at the end of the previous line.
>
> And there's no reason to put parentheses around a return value.
>
>>> +if(methodSet.contains("TRACE"))
>>> +throw new IllegalArgumentException("TRACE method MUST NOT
>>> include an entity (see RFC 2616 Section 9.6)");
>> This should use the StringManager for i18n support.
>
> Also needs a space after the if.
>
> Is there a convention for line length,
Max of 80 (not always adhered to).
> and how to handle long constant strings that aren't controlled by the
> StringManager?
Static finals with appropriate visibility depending on if they need to
be re-used.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1042395 - in /tomcat/trunk/java/org/apache: catalina/security/SecurityClassLoad.java jasper/security/SecurityClassLoad.java
Author: kkolinko
Date: Sun Dec 5 18:22:25 2010
New Revision: 1042395
URL: http://svn.apache.org/viewvc?rev=1042395&view=rev
Log:
Mark 'basePackage' as final, to allow string concatenation to be done at
compile time.
Modified:
tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java
tomcat/trunk/java/org/apache/jasper/security/SecurityClassLoad.java
Modified: tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java?rev=1042395&r1=1042394&r2=1042395&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java Sun
Dec 5 18:22:25 2010
@@ -50,7 +50,7 @@ public final class SecurityClassLoad {
private final static void loadCorePackage(ClassLoader loader)
throws Exception {
-String basePackage = "org.apache.catalina.core.";
+final String basePackage = "org.apache.catalina.core.";
loader.loadClass
(basePackage +
"ApplicationContextFacade$1");
@@ -98,7 +98,7 @@ public final class SecurityClassLoad {
private final static void loadLoaderPackage(ClassLoader loader)
throws Exception {
-String basePackage = "org.apache.catalina.loader.";
+final String basePackage = "org.apache.catalina.loader.";
loader.loadClass
(basePackage +
"WebappClassLoader$PrivilegedFindResourceByName");
@@ -107,7 +107,7 @@ public final class SecurityClassLoad {
private final static void loadSessionPackage(ClassLoader loader)
throws Exception {
-String basePackage = "org.apache.catalina.session.";
+final String basePackage = "org.apache.catalina.session.";
loader.loadClass
(basePackage + "StandardSession");
loader.loadClass
@@ -121,7 +121,7 @@ public final class SecurityClassLoad {
private final static void loadUtilPackage(ClassLoader loader)
throws Exception {
-String basePackage = "org.apache.catalina.util.";
+final String basePackage = "org.apache.catalina.util.";
loader.loadClass(basePackage + "Enumerator");
loader.loadClass(basePackage + "ParameterMap");
}
@@ -129,7 +129,7 @@ public final class SecurityClassLoad {
private final static void loadCoyotePackage(ClassLoader loader)
throws Exception {
-String basePackage = "org.apache.coyote.";
+final String basePackage = "org.apache.coyote.";
loader.loadClass(basePackage + "http11.AbstractOutputBuffer$1");
}
@@ -142,7 +142,7 @@ public final class SecurityClassLoad {
private final static void loadConnectorPackage(ClassLoader loader)
throws Exception {
-String basePackage = "org.apache.catalina.connector.";
+final String basePackage = "org.apache.catalina.connector.";
loader.loadClass
(basePackage +
"RequestFacade$GetAttributePrivilegedAction");
@@ -225,7 +225,7 @@ public final class SecurityClassLoad {
private final static void loadTomcatPackage(ClassLoader loader)
throws Exception {
-String basePackage = "org.apache.tomcat.";
+final String basePackage = "org.apache.tomcat.";
// Make sure system property is read at this point
Class clazz = loader.loadClass(
basePackage + "util.http.FastHttpDateFormat");
Modified: tomcat/trunk/java/org/apache/jasper/security/SecurityClassLoad.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/security/SecurityClassLoad.java?rev=1042395&r1=1042394&r2=1042395&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/security/SecurityClassLoad.java
(original)
+++ tomcat/trunk/java/org/apache/jasper/security/SecurityClassLoad.java Sun Dec
5 18:22:25 2010
@@ -37,7 +37,7 @@ public final class SecurityClassLoad {
return;
}
-String basePackage = "org.apache.jasper.";
+final String basePackage = "org.apache.jasper.";
try {
loader.loadClass( basePackage +
"runtime.JspFactoryImpl$PrivilegedGetPageContext");
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1041892 - in /tomcat/trunk: java/org/apache/catalina/connector/ test/org/apache/catalina/connector/ webapps/docs/ webapps/docs/config/
2010/12/5 Caldarale, Charles R : > Is there a convention for line length, The only strict rule is to use spaces, and never tabs. The rest is -- see how the file was formatted before. I, personally, use "Java Conventions" with indent setting changed to be spaces only, and let IDE format just the selected block of code. I suspect that other do similar things as well. It is preferred that the line does not exceed 80 chars. > and how to handle long constant strings that aren't controlled by the > StringManager? Long strings could be splitted in parts by '+' (they will be concatenated at compile time anyway), thought it would make harder to search for them. Usually there is no need to bother. One example are string constants in HTMLManagerServlet. Another is SecurityClassLoad. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1041892 - in /tomcat/trunk: java/org/apache/catalina/connector/ test/org/apache/catalina/connector/ webapps/docs/ webapps/docs/config/
Mark,
Thanks for the feedback. Is is better form to back-out these changes and
apply a new patch, or to simply make these changes to trunk and commit them?
Thanks,
-chris
On 12/5/2010 12:31 PM, Mark Thomas wrote:
> On 03/12/2010 16:07, schu...@apache.org wrote:
>> Author: schultz
>> Date: Fri Dec 3 16:07:50 2010
>> New Revision: 1041892
>>
>> URL: http://svn.apache.org/viewvc?rev=1041892&view=rev
>> Log:
>> Fixed bug 48692: Provide option to parse application/x-www-form-urlencoded
>> PUT requests
>
> Some minor comments in-line.
>
>> +protected HashSet parseBodyMethodsSet;
> This needs to use generics (same for subsequent use later on in the class).
>
>> +public String getParseBodyMethods()
>> +{
>> +return (this.parseBodyMethods);
>> +}
> The Tomcat code style is to have brackets at the end of the previous line.
>
>> +if(methodSet.contains("TRACE"))
>> +throw new IllegalArgumentException("TRACE method MUST NOT
>> include an entity (see RFC 2616 Section 9.6)");
> This should use the StringManager for i18n support.
>
>> +public boolean isParseBodyMethod(String method)
> This method could (should?) be protected rather then public.
>
>> -if (!getMethod().equalsIgnoreCase("POST"))
>> +if(!getConnector().isParseBodyMethod(getMethod()))
> The Tomcat code style is to have a space after the if.
>
>>
>> +
>> +48692: Provide option to parse
>> +application/x-www-form-urlencoded PUT requests.
>> (schultz)
>> +
>>
>> 8705: org.apache.catalina.SessionListener
>> now
>> extends java.util.EventListener. (markt)
> Bugs get added to the changelog in ascending numerical order within the
> appropriate section.
>
>> +
>> + A comma-separated list of HTTP methods for which request
>> + bodies will be parsed for request parameters identically
>> + to POST. This is useful in RESTful applications that want to
>> + support POST-style semantics for PUT requests.
>> + Note that any setting other than POST causes Tomcat
>> + to behave in a way that violates the servlet specification.
>> + The HTTP method TRACE is specifically forbidden here in accordance
>> + with the HTTP specification.
>> + The default is POST
>> +
> "violates" is probably too strong a term here. There is some wiggle
> room in the language. I would suggest "goes against the intent" is
> probably closer.
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
signature.asc
Description: OpenPGP digital signature
Re: svn commit: r1041892 - in /tomcat/trunk: java/org/apache/catalina/connector/ test/org/apache/catalina/connector/ webapps/docs/ webapps/docs/config/
On 05/12/2010 19:12, Christopher Schultz wrote: > Mark, > > Thanks for the feedback. Is is better form to back-out these changes and > apply a new patch, or to simply make these changes to trunk and commit them? Just committing the fixes should be fine. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1042413 - /tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java
Author: markt
Date: Sun Dec 5 19:16:07 2010
New Revision: 1042413
URL: http://svn.apache.org/viewvc?rev=1042413&view=rev
Log:
Address some review comments:
1. Avoid possible NPEs by using a local variable for the newDefaultAccessLog
2. PropertyChangeListener should be added to the Engine
3. Add the listener when the Noop logger is used so changes can be detected
that could cause a different logger to be used.
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java?rev=1042413&r1=1042412&r2=1042413&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java Sun Dec 5
19:16:07 2010
@@ -321,41 +321,54 @@ public class StandardEngine extends Cont
}
if (!logged && useDefault) {
-if (defaultAccessLog == null) {
+AccessLog newDefaultAccessLog = defaultAccessLog;
+if (newDefaultAccessLog == null) {
// If we reached this point, this Engine can't have an
AccessLog
// Look in the defaultHost
Host host = (Host) findChild(getDefaultHost());
+Context context = null;
if (host != null && host.getState().isAvailable()) {
-defaultAccessLog = host.getAccessLog();
+newDefaultAccessLog = host.getAccessLog();
-if (defaultAccessLog != null) {
+if (newDefaultAccessLog != null) {
AccessLogListener l = new AccessLogListener(this);
-host.addPropertyChangeListener(l);
+this.addPropertyChangeListener(l);
host.addContainerListener(l);
host.addLifecycleListener(l);
} else {
// Try the ROOT context of default host
-Context context = (Context) host.findChild("");
+context = (Context) host.findChild("");
if (context != null &&
context.getState().isAvailable()) {
-defaultAccessLog = context.getAccessLog();
+newDefaultAccessLog = context.getAccessLog();
-if (defaultAccessLog != null) {
+if (newDefaultAccessLog != null) {
AccessLogListener l =
new AccessLogListener(this);
-context.addPropertyChangeListener(l);
+this.addPropertyChangeListener(l);
context.addLifecycleListener(l);
}
}
}
}
-if (defaultAccessLog == null) {
-defaultAccessLog = new NoopAccessLog();
+if (newDefaultAccessLog == null) {
+newDefaultAccessLog = new NoopAccessLog();
+AccessLogListener l = new AccessLogListener(this);
+this.addPropertyChangeListener(l);
+if (host != null) {
+host.addContainerListener(l);
+host.addLifecycleListener(l);
+}
+if (context != null) {
+context.addLifecycleListener(l);
+}
+
}
+defaultAccessLog = newDefaultAccessLog;
}
-defaultAccessLog.log(request, response, time);
+newDefaultAccessLog.log(request, response, time);
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1042421 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Sun Dec 5 19:22:19 2010 New Revision: 1042421 URL: http://svn.apache.org/viewvc?rev=1042421&view=rev Log: Update patch. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1042421&r1=1042420&r2=1042421&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Dec 5 19:22:19 2010 @@ -204,32 +204,40 @@ PATCHES PROPOSED TO BACKPORT: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50201 Handle ROOT webapp redployment, host start/stop etc for default access log - http://people.apache.org/~markt/patches/2010-12-02-bug50201-tc6.patch + http://people.apache.org/~markt/patches/2010-12-05-bug50201-tc6.patch +1: markt -1: kkolinko: 1) A typo: in "checkHost = ((ContainerBase) context).started;" - should be s/checkHost/checkContext/ + should be s/checkHost/checkContext/ + markt: Fixed in updated patch above 2) Possible NPEs in StandardEngine.logAccess(). With the old code - the defaultAccessLog field can be checked once, and we know that - if it is already not-null it will never become null. That is no - longer the case and subsequent accesses to that volatile field can result in NPE. - One needs to keep a local copy of that field. + the defaultAccessLog field can be checked once, and we know that + if it is already not-null it will never become null. That is no + longer the case and subsequent accesses to that volatile field can result + in NPE. One needs to keep a local copy of that field. + markt: Fixed in updated patch above 3) addPropertyChangeListener(l). If we are only interested in "defaultHost" - property change, shouldn't we add the listener to StandardEngine? - I think that there is no need to add it to Context or Host (and - are they notified about that change at all?). + property change, shouldn't we add the listener to StandardEngine? + I think that there is no need to add it to Context or Host (and + are they notified about that change at all?). + markt: Fixed in updated patch above 4) Initializing defaultAccessLog may be performed by several threads - concurrently. That may result in several listener instances being - added. (It won't break their operation, but it is just a waste). + concurrently. That may result in several listener instances being + added. (It won't break their operation, but it is just a waste). + markt: Agreed it is a waste. Can't do much about it without lots and lots +of complexity. 5) in AccessLogListener.containerEvent(): Context context = (Context) event.getData(); - Maybe it'd be better to add an instanceof check before that cast. + Maybe it'd be better to add an instanceof check before that cast. + markt: Not worth it. That object has to be an instance of Context else all +sorts of stuff would break way before the code got this far. 6) In the proposed patch the Listener is only installed iff there - is an access log there. It should be installed unconditionally. - E.g., if Tomcat starts without access logs, NoopAccessLog is created. - As there are no listeners, any change to the configuration - (e.g. redeploying the ROOT webapp) will pass unnoticed - and won't reenable the access log. + is an access log there. It should be installed unconditionally. + E.g., if Tomcat starts without access logs, NoopAccessLog is created. + As there are no listeners, any change to the configuration + (e.g. redeploying the ROOT webapp) will pass unnoticed + and won't reenable the access log. + markt: Fixed in updated patch above * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48973 Avoid creating file SESSIONS.ser if there's no session. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1042427 - in /tomcat/trunk: java/org/apache/catalina/session/PersistentManagerBase.java webapps/docs/changelog.xml
Author: markt
Date: Sun Dec 5 19:32:00 2010
New Revision: 1042427
URL: http://svn.apache.org/viewvc?rev=1042427&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50411
Ensure sessions are removed from the Store associated with a PersistentManager.
Modified:
tomcat/trunk/java/org/apache/catalina/session/PersistentManagerBase.java
tomcat/trunk/webapps/docs/changelog.xml
Modified:
tomcat/trunk/java/org/apache/catalina/session/PersistentManagerBase.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/session/PersistentManagerBase.java?rev=1042427&r1=1042426&r2=1042427&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/session/PersistentManagerBase.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/session/PersistentManagerBase.java
Sun Dec 5 19:32:00 2010
@@ -584,9 +584,9 @@ public abstract class PersistentManagerB
* @param session Session to be removed
*/
@Override
-public void remove(Session session) {
+public void remove(Session session, boolean update) {
-super.remove (session);
+super.remove (session, update);
if (store != null){
removeSession(session.getIdInternal());
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1042427&r1=1042426&r2=1042427&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Sun Dec 5 19:32:00 2010
@@ -111,6 +111,11 @@
Code clean-up. Replace use of inefficient constructors with more
efficient alternatives. (markt)
+
+50411: Ensure sessions are removed from the
+Store associated with a PersistentManager.
+(markt)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50411] invalid sessions not removed from PersistenManager store
https://issues.apache.org/bugzilla/show_bug.cgi?id=50411 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Mark Thomas 2010-12-05 14:32:20 EST --- Thanks for the report. This has been fixed in trunk and will be included in 7.0.6 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50411] invalid sessions not removed from PersistenManager store
https://issues.apache.org/bugzilla/show_bug.cgi?id=50411 Marco changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #2 from Marco 2010-12-05 15:15:09 EST --- Hi Mark, the bug needs a second change. In PersistentManagerBase.swapOut(...) the method call super.remove(session) must change to super.remove(session, false). At the moment a passivate session is not stored. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [ANN] New Tomcat committer: Sylvain Laurent (slaurent)
Welcome Sylvain. Le 2 déc. 2010 à 16:47, Mark Thomas a écrit : > On behalf of the Tomcat committers I am pleased to announce that Sylvain > Laurent (slaurent) has been voted in as a new Tomcat committer. > > Please join me in welcoming him. > > Mark > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Automated FindBugs Reportg
We should just ask Sonar Team. I know them, would you like me to contact them ? Tomcat 5.5 and 7 ? Le 2 déc. 2010 à 23:31, Mark Thomas a écrit : > On 02/12/2010 22:07, Henri Gomez wrote: >> FindBugs, Checkstyle and many more QA tests are allready provided by >> Sonar team for Tomcat :-) >> >> http://nemo.sonarsource.org/dashboard/index/50544 > > Nice. It looks liek that is for Tomcat 6.0.x. How do we get 7.0.x and > 5.5.x added? > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1042447 - /tomcat/trunk/webapps/docs/config/listeners.xml
Author: slaurent Date: Sun Dec 5 21:06:25 2010 New Revision: 1042447 URL: http://svn.apache.org/viewvc?rev=1042447&view=rev Log: bug 50282 / fixed some typos in documentation Modified: tomcat/trunk/webapps/docs/config/listeners.xml Modified: tomcat/trunk/webapps/docs/config/listeners.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/listeners.xml?rev=1042447&r1=1042446&r2=1042447&view=diff == --- tomcat/trunk/webapps/docs/config/listeners.xml (original) +++ tomcat/trunk/webapps/docs/config/listeners.xml Sun Dec 5 21:06:25 2010 @@ -273,11 +273,11 @@ service:jmx:rmi://:10002 Enables protection so that usage of the javax.security.auth.login.Configuration class by a web -application does not in a memory leak. The first access of this class will -trigger the initializer that will retain a static reference to the context -class loader. The protection loads the class with the system classloader -to ensure that the static initializer is not triggered by web application. -Defaults to true. +application does not provoke a memory leak. The first access of this +class will trigger the initializer that will retain a static reference +to the context class loader. The protection loads the class with the +system class loader to ensure that the static initializer is not +triggered by web application. Defaults to true. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1042448 - /tomcat/trunk/webapps/docs/changelog.xml
Author: slaurent Date: Sun Dec 5 21:07:49 2010 New Revision: 1042448 URL: http://svn.apache.org/viewvc?rev=1042448&view=rev Log: sort entries by ascending BZ number Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1042448&r1=1042447&r2=1042448&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Sun Dec 5 21:07:49 2010 @@ -42,31 +42,25 @@ - -50282: Load javax.security.auth.login.Configuration -with JreMemoryLeakPreventionListener to avoid memory leak -when stopping a webapp that would use JAAS. -(slaurent) - - -48973: Avoid creating a SESSIONS.ser file when stopping an -application if there's no session. Patch provided by Marc Guillemot. -(slaurent) - - -48692: Provide option to parse -application/x-www-form-urlencoded PUT requests. (schultz) - 8705: org.apache.catalina.SessionListener now extends java.util.EventListener. (markt) + +48692: Provide option to parse +application/x-www-form-urlencoded PUT requests. (schultz) + 48837: Extend thread local memory leak detection to include classes loaded by subordinate class loaders to the web application's class loader such as the Jasper class loader. Based on a patch by Sylvain Laurent. (markt) + +48973: Avoid creating a SESSIONS.ser file when stopping an +application if there's no session. Patch provided by Marc Guillemot. +(slaurent) + 49650: Remove unnecessary entries package.access property defined in catalina.properties. Patch provided by Owen Farrell. (markt) @@ -81,6 +75,12 @@ options to control the SecureRandom instances used to generate session IDs. (markt) + +50282: Load javax.security.auth.login.Configuration +with JreMemoryLeakPreventionListener to avoid memory leak +when stopping a web application that would use JAAS. +(slaurent) + 50351: Fix the regression that broke BeanFactory resources caused by the previous fix for 50159. (markt) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1042022 - in /tomcat: tc6.0.x/trunk/STATUS.txt trunk/java/org/apache/catalina/session/StandardManager.java trunk/webapps/docs/changelog.xml
On 5 déc. 2010, at 18:58, Mark Thomas wrote: > We haven't been good at this historically for debug messages but we > should really use a StringManager here for i18n support. Though i can understand that i18n is useful for information and error message, is it really useful for debug level messages ?? > Bugs should be added in ascending numerical order within the relevant > section. Fixed - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1042452 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java
Author: slaurent
Date: Sun Dec 5 21:26:22 2010
New Revision: 1042452
URL: http://svn.apache.org/viewvc?rev=1042452&view=rev
Log:
bug 50282 / fixed line length
Modified:
tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java
Modified:
tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java?rev=1042452&r1=1042451&r2=1042452&view=diff
==
---
tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java
(original)
+++
tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java
Sun Dec 5 21:26:22 2010
@@ -107,19 +107,20 @@ public class JreMemoryLeakPreventionList
this.securityPolicyProtection = securityPolicyProtection;
}
- /**
- * Protect against the memory leak caused when the first call to
- * javax.security.auth.login.Configuration is triggered by a
web
- * application. This first call populate a static variable with a
reference
- * to the context class loader. Defaults to true.
- */
- private boolean securityLoginConfigurationProtection = true;
- public boolean isSecurityLoginConfigurationProtection() {
- return securityLoginConfigurationProtection;
- }
- public void setSecurityLoginConfigurationProtection(boolean
securityLoginConfigurationProtection) {
- this.securityLoginConfigurationProtection =
securityLoginConfigurationProtection;
- }
+/**
+ * Protects against the memory leak caused when the first call to
+ * javax.security.auth.login.Configuration is triggered by a
+ * web application. This first call populate a static variable with a
+ * reference to the context class loader. Defaults to true.
+ */
+private boolean securityLoginConfigurationProtection = true;
+public boolean isSecurityLoginConfigurationProtection() {
+return securityLoginConfigurationProtection;
+}
+public void setSecurityLoginConfigurationProtection(
+boolean securityLoginConfigurationProtection) {
+this.securityLoginConfigurationProtection =
securityLoginConfigurationProtection;
+}
/**
* Protect against the memory leak, when the initialization of the
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Automated FindBugs Reportg
On 05/12/2010 20:50, Henri Gomez wrote: > We should just ask Sonar Team. > > I know them, would you like me to contact them ? > > Tomcat 5.5 and 7 ? That would be great. I'd request: http://svn.apache.org/repos/asf/tomcat/tc5.5.x/trunk/ http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/ http://svn.apache.org/repos/asf/tomcat/trunk/ with http://svn.apache.org/repos/asf/tomcat/tc7.0.x/trunk/ to be added once created. Cheers, Mark > > Le 2 déc. 2010 à 23:31, Mark Thomas a écrit : > >> On 02/12/2010 22:07, Henri Gomez wrote: >>> FindBugs, Checkstyle and many more QA tests are allready provided by >>> Sonar team for Tomcat :-) >>> >>> http://nemo.sonarsource.org/dashboard/index/50544 >> >> Nice. It looks liek that is for Tomcat 6.0.x. How do we get 7.0.x and >> 5.5.x added? >> >> Mark >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1042022 - in /tomcat: tc6.0.x/trunk/STATUS.txt trunk/java/org/apache/catalina/session/StandardManager.java trunk/webapps/docs/changelog.xml
On 05/12/2010 21:18, Sylvain Laurent wrote: > > On 5 déc. 2010, at 18:58, Mark Thomas wrote: > >> We haven't been good at this historically for debug messages but we >> should really use a StringManager here for i18n support. > > Though i can understand that i18n is useful for information and error > message, is it really useful for debug level messages ?? Less useful but there is no reason to suppose folks who read debug messages understand English any better than folks that read info or error messages. Some debug messages do use StringManagers, some don't. I just think new stuff should although there are plenty of examples where it doesn't. I'm not massively bothered if it doesn't. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1042480 - /tomcat/trunk/java/org/apache/catalina/session/PersistentManagerBase.java
Author: markt Date: Sun Dec 5 22:50:56 2010 New Revision: 1042480 URL: http://svn.apache.org/viewvc?rev=1042480&view=rev Log: Additional fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=50411 Modified: tomcat/trunk/java/org/apache/catalina/session/PersistentManagerBase.java Modified: tomcat/trunk/java/org/apache/catalina/session/PersistentManagerBase.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/session/PersistentManagerBase.java?rev=1042480&r1=1042479&r2=1042480&view=diff == --- tomcat/trunk/java/org/apache/catalina/session/PersistentManagerBase.java (original) +++ tomcat/trunk/java/org/apache/catalina/session/PersistentManagerBase.java Sun Dec 5 22:50:56 2010 @@ -771,7 +771,7 @@ public abstract class PersistentManagerB ((StandardSession)session).passivate(); writeSession(session); -super.remove(session); +super.remove(session, true); session.recycle(); } - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50411] invalid sessions not removed from PersistenManager store
https://issues.apache.org/bugzilla/show_bug.cgi?id=50411 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #3 from Mark Thomas 2010-12-05 17:51:06 EST --- Fixed. Also will be in 7.0.6. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1042482 - in /tomcat/trunk: ./ conf/ java/org/apache/catalina/core/ java/org/apache/catalina/loader/ java/org/apache/tomcat/util/threads/ res/confinstall/ webapps/ webapps/docs/ webapps/d
Author: slaurent Date: Sun Dec 5 22:54:05 2010 New Revision: 1042482 URL: http://svn.apache.org/viewvc?rev=1042482&view=rev Log: bug 49159: Improve ThreadLocal memory leak clean-up https://issues.apache.org/bugzilla/show_bug.cgi?id=49159 Renewing threads of the pool when a webapp is stopped Added: tomcat/trunk/java/org/apache/catalina/core/ThreadLocalLeakPreventionListener.java tomcat/trunk/java/org/apache/tomcat/util/threads/Constants.java tomcat/trunk/java/org/apache/tomcat/util/threads/LocalStrings.properties tomcat/trunk/java/org/apache/tomcat/util/threads/TaskThread.java Modified: tomcat/trunk/ (props changed) tomcat/trunk/conf/ (props changed) tomcat/trunk/conf/server.xml tomcat/trunk/java/org/apache/catalina/core/StandardContext.java tomcat/trunk/java/org/apache/catalina/core/StandardThreadExecutor.java tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml tomcat/trunk/java/org/apache/catalina/loader/LocalStrings.properties tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java tomcat/trunk/java/org/apache/catalina/loader/WebappLoader.java tomcat/trunk/java/org/apache/tomcat/util/threads/TaskQueue.java tomcat/trunk/java/org/apache/tomcat/util/threads/TaskThreadFactory.java tomcat/trunk/java/org/apache/tomcat/util/threads/ThreadPoolExecutor.java tomcat/trunk/res/confinstall/server_1.xml tomcat/trunk/webapps/ (props changed) tomcat/trunk/webapps/docs/changelog.xml tomcat/trunk/webapps/docs/config/context.xml tomcat/trunk/webapps/docs/config/executor.xml Propchange: tomcat/trunk/ -- --- svn:ignore (original) +++ svn:ignore Sun Dec 5 22:54:05 2010 @@ -1,3 +1,9 @@ -.* +.settings +.classpath +.project output build.properties +.checkstyle +.pmd +work +logs Propchange: tomcat/trunk/conf/ -- --- svn:ignore (added) +++ svn:ignore Sun Dec 5 22:54:05 2010 @@ -0,0 +1 @@ +Catalina Modified: tomcat/trunk/conf/server.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/conf/server.xml?rev=1042482&r1=1042481&r2=1042482&view=diff == --- tomcat/trunk/conf/server.xml (original) +++ tomcat/trunk/conf/server.xml Sun Dec 5 22:54:05 2010 @@ -28,6 +28,7 @@ + +
DO NOT REPLY [Bug 49159] Improve ThreadLocal memory leak clean-up
https://issues.apache.org/bugzilla/show_bug.cgi?id=49159 --- Comment #16 from Sylvain Laurent 2010-12-05 18:00:05 EST --- Applied the patch to renew threads of the pool on trunk, will be available for 7.0.6. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1042482 - in /tomcat/trunk: ./ conf/ java/org/apache/catalina/core/ java/org/apache/catalina/loader/ java/org/apache/tomcat/util/threads/ res/confinstall/ webapps/ webapps/docs/ webap
On 05/12/2010 22:54, slaur...@apache.org wrote:
> Author: slaurent
> Date: Sun Dec 5 22:54:05 2010
> New Revision: 1042482
>
> URL: http://svn.apache.org/viewvc?rev=1042482&view=rev
General comments:
Numerous new lines with length > 80 chars.
ASF policy is to strongly discourage author tags.
Your svn client should be configured to set svn:eol-style native on new
text files.
I did wonder about the fixing over time nature of this approach vs. the
immediate fixing of the previous approach and whether or not we should
give users the option of both. On reflection I think providing both will
add a fair amount of complexity and given that this is trying to fix
what is essentially an application bug then I think just having one
approach is fine and this is a better approach than the previous
implementation.
Specific comments in-line.
> Modified:
> tomcat/trunk/ (props changed)
> tomcat/trunk/conf/ (props changed)
> tomcat/trunk/webapps/(props changed)
-1 to all these changes.
a) This is not a Tomcat instance for running. That is created in output.
b) It reverts a useful change I made earlier today
> Added:
> tomcat/trunk/java/org/apache/catalina/core/ThreadLocalLeakPreventionListener.java
> +private static final Log log = LogFactory
> +.getLog(ThreadLocalLeakPreventionListener.class);
That is an odd place for a line-break that I find hard to read. I find
either of the following easier to read:
private static final Log log =
LogFactory.getLog(ThreadLocalLeakPreventionListener.class);
private static final Log log = LogFactory.getLog(
ThreadLocalLeakPreventionListener.class);
There are multiple instances of this throughout the commit.
> +public void lifecycleEvent(LifecycleEvent event) {
> +try {
> +Lifecycle lifecycle = event.getLifecycle();
> +if (Lifecycle.AFTER_START_EVENT.equals(event.getType())
> +&& lifecycle instanceof Server) {
With the operator on the new line it is easy to miss what is going on.
Generally, Tomcat style is to put the operator on the first line. e.g.
if (Lifecycle.AFTER_START_EVENT.equals(event.getType()) &&
lifecycle instanceof Server) {
There are multiple instances of this throughout the commit.
> +} catch (Exception e) {
> +log.error("Exception processing event " + event, e);
> +}
Error messages really should be using a StringManager.
There are multiple instances of this throughout the commit.
> +protected void processContainerRemoveChild(Container parent, Container
> child) {
> +
> +if (log.isDebugEnabled())
> +log.debug("Process removeChild[parent=" + parent + ",child="
> ++ child + "]");
> +
> +try {
> +if (child instanceof Context) {
> +Context context = (Context) child;
> +context.removeLifecycleListener(this);
> +} else if (child instanceof Host) {
> +Host host = (Host) child;
> +host.removeContainerListener(this);
> +} else if (child instanceof Engine) {
> +Engine engine = (Engine) child;
> +engine.removeContainerListener(this);
> +}
Why all this? Just use:
child.removeLifecycleListener(this);
Does the fact the Container implements Lifecycle simplify any of the
other code here?
> Modified: tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java
> -private void clearThreadLocalMap(Object map, Field internalTableField)
> +private void checkThreadLocalMapForLeaks(Object map, Field
> internalTableField)
> throws NoSuchMethodException, IllegalAccessException,
> NoSuchFieldException, InvocationTargetException {
Not all of those Exceptions are required after this commit.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1042494 - /tomcat/trunk/webapps/docs/config/listeners.xml
Author: markt Date: Mon Dec 6 00:15:45 2010 New Revision: 1042494 URL: http://svn.apache.org/viewvc?rev=1042494&view=rev Log: Fix typo Modified: tomcat/trunk/webapps/docs/config/listeners.xml Modified: tomcat/trunk/webapps/docs/config/listeners.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/listeners.xml?rev=1042494&r1=1042493&r2=1042494&view=diff == --- tomcat/trunk/webapps/docs/config/listeners.xml (original) +++ tomcat/trunk/webapps/docs/config/listeners.xml Mon Dec 6 00:15:45 2010 @@ -277,7 +277,7 @@ service:jmx:rmi://:10002 class will trigger the initializer that will retain a static reference to the context class loader. The protection loads the class with the system class loader to ensure that the static initializer is not -triggered by web application. Defaults to true. +triggered by a web application. Defaults to true. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1042495 - /tomcat/trunk/webapps/docs/changelog.xml
Author: markt Date: Mon Dec 6 00:17:43 2010 New Revision: 1042495 URL: http://svn.apache.org/viewvc?rev=1042495&view=rev Log: Line-length Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1042495&r1=1042494&r2=1042495&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Mon Dec 6 00:17:43 2010 @@ -38,7 +38,9 @@ - + @@ -80,10 +82,10 @@ generate session IDs. (markt) -50282: Load javax.security.auth.login.Configuration -with JreMemoryLeakPreventionListener to avoid memory leak -when stopping a web application that would use JAAS. -(slaurent) +50282: Load +javax.security.auth.login.Configuration with +JreMemoryLeakPreventionListener to avoid memory leak when +stopping a web application that would use JAAS. (slaurent) 50351: Fix the regression that broke BeanFactory resources - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50414] New: tlv package cause another split package issue in impl and jstlel bundles
https://issues.apache.org/bugzilla/show_bug.cgi?id=50414 Summary: tlv package cause another split package issue in impl and jstlel bundles Product: Taglibs Version: 1.2.0 Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Standard Taglib AssignedTo: dev@tomcat.apache.org ReportedBy: rwo...@gmail.com I found another split package issue: impl\src\main\java\org\apache\taglibs\standard\tlv jstlel\src\main\java\org\apache\taglibs\standard\tlv Will try provide a patch.. -Rex -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50414] tlv package cause another split package issue in impl and jstlel bundles
https://issues.apache.org/bugzilla/show_bug.cgi?id=50414 --- Comment #1 from Rex Wang 2010-12-05 22:54:44 EST --- Created an attachment (id=26376) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26376) patch for jstlel -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50414] tlv package cause another split package issue in impl and jstlel bundles
https://issues.apache.org/bugzilla/show_bug.cgi?id=50414 --- Comment #2 from Rex Wang 2010-12-06 00:37:10 EST --- btw, should we remove the blank folder "\impl\src\main\resources\org\apache\taglibs\standard\lang" ? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1042524 - /tomcat/taglibs/standard/trunk/impl/src/main/resources/org/apache/taglibs/standard/lang/
Author: jboynes Date: Mon Dec 6 06:31:18 2010 New Revision: 1042524 URL: http://svn.apache.org/viewvc?rev=1042524&view=rev Log: remove empty directory Removed: tomcat/taglibs/standard/trunk/impl/src/main/resources/org/apache/taglibs/standard/lang/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Automated FindBugs Reportg
I'll ask them :-) Le 5 déc. 2010 à 22:57, Mark Thomas a écrit : > On 05/12/2010 20:50, Henri Gomez wrote: >> We should just ask Sonar Team. >> >> I know them, would you like me to contact them ? >> >> Tomcat 5.5 and 7 ? > > That would be great. > > I'd request: > http://svn.apache.org/repos/asf/tomcat/tc5.5.x/trunk/ > http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/ > http://svn.apache.org/repos/asf/tomcat/trunk/ > > with http://svn.apache.org/repos/asf/tomcat/tc7.0.x/trunk/ to be added > once created. > > Cheers, > > Mark > > >> >> Le 2 déc. 2010 à 23:31, Mark Thomas a écrit : >> >>> On 02/12/2010 22:07, Henri Gomez wrote: FindBugs, Checkstyle and many more QA tests are allready provided by Sonar team for Tomcat :-) http://nemo.sonarsource.org/dashboard/index/50544 >>> >>> Nice. It looks liek that is for Tomcat 6.0.x. How do we get 7.0.x and >>> 5.5.x added? >>> >>> Mark >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >>> For additional commands, e-mail: dev-h...@tomcat.apache.org >>> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "PoweredBy" by Oleksandr
Dear Wiki user,
You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change
notification.
The "PoweredBy" page has been changed by Oleksandr.
http://wiki.apache.org/tomcat/PoweredBy?action=diff&rev1=275&rev2=276
--
=== NEXCESS.NET ===
{{http://nexcess.net/banners/nexcess_468x60_1.gif|http://nexcess.net/banners/nexcess_468x60_1.gif|class="external_image
fkromjtocnoxhitqgdwz fkromjtocnoxhitqgdwz"}}
[[http://www.nexcess.net|NEXCESS.NET]] is now supporting JSP/Servlets using
Tomcat.
+
+ === Olvius.com CMS Website Builder ===
+ {{http://www.olvius.com/sites/public/olvius.jpg}}
[[http://www.olvius.com|olvius.com]] CMS Website Builder with powerful HTML/CSS
editors provides user-maintained hosting using Tomcat 6 / CentOS 5.
=== Opticalhost ===
[[http://www.opticalhost.com.br/|Opticalhost - Soluçoes para o seu site]]
provides webhosting with JSP/Servlets support using Tomcat.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "PoweredBy" by Oleksandr
Dear Wiki user,
You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change
notification.
The "PoweredBy" page has been changed by Oleksandr.
http://wiki.apache.org/tomcat/PoweredBy?action=diff&rev1=276&rev2=277
--
{{http://www.become.com/images/become_home.gif}}
[[http://Become.com|Become.com]] - The statistics servers for this
massively-scaled shopping web crawler:
[[http://java.sun.com/developer/technicalArticles/WebServices/become/|Read
About It]]
=== BergenJerseyForeclosures.com ===
-
{{http://www.bergenjerseyforeclosures.com/templates/default/images/BergenJerseyForeclosures.png}}
[[http://www.bergenjerseyforeclosures.com|Bergen Jersey Foreclosures]] - The
most popular site for free [[http://www.bergenjerseyforeclosures.com|NJ
foreclosure]] listings has been powered by Tomcat for years since it was first
deployed.
+
{{http://www.bergenjerseyforeclosures.com/templates/default/images/BergenJerseyForeclosures.png}}
[[http://www.bergenjerseyforeclosures.com|Bergen Jersey Foreclosures]] - The
most popular site for free [[http://www.bergenjerseyforeclosures.com|NJ
foreclosure]] listings has been powered by Tomcat for years since it was first
deployed.
=== BlogScope.net ===
[[http://www.blogscope.net/|{{http://www.blogscope.net/images/blogscope-white-logo.png|http://www.blogscope.net/}}]]
[[http://www.blogscope.net/|BlogScope]] is a search and analysis tool for
blogosphere. Developed as research project at U of Toronto, built upon many
open source applications including Tomcat.
[[http://www.blogscope.net/about/|Read more about it]].
@@ -404, +404 @@
{{http://javaservlethosting.com/images/javaservlethosting.com_logo_for_tomcat.apache.org.png}}
[[http://www.javaservlethosting.com|JavaServletHosting]] - You'll find
professional-grade Java Hosting at very affordable prices. For more than 15
years, they've been a leader in commercial web hosting and n-tier application
development. They are one of the original three hosting providers featured on
this page back in 2005.
=== Java Hoster.com ===
- {{http://www.java-hoster.com/pictures/icon/logo.png}}
[[http://www.java-hoster.com| Java Hoster]] - Hosting provider fully dedicated
to Java/J2EE hosting located in France with support to Tomcat 6.0.
+ {{http://www.java-hoster.com/pictures/icon/logo.png}}
[[http://www.java-hoster.com|Java Hoster]] - Hosting provider fully dedicated
to Java/J2EE hosting located in France with support to Tomcat 6.0.
=== KingHost ===
{{http://www.kinghost.com.br/img/logo_kinghost_painel.jpg}}
[[http://www.kinghost.com.br/|KingHost - Hospedagem de Sites]] provides
webhosting with JSP/Servlets support using Tomcat 5.0, 5.5 and 6.0.
@@ -431, +431 @@
{{http://nexcess.net/banners/nexcess_468x60_1.gif|http://nexcess.net/banners/nexcess_468x60_1.gif|class="external_image
fkromjtocnoxhitqgdwz fkromjtocnoxhitqgdwz"}}
[[http://www.nexcess.net|NEXCESS.NET]] is now supporting JSP/Servlets using
Tomcat.
=== Olvius.com CMS Website Builder ===
- {{http://www.olvius.com/sites/public/olvius.jpg}}
[[http://www.olvius.com|olvius.com]] CMS Website Builder with powerful HTML/CSS
editors provides user-maintained hosting using Tomcat 6 / CentOS 5.
+ {{http://www.olvius.com/sites/public/olvius.jpg}}
[[http://www.olvius.com|olvius.com]] CMS Website Builder with HTML/CSS editors
provides user-maintained hosting using Tomcat 6 / CentOS 5.
=== Opticalhost ===
[[http://www.opticalhost.com.br/|Opticalhost - Soluçoes para o seu site]]
provides webhosting with JSP/Servlets support using Tomcat.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
