DO NOT REPLY [Bug 50494] Need to add ability to disable chunked encoding or support HTTP 1.0 response.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50494 gober...@msn.com changed: What|Removed |Added CC||gober...@msn.com -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50495] Comet connector needs ability to access the client send queue.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50495 gober...@msn.com changed: What|Removed |Added CC||gober...@msn.com -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50495] New: Comet connector needs ability to access the client send queue.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50495 Summary: Comet connector needs ability to access the client send queue. Product: Tomcat 7 Version: 7.0.5 Platform: PC OS/Version: All Status: NEW Severity: blocker Priority: P2 Component: Connectors AssignedTo: dev@tomcat.apache.org ReportedBy: gober...@msn.com I use NIO HTTP Tomcat connector org.apache.coyote.Http11NioProtocol to implement Comet streaming to browsers and mobile devices. The application opens 'primary' persistent Comet connection to receive data from the server. Server sends data to the client periodically. It will be possible that one of the clients is "slow reader" for various reasons. If I call PrintWriter.print("message") to send data to such client, the message will be queued internally by the Tomcat "Comet Processor". If message flow is heavy, the client message queues may become large and Tomcat can run out of memory. I was able to duplicate this quite easily by sending messages in a loop. It will be critical to address these issues for any "production quality" application. I would like to request 2 enhancements to address this: 1) I would like to somehow "compress" the pending client's queue. Messages I send are financial market data messages. So if I send message for stock IBM and the message is queued, then when a new message for IBM is generated, I should be able to detect that there is a message in the queue pending to be sent and just replace content of the one already pending instead of queuing a new one. 2) If queue for a client reaches a high water mark, I should be able to detect it, disconnect the client and delete the queue. This is how data is sent now with Tomcat Comet: PrintWriter out = response.getWriter(); out.print("my message"); This is how I would prefer it to work. This is very rough idea. // Comet PrintWriter will be exposed: CometPrintWriter out = (CometPrintWriter)response.getWriter(); // detect queue size and disconnect if necessary. int queueSize = out.getQueue().size() // get cached message for the stock symbol ICometMessage existingMessageForTheSymbol = ... if (existingMessageForTheSymbol == null) { ICometMessage newMessage = new MyMessage(...) out.addMessage(newMessage); // cache the newMessage in a Map. } else { if (!existingMessageForTheSymbol.replaceMessage(...)) { // message is already sent. need to create a new one: ICometMessage newMessage = new MyMessage(...) out.addMessage(newMessage); // cache the newMessage in a Map. } } // this interface would be a part of Tomcat Comet interface ICometMessage { // called by Tomcat comet before message is sent. void beforeMessageSent(); // called by Tomcat comet after message is sent. void afterMessageSent(); } class MyMessage implements ICometMessage { ReentrantLock lock = ...; boolean messageSent; public void beforeMessageSent() { lock.lock(); messageSent = true; } public void afterMessageSent() { lock.unlock(); } public boolean replaceMessage(...) { lock.lock(); if (messageSent) { lock.unlock(); return false; } // replace message data. lock.unlock(); return true; } } -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50494] New: Need to add ability to disable chunked encoding or support HTTP 1.0 response.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50494 Summary: Need to add ability to disable chunked encoding or support HTTP 1.0 response. Product: Tomcat 7 Version: 7.0.5 Platform: PC OS/Version: All Status: NEW Severity: critical Priority: P2 Component: Connectors AssignedTo: dev@tomcat.apache.org ReportedBy: gober...@msn.com I use NIO HTTP Tomcat connector org.apache.coyote.Http11NioProtocol to implement Comet streaming to browsers and mobile devices. The application opens 'primary' persistent Comet connection to receive data from the server. Server sends data to the client periodically. Currently, the response always uses HTTP 1.1 type response with chunked encoding. There could be a legitimate reason to disable chunked encoding - use "Connection: close" without "Content-Length" headers. For example, if I use tomcat to implement EventType streaming with Chrome, it does not like chunked encoding and fails to receive any data. Also, chunked encoding increases network bandwidth. One way to disable chunked encoding (and actually the one I would prefer) is to force HTTP 1.0 response. So my questions are: 1) is it possible to force HTTP 1.0 response 2) is it possible to use HTTP 1.1 response, but disable chunked encoding. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: isapi_redirector.dll -- Tomcat to IIS problems
amythyst wrote: > > Hi, I am trying to get an application called JIRA to work externally on > our corporate domain. We believe we have everything set up properly and > have followed numoerous online instructions. The default website in IIS > (version 6) is up and the ISAPI filter is "loaded" with the green light. > However, when we go to the website we're getting a "Bad Gateway" error and > the ISAPI logs say this: > > [Thu Dec 16 11:20:10.559 2010] [1508:1800] [error] > ajp_get_reply::jk_ajp_common.c (2058): (worker1) Tomcat is down or refused > connection. No response has been sent to the client (yet) > > [Thu Dec 16 11:20:10.559 2010] [1508:1800] [info] > ajp_service::jk_ajp_common.c (2543): (worker1) sending request to tomcat > failed (recoverable), because of protocol error (attempt=1) > > [Thu Dec 16 11:20:10.559 2010] [1508:1800] [debug] > ajp_service::jk_ajp_common.c (2400): retry 1, sleeping for 100 ms before > retrying > > [Thu Dec 16 11:20:10.668 2010] [1508:1800] [debug] > ajp_send_request::jk_ajp_common.c (1572): (worker1) all endpoints are > disconnected. > > [Thu Dec 16 11:20:10.668 2010] [1508:1800] [debug] > jk_open_socket::jk_connect.c (484): socket TCP_NODELAY set to On > > Could really really use some help here. Please let me know what > additional info you need to assist. > bump o.o -- View this message in context: http://old.nabble.com/isapi_redirector.dllTomcat-to-IIS-problems-tp30474659p30485046.html Sent from the Tomcat - Dev mailing list archive at Nabble.com. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1050504 - in /tomcat/trunk/java/org/apache/juli/logging: DirectJDKLog.java LogFactory.java
Author: markt Date: Fri Dec 17 22:09:28 2010 New Revision: 1050504 URL: http://svn.apache.org/viewvc?rev=1050504&view=rev Log: Fix remaining Eclipse warnings in o.a.juli Modified: tomcat/trunk/java/org/apache/juli/logging/DirectJDKLog.java tomcat/trunk/java/org/apache/juli/logging/LogFactory.java Modified: tomcat/trunk/java/org/apache/juli/logging/DirectJDKLog.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/juli/logging/DirectJDKLog.java?rev=1050504&r1=1050503&r2=1050504&view=diff == --- tomcat/trunk/java/org/apache/juli/logging/DirectJDKLog.java (original) +++ tomcat/trunk/java/org/apache/juli/logging/DirectJDKLog.java Fri Dec 17 22:09:28 2010 @@ -71,74 +71,92 @@ class DirectJDKLog implements Log { logger=Logger.getLogger(name); } +@Override public final boolean isErrorEnabled() { return logger.isLoggable(Level.SEVERE); } +@Override public final boolean isWarnEnabled() { return logger.isLoggable(Level.WARNING); } +@Override public final boolean isInfoEnabled() { return logger.isLoggable(Level.INFO); } +@Override public final boolean isDebugEnabled() { return logger.isLoggable(Level.FINE); } +@Override public final boolean isFatalEnabled() { return logger.isLoggable(Level.SEVERE); } +@Override public final boolean isTraceEnabled() { return logger.isLoggable(Level.FINER); } +@Override public final void debug(Object message) { log(Level.FINE, String.valueOf(message), null); } +@Override public final void debug(Object message, Throwable t) { log(Level.FINE, String.valueOf(message), t); } +@Override public final void trace(Object message) { log(Level.FINER, String.valueOf(message), null); } +@Override public final void trace(Object message, Throwable t) { log(Level.FINER, String.valueOf(message), t); } +@Override public final void info(Object message) { log(Level.INFO, String.valueOf(message), null); } +@Override public final void info(Object message, Throwable t) { log(Level.INFO, String.valueOf(message), t); } +@Override public final void warn(Object message) { log(Level.WARNING, String.valueOf(message), null); } +@Override public final void warn(Object message, Throwable t) { log(Level.WARNING, String.valueOf(message), t); } +@Override public final void error(Object message) { log(Level.SEVERE, String.valueOf(message), null); } +@Override public final void error(Object message, Throwable t) { log(Level.SEVERE, String.valueOf(message), t); } +@Override public final void fatal(Object message) { log(Level.SEVERE, String.valueOf(message), null); } +@Override public final void fatal(Object message, Throwable t) { log(Level.SEVERE, String.valueOf(message), t); } Modified: tomcat/trunk/java/org/apache/juli/logging/LogFactory.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/juli/logging/LogFactory.java?rev=1050504&r1=1050503&r2=1050504&view=diff == --- tomcat/trunk/java/org/apache/juli/logging/LogFactory.java (original) +++ tomcat/trunk/java/org/apache/juli/logging/LogFactory.java Fri Dec 17 22:09:28 2010 @@ -321,11 +321,10 @@ public /* abstract */ class LogFactory { * * @param classLoader ClassLoader for which to release the LogFactory */ -public static void release( -@SuppressWarnings("unused") ClassLoader classLoader) { -// JULI's log manager looks at the current classLoader, the default -// implementation does not so calling reset in that case will break -// things +public static void release(ClassLoader classLoader) { +// JULI's log manager looks at the current classLoader so there is no +// need to use the passed in classLoader, the default implementation +// does not so calling reset in that case will break things if (!LogManager.getLogManager().getClass().getName().equals( "java.util.logging.LogManager")) { LogManager.getLogManager().reset(); - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1050502 - in /tomcat/trunk/java/org/apache/coyote: Response.java http11/Http11NioProtocol.java http11/Http11Protocol.java
Author: markt Date: Fri Dec 17 22:06:33 2010 New Revision: 1050502 URL: http://svn.apache.org/viewvc?rev=1050502&view=rev Log: Fix remaining Eclipse warnings in o.a.coyote Modified: tomcat/trunk/java/org/apache/coyote/Response.java tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java Modified: tomcat/trunk/java/org/apache/coyote/Response.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/Response.java?rev=1050502&r1=1050501&r2=1050502&view=diff == --- tomcat/trunk/java/org/apache/coyote/Response.java (original) +++ tomcat/trunk/java/org/apache/coyote/Response.java Fri Dec 17 22:06:33 2010 @@ -445,6 +445,7 @@ public final class Response { * * @param type the content type */ +@SuppressWarnings("deprecation") public void setContentType(String type) { int semicolonIndex = -1; @@ -466,6 +467,7 @@ public final class Response { while (index != -1) { semicolonIndex = index; index++; +// Yes, isSpace() is deprecated but it does exactly what we need while (index < len && Character.isSpace(type.charAt(index))) { index++; } Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java?rev=1050502&r1=1050501&r2=1050502&view=diff == --- tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java (original) +++ tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java Fri Dec 17 22:06:33 2010 @@ -219,6 +219,7 @@ public class Http11NioProtocol extends A recycledProcessors.clear(); } +@Override public SSLImplementation getSslImplementation() { return proto.sslImplementation; } Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java?rev=1050502&r1=1050501&r2=1050502&view=diff == --- tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java (original) +++ tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java Fri Dec 17 22:06:33 2010 @@ -151,6 +151,7 @@ public class Http11Protocol extends Abst return global; } +@Override public SSLImplementation getSslImplementation() { return proto.sslImplementation; } - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1050500 - in /tomcat/trunk/test/org/apache/catalina: filters/TesterResponse.java tribes/demos/IntrospectionUtils.java tribes/demos/MapDemo.java tribes/demos/MembersWithProperties.java
Author: markt Date: Fri Dec 17 22:01:59 2010 New Revision: 1050500 URL: http://svn.apache.org/viewvc?rev=1050500&view=rev Log: Fix remaining warnings in unit tests (with recently documented settings) Modified: tomcat/trunk/test/org/apache/catalina/filters/TesterResponse.java tomcat/trunk/test/org/apache/catalina/tribes/demos/IntrospectionUtils.java tomcat/trunk/test/org/apache/catalina/tribes/demos/MapDemo.java tomcat/trunk/test/org/apache/catalina/tribes/demos/MembersWithProperties.java Modified: tomcat/trunk/test/org/apache/catalina/filters/TesterResponse.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/filters/TesterResponse.java?rev=1050500&r1=1050499&r2=1050500&view=diff == --- tomcat/trunk/test/org/apache/catalina/filters/TesterResponse.java (original) +++ tomcat/trunk/test/org/apache/catalina/filters/TesterResponse.java Fri Dec 17 22:01:59 2010 @@ -105,7 +105,7 @@ public class TesterResponse * @param b * @throws IOException */ -public void write(@SuppressWarnings("unused") int b) throws IOException { +public void write(int b) throws IOException { // NOOP } /** @@ -113,8 +113,8 @@ public class TesterResponse * @param b * @throws IOException */ -public void write(@SuppressWarnings("unused") byte b[]) throws IOException { - // NOOP +public void write(byte b[]) throws IOException { +// NOOP } /** * @@ -123,9 +123,9 @@ public class TesterResponse * @param len * @throws IOException */ -public void write(@SuppressWarnings("unused") byte b[], -@SuppressWarnings("unused") int off, -@SuppressWarnings("unused") int len) throws IOException {/* NOOP */} +public void write(byte b[], int off, int len) throws IOException { +// NOOP +} @Override public void flushBuffer() throws IOException {/* NOOP */} @Override Modified: tomcat/trunk/test/org/apache/catalina/tribes/demos/IntrospectionUtils.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/tribes/demos/IntrospectionUtils.java?rev=1050500&r1=1050499&r2=1050500&view=diff == --- tomcat/trunk/test/org/apache/catalina/tribes/demos/IntrospectionUtils.java (original) +++ tomcat/trunk/test/org/apache/catalina/tribes/demos/IntrospectionUtils.java Fri Dec 17 22:01:59 2010 @@ -258,6 +258,7 @@ public final class IntrospectionUtils { * int or boolean we'll convert value to the right type before) - that means * you can have setDebug(1). */ +@SuppressWarnings("null") public static boolean setProperty(Object o, String name, String value) { if (log.isDebugEnabled()) log.debug("IntrospectionUtils: setProperty(" + @@ -355,7 +356,8 @@ public final class IntrospectionUtils { params[1] = value; if (setPropertyMethodBool != null) { try { -return (Boolean) setPropertyMethodBool.invoke(o, params); +return ((Boolean) setPropertyMethodBool.invoke(o, +params)).booleanValue(); }catch (IllegalArgumentException biae) { //the boolean method had the wrong //parameter types. lets try the other @@ -712,6 +714,7 @@ public final class IntrospectionUtils { return methods; } +@SuppressWarnings("null") public static Method findMethod(Class c, String name, Class params[]) { Method methods[] = findMethods(c); @@ -777,30 +780,6 @@ public final class IntrospectionUtils { m.invoke(c, new Object[] { args }); } -public static Object callMethod1(Object target, String methodN, -Object param1, String typeParam1, ClassLoader cl) throws Exception { -if (target == null || param1 == null) { -if (log.isDebugEnabled()) -log.debug("IntrospectionUtils: Assert: Illegal params " + -target + " " + param1); -} -if (log.isDebugEnabled()) -log.debug("IntrospectionUtils: callMethod1 " + -target.getClass().getName() + " " + -param1.getClass().getName() + " " + typeParam1); - -Class params[] = new Class[1]; -if (typeParam1 == null) -params[0] = param1.getClass(); -else -params[0] = cl.loadClass(typeParam1); -Method m = findMethod(target.getClass(), methodN, params); -if (m == null) -throw new NoSuchMethodException(target.getClass().getName() + " " -+ methodN); -return m.invoke(target, new Object[] { param1 }); -} - public static Object callMethod0(Object targe
svn commit: r1050499 - /tomcat/trunk/webapps/examples/WEB-INF/classes/filters/SetCharacterEncodingFilter.java
Author: markt Date: Fri Dec 17 21:51:11 2010 New Revision: 1050499 URL: http://svn.apache.org/viewvc?rev=1050499&view=rev Log: Fix remaining warnings in webapps (with recently documented settings) Modified: tomcat/trunk/webapps/examples/WEB-INF/classes/filters/SetCharacterEncodingFilter.java Modified: tomcat/trunk/webapps/examples/WEB-INF/classes/filters/SetCharacterEncodingFilter.java URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/examples/WEB-INF/classes/filters/SetCharacterEncodingFilter.java?rev=1050499&r1=1050498&r2=1050499&view=diff == --- tomcat/trunk/webapps/examples/WEB-INF/classes/filters/SetCharacterEncodingFilter.java (original) +++ tomcat/trunk/webapps/examples/WEB-INF/classes/filters/SetCharacterEncodingFilter.java Fri Dec 17 21:51:11 2010 @@ -165,8 +165,7 @@ public class SetCharacterEncodingFilter * * @param request The servlet request we are processing */ -protected String selectEncoding( -@SuppressWarnings("unused") ServletRequest request) { +protected String selectEncoding(ServletRequest request) { return (this.encoding); - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1050498 - in /tomcat/trunk/java/javax/servlet: http/HttpServlet.java jsp/JspContext.java jsp/el/ImplicitObjectELResolver.java
Author: markt Date: Fri Dec 17 21:49:54 2010 New Revision: 1050498 URL: http://svn.apache.org/viewvc?rev=1050498&view=rev Log: Fix remaining warnings in javax package (with recently documented settings) Modified: tomcat/trunk/java/javax/servlet/http/HttpServlet.java tomcat/trunk/java/javax/servlet/jsp/JspContext.java tomcat/trunk/java/javax/servlet/jsp/el/ImplicitObjectELResolver.java Modified: tomcat/trunk/java/javax/servlet/http/HttpServlet.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/http/HttpServlet.java?rev=1050498&r1=1050497&r2=1050498&view=diff == --- tomcat/trunk/java/javax/servlet/http/HttpServlet.java (original) +++ tomcat/trunk/java/javax/servlet/http/HttpServlet.java Fri Dec 17 21:49:54 2010 @@ -200,8 +200,7 @@ public abstract class HttpServlet extend * since midnight, January 1, 1970 GMT, or * -1 if the time is not known */ -protected long getLastModified( -@SuppressWarnings("unused") HttpServletRequest req) { +protected long getLastModified(HttpServletRequest req) { return -1; } @@ -475,8 +474,7 @@ public abstract class HttpServlet extend * @exception ServletException if the request for the * OPTIONS cannot be handled */ -protected void doOptions( -@SuppressWarnings("unused") HttpServletRequest req, +protected void doOptions(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException { Modified: tomcat/trunk/java/javax/servlet/jsp/JspContext.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/jsp/JspContext.java?rev=1050498&r1=1050497&r2=1050498&view=diff == --- tomcat/trunk/java/javax/servlet/jsp/JspContext.java (original) +++ tomcat/trunk/java/javax/servlet/jsp/JspContext.java Fri Dec 17 21:49:54 2010 @@ -19,8 +19,6 @@ package javax.servlet.jsp; import java.util.Enumeration; import javax.el.ELContext; -import javax.servlet.jsp.el.ExpressionEvaluator; -import javax.servlet.jsp.el.VariableResolver; /** * @@ -227,7 +225,7 @@ public abstract class JspContext { * JspApplicationContext.getExpressionFactory() */ @SuppressWarnings("dep-ann") // TCK signature test fails with annotation -public abstract ExpressionEvaluator getExpressionEvaluator(); +public abstract javax.servlet.jsp.el.ExpressionEvaluator getExpressionEvaluator(); public abstract ELContext getELContext(); @@ -245,7 +243,7 @@ public abstract class JspContext { * jspContext.getELContext().getELResolver() */ @SuppressWarnings("dep-ann") // TCK signature test fails with annotation -public abstract VariableResolver getVariableResolver(); +public abstract javax.servlet.jsp.el.VariableResolver getVariableResolver(); /** * Return a new JspWriter object that sends output to the Modified: tomcat/trunk/java/javax/servlet/jsp/el/ImplicitObjectELResolver.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/jsp/el/ImplicitObjectELResolver.java?rev=1050498&r1=1050497&r2=1050498&view=diff == --- tomcat/trunk/java/javax/servlet/jsp/el/ImplicitObjectELResolver.java (original) +++ tomcat/trunk/java/javax/servlet/jsp/el/ImplicitObjectELResolver.java Fri Dec 17 21:49:54 2010 @@ -504,10 +504,12 @@ public class ImplicitObjectELResolver ex protected abstract V getAttribute(String name); +@SuppressWarnings("unused") protected void removeAttribute(String name) { throw new UnsupportedOperationException(); } +@SuppressWarnings("unused") protected void setAttribute(String name, Object value) { throw new UnsupportedOperationException(); } - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1050497 - /tomcat/trunk/res/ide-support/eclipse/java-compiler-errors-warnings.txt
Author: markt Date: Fri Dec 17 21:47:52 2010 New Revision: 1050497 URL: http://svn.apache.org/viewvc?rev=1050497&view=rev Log: Document the Eclipse compiler errors/warnings settings I am using Added: tomcat/trunk/res/ide-support/eclipse/java-compiler-errors-warnings.txt Added: tomcat/trunk/res/ide-support/eclipse/java-compiler-errors-warnings.txt URL: http://svn.apache.org/viewvc/tomcat/trunk/res/ide-support/eclipse/java-compiler-errors-warnings.txt?rev=1050497&view=auto == --- tomcat/trunk/res/ide-support/eclipse/java-compiler-errors-warnings.txt (added) +++ tomcat/trunk/res/ide-support/eclipse/java-compiler-errors-warnings.txt Fri Dec 17 21:47:52 2010 @@ -0,0 +1,39 @@ +Following settings for Helios Service Release 1 + + +W = Warning +I = Ignore +E = Error + +Code style + - Non-static access to static member - W + - Indirect access to static member - I + - Unqualified access to instance field - I + - Undocumented empty block - I + - Access to a non-accessible member... - I + - Method with a constructor name - W + - Parameter assignment - I + - Non-externalized strings - I +Potential programming errors + - All - W +Name shadowing and conflicts + - Field declaration hides another... - I + - Local variable declaration hides.. - I + - Type parameter hides another type- W + - Method does not override... - W + - Interface method conflicts...- W +Deprecated and restricted API + - Deprecated API - W + (no additional check boxes) + - Forbidden references - E + - Discouraged reference- W +Unnecessary code + - Unnecessary else - I + - The rest - W + (all additional check boxes) +Generic types + - All - W +Annotations + - All - W + (all additional check boxes) + \ No newline at end of file - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48550] Update examples and default server.xml to use UTF-8
https://issues.apache.org/bugzilla/show_bug.cgi?id=48550 --- Comment #5 from Christopher Schultz 2010-12-17 14:35:27 EST --- (In reply to comment #3) > - On client side FF 3.6, Chrome 8, Opera 11 and IE9 Beta (and as I found on > the > web older versions too) use the character encoding of the page to encode the > query parameters. So if the html is served with utf-8 encoding the query > parameters are encoded with utf-8. Could you provide references to the above? I had trouble finding official default values for the URL character encoding used by browsers. There's also the trouble of users being able to override the default and revert back to (most likely) ISO-8859-1 encoding. Right now, I'm -1 for making URIEncoding="UTF-8" by default since it might break a lot of servers, but I'm willing to be convinced. For the record, I always set URIEncoding="UTF-8" on my projects but we don't want an out-of-the-box server configuration to surprise anyone. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48550] Update examples and default server.xml to use UTF-8
https://issues.apache.org/bugzilla/show_bug.cgi?id=48550 Attila Király changed: What|Removed |Added CC||kiralyattila...@gmail.com --- Comment #4 from Attila Király 2010-12-17 13:33:51 EST --- One more info. Further test revealed that Glassfish 3.0.1 is actually using the request encoding for query parameter decoding. Calling request.setCharacterEncoding("UTF-8"); triggered UTF-8 based decoding for parameters. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48550] Update examples and default server.xml to use UTF-8
https://issues.apache.org/bugzilla/show_bug.cgi?id=48550 --- Comment #3 from Attila Király 2010-12-17 13:23:50 EST --- As a user of Tomcat and a webapp developer I would really like to see the 1) added to the default server.xml. I mostly develop apps using utf-8 encoding and if the customer is using tomcat extra care is needed to either not use non iso-8859-1 characters in query parameters or convincing them to modify the tomcat configuration (from these options the former is always the easier). Some test results: - Glassfish 3.0.1 documentation contains a similar, optional (default value "UTF-8") attribute called "uri-encoding" on the "http" element in the "domain.xml" (mentioned here: http://docs.sun.com/app/docs/doc/821-1753/girlq?l=en&a=view#indexterm-246 ). Unfortunately it does not have any effect on query encoding (tried it with different values but always ISO-8859-1 was used to decode query parameters). This might be a bug in GF but the intention is there. - On client side FF 3.6, Chrome 8, Opera 11 and IE9 Beta (and as I found on the web older versions too) use the character encoding of the page to encode the query parameters. So if the html is served with utf-8 encoding the query parameters are encoded with utf-8. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Getting Started Tomcat Development
Faisal, On 12/17/2010 8:35 AM, Faisal CM wrote: > How can > i make sure that patch meets the exact requirement as if enhancement > does not say much? Your patch should be as small as possible to fix the issue / enhancement. > 2) - Can i get information/guideline of all the > steps needs to be done before submitting a patch through bugzilla > (e.g proposed patch, testcases etc)? Technically, you can submit anything you'd like. /Successful/ patches should: 0. Not contain any tab characters :) 1. Solve the problem in the bug 2. Include any appropriate documentation (new configuration, notes about behavior, etc.) 3. Include unit test cases if appropriate 4. Not include additional changes (code formatting, etc.) 5. Not break anything else :) Thanks for your contribution(s), -chris signature.asc Description: OpenPGP digital signature
Re: Adding annotations to JspC
All, On 12/17/2010 10:59 AM, Christopher Schultz wrote: > WEB-INF/web-fragment.xml Sorry, meant to say META-INF/web-fragment.xml -chris signature.asc Description: OpenPGP digital signature
Re: Adding annotations to JspC
Konstantin, On 12/17/2010 3:49 AM, Konstantin Kolinko wrote: > 2010/12/16 Christopher Schultz : >> All, >> >> I'm looking at writing a patch for bug 50234 ("JspC use servlet 3.0 >> features": https://issues.apache.org/bugzilla/show_bug.cgi?id=50234) and >> I'm thinking that the annotations should actually have nothing to do >> with the precompiler, but the compiler itself. >> >> Can anyone think of a reason not to simply update >> jasper.compiler.Generator to add the @WebServlet annotations? I believe >> everything else needs to be handled by JspC. >> > > Note, that you still have to preserve compatibility for the webapps > that adhere to Servlet 2.5 and earlier versions of specification. > > Using JspC may be limited to Servlet 3.0+ ones (if it is worth it), > but just deploying earlier versions of the webapps on Tomcat should > still work. I think that limiting the compiled servlets to Tomcat 7 (Servlet 3.0+) is okay: the documentation states that JSPs should be recompiled using the version of Tomcat you expect to use for deployment, so backward compatibility isn't something I'm terribly concerned about. > Do you really need @WebServlet here? Are the jsp servlets discovered > though annotations, or do you list them in web-fragment.xml ? The enhancement requests /both/ of those, actually: generating a formal web-fragment.xml (the current implementation just dumps bare and elements -- it's not currently a valid XML document) as well as @WebServlet annotations on the classes. The idea is that JspC could generate a JAR file that could be tossed-into a webapp instead of having all those class files sitting around, and also having to modify the webapp's web.xml file. With the annotations and/or a WEB-INF/web-fragment.xml, the compiled JSPs could be detected and configured automatically. -chris signature.asc Description: OpenPGP digital signature
DO NOT REPLY [Bug 48226] Wrong JRE_HOME set
https://issues.apache.org/bugzilla/show_bug.cgi?id=48226 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Comment #5 from Mark Thomas 2010-12-17 09:25:57 EST --- I tend to agree with Konstantin that this is a WONTFIX. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 45051] Provide read only access for certain role in Administration webapp
https://issues.apache.org/bugzilla/show_bug.cgi?id=45051 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Comment #1 from Mark Thomas 2010-12-17 09:21:32 EST --- Development of the Admin app has all but stopped. Bugs will be fixed but no new features will be developed. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 33453] Jasper should recompile JSP files whose datestamps change in either direction (not just newer)
https://issues.apache.org/bugzilla/show_bug.cgi?id=33453 Mark Thomas changed: What|Removed |Added CC||gus.h...@olin.edu --- Comment #66 from Mark Thomas 2010-12-17 09:14:37 EST --- *** Bug 15417 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 15417] Add port for forced compilation of JSP pages
https://issues.apache.org/bugzilla/show_bug.cgi?id=15417 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||DUPLICATE --- Comment #6 from Mark Thomas 2010-12-17 09:14:37 EST --- *** This bug has been marked as a duplicate of bug 33453 *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 24455] allow to override 'cookies="false"' on a per user/session basis.
https://issues.apache.org/bugzilla/show_bug.cgi?id=24455 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Comment #4 from Mark Thomas 2010-12-17 09:13:04 EST --- I think this enhancement request has been overtaken by browser developments - at least the versions of Firefox and IE running on my desktop have an option to allow session cookies but block others. Therefore marking this as WONTFIX. The other thing that worries me about this is that the app would need to use a proprietary API to set the user's cookie preference making the app non-portable. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 42747] Context className attribute ignored for contexts deployed from descriptors in web/META-INF/context.xml
https://issues.apache.org/bugzilla/show_bug.cgi?id=42747 Mark Thomas changed: What|Removed |Added CC||duff...@yahoo.com --- Comment #5 from Mark Thomas 2010-12-17 09:07:48 EST --- *** Bug 20608 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 20608] context.xml not bound from WAR file
https://issues.apache.org/bugzilla/show_bug.cgi?id=20608 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Comment #3 from Mark Thomas 2010-12-17 09:07:48 EST --- *** This bug has been marked as a duplicate of bug 42747 *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 14635] Should be possible not to have YYYY-MM-DD in log file names
https://issues.apache.org/bugzilla/show_bug.cgi?id=14635 Mark Thomas changed: What|Removed |Added CC||radoslaw.wierzbi...@db.com --- Comment #2 from Mark Thomas 2010-12-17 09:05:29 EST --- *** Bug 16596 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 16596] option for disabling log rotation
https://issues.apache.org/bugzilla/show_bug.cgi?id=16596 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Comment #6 from Mark Thomas 2010-12-17 09:05:29 EST --- *** This bug has been marked as a duplicate of bug 14635 *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 14635] Should be possible not to have YYYY-MM-DD in log file names
https://issues.apache.org/bugzilla/show_bug.cgi?id=14635 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Mark Thomas 2010-12-17 08:56:36 EST --- This feature is available in Tomcat 7. Set the rotatable property to false which removes the date from the log file name and prevents JULI from rotating the file. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 14416] blank tag name in TLD cause NullPointerException
https://issues.apache.org/bugzilla/show_bug.cgi?id=14416 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Mark Thomas 2010-12-17 08:52:23 EST --- Just tested this with 7.0.x and with if deploying a web application with such a TLD full details are provided. With JspC, the NPE from TagLibraryInfo did mask the problem. I have made that method more robust when it comes to handling nulls. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1050384 - in /tomcat/trunk: java/javax/servlet/jsp/tagext/TagLibraryInfo.java webapps/docs/changelog.xml
Author: markt Date: Fri Dec 17 13:52:22 2010 New Revision: 1050384 URL: http://svn.apache.org/viewvc?rev=1050384&view=rev Log: Avoid a possible NPE that in turn was masking the root cause from JspC Modified: tomcat/trunk/java/javax/servlet/jsp/tagext/TagLibraryInfo.java tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/java/javax/servlet/jsp/tagext/TagLibraryInfo.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/jsp/tagext/TagLibraryInfo.java?rev=1050384&r1=1050383&r2=1050384&view=diff == --- tomcat/trunk/java/javax/servlet/jsp/tagext/TagLibraryInfo.java (original) +++ tomcat/trunk/java/javax/servlet/jsp/tagext/TagLibraryInfo.java Fri Dec 17 13:52:22 2010 @@ -137,12 +137,12 @@ public abstract class TagLibraryInfo { public TagInfo getTag(String shortname) { TagInfo tags[] = getTags(); -if (tags == null || tags.length == 0) { +if (tags == null || tags.length == 0 || shortname == null) { return null; } for (int i = 0; i < tags.length; i++) { -if (tags[i].getTagName().equals(shortname)) { +if (shortname.equals(tags[i].getTagName())) { return tags[i]; } } Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1050384&r1=1050383&r2=1050384&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Fri Dec 17 13:52:22 2010 @@ -230,6 +230,10 @@ removed when the service stops which prevents the service from starting. (markt) + +14416: Make TagLibraryInfo.getTag() more robust +at handling nulls. (markt) + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50491] Text for link to Changelog is wrong.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50491 --- Comment #2 from Igor Galić 2010-12-17 08:39:43 EST --- Created an attachment (id=26418) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26418) diff for xdox Don't you love it when that happens? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Getting Started Tomcat Development
HI All,I recently started investigating an enhancement, ended up a few questions to ask how tomcat development process works?e.g https://issues.apache.org/bugzilla/show_bug.cgi?id=499391) - How can i make sure that patch meets the exact requirement as if enhancement does not say much?2) - Can i get information/guideline of all the steps needs to be done before submitting a patch through bugzilla (e.g proposed patch, testcases etc)?3) - Any information/best practices that would help in diagnosing the problem, and testing the scenario in tomcat development. ThanksFaisal
Re: Adding annotations to JspC
On 17/12/2010 08:49, Konstantin Kolinko wrote: > 2010/12/16 Christopher Schultz : >> All, >> >> I'm looking at writing a patch for bug 50234 ("JspC use servlet 3.0 >> features": https://issues.apache.org/bugzilla/show_bug.cgi?id=50234) and >> I'm thinking that the annotations should actually have nothing to do >> with the precompiler, but the compiler itself. >> >> Can anyone think of a reason not to simply update >> jasper.compiler.Generator to add the @WebServlet annotations? I believe >> everything else needs to be handled by JspC. >> > > Note, that you still have to preserve compatibility for the webapps > that adhere to Servlet 2.5 and earlier versions of specification. > > Using JspC may be limited to Servlet 3.0+ ones (if it is worth it), > but just deploying earlier versions of the webapps on Tomcat should > still work. JspC should know which spec version is defined in web.xml, so could switch behaviour. > Do you really need @WebServlet here? Are the jsp servlets discovered > though annotations, or do you list them in web-fragment.xml ? Does Tomcat automatically discover classes annotated with @WebServlet, or must they be included in a JAR, with a web-fragment.xml? I though the latter only. p 0x62590808.asc Description: application/pgp-keys signature.asc Description: OpenPGP digital signature
DO NOT REPLY [Bug 12428] request.getUserPrincipal(): Misinterpretation of specification?
https://issues.apache.org/bugzilla/show_bug.cgi?id=12428 --- Comment #26 from Werner Donn 2010-12-17 04:05:00 EST --- There are two issues here. The first is pre-emptive authentication. RFC 2617 section 1.2 is very clear on this: " A user agent that wishes to authenticate itself with an origin server--usually, but not necessarily, after receiving a 401 (Unauthorized)--MAY do so by including an Authorization header field with the request." And further: "If the origin server does not wish to accept the credentials sent with a request, it SHOULD return a 401 (Unauthorized) response. The response MUST include a WWW-Authenticate header field containing at least one (possibly new) challenge applicable to the requested resource." This means the origin server must always deal with this, no matter the technology being used. The fact that a method is not declared as being protected doesn't play any role. The second issue is that according to you the application should not be able to trigger the challenge-reponse mechanism by setting the status code to 401. Can you give one piece of evidence in the servlet spec for this? Are there restrictions in the HttpServletRequest.setStatus() method that say the application can't use certain status codes? Here is what the servlet spec says about programmatic security: "Programmatic security is used by security aware applications when declarative security alone is not sufficient to express the security model of the application." Declarative security is fine, but doesn't prohibit programmatic security and programmatic security doesn't require declarative security to be present. They are simply not related. According to you they are. Can you tell me why? The patch shows how trivial it is to implement this correctly. Would harm be done if it were implemented? Which spec would be violated in that case? Your stance makes it impossible to implement WebDAV ACLs (RFC 3744). A user can change access control for a resource from protected to public. The former requires authentication prior to access control, while the latter doesn't. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Adding annotations to JspC
2010/12/16 Christopher Schultz : > All, > > I'm looking at writing a patch for bug 50234 ("JspC use servlet 3.0 > features": https://issues.apache.org/bugzilla/show_bug.cgi?id=50234) and > I'm thinking that the annotations should actually have nothing to do > with the precompiler, but the compiler itself. > > Can anyone think of a reason not to simply update > jasper.compiler.Generator to add the @WebServlet annotations? I believe > everything else needs to be handled by JspC. > Note, that you still have to preserve compatibility for the webapps that adhere to Servlet 2.5 and earlier versions of specification. Using JspC may be limited to Servlet 3.0+ ones (if it is worth it), but just deploying earlier versions of the webapps on Tomcat should still work. Do you really need @WebServlet here? Are the jsp servlets discovered though annotations, or do you list them in web-fragment.xml ? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org