Re: Plans for 6.0.next?
On 10/11/2011 04:00 PM, Konstantin Kolinko wrote: Hi! Now that JavaOne is over and people are back to their homes, maybe it is time to roll 6.0.34? I plan to do that next week. Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51862] JreMemoryLeakPreventionListener enhancement to load configurable classes
https://issues.apache.org/bugzilla/show_bug.cgi?id=51862 --- Comment #5 from Sylvain Laurent 2011-10-12 05:03:18 UTC --- It would indeed simplify JMLPL but would break the existing "API" if the setters and getters were removed. Or we can refactor to have the flag setters merely add some known class names to the set of classes to load. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52009] NPE exception in org.apache.catalina.connector.CoyoteAdapter.service
https://issues.apache.org/bugzilla/show_bug.cgi?id=52009
--- Comment #4 from Konstantin Kolinko 2011-10-12
04:31:05 UTC ---
> I already sent you the application in gmail, which is so large to attache
> here.
1) I bet that you do not need all 25 Mb of dojox components of dojotoolkit.
The NPE issue is still reproducible if I delete the dojox folder from the
webapp and that shrinks its size significantly.
2) Source code for StockServlet is there - thank you, but sources of its parent
class BayeuxServlet is not available.
3) To reproduce the issue, open http://localhost:/QuoteStreamerApp/
Just open the page in browser and leave it open.
The page sends a flow of POST requests to
/QuoteStreamerApp/stockServlet HTTP/1.1
4) I am running with the following line added to catalina.properties file:
org.apache.coyote.http11.InternalNioInputBuffer.level = FINE
and it shows that there are problems in BayeuxServlet that it calls setHeader()
on a response that has already been recycled.
It is an application error. This is unacceptable and can lead to updating a
response that is being delivered to a different client.
Stacktrace in localhost.2011-10-12.log:
12-окт-2011 08:04:02.078 SEVERE [http-nio--exec-8]
org.apache.catalina.core.StandardWrapperValve.event Servlet.service() for
servlet [StockServlet] in context with path [/QuoteStreamerApp] threw exception
java.lang.IllegalStateException: The response object has been recycled and is
no longer associated with this facade
at
org.apache.catalina.connector.ResponseFacade.isCommitted(ResponseFacade.java:325)
at
org.apache.catalina.connector.ResponseFacade.setHeader(ResponseFacade.java:518)
at
com.ibm.ws.webmsg.servlet.adapter.ServletResponse.setHeader(ServletResponse.java:147)
at
com.ibm.ws.webmsg.client.bayeux.protocol.vone.JSONTransport.endResponse(JSONTransport.java:191)
at
com.ibm.ws.webmsg.client.bayeux.protocol.vone.processor.EventDeliveryProcessor.close(EventDeliveryProcessor.java:139)
at
com.ibm.ws.webmsg.client.bayeux.protocol.vone.WASCEClientImpl.shutdown(WASCEClientImpl.java:117)
at
com.ibm.ws.webmsg.client.bayeux.protocol.vone.processor.DisconnectProcessor.processMessage(DisconnectProcessor.java:63)
at
com.ibm.ws.webmsg.client.bayeux.protocol.vone.ClientImpl.processRequest(ClientImpl.java:332)
at com.ibm.webmsg.servlet.BayeuxServlet.handleRead(BayeuxServlet.java:233)
at com.ibm.webmsg.servlet.BayeuxServlet.event(BayeuxServlet.java:210)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilterEvent(ApplicationFilterChain.java:482)
at
org.apache.catalina.core.ApplicationFilterChain.doFilterEvent(ApplicationFilterChain.java:376)
at
org.apache.catalina.core.StandardWrapperValve.event(StandardWrapperValve.java:414)
at
org.apache.catalina.core.StandardContextValve.event(StandardContextValve.java:192)
at org.apache.catalina.valves.ValveBase.event(ValveBase.java:226)
at
org.apache.catalina.core.StandardHostValve.event(StandardHostValve.java:245)
at org.apache.catalina.valves.ValveBase.event(ValveBase.java:226)
at org.apache.catalina.valves.ValveBase.event(ValveBase.java:226)
at
org.apache.catalina.core.StandardEngineValve.event(StandardEngineValve.java:138)
at
org.apache.catalina.connector.CoyoteAdapter.event(CoyoteAdapter.java:211)
at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:411)
at
org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:970)
at
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:515)
at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1550)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)
5) There are a lot of exceptions like
javax.jms.JMSException: Could not connect to broker URL: tcp://localhost:61616.
Reason: java.net.ConnectException: Connection refused: connect
but the NullPointerException at CoyoteAdapter.java:436 is reproducible.
6) The NPE is reproducible both in 7.0.22 and in trunk.
The requests to of them fail with error 500, but response sizes in different
requests are different.
I noted the following while debugging trunk:
1. In access log all requests are POST to /QuoteStreamerApp/stockServlet.
They all fail with error 500, but response sizes are different.
2. After the call to getPipeline().getFirst().invoke(request, response) the
value of request.isComet() is true.
3. The cause for NPE at CoyoteAdapter.java:436 is that at that point the
request is already recycled and request.getMappingData().context is null.
4. The recycling happens in the finally block in CoyoteAdapter#event(..),
lines 252-254:
if (error || response.isClosed() || !request.isComet()) {
request.recycle();
DO NOT REPLY [Bug 52009] NPE exception in org.apache.catalina.connector.CoyoteAdapter.service
https://issues.apache.org/bugzilla/show_bug.cgi?id=52009 --- Comment #3 from viola.lu 2011-10-12 03:18:05 UTC --- Hi, Konstantin: Errors were generated when tomcat start. I just directly put it before tomcat start, so it failed when start tomcat. You can start tomcat, and then put it in webapp folder to recreate it. I already sent you the application in gmail, which is so large to attache here. I tried to debug it, but failed to get request. May i can add a println to get request in this tomcat code. Full log, but i can't get any hints from this log, is there log level option i can change, so ii can get more details? 2011-10-11 15:52:19 org.apache.catalina.startup.HostConfig deployWAR INFO: Deploying web application archive QuoteStreamerApp.war 2011-10-11 15:52:20 org.apache.catalina.startup.HostConfig deployDirectory INFO: Deploying web application directory docs 2011-10-11 15:52:20 org.apache.catalina.startup.HostConfig deployDirectory INFO: Deploying web application directory examples 2011-10-11 15:52:20 org.apache.catalina.startup.HostConfig deployDirectory INFO: Deploying web application directory host-manager 2011-10-11 15:52:20 org.apache.catalina.startup.HostConfig deployDirectory INFO: Deploying web application directory manager 2011-10-11 15:52:20 org.apache.catalina.startup.HostConfig deployDirectory INFO: Deploying web application directory ROOT 2011-10-11 15:52:20 org.apache.coyote.AbstractProtocol start INFO: Starting ProtocolHandler ["http-bio-8080"] 2011-10-11 15:52:20 org.apache.coyote.AbstractProtocol start INFO: Starting ProtocolHandler ["ajp-bio-8009"] 2011-10-11 15:52:20 org.apache.coyote.AbstractProtocol start INFO: Starting ProtocolHandler ["http-nio-"] 2011-10-11 15:52:20 org.apache.catalina.startup.Catalina start INFO: Server startup in 3328 ms 2011-10-11 15:53:01 org.apache.catalina.startup.HostConfig checkResources INFO: Undeploying context [/QuoteStreamerApp] 2011-10-11 15:53:11 org.apache.catalina.startup.HostConfig deployWAR INFO: Deploying web application archive QuoteStreamerApp.war 2011-10-11 15:53:52 com.ibm.websphere.webmsg.quotestreamer.AppInit init INFO: DataSimulator successfully created and set and started. 2011-10-11 15:54:01 com.ibm.webmsg.example.StockServlet setProperties INFO: Configured properties for quote streamer requests. 2011-10-11 15:54:02 com.ibm.webmsg.example.StockServlet registerURL INFO: Registered the URL for comet requests. 2011-10-11 15:54:02 org.apache.coyote.http11.AbstractHttp11Processor process SEVERE: Error processing request java.lang.NullPointerException at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:436) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:970) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:515) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1550) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:662) 2011-10-11 15:54:02 org.apache.coyote.http11.AbstractHttp11Processor process SEVERE: Error processing request java.lang.NullPointerException at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:436) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:970) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:515) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1550) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:662) 2011-10-11 15:54:04 org.apache.coyote.http11.AbstractHttp11Processor process SEVERE: Error processing request java.lang.NullPointerException at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:436) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:970) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:515) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1550) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:662) 2011-10-11 15:54:04 org.apache.coyote.http11.AbstractHttp11Processor process SEVERE: Error processing request java.lang.NullPointerException at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:436) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:970) at org.apache.coyote.Abst
DO NOT REPLY [Bug 52009] NPE exception in org.apache.catalina.connector.CoyoteAdapter.service
https://issues.apache.org/bugzilla/show_bug.cgi?id=52009 --- Comment #2 from viola.lu 2011-10-12 03:07:05 UTC --- Created attachment 27764 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27764 tomcat configuration tomcat configuration -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52009] NPE exception in org.apache.catalina.connector.CoyoteAdapter.service
https://issues.apache.org/bugzilla/show_bug.cgi?id=52009 --- Comment #1 from Konstantin Kolinko 2011-10-12 02:57:34 UTC --- (In reply to comment #0) > You can also get these file from attached zip > 4. Put sample files QuoteStreamerApp.war as attached in webapp folder 1) You forgot to attach the files. > > 2011-10-11 15:53:01 org.apache.catalina.startup.HostConfig checkResources > INFO: Undeploying context [/QuoteStreamerApp] 2) What happened before the above line? Undeploying/redeploying the webapp is not mentioned in your reproduction scenario. It would better to see the full logs. You may attach them to the issue - no need to paste them into the text field. 3) What pages should I access in web browser to reproduce the issue? It is not mentioned. (The logs say that CoyoteAdapter processes a request. What a request that is?) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Created] (MTOMCAT-101) Add the ability to deploy to a Tomcat instance on the filesystem rather than via HTTP
Add the ability to deploy to a Tomcat instance on the filesystem rather than via HTTP - Key: MTOMCAT-101 URL: https://issues.apache.org/jira/browse/MTOMCAT-101 Project: Maven 2.x Tomcat Plugin Issue Type: New Feature Components: tomcat6, tomcat7 Reporter: Steve Swinsburg Assignee: Olivier Lamy It would be great to have the ability to deploy a webapp to Tomcat without using HTTP and the Tomcat Manager, by simply doing a filesystem copy of the built war file to the location specified. We currently use an ant profile to do this, but want to replace this with a proper plugin. We will be looking at contributing this feature in the near future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51741] Eclipse WTP "Serve modules without publishing" broken with tc7, needs patch in tomcat
https://issues.apache.org/bugzilla/show_bug.cgi?id=51741 Mike Youngstrom changed: What|Removed |Added CC||you...@gmail.com -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51862] JreMemoryLeakPreventionListener enhancement to load configurable classes
https://issues.apache.org/bugzilla/show_bug.cgi?id=51862 --- Comment #4 from Konstantin Kolinko 2011-10-11 23:34:11 UTC --- If you have predefined list of classes, what will this configuration property do: add to it, or replace it? If it adds to it, how you remove items from predefined list (that is currently done by setting some properties to false) - by editing catalina.properties? In general it makes sense, because it is easier to edit some default list (if we have to add some new classes to it in the default configuration) than introduce new setters and property name. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Closed] (MTOMCAT-100) support war overlay to add war external dependencies in tomcat run
[ https://issues.apache.org/jira/browse/MTOMCAT-100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy closed MTOMCAT-100. Resolution: Fixed implemented > support war overlay to add war external dependencies in tomcat run > --- > > Key: MTOMCAT-100 > URL: https://issues.apache.org/jira/browse/MTOMCAT-100 > Project: Maven 2.x Tomcat Plugin > Issue Type: Improvement > Components: tomcat6, tomcat7 >Reporter: Olivier Lamy >Assignee: Olivier Lamy > Fix For: 2.0 > > > /WEB-INF/lib/*.jar and /WEB-INF/classes will added to web app classloader > when using tomcat*:run to do as war overlays does. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-100) support war overlay to add war external dependencies in tomcat run
[ https://issues.apache.org/jira/browse/MTOMCAT-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125381#comment-13125381 ] Hudson commented on MTOMCAT-100: Integrated in TomcatMavenPlugin #27 (See [https://builds.apache.org/job/TomcatMavenPlugin/27/]) [MTOMCAT-100] support war overlay to add war external dependencies in tomcat run: this option must be on by default to mimic what the maven war plugin does with overlays. olamy : http://svn.apache.org/viewvc/?view=rev&rev=1182081 Files : * /tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java * /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java > support war overlay to add war external dependencies in tomcat run > --- > > Key: MTOMCAT-100 > URL: https://issues.apache.org/jira/browse/MTOMCAT-100 > Project: Maven 2.x Tomcat Plugin > Issue Type: Improvement > Components: tomcat6, tomcat7 >Reporter: Olivier Lamy >Assignee: Olivier Lamy > Fix For: 2.0 > > > /WEB-INF/lib/*.jar and /WEB-INF/classes will added to web app classloader > when using tomcat*:run to do as war overlays does. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1182081 - in /tomcat/maven-plugin/trunk: tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/
Author: olamy
Date: Tue Oct 11 20:50:38 2011
New Revision: 1182081
URL: http://svn.apache.org/viewvc?rev=1182081&view=rev
Log:
[MTOMCAT-100] support war overlay to add war external dependencies in tomcat
run: this option must be on by default to mimic what the maven war plugin does
with overlays.
Modified:
tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java
tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java
Modified:
tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java
URL:
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java?rev=1182081&r1=1182080&r2=1182081&view=diff
==
---
tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java
(original)
+++
tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java
Tue Oct 11 20:50:38 2011
@@ -103,7 +103,7 @@ public class RunMojo
/**
* will add /WEB-INF/lib/*.jar and /WEB-INF/classes from war dependencies
in the webappclassloader
*
- * @parameter expression="${maven.tomcat.addWarDependenciesInClassloader}"
default-value="false"
+ * @parameter expression="${maven.tomcat.addWarDependenciesInClassloader}"
default-value="true"
* @since 2.0
*/
private boolean addWarDependenciesInClassloader;
Modified:
tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java
URL:
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java?rev=1182081&r1=1182080&r2=1182081&view=diff
==
---
tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java
(original)
+++
tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java
Tue Oct 11 20:50:38 2011
@@ -101,7 +101,7 @@ public class RunMojo
/**
* will add /WEB-INF/lib/*.jar and /WEB-INF/classes from war dependencies
in the webappclassloader
*
- * @parameter expression="${maven.tomcat.addWarDependenciesInClassloader}"
default-value="false"
+ * @parameter expression="${maven.tomcat.addWarDependenciesInClassloader}"
default-value="true"
* @since 2.0
*/
private boolean addWarDependenciesInClassloader;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Updated] (MTOMCAT-100) support war overlay to add war external dependencies in tomcat run
[ https://issues.apache.org/jira/browse/MTOMCAT-100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy updated MTOMCAT-100: - Description: /WEB-INF/lib/*.jar and /WEB-INF/classes will added to web app classloader when using tomcat*:run to do as war overlays does. (was: if activated /WEB-INF/lib/*.jar and /WEB-INF/classes will added to web app classloader when using tomcat*:run) > support war overlay to add war external dependencies in tomcat run > --- > > Key: MTOMCAT-100 > URL: https://issues.apache.org/jira/browse/MTOMCAT-100 > Project: Maven 2.x Tomcat Plugin > Issue Type: Improvement > Components: tomcat6, tomcat7 >Reporter: Olivier Lamy >Assignee: Olivier Lamy > Fix For: 2.0 > > > /WEB-INF/lib/*.jar and /WEB-INF/classes will added to web app classloader > when using tomcat*:run to do as war overlays does. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46264] Shutting down tomcat with large number of contexts is slow
https://issues.apache.org/bugzilla/show_bug.cgi?id=46264 --- Comment #16 from Konstantin Kolinko 2011-10-11 20:32:53 UTC --- (In reply to comment #15) > There is a new Digester release (3.0), but I have no idea whether it would > significantly improve speed >From threading point of view it is still the same: Rule, Digester and xml parser are usable in a single thread at once only. I do not think that xml parsers can be multi-threaded. There is new API to declare a factory that creates sets of rules (binder.RulesModule), but we already do something similar, e.g. WebRuleSet#addRuleInstances(). Digester 3.0 release notes: http://commons.apache.org/digester/commons-digester-3.0/RELEASE-NOTES.txt -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51966] Tomcat does not support ssha hashed passwords in all contexts
https://issues.apache.org/bugzilla/show_bug.cgi?id=51966 --- Comment #5 from Christopher Schultz 2011-10-11 20:30:51 UTC --- (In reply to comment #3) > Thank you for the great feedback. The salt isn't part of the users password. > If > you look at the digest method that's used to generate the encoded password, it > is 4 random bytes. Given the small scope of the patch, it wasn't clear that Principal.getPassword was returning the hashed password from the credential store. Apologies for not reading carefully. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-100) support war overlay to add war external dependencies in tomcat run
[ https://issues.apache.org/jira/browse/MTOMCAT-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125354#comment-13125354 ] Hudson commented on MTOMCAT-100: Integrated in TomcatMavenPlugin-mvn2.x #8 (See [https://builds.apache.org/job/TomcatMavenPlugin-mvn2.x/8/]) [MTOMCAT-100] support war overlay to add war external dependencies in tomcat run: tomcat6 support too. [MTOMCAT-100] support war overlay to add war external dependencies in tomcat run. olamy : http://svn.apache.org/viewvc/?view=rev&rev=1182064 Files : * /tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java * /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java olamy : http://svn.apache.org/viewvc/?view=rev&rev=1182063 Files : * /tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/pom.xml * /tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/ClassLoaderEntriesCalculator.java * /tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/ClassLoaderEntriesCalculatorRequest.java * /tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/DefaultClassLoaderEntriesCalculator.java * /tomcat/maven-plugin/trunk/pom.xml * /tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/AbstractRunMojo.java * /tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java * /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java * /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java > support war overlay to add war external dependencies in tomcat run > --- > > Key: MTOMCAT-100 > URL: https://issues.apache.org/jira/browse/MTOMCAT-100 > Project: Maven 2.x Tomcat Plugin > Issue Type: Improvement > Components: tomcat6, tomcat7 >Reporter: Olivier Lamy >Assignee: Olivier Lamy > Fix For: 2.0 > > > if activated /WEB-INF/lib/*.jar and /WEB-INF/classes will added to web app > classloader when using tomcat*:run -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-100) support war overlay to add war external dependencies in tomcat run
[ https://issues.apache.org/jira/browse/MTOMCAT-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125353#comment-13125353 ] Hudson commented on MTOMCAT-100: Integrated in TomcatMavenPlugin #25 (See [https://builds.apache.org/job/TomcatMavenPlugin/25/]) [MTOMCAT-100] support war overlay to add war external dependencies in tomcat run: tomcat6 support too. [MTOMCAT-100] support war overlay to add war external dependencies in tomcat run. olamy : http://svn.apache.org/viewvc/?view=rev&rev=1182064 Files : * /tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java * /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java olamy : http://svn.apache.org/viewvc/?view=rev&rev=1182063 Files : * /tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/pom.xml * /tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/ClassLoaderEntriesCalculator.java * /tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/ClassLoaderEntriesCalculatorRequest.java * /tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/DefaultClassLoaderEntriesCalculator.java * /tomcat/maven-plugin/trunk/pom.xml * /tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/AbstractRunMojo.java * /tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java * /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java * /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java > support war overlay to add war external dependencies in tomcat run > --- > > Key: MTOMCAT-100 > URL: https://issues.apache.org/jira/browse/MTOMCAT-100 > Project: Maven 2.x Tomcat Plugin > Issue Type: Improvement > Components: tomcat6, tomcat7 >Reporter: Olivier Lamy >Assignee: Olivier Lamy > Fix For: 2.0 > > > if activated /WEB-INF/lib/*.jar and /WEB-INF/classes will added to web app > classloader when using tomcat*:run -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1182067 - /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/pom.xml
Author: olamy Date: Tue Oct 11 20:19:36 2011 New Revision: 1182067 URL: http://svn.apache.org/viewvc?rev=1182067&view=rev Log: upgrade to tomcat core 7.0.22 Modified: tomcat/maven-plugin/trunk/tomcat7-maven-plugin/pom.xml Modified: tomcat/maven-plugin/trunk/tomcat7-maven-plugin/pom.xml URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/pom.xml?rev=1182067&r1=1182066&r2=1182067&view=diff == --- tomcat/maven-plugin/trunk/tomcat7-maven-plugin/pom.xml (original) +++ tomcat/maven-plugin/trunk/tomcat7-maven-plugin/pom.xml Tue Oct 11 20:19:36 2011 @@ -33,7 +33,7 @@ -7.0.21 +7.0.22 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1182064 - in /tomcat/maven-plugin/trunk: tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/
Author: olamy
Date: Tue Oct 11 20:19:12 2011
New Revision: 1182064
URL: http://svn.apache.org/viewvc?rev=1182064&view=rev
Log:
[MTOMCAT-100] support war overlay to add war external dependencies in tomcat
run: tomcat6 support too.
Modified:
tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java
tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java
Modified:
tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java
URL:
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java?rev=1182064&r1=1182063&r2=1182064&view=diff
==
---
tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java
(original)
+++
tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java
Tue Oct 11 20:19:12 2011
@@ -100,6 +100,14 @@ public class RunMojo
*/
private ClassLoaderEntriesCalculator classLoaderEntriesCalculator;
+/**
+ * will add /WEB-INF/lib/*.jar and /WEB-INF/classes from war dependencies
in the webappclassloader
+ *
+ * @parameter expression="${maven.tomcat.addWarDependenciesInClassloader}"
default-value="false"
+ * @since 2.0
+ */
+private boolean addWarDependenciesInClassloader;
+
private File temporaryContextFile = null;
// --
@@ -140,7 +148,9 @@ public class RunMojo
try
{
ClassLoaderEntriesCalculatorRequest request =
-new ClassLoaderEntriesCalculatorRequest().setDependencies(
dependencies ).setLog( getLog() ).setMavenProject( project );
+new ClassLoaderEntriesCalculatorRequest().setDependencies(
dependencies )
+.setLog( getLog() ).setMavenProject( project )
+.setAddWarDependenciesInClassloader(
addWarDependenciesInClassloader );
List classLoaderEntries =
classLoaderEntriesCalculator.calculateClassPathEntries(request);
Modified:
tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java
URL:
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java?rev=1182064&r1=1182063&r2=1182064&view=diff
==
---
tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java
(original)
+++
tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java
Tue Oct 11 20:19:12 2011
@@ -99,7 +99,7 @@ public class RunMojo
private ClassLoaderEntriesCalculator classLoaderEntriesCalculator;
/**
- * FIXME javadoc
+ * will add /WEB-INF/lib/*.jar and /WEB-INF/classes from war dependencies
in the webappclassloader
*
* @parameter expression="${maven.tomcat.addWarDependenciesInClassloader}"
default-value="false"
* @since 2.0
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1182063 - in /tomcat/maven-plugin/trunk: ./ common-tomcat-maven-plugin/ common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/ tomcat6-maven-plugin/src/main/java/org
Author: olamy
Date: Tue Oct 11 20:16:43 2011
New Revision: 1182063
URL: http://svn.apache.org/viewvc?rev=1182063&view=rev
Log:
[MTOMCAT-100] support war overlay to add war external dependencies in tomcat
run.
Added:
tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/ClassLoaderEntriesCalculatorRequest.java
(with props)
Modified:
tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/pom.xml
tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/ClassLoaderEntriesCalculator.java
tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/DefaultClassLoaderEntriesCalculator.java
tomcat/maven-plugin/trunk/pom.xml
tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/AbstractRunMojo.java
tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java
tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java
Modified: tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/pom.xml
URL:
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/pom.xml?rev=1182063&r1=1182062&r2=1182063&view=diff
==
--- tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/pom.xml (original)
+++ tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/pom.xml Tue Oct 11
20:16:43 2011
@@ -41,6 +41,26 @@
+ org.apache.maven
+ maven-archiver
+
+
+
+ org.codehaus.plexus
+ plexus-archiver
+
+
+
+ com.google.guava
+ guava
+
+
+
+ commons-io
+ commons-io
+
+
+
org.apache.tomcat
catalina
6.0.33
@@ -58,6 +78,12 @@
commons-codec
commons-codec
+
+
+ commons-lang
+ commons-lang
+
+
Modified:
tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/ClassLoaderEntriesCalculator.java
URL:
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/ClassLoaderEntriesCalculator.java?rev=1182063&r1=1182062&r2=1182063&view=diff
==
---
tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/ClassLoaderEntriesCalculator.java
(original)
+++
tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/ClassLoaderEntriesCalculator.java
Tue Oct 11 20:16:43 2011
@@ -32,6 +32,6 @@ import java.util.Set;
*/
public interface ClassLoaderEntriesCalculator
{
-List calculateClassPathEntries( MavenProject mavenProject,
Set dependencies, Log log )
+List calculateClassPathEntries(
ClassLoaderEntriesCalculatorRequest classLoaderEntriesCalculatorRequest )
throws TomcatRunException;
}
Added:
tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/ClassLoaderEntriesCalculatorRequest.java
URL:
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/ClassLoaderEntriesCalculatorRequest.java?rev=1182063&view=auto
==
---
tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/ClassLoaderEntriesCalculatorRequest.java
(added)
+++
tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/ClassLoaderEntriesCalculatorRequest.java
Tue Oct 11 20:16:43 2011
@@ -0,0 +1,84 @@
+package org.apache.tomcat.maven.common.run;
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.artifact.Artifact;
+import org.apach
[jira] [Updated] (MTOMCAT-100) support war overlay to add war external dependencies in tomcat run
[ https://issues.apache.org/jira/browse/MTOMCAT-100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy updated MTOMCAT-100: - Component/s: tomcat7 tomcat6 > support war overlay to add war external dependencies in tomcat run > --- > > Key: MTOMCAT-100 > URL: https://issues.apache.org/jira/browse/MTOMCAT-100 > Project: Maven 2.x Tomcat Plugin > Issue Type: Improvement > Components: tomcat6, tomcat7 >Reporter: Olivier Lamy >Assignee: Olivier Lamy > Fix For: 2.0 > > > if activated /WEB-INF/lib/*.jar and /WEB-INF/classes will added to web app > classloader when using tomcat*:run -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Created] (MTOMCAT-100) support war overlay to add war external dependencies in tomcat run
support war overlay to add war external dependencies in tomcat run --- Key: MTOMCAT-100 URL: https://issues.apache.org/jira/browse/MTOMCAT-100 Project: Maven 2.x Tomcat Plugin Issue Type: Improvement Reporter: Olivier Lamy Assignee: Olivier Lamy Fix For: 2.0 if activated /WEB-INF/lib/*.jar and /WEB-INF/classes will added to web app classloader when using tomcat*:run -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46264] Shutting down tomcat with large number of contexts is slow
https://issues.apache.org/bugzilla/show_bug.cgi?id=46264 --- Comment #15 from Pid 2011-10-11 18:05:57 UTC --- There is a new Digester release (3.0), but I have no idea whether it would significantly improve speed and I suspect it's incompatible so could require non-trivial modifications elsewhere. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46264] Shutting down tomcat with large number of contexts is slow
https://issues.apache.org/bugzilla/show_bug.cgi?id=46264 Mark Thomas changed: What|Removed |Added Attachment #27758|0 |1 is obsolete|| --- Comment #14 from Mark Thomas 2011-10-11 17:12:24 UTC --- Created attachment 27761 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27761 Threaded start, stop and deployment for Contexts Updated patch that: - fixes the issues identified by Konstantin - includes a variation of Felix's patch for context.xml parsing - fixes a similar issue with web.xml parsing - fixes an issue that meant the host's executor spun up threads every time it checked for new apps to deploy With this patch applied, I see around 30% improvement in start time for 10s of small, simple applications. This is better, but not the improvement I was hoping for with 4 threads on an 8-core machine. The bulk of the time appears to be spent in XML parsing. I'm continuing to look into to this to see if there is scope for further improvement. Suggestions and/or additional analysis welcome. Note: The overhead of creating a digester per app is noticeable at ~5% so I think it is a price worth paying. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: ApacheMeetupsNa11 tomcat one?
> From: Christopher Schultz [mailto:ch...@christopherschultz.net] > Subject: Re: ApacheMeetupsNa11 tomcat one? > On 10/11/2011 4:04 AM, jean-frederic clere wrote: > > Do we want to "organize" a Tomcat meetup during the ApacheCon? > I'll be there. Moi aussi, although only at ApacheCon on Thursday and Friday. We will be in the Vancouver area for the next week. - Chuck
DO NOT REPLY [Bug 51862] JreMemoryLeakPreventionListener enhancement to load configurable classes
https://issues.apache.org/bugzilla/show_bug.cgi?id=51862 --- Comment #3 from Christopher Schultz 2011-10-11 15:50:29 UTC --- It seems like this feature could be used to reduce the amount of code in JMLPL by providing a default list of classes to load, since that's mainly what's going on in there. Is that worth it, or is it better to handle the cases we already handle and leave this feature for use with webapp-specific (e.g. private) classes? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: ApacheMeetupsNa11 tomcat one?
Jean-Frederic, On 10/11/2011 4:04 AM, jean-frederic clere wrote: > Do we want to "organize" a Tomcat meetup during the ApacheCon? +1 I'll be there. Though the content last year was rather thin, it was nice to meet Keiichi there. I'd be happy to have a meet-up at Whistler (local ski resort), too, if anyone is interested. -chris signature.asc Description: OpenPGP digital signature
DO NOT REPLY [Bug 46264] Shutting down tomcat with large number of contexts is slow
https://issues.apache.org/bugzilla/show_bug.cgi?id=46264 --- Comment #13 from Mark Thomas 2011-10-11 15:17:17 UTC --- I've fixed the +/- issue locally and will include that in the next version of the patch. Thanks Konstantin for the catch. Felix, I think you have found one of the places where it is assumed context's are processed serially. I'm pretty sure there will be others or places where multiple threads don't help because of syncs (e.g. processing web.xml) I'll take a look through the Context init code and see what I can find. I'll include any fixes in the next version of the patch. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46264] Shutting down tomcat with large number of contexts is slow
https://issues.apache.org/bugzilla/show_bug.cgi?id=46264 Felix Schumacher changed: What|Removed |Added Attachment #27759|0 |1 is obsolete|| --- Comment #12 from Felix Schumacher 2011-10-11 14:49:21 UTC --- Created attachment 27760 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27760 make ContextConfig threadsafe Since Mark's patch is more elegant and complete than mine, it makes mine obsolete. But it has the same problem with the missing threadsafety of ContextConfig. The attached patch makes Digester a member variable and the initialization more correct. With that I haven't seen an exception (yet). -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Plans for 6.0.next?
Hi! Now that JavaOne is over and people are back to their homes, maybe it is time to roll 6.0.34? There were not many changes, but there was a fix for CVE-2011-3190 among them. Regarding the items currently in STATUS: the fixes for BZ 51872, 51905 are important and need votes. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46264] Shutting down tomcat with large number of contexts is slow
https://issues.apache.org/bugzilla/show_bug.cgi?id=46264 Felix Schumacher changed: What|Removed |Added Attachment #27755|0 |1 is obsolete|| --- Comment #11 from Felix Schumacher 2011-10-11 13:53:26 UTC --- Created attachment 27759 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27759 starting contexts in parallel using an executor In my testings, I have found that my patch sometimes throws exception deep inside tomcat. Those seem to come from incorrect locking of the digester in ContextConfig. I have corrected the initialization, so that findbugs is happy. But while testing while writing this I got: java.lang.NullPointerException at org.apache.tomcat.util.digester.Digester.startElement(Digester.java:1231) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(AbstractSAXParser.java:501) at com.sun.org.apache.xerces.internal.parsers.AbstractXMLDocumentParser.emptyElement(AbstractXMLDocumentParser.java:179) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanStartElement(XMLDocumentFragmentScannerImpl.java:1343) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:2755) at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:648) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:511) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:808) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:737) at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:119) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1205) at com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:522) at org.apache.tomcat.util.digester.Digester.parse(Digester.java:1537) at org.apache.catalina.startup.ContextConfig.processContextConfig(ContextConfig.java:650) at org.apache.catalina.startup.ContextConfig.contextConfig(ContextConfig.java:607) at org.apache.catalina.startup.ContextConfig.init(ContextConfig.java:845) at org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfig.java:340) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119) at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:90) at org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:389) at org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:110) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:139) at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:812) at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:787) at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:655) at org.apache.catalina.startup.HostConfig.deployDescriptor(HostConfig.java:653) at org.apache.catalina.startup.HostConfig$1.run(HostConfig.java:563) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:619) after that the digester seems to be unusable and I get following: org.xml.sax.SAXException: FWK005 parse may not be called while parsing. at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1245) at com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:522) at org.apache.tomcat.util.digester.Digester.parse(Digester.java:1537) at org.apache.catalina.startup.ContextConfig.processContextConfig(ContextConfig.java:650) at org.apache.catalina.startup.ContextConfig.contextConfig(ContextConfig.java:587) at org.apache.catalina.startup.ContextConfig.init(ContextConfig.java:845) at org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfig.java:340) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119) at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:90) at org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:389) at org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:110) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:139)
DO NOT REPLY [Bug 46264] Shutting down tomcat with large number of contexts is slow
https://issues.apache.org/bugzilla/show_bug.cgi?id=46264 --- Comment #10 from Konstantin Kolinko 2011-10-11 13:48:19 UTC --- (In reply to comment #9) +// Zero == Runtime.getRuntime().availableProcessors() +// -ve == Runtime.getRuntime().availableProcessors() - value +// These two are the same +result = Runtime.getRuntime().availableProcessors() - result; result is negative, so it gets more threads than processors? You would want "+ result" here and "+ value" in the comment and in docs. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46264] Shutting down tomcat with large number of contexts is slow
https://issues.apache.org/bugzilla/show_bug.cgi?id=46264 --- Comment #9 from Mark Thomas 2011-10-11 13:39:57 UTC --- Created attachment 27758 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27758 Threaded start, stop and deployment fo Contexts This proposed patch (against trunk) provides threaded start/stop for Contexts and Hosts and threaded deployment for Contexts. It builds on the previous suggested patches and the discussion on the users mailing list. The patch is provided for review and feedback. It will be amended or committed based on the feedback received. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52011] Importing library Jollyday
https://issues.apache.org/bugzilla/show_bug.cgi?id=52011 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID OS/Version||All --- Comment #1 from Konstantin Kolinko 2011-10-11 13:32:39 UTC --- I do not see any infinite loop. There is a problem with this library though: It contains logging.properties with .level = ALL If the library is placed into Tomcat's /lib folder or in WEB-INF/lib in a webapp, Tomcat will load the file and will start generate tons of debug logs. According to that configuration file the logs are printed to the console only and not to any proper logging file. This behaviour is by design. A workaround is to copy the default logging.properties file into the lib folder as well, as it will take priority over the one provided by the library. Though better solution is to repack the library and ask its authors to fix it. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1181772 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Tue Oct 11 13:20:13 2011 New Revision: 1181772 URL: http://svn.apache.org/viewvc?rev=1181772&view=rev Log: Add followup fix and trunk revision numbers. I am not voting for this yet - see https://issues.apache.org/bugzilla/show_bug.cgi?id=51940#c9 It is broken in trunk, though 6.0 is not affected. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1181772&r1=1181771&r2=1181772&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Oct 11 13:20:13 2011 @@ -115,6 +115,8 @@ PATCHES PROPOSED TO BACKPORT: requests since any HTTP method may include a body. Based on a patch by Nicholas Sushkin http://svn.apache.org/viewvc?rev=1181030&view=rev + http://svn.apache.org/viewvc?rev=1181137&view=rev + (1181028,1181136 in trunk) +1: markt -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51940] Form Authentication Valve should restore request body on PUT method
https://issues.apache.org/bugzilla/show_bug.cgi?id=51940
--- Comment #9 from Konstantin Kolinko 2011-10-11
13:15:18 UTC ---
1. I tried to test this in trunk, and replaying a POST request fails for me.
Using the following standalone HTML page:
[[[
http://localhost:8080/examples/jsp/security/protected/index.jsp";
method="POST">
]]]
- Configure a sample user with a role of "tomcat" and start Tomcat
- Start a new web browser and load the above page
- Type "aaa" and press submit.
- Respond to FORM authentication.
- The protected page is displayed.
Expected: "You have not been granted role "
Actual: no such message.
I tried to debug this, but I do not see anything wrong in FormAuthenticator.
The body and method were saved and restored. Request#parametersParsed was
false.
Then, setting a breakpoint in Request#parseParameters() I see that
Request#usingInputStream is true and thus parseParameters() exits early.
This is reproducible in 7.0.22.
This does not happen in 6.0.33 - it replays POSTs correctly.
2. request.getCoyoteRequest().method().setString("GET");
is seen as GET in access log. Not much of an issue though, as anyway we return
not what was originally requested by client.
I think that to fix this one can restore the original method in
FormAuthenticator#forwardToLoginPage(..) when disp.forward() call returns.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52011] New: Importing library Jollyday
https://issues.apache.org/bugzilla/show_bug.cgi?id=52011 Bug #: 52011 Summary: Importing library Jollyday Product: Tomcat 7 Version: 7.0.22 Platform: PC Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: zanderbo...@gmx.de Classification: Unclassified I need the library Jollyday for my web application (http://sourceforge.net/projects/jollyday/) But Tomcat seems to have problems with importing the jollyday-0.4.4.jar and ends in an infinite loop. Copying jollyday-0.4.4.jar to the lib directory of Tomcat will cause this loop. jollyday-0.4.4.jar contains lots of XML files and this will be the problem. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1181749 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/HostConfig.java java/org/apache/catalina/startup/LocalStrings.properties webapps/docs/changelog.xml
Author: markt Date: Tue Oct 11 12:23:10 2011 New Revision: 1181749 URL: http://svn.apache.org/viewvc?rev=1181749&view=rev Log: Simplify deployment code Use full paths in log messages to remove ambiguity Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/HostConfig.java tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/LocalStrings.properties tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc7.0.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Tue Oct 11 12:23:10 2011 @@ -1 +1 @@ -/tomcat/trunk:1156115,1156171,1156276,1156304,1156519,1156530,1156602,1157015,1157018,1157151,1157198,1157204,1157810,1157832,1157834,1157847,1157908,1157939,1158155,1158160,1158176,1158195,1158198-1158199,1158227,1158331,1158334-1158335,1158426,1160347,1160592,1160611,1160619,1160626,1160639,1160652,1160720-1160721,1160772,1160774,1160776,1161303,1161310,1161322,1161339,1161486,1161540,1161549,1161584,1162082,1162149,1162169,1162721,1162769,1162836,1162932,1163630,1164419,1164438,1164469,1164480,1164567,1165234,1165247-1165248,1165253,1165273,1165282,1165309,1165331,1165338,1165347,1165360-1165361,1165367-1165368,1165602,1165608,1165677,1165693,1165721,1165723,1165728,1165730,1165738,1165746,1165765,1165777,1165918,1165921,1166077,1166150-1166151,1166290,1166366,1166620,1166686,1166752,1166757,1167368,1167394,1169447,1170647,1171692,1172233-1172234,1172236,1172269,1172278,1172282,1172610,1172664,1172689,1172711,1173020-1173021,1173082,1173088,1173090,1173096,1173241,1173256 ,1173288,117,1173342,1173461,1173614,1173630,1173659,1173722,1174061,1174239,1174322,1174325,1174329-1174330,1174337-1174339,1174343,1174353,1174799,1174882,1174884,1174983,1175155,1175158,1175167,1175182,1175190,1175201,1175272,1175275,1175283,1175582,1175589-1175590,1175594,1175602,1175613,1175633,1175690,1175713,1175889,1175896,1175907,1176584,1176590,1176799,1177050,1177060,1177125,1177152,1177160,1177245,1177850,1177862,1177978,1178209,1178228,1178233,1178449,1178542,1178681,1178721,1180261,1180907,1181028,1181123,1181125,1181136 +/tomcat/trunk:1156115,1156171,1156276,1156304,1156519,1156530,1156602,1157015,1157018,1157151,1157198,1157204,1157810,1157832,1157834,1157847,1157908,1157939,1158155,1158160,1158176,1158195,1158198-1158199,1158227,1158331,1158334-1158335,1158426,1160347,1160592,1160611,1160619,1160626,1160639,1160652,1160720-1160721,1160772,1160774,1160776,1161303,1161310,1161322,1161339,1161486,1161540,1161549,1161584,1162082,1162149,1162169,1162721,1162769,1162836,1162932,1163630,1164419,1164438,1164469,1164480,1164567,1165234,1165247-1165248,1165253,1165273,1165282,1165309,1165331,1165338,1165347,1165360-1165361,1165367-1165368,1165602,1165608,1165677,1165693,1165721,1165723,1165728,1165730,1165738,1165746,1165765,1165777,1165918,1165921,1166077,1166150-1166151,1166290,1166366,1166620,1166686,1166752,1166757,1167368,1167394,1169447,1170647,1171692,1172233-1172234,1172236,1172269,1172278,1172282,1172610,1172664,1172689,1172711,1173020-1173021,1173082,1173088,1173090,1173096,1173241,1173256 ,1173288,117,1173342,1173461,1173614,1173630,1173659,1173722,1174061,1174239,1174322,1174325,1174329-1174330,1174337-1174339,1174343,1174353,1174799,1174882,1174884,1174983,1175155,1175158,1175167,1175182,1175190,1175201,1175272,1175275,1175283,1175582,1175589-1175590,1175594,1175602,1175613,1175633,1175690,1175713,1175889,1175896,1175907,1176584,1176590,1176799,1177050,1177060,1177125,1177152,1177160,1177245,1177850,1177862,1177978,1178209,1178228,1178233,1178449,1178542,1178681,1178721,1180261,1180907,1181028,1181123,1181125,1181136,1181291,1181743 Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/HostConfig.java URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/HostConfig.java?rev=1181749&r1=1181748&r2=1181749&view=diff == --- tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/HostConfig.java (original) +++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/HostConfig.java Tue Oct 11 12:23:10 2011 @@ -522,16 +522,15 @@ public class HostConfig // Deploy XML descriptors from configBase File xml = new File(configBase, baseName + ".xml"); if (xml.exists()) -deployDescriptor(cn, xml, baseName + ".xml"); +deployDescriptor(cn, xml); // Deploy WARs, and loop if additional descriptors are found File war = new File(appBase, baseName + ".war"); if (war.exists()) -deployWAR(cn, war, baseName + ".war"); +deployWAR(cn, war); // Deploy expanded folders File dir = new File(appBase, baseName); if (dir.exists()) -deployDirectory(cn, dir, baseName); - +deployDirectory(cn, dir); } @
svn commit: r1181743 - in /tomcat/trunk/java/org/apache/catalina/startup: HostConfig.java LocalStrings.properties
Author: markt
Date: Tue Oct 11 12:15:44 2011
New Revision: 1181743
URL: http://svn.apache.org/viewvc?rev=1181743&view=rev
Log:
Simplify deployment code
Use full paths in log messages to remove ambiguity
Modified:
tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java
tomcat/trunk/java/org/apache/catalina/startup/LocalStrings.properties
Modified: tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java?rev=1181743&r1=1181742&r2=1181743&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java Tue Oct 11
12:15:44 2011
@@ -500,16 +500,15 @@ public class HostConfig
// Deploy XML descriptors from configBase
File xml = new File(configBase, baseName + ".xml");
if (xml.exists())
-deployDescriptor(cn, xml, baseName + ".xml");
+deployDescriptor(cn, xml);
// Deploy WARs, and loop if additional descriptors are found
File war = new File(appBase, baseName + ".war");
if (war.exists())
-deployWAR(cn, war, baseName + ".war");
+deployWAR(cn, war);
// Deploy expanded folders
File dir = new File(appBase, baseName);
if (dir.exists())
-deployDirectory(cn, dir, baseName);
-
+deployDirectory(cn, dir);
}
@@ -531,9 +530,7 @@ public class HostConfig
if (isServiced(name))
continue;
-String file = files[i];
-
-deployDescriptor(cn, contextXml, file);
+deployDescriptor(cn, contextXml);
}
}
}
@@ -542,9 +539,8 @@ public class HostConfig
/**
* @param cn
* @param contextXml
- * @param file
*/
-protected void deployDescriptor(ContextName cn, File contextXml, String
file) {
+protected void deployDescriptor(ContextName cn, File contextXml) {
if (deploymentExists(cn.getName())) {
return;
}
@@ -553,8 +549,8 @@ public class HostConfig
// Assume this is a configuration descriptor and deploy it
if(log.isInfoEnabled()) {
-log.info(sm.getString("hostConfig.deployDescriptor", file,
-configBase.getPath()));
+log.info(sm.getString("hostConfig.deployDescriptor",
+contextXml.getAbsolutePath()));
}
Context context = null;
@@ -563,8 +559,9 @@ public class HostConfig
try {
context = (Context) digester.parse(contextXml);
if (context == null) {
-
log.error(sm.getString("hostConfig.deployDescriptor.error",
-file));
+log.error(sm.getString(
+"hostConfig.deployDescriptor.error",
+contextXml.getAbsolutePath()));
return;
}
} finally {
@@ -656,7 +653,7 @@ public class HostConfig
} catch (Throwable t) {
ExceptionUtils.handleThrowable(t);
log.error(sm.getString("hostConfig.deployDescriptor.error",
- file), t);
+ contextXml.getAbsolutePath()), t);
}
if (context != null && host.findChild(context.getName()) != null) {
@@ -696,7 +693,7 @@ public class HostConfig
if (isServiced(cn.getName()))
continue;
-deployWAR(cn, dir, files[i]);
+deployWAR(cn, dir);
}
}
}
@@ -741,9 +738,8 @@ public class HostConfig
/**
* @param cn
* @param war
- * @param file
*/
-protected void deployWAR(ContextName cn, File war, String file) {
+protected void deployWAR(ContextName cn, File war) {
if (deploymentExists(cn.getName()))
return;
@@ -755,12 +751,10 @@ public class HostConfig
BufferedOutputStream ostream = null;
File xml;
if (copyXML) {
-xml = new File(configBase(),
-file.substring(0, file.lastIndexOf(".")) + ".xml");
+xml = new File(configBase(), cn.getBaseName() + ".xml");
} else {
xml = new File(host.getAppBaseFile(),
-file.substring(0, file.lastIndexOf(".")) +
-"/META-INF/context.xml");
+cn.getBaseName() + "/META-INF/context.xml");
}
boolean xmlInWar = false;
@@ -826,7 +820,8 @@ public class HostConfig
// Deploy the application in this WAR file
if(log.isInfoEnabled())
-
Re: [RFC] Netmask-based filter and valve
On Tue, Oct 11, 2011 at 13:59, Tim Funk wrote:
> Looks ok ... a few comments.
>
> RemoteCIDRFilter (most of the below apply to the valve too)
>
> setAllow = If nothing passed - This should clear allow
> setAllow = If a bad "allow" is passed - throw exception. I'd think throwing
> an IllegalArgumentException is OK so no catch is needed. Depending on when
> this is called ... throwing an UnavailableException might cause enough
> disruption to disable the webapp too. (depending on the exception
> propagation)
>
> setAllow,setDeny - Should all the netmasks be verified before before
> internal allow/deny is updated? If can be possible that only some masks are
> applied before exception is thrown. Which causes a partial mask to be
> working. Of course ... if the exception is thrown and the webapp is
> disabled... this might not be an issue.
>
> setAllow,setDeny - call clear() before adding new values. With
> embdedding,JMX etc - these can be called multiple times with different
> values post startup.
>
> getAllow/getDeny - Needs tweaked since most would assume the output of
> getAllow() can be used to do setAllow(). By using List.toString() - [] would
> be added.
>
Yes, I was kind of wondering whether the .get*() methods required
symmetry with .put*(). So, this is one of my questions answered.
Along with the question of why Remote{Host,Addr}Filter cleared allow
and deny before assigning them...
I'll rework this part, along with exception handling.
Thanks for the comments,
--
Francis Galiegue, fgalie...@gmail.com
"It seems obvious [...] that at least some 'business intelligence'
tools invest so much intelligence on the business side that they have
nothing left for generating SQL queries" (Stéphane Faroult, in "The
Art of SQL", ISBN 0-596-00894-5)
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [RFC] Netmask-based filter and valve
Looks ok ... a few comments.
RemoteCIDRFilter (most of the below apply to the valve too)
setAllow = If nothing passed - This should clear allow
setAllow = If a bad "allow" is passed - throw exception. I'd think throwing
an IllegalArgumentException is OK so no catch is needed. Depending on when
this is called ... throwing an UnavailableException might cause enough
disruption to disable the webapp too. (depending on the exception
propagation)
setAllow,setDeny - Should all the netmasks be verified before before
internal allow/deny is updated? If can be possible that only some masks are
applied before exception is thrown. Which causes a partial mask to be
working. Of course ... if the exception is thrown and the webapp is
disabled... this might not be an issue.
setAllow,setDeny - call clear() before adding new values. With
embdedding,JMX etc - these can be called multiple times with different
values post startup.
getAllow/getDeny - Needs tweaked since most would assume the output of
getAllow() can be used to do setAllow(). By using List.toString() - [] would
be added.
-Tim
On Mon, Oct 10, 2011 at 2:22 PM, Francis Galiegue wrote:
> Hello list,
>
> Frustrated by the limitations of existing
> Remote{Addr,Host}{Filter,Valve}, I have coded an implementation of a
> Filter and Valve doing netmask-based matching. These valves can also
> do IP-based matching (just don't specify a netmask).
>
> Having quite some difficulties writing unit tests for now, I have
> instead tried it in "real life" situations, that is using both in a
> temporary install on both IPv4 and IPv6. They both work.
>
> But I need help. Not only with writing unit tests, which for now only
> exist for the base NetMask class, but also for error handling (what
> should be done when an illegal netmask is supplied, etc).
>
> You can see the whole patch here:
>
>
> https://github.com/fge/tomcat70/commit/79e276d13ba804d0ae06c75592d0364cb2110285
>
>
>
Re: [RFC] Netmask-based filter and valve
On Tue, Oct 11, 2011 at 11:41, Konstantin Kolinko wrote: > 2011/10/10 Francis Galiegue : >> error handling (what >> should be done when an illegal netmask is supplied, etc). > > I think the called method should fail with some RuntimeException. > > That is what will happen with existing RemoteAddrValve if you pass a > value that Pattern.compile() cannot handle. (See > RequestFilterValve#setAllow(String)). > > It would not be safe to operate a Valve that is misconfigured. > OK, I will update the code, post an updated version in the Bugzilla entry and add more questions over there (#51953). -- Francis Galiegue, fgalie...@gmail.com "It seems obvious [...] that at least some 'business intelligence' tools invest so much intelligence on the business side that they have nothing left for generating SQL queries" (Stéphane Faroult, in "The Art of SQL", ISBN 0-596-00894-5) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51862] JreMemoryLeakPreventionListener enhancement to load configurable classes
https://issues.apache.org/bugzilla/show_bug.cgi?id=51862 Konstantin Kolinko changed: What|Removed |Added Platform|Macintosh |All --- Comment #2 from Konstantin Kolinko 2011-10-11 11:33:18 UTC --- Added to 6.0 in r1181719 and will be in 6.0.34. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1181719 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java java/org/apache/catalina/core/LocalStrings.properties webapps/docs/cha
Author: kkolinko Date: Tue Oct 11 11:30:03 2011 New Revision: 1181719 URL: http://svn.apache.org/viewvc?rev=1181719&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51862 JreMemoryLeakPreventionListener enhancement to load configurable classes Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/LocalStrings.properties tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml tomcat/tc6.0.x/trunk/webapps/docs/config/listeners.xml Propchange: tomcat/tc6.0.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Tue Oct 11 11:30:03 2011 @@ -1 +1 @@ -/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,752323,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,77 0809,770876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,8901 39,890265,890349-890350,890417,891185-891187,891583,892198,892341,892415,892464,892555,892812,892814,892817,892843,892887,893321,893493,894580,894586,894805,894831,895013,895045,895057,895191,895392,895703,896370,896384,897380-897381,897776,898126,898256,898468,898527,898555,898558,898718,898836,898906,899284,899348,899420,899653,899769-899770,899783,899788,899792,899916,899918-899919,899935,899949,903916,905020,905151,905722,905728,905735,907311,907513,907538,907652,907819,907825,907864,908002,908721,908754,908759,909097,909206,909212,909525,909636,909869,909875,909887,910266,910370,910442,910471,910485,910974,915226,915737,915861,916097,916141,916157,916170,917598,917633,918093,918489,918594,918684,918787,918792,918799,918803,918885,919851,919914,920025,920055,920298,920449,920596,920824,920840,921444,922010,926716,927062,927621,928482,928695,928732,928798,931709,932357,932967,935105,935983,939491,939551,940064,941356,941463,943112,944409,944416,945231,945808,945835,945841 ,946686,948057,950164,950596,950614,950851,950905,951615,953434,954435,955648,955655,956832,957130,957830,958192,960701,961948,962865,962872,962881,962900,963106,963865,963868,964614,966177-966178,966292,966692,966863,981815,988448,991837,993042,1001955,1002185,1002263,1002274,1002349,1002359,1002362,1002481,1002514,1003461,1003481,1003488,1003556,1003572,1003581,1003861,1004393,1004409,1004415,1004868-1004869,1004912,1005452,1005467,1005647,1005802,1022120,1022134,1022323,1022415,1022606,1022623,1024224,1024251,1026042,1026784,1026912,1026920,1029767,1033415,1033448,1033842,1033897,1037715,1037794,1037887,1037924,1038041,1042022,1042029,1042447,1042452,1042494,1044944,1044987,1050249,1055055,1055236,1055458,1055975,1056264,1056828,1056889,1059881,1061412,1061442,1061446,1062398,1064652,1066244,1066772,1067039,1067139,1069824,1070139,1070420,1070609,1072042,1073393,1075458,1076212,1078409,1078412,1079801,1081334,1088179,1088460,1090022,1094069,1094089,1095138,1097899,1099575 ,1099586,1099772,1099789,1100145,1100822,1101094,1101144,1124680,1130774,1133014,1137862,1137996,1138950,1138953,1140693,1141104,1141441,1142043,1142904,1143134,1143150,1148216,1148471,1152601,
DO NOT REPLY [Bug 46264] Shutting down tomcat with large number of contexts is slow
https://issues.apache.org/bugzilla/show_bug.cgi?id=46264 --- Comment #8 from Mark Thomas 2011-10-11 11:02:10 UTC --- I'm currently working on combining these two patches into a complete solution that covers multi-threaded deployment, and container start and stop. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [RFC] Netmask-based filter and valve
2011/10/10 Francis Galiegue : > error handling (what > should be done when an illegal netmask is supplied, etc). I think the called method should fail with some RuntimeException. That is what will happen with existing RemoteAddrValve if you pass a value that Pattern.compile() cannot handle. (See RequestFilterValve#setAllow(String)). It would not be safe to operate a Valve that is misconfigured. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [RFC] Netmask-based filter and valve
Hi, that looks good, arrange the formatting and create a bugzilla so it is not forgotten. Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52009] NPE exception in org.apache.catalina.connector.CoyoteAdapter.service
https://issues.apache.org/bugzilla/show_bug.cgi?id=52009 viola.lu changed: What|Removed |Added CC||viola...@gmail.com -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52009] New: NPE exception in org.apache.catalina.connector.CoyoteAdapter.service
https://issues.apache.org/bugzilla/show_bug.cgi?id=52009 Bug #: 52009 Summary: NPE exception in org.apache.catalina.connector.CoyoteAdapter.service Product: Tomcat 7 Version: 7.0.22 Platform: PC OS/Version: Windows XP Status: NEW Severity: major Priority: P2 Component: Connectors AssignedTo: dev@tomcat.apache.org ReportedBy: viola...@gmail.com Classification: Unclassified 1. I copied activemq-all-5.4.2.jar, commons-logging-1.1.jar to tomcat lib folder 2. Edit tomcat-user.xml, context.xml, server.xml as below: Changes in server.xml: Changes in context.xml You can also get these file from attached zip Then access http://localhost:8080/manager/text/resources, got three JMS resource i defined OK - Listed global resources of all types jms/topic/MyTopic:org.apache.activemq.command.ActiveMQTopic jms/queue/MyQueue:org.apache.activemq.command.ActiveMQQueue jms/broker:org.apache.activemq.ActiveMQConnectionFactory UserDatabase:org.apache.catalina.users.MemoryUserDatabase 3. Start apache-activemq-5.4.2, create topic APP.JMS.TOPIC, and queque: APP.JMS.QUEUE 4. Put sample files QuoteStreamerApp.war as attached in webapp folder, then it will report errors, but if don't define NIO connector, this error doesn't exist 2011-10-11 15:53:01 org.apache.catalina.startup.HostConfig checkResources INFO: Undeploying context [/QuoteStreamerApp] 2011-10-11 15:53:11 org.apache.catalina.startup.HostConfig deployWAR INFO: Deploying web application archive QuoteStreamerApp.war 2011-10-11 15:53:52 com.ibm.websphere.webmsg.quotestreamer.AppInit init INFO: DataSimulator successfully created and set and started. 2011-10-11 15:54:01 com.ibm.webmsg.example.StockServlet setProperties INFO: Configured properties for quote streamer requests. 2011-10-11 15:54:02 com.ibm.webmsg.example.StockServlet registerURL INFO: Registered the URL for comet requests. 2011-10-11 15:54:02 org.apache.coyote.http11.AbstractHttp11Processor process SEVERE: Error processing request java.lang.NullPointerException at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:436) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:970) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:515) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1550) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:662) 2011-10-11 15:54:02 org.apache.coyote.http11.AbstractHttp11Processor process SEVERE: Error processing request java.lang.NullPointerException at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:436) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:970) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:515) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1550) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:662) 2011-10-11 15:54:04 org.apache.coyote.http11.AbstractHttp11Processor process SEVERE: Error processing request java.lang.NullPointerException at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:436) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:970) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:515) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1550) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:662) 2011-10-11 15:54:04 org.apache.coyote.http11.AbstractHttp11Processor process SEVERE: Error processing request java.lang.NullPointerException at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:436) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:970) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:515) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1550) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:662) -- Configure bugmail: https://
ApacheMeetupsNa11 tomcat one?
Hi, Do we want to "organize" a Tomcat meetup during the ApacheCon? See http://wiki.apache.org/apachecon/ApacheMeetupsNa11 for space and already used slots. Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
