Re: [ANN] New committer: Konstantin Preißer

[Henri Gomez]

Welcome Konstantin

Nice to see than such a venerable project like Tomcat still attract new
commiters :)


2013/9/25 Mark Thomas 

> On behalf of the Tomcat committers I am pleased to announce that
> Konstantin Preißer has been voted in as a new Tomcat committer.
>
> In addition to a number of high quality bug reports and patches,
> Konstantin is also responsible for the makeover the Tomcat web site and
> Tomcat 8 documentation has received.
>
> Please join me in welcoming him.
>
> Regards,
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

[GUMP@vmgump]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed

[Bill Barker]

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc7.0.x-validate has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 83 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc7.0.x-validate :  Tomcat 7.x, a web server implementing Java 
Servlet 3.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-validate/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on checkstyle exists, no need to add for property 
checkstyle.jar.
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-validate/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-validate.html
Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-validate (Type: Build)
Work ended in a state of : Failed
Elapsed: 17 secs
Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-5.7-SNAPSHOT.jar
 -Dexecute.validate=true validate 
[Working Directory: /srv/gump/public/workspace/tomcat-7.0.x]
CLASSPATH: 
/usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.7-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20130925.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/exec/tar
 
get/commons-exec-1.1.1-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-20130925.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20130925.jar:/srv/gump/public/workspace/apache-commons/validator/dist/commons-validator-20130925.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-16.0-SNAPSHOT.jar
-
Buildfile: /srv/gump/public/workspace/tomcat-7.0.x/build.xml

build-prepare:
   [delete] Deleting directory 
/srv/gump/public/workspace/tomcat-7.0.x/output/build/temp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-7.0.x/output/build/temp

compile-prepare:

download-validate:

proxyflags:

setproxy:

testexist:
 [echo] Testing  for 
/srv/gump/public/workspace/checkstyle/target/checkstyle-5.7-SNAPSHOT.jar

downloadzip:

validate:
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-7.0.x/output/res/checkstyle
[checkstyle] Running Checkstyle 5.7-SNAPSHOT on 2529 files
[checkstyle] 
/srv/gump/public/workspace/tomcat-7.0.x/res/maven/mvn-pub.xml:312:3: File 
contains tab characters (this is the first instance).

BUILD FAILED
/srv/gump/public/workspace/tomcat-7.0.x/build.xml:472: Got 1 errors and 0 
warnings.

Total time: 17 seconds
-

To subscribe to this information via syndicated feeds:
- RSS: 
http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-validate/rss.xml
- Atom: 
http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-validate/atom.xml

== Gump Tracking Only ===
Produced by Apache Gump(TM) version 2.3.
Gump Run 2013092505, vmgump.apache.org:vmgump:2013092505
Gump E-mail Identifier (unique within run) #4.

--
Apache Gump
http://gump.apache.org/ [Instance: vmgump]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1526052 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

[markt]

Author: markt
Date: Tue Sep 24 23:50:09 2013
New Revision: 1526052

URL: http://svn.apache.org/r1526052
Log:
Removal of a socket from the poller needs to happen on the poller thread as 
removal, like addition, is not thread safe.
Removal of a socket from the poller needs to remove the socket from the 
addListif it is present otherwise the closed socket could end up in the poller.

Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=1526052&r1=1526051&r2=1526052&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Tue Sep 24 
23:50:09 2013
@@ -907,7 +907,7 @@ public class AprEndpoint extends Abstrac
 // countDownConnection() in that case
 Poller poller = this.poller;
 if (poller != null) {
-poller.removeFromPoller(socket);
+poller.remove(socket);
 }
 connections.remove(Long.valueOf(socket));
 destroySocket(socket, running);
@@ -1220,6 +1220,19 @@ public class AprEndpoint extends Abstrac
 }
 }
 
+public boolean remove(long socket) {
+for (int i = 0; i < size; i++) {
+if (sockets[i] == socket) {
+sockets[i] = sockets[size - 1];
+timeouts[i] = timeouts[size - 1];
+flags[size] = flags[size -1];
+size--;
+return true;
+}
+}
+return false;
+}
+
 public void duplicate(SocketList copy) {
 copy.size = size;
 copy.pos = pos;
@@ -1276,6 +1289,12 @@ public class AprEndpoint extends Abstrac
 
 
 /**
+ * List of sockets to be removed from the poller.
+ */
+private SocketList removeList = null;
+
+
+/**
  * Structure used for storing timeouts.
  */
 private SocketTimeouts timeouts = null;
@@ -1349,6 +1368,7 @@ public class AprEndpoint extends Abstrac
 desc = new long[actualPollerSize * 2];
 connectionCount = 0;
 addList = new SocketList(defaultPollerSize);
+removeList = new SocketList(defaultPollerSize);
 }
 
 
@@ -1464,8 +1484,10 @@ public class AprEndpoint extends Abstrac
 }
 }
 
+
 /**
- * Add specified socket to one of the pollers.
+ * Add specified socket to one of the pollers. Must only be called from
+ * {@link Poller#run()}.
  */
 private boolean addToPoller(long socket, int events) {
 int rv = -1;
@@ -1482,10 +1504,19 @@ public class AprEndpoint extends Abstrac
 return false;
 }
 
+
+protected void remove(long socket) {
+synchronized (this) {
+removeList.add(socket, 0, 0);
+}
+}
+
+
 /**
- * Remove specified socket from the pollers.
+ * Remove specified socket from the pollers. Must only be called from
+ * {@link Poller#run()}.
  */
-protected boolean removeFromPoller(long socket) {
+private boolean removeFromPoller(long socket) {
 int rv = -1;
 for (int i = 0; i < pollers.length; i++) {
 if (pollerSpace[i] < actualPollerSize) {
@@ -1560,7 +1591,7 @@ public class AprEndpoint extends Abstrac
 
 int maintain = 0;
 SocketList localAddList = new SocketList(getMaxConnections());
-
+SocketList localRemoveList = new SocketList(getMaxConnections());
 
 // Loop until we receive a shutdown command
 while (pollerRunning) {
@@ -1598,7 +1629,18 @@ public class AprEndpoint extends Abstrac
 }
 
 try {
-// Add sockets which are waiting to the poller
+// Duplicate the add and remove lists so that the syncs are
+// minimised
+if (removeList.size() > 0) {
+synchronized (this) {
+// Duplicate to another list, so that the syncing 
is
+// minimal
+removeList.duplicate(localRemoveList);
+removeList.clear();
+}
+} else {
+localAddList.clear();
+}
 if (addList.size() > 0) {
 synchronized (this) {
 // Duplicate to another list, so that the syncing 
is
@@ -1606,6 +1648,22 @@ public class AprEndpoint extends Abstrac
 

Re: Issue in AprEndpoint detected by TestCoyoteAdapter

[Mark Thomas]

On 24/09/2013 16:19, Mark Thomas wrote:
> On 24/09/2013 08:16, Mark Thomas wrote:
>> On 23/09/2013 00:54, Rainer Jung wrote:
>>
>>> I agree that there's probably another problem further up the stack.
>>
>> I'm looking at this now.
> 
> I've found a couple of issues. Not sure if either of these are the root
> cause of the remaining issues we see but I'll look into fixing them.
> 
> - AprEndpoint.destroySocket() calls Poller.removeFromPoller() but that
>   call isn't thread safe. I think we need a remove process similar to
>   the add process.
> - sockets are not always removed from the timeout list when they are
>   destroyed

Fixed.

Rainer, over to you.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1525975 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

[Olivier Lamy]

Welcome!

On 25 September 2013 05:10,   wrote:
> Author: kpreisser
> Date: Tue Sep 24 19:10:44 2013
> New Revision: 1525975
>
> URL: http://svn.apache.org/r1525975
> Log:
> Add myself to the committers list.
>
> Modified:
> tomcat/site/trunk/docs/whoweare.html
> tomcat/site/trunk/xdocs/whoweare.xml
>
> Modified: tomcat/site/trunk/docs/whoweare.html
> URL: 
> http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whoweare.html?rev=1525975&r1=1525974&r2=1525975&view=diff
> ==
> --- tomcat/site/trunk/docs/whoweare.html (original)
> +++ tomcat/site/trunk/docs/whoweare.html Tue Sep 24 19:10:44 2013
> @@ -363,6 +363,12 @@ A complete list of all the Apache Commit
>
>
>  
> +Konstantin Preißer (kpreisser at apache.org)
> +
> +
> +
> +
> +
>  Peter Rossbach (pero at apache.org)
>  
>
>
> Modified: tomcat/site/trunk/xdocs/whoweare.xml
> URL: 
> http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/whoweare.xml?rev=1525975&r1=1525974&r2=1525975&view=diff
> ==
> --- tomcat/site/trunk/xdocs/whoweare.xml (original)
> +++ tomcat/site/trunk/xdocs/whoweare.xml Tue Sep 24 19:10:44 2013
> @@ -100,6 +100,9 @@ A complete list of all the Apache Commit
>  Costin Manolache (costin at apache.org)
>  
>
> +Konstantin Preißer (kpreisser at apache.org)
> +
> +
>  Peter Rossbach (pero at apache.org)
>  
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>



-- 
Olivier Lamy
Ecetera: http://ecetera.com.au
http://twitter.com/olamy | http://linkedin.com/in/olamy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Issue in AprEndpoint detected by TestCoyoteAdapter

[Mark Thomas]

On 24/09/2013 08:16, Mark Thomas wrote:
> On 23/09/2013 00:54, Rainer Jung wrote:
> 
>> I agree that there's probably another problem further up the stack.
> 
> I'm looking at this now.

I've found a couple of issues. Not sure if either of these are the root
cause of the remaining issues we see but I'll look into fixing them.

- AprEndpoint.destroySocket() calls Poller.removeFromPoller() but that
  call isn't thread safe. I think we need a remove process similar to
  the add process.
- sockets are not always removed from the timeout list when they are
  destroyed

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1526043 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

[markt]

Author: markt
Date: Tue Sep 24 22:49:13 2013
New Revision: 1526043

URL: http://svn.apache.org/r1526043
Log:
Narrow scope of localAddList

Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=1526043&r1=1526042&r2=1526043&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Tue Sep 24 
22:49:13 2013
@@ -1274,10 +1274,6 @@ public class AprEndpoint extends Abstrac
  */
 private SocketList addList = null;
 
-/**
- * List of sockets to be added to the poller.
- */
-private SocketList localAddList = null;
 
 /**
  * Structure used for storing timeouts.
@@ -1353,7 +1349,6 @@ public class AprEndpoint extends Abstrac
 desc = new long[actualPollerSize * 2];
 connectionCount = 0;
 addList = new SocketList(defaultPollerSize);
-localAddList = new SocketList(defaultPollerSize);
 }
 
 
@@ -1502,6 +1497,7 @@ public class AprEndpoint extends Abstrac
 }
 }
 }
+timeouts.remove(socket);
 return (rv == Status.APR_SUCCESS);
 }
 
@@ -1563,6 +1559,9 @@ public class AprEndpoint extends Abstrac
 public void run() {
 
 int maintain = 0;
+SocketList localAddList = new SocketList(getMaxConnections());
+
+
 // Loop until we receive a shutdown command
 while (pollerRunning) {
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1526036 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

[markt]

Author: markt
Date: Tue Sep 24 22:39:14 2013
New Revision: 1526036

URL: http://svn.apache.org/r1526036
Log:
Reduce visibility

Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=1526036&r1=1526035&r2=1526036&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Tue Sep 24 
22:39:14 2013
@@ -1237,64 +1237,64 @@ public class AprEndpoint extends Abstrac
 /**
  * Pointers to the pollers.
  */
-protected long[] pollers = null;
+private long[] pollers = null;
 
 /**
  * Actual poller size.
  */
-protected int actualPollerSize = 0;
+private int actualPollerSize = 0;
 
 /**
  * Amount of spots left in the poller.
  */
-protected int[] pollerSpace = null;
+private int[] pollerSpace = null;
 
 /**
  * Amount of low level pollers in use by this poller.
  */
-protected int pollerCount;
+private int pollerCount;
 
 /**
  * Timeout value for the poll call.
  */
-protected int pollerTime;
+private int pollerTime;
 
 /**
  * Root pool.
  */
-protected long pool = 0;
+private long pool = 0;
 
 /**
  * Socket descriptors.
  */
-protected long[] desc;
+private long[] desc;
 
 /**
  * List of sockets to be added to the poller.
  */
-protected SocketList addList = null;
+private SocketList addList = null;
 
 /**
  * List of sockets to be added to the poller.
  */
-protected SocketList localAddList = null;
+private SocketList localAddList = null;
 
 /**
  * Structure used for storing timeouts.
  */
-protected SocketTimeouts timeouts = null;
+private SocketTimeouts timeouts = null;
 
 
 /**
  * Last run of maintain. Maintain will run usually every 5s.
  */
-protected long lastMaintain = System.currentTimeMillis();
+private long lastMaintain = System.currentTimeMillis();
 
 
 /**
  * Amount of connections inside this poller.
  */
-protected int connectionCount = 0;
+private int connectionCount = 0;
 public int getConnectionCount() { return connectionCount; }
 
 
@@ -1472,7 +1472,7 @@ public class AprEndpoint extends Abstrac
 /**
  * Add specified socket to one of the pollers.
  */
-protected boolean addToPoller(long socket, int events) {
+private boolean addToPoller(long socket, int events) {
 int rv = -1;
 for (int i = 0; i < pollers.length; i++) {
 if (pollerSpace[i] > 0) {
@@ -1506,9 +1506,9 @@ public class AprEndpoint extends Abstrac
 }
 
 /**
- * Timeout checks.
+ * Timeout checks. Must only be called from {@link Poller#run()}.
  */
-protected void maintain() {
+private void maintain() {
 
 long date = System.currentTimeMillis();
 // Maintain runs at most once every 5s, although it will likely get



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[ANN] New committer: Konstantin Preißer

[Mark Thomas]

On behalf of the Tomcat committers I am pleased to announce that
Konstantin Preißer has been voted in as a new Tomcat committer.

In addition to a number of high quality bug reports and patches,
Konstantin is also responsible for the makeover the Tomcat web site and
Tomcat 8 documentation has received.

Please join me in welcoming him.

Regards,

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

RE: svn commit: r1525975 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

[Konstantin Preißer]

Hi Mark,

> -Original Message-
> From: Mark Thomas [mailto:ma...@apache.org]
> Sent: Tuesday, September 24, 2013 10:02 PM

> I guess everything works then :)

Yes, E-Mail and SVN seem to be working. :)

> A very warm welcome.

Thanks!


Konstantin


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1525977 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

[Christopher Schultz]

Konstantin,

On 9/24/13 3:22 PM, kpreis...@apache.org wrote:
> Author: kpreisser

Welcome!

-chris



signature.asc
Description: OpenPGP digital signature

svn commit: r1526018 - in /tomcat/site/trunk: ./ docs/tomcat-8.0-doc/ docs/tomcat-8.0-doc/api/ docs/tomcat-8.0-doc/api/org/apache/catalina/ docs/tomcat-8.0-doc/api/org/apache/catalina/ant/ docs/tomcat

[markt]

Author: markt
Date: Tue Sep 24 21:33:05 2013
New Revision: 1526018

URL: http://svn.apache.org/r1526018
Log:
Update docs to 8.0.0-RC3


[This commit notification would consist of 125 parts, 
which exceeds the limit of 50 ones, so it was shortened to the summary.]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r2975 - /release/tomcat/tomcat-8/v8.0.0-RC1/

[markt]

Author: markt
Date: Tue Sep 24 20:44:43 2013
New Revision: 2975

Log:
Remove old release

Removed:
release/tomcat/tomcat-8/v8.0.0-RC1/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r2975 - /release/tomcat/tomcat-8/v8.0.0-RC1/

[markt]

Author: markt
Date: Tue Sep 24 20:44:43 2013
New Revision: 2975

Log:
Remove old release

Removed:
release/tomcat/tomcat-8/v8.0.0-RC1/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[ANN] Apache Tomcat 8.0.0-RC3 (alpha) available

[Mark Thomas]

The Apache Tomcat team announces the immediate availability of Apache
Tomcat 8.0.0-RC3 (alpha).

Apache Tomcat 8 is an open source software implementation of the Java
Servlet, JavaServer Pages, Java Unified Expression Language and Java
WebSocket technologies.

Apache Tomcat 8 is aligned with Java EE 7. In addition to supporting
updated versions of the Java EE specifications, Tomcat 8 includes a
number of improvements compared to Tomcat 7. The notable changes
include:

- Support for Java Servlet 3.1, JavaServer Pages 2.3, Java Unified
  Expression Language 3.0 and Java WebSocket 1.0.

- The default connector implementation is now the Java non-blocking
  implementation (NIO) for both HTTP and AJP.

- A new resources implementation that replaces Aliases, VirtualLoader,
  VirtualDirContext, JAR resources and external repositories with a
  single, consistent approach for configuring additional web
  application resources. The new resources implementation can also be
  used to implement overlays (using a master WAR as the basis for
  multiple web applications that each have their own
  customizations).


Apache Tomcat 8.0.0-RC3 includes numerous fixes for issues identified in
RC1 as well as a number of other enhancements and changes. The notable
changes since RC1 include:

- Switch to UFT-8 by default for connectors and example web
  applications.

- Switch to the asynchronous logger and one line formatter by default.

- Add Servlet 3.1 non-blocking IO support to the AJP connectors.


Please refer to the change log for the complete list of changes:
http://tomcat.apache.org/tomcat-8.0-doc/changelog.html

The purpose of this release candidate is to give users an opportunity to
test Tomcat 8 and provide feedback to the Tomcat community. It has been
given an alpha status which means that it is not judged as being ready
for production usage. The implementations of the 4 Java EE 7
specifications are all complete but there is some internal refactoring
to be completed before the alpha label is removed.

Note: This version has 4 zip binaries: a generic one and three
  bundled with Tomcat native binaries for Windows operating systems
  running on different CPU architectures.

Downloads:
http://tomcat.apache.org/download-80.cgi

Migration guides from Apache Tomcat 5.5.x, 6.0.x and 7.0.x:
http://tomcat.apache.org/migration.html

Enjoy!

- The Apache Tomcat team

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1526000 - in /tomcat/site/trunk: docs/doap_Tomcat.rdf docs/download-80.html docs/index.html docs/oldnews.html docs/whichversion.html xdocs/doap_Tomcat.rdf xdocs/download-80.xml xdocs/inde

[markt]

Author: markt
Date: Tue Sep 24 20:30:42 2013
New Revision: 1526000

URL: http://svn.apache.org/r1526000
Log:
Update main site for 8.0.0-RC3

Modified:
tomcat/site/trunk/docs/doap_Tomcat.rdf
tomcat/site/trunk/docs/download-80.html
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/docs/oldnews.html
tomcat/site/trunk/docs/whichversion.html
tomcat/site/trunk/xdocs/doap_Tomcat.rdf
tomcat/site/trunk/xdocs/download-80.xml
tomcat/site/trunk/xdocs/index.xml
tomcat/site/trunk/xdocs/oldnews.xml
tomcat/site/trunk/xdocs/whichversion.xml

Modified: tomcat/site/trunk/docs/doap_Tomcat.rdf
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/doap_Tomcat.rdf?rev=1526000&r1=1525999&r2=1526000&view=diff
==
--- tomcat/site/trunk/docs/doap_Tomcat.rdf (original)
+++ tomcat/site/trunk/docs/doap_Tomcat.rdf Tue Sep 24 20:30:42 2013
@@ -57,8 +57,8 @@
 
   
 Latest 8.0.x Release (Non-stable)
-2013-08-05
-8.0.0-RC1 (alpha)
+2013-09-23
+8.0.0-RC3 (alpha)
   
 
 

Modified: tomcat/site/trunk/docs/download-80.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-80.html?rev=1526000&r1=1525999&r2=1526000&view=diff
==
--- tomcat/site/trunk/docs/download-80.html (original)
+++ tomcat/site/trunk/docs/download-80.html Tue Sep 24 20:30:42 2013
@@ -219,8 +219,8 @@
 
 
 https://www.apache.org/dist/tomcat/tomcat-8/KEYS";>KEYS |
-8.0.0-RC1 |
-Browse |
+8.0.0-RC3 |
+Browse |
 http://archive.apache.org/dist/tomcat/tomcat-8";>Archives
   
 
@@ -266,12 +266,12 @@

   
 
-8.0.0-RC1
+8.0.0-RC3
 
   
 
   Please see the 
-  README
+  README
   file for packaging information.  It explains what every distribution 
contains.
   
 
@@ -287,44 +287,44 @@
   
 
 
-zip 
-(https://www.apache.org/dist/tomcat/tomcat-8/v8.0.0-RC1/bin/apache-tomcat-8.0.0-RC1.zip.asc";>pgp,
 
-https://www.apache.org/dist/tomcat/tomcat-8/v8.0.0-RC1/bin/apache-tomcat-8.0.0-RC1.zip.md5";>md5)
+zip 
+(https://www.apache.org/dist/tomcat/tomcat-8/v8.0.0-RC3/bin/apache-tomcat-8.0.0-RC3.zip.asc";>pgp,
 
+https://www.apache.org/dist/tomcat/tomcat-8/v8.0.0-RC3/bin/apache-tomcat-8.0.0-RC3.zip.md5";>md5)
   
   
 
 
-tar.gz 
-(https://www.apache.org/dist/tomcat/tomcat-8/v8.0.0-RC1/bin/apache-tomcat-8.0.0-RC1.tar.gz.asc";>pgp,
 
-https://www.apache.org/dist/tomcat/tomcat-8/v8.0.0-RC1/bin/apache-tomcat-8.0.0-RC1.tar.gz.md5";>md5)
+tar.gz 
+(https://www.apache.org/dist/tomcat/tomcat-8/v8.0.0-RC3/bin/apache-tomcat-8.0.0-RC3.tar.gz.asc";>pgp,
 
+https://www.apache.org/dist/tomcat/tomcat-8/v8.0.0-RC3/bin/apache-tomcat-8.0.0-RC3.tar.gz.md5";>md5)
   
   
 
 
-32-bit Windows zip 
-(https://www.apache.org/dist/tomcat/tomcat-8/v8.0.0-RC1/bin/apache-tomcat-8.0.0-RC1-windows-x86.zip.asc";>pgp,
 
-https://www.apache.org/dist/tomcat/tomcat-8/v8.0.0-RC1/bin/apache-tomcat-8.0.0-RC1-windows-x86.zip.md5";>md5)
+32-bit Windows zip 
+(https://www.apache.org/dist/tomcat/tomcat-8/v8.0.0-RC3/bin/apache-tomcat-8.0.0-RC3-windows-x86.zip.asc";>pgp,
 
+https://www.apache.org/dist/tomcat/tomcat-8/v8.0.0-RC3/bin/apache-tomcat-8.0.0-RC3-windows-x86.zip.md5";>md5)
   
   
 
 
-64-bit Windows zip 
-(https://www.apache.org/dist/tomcat/tomcat-8/v8.0.0-RC1/bin/apache-tomcat-8.0.0-RC1-windows-x64.zip.asc";>pgp,
 
-https://www.apache.org/dist/tomcat/tomcat-8/v8.0.0-RC1/bin/apache-tomcat-8.0.0-RC1-windows-x64.zip.md5";>md5)
+64-bit Windows zip 
+(https://www.apache.org/dist/tomcat/tomcat-8/v8.0.0-RC3/bin/apache-tomcat-8.0.0-RC3-windows-x64.zip.asc";>pgp,
 
+https://www.apache.org/dist/tomcat/tomcat-8/v8.0.0-RC3/bin/apache-tomcat-8.0.0-RC3-windows-x64.zip.md5";>md5)
   
   
 
 
-64-bit Itanium Windows zip 
-(https://www.apache.org/dist/tomcat/tomcat-8/v8.0.0-RC1/bin/apache-tomcat-8.0.0-RC1-windows-i64.zip.asc";>pgp,
 
-https://www.apache.org/dist/tomcat/tomcat-8/v8.0.0-RC1/bin/apache-tomcat-8.0.0-RC1-windows-i64.zip.md5";>md5)
+64-bit Itanium Windows zip 
+(https://www.apache.org/dist/tomcat/tomcat-8/v8.0.0-RC3/bin/apache-tomcat-8.0.0-RC3-windows-i64.zip.asc";>pgp,
 
+https://www.apache.org/dist/tomcat/tomcat-8/v8.0.0-RC3/bin/apache-tomcat-8.0.0-RC3-windows-i64.zip.md5";>md5)
   
   
 
 
-32-bit/64-bit Windows Service Installer 
-(https://www.apache.org/dist/tomcat/tomcat-8/v8.0.0-RC1/bin/apache-tomcat-8.0.0-RC1.exe.asc";>pgp,
 
-https://www.apache.org/dist/tomcat/tom

svn commit: r1525996 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

[violetagg]

Author: violetagg
Date: Tue Sep 24 20:15:18 2013
New Revision: 1525996

URL: http://svn.apache.org/r1525996
Log:
Mark 7.0.44 as not released based on the vote results.

Modified:
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1525996&r1=1525995&r2=1525996&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Tue Sep 24 20:15:18 2013
@@ -73,7 +73,7 @@
 
   
 
-
+
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1525995 - in /tomcat/tc7.0.x/trunk/res/maven: mvn-pub.xml tomcat-websocket.pom tomcat7-websocket.pom

[markt]

Author: markt
Date: Tue Sep 24 20:14:50 2013
New Revision: 1525995

URL: http://svn.apache.org/r1525995
Log:
Add the Tomcat 7 WebSocket impl JAR to the maven upload script

Added:
tomcat/tc7.0.x/trunk/res/maven/tomcat7-websocket.pom
  - copied, changed from r1525898, 
tomcat/tc7.0.x/trunk/res/maven/tomcat-websocket.pom
Removed:
tomcat/tc7.0.x/trunk/res/maven/tomcat-websocket.pom
Modified:
tomcat/tc7.0.x/trunk/res/maven/mvn-pub.xml

Modified: tomcat/tc7.0.x/trunk/res/maven/mvn-pub.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/res/maven/mvn-pub.xml?rev=1525995&r1=1525994&r2=1525995&view=diff
==
--- tomcat/tc7.0.x/trunk/res/maven/mvn-pub.xml (original)
+++ tomcat/tc7.0.x/trunk/res/maven/mvn-pub.xml Tue Sep 24 20:14:50 2013
@@ -305,10 +305,15 @@
   jarFileName="servlet-api.jar"
srcJarFileName="servlet-api-src.jar"/>
 
-
+
+
+   
 
 
 
+
 
 
 

Copied: tomcat/tc7.0.x/trunk/res/maven/tomcat7-websocket.pom (from r1525898, 
tomcat/tc7.0.x/trunk/res/maven/tomcat-websocket.pom)
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/res/maven/tomcat7-websocket.pom?p2=tomcat/tc7.0.x/trunk/res/maven/tomcat7-websocket.pom&p1=tomcat/tc7.0.x/trunk/res/maven/tomcat-websocket.pom&r1=1525898&r2=1525995&rev=1525995&view=diff
==
(empty)



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.44

[Mark Thomas]

On 24/09/2013 08:40, Mark Thomas wrote:
> On 24/09/2013 08:07, Martin Grigorov wrote:
>> On Tue, Sep 24, 2013 at 4:35 PM, Rossen Stoyanchev <

>>> Also what's the equivalent of the Tomcat 8 tomcat-websocket
>>> dependency? I see the 7.0.44 binary has tomcat7-websocket.jar but I
>>>
>>
>> Here is what I use for Apache Wicket integration:
>> https://github.com/apache/wicket/blob/master/wicket-experimental/wicket-native-websocket/wicket-native-websocket-tomcat/pom.xml#L43
>>
>>
>>> can't find such a dependency in the staging maven repository.
> 
> The necessary update to the script that uploads those JARs to the Maven
> repo was missed. I think I have fixed it locally but need to test it
> from somewhere with connectivity. Unless the JavaOne Wifi is
> significantly better than yesterday that won't be for a few hours.

I've fixed the build scripts and confirmed they work by generating a
7.0.x SNAPSHOT.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1525994 - /tomcat/tc7.0.x/trunk/build.xml

[markt]

Author: markt
Date: Tue Sep 24 20:12:42 2013
New Revision: 1525994

URL: http://svn.apache.org/r1525994
Log:
Correct reference to name of Tomcat 7 WebSocket implementation source JAR

Modified:
tomcat/tc7.0.x/trunk/build.xml

Modified: tomcat/tc7.0.x/trunk/build.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/build.xml?rev=1525994&r1=1525993&r2=1525994&view=diff
==
--- tomcat/tc7.0.x/trunk/build.xml (original)
+++ tomcat/tc7.0.x/trunk/build.xml Tue Sep 24 20:12:42 2013
@@ -2479,7 +2479,7 @@ Apache Tomcat ${version} native binaries
   manifest="${tomcat.manifests}/websocket-api.jar.manifest" />
 
 
-
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r2974 - /dev/tomcat/tomcat-7/v7.0.44/

[violetagg]

Author: violetagg
Date: Tue Sep 24 20:07:02 2013
New Revision: 2974

Log:
7.0.44 RC did not pass the vote - dropping.

Removed:
dev/tomcat/tomcat-7/v7.0.44/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r2974 - /dev/tomcat/tomcat-7/v7.0.44/

[violetagg]

Author: violetagg
Date: Tue Sep 24 20:07:02 2013
New Revision: 2974

Log:
7.0.44 RC did not pass the vote - dropping.

Removed:
dev/tomcat/tomcat-7/v7.0.44/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1525975 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

[Mark Thomas]

On 24/09/2013 12:10, kpreis...@apache.org wrote:
> Author: kpreisser
> Date: Tue Sep 24 19:10:44 2013
> New Revision: 1525975
> 
> URL: http://svn.apache.org/r1525975
> Log:
> Add myself to the committers list.

I guess everything works then :)

A very warm welcome.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.44

[Violeta Georgieva]

2013/9/24 Nick Williams 
>
>
> On Sep 24, 2013, at 11:00 AM, Rossen Stoyanchev wrote:
>
> > On Tue, Sep 24, 2013 at 11:40 AM, Mark Thomas  wrote:
> >
> >> The necessary update to the script that uploads those JARs to the Maven
> >> repo was missed. I think I have fixed it locally but need to test it
> >> from somewhere with connectivity. Unless the JavaOne Wifi is
> >> significantly better than yesterday that won't be for a few hours.
> >
> > I'll run tests when this is available.
>
> S, does that mean this vote is cancelled, too?


Yes I'll cancel this vote and I'll mark 7.0.44 as "not released".
I'm going to tag 7.0.45 tomorrow morning.

Regards
Violeta

svn commit: r1525977 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

[kpreisser]

Author: kpreisser
Date: Tue Sep 24 19:22:58 2013
New Revision: 1525977

URL: http://svn.apache.org/r1525977
Log:
Fix link to the Apache Committers list - it is now handled by the ASF 
Infrastructure.

Modified:
tomcat/site/trunk/docs/whoweare.html
tomcat/site/trunk/xdocs/whoweare.xml

Modified: tomcat/site/trunk/docs/whoweare.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whoweare.html?rev=1525977&r1=1525976&r2=1525977&view=diff
==
--- tomcat/site/trunk/docs/whoweare.html (original)
+++ tomcat/site/trunk/docs/whoweare.html Tue Sep 24 19:22:58 2013
@@ -238,7 +238,7 @@ short bios for some of them.
 
 
 A complete list of all the Apache Committers is
-http://www.apache.org/~jim/committers.html";>also available.
+http://people.apache.org/committer-index.html";>also available.
 (It's a long list, so please be patient.)
 
 

Modified: tomcat/site/trunk/xdocs/whoweare.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/whoweare.xml?rev=1525977&r1=1525976&r2=1525977&view=diff
==
--- tomcat/site/trunk/xdocs/whoweare.xml (original)
+++ tomcat/site/trunk/xdocs/whoweare.xml Tue Sep 24 19:22:58 2013
@@ -34,7 +34,7 @@ short bios for some of them.
 
 
 A complete list of all the Apache Committers is
-http://www.apache.org/~jim/committers.html";>also available.
+http://people.apache.org/committer-index.html";>also available.
 (It's a long list, so please be patient.)
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1525975 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

[kpreisser]

Author: kpreisser
Date: Tue Sep 24 19:10:44 2013
New Revision: 1525975

URL: http://svn.apache.org/r1525975
Log:
Add myself to the committers list.

Modified:
tomcat/site/trunk/docs/whoweare.html
tomcat/site/trunk/xdocs/whoweare.xml

Modified: tomcat/site/trunk/docs/whoweare.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whoweare.html?rev=1525975&r1=1525974&r2=1525975&view=diff
==
--- tomcat/site/trunk/docs/whoweare.html (original)
+++ tomcat/site/trunk/docs/whoweare.html Tue Sep 24 19:10:44 2013
@@ -363,6 +363,12 @@ A complete list of all the Apache Commit
 
 
 
+Konstantin Preißer (kpreisser at apache.org)
+
+
+
+
+
 Peter Rossbach (pero at apache.org)
 
 

Modified: tomcat/site/trunk/xdocs/whoweare.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/whoweare.xml?rev=1525975&r1=1525974&r2=1525975&view=diff
==
--- tomcat/site/trunk/xdocs/whoweare.xml (original)
+++ tomcat/site/trunk/xdocs/whoweare.xml Tue Sep 24 19:10:44 2013
@@ -100,6 +100,9 @@ A complete list of all the Apache Commit
 Costin Manolache (costin at apache.org)
 
 
+Konstantin Preißer (kpreisser at apache.org)
+
+
 Peter Rossbach (pero at apache.org)
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.44

[Nick Williams]

On Sep 24, 2013, at 11:00 AM, Rossen Stoyanchev wrote:

> On Tue, Sep 24, 2013 at 11:40 AM, Mark Thomas  wrote:
> 
>> The necessary update to the script that uploads those JARs to the Maven
>> repo was missed. I think I have fixed it locally but need to test it
>> from somewhere with connectivity. Unless the JavaOne Wifi is
>> significantly better than yesterday that won't be for a few hours.
> 
> I'll run tests when this is available.

S, does that mean this vote is cancelled, too?

Nick

smime.p7s
Description: S/MIME cryptographic signature

Re: [VOTE] Release Apache Tomcat 7.0.44

[Rossen Stoyanchev]

On Tue, Sep 24, 2013 at 11:40 AM, Mark Thomas  wrote:

> The necessary update to the script that uploads those JARs to the Maven
> repo was missed. I think I have fixed it locally but need to test it
> from somewhere with connectivity. Unless the JavaOne Wifi is
> significantly better than yesterday that won't be for a few hours.

I'll run tests when this is available.

Thanks,
Rossen

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1525932 - /tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java

[markt]

Author: markt
Date: Tue Sep 24 15:58:22 2013
New Revision: 1525932

URL: http://svn.apache.org/r1525932
Log:
Fix issue with unwrapping. Cast needs to use the unwrapped request object.

Modified:

tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java?rev=1525932&r1=1525931&r2=1525932&view=diff
==
--- 
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java 
(original)
+++ 
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java 
Tue Sep 24 15:58:22 2013
@@ -181,7 +181,7 @@ public class UpgradeUtil {
 }
 if (inner instanceof RequestFacade) {
 WsHttpUpgradeHandler wsHandler =
-((RequestFacade) req).upgrade(WsHttpUpgradeHandler.class);
+((RequestFacade) 
inner).upgrade(WsHttpUpgradeHandler.class);
 wsHandler.preInit(ep, sec, sc, wsRequest, subProtocol,
 pathParams, req.isSecure());
 } else {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.44

[Mark Thomas]

On 24/09/2013 08:52, Rossen Stoyanchev wrote:
> On Tue, Sep 24, 2013 at 11:40 AM, Mark Thomas  wrote:
> 
>> Tomcat should already being the necessary unwrapping in lines 179-181.
>> It isn't immediately clear to me why this isn't working as intended. Can
>> you denug this and add some insight?
> 
> Indeed, the code does unwrap the request correctly but then it uses
> the original "req" var, not "inner". Doh!

Whoops. Guess that is my fault. Sorry. I'll get that fixed.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.44

[Rossen Stoyanchev]

On Tue, Sep 24, 2013 at 11:40 AM, Mark Thomas  wrote:

> Tomcat should already being the necessary unwrapping in lines 179-181.
> It isn't immediately clear to me why this isn't working as intended. Can
> you denug this and add some insight?

Indeed, the code does unwrap the request correctly but then it uses
the original "req" var, not "inner". Doh!

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.44

[Mark Thomas]

On 24/09/2013 08:07, Martin Grigorov wrote:
> Hi Rossen,
> 
> 
> On Tue, Sep 24, 2013 at 4:35 PM, Rossen Stoyanchev <
> rstoyanc...@gopivotal.com> wrote:
> 
>> I am getting a ClassCastException when using (non JSR-356) upgrade,
>> i.e. WsServerContainer.doUpgrade:
>>
>> Caused by: java.lang.ClassCastException:
>>
>> org.springframework.security.web.servletapi.HttpServlet3RequestFactory$Servlet3SecurityContextHolderAwareRequestWrapper
>> cannot be cast to org.apache.catalina.connector.RequestFacade
>>
> 
> See
> https://github.com/apache/wicket/blob/master/wicket-experimental/wicket-native-websocket/wicket-native-websocket-tomcat/src/main/java/org/apache/wicket/protocol/ws/tomcat7/Tomcat7WebSocketFilter.java#L81
> 
> I had to add this code exactly because of Spring Security -
> https://issues.apache.org/jira/browse/WICKET-5266. But it is valid for any
> other usage of HttpServletRequestWrapper
> 
> 
>> at
>> org.apache.tomcat.websocket.server.UpgradeUtil.doUpgrade(UpgradeUtil.java:183)

Tomcat should already being the necessary unwrapping in lines 179-181.
It isn't immediately clear to me why this isn't working as intended. Can
you denug this and add some insight?

>> Also what's the equivalent of the Tomcat 8 tomcat-websocket
>> dependency? I see the 7.0.44 binary has tomcat7-websocket.jar but I
>>
> 
> Here is what I use for Apache Wicket integration:
> https://github.com/apache/wicket/blob/master/wicket-experimental/wicket-native-websocket/wicket-native-websocket-tomcat/pom.xml#L43
> 
> 
>> can't find such a dependency in the staging maven repository.

The necessary update to the script that uploads those JARs to the Maven
repo was missed. I think I have fixed it locally but need to test it
from somewhere with connectivity. Unless the JavaOne Wifi is
significantly better than yesterday that won't be for a few hours.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Issue in AprEndpoint detected by TestCoyoteAdapter

[Mark Thomas]

On 23/09/2013 00:54, Rainer Jung wrote:

> I agree that there's probably another problem further up the stack.

I'm looking at this now.

> Since the apr endpoint explicitely uses the return value of remove to
> decide whether something was removed, APT_NOTFOUND seems better. But as
> you said: why is it calling remove for a socket not in the poller? When
> the endpoint called remove for "2856392", the poller has size one and
> consisted only of socket 2218784. Strange.

I suspect that this is because the socket could be in the poller for
write while being processed for read (or the other way around). If the
IO operation fails, the socket needs to be removed from the poller
otherwise other bad things (tm) happen.

This is one of the complications caused by having to implement some
WebSocket writes as blocking.



> - since removeFromPoller() is part of error condition handling, and its
> return code is used to determine adjusting the externally tracked size
> of the poller and the connection counts, the return code must be
> "correct". It is still open to me, whether returning APR_NOTFOUND is a
> problem for the conection count tracking.

I was expecting a APR_NOTFOUND return value if the socket wasn't in the
Poller when I wrote that code.

> - we should check, whethera 0 byte read after OPEN_READ really is a
> problem or must be expected even for a non-broken socket.

OPEN_READ should mean there is data available to read without bocking.
Therefore, a read returning 0 bytes looks like an error to me. Could it
be signalling EOF ?

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.44

[Martin Grigorov]

Hi Rossen,


On Tue, Sep 24, 2013 at 4:35 PM, Rossen Stoyanchev <
rstoyanc...@gopivotal.com> wrote:

> I am getting a ClassCastException when using (non JSR-356) upgrade,
> i.e. WsServerContainer.doUpgrade:
>
> Caused by: java.lang.ClassCastException:
>
> org.springframework.security.web.servletapi.HttpServlet3RequestFactory$Servlet3SecurityContextHolderAwareRequestWrapper
> cannot be cast to org.apache.catalina.connector.RequestFacade
>

See
https://github.com/apache/wicket/blob/master/wicket-experimental/wicket-native-websocket/wicket-native-websocket-tomcat/src/main/java/org/apache/wicket/protocol/ws/tomcat7/Tomcat7WebSocketFilter.java#L81

I had to add this code exactly because of Spring Security -
https://issues.apache.org/jira/browse/WICKET-5266. But it is valid for any
other usage of HttpServletRequestWrapper


> at
> org.apache.tomcat.websocket.server.UpgradeUtil.doUpgrade(UpgradeUtil.java:183)
> at
> org.apache.tomcat.websocket.server.WsServerContainer.doUpgrade(WsServerContainer.java:235)
> at
> org.springframework.web.socket.server.support.TomcatRequestUpgradeStrategy.upgradeInternal(TomcatRequestUpgradeStrategy.java:77)
> at
> org.springframework.web.socket.server.support.AbstractStandardUpgradeStrategy.upgrade(AbstractStandardUpgradeStrategy.java:59)
> at
> org.springframework.web.socket.server.DefaultHandshakeHandler.doHandshake(DefaultHandshakeHandler.java:183)
> at
> org.springframework.web.socket.sockjs.transport.handler.WebSocketTransportHandler.handleRequest(WebSocketTransportHandler.java:82)
>
> Also what's the equivalent of the Tomcat 8 tomcat-websocket
> dependency? I see the 7.0.44 binary has tomcat7-websocket.jar but I
>

Here is what I use for Apache Wicket integration:
https://github.com/apache/wicket/blob/master/wicket-experimental/wicket-native-websocket/wicket-native-websocket-tomcat/pom.xml#L43


> can't find such a dependency in the staging maven repository.
>
> Thanks,
> Rossen
>
>
> On Mon, Sep 23, 2013 at 4:58 PM, Violeta Georgieva 
> wrote:
> > The proposed Apache Tomcat 7.0.44 release is now available for voting.
> > This release candidate contains JSR-356 Java WebSocket 1.0
> implementation.
> > Note that use of this functionality requires Java 7.
> >
> > It can be obtained from:
> > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.44/
> > The Maven staging repo is:
> > https://repository.apache.org/content/repositories/orgapachetomcat-090/
> > The svn tag is:
> > http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_44/
> >
> > The proposed 7.0.44 release is:
> > [ ] Broken - do not release
> > [ ] Stable - go ahead and release as 7.0.44 Stable
> >
> > Regards
> > Violeta
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 7.0.44

[Christopher Schultz]

Violetta,

On 9/24/13 10:01 AM, Christopher Schultz wrote:
> Building tomcat-dbcp with Java 1.6 and resuming the build with Java 7
> shows everything is okay.
> 
> But, when I run all the tests, I get lots and lots of failures:
> Testsuite: javax.el.TestArrayELResolver
> Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec
> 
> Caused an ERROR
> javax/el/TestArrayELResolver : Unsupported major.minor version 51.0
> java.lang.UnsupportedClassVersionError: javax/el/TestArrayELResolver :
> Unsupported major.minor version 51.0
> at java.lang.ClassLoader.defineClass1(Native Method)
> at java.lang.ClassLoader.defineClassCond(ClassLoader.java:631)
> at java.lang.ClassLoader.defineClass(ClassLoader.java:615)
> at
> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:141)
> at java.net.URLClassLoader.defineClass(URLClassLoader.java:283)
> at java.net.URLClassLoader.access$000(URLClassLoader.java:58)
> at java.net.URLClassLoader$1.run(URLClassLoader.java:197)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:169)
> 
> I'm fairly sure this is a problem with my environment. I have JAVA_HOME
> set to point to Java 7 but I suspect somewhere that's getting overridden
> when the tests are being run.

Specifying "-Djava.bin.path=$JAVA_HOME/bin/" on the command-line shows
all tests passing (save for Tribes, which are known to fail in my
environment).

Thanks,
-chris



signature.asc
Description: OpenPGP digital signature

Re: [VOTE] Release Apache Tomcat 7.0.44

[Christopher Schultz]

Rossen,

On 9/24/13 10:35 AM, Rossen Stoyanchev wrote:
> I am getting a ClassCastException when using (non JSR-356) upgrade,
> i.e. WsServerContainer.doUpgrade:
> 
> Caused by: java.lang.ClassCastException:
> org.springframework.security.web.servletapi.HttpServlet3RequestFactory$Servlet3SecurityContextHolderAwareRequestWrapper
> cannot be cast to org.apache.catalina.connector.RequestFacade

Looks like Spring is interfering, here. Can you post your relevant
Spring configuration?

-chris



signature.asc
Description: OpenPGP digital signature

Re: [VOTE] Release Apache Tomcat 7.0.44

[Rossen Stoyanchev]

I am getting a ClassCastException when using (non JSR-356) upgrade,
i.e. WsServerContainer.doUpgrade:

Caused by: java.lang.ClassCastException:
org.springframework.security.web.servletapi.HttpServlet3RequestFactory$Servlet3SecurityContextHolderAwareRequestWrapper
cannot be cast to org.apache.catalina.connector.RequestFacade
at 
org.apache.tomcat.websocket.server.UpgradeUtil.doUpgrade(UpgradeUtil.java:183)
at 
org.apache.tomcat.websocket.server.WsServerContainer.doUpgrade(WsServerContainer.java:235)
at 
org.springframework.web.socket.server.support.TomcatRequestUpgradeStrategy.upgradeInternal(TomcatRequestUpgradeStrategy.java:77)
at 
org.springframework.web.socket.server.support.AbstractStandardUpgradeStrategy.upgrade(AbstractStandardUpgradeStrategy.java:59)
at 
org.springframework.web.socket.server.DefaultHandshakeHandler.doHandshake(DefaultHandshakeHandler.java:183)
at 
org.springframework.web.socket.sockjs.transport.handler.WebSocketTransportHandler.handleRequest(WebSocketTransportHandler.java:82)

Also what's the equivalent of the Tomcat 8 tomcat-websocket
dependency? I see the 7.0.44 binary has tomcat7-websocket.jar but I
can't find such a dependency in the staging maven repository.

Thanks,
Rossen


On Mon, Sep 23, 2013 at 4:58 PM, Violeta Georgieva  wrote:
> The proposed Apache Tomcat 7.0.44 release is now available for voting.
> This release candidate contains JSR-356 Java WebSocket 1.0 implementation.
> Note that use of this functionality requires Java 7.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.44/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-090/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_44/
>
> The proposed 7.0.44 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 7.0.44 Stable
>
> Regards
> Violeta

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot success in ASF Buildbot on tomcat-trunk

[buildbot]

The Buildbot has detected a restored build on builder tomcat-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/5001

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/trunk] 1525880
Blamelist: markt

Build succeeded!

sincerely,
 -The Buildbot

Re: [WS] To flush or not to flush

[Remy Maucherat]

On Tue, 2013-09-24 at 06:34 -0700, Mark Thomas wrote:
> Non-blocking IO with non-upgraded streams still uses the standard
> buffering mechanisms.
> 
> I agree some clarification is required. When section 5.1 discusses
> buffering, it does so in the context of the ServletResponse object so it
> isn't immediately obvious how the buffer should be controlled (or even
> if it should exist) in the upgraded scenario.

Yes, that's correct, everything is described with the Servlet POV, so
the upgraded mode is undefined as far as buffering goes (so unbuffered
is correct).

Assuming a buffering scenario, I could add sos.flush() (which is a noop
currently) on line 92 in WsRemoteEndpointImplServer, that looks to me
the right location.

Rémy



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.44

[Christopher Schultz]

Violetta,

On 9/23/13 4:58 PM, Violeta Georgieva wrote:
> The proposed Apache Tomcat 7.0.44 release is now available for voting.
> This release candidate contains JSR-356 Java WebSocket 1.0 implementation.
> Note that use of this functionality requires Java 7.
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.44/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-090/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_44/
> 
> The proposed 7.0.44 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 7.0.44 Stable

Debian Linux 2.6, x86_84
Oracle Java 1.6.0_26, 64-bit Server VM

Binary ZIP and tarball are the same
Source ZIP and tarball are the same
MD5 sums are okay
GPG sigs are okay
tcnative builds fine, with some "notes"
Checkstyle is happy
Tomcat builds with one warning:

compile-java6:
[javac] Compiling 1313 source files to
/home/cschultz/projects/apache-tomcat/tarball/apache-tomcat-7.0.44-src/output/classes
[javac]
/home/cschultz/projects/apache-tomcat/tarball/apache-tomcat-7.0.44-src/java/javax/el/ResourceBundleELResolver.java:109:
warning: getFeatureDescriptors(javax.el.ELContext,java.lang.Object) in
javax.el.ResourceBundleELResolver overrides
getFeatureDescriptors(javax.el.ELContext,java.lang.Object) in
javax.el.ELResolver; return type requires unchecked conversion
[javac] found   : java.util.Iterator
[javac] required: java.util.Iterator
[javac] public Iterator getFeatureDescriptors(
[javac] ^
[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] 1 warning


Unit tests pass (except Tribes, known to fail in my environment)

Quick smoke test on my own web application (no new features e.g.
Websocket are in use) shows no problems.

Looks good to me.

When using Java 1.7.0_40, tomcat-dbcp fails to build:

build-tomcat-dbcp:
 [copy] Copying 68 files to
/home/cschultz/projects/apache-tomcat/tarball/downloads/tomcat7-deps/dbcp
[mkdir] Created dir:
/home/cschultz/projects/apache-tomcat/tarball/downloads/tomcat7-deps/dbcp/src/java/org/apache/tomcat/dbcp
 [move] Moving 64 files to
/home/cschultz/projects/apache-tomcat/tarball/downloads/tomcat7-deps/dbcp/src/java/org/apache/tomcat/dbcp
[mkdir] Created dir:
/home/cschultz/projects/apache-tomcat/tarball/downloads/tomcat7-deps/dbcp/classes
[javac] Compiling 64 source files to
/home/cschultz/projects/apache-tomcat/tarball/downloads/tomcat7-deps/dbcp/classes
[javac] warning: [options] bootstrap class path not set in
conjunction with -source 1.6
[javac]
/home/cschultz/projects/apache-tomcat/tarball/downloads/tomcat7-deps/dbcp/src/java/org/apache/tomcat/dbcp/dbcp/BasicDataSource.java:53:
error: BasicDataSource is not abstract and does not override abstract
method getParentLogger() in CommonDataSource
[javac] public class BasicDataSource implements DataSource {
[javac]^
[javac]
/home/cschultz/projects/apache-tomcat/tarball/downloads/tomcat7-deps/dbcp/src/java/org/apache/tomcat/dbcp/dbcp/DelegatingStatement.java:46:
error: DelegatingStatement is not abstract and does not override
abstract method isCloseOnCompletion() in Statement
[javac] public class DelegatingStatement extends AbandonedTrace
implements Statement {

 [...]

Building tomcat-dbcp with Java 1.6 and resuming the build with Java 7
shows everything is okay.

But, when I run all the tests, I get lots and lots of failures:
Testsuite: javax.el.TestArrayELResolver
Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec

Caused an ERROR
javax/el/TestArrayELResolver : Unsupported major.minor version 51.0
java.lang.UnsupportedClassVersionError: javax/el/TestArrayELResolver :
Unsupported major.minor version 51.0
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClassCond(ClassLoader.java:631)
at java.lang.ClassLoader.defineClass(ClassLoader.java:615)
at
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:141)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:283)
at java.net.URLClassLoader.access$000(URLClassLoader.java:58)
at java.net.URLClassLoader$1.run(URLClassLoader.java:197)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:169)

I'm fairly sure this is a problem with my environment. I have JAVA_HOME
set to point to Java 7 but I suspect somewhere that's getting overridden

Re: Refactoring class loader access to resources

[Romain Manni-Bucau]

Hi

about the expanding, tomee forces it so an option can work. I agree with
you "theorically" components shouldn't do it but in practises they have to
(there is no real solutions on this side. That's why all APIs about
scanning ends with a SPI :().

About addURL I think you are right too and addURL() impl can handle the
conversion.

About jars.txt here is the history about it
https://issues.apache.org/jira/browse/TOMEE-794. In 2 words you can pu tin
WEB-INF a file called jars.txt and each line represent a jar. It can be a
mvn url, a http url, a file url or simply a path (with a hack for *.jar as
in the virtual webapp class loader of tomcat). A part of the magic is done
in start and addURL methods of
http://svn.apache.org/repos/asf/tomee/tomee/trunk/tomee/tomee-catalina/src/main/java/org/apache/tomee/catalina/LazyStopWebappClassLoader.java
(of
course this supposes getURLs impact addURL then).

Hope it is clearer

*Romain Manni-Bucau*
*Twitter: @rmannibucau *
*Blog: **http://rmannibucau.wordpress.com/*
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*



2013/9/24 Mark Thomas 

> On 24/09/2013 05:05, Romain Manni-Bucau wrote:
> > Hi
> >
> > about the handler: a lot of container (i particularly know tomee but not
> > only) use string representation of URL to find file to then work on the
> > file (either during scanning or sometimes for some more advanced "hack").
> > If you introduce something not known by these framework it will just
> fail.
> > That's the reason why scanning is not really portable and why vfs (for
> > JBoss for instance) exists. You are doing the same in tomcat (which is
> sad
> > since tomcat was until today simple on this aspect).
>
> I'd argue that components shouldn't be doing that as they have no idea
> what URLs might be coming back.
>
> I think the way to handle this is an option on the Context (so the
> default can be changed in conf/context.xml) to expand JARs from a WAR
> into the work dir and generate URLs to those files if all of the
> following are true:
> - running in a packed WAR
> - getURLs() is called
> - the option is enabled
>
> The JARs will be deleted on context stop.
>
> What I am trying to avoid here is the automatic copying of resources to
> the work dir. I'm also trying to ensure that all resource access goes
> through WebResources as I want to add some memory leak detection code
> their to catch things like InputStreams that are never closed that lead
> to locked files. Having spent ages trying to track down the root cause
> of a locked file, I see this sort of feature as extremely useful. In the
> same way the original memory leak detection code drove improvements in
> Tomcat and 3rd party libraries, I think this code do the same.
>
> > About addURL: we use it in tomee to enrich the classloader in multiple
> > places (but i saw some tomcat extensions doing it too). Our needs are:
> > 1) add container jar in a particular deployment mode (tomee as a webapp)
> > 2) add container jar for some particular features (jsf, jpa, ... - some
> > classes needs to be loaded from the webapp)
> > 3) use a descriptor to define the container (typically jars.txt lists all
> > jar of the loader with mvn/file/http/... syntax). Then our scanning just
> > reuse getURLs().
>
> I think this can be handled by addURL() being used to create the
> appropriate dir/JAR resource and adding it to WebResources but I'm not
> sure about the last one. Could you expand on that use case a little?
>
> Cheers,
>
> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [WS] To flush or not to flush

[Mark Thomas]

On 23/09/2013 09:43, Remy Maucherat wrote:
> Hi Mark,
> 
> Unless I missed something, Websockets 1.0 on Servlet 3.1 upgrade doesn't
> do much flushing, so that the IS/OS used in upgrade must effectively
> just write immediately the data (and ensure it is really sent over the
> wire).

Correct. Unless batching is enabled, writes go immediately.

> I find that a bit weird, since during the design of Servlets 3.1, the
> idea was to retain buffering. Of course, upgrade was then added, char
> support was taken out of the new IO, and it should be feasible to use
> this sort of bufferless streams in upgraded mode. But that's a lot of
> assumptions, shouldn't the websockets implementation just flush ? In any
> case it would be good to have the buffer vs no buffer choice clarified
> for the upgraded mode [to be honest, I thought it was like the regular
> Servlet 3.1 IO mode, minus the HTTP transfer encodings].

Tomcat's implementation doesn't buffer upgraded streams at all.

Non-blocking IO with non-upgraded streams still uses the standard
buffering mechanisms.

I agree some clarification is required. When section 5.1 discusses
buffering, it does so in the context of the ServletResponse object so it
isn't immediately obvious how the buffer should be controlled (or even
if it should exist) in the upgraded scenario.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.44

[Jeanfrancois Arcand]

On 2013-09-23 4:58 PM, Violeta Georgieva wrote:

The proposed Apache Tomcat 7.0.44 release is now available for voting.
This release candidate contains JSR-356 Java WebSocket 1.0 implementation.
Note that use of this functionality requires Java 7.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.44/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-090/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_44/

The proposed 7.0.44 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 7.0.44 Stable
Tested with Atmosphere, jdk6/7, native comet/Servlet Async API, jsr356, 
Native WebSocket.


-- Jeanfrancois





Regards
Violeta




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1525881 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/util/ParameterMap.java java/org/apache/tomcat/util/http/Parameters.java test/org/apache/tomcat/util/http/TestParameters.jav

[markt]

Author: markt
Date: Tue Sep 24 13:22:49 2013
New Revision: 1525881

URL: http://svn.apache.org/r1525881
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55576
Preserve the order that request parameters were presented by the client.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/util/ParameterMap.java
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/http/Parameters.java
tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/http/TestParameters.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
  Merged /tomcat/trunk:r1525696

Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/util/ParameterMap.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/util/ParameterMap.java?rev=1525881&r1=1525880&r2=1525881&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/util/ParameterMap.java 
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/util/ParameterMap.java Tue 
Sep 24 13:22:49 2013
@@ -14,17 +14,13 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
-
 package org.apache.catalina.util;
 
-
-import java.util.HashMap;
+import java.util.LinkedHashMap;
 import java.util.Map;
 
 import org.apache.tomcat.util.res.StringManager;
 
-
 /**
  * Extended implementation of HashMap that includes a
  * locked property.  This class can be used to safely expose
@@ -35,8 +31,7 @@ import org.apache.tomcat.util.res.String
  * @author Craig R. McClanahan
  * @version $Id$
  */
-
-public final class ParameterMap extends HashMap {
+public final class ParameterMap extends LinkedHashMap {
 
 private static final long serialVersionUID = 1L;
 

Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/http/Parameters.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/http/Parameters.java?rev=1525881&r1=1525880&r2=1525881&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/http/Parameters.java 
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/http/Parameters.java Tue 
Sep 24 13:22:49 2013
@@ -22,7 +22,7 @@ import java.nio.charset.Charset;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Enumeration;
-import java.util.HashMap;
+import java.util.LinkedHashMap;
 import java.util.Map;
 
 import org.apache.tomcat.util.buf.B2CConverter;
@@ -49,8 +49,8 @@ public final class Parameters {
 protected static final StringManager sm =
 StringManager.getManager("org.apache.tomcat.util.http");
 
-private final HashMap> paramHashValues =
-new HashMap>();
+private final Map> paramHashValues =
+new LinkedHashMap>();
 
 private boolean didQueryParameters=false;
 

Modified: 
tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/http/TestParameters.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/http/TestParameters.java?rev=1525881&r1=1525880&r2=1525881&view=diff
==
--- tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/http/TestParameters.java 
(original)
+++ tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/http/TestParameters.java 
Tue Sep 24 13:22:49 2013
@@ -207,8 +207,8 @@ public class TestParameters {
 
 names = p.getParameterNames();
 assertTrue(names.hasMoreElements());
-assertEquals("foo2", names.nextElement());
 assertEquals("foo1", names.nextElement());
+assertEquals("foo2", names.nextElement());
 assertFalse(names.hasMoreElements());
 
 values = p.getParameterValues("foo1");
@@ -231,8 +231,8 @@ public class TestParameters {
 // Check current parameters remain unaffected
 names = p.getParameterNames();
 assertTrue(names.hasMoreElements());
-assertEquals("foo2", names.nextElement());
 assertEquals("foo1", names.nextElement());
+assertEquals("foo2", names.nextElement());
 assertFalse(names.hasMoreElements());
 
 values = p.getParameterValues("foo1");

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1525881&r1=1525880&r2=1525881&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Tue Sep 24 13:22:49 2013
@@ -56,6 +56,14 @@
   issues to not "pop up" wrt. others).
 -->
 
+  
+
+  
+55576: Preserve the order in which request parameters were
+received when accessi

svn commit: r1525880 - /tomcat/trunk/test/org/apache/tomcat/util/http/TestParameters.java

[markt]

Author: markt
Date: Tue Sep 24 13:17:32 2013
New Revision: 1525880

URL: http://svn.apache.org/r1525880
Log:
Fix unit test now that parameters are returned in the order they are received.

Modified:
tomcat/trunk/test/org/apache/tomcat/util/http/TestParameters.java

Modified: tomcat/trunk/test/org/apache/tomcat/util/http/TestParameters.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/http/TestParameters.java?rev=1525880&r1=1525879&r2=1525880&view=diff
==
--- tomcat/trunk/test/org/apache/tomcat/util/http/TestParameters.java (original)
+++ tomcat/trunk/test/org/apache/tomcat/util/http/TestParameters.java Tue Sep 
24 13:17:32 2013
@@ -207,8 +207,8 @@ public class TestParameters {
 
 names = p.getParameterNames();
 assertTrue(names.hasMoreElements());
-assertEquals("foo2", names.nextElement());
 assertEquals("foo1", names.nextElement());
+assertEquals("foo2", names.nextElement());
 assertFalse(names.hasMoreElements());
 
 values = p.getParameterValues("foo1");
@@ -231,8 +231,8 @@ public class TestParameters {
 // Check current parameters remain unaffected
 names = p.getParameterNames();
 assertTrue(names.hasMoreElements());
-assertEquals("foo2", names.nextElement());
 assertEquals("foo1", names.nextElement());
+assertEquals("foo2", names.nextElement());
 assertFalse(names.hasMoreElements());
 
 values = p.getParameterValues("foo1");



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1525879 - /tomcat/trunk/java/org/apache/catalina/webresources/TomcatURLStreamHandlerFactory.java

[markt]

Author: markt
Date: Tue Sep 24 13:14:11 2013
New Revision: 1525879

URL: http://svn.apache.org/r1525879
Log:
Fix typo

Modified:

tomcat/trunk/java/org/apache/catalina/webresources/TomcatURLStreamHandlerFactory.java

Modified: 
tomcat/trunk/java/org/apache/catalina/webresources/TomcatURLStreamHandlerFactory.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/webresources/TomcatURLStreamHandlerFactory.java?rev=1525879&r1=1525878&r2=1525879&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/webresources/TomcatURLStreamHandlerFactory.java
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/webresources/TomcatURLStreamHandlerFactory.java
 Tue Sep 24 13:14:11 2013
@@ -60,7 +60,7 @@ public class TomcatURLStreamHandlerFacto
  * Since the JVM only allows a single call to
  * {@link URL#setURLStreamHandlerFactory(URLStreamHandlerFactory)} and
  * Tomcat needs to register a handler, provide a mechanism to allow
- * applications to registertheir own handlers.
+ * applications to register their own handlers.
  */
 public static void addUserFactory(URLStreamHandlerFactory factory) {
 instance.userFactories.add(factory);



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Refactoring class loader access to resources

[Mark Thomas]

On 24/09/2013 05:05, Romain Manni-Bucau wrote:
> Hi
> 
> about the handler: a lot of container (i particularly know tomee but not
> only) use string representation of URL to find file to then work on the
> file (either during scanning or sometimes for some more advanced "hack").
> If you introduce something not known by these framework it will just fail.
> That's the reason why scanning is not really portable and why vfs (for
> JBoss for instance) exists. You are doing the same in tomcat (which is sad
> since tomcat was until today simple on this aspect).

I'd argue that components shouldn't be doing that as they have no idea
what URLs might be coming back.

I think the way to handle this is an option on the Context (so the
default can be changed in conf/context.xml) to expand JARs from a WAR
into the work dir and generate URLs to those files if all of the
following are true:
- running in a packed WAR
- getURLs() is called
- the option is enabled

The JARs will be deleted on context stop.

What I am trying to avoid here is the automatic copying of resources to
the work dir. I'm also trying to ensure that all resource access goes
through WebResources as I want to add some memory leak detection code
their to catch things like InputStreams that are never closed that lead
to locked files. Having spent ages trying to track down the root cause
of a locked file, I see this sort of feature as extremely useful. In the
same way the original memory leak detection code drove improvements in
Tomcat and 3rd party libraries, I think this code do the same.

> About addURL: we use it in tomee to enrich the classloader in multiple
> places (but i saw some tomcat extensions doing it too). Our needs are:
> 1) add container jar in a particular deployment mode (tomee as a webapp)
> 2) add container jar for some particular features (jsf, jpa, ... - some
> classes needs to be loaded from the webapp)
> 3) use a descriptor to define the container (typically jars.txt lists all
> jar of the loader with mvn/file/http/... syntax). Then our scanning just
> reuse getURLs().

I think this can be handled by addURL() being used to create the
appropriate dir/JAR resource and adding it to WebResources but I'm not
sure about the last one. Could you expand on that use case a little?

Cheers,

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.44

[Martin Grigorov]

On Mon, Sep 23, 2013 at 10:58 PM, Violeta Georgieva wrote:

> The proposed Apache Tomcat 7.0.44 release is now available for voting.
> This release candidate contains JSR-356 Java WebSocket 1.0 implementation.
> Note that use of this functionality requires Java 7.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.44/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-090/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_44/
>
> The proposed 7.0.44 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 7.0.44 Stable
>

Tested Apache Wicket Native WebSocket with both Tomcat 7 websocket impl and
the new JSR356 impl.


>
> Regards
> Violeta
>

Re: Refactoring class loader access to resources

[Romain Manni-Bucau]

Hi

about the handler: a lot of container (i particularly know tomee but not
only) use string representation of URL to find file to then work on the
file (either during scanning or sometimes for some more advanced "hack").
If you introduce something not known by these framework it will just fail.
That's the reason why scanning is not really portable and why vfs (for
JBoss for instance) exists. You are doing the same in tomcat (which is sad
since tomcat was until today simple on this aspect).

About addURL: we use it in tomee to enrich the classloader in multiple
places (but i saw some tomcat extensions doing it too). Our needs are:
1) add container jar in a particular deployment mode (tomee as a webapp)
2) add container jar for some particular features (jsf, jpa, ... - some
classes needs to be loaded from the webapp)
3) use a descriptor to define the container (typically jars.txt lists all
jar of the loader with mvn/file/http/... syntax). Then our scanning just
reuse getURLs().

If you want to discuss of it a bit more dynamically i'm still on IRC
(freenode #openejb) for some hours.

*Romain Manni-Bucau*
*Twitter: @rmannibucau *
*Blog: **http://rmannibucau.wordpress.com/*
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*



2013/9/24 Mark Thomas 

> On 23/09/2013 21:52, Romain Manni-Bucau wrote:
> > I already explained how t8 loader and WebResource breaks libs based on
> std
> > URLClassLoader
>
> I've looked back through the dev list archives and can't find any
> specific information that describes the problem in any detail. I'm
> fairly confident that whatever is missing / broken can be provided/fixed
> but that isn't going to happen without a clear explanation of what the
> problem is.
>
>
> > Here is the class in xbean
> >
> http://svn.apache.org/repos/asf/geronimo/xbean/trunk/xbean-finder/src/main/java/org/apache/xbean/finder/ClassLoaders.java
> >
> > I know we can workaround it but then we miss classes in the loader (was
> the
> > reason to use getURLs). Another thing is getURLs is insanely fast
> compared
> > to the other algorithm.
> >
> > Here is the xbean case but a lot of libs do it cause that's the only real
> > way to find urls from loaders.
> >
> > Another thing is jar:war urls will totally break common scanners (all
> since
> > it was not existing, isnt it?). So tomee, spring, owb, weld, ... will be
> > broken
>
> Why? They will be valid URLs in that JVM because the appropriate handler
> will have been registered. I can certainly imagine some scenarios where
> TomcatURLStreamHandlerFactory needs some tweaks to get it to play nicely
> in a broader container environment. Let us know what those tweaks are
> and they can be implemented.
>
> > Finally getURLs still say it respects addURL which doesnt look right
> (sadly)
>
> I see what happened on this. addURL() was removed as part of the
> resources refactoring that removed addRepository(). It looks like
> addURL() and the associated plumbing needs to be added back.
>
> What is the use case for needing to call addURL() on this class loader?
> It adds complexity to the class loader that I'd be happy to avoid if I
> could. Is the use case is something that can/should be handled through
> the new resources implementation?
>
> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: Refactoring class loader access to resources

[Mark Thomas]

On 23/09/2013 21:52, Romain Manni-Bucau wrote:
> I already explained how t8 loader and WebResource breaks libs based on std
> URLClassLoader

I've looked back through the dev list archives and can't find any
specific information that describes the problem in any detail. I'm
fairly confident that whatever is missing / broken can be provided/fixed
but that isn't going to happen without a clear explanation of what the
problem is.


> Here is the class in xbean
> http://svn.apache.org/repos/asf/geronimo/xbean/trunk/xbean-finder/src/main/java/org/apache/xbean/finder/ClassLoaders.java
> 
> I know we can workaround it but then we miss classes in the loader (was the
> reason to use getURLs). Another thing is getURLs is insanely fast compared
> to the other algorithm.
> 
> Here is the xbean case but a lot of libs do it cause that's the only real
> way to find urls from loaders.
> 
> Another thing is jar:war urls will totally break common scanners (all since
> it was not existing, isnt it?). So tomee, spring, owb, weld, ... will be
> broken

Why? They will be valid URLs in that JVM because the appropriate handler
will have been registered. I can certainly imagine some scenarios where
TomcatURLStreamHandlerFactory needs some tweaks to get it to play nicely
in a broader container environment. Let us know what those tweaks are
and they can be implemented.

> Finally getURLs still say it respects addURL which doesnt look right (sadly)

I see what happened on this. addURL() was removed as part of the
resources refactoring that removed addRepository(). It looks like
addURL() and the associated plumbing needs to be added back.

What is the use case for needing to call addURL() on this class loader?
It adds complexity to the class loader that I'd be happy to avoid if I
could. Is the use case is something that can/should be handled through
the new resources implementation?

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Why does mod_jk require a C++ compiler instead of just C?

[Rainer Jung]

On 24.09.2013 11:58, Mladen Turk wrote:
> On 09/23/2013 10:58 PM, Christopher Schultz wrote:
>> All,
>>
>> Someone recently on the users list[1] had some trouble building mod_jk
>> and it turned out that the problem was a missing c++ compiler.
>>
> 
> There is nothing in the code that would require C++.
> It's probably an extra (or copy/paste) configure requirement.

I had a quick look, but I find no indication of that in configure.in or
any of our m4 files.

I wonder how that comes into play. Maybe something autoomatically
triggered by the libtool used or by the gcc self-report.

I must admit: Currently no idea.

But Mladen is of course right: no use for gcc during make and we should
be able to remove the need from the configure script, only that I have
no idea how.

Regards,

Rainer


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1525831 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/ha/session/BackupManager.java java/org/apache/catalina/ha/session/DeltaManager.java webapps/docs/changelog.xml

[kfujino]

Author: kfujino
Date: Tue Sep 24 10:22:24 2013
New Revision: 1525831

URL: http://svn.apache.org/r1525831
Log:
Logger instance of cluster session manager is changed to non-static in order to 
enable logging of each application.

Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/BackupManager.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaManager.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/BackupManager.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/BackupManager.java?rev=1525831&r1=1525830&r2=1525831&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/BackupManager.java 
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/BackupManager.java 
Tue Sep 24 10:22:24 2013
@@ -42,7 +42,7 @@ import org.apache.tomcat.util.res.String
 public class BackupManager extends ClusterManagerBase
 implements MapOwner, DistributedManager {
 
-private static final Log log = LogFactory.getLog(BackupManager.class);
+private final Log log = LogFactory.getLog(BackupManager.class);
 
 /**
  * The string manager for this package.

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaManager.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaManager.java?rev=1525831&r1=1525830&r2=1525831&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaManager.java 
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaManager.java 
Tue Sep 24 10:22:24 2013
@@ -68,7 +68,7 @@ import org.apache.tomcat.util.res.String
 public class DeltaManager extends ClusterManagerBase{
 
 //  Security Classes
-public static final org.apache.juli.logging.Log log = 
org.apache.juli.logging.LogFactory.getLog(DeltaManager.class);
+public final org.apache.juli.logging.Log log = 
org.apache.juli.logging.LogFactory.getLog(DeltaManager.class);
 
 /**
  * The string manager for this package.

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1525831&r1=1525830&r2=1525831&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Tue Sep 24 10:22:24 2013
@@ -55,6 +55,16 @@
   They eventually become mixed with the numbered issues. (I.e., numbered
   issues to not "pop up" wrt. others).
 -->
+
+  
+
+  
+Logger instance of cluster session manager is changed to non-static in
+order to enable logging of each application. (kfujino)
+  
+
+  
+
 
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1525827 - in /tomcat/trunk/java/org/apache/catalina/ha/session: BackupManager.java DeltaManager.java

[kfujino]

Author: kfujino
Date: Tue Sep 24 10:08:58 2013
New Revision: 1525827

URL: http://svn.apache.org/r1525827
Log:
Logger instance of cluster session manager is changed to non-static in order to 
enable logging of each application.

Modified:
tomcat/trunk/java/org/apache/catalina/ha/session/BackupManager.java
tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java

Modified: tomcat/trunk/java/org/apache/catalina/ha/session/BackupManager.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/BackupManager.java?rev=1525827&r1=1525826&r2=1525827&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ha/session/BackupManager.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/session/BackupManager.java Tue Sep 
24 10:08:58 2013
@@ -42,7 +42,7 @@ import org.apache.tomcat.util.res.String
 public class BackupManager extends ClusterManagerBase
 implements MapOwner, DistributedManager {
 
-private static final Log log = LogFactory.getLog(BackupManager.class);
+private final Log log = LogFactory.getLog(BackupManager.class);
 
 /**
  * The string manager for this package.

Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java?rev=1525827&r1=1525826&r2=1525827&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java Tue Sep 
24 10:08:58 2013
@@ -68,7 +68,7 @@ import org.apache.tomcat.util.res.String
 public class DeltaManager extends ClusterManagerBase{
 
 //  Security Classes
-public static final org.apache.juli.logging.Log log =
+public final org.apache.juli.logging.Log log =
 org.apache.juli.logging.LogFactory.getLog(DeltaManager.class);
 
 /**



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Why does mod_jk require a C++ compiler instead of just C?

[Mladen Turk]

On 09/23/2013 10:58 PM, Christopher Schultz wrote:

All,

Someone recently on the users list[1] had some trouble building mod_jk
and it turned out that the problem was a missing c++ compiler.



There is nothing in the code that would require C++.
It's probably an extra (or copy/paste) configure requirement.


Regards
--
^TM

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

[Bill Barker]

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test :  Tomcat 8.x, a web server implementing the Java 
Servlet 3.1,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on junit exists, no need to add for property hamcrest.jar.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -DEBUG- Dependency on tomcat-trunk exists, no need to add for property 
tomcat-dbcp.home.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/build/logs



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_work/build_tomcat-trunk_tomcat-trunk-test.html
Work Name: build_tomcat-trunk_tomcat-trunk-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 56 mins 24 secs
Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-20130924.jar 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.1-SNAPSHOT.jar
 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20130924-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar
 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20130924.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20130924-native-src.tar.gz
 -Dtest.accesslog=true 
-Dcommons-pool.home=/srv/gump/public/workspace/apache-commons/pool 
-Dcommons-dbcp.home=/
 srv/gump/public/workspace/apache-commons/dbcp 
-Deasymock.jar=/srv/gump/public/workspace/easymock/easymock/target/easymock-3.3-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/public/workspace/junit/dist/junit-20130924.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servle
 
t-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-jni.jar:/srv/gump/public/workspace/tomcat
 
-trunk/output/build/lib/tomcat-spdy.jar:/srv/g