Bug report for Taglibs [2013/10/13]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |38193|Ass|Enh|2006-01-09|[RDC] BuiltIn Grammar support for Field | |38600|Ass|Enh|2006-02-10|[RDC] Enable RDCs to be used in X+V markup (X+RDC)| |42413|New|Enh|2007-05-14|[PATCH] Log Taglib enhancements | |46052|New|Nor|2008-10-21|SetLocaleSupport is slow to initialize when many l| |48333|New|Enh|2009-12-02|TLD generator | |55609|New|Enh|2013-09-28|c:forEach loop on integer range consumes unnecessa| +-+---+---+--+--+ | Total6 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat 7 [2013/10/13]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |18500|New|Enh|2003-03-30|Host aliases to match by regular expression | |28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn | |40881|Opn|Enh|2006-11-02|Unable to receive message through TCP channel -> | |41007|Opn|Enh|2006-11-20|Can't define customized 503 error page| |43866|New|Enh|2007-11-14|add support for session attribute propagation with| |43925|Opn|Enh|2007-11-21|org.apache.jasper.runtime.BodyContentImpl causing | |44216|New|Enh|2008-01-11|Don't reuse session ID even if emptySessionPath=tr| |49134|Inf|Nor|2010-04-16|Server.stop() doesn't unregister all MBeans | |49395|New|Enh|2010-06-06|manager.findLeaks : display the date when the leak| |49589|New|Enh|2010-07-12|Tag handlers with constant attribute values are al| |49785|New|Enh|2010-08-19|Enabling TLS for JNDIRealm| |49821|New|Enh|2010-08-25|Tomcat CLI| |50019|New|Enh|2010-09-28|Adding JNDI "lookup-name" support In XML and Resou| |50175|New|Enh|2010-10-28|Enhance memory leak detection by selectively apply| |50234|New|Enh|2010-11-08|JspC use servlet 3.0 features | |50504|New|Enh|2010-12-21|Allow setting query string character set trough re| |50670|New|Enh|2011-01-27|Tribes | RpcChannel | Add option to specify extern| |51195|New|Enh|2011-05-13|"Find leaks" reports a false positive memory/class| |51294|Opn|Enh|2011-05-30|Since 7.0.12 do not work option unpackWARs=true fo| |51423|Inf|Enh|2011-06-23|[Patch] to add a path and a version parameters to | |51463|New|Enh|2011-07-01|Tomcat.setBaseDir (package org.apache.catalina.st| |51496|New|Enh|2011-07-11|NSIS - Warn that duplicate service name will resul| |51587|New|Enh|2011-07-29|Implement status and uptime commands | |51953|New|Enh|2011-10-04|Proposal: netmask filtering valve and filter | |52235|New|Enh|2011-11-23|Please do a bit of SEO tuning for the web site| |52323|New|Enh|2011-12-13|Cobertura test code coverage support for build.xml| |52381|New|Enh|2011-12-22|Please add OSGi metadata | |52448|New|Enh|2012-01-11|Cache jar indexes in WebappClassLoader to speed up| |52489|New|Enh|2012-01-19|Enhancement request for code signing of war files | |52688|New|Enh|2012-02-16|Add ability to remove old access log files| |52751|Opn|Enh|2012-02-23|Optimized configuration of the system info display| |52952|New|Enh|2012-03-20|Improve ExtensionValidator handling for embedded s| |53085|New|Enh|2012-04-16|[perf] [concurrency] DefaultInstanceManager.annota| |53387|New|Enh|2012-06-08|SSI: Allow to use $1 to get result of regular expr| |53411|Opn|Enh|2012-06-13|NullPointerException in org.apache.tomcat.util.buf| |53492|New|Enh|2012-07-01|Make JspC shell multithreaded | |53553|New|Enh|2012-07-16|[PATCH] Deploy uploaded WAR with context.xml from | |53620|New|Enh|2012-07-30|[juli] delay opening a file until something gets l| |54330|New|Enh|2012-12-19|Patch with some refactoring of Member.java| |54499|New|Enh|2013-01-29|Implementation of Extensible EL Interpreter | |54618|New|Enh|2013-02-28|Add filter implementing HTTP Strict Transport Secu| |54802|New|Enh|2013-04-04|Provide location information for exceptions thrown| |55104|New|Enh|2013-06-16|Allow passing arguments with spaces to Commons Dae| |55470|New|Enh|2013-08-23|Help users for ClassNotFoundExceptions during star| |55477|New|Enh|2013-08-23|Add a solution to map an realm name to a security | |55530|New|Enh|2013-09-06|webdavServlet support aliases folder upload and de| +-+---+---+--+--+ | Total 46 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: d
Bug report for Tomcat 8 [2013/10/13]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |51497|New|Enh|2011-07-11|Use canonical IPv6 text representation in logs| |53737|Opn|Enh|2012-08-18|Use ServletContext.getJspConfigDescriptor() in Jas| |53930|New|Enh|2012-09-24|allow capture of catalina stdout/stderr to a comma| |54503|New|Enh|2013-01-29|SAML2 based single sign on| |54700|New|Enh|2013-03-15|Improvement: Add support for system property to sp| |54741|New|Enh|2013-03-22|Add org.apache.catalina.startup.Tomcat#addWebapp(S| |55006|New|Enh|2013-05-22|Add http proxy support for ClientEndpoint using sy| |55212|New|Enh|2013-07-08|Jasper does not validate XSD-based configuration f| |55243|New|Enh|2013-07-11|Add special search string for nested roles| |55252|New|Enh|2013-07-12|Separate Ant and command-line wrappers for JspC | |55383|New|Enh|2013-08-07|Improve markup and design of Tomcat's HTML pages | |55479|New|Enh|2013-08-24|JSR 196 (JASPIC) support in Tomcat| |9|New|Enh|2013-09-14|UserDatabaseRealm enhacement: may use local JNDI | +-+---+---+--+--+ | Total 13 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat 6 [2013/10/13]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |41679|New|Enh|2007-02-22|SemaphoreValve should be able to filter on url pat| |41883|Ass|Enh|2007-03-18|use abstract wrapper instead of plain X509Certific| |43001|New|Enh|2007-07-30|JspC lacks setMappedFile and setDie for use in Ant| |43400|New|Enh|2007-09-14|enum support for tag libs | |43548|Opn|Enh|2007-10-04|xml schema for tomcat-users.xml | |43682|New|Enh|2007-10-23|JULI: web-inf/classes/logging.properties to suppor| |43742|New|Enh|2007-10-30|.tag compiles performed one at a time -- extremel| |43979|New|Enh|2007-11-27|Add abstraction for Java and Classfile output | |44199|New|Enh|2008-01-10|expose current backlog queue size | |44225|New|Enh|2008-01-14|SSL connector tries to load the private keystore f| |44294|New|Enh|2008-01-25|Support for EL functions with varargs | |44645|New|Enh|2008-03-20|[Patch] JNDIRealm - Doesn't support JNDI "java.nam| |44787|New|Enh|2008-04-09|provide more error context on "java.lang.IllegalSt| |45014|New|Enh|2008-05-15|Request and Response classes should have wrappers | |45282|New|Enh|2008-06-25|NioReceiver doesn't close cleanly, leaving sockets| |45832|New|Enh|2008-09-18|add DIGEST authentication support to Ant tasks| |45878|New|Enh|2008-09-24|Generated jars do not contain proper manifests or | |45879|Opn|Enh|2008-09-24|Windows installer fails to install NOTICE and RELE| |45931|Opn|Enh|2008-10-01|trimSpaces incorrectly modifies output| |46173|New|Enh|2008-11-09|Small patch for manager app: Setting an optional c| |46284|New|Enh|2008-11-24|Add flag to DeltaManager that blocks processing cl| |46350|New|Enh|2008-12-05|Maven repository should contain source bundles| |46558|Opn|Enh|2009-01-19|Shutdown port with address binding| |46902|New|Enh|2009-03-24|LoginValve to bypass restrictions of j_security_ch| |47214|New|Enh|2009-05-17|Inner classes that are explicitly referenced - sho| |47242|New|Enh|2009-05-22|request for AJP command line client | |47281|New|Enh|2009-05-28|Efficiency of the JDBCStore | |47407|New|Enh|2009-06-23|HttpSessionListener doesn't operate in the session| |47467|New|Enh|2009-07-02|Deployment of the war file by URL when contextpath| |47834|New|Enh|2009-09-14|TldConfig throws Exception when exploring unpacked| |47919|New|Enh|2009-09-30|Log Tomcat & Java environment variables in additio| |48358|Opn|Enh|2009-12-09|JSP-unloading reloaded| |48543|New|Enh|2010-01-14|[Patch] More flexibility in specifying -Dcatalina.| |48672|New|Enh|2010-02-03|Tomcat Virtual Host Manager (/host-manager) have b| |48674|New|Enh|2010-02-03|Tomcat Virtual Host Manager application doesn't pe| |48743|New|Enh|2010-02-15|Make the SLEEP variable in catalina.sh settable fr| |48899|New|Enh|2010-03-12|Guess URI charset should solve lot of problems| |48922|New|Enh|2010-03-16|org.apache.catalina.connector.Request clone static| |48928|New|Enh|2010-03-17|An alternative solution to preloading classes when| |49161|New|Enh|2010-04-21|Unknown Publisher when installing tomcat 6.0.26 | |49176|Opn|Enh|2010-04-23|Jasper in Dev Mode Is Memory Inefficient | |49464|New|Enh|2010-06-18|DefaultServlet and CharacterEncoding | |49531|New|Enh|2010-06-30|singlesignon failover not working on DeltaManager/| |49804|New|Enh|2010-08-23|Allow Embedded.redirectStreams value to be configu| |49939|New|Enh|2010-09-16|Expose a method via JMX which empties the webapp f| |49943|New|Enh|2010-09-16|Logging (via juli) does not reread configuration c| |50285|New|Enh|2010-11-17|Standard HTTP and AJP connectors silently ignore a| |50288|New|Enh|2010-11-17|Uploading a war file that already exists should au| |50692|New|Enh|2011-01-31|Improve log message in ThreadPool.logFull | |51142|New|Enh|2011-05-03|Offer possible resolution of StringIndexOutOfBound| |51513|New|Enh|2011-07-15|GzipInterceptor: Do not compress small packages | |51966|
Bug report for Tomcat Connectors [2013/10/13]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |34526|Opn|Nor|2005-04-19|Truncated content in decompressed requests from mo| |35959|Opn|Enh|2005-08-01|mod_jk not independant of UseCanonicalName| |43303|New|Enh|2007-09-04|Versioning under Windows not reported by many conn| |43968|Inf|Enh|2007-11-26|[patch] support ipv6 with mod_jk | |44290|Inf|Nor|2008-01-24|mod_jk/1.2.26: retry is not useful for an importan| |44349|Inf|Maj|2008-02-04|mod_jk/1.2.26 module does not read worker.status.s| |44379|New|Enh|2008-02-07|convert the output of strftime into UTF-8 | |44454|New|Nor|2008-02-19|busy count reported in mod_jk inflated, causes inc| |44571|New|Enh|2008-03-10|Limits busy per worker to a threshold | |45063|New|Nor|2008-05-22|JK-1.2.26 IIS ISAPI filter issue when running diff| |45313|New|Nor|2008-06-30|mod_jk 1.2.26 & apache 2.2.9 static compiled on so| |46337|New|Nor|2008-12-04|real worker name is wrong | |46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca| |47327|New|Enh|2009-06-07|remote_user not logged in apache logfile | |47617|Inf|Enh|2009-07-31|include time spent doing ajp_get_endpoint() in err| |47678|New|Cri|2009-08-11|Unable to allocate shared memory when using isapi_| |47714|New|Cri|2009-08-20|Reponse mixed between users | |47750|New|Maj|2009-08-27|Loss of worker settings when changing via jkstatus| |47795|New|Maj|2009-09-07|service sticky_session not being set correctly wit| |47840|Inf|Min|2009-09-14|A broken worker name is written in the log file. | |48191|New|Maj|2009-11-13|Problem with mod_jk 1.2.28 - Can not render up the| |48460|New|Nor|2009-12-30|mod_proxy_ajp document has three misleading portio| |48490|New|Nor|2010-01-05|Changing a node to stopped in uriworkermap.propert| |48513|New|Enh|2010-01-09|IIS Quick setup instructions | |48564|New|Nor|2010-01-18|Unable to turn off retries for LB worker | |48830|New|Nor|2010-03-01|IIS shutdown blocked in endpoint service when serv| |48891|Opn|Enh|2010-03-11|Missing EOL-style settings in tomcat/jk/trunk | |49035|New|Maj|2010-04-01|data lost when post a multipart/form-data form| |49063|New|Enh|2010-04-07|Please add JkStripSession status in jk-status work| |49135|New|Enh|2010-04-16|SPDY Connector for The Tomcat | |49469|New|Enh|2010-06-19|Workers status page has negative number of connect| |49732|Opn|Nor|2010-08-10|reply_timeout can't wait forever. | |49822|New|Enh|2010-08-25|Add hash lb worker method | |49903|New|Enh|2010-09-09|Make workers file reloadable | |50186|New|Nor|2010-10-31|Wrong documentation of connection_pool_timeout / c| |52334|New|Maj|2011-12-14|recover_time is not properly used | |52483|New|Enh|2012-01-18|Print JkOptions's options in log file and jkstatus| |52651|New|Nor|2012-02-13|JKSHMFile size limitation | |53324|Opn|Nor|2012-05-30|Starting with mod_jk 1.2.35 I cannot modify worker| |53542|New|Min|2012-07-13|Spelling mistake on 503 service unavailable page | |53762|New|Nor|2012-08-22|JK status manager: mass nodes handling doesn't wor| |53883|New|Maj|2012-09-17|isapi_redirect v 1.2.37 crashes w3wp.exe on the p| |53977|New|Maj|2012-10-07|32bits isapi connector cannot work in wow64 mode | |54027|New|Cri|2012-10-18|isapi send request to outside address instead of i| |54112|Opn|Blk|2012-11-07|ISAPI redirector not working when IIS recycles| |54117|New|Maj|2012-11-08|access violation exception in isapi_redirect.dll | |54177|New|Nor|2012-11-20|jkmanager generates non-well-formed XML for certai| |54596|New|Nor|2013-02-22|Relative path functionality truncates last charact| |54621|New|Nor|2013-02-28|[PATCH] custom mod_jk availability checks | |54646|New|Trv|2013-03-06|socket_keepalive is sometimes 1 or true or True in| |54923|New|Nor|2013-05-03|nsapi_redirect.so does not work with iPlanet on So| |55094|
Bug report for Tomcat Native [2013/10/13]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |46179|Opn|Maj|2008-11-10|apr ssl client authentication | |48655|Inf|Nor|2010-02-02|Active multipart downloads prevent tomcat shutdown| |49038|Inf|Nor|2010-04-02|Crash in tcnative | |52153|New|Maj|2011-11-08|periodic JVM crash (access violation) on buffer fl| |52319|New|Maj|2011-12-12|Tomcat 6 crashes with [libapr-1.so.0+0x196da] sig| |52627|New|Min|2012-02-08|Segmentation fault in org.apache.tomcat.jni.File.i| |53605|New|Nor|2012-07-26|use tcnative-1.1.24 Tomcat shutdown still crash | |53847|Inf|Nor|2012-09-10|High CPU usage in tomcat native 1.22+ | |53940|New|Enh|2012-09-27|Added support for new CRL loading after expiration| |53952|New|Nor|2012-10-02|Add support for TLS 1.1 and 1.2 | |54085|New|Nor|2012-11-01|ssl_socket_recv sometimes loops infinitely with no| |54664|New|Reg|2013-03-11|[1.1.27 branch] Poll.remove incorrectly reports AP| |55087|New|Cri|2013-06-10|tomcat crashes in tcnative-1.dll with OCSP when OC| |55113|New|Nor|2013-06-18|FIPS-compatible OpenSSL fails fingerprint test in | |55114|New|Nor|2013-06-18|BUILDING file in win32 source package contains UNI| |55588|Inf|Maj|2013-09-24|Tomcat randomly crashes with [libtcnative-1.so+0x1| +-+---+---+--+--+ | Total 16 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Modules [2013/10/13]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |48240|New|Nor|2009-11-19|Tomcat-Lite missing @Override markers | |48268|New|Nor|2009-11-23|Patch to fix generics in tomcat-lite | |48861|New|Nor|2010-03-04|Files without AL headers | |49685|New|Nor|2010-08-02|Unsafe synchronization in class ManagedBean | |49686|New|Nor|2010-08-02|Using an instance lock to protect static shared da| |50571|Inf|Nor|2011-01-11|Tomcat 7 JDBC connection pool exception enhancemen| |51595|Inf|Nor|2011-08-01|org.apache.tomcat.jdbc.pool.jmx.ConnectionPool sho| |51879|Inf|Enh|2011-09-22|Improve access to Native Connection Methods | |52024|Inf|Enh|2011-10-13|Custom interceptor to support automatic failover o| |53088|Opn|Min|2012-04-17|Give PoolCleaner TimerTask a better name | |53198|New|Cri|2012-05-07|'driverClassName' Data Source Property Being Manda| |53199|Inf|Enh|2012-05-07|Refactor ConnectionPool to use ScheduledExecutorSe| |53200|New|Enh|2012-05-07|Be able to use SlowQueryReport without reporting f| |53770|New|Enh|2012-08-23|tomcat-pool: always log validation query syntax er| |53853|New|Nor|2012-09-11|Can tomcat-jdbc consider Thread#getContextClassLoa| |54225|New|Nor|2012-11-30|if initSQL property is set to an empty string a Nu| |54227|New|Nor|2012-11-30|maxAge should be checked on borrow| |54235|New|Nor|2012-12-03|tomcat jdbc pool stackoverflow error used with spr| |54395|New|Nor|2013-01-09|JdbcInterceptor config parameter parsing errors | |54437|New|Enh|2013-01-16|Update PoolProperties javadoc for ConnectState int| |54537|New|Cri|2013-02-07|StatementFinalizer closeInvoked is too slow for la| |54929|New|Nor|2013-05-05|jdbc-pool cannot be used with Java 1.5, "java.lang| |54978|New|Nor|2013-05-15|Validate on Borrow should be tested on Reconnect i| |55078|New|Nor|2013-06-07|Configuring a DataSource Resource with dataSourceJ| |55444|New|Nor|2013-08-18|Support JDBC Drivers outside of tomcat/lib/ | +-+---+---+--+--+ | Total 25 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1531625 - /tomcat/trunk/build.properties.default
Author: markt Date: Sun Oct 13 08:17:57 2013 New Revision: 1531625 URL: http://svn.apache.org/r1531625 Log: Update pool and dbcp snapshots Modified: tomcat/trunk/build.properties.default Modified: tomcat/trunk/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=1531625&r1=1531624&r2=1531625&view=diff == --- tomcat/trunk/build.properties.default (original) +++ tomcat/trunk/build.properties.default Sun Oct 13 08:17:57 2013 @@ -152,7 +152,7 @@ tomcat-native.win.2=${base-tomcat.loc.2} #commons-dbcp.home=${base.path}/commons-dbcp-${commons-dbcp.version}-src #commons-dbcp-src.loc.1=${base-commons.loc.1}/dbcp/source/commons-dbcp-${commons-dbcp.version}-src.tar.gz #commons-dbcp-src.loc.2=${base-commons.loc.2}/dbcp/source/commons-dbcp-${commons-dbcp.version}-src.tar.gz -commons-dbcp.version=2.0-20130809.062714-130 +commons-dbcp.version=2.0-20131011.192659-135 commons-dbcp.home=${base.path}/commons-dbcp2-2.0-SNAPSHOT-src commons-dbcp-src.loc.1=https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-dbcp2/2.0-SNAPSHOT/commons-dbcp2-${commons-dbcp.version}-src.tar.gz commons-dbcp-src.loc.2=https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-dbcp2/2.0-SNAPSHOT/commons-dbcp2-${commons-dbcp.version}-src.tar.gz @@ -163,7 +163,7 @@ commons-dbcp-src.loc.2=https://repositor #commons-pool-src.loc.1=${base-commons.loc.1}/pool/source/commons-pool-${commons-pool.version}-src.tar.gz #commons-pool-src.loc.2=${base-commons.loc.2}/pool/source/commons-pool-${commons-pool.version}-src.tar.gz #Temporary use of snapshots until Commons Pool 2 has its first release -commons-pool.version=2.0-20131011.142522-239 +commons-pool.version=2.0-20131011.192519-241 commons-pool.home=${base.path}/commons-pool2-2.0-SNAPSHOT-src commons-pool-src.loc.1=https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-pool2/2.0-SNAPSHOT/commons-pool2-${commons-pool.version}-src.tar.gz commons-pool-src.loc.2=https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-pool2/2.0-SNAPSHOT/commons-pool2-${commons-pool.version}-src.tar.gz - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [Tomcat 8.0.x trunk] APR sendfile problem
On 12/10/2013 23:27, Konstantin Preißer wrote: > > >> -Original Message- >> From: Ognjen Blagojevic [mailto:ognjen.d.blagoje...@gmail.com] >> Sent: Sunday, October 13, 2013 12:11 AM >> To: Tomcat Developers List >> Subject: Re: [Tomcat 8.0.x trunk] APR sendfile problem >> >> Konstantin, >> >> On 12.10.2013 3:52, Konstantin Preißer wrote: >>> I also tried this now with trunk (r1531312) and Native 1.1.29 RC on Windows >> 8 64-bit with Java 1.7.0_40, and can confirm the behavior: >>> With the above configuration for a SSL HTTP APR connector, I cannot >> receive the contents of "/docs/manager-howto.html", whereas it works if I >> either add useSendfile="true" or useSendfile="false". >> >> Thank you for verifying. >> >> I now re-read the docs, and realized that sendfile is not allowed with >> HTTPS, so one should always add useSendfile="false" to HTTPS APR >> connector. >> >> It is strange that useSendfile="true", and not adding attribute >> useSendfile at all behaves differently, but this is, IMO, minor issue in >> interpreting server.xml. > > BTW, if I revert the changes in r1530269 (in AprEndpoint) then that specific > issue does no longer appear when "useSendfile" attribute is not specified on > the SSL connector - then Firefox shows the correct contents if I request > "/docs/manager-howto.html". Thanks - that tells me where to look. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot success in ASF Buildbot on tomcat-trunk
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5103 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1531625 Blamelist: markt Build succeeded! sincerely, -The Buildbot
svn commit: r1531659 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java res/LocalStrings.properties
Author: markt Date: Sun Oct 13 09:42:32 2013 New Revision: 1531659 URL: http://svn.apache.org/r1531659 Log: Fix the regression in r1530269. Enabling/disabling sendfile should occur during bind not during start. Add a warning message if the user tries to explicitly enable sendfile with SSL. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java tomcat/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=1531659&r1=1531658&r2=1531659&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Sun Oct 13 09:42:32 2013 @@ -457,8 +457,11 @@ public class AprEndpoint extends Abstrac Socket.optSet(serverSock, Socket.APR_SO_REUSEADDR, 1); } -// Sendfile usage on systems which don't support it cause major problems -if (useSendfile && !Library.APR_HAS_SENDFILE) { +// Enable Sendfile by default if it has not been configured but usage on +// systems which don't support it cause major problems +if (!useSendFileSet) { +useSendfile = Library.APR_HAS_SENDFILE; +} else if (useSendfile && !Library.APR_HAS_SENDFILE) { useSendfile = false; } @@ -583,7 +586,12 @@ public class AprEndpoint extends Abstrac } SSLContext.setVerify(sslContext, value, SSLVerifyDepth); // For now, sendfile is not supported with SSL -useSendfile = false; +if (useSendfile) { +useSendfile = false; +if (useSendFileSet) { +log.warn(sm.getString("endpoint.apr.noSendfileWithSSL")); +} +} } } @@ -617,9 +625,6 @@ public class AprEndpoint extends Abstrac pollerThread.start(); // Start sendfile thread -if (!useSendFileSet) { -useSendfile = Library.APR_HAS_SENDFILE; -} if (useSendfile) { sendfile = new Sendfile(); sendfile.init(); Modified: tomcat/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties?rev=1531659&r1=1531658&r2=1531659&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties (original) +++ tomcat/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties Sun Oct 13 09:42:32 2013 @@ -55,4 +55,5 @@ endpoint.apr.pollAddInvalid=Invalid atte endpoint.apr.pollError=Poller failed with error [{0}] : [{1}] endpoint.apr.pollUnknownEvent=A socket was returned from the poller with an unrecognized event [{0}] endpoint.apr.invalidSslProtocol=An invalid value [{0}] was provided for the SSLProtocol attribute +endpoint.apr.noSendfileWithSSL=Sendfile is not supported for the APR/native connector when SSL is enabled endpoint.nio.selectorCloseFail=Failed to close selector when closing the poller - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [Tomcat 8.0.x trunk] APR sendfile problem
On 13/10/2013 09:21, Mark Thomas wrote: > On 12/10/2013 23:27, Konstantin Preißer wrote: >> >> >>> -Original Message- >>> From: Ognjen Blagojevic [mailto:ognjen.d.blagoje...@gmail.com] >>> Sent: Sunday, October 13, 2013 12:11 AM >>> To: Tomcat Developers List >>> Subject: Re: [Tomcat 8.0.x trunk] APR sendfile problem >>> >>> Konstantin, >>> >>> On 12.10.2013 3:52, Konstantin Preißer wrote: I also tried this now with trunk (r1531312) and Native 1.1.29 RC on Windows >>> 8 64-bit with Java 1.7.0_40, and can confirm the behavior: With the above configuration for a SSL HTTP APR connector, I cannot >>> receive the contents of "/docs/manager-howto.html", whereas it works if I >>> either add useSendfile="true" or useSendfile="false". >>> >>> Thank you for verifying. >>> >>> I now re-read the docs, and realized that sendfile is not allowed with >>> HTTPS, so one should always add useSendfile="false" to HTTPS APR >>> connector. >>> >>> It is strange that useSendfile="true", and not adding attribute >>> useSendfile at all behaves differently, but this is, IMO, minor issue in >>> interpreting server.xml. >> >> BTW, if I revert the changes in r1530269 (in AprEndpoint) then that specific >> issue does no longer appear when "useSendfile" attribute is not specified on >> the SSL connector - then Firefox shows the correct contents if I request >> "/docs/manager-howto.html". > > Thanks - that tells me where to look. Fixed. Thanks again for the pointers. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1531673 - /tomcat/trunk/bin/catalina.bat
Author: kkolinko Date: Sun Oct 13 12:15:10 2013 New Revision: 1531673 URL: http://svn.apache.org/r1531673 Log: For https://issues.apache.org/bugzilla/show_bug.cgi?id=55620 Correct a copy-paste typo in r1530890 Modified: tomcat/trunk/bin/catalina.bat Modified: tomcat/trunk/bin/catalina.bat URL: http://svn.apache.org/viewvc/tomcat/trunk/bin/catalina.bat?rev=1531673&r1=1531672&r2=1531673&view=diff == --- tomcat/trunk/bin/catalina.bat (original) +++ tomcat/trunk/bin/catalina.bat Sun Oct 13 12:15:10 2013 @@ -145,7 +145,7 @@ goto end if "%CATALINA_BASE%" == "%CATALINA_BASE:;=%" goto baseNoSemicolon echo Using CATALINA_BASE: "%CATALINA_BASE%" -echo Unable to start as CATALINA_HOME contains a semicolon (;) character +echo Unable to start as CATALINA_BASE contains a semicolon (;) character goto end :baseNoSemicolon - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1531680 - /tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/web.xml
Author: kpreisser Date: Sun Oct 13 12:30:56 2013 New Revision: 1531680 URL: http://svn.apache.org/r1531680 Log: Allow the JSR 356 WebSocket examples using the programmatic API (Endpoint subclasses) to work as they use a ServletContextListener that has @WebListener annotation, which would not be called with metadata-complete="true". Modified: tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/web.xml Modified: tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/web.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/web.xml?rev=1531680&r1=1531679&r2=1531680&view=diff == --- tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/web.xml (original) +++ tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/web.xml Sun Oct 13 12:30:56 2013 @@ -20,7 +20,7 @@ xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd"; version="3.0" - metadata-complete="true"> + metadata-complete="false"> Servlet and JSP Examples. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Serving gz files in DefaultServlet (Re: r1531115, BZ 54095)
Hi! Regarding this commit: 2013/10/11 : > Author: markt > Date: Thu Oct 10 21:24:59 2013 > New Revision: 1531115 > > URL: http://svn.apache.org/r1531115 > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54095 > Add support to the Default Servlet for serving gzipped versions of static > resources directly from disk as an alternative to Tomcat compressing them on > each request. Patch by Philippe Marschall. > > Added: > tomcat/trunk/test/webapp/index.html.gz (with props) > Modified: > tomcat/trunk/conf/web.xml > tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java > tomcat/trunk/test/org/apache/catalina/servlets/TestDefaultServlet.java > tomcat/trunk/webapps/docs/changelog.xml > tomcat/trunk/webapps/docs/default-servlet.xml > General: I think this feature should be opt-in, like the listings feature of DefaultServlet, being off by default. Concerns: (1) Excessive disk access to check existence of gz files. (2) Additional access path for ".gz" files, which might be not covered by security constraints (3) Interoperability with filters that may preprocess or postprocess the response, including ISE handling in the following lines of DefaultServlet: [[[ try { ostream = response.getOutputStream(); } catch (IllegalStateException e) { ... writer = response.getWriter(); ]]] (2) and (3) would occur only if both "foo" and "foo.gz" files are present. As (2) requires the presence and accessibility of "foo" file (as "resource.exists()" check is done before gzip processing), I see no exploitable issue here, though we may mention this on the "security-howto" page. Technical issues with the code: 1) "If-Modified-Since" header processing is inconsistent, The checkIfHeaders(...) call happens before gzip processing and checks the date of original resource, not of gz one, but "ETag" and "Last-Modified" headers will be for the gz resource. I think it is better to respond with "ETag" and "Last-Modified" of the original resource. 2) I think that if it is an "included" resource, the gzip feature should be disabled. See lines 751-752 as an example: [[[ boolean included = (request.getAttribute( RequestDispatcher.INCLUDE_CONTEXT_PATH) != null); ]]] 3) The following line: >+ gzipResource.setMimeType(contentType); I think that line is not needed here, as the "Content-Type" header is served from a local variable, not property of the resource. Moreover I suspect that it changes mime-type of a cached resource and a subsequent direct request for "foo.gz" will be served with wrong mime-type. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot failure in ASF Buildbot on tomcat-7-trunk
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1469 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1531680 Blamelist: kpreisser BUILD FAILED: failed compile_1 sincerely, -The Buildbot
Re: svn commit: r1531680 - /tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/web.xml
On 13/10/2013 13:30, kpreis...@apache.org wrote: > Author: kpreisser > Date: Sun Oct 13 12:30:56 2013 > New Revision: 1531680 > > URL: http://svn.apache.org/r1531680 > Log: > Allow the JSR 356 WebSocket examples using the programmatic API (Endpoint > subclasses) to work as they use a ServletContextListener that has > @WebListener annotation, which would not be called with > metadata-complete="true". That appears to have triggered a number of CI failures. Implementing a ServerEndpointConfig and letting the SCI deploy it would be an alternative option. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: svn commit: r1531680 - /tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/web.xml
Mark, > -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Sunday, October 13, 2013 3:58 PM > To: Tomcat Developers List > Subject: Re: svn commit: r1531680 - > /tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/web.xml > > On 13/10/2013 13:30, kpreis...@apache.org wrote: > > Author: kpreisser > > Date: Sun Oct 13 12:30:56 2013 > > New Revision: 1531680 > > > > URL: http://svn.apache.org/r1531680 > > Log: > > Allow the JSR 356 WebSocket examples using the programmatic API > (Endpoint subclasses) to work as they use a ServletContextListener that has > @WebListener annotation, which would not be called with metadata- > complete="true". > > That appears to have triggered a number of CI failures. OK, can you give me a hint why buildbot fails? When I look at the stdio logs for compile_1 [1], I can see NPEs in the examples-WsConfigListener that did not happen previously (but they happen also in trunk). I do also get these NPEs when I debug Tomcat in Eclipse as it seems the Servlet Context did not have the "javax.websocket.server.ServerContainer" attribute. I solved this by adding new WsContextListener().contextInitialized(sce); at the beginning of contextInitialized() method in the WsConfigListener. But I don't know if the failures have something to do with it. (When I build Tomcat7 locally with WebSocket support and run it, then I do not get such exceptions.) Regards, Konstantin Preißer [1] http://ci.apache.org/builders/tomcat-7-trunk/builds/1469/steps/compile_1/logs/stdio - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: svn commit: r1531680 - /tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/web.xml
> -Original Message- > From: Konstantin Preißer [mailto:kpreis...@apache.org] > Sent: Sunday, October 13, 2013 4:34 PM > To: 'Tomcat Developers List' > Subject: RE: svn commit: r1531680 - > /tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/web.xml > > "javax.websocket.server.ServerContainer" attribute. I solved this by adding > new WsContextListener().contextInitialized(sce); > at the beginning of contextInitialized() method in the WsConfigListener. Sorry, that should read: I solved this by adding new org.apache.tomcat.websocket.server.WsContextListener.contextInitialized(sce); at the beginning of contextInitialized() method in the Examples WsConfigListeners. Regards, Konstantin Preißer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1531696 - /tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java
Author: markt Date: Sun Oct 13 14:58:44 2013 New Revision: 1531696 URL: http://svn.apache.org/r1531696 Log: Review by kkolinko - disable use of gzip version for included resources - don't change the content type of the gzip'd version of the resource - use eTag and last modified date from original rather than gzip'd version - don't fall back to write when using gzip'd version Modified: tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java Modified: tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java?rev=1531696&r1=1531695&r2=1531696&view=diff == --- tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java (original) +++ tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java Sun Oct 13 14:58:44 2013 @@ -744,11 +744,12 @@ public class DefaultServlet boolean isError = response.getStatus() >= HttpServletResponse.SC_BAD_REQUEST; +boolean included = false; // Check if the conditions specified in the optional If headers are // satisfied. if (resource.isFile()) { // Checking If headers -boolean included = (request.getAttribute( +included = (request.getAttribute( RequestDispatcher.INCLUDE_CONTEXT_PATH) != null); if (!included && !isError && !checkIfHeaders(request, response, resource)) { @@ -764,16 +765,29 @@ public class DefaultServlet resource.setMimeType(contentType); } +// These need to reflect the original resource, not the potentially +// gzip'd version of the resource so get them now if they are going to +// be needed later +String eTag = null; +String lastModifiedHttp = null; +if (resource.isFile() && !isError) { +eTag = resource.getETag(); +lastModifiedHttp = resource.getLastModifiedHttp(); +} + + // Serve a gzipped version of the file if present -if (gzip -&& checkIfGzip(request) -&& resource.isFile() -&& !path.endsWith(".gz")) { +boolean usingGzippedVersion = false; +if (gzip && +resource.isFile() && +!included && +!path.endsWith(".gz") && +checkIfGzip(request)) { WebResource gzipResource = resources.getResource(path + ".gz"); if (gzipResource.exists() && gzipResource.isFile()) { -gzipResource.setMimeType(contentType); response.addHeader("Content-Encoding", "gzip"); resource = gzipResource; +usingGzippedVersion = true; } } @@ -800,11 +814,10 @@ public class DefaultServlet ranges = parseRange(request, response, resource); // ETag header -response.setHeader("ETag", resource.getETag()); +response.setHeader("ETag", eTag); // Last-Modified header -response.setHeader("Last-Modified", -resource.getLastModifiedHttp()); +response.setHeader("Last-Modified", lastModifiedHttp); } // Get content length @@ -829,10 +842,12 @@ public class DefaultServlet } catch (IllegalStateException e) { // If it fails, we try to get a Writer instead if we're // trying to serve a text file -if ( (contentType == null) -|| (contentType.startsWith("text")) -|| (contentType.endsWith("xml")) -|| (contentType.contains("/javascript")) ) { +if (!usingGzippedVersion && +((contentType == null) || +(contentType.startsWith("text")) || +(contentType.endsWith("xml")) || +(contentType.contains("/javascript"))) +) { writer = response.getWriter(); // Cannot reliably serve partial content with a Writer ranges = FULL; - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Serving gz files in DefaultServlet (Re: r1531115, BZ 54095)
On 13/10/2013 14:11, Konstantin Kolinko wrote: >> URL: http://svn.apache.org/r1531115 >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54095 >> Add support to the Default Servlet for serving gzipped versions of static >> resources directly from disk as an alternative to Tomcat compressing them on >> each request. Patch by Philippe Marschall. > General: > I think this feature should be opt-in, like the listings feature of > DefaultServlet, being off by default. I disagree since: - this is only in 8.0.x and we haven't had a stable release yet. - the user has to create the gzip'd version which is unlikely to exist be default before this feature does anything I agree if it is ever back-ported to earlier versions it needs to be disabled by default. > Concerns: > (1) Excessive disk access to check existence of gz files. The caching mechanism should handle this the same way it does for any other static resource. > (2) Additional access path for ".gz" files, which might be not covered > by security constraints > > (3) Interoperability with filters that may preprocess or postprocess > the response, > including ISE handling in the following lines of DefaultServlet: > > [[[ > try { > ostream = response.getOutputStream(); > } catch (IllegalStateException e) { > ... > writer = response.getWriter(); > ]]] > > (2) and (3) would occur only if both "foo" and "foo.gz" files are present. I've disabled the fall back for (3). > As (2) requires the presence and accessibility of "foo" file (as > "resource.exists()" check is done before gzip processing), I see no > exploitable issue here, though we may mention this on the > "security-howto" page. I think it is worth mentioning that the .gz versions will be directly accessible and need to be protected if the normal version is protected. > Technical issues with the code: > 1) "If-Modified-Since" header processing is inconsistent, Fixed. > 2) I think that if it is an "included" resource, the gzip feature > should be disabled. Fixed. > 3) The following line: >> + gzipResource.setMimeType(contentType); > > I think that line is not needed here, as the "Content-Type" header is > served from a local variable, not property of the resource. Fixed. Thanks for the review, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1531698 - /tomcat/trunk/webapps/docs/default-servlet.xml
Author: markt Date: Sun Oct 13 15:11:53 2013 New Revision: 1531698 URL: http://svn.apache.org/r1531698 Log: Note requirements for securing the gzipped version of a file. Modified: tomcat/trunk/webapps/docs/default-servlet.xml Modified: tomcat/trunk/webapps/docs/default-servlet.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/default-servlet.xml?rev=1531698&r1=1531697&r2=1531698&view=diff == --- tomcat/trunk/webapps/docs/default-servlet.xml (original) +++ tomcat/trunk/webapps/docs/default-servlet.xml Sun Oct 13 15:11:53 2013 @@ -99,6 +99,10 @@ directory listings are disabled and debu appended to the file name located alongside the original file), Tomcat will serve the gzipped file if the user agent supports gzip and this option is enabled. [true] + +The file with the .gz extension will be accessible if +requested directly so if the original resource is protected with a +security constraint, the gzipped version must be similarly protected. If a directory listing is presented, a readme file may also - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1531680 - /tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/web.xml
On 13/10/2013 15:33, Konstantin Preißer wrote: > Mark, > >> -Original Message- >> From: Mark Thomas [mailto:ma...@apache.org] >> Sent: Sunday, October 13, 2013 3:58 PM >> To: Tomcat Developers List >> Subject: Re: svn commit: r1531680 - >> /tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/web.xml >> >> On 13/10/2013 13:30, kpreis...@apache.org wrote: >>> Author: kpreisser >>> Date: Sun Oct 13 12:30:56 2013 >>> New Revision: 1531680 >>> >>> URL: http://svn.apache.org/r1531680 >>> Log: >>> Allow the JSR 356 WebSocket examples using the programmatic API >> (Endpoint subclasses) to work as they use a ServletContextListener that has >> @WebListener annotation, which would not be called with metadata- >> complete="true". >> >> That appears to have triggered a number of CI failures. > > OK, can you give me a hint why buildbot fails? The SCI doesn't run when using the Tomcat class which is used by the unit tests. The unit tests that need WebSocket support explicitly enable it. Annotations are processed so changing metadata-complete means the listener is fired in a number of places where WebSocket is not available. The examples should not require metadata-complete="false" Mark > > When I look at the stdio logs for compile_1 [1], I can see NPEs in the > examples-WsConfigListener that did not happen previously (but they happen > also in trunk). I do also get these NPEs when I debug Tomcat in Eclipse as it > seems the Servlet Context did not have the > "javax.websocket.server.ServerContainer" attribute. I solved this by adding > new WsContextListener().contextInitialized(sce); > at the beginning of contextInitialized() method in the WsConfigListener. > > But I don't know if the failures have something to do with it. > (When I build Tomcat7 locally with WebSocket support and run it, then I do > not get such exceptions.) > > > Regards, > Konstantin Preißer > > [1] > http://ci.apache.org/builders/tomcat-7-trunk/builds/1469/steps/compile_1/logs/stdio > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: svn commit: r1531680 - /tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/web.xml
Mark, > -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Sunday, October 13, 2013 5:17 PM > To: Tomcat Developers List > Subject: Re: svn commit: r1531680 - > /tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/web.xml > > OK, can you give me a hint why buildbot fails? > > The SCI doesn't run when using the Tomcat class which is used by the > unit tests. The unit tests that need WebSocket support explicitly enable it. > > Annotations are processed so changing metadata-complete means the > listener is fired in a number of places where WebSocket is not available. > > The examples should not require metadata-complete="false" OK, thank you. The reason I changed the metadata-complete to "false" is that otherwise with Tomcat 7, the "EchoEndpoint" and "DrawboardEndpoint" would not be deployed so these examples would not work. In Tomcat 8 the examples Webapp has metadata-complete="false" so I thought it would be as simple to make the same change in Tomcat7's example web.xml. I guess when setting metadata-complete="true", one would have to add the two WsConfigListeners to the web.xml, but I guess that would not fix the failures. > Implementing a ServerEndpointConfig and letting the SCI deploy it would > be an alternative option. I'm sorry as I do not have enough knowledge of the various servlet specs to fix this correctly - are you able to do it? Thanks! Regards, Konstantin Preißer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: svn commit: r1531680 - /tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/web.xml
> -Original Message- > From: Konstantin Preißer [mailto:kpreis...@apache.org] > Sent: Sunday, October 13, 2013 5:27 PM > To: 'Tomcat Developers List' > Subject: RE: svn commit: r1531680 - > /tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/web.xml > > Mark, > > The reason I changed the metadata-complete to "false" is that otherwise > with Tomcat 7, the "EchoEndpoint" and "DrawboardEndpoint" would not be > deployed so these examples would not work. In Tomcat 8 the examples > Webapp has metadata-complete="false" so I thought it would be as simple > to make the same change in Tomcat7's example web.xml. > I guess when setting metadata-complete="true", one would have to add the > two WsConfigListeners to the web.xml, but I guess that would not fix the > failures. > > > Implementing a ServerEndpointConfig and letting the SCI deploy it would > > be an alternative option. > > I'm sorry as I do not have enough knowledge of the various servlet specs to > fix this correctly - are you able to do it? I see now that the examples webapp will fail to start if runnint Tomcat 7 with Java6 and having metadata-complete="false" in the example's web.xml. Is it OK to add a null check in the example WsConfigListeners to prevent the errors when websocket is not available? Thanks, Konstantin Preißer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [Tomcat 8.0.x trunk] APR sendfile problem
Mark, On 13.10.2013 11:42, Mark Thomas wrote: Fixed. Thanks again for the pointers. Thanks, it works as exptected: 1. useSendfile="true", issues a warning, and disables sendfile. 2. useSednfile="false" or omitting attribute useSendfile, disables sendfile. -Ognjen - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1531713 - /tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/web.xml
Author: kpreisser Date: Sun Oct 13 16:57:42 2013 New Revision: 1531713 URL: http://svn.apache.org/r1531713 Log: Revert r1531680 to prevent CI failures and to prevent the Examples webapp from failing to start when running Tomcat 7 with Java 6. Modified: tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/web.xml Modified: tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/web.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/web.xml?rev=1531713&r1=1531712&r2=1531713&view=diff == --- tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/web.xml (original) +++ tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/web.xml Sun Oct 13 16:57:42 2013 @@ -20,7 +20,7 @@ xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd"; version="3.0" - metadata-complete="false"> + metadata-complete="true"> Servlet and JSP Examples. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot success in ASF Buildbot on tomcat-7-trunk
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1470 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1531713 Blamelist: kpreisser Build succeeded! sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org