[Bug 59703] RFC 6265 Cookie Processor doesn't allow cookie domains with a leading dot.

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59703

--- Comment #2 from Huxing Zhang  ---
We ran into the same issue in 8.5.x, as a result, we've chosen to use
org.apache.tomcat.util.http.LegacyCookieProcessor instead for compatibility.


As there is another one commenting on this issue (see bottom of [1]), is it
worth mentioning it in the documentation?

[1] https://tomcat.apache.org/tomcat-8.0-doc/config/cookie-processor.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.5.14

[Huxing Zhang]

The proposed 8.5.14 release is:
[ ] Broken - do not release
[ X ] Stable - go ahead and release as 8.5.14

Test case: ok
Our test web application works fine

--
From:Mark Thomas 
Time:2017 Apr 13 (Thu) 21:13
To:Tomcat Developers List 
Subject:[VOTE] Release Apache Tomcat 8.5.14


The proposed Apache Tomcat 8.5.14 release is now available for voting.

The major changes compared to the 8.5.13 release are:

- Correct a regression that broke JMX operations (including the Manager
  web application) if the operation took parameters

- Add JMX support for Tribes components

- Calls to isReady() no longer throw exceptions after timeouts for async
  servlets


It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.14/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1132/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_14/

The proposed 8.5.14 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 8.5.14

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60963] Optimize class loading for unpackWARs=false case

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60963

--- Comment #6 from Thomas Meyer  ---
Regarding ZipInputStreamWithPosition:
I think you found the ugly part of this patch. I guess your suggestion wouldn't
work, because ZipInputStream will construct itself with a new
PushBackInputstream and the provided input stream as decorated object. Passing
the input stream as you suggest would result in a PushBackInputStream with an
PushBackInputStreamWithPosition as decorated object, which is wrong for our
intention here.
By setting the decorated object after the super constructor has finished we
replace the PushbsckInputStream with our implementation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60963] Optimize class loading for unpackWARs=false case

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60963

--- Comment #5 from Thomas Meyer  ---
Regarding file locking issue: I didn't check this. I'll try to test this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.0.M20

[Martin Grigorov]

On Wed, Apr 12, 2017 at 10:11 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.0.M20 release is now available for voting.
>
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
> The major changes compared to the 9.0.0.M19 release are:
>
> - Correct a regression that broke JMX operations (including the Manager
>   web application) if the operation took parameters
>
> - Add JMX support for Tribes components
>
> - Calls to isReady() no longer throw exceptions after timeouts for async
>   servlets
>
>
> Along with lots of other bug fixes and improvements
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M20/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1131/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M20/
>
> The proposed 9.0.0.M20 release is:
> [ ] Broken - do not release
> [ X ] Alpha - go ahead and release as 9.0.0.M20
>

Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 8.5.14

[Martin Grigorov]

On Thu, Apr 13, 2017 at 3:12 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.14 release is now available for voting.
>
> The major changes compared to the 8.5.13 release are:
>
> - Correct a regression that broke JMX operations (including the Manager
>   web application) if the operation took parameters
>
> - Add JMX support for Tribes components
>
> - Calls to isReady() no longer throw exceptions after timeouts for async
>   servlets
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.14/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1132/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_14/
>
> The proposed 8.5.14 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 8.5.14
>

Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 9.0.0.M20

[Huxing Zhang]

Hi,

The proposed 9.0.0.M20 release is:
[ ] Broken - do not release
[ X ] Alpha - go ahead and release as 9.0.0.M20

Test cases: ok.
Our test web app works fine.

--
From:Mark Thomas 
Time:2017 Apr 13 (Thu) 04:20
To:Tomcat Developers List 
Subject:[VOTE] Release Apache Tomcat 9.0.0.M20


The proposed Apache Tomcat 9.0.0.M20 release is now available for voting.

This is a milestone release for the 9.0.x branch. It should be
noted that, as a milestone release:
- Servlet 4.0 is not finalised
- The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0

The major changes compared to the 9.0.0.M19 release are:

- Correct a regression that broke JMX operations (including the Manager
  web application) if the operation took parameters

- Add JMX support for Tribes components

- Calls to isReady() no longer throw exceptions after timeouts for async
  servlets


Along with lots of other bug fixes and improvements

For full details, see the changelog:
http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M20/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1131/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M20/

The proposed 9.0.0.M20 release is:
[ ] Broken - do not release
[ ] Alpha - go ahead and release as 9.0.0.M20

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60769] Problem with Jsp character encoding configuration

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60769

--- Comment #8 from Lazar  ---
Created attachment 34914
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34914=edit
Correct war for reproducing the exotic encoding problem

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60769] Problem with Jsp character encoding configuration

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60769

Lazar  changed:

   What|Removed |Added

  Attachment #34913|0   |1
is obsolete||

--- Comment #7 from Lazar  ---
Comment on attachment 34913
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34913
Sample war with jspx in exotic encoding

Invalid jspx file within.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1791325 - in /tomcat/trunk: java/org/apache/catalina/tribes/transport/ReceiverBase.java java/org/apache/catalina/tribes/transport/nio/NioReceiverMBean.java webapps/docs/changelog.xml

[kfujino]

Author: kfujino
Date: Fri Apr 14 08:17:17 2017
New Revision: 1791325

URL: http://svn.apache.org/viewvc?rev=1791325=rev
Log:
Add features to get the statistics of the thread pool of the Receiver component.
These statistics information can be acquired via JMX.

Modified:
tomcat/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java

tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/NioReceiverMBean.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java?rev=1791325=1791324=1791325=diff
==
--- tomcat/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java 
Fri Apr 14 08:17:17 2017
@@ -23,6 +23,7 @@ import java.net.InetSocketAddress;
 import java.net.ServerSocket;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.ThreadFactory;
+import java.util.concurrent.ThreadPoolExecutor;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicInteger;
 
@@ -516,6 +517,55 @@ public abstract class ReceiverBase imple
 this.channel = channel;
 }
 
+// -- stats of the thread pool
+/**
+ * Return the current number of threads that are managed by the pool.
+ * @return the current number of threads that are managed by the pool
+ */
+public int getPoolSize() {
+if (executor instanceof ThreadPoolExecutor) {
+return ((ThreadPoolExecutor) executor).getPoolSize();
+} else {
+return -1;
+}
+}
+
+/**
+ * Return the current number of threads that are in use.
+ * @return the current number of threads that are in use
+ */
+public int getActiveCount() {
+if (executor instanceof ThreadPoolExecutor) {
+return ((ThreadPoolExecutor) executor).getActiveCount();
+} else {
+return -1;
+}
+}
+
+/**
+ * Return the total number of tasks that have ever been scheduled for 
execution by the pool.
+ * @return the total number of tasks that have ever been scheduled for 
execution by the pool
+ */
+public long getTaskCount() {
+if (executor instanceof ThreadPoolExecutor) {
+return ((ThreadPoolExecutor) executor).getTaskCount();
+} else {
+return -1;
+}
+}
+
+/**
+ * Return the total number of tasks that have completed execution by the 
pool.
+ * @return the total number of tasks that have completed execution by the 
pool
+ */
+public long getCompletedTaskCount() {
+if (executor instanceof ThreadPoolExecutor) {
+return ((ThreadPoolExecutor) executor).getCompletedTaskCount();
+} else {
+return -1;
+}
+}
+
 // -- ThreadFactory Inner Class
 class TaskThreadFactory implements ThreadFactory {
 final ThreadGroup group;

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/NioReceiverMBean.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/NioReceiverMBean.java?rev=1791325=1791324=1791325=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/NioReceiverMBean.java
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/NioReceiverMBean.java
 Fri Apr 14 08:17:17 2017
@@ -64,4 +64,14 @@ public interface NioReceiverMBean {
 public boolean getUseBufferPool();
 
 public boolean isListening();
+
+// pool stats
+public int getPoolSize();
+
+public int getActiveCount();
+
+public long getTaskCount();
+
+public long getCompletedTaskCount();
+
 }

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1791325=1791324=1791325=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Fri Apr 14 08:17:17 2017
@@ -54,6 +54,15 @@
   
 
   
+  
+
+  
+Add features to get the statistics of the thread pool of the
+Receiver component. These statistics information can be
+acquired via JMX. (kfujino)
+  
+
+  
 
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60769] Problem with Jsp character encoding configuration

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60769

--- Comment #6 from Lazar  ---
Created attachment 34913
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34913=edit
Sample war with jspx in exotic encoding

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60769] Problem with Jsp character encoding configuration

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60769

--- Comment #5 from Lazar  ---
The content of the enctest.jspx is:



http://java.sun.com/JSP/Page;>
 
 
 
 You should see this text.
 


So actually there is an encoding attribute in the prolog. For some reason JRE
XML parser does not detect it correctly. On the other hand, the deprecated
XMLEncodingDetector from before the refactoring, which parsed the files itself,
correctly detects the encoding from the prolog - for example, with Tomcat 8.5.4
the sample works correctly.

I apologise for that my second attachment is an incorrect one - I noticed that
by mistake I have attached the second war from the first attachment instead of
the problematic war with IBM871 encoding. I attach now the correct one with
name encsample.war

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.5.14

[Mark Thomas]

On 14/04/2017 07:43, Keiichi Fujino wrote:
> 2017-04-13 22:12 GMT+09:00 Mark Thomas :
> 
>> The proposed Apache Tomcat 8.5.14 release is now available for voting.
>>
>> The major changes compared to the 8.5.13 release are:
>>
>> - Correct a regression that broke JMX operations (including the Manager
>>   web application) if the operation took parameters
>>
>> - Add JMX support for Tribes components
>>
>>
> This has not back-ported into Tomcat8.5 yet.

Sorry. Non-thinking copy/paste on my part. I'll make sure I don't
include that in the release announcement.

Mark


> 
> 
>> - Calls to isReady() no longer throw exceptions after timeouts for async
>>   servlets
>>
>>
>> It can be obtained from:
>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.14/
>> The Maven staging repo is:
>> https://repository.apache.org/content/repositories/orgapachetomcat-1132/
>> The svn tag is:
>> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_14/
>>
>> The proposed 8.5.14 release is:
>> [ ] Broken - do not release
>> [X] Stable - go ahead and release as 8.5.14
>>
>>
> +1
> Tested on my handmade app.(use BackupManager).
> 
> 
> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>> --
>> Keiichi.Fujino
>> 
> 
> 
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.5.14

[Keiichi Fujino]

2017-04-13 22:12 GMT+09:00 Mark Thomas :

> The proposed Apache Tomcat 8.5.14 release is now available for voting.
>
> The major changes compared to the 8.5.13 release are:
>
> - Correct a regression that broke JMX operations (including the Manager
>   web application) if the operation took parameters
>
> - Add JMX support for Tribes components
>
>
This has not back-ported into Tomcat8.5 yet.


> - Calls to isReady() no longer throw exceptions after timeouts for async
>   servlets
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.14/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1132/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_14/
>
> The proposed 8.5.14 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.14
>
>
+1
Tested on my handmade app.(use BackupManager).



> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
> --
> Keiichi.Fujino
> 

Re: [VOTE] Release Apache Tomcat 9.0.0.M20

[Keiichi Fujino]

2017-04-13 5:11 GMT+09:00 Mark Thomas :

> The proposed Apache Tomcat 9.0.0.M20 release is now available for voting.
>
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
> The major changes compared to the 9.0.0.M19 release are:
>
> - Correct a regression that broke JMX operations (including the Manager
>   web application) if the operation took parameters
>
> - Add JMX support for Tribes components
>
> - Calls to isReady() no longer throw exceptions after timeouts for async
>   servlets
>
>
> Along with lots of other bug fixes and improvements
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M20/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1131/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M20/
>
> The proposed 9.0.0.M20 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 9.0.0.M20
>
>
+1
Tested on my handmade app.(use BackupManager).



> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
> --
> Keiichi.Fujino
>