[GitHub] tomcat issue #68: Fix #61224 - Make the GlobalRequestProcessor mbeans read-o...

[hasalex]

Github user hasalex commented on the issue:

https://github.com/apache/tomcat/pull/68
  
Thanks for fixing (and merging) the PR
It worked on my machine ;) I'll have to learn more on the build process.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1800009 - in /tomcat/trunk: java/org/apache/coyote/http11/filters/ChunkedOutputFilter.java webapps/docs/changelog.xml

[huxing]

Author: huxing
Date: Tue Jun 27 03:23:59 2017
New Revision: 189

URL: http://svn.apache.org/viewvc?rev=189=rev
Log:
Ensure to send a space between trailer field name and field value for HTTP 
responses trailer fields

Modified:
tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedOutputFilter.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedOutputFilter.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedOutputFilter.java?rev=189=188=189=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedOutputFilter.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedOutputFilter.java 
Tue Jun 27 03:23:59 2017
@@ -191,6 +191,7 @@ public class ChunkedOutputFilter impleme
 }
 osw.write(trailerField.getKey());
 osw.write(':');
+osw.write(' ');
 osw.write(trailerField.getValue());
 osw.write("\r\n");
 }

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=189=188=189=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Tue Jun 27 03:23:59 2017
@@ -197,6 +197,10 @@
 variable for CGI executables is populated in a consistent way 
regardless
 of how the CGI servlet is mapped to a request. (markt)
   
+  
+Ensure to send a space between trailer field name and field value
+for HTTP responses trailer fields. (huxing)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] 8.0.x EOL - 30 June 2018

[Huxing Zhang]

Hi,

The main reason is RFC6265 is released after IE9, and IE9 is still in our 
supported browser list (though not recommended). 
I'm personally fine with using LegacyCookieProcessor instead of 
RFC6265CookieProcessor for LEGACY issues.
However, it is not easy for an embedded Tomcat in an Spring-boot application to 
switch RFC6265CookieProcessor to LegacyCookieProcessor, unless we change the 
Spring-boot code.
I am thinking of adding an system property, e.g. 
"org.apache.tomcat.util.http.CookieProcessor", to make the process easier.

--
From:Mark Thomas 
Time:2017 Jun 26 (Mon) 17:55
To:Tomcat Developers List 
Subject:Re: [VOTE] 8.0.x EOL - 30 June 2018


On 26/06/17 03:19, Huxing Zhang wrote:
>> The only thing I can think of is lack of support for the BIO connectors.
>> I have an easy fix for that if there is interest. Anything else?
> 
> Also the RFC6265CookieProcessor.  We've experienced several incompatibility 
> with LegacyCookieProcessor.
> For example,  cookies with leading dot is no longer valid in 
> RFC6265CookieProcessor.

Since RFC6265 is clear that the leading '.' should not be there, I'm
reluctant to introduce a change to allow it. Unsurprisingly, it is IE
that needs the leading '.' in some cases.

We have made exceptions for IE in the past. Do we want to do that here?
LegacyCookieProcessor remains an option for those that need to support
this particular quirk of IE.

Personally, I'd prefer not to introduce a new option but I could be
persuaded to support such a change if there was sufficient demand.

Mark


> --
> From:Mark Thomas 
> Time:2017 Jun 24 (Sat) 23:26
> To:Tomcat Developers List 
> Subject:Re: [VOTE] 8.0.x EOL - 30 June 2018
> 
> 
> On 23/06/17 23:17, Emmanuel Bourg wrote:
>> Le 23/06/2017 à 21:15, Christopher Schultz a écrit :
>>
>>> The idea was to encourage package repository maintainers to migrate to
>>> Tomcat 8.5. If we never sundown Tomcat 8.0, they'll never move (witness
>>> the presence of Tomcat 6.0 still lurking around half the Internet).
>>
>> As far as Debian is concerned, the migration to Tomcat 8.5 did happen in
>> Debian 9. But Debian 8 users are stuck with Tomcat 8.0.x until June
>> 2020. Tomcat 8.5 isn't a drop-in replacement for Tomcat 8.0
>> unfortunately, so it's a bit difficult to push this upgrade in a stable
>> distribution.
> 
> If 8.5.x was a drop-in replacement would that make a difference?
> 
> And as a follow-up, what would need to change so 8.5.x was viewed a
> drop-in replacement?
> 
> The only thing I can think of is lack of support for the BIO connectors.
> I have an easy fix for that if there is interest. Anything else?
> 
> Mark
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.79

[Rainer Jung]

Am 26.06.2017 um 19:22 schrieb Violeta Georgieva:

The proposed Apache Tomcat 7.0.79 release is now available for voting.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.79/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1139/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_79/

The proposed 7.0.79 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 7.0.79 Stable


+1 to release, thanks for RM.

Details:

- MD5 OK
- signatures OK
- key in KEYS file
- gz and zip for src and bin consistent
- src completely consistent with svn tag
- builds fine
   - warnings about unchecked calls or conversions in:
 - o.a.t.dbcp
 - javax/el/ResourceBundleELResolver.java
   Both not a regression
- build result looks consistent with binaries
- no checkstyle complaints
- no Javadoc warnings

- JMX MBean Comparison with 7.0.78:

  - Manager MBean attribute sessionAttributeValueClassNameFilter added
for webapp manager and host-manager with value
java\.lang\.(?:Boolean|Integer|Long|Number|String)|org\.apache\.catalina\.filters\.CsrfPreventionFilter\$LruCache(?:\$1)?|java\.util\.(?:Linked)?HashMap
This is due to BZ61150, r1798387

  - MBean java.util.logging:type=Logging has three items removed
from the LoggerNames array: org.apache.catalina.session,
org.apache.catalina.session.ManagerBase and
org.apache.catalina.session.StandardManager


- Unit tests: no errors or failures, below comparisons are against 
7.0.77 and 7.0.79


Numbers are given for 77 / 78 / 79.

  - Exceptions:

- 1 / 3 / 1
Exception in thread "testBug54928" java.lang.IllegalStateException: The 
request associated with the AsyncContext has already completed processing.


- Change from 2 times in 77:
Exception in thread "testBug54928" java.lang.IllegalStateException: 
Calling [asyncComplete()] is not valid for a request with Async state 
[MUST_COMPLETE]

  to nothing for 78 and once each for 79:
Exception in thread "testBug54928" java.lang.IllegalStateException: 
Calling [asyncComplete()] is not valid for a request with Async state 
[DISPATCHED]
Exception in thread "testBug54928" java.lang.IllegalStateException: 
Calling [asyncComplete()] is not valid for a request with Async state 
[MUST_ERROR]


- java.io.IOException

  - new in 79 (3 times)
java.security.cert.CertificateException: Unable to initialize, 
java.io.IOException: extra data given to DerValue constructor

java.security.NoSuchProviderException: no such provider: wontBeFound
Caused by: java.io.IOException: extra data given to DerValue constructor

  - 4 / 5 / 5
java.io.IOException: java.util.concurrent.ExecutionException: 
java.io.IOException: Unexpected error [NUMBER] writing data to the 
APR/native socket [NUMBER] with wrapper 
[org.apache.tomcat.util.net.AprEndpoint$AprSocketWrapper@HEX:NUM].
Caused by: java.io.IOException: Unexpected error [NUMBER] writing data 
to the APR/native socket [NUMBER] with wrapper 
[org.apache.tomcat.util.net.AprEndpoint$AprSocketWrapper@HEX:NUM].
Caused by: java.util.concurrent.ExecutionException: java.io.IOException: 
Unexpected error [NUMBER] writing data to the APR/native socket [NUMBER] 
with wrapper 
[org.apache.tomcat.util.net.AprEndpoint$AprSocketWrapper@HEX:NUM].


- 5 / 4 / 6
java.io.IOException: java.util.concurrent.ExecutionException: 
java.io.IOException: Broken pipe

Caused by: java.io.IOException: Broken pipe
Caused by: java.util.concurrent.ExecutionException: java.io.IOException: 
Broken pipe


- 1 / 0 / 1
java.io.EOFException

- new in 79 (once)
java.io.EOFException: The client aborted the connection.

- 6 / 5 / 5
org.apache.catalina.tribes.transport.nio.NioReplicationTask.run 
IOException in replication worker, unable to drain channel. Probable 
cause: Keep alive socket closed[null].


- 7 / 6 / 6
org.apache.catalina.tribes.ChannelException: Sender not connected.; No 
faulty members identified.


- 4 / 2 / 3
org.apache.catalina.tribes.ChannelException: Operation has timed 
out(3000 ms.).; Faulty members:tcp://{IP}:PORT;


- 1 / 0 / 3
org.apache.catalina.tribes.ChannelException: java.net.ConnectException: 
Connection refused; Faulty members:tcp://{IP}:PORT;

Caused by: java.net.ConnectException: Connection refused


  - SEVERE messages

- new in 79 (3 times)
org.apache.catalina.valves.SSLValve.invoke The SSL provider specified on 
the connector associated with this request of [wontBeFound] is invalid. 
The certificate data could not be processed.


- 1 / 0 / 1
SEVERE: Servlet.service() for servlet [comet] in context with path [] 
threw exception


- 5 / 6 / 5
org.apache.catalina.core.StandardWrapperValve.event Servlet.service() 
for servlet [comet] in context with path [] threw exception


- 1 / 0 / 2
org.apache.tomcat.websocket.pojo.PojoEndpointBase.onError No error 
handling configured for 

buildbot success in on tomcat-8-trunk

[buildbot]

The Buildbot has detected a restored build on builder tomcat-8-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-8-trunk/builds/1050

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-8-commit' 
triggered this build
Build Source Stamp: [branch tomcat/tc8.0.x/trunk] 175
Blamelist: violetagg

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.0.45

[Rémy Maucherat]

On Mon, Jun 26, 2017 at 4:05 PM, Violeta Georgieva 
wrote:

> The proposed Apache Tomcat 8.0.45 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.45/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1140/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_45/
>
> The proposed 8.0.45 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.0.45
>

Rémy

svn commit: r1799995 - in /tomcat/tc8.0.x/trunk: build.properties.default res/maven/mvn.properties.default webapps/docs/changelog.xml

[violetagg]

Author: violetagg
Date: Mon Jun 26 21:10:48 2017
New Revision: 175

URL: http://svn.apache.org/viewvc?rev=175=rev
Log:
Increment version for next dev cycle

Modified:
tomcat/tc8.0.x/trunk/build.properties.default
tomcat/tc8.0.x/trunk/res/maven/mvn.properties.default
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc8.0.x/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/build.properties.default?rev=175=174=175=diff
==
--- tomcat/tc8.0.x/trunk/build.properties.default (original)
+++ tomcat/tc8.0.x/trunk/build.properties.default Mon Jun 26 21:10:48 2017
@@ -25,7 +25,7 @@
 # - Version Control Flags -
 version.major=8
 version.minor=0
-version.build=45
+version.build=46
 version.patch=0
 version.suffix=-dev
 

Modified: tomcat/tc8.0.x/trunk/res/maven/mvn.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/res/maven/mvn.properties.default?rev=175=174=175=diff
==
--- tomcat/tc8.0.x/trunk/res/maven/mvn.properties.default (original)
+++ tomcat/tc8.0.x/trunk/res/maven/mvn.properties.default Mon Jun 26 21:10:48 
2017
@@ -35,7 +35,7 @@ maven.asf.release.repo.url=https://repos
 maven.asf.release.repo.repositoryId=apache.releases
 
 # Release version info
-maven.asf.release.deploy.version=8.0.45
+maven.asf.release.deploy.version=8.0.46
 
 #Where do we load the libraries from
 tomcat.lib.path=../../output/build/lib

Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml?rev=175=174=175=diff
==
--- tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Mon Jun 26 21:10:48 2017
@@ -44,7 +44,9 @@
   They eventually become mixed with the numbered issues. (I.e., numbered
   issues do not "pop up" wrt. others).
 -->
-
+
+
+
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[VOTE] Release Apache Tomcat 8.0.45

[Violeta Georgieva]

The proposed Apache Tomcat 8.0.45 release is now available for voting.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.45/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1140/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_45/

The proposed 8.0.45 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 8.0.45

Regards,
Violeta

svn commit: r20200 [2/2] - in /dev/tomcat/tomcat-8/v8.0.45: ./ bin/ bin/embed/ bin/extras/ src/

[violetagg]

Added: dev/tomcat/tomcat-8/v8.0.45/bin/extras/catalina-ws.jar.asc
==
--- dev/tomcat/tomcat-8/v8.0.45/bin/extras/catalina-ws.jar.asc (added)
+++ dev/tomcat/tomcat-8/v8.0.45/bin/extras/catalina-ws.jar.asc Mon Jun 26 
20:58:58 2017
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v2
+
+iQIcBAABCgAGBQJZUWm7AAoJECCLCrHWMBHHLvEP/jgawbmO5ljRzhoGSJqsUGnB
+oH7w1FEEgfl8O4IkvRmu7sIJn7OjPxfBF1uMs+NhrSsfTRmq4CYHIwZ7igJ8AcNF
+YDZr8JykfkyAH6cx+hBYAfwLnk61xUlvRLBp/UILxXif94Y3HMGM/Z3XO5r7cwK1
+LkggyZRDzs43DEVJw/MRCn2uYmKPmhwIow0xW6wxO+4j9kkzmGqvQyYbhRarKkv1
+DWofViDjO0AXG6ACZVI/QqyRY0mZPbRbTEc9vA/gsgRYICznv74LFGfaupGZF6fE
+Vw6RDYlRIn+lO8VvFjceL0gbe8MUHghmPVdQPC57IwbnCuAwjnDgQyJq46AN+/UH
+qo8EA0Lt0pK+Vz44+Ooevuauu+QVmA1rCS+arQU6KPmtthwmgqYW/XwaNQlwZ+iY
+MkgT+zil1mpWLf5dRjyArmhweVANxmJIpY1yJo5PH9zvI97dUxgj1A0qSdfNG9/6
+Sn0FFUufP9BXkWflWxEfIufe53ybDtmdd8Y+EYWJBG/XbOoPkTw53+BJzKxGva5O
+szv0DVmYxM5TgwgitKu9HyT6QA7rs9RedOeYCmhMJIl1pdiycDKFMZjXzALrRouZ
+38eWNDTQo7XHF1LRVM16qKWiuvcAMxxT3E3K02WcIzafuB5Kc2AIEk/8D3MIlXz9
+V0g/tAkfzkzVkOMNfYlK
+=3ut8
+-END PGP SIGNATURE-

Added: dev/tomcat/tomcat-8/v8.0.45/bin/extras/catalina-ws.jar.md5
==
--- dev/tomcat/tomcat-8/v8.0.45/bin/extras/catalina-ws.jar.md5 (added)
+++ dev/tomcat/tomcat-8/v8.0.45/bin/extras/catalina-ws.jar.md5 Mon Jun 26 
20:58:58 2017
@@ -0,0 +1 @@
+85a82e7266d010156f741362101c1cff *catalina-ws.jar
\ No newline at end of file

Added: dev/tomcat/tomcat-8/v8.0.45/bin/extras/catalina-ws.jar.sha1
==
--- dev/tomcat/tomcat-8/v8.0.45/bin/extras/catalina-ws.jar.sha1 (added)
+++ dev/tomcat/tomcat-8/v8.0.45/bin/extras/catalina-ws.jar.sha1 Mon Jun 26 
20:58:58 2017
@@ -0,0 +1 @@
+d3224afa673a4b3bd3b6121b994fe9984b3691ef *catalina-ws.jar
\ No newline at end of file

Added: dev/tomcat/tomcat-8/v8.0.45/bin/extras/tomcat-juli-adapters.jar
==
Binary file - no diff available.

Propchange: dev/tomcat/tomcat-8/v8.0.45/bin/extras/tomcat-juli-adapters.jar
--
svn:mime-type = application/octet-stream

Added: dev/tomcat/tomcat-8/v8.0.45/bin/extras/tomcat-juli-adapters.jar.asc
==
--- dev/tomcat/tomcat-8/v8.0.45/bin/extras/tomcat-juli-adapters.jar.asc (added)
+++ dev/tomcat/tomcat-8/v8.0.45/bin/extras/tomcat-juli-adapters.jar.asc Mon Jun 
26 20:58:58 2017
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v2
+
+iQIcBAABCgAGBQJZUWm6AAoJECCLCrHWMBHHIZIP/0XJlxcEJM6gWbxuSBgSRjHl
+uMhcW6eNuwypf2ON+ff8neQJMRH//Dykfw7HAaESiugx4/OXf9u7TviuLFybdMiK
+cgUXJqB5wR5HXzq/BOZ5Y+I2FqHiVLrwwZV5l3IU0JgPlRkoGpVHSZCIOlzNa/aM
+8GLvbynIwziWts1E4fXTI78tsFVvIJyI6rBxLYbm4gDeRN/tz9tIZQXgtz2bKkQv
+tliNnrjwqMxPVZQtWYxI2wEVt4HfOVVr5d08yEcfhzxs3Lo3gqunJ8oCJ9gIOL/V
+i5Wo2PihIqZaxoHxj9mTxekQ+czvrrBocZpvFWJplZQUymr+3ABl9HPzKt8V3pYY
+aKUqn0Ddfrwtg0pDO1I1bJk1IhUrUPJW8P825C/FRHBNEvMj0JTeXzPjFgWNJ9pe
+z2RrRkxQNi1KN4SfkHlqAwx1X/X+PPtFTV9o+ZZba0VvlJUEVGymUHJSUJGNlr84
+JGWiiNq3s6VwaTmjqa1zUFNIuWWSODjzesKQS6WcWpwr3g8ZxqYU5LVCbswoS5y5
+JEJ00i8vAdIAvcxEUE3vcn6kEwh4a8Ic1iWOG6GJnGW+bVQZ6PSVjoiSjn+1RcnD
+Fti7aFzIRGCSA9zrNcR+rhFYK8rj+vcsuTXNHMDx9crkFCdBPnnyN0PtQnOYvKiX
++m1BkvTfC12YV27x+yNA
+=biQf
+-END PGP SIGNATURE-

Added: dev/tomcat/tomcat-8/v8.0.45/bin/extras/tomcat-juli-adapters.jar.md5
==
--- dev/tomcat/tomcat-8/v8.0.45/bin/extras/tomcat-juli-adapters.jar.md5 (added)
+++ dev/tomcat/tomcat-8/v8.0.45/bin/extras/tomcat-juli-adapters.jar.md5 Mon Jun 
26 20:58:58 2017
@@ -0,0 +1 @@
+d5d078603311920e5d92331594d072c3 *tomcat-juli-adapters.jar
\ No newline at end of file

Added: dev/tomcat/tomcat-8/v8.0.45/bin/extras/tomcat-juli-adapters.jar.sha1
==
--- dev/tomcat/tomcat-8/v8.0.45/bin/extras/tomcat-juli-adapters.jar.sha1 (added)
+++ dev/tomcat/tomcat-8/v8.0.45/bin/extras/tomcat-juli-adapters.jar.sha1 Mon 
Jun 26 20:58:58 2017
@@ -0,0 +1 @@
+6b21ce6683212098b532c542a5a4520f84881988 *tomcat-juli-adapters.jar
\ No newline at end of file

Added: dev/tomcat/tomcat-8/v8.0.45/bin/extras/tomcat-juli.jar
==
Binary file - no diff available.

Propchange: dev/tomcat/tomcat-8/v8.0.45/bin/extras/tomcat-juli.jar
--
svn:mime-type = application/octet-stream

Added: dev/tomcat/tomcat-8/v8.0.45/bin/extras/tomcat-juli.jar.asc
==
--- dev/tomcat/tomcat-8/v8.0.45/bin/extras/tomcat-juli.jar.asc 

svn commit: r20200 [1/2] - in /dev/tomcat/tomcat-8/v8.0.45: ./ bin/ bin/embed/ bin/extras/ src/

[violetagg]

Author: violetagg
Date: Mon Jun 26 20:58:58 2017
New Revision: 20200

Log:
Stage 8.0.45 RC

Added:
dev/tomcat/tomcat-8/v8.0.45/
dev/tomcat/tomcat-8/v8.0.45/KEYS
dev/tomcat/tomcat-8/v8.0.45/README.html
dev/tomcat/tomcat-8/v8.0.45/RELEASE-NOTES
dev/tomcat/tomcat-8/v8.0.45/bin/
dev/tomcat/tomcat-8/v8.0.45/bin/README.html
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45-deployer.tar.gz   
(with props)
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45-deployer.tar.gz.asc
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45-deployer.tar.gz.md5
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45-deployer.tar.gz.sha1
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45-deployer.zip   (with 
props)
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45-deployer.zip.asc
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45-deployer.zip.md5
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45-deployer.zip.sha1
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45-fulldocs.tar.gz   
(with props)
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45-fulldocs.tar.gz.asc
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45-fulldocs.tar.gz.md5
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45-fulldocs.tar.gz.sha1
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45-windows-x64.zip   
(with props)
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45-windows-x64.zip.asc
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45-windows-x64.zip.md5
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45-windows-x64.zip.sha1
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45-windows-x86.zip   
(with props)
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45-windows-x86.zip.asc
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45-windows-x86.zip.md5
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45-windows-x86.zip.sha1
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45.exe   (with props)
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45.exe.asc
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45.exe.md5
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45.exe.sha1
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45.tar.gz   (with props)
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45.tar.gz.asc
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45.tar.gz.md5
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45.tar.gz.sha1
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45.zip   (with props)
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45.zip.asc
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45.zip.md5
dev/tomcat/tomcat-8/v8.0.45/bin/apache-tomcat-8.0.45.zip.sha1
dev/tomcat/tomcat-8/v8.0.45/bin/embed/
dev/tomcat/tomcat-8/v8.0.45/bin/embed/apache-tomcat-8.0.45-embed.tar.gz   
(with props)
dev/tomcat/tomcat-8/v8.0.45/bin/embed/apache-tomcat-8.0.45-embed.tar.gz.asc
dev/tomcat/tomcat-8/v8.0.45/bin/embed/apache-tomcat-8.0.45-embed.tar.gz.md5
dev/tomcat/tomcat-8/v8.0.45/bin/embed/apache-tomcat-8.0.45-embed.tar.gz.sha1
dev/tomcat/tomcat-8/v8.0.45/bin/embed/apache-tomcat-8.0.45-embed.zip   
(with props)
dev/tomcat/tomcat-8/v8.0.45/bin/embed/apache-tomcat-8.0.45-embed.zip.asc
dev/tomcat/tomcat-8/v8.0.45/bin/embed/apache-tomcat-8.0.45-embed.zip.md5
dev/tomcat/tomcat-8/v8.0.45/bin/embed/apache-tomcat-8.0.45-embed.zip.sha1
dev/tomcat/tomcat-8/v8.0.45/bin/extras/
dev/tomcat/tomcat-8/v8.0.45/bin/extras/catalina-jmx-remote.jar   (with 
props)
dev/tomcat/tomcat-8/v8.0.45/bin/extras/catalina-jmx-remote.jar.asc
dev/tomcat/tomcat-8/v8.0.45/bin/extras/catalina-jmx-remote.jar.md5
dev/tomcat/tomcat-8/v8.0.45/bin/extras/catalina-jmx-remote.jar.sha1
dev/tomcat/tomcat-8/v8.0.45/bin/extras/catalina-ws.jar   (with props)
dev/tomcat/tomcat-8/v8.0.45/bin/extras/catalina-ws.jar.asc
dev/tomcat/tomcat-8/v8.0.45/bin/extras/catalina-ws.jar.md5
dev/tomcat/tomcat-8/v8.0.45/bin/extras/catalina-ws.jar.sha1
dev/tomcat/tomcat-8/v8.0.45/bin/extras/tomcat-juli-adapters.jar   (with 
props)
dev/tomcat/tomcat-8/v8.0.45/bin/extras/tomcat-juli-adapters.jar.asc
dev/tomcat/tomcat-8/v8.0.45/bin/extras/tomcat-juli-adapters.jar.md5
dev/tomcat/tomcat-8/v8.0.45/bin/extras/tomcat-juli-adapters.jar.sha1
dev/tomcat/tomcat-8/v8.0.45/bin/extras/tomcat-juli.jar   (with props)
dev/tomcat/tomcat-8/v8.0.45/bin/extras/tomcat-juli.jar.asc
dev/tomcat/tomcat-8/v8.0.45/bin/extras/tomcat-juli.jar.md5
dev/tomcat/tomcat-8/v8.0.45/bin/extras/tomcat-juli.jar.sha1
dev/tomcat/tomcat-8/v8.0.45/src/
dev/tomcat/tomcat-8/v8.0.45/src/apache-tomcat-8.0.45-src.tar.gz   (with 
props)
dev/tomcat/tomcat-8/v8.0.45/src/apache-tomcat-8.0.45-src.tar.gz.asc
dev/tomcat/tomcat-8/v8.0.45/src/apache-tomcat-8.0.45-src.tar.gz.md5
dev/tomcat/tomcat-8/v8.0.45/src/apache-tomcat-8.0.45-src.tar.gz.sha1

[Bug 61224] GlobalRequestProcessor mbeans should be read-only

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61224

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #2 from Mark Thomas  ---
Thanks for the PR. I modified it slightly to take account of some refactoring I
did triggered by reviewing the PR and to ensure that it compiled cleanly with
checkstyle enabled.

Since this arguably changes a user API, I'm only applying this to trunk. Users
should not be calling the removed setters but you never know.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat pull request #68: Fix #61224 - Make the GlobalRequestProcessor mbeans...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/tomcat/pull/68


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1799986 - in /tomcat/trunk: java/org/apache/coyote/RequestGroupInfo.java java/org/apache/coyote/mbeans-descriptors.xml webapps/docs/changelog.xml

[markt]

Author: markt
Date: Mon Jun 26 20:39:16 2017
New Revision: 1799986

URL: http://svn.apache.org/viewvc?rev=1799986=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61224
Make the GlobalRequestProcessor MBean attributes read-only.
Patch provided by Alexis Hassler.
This closes #68

Added:
tomcat/trunk/java/org/apache/coyote/mbeans-descriptors.xml   (with props)
Modified:
tomcat/trunk/java/org/apache/coyote/RequestGroupInfo.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/coyote/RequestGroupInfo.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/RequestGroupInfo.java?rev=1799986=1799985=1799986=diff
==
--- tomcat/trunk/java/org/apache/coyote/RequestGroupInfo.java (original)
+++ tomcat/trunk/java/org/apache/coyote/RequestGroupInfo.java Mon Jun 26 
20:39:16 2017
@@ -19,11 +19,13 @@ package org.apache.coyote;
 import java.util.ArrayList;
 import java.util.List;
 
+import org.apache.tomcat.util.modeler.BaseModelMBean;
+
 /** This can be moved to top level ( eventually with a better name ).
  *  It is currently used only as a JMX artifact, to aggregate the data
  *  collected from each RequestProcessor thread.
  */
-public class RequestGroupInfo {
+public class RequestGroupInfo extends BaseModelMBean {
 private final List processors = new ArrayList<>();
 private long deadMaxTime = 0;
 private long deadProcessingTime = 0;

Added: tomcat/trunk/java/org/apache/coyote/mbeans-descriptors.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/mbeans-descriptors.xml?rev=1799986=auto
==
--- tomcat/trunk/java/org/apache/coyote/mbeans-descriptors.xml (added)
+++ tomcat/trunk/java/org/apache/coyote/mbeans-descriptors.xml Mon Jun 26 
20:39:16 2017
@@ -0,0 +1,59 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file

Propchange: tomcat/trunk/java/org/apache/coyote/mbeans-descriptors.xml
--
svn:eol-style = native

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1799986=1799985=1799986=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Mon Jun 26 20:39:16 2017
@@ -90,6 +90,10 @@
   
 60461: Sync SSL session access for the APR connector. (remm)
   
+  
+61224: Make the GlobalRequestProcessor MBean
+attributes read-only. Patch provided by Alexis Hassler. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1799981 - in /tomcat/trunk/java/org/apache: catalina/mbeans/ tomcat/util/modeler/

[markt]

Author: markt
Date: Mon Jun 26 20:27:09 2017
New Revision: 1799981

URL: http://svn.apache.org/viewvc?rev=1799981=rev
Log:
Refactor - remove unnecessary code

Modified:
tomcat/trunk/java/org/apache/catalina/mbeans/BaseCatalinaMBean.java
tomcat/trunk/java/org/apache/catalina/mbeans/ClassNameMBean.java
tomcat/trunk/java/org/apache/catalina/mbeans/ConnectorMBean.java
tomcat/trunk/java/org/apache/catalina/mbeans/ContainerMBean.java
tomcat/trunk/java/org/apache/catalina/mbeans/ContextEnvironmentMBean.java
tomcat/trunk/java/org/apache/catalina/mbeans/ContextMBean.java
tomcat/trunk/java/org/apache/catalina/mbeans/ContextResourceLinkMBean.java
tomcat/trunk/java/org/apache/catalina/mbeans/ContextResourceMBean.java
tomcat/trunk/java/org/apache/catalina/mbeans/GroupMBean.java
tomcat/trunk/java/org/apache/catalina/mbeans/MemoryUserDatabaseMBean.java
tomcat/trunk/java/org/apache/catalina/mbeans/NamingResourcesMBean.java
tomcat/trunk/java/org/apache/catalina/mbeans/RoleMBean.java
tomcat/trunk/java/org/apache/catalina/mbeans/ServiceMBean.java
tomcat/trunk/java/org/apache/catalina/mbeans/UserMBean.java
tomcat/trunk/java/org/apache/tomcat/util/modeler/BaseModelMBean.java

Modified: tomcat/trunk/java/org/apache/catalina/mbeans/BaseCatalinaMBean.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/mbeans/BaseCatalinaMBean.java?rev=1799981=1799980=1799981=diff
==
--- tomcat/trunk/java/org/apache/catalina/mbeans/BaseCatalinaMBean.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/mbeans/BaseCatalinaMBean.java Mon Jun 
26 20:27:09 2017
@@ -25,11 +25,6 @@ import org.apache.tomcat.util.modeler.Ba
 
 public abstract class BaseCatalinaMBean extends BaseModelMBean {
 
-protected BaseCatalinaMBean() throws MBeanException, 
RuntimeOperationsException {
-super();
-}
-
-
 protected T doGetManagedResource() throws MBeanException {
 try {
 @SuppressWarnings("unchecked")

Modified: tomcat/trunk/java/org/apache/catalina/mbeans/ClassNameMBean.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/mbeans/ClassNameMBean.java?rev=1799981=1799980=1799981=diff
==
--- tomcat/trunk/java/org/apache/catalina/mbeans/ClassNameMBean.java (original)
+++ tomcat/trunk/java/org/apache/catalina/mbeans/ClassNameMBean.java Mon Jun 26 
20:27:09 2017
@@ -16,9 +16,6 @@
  */
 package org.apache.catalina.mbeans;
 
-import javax.management.MBeanException;
-import javax.management.RuntimeOperationsException;
-
 /**
  * A convenience base class for ModelMBean implementations
  * where the underlying base class (and therefore the set of supported
@@ -35,20 +32,6 @@ import javax.management.RuntimeOperation
 public class ClassNameMBean extends BaseCatalinaMBean {
 
 /**
- * Construct a ModelMBean with default
- * ModelMBeanInfo information.
- *
- * @exception MBeanException if the initialize of an object
- *  throws an exception
- * @exception RuntimeOperationsException if an IllegalArgumentException
- *  occurs
- */
-public ClassNameMBean() throws MBeanException, RuntimeOperationsException {
-super();
-}
-
-
-/**
  * Return the fully qualified Java class name of the managed object
  * for this MBean.
  */

Modified: tomcat/trunk/java/org/apache/catalina/mbeans/ConnectorMBean.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/mbeans/ConnectorMBean.java?rev=1799981=1799980=1799981=diff
==
--- tomcat/trunk/java/org/apache/catalina/mbeans/ConnectorMBean.java (original)
+++ tomcat/trunk/java/org/apache/catalina/mbeans/ConnectorMBean.java Mon Jun 26 
20:27:09 2017
@@ -34,20 +34,6 @@ import org.apache.tomcat.util.Introspect
 public class ConnectorMBean extends ClassNameMBean {
 
 /**
- * Construct a ModelMBean with default
- * ModelMBeanInfo information.
- *
- * @exception MBeanException if the initializer of an object
- *  throws an exception
- * @exception RuntimeOperationsException if an IllegalArgumentException
- *  occurs
- */
-public ConnectorMBean() throws MBeanException, RuntimeOperationsException {
-super();
-}
-
-
-/**
  * Obtain and return the value of a specific attribute of this MBean.
  *
  * @param name Name of the requested attribute

Modified: tomcat/trunk/java/org/apache/catalina/mbeans/ContainerMBean.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/mbeans/ContainerMBean.java?rev=1799981=1799980=1799981=diff
==
--- tomcat/trunk/java/org/apache/catalina/mbeans/ContainerMBean.java (original)
+++ 

[GitHub] tomcat issue #68: Fix #61224 - Make the GlobalRequestProcessor mbeans read-o...

[markt-asf]

Github user markt-asf commented on the issue:

https://github.com/apache/tomcat/pull/68
  
Tomcat fails to compile after applying this patch.

Looking in to this, I don't see any reason for BaseModelMBean to throw 
exceptions in its constructor. As far as I can tell, the constructor (and the 
matching constructors on all the sub-classes) can be removed.

I'm going to look into this before coming back to this PR. No need to 
update the PR. The changes required are minor enough that I'll handle it on 
merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1799975 - in /tomcat/tc8.0.x/tags/TOMCAT_8_0_45: ./ build.properties.default webapps/docs/changelog.xml

[violetagg]

Author: violetagg
Date: Mon Jun 26 20:00:20 2017
New Revision: 1799975

URL: http://svn.apache.org/viewvc?rev=1799975=rev
Log:
Tag 8.0.45

Added:
tomcat/tc8.0.x/tags/TOMCAT_8_0_45/   (props changed)
  - copied from r1799974, tomcat/tc8.0.x/trunk/
Modified:
tomcat/tc8.0.x/tags/TOMCAT_8_0_45/build.properties.default
tomcat/tc8.0.x/tags/TOMCAT_8_0_45/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/tags/TOMCAT_8_0_45/
--
bugtraq:append = false

Propchange: tomcat/tc8.0.x/tags/TOMCAT_8_0_45/
--
bugtraq:label = Bugzilla ID (optional)

Propchange: tomcat/tc8.0.x/tags/TOMCAT_8_0_45/
--
--- bugtraq:logregex (added)
+++ bugtraq:logregex Mon Jun 26 20:00:20 2017
@@ -0,0 +1,2 @@
+(https?\://(bz|issues)\.apache\.org/bugzilla/show_bug.cgi\?id=\d+|BZ\s?\d+)
+(\d+)

Propchange: tomcat/tc8.0.x/tags/TOMCAT_8_0_45/
--
bugtraq:message = Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=%BUGID%

Propchange: tomcat/tc8.0.x/tags/TOMCAT_8_0_45/
--
bugtraq:url = https://bz.apache.org/bugzilla/show_bug.cgi?id=%BUGID%

Propchange: tomcat/tc8.0.x/tags/TOMCAT_8_0_45/
--
--- svn:ignore (added)
+++ svn:ignore Mon Jun 26 20:00:20 2017
@@ -0,0 +1,7 @@
+.*
+build.properties
+logs
+nbproject
+output
+work
+*.iml

Propchange: tomcat/tc8.0.x/tags/TOMCAT_8_0_45/
--
--- svn:mergeinfo (added)
+++ svn:mergeinfo Mon Jun 26 20:00:20 2017
@@ -0,0 +1,2 @@
+/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948,1777014,1779719,1782037,1782240,1782386-1782387,1785669,1786845,1788249,1788324,1788905,1789216,1789335,1791528,1791558,1796697-1796698,1797521,1798543,1799162
+/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 

[Bug 61210] When using the Security Manager, Tomcat prints warning about a non-existent file

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61210

--- Comment #7 from Mark Thomas  ---
There is a way to do this.

Hint: Take a look at org.apache.juli.WebappProperties and how it is used.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61210] When using the Security Manager, Tomcat prints warning about a non-existent file

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61210

--- Comment #6 from Mark Thomas  ---
It fails because the call originates in JULI and JULI doesn't have permissions
to read the file. All the Privileged block does is stop the security manager
also checking that all of the callers up the stack also have permission to read
the file.

An alternative approach will be required.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat pull request #67: Fix #61216 - Enhanced output format of CompositeDat...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/tomcat/pull/67


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1799957 - in /tomcat/tc7.0.x/trunk: build.properties.default res/maven/mvn.properties.default webapps/docs/changelog.xml

[violetagg]

Author: violetagg
Date: Mon Jun 26 17:25:51 2017
New Revision: 1799957

URL: http://svn.apache.org/viewvc?rev=1799957=rev
Log:
Increment version for next dev cycle

Modified:
tomcat/tc7.0.x/trunk/build.properties.default
tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc7.0.x/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/build.properties.default?rev=1799957=1799956=1799957=diff
==
--- tomcat/tc7.0.x/trunk/build.properties.default (original)
+++ tomcat/tc7.0.x/trunk/build.properties.default Mon Jun 26 17:25:51 2017
@@ -25,7 +25,7 @@
 # - Version Control Flags -
 version.major=7
 version.minor=0
-version.build=79
+version.build=80
 version.patch=0
 version.suffix=-dev
 

Modified: tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default?rev=1799957=1799956=1799957=diff
==
--- tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default (original)
+++ tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default Mon Jun 26 17:25:51 
2017
@@ -35,7 +35,7 @@ maven.asf.release.repo.url=https://repos
 maven.asf.release.repo.repositoryId=apache.releases
 
 # Release version info
-maven.asf.release.deploy.version=7.0.79
+maven.asf.release.deploy.version=7.0.80
 
 #Where do we load the libraries from
 tomcat.lib.path=../../output/build/lib

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1799957=1799956=1799957=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Mon Jun 26 17:25:51 2017
@@ -57,6 +57,8 @@
   They eventually become mixed with the numbered issues. (I.e., numbered
   issues do not "pop up" wrt. others).
 -->
+
+
 
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[VOTE] Release Apache Tomcat 7.0.79

[Violeta Georgieva]

The proposed Apache Tomcat 7.0.79 release is now available for voting.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.79/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1139/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_79/

The proposed 7.0.79 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 7.0.79 Stable

Regards,
Violeta

[Bug 61210] When using the Security Manager, Tomcat prints warning about a non-existent file

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61210

--- Comment #5 from Coty Sutherland  ---
Created attachment 35077
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35077=edit
First attempt

Here's my first attempt at checking whether or not the file exists before
logging. The problem with this is that the privileged block is still failing
checkPermission. I'm not quite sure how to fix it as I modeled my change after
some other doPrivileged calls in the same class. The only difference is that
I'm returning a value to check later in the readConfiguration method instead of
Void. Can anyone point me in the right direction?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r20199 [2/2] - in /dev/tomcat/tomcat-7/v7.0.79: ./ bin/ bin/embed/ bin/extras/ src/

[violetagg]

Added: dev/tomcat/tomcat-7/v7.0.79/bin/extras/catalina-jmx-remote.jar.sha1
==
--- dev/tomcat/tomcat-7/v7.0.79/bin/extras/catalina-jmx-remote.jar.sha1 (added)
+++ dev/tomcat/tomcat-7/v7.0.79/bin/extras/catalina-jmx-remote.jar.sha1 Mon Jun 
26 17:21:13 2017
@@ -0,0 +1 @@
+4b490bfd1568a6b2c8c4f84b002f51718c3b8112 *catalina-jmx-remote.jar
\ No newline at end of file

Added: dev/tomcat/tomcat-7/v7.0.79/bin/extras/catalina-ws.jar
==
Binary file - no diff available.

Propchange: dev/tomcat/tomcat-7/v7.0.79/bin/extras/catalina-ws.jar
--
svn:mime-type = application/octet-stream

Added: dev/tomcat/tomcat-7/v7.0.79/bin/extras/catalina-ws.jar.asc
==
--- dev/tomcat/tomcat-7/v7.0.79/bin/extras/catalina-ws.jar.asc (added)
+++ dev/tomcat/tomcat-7/v7.0.79/bin/extras/catalina-ws.jar.asc Mon Jun 26 
17:21:13 2017
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v2
+
+iQIcBAABCgAGBQJZUTX6AAoJECCLCrHWMBHH+fEP/1h+65EQL3FazeIZbb3FKsBx
+xdiNS9+XI5kcsqk3hqRgirvOZWbAK0yWolHhSrbGjOZYPA2ZaFvbNitS3GEr32xK
+clvbkaXbbDHB0ZS70wEhkUJA0/M5Hf9F4c5KDnRzKmVENpS/ZNtN6ravZjoxJe+F
+CdsVIPKh8SqAej0E70Hj9joq6VlH0nTDqChzEm1cJ6FtqdrRBKpGNUKpFAhSa3LA
+VwefIPEdL0G4+41vbIblENjUNUTw6LXY3AaOvq37+4Ep1ljEM4c3FG85NXsMQkAj
+lDVtXZI6lD6P8+CruHiOzRNub4zBSD9WTdWVjstZasqPk4dVftsPTkjEVDe81xu6
+3Zv2n/4vS9fGv374tXuriICU1E8QYHEVnE/Cwag+4cTZCJBesuC6+AYsrXA2JoXQ
+7/w2g0cEid/NtB2YZNHgvUo/mebCet8muX4XxWklX3GSIT0752rF+iGgqDuIOe4k
+zbuOgLfi+QN8ui0uhee94uUBWbJdXYF4+8pFTfsgn2QaM+xEOQKMY3DY6vb9tqdK
+2vanUpf2DZHHxltOKaZ15oHGF6yQKf2EQVdzn3nC1ZPu0AsqzveeOOk3DesIyccg
+bWm0Gr80p1Y1PoJZzgVhsiPfcRCuUEXI5dX6Q/BnyGcZH10rz/4OU6uBFprt5uwi
+ohIpckTXkyYwqzf1lSyL
+=hl6H
+-END PGP SIGNATURE-

Added: dev/tomcat/tomcat-7/v7.0.79/bin/extras/catalina-ws.jar.md5
==
--- dev/tomcat/tomcat-7/v7.0.79/bin/extras/catalina-ws.jar.md5 (added)
+++ dev/tomcat/tomcat-7/v7.0.79/bin/extras/catalina-ws.jar.md5 Mon Jun 26 
17:21:13 2017
@@ -0,0 +1 @@
+d4ba92d8f30fb4613d50339e92ef4e6c *catalina-ws.jar
\ No newline at end of file

Added: dev/tomcat/tomcat-7/v7.0.79/bin/extras/catalina-ws.jar.sha1
==
--- dev/tomcat/tomcat-7/v7.0.79/bin/extras/catalina-ws.jar.sha1 (added)
+++ dev/tomcat/tomcat-7/v7.0.79/bin/extras/catalina-ws.jar.sha1 Mon Jun 26 
17:21:13 2017
@@ -0,0 +1 @@
+373104338deb80e33effe6ca8d302739e8153383 *catalina-ws.jar
\ No newline at end of file

Added: dev/tomcat/tomcat-7/v7.0.79/bin/extras/tomcat-juli-adapters.jar
==
Binary file - no diff available.

Propchange: dev/tomcat/tomcat-7/v7.0.79/bin/extras/tomcat-juli-adapters.jar
--
svn:mime-type = application/octet-stream

Added: dev/tomcat/tomcat-7/v7.0.79/bin/extras/tomcat-juli-adapters.jar.asc
==
--- dev/tomcat/tomcat-7/v7.0.79/bin/extras/tomcat-juli-adapters.jar.asc (added)
+++ dev/tomcat/tomcat-7/v7.0.79/bin/extras/tomcat-juli-adapters.jar.asc Mon Jun 
26 17:21:13 2017
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v2
+
+iQIcBAABCgAGBQJZUTX5AAoJECCLCrHWMBHHp3YP+gLdPqVZ3zPKCiZlyse8K0bW
+lMMLb5Ihgg3XJuSIt3mXrlV9aad+aKdHZM1NvSiiSqg/wNkAH93AsCNWDdjTPIbG
+IiLXAOeVwqz8fDicpB7v7RJDtCCOqomU8Vm4MXL7TTK+PgigXvMzfuFwKER84424
++1jo23BckpPUn6zDh2yZkbhFfqsOBTk/glWKGxWhL5MoUK7o3Gop8ORiyZOBBUEv
+72fylz+Xv9v3D5BbQVRsSLxRr5BOot8NDaUhzPH88scVSBTrHF7iYztqyemqtzZj
+ZRDVDjKWfE0Gw1uOerRgrvYqXoxrvtUKRdJoRR6PpE4Wcf1C+zfZcur4sfY6eDTi
+wV8syh1eGeiDd0/QDFMGfbhjQ1WFoEkjKPin7XEQH1kpO4WE3Osas0OQDOB7Yf1K
+QZvtNgXOgJ8PSA4ojhpPlR9NLHqVmIzwryQ+p84lP3LAzr9uDdxgSdBkCDonibP8
+xZwgmFP6RR6lZ9XYde7+GStdJQFqmYEi7tizijovUGKNKhJmGD4n+ZnHQSru5963
+CXPjavptXXY6DUQ0jS8cTPYPn19PRp2gP+iPeD74Pp6uyyDQmFWU6DwYazZF9oDp
+P9CbAq+g7ldcd+kYfRYl+saDjZcRfQhDTJ2vvzF0qE3wXF/MzkgyL0TIQpNbto4A
+vPr4kthGpGmKE3jbf89u
+=OZea
+-END PGP SIGNATURE-

Added: dev/tomcat/tomcat-7/v7.0.79/bin/extras/tomcat-juli-adapters.jar.md5
==
--- dev/tomcat/tomcat-7/v7.0.79/bin/extras/tomcat-juli-adapters.jar.md5 (added)
+++ dev/tomcat/tomcat-7/v7.0.79/bin/extras/tomcat-juli-adapters.jar.md5 Mon Jun 
26 17:21:13 2017
@@ -0,0 +1 @@
+fe0704225545fe29fc19f9baa3dbbd79 *tomcat-juli-adapters.jar
\ No newline at end of file

Added: dev/tomcat/tomcat-7/v7.0.79/bin/extras/tomcat-juli-adapters.jar.sha1
==
--- 

svn commit: r20199 [1/2] - in /dev/tomcat/tomcat-7/v7.0.79: ./ bin/ bin/embed/ bin/extras/ src/

[violetagg]

Author: violetagg
Date: Mon Jun 26 17:21:13 2017
New Revision: 20199

Log:
Stage 7.0.79 RC

Added:
dev/tomcat/tomcat-7/v7.0.79/
dev/tomcat/tomcat-7/v7.0.79/KEYS
dev/tomcat/tomcat-7/v7.0.79/README.html
dev/tomcat/tomcat-7/v7.0.79/RELEASE-NOTES
dev/tomcat/tomcat-7/v7.0.79/bin/
dev/tomcat/tomcat-7/v7.0.79/bin/README.html
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79-deployer.tar.gz   
(with props)
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79-deployer.tar.gz.asc
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79-deployer.tar.gz.md5
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79-deployer.tar.gz.sha1
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79-deployer.zip   (with 
props)
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79-deployer.zip.asc
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79-deployer.zip.md5
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79-deployer.zip.sha1
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79-fulldocs.tar.gz   
(with props)
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79-fulldocs.tar.gz.asc
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79-fulldocs.tar.gz.md5
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79-fulldocs.tar.gz.sha1
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79-windows-x64.zip   
(with props)
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79-windows-x64.zip.asc
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79-windows-x64.zip.md5
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79-windows-x64.zip.sha1
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79-windows-x86.zip   
(with props)
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79-windows-x86.zip.asc
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79-windows-x86.zip.md5
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79-windows-x86.zip.sha1
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79.exe   (with props)
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79.exe.asc
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79.exe.md5
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79.exe.sha1
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79.tar.gz   (with props)
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79.tar.gz.asc
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79.tar.gz.md5
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79.tar.gz.sha1
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79.zip   (with props)
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79.zip.asc
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79.zip.md5
dev/tomcat/tomcat-7/v7.0.79/bin/apache-tomcat-7.0.79.zip.sha1
dev/tomcat/tomcat-7/v7.0.79/bin/embed/
dev/tomcat/tomcat-7/v7.0.79/bin/embed/apache-tomcat-7.0.79-embed.tar.gz   
(with props)
dev/tomcat/tomcat-7/v7.0.79/bin/embed/apache-tomcat-7.0.79-embed.tar.gz.asc
dev/tomcat/tomcat-7/v7.0.79/bin/embed/apache-tomcat-7.0.79-embed.tar.gz.md5
dev/tomcat/tomcat-7/v7.0.79/bin/embed/apache-tomcat-7.0.79-embed.tar.gz.sha1
dev/tomcat/tomcat-7/v7.0.79/bin/embed/apache-tomcat-7.0.79-embed.zip   
(with props)
dev/tomcat/tomcat-7/v7.0.79/bin/embed/apache-tomcat-7.0.79-embed.zip.asc
dev/tomcat/tomcat-7/v7.0.79/bin/embed/apache-tomcat-7.0.79-embed.zip.md5
dev/tomcat/tomcat-7/v7.0.79/bin/embed/apache-tomcat-7.0.79-embed.zip.sha1
dev/tomcat/tomcat-7/v7.0.79/bin/extras/
dev/tomcat/tomcat-7/v7.0.79/bin/extras/catalina-jmx-remote.jar   (with 
props)
dev/tomcat/tomcat-7/v7.0.79/bin/extras/catalina-jmx-remote.jar.asc
dev/tomcat/tomcat-7/v7.0.79/bin/extras/catalina-jmx-remote.jar.md5
dev/tomcat/tomcat-7/v7.0.79/bin/extras/catalina-jmx-remote.jar.sha1
dev/tomcat/tomcat-7/v7.0.79/bin/extras/catalina-ws.jar   (with props)
dev/tomcat/tomcat-7/v7.0.79/bin/extras/catalina-ws.jar.asc
dev/tomcat/tomcat-7/v7.0.79/bin/extras/catalina-ws.jar.md5
dev/tomcat/tomcat-7/v7.0.79/bin/extras/catalina-ws.jar.sha1
dev/tomcat/tomcat-7/v7.0.79/bin/extras/tomcat-juli-adapters.jar   (with 
props)
dev/tomcat/tomcat-7/v7.0.79/bin/extras/tomcat-juli-adapters.jar.asc
dev/tomcat/tomcat-7/v7.0.79/bin/extras/tomcat-juli-adapters.jar.md5
dev/tomcat/tomcat-7/v7.0.79/bin/extras/tomcat-juli-adapters.jar.sha1
dev/tomcat/tomcat-7/v7.0.79/bin/extras/tomcat-juli.jar   (with props)
dev/tomcat/tomcat-7/v7.0.79/bin/extras/tomcat-juli.jar.asc
dev/tomcat/tomcat-7/v7.0.79/bin/extras/tomcat-juli.jar.md5
dev/tomcat/tomcat-7/v7.0.79/bin/extras/tomcat-juli.jar.sha1
dev/tomcat/tomcat-7/v7.0.79/src/
dev/tomcat/tomcat-7/v7.0.79/src/apache-tomcat-7.0.79-src.tar.gz   (with 
props)
dev/tomcat/tomcat-7/v7.0.79/src/apache-tomcat-7.0.79-src.tar.gz.asc
dev/tomcat/tomcat-7/v7.0.79/src/apache-tomcat-7.0.79-src.tar.gz.md5
dev/tomcat/tomcat-7/v7.0.79/src/apache-tomcat-7.0.79-src.tar.gz.sha1

svn commit: r1799956 - /tomcat/trunk/java/org/apache/catalina/mbeans/MBeanDumper.java

[markt]

Author: markt
Date: Mon Jun 26 17:20:46 2017
New Revision: 1799956

URL: http://svn.apache.org/viewvc?rev=1799956=rev
Log:
Reformat.
No functional change.

Modified:
tomcat/trunk/java/org/apache/catalina/mbeans/MBeanDumper.java

Modified: tomcat/trunk/java/org/apache/catalina/mbeans/MBeanDumper.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/mbeans/MBeanDumper.java?rev=1799956=1799955=1799956=diff
==
--- tomcat/trunk/java/org/apache/catalina/mbeans/MBeanDumper.java (original)
+++ tomcat/trunk/java/org/apache/catalina/mbeans/MBeanDumper.java Mon Jun 26 
17:20:46 2017
@@ -34,7 +34,6 @@ import org.apache.tomcat.util.ExceptionU
 
 /**
  * General helper to dump MBean contents to the log.
- *
  */
 public class MBeanDumper {
 
@@ -42,14 +41,15 @@ public class MBeanDumper {
 
 private static final String CRLF = "\r\n";
 
+
 /**
  * The following code to dump MBeans has been copied from JMXProxyServlet.
+ *
  * @param mbeanServer the MBean server
  * @param names a set of object names for which to dump the info
  * @return a string representation of the MBeans
  */
-public static String dumpBeans(MBeanServer mbeanServer, Set 
names)
-{
+public static String dumpBeans(MBeanServer mbeanServer, Set 
names) {
 StringBuilder buf = new StringBuilder();
 for (ObjectName oname : names) {
 buf.append("Name: ");
@@ -57,26 +57,27 @@ public class MBeanDumper {
 buf.append(CRLF);
 
 try {
-MBeanInfo minfo=mbeanServer.getMBeanInfo(oname);
+MBeanInfo minfo = mbeanServer.getMBeanInfo(oname);
 // can't be null - I think
-String code=minfo.getClassName();
+String code = minfo.getClassName();
 if ("org.apache.commons.modeler.BaseModelMBean".equals(code)) {
-code=(String)mbeanServer.getAttribute(oname, 
"modelerType");
+code = (String) mbeanServer.getAttribute(oname, 
"modelerType");
 }
 buf.append("modelerType: ");
 buf.append(code);
 buf.append(CRLF);
 
-MBeanAttributeInfo attrs[]=minfo.getAttributes();
-Object value=null;
+MBeanAttributeInfo attrs[] = minfo.getAttributes();
+Object value = null;
 
 for (MBeanAttributeInfo attr : attrs) {
-if (!attr.isReadable()) continue;
+if (!attr.isReadable())
+continue;
 String attName = attr.getName();
-if ("modelerType".equals(attName)) continue;
-if (attName.indexOf('=') >= 0 ||
-attName.indexOf(':') >= 0 ||
-attName.indexOf(' ') >= 0) {
+if ("modelerType".equals(attName))
+continue;
+if (attName.indexOf('=') >= 0 || attName.indexOf(':') >= 0
+|| attName.indexOf(' ') >= 0) {
 continue;
 }
 
@@ -86,33 +87,31 @@ public class MBeanDumper {
 Throwable cause = rme.getCause();
 if (cause instanceof UnsupportedOperationException) {
 if (log.isDebugEnabled()) {
-log.debug("Error getting attribute " + oname
-+ " " + attName, rme);
+log.debug("Error getting attribute " + oname + 
" " + attName, rme);
 }
 } else if (cause instanceof NullPointerException) {
 if (log.isDebugEnabled()) {
-log.debug("Error getting attribute " + oname
-+ " " + attName, rme);
+log.debug("Error getting attribute " + oname + 
" " + attName, rme);
 }
 } else {
-log.error("Error getting attribute " + oname +
-" " + attName, rme);
+log.error("Error getting attribute " + oname + " " 
+ attName, rme);
 }
 continue;
 } catch (Throwable t) {
 ExceptionUtils.handleThrowable(t);
-log.error("Error getting attribute " + oname +
-" " + attName, t);
+log.error("Error getting attribute " + oname + " " + 
attName, t);
+continue;
+}
+if (value == null) {
 continue;
 }
-

[Bug 61216] Enhanced output format of CompositeData and TabularData in JMXProxy

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61216

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Mark Thomas  ---
Thanks for the patch. It has been applied to 9.0.c for 9.0.0.M23 onwards.

I'm not planning on back-porting it since, while users should not depend on the
exact format out this sort of output, experience is that they do.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1799952 - in /tomcat/trunk: java/org/apache/catalina/mbeans/MBeanDumper.java webapps/docs/changelog.xml

[markt]

Author: markt
Date: Mon Jun 26 17:15:07 2017
New Revision: 1799952

URL: http://svn.apache.org/viewvc?rev=1799952=rev
Log:
Improve layout for CompositeData and TabularData when viewing via the JMX proxy 
servlet.
Patch provided by Alexis Hassler.
This closes #67

Modified:
tomcat/trunk/java/org/apache/catalina/mbeans/MBeanDumper.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/mbeans/MBeanDumper.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/mbeans/MBeanDumper.java?rev=1799952=1799951=1799952=diff
==
--- tomcat/trunk/java/org/apache/catalina/mbeans/MBeanDumper.java (original)
+++ tomcat/trunk/java/org/apache/catalina/mbeans/MBeanDumper.java Mon Jun 26 
17:15:07 2017
@@ -18,12 +18,15 @@ package org.apache.catalina.mbeans;
 
 import java.lang.reflect.Array;
 import java.util.Set;
+import java.util.StringJoiner;
 
 import javax.management.JMRuntimeException;
 import javax.management.MBeanAttributeInfo;
 import javax.management.MBeanInfo;
 import javax.management.MBeanServer;
 import javax.management.ObjectName;
+import javax.management.openmbean.CompositeData;
+import javax.management.openmbean.TabularData;
 
 import org.apache.juli.logging.Log;
 import org.apache.juli.logging.LogFactory;
@@ -67,18 +70,18 @@ public class MBeanDumper {
 MBeanAttributeInfo attrs[]=minfo.getAttributes();
 Object value=null;
 
-for (int i=0; i< attrs.length; i++) {
-if (! attrs[i].isReadable()) continue;
-String attName=attrs[i].getName();
+for (MBeanAttributeInfo attr : attrs) {
+if (!attr.isReadable()) continue;
+String attName = attr.getName();
 if ("modelerType".equals(attName)) continue;
-if (attName.indexOf('=') >=0 ||
-attName.indexOf(':') >=0 ||
-attName.indexOf(' ') >=0 ) {
+if (attName.indexOf('=') >= 0 ||
+attName.indexOf(':') >= 0 ||
+attName.indexOf(' ') >= 0) {
 continue;
 }
 
 try {
-value=mbeanServer.getAttribute(oname, attName);
+value = mbeanServer.getAttribute(oname, attName);
 } catch (JMRuntimeException rme) {
 Throwable cause = rme.getCause();
 if (cause instanceof UnsupportedOperationException) {
@@ -102,7 +105,7 @@ public class MBeanDumper {
 " " + attName, t);
 continue;
 }
-if (value==null) continue;
+if (value == null) continue;
 String valueString;
 try {
 Class c = value.getClass();
@@ -114,34 +117,33 @@ public class MBeanDumper {
 sb.append(CRLF);
 }
 for (int j = 0; j < len; j++) {
-sb.append("\t");
 Object item = Array.get(value, j);
-if (item == null) {
-sb.append("NULL VALUE");
-} else {
-try {
-sb.append(escape(item.toString()));
-}
-catch (Throwable t) {
-ExceptionUtils.handleThrowable(t);
-sb.append("NON-STRINGABLE VALUE");
-}
-}
+sb.append(tableItemToString(item));
 if (j < len - 1) {
 sb.append(CRLF);
 }
 }
 valueString = sb.toString();
 }
+else if (TabularData.class.isInstance(value)) {
+TabularData tab = TabularData.class.cast(value);
+StringJoiner joiner = new StringJoiner(CRLF);
+joiner.add("TabularData["
++ 
tab.getTabularType().getRowType().getTypeName()
++ "] of length " + tab.size());
+for (Object item : tab.values()) {
+joiner.add(tableItemToString(item));
+}
+valueString = joiner.toString();
+}

[Bug 61217] Tomcat does not send all buffer in case of response was modify

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61217

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #4 from Mark Thomas  ---
When the response is flushed, the HTTP headers are written to the client. At
that point, if a content-length is set, that content-length is fixed.

If you don't want this behaviour, wrap the response and prevent the application
setting the content-length header. This will cause a switch to chunked
encoding.

Note that the only spec compliant way to modify the output is to wrap the
response and handle all the changes in the wrapped response. This can get quite
tricky, quite quickly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: tomcat-dbcp vs tomcat-jdbc

[Coty Sutherland]

On Mon, Jun 26, 2017 at 12:41 PM, Mark Thomas  wrote:
> On 26/06/17 17:16, Coty Sutherland wrote:
>> Hi,
>>
>> I have been looking at the connection pooling libraries that we
>> presently have and it appears (at least the way the documentation puts
>> it, https://tomcat.apache.org/tomcat-8.5-doc/jdbc-pool.html) that
>> tomcat-jdbc is much better than tomcat-dbcp.
>
> It is a false comparison. It is comparing jdbc-pool to DBCP 1.x.
> tomcat-dbcp is based on DBCP 2.x.
>
>> Have we considered
>> promoting it to the default connection pool implementation? Do we want
>> to continue to offer it and an alternative? Are there situations when
>> dbcp is better than jdbc?
>
> The performance numbers are broadly similar. tomcat-jdbc had a slight
> edge last time I checked but the differences are in the noise compared
> to even the most basis database operation. The reason for that edge is
> that tomcat-jdbc doesn't do everything by default that tomcat-dbcp does.
>
> Some back-ground:
> http://markmail.org/message/nhayhdcstkj2lssf

Thanks for the history.

>> Disclaimer: I haven't used either, but figured that potentially
>> removing a dependency was worth inquiring about.
>
> Once thing tomcat-jdbc does a lot better than tomcat-dbcp is JMX. That
> is the primary reason I haven't followed up on this thread:
>
> http://tomcat.markmail.org/thread/o4d2qalqf7267gl6

OK, got it. I'll leave it alone too then :)

> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: tomcat-dbcp vs tomcat-jdbc

[Mark Thomas]

On 26/06/17 17:16, Coty Sutherland wrote:
> Hi,
> 
> I have been looking at the connection pooling libraries that we
> presently have and it appears (at least the way the documentation puts
> it, https://tomcat.apache.org/tomcat-8.5-doc/jdbc-pool.html) that
> tomcat-jdbc is much better than tomcat-dbcp.

It is a false comparison. It is comparing jdbc-pool to DBCP 1.x.
tomcat-dbcp is based on DBCP 2.x.

> Have we considered
> promoting it to the default connection pool implementation? Do we want
> to continue to offer it and an alternative? Are there situations when
> dbcp is better than jdbc?

The performance numbers are broadly similar. tomcat-jdbc had a slight
edge last time I checked but the differences are in the noise compared
to even the most basis database operation. The reason for that edge is
that tomcat-jdbc doesn't do everything by default that tomcat-dbcp does.

Some back-ground:
http://markmail.org/message/nhayhdcstkj2lssf

> Disclaimer: I haven't used either, but figured that potentially
> removing a dependency was worth inquiring about.

Once thing tomcat-jdbc does a lot better than tomcat-dbcp is JMX. That
is the primary reason I haven't followed up on this thread:

http://tomcat.markmail.org/thread/o4d2qalqf7267gl6

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

tomcat-dbcp vs tomcat-jdbc

[Coty Sutherland]

Hi,

I have been looking at the connection pooling libraries that we
presently have and it appears (at least the way the documentation puts
it, https://tomcat.apache.org/tomcat-8.5-doc/jdbc-pool.html) that
tomcat-jdbc is much better than tomcat-dbcp. Have we considered
promoting it to the default connection pool implementation? Do we want
to continue to offer it and an alternative? Are there situations when
dbcp is better than jdbc?

Disclaimer: I haven't used either, but figured that potentially
removing a dependency was worth inquiring about.



Thanks,
Coty

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1799944 - in /tomcat/tc7.0.x/tags/TOMCAT_7_0_79: ./ build.properties.default

[violetagg]

Author: violetagg
Date: Mon Jun 26 16:13:30 2017
New Revision: 1799944

URL: http://svn.apache.org/viewvc?rev=1799944=rev
Log:
Tag 7.0.79

Added:
tomcat/tc7.0.x/tags/TOMCAT_7_0_79/   (props changed)
  - copied from r1799940, tomcat/tc7.0.x/trunk/
Modified:
tomcat/tc7.0.x/tags/TOMCAT_7_0_79/build.properties.default

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_79/
--
bugtraq:append = false

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_79/
--
bugtraq:label = Bugzilla ID (optional)

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_79/
--
--- bugtraq:logregex (added)
+++ bugtraq:logregex Mon Jun 26 16:13:30 2017
@@ -0,0 +1,2 @@
+(https?\://(bz|issues)\.apache\.org/bugzilla/show_bug.cgi\?id=\d+|BZ\s?\d+)
+(\d+)

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_79/
--
bugtraq:message = Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=%BUGID%

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_79/
--
bugtraq:url = https://bz.apache.org/bugzilla/show_bug.cgi?id=%BUGID%

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_79/
--
--- svn:ignore (added)
+++ svn:ignore Mon Jun 26 16:13:30 2017
@@ -0,0 +1,7 @@
+.*
+build.properties
+logs
+nbproject
+output
+work
+*.iml

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_79/
--
--- svn:mergeinfo (added)
+++ svn:mergeinfo Mon Jun 26 16:13:30 2017
@@ -0,0 +1,3 @@
+/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702
 
742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1725974,1
 

Re: asyncError() is not valid while in Async state DISPATCHING

[Mark Thomas]

On 26/06/17 14:58, Violeta Georgieva wrote:
> 2017-06-26 16:35 GMT+03:00 Mark Thomas :
>>
>> On 26/06/17 14:18, Violeta Georgieva wrote:
>>> 2017-06-26 16:13 GMT+03:00 Mark Thomas :

 On 23/06/17 14:47, Violeta Georgieva wrote:
> 2017-06-13 15:44 GMT+03:00 Mark Thomas :
>> On 13/06/17 11:05, Violeta Georgieva wrote:
>>> 2017-06-13 13:04 GMT+03:00 Violeta Georgieva :

 

 java.lang.NullPointerException: null
>>
>> Appears to be the same cause as above, but triggered at a different
>>> point.
>>
>
> What about at least not throw NPE?

 Which object is null? Since the stack trace is from a dev version, I'm
 not exactly sure where the null is in this case.
>>>
>>> The first thread makes a dispatch and clears the request and response
>>>
> https://github.com/apache/tomcat/blob/trunk/java/org/apache/catalina/core/AsyncContextImpl.java#L209
>>>
>>> the second thread handles the error and tries to set a status code
>>>
> https://github.com/apache/tomcat/blob/trunk/java/org/apache/catalina/core/AsyncContextImpl.java#L411
>>
>> This should be fixed in trunk. If this is sufficient, we can back-port.
>>
> 
> I just tested it. I did not see any NPEs. Please back-port it.

Done.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1799935 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/AsyncContextImpl.java

[markt]

Author: markt
Date: Mon Jun 26 15:53:51 2017
New Revision: 1799935

URL: http://svn.apache.org/viewvc?rev=1799935=rev
Log:
Avoid NPE during non-container thread error handling

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jun 26 15:53:51 2017
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702
 
742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1725974,1
 
726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1759565,1761686,1762173,1762206,1766280,1767507-1767508,1767653,1767656,1769267,1772949,1773521,1773527,1774104,1777015,1777213,1779330,1783151,1784188,1784966,1785670,1786846,1788260,1788999,1789140,1789402,1791529,1791559,1795291,1796906,1797523,1799214

svn commit: r1799934 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/AsyncContextImpl.java

[markt]

Author: markt
Date: Mon Jun 26 15:53:15 2017
New Revision: 1799934

URL: http://svn.apache.org/viewvc?rev=1799934=rev
Log:
Avoid NPE during non-container thread error handling

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jun 26 15:53:15 2017
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948,1777014,1779719,1782037,1782240,1782386-1782387,1785669,1786845,1788249,1788324,1788905,1789216,1789335,1791528,1791558,1796697-1796698,1797521,1798543,1799162
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452
 

svn commit: r1799932 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/core/AsyncContextImpl.java

[markt]

Author: markt
Date: Mon Jun 26 15:52:20 2017
New Revision: 1799932

URL: http://svn.apache.org/viewvc?rev=1799932=rev
Log:
Avoid NPE during non-container thread error handling

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jun 26 15:52:20 2017
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747
 
536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1
 
756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-1762053,1762123,176216
 

Re: asyncError() is not valid while in Async state DISPATCHING

[Violeta Georgieva]

2017-06-26 16:35 GMT+03:00 Mark Thomas :
>
> On 26/06/17 14:18, Violeta Georgieva wrote:
> > 2017-06-26 16:13 GMT+03:00 Mark Thomas :
> >>
> >> On 23/06/17 14:47, Violeta Georgieva wrote:
> >>> 2017-06-13 15:44 GMT+03:00 Mark Thomas :
>  On 13/06/17 11:05, Violeta Georgieva wrote:
> > 2017-06-13 13:04 GMT+03:00 Violeta Georgieva :
> >>
> >> 
> >>
> >> java.lang.NullPointerException: null
> 
>  Appears to be the same cause as above, but triggered at a different
> > point.
> 
> >>>
> >>> What about at least not throw NPE?
> >>
> >> Which object is null? Since the stack trace is from a dev version, I'm
> >> not exactly sure where the null is in this case.
> >
> > The first thread makes a dispatch and clears the request and response
> >
https://github.com/apache/tomcat/blob/trunk/java/org/apache/catalina/core/AsyncContextImpl.java#L209
> >
> > the second thread handles the error and tries to set a status code
> >
https://github.com/apache/tomcat/blob/trunk/java/org/apache/catalina/core/AsyncContextImpl.java#L411
>
> This should be fixed in trunk. If this is sufficient, we can back-port.
>

I just tested it. I did not see any NPEs. Please back-port it.

Thanks,
Violeta

> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

buildbot failure in on tomcat-8-trunk

[buildbot]

The Buildbot has detected a new failure on builder tomcat-8-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-8-trunk/builds/1048

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-8-commit' 
triggered this build
Build Source Stamp: [branch tomcat/tc8.0.x/trunk] 1799912
Blamelist: markt

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61223] Enhance the documentation for mbeans-descriptors.xml

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61223

Mark Thomas  changed:

   What|Removed |Added

   Keywords||Beginner
   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: asyncError() is not valid while in Async state DISPATCHING

[Mark Thomas]

On 26/06/17 14:18, Violeta Georgieva wrote:
> 2017-06-26 16:13 GMT+03:00 Mark Thomas :
>>
>> On 23/06/17 14:47, Violeta Georgieva wrote:
>>> 2017-06-13 15:44 GMT+03:00 Mark Thomas :
 On 13/06/17 11:05, Violeta Georgieva wrote:
> 2017-06-13 13:04 GMT+03:00 Violeta Georgieva :
>>
>> 
>>
>> java.lang.NullPointerException: null

 Appears to be the same cause as above, but triggered at a different
> point.

>>>
>>> What about at least not throw NPE?
>>
>> Which object is null? Since the stack trace is from a dev version, I'm
>> not exactly sure where the null is in this case.
> 
> The first thread makes a dispatch and clears the request and response
> https://github.com/apache/tomcat/blob/trunk/java/org/apache/catalina/core/AsyncContextImpl.java#L209
> 
> the second thread handles the error and tries to set a status code
> https://github.com/apache/tomcat/blob/trunk/java/org/apache/catalina/core/AsyncContextImpl.java#L411

This should be fixed in trunk. If this is sufficient, we can back-port.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1799916 - /tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java

[markt]

Author: markt
Date: Mon Jun 26 13:33:47 2017
New Revision: 1799916

URL: http://svn.apache.org/viewvc?rev=1799916=rev
Log:
Avoid NPE during non-container thread error handling

Modified:
tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java

Modified: tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java?rev=1799916=1799915=1799916=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java Mon Jun 26 
13:33:47 2017
@@ -407,6 +407,10 @@ public class AsyncContextImpl implements
 if (result.get()) {
 // No listener called dispatch() or complete(). This is an error.
 // SRV.2.3.3.3 (search for "error dispatch")
+// Take a local copy to avoid threading issues if another thread
+// clears this (can happen during error handling with non-container
+// threads)
+ServletResponse servletResponse = this.servletResponse;
 if (servletResponse instanceof HttpServletResponse) {
 ((HttpServletResponse) servletResponse).setStatus(
 HttpServletResponse.SC_INTERNAL_SERVER_ERROR);



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1799914 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/AbstractProcessor.java java/org/apache/coyote/AsyncStateMachine.java webapps/docs/changelog.xml

[markt]

Author: markt
Date: Mon Jun 26 13:30:37 2017
New Revision: 1799914

URL: http://svn.apache.org/viewvc?rev=1799914=rev
Log:
Make asynchronous error handling more robust. In particular ensure that 
onError() is called for any registered AsyncListeners after an I/O error on a 
non-container thread.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/coyote/AbstractProcessor.java
tomcat/tc7.0.x/trunk/java/org/apache/coyote/AsyncStateMachine.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jun 26 13:30:37 2017
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702
 
742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1725974,1
 
726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1759565,1761686,1762173,1762206,1766280,1767507-1767508,1767653,1767656,1769267,1772949,1773521,1773527,1774104,1777015,1777213,1779330,1783151,1784188,1784966,1785670,1786846,1788260,1788999,1789140,1789402,1791529,1791559,1795291,1796906,1797523,1799214

svn commit: r1799912 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/coyote/AbstractProcessor.java java/org/apache/coyote/AsyncStateMachine.java webapps/docs/changelog.xml

[markt]

Author: markt
Date: Mon Jun 26 13:20:01 2017
New Revision: 1799912

URL: http://svn.apache.org/viewvc?rev=1799912=rev
Log:
Make asynchronous error handling more robust. In particular ensure that 
onError() is called for any registered AsyncListeners after an I/O error on a 
non-container thread.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/coyote/AbstractProcessor.java
tomcat/tc8.0.x/trunk/java/org/apache/coyote/AsyncStateMachine.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jun 26 13:20:01 2017
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948,1777014,1779719,1782037,1782240,1782386-1782387,1785669,1786845,1788249,1788324,1788905,1789216,1789335,1791528,1791558,1796697-1796698,1797521,1798543,1799162
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 

svn commit: r1799911 - /tomcat/tc8.5.x/trunk/conf/logging.properties

[markt]

Author: markt
Date: Mon Jun 26 13:19:27 2017
New Revision: 1799911

URL: http://svn.apache.org/viewvc?rev=1799911=rev
Log:
Revert accidental commit

Modified:
tomcat/tc8.5.x/trunk/conf/logging.properties

Modified: tomcat/tc8.5.x/trunk/conf/logging.properties
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/conf/logging.properties?rev=1799911=1799910=1799911=diff
==
--- tomcat/tc8.5.x/trunk/conf/logging.properties (original)
+++ tomcat/tc8.5.x/trunk/conf/logging.properties Mon Jun 26 13:19:27 2017
@@ -65,8 +65,6 @@ org.apache.catalina.core.ContainerBase.[
 
 # To see debug messages for HTTP/2 handling, uncomment the following line:
 #org.apache.coyote.http2.level = FINE
-org.apache.coyote.level = FINEST
-org.apache.catalina.level = FINEST
 
 # To see debug messages for WebSocket handling, uncomment the following line:
 #org.apache.tomcat.websocket.level = FINE



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: asyncError() is not valid while in Async state DISPATCHING

[Violeta Georgieva]

2017-06-26 16:13 GMT+03:00 Mark Thomas :
>
> On 23/06/17 14:47, Violeta Georgieva wrote:
> > 2017-06-13 15:44 GMT+03:00 Mark Thomas :
> >> On 13/06/17 11:05, Violeta Georgieva wrote:
> >>> 2017-06-13 13:04 GMT+03:00 Violeta Georgieva :
>
> 
>
>  java.lang.NullPointerException: null
> >>
> >> Appears to be the same cause as above, but triggered at a different
point.
> >>
> >
> > What about at least not throw NPE?
>
> Which object is null? Since the stack trace is from a dev version, I'm
> not exactly sure where the null is in this case.

The first thread makes a dispatch and clears the request and response
https://github.com/apache/tomcat/blob/trunk/java/org/apache/catalina/core/AsyncContextImpl.java#L209

the second thread handles the error and tries to set a status code
https://github.com/apache/tomcat/blob/trunk/java/org/apache/catalina/core/AsyncContextImpl.java#L411


>  at
> >>>
> >
org.apache.catalina.core.AsyncContextImpl.setErrorState(AsyncContextImpl.java:411)
> >>> ~[tomcat-embed-core.jar!/:8.5.16-dev]
> >>
> >> 
> >>
> >> This is consistent with what I'd expect. In both of the above cases any
> >> AsyncListener.onError() methods should execute but if the app continues
> >> to do things on the non-container thread then there possibility of
> >> exceptions remains.
> >>
> >
> > Ok I understand.
> >
> > Can we back port the change to Tomcat 8.5 so that it is guaranteed that
the
> > AsyncListeners will be invoked on error.
>
> Next on my TODO lis.
>
> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

svn commit: r1799908 - in /tomcat/tc8.5.x/trunk: ./ conf/logging.properties java/org/apache/coyote/AbstractProcessor.java java/org/apache/coyote/AsyncStateMachine.java webapps/docs/changelog.xml

[markt]

Author: markt
Date: Mon Jun 26 13:16:50 2017
New Revision: 1799908

URL: http://svn.apache.org/viewvc?rev=1799908=rev
Log:
Make asynchronous error handling more robust. In particular ensure that 
onError() is called for any registered AsyncListeners after an I/O error on a 
non-container thread.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/conf/logging.properties
tomcat/tc8.5.x/trunk/java/org/apache/coyote/AbstractProcessor.java
tomcat/tc8.5.x/trunk/java/org/apache/coyote/AsyncStateMachine.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jun 26 13:16:50 2017
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747
 
536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1
 
756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-1762053,1762123,176216
 

Re: asyncError() is not valid while in Async state DISPATCHING

[Mark Thomas]

On 23/06/17 14:47, Violeta Georgieva wrote:
> 2017-06-13 15:44 GMT+03:00 Mark Thomas :
>> On 13/06/17 11:05, Violeta Georgieva wrote:
>>> 2017-06-13 13:04 GMT+03:00 Violeta Georgieva :



 java.lang.NullPointerException: null
>>
>> Appears to be the same cause as above, but triggered at a different point.
>>
> 
> What about at least not throw NPE?

Which object is null? Since the stack trace is from a dev version, I'm
not exactly sure where the null is in this case.

 at
>>>
> org.apache.catalina.core.AsyncContextImpl.setErrorState(AsyncContextImpl.java:411)
>>> ~[tomcat-embed-core.jar!/:8.5.16-dev]
>>
>> 
>>
>> This is consistent with what I'd expect. In both of the above cases any
>> AsyncListener.onError() methods should execute but if the app continues
>> to do things on the non-container thread then there possibility of
>> exceptions remains.
>>
> 
> Ok I understand.
> 
> Can we back port the change to Tomcat 8.5 so that it is guaranteed that the
> AsyncListeners will be invoked on error.

Next on my TODO lis.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61215] NoSuchMethodException in JMX Proxy when accessing to RemoteAddrValve MBeans

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61215

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Mark Thomas  ---
This has been fixed in:
- trunk for 9.0.0.M23 onwards
- 8.5.x for 8.5.17 onwards
- 8.0.x for 8.0.45 onwards
- 7.0.x for 7.0.79 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1799906 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/valves/RemoteAddrValve.java java/org/apache/catalina/valves/RemoteHostValve.java java/org/apache/catalina/valves/RequestFil

[markt]

Author: markt
Date: Mon Jun 26 13:06:06 2017
New Revision: 1799906

URL: http://svn.apache.org/viewvc?rev=1799906=rev
Log:
Refactor to reduce code duplication.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/RemoteAddrValve.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/RemoteHostValve.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/RequestFilterValve.java

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jun 26 13:06:06 2017
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702
 
742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1725974,1
 
726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1759565,1761686,1762173,1762206,1766280,1767507-1767508,1767653,1767656,1769267,1772949,1773521,1773527,1774104,1777015,1777213,1779330,1783151,1784188,1784966,1785670,1786846,1788260,1788999,1789140,1789402,1791529,1791559,1795291,1796906,1797523,1799214

svn commit: r1799905 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/valves/mbeans-descriptors.xml webapps/docs/changelog.xml

[markt]

Author: markt
Date: Mon Jun 26 13:01:59 2017
New Revision: 1799905

URL: http://svn.apache.org/viewvc?rev=1799905=rev
Log:
Correctly define addConnectorPort and invalidAuthenticationWhenDeny in the 
mbean-descriptors.xml file for the org.apache.catalina.valves package so that 
the attributes are accessible via JMX.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jun 26 13:01:59 2017
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702
 
742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1725974,1
 
726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1759565,1761686,1762173,1762206,1766280,1767507-1767508,1767653,1767656,1769267,1772949,1773521,1773527,1774104,1777015,1777213,1779330,1783151,1784188,1784966,1785670,1786846,1788260,1788999,1789140,1789402,1791529,1791559,1795291,1796906,1797523,1799214

svn commit: r1799904 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/valves/RemoteAddrValve.java java/org/apache/catalina/valves/RemoteHostValve.java java/org/apache/catalina/valves/RequestFil

[markt]

Author: markt
Date: Mon Jun 26 12:58:27 2017
New Revision: 1799904

URL: http://svn.apache.org/viewvc?rev=1799904=rev
Log:
Refactor to reduce code duplication.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/catalina/valves/RemoteAddrValve.java
tomcat/tc8.0.x/trunk/java/org/apache/catalina/valves/RemoteHostValve.java
tomcat/tc8.0.x/trunk/java/org/apache/catalina/valves/RequestFilterValve.java

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jun 26 12:58:27 2017
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948,1777014,1779719,1782037,1782240,1782386-1782387,1785669,1786845,1788249,1788324,1788905,1789216,1789335,1791528,1791558,1796697-1796698,1797521,1798543,1799162
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452
 

svn commit: r1799902 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/valves/mbeans-descriptors.xml webapps/docs/changelog.xml

[markt]

Author: markt
Date: Mon Jun 26 12:56:03 2017
New Revision: 1799902

URL: http://svn.apache.org/viewvc?rev=1799902=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61215
Correctly define addConnectorPort and invalidAuthenticationWhenDeny in the 
mbean-descriptors.xml file for the org.apache.catalina.valves package so that 
the attributes are accessible via JMX.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jun 26 12:56:03 2017
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948,1777014,1779719,1782037,1782240,1782386-1782387,1785669,1786845,1788249,1788324,1788905,1789216,1789335,1791528,1791558,1796697-1796698,1797521,1798543,1799162
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 

svn commit: r1799901 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/valves/RemoteAddrValve.java java/org/apache/catalina/valves/RemoteHostValve.java java/org/apache/catalina/valves/RequestFil

[markt]

Author: markt
Date: Mon Jun 26 12:46:45 2017
New Revision: 1799901

URL: http://svn.apache.org/viewvc?rev=1799901=rev
Log:
Refactor to reduce code duplication.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/catalina/valves/RemoteAddrValve.java
tomcat/tc8.5.x/trunk/java/org/apache/catalina/valves/RemoteHostValve.java
tomcat/tc8.5.x/trunk/java/org/apache/catalina/valves/RequestFilterValve.java

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jun 26 12:46:45 2017
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747
 
536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1
 
756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-1762053,1762123,176216
 

svn commit: r1799900 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/valves/mbeans-descriptors.xml webapps/docs/changelog.xml

[markt]

Author: markt
Date: Mon Jun 26 12:45:49 2017
New Revision: 1799900

URL: http://svn.apache.org/viewvc?rev=1799900=rev
Log:
Correctly define addConnectorPort and invalidAuthenticationWhenDeny in the 
mbean-descriptors.xml file for the org.apache.catalina.valves package so that 
the attributes are accessible via JMX.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jun 26 12:45:49 2017
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747
 
536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1
 
756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-1762053,1762123,176216
 

[Bug 61214] NoSuchMethodException in JMX Proxy when accessing to Context MBeans

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61214

--- Comment #4 from Mark Thomas  ---
Thanks for the heads up. I did check 8.5.x and thought the method was still
there but I didn't check carefully enough.

Fixed in 8.5.x for 8.5.17 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1799898 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/core/mbeans-descriptors.xml webapps/docs/changelog.xml

[markt]

Author: markt
Date: Mon Jun 26 12:43:29 2017
New Revision: 1799898

URL: http://svn.apache.org/viewvc?rev=1799898=rev
Log:
Remove deleted attribute servlets from the Context MBean 
description.
Patch provided by Alexis Hassler.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jun 26 12:43:29 2017
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747
 
536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1
 
756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-1762053,1762123,176216
 

svn commit: r1799895 - in /tomcat/trunk/java/org/apache/catalina/valves: RemoteAddrValve.java RemoteHostValve.java RequestFilterValve.java

[markt]

Author: markt
Date: Mon Jun 26 12:39:15 2017
New Revision: 1799895

URL: http://svn.apache.org/viewvc?rev=1799895=rev
Log:
Refactor to reduce code duplication.

Modified:
tomcat/trunk/java/org/apache/catalina/valves/RemoteAddrValve.java
tomcat/trunk/java/org/apache/catalina/valves/RemoteHostValve.java
tomcat/trunk/java/org/apache/catalina/valves/RequestFilterValve.java

Modified: tomcat/trunk/java/org/apache/catalina/valves/RemoteAddrValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/RemoteAddrValve.java?rev=1799895=1799894=1799895=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/RemoteAddrValve.java (original)
+++ tomcat/trunk/java/org/apache/catalina/valves/RemoteAddrValve.java Mon Jun 
26 12:39:15 2017
@@ -39,48 +39,12 @@ public final class RemoteAddrValve exten
 private static final Log log = LogFactory.getLog(RemoteAddrValve.class);
 
 
-// - Instance Variables
-
-/**
- * Flag deciding whether we add the server connector port to the property
- * compared in the filtering method. The port will be appended
- * using a ";" as a separator.
- */
-volatile boolean addConnectorPort = false;
-
-// - Properties
-
-
-/**
- * Get the flag deciding whether we add the server connector port to the
- * property compared in the filtering method. The port will be appended
- * using a ";" as a separator.
- * @return true to add the connector port, the default is
- *  false
- */
-public boolean getAddConnectorPort() {
-return addConnectorPort;
-}
-
-
-/**
- * Set the flag deciding whether we add the server connector port to the
- * property compared in the filtering method. The port will be appended
- * using a ";" as a separator.
- *
- * @param addConnectorPort The new flag
- */
-public void setAddConnectorPort(boolean addConnectorPort) {
-this.addConnectorPort = addConnectorPort;
-}
-
-
 // - Public Methods
 
 @Override
 public void invoke(Request request, Response response) throws IOException, 
ServletException {
 String property;
-if (addConnectorPort) {
+if (getAddConnectorPort()) {
 property = request.getRequest().getRemoteAddr() + ";" + 
request.getConnector().getPort();
 } else {
 property = request.getRequest().getRemoteAddr();

Modified: tomcat/trunk/java/org/apache/catalina/valves/RemoteHostValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/RemoteHostValve.java?rev=1799895=1799894=1799895=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/RemoteHostValve.java (original)
+++ tomcat/trunk/java/org/apache/catalina/valves/RemoteHostValve.java Mon Jun 
26 12:39:15 2017
@@ -37,47 +37,12 @@ public final class RemoteHostValve exten
 private static final Log log = LogFactory.getLog(RemoteHostValve.class);
 
 
-// - Instance Variables
-
-/**
- * Flag deciding whether we add the server connector port to the property
- * compared in the filtering method. The port will be appended
- * using a ";" as a separator.
- */
-volatile boolean addConnectorPort = false;
-
-// - Properties
-
-
-/**
- * Get the flag deciding whether we add the server connector port to the
- * property compared in the filtering method. The port will be appended
- * using a ";" as a separator.
- * @return true to add the connector port
- */
-public boolean getAddConnectorPort() {
-return addConnectorPort;
-}
-
-
-/**
- * Set the flag deciding whether we add the server connector port to the
- * property compared in the filtering method. The port will be appended
- * using a ";" as a separator.
- *
- * @param addConnectorPort The new flag
- */
-public void setAddConnectorPort(boolean addConnectorPort) {
-this.addConnectorPort = addConnectorPort;
-}
-
-
 // - Public Methods
 
 @Override
 public void invoke(Request request, Response response) throws IOException, 
ServletException {
 String property;
-if (addConnectorPort) {
+if (getAddConnectorPort()) {
 property = request.getRequest().getRemoteHost() + ";" + 
request.getConnector().getPort();
 } else {
 property = request.getRequest().getRemoteHost();

Modified: tomcat/trunk/java/org/apache/catalina/valves/RequestFilterValve.java
URL: 

svn commit: r1799893 - in /tomcat/trunk: java/org/apache/catalina/valves/mbeans-descriptors.xml webapps/docs/changelog.xml

[markt]

Author: markt
Date: Mon Jun 26 12:35:46 2017
New Revision: 1799893

URL: http://svn.apache.org/viewvc?rev=1799893=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61215
Correctly define addConnectorPort and invalidAuthenticationWhenDeny in the 
mbean-descriptors.xml file for the org.apache.catalina.valves package so that 
the attributes are accessible via JMX.

Modified:
tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml?rev=1799893=1799892=1799893=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml 
(original)
+++ tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml Mon Jun 
26 12:35:46 2017
@@ -336,7 +336,6 @@
 
 
 
 
 
 
 
 
 
 http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1799893=1799892=1799893=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Mon Jun 26 12:35:46 2017
@@ -51,6 +51,13 @@
 61214: Remove deleted attribute servlets from
 the Context MBean description. Patch provided by Alexis Hassler. 
(markt)
   
+  
+61215: Correctly define addConnectorPort and
+invalidAuthenticationWhenDeny in the
+mbean-descriptors.xml file for the
+org.apache.catalina.valves package so that the attributes
+are accessible via JMX. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1799892 - in /tomcat/site/trunk: docs/migration-9.html xdocs/migration-9.xml

[violetagg]

Author: violetagg
Date: Mon Jun 26 12:35:04 2017
New Revision: 1799892

URL: http://svn.apache.org/viewvc?rev=1799892=rev
Log:
Add a new section about Logging. The log files will be kept 90 days by default.

Modified:
tomcat/site/trunk/docs/migration-9.html
tomcat/site/trunk/xdocs/migration-9.xml

Modified: tomcat/site/trunk/docs/migration-9.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration-9.html?rev=1799892=1799891=1799892=diff
==
--- tomcat/site/trunk/docs/migration-9.html (original)
+++ tomcat/site/trunk/docs/migration-9.html Mon Jun 26 12:35:04 2017
@@ -275,6 +275,9 @@
 
 Context configurations
 
+
+Logging
+
 
 
 
@@ -768,6 +771,19 @@ of Apache Tomcat.
 
   
 
+
+
+  
+
+Logging
+
+
+
+By default the log files will be kept 90 days and then removed from the file
+system.
+
+  
+
 
 
 

Modified: tomcat/site/trunk/xdocs/migration-9.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/migration-9.xml?rev=1799892=1799891=1799892=diff
==
--- tomcat/site/trunk/xdocs/migration-9.xml (original)
+++ tomcat/site/trunk/xdocs/migration-9.xml Mon Jun 26 12:35:04 2017
@@ -287,6 +287,13 @@ of Apache Tomcat.
 
   
 
+  
+
+By default the log files will be kept 90 days and then removed from the
+file system.
+
+  
+
 
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61214] NoSuchMethodException in JMX Proxy when accessing to Context MBeans

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61214

--- Comment #3 from Violeta Georgieva  ---
Hi Mark,

I think that this should be backported to 8.5.x as this functionality (JSR77)
was removed there also.

Regards,
Violeta

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] 8.0.x EOL - 30 June 2018

[Mark Thomas]

On 26/06/17 13:13, Coty Sutherland wrote:
> On Mon, Jun 26, 2017 at 5:51 AM, Mark Thomas  wrote:
>> On 26/06/17 08:12, Emmanuel Bourg wrote:
>>> Le 24/06/2017 à 17:25, Mark Thomas a écrit :
>>>
 If 8.5.x was a drop-in replacement would that make a difference?
>>>
>>> Yes that would help.
>>>
>>>
 And as a follow-up, what would need to change so 8.5.x was viewed a
 drop-in replacement?
>>>
>>> The removal of the BIO connectors was the main issue reported. It broke
>>> tomcatjss [1][2], dogtag [3][4] and jglobus [5].
>>
>> That is easily fixable. I've already got a patch to fix that I use as
>> $work that I can pull in.
> 
> That fix won't work for tomcatjss because they use the socket directly
> iirc. Short of putting the connector back tomcatjss has to be updated
> to work with NIO before it will work again.

:(

I don't see a full restoration of BIO happening in 8.5.x.

> I'm trying to make it easy
> on the Fedora folks by not updating to 8.5 until they have a solution
> for dogtag, so the sooner that is resolved (I think we've already made
> suggestions on how to fix it) the sooner I can update Fedora Rawhide
> to 8.5 and push for adoption there.

If there is anything we can do in Tomcat to make that process easier
then do speak up.

Mark


> 
 Anything else?
>>>
>>> I can't remember of other issues with the transition to 8.5.
>>
>> OK, that is pretty good news then.
>>
>> Assuming we get the BIO issue fixed, might a transition to 8.5.x be
>> looked at again? If any additional issues come up I'm sure the Tomcat
>> community would be willing to discuss options for resolving them.
>>
>> Mark
>>
>>>
>>> Emmanuel Bourg
>>>
>>>
>>> [1] https://github.com/dogtagpki/tomcatjss
>>> [2] https://bugs.debian.org/846677
>>> [3] http://pki.fedoraproject.org
>>> [4] https://bugs.debian.org/846714
>>> [5] https://bugs.debian.org/846723
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>>
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61214] NoSuchMethodException in JMX Proxy when accessing to Context MBeans

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61214

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Mark Thomas  ---
Thanks for the report and the PR. This has been fixed in trunk and will be
included in 9.0.0.M23 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat pull request #65: Fix bug #61214 : NoSuchMethodException in JMX Proxy...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/tomcat/pull/65


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1799885 - in /tomcat/trunk: java/org/apache/catalina/core/mbeans-descriptors.xml webapps/docs/changelog.xml

[markt]

Author: markt
Date: Mon Jun 26 12:14:27 2017
New Revision: 1799885

URL: http://svn.apache.org/viewvc?rev=1799885=rev
Log:
Remove deleted attribute servlets from the Context MBean 
description.
Patch provided by Alexis Hassler.
This closes #65.

Modified:
tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml?rev=1799885=1799884=1799885=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml (original)
+++ tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml Mon Jun 
26 12:14:27 2017
@@ -264,11 +264,6 @@
description="The J2EE Server this module is deployed on"
type="java.lang.String"/>
 
-
-
 

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1799885=1799884=1799885=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Mon Jun 26 12:14:27 2017
@@ -45,6 +45,14 @@
   issues do not "pop up" wrt. others).
 -->
 
+  
+
+  
+61214: Remove deleted attribute servlets from
+the Context MBean description. Patch provided by Alexis Hassler. 
(markt)
+  
+
+  
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] 8.0.x EOL - 30 June 2018

[Coty Sutherland]

On Mon, Jun 26, 2017 at 5:51 AM, Mark Thomas  wrote:
> On 26/06/17 08:12, Emmanuel Bourg wrote:
>> Le 24/06/2017 à 17:25, Mark Thomas a écrit :
>>
>>> If 8.5.x was a drop-in replacement would that make a difference?
>>
>> Yes that would help.
>>
>>
>>> And as a follow-up, what would need to change so 8.5.x was viewed a
>>> drop-in replacement?
>>
>> The removal of the BIO connectors was the main issue reported. It broke
>> tomcatjss [1][2], dogtag [3][4] and jglobus [5].
>
> That is easily fixable. I've already got a patch to fix that I use as
> $work that I can pull in.

That fix won't work for tomcatjss because they use the socket directly
iirc. Short of putting the connector back tomcatjss has to be updated
to work with NIO before it will work again. I'm trying to make it easy
on the Fedora folks by not updating to 8.5 until they have a solution
for dogtag, so the sooner that is resolved (I think we've already made
suggestions on how to fix it) the sooner I can update Fedora Rawhide
to 8.5 and push for adoption there.

>>> Anything else?
>>
>> I can't remember of other issues with the transition to 8.5.
>
> OK, that is pretty good news then.
>
> Assuming we get the BIO issue fixed, might a transition to 8.5.x be
> looked at again? If any additional issues come up I'm sure the Tomcat
> community would be willing to discuss options for resolving them.
>
> Mark
>
>>
>> Emmanuel Bourg
>>
>>
>> [1] https://github.com/dogtagpki/tomcatjss
>> [2] https://bugs.debian.org/846677
>> [3] http://pki.fedoraproject.org
>> [4] https://bugs.debian.org/846714
>> [5] https://bugs.debian.org/846723
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #65: Fix bug #61214 : NoSuchMethodException in JMX Proxy (Conte...

[markt-asf]

Github user markt-asf commented on the issue:

https://github.com/apache/tomcat/pull/65
  
My favourite kind of patch. It fixes a problem by deleting stuff. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1799884 - in /tomcat/site/trunk: docs/migration-85.html xdocs/migration-85.xml

[markt]

Author: markt
Date: Mon Jun 26 12:07:38 2017
New Revision: 1799884

URL: http://svn.apache.org/viewvc?rev=1799884=rev
Log:
Add info on new BIO handling for 8.5.x.

Modified:
tomcat/site/trunk/docs/migration-85.html
tomcat/site/trunk/xdocs/migration-85.xml

Modified: tomcat/site/trunk/docs/migration-85.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration-85.html?rev=1799884=1799883=1799884=diff
==
--- tomcat/site/trunk/docs/migration-85.html (original)
+++ tomcat/site/trunk/docs/migration-85.html Mon Jun 26 12:07:38 2017
@@ -295,7 +295,10 @@ of Apache Tomcat.
 
 The Java blocking IO implementation (BIO) for both HTTP and AJP has been
 removed. Users are recommended to switch to the Java non-blocking IO
-implementation (NIO).
+implementation (NIO). As of Tomcat 8.5.17, if a BIO Connector is explicitly
+configured, rather than failing to start the Connector, Tomcat will
+automatically switch the Connector to use the NIO implementation and log a
+warning.
 
   
 

Modified: tomcat/site/trunk/xdocs/migration-85.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/migration-85.xml?rev=1799884=1799883=1799884=diff
==
--- tomcat/site/trunk/xdocs/migration-85.xml (original)
+++ tomcat/site/trunk/xdocs/migration-85.xml Mon Jun 26 12:07:38 2017
@@ -29,7 +29,10 @@ of Apache Tomcat.
 
 The Java blocking IO implementation (BIO) for both HTTP and AJP has been
 removed. Users are recommended to switch to the Java non-blocking IO
-implementation (NIO).
+implementation (NIO). As of Tomcat 8.5.17, if a BIO Connector is explicitly
+configured, rather than failing to start the Connector, Tomcat will
+automatically switch the Connector to use the NIO implementation and log a
+warning.
 
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1799883 - in /tomcat/tc8.5.x/trunk: java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ webapps/docs/

[markt]

Author: markt
Date: Mon Jun 26 12:05:09 2017
New Revision: 1799883

URL: http://svn.apache.org/viewvc?rev=1799883=rev
Log:
 To ease migration from 8.0.x to 8.5.x, if the HTTP or AJP BIO connector is 
explicitly configured, rather than failing to start the connector because BIO 
has been removed, automatically switch to NIO and continue.
A warning will be logged to alert the user to the switch.

Added:
tomcat/tc8.5.x/trunk/java/org/apache/coyote/ajp/AjpProtocol.java   (with 
props)
tomcat/tc8.5.x/trunk/java/org/apache/coyote/http11/Http11Protocol.java   
(with props)
Modified:
tomcat/tc8.5.x/trunk/java/org/apache/coyote/ajp/LocalStrings.properties
tomcat/tc8.5.x/trunk/java/org/apache/coyote/http11/LocalStrings.properties
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Added: tomcat/tc8.5.x/trunk/java/org/apache/coyote/ajp/AjpProtocol.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/coyote/ajp/AjpProtocol.java?rev=1799883=auto
==
--- tomcat/tc8.5.x/trunk/java/org/apache/coyote/ajp/AjpProtocol.java (added)
+++ tomcat/tc8.5.x/trunk/java/org/apache/coyote/ajp/AjpProtocol.java Mon Jun 26 
12:05:09 2017
@@ -0,0 +1,37 @@
+/*
+ *  Licensed to the Apache Software Foundation (ASF) under one or more
+ *  contributor license agreements.  See the NOTICE file distributed with
+ *  this work for additional information regarding copyright ownership.
+ *  The ASF licenses this file to You under the Apache License, Version 2.0
+ *  (the "License"); you may not use this file except in compliance with
+ *  the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+package org.apache.coyote.ajp;
+
+import org.apache.juli.logging.Log;
+import org.apache.juli.logging.LogFactory;
+import org.apache.tomcat.util.res.StringManager;
+
+/**
+ * @deprecated This class will be removed in Tomcat 9.
+ */
+@Deprecated
+public class AjpProtocol extends AjpNioProtocol {
+
+private static final Log log = LogFactory.getLog(AjpProtocol.class);
+private static final StringManager sm = 
StringManager.getManager(AjpProtocol.class);
+
+
+public AjpProtocol() {
+super();
+log.warn(sm.getString("ajpprotocol.noBio"));
+}
+}
\ No newline at end of file

Propchange: tomcat/tc8.5.x/trunk/java/org/apache/coyote/ajp/AjpProtocol.java
--
svn:eol-style = native

Modified: 
tomcat/tc8.5.x/trunk/java/org/apache/coyote/ajp/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/coyote/ajp/LocalStrings.properties?rev=1799883=1799882=1799883=diff
==
--- tomcat/tc8.5.x/trunk/java/org/apache/coyote/ajp/LocalStrings.properties 
(original)
+++ tomcat/tc8.5.x/trunk/java/org/apache/coyote/ajp/LocalStrings.properties Mon 
Jun 26 12:05:09 2017
@@ -12,6 +12,11 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+ajpprotocol.noBio=The AJP BIO connector has been removed in Tomcat 8.5.x 
onwards. The AJP BIO connector configuration has been automatically switched to 
use the AJP NIO connector instead.
+ajpprotocol.noSSL=SSL is not supported with AJP. The SSL host configuration 
for [{0}] was ignored
+ajpprotocol.noUpgrade=Upgrade is not supported with AJP. The UpgradeProtocol 
configuration for [{0}] was ignored
+ajpprotocol.noUpgradeHandler=Upgrade is not supported with AJP. The 
HttpUpgradeHandler [{0}] can not be processed
+
 ajpprotocol.noSSL=SSL is not supported with AJP. The SSL host configuration 
for [{0}] was ignored
 ajpprotocol.noUpgrade=Upgrade is not supported with AJP. The UpgradeProtocol 
configuration for [{0}] was ignored
 ajpprotocol.noUpgradeHandler=Upgrade is not supported with AJP. The 
HttpUpgradeHandler [{0}] can not be processed

Added: tomcat/tc8.5.x/trunk/java/org/apache/coyote/http11/Http11Protocol.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/coyote/http11/Http11Protocol.java?rev=1799883=auto
==
--- tomcat/tc8.5.x/trunk/java/org/apache/coyote/http11/Http11Protocol.java 
(added)
+++ tomcat/tc8.5.x/trunk/java/org/apache/coyote/http11/Http11Protocol.java Mon 
Jun 26 12:05:09 2017
@@ -0,0 +1,37 @@
+/*
+ *  Licensed to the Apache Software Foundation (ASF) under one or more
+ *  

svn commit: r1799881 - /tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

[markt]

Author: markt
Date: Mon Jun 26 11:56:16 2017
New Revision: 1799881

URL: http://svn.apache.org/viewvc?rev=1799881=rev
Log:
Add release date for 8.5.16

Modified:
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml?rev=1799881=1799880=1799881=diff
==
--- tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Mon Jun 26 11:56:16 2017
@@ -69,7 +69,7 @@
 
   
 
-
+
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r20197 - /dev/tomcat/tomcat-8/v8.5.16/ /release/tomcat/tomcat-8/v8.5.16/

[markt]

Author: markt
Date: Mon Jun 26 11:54:54 2017
New Revision: 20197

Log:
Release Apache Tomcat 8.5.16

Added:
release/tomcat/tomcat-8/v8.5.16/
  - copied from r20196, dev/tomcat/tomcat-8/v8.5.16/
Removed:
dev/tomcat/tomcat-8/v8.5.16/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[VOTE][RESULT] Release Apache Tomcat 8.5.16

[Mark Thomas]

The following votes were cast:

Binding:
+1: violetagg, csutherl, rjung, fschumacher, huxing, markt

No other votes were case.

The vote therefore passes.

Thanks to everyone who contributed to this release.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61217] Tomcat does not send all buffer in case of response was modify

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61217

--- Comment #3 from tzachi.str...@behalf.com ---
Guys thank you for the quick response! 

Chuck,
before i opened the bug i saw source code of version 44 and
IdentityOutputFilter class have the same logic as 33. 
i will try to run it with 8.0.44.  

Mark,

it is a good question.

but before i answer that i want to share the info that i am running embedded
tomcat version 8.0.33 via spring boot. 

as you can see from below stack trace spring invoke my controller and flush the
response right after that.
so IdentityOutputFilter initialize at that point.

Then the thread return back to my filter that responsible to modify it and
write it again. 
response.getOriginalResponse().getWriter().write(modifyResponseContent);
The IdentityOutputFilter instance is already initialized with remaining of the
original response.

StackTrace:
http-nio--exec-5@12102" daemon prio=5 tid=0x19 nid=NA runnable
  java.lang.Thread.State: RUNNABLE
  at
org.apache.coyote.http11.filters.IdentityOutputFilter.setResponse(IdentityOutputFilter.java:118)
  at
org.apache.coyote.http11.AbstractOutputBuffer.addActiveFilter(AbstractOutputBuffer.java:200)
  at
org.apache.coyote.http11.AbstractHttp11Processor.prepareResponse(AbstractHttp11Processor.java:1492)
  at
org.apache.coyote.http11.AbstractHttp11Processor.action(AbstractHttp11Processor.java:739)
  at org.apache.coyote.Response.action(Response.java:179)
  at org.apache.coyote.Response.sendHeaders(Response.java:350)
  at
org.apache.catalina.connector.OutputBuffer.doFlush(OutputBuffer.java:335)
  at
org.apache.catalina.connector.OutputBuffer.flush(OutputBuffer.java:317)
  at
org.apache.catalina.connector.Response.flushBuffer(Response.java:496)
  at
org.apache.catalina.connector.ResponseFacade.flushBuffer(ResponseFacade.java:318)
  at
javax.servlet.ServletResponseWrapper.flushBuffer(ServletResponseWrapper.java:176)
  at
com.zazma.bewebapp.filter.ResponseWrapper.flushBuffer(ResponseWrapper.java:70)
  at
org.springframework.http.server.ServletServerHttpResponse.flush(ServletServerHttpResponse.java:96)
  at
org.springframework.web.servlet.mvc.method.annotation.HttpEntityMethodProcessor.handleReturnValue(HttpEntityMethodProcessor.java:206)
  at
org.springframework.web.method.support.HandlerMethodReturnValueHandlerComposite.handleReturnValue(HandlerMethodReturnValueHandlerComposite.java:81)

Questions:
1. In case the controller return JSON (without header Content-Length)it execute
ChunkedOutputFilter. 
1.1 what is the different between dose output filter?
1.2 why in IdentityOutputFilter ignore the bytes that bigger than
remaining
// The chunk is longer than the number of bytes
remaining
// in the body; changing the chunk length to the number
// of bytes remaining
chunk.setBytes(chunk.getBytes(), chunk.getStart(),
(int) remaining);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Tagging Tomcat 8.0/7.0

[Violeta Georgieva]

Hi,

I'm planning to tag Tomcat 8.0/7.0 later today.

Regards,
Violeta

Re: [VOTE] Release Apache Tomcat 8.5.16

[Mark Thomas]

On 21/06/17 22:37, Mark Thomas wrote:
> The proposed Apache Tomcat 8.5.16 release is now available for voting.
> 
> The major changes compared to the 8.5.16 release are:
> 
> - Add a new JULI FileHandler configuration for specifying the maximum
>   number of days to keep the log files. By default the log files will be
>   kept 90 days.
> 
> - Improvements to enable the Manager and HostManager to work in the
>   default configuration when working under a security manager
> 
> - Introduce new API o.a.tomcat.websocket.WsSession#suspend/
>   o.a.tomcat.websocket.WsSession#resume that can be used to
>   suspend/resume reading of the incoming messages.
> 
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.16/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1138/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_16/
> 
> The proposed 8.5.16 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.16

Tests passed with NIO, NIO2 and APR/native on Windows, Linux and OSX.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1799870 - /tomcat/trunk/webapps/docs/changelog.xml

[markt]

Author: markt
Date: Mon Jun 26 10:51:20 2017
New Revision: 1799870

URL: http://svn.apache.org/viewvc?rev=1799870=rev
Log:
Add release date for 9.0.0.M22

Modified:
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1799870=1799869=1799870=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Mon Jun 26 10:51:20 2017
@@ -81,7 +81,7 @@
 
   
 
-
+
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r20194 - /dev/tomcat/tomcat-9/v9.0.0.M22/ /release/tomcat/tomcat-9/v9.0.0.M22/

[markt]

Author: markt
Date: Mon Jun 26 10:49:27 2017
New Revision: 20194

Log:
Release Tomcat 9.0.0.M22

Added:
release/tomcat/tomcat-9/v9.0.0.M22/
  - copied from r20193, dev/tomcat/tomcat-9/v9.0.0.M22/
Removed:
dev/tomcat/tomcat-9/v9.0.0.M22/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[VOTE][RESULT] Release Apache Tomcat 9.0.0.M22

[Mark Thomas]

The following votes were cast:

Binding:
+1: violetagg, csutherl, huxing, rjung, fschumacher, markt

No other votes were cast.

The release vote therefore passes.

Thanks to everyone who contributed towards this release.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.0.M22

[Mark Thomas]

On 23/06/17 07:24, Huxing Zhang wrote:
> Hi,
> 
> The proposed 9.0.0.M22 release is:
> [ ] Broken - do not release
> [ X ] Alpha - go ahead and release as 9.0.0.M22
> 
> Unit test passed.
> Our test web application works fine.
> 
> 1. There is a typo in trailers.ResponseTrailers, I will fix that later.
> 2. Actually I have a concern of the trailer field implementation. Should we 
> add an extra whitespace between the trailer field name and trailer field, 
> just to keep align with the head field format?

We should be consistent so no objections to the space being added.

Mark


> 
> In rfc7230 section 4.1.2 says the white space is optional.
> header-field   = field-name ":" OWS field-value OWS
> 
> But right now the format is inconsistent between header and trailer field.
> 
> Examples: 
> 
> Escape character is '^]'.
> GET /examples/servlets/trailers/response HTTP/1.1
> Host: hsf.taobao.net:8180
> User-Agent: curl/7.47.0
> Accept: */*
> 
> HTTP/1.1 200
> Content-Type: text/plain;charset=UTF-8
> Transfer-Encoding: chunked
> Date: Fri, 23 Jun 2017 05:49:14 GMT
> 
> 2b
> This reponse should include trailer fields.
> 0
> x-trailer-2:Trailer value two
> x-trailer-1:Trailer value one
> 
> BTW, Jetty[1] has an white space between trailer field name and value. 
> https://webtide.com/http-trailers-in-jetty/
> 
> --
> From:Mark Thomas 
> Time:2017 Jun 21 (Wed) 22:18
> To:Tomcat Developers List 
> Subject:[VOTE] Release Apache Tomcat 9.0.0.M22
> 
> 
> The proposed Apache Tomcat 9.0.0.M22 release is now available for voting.
> 
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
> 
> The major changes compared to the 9.0.0.M21 release are:
> 
> - Add a new JULI FileHandler configuration for specifying the maximum
>   number of days to keep the log files. By default the log files will be
>   kept 90 days.
> 
> - Update the Servlet 4.0 implementation to add support for setting
>   trailer fields for HTTP responses.
> 
> - When pre-compiling with JspC, report all compilation errors rather
>   than stopping after the first error.
> 
> Along with lots of other bug fixes and improvements
> 
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M22/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1137/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M22/
> 
> The proposed 9.0.0.M22 release is:
> [ ] Broken - do not release
> [ ] Alpha - go ahead and release as 9.0.0.M22
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.0.M22

[Mark Thomas]

On 21/06/17 15:18, Mark Thomas wrote:
> The proposed Apache Tomcat 9.0.0.M22 release is now available for voting.
> 
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
> 
> The major changes compared to the 9.0.0.M21 release are:
> 
> - Add a new JULI FileHandler configuration for specifying the maximum
>   number of days to keep the log files. By default the log files will be
>   kept 90 days.
> 
> - Update the Servlet 4.0 implementation to add support for setting
>   trailer fields for HTTP responses.
> 
> - When pre-compiling with JspC, report all compilation errors rather
>   than stopping after the first error.
> 
> Along with lots of other bug fixes and improvements
> 
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M22/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1137/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M22/
> 
> The proposed 9.0.0.M22 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 9.0.0.M22

Tests passed for NIO, NIO2 and APR/native on Windows, Linux and OSX.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] 8.0.x EOL - 30 June 2018

[Mark Thomas]

On 26/06/17 03:19, Huxing Zhang wrote:
>> The only thing I can think of is lack of support for the BIO connectors.
>> I have an easy fix for that if there is interest. Anything else?
> 
> Also the RFC6265CookieProcessor.  We've experienced several incompatibility 
> with LegacyCookieProcessor.
> For example,  cookies with leading dot is no longer valid in 
> RFC6265CookieProcessor.

Since RFC6265 is clear that the leading '.' should not be there, I'm
reluctant to introduce a change to allow it. Unsurprisingly, it is IE
that needs the leading '.' in some cases.

We have made exceptions for IE in the past. Do we want to do that here?
LegacyCookieProcessor remains an option for those that need to support
this particular quirk of IE.

Personally, I'd prefer not to introduce a new option but I could be
persuaded to support such a change if there was sufficient demand.

Mark


> --
> From:Mark Thomas 
> Time:2017 Jun 24 (Sat) 23:26
> To:Tomcat Developers List 
> Subject:Re: [VOTE] 8.0.x EOL - 30 June 2018
> 
> 
> On 23/06/17 23:17, Emmanuel Bourg wrote:
>> Le 23/06/2017 à 21:15, Christopher Schultz a écrit :
>>
>>> The idea was to encourage package repository maintainers to migrate to
>>> Tomcat 8.5. If we never sundown Tomcat 8.0, they'll never move (witness
>>> the presence of Tomcat 6.0 still lurking around half the Internet).
>>
>> As far as Debian is concerned, the migration to Tomcat 8.5 did happen in
>> Debian 9. But Debian 8 users are stuck with Tomcat 8.0.x until June
>> 2020. Tomcat 8.5 isn't a drop-in replacement for Tomcat 8.0
>> unfortunately, so it's a bit difficult to push this upgrade in a stable
>> distribution.
> 
> If 8.5.x was a drop-in replacement would that make a difference?
> 
> And as a follow-up, what would need to change so 8.5.x was viewed a
> drop-in replacement?
> 
> The only thing I can think of is lack of support for the BIO connectors.
> I have an easy fix for that if there is interest. Anything else?
> 
> Mark
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] 8.0.x EOL - 30 June 2018

[Mark Thomas]

On 26/06/17 08:12, Emmanuel Bourg wrote:
> Le 24/06/2017 à 17:25, Mark Thomas a écrit :
> 
>> If 8.5.x was a drop-in replacement would that make a difference?
> 
> Yes that would help.
> 
> 
>> And as a follow-up, what would need to change so 8.5.x was viewed a
>> drop-in replacement?
> 
> The removal of the BIO connectors was the main issue reported. It broke
> tomcatjss [1][2], dogtag [3][4] and jglobus [5].

That is easily fixable. I've already got a patch to fix that I use as
$work that I can pull in.

>> Anything else?
> 
> I can't remember of other issues with the transition to 8.5.

OK, that is pretty good news then.

Assuming we get the BIO issue fixed, might a transition to 8.5.x be
looked at again? If any additional issues come up I'm sure the Tomcat
community would be willing to discuss options for resolving them.

Mark

> 
> Emmanuel Bourg
> 
> 
> [1] https://github.com/dogtagpki/tomcatjss
> [2] https://bugs.debian.org/846677
> [3] http://pki.fedoraproject.org
> [4] https://bugs.debian.org/846714
> [5] https://bugs.debian.org/846723
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61224] GlobalRequestProcessor mbeans should be read-only

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61224

--- Comment #1 from Alexis Hassler  ---
PR #68

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat pull request #68: Fix #61224 - Make the GlobalRequestProcessor mbeans...

[hasalex]

GitHub user hasalex opened a pull request:

https://github.com/apache/tomcat/pull/68

Fix #61224 - Make the GlobalRequestProcessor mbeans read-only



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hasalex/tomcat GlobalRequestProcessor

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomcat/pull/68.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #68


commit 54156d4a63ac60cf10f83758117a53ea93f317b7
Author: Alexis Hassler 
Date:   2017-06-26T06:49:04Z

Fix #61224 - Make the GlobalRequestProcessor mbeans read-only




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] 8.0.x EOL - 30 June 2018

[Emmanuel Bourg]

Le 24/06/2017 à 17:25, Mark Thomas a écrit :

> If 8.5.x was a drop-in replacement would that make a difference?

Yes that would help.


> And as a follow-up, what would need to change so 8.5.x was viewed a
> drop-in replacement?

The removal of the BIO connectors was the main issue reported. It broke
tomcatjss [1][2], dogtag [3][4] and jglobus [5].


> Anything else?

I can't remember of other issues with the transition to 8.5.

Emmanuel Bourg


[1] https://github.com/dogtagpki/tomcatjss
[2] https://bugs.debian.org/846677
[3] http://pki.fedoraproject.org
[4] https://bugs.debian.org/846714
[5] https://bugs.debian.org/846723

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org