[Bug 61164] Add %X option to access log for connection status

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61164

--- Comment #1 from Zemian Deng  ---
Hi there,

I have created a PR here (https://github.com/apache/tomcat/pull/70) for this
enhancement. Let me know what you think.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat pull request #70: Add new accesslog valve pattern %X for recording co...

[zemian]

GitHub user zemian opened a pull request:

https://github.com/apache/tomcat/pull/70

Add new accesslog valve pattern %X for recording connection status

- https://bz.apache.org/bugzilla/show_bug.cgi?id=61164

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zemian/tomcat zemian_61164-accesslog

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomcat/pull/70.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #70


commit 63e749b4d57c9d38ce2b6dc3e8fd54f200f60d61
Author: Zemian Deng 
Date:   2017-07-21T03:10:53Z

Add new accesslog valve pattern %X for recording connection status

- https://bz.apache.org/bugzilla/show_bug.cgi?id=61164




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

RE: [VOTE] Release Apache Tomcat 8.5.18

[George Stanchev]

Mark,

Can you look at my comments at the user's mailing list on the original thread 
about the encoding issue. The issue seems to have resurfaced in a different 
form.

George

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.5.18

[Rémy Maucherat]

On Tue, Jul 18, 2017 at 3:58 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.18 release is now available for voting.
>
> The major changes compared to the 8.5.16 release are:
>
> - Enable TLS connectors to use Java key stores that contain multiple
>   keys where each key has a separate password. Based on a patch by Frank
>   Taffelt.
>
> - Make asynchronous error handling more robust. In particular ensure
>   that onError() is called for any registered AsyncListeners after an
>   I/O error on a non-container thread.
>
> - Sync SSL session access for the APR connector to prevent errors when
>   accessing the session.
>
>
> Along with lots of other bug fixes and improvements.
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.18/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1144/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_18/
>
> The proposed 8.5.18 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.18
>
> Rémy

Re: [VOTE] Release Apache Tomcat 9.0.0.M24

[Rémy Maucherat]

On Tue, Jul 18, 2017 at 1:43 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.0.M24 release is now available for voting.
>
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
> Note that the 9.0.0.M23 release vote was cancelled due to a regression.
>
> The major changes compared to the 9.0.0.M22 release are:
>
> - Correct a regression in 9.0.0.M22 that prevented Tomcat from shutting
>   down cleanly.
>
> - Add LoadBalancerDrainingValve, a Valve designed to reduce the amount
>   of time required for a node to drain its authenticated users.
>
> - When generating JSP runtime error messages that quote the relevant JSP
>   source code, switch from using the results of the JSP page parsing
>   process to using the JSR 045 source map data to identify the correct
>   part of the JSP source from the stack trace. This significantly
>   reduces the memory footprint of Jasper in development mode, provides a
>   small performance improvement for error page generation and enables
>   source quotes to continue to be provided after a Tomcat restart.
>
> - Add support for a Tomcat specific deployment descriptor,
>   /WEB-INF/tomcat-web.xml
>
> Along with lots of other bug fixes and improvements.
>
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M24/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1143/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M24/
>
> The proposed 9.0.0.M24 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 9.0.0.M24
>
> Rémy

Re: [VOTE] Release Apache Tomcat 8.5.18

[Mark Thomas]

On 20/07/17 19:09, Christopher Schultz wrote:
> Mark,
> 
> On 7/18/17 9:58 AM, Mark Thomas wrote:
>> The proposed Apache Tomcat 8.5.18 release is now available for
>> voting.



>> The proposed 8.5.18 release is: [ ] Broken - do not release [?]
>> Stable - go ahead and release as 8.5.18
> 
> Works fine for me in a development environment. *There was a unit test
> failure I've never seen before.* Someone who knows more about this
> particular test might want to weigh-in on whether or not this is a
> problem.
> 
> Details below.



> For TestVirtualContext (which only failed for NIO2, oddly), here are
> the errors:
> 
> 20-Jul-2017 12:10:16.422 SEVERE [http-nio2-127.0.0.1-auto-2-exec-2]
> org.apache.catalina.core.StandardHostValve.invoke Exception Processing
> null
>  java.lang.NullPointerException
> at
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValv
> e.java:236)

OK. That is in the exception handling. That is odd to start with since
we don't expect this test to enter that code. As to what might be
triggering the NPE, it could be any of:
- container
- container.getLogger()
- wrapper
- context

None of which should ever be null at that point.



> 20-Jul-2017 12:10:16.427 SEVERE [http-nio2-127.0.0.1-auto-2-exec-2]
> org.apache.coyote.http11.Http11Processor.service Error processing reques
> t
>  java.lang.NullPointerException
> at
> org.apache.catalina.connector.Request.notifyAttributeAssigned(Request.ja
> va:1555)

That suggests context is null.



> 20-Jul-2017 12:10:16.440 SEVERE [http-nio2-127.0.0.1-auto-2-exec-2]
> org.apache.coyote.http11.Http11Processor.endRequest Error finishing
> response
>  java.lang.NullPointerException
> at
> org.apache.coyote.http11.Http11OutputBuffer.commit(Http11OutputBuffer.ja
> va:368)

That suggests socketWrapper is null.



> ... and then finally:
> Testcase: testVirtualClassLoader took 14.813 sec
> Caused an ERROR
> Read timed out
> java.net.SocketTimeoutException: Read timed out
> at java.net.SocketInputStream.socketRead0(Native Method)

Hmm. The test should complete in a couple of seconds.



> org.apache.catalina.loader.TestVirtualContext.testVirtualClassLoader(Tes
> tVirtualContext.java:105)

and finally that is the first request made to Tomcat as part of this test.

I'm guessing that this failure is not repeatable..

Given everything is on localhost, a network glitch seems unlikely. Some
sort of threading / timing issue seems more likely.

If it isn't repeatable, I'm not sure there is a lot we can do about
this. It suggests that there might be an issue somewhere - maybe in the
start-up code - but it could equally be an issue with the test code.

I'd be tempted to note this but carry on with the release unless it is
repeatable.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.0.M24

[Felix Schumacher]

Am 18.07.2017 um 13:43 schrieb Mark Thomas:

The proposed Apache Tomcat 9.0.0.M24 release is now available for voting.

This is a milestone release for the 9.0.x branch. It should be
noted that, as a milestone release:
- Servlet 4.0 is not finalised
- The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0

Note that the 9.0.0.M23 release vote was cancelled due to a regression.

The major changes compared to the 9.0.0.M22 release are:

- Correct a regression in 9.0.0.M22 that prevented Tomcat from shutting
   down cleanly.

- Add LoadBalancerDrainingValve, a Valve designed to reduce the amount
   of time required for a node to drain its authenticated users.

- When generating JSP runtime error messages that quote the relevant JSP
   source code, switch from using the results of the JSP page parsing
   process to using the JSR 045 source map data to identify the correct
   part of the JSP source from the stack trace. This significantly
   reduces the memory footprint of Jasper in development mode, provides a
   small performance improvement for error page generation and enables
   source quotes to continue to be provided after a Tomcat restart.

- Add support for a Tomcat specific deployment descriptor,
   /WEB-INF/tomcat-web.xml

Along with lots of other bug fixes and improvements.


For full details, see the changelog:
http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M24/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1143/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M24/

The proposed 9.0.0.M24 release is:
[ ] Broken - do not release
[x] Alpha - go ahead and release as 9.0.0.M24


Felix



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.5.18

[Felix Schumacher]

Am 18.07.2017 um 15:58 schrieb Mark Thomas:

The proposed Apache Tomcat 8.5.18 release is now available for voting.

The major changes compared to the 8.5.16 release are:

- Enable TLS connectors to use Java key stores that contain multiple
   keys where each key has a separate password. Based on a patch by Frank
   Taffelt.

- Make asynchronous error handling more robust. In particular ensure
   that onError() is called for any registered AsyncListeners after an
   I/O error on a non-container thread.

- Sync SSL session access for the APR connector to prevent errors when
   accessing the session.


Along with lots of other bug fixes and improvements.


It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.18/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1144/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_18/

The proposed 8.5.18 release is:
[ ] Broken - do not release
[x] Stable - go ahead and release as 8.5.18


Felix


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 52671] NIO Connector: Exception invoking method readBufSize / writeBufSize in the JMX Proxy Servlet

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=52671

--- Comment #5 from ekoch...@gmail.com  ---
More info ...

It happens when I try to get:
ThreadPool.ajp-nio-8009.readBufSize
or
ThreadPool.ajp-nio-8009.writeBufSize

Thanks,
Evgeny Kochnev

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 52671] NIO Connector: Exception invoking method readBufSize / writeBufSize in the JMX Proxy Servlet

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=52671

--- Comment #4 from ekoch...@gmail.com  ---
and ...
2017-07-20 14:15:37,491 ERROR [chedulerFactoryBean#0_Worker-9]
[shc.ecom.sywlocal.monitoring.HTTPReporter] - Got exception: 
javax.management.RuntimeOperationsException: Exception invoking method
readBufSize
at
org.apache.tomcat.util.modeler.BaseModelMBean.getAttribute(BaseModelMBean.java:196)
at
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:647)
at
com.sun.jmx.mbeanserver.JmxMBeanServer.getAttribute(JmxMBeanServer.java:678)
at
com.codahale.metrics.JmxAttributeGauge.getValue(JmxAttributeGauge.java:44)
at
com.shc.ecom.sywlocal.monitoring.HTTPReporter.createMeasurementObject(HTTPReporter.java:123)
at
com.shc.ecom.sywlocal.monitoring.HTTPReporter.createWebContainerData(HTTPReporter.java:363)
at
com.shc.ecom.sywlocal.monitoring.HTTPReporter.createMeasurementObjects(HTTPReporter.java:151)
at
com.shc.ecom.sywlocal.monitoring.HTTPReporter.report(HTTPReporter.java:89)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.springframework.util.MethodInvoker.invoke(MethodInvoker.java:269)
at
org.springframework.scheduling.quartz.MethodInvokingJobDetailFactoryBean$MethodInvokingJob.executeInternal(MethodInvokingJobDetailFactoryBean.java:312)
at
org.springframework.scheduling.quartz.QuartzJobBean.execute(QuartzJobBean.java:114)
at org.quartz.core.JobRunShell.run(JobRunShell.java:202)
at
org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:525)
Caused by: java.lang.NullPointerException
at
org.apache.tomcat.util.net.SocketProperties.getRxBufSize(SocketProperties.java:272)
at
org.apache.tomcat.util.net.NioEndpoint.getReadBufSize(NioEndpoint.java:497)
at sun.reflect.GeneratedMethodAccessor121.invoke(Unknown Source)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.apache.tomcat.util.modeler.BaseModelMBean.getAttribute(BaseModelMBean.java:189)
... 16 more

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 52671] NIO Connector: Exception invoking method readBufSize / writeBufSize in the JMX Proxy Servlet

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=52671

--- Comment #3 from ekoch...@gmail.com  ---
Hi,

It's strange but I've got almost the same exception but at Tomcat 8.0.33.

2017-07-20 14:18:45,572 ERROR [chedulerFactoryBean#0_Worker-9]
[shc.ecom.sywlocal.monitoring.HTTPReporter] - Got exception: 
javax.management.RuntimeOperationsException: Exception invoking method
writeBufSize
at
org.apache.tomcat.util.modeler.BaseModelMBean.getAttribute(BaseModelMBean.java:196)
at
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:647)
at
com.sun.jmx.mbeanserver.JmxMBeanServer.getAttribute(JmxMBeanServer.java:678)
at
com.codahale.metrics.JmxAttributeGauge.getValue(JmxAttributeGauge.java:44)
at
com.shc.ecom.sywlocal.monitoring.HTTPReporter.createMeasurementObject(HTTPReporter.java:123)
at
com.shc.ecom.sywlocal.monitoring.HTTPReporter.createWebContainerData(HTTPReporter.java:363)
at
com.shc.ecom.sywlocal.monitoring.HTTPReporter.createMeasurementObjects(HTTPReporter.java:151)
at
com.shc.ecom.sywlocal.monitoring.HTTPReporter.report(HTTPReporter.java:89)
at sun.reflect.GeneratedMethodAccessor151.invoke(Unknown Source)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.springframework.util.MethodInvoker.invoke(MethodInvoker.java:269)
at
org.springframework.scheduling.quartz.MethodInvokingJobDetailFactoryBean$MethodInvokingJob.executeInternal(MethodInvokingJobDetailFactoryBean.java:312)
at
org.springframework.scheduling.quartz.QuartzJobBean.execute(QuartzJobBean.java:114)
at org.quartz.core.JobRunShell.run(JobRunShell.java:202)
at
org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:525)
Caused by: java.lang.NullPointerException
at
org.apache.tomcat.util.net.SocketProperties.getTxBufSize(SocketProperties.java:300)
at
org.apache.tomcat.util.net.NioEndpoint.getWriteBufSize(NioEndpoint.java:493)
at sun.reflect.GeneratedMethodAccessor147.invoke(Unknown Source)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.apache.tomcat.util.modeler.BaseModelMBean.getAttribute(BaseModelMBean.java:189)
... 15 more

Will create proper bug for Tomcat 8.0.33 later.

Thanks,
Evgeny Kochnev

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.5.18

[Christopher Schultz]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Mark,

On 7/18/17 9:58 AM, Mark Thomas wrote:
> The proposed Apache Tomcat 8.5.18 release is now available for
> voting.
> 
> The major changes compared to the 8.5.16 release are:
> 
> - Enable TLS connectors to use Java key stores that contain
> multiple keys where each key has a separate password. Based on a
> patch by Frank Taffelt.
> 
> - Make asynchronous error handling more robust. In particular
> ensure that onError() is called for any registered AsyncListeners
> after an I/O error on a non-container thread.
> 
> - Sync SSL session access for the APR connector to prevent errors
> when accessing the session.
> 
> 
> Along with lots of other bug fixes and improvements.
> 
> 
> It can be obtained from: 
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.18/ The
> Maven staging repo is: 
> https://repository.apache.org/content/repositories/orgapachetomcat-114
4/
>
> 
The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_18/
> 
> The proposed 8.5.18 release is: [ ] Broken - do not release [?]
> Stable - go ahead and release as 8.5.18

Works fine for me in a development environment. *There was a unit test
failure I've never seen before.* Someone who knows more about this
particular test might want to weigh-in on whether or not this is a
problem.

Details below.

- -chris

* Environment
*  Java (build): java version "1.8.0_101" Java(TM) SE Runtime
Environment (build 1.8.0_101-b13) Java HotSpot(TM) 64-Bit Server VM
(build 25.101-b13, mixed mode)
*  Java (test): java version "1.8.0_101" Java(TM) SE Runtime
Environment (build 1.8.0_101-b13) Java HotSpot(TM) 64-Bit Server VM
(build 25.101-b13, mixed mode)
*  OS:   Linux 2.6.32-312-ec2 x86_64
*  cc:   cc (Debian 4.7.2-5) 4.7.2
*  make: GNU Make 3.81
*  OpenSSL:  1.0.2k
*  APR:  1.4.6
*
* Valid MD5 signature for apache-tomcat-8.5.18.zip
* Valid GPG signature for apache-tomcat-8.5.18.zip
* Valid MD5 signature for apache-tomcat-8.5.18.tar.gz
* Valid GPG signature for apache-tomcat-8.5.18.tar.gz
* Valid MD5 signature for apache-tomcat-8.5.18.exe
* Valid GPG signature for apache-tomcat-8.5.18.exe
* Valid MD5 signature for apache-tomcat-8.5.18-src.zip
* Valid GPG signature for apache-tomcat-8.5.18-src.zip
* Valid MD5 signature for apache-tomcat-8.5.18-src.tar.gz
* Valid GPG signature for apache-tomcat-8.5.18-src.tar.gz
*
* Binary Zip and tarball: Same
* Source Zip and tarball: !! NOT SAME

Konstantin pointed-out that the newline-rewriting process in the build
is not working properly. No reason to block the release.

* Building dependencies returned: 0
* tcnative builds cleanly
* Tomcat builds cleanly
* Junit Tests: FAILED

JUnit test case failures are almost all expected: (a) no multicast and
(b) cipher tests are highly dependent upon environment.

For TestVirtualContext (which only failed for NIO2, oddly), here are
the errors:

20-Jul-2017 12:10:16.422 SEVERE [http-nio2-127.0.0.1-auto-2-exec-2]
org.apache.catalina.core.StandardHostValve.invoke Exception Processing
null
 java.lang.NullPointerException
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValv
e.java:236)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValv
e.java:96)
at
org.apache.catalina.authenticator.AuthenticatorBase.invoke(Authenticator
Base.java:478)
at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java
:140)
at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java
:80)
at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.
java:87)
at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:3
42)
at
org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:79
9)
at
org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.
java:66)
at
org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractPro
tocol.java:868)
at
org.apache.tomcat.util.net.Nio2Endpoint$SocketProcessor.doRun(Nio2Endpoi
nt.java:1697)
at
org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.j
ava:49)
at
org.apache.tomcat.util.net.AbstractEndpoint.processSocket(AbstractEndpoi
nt.java:946)
at
org.apache.tomcat.util.net.Nio2Endpoint$Nio2SocketWrapper$4.completed(Ni
o2Endpoint.java:626)
at
org.apache.tomcat.util.net.Nio2Endpoint$Nio2SocketWrapper$4.completed(Ni
o2Endpoint.java:604)
at sun.nio.ch.Invoker.invokeUnchecked(Invoker.java:126)
at sun.nio.ch.Invoker$2.run(Invoker.java:218)
at
sun.nio.ch.AsynchronousChannelGroupImpl$1.run(AsynchronousChannelGroupIm
pl.java:112)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.jav
a:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.ja
va:617)
at

Re: [VOTE] Release Apache Tomcat 8.5.18

[Mark Thomas]

On 18/07/17 14:58, Mark Thomas wrote:



> The proposed 8.5.18 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.18

Unit tests pass for NIO, NIO2 and APR on Windows, OSX and Linux all
using Tomcat Native 1.2.12.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.0.M24

[Mark Thomas]

On 18/07/17 12:43, Mark Thomas wrote:



> The proposed 9.0.0.M24 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 9.0.0.M24

Unit tests pass for NIO, NIO2 and APR on Windows, OSX and Linux all
using Tomcat Native 1.2.12.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60963] Optimize class loading for unpackWARs=false case

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60963

--- Comment #25 from Mark Thomas  ---
Having looked into this further, the only way I could see to improve things
significantly was to pre-process the JAR files from a packed WAR and populate
the cache with the contents of the JARs. This wasn't a great solution for
several reasons:
- It would have required a fair amount of new code and/or a lot of refactoring
- The memory requirements for the cache would increase. For the solution to be
useful, all the contents of all the JARs need to reside in the cache.

In the end, I opted to implement a new WebResourceRoot implementation,
ExtractingRoot that returns to the 7.0.x idea of extracting the JAR files into
the work directory. This will be included in 9.0.0.M25 onwards. Assuming no
issues are identified, I'll back-port it to 8.5.x and 8.0.x. An open question
is whether the overall refactoring of resource handling is sufficient to
protect against the file locking issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1802490 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/webresources/ webapps/docs/ webapps/docs/config/

[markt]

Author: markt
Date: Thu Jul 20 14:13:48 2017
New Revision: 1802490

URL: http://svn.apache.org/viewvc?rev=1802490=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60963
Add a new WebResourceRoot implementation that extracts JARs to the work 
directory for improved performance when deploying packed WAR files.

Added:
tomcat/trunk/java/org/apache/catalina/webresources/ExtractingRoot.java   
(with props)
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
tomcat/trunk/java/org/apache/catalina/webresources/LocalStrings.properties
tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/config/host.xml
tomcat/trunk/webapps/docs/config/resources.xml

Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardContext.java?rev=1802490=1802489=1802490=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardContext.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Thu Jul 20 
14:13:48 2017
@@ -4864,6 +4864,9 @@ public class StandardContext extends Con
 namingResources.start();
 }
 
+// Post work directory
+postWorkDirectory();
+
 // Add missing components as necessary
 if (getResources() == null) {   // (1) Required by Loader
 if (log.isDebugEnabled())
@@ -4894,9 +4897,6 @@ public class StandardContext extends Con
 // Initialize character set mapper
 getCharsetMapper();
 
-// Post work directory
-postWorkDirectory();
-
 // Validate required extensions
 boolean dependencyCheck = true;
 try {

Added: tomcat/trunk/java/org/apache/catalina/webresources/ExtractingRoot.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/webresources/ExtractingRoot.java?rev=1802490=auto
==
--- tomcat/trunk/java/org/apache/catalina/webresources/ExtractingRoot.java 
(added)
+++ tomcat/trunk/java/org/apache/catalina/webresources/ExtractingRoot.java Thu 
Jul 20 14:13:48 2017
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.catalina.webresources;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+
+import javax.servlet.ServletContext;
+
+import org.apache.catalina.LifecycleException;
+import org.apache.catalina.WebResource;
+import org.apache.catalina.startup.ExpandWar;
+import org.apache.catalina.util.IOTools;
+import org.apache.tomcat.util.res.StringManager;
+
+/**
+ * If the main resources are packaged as a WAR file then any JARs will be
+ * extracted to the work directory and used from there.
+ */
+public class ExtractingRoot extends StandardRoot {
+
+private static final StringManager sm = 
StringManager.getManager(ExtractingRoot.class);
+
+private static final String APPLICATION_JARS_DIR = "application-jars";
+
+@Override
+protected void processWebInfLib() throws LifecycleException {
+
+// Don't extract JAR files unless the application is deployed as a
+// packed WAR file.
+if (!super.isPackedWarFile()) {
+super.processWebInfLib();
+return;
+}
+
+File expansionTarget = getExpansionTarget();
+if (!expansionTarget.isDirectory()) {
+if (!expansionTarget.mkdirs()) {
+throw new LifecycleException(
+sm.getString("extractingRoot.targetFailed", 
expansionTarget));
+}
+}
+
+WebResource[] possibleJars = listResources("/WEB-INF/lib", false);
+
+for (WebResource possibleJar : possibleJars) {
+if (possibleJar.isFile() && 
possibleJar.getName().endsWith(".jar")) {
+try {
+File dest = new File(expansionTarget, 
possibleJar.getName());
+dest = 

[Bug 61316] Test files used by TestEncodingDetector test are broken in src.zip, src.tar.gz [8.5.18]

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61316

--- Comment #2 from Konstantin Kolinko  ---
svn is configured correctly:
If I run the tests from svn checkout, it completes successfully on my Windows,
and it completes successfully at Buildbot (on Linux).

>From svn pont of view the files with 16-bit characters should be treated as
binary. The should not have svn:eol-style property on them.


The problem is with configuration of  task in build.xml.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1802477 - in /tomcat/tc8.0.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/config/resources.xml

[markt]

Author: markt
Date: Thu Jul 20 12:09:16 2017
New Revision: 1802477

URL: http://svn.apache.org/viewvc?rev=1802477=rev
Log:
Correct the documentation for how StandardRoot is configured.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
tomcat/tc8.0.x/trunk/webapps/docs/config/resources.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Jul 20 12:09:16 2017
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948,1777014,1779719,1782037,1782240,1782386-1782387,1785669,1786845,1788249,1788324,1788905,1789216,1789335,1791528,1791558,1796697-1796698,1797521,1798543,1799162,1800143,1801693
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452
 

svn commit: r1802476 - in /tomcat/tc8.5.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/config/resources.xml

[markt]

Author: markt
Date: Thu Jul 20 12:07:37 2017
New Revision: 1802476

URL: http://svn.apache.org/viewvc?rev=1802476=rev
Log:
Correct the documentation for how StandardRoot is configured.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
tomcat/tc8.5.x/trunk/webapps/docs/config/resources.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Jul 20 12:07:37 2017
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747
 
536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1
 
756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-1762053,1762123,176216
 

svn commit: r1802475 - in /tomcat/trunk/webapps/docs: changelog.xml config/resources.xml

[markt]

Author: markt
Date: Thu Jul 20 12:06:03 2017
New Revision: 1802475

URL: http://svn.apache.org/viewvc?rev=1802475=rev
Log:
Correct the documentation for how StandardRoot is configured.

Modified:
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/config/resources.xml

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1802475=1802474=1802475=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Jul 20 12:06:03 2017
@@ -54,6 +54,14 @@
   
 
   
+  
+
+  
+Correct the documentation for how StandardRoot is
+configured. (markt)
+  
+
+  
 
 
   

Modified: tomcat/trunk/webapps/docs/config/resources.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/resources.xml?rev=1802475=1802474=1802475=diff
==
--- tomcat/trunk/webapps/docs/config/resources.xml (original)
+++ tomcat/trunk/webapps/docs/config/resources.xml Thu Jul 20 12:06:03 2017
@@ -150,8 +150,8 @@
   
 
 The standard implementation of Resources is
-org.apache.catalina.webresources.StandardRoot, and
-is configured by its parent Context element.
+org.apache.catalina.webresources.StandardRoot. It does not
+support any additional attributes.
 
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60523] Reduce number of network packets that server sends to client via WebSocket connection

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60523

Mark Thomas  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |---

--- Comment #9 from Mark Thomas  ---
Re-open to review the most recent comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org