svn commit: r24429 - /release/tomcat/tomcat-7/v7.0.82/

2018-01-24 Thread violetagg 
Author: violetagg
Date: Thu Jan 25 07:54:59 2018
New Revision: 24429

Log:
Remove 7.0.82

Removed:
release/tomcat/tomcat-7/v7.0.82/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1822179 - in /tomcat/site/trunk/docs/tomcat-7.0-doc: ./ api/ api/org/apache/catalina/ api/org/apache/catalina/ant/ api/org/apache/catalina/ant/jmx/ api/org/apache/catalina/authenticator/

2018-01-24 Thread violetagg 
Author: violetagg
Date: Thu Jan 25 07:51:24 2018
New Revision: 1822179

URL: http://svn.apache.org/viewvc?rev=1822179&view=rev
Log:
Update docs for Apache Tomcat 7.0.84 release.


[This commit notification would consist of 347 parts, 
which exceeds the limit of 50 ones, so it was shortened to the summary.]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1822178 - in /tomcat/site/trunk: ./ docs/ xdocs/

2018-01-24 Thread violetagg 
Author: violetagg
Date: Thu Jan 25 07:36:43 2018
New Revision: 1822178

URL: http://svn.apache.org/viewvc?rev=1822178&view=rev
Log:
Updates (excluding docs) for 7.0.84 release

Modified:
tomcat/site/trunk/build.properties.default
tomcat/site/trunk/docs/doap_Tomcat.rdf
tomcat/site/trunk/docs/download-70.html
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/docs/migration-7.html
tomcat/site/trunk/docs/oldnews.html
tomcat/site/trunk/docs/whichversion.html
tomcat/site/trunk/xdocs/doap_Tomcat.rdf
tomcat/site/trunk/xdocs/download-70.xml
tomcat/site/trunk/xdocs/index.xml
tomcat/site/trunk/xdocs/migration-7.xml
tomcat/site/trunk/xdocs/oldnews.xml
tomcat/site/trunk/xdocs/whichversion.xml

Modified: tomcat/site/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/build.properties.default?rev=1822178&r1=1822177&r2=1822178&view=diff
==
--- tomcat/site/trunk/build.properties.default (original)
+++ tomcat/site/trunk/build.properties.default Thu Jan 25 07:36:43 2018
@@ -36,7 +36,7 @@ tomcat.loc=http://www.apache.org/dist/to
 
 
 # - Tomcat versions -
-tomcat70=7.0.82
+tomcat70=7.0.84
 tomcat80=8.0.48
 tomcat85=8.5.27
 tomcat90=9.0.4

Modified: tomcat/site/trunk/docs/doap_Tomcat.rdf
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/doap_Tomcat.rdf?rev=1822178&r1=1822177&r2=1822178&view=diff
==
--- tomcat/site/trunk/docs/doap_Tomcat.rdf (original)
+++ tomcat/site/trunk/docs/doap_Tomcat.rdf Thu Jan 25 07:36:43 2018
@@ -81,8 +81,8 @@
 
   
 Latest Stable 7.0.x Release
-2017-10-03
-7.0.82
+2018-01-24
+7.0.84
   
 
 

Modified: tomcat/site/trunk/docs/download-70.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-70.html?rev=1822178&r1=1822177&r2=1822178&view=diff
==
--- tomcat/site/trunk/docs/download-70.html (original)
+++ tomcat/site/trunk/docs/download-70.html Thu Jan 25 07:36:43 2018
@@ -211,7 +211,7 @@
 Quick Navigation
 
 
-[define v]7.0.82[end]
+[define v]7.0.84[end]
 https://www.apache.org/dist/tomcat/tomcat-7/KEYS";>KEYS |
 [v] |
 Browse |

Modified: tomcat/site/trunk/docs/index.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/index.html?rev=1822178&r1=1822177&r2=1822178&view=diff
==
--- tomcat/site/trunk/docs/index.html (original)
+++ tomcat/site/trunk/docs/index.html Thu Jan 25 07:36:43 2018
@@ -234,6 +234,43 @@ project logo are trademarks of the Apach
 
 
 
+
+2018-01-24 Tomcat 7.0.84 Released
+
+
+
+The Apache Tomcat Project is proud to announce the release of version 7.0.84 of
+Apache Tomcat. This release contains a number of bug fixes and improvements
+compared to version 7.0.82. The notable changes compared to 7.0.82 include:
+
+
+
+
+Java 9 is fully supported
+
+Updated the packaged version of the Tomcat Native Library to 1.2.16 to pick
+up the latest Windows binaries built with APR 1.6.3 and OpenSSL 1.0.2m
+
+Add a new system property
+(org.apache.jasper.runtime.BodyContentImpl.BUFFER_SIZE) to control the
+size of the buffer used by Jasper when buffering tag bodies.
+
+
+
+
+
+Full details of these changes, and all the other changes, are available in the
+Tomcat 7 
changelog.
+
+
+
+
+
+https://tomcat.apache.org/download-70.cgi";>Download
+
+
+
+
 
 2018-01-22 Tomcat 8.5.27 Released
 
@@ -381,39 +418,6 @@ Tomcat Native. The notable changes since
 
 
 
-
-
-2017-10-03 Tomcat 7.0.82 Released
-
-
-
-The Apache Tomcat Project is proud to announce the release of version 7.0.82 of
-Apache Tomcat. This release contains a number of bug fixes and improvements
-compared to version 7.0.81. The notable changes compared to 7.0.81 include:
-
-
-
-
-A fix for CVE-2017-12617.
-
-Update the packaged version of the Tomcat Native Library to 1.2.14 to pick
-up the latest Windows binaries built with APR 1.6.2 and OpenSSL 
1.0.2l.
-
-
-
-
-
-Full details of these changes, and all the other changes, are available in the
-Tomcat 7 
changelog.
-
-
-
-
-
-https://tomcat.apache.org/download-70.cgi";>Download
-
-
-
 
 
 2016-10-05 Tomcat Connectors 1.2.42 
Released

Modified: tomcat/site/trunk/docs/migration-7.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration-7.html?rev=1822178&r1=1822177&r2=1822178&view=diff
==
--- tomcat/site/trunk/docs/migration-7.html (original)
+++ tomcat/site/trunk/docs/migration-7.html Thu Jan 25 07:36:43 2018
@@ -1093,7 +1093,8 @@ of Apache Tomcat.
   "7.0.78":"1794730",
   "7.0.79":"1799944",
   "7.0.81":"1804761",
-  "7.0.82":"1810087"
+  "7.0

Re: Responsive Website for tomcat.apache.org

2018-01-24 Thread Violeta Georgieva 
2018-01-24 21:05 GMT+02:00 Igal @ Lucee.org :
>
> Konstantin,
>
> I'd be happy to make all the necessary corections.
>
> On 1/24/2018 2:44 AM, Konstantin Kolinko wrote:
>>
>> 1. The "print view" of the page is important. One should be able to
>> print it. Especially the documentation.
>>
>> I think that menu and search box were not visible when printing, but
>> one has to check.
>
> IIRC the menu and search box were not visible when printing earlier
either.  The print view is very similar to the way it.  Is there any
important information that is missing?  See my print out at
https://github.com/isapir/tomcat-site/releases/download/0.1/Apache.Tomcat.-.Welcome.pdf
>
>> 2. The "GO" button on the search box looks off, misaligned.
>
> What browser are you using?  See screenshots at
>
https://user-images.githubusercontent.com/885907/35351078-b1cece0e-00f4-11e8-9d4d-6305d7ef4545.png
>
https://user-images.githubusercontent.com/885907/35351182-fd2f6048-00f4-11e8-8b73-1a005145a85a.png

Here is what I see with Chrome, Firefox and Safari
https://github.com/violetagg/tomcat-website-screenshots

Regards,
Violeta


>> 3. We would have to update some documentation.
>>
>> http://tomcat.apache.org/lists.html#tomcat-users
>> "2. Note, that Tomcat Documentation is provided on this site (see the
>> links at the left) and is searchable (see an input box above)."
>
> Perhaps a better phrasing would be:
>
> "Note, that Tomcat Documentation is provided on this site and is
searchable (see links and search box at the left)."
>
> Given that I can not make the change myself and the git patches take an
extra step, it would be easier for any committer to update it without a
patch from me at this point.
>
>> 4. Accessibility. Is it possible to operate the site without having a
mouse?
>>
>> If menu is closed, I cannot access the hamburger button with keyboard
>> (e.g. pressing tab), cannot open it.  And the text on the main page
>> does not provide other ways to access those parts of the site.
>
> Sure, I will work on that.
>
> Best,
>
>
> Igal Sapir
> Lucee Core Developer
> Lucee.org 
>

Re: Migrating to git

2018-01-24 Thread Coty Sutherland 
On Wed, Jan 24, 2018 at 4:57 PM, Christopher Schultz
 wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> Coty,
>
> On 1/24/18 1:34 PM, Coty Sutherland wrote:
>> I think this is the right thread to add this :)
>>
>> Given that we will be able to accept PRs on Github after this
>> migration, do we want to add a Travis (or other CI) configuration
>> to our repository so that it will do a test build (and maybe test
>> one connector) when someone proposes a pull? Doing that will ensure
>> we get all of the new code accepted by PRs tested without manual
>> intervention or waiting for the ASF build infrastructure to do it.
>> You can make passing the tests a condition to accept the PR too I
>> believe.
>
> Could this "feature" be used to DOS some host(s)? If every PR causes a
> checkout/compile/test cycle, it could get "expensive".

Possibly, but my thoughts were to use travis (https://travis-ci.org/)
which has it's own hosts and such that we won't need to worry about.
Travis also allows you to limit concurrent builds and even limit it to
only building PRs. Were you worried about the potential for DoSing ASF
infra? I just pushed a test .travls.yml in my tomcat fork
(https://github.com/csutherl/tomcat/blob/trunk/.travis.yml) so I could
play with it a bit.

> - -chris
> -BEGIN PGP SIGNATURE-
> Comment: GPGTools - http://gpgtools.org
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iQJRBAEBCAA7FiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlppAVQdHGNocmlzQGNo
> cmlzdG9waGVyc2NodWx0ei5uZXQACgkQHPApP6U8pFjBPg/+LywMRfUig0DsOkAt
> StgtY8dvvBJJyf9H9pQM8cqnjWx/nfKhvGhaaHgCd8ftfynM3k8I9X4iImKlRRhN
> xKCRbXyIr7QsCkbUDZqzVoTQeYE3A0OHSgo5kKlauI0+nrFPaoJW0fSAx9Gd4npV
> cV4PPsKokYiBbFl8/7q9taZ/FP0wB5QWf3hN1QEUFVyhlKzKhouB+dxmnzZzgBFS
> NRBFViOygJvYV299Jcg8UlyFC4HCfLy+L7uFsS5pf7MO29TG71xEMVrdNiMihz+j
> TxWG2n6AAK1fu0HS4GTIcan4zQUDtDoQB9VJD1TwOYQATgJQlNQbvaZvMk/+n6Gu
> WieMrGyLbJfix7asgv4qkQ80TyCTdQ1M3Ab4afrP0YGVzqIXRKFoyHQgiTZXgs6k
> de5Y6uFOgDna13up596BFKL94QkRyirAPXasVbB4QSuynmGiGCpAf7S+KHXb/T5W
> Ro2Zs1bHj1vTFB46NqGNJCjXC21ZmvPoujil7evohNc0vEVFNFLqsqcta2A30D6n
> +Yp/tbmDzY0xAl1Rp7BEUKVndzIWofvbQ08A41qWLMWTG1n16FjUQJg3xO3YHcDZ
> Oy0gWDnYvQlQnFKZs4bRCLle36dkAcZ2GzCwBELbxKKwiXk+mLS+Fz05YGG2BMYt
> 7GOhLV/GMhrz2Rs0MEzWgxlKhes=
> =ZVjJ
> -END PGP SIGNATURE-
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62032] NPE caused by Connector and SSLHostConfig

2018-01-24 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=62032

--- Comment #7 from Coty Sutherland  ---
Actually using "caught" was the wrong word. I prevented the NPE by checking the
certificate a bit earlier in the stack and threw a FNFE (where a warn was
previously logged) up to the Connector init. Take a look at the revision
(r1822150) and let me know if you see a better way to handle those.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Migrating to git

2018-01-24 Thread Christopher Schultz 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Coty,

On 1/24/18 1:34 PM, Coty Sutherland wrote:
> I think this is the right thread to add this :)
> 
> Given that we will be able to accept PRs on Github after this 
> migration, do we want to add a Travis (or other CI) configuration
> to our repository so that it will do a test build (and maybe test
> one connector) when someone proposes a pull? Doing that will ensure
> we get all of the new code accepted by PRs tested without manual
> intervention or waiting for the ASF build infrastructure to do it.
> You can make passing the tests a condition to accept the PR too I
> believe.

Could this "feature" be used to DOS some host(s)? If every PR causes a
checkout/compile/test cycle, it could get "expensive".

- -chris
-BEGIN PGP SIGNATURE-
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQJRBAEBCAA7FiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlppAVQdHGNocmlzQGNo
cmlzdG9waGVyc2NodWx0ei5uZXQACgkQHPApP6U8pFjBPg/+LywMRfUig0DsOkAt
StgtY8dvvBJJyf9H9pQM8cqnjWx/nfKhvGhaaHgCd8ftfynM3k8I9X4iImKlRRhN
xKCRbXyIr7QsCkbUDZqzVoTQeYE3A0OHSgo5kKlauI0+nrFPaoJW0fSAx9Gd4npV
cV4PPsKokYiBbFl8/7q9taZ/FP0wB5QWf3hN1QEUFVyhlKzKhouB+dxmnzZzgBFS
NRBFViOygJvYV299Jcg8UlyFC4HCfLy+L7uFsS5pf7MO29TG71xEMVrdNiMihz+j
TxWG2n6AAK1fu0HS4GTIcan4zQUDtDoQB9VJD1TwOYQATgJQlNQbvaZvMk/+n6Gu
WieMrGyLbJfix7asgv4qkQ80TyCTdQ1M3Ab4afrP0YGVzqIXRKFoyHQgiTZXgs6k
de5Y6uFOgDna13up596BFKL94QkRyirAPXasVbB4QSuynmGiGCpAf7S+KHXb/T5W
Ro2Zs1bHj1vTFB46NqGNJCjXC21ZmvPoujil7evohNc0vEVFNFLqsqcta2A30D6n
+Yp/tbmDzY0xAl1Rp7BEUKVndzIWofvbQ08A41qWLMWTG1n16FjUQJg3xO3YHcDZ
Oy0gWDnYvQlQnFKZs4bRCLle36dkAcZ2GzCwBELbxKKwiXk+mLS+Fz05YGG2BMYt
7GOhLV/GMhrz2Rs0MEzWgxlKhes=
=ZVjJ
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 57129] Regression. Load WEB-INF/lib jarfiles in alphabetical order

2018-01-24 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=57129

--- Comment #24 from Christopher Schultz  ---
(In reply to Sebastien Tardif from comment #23)
> It seems this issue is about fundamentalist versus pragmatism. Even if the
> order is deterministic, some application will still fail because not the
> order they are used to, but at least always fail. 
> 
> I hate when things are random and I try to compare logs file, it's a pain.
> Just for that reason I would have fixed this.
> 
> I can tell you that my organization spent so far at least $3000 USD in lost
> of time due to this.
> 
> I learned in 3rd grade high school that probability of success get lower
> fast if you have many tiny problem that doesn't seem useful to fix by
> themselves.
> 
> My app is like 10 years old, with many millions line of code, coded by 100+
> developers.

While I did not perform an exhaustive search, I know of no servlet container
which explicitly guarantees JAR-file load-ordering within a particular
directory. Yes, WEB-INF/classes will be loaded before WEB-INF/lib/*.jar but
there is no explicit guarantee of the ordering among the JAR files. The servlet
spec also does not mandate any JAR-load-ordering.

I actually support the idea of alphabetical JAR-load-ordering if for no other
reason than it allows you to patch a server by dropping a new JAR file into
WEB-INF/lib and starting the context. If that option is not available, you need
to use container-specific features such a Tomcat's , etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62032] NPE caused by Connector and SSLHostConfig

2018-01-24 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=62032

--- Comment #6 from Christopher Schultz  ---
Catching NPE/FNFE is pretty ugly. Is there a better way to do it? I'd prefer to
pro-actively validate the configuration and tell the user something is wrong
than catch these exceptions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 52381] Please add OSGi metadata

2018-01-24 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=52381

--- Comment #15 from Coty Sutherland  ---
Any thoughts on the patch? It's a rough draft and I should replace all the hard
coded spec version info with dynamic stuff, but as far as using these manifests
as a template to fill in other info, does that look OK to anyone/everyone? I
don't see any other easy alternative to generate this info except maybe Apache
Ivy, which has an experimental OSGi bundle thingy.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62032] NPE caused by Connector and SSLHostConfig

2018-01-24 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=62032

Coty Sutherland  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #5 from Coty Sutherland  ---
I caught the NPE and reported it as a configuration error (missing
certificateFile attribute on the SSLHostConfig) and caught/handled the
FileNotFoundException for the other two scenarios above in a way that is
consistent across file types (I threw the exception up to the Connector
creation to be handled). There was some message/stack trace duplication that I
removed in there too, which reduces unnecessary logging and creates a better
user experience.

Fixed in:
- trunk for 9.0.5 onwards
- 8.5.x for 8.5.28 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1822152 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/ java/org/apache/tomcat/util/net/jsse/ webapps/docs/

2018-01-24 Thread csutherl 
Author: csutherl
Date: Wed Jan 24 19:49:03 2018
New Revision: 1822152

URL: http://svn.apache.org/viewvc?rev=1822152&view=rev
Log:
Fixed https://bz.apache.org/bugzilla/show_bug.cgi?id=62032
Fix NullPointerException when certificateFile is not defined on an 
SSLHostConfig and unify the behavior when a certificateFile is defined but the 
file does not exist for both JKS and PEM file types.

I also fixed one TODO in SSLHostConfig and changed how the 
IllegalArgumentException is thrown in AbstractJsseEndpoint so that it's message 
is consistent with other logging messages.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)

tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/AbstractJsseEndpoint.java
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/SSLHostConfig.java
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/SSLUtilBase.java
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/jsse/JSSEUtil.java

tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/jsse/LocalStrings.properties
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Jan 24 19:49:03 2018
@@ -1,2 +1,2 @@
 /tomcat/tc8.0.x/trunk:1809644
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409
 
,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747
 
404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1
 
756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,17585

svn commit: r1822150 - in /tomcat/trunk: java/org/apache/tomcat/util/net/ java/org/apache/tomcat/util/net/jsse/ webapps/docs/

2018-01-24 Thread csutherl 
Author: csutherl
Date: Wed Jan 24 19:45:00 2018
New Revision: 1822150

URL: http://svn.apache.org/viewvc?rev=1822150&view=rev
Log:
Fixed https://bz.apache.org/bugzilla/show_bug.cgi?id=62032
Fix NullPointerException when certificateFile is not defined on an 
SSLHostConfig and unify the behavior when a certificateFile is defined but the 
file does not exist for both JKS and PEM file types.

I also fixed one TODO in SSLHostConfig and changed how the 
IllegalArgumentException is thrown in AbstractJsseEndpoint so that it's message 
is consistent with other logging messages.

Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AbstractJsseEndpoint.java
tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties
tomcat/trunk/java/org/apache/tomcat/util/net/SSLHostConfig.java
tomcat/trunk/java/org/apache/tomcat/util/net/SSLUtilBase.java
tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSEUtil.java
tomcat/trunk/java/org/apache/tomcat/util/net/jsse/LocalStrings.properties
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AbstractJsseEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AbstractJsseEndpoint.java?rev=1822150&r1=1822149&r2=1822150&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/AbstractJsseEndpoint.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/AbstractJsseEndpoint.java Wed 
Jan 24 19:45:00 2018
@@ -111,7 +111,7 @@ public abstract class AbstractJsseEndpoi
 sslContext = sslUtil.createSSLContext(negotiableProtocols);
 sslContext.init(sslUtil.getKeyManagers(), 
sslUtil.getTrustManagers(), null);
 } catch (Exception e) {
-throw new IllegalArgumentException(e);
+throw new IllegalArgumentException(e.getMessage(), e);
 }
 
 SSLSessionContext sessionContext = 
sslContext.getServerSessionContext();

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties?rev=1822150&r1=1822149&r2=1822150&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties Wed 
Jan 24 19:45:00 2018
@@ -146,6 +146,7 @@ sslHostConfig.prefix_missing=The protoco
 sslHostConfigCertificate.mismatch=The property [{0}] was set on the 
SSLHostConfigCertificate named [{1}] and is for certificate storage type [{2}] 
but the certificate is being used with a storage of type [{3}]
 sslHostConfig.opensslconf.null=Attempt to set null OpenSSLConf ignored
 sslHostConfig.opensslconf.alreadyset=Attempt to set another OpenSSLConf ignored
+sslHostConfig.fileNotFound=Configured file [{0}] does not exist
 
 sslImplementation.cnfe= Unable to create SSLImplementation for class [{0}]
 

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SSLHostConfig.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/SSLHostConfig.java?rev=1822150&r1=1822149&r2=1822150&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/SSLHostConfig.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/SSLHostConfig.java Wed Jan 24 
19:45:00 2018
@@ -17,6 +17,7 @@
 package org.apache.tomcat.util.net;
 
 import java.io.File;
+import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.io.Serializable;
 import java.security.KeyStore;
@@ -824,7 +825,7 @@ public class SSLHostConfig implements Se
 
 // - Support 
methods
 
-public static String adjustRelativePath(String path) {
+public static String adjustRelativePath(String path) throws 
FileNotFoundException {
 // Empty or null path can't point to anything useful. The assumption is
 // that the value is deliberately empty / null so leave it that way.
 if (path == null || path.length() == 0) {
@@ -837,8 +838,7 @@ public class SSLHostConfig implements Se
 f = new File(newPath);
 }
 if (!f.exists()) {
-// TODO i18n, sm
-log.warn("configured file:["+newPath+"] does not exist.");
+throw new 
FileNotFoundException(sm.getString("sslHostConfig.fileNotFound", newPath));
 }
 return newPath;
 }

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SSLUtilBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/SSLUtilBase.java?rev=1822150&r1=1822149&r2=1822150&view=diff
==
--- tomcat/trun

Re: Responsive Website for tomcat.apache.org

2018-01-24 Thread Igal @ Lucee.org 

Konstantin,

I'd be happy to make all the necessary corections.

On 1/24/2018 2:44 AM, Konstantin Kolinko wrote:

1. The "print view" of the page is important. One should be able to
print it. Especially the documentation.

I think that menu and search box were not visible when printing, but
one has to check.
IIRC the menu and search box were not visible when printing earlier 
either.  The print view is very similar to the way it.  Is there any 
important information that is missing?  See my print out at 
https://github.com/isapir/tomcat-site/releases/download/0.1/Apache.Tomcat.-.Welcome.pdf



2. The "GO" button on the search box looks off, misaligned.

What browser are you using?  See screenshots at
https://user-images.githubusercontent.com/885907/35351078-b1cece0e-00f4-11e8-9d4d-6305d7ef4545.png
https://user-images.githubusercontent.com/885907/35351182-fd2f6048-00f4-11e8-8b73-1a005145a85a.png


3. We would have to update some documentation.

http://tomcat.apache.org/lists.html#tomcat-users
"2. Note, that Tomcat Documentation is provided on this site (see the
links at the left) and is searchable (see an input box above)."

Perhaps a better phrasing would be:

"Note, that Tomcat Documentation is provided on this site and is 
searchable (see links and search box at the left)."


Given that I can not make the change myself and the git patches take an 
extra step, it would be easier for any committer to update it without a 
patch from me at this point.



4. Accessibility. Is it possible to operate the site without having a mouse?

If menu is closed, I cannot access the hamburger button with keyboard
(e.g. pressing tab), cannot open it.  And the text on the main page
does not provide other ways to access those parts of the site.

Sure, I will work on that.

Best,

Igal Sapir
Lucee Core Developer
Lucee.org

Re: Responsive Website for tomcat.apache.org

2018-01-24 Thread Mark Thomas 
On 24/01/18 18:38, Igal @ Lucee.org wrote:
> Mark,
> 
> On 1/24/2018 1:43 AM, Mark Thomas wrote:
>> Looks great. Patch applied many thanks.
> Thank you.  I appreciate the feedback.
> 
>> I don't suppose you are interested in making similar changes to the
>> documentation web applications (the content gets copied to the web-site)
>> and/or updating the Tomcat 7 docs to match the style of the others?
> I'm happy to contribute to the Tomcat project in any way that I can.
> 
> To clarify, you are referring to these sites, right?
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/trunk/webapps/docs/
> http://svn.apache.org/repos/asf/tomcat/tc***.x/trunk/webapps/docs/

I am.

Konstantin's feedback on the changes so far is probably a higher
priority though.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Migrating to git

2018-01-24 Thread Mark Thomas 
On 24/01/18 18:34, Coty Sutherland wrote:
> I think this is the right thread to add this :)
> 
> Given that we will be able to accept PRs on Github after this
> migration, do we want to add a Travis (or other CI) configuration to
> our repository so that it will do a test build (and maybe test one
> connector) when someone proposes a pull? Doing that will ensure we get
> all of the new code accepted by PRs tested without manual intervention
> or waiting for the ASF build infrastructure to do it. You can make
> passing the tests a condition to accept the PR too I believe.

+1 to more CI. I lean towards reporting results rather than hard
requirements but I suspect we'll tweak that sort of detail as we go along.

Mark



> 
> On Wed, Dec 13, 2017 at 8:52 AM, Rémy Maucherat  wrote:
>> On Wed, Dec 13, 2017 at 10:23 AM, Mark Thomas  wrote:
>>
>>> The plan is to switch to "github as master' which is actually a dual
>>> master system where commits can be made directly to either github or the
>>> ASF. I don't think it matter which we use. My (not recent) experience is
>>> that github is faster.
>>>
>>> Nice setup.
>>
>> Rémy
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Responsive Website for tomcat.apache.org

2018-01-24 Thread Igal @ Lucee.org 

Mark,

On 1/24/2018 1:43 AM, Mark Thomas wrote:

Looks great. Patch applied many thanks.

Thank you.  I appreciate the feedback.


I don't suppose you are interested in making similar changes to the
documentation web applications (the content gets copied to the web-site)
and/or updating the Tomcat 7 docs to match the style of the others?

I'm happy to contribute to the Tomcat project in any way that I can.

To clarify, you are referring to these sites, right?
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/trunk/webapps/docs/
http://svn.apache.org/repos/asf/tomcat/tc***.x/trunk/webapps/docs/

Igal Sapir
Lucee Core Developer
Lucee.org

Re: Migrating to git

2018-01-24 Thread Coty Sutherland 
I think this is the right thread to add this :)

Given that we will be able to accept PRs on Github after this
migration, do we want to add a Travis (or other CI) configuration to
our repository so that it will do a test build (and maybe test one
connector) when someone proposes a pull? Doing that will ensure we get
all of the new code accepted by PRs tested without manual intervention
or waiting for the ASF build infrastructure to do it. You can make
passing the tests a condition to accept the PR too I believe.

On Wed, Dec 13, 2017 at 8:52 AM, Rémy Maucherat  wrote:
> On Wed, Dec 13, 2017 at 10:23 AM, Mark Thomas  wrote:
>
>> The plan is to switch to "github as master' which is actually a dual
>> master system where commits can be made directly to either github or the
>> ASF. I don't think it matter which we use. My (not recent) experience is
>> that github is faster.
>>
>> Nice setup.
>
> Rémy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot success in on tomcat-7-trunk

2018-01-24 Thread buildbot 
The Buildbot has detected a restored build on builder tomcat-7-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-7-trunk/builds/989

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-7-commit' 
triggered this build
Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1822134
Blamelist: remm

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62024] Suspected memory leak of org.apache.coyote.AbstractProtocol$ConnectionHandler object while using Websocket

2018-01-24 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=62024

--- Comment #2 from SergeP  ---
Mark

Looks like it did not save my environment - Windows Server 2012

Also these bugs might be related to this one:

*[57546](https://bz.apache.org/bugzilla/show_bug.cgi?id=57546)
*[57750](https://bz.apache.org/bugzilla/show_bug.cgi?id=57750)

The 57546 bug looks very similar to what we are experiencing. We tested on
Linux and so far we do not see the same behavior. Also this is our web socket
code:

package ad.ecs.async.websocket;

import java.io.IOException;
import java.util.Arrays;

import javax.websocket.CloseReason;
import javax.websocket.OnClose;
import javax.websocket.OnError;
import javax.websocket.OnMessage;
import javax.websocket.OnOpen;
import javax.websocket.Session;
import javax.websocket.server.ServerEndpoint;

import ad.common.Global;
import ad.ecs.async.AsyncEngine;
import ad.ecs.async.AsyncResponse;
import ad.ecs.async.AsyncType;
import ad.ecs.db.DatabaseEngine;
import ad.ecs.db.paradox.User;
import ad.ecs.security.engine.SecurityEngine;

/**
 * @author Serge Perepel
 * @since Aug 23, 2017 12:23:32 PM
 */
@ServerEndpoint(value = "/asyncMsg", encoders = AsyncResponseEncoder.class)
public class ECSAsync {

@OnOpen
public void open(Session session) throws IOException{
session.getBasicRemote().sendText("Connection Established");
}

@OnMessage
public String login(String sessionID, Session session) {
AsyncEngine.INSTANCE.wsConnect(session, sessionID);
org.hibernate.Session dbSession =
DatabaseEngine.getSessionFactory().openSession();
try {
int userID =
SecurityEngine.INSTANCE.getUserIDBasedOnSessionID(sessionID);
User user = (User) dbSession.get(User.class, userID);
if (user != null) {
if (user.getNextLogin() == 1) {
AsyncResponse response = new AsyncResponse();
response.setType(AsyncType.None);
response.setData(Arrays.asList("PASSWORD"));
response.setObjData("PASSWORD");
   
AsyncEngine.INSTANCE.addTransientResult(sessionID, response);
}
}
} finally {
dbSession.close();
}
return "ok"; 
}

@OnClose 
public void close(Session session, CloseReason reason) {
AsyncEngine.INSTANCE.wsDisconnect(session);
}

@OnError
public void error(Session session, Throwable error) {
Global.INSTANCE.getLogHelper().exception(error);
//session.close(new CloseReason(closeCode, reasonPhrase));
}
}

Front end opens connection and sends invalid sessionID which causes
the line `AsyncEngine.INSTANCE.wsConnect(session, sessionID);` to throw
exception and after that disconnect happens on the front end. At this point
front end opens new connection and process goes into the loop. I'm assuming
that the connection handler suppose to get freed after a disconnect happen. But
it seems to accumulate. You can try this code and just replace code in the
login method to always throw the exception. On the front end onDisconnect try
to open new connection and send a random message to the web socket. Hopefully
this will reproduce the issue for you.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1822141 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ThreadLocalLeakPreventionListener.java webapps/docs/changelog.xml

2018-01-24 Thread remm 
Author: remm
Date: Wed Jan 24 17:54:08 2018
New Revision: 1822141

URL: http://svn.apache.org/viewvc?rev=1822141&view=rev
Log:
 Avoid NPE if there is no Engine.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)

tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ThreadLocalLeakPreventionListener.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Jan 24 17:54:08 2018
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644525,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988
 
,1667553-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702
 
739,1702742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1
 
725974,1726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1758563,1759565,1761686,1762173,1762206,1766280,1767507-1767508,1767653,1767656,1769267,1772949,1773521,1773527,1774104,1777015,1777213,1779330,1783151,1784188,1784966,1785670,1786846,1788260,1788999,1789140,1789402,1791529,1791559,1795291,1796906,1797523,1799214,1800998-1800999,1801003,1801007-1801008,1801017,1801020,1802808,180281
 
4,1803618,1806107,1806733,1807082-1807083,1808707,1808884,1809267,1809644,1809832,1809904,1809915,1809924,1810283,1810328,1810574,1810576-1810577,1810584,1810588,1811141,1811842,1812090,1812096,1812150,1812511,1814976,1814983,1815072,1815453,1815946,1815957,1816143,1816682,1817229,1817287,1820200,1820209,1820283,1820305,1821303-1821311,1821313,1821316,1821330,1821365
 
/tomcat/tc8.5.x/trunk:1735579,1736839,1737199,1737966,173804

buildbot failure in on tomcat-7-trunk

2018-01-24 Thread buildbot 
The Buildbot has detected a new failure on builder tomcat-7-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-7-trunk/builds/988

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-7-commit' 
triggered this build
Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1822119
Blamelist: markt

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1822138 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/ThreadLocalLeakPreventionListener.java webapps/docs/changelog.xml

2018-01-24 Thread remm 
Author: remm
Date: Wed Jan 24 17:49:56 2018
New Revision: 1822138

URL: http://svn.apache.org/viewvc?rev=1822138&view=rev
Log:
 Avoid NPE if there is no Engine.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)

tomcat/tc8.0.x/trunk/java/org/apache/catalina/core/ThreadLocalLeakPreventionListener.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Jan 24 17:49:56 2018
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948,1777014,1779719,1782037,1782240,1782386-1782387,1785669,1786845,1788249,1788324,1788905,1789216,1789335,1791528,1791558,1796697-1796698,1797521,1798543,1799162,1800143,1801693,1802805,1806799,1807079-1807080,1808880,1809831,1812093,1812143,1812145,1812319,1814975,1815945,1815956,1820207
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452
 
7

svn commit: r1822136 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/core/ThreadLocalLeakPreventionListener.java webapps/docs/changelog.xml

2018-01-24 Thread remm 
Author: remm
Date: Wed Jan 24 17:48:18 2018
New Revision: 1822136

URL: http://svn.apache.org/viewvc?rev=1822136&view=rev
Log:
 Avoid NPE if there is no Engine.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)

tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/ThreadLocalLeakPreventionListener.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Jan 24 17:48:18 2018
@@ -1,2 +1,2 @@
 /tomcat/tc8.0.x/trunk:1809644
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409
 
,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747
 
404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1
 
756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205
 
3,1762123,1762168,1762172,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-1763320,1763370,1763372,1763375,1763377,1763393,1763412,1763430,1763450,1763462,1763505,1763511-1763512,1763516,

svn commit: r1822134 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/Catalina.java webapps/docs/changelog.xml

2018-01-24 Thread remm 
Author: remm
Date: Wed Jan 24 17:46:54 2018
New Revision: 1822134

URL: http://svn.apache.org/viewvc?rev=1822134&view=rev
Log:
 Avoid duplicate load calls (which can happen in some cases like a malformed 
server.xml).

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/Catalina.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Jan 24 17:46:54 2018
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644525,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988
 
,1667553-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702
 
739,1702742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1
 
725974,1726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1758563,1759565,1761686,1762173,1762206,1766280,1767507-1767508,1767653,1767656,1769267,1772949,1773521,1773527,1774104,1777015,1777213,1779330,1783151,1784188,1784966,1785670,1786846,1788260,1788999,1789140,1789402,1791529,1791559,1795291,1796906,1797523,1799214,1800998-1800999,1801003,1801007-1801008,1801017,1801020,1802808,180281
 
4,1803618,1806107,1806733,1807082-1807083,1808707,1808884,1809267,1809644,1809832,1809904,1809915,1809924,1810283,1810328,1810574,1810576-1810577,1810584,1810588,1811141,1811842,1812090,1812096,1812150,1812511,1814976,1814983,1815072,1815453,1815946,1815957,1816143,1816682,1817229,1817287,1820200,1820209,1820283,1820305,1821303-1821311,1821313,1821316,1821330,1821365
 
/tomcat/tc8.5.x/trunk:1735

svn commit: r1822132 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/startup/Catalina.java webapps/docs/changelog.xml

2018-01-24 Thread remm 
Author: remm
Date: Wed Jan 24 17:45:03 2018
New Revision: 1822132

URL: http://svn.apache.org/viewvc?rev=1822132&view=rev
Log:
 Avoid duplicate load calls (which can happen in some cases like a malformed 
server.xml).

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/catalina/startup/Catalina.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Jan 24 17:45:03 2018
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948,1777014,1779719,1782037,1782240,1782386-1782387,1785669,1786845,1788249,1788324,1788905,1789216,1789335,1791528,1791558,1796697-1796698,1797521,1798543,1799162,1800143,1801693,1802805,1806799,1807079-1807080,1808880,1809831,1812093,1812143,1812145,1812319,1814975,1815945,1815956,1820207
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,

svn commit: r1822131 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/startup/Catalina.java webapps/docs/changelog.xml

2018-01-24 Thread remm 
Author: remm
Date: Wed Jan 24 17:43:22 2018
New Revision: 1822131

URL: http://svn.apache.org/viewvc?rev=1822131&view=rev
Log:
 Avoid duplicate load calls (which can happen in some cases like a malformed 
server.xml).

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/catalina/startup/Catalina.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Jan 24 17:43:22 2018
@@ -1,2 +1,2 @@
 /tomcat/tc8.0.x/trunk:1809644
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409
 
,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747
 
404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1
 
756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205
 
3,1762123,1762168,1762172,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-1763320,1763370,1763372,1763375,1763377,1763393,1763412,1763430,1763450,176346

[Bug 62028] Server Sent Event closed connection throws IOException

2018-01-24 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=62028

--- Comment #1 from Mark Thomas  ---
Comment on attachment 35693
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35693
Tomcat 9 log, regarding Server Sent Events

The NPE on shutdown looks like a Tomcat bug to me and we should get that fixed.

The IOException on connection close is exactly what should happen. This is an
asynchronous request using blocking I/O (WebSocket is not involved here based
on the stack trace) as far as I can tell so Tomcat has no way of knowing the
socket is closed until the app tries to write to the socket. At that point an
IOException is thrown. The app does't handle it so Tomcat logs it. This is all
as designed. I'd expect either the app or possibly Spring to handle this case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62036] Roles stripped when using programmatic login() in tomcat 8.5 but not 8.0

2018-01-24 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=62036

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Mark Thomas  ---
The prior call to checkForCachedAuthentication() will trigger a logout if the
GSSCredential has expired so the proposed fix looks good.

Fixed in:
- trunk for 9.0.5 onwards
- 8.5.x for 8.5.28 onwards
- 8.0.x for 8.0.50 onwards
- 7.0.x for 7.0.85 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1822119 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/authenticator/NonLoginAuthenticator.java webapps/docs/changelog.xml

2018-01-24 Thread markt 
Author: markt
Date: Wed Jan 24 16:35:23 2018
New Revision: 1822119

URL: http://svn.apache.org/viewvc?rev=1822119&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62036
When caching an authenticated user Principal in the session when the web 
application is configured with the NonLoginAuthenticator, cache the internal 
Principal object rather than the user facing Principal object as Tomcat 
requires the internal object to correctly process later authorization checks.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)

tomcat/tc7.0.x/trunk/java/org/apache/catalina/authenticator/NonLoginAuthenticator.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Jan 24 16:35:23 2018
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644525,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988
 
,1667553-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702
 
739,1702742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1
 
725974,1726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1758563,1759565,1761686,1762173,1762206,1766280,1767507-1767508,1767653,1767656,1769267,1772949,1773521,1773527,1774104,1777015,1777213,1779330,1783151,1784188,1784966,1785670,1786846,1788260,1788999,1789140,1789402,1791529,1791559,1795291,1796906,1797523,1799214,1800998-1800999,1801003,1801007-1801008,1801017,1801020,1802808,180281
 
4,1803618,1806107,1806733,1807082-1807083,1808707,1808884,1809267,1809644,1809832,1809904,1809915,1809924,18

svn commit: r1822118 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/authenticator/NonLoginAuthenticator.java webapps/docs/changelog.xml

2018-01-24 Thread markt 
Author: markt
Date: Wed Jan 24 16:34:40 2018
New Revision: 1822118

URL: http://svn.apache.org/viewvc?rev=1822118&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62036
When caching an authenticated user Principal in the session when the web 
application is configured with the NonLoginAuthenticator, cache the internal 
Principal object rather than the user facing Principal object as Tomcat 
requires the internal object to correctly process later authorization checks.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)

tomcat/tc8.0.x/trunk/java/org/apache/catalina/authenticator/NonLoginAuthenticator.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Jan 24 16:34:40 2018
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948,1777014,1779719,1782037,1782240,1782386-1782387,1785669,1786845,1788249,1788324,1788905,1789216,1789335,1791528,1791558,1796697-1796698,1797521,1798543,1799162,1800143,1801693,1802805,1806799,1807079-1807080,1808880,1809831,1812093,1812143,1812145,1812319,1814975,1815945,1815956,1820207
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,167870

svn commit: r1822117 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/authenticator/NonLoginAuthenticator.java webapps/docs/changelog.xml

2018-01-24 Thread markt 
Author: markt
Date: Wed Jan 24 16:33:47 2018
New Revision: 1822117

URL: http://svn.apache.org/viewvc?rev=1822117&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62036
When caching an authenticated user Principal in the session when the web 
application is configured with the NonLoginAuthenticator, cache the internal 
Principal object rather than the user facing Principal object as Tomcat 
requires the internal object to correctly process later authorization checks.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)

tomcat/tc8.5.x/trunk/java/org/apache/catalina/authenticator/NonLoginAuthenticator.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Jan 24 16:33:47 2018
@@ -1,2 +1,2 @@
 /tomcat/tc8.0.x/trunk:1809644
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409
 
,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747
 
404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1
 
756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205
 
3,1762123,1762168,1762172,1762182,1762201-1762202,1762204,1762208,1762288,1762

svn commit: r1822116 - in /tomcat/trunk: java/org/apache/catalina/authenticator/NonLoginAuthenticator.java webapps/docs/changelog.xml

2018-01-24 Thread markt 
Author: markt
Date: Wed Jan 24 16:32:31 2018
New Revision: 1822116

URL: http://svn.apache.org/viewvc?rev=1822116&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62036
When caching an authenticated user Principal in the session when the web 
application is configured with the NonLoginAuthenticator, cache the internal 
Principal object rather than the user facing Principal object as Tomcat 
requires the internal object to correctly process later authorization checks.

Modified:

tomcat/trunk/java/org/apache/catalina/authenticator/NonLoginAuthenticator.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/trunk/java/org/apache/catalina/authenticator/NonLoginAuthenticator.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/authenticator/NonLoginAuthenticator.java?rev=1822116&r1=1822115&r2=1822116&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/authenticator/NonLoginAuthenticator.java 
(original)
+++ 
tomcat/trunk/java/org/apache/catalina/authenticator/NonLoginAuthenticator.java 
Wed Jan 24 16:32:31 2018
@@ -80,10 +80,10 @@ public final class NonLoginAuthenticator
 // Don't try and use SSO to authenticate since there is no auth
 // configured for this web application
 if (checkForCachedAuthentication(request, response, true)) {
-// save the inherited Principal in this session so it can remain
-// authenticated until it expires
+// Save the inherited Principal in this session so it can remain
+// authenticated until it expires.
 if (cache) {
-
request.getSessionInternal(true).setPrincipal(request.getUserPrincipal());
+
request.getSessionInternal(true).setPrincipal(request.getPrincipal());
 }
 return true;
 }

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1822116&r1=1822115&r2=1822116&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Jan 24 16:32:31 2018
@@ -58,6 +58,13 @@
 Avoid NPE in ThreadLocalLeakPreventionListener if there is no Engine.
 (remm)
   
+  
+62036: When caching an authenticated user Principal in the
+session when the web application is configured with the
+NonLoginAuthenticator, cache the internal Principal object
+rather than the user facing Principal object as Tomcat requires the
+internal object to correctly process later authorization checks. 
(markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62024] Suspected memory leak of org.apache.coyote.AbstractProtocol$ConnectionHandler object while using Websocket

2018-01-24 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=62024

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED
 OS||All

--- Comment #1 from Mark Thomas  ---
There is nothing in this report that indicates a bug in Apache Tomcat and no
information that might enable a developer to reproduce the behaviour you are
seeing.

Bugzilla is not a support forum. Please use the Tomcat users mailing list to
debug this issue. If that discussion concludes that there is a Tomcat bug,
please re-open this issue and provide the necessary steps to reproduce the
issue on a clean install of the latest release of any currently supported
branch.

http://tomcat.apache.org/lists.html#tomcat-users

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62024] Suspected memory leak of org.apache.coyote.AbstractProtocol$ConnectionHandler object while using Websocket

2018-01-24 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=62024

SergeP  changed:

   What|Removed |Added

   Severity|normal  |major
 OS||Windows Server 2012

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 57129] Regression. Load WEB-INF/lib jarfiles in alphabetical order

2018-01-24 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=57129

--- Comment #23 from Sebastien Tardif  ---
It seems this issue is about fundamentalist versus pragmatism. Even if the
order is deterministic, some application will still fail because not the order
they are used to, but at least always fail. 

I hate when things are random and I try to compare logs file, it's a pain. Just
for that reason I would have fixed this.

I can tell you that my organization spent so far at least $3000 USD in lost of
time due to this.

I learned in 3rd grade high school that probability of success get lower fast
if you have many tiny problem that doesn't seem useful to fix by themselves.

My app is like 10 years old, with many millions line of code, coded by 100+
developers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62024] Suspected memory leak of org.apache.coyote.AbstractProtocol$ConnectionHandler object while using Websocket

2018-01-24 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=62024

SergeP  changed:

   What|Removed |Added

 OS||Windows Server 2012

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62024] Suspected memory leak of org.apache.coyote.AbstractProtocol$ConnectionHandler object while using Websocket

2018-01-24 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=62024

SergeP  changed:

   What|Removed |Added

 OS|All |Windows Server 2012

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: JDK 10 Early Access b40 & JDK 8u172 Early Access b02 are available on jdk.java.net

2018-01-24 Thread Rory O'Donnell 

Thanks for the quick feedback!

Rgds,Rory


On 24/01/2018 12:10, Mark Thomas wrote:

On 22/01/18 10:18, Rory O'Donnell wrote:

  Hi Mark,

Happy New Year!

*OpenJDK builds - *JDK 10 Early Access build 40 is available at
http://jdk.java.net/10/

Builds OK.

Starts and stops without error. Quick smoke test with the WebSocket
examples looks OK.

Unit tests pass on Linux.

Overall, looking good.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA, Dublin,Ireland


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62036] Roles stripped when using programmatic login() in tomcat 8.5 but not 8.0

2018-01-24 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=62036

--- Comment #8 from Mark Thomas  ---
Regardless, this does look like a bug that needs to be fixed. Apart from
NonLoginAuthenticator.doAuthenticate() everywhere else that caches the
Principal in the session caches the TomcatPrincipal. Switching to
s/getUserPrincipal()/getPrincipal()/ looks like it will work - but I want to
see if we need to validate any GSSCredential at this point.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 57129] Regression. Load WEB-INF/lib jarfiles in alphabetical order

2018-01-24 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=57129

Sebastien Tardif  changed:

   What|Removed |Added

 CC||sebtar...@ncf.ca

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1822111 - in /tomcat/trunk: java/org/apache/catalina/core/ThreadLocalLeakPreventionListener.java webapps/docs/changelog.xml

2018-01-24 Thread remm 
Author: remm
Date: Wed Jan 24 15:19:25 2018
New Revision: 1822111

URL: http://svn.apache.org/viewvc?rev=1822111&view=rev
Log:
Avoid NPE if there is no Engine.

Modified:

tomcat/trunk/java/org/apache/catalina/core/ThreadLocalLeakPreventionListener.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/trunk/java/org/apache/catalina/core/ThreadLocalLeakPreventionListener.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ThreadLocalLeakPreventionListener.java?rev=1822111&r1=1822110&r2=1822111&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/core/ThreadLocalLeakPreventionListener.java
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/core/ThreadLocalLeakPreventionListener.java
 Wed Jan 24 15:19:25 2018
@@ -128,8 +128,10 @@ public class ThreadLocalLeakPreventionLi
 private void registerListenersForServer(Server server) {
 for (Service service : server.findServices()) {
 Engine engine = service.getContainer();
-engine.addContainerListener(this);
-registerListenersForEngine(engine);
+if (engine != null) {
+engine.addContainerListener(this);
+registerListenersForEngine(engine);
+}
 }
 
 }

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1822111&r1=1822110&r2=1822111&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Jan 24 15:19:25 2018
@@ -54,6 +54,10 @@
   
 Avoid duplicate load attempts if one has been made already. (remm)
   
+  
+Avoid NPE in ThreadLocalLeakPreventionListener if there is no Engine.
+(remm)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1822109 - in /tomcat/trunk: java/org/apache/catalina/startup/Catalina.java webapps/docs/changelog.xml

2018-01-24 Thread remm 
Author: remm
Date: Wed Jan 24 15:13:11 2018
New Revision: 1822109

URL: http://svn.apache.org/viewvc?rev=1822109&view=rev
Log:
Avoid duplicate load calls (which can happen in some cases like a malformed 
server.xml).

Modified:
tomcat/trunk/java/org/apache/catalina/startup/Catalina.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/startup/Catalina.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/Catalina.java?rev=1822109&r1=1822108&r2=1822109&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/Catalina.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/Catalina.java Wed Jan 24 
15:13:11 2018
@@ -122,6 +122,12 @@ public class Catalina {
 protected boolean useNaming = true;
 
 
+/**
+ * Prevent duplicate loads.
+ */
+protected boolean loaded = false;
+
+
 // --- Constructors
 
 public Catalina() {
@@ -518,6 +524,11 @@ public class Catalina {
  */
 public void load() {
 
+if (loaded) {
+return;
+}
+loaded = true;
+
 long t1 = System.nanoTime();
 
 initDirs();

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1822109&r1=1822108&r2=1822109&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Jan 24 15:13:11 2018
@@ -51,6 +51,9 @@
 Prevent a stack trace being written to standard out when running on 
Java
 10 due to changes in the LogManager implementation. 
(markt)
   
+  
+Avoid duplicate load attempts if one has been made already. (remm)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62036] Roles stripped when using programmatic login() in tomcat 8.5 but not 8.0

2018-01-24 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=62036

--- Comment #7 from Mark Thomas  ---
Hmm. 8.0.43 fails in the same way.

Maybe the 8.0.43 tested by the OP was configured in such a way that this
worked?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62036] Roles stripped when using programmatic login() in tomcat 8.5 but not 8.0

2018-01-24 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=62036

--- Comment #6 from Mark Thomas  ---
I see the same behaviour with trunk 8.0.x. This looks like a regression between
8.0.43 and 8.0.49. Nothing obvious in the change log. Still looking.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62032] NPE caused by Connector and SSLHostConfig

2018-01-24 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=62032

--- Comment #4 from Coty Sutherland  ---
(In reply to Mark Thomas from comment #3)
> We should check that the behaviour is consistent for:
> - no keystore or PEM file specified

This behaves the same as the bugzilla description (throws an NPE).

> - keystore specified but file does not exist

SSLUtilBase.getStore() throws a FNFE with a nice message and stack trace which
is logged again by StandardService.initInternal() when the Connector fails to
init. I think we should remove the stack trace from SSLUtilBase.getStore()'s
log message (or maybe make it debug?) and keep the message so that the stack is
only printed once for the exception here.

> - PEM file specified but file does not exist

This one behaves really weirdly. Two (duplicate) warning messages are logged at
the same time from SSLHostConfig.adjustRelativePath() stating that the PEM file
does not exist. Then another warning from OpenSSLContext.init() saying that it
can't init the SSL context because there's no such file...but, the Connector
init doesn't fail and it binds as usual (albeit unusable). When you try and
access the Connector over https it gets rejected and the following is logged:

SEVERE [https-openssl-nio-8443-exec-1]
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun 
 java.lang.Exception: cannot create new ssl
at org.apache.tomcat.jni.SSL.newSSL(Native Method)
at
org.apache.tomcat.util.net.openssl.OpenSSLEngine.(OpenSSLEngine.java:213)
at
org.apache.tomcat.util.net.openssl.OpenSSLContext.createSSLEngine(OpenSSLContext.java:514)
at
org.apache.tomcat.util.net.AbstractJsseEndpoint.createSSLEngine(AbstractJsseEndpoint.java:162)


If you try the Connector over http, you'll get and 400 status response with a
"Bad Request" body.

I think all of these scenarios should be consistent experiences and behave like
scenario two above (throw a FNFE), with the amendment of only dumping the stack
once per exception.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: JDK 10 Early Access b40 & JDK 8u172 Early Access b02 are available on jdk.java.net

2018-01-24 Thread Mark Thomas 
On 22/01/18 10:18, Rory O'Donnell wrote:
>  Hi Mark,
> 
> Happy New Year!
> 
> *OpenJDK builds - *JDK 10 Early Access build 40 is available at
> http://jdk.java.net/10/

Builds OK.

Starts and stops without error. Quick smoke test with the WebSocket
examples looks OK.

Unit tests pass on Linux.

Overall, looking good.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot success in on tomcat-trunk

2018-01-24 Thread buildbot 
The Buildbot has detected a restored build on builder tomcat-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/2985

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1822094
Blamelist: markt

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1822094 - /tomcat/trunk/test/org/apache/coyote/http2/TestAbstractStream.java

2018-01-24 Thread markt 
Author: markt
Date: Wed Jan 24 10:54:49 2018
New Revision: 1822094

URL: http://svn.apache.org/viewvc?rev=1822094&view=rev
Log:
SpotBugs
Add a check to silence a warning
Trivial(ish) commit to test CI

Modified:
tomcat/trunk/test/org/apache/coyote/http2/TestAbstractStream.java

Modified: tomcat/trunk/test/org/apache/coyote/http2/TestAbstractStream.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/coyote/http2/TestAbstractStream.java?rev=1822094&r1=1822093&r2=1822094&view=diff
==
--- tomcat/trunk/test/org/apache/coyote/http2/TestAbstractStream.java (original)
+++ tomcat/trunk/test/org/apache/coyote/http2/TestAbstractStream.java Wed Jan 
24 10:54:49 2018
@@ -270,7 +270,7 @@ public class TestAbstractStream {
 Assert.assertEquals(b, d.getParentStream());
 
 // This triggers the StackOverflowError
-c.isDescendant(d);
+Assert.assertTrue(c.isDescendant(d));
 
 // Check children
 Assert.assertEquals(1,  handler.getChildStreams().size());



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Responsive Website for tomcat.apache.org

2018-01-24 Thread Konstantin Kolinko 
2018-01-24 12:43 GMT+03:00 Mark Thomas :
> On 20/01/18 03:04, Igal Sapir wrote:
>> UPDATE:
>>
>> On Fri, Jan 19, 2018 at 4:30 PM, Igal Sapir  wrote:
>>
>>> To clarify,
>>>
>>> I have updated the code for the site.  I have not updated the site itself
>>> since I'm not a committer (my previous statement seemed unclear).
>>>
>>> A committer needs to patch the tomcat-site accordingly.
>>>
>>
>> I made a small change and a second commit.  This changeset includes both
>> commits:
>> https://github.com/isapir/tomcat-site/compare/186404e...4046209
>> and this is the patch file that includes both:
>> https://github.com/isapir/tomcat-site/compare/186404e...4046209.patch
>
> Looks great. Patch applied many thanks.
>
> I don't suppose you are interested in making similar changes to the
> documentation web applications (the content gets copied to the web-site)
> and/or updating the Tomcat 7 docs to match the style of the others?

1. The "print view" of the page is important. One should be able to
print it. Especially the documentation.

I think that menu and search box were not visible when printing, but
one has to check.

2. The "GO" button on the search box looks off, misaligned.

3. We would have to update some documentation.

http://tomcat.apache.org/lists.html#tomcat-users
"2. Note, that Tomcat Documentation is provided on this site (see the
links at the left) and is searchable (see an input box above)."

4. Accessibility. Is it possible to operate the site without having a mouse?

If menu is closed, I cannot access the hamburger button with keyboard
(e.g. pressing tab), cannot open it.  And the text on the main page
does not provide other ways to access those parts of the site.

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62032] NPE caused by Connector and SSLHostConfig

2018-01-24 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=62032

--- Comment #3 from Mark Thomas  ---
No good reason I can recall.

We should check that the behaviour is consistent for:
- no keystore or PEM file specified
- keystore specified but file does not exist
- PEM file specified but file doe snot exist

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1822092 - in /tomcat/site/trunk: docs/download-90.html xdocs/download-90.xml

2018-01-24 Thread markt 
Author: markt
Date: Wed Jan 24 09:48:53 2018
New Revision: 1822092

URL: http://svn.apache.org/viewvc?rev=1822092&view=rev
Log:
Remove beta tag from 9.0.x

Modified:
tomcat/site/trunk/docs/download-90.html
tomcat/site/trunk/xdocs/download-90.xml

Modified: tomcat/site/trunk/docs/download-90.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-90.html?rev=1822092&r1=1822091&r2=1822092&view=diff
==
--- tomcat/site/trunk/docs/download-90.html (original)
+++ tomcat/site/trunk/docs/download-90.html Wed Jan 24 09:48:53 2018
@@ -213,7 +213,7 @@
 
 [define v]9.0.4[end]
 https://www.apache.org/dist/tomcat/tomcat-9/KEYS";>KEYS |
-[v] (beta) |
+[v] |
 Browse |
 https://archive.apache.org/dist/tomcat/tomcat-9";>Archives
   
@@ -261,7 +261,7 @@

   
 
-[v] (beta)
+[v]
 
   
 

Modified: tomcat/site/trunk/xdocs/download-90.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/download-90.xml?rev=1822092&r1=1822091&r2=1822092&view=diff
==
--- tomcat/site/trunk/xdocs/download-90.xml (original)
+++ tomcat/site/trunk/xdocs/download-90.xml Wed Jan 24 09:48:53 2018
@@ -20,7 +20,7 @@
 -->
 [define v]9.0.4[end]
 https://www.apache.org/dist/tomcat/tomcat-9/KEYS";>KEYS |
-[v] (beta) |
+[v] |
 Browse |
 https://archive.apache.org/dist/tomcat/tomcat-9";>Archives
   
@@ -65,7 +65,7 @@
   
 
   
-  
+  
   
   Please see the 
   README



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Responsive Website for tomcat.apache.org

2018-01-24 Thread Mark Thomas 
On 20/01/18 03:04, Igal Sapir wrote:
> UPDATE:
> 
> On Fri, Jan 19, 2018 at 4:30 PM, Igal Sapir  wrote:
> 
>> To clarify,
>>
>> I have updated the code for the site.  I have not updated the site itself
>> since I'm not a committer (my previous statement seemed unclear).
>>
>> A committer needs to patch the tomcat-site accordingly.
>>
> 
> I made a small change and a second commit.  This changeset includes both
> commits:
> https://github.com/isapir/tomcat-site/compare/186404e...4046209
> and this is the patch file that includes both:
> https://github.com/isapir/tomcat-site/compare/186404e...4046209.patch

Looks great. Patch applied many thanks.

I don't suppose you are interested in making similar changes to the
documentation web applications (the content gets copied to the web-site)
and/or updating the Tomcat 7 docs to match the style of the others?

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1822091 [2/4] - in /tomcat/site/trunk: docs/ docs/res/css/ docs/res/js/ xdocs/res/css/ xdocs/res/js/ xdocs/stylesheets/

2018-01-24 Thread markt 
Modified: tomcat/site/trunk/docs/migration-9.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration-9.html?rev=1822091&r1=1822090&r2=1822091&view=diff
==
--- tomcat/site/trunk/docs/migration-9.html (original)
+++ tomcat/site/trunk/docs/migration-9.html Wed Jan 24 09:41:27 2018
@@ -2,41 +2,36 @@
 
 
 
+
 
+
 Apache Tomcat® - Migration Guide - Tomcat 9.0.x
 
 
 
 
-
-
-
-
-
-http://tomcat.apache.org/";>
-
-
-
-https://www.apache.org/foundation/contributing.html"; 
target="_blank">https://www.apache.org/images/SupportApache-small.png"; alt="Support 
Apache" style="height: 83px; margin-right: 15px;">http://www.apache.org/"; target="_blank">
+
+
+
+
 
-Apache Tomcat®
+http://tomcat.apache.org/";>
+Apache Tomcat®
 
-
-
-https://www.google.com/search"; method="get">
-Search
-
-
-
-
-
+
+https://www.apache.org/foundation/contributing.html"; target="_blank" 
class="pull-left">https://www.apache.org/images/SupportApache-small.png"; class="support-asf" 
alt="Support Apache">http://www.apache.org/"; target="_blank" 
class="pull-left">
 
 
 
-
-
-
+
 
+
+
+
+https://www.google.com/search"; method="get">
+GO
+
+
 
 
 Apache Tomcat
@@ -943,16 +938,20 @@ of Apache Tomcat.
 
 
 
-
-
-
+
+
 Copyright © 1999-2018, The Apache Software Foundation
 
 Apache Tomcat, Tomcat, Apache, the Apache feather, and the Apache Tomcat
 project logo are either registered trademarks or trademarks of the Apache
 Software Foundation.
-  
-
+  
 
+
+  addLiveEventListeners(".menu-toggler", "click", function(evt){
+toggleClass("#mainLeft", "opened");
+toggleClass(".menu-toggler", "opened");
+  });
+
 
 

Modified: tomcat/site/trunk/docs/migration.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration.html?rev=1822091&r1=1822090&r2=1822091&view=diff
==
--- tomcat/site/trunk/docs/migration.html (original)
+++ tomcat/site/trunk/docs/migration.html Wed Jan 24 09:41:27 2018
@@ -2,41 +2,36 @@
 
 
 
+
 
+
 Apache Tomcat® - Migration Guide
 
 
 
 
-
-
-
-
-
-http://tomcat.apache.org/";>
-
-
-
-https://www.apache.org/foundation/contributing.html"; 
target="_blank">https://www.apache.org/images/SupportApache-small.png"; alt="Support 
Apache" style="height: 83px; margin-right: 15px;">http://www.apache.org/"; target="_blank">
+
+
+
+
 
-Apache Tomcat®
+http://tomcat.apache.org/";>
+Apache Tomcat®
 
-
-
-https://www.google.com/search"; method="get">
-Search
-
-
-
-
-
+
+https://www.apache.org/foundation/contributing.html"; target="_blank" 
class="pull-left">https://www.apache.org/images/SupportApache-small.png"; class="support-asf" 
alt="Support Apache">http://www.apache.org/"; target="_blank" 
class="pull-left">
 
 
 
-
-
-
+
 
+
+
+
+https://www.google.com/search"; method="get">
+GO
+
+
 
 
 Apache Tomcat
@@ -285,16 +280,20 @@ accordingly.
 
 
 
-
-
-
+
+
 Copyright © 1999-2018, The Apache Software Foundation
 
 Apache Tomcat, Tomcat, Apache, the Apache feather, and the Apache Tomcat
 project logo are either registered trademarks or trademarks of the Apache
 Software Foundation.
-  
-
+  
 
+
+  addLiveEventListeners(".menu-toggler", "click", function(evt){
+toggleClass("#mainLeft", "opened");
+toggleClass(".menu-toggler", "opened");
+  });
+
 
 

Modified: tomcat/site/trunk/docs/oldnews-2010.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/oldnews-2010.html?rev=1822091&r1=1822090&r2=1822091&view=diff
==
--- tomcat/site/trunk/docs/oldnews-2010.html (original)
+++ tomcat/site/trunk/docs/oldnews-2010.html Wed Jan 24 09:41:27 2018
@@ -2,41 +2,36 @@
 
 
 
+
 
+
 Apache Tomcat® - Old news! - 2010
 
 
 
 
-
-
-
-
-
-http://tomcat.apache.org/";>
+
+
+
+
 
-
-
-https://www.apache.org/foundation/contributing.html"; 
target="_blank">https://www.apache.org/images/SupportApache-small.png"; alt="Support 
Apache" style="height: 83px; margin-right: 15px;">http://www.apache.org/"; target="_blank">
-
-Apache Tomcat®
+http://tomcat.apache.org/";>
+Apache Tomcat®
 
-
-
-https://www.google.com/search"; method="get">
-Search
-
-
-
-
-
+
+https://www.apache.org/foundation/contributing.html"; target="_blank" 
class="pull-left">https://www.apache.org/images/SupportApache-small.png"; class="support-asf" 
alt="Support Apache">http://www.apache.org/"; target="_blank" 
class="pull-left">
 
 
 
-
-
-
+
 
+
+
+
+https://www.google.com/search"; method="get">
+GO
+
+
 
 
 Apache Tomcat
@@ -246,7 +241,7 @@
 
 
 
-2010-12-01 Tomcat 7.0.5 Released
+2010-12-01 Tomcat 7.0.5 Released
 
 
 
@@ -264,7 +259,7 @@ changelog.
 
 
 
-2010-11-01 Tomcat Connectors 1.2.31 
Released
+2010-11-01 Tomcat Connectors 1.2.31 
Released
 
 
 
@@ -275,7 +270,7 @@ This release includes mainly bug fixes a
 
 
 
-2010-10-21 Tomcat 7.0.4 Released
+2010-10-21 Tomcat 7.0.4 Released
 
 
 
@@ -

svn commit: r1822091 [3/4] - in /tomcat/site/trunk: docs/ docs/res/css/ docs/res/js/ xdocs/res/css/ xdocs/res/js/ xdocs/stylesheets/

2018-01-24 Thread markt 
Modified: tomcat/site/trunk/docs/oldnews.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/oldnews.html?rev=1822091&r1=1822090&r2=1822091&view=diff
==
--- tomcat/site/trunk/docs/oldnews.html (original)
+++ tomcat/site/trunk/docs/oldnews.html Wed Jan 24 09:41:27 2018
@@ -2,41 +2,36 @@
 
 
 
+
 
+
 Apache Tomcat® - Old news!
 
 
 
 
-
-
-
-
-
-http://tomcat.apache.org/";>
-
-
-
-https://www.apache.org/foundation/contributing.html"; 
target="_blank">https://www.apache.org/images/SupportApache-small.png"; alt="Support 
Apache" style="height: 83px; margin-right: 15px;">http://www.apache.org/"; target="_blank">
+
+
+
+
 
-Apache Tomcat®
+http://tomcat.apache.org/";>
+Apache Tomcat®
 
-
-
-https://www.google.com/search"; method="get">
-Search
-
-
-
-
-
+
+https://www.apache.org/foundation/contributing.html"; target="_blank" 
class="pull-left">https://www.apache.org/images/SupportApache-small.png"; class="support-asf" 
alt="Support Apache">http://www.apache.org/"; target="_blank" 
class="pull-left">
 
 
 
-
-
-
+
 
+
+
+
+https://www.google.com/search"; method="get">
+GO
+
+
 
 
 Apache Tomcat
@@ -246,7 +241,7 @@
 
 
 
-2017-11-30 Tomcat 8.5.24 Released
+2017-11-30 Tomcat 8.5.24 Released
 
 
 
@@ -285,7 +280,7 @@ changelog.
 
 
 
-2017-11-30 Tomcat 9.0.2 (beta) Released
+2017-11-30 Tomcat 9.0.2 (beta) Released
 
 
 
@@ -321,7 +316,7 @@ changelog.
 
 
 
-2017-10-03 Tomcat 8.0.47 Released
+2017-10-03 Tomcat 8.0.47 Released
 
 
 
@@ -366,7 +361,7 @@ changelog.
 
 
 
-2017-10-01 Tomcat 8.5.23 Released
+2017-10-01 Tomcat 8.5.23 Released
 
 
 
@@ -407,7 +402,7 @@ changelog.
 
 
 
-2017-09-30 Tomcat 9.0.1 (beta) Released
+2017-09-30 Tomcat 9.0.1 (beta) Released
 
 
 
@@ -444,7 +439,7 @@ changelog.
 
 
 
-2017-09-04 Tomcat Native 1.2.14 
Released
+2017-09-04 Tomcat Native 1.2.14 Released
 
 
 
@@ -473,7 +468,7 @@ Tomcat Native. The notable changes since
 
 
 
-2017-08-16 Tomcat 7.0.81 Released
+2017-08-16 Tomcat 7.0.81 Released
 
 
 
@@ -507,7 +502,7 @@ Full details of these changes, and all t
 
 
 
-2017-08-18 Tomcat 8.0.46 Released
+2017-08-18 Tomcat 8.0.46 Released
 
 
 
@@ -549,7 +544,7 @@ changelog.
 
 
 
-2017-08-08 Tomcat 8.5.20 Released
+2017-08-08 Tomcat 8.5.20 Released
 
 
 
@@ -589,7 +584,7 @@ changelog.
 
 
 
-2017-08-08 Tomcat 9.0.0.M26 (alpha) 
Released
+2017-08-08 Tomcat 9.0.0.M26 (alpha) 
Released
 
 
 
@@ -650,7 +645,7 @@ changelog.
 
 
 
-2017-07-01 Tomcat 8.0.45 Released
+2017-07-01 Tomcat 8.0.45 Released
 
 
 
@@ -693,7 +688,7 @@ changelog.
 
 
 
-2017-07-01 Tomcat 7.0.79 Released
+2017-07-01 Tomcat 7.0.79 Released
 
 
 
@@ -728,7 +723,7 @@ Full details of these changes, and all t
 
 
 
-2017-06-26 Tomcat 8.5.16 Released
+2017-06-26 Tomcat 8.5.16 Released
 
 
 
@@ -769,7 +764,7 @@ changelog.
 
 
 
-2017-06-26 Tomcat 9.0.0.M22 (alpha) 
Released
+2017-06-26 Tomcat 9.0.0.M22 (alpha) 
Released
 
 
 
@@ -809,7 +804,7 @@ changelog.
 
 
 
-2017-05-16 Tomcat 8.0.44 Released
+2017-05-16 Tomcat 8.0.44 Released
 
 
 
@@ -845,7 +840,7 @@ changelog.
 
 
 
-2017-05-16 Tomcat 7.0.78 Released
+2017-05-16 Tomcat 7.0.78 Released
 
 
 
@@ -878,7 +873,7 @@ Full details of these changes, and all t
 
 
 
-2017-05-10 Tomcat 8.5.15 Released
+2017-05-10 Tomcat 8.5.15 Released
 
 
 
@@ -915,7 +910,7 @@ changelog.
 
 
 
-2017-05-10 Tomcat 9.0.0.M21 (alpha) 
Released
+2017-05-10 Tomcat 9.0.0.M21 (alpha) 
Released
 
 
 
@@ -952,7 +947,7 @@ changelog.
 
 
 
-2017-04-18 Tomcat 8.5.14 Released
+2017-04-18 Tomcat 8.5.14 Released
 
 
 
@@ -988,7 +983,7 @@ changelog.
 
 
 
-2017-04-18 Tomcat 9.0.0.M20 (alpha) 
Released
+2017-04-18 Tomcat 9.0.0.M20 (alpha) 
Released
 
 
 
@@ -1026,7 +1021,7 @@ changelog.
 
 
 
-2017-04-07 Tomcat 6.0.53 Released
+2017-04-07 Tomcat 6.0.53 Released
 
 
 
@@ -1052,7 +1047,7 @@ Apache Tomcat 6.0.51.
 
 
 
-2017-04-02 Tomcat 7.0.77 Released
+2017-04-02 Tomcat 7.0.77 Released
 
 
 
@@ -1076,7 +1071,7 @@ Full details of these changes, and all t
 
 
 
-2017-04-02 Tomcat 8.0.43 Released
+2017-04-02 Tomcat 8.0.43 Released
 
 
 
@@ -1100,7 +1095,7 @@ changelog.
 
 
 
-2017-03-30 Tomcat 8.5.13 Released
+2017-03-30 Tomcat 8.5.13 Released
 
 
 
@@ -1137,7 +1132,7 @@ changelog.
 
 
 
-2017-03-30 Tomcat 9.0.0.M19 (alpha) 
Released
+2017-03-30 Tomcat 9.0.0.M19 (alpha) 
Released
 
 
 
@@ -1174,7 +1169,7 @@ changelog.
 
 
 
-2017-03-16 Tomcat 6.0.51 Released
+2017-03-16 Tomcat 6.0.51 Released
 
 
 
@@ -1212,7 +1207,7 @@ Apache Tomcat 6.0.48. The notable change
 
 
 
-2017-03-16 Tomcat 7.0.76 Released
+2017-03-16 Tomcat 7.0.76 Released
 
 
 
@@ -1247,7 +1242,7 @@ Full details of these changes, and all t
 
 
 
-2017-03-14 Tomcat 8.0.42 Released
+2017-03-14 Tomcat 8.0.42 Released
 
 
 
@@ -1283,7 +1278,7 @@ changelog.
 
 
 
-2017-03-13 Tomcat 8.5.12 Released
+2017-03-13 Tomcat 8.5.12 Released
 
 
 
@@ -1321,7 +1316,7 @@ changelog.
 
 
 
-2017-03-13 Tomcat 9.0.0.M18 (alpha) 
Released
+2017-03-13 Tomcat 9.0.0.M18 (alpha) 
Released
 
 
 
@@ -

svn commit: r1822091 [1/4] - in /tomcat/site/trunk: docs/ docs/res/css/ docs/res/js/ xdocs/res/css/ xdocs/res/js/ xdocs/stylesheets/

2018-01-24 Thread markt 
Author: markt
Date: Wed Jan 24 09:41:27 2018
New Revision: 1822091

URL: http://svn.apache.org/viewvc?rev=1822091&view=rev
Log:
Make web site responsive. Patch by Igal Sapir.

Added:
tomcat/site/trunk/docs/res/js/
tomcat/site/trunk/docs/res/js/tomcat.js   (with props)
tomcat/site/trunk/xdocs/res/js/
tomcat/site/trunk/xdocs/res/js/tomcat.js   (with props)
Modified:
tomcat/site/trunk/docs/bugreport.html
tomcat/site/trunk/docs/ci.html
tomcat/site/trunk/docs/conference.html
tomcat/site/trunk/docs/contact.html
tomcat/site/trunk/docs/download-70.html
tomcat/site/trunk/docs/download-80.html
tomcat/site/trunk/docs/download-90.html
tomcat/site/trunk/docs/download-connectors.html
tomcat/site/trunk/docs/download-native.html
tomcat/site/trunk/docs/download-taglibs.html
tomcat/site/trunk/docs/findhelp.html
tomcat/site/trunk/docs/getinvolved.html
tomcat/site/trunk/docs/heritage.html
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/docs/irc.html
tomcat/site/trunk/docs/legal.html
tomcat/site/trunk/docs/lists.html
tomcat/site/trunk/docs/maven-plugin.html
tomcat/site/trunk/docs/migration-6.html
tomcat/site/trunk/docs/migration-7.html
tomcat/site/trunk/docs/migration-8.html
tomcat/site/trunk/docs/migration-85.html
tomcat/site/trunk/docs/migration-9.html
tomcat/site/trunk/docs/migration.html
tomcat/site/trunk/docs/oldnews-2010.html
tomcat/site/trunk/docs/oldnews-2011.html
tomcat/site/trunk/docs/oldnews-2012.html
tomcat/site/trunk/docs/oldnews-2013.html
tomcat/site/trunk/docs/oldnews-2014.html
tomcat/site/trunk/docs/oldnews-2015.html
tomcat/site/trunk/docs/oldnews-2016.html
tomcat/site/trunk/docs/oldnews.html
tomcat/site/trunk/docs/presentations.html
tomcat/site/trunk/docs/res/css/tomcat.css
tomcat/site/trunk/docs/resources.html
tomcat/site/trunk/docs/security-3.html
tomcat/site/trunk/docs/security-4.html
tomcat/site/trunk/docs/security-5.html
tomcat/site/trunk/docs/security-6.html
tomcat/site/trunk/docs/security-7.html
tomcat/site/trunk/docs/security-8.html
tomcat/site/trunk/docs/security-9.html
tomcat/site/trunk/docs/security-impact.html
tomcat/site/trunk/docs/security-jk.html
tomcat/site/trunk/docs/security-native.html
tomcat/site/trunk/docs/security-taglibs.html
tomcat/site/trunk/docs/security.html
tomcat/site/trunk/docs/svn.html
tomcat/site/trunk/docs/taglibs.html
tomcat/site/trunk/docs/tomcat-55-eol.html
tomcat/site/trunk/docs/tomcat-60-eol.html
tomcat/site/trunk/docs/tomcat-80-eol.html
tomcat/site/trunk/docs/tools.html
tomcat/site/trunk/docs/whichversion.html
tomcat/site/trunk/docs/whoweare.html
tomcat/site/trunk/xdocs/res/css/tomcat.css
tomcat/site/trunk/xdocs/stylesheets/tomcat-site.xsl

Modified: tomcat/site/trunk/docs/bugreport.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/bugreport.html?rev=1822091&r1=1822090&r2=1822091&view=diff
==
--- tomcat/site/trunk/docs/bugreport.html (original)
+++ tomcat/site/trunk/docs/bugreport.html Wed Jan 24 09:41:27 2018
@@ -2,41 +2,36 @@
 
 
 
+
 
+
 Apache Tomcat® - Reporting Bugs
 
 
 
 
-
-
-
-
-
-http://tomcat.apache.org/";>
-
-
-
-https://www.apache.org/foundation/contributing.html"; 
target="_blank">https://www.apache.org/images/SupportApache-small.png"; alt="Support 
Apache" style="height: 83px; margin-right: 15px;">http://www.apache.org/"; target="_blank">
+
+
+
+
 
-Apache Tomcat®
+http://tomcat.apache.org/";>
+Apache Tomcat®
 
-
-
-https://www.google.com/search"; method="get">
-Search
-
-
-
-
-
+
+https://www.apache.org/foundation/contributing.html"; target="_blank" 
class="pull-left">https://www.apache.org/images/SupportApache-small.png"; class="support-asf" 
alt="Support Apache">http://www.apache.org/"; target="_blank" 
class="pull-left">
 
 
 
-
-
-
+
 
+
+
+
+https://www.google.com/search"; method="get">
+GO
+
+
 
 
 Apache Tomcat
@@ -991,16 +986,20 @@ See Security Rep
 
 
 
-
-
-
+
+
 Copyright © 1999-2018, The Apache Software Foundation
 
 Apache Tomcat, Tomcat, Apache, the Apache feather, and the Apache Tomcat
 project logo are either registered trademarks or trademarks of the Apache
 Software Foundation.
-  
-
+  
 
+
+  addLiveEventListeners(".menu-toggler", "click", function(evt){
+toggleClass("#mainLeft", "opened");
+toggleClass(".menu-toggler", "opened");
+  });
+
 
 

Modified: tomcat/site/trunk/docs/ci.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/ci.html?rev=1822091&r1=1822090&r2=1822091&view=diff
==
--- tomcat/site/trunk/docs/ci.html (original)
+++ tomcat/site/trunk/docs/ci.html Wed Jan 24 09:41:27 2018
@@ -2,40 +2,35 @@
 
 
 
+
 
+
 Apache Tomcat® - Continuous Integration
 
 
 
-
-
-
-
-
-http://tomcat.apa

svn commit: r1822091 [4/4] - in /tomcat/site/trunk: docs/ docs/res/css/ docs/res/js/ xdocs/res/css/ xdocs/res/js/ xdocs/stylesheets/

2018-01-24 Thread markt 
Modified: tomcat/site/trunk/docs/security-impact.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/security-impact.html?rev=1822091&r1=1822090&r2=1822091&view=diff
==
--- tomcat/site/trunk/docs/security-impact.html (original)
+++ tomcat/site/trunk/docs/security-impact.html Wed Jan 24 09:41:27 2018
@@ -2,41 +2,36 @@
 
 
 
+
 
+
 Apache Tomcat® - Security Impact Levels
 
 
 
 
-
-
-
-
-
-http://tomcat.apache.org/";>
-
-
-
-https://www.apache.org/foundation/contributing.html"; 
target="_blank">https://www.apache.org/images/SupportApache-small.png"; alt="Support 
Apache" style="height: 83px; margin-right: 15px;">http://www.apache.org/"; target="_blank">
+
+
+
+
 
-Apache Tomcat®
+http://tomcat.apache.org/";>
+Apache Tomcat®
 
-
-
-https://www.google.com/search"; method="get">
-Search
-
-
-
-
-
+
+https://www.apache.org/foundation/contributing.html"; target="_blank" 
class="pull-left">https://www.apache.org/images/SupportApache-small.png"; class="support-asf" 
alt="Support Apache">http://www.apache.org/"; target="_blank" 
class="pull-left">
 
 
 
-
-
-
+
 
+
+
+
+https://www.google.com/search"; method="get">
+GO
+
+
 
 
 Apache Tomcat
@@ -270,16 +265,20 @@
 
 
 
-
-
-
+
+
 Copyright © 1999-2018, The Apache Software Foundation
 
 Apache Tomcat, Tomcat, Apache, the Apache feather, and the Apache Tomcat
 project logo are either registered trademarks or trademarks of the Apache
 Software Foundation.
-  
-
+  
 
+
+  addLiveEventListeners(".menu-toggler", "click", function(evt){
+toggleClass("#mainLeft", "opened");
+toggleClass(".menu-toggler", "opened");
+  });
+
 
 

Modified: tomcat/site/trunk/docs/security-jk.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/security-jk.html?rev=1822091&r1=1822090&r2=1822091&view=diff
==
--- tomcat/site/trunk/docs/security-jk.html (original)
+++ tomcat/site/trunk/docs/security-jk.html Wed Jan 24 09:41:27 2018
@@ -2,41 +2,36 @@
 
 
 
+
 
+
 Apache Tomcat® - Apache Tomcat JK Connectors vulnerabilities
 
 
 
 
-
-
-
-
-
-http://tomcat.apache.org/";>
-
-
-
-https://www.apache.org/foundation/contributing.html"; 
target="_blank">https://www.apache.org/images/SupportApache-small.png"; alt="Support 
Apache" style="height: 83px; margin-right: 15px;">http://www.apache.org/"; target="_blank">
+
+
+
+
 
-Apache Tomcat®
+http://tomcat.apache.org/";>
+Apache Tomcat®
 
-
-
-https://www.google.com/search"; method="get">
-Search
-
-
-
-
-
+
+https://www.apache.org/foundation/contributing.html"; target="_blank" 
class="pull-left">https://www.apache.org/images/SupportApache-small.png"; class="support-asf" 
alt="Support Apache">http://www.apache.org/"; target="_blank" 
class="pull-left">
 
 
 
-
-
-
+
 
+
+
+
+https://www.google.com/search"; method="get">
+GO
+
+
 
 
 Apache Tomcat
@@ -426,16 +421,20 @@
 
 
 
-
-
-
+
+
 Copyright © 1999-2018, The Apache Software Foundation
 
 Apache Tomcat, Tomcat, Apache, the Apache feather, and the Apache Tomcat
 project logo are either registered trademarks or trademarks of the Apache
 Software Foundation.
-  
-
+  
 
+
+  addLiveEventListeners(".menu-toggler", "click", function(evt){
+toggleClass("#mainLeft", "opened");
+toggleClass(".menu-toggler", "opened");
+  });
+
 
 

Modified: tomcat/site/trunk/docs/security-native.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/security-native.html?rev=1822091&r1=1822090&r2=1822091&view=diff
==
--- tomcat/site/trunk/docs/security-native.html (original)
+++ tomcat/site/trunk/docs/security-native.html Wed Jan 24 09:41:27 2018
@@ -2,41 +2,36 @@
 
 
 
+
 
+
 Apache Tomcat® - Apache Tomcat APR/native Connector 
vulnerabilities
 
 
 
 
-
-
-
-
-
-http://tomcat.apache.org/";>
-
-
-
-https://www.apache.org/foundation/contributing.html"; 
target="_blank">https://www.apache.org/images/SupportApache-small.png"; alt="Support 
Apache" style="height: 83px; margin-right: 15px;">http://www.apache.org/"; target="_blank">
+
+
+
+
 
-Apache Tomcat®
+http://tomcat.apache.org/";>
+Apache Tomcat®
 
-
-
-https://www.google.com/search"; method="get">
-Search
-
-
-
-
-
+
+https://www.apache.org/foundation/contributing.html"; target="_blank" 
class="pull-left">https://www.apache.org/images/SupportApache-small.png"; class="support-asf" 
alt="Support Apache">http://www.apache.org/"; target="_blank" 
class="pull-left">
 
 
 
-
-
-
+
 
+
+
+
+https://www.google.com/search"; method="get">
+GO
+
+
 
 
 Apache Tomcat
@@ -303,16 +298,20 @@
 
 
 
-
-
-
+
+
 Copyright © 1999-2018, The Apache Software Foundation
 
 Apache Tomcat, Tomcat, Apache, the Apache feather, and the Apache Tomcat
 project logo are either registered trademarks or trademarks of the Apache
 Software Foundation.
-  
-
+  
 
+
+  addLiveEventListene

svn commit: r1822090 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2018-01-24 Thread violetagg 
Author: violetagg
Date: Wed Jan 24 09:25:56 2018
New Revision: 1822090

URL: http://svn.apache.org/viewvc?rev=1822090&view=rev
Log:
Update the release date for 7.0.84

Modified:
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1822090&r1=1822089&r2=1822090&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Wed Jan 24 09:25:56 2018
@@ -67,7 +67,7 @@
 
   
 
-
+
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r24408 - /dev/tomcat/tomcat-7/v7.0.84/ /release/tomcat/tomcat-7/v7.0.84/

2018-01-24 Thread violetagg 
Author: violetagg
Date: Wed Jan 24 09:21:39 2018
New Revision: 24408

Log:
Release 7.0.84

Added:
release/tomcat/tomcat-7/v7.0.84/
  - copied from r24407, dev/tomcat/tomcat-7/v7.0.84/
Removed:
dev/tomcat/tomcat-7/v7.0.84/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [RESULT][VOTE] Release Apache Tomcat 7.0.84

2018-01-24 Thread Violeta Georgieva 
Hi,

2018-01-19 17:41 GMT+02:00 Violeta Georgieva :
>
> The proposed Apache Tomcat 7.0.84 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.84/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1168/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_84/
>
> The proposed 7.0.84 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 7.0.84 Stable


+1 (binding):violetagg, huxing, remm, csutherl, markt

No other voters were cast.

The vote has passed.

I'll do the release shortly and announce it once the mirrors catch up.

Regards,
Violeta

svn commit: r1822089 - /tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

2018-01-24 Thread violetagg 
Author: violetagg
Date: Wed Jan 24 09:14:11 2018
New Revision: 1822089

URL: http://svn.apache.org/viewvc?rev=1822089&view=rev
Log:
Update the release date for 8.0.49

Modified:
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml?rev=1822089&r1=1822088&r2=1822089&view=diff
==
--- tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Wed Jan 24 09:14:11 2018
@@ -54,7 +54,7 @@
 
   
 
-
+
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r24407 - /dev/tomcat/tomcat-8/v8.0.49/ /release/tomcat/tomcat-8/v8.0.49/

2018-01-24 Thread violetagg 
Author: violetagg
Date: Wed Jan 24 09:07:59 2018
New Revision: 24407

Log:
Release 8.0.49

Added:
release/tomcat/tomcat-8/v8.0.49/
  - copied from r24406, dev/tomcat/tomcat-8/v8.0.49/
Removed:
dev/tomcat/tomcat-8/v8.0.49/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [RESULT][VOTE] Release Apache Tomcat 8.0.49

2018-01-24 Thread Violeta Georgieva 
Hi,

2018-01-19 23:08 GMT+02:00 Violeta Georgieva :
>
> The proposed Apache Tomcat 8.0.49 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.49/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1169/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_49/
>
> The proposed 8.0.49 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 8.0.49


+1 (binding):violetagg, remm, csutherl, markt

No other voters were cast.

The vote has passed.

I'll do the release shortly and announce it once the mirrors catch up.

Regards,
Violeta