[Bug 56343] NPE in org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer
https://issues.apache.org/bugzilla/show_bug.cgi?id=56343 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #9 from Mark Thomas ma...@apache.org --- This has been fixed in 8.0.x for 8.0.6 onwards and in 7.0.x 7.0.54 onwards. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56343] NPE in org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer
https://issues.apache.org/bugzilla/show_bug.cgi?id=56343 Remy Maucherat r...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID OS||All --- Comment #1 from Remy Maucherat r...@apache.org --- There's no bug in what you describe, it will use a static instance (rather than a new instance). -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56343] NPE in org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer
https://issues.apache.org/bugzilla/show_bug.cgi?id=56343 Przemyslaw Bielicki pbieli...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID |--- --- Comment #2 from Przemyslaw Bielicki pbieli...@gmail.com --- Hi, not really: Exception in thread main java.lang.NullPointerException at org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer(WsWebSocketContainer.java:259) at org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer(WsWebSocketContainer.java:198) at org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer(WsWebSocketContainer.java:215) at WsClient.main(WsClient.java:21) Cheers, Przemyslaw -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56343] NPE in org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer
https://issues.apache.org/bugzilla/show_bug.cgi?id=56343 --- Comment #3 from Mark Thomas ma...@apache.org --- Please provide test case (with all source code) for the simplest possible client (I'd strongly suggest the client connects to the Tomcat WebSocket echo example on localhost, port 8080 for easy testing) that demonstrates this issue. That will enable us to figure out exactly what is going on here. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56343] NPE in org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer
https://issues.apache.org/bugzilla/show_bug.cgi?id=56343 --- Comment #4 from Przemyslaw Bielicki pbieli...@gmail.com --- Created attachment 31470 -- https://issues.apache.org/bugzilla/attachment.cgi?id=31470action=edit WsClient.java main class -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56343] NPE in org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer
https://issues.apache.org/bugzilla/show_bug.cgi?id=56343 --- Comment #5 from Przemyslaw Bielicki pbieli...@gmail.com --- Created attachment 31471 -- https://issues.apache.org/bugzilla/attachment.cgi?id=31471action=edit EchoClient.java websocket client endpoint -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56343] NPE in org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer
https://issues.apache.org/bugzilla/show_bug.cgi?id=56343 --- Comment #6 from Przemyslaw Bielicki pbieli...@gmail.com --- small tip: I'm not using tomcat-websocket-api.jar - I'm using the official javax.websocket-api-1.0.jar instead -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56343] NPE in org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer
https://issues.apache.org/bugzilla/show_bug.cgi?id=56343 --- Comment #7 from Przemyslaw Bielicki pbieli...@gmail.com --- and I found that there are some discrepancies in ClientEndpointConfig.java between Tomcat and JSR jars. IMHO you should align Tomcat WebSocket API to match the one from JSR, to avoid such nasty errors. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56343] NPE in org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer
https://issues.apache.org/bugzilla/show_bug.cgi?id=56343 --- Comment #8 from Mark Thomas ma...@apache.org --- The public API for the Tomcat implementation of the Java WebSocket 1.0 API and any other implementation (inlcuding the RI) should be identical. I was checking this regularly all the way through development so there should not be any differences. If you have spotted a difference in the public API then please open a separate Bugzilla issue for that. Note that the actual implementation beind the API may well differ. What appears to have happened here is that the Tomcat implementation and the RI are both correctly treating a null client configurator as meaning use the default NO-OP implementation but Tomcat and the RI have implemented that differently. The differences stem from Tomcat's desire to have a single default Configurator instance to reduce memory footprint and GC. The difference is problematic because the difference crosses the boundary between the API classes and the implementation classes. I'm leaning towards calling this a bug in Tomcat primarily because of the Javadoc for ClientEndpointConfig.Builder.configurator(). Tomcat calls this with null which arguably is the wrong thing to do. It would certainly be safer (and should have the same end result) not to call the method at all in this case. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
