[Bug 56397] Establish parallel Maven-based build process
https://bz.apache.org/bugzilla/show_bug.cgi?id=56397 Mark Thomas ma...@apache.org changed: What|Removed |Added Resolution|--- |LATER Status|NEW |RESOLVED --- Comment #49 from Mark Thomas ma...@apache.org --- This is in place (with no much interest for a while now) so as per comment #1 I'm closing this as LATER. We can resurrect this issue then next time the Why doesn't Tomcat move to Maven? thread kicks off on dev. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #48 from Mark Thomas ma...@apache.org --- Patch applied. Sorry it took a while. I dropped this part of the source tree from my checkout because svn up was so slow. I now have a dedicated checkout for this. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #47 from Pierre Viret pierre.vi...@gmail.com --- Can you please check my last patch and commit it if it's ok? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 Pierre Viret pierre.vi...@gmail.com changed: What|Removed |Added Attachment #32151|0 |1 is obsolete|| --- Comment #46 from Pierre Viret pierre.vi...@gmail.com --- Created attachment 32229 -- https://issues.apache.org/bugzilla/attachment.cgi?id=32229action=edit patch for tomcat-maven-layout created with svn diff -x -u - Updated the version of the poems to 9.0.0-SNAPSHOT - created tomcat-tests component containing all the tests - add a 'utils' artifact created by the web examples component and needed by the tests (for TestCookieFilter) I have tried to split the test into the components but it's quite complicated because of the dependencies. So I have simply added a new component with all the tests so that it is possible to start the tests using maven (one can select the tests to be run using -Dtest=xyz) or with the IDE. This is not optimal yet but I think this is a good starting point. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #45 from Mark Thomas ma...@apache.org --- Patch applied. Many thanks. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 Pierre Viret pierre.vi...@gmail.com changed: What|Removed |Added Attachment #32120|0 |1 is obsolete|| --- Comment #44 from Pierre Viret pierre.vi...@gmail.com --- Created attachment 32151 -- https://issues.apache.org/bugzilla/attachment.cgi?id=32151action=edit patch for tomcat-maven-layout created with svn diff -x -u This patch adds filtering for some webapp files so that the version number gets displayed in the standard tomcat web app. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 Pierre Viret pierre.vi...@gmail.com changed: What|Removed |Added Attachment #32113|0 |1 is obsolete|| --- Comment #42 from Pierre Viret pierre.vi...@gmail.com --- Created attachment 32120 -- https://issues.apache.org/bugzilla/attachment.cgi?id=32120action=edit patch for tomcat-maven-layout created with svn diff -x -u This new patch contains following fixes: - add the service configuration in META-INF from some jars (thanks Mark for the tip!) - fix tomcat-websocket svn:externals to import the correct java classes (it contained the api classes...) - implement a workaround for the problem with the empty logs temp dirs -- now the tomcat server starts and the standard web-application is displayed quite correctly ! I haven't verified it yet but it looks nice ;-) Next steps: - verify the standard web-applications (f.i. manager) - implement the tests I'm off for 10 days for vacation and without my computer so you will hear from me again at the beginning of november :-) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #43 from Mark Thomas ma...@apache.org --- Nice. This passes a simple smoke test (WebSocket snake game). One thing to think about when you get back is how to translate the version number filtering to Maven. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #41 from Mark Thomas ma...@apache.org --- Great. The instance starts for me too. I suspect the issue with JSPs is that Jasper is not getting initialized. If you look in trunk/res/META-INF you'll see various files that need to be packaged with the JARs. The important one here is, I suspect, Jasper's SCI. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #38 from Pierre Viret pierre.vi...@gmail.com --- Something went wrong with the patch: I had renamed the dir: apache-tomcat/src/main/resoucres/ To : apache-tomcat/src/main/resources but maybe the svn mv was not contained in the patch?? Can you please try to svn mv the dir directly? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #39 from Mark Thomas ma...@apache.org --- That fixed it. It looks like (from a quick glance at the stack traces) the problem is that the mbean-descriptor.xml files are not being included in the JARs. They need to appear in the same package as they do in the source tree. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 Pierre Viret pierre.vi...@gmail.com changed: What|Removed |Added Attachment #32108|0 |1 is obsolete|| --- Comment #40 from Pierre Viret pierre.vi...@gmail.com --- Created attachment 32113 -- https://issues.apache.org/bugzilla/attachment.cgi?id=32113action=edit patch for tomcat-maven-layout created with svn diff -x -u Thanks for your hint, you were right: this patch fixes this, the non-java files from the src dir are now added as resources. I had to add dummy files for logs temp dirs to get created (seems assembly won't create empty dirs). Now the server can be started successfully! The default web applications still do not work (some problem with the JSP), I will have to analyse this. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #37 from Mark Thomas ma...@apache.org --- Patch applied. I still don't see the scripts or the conf directory being created. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #35 from Mark Thomas ma...@apache.org --- No need to think too much about git at the moment. There doesn't seem to be much interest in moving right now. Patche are all applied and the build completes. I don't see the startup scripts or the config files in Tomcat instance that gets created. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 Pierre Viret pierre.vi...@gmail.com changed: What|Removed |Added Attachment #32101|0 |1 is obsolete|| --- Comment #36 from Pierre Viret pierre.vi...@gmail.com --- Created attachment 32108 -- https://issues.apache.org/bugzilla/attachment.cgi?id=32108action=edit Patch for tomcat-maven-layout created with svn diff -x -u This patch contains following changes: - fix typo in name of dir apache-tomcat/src/main/resources - work on docs web app (the most files are generated but the content could not be tested yet) - apache-tomcat now generates the structure correctly (bin, conf, ...) The server can be started but there are SEVERE errors: I suppose that some classes are missing somewhere in the jars. Next steps: - check every jars generated by maven if it contains all needed classes (compare with the ant build output) - fix the errors until the server can start correctly - implement the tests: maybe I should start with this step as it could show if some class is missing in some generated jar. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 Pierre Viret pierre.vi...@gmail.com changed: What|Removed |Added Attachment #32088|0 |1 is obsolete|| --- Comment #34 from Pierre Viret pierre.vi...@gmail.com --- Created attachment 32101 -- https://issues.apache.org/bugzilla/attachment.cgi?id=32101action=edit Fixes some bugs which broke the mvm build This patch fixes some bugs: after applying it the master project should be successfully built. - tomcat-webapps/docs/pom.xml was not in the last patch (I think I did something wrong with svn): I have updated it to 'my' version. - commented out the module jdbc-pool from master project as it does not build yet : see https://issues.apache.org/bugzilla/show_bug.cgi?id=57005 where a patch is still waiting to be committed. About git: if it's not urgent I think I will first finish the implementation of the maven build, and afterwards I can try to find a solution for git (for instance using the mirror https://github.com/apache/tomcat.git). -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 Mark Thomas ma...@apache.org changed: What|Removed |Added Attachment #32088|0 |1 is patch|| -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #32 from Mark Thomas ma...@apache.org --- I have applied your patch. I had to apply some bits manually so apologies if any bits got lost. I'm done a simple test on my dev machine. svn up on the Maven layout takes ~2 minutes. svn up on /trunk takes 1-2 seconds. I remain concerned about the viability of this approach but I'm happy to keep applying patches if you are happy to continue. Regarding the move to git. Nothing is certain at this point. I'm not even sure that there is consensus amongst the committers to make the move at this point. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #33 from Mark Thomas ma...@apache.org --- Looks like tomcat-webapps/docs/pom.xml is missing -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #30 from Mark Thomas ma...@apache.org --- Something to think about. Tomcat might be moving to git. svn externals will no longer be available. How would you solve this then? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 Pierre Viret pierre.vi...@gmail.com changed: What|Removed |Added Attachment #32077|0 |1 is obsolete|| --- Comment #31 from Pierre Viret pierre.vi...@gmail.com --- Created attachment 32088 -- https://issues.apache.org/bugzilla/attachment.cgi?id=32088action=edit Patch for tomcat-maven-layout Here a patch containing the whole maven hierarchy. The build can be performed in this way: $ cd trunk-maven-layout $ mvn clean install $ cd apache-tomcat/target/apache-tomcat-8.0.13-SNAPSHOT-distrib/apache-tomcat-8.0.13-SNAPSHOT/bin/ $ ./startup.sh The server starts but if you open your browser with http://12.0.0.1:8080 you only get a white page: this is because the web apps are not ok for now, the rewriting of the config files is not correct. Following points are still opened: - fix the web apps - fix the apache-tomcat project until the server can be started without error - docs web apps: I have not implemented all the xslt transformations yet - tests: still not implemented yet. About git: I think there are solutions, but I have no experience with this for now. See for instance: http://stackoverflow.com/questions/571232/svnexternals-equivalent-in-git Do you have an idea when tomcat might move to git? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #28 from Mark Thomas ma...@apache.org --- A few questions/comments on the proposed patch 1. Why has the license header been removed from pom.xml? 2. Every pom.xml file should have a license header. 3. Why has the url element been removed from a number of pom files? 4. Indentation is inconsistent. 2 spaces or 4 spaces (never tabs). Pick one and use it consistently. 5. Why has scopetestscope/ been removed from the junit dependencies? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #29 from Pierre Viret pierre.vi...@gmail.com --- Thank you for your feedback. Here my answers: 1. Why has the license header been removed from pom.xml? 2. Every pom.xml file should have a license header. -- I've just forgotten to copy it, I will fix this 3. Why has the url element been removed from a number of pom files? -- as it is defined in the master project I think this was not necessary to define it redundantly in the sub-projects: it is automatically inherited. But if I execute mvm help:effective-pom in a sub-project it seems that the url from parent get automatically extended with the sub-project id (i.e. urlhttp://tomcat.apache.org/tomcat-catalina/url for tomcat-catalina sub-project). I will check this and insert the url again. 4. Indentation is inconsistent. 2 spaces or 4 spaces (never tabs). Pick one and use it consistently. -- I will fix this 5. Why has scopetestscope/ been removed from the junit dependencies? -- the scope test is defined per default in the master project DependencyManagement section for junit, so it is automatically inherited: dependency groupIdjunit/groupId artifactIdjunit/artifactId version4.11/version scopetest/scope /dependency I will fix the problems and upload a new patch tomorrow. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #24 from Pierre Viret pierre.vi...@gmail.com --- I'm getting troubles with the svn:externals and the fact that my changes were never committed: I always got some svn errors like Path xyz has no committed revision. Did you try to commit my patch? As I didn't modify any real source but only the files in sandbox/trunk-maven-layout there is no risk that something get broken. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #25 from Mark Thomas ma...@apache.org --- No, your patch hasn't been applied. I won't be applying it as I don't believe externals alone are a viable solution. It is too slow to do svn up. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #26 from Pierre Viret pierre.vi...@gmail.com --- OK I understand and can accept your point. I will try to implement it using so few externals as possible and upload a corresponding patch. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 Pierre Viret pierre.vi...@gmail.com changed: What|Removed |Added Attachment #32072|0 |1 is obsolete|| --- Comment #27 from Pierre Viret pierre.vi...@gmail.com --- Created attachment 32077 -- https://issues.apache.org/bugzilla/attachment.cgi?id=32077action=edit patch for tomcat-maven-layout: 2nd try In this new patch I use so few svn:externals as possible and exclude the sources in the maven configuration if necessary. There is still work to do, but following is implemented: - master project in the root of tomcat-maven-layout directory: it can be used to build all the maven modules - many JAR components are implemented - the tomcat-extras-juli adapters jars were implemented to show how we can relocate classes from external libraries I plan to perform following steps next week: - implement the web apps (module tomcat-webapps) - build a working instance (same as output/build with ant) - add the tests Please let me know if there is any problem with the patch. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #22 from Mark Thomas ma...@apache.org --- Comment on attachment 32072 -- https://issues.apache.org/bugzilla/attachment.cgi?id=32072 Patch for tomcat-maven-layout created with svn diff -x -u I do not believe that your current approach is viable. Calling svn up on an external is a relatively slow process. One external per module is just about OK. 30-40 externals per module is not. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #23 from Pierre Viret pierre.vi...@gmail.com --- I have seen that the update takes some time but it is difficult for me to say if this is really an issue or not, as the external definitions are not committed yet. On one hand the update is slower, on the other hand there are advantages with this approach: - The file system is correct, we really have the files where they belong to -- all shell commands working on the source files (find / grep and so on) can be used without problem. - we don't need to care about IDE filters and configurations - we use the standard maven layout and no special configuration regarding sources is needed: this is a big advantage and could avoid problems with some plugins. - later, if we decide to move from ant to maven then we don't need to change the maven configurations and processing anymore. Let's not forget that this is just an experiment and that if, later, the maven layout is estimated to be a good thing then it would make sense to move the sources to the corresponding modules and the svn:externals would not be needed anymore. OMHO it makes sense to experiment using this approach as it is cleaner from a maven point of vue and it seems easyier to implement the build on the maven side. So my proposal is to go one with this approach. If the feedback we get from the community is that the svn update is too slow, then we can always optimize this in a second step, but at the moment I think it is more important to get a maven build running. As soon as the svn:externals definitions are committed I will be able to test the svn updates and maybe I quickly come to your point of vue that this is too slow ;-) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 Pierre Viret pierre.vi...@gmail.com changed: What|Removed |Added Attachment #32016|0 |1 is obsolete|| Attachment #32017|0 |1 is obsolete|| Attachment #32044|0 |1 is obsolete|| --- Comment #21 from Pierre Viret pierre.vi...@gmail.com --- Created attachment 32072 -- https://issues.apache.org/bugzilla/attachment.cgi?id=32072action=edit Patch for tomcat-maven-layout created with svn diff -x -u New version of the patch. As the first patch was not committed yet this one can be committed directly. I hope there won't be any issue with the svn:externals because for now I get strange errors when I try to svn update the tomcat-maven-layout directory. I've mainly worked on tomcat-examples: this project generates the examples for the tomcat instance (exactly like what ant creates in output/build/webapps/examples). My next step will be to finish the implementation of the apache-tomcat project, which generates the whole working instance (output/build). I think that I will have some time today to do it. With this actual implementation, no special configuration of the IDE is necessary: simply open the master project in NetBeans and you can build work with all components immediately. I have not tested it with eclipse for now. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #20 from Pierre Viret pierre.vi...@gmail.com --- Created attachment 32044 -- https://issues.apache.org/bugzilla/attachment.cgi?id=32044action=edit patch to be applied in tomcat_maven_layout created with svn diff I have created the necessary source directories and updated the svn:externals to select only the source files needed by each component. I can build the master project successfully in NetBeans. Can you please check commit the patch? The next step will be to create the structure externals for the tests. I have met following issue: - tomcat-util / tomcat-util-scan: org.apache.tomcat.util.file is in both components as defined in the ant file patterns. As tomcat-util-scan depends on tomcat-util I propose to remove it from tomcat-util-scan. - tomcat-api / tomcat-dbcp: org/apache/tomcat/dbcp is in both components as defined in the ant file patterns. Is it necessary or should I remove it from tomcat-api? I was positively surprised with svn externals: it is possible to set the svn:externals property on a directory which I have simply added to svn, and then with svn update to populate it's content, even without having committed the directory. So I (unfortunately ;-) ) do not need to be able to commit to svn myself. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #19 from Mark Thomas ma...@apache.org --- (In reply to Pierre Viret from comment #18) Would it be possible for me to commit to the sandbox/trunk-maven-layout repository? Not until the dev community decides to offer you committership ;) I don't know how I can try test the svn externals without being able to commit to the repository. This is due to the fact that one has to update the svn:external property, commit then perform an update to get the files checked out through the externals. What do you think? Do you have a solution for this? Yes. The restriction is that the directory on which the external is defined must be in svn. The property does not need to be checked in for the external to work. I suggest you create a patch that adds all the necessary empty directories to the existing structure. I (or another committer) can then commit it. With that in place you can experiment with externals. Maybe an alternative would be to create my own local svn repository so that I can commit there and import the head of trunk of the sandbox/tomcat-maven-layout directory there. But I fear that it would get messy and very difficult to synchronize my changes back to the official repository... Agreed. On the subject of IDEs and POM level filters, most IDEs allow you to filter out unwanted sources so we could provide sample IDE configs - like we do for the main Tomcat build - in a suitable location. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #17 from Pierre Viret pierre.vi...@gmail.com --- The use of filters for the maven-compiler-plugin in the pom is not optimal: in the IDE you see all the classes under the component, even if they are excluded through filters in pom. I don't think that we can work this out. So on my opinion we have to try to implement the svn externals for all modules even if it's painful. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #18 from Pierre Viret pierre.vi...@gmail.com --- Would it be possible for me to commit to the sandbox/trunk-maven-layout repository? I don't know how I can try test the svn externals without being able to commit to the repository. This is due to the fact that one has to update the svn:external property, commit then perform an update to get the files checked out through the externals. What do you think? Do you have a solution for this? Maybe an alternative would be to create my own local svn repository so that I can commit there and import the head of trunk of the sandbox/tomcat-maven-layout directory there. But I fear that it would get messy and very difficult to synchronize my changes back to the official repository... -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #9 from Mark Thomas ma...@apache.org --- Thanks for this. I still want to try and create the svn externals as that means the Maven build would be based directly on svn and folks would be able to commit / propose patches / merge updates much more easily. I intended to start on this on Monday but got somewhat side-tracked with other things. One issue I did not want to forget. The patch mentions a circular dependency. That is bad and I thought we had got rid of all of those. I know I could work out the details for myself but if you have them handy it would be very helpful if you could add them here. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #10 from Pierre Viret pierre.vi...@gmail.com ---
Thank you very much for your feedback.
1) About the circular dependency: the pattern for the tomcat-coyote component
selects the file org/apache/tomcat/util/net/Constants.java.
This class is referenced by
org.apache.tomcat.util.threads.TaskThreadFactory.java which belongs to the
tomcat-util component. Actually only one constant field is used:
This field is defined like this in the Constants class:
public static final boolean IS_SECURITY_ENABLED =
(System.getSecurityManager() != null);
I think we can get rid of the circular dependency simply by modifying the
TaskThreadFactory class: replace the two lines which use the constant:
if (Constants.IS_SECURITY_ENABLED) {
With following: if (System.getSecurityManager() != null) {
and we should get the same result.
2) About the svn externals: this would be great! I don't know this feature so I
will study the svn documentation to understand how this would work. For
instance, is it possible to reuse the ant patterns defined in the build.xml
for selecting the right sources for each component?
3) I have started the implementation of a new maven project: apache-tomcat
which would create the distributions (as we can download them from
http://tomcat.apache.org/download-80.cgi). I will upload the new version of the
maven project files and the patch for the build.xml in this bug as soon as I
have a working base which would show how this can be implemented.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #11 from Pierre Viret pierre.vi...@gmail.com --- Sorry about the circular dependency I forgot to mention that tomcat-coyote needs tomcat-util to compile, so tomcat-util may not depend on the tomcat-coyote. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #12 from Mark Thomas ma...@apache.org --- I am making progress. The structure is in svn, the sources for JULI are hooked up via externals and the tomcat-juli-8.0.13-SNAPSHOT.jar that is created looks reasonable (I haven't tested it). If we want this to be a way folks familiar with Maven can work with the source, that is one thing (and I think we have most of whet we need once the svn externals are finished). If we want users to be able to use this to build a working Tomcat distribution, that is is more complex. If we want to be able to use this to build a release that is more complex again. Working with the source: 1. How do you propose to update the version number after a release? Updating every POM by hand is not viable. 2. The JARs need to contain the right LICENSE and NOTICE file. Even if they aren't meant to be released, someone will distribute them somewhere, somehow. Working instance: 3. How do we get to this point? Distribution: 4. Can source JARs are be created? 5. Windows installer, signing etc. For this to be useful I think it has to be possible to create a working Tomcat instance. I'm far less concerned about being able to release. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #13 from Mark Thomas ma...@apache.org --- Mmm. Because of what needs to be filtered, the use of externals is going to get painful for some modules. I'm wondering if there is a better solution. The modules aspect of this is good. Is it possible to point a module at standard Tomcat checkout (i.e. the full source tree) and then tell Maven to filter that to only include the classes we want for that module? If yes, would this work (including in an IDE) if the source tree was outside of the modules or would you need a complete Tomcat checkout in each module? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #14 from Mark Thomas ma...@apache.org --- For the record a narrow as possible single external combined with include/exclude filters in the POM looks like a good solution. I'll update the existing modules that use multiple externals to use this approach. A new problem has emerged. The unit tests (which in many cases are more like integration tests) have all sorts of circular dependencies. Suggestions on how to handle this welcome. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #15 from Pierre Viret pierre.vi...@gmail.com --- Here my answers to the first comment: Working with the source: 1. How do you propose to update the version number after a release? Updating every POM by hand is not viable. -- I use the maven-versions-plugin with several big projects for this (http://mojo.codehaus.org/versions-maven-plugin). The goal versions:set is exactly what we need and this works very well. But if you have some inconsistency in the versions of your project hierarchy you have to fix them by hand. 2. The JARs need to contain the right LICENSE and NOTICE file. Even if they aren't meant to be released, someone will distribute them somewhere, somehow. -- this should not be a big issue. There are several ays to achieve this, I think that one good solution is too define a component containing global ressources, each component needing these files depends on this one and can pull the files using dependency-plugin in the generate-resources phase. Another solution would be to add the files as ressource in each component using svn externals, into src/main/resources dir of the component then the files are added to the jar. But on my opinion the first solution is easier. Working instance: 3. How do we get to this point? -- Is the working instance what the ant build generates under output/build ? Actually what I have begun to implement for generating the distributions is quite the same as the working instance I think. Distribution: 4. Can source JARs are be created? -- yes this is easy 5. Windows installer, signing etc. -- I have no experience with Windows installer. Signing should not be a problem. It is possible to perform some steps in the maven build using ant targets so everything we can do with ant should be possible with maven. I have used this (the maven-antrun-plugin) for a project where we call some ant tasks of Weblogic Server to generate Security Providers. I will have again time to work on this Friday afternoon. Are you working on some branch in svn for the svn externals ? How should I checkout the sources to get what you have implemented for JULI ? I have checkout the trunk but I didn't see anything about externals references. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #16 from Pierre Viret pierre.vi...@gmail.com --- I've just figured out where you have performed the changes (tomcat/sandbox/trunk-maven-layout/) so I will be able to check this out on Friday. Regarding the tests: I have not tried to integrate the tests in the maven components yet. A good practice in maven is to split the integration tests in separate components which are built tested late in the build cycle, when all base components are already built and can be referenced. Only the real unit tests, which run quickly (if they last more than a couple of seconds then we risk that the developers skip them...) should be integrated in the corresponding component and so the developer get at once a feedback if something is broken at this level. If some test classes are widely used then a solution is to create a common-test component containing all these utility classes which is then added as dependency (with scope test) in the other components. One other (quick dirty) solution would be to create one single test component and put all the tests there, but I think this should only be used in a first throw and that we should integrate the real unit-tests in the corresponding components as soon as possible. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #6 from Pierre Viret pierre.vi...@gmail.com --- Created attachment 32016 -- https://issues.apache.org/bugzilla/attachment.cgi?id=32016action=edit tar containing the maven pom.xml files and the directories See README-MAVEN.txt file for usage -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #7 from Pierre Viret pierre.vi...@gmail.com --- Created attachment 32017 -- https://issues.apache.org/bugzilla/attachment.cgi?id=32017action=edit README for setting up maven for tomcat This file contains a small how-to explaining the steps needed to set up maven projects for tomcat. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #8 from Pierre Viret pierre.vi...@gmail.com --- I have implemented an EXPERIMENTAL set of maven projects for the tomcat components. The main idea is that the sources are simply copied from the central repository to an existing maven projects' tree. Everyone can download the readme, patch the build.xml, unpack the tar with the maven project files and enjoy maven projects. This works well for me and I can work with the projects in NetBeans. This is experimental and has to be verified and tested in depth (f.i. compare the jars created by maven and the jars created by ant). The advantage of this solution is that we can take any revision of the tomcat source tree and (so long the main source packages of the components were not refactored) generate the maven project out of it. My proposal: we can now set up the maven projects so that they really build 100% what we want, without impacting the ant build. When we are ready to switch to maven then the work remaining is to svn move the source packages to the corresponding maven modules. This is not a parallel build system but could be very interesting for experimentation and developing the maven build. Please feel free to try it out and give me feedback. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #5 from Pierre Viret pierre.vi...@gmail.com --- I have already migrated several projects from ant to maven and I like this kind of challenge. I'm ready to help here. So my fist question is: do you need some help? If the answer is positive: can you please explain what is the actual status of the work? I would not like to start something and hear several weeks later that it was already done by someone else ;-) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 Pierre Viret pierre.vi...@gmail.com changed: What|Removed |Added CC||pierre.vi...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #3 from Remy Maucherat r...@apache.org --- Ok, let me know when the basics are in. Although I did put in place the single source tree, which worked fine, and it's great if it has been useful for a (long) while. OTOH people keep whining about Maven, IDEs got better at handling Maven style projects, and the Ant build script is indeed meh (the Maven fans have a point there). -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #4 from Tim Whittington t...@apache.org --- and the Ant build script is indeed meh (the Maven fans have a point there). Also Ant as a project appears to be in some difficulty - 1.8 and 1.9 (until I patched it, and I'm still suspicious of some intermittent exec failures) completely borked the performance of native execs and went unfixed for _years_, so 1.7.1 is pretty much state of the art for many real-world builds. If you have time/interest, Gradle might be worth exploring, since it seems to tread the line between the flexibility of Ant and the conventional structure and publishing of Maven (I don't care to discuss the relative merits of lack thereof). -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #1 from Remy Maucherat r...@apache.org --- I don't see how this is doable or useful since the point of maven is to accept its source code structure and componentization. IMO it is either Tomcat switches cleanly to Maven (or another similar one) for a next version or it stays with the current Ant build. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56397] Establish parallel Maven-based build process
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #2 from Mark Thomas ma...@apache.org --- This is one of the things discussed at the Tomcat Summit this week. My proposal was to start a multi-module maven project in the sandbox using svn externals to pull in the relevant bits of Tomcat source for each module. I'd create a couple of modules to see if it was doable and then leave it for the next Maven fan who comes along championing a switch to finish off. If they are able to create a working build then at that point the community can compare the Maven build and the Ant build and decide which is best. I plan to close this issue as LATER once I have the first couple of modules created. Right now I am not at all convinced of the benfits of switching - I think your move to a single source tree was one of the best things we ever did for making the code easier to work with - but switching to Maven keeps coming up and rather than yet another abstract discussion this provides a mechansim for us to have something concrete to compare. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
