Re: [VOTE] Release Apache Tomcat 8.5.18
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, I'm repeating all tests for the 8.5.19 release, so I'll see if I can get it to fail again. Thanks, - -chris On 7/20/17 3:56 PM, Mark Thomas wrote: > On 20/07/17 19:09, Christopher Schultz wrote: >> Mark, >> >> On 7/18/17 9:58 AM, Mark Thomas wrote: >>> The proposed Apache Tomcat 8.5.18 release is now available for >>> voting. > > > >>> The proposed 8.5.18 release is: [ ] Broken - do not release >>> [?] Stable - go ahead and release as 8.5.18 >> >> Works fine for me in a development environment. *There was a unit >> test failure I've never seen before.* Someone who knows more >> about this particular test might want to weigh-in on whether or >> not this is a problem. >> >> Details below. > > > >> For TestVirtualContext (which only failed for NIO2, oddly), here >> are the errors: >> >> 20-Jul-2017 12:10:16.422 SEVERE >> [http-nio2-127.0.0.1-auto-2-exec-2] >> org.apache.catalina.core.StandardHostValve.invoke Exception >> Processing null java.lang.NullPointerException at >> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperV alv >> >> e.java:236) > > OK. That is in the exception handling. That is odd to start with > since we don't expect this test to enter that code. As to what > might be triggering the NPE, it could be any of: - container - > container.getLogger() - wrapper - context > > None of which should ever be null at that point. > > > >> 20-Jul-2017 12:10:16.427 SEVERE >> [http-nio2-127.0.0.1-auto-2-exec-2] >> org.apache.coyote.http11.Http11Processor.service Error processing >> reques t java.lang.NullPointerException at >> org.apache.catalina.connector.Request.notifyAttributeAssigned(Request .ja >> >> va:1555) > > That suggests context is null. > > > >> 20-Jul-2017 12:10:16.440 SEVERE >> [http-nio2-127.0.0.1-auto-2-exec-2] >> org.apache.coyote.http11.Http11Processor.endRequest Error >> finishing response java.lang.NullPointerException at >> org.apache.coyote.http11.Http11OutputBuffer.commit(Http11OutputBuffer .ja >> >> va:368) > > That suggests socketWrapper is null. > > > >> ... and then finally: Testcase: testVirtualClassLoader took >> 14.813 sec Caused an ERROR Read timed out >> java.net.SocketTimeoutException: Read timed out at >> java.net.SocketInputStream.socketRead0(Native Method) > > Hmm. The test should complete in a couple of seconds. > > > >> org.apache.catalina.loader.TestVirtualContext.testVirtualClassLoader( Tes >> >> tVirtualContext.java:105) > > and finally that is the first request made to Tomcat as part of > this test. > > I'm guessing that this failure is not repeatable.. > > Given everything is on localhost, a network glitch seems unlikely. > Some sort of threading / timing issue seems more likely. > > If it isn't repeatable, I'm not sure there is a lot we can do > about this. It suggests that there might be an issue somewhere - > maybe in the start-up code - but it could equally be an issue with > the test code. > > I'd be tempted to note this but carry on with the release unless it > is repeatable. > > Mark > > - > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > -BEGIN PGP SIGNATURE- Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJZeMZwAAoJEBzwKT+lPKRYmIIP/18XTeTMJrbsoB8n7IikIcKH hM3AkU4LyI53d+G8swfDPDZ1FTvf4uG6L85Hxm80KdsLFwlV/AXkAa8WNLQ7SwVZ vXA8VVJfyy8ChgjTQiZ19h9LUtAuqMiQtbJ04WdHyTGF4AA+oL1NS0pQ5U3QHFi8 xeHjSK+4ab4ZazdroIJWvo2xDq9d59ckxqE5kwYUUN7ws6YKtkGiLD5nS+LIYp21 O2RvTbN5gAJjkgX7c4kRC9aL11PDCOnd7KcEkSwWyPaGwMaArPPql0eslKGBPNeF sVSugNJAgwR8bbQ4wJAFFYexHdHUxpSxSJU1Gy4YdeA0HJFZ0BOOnBGkHXOWeugY Y3Es2vN1GZcLlWQtaodnxaHMmk80eCpg1XGsK0X4ClhWzA7bY4k1vu+E54QFfyiN pm1ibViBFFmLHTYHn1iMohJ+UcNgpdHXMiIgrg8yx8lDrsORRYP9mThKMHbJ/rdr xa86GoTO3EDPwvTj34m1KUrPQoTWFvbr/6Ih9QvMvZ/WS3oZt6Tw4IBCbk1kDKUh tp2mCNeMAW9TKvRo+OvwtX3xF3LZ0O7pAU7UbcI6eTn5EOnXxvWZD7FpwD0GUux2 dT1Yqa+19lHUSHM2hNnDGyKJqeKDzhN0XT05zuMdSPas5Y50UJi88f+zDnq/3Rc9 cfZGmU+9LgohEV7Y0UKf =+Rnw -END PGP SIGNATURE- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.18
The following votes were cast: Binding: +1: kkolinko, fschumacher, remm, mgrigorov -1: markt (changed from +1 due to regression) And schultz voted a possible +1 but with a query regarding a unit test failure. Non-binding George Stanchev raised a possible regression issue While there are enough votes to release, I'm going to call this result as failed, fix the regression and roll a new release. Thanks to everyone who contributed to this release. Sorry again for the further regressions in the static file handling. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.18
On Tue, Jul 18, 2017 at 3:58 PM, Mark Thomas wrote: > The proposed Apache Tomcat 8.5.18 release is now available for voting. > > The major changes compared to the 8.5.16 release are: > > - Enable TLS connectors to use Java key stores that contain multiple > keys where each key has a separate password. Based on a patch by Frank > Taffelt. > > - Make asynchronous error handling more robust. In particular ensure > that onError() is called for any registered AsyncListeners after an > I/O error on a non-container thread. > > - Sync SSL session access for the APR connector to prevent errors when > accessing the session. > > > Along with lots of other bug fixes and improvements. > > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.18/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1144/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_18/ > > The proposed 8.5.18 release is: > [ ] Broken - do not release > [ X ] Stable - go ahead and release as 8.5.18 > Regards, Martin > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: [VOTE] Release Apache Tomcat 8.5.18
On 18/07/17 14:58, Mark Thomas wrote: > The proposed Apache Tomcat 8.5.18 release is now available for voting. > > The major changes compared to the 8.5.16 release are: > > - Enable TLS connectors to use Java key stores that contain multiple > keys where each key has a separate password. Based on a patch by Frank > Taffelt. > > - Make asynchronous error handling more robust. In particular ensure > that onError() is called for any registered AsyncListeners after an > I/O error on a non-container thread. > > - Sync SSL session access for the APR connector to prevent errors when > accessing the session. > > > Along with lots of other bug fixes and improvements. > > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.18/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1144/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_18/ > > The proposed 8.5.18 release is: > [X] Broken - do not release > [ ] Stable - go ahead and release as 8.5.18 Sorry, another regression around static file handling and encoding differences. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: [VOTE] Release Apache Tomcat 8.5.18
Mark, Can you look at my comments at the user's mailing list on the original thread about the encoding issue. The issue seems to have resurfaced in a different form. George - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.18
On Tue, Jul 18, 2017 at 3:58 PM, Mark Thomas wrote: > The proposed Apache Tomcat 8.5.18 release is now available for voting. > > The major changes compared to the 8.5.16 release are: > > - Enable TLS connectors to use Java key stores that contain multiple > keys where each key has a separate password. Based on a patch by Frank > Taffelt. > > - Make asynchronous error handling more robust. In particular ensure > that onError() is called for any registered AsyncListeners after an > I/O error on a non-container thread. > > - Sync SSL session access for the APR connector to prevent errors when > accessing the session. > > > Along with lots of other bug fixes and improvements. > > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.18/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1144/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_18/ > > The proposed 8.5.18 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.5.18 > > Rémy
Re: [VOTE] Release Apache Tomcat 8.5.18
On 20/07/17 19:09, Christopher Schultz wrote: > Mark, > > On 7/18/17 9:58 AM, Mark Thomas wrote: >> The proposed Apache Tomcat 8.5.18 release is now available for >> voting. >> The proposed 8.5.18 release is: [ ] Broken - do not release [?] >> Stable - go ahead and release as 8.5.18 > > Works fine for me in a development environment. *There was a unit test > failure I've never seen before.* Someone who knows more about this > particular test might want to weigh-in on whether or not this is a > problem. > > Details below. > For TestVirtualContext (which only failed for NIO2, oddly), here are > the errors: > > 20-Jul-2017 12:10:16.422 SEVERE [http-nio2-127.0.0.1-auto-2-exec-2] > org.apache.catalina.core.StandardHostValve.invoke Exception Processing > null > java.lang.NullPointerException > at > org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValv > e.java:236) OK. That is in the exception handling. That is odd to start with since we don't expect this test to enter that code. As to what might be triggering the NPE, it could be any of: - container - container.getLogger() - wrapper - context None of which should ever be null at that point. > 20-Jul-2017 12:10:16.427 SEVERE [http-nio2-127.0.0.1-auto-2-exec-2] > org.apache.coyote.http11.Http11Processor.service Error processing reques > t > java.lang.NullPointerException > at > org.apache.catalina.connector.Request.notifyAttributeAssigned(Request.ja > va:1555) That suggests context is null. > 20-Jul-2017 12:10:16.440 SEVERE [http-nio2-127.0.0.1-auto-2-exec-2] > org.apache.coyote.http11.Http11Processor.endRequest Error finishing > response > java.lang.NullPointerException > at > org.apache.coyote.http11.Http11OutputBuffer.commit(Http11OutputBuffer.ja > va:368) That suggests socketWrapper is null. > ... and then finally: > Testcase: testVirtualClassLoader took 14.813 sec > Caused an ERROR > Read timed out > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) Hmm. The test should complete in a couple of seconds. > org.apache.catalina.loader.TestVirtualContext.testVirtualClassLoader(Tes > tVirtualContext.java:105) and finally that is the first request made to Tomcat as part of this test. I'm guessing that this failure is not repeatable.. Given everything is on localhost, a network glitch seems unlikely. Some sort of threading / timing issue seems more likely. If it isn't repeatable, I'm not sure there is a lot we can do about this. It suggests that there might be an issue somewhere - maybe in the start-up code - but it could equally be an issue with the test code. I'd be tempted to note this but carry on with the release unless it is repeatable. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.18
Am 18.07.2017 um 15:58 schrieb Mark Thomas: The proposed Apache Tomcat 8.5.18 release is now available for voting. The major changes compared to the 8.5.16 release are: - Enable TLS connectors to use Java key stores that contain multiple keys where each key has a separate password. Based on a patch by Frank Taffelt. - Make asynchronous error handling more robust. In particular ensure that onError() is called for any registered AsyncListeners after an I/O error on a non-container thread. - Sync SSL session access for the APR connector to prevent errors when accessing the session. Along with lots of other bug fixes and improvements. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.18/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1144/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_18/ The proposed 8.5.18 release is: [ ] Broken - do not release [x] Stable - go ahead and release as 8.5.18 Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.18
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 7/18/17 9:58 AM, Mark Thomas wrote: > The proposed Apache Tomcat 8.5.18 release is now available for > voting. > > The major changes compared to the 8.5.16 release are: > > - Enable TLS connectors to use Java key stores that contain > multiple keys where each key has a separate password. Based on a > patch by Frank Taffelt. > > - Make asynchronous error handling more robust. In particular > ensure that onError() is called for any registered AsyncListeners > after an I/O error on a non-container thread. > > - Sync SSL session access for the APR connector to prevent errors > when accessing the session. > > > Along with lots of other bug fixes and improvements. > > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.18/ The > Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-114 4/ > > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_18/ > > The proposed 8.5.18 release is: [ ] Broken - do not release [?] > Stable - go ahead and release as 8.5.18 Works fine for me in a development environment. *There was a unit test failure I've never seen before.* Someone who knows more about this particular test might want to weigh-in on whether or not this is a problem. Details below. - -chris * Environment * Java (build): java version "1.8.0_101" Java(TM) SE Runtime Environment (build 1.8.0_101-b13) Java HotSpot(TM) 64-Bit Server VM (build 25.101-b13, mixed mode) * Java (test): java version "1.8.0_101" Java(TM) SE Runtime Environment (build 1.8.0_101-b13) Java HotSpot(TM) 64-Bit Server VM (build 25.101-b13, mixed mode) * OS: Linux 2.6.32-312-ec2 x86_64 * cc: cc (Debian 4.7.2-5) 4.7.2 * make: GNU Make 3.81 * OpenSSL: 1.0.2k * APR: 1.4.6 * * Valid MD5 signature for apache-tomcat-8.5.18.zip * Valid GPG signature for apache-tomcat-8.5.18.zip * Valid MD5 signature for apache-tomcat-8.5.18.tar.gz * Valid GPG signature for apache-tomcat-8.5.18.tar.gz * Valid MD5 signature for apache-tomcat-8.5.18.exe * Valid GPG signature for apache-tomcat-8.5.18.exe * Valid MD5 signature for apache-tomcat-8.5.18-src.zip * Valid GPG signature for apache-tomcat-8.5.18-src.zip * Valid MD5 signature for apache-tomcat-8.5.18-src.tar.gz * Valid GPG signature for apache-tomcat-8.5.18-src.tar.gz * * Binary Zip and tarball: Same * Source Zip and tarball: !! NOT SAME Konstantin pointed-out that the newline-rewriting process in the build is not working properly. No reason to block the release. * Building dependencies returned: 0 * tcnative builds cleanly * Tomcat builds cleanly * Junit Tests: FAILED JUnit test case failures are almost all expected: (a) no multicast and (b) cipher tests are highly dependent upon environment. For TestVirtualContext (which only failed for NIO2, oddly), here are the errors: 20-Jul-2017 12:10:16.422 SEVERE [http-nio2-127.0.0.1-auto-2-exec-2] org.apache.catalina.core.StandardHostValve.invoke Exception Processing null java.lang.NullPointerException at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValv e.java:236) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValv e.java:96) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(Authenticator Base.java:478) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java :140) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java :80) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve. java:87) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:3 42) at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:79 9) at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight. java:66) at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractPro tocol.java:868) at org.apache.tomcat.util.net.Nio2Endpoint$SocketProcessor.doRun(Nio2Endpoi nt.java:1697) at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.j ava:49) at org.apache.tomcat.util.net.AbstractEndpoint.processSocket(AbstractEndpoi nt.java:946) at org.apache.tomcat.util.net.Nio2Endpoint$Nio2SocketWrapper$4.completed(Ni o2Endpoint.java:626) at org.apache.tomcat.util.net.Nio2Endpoint$Nio2SocketWrapper$4.completed(Ni o2Endpoint.java:604) at sun.nio.ch.Invoker.invokeUnchecked(Invoker.java:126) at sun.nio.ch.Invoker$2.run(Invoker.java:218) at sun.nio.ch.AsynchronousChannelGroupImpl$1.run(AsynchronousChannelGroupIm pl.java:112) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.jav a:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.ja va:617) at org.apache.tomcat.util.threads.TaskThread$WrappingRunnab
Re: [VOTE] Release Apache Tomcat 8.5.18
On 18/07/17 14:58, Mark Thomas wrote: > The proposed 8.5.18 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.5.18 Unit tests pass for NIO, NIO2 and APR on Windows, OSX and Linux all using Tomcat Native 1.2.12. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.18
2017-07-18 16:58 GMT+03:00 Mark Thomas : > The proposed Apache Tomcat 8.5.18 release is now available for voting. > > The major changes compared to the 8.5.16 release are: > > - Enable TLS connectors to use Java key stores that contain multiple > keys where each key has a separate password. Based on a patch by Frank > Taffelt. > > - Make asynchronous error handling more robust. In particular ensure > that onError() is called for any registered AsyncListeners after an > I/O error on a non-container thread. > > - Sync SSL session access for the APR connector to prevent errors when > accessing the session. > > > Along with lots of other bug fixes and improvements. > > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.18/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1144/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_18/ > > The proposed 8.5.18 release is: > [ ] Broken - do not release > [x] Stable - go ahead and release as 8.5.18 Smoke testing OK. JUnit test - OK except one (Java 8u141 32-bit x all connectors, Windows 10) Notes: 1. apache-tomcat-8.5.18.exe is not signed. I guess that "Code signing service currently unavailable" issue that Mark mentioned 2017-06-21 is still not cleared. https://bz.apache.org/bugzilla/show_bug.cgi?id=61316 2. TestEncodingDetector test is failing, as its data files are broken in src.zip that I tested, do not match the svn tag. I filed this issue into Bugzilla, https://bz.apache.org/bugzilla/show_bug.cgi?id=61316 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[VOTE] Release Apache Tomcat 8.5.18
The proposed Apache Tomcat 8.5.18 release is now available for voting. The major changes compared to the 8.5.16 release are: - Enable TLS connectors to use Java key stores that contain multiple keys where each key has a separate password. Based on a patch by Frank Taffelt. - Make asynchronous error handling more robust. In particular ensure that onError() is called for any registered AsyncListeners after an I/O error on a non-container thread. - Sync SSL session access for the APR connector to prevent errors when accessing the session. Along with lots of other bug fixes and improvements. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.18/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1144/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_18/ The proposed 8.5.18 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 8.5.18 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org