Re: [tomcat-jakartaee-migration] branch master updated (397ff8a -> c4e5c18)
Le 07/04/2020 à 12:24, Mark Thomas a écrit : > +1 to all of the above. Thank you for the review. >> new 3618367 Renamed NoOpConverter to PassThroughConverter > > What problem does this commit address and/or what new feature does it > add? It looks more like a personal preference for a different name to me. I've found "NoOp" to be confusing, at first glance based on the name I thought it was an empty implementation of the Converter interface, and I was wrong since it actually copies the source unmodified. I think the term "pass-through" better describes the behavior of the converter. > I think there is less likelihood of conflict if there is a technical > justification for a change, and, if the justification is not / might not > be obvious then mention it in the commit message. Ok, I tend to write concise commit messages but I'll try to elaborate in this kind of situation. > This tests creates a file but doesn't remove it afterwards. Tests that > create files should remove those files on completion. It might be worth > considering creating such files in a temporary location rather than in > the source tree. I agree this can be improved. > Generally, the code was clean (no IDE warnings) and the aim is to keep > it this way as it enables errors to be spotted more easily. This is no > longer the case after the above changes. The unused charset parameter is > flagged as a warning. Sorry, for some reason my IDE was misconfigured and no longer highlighted unused code. I'll fix that. Emmanuel Bourg - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [tomcat-jakartaee-migration] branch master updated (397ff8a -> c4e5c18)
On 07/04/2020 01:56, ebo...@apache.org wrote: > This is an automated email from the ASF dual-hosted git repository. > > ebourg pushed a change to branch master > in repository > https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git. > > > from 397ff8a Travis integration > new c8afe9b One line log messages when running from the command line > new 07b9ad1 Test with an alternative profile > new 703262f Moved EESpecProfile to the top level > new e58d4c5 Renamed getEESpecLevel() to getEESpecProfile() > new 39ada70 Turned the migration profile into an instance field of the > Migration class > new ec70314 Added a -verbose option +1 to all of the above. > new 3618367 Renamed NoOpConverter to PassThroughConverter What problem does this commit address and/or what new feature does it add? It looks more like a personal preference for a different name to me. My main concern here is if two (or more) committers feel strongly about an issue of personal preference the situation can escalate. I think there is less likelihood of conflict if there is a technical justification for a change, and, if the justification is not / might not be obvious then mention it in the commit message. > new f69a7d9 Support inplace file migration This tests creates a file but doesn't remove it afterwards. Tests that create files should remove those files on completion. It might be worth considering creating such files in a temporary location rather than in the source tree. > new 884aa46 Moved common stream operation methods to the Util class The charset parameter on Util.toString() appears to be unused. > new c4e5c18 Test invalid options Generally, the code was clean (no IDE warnings) and the aim is to keep it this way as it enables errors to be spotted more easily. This is no longer the case after the above changes. The unused charset parameter is flagged as a warning. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat-jakartaee-migration] branch master updated (397ff8a -> c4e5c18)
This is an automated email from the ASF dual-hosted git repository.
ebourg pushed a change to branch master
in repository
https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git.
from 397ff8a Travis integration
new c8afe9b One line log messages when running from the command line
new 07b9ad1 Test with an alternative profile
new 703262f Moved EESpecProfile to the top level
new e58d4c5 Renamed getEESpecLevel() to getEESpecProfile()
new 39ada70 Turned the migration profile into an instance field of the
Migration class
new ec70314 Added a -verbose option
new 3618367 Renamed NoOpConverter to PassThroughConverter
new f69a7d9 Support inplace file migration
new 884aa46 Moved common stream operation methods to the Util class
new c4e5c18 Test invalid options
The 10 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../apache/tomcat/jakartaee/ClassConverter.java| 4 +-
.../org/apache/tomcat/jakartaee/Converter.java | 2 +-
.../org/apache/tomcat/jakartaee/EESpecProfile.java | 50 +
.../org/apache/tomcat/jakartaee/Migration.java | 84 +-
...oOpConverter.java => PassThroughConverter.java} | 10 +--
.../org/apache/tomcat/jakartaee/TextConverter.java | 24 ++-
.../java/org/apache/tomcat/jakartaee/Util.java | 66 +
.../org/apache/tomcat/jakartaee/MigrationTest.java | 52 ++
.../tomcat/jakartaee/NoExitSecurityManager.java} | 64 +
9 files changed, 234 insertions(+), 122 deletions(-)
create mode 100644 src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java
rename src/main/java/org/apache/tomcat/jakartaee/{NoOpConverter.java =>
PassThroughConverter.java} (79%)
copy src/{main/java/org/apache/tomcat/jakartaee/Converter.java =>
test/java/org/apache/tomcat/jakartaee/NoExitSecurityManager.java} (67%)
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
